Re: [RFC PATCH] ui/gtk: ??? Remove dead code around X11 ???

2024-11-21 Thread Daniel P . Berrangé
On Thu, Nov 21, 2024 at 02:09:39PM +0100, Philippe Mathieu-Daudé wrote: > I have no clue about what this code does, > but gtk_widget_set_double_buffered() is deprecated since GTK 3.14 > and we require 3.22 since more than 4 years, commit 7b23d121f9 > ("ui: increase min required GTK version to 3.22.

Re: [PATCH 02/12] qom: New container_create()

2024-11-21 Thread Markus Armbruster
Peter Xu writes: > To move towards explicit creations of containers, starting that by > providing a helper for creating container objects. > > Signed-off-by: Peter Xu > --- > include/qom/object.h | 12 > qom/container.c | 18 +++--- > 2 files changed, 27 insertions

Re: [PATCH 10/12] qom: Create system containers explicitly

2024-11-21 Thread Markus Armbruster
Peter Xu writes: > Always explicitly create QEMU system containers upfront. > > Root containers will be created when trying to fetch the root object the > 1st time. Which ones are affected? Not a fan of creating stuff on first use, unless there may not be any use. But no worse than before. >

[PATCH] 9pfs: cleanup V9fsFidState

2024-11-21 Thread Christian Schoenebeck
Drop V9fsFidState's 'next' member, which is no longer used since: f5265c8f917e ('9pfs: use GHashTable for fid table') Signed-off-by: Christian Schoenebeck --- hw/9pfs/9p.h | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/9pfs/9p.h b/hw/9pfs/9p.h index a6f59abccb..5e041e1f60 100644 --- a/

Re: [PATCH] hw/usb: Use __attribute__((packed)) vs __packed

2024-11-21 Thread Paolo Bonzini
On 11/21/24 11:24, Thomas Huth wrote: On 21/11/2024 11.01, Michael Tokarev wrote: 04.11.2024 10:37, Thomas Huth wrote: On 01/11/2024 22.17, Roque Arcudia Hernandez wrote: __packed is non standard and is not present in clang-cl. __attribute__((packed)) has the same semantics. Signed-off-by: Er

Re: [PATCH] hw/i386/amd_iommu: Allow migration

2024-11-21 Thread Joao Martins
On 20/11/2024 07:31, Suravee Suthikulpanit wrote: > Add migration support for AMD IOMMU model by saving necessary AMDVIState > parameters for MMIO registers, device table, command buffer, and event > buffers. > > Signed-off-by: Suravee Suthikulpanit > --- > hw/i386/amd_iommu.c | 36 +

[RFC PATCH] ui/gtk: ??? Remove dead code around X11 ???

2024-11-21 Thread Philippe Mathieu-Daudé
I have no clue about what this code does, but gtk_widget_set_double_buffered() is deprecated since GTK 3.14 and we require 3.22 since more than 4 years, commit 7b23d121f9 ("ui: increase min required GTK version to 3.22.0"). Assert gtk_use_gl_area is set and remove the dead code. Signed-off-by: Ph

Re: [PATCH 02/12] qom: New container_create()

2024-11-21 Thread Peter Xu
On Thu, Nov 21, 2024 at 02:20:44PM +0100, Markus Armbruster wrote: > Peter Xu writes: > > > To move towards explicit creations of containers, starting that by > > providing a helper for creating container objects. > > > > Signed-off-by: Peter Xu > > --- > > include/qom/object.h | 12 +++

[PATCH v2 09/18] tests/functional: put QEMUMachine logs in testcase log directory

2024-11-21 Thread Daniel P . Berrangé
We are not passing the 'log_dir' parameter to QEMUMachine, so the QEMU stdout/err logs are being placed in a temp directory and thus deleted after execution. This makes them inaccessible as gitlab CI artifacts. Pass the testcase log directory path into QEMUMachine to make the logs persistent. Rev

[PATCH v3 3/3] tests/functional: Remove sleep workarounds from Aspeed tests

2024-11-21 Thread Cédric Le Goater
These were introduced in the avocado tests to workaround read issues when interacting with console. They are no longer necessary and we can use the expected "login:" string or the command prompt now. Drop the last use of exec_command. Signed-off-by: Cédric Le Goater Reviewed-by: Thomas Huth ---

[PATCH v3 2/3] tests/functional: Convert Aspeed arm SDK tests

2024-11-21 Thread Cédric Le Goater
Drop the SSH connection which was introduced in the avocado tests to workaround read issues when interacting with console. EXTRA_BOOTARGS was introduced to reduce the console output at Linux boot time. This didn't have the desired effect as we still had issues when trying to match patterns on the

[PATCH v3 1/3] tests/functional: Convert Aspeed aarch64 SDK tests

2024-11-21 Thread Cédric Le Goater
Drop the SSH connection which was introduced in the avocado tests to workaround read issues when interacting with console. Signed-off-by: Cédric Le Goater Reviewed-by: Thomas Huth --- tests/avocado/machine_aspeed.py | 78 tests/functional/meson.build| 2

[PATCH v3 0/3] tests/functional: Finish conversion of Aspeed tests

2024-11-21 Thread Cédric Le Goater
Hello, This series completes the conversion of the Aspeed tests to the new functional framework and removes the workarounds for capturing the console output. Thanks, C. Changes in v3: - Rebased on : https://lore.kernel.org/all/20241121165806.476008-1-alex.ben...@linaro.org/ - Added docu

Re: [PATCH v10 01/15] ui & main loop: Redesign of system-specific main thread event handling

2024-11-21 Thread Phil Dennis-Jordan
On Fri 22. Nov 2024 at 06:02, Akihiko Odaki wrote: > On 2024/11/13 23:23, Phil Dennis-Jordan wrote: > > macOS's Cocoa event handling must be done on the initial (main) thread > > of the process. Furthermore, if library or application code uses > > libdispatch, the main dispatch queue must be hand

[PATCH 2/2] rust: add bindings for interrupt sources

2024-11-21 Thread Paolo Bonzini
The InterruptSource bindings let us call qemu_set_irq() and sysbus_init_irq() as safe code. Interrupt sources, qemu_irq in C code, are pointers to IRQState objects. They are QOM link properties and can be written to outside the control of the device (i.e. from a shared reference); therefore they m

[PATCH 1/2] rust: add BQL-enforcing Cell variant

2024-11-21 Thread Paolo Bonzini
QEMU objects usually have their pointer shared with the "outside world" very early in their lifetime, for example when they create their MemoryRegions. Because at this point it is not valid anymore to create a &mut reference to the device, individual parts of the device struct must be made mutable

[PATCH 0/2] rust: safe wrappers for interrupt sources

2024-11-21 Thread Paolo Bonzini
Interrupt sources, qemu_irq in C code, are pointers to IRQState objects. They are QOM link properties and can be written to outside the control of the device (i.e. from a shared reference); therefore their Rust representation must be an interior-mutable field. This make interrupt sources similar t

Re: [PATCH v4] hw/riscv: Add Microblaze V generic board

2024-11-21 Thread Michal Simek
On 11/22/24 06:42, Alistair Francis wrote: On Wed, Nov 20, 2024 at 12:50 AM Sai Pavan Boddu wrote: Add a basic board with interrupt controller (intc), timer, serial (uartlite), small memory called LMB@0 (128kB) and DDR@0x8000 (configured via command line eg. -m 2g). This is basic config

Re: [PATCH v3 5/6] virtio-net: Initialize hash reporting values

2024-11-21 Thread Philippe Mathieu-Daudé
On 22/11/24 06:03, Akihiko Odaki wrote: The specification says hash_report should be set to VIRTIO_NET_HASH_REPORT_NONE if VIRTIO_NET_F_HASH_REPORT is negotiated but not configured with VIRTIO_NET_CTRL_MQ_RSS_CONFIG. However, virtio_net_receive_rcu() instead wrote out the content of the extra_hdr

Re: pc-bios/optionrom: when/why do we build it?

2024-11-21 Thread Michael Tokarev
Maybe a more general question would be: what is our main build entry point? Is it `make` (or `make all`) still, or is it meson now? For this specific optionrom thing, I'd say we should add a separate rule to the top-level Makefile (or to meson.build) which is not run by default but can be run ex

Re: [PATCH v3 1/6] net: checksum: Convert data to void *

2024-11-21 Thread Philippe Mathieu-Daudé
On 22/11/24 06:03, Akihiko Odaki wrote: Convert the data parameter of net_checksum_calculate() to void * to save unnecessary casts for callers. Signed-off-by: Akihiko Odaki --- include/net/checksum.h | 2 +- net/checksum.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH v5 1/9] target/riscv: fix henvcfg potentially containing stale bits

2024-11-21 Thread Clément Léger
On 20/11/2024 06:02, Alistair Francis wrote: > On Tue, Nov 19, 2024 at 9:27 PM Clément Léger wrote: >> >> >> >> On 19/11/2024 05:16, Alistair Francis wrote: >>> On Thu, Nov 14, 2024 at 7:14 PM Clément Léger wrote: With the current implementation, if we had the current scenario:

[PATCH v2 0/7] Pointer Masking update for Zjpm v1.0

2024-11-21 Thread baturo . alexey
From: Alexey Baturo Hi, I've rebased this patch series and addressed Richard's and Daniel's comments. Thanks *** BLURB HERE *** [v0]: As Pointer Masking is finally ratified, these patches intend to update the existing code to the final version. These patches have been submitted previously and

Re: [PATCH 15/15] tests/functional: add a QMP backdoor for debugging stalled tests

2024-11-21 Thread Thomas Huth
On 19/11/2024 16.05, Daniel P. Berrangé wrote: Support the QEMU_TEST_QMP_BACKDOOR=backdoor.sock env variable as a way to get a QMP backdoor for debugging a stalled QEMU test. Most typically this would be used if running the tests directly: $ QEMU_TEST_QMP_BACKDOOR=backdoor.sock \ QEMU_TEST

Re: [PATCH 07/12] ppc/e500: Avoid abuse of container_get()

2024-11-21 Thread Cédric Le Goater
On 11/21/24 10:38, Cédric Le Goater wrote: On 11/20/24 22:56, Peter Xu wrote: container_get() is going to become strict on not allowing to return a non-container. Switch the e500 user to use object_resolve_path_component() explicitly. Cc: Bharat Bhushan Cc: qemu-...@nongnu.org Signed-off-by:

Re: New "rme-guest" QEMU object addition

2024-11-21 Thread Itaru Kitayama
> On Nov 21, 2024, at 18:53, Daniel P. Berrangé wrote: > > On Thu, Nov 21, 2024 at 02:34:24PM +0900, Itaru Kitayama wrote: >> Hi Jean, Mathieu, >> >> I’ve been using you guys’ ccs/v3 QEMU for some time to bring >> up an Realm instance without a major issue, and as a one who >> is making chang

Re: [PATCH 00/12] QOM: container_get() removal

2024-11-21 Thread Philippe Mathieu-Daudé
On 20/11/24 22:56, Peter Xu wrote: Peter Xu (12): qom: Add TYPE_CONTAINER macro qom: New container_create() tests: Fix test-qdev-global-props on anonymous qdev realize() tests: Explicitly create containers in test_qom_partial_path() ui/console: Explicitly create "/backend" contain

Re: New "rme-guest" QEMU object addition

2024-11-21 Thread Daniel P . Berrangé
On Thu, Nov 21, 2024 at 02:34:24PM +0900, Itaru Kitayama wrote: > Hi Jean, Mathieu, > > I’ve been using you guys’ ccs/v3 QEMU for some time to bring > up an Realm instance without a major issue, and as a one who > is making changes libvirt to support CCA, I wonder if you > could merge the v3 local

Re: New "rme-guest" QEMU object addition

2024-11-21 Thread Daniel P . Berrangé
On Thu, Nov 21, 2024 at 06:55:18PM +0900, Itaru Kitayama wrote: > > > > On Nov 21, 2024, at 18:53, Daniel P. Berrangé wrote: > > > > On Thu, Nov 21, 2024 at 02:34:24PM +0900, Itaru Kitayama wrote: > >> Hi Jean, Mathieu, > >> > >> I’ve been using you guys’ ccs/v3 QEMU for some time to bring > >

Re: New "rme-guest" QEMU object addition

2024-11-21 Thread Jean-Philippe Brucker
Hi Itaru, On Thu, Nov 21, 2024 at 02:34:24PM +0900, Itaru Kitayama wrote: > Hi Jean, Mathieu, > > I’ve been using you guys’ ccs/v3 QEMU for some time to bring up an Realm > instance without a major issue, and as a one who is making changes libvirt to > support CCA, I wonder if you could merge t

Re: [PATCH 09/12] qdev: Add machine_get_container()

2024-11-21 Thread Philippe Mathieu-Daudé
On 20/11/24 22:57, Peter Xu wrote: Add a helper to fetch machine containers. Add some sanity check around. Signed-off-by: Peter Xu --- include/hw/qdev-core.h | 10 ++ hw/core/qdev.c | 17 + 2 files changed, 27 insertions(+) Reviewed-by: Philippe Mathieu-Da

Re: [PATCH] hw/usb: Use __attribute__((packed)) vs __packed

2024-11-21 Thread Michael Tokarev
04.11.2024 10:37, Thomas Huth wrote: On 01/11/2024 22.17, Roque Arcudia Hernandez wrote: __packed is non standard and is not present in clang-cl. __attribute__((packed)) has the same semantics. Signed-off-by: Erwin Jansen Signed-off-by: Roque Arcudia Hernandez ---   include/hw/usb/dwc2-regs.h

[PATCH] hw/ide/ahci: Check for PCI device once in ahci_init()

2024-11-21 Thread Philippe Mathieu-Daudé
object_dynamic_cast() is expensive; IRQ helpers are certainly a bad place to call it. Since the device type won't change at runtime, resolve it once when the AHCI context is initialized in ahci_init(). Reported-by: Peter Xu Signed-off-by: Philippe Mathieu-Daudé --- include/hw/ide/ahci.h | 2 +-

Re: [PATCH 02/12] qom: New container_create()

2024-11-21 Thread Daniel P . Berrangé
On Wed, Nov 20, 2024 at 04:56:53PM -0500, Peter Xu wrote: > To move towards explicit creations of containers, starting that by > providing a helper for creating container objects. > > Signed-off-by: Peter Xu > --- > include/qom/object.h | 12 > qom/container.c | 18

Re: [PATCH 01/12] qom: Add TYPE_CONTAINER macro

2024-11-21 Thread Daniel P . Berrangé
On Wed, Nov 20, 2024 at 04:56:52PM -0500, Peter Xu wrote: > Provide a macro for the container type across QEMU source tree, rather than > hard code it every time. > > Signed-off-by: Peter Xu > --- > include/qom/object.h | 1 + > hw/arm/stellaris.c | 2 +- > qom/container.c | 4 ++-- > qom

Re: [PATCH v2 0/6] virtio-net fixes

2024-11-21 Thread Michael Tokarev
11.11.2024 09:40, Akihiko Odaki wrote: Most of this series are fixes for software RSS and hash reporting, which should have no production user. However there is one exception; patch "virtio-net: Fix size check in dhclient workaround" fixes an out-of-bound access that can be triggered for anyone

Re: [PATCH 2/7] target/i386/kvm: introduce 'pmu-cap-disabled' to set KVM_PMU_CAP_DISABLE

2024-11-21 Thread Mi, Dapeng
On 11/8/2024 7:44 AM, dongli.zh...@oracle.com wrote: > Hi Zhao, > > > On 11/6/24 11:52 PM, Zhao Liu wrote: >> (+Dapang & Zide) >> >> Hi Dongli, >> >> On Mon, Nov 04, 2024 at 01:40:17AM -0800, Dongli Zhang wrote: >>> Date: Mon, 4 Nov 2024 01:40:17 -0800 >>> From: Dongli Zhang >>> Subject: [PATCH

Re: [PATCH 11/12] qom: Add object_get_container()

2024-11-21 Thread Philippe Mathieu-Daudé
On 20/11/24 22:57, Peter Xu wrote: Add a helper to fetch a root container (under object_get_root()). Sanity check on the type of the object. Signed-off-by: Peter Xu --- include/qom/object.h | 10 ++ qom/object.c | 10 ++ 2 files changed, 20 insertions(+) Reviewed-

Re: [PATCH 07/12] ppc/e500: Avoid abuse of container_get()

2024-11-21 Thread Cédric Le Goater
On 11/20/24 22:56, Peter Xu wrote: container_get() is going to become strict on not allowing to return a non-container. Switch the e500 user to use object_resolve_path_component() explicitly. Cc: Bharat Bhushan Cc: qemu-...@nongnu.org Signed-off-by: Peter Xu --- hw/pci-host/ppce500.c | 4 ++

[PATCH for 10.0] tcg/optimize: fold recursively after optimizing deposit

2024-11-21 Thread Paolo Bonzini
When generating code for x86 targets, this is able to simplify XOR+SETcc sequences. SETcc generates a setcond+deposit pair of TCG opcodes which used to become setcond+ext32u after optimization; now TCG recognizes that the output of setcond is itself already zero extended and turns the deposit into

Re: [PATCH 06/12] hw/ppc: Explicitly create the drc container

2024-11-21 Thread Philippe Mathieu-Daudé
Hi Peter, On 20/11/24 22:56, Peter Xu wrote: QEMU will start to not rely on implicit creations of containers soon. Make PPC drc devices follow by explicitly create the container whenever a drc device is realized, dropping container_get() calls. No functional change intended. Cc: Nicholas Pigg

RE: [RFC PATCH 4/5] hw/arm/virt-acpi-build: Build IORT with multiple SMMU nodes

2024-11-21 Thread Shameerali Kolothum Thodi via
Hi Eric, > -Original Message- > From: Shameerali Kolothum Thodi > Sent: Wednesday, November 20, 2024 4:26 PM > To: 'eric.au...@redhat.com' ; qemu- > a...@nongnu.org; qemu-devel@nongnu.org > Cc: peter.mayd...@linaro.org; j...@nvidia.com; nicol...@nvidia.com; > ddut...@redhat.com; Linuxarm ;

RE: nested-smmuv3 topic for QEMU/libvirt, Nov 2024

2024-11-21 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: Andrea Bolognani > Sent: Wednesday, November 20, 2024 9:14 PM > To: Shameerali Kolothum Thodi > Cc: Nicolin Chen ; Eric Auger > ; Mostafa Saleh ; qemu- > a...@nongnu.org; qemu-devel@nongnu.org; Peter Maydell > ; Jason Gunthorpe ; Jean- > Philippe Brucker ; M

Re: [RFC PATCH] docs: Add roadmap for heterogeneous emulation

2024-11-21 Thread Alex Bennée
Thomas Huth writes: > On 19/11/2024 17.13, Philippe Mathieu-Daudé wrote: >> This document tries to document the steps required to: >> - Have a single binary to run system emulations >> - Emulate different architectures in the same process >> - Have QEMU assemble dynamic machines at runtime

Re: [PATCH v2] linux-user: Fix strace output for s390x mmap()

2024-11-21 Thread Philippe Mathieu-Daudé
On 20/11/24 22:26, Ilya Leoshkevich wrote: print_mmap() assumes that mmap() receives arguments via memory if mmap2() is present. s390x (as opposed to s390) does not fit this pattern: it does not have mmap2(), but mmap() still receives arguments via memory. Fix by sharing the detection logic betw

Re: [PATCH v2 0/2] Fix PVH entrypoint parsing

2024-11-21 Thread Ard Biesheuvel
On Sun, 29 Sept 2024 at 20:07, Ard Biesheuvel wrote: > > Fix the handling of the ELF note that describes the PVH entrypoint > > v2: fix broken ELF note handling on big endian hosts > > Ard Biesheuvel (2): > hw/elf_ops: Implement missing endian swabbing for ELF notes > hw/x86: Always treat the

[PATCH v2 5/7] target/riscv: Update address modify functions to take into account pointer masking

2024-11-21 Thread baturo . alexey
From: Alexey Baturo Signed-off-by: Alexey Baturo --- target/riscv/translate.c | 22 -- target/riscv/vector_helper.c | 16 2 files changed, 32 insertions(+), 6 deletions(-) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index bb92f36ba1

[ANNOUNCE] QEMU 8.2.8 Stable released

2024-11-21 Thread Michael Tokarev
Hi everyone, The QEMU v8.2.8 stable release is now available. You can grab the tarball from our download page here: https://www.qemu.org/download/#source https://download.qemu.org/qemu-8.2.8.tar.xz https://download.qemu.org/qemu-8.2.8.tar.xz.sig (signature) v8.2.8 is now tagged in the o

[ANNOUNCE] QEMU 9.1.2 Stable released

2024-11-21 Thread Michael Tokarev
Hi everyone, The QEMU v9.1.2 stable release is now available. You can grab the tarball from our download page here: https://www.qemu.org/download/#source https://download.qemu.org/qemu-9.1.2.tar.xz https://download.qemu.org/qemu-9.1.2.tar.xz.sig (signature) v9.1.2 is now tagged in the o

Re: [PATCH 10/12] qom: Create system containers explicitly

2024-11-21 Thread Philippe Mathieu-Daudé
On 20/11/24 22:57, Peter Xu wrote: Always explicitly create QEMU system containers upfront. Root containers will be created when trying to fetch the root object the 1st time. Machine sub-containers will be created only until machine is being initialized. Signed-off-by: Peter Xu --- hw/core/

Re: [PATCH 05/12] ui/console: Explicitly create "/backend" container

2024-11-21 Thread Philippe Mathieu-Daudé
On 20/11/24 22:56, Peter Xu wrote: Follow the trend to explicitly create containers, do that for console.c on "/backend" container. Cc: Marc-André Lureau Signed-off-by: Peter Xu --- ui/console.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 03/12] tests: Fix test-qdev-global-props on anonymous qdev realize()

2024-11-21 Thread Philippe Mathieu-Daudé
On 20/11/24 22:56, Peter Xu wrote: test-qdev-global-props creates a few subprocesses and test things based on qdev realize(). One thing was overlooked since the start, that anonymous creations of qdev (then realize() the device) requires the machine object's presence, as all these devices need t

Re: [PATCH 04/12] tests: Explicitly create containers in test_qom_partial_path()

2024-11-21 Thread Philippe Mathieu-Daudé
On 20/11/24 22:56, Peter Xu wrote: Drop one use of container_get(), instead switch to the explicit function to create a container. Signed-off-by: Peter Xu --- tests/unit/check-qom-proplist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 08/12] qdev: Make qdev_get_machine() not use container_get()

2024-11-21 Thread Daniel P . Berrangé
On Wed, Nov 20, 2024 at 04:56:59PM -0500, Peter Xu wrote: > Currently, qdev_get_machine() has a slight misuse on container_get(), as > the helper says "get a container" but in reality the goal is to get the > machine object. It is still a "container" but not strictly. > > Note that it _may_ get a

Re: [PATCH 11/12] qom: Add object_get_container()

2024-11-21 Thread Daniel P . Berrangé
On Wed, Nov 20, 2024 at 04:57:02PM -0500, Peter Xu wrote: > Add a helper to fetch a root container (under object_get_root()). Sanity > check on the type of the object. > > Signed-off-by: Peter Xu > --- > include/qom/object.h | 10 ++ > qom/object.c | 10 ++ > 2 files cha

Re: [PATCH 09/12] qdev: Add machine_get_container()

2024-11-21 Thread Daniel P . Berrangé
On Wed, Nov 20, 2024 at 04:57:00PM -0500, Peter Xu wrote: > Add a helper to fetch machine containers. Add some sanity check around. > > Signed-off-by: Peter Xu > --- > include/hw/qdev-core.h | 10 ++ > hw/core/qdev.c | 17 + > 2 files changed, 27 insertions(+) >

Re: [PATCH 10/12] qom: Create system containers explicitly

2024-11-21 Thread Philippe Mathieu-Daudé
On 21/11/24 11:30, Daniel P. Berrangé wrote: On Wed, Nov 20, 2024 at 04:57:01PM -0500, Peter Xu wrote: Always explicitly create QEMU system containers upfront. Root containers will be created when trying to fetch the root object the 1st time. Machine sub-containers will be created only until m

[PATCH-for-9.2] ui/cocoa: Temporarily ignore annoying deprecated declaration warnings

2024-11-21 Thread Philippe Mathieu-Daudé
These warnings are breaking some build configurations since 2 months now (https://gitlab.com/qemu-project/qemu/-/issues/2575): ui/cocoa.m:662:14: error: 'CVDisplayLinkCreateWithCGDisplay' is deprecated: first deprecated in macOS 15.0 - use NSView.displayLink(target:selector:), NSWindow.display

Re: [PATCH-for-9.2] ui/cocoa: Temporarily ignore annoying deprecated declaration warnings

2024-11-21 Thread Phil Dennis-Jordan
As we're talking about macOS-only code I'd perhaps have used '#pragma clang diagnostic' rather than the GCC versions, but clang seems to understand these just fine too. (Plus, we very much intend for these to be genuinely temporary.) Reviewed-by: Phil Dennis-Jordan Tested-by: Phil Dennis-Jordan

Re: [PATCH v7 01/12] meson: Introduce new instruction set enqcmd to the build system.

2024-11-21 Thread Fabiano Rosas
Yichen Wang writes: > From: Hao Xiang > > Enable instruction set enqcmd in build. > > Signed-off-by: Hao Xiang > Signed-off-by: Yichen Wang Reviewed-by: Fabiano Rosas

Re: New "rme-guest" QEMU object addition

2024-11-21 Thread Itaru Kitayama
Hi Jean, > On Nov 21, 2024, at 19:00, Jean-Philippe Brucker > wrote: > > Hi Itaru, > > On Thu, Nov 21, 2024 at 02:34:24PM +0900, Itaru Kitayama wrote: >> Hi Jean, Mathieu, >> >> I’ve been using you guys’ ccs/v3 QEMU for some time to bring up an Realm >> instance without a major issue, and as

Re: [PATCH 05/12] ui/console: Explicitly create "/backend" container

2024-11-21 Thread Daniel P . Berrangé
On Wed, Nov 20, 2024 at 04:56:56PM -0500, Peter Xu wrote: > Follow the trend to explicitly create containers, do that for console.c on > "/backend" container. > > Cc: Marc-André Lureau > Signed-off-by: Peter Xu > --- > ui/console.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [PATCH 01/12] qom: Add TYPE_CONTAINER macro

2024-11-21 Thread Philippe Mathieu-Daudé
On 20/11/24 22:56, Peter Xu wrote: Provide a macro for the container type across QEMU source tree, rather than hard code it every time. Signed-off-by: Peter Xu --- include/qom/object.h | 1 + hw/arm/stellaris.c | 2 +- qom/container.c | 4 ++-- qom/object.c | 4 ++-- 4 file

Re: [PATCH] 9pfs: cleanup V9fsFidState

2024-11-21 Thread Greg Kurz
On Thu, 21 Nov 2024 11:52:48 +0100 Christian Schoenebeck wrote: > Drop V9fsFidState's 'next' member, which is no longer used since: > > f5265c8f917e ('9pfs: use GHashTable for fid table') > Good catch ! Fixes: f5265c8f917e ('9pfs: use GHashTable for fid table') Reviewed-by: Greg Kurz > Si

Re: [PATCH 10/12] qom: Create system containers explicitly

2024-11-21 Thread Daniel P . Berrangé
On Wed, Nov 20, 2024 at 04:57:01PM -0500, Peter Xu wrote: > Always explicitly create QEMU system containers upfront. > > Root containers will be created when trying to fetch the root object the > 1st time. Machine sub-containers will be created only until machine is > being initialized. > > Sign

Re: [PATCH 12/12] qom: Drop container_get()

2024-11-21 Thread Daniel P . Berrangé
Subject says drop container_get, actual commit does alot more. Suggest splitting the conversion to (object/machine)_get_container, from the dropping of container_get. On Wed, Nov 20, 2024 at 04:57:03PM -0500, Peter Xu wrote: > Now we should be ready to always create containers upfront, meanwhile

Re: [PATCH v2] linux-user: Fix strace output for s390x mmap()

2024-11-21 Thread iii
On 2024-11-21 10:00, Philippe Mathieu-Daudé wrote: On 20/11/24 22:26, Ilya Leoshkevich wrote: print_mmap() assumes that mmap() receives arguments via memory if mmap2() is present. s390x (as opposed to s390) does not fit this pattern: it does not have mmap2(), but mmap() still receives arguments

Re: [RFC PATCH 0/5] hw/arm/virt: Add support for user-creatable nested SMMUv3

2024-11-21 Thread Nathan Chen
Hi Shameer, > Attempt to add the HNS VF to a different SMMUv3 will result in, > > -device vfio-pci,host=:7d:02.2,bus=pcie.port3,iommufd=iommufd0: Unable to attach viommu > -device vfio-pci,host=:7d:02.2,bus=pcie.port3,iommufd=iommufd0: vfio :7d:02.2: >Failed to set iommu_device

Re: [PATCH v2] linux-user: Fix strace output for s390x mmap()

2024-11-21 Thread iii
On 2024-11-21 11:07, Philippe Mathieu-Daudé wrote: On 21/11/24 10:26, iii wrote: On 2024-11-21 10:00, Philippe Mathieu-Daudé wrote: On 20/11/24 22:26, Ilya Leoshkevich wrote: print_mmap() assumes that mmap() receives arguments via memory if mmap2() is present. s390x (as opposed to s390) does n

Missing PDF file download.

2024-11-21 Thread Asif
Hi Stefan! First off, thank you for your awesome blog! Secondly, you have broken links on you page: QEMU Internals: Big Picture Overview Broken Link: Jan Kiszka's Linux Kongress 2010 presentation on the Architecture of

Re: [PATCH 07/12] ppc/e500: Avoid abuse of container_get()

2024-11-21 Thread Daniel P . Berrangé
On Wed, Nov 20, 2024 at 04:56:58PM -0500, Peter Xu wrote: > container_get() is going to become strict on not allowing to return a > non-container. > > Switch the e500 user to use object_resolve_path_component() explicitly. > > Cc: Bharat Bhushan > Cc: qemu-...@nongnu.org > Signed-off-by: Peter X

Re: [PATCH] qdev: Fix set_pci_devfn() to visit option only once

2024-11-21 Thread Markus Armbruster
Kevin Wolf writes: > pci_devfn properties accept either a string or an integer as input. To > implement this, set_pci_devfn() first tries to visit the option as a > string, and if that fails, it visits it as an integer instead. While the > QemuOpts visitor happens to accept this, it is invalid ac

[PATCH v2 17/18] tests/functional: add a QMP backdoor for debugging stalled tests

2024-11-21 Thread Daniel P . Berrangé
Support the QEMU_TEST_QMP_BACKDOOR=backdoor.sock env variable as a way to get a QMP backdoor for debugging a stalled QEMU test. Most typically this would be used if running the tests directly: $ QEMU_TEST_QMP_BACKDOOR=backdoor.sock \ QEMU_TEST_QEMU_BINARY=./build/qemu-system-arm \ PYTHONPAT

[PATCH v2 08/18] tests/functional: honour self.workdir in ACPI bits tests

2024-11-21 Thread Daniel P . Berrangé
The ACPI bits test sets up its own private temporary directory into it creates scratch files. This is justified by a suggestion that we need to be able to preserve the scratch files. We have the ability to preserve the scratch dir with our functional harness, so there's no reason to diverge from st

[PATCH v2 07/18] tests/functional: remove comments talking about avocado

2024-11-21 Thread Daniel P . Berrangé
The first comment is still relevant but should talk about our own test harness instead. The second comment adds no value over reading the code and can be removed. Signed-off-by: Daniel P. Berrangé --- tests/functional/test_acpi_bits.py | 13 ++--- 1 file changed, 6 insertions(+), 7 delet

Re: QEMU wiki theme table of contents changes

2024-11-21 Thread Stefan Hajnoczi
On Fri, Nov 15, 2024 at 07:38:06PM +, Daniel P. Berrangé wrote: > On Fri, Nov 15, 2024 at 02:21:12PM -0500, Stefan Hajnoczi wrote: > > On Fri, 15 Nov 2024 at 03:54, Daniel P. Berrangé > > wrote: > > > > > > On Thu, Nov 14, 2024 at 02:04:35PM -0500, Stefan Hajnoczi wrote: > > > > On Thu, 14 No

[PATCH v2 03/18] tests/functional: remove "AVOCADO" from env variable name

2024-11-21 Thread Daniel P . Berrangé
This env variable is a debugging flag to save screendumps in the mips64el malta tests. Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/functional/test_mips64el_malta.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH v2 06/18] tests/functional: remove obsolete reference to avocado bug

2024-11-21 Thread Daniel P . Berrangé
Historical bugs in avocado related to zstd support are not relevant to the code now that it uses QEMU's native test harness. Reviewed-by: Alex Bennée Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/tuxruntest.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/functiona

[PATCH v2 11/18] tests/functional: enable debug logging for QEMUMachine

2024-11-21 Thread Daniel P . Berrangé
Set the 'qemu.machine' logger to 'DEBUG' level, to ensure we see log messages related to the QEMUMachine class. Most importantly this ensures we capture the full QEMU command line args for instances we spawn. Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/testcase.py | 6 ++

[PATCH v2 12/18] tests/functional: logs details of console interaction operations

2024-11-21 Thread Daniel P . Berrangé
When functional tests go wrong, it will often be related to the console interaction wait state. By logging the messages that we're looking for, and data we're about to be sending, it'll be easier to diagnose where tests are getting stuck. Signed-off-by: Daniel P. Berrangé --- tests/functional/qe

[PATCH v2 16/18] tests/functional: remove time.sleep usage from tuxrun tests

2024-11-21 Thread Daniel P . Berrangé
The tuxrun tests send a series of strings to the guest to login and then run commands. Since we have been unable to match on console output that isn't followed by a newline, the test used many time.sleep() statements to pretend to synchronize with the guest. This has proved to be unreliable for th

Re: [PATCH] docs: explicitly permit a "commonly known identity" with SoB

2024-11-21 Thread Stefan Hajnoczi
On Fri, Nov 15, 2024 at 03:19:40PM +, Peter Maydell wrote: > On Mon, 21 Oct 2024 at 20:10, Daniel P. Berrangé wrote: > > > > The docs for submitting a patch describe using your "Real Name" with > > the Signed-off-by line. Although somewhat ambiguous, this has often > > been interpreted to mean

[PATCH v2 15/18] tests/functional: rewrite console handling to be bytewise

2024-11-21 Thread Daniel P . Berrangé
The console interaction that waits for predicted strings uses readline(), and thus is only capable of waiting for strings that are followed by a newline. This is inconvenient when needing to match on some things, particularly login prompts, or shell prompts, causing tests to use time.sleep(...) in

[PATCH v2 14/18] tests/functional: require non-NULL success_message for console wait

2024-11-21 Thread Daniel P . Berrangé
When waiting for expected output, the 'success_message' is a mandatory parameter, with 'failure_message' defaulting to None. The code has logic which indicates it was trying to cope with 'success_message' being None and 'failure_message' being non-None but it does not appear able to actually do an

Re: QEMU wiki theme table of contents changes

2024-11-21 Thread Daniel P . Berrangé
On Tue, Nov 19, 2024 at 02:54:29PM -0500, Stefan Hajnoczi wrote: > On Fri, Nov 15, 2024 at 07:38:06PM +, Daniel P. Berrangé wrote: > > On Fri, Nov 15, 2024 at 02:21:12PM -0500, Stefan Hajnoczi wrote: > > > On Fri, 15 Nov 2024 at 03:54, Daniel P. Berrangé > > > wrote: > > > > > > > > On Thu, N

[PATCH v2 04/18] tests/functional: remove todo wrt avocado.utils.wait_for

2024-11-21 Thread Daniel P . Berrangé
We're not using avocado anymore, so while the TODO item is still relevant, suggesting use of avocado.utils is not. Reviewed-by: Alex Bennée Signed-off-by: Daniel P. Berrangé --- tests/functional/test_m68k_nextcube.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/fu

Re: [PATCH] qdev: Fix set_pci_devfn() to visit option only once

2024-11-21 Thread Paolo Bonzini
On 11/19/24 13:03, Kevin Wolf wrote: pci_devfn properties accept either a string or an integer as input. To implement this, set_pci_devfn() first tries to visit the option as a string, and if that fails, it visits it as an integer instead. While the QemuOpts visitor happens to accept this, it is

[PULL v2 0/8] Block layer patches

2024-11-21 Thread Kevin Wolf
The following changes since commit e6459afb1ff4d86b361b14f4a2fc43f0d2b4d679: Merge tag 'pull-target-arm-20241119' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-11-19 14:23:34 +) are available in the Git repository at: https://repo.or.cz/qemu/kevin.git tags/for-u

Re: [PATCH] migration: Allow pipes to keep working for fd migrations

2024-11-21 Thread Fabiano Rosas
Peter Xu writes: > Libvirt may still use pipes for old file migrations in fd: URI form, > especially when loading old images dumped from Libvirt's compression > algorithms. > > In that case, Libvirt needs to compress / uncompress the images on its own > over the migration binary stream, and pipes

Re: [PATCH] 9pfs: cleanup V9fsFidState

2024-11-21 Thread Christian Schoenebeck
On Thursday, November 21, 2024 12:07:39 PM CET Greg Kurz wrote: > On Thu, 21 Nov 2024 11:52:48 +0100 > Christian Schoenebeck wrote: > > > Drop V9fsFidState's 'next' member, which is no longer used since: > > > > f5265c8f917e ('9pfs: use GHashTable for fid table') > > > > Good catch ! Coinci

Re: [PATCH v2 0/6] virtio-net fixes

2024-11-21 Thread Akihiko Odaki
On 2024/11/21 19:05, Michael Tokarev wrote: 11.11.2024 09:40, Akihiko Odaki wrote: Most of this series are fixes for software RSS and hash reporting, which should have no production user. However there is one exception; patch "virtio-net: Fix size check in dhclient workaround" fixes an out-of-b

RE: [RFC PATCH 0/5] hw/arm/virt: Add support for user-creatable nested SMMUv3

2024-11-21 Thread Shameerali Kolothum Thodi via
Hi Nathan, > -Original Message- > From: Nathan Chen > Sent: Wednesday, November 20, 2024 11:59 PM > To: Shameerali Kolothum Thodi > Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; > eric.au...@redhat.com; peter.mayd...@linaro.org; j...@nvidia.com; > ddut...@redhat.com; Linuxarm ; Wangzho

Re: [PATCH v2] linux-user: Fix strace output for s390x mmap()

2024-11-21 Thread Philippe Mathieu-Daudé
On 21/11/24 10:26, iii wrote: On 2024-11-21 10:00, Philippe Mathieu-Daudé wrote: On 20/11/24 22:26, Ilya Leoshkevich wrote: print_mmap() assumes that mmap() receives arguments via memory if mmap2() is present. s390x (as opposed to s390) does not fit this pattern: it does not have mmap2(), but m

Re: New "rme-guest" QEMU object addition

2024-11-21 Thread Itaru Kitayama
Hi Daniel, > On Nov 21, 2024, at 18:58, Daniel P. Berrangé wrote: > > On Thu, Nov 21, 2024 at 06:55:18PM +0900, Itaru Kitayama wrote: >> >> >>> On Nov 21, 2024, at 18:53, Daniel P. Berrangé wrote: >>> >>> On Thu, Nov 21, 2024 at 02:34:24PM +0900, Itaru Kitayama wrote: Hi Jean, Mathieu,

Re: [PATCH 03/12] tests: Fix test-qdev-global-props on anonymous qdev realize()

2024-11-21 Thread Daniel P . Berrangé
On Wed, Nov 20, 2024 at 04:56:54PM -0500, Peter Xu wrote: > test-qdev-global-props creates a few subprocesses and test things based on > qdev realize(). One thing was overlooked since the start, that anonymous > creations of qdev (then realize() the device) requires the machine object's > presence

Re: [PATCH 04/12] tests: Explicitly create containers in test_qom_partial_path()

2024-11-21 Thread Daniel P . Berrangé
On Wed, Nov 20, 2024 at 04:56:55PM -0500, Peter Xu wrote: > Drop one use of container_get(), instead switch to the explicit function to > create a container. > > Signed-off-by: Peter Xu > --- > tests/unit/check-qom-proplist.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by:

[PATCH v2 13/18] tests/functional: don't try to wait for the empty string

2024-11-21 Thread Daniel P . Berrangé
Telling exec_command_wand_wait_for_pattern to wait for the empty string does not make any conceptual sense, as a check for empty string will always succeed. It makes even less sense when followed by a call to wait_for_console_pattern() with a real match. Signed-off-by: Daniel P. Berrangé --- tes

[PATCH v2 18/18] tests/functional: avoid accessing log_filename on earlier failures

2024-11-21 Thread Daniel P . Berrangé
If a failure occurs early in the QemuBaseTest constructor, the 'log_filename' object atttribute may not exist yet. This happens most notably if the QEMU_TEST_QEMU_BINARY is not set. We can't initialize 'log_filename' earlier as we use the binary to identify the architecture which is then used to bu

Re: [PATCH v7 02/12] util/dsa: Add idxd into linux header copy list.

2024-11-21 Thread Fabiano Rosas
Yichen Wang writes: > Signed-off-by: Yichen Wang > --- > scripts/update-linux-headers.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh > index 99a8d9fa4c..9128c7499b 100755 > --- a/scripts/update-linux-

[ANNOUNCE] QEMU 7.2.15 Stable released

2024-11-21 Thread Michael Tokarev
Hi everyone, The QEMU v7.2.15 stable release is now available. You can grab the tarball from our download page here: https://www.qemu.org/download/#source https://download.qemu.org/qemu-7.2.15.tar.xz https://download.qemu.org/qemu-7.2.15.tar.xz.sig (signature) v7.2.15 is now tagged in t

  1   2   3   >