Re: [PATCH v2 7/8] target/mips: Enable MSA ASE for mips32r6-generic

2024-10-19 Thread Aleksandar Rikalo
> > Enable MSA ASE for mips32r6-generic CPU. > > Cherry-picked 0186e83a0613e90aff6d4c12c91cdb080d695d37 > from https://github.com/MIPS/gnutools-qemu > > Signed-off-by: Aleksandar Markovic > Signed-off-by: Faraz Shahbazker > Signed-off-by: Aleksandar Rakic > --- > target/mips/cpu-defs.c.inc | 8

Re: [PATCH v2 8/8] target/mips: Enable MSA ASE for mips64R2-generic

2024-10-19 Thread Aleksandar Rikalo
> > Enable MSA ASE for mips64R2-generic CPU. > > Cherry-picked 60f6ae8d3d685ba1ea5d301222fb72b67f39264f > from https://github.com/MIPS/gnutools-qemu > > Signed-off-by: Faraz Shahbazker > Signed-off-by: Aleksandar Rakic > --- > target/mips/cpu-defs.c.inc | 4 +++- > 1 file changed, 3 insertions(

Re: [PATCH v2 5/8] Add micromips to P5600

2024-10-19 Thread Aleksandar Rikalo
> > Add micromips to P5600. > > Cherry-picked d7bf2c2f7f2e03b55c6e9c57eec5c3e6207005a0 > from https://github.com/MIPS/gnutools-qemu > > Signed-off-by: Faraz Shahbazker > Signed-off-by: Matthew Fortune > Signed-off-by: Aleksandar Rakic > --- > target/mips/cpu-defs.c.inc | 2 +- > 1 file changed,

Re: [PATCH v2 2/8] Add support for emulation of CRC32 instructions

2024-10-19 Thread Aleksandar Rikalo
> > Add emulation of MIPS' CRC32 (Cyclic Redundancy Check) instructions. > Reuse zlib crc32() and Linux crc32c(). > > Cherry-picked 4cc974938aee1588f852590509004e340c072940 > from https://github.com/MIPS/gnutools-qemu > > Signed-off-by: Yongbok Kim > Signed-off-by: Aleksandar Markovic > Signed-of

[Question] What is the definition of “private” fields in QOM?

2024-10-19 Thread Zhao Liu
Hi maintainers and list, In the QOM structure, the class and object structs have two members: parent_class and parent_obj, which are often marked as "< private >" in the comment. I couldn’t find information on why to define ‘private’ and ‘public’, even in the earliest QOM commits and the patch em

[RFC PATCH v2 1/7] plugins: add API for registering trap related callbacks

2024-10-19 Thread Julian Ganz
The plugin API allows registration of callbacks for a variety of VCPU related events, such as VCPU reset, idle and resume. However, traps of any kind, i.e. interrupts or exceptions, were previously not covered. These kinds of events are arguably quite significant and usually go hand in hand with a

Re: [PATCH] hw/sd/sdcard: Allow user creation of eMMCs

2024-10-19 Thread Philippe Mathieu-Daudé
On 18/10/24 12:42, Peter Maydell wrote: On Tue, 15 Oct 2024 at 14:57, Jan Luebbe wrote: For testing eMMC-specific functionality (such as handling boot partitions), it would be very useful to attach them to generic VMs such as x86_64 via the sdhci-pci device: ... -drive if=none,id=emmc-driv

[RFC PATCH v2 4/7] target/arm: call plugin trap callbacks

2024-10-19 Thread Julian Ganz
We recently introduced API for registering callbacks for trap related events as well as the corresponding hook functions. Due to differences between architectures, the latter need to be called from target specific code. This change places hooks for ARM (and Aarch64) targets. We decided to treat th

[RFC PATCH v2 0/7] tcg-plugins: add hooks for interrupts, exceptions and traps

2024-10-19 Thread Julian Ganz
Some analysis greatly benefits, or depends on, information about interrupts. For example, we may need to handle the execution of a new translation block differently if it is not the result of normal program flow but of an interrupt. Even with the existing interfaces, it is more or less possible to

[RFC PATCH v2 6/7] target/riscv: call plugin trap callbacks

2024-10-19 Thread Julian Ganz
We recently introduced API for registering callbacks for trap related events as well as the corresponding hook functions. Due to differences between architectures, the latter need to be called from target specific code. This change places hooks for RISC-V targets. Signed-off-by: Julian Ganz ---

[RFC PATCH v2 5/7] target/avr: call plugin trap callbacks

2024-10-19 Thread Julian Ganz
We recently introduced API for registering callbacks for trap related events as well as the corresponding hook functions. Due to differences between architectures, the latter need to be called from target specific code. This change places the hook for AVR targets. That architecture appears to only

[RFC PATCH v2 7/7] target/sparc: call plugin trap callbacks

2024-10-19 Thread Julian Ganz
We recently introduced API for registering callbacks for trap related events as well as the corresponding hook functions. Due to differences between architectures, the latter need to be called from target specific code. This change places hooks for SPARC (32bit and 64bit) targets. We treat any int

[RFC PATCH v2 2/7] plugins: add hooks for new trap related callbacks

2024-10-19 Thread Julian Ganz
The plugin API allows registration of callbacks for a variety of VCPU related events, such as VCPU reset, idle and resume. In addition, we recently introduced API for registering callbacks for trap events, specifically for interrupts, exceptions and semihosting events. This change introduces the c

Re: [RFC PATCH v2 5/7] target/avr: call plugin trap callbacks

2024-10-19 Thread Michael Rolnik
Reviewed-by: Michael Rolnik On Sat, Oct 19, 2024 at 7:39 PM Julian Ganz wrote: > We recently introduced API for registering callbacks for trap related > events as well as the corresponding hook functions. Due to differences > between architectures, the latter need to be called from target speci

Re: [PATCH net-next v7] ptp: Add support for the AMZNC10C 'vmclock' device

2024-10-19 Thread David Woodhouse
On Mon, 2024-10-14 at 13:12 -0700, Jakub Kicinski wrote: > On Mon, 14 Oct 2024 08:25:35 +0100 David Woodhouse wrote: > > On Wed, 2024-10-09 at 17:32 -0700, Jakub Kicinski wrote: > > > On Sun, 06 Oct 2024 08:17:58 +0100 David Woodhouse wrote:  > > > > +config PTP_1588_CLOCK_VMCLOCK > > > > +   

Re: [PATCH] sockets: Remove deadcode

2024-10-19 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Sep 19, 2024 at 12:26:33AM +0100, d...@treblig.org wrote: > > From: "Dr. David Alan Gilbert" > > > > socket_remote_address hasn't been used since it was added in > > 17c55decec ("sockets: add helpers for creating SocketAddress from a

Re: [PATCH v2] block/file-posix: optimize append write

2024-10-19 Thread Damien Le Moal
On 10/18/24 23:37, Kevin Wolf wrote: > Am 04.10.2024 um 12:41 hat Sam Li geschrieben: >> When the file-posix driver emulates append write, it holds the lock >> whenever accessing wp, which limits the IO queue depth to one. >> >> The write IO flow can be optimized to allow concurrent writes. The loc

[PATCH v5 01/19] hw/s390x/ipl: Provide more memory to the s390-ccw.img firmware

2024-10-19 Thread jrossi
From: Jared Rossi We are going to link the SLOF libc into the s390-ccw.img, and this libc needs more memory for providing space for malloc() and friends. Thus bump the memory size that we reserve for the bios to 3 MiB instead of only 2 MiB. While we're at it, add a proper check that there is real

[PATCH v5 00/19] s390x: Add Full Boot Order Support

2024-10-19 Thread jrossi
From: Jared Rossi changes v4 -> v5: - Fix a bug with per-deice loadparm support: The machine loadparm is no longer overwritten by device values, which now allows an empty machine loadparm to propagate to later devices even if the primary boot device set an initial loadparm - Fix two i

[PATCH v5 08/19] pc-bios/s390-ccw: Remove panics from ECKD IPL path

2024-10-19 Thread jrossi
From: Jared Rossi Remove panic-on-error from ECKD block device IPL specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code. Signed-off-by: Jared Rossi --- pc-bios/s390-ccw/bootmap.h | 1 + pc-bios/s390-ccw/boot

[PATCH v5 05/19] pc-bios/s390-ccw: Merge netboot.mak into the main Makefile

2024-10-19 Thread jrossi
From: Jared Rossi Now that the netboot code has been merged into the main s390-ccw.img, it also does not make sense to keep the build rules in a separate file. Thus let's merge netboot.mak into the main Makefile. Co-authored by: Thomas Huth Signed-off-by: Jared Rossi --- pc-bios/s390-ccw/netb

[PATCH v5 03/19] pc-bios/s390-ccw: Link the netboot code into the main s390-ccw.img binary

2024-10-19 Thread jrossi
From: Jared Rossi We originally built a separate binary for the netboot code since it was considered as experimental and we could not be sure that the necessary SLOF module had been checked out. Time passed, the code proved its usefulness, and the build system nowadays makes sure that the SLOF mo

[PATCH v5 16/19] s390x: Rebuild IPLB for SCSI device directly from DIAG308

2024-10-19 Thread jrossi
From: Jared Rossi Because virtio-scsi type devices use a non-architected IPLB pbt code they cannot be set and stored normally. Instead, the IPLB must be rebuilt during re-ipl. As s390x does not natively support multiple boot devices, the devno field is used to store the position in the boot orde

[PATCH v5 14/19] s390x: Add individual loadparm assignment to CCW device

2024-10-19 Thread jrossi
From: Jared Rossi Add a loadparm property to the VirtioCcwDevice object so that different loadparms can be defined on a per-device basis for CCW boot devices. The machine/global loadparm is still supported. If both a global and per-device loadparm are defined, the per-device value will override

[PATCH v5 17/19] pc-bios/s390x: Enable multi-device boot loop

2024-10-19 Thread jrossi
From: Jared Rossi Allow attempts to boot from multiple IPL devices. If the first device fails to IPL, select the pre-built IPLB for the next device in the boot order and attempt to IPL from it. Continue this process until IPL is successful or there are no devices left to try. Signed-off-by: Jare

[PATCH v5 12/19] pc-bios/s390-ccw: Enable failed IPL to return after error

2024-10-19 Thread jrossi
From: Jared Rossi Remove panic-on-error from IPL functions such that a return code is propagated back to the main IPL calling function (rather than terminating immediately), which facilitates possible error recovery in the future. A select few panics remain, which indicate fatal non-devices erro

[PATCH v5 04/19] hw/s390x: Remove the possibility to load the s390-netboot.img binary

2024-10-19 Thread jrossi
From: Jared Rossi Since the netboot code has now been merged into the main s390-ccw.img binary, we don't need the separate s390-netboot.img anymore. Remove it and the code that was responsible for loading it. Co-authored by: Thomas Huth Signed-off-by: Jared Rossi --- hw/s390x/ipl.h

[PATCH v5 19/19] tests/qtest: Add s390x boot order tests to cdrom-test.c

2024-10-19 Thread jrossi
From: Jared Rossi Add two new qtests to verify that a valid IPL device can successfully boot after failed IPL attempts from one or more invalid devices. cdrom-test/as-fallback-device: Defines the primary boot target as a device that is invalid for IPL and a second boot target that is valid for I

[PATCH v5 07/19] pc-bios/s390-ccw: Remove panics from ISO IPL path

2024-10-19 Thread jrossi
From: Jared Rossi Remove panic-on-error from IPL ISO El Torito specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code. Signed-off-by: Jared Rossi --- pc-bios/s390-ccw/bootmap.h | 15 +++ pc-bios/s390-ccw/s3

[PATCH v5 15/19] hw/s390x: Build an IPLB for each boot device

2024-10-19 Thread jrossi
From: Jared Rossi Build an IPLB for any device with a bootindex (up to a maximum of 8 devices). The IPLB chain is placed immediately before the BIOS in memory. Because this is not a fixed address, the location of the next IPLB and number of remaining boot devices is stored in the QIPL global var

Ping: [PATCH v2] net/vmnet: Pad short Ethernet frames

2024-10-19 Thread William Hooper
On Sat, Aug 17, 2024 at 11:33 PM William Hooper wrote: > At least on macOS 12.7.2, vmnet doesn't pad Ethernet frames, such as the > host's ARP replies, to the minimum size (60 bytes before the frame check > sequence) defined in IEEE Std 802.3-2022, so guests' Ethernet device > drivers may drop the

Re: [PATCH v2 1/8] Add CP0 MemoryMapID register implementation

2024-10-19 Thread Aleksandar Rikalo
Add CP0 MemoryMapID register implementation. > > Cherry-picked 9e0cb40adb110c2c76e2e97719ba8afcce72bcf5 > from https://github.com/MIPS/gnutools-qemu > > Signed-off-by: Yongbok Kim > Signed-off-by: Aleksandar Markovic > Signed-off-by: Aleksandar Rakic > --- > target/mips/sysemu/machine.c | 7 +++

Re: [PULL 08/20] virtio-net: Add only one queue pair when realizing

2024-10-19 Thread Akihiko Odaki
On 2024/10/18 13:50, Jason Wang wrote: On Thu, Oct 17, 2024 at 5:42 PM Akihiko Odaki wrote: On 2024/10/17 18:17, Laurent Vivier wrote: On 17/10/2024 11:07, Akihiko Odaki wrote: On 2024/10/17 16:32, Laurent Vivier wrote: On 17/10/2024 08:59, Jason Wang wrote: On Mon, Oct 14, 2024 at 11:16 P

Re: [PATCH v2 6/8] Revert use of clock_gettime for benchmarking

2024-10-19 Thread Philippe Mathieu-Daudé
Hi, On 18/10/24 10:20, Aleksandar Rakic wrote: This patch reverts the commit (with SHA 50290c002c045280f8defad911901e16bfb52884 from https://github.com/MIPS/gnutools-qemu) that breaks for mingw builds, where clock_gettime and CLOCK_MONOTONIC are not available. Isn't get_clock() what we want he

[RFC PATCH v2 3/7] contrib/plugins: add plugin showcasing new trap related API

2024-10-19 Thread Julian Ganz
We recently introduced new plugin API for registration of trap related callbacks. This change introduces a minimal plugin showcasing the new API. It simply counts the occurances of interrupts, exceptions and semihosting events per CPU and reports the counts when exitting. Signed-off-by: Julian Gan

[PATCH v5 13/19] include/hw/s390x: Add include files for common IPL structs

2024-10-19 Thread jrossi
From: Jared Rossi Currently, structures defined in both hw/s390x/ipl.h and pc-bios/s390-ccw/iplb.h must be kept in sync, which is prone to error. Instead, create a new directory at include/hw/s390x/ipl/ to contain the definitions that must be shared. Signed-off-by: Jared Rossi Reviewed-by: Thom

[PATCH v5 02/19] pc-bios/s390-ccw: Use the libc from SLOF and remove sclp prints

2024-10-19 Thread jrossi
From: Jared Rossi We are already using the libc from SLOF for the s390-netboot.img, and this libc implementation is way more complete and accurate than the simple implementation that we currently use for the s390-ccw.img binary. Since we are now always assuming that the SLOF submodule is availabl

[PATCH v5 18/19] docs/system: Update documentation for s390x IPL

2024-10-19 Thread jrossi
From: Jared Rossi Update docs to show that s390x PC BIOS can support more than one boot device. Signed-off-by: Jared Rossi Reviewed-by: Thomas Huth --- docs/system/bootindex.rst | 7 --- docs/system/s390x/bootdevices.rst | 9 ++--- 2 files changed, 10 insertions(+), 6 deletion

[PATCH v5 06/19] docs/system/s390x/bootdevices: Update the documentation about network booting

2024-10-19 Thread jrossi
From: Jared Rossi Remove the information about the separate s390-netboot.img from the documentation. Co-authored by: Thomas Huth Signed-off-by: Jared Rossi --- docs/system/s390x/bootdevices.rst | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/docs/syst

[PATCH v5 11/19] pc-bios/s390-ccw: Remove panics from Netboot IPL path

2024-10-19 Thread jrossi
From: Jared Rossi Remove panic-on-error from Netboot specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code. Signed-off-by: Jared Rossi --- pc-bios/s390-ccw/s390-ccw.h | 2 +- pc-bios/s390-ccw/bootmap.c|

[PATCH v5 10/19] pc-bios/s390-ccw: Remove panics from DASD IPL path

2024-10-19 Thread jrossi
From: Jared Rossi Remove panic-on-error from DASD IPL specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code. Signed-off-by: Jared Rossi Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/dasd-ipl.h | 2 +- pc-bios

[PATCH v5 09/19] pc-bios/s390-ccw: Remove panics from SCSI IPL path

2024-10-19 Thread jrossi
From: Jared Rossi Remove panic-on-error from virtio-scsi IPL specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code. Signed-off-by: Jared Rossi --- pc-bios/s390-ccw/bootmap.c | 88 ++- pc-

Re: [PATCH v2] intel_iommu: Introduce property "x-stale-tm" to control Transient Mapping (TM) field

2024-10-19 Thread Michael S. Tsirkin
On Thu, Oct 17, 2024 at 07:57:53AM +, Duan, Zhenzhong wrote: > > > >-Original Message- > >From: Jason Wang > >Subject: Re: [PATCH v2] intel_iommu: Introduce property "x-stale-tm" to > >control > >Transient Mapping (TM) field > > > >On Thu, Oct 10, 2024 at 3:57 PM Zhenzhong Duan > >