Re: [PATCH v2 12/31] monitor: adapt to new import path for qobject data type headers

2024-10-18 Thread Zhao Liu
On Thu, Oct 17, 2024 at 12:33:24PM +0100, Daniel P. Berrangé wrote: > Date: Thu, 17 Oct 2024 12:33:24 +0100 > From: "Daniel P. Berrangé" > Subject: [PATCH v2 12/31] monitor: adapt to new import path for qobject > data type headers > > The qobject data type headers have moved from qapi/qmp/ to >

Re: [PATCH v2 19/23] hw/block/pflash_cfi01: Prefer DEFINE_TYPES() macro

2024-10-18 Thread Kevin Wolf
Am 05.10.2024 um 21:45 hat Bernhard Beschow geschrieben: > Reviewed-by: Cédric Le Goater > Signed-off-by: Bernhard Beschow Reviewed-by: Kevin Wolf

[PULL 5/9] block: Adjust check_block_size() signature

2024-10-18 Thread Markus Armbruster
Parameter @id is no longer used, drop. Return a bool to indicate success / failure, as recommended by qapi/error.h. Signed-off-by: Markus Armbruster Message-ID: <20241010150144.986655-4-arm...@redhat.com> Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé --- util/block-helpe

[PULL 8/9] hw/intc/openpic: Improve errors for out of bounds property values

2024-10-18 Thread Markus Armbruster
The error message doesn't matter much, as the "openpic" device isn't user-creatable. But it's the last use of QERR_PROPERTY_VALUE_OUT_OF_RANGE, which has to go. Change the message just like the previous commit did for x86 CPUs. Signed-off-by: Markus Armbruster Message-ID: <20241010150144.986655

[PULL 4/9] block: Improve errors about block sizes

2024-10-18 Thread Markus Armbruster
Block sizes need to be a power of two between 512 and an arbitrary limit, currently 2MiB. Commit 5937835ac4c factored block size checking out of set_blocksize() into new check_block_size(), for reuse in block/export/. Its two error messages are okay for the original purpose: $ qemu-system-x8

[PULL 3/9] error: Drop superfluous #include "qapi/qmp/qerror.h"

2024-10-18 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-ID: <20241010150144.986655-2-arm...@redhat.com> Reviewed-by: Daniel P. Berrangé --- qga/commands-bsd.c | 1 - qga/commands-linux.c | 1 - qga/commands-posix.c | 1 - 3 files changed, 3 deletions(-) diff --git a/qga/commands-bsd.c b/qga/commands-bsd.c i

[PULL 6/9] target/i386/cpu: Avoid mixing signed and unsigned in property setters

2024-10-18 Thread Markus Armbruster
Properties "family", "model", and "stepping" are visited as signed integers. They are backed by bits in CPUX86State member @cpuid_version. The code to extract and insert these bits mixes signed and unsigned. Not actually wrong, but avoiding such mixing is good practice. Visit them as unsigned i

[PULL 1/9] qga/qapi-schema: Drop obsolete note on "unsupported" errors

2024-10-18 Thread Markus Armbruster
The note talks about "unsupported" errors and QERR_UNSUPPORTED. The former is vague, and the latter makes sense only in C, not in external interface documentation. Fortunately, we don't have to address this anymore: recent merge commit 3b5efc553eb got rid of these errors. Delete the note. Signed

[PULL 2/9] qga: Improve error for guest-set-user-password parameter @crypted

2024-10-18 Thread Markus Armbruster
The Windows version of guest-set-user-password rejects argument "crypted": true with the rather useless "this feature or command is not currently supported". Improve to "'crypted' must be off on this host". QERR_UNSUPPORTED is now unused. Drop. Signed-off-by: Markus Armbruster Message-ID: <202

[PULL 0/9] Error reporting patches for 2024-10-18

2024-10-18 Thread Markus Armbruster
The following changes since commit 95a16ee753d6da651fce8df876333bf7fcf134d9: Merge tag 'pull-loongarch-20241016' of https://gitlab.com/gaosong/qemu into staging (2024-10-17 12:42:23 +0100) are available in the Git repository at: https://repo.or.cz/qemu/armbru.git tags/pull-error-2024-10-18

[PULL 7/9] target/i386/cpu: Improve errors for out of bounds property values

2024-10-18 Thread Markus Armbruster
The error message for a "stepping" value that is out of bounds is a bit odd: $ qemu-system-x86_64 -cpu qemu64,stepping=16 qemu-system-x86_64: can't apply global qemu64-x86_64-cpu.stepping=16: Property .stepping doesn't take value 16 (minimum: 0, maximum: 15) The "can't apply global" part

Re: [RFC PATCH 00/16] rust: allow older versions of rustc and bindgen

2024-10-18 Thread Daniel P . Berrangé
On Tue, Oct 15, 2024 at 03:17:18PM +0200, Paolo Bonzini wrote: > On top of this, the required version of bindgen is still too new > for Debian 12 and Ubuntu 22.04. This is fixed by the last four patches. > > This is an RFC for two reasons. First, because it would be a valid > decision to delay e

Re: [PATCH v2 26/31] trace: adapt to new import path for qobject data type headers

2024-10-18 Thread Zhao Liu
On Thu, Oct 17, 2024 at 12:33:38PM +0100, Daniel P. Berrangé wrote: > Date: Thu, 17 Oct 2024 12:33:38 +0100 > From: "Daniel P. Berrangé" > Subject: [PATCH v2 26/31] trace: adapt to new import path for qobject data > type headers > > The qobject data type headers have moved from qapi/qmp/ to > qo

Re: [SPAM] [PATCH v1 02/16] hw/block:m25p80: Fix coding style

2024-10-18 Thread Cédric Le Goater
On 10/18/24 07:30, Jamin Lin wrote: Fix coding style issues from checkpatch.pl Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Thanks, C. --- hw/block/m25p80.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/hw/block/m25p80.c b/hw/b

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Peter Maydell
On Fri, 18 Oct 2024 at 10:01, Daniel P. Berrangé wrote: > Test reliability is a different thing. If a particular test is > flaky, it needs to either be fixed or disabled. Splitting into > a fast & slow grouping doesn't address reliability, just hides > the problem from view. On the subject of 'fl

Re: [PATCH v4] arm/kvm: add support for MTE

2024-10-18 Thread Peter Maydell
On Tue, 8 Oct 2024 at 12:43, Ganapatrao Kulkarni wrote: > > From: Cornelia Huck > > Extend the 'mte' property for the virt machine to cover KVM as > well. For KVM, we don't allocate tag memory, but instead enable > the capability. > > If MTE has been enabled, we need to disable migration, as we d

Re: [PATCH v3 0/2] throttling for BLOCK_IO_ERROR

2024-10-18 Thread Kevin Wolf
Am 02.10.2024 um 17:18 hat Vladimir Sementsov-Ogievskiy geschrieben: > v2: switch to qom-path as discriminator, for this, add patch 01. > > Leonid Kaplan (1): > block-backend: per-device throttling of BLOCK_IO_ERROR reports > > Vladimir Sementsov-Ogievskiy (1): > qapi: add qom-path to BLOCK_I

Re: [RFC V1 04/14] accel: set accelerator and machine props earlier

2024-10-18 Thread Steven Sistare
On 10/18/2024 11:08 AM, Fabiano Rosas wrote: Steve Sistare writes: Make all global and compat properties available before the first objects are created. Set accelerator compatibility properties in configure_accelerators, when the accelerator is chosen, and call configure_accelerators earlier.

Re: [QEMU RFC] hw/mem/cxl_type3: add guard to avoid event log overflow during a DC extent add/release request

2024-10-18 Thread Fan Ni
On Mon, Oct 14, 2024 at 12:23:22PM +0100, Jonathan Cameron wrote: > On Fri, 11 Oct 2024 13:24:50 -0700 > nifan@gmail.com wrote: > > > From: Fan Ni > > > > One DC extent add/release request can take multiple DC extents. > > For each extent in the request, one DC event record will be generated

Re: [RFC PATCH] cli: add connect-gpios option

2024-10-18 Thread Peter Maydell
On Thu, 10 Oct 2024 at 18:39, Octavian Purdila wrote: > > From: Valentin Ghita > > Add option to allow for connecting device GPIOs. This is useful when > adding a peripheral device from the command line which uses an > interrupt. > > It takes the following options: > > * in-dev-path, out-dev-path

Re: [PATCH 04/16] rust: patch bilge-impl to allow compilation with 1.63.0

2024-10-18 Thread Zhao Liu
On Tue, Oct 15, 2024 at 03:17:22PM +0200, Paolo Bonzini wrote: > Date: Tue, 15 Oct 2024 15:17:22 +0200 > From: Paolo Bonzini > Subject: [PATCH 04/16] rust: patch bilge-impl to allow compilation with > 1.63.0 > X-Mailer: git-send-email 2.46.2 > > Apply a patch that removes "let ... else" construc

Re: [PATCH v4 1/4] KVM: Dynamic sized kvm memslots array

2024-10-18 Thread Michael Tokarev
17.09.2024 19:38, Peter Xu wrote: Zhiyi reported an infinite loop issue in VFIO use case. The cause of that was a separate discussion, however during that I found a regression of dirty sync slowness when profiling. Each KVMMemoryListerner maintains an array of kvm memslots. Currently it's stat

Re: [PATCH v9 4/7] qapi: add blockdev-replace command

2024-10-18 Thread Kevin Wolf
Am 04.10.2024 um 19:01 hat Vladimir Sementsov-Ogievskiy geschrieben: > On 02.10.24 17:41, Vladimir Sementsov-Ogievskiy wrote: > > On 26.06.24 14:53, Vladimir Sementsov-Ogievskiy wrote: > > > diff --git a/qapi/block-core.json b/qapi/block-core.json > > > index df5e07debd..0a6f08a6e0 100644 > > > ---

Re: [PATCH v2 07/31] docs: adapt to new import path for qobject data type headers

2024-10-18 Thread Zhao Liu
On Thu, Oct 17, 2024 at 12:33:19PM +0100, Daniel P. Berrangé wrote: > Date: Thu, 17 Oct 2024 12:33:19 +0100 > From: "Daniel P. Berrangé" > Subject: [PATCH v2 07/31] docs: adapt to new import path for qobject data > type headers > > The qobject data type headers have moved from qapi/qmp/ to > qob

[PATCH v2 2/8] Add support for emulation of CRC32 instructions

2024-10-18 Thread Aleksandar Rakic
Add emulation of MIPS' CRC32 (Cyclic Redundancy Check) instructions. Reuse zlib crc32() and Linux crc32c(). Cherry-picked 4cc974938aee1588f852590509004e340c072940 from https://github.com/MIPS/gnutools-qemu Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic Signed-off-by: Aleksandar R

[PATCH v2 5/8] Add micromips to P5600

2024-10-18 Thread Aleksandar Rakic
Add micromips to P5600. Cherry-picked d7bf2c2f7f2e03b55c6e9c57eec5c3e6207005a0 from https://github.com/MIPS/gnutools-qemu Signed-off-by: Faraz Shahbazker Signed-off-by: Matthew Fortune Signed-off-by: Aleksandar Rakic --- target/mips/cpu-defs.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH v2 3/8] GTM19-448: Fix script to work without realpath

2024-10-18 Thread Aleksandar Rakic
The archive-source.sh script depends on realpath command, which was introduced in coreutils-8.15. CentOS-6 build systems use coreutils-4.7, which does not have realpath, so fix the script to use 'readlink -e' to perform the same action. Cherry-picked 5d1d5766f0219ce2bec4e41c2467317df920ec0a and 80

[PATCH v2 1/8] Add CP0 MemoryMapID register implementation

2024-10-18 Thread Aleksandar Rakic
Add CP0 MemoryMapID register implementation. Cherry-picked 9e0cb40adb110c2c76e2e97719ba8afcce72bcf5 from https://github.com/MIPS/gnutools-qemu Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic Signed-off-by: Aleksandar Rakic --- target/mips/sysemu/machine.c | 7 +-- 1 file cha

[PATCH v2 4/8] Skip NaN mode check for soft-float

2024-10-18 Thread Aleksandar Rakic
Skip NaN mode check for soft-float since NaN mode is irrelevant if an ELF binary's FPU mode is soft-float, i.e. it doesn't utilize a FPU. Cherry-picked 63492a56485f6b755fccf7ad623f7a189bfc79b6 from https://github.com/MIPS/gnutools-qemu Signed-off-by: Faraz Shahbazker Signed-off-by: Aleksandar R

[PATCH v2 7/8] target/mips: Enable MSA ASE for mips32r6-generic

2024-10-18 Thread Aleksandar Rakic
Enable MSA ASE for mips32r6-generic CPU. Cherry-picked 0186e83a0613e90aff6d4c12c91cdb080d695d37 from https://github.com/MIPS/gnutools-qemu Signed-off-by: Aleksandar Markovic Signed-off-by: Faraz Shahbazker Signed-off-by: Aleksandar Rakic --- target/mips/cpu-defs.c.inc | 8 +--- 1 file cha

[PATCH v2 6/8] Revert use of clock_gettime for benchmarking

2024-10-18 Thread Aleksandar Rakic
This patch reverts the commit (with SHA 50290c002c045280f8defad911901e16bfb52884 from https://github.com/MIPS/gnutools-qemu) that breaks for mingw builds, where clock_gettime and CLOCK_MONOTONIC are not available. Cherry-picked d57c735e1af1ca719dbd0c3a904ad70c9c31cbb7 from https://github.com/MIPS/

[PATCH v2 8/8] target/mips: Enable MSA ASE for mips64R2-generic

2024-10-18 Thread Aleksandar Rakic
Enable MSA ASE for mips64R2-generic CPU. Cherry-picked 60f6ae8d3d685ba1ea5d301222fb72b67f39264f from https://github.com/MIPS/gnutools-qemu Signed-off-by: Faraz Shahbazker Signed-off-by: Aleksandar Rakic --- target/mips/cpu-defs.c.inc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) d

Re: [PATCH 01/16] meson: import rust module into a global variable

2024-10-18 Thread Zhao Liu
On Tue, Oct 15, 2024 at 03:17:19PM +0200, Paolo Bonzini wrote: > Date: Tue, 15 Oct 2024 15:17:19 +0200 > From: Paolo Bonzini > Subject: [PATCH 01/16] meson: import rust module into a global variable > X-Mailer: git-send-email 2.46.2 > > Signed-off-by: Paolo Bonzini > --- > meson.build

[PATCH v2 3/5] guestperf: Support deferred migration for multifd

2024-10-18 Thread Hyman Huang
The way to enable multifd migration has been changed by commit, 82137e6c8c (migration: enforce multifd and postcopy preempt to be set before incoming), and guestperf has not made the necessary changes. If multifd migration had been enabled in the previous manner, the following error would have occu

Re: [RFC V1 04/14] accel: set accelerator and machine props earlier

2024-10-18 Thread Steven Sistare
On 10/18/2024 11:40 AM, Steven Sistare wrote: On 10/18/2024 11:32 AM, Steven Sistare wrote: On 10/18/2024 11:08 AM, Fabiano Rosas wrote: Steve Sistare writes: Make all global and compat properties available before the first objects are created.  Set accelerator compatibility properties in co

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Daniel P . Berrangé
On Fri, Oct 18, 2024 at 10:51:08AM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > On Thu, Oct 17, 2024 at 01:29:35PM -0300, Fabiano Rosas wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Thu, Oct 17, 2024 at 11:32:11AM -0300, Fabiano Rosas wrote: > >> >> Recent changes to h

[PATCH 0/7] docs/system/arm: Provide at least skeleton docs for all boards

2024-10-18 Thread Peter Maydell
In target-arm.rst there is an apologetic note: Unfortunately many of the Arm boards QEMU supports are currently undocumented; you can get a complete list by running ``qemu-system-aarch64 --machine help``. However, the situation isn't actually as bleak as this suggests: over the years we hav

[PATCH 3/7] docs/system/arm: Split fby35 out from aspeed.rst

2024-10-18 Thread Peter Maydell
The fby35 machine is not implemented in hw/arm/aspeed.c, but its documentation is currently stuck at the end of aspeed.rst, formatted in a way that it gets its own heading in the top-level list of boards in target-arm.html. We don't have any other boards that we document like this; split it out in

[PATCH 6/7] docs/system/arm: Add placeholder docs for mcimx6ul-evk and mcimx7d-sabre

2024-10-18 Thread Peter Maydell
Add placeholder docs for the mcimx6ul-evk and mcimx7d-sabre boards. Signed-off-by: Peter Maydell --- MAINTAINERS | 2 ++ docs/system/arm/mcimx6ul-evk.rst | 5 + docs/system/arm/mcimx7d-sabre.rst | 5 + docs/system/target-arm.rst| 2 ++ 4 files changed, 14 i

[PATCH 7/7] docs/system/target-arm.rst: Remove "many boards are undocumented" note

2024-10-18 Thread Peter Maydell
We now have at least placeholder documentation for every Arm board, so we can remove the apologetic note that says that there are undocumented ones which you can only find out about via the ``--machine help`` option. Signed-off-by: Peter Maydell --- docs/system/target-arm.rst | 4 1 file ch

[PATCH 5/7] docs/system/arm: Add placeholder doc for xlnx-zcu102 board

2024-10-18 Thread Peter Maydell
Add a placeholder doc for the xlnx-zcu102 board. Signed-off-by: Peter Maydell --- MAINTAINERS | 1 + docs/system/arm/xlnx-zcu102.rst | 19 +++ docs/system/target-arm.rst | 1 + 3 files changed, 21 insertions(+) create mode 100644 docs/system/arm/xlnx-z

[PATCH 4/7] docs/system/arm: Add placeholder doc for exynos4 boards

2024-10-18 Thread Peter Maydell
Add a placeholder doc for the exynos4 boards nuri and smdkc210. Signed-off-by: Peter Maydell --- MAINTAINERS| 1 + docs/system/arm/exynos.rst | 9 + docs/system/target-arm.rst | 1 + 3 files changed, 11 insertions(+) create mode 100644 docs/system/arm/exynos.rst diff --

[PATCH 2/7] docs/system/arm: Don't use wildcard '*-bmc' in doc titles

2024-10-18 Thread Peter Maydell
We have two Arm board doc files which both use '*-bmc' in their documentation title. The result is that when you read the table of contents in system/target-arm.html you don't know which boards are covered by which file. Expand out the board names entirely in the document titles. Signed-off-by: P

[PATCH 1/7] docs/system/arm/stm32: List olimex-stm32-h405 in document title

2024-10-18 Thread Peter Maydell
List the olimex-stm32-h405 board in the document title, so that the board name appears in the table of contents in system/target-arm.rst. Signed-off-by: Peter Maydell --- docs/system/arm/stm32.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/system/arm/stm32.rst b

Re: [PATCH V1 2/4] hw/acpi: Update ACPI CPU Status `is_{present, enabled}` during vCPU hot(un)plug

2024-10-18 Thread Igor Mammedov
On Mon, 14 Oct 2024 20:22:03 +0100 Salil Mehta wrote: > Update the `AcpiCpuStatus` for `is_enabled` and `is_present` accordingly when > vCPUs are hot-plugged or hot-unplugged, taking into account the *persistence* > of the vCPUs. > > Signed-off-by: Salil Mehta > --- > hw/acpi/cpu.c | 7 +++

Re: [PATCH V1 3/4] hw/acpi: Reflect ACPI vCPU {present,enabled} states in ACPI _STA.{PRES,ENA} Bits

2024-10-18 Thread Igor Mammedov
On Mon, 14 Oct 2024 20:22:04 +0100 Salil Mehta wrote: > Reflect the ACPI CPU hotplug `is_{present, enabled}` states in the `_STA.PRES` > (presence) and `_STA.ENA` (enabled) bits when the guest kernel evaluates the > ACPI `_STA` method during initialization, as well as when vCPUs are > hot-plugge

Re: [PATCH V1 4/4] hw/acpi: Populate vCPU Hotplug VMSD to migrate `is_{present,enabled}` states

2024-10-18 Thread Igor Mammedov
On Mon, 14 Oct 2024 20:22:05 +0100 Salil Mehta wrote: > The ACPI CPU hotplug states `is_{present, enabled}` must be migrated alongside > other vCPU hotplug states to the destination VM. Therefore, they should be > integrated into the existing CPU Hotplug VM State Description (VMSD) table. > Depen

[PATCH] stubs: remove stubs/qdev.c

2024-10-18 Thread Paolo Bonzini
qapi_event_send_device_deleted is always included (together with the rest of QAPI) in libqemuutil.a, so it is unnecessary to include a stub for it. This avoids a duplicate symbol in libqemuutil.a, which in principle could result in missing events on the monitor. Cc: qemu-sta...@nongnu.org Signed-

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Daniel P . Berrangé
On Fri, Oct 18, 2024 at 11:28:53AM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > On Fri, Oct 18, 2024 at 10:51:03AM -0300, Fabiano Rosas wrote: > >> Daniel P. Berrangé writes: > >> > >> > That could be a good reason to split the migration-test into > >> > two distinct programs.

Re: [PATCH v2] block/file-posix: optimize append write

2024-10-18 Thread Kevin Wolf
Am 04.10.2024 um 12:41 hat Sam Li geschrieben: > When the file-posix driver emulates append write, it holds the lock > whenever accessing wp, which limits the IO queue depth to one. > > The write IO flow can be optimized to allow concurrent writes. The lock > is held in two cases: > 1. Assumed tha

[PATCH 00/13] rust: miscellaneous cleanups + QOM integration tests

2024-10-18 Thread Paolo Bonzini
This series integrates some of the observations from the MSRV patches at https://lore.kernel.org/qemu-devel/20241015131735.518771-1-pbonz...@redhat.com/. The main changes here are two: first, build an integration test that actually tries to create a QOM object that is defined by Rust code; second,

[PATCH 10/13] qdev: make properties array "const"

2024-10-18 Thread Paolo Bonzini
Constify all accesses to qdev properties, except for the ObjectPropertyAccessor itself. This makes it possible to place them in read-only memory, and also lets Rust bindings switch from "static mut" arrays to "static"; which is advantageous, because mutable statics are highly discouraged. Signed-

[PATCH 11/13] rust: make properties array immutable

2024-10-18 Thread Paolo Bonzini
Now that device_class_set_props() takes a const pointer, the only part of "define_property!" that needs to be non-const is the call to try_into(). This in turn will only break if offset_of returns a value with the most significant bit set (i.e. a struct size that is >=2^31 or >= 2^63, respectively

[PATCH 12/13] rust: provide safe wrapper for MaybeUninit::zeroed()

2024-10-18 Thread Paolo Bonzini
MaybeUninit::zeroed() is handy, but it introduces unsafe (and has a pretty heavy syntax in general). Introduce a trait that provides the same functionality while staying within safe Rust. In addition, MaybeUninit::zeroed() is not available as a "const" function until Rust 1.75.0, so this also pre

[PATCH 03/13] meson: pass rustc_args when building all crates

2024-10-18 Thread Paolo Bonzini
rustc_args is needed to smooth the difference in warnings between the various versions of rustc. Always include those arguments. Signed-off-by: Paolo Bonzini --- meson.build | 18 +++--- rust/qemu-api/meson.build | 2 +- rust/qemu-api/src/device_class.

[PATCH 05/13] rust: remove uses of #[no_mangle]

2024-10-18 Thread Paolo Bonzini
Mangled symbols do not cause any issue; disabling mangling is only useful if C headers reference the Rust function, which is not the case here. Signed-off-by: Paolo Bonzini --- rust/hw/char/pl011/src/device.rs | 5 - rust/hw/char/pl011/src/device_class.rs | 2 -- rust/hw/char/pl011/src

[PATCH 13/13] rust: do not use TYPE_CHARDEV unnecessarily

2024-10-18 Thread Paolo Bonzini
In the invocation of qdev_prop_set_chr(), "chardev" is the name of a property rather than a type and has to match the name of the property in device_class.rs. Do not use TYPE_CHARDEV here, just like in the C version of pl011_create. Signed-off-by: Paolo Bonzini --- rust/hw/char/pl011/src/device

[PATCH 08/13] rust: build integration test for the qemu_api crate

2024-10-18 Thread Paolo Bonzini
Adjust the integration test to compile with a subset of QEMU object files, and make it actually create an object of the class it defines. Follow the Rust filesystem conventions, where tests go in tests/ if they use the library in the same way any other code would. Signed-off-by: Paolo Bonzini --

[PATCH 01/13] meson: import rust module into a global variable

2024-10-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- meson.build | 1 + rust/qemu-api-macros/meson.build | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index d26690ce204..ffd78b6cbb3 100644 --- a/meson.build +++ b/meson.build @@ -15,6 +15,7 @@ me

Re: [PULL v2 00/26] x86 and KVM patches for 2024-10-15

2024-10-18 Thread Peter Maydell
On Thu, 17 Oct 2024 at 18:45, Paolo Bonzini wrote: > > The following changes since commit f774a677507966222624a9b2859f06ede7608100: > > Merge tag 'pull-target-arm-20241015-1' of > https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-10-15 > 15:18:22 +0100) > > are available in th

[PATCH v4] scripts/symlink-install-tree.py: Fix MESONINTROSPECT parsing

2024-10-18 Thread Peter Maydell
From: Akihiko Odaki The arguments in MESONINTROSPECT are quoted with shlex.quote() so it must be parsed with shlex.split(). Otherwise the script will fail if the build directory has a character like "~" in it. Note: this fix cannot be backported directly to any stable branch that doesn't requir

[PATCH] qemu-ga: Fix a SIGSEGV on guest-set-time command

2024-10-18 Thread Sunil Nimmagadda
qemu-ga on a NetBSD -current VM terminates with a SIGSEGV upon receiving 'guest-set-time' command... Core was generated by `qemu-ga'. Program terminated with signal SIGSEGV, Segmentation fault. #0 0x0cd37a40 in ga_pipe_read_str (fd=fd@entry=0xff922a20, str=str@entry=0xff922a18)

Re: [PATCH v6 0/3] Add support for the RAPL MSRs series

2024-10-18 Thread Igor Mammedov
On Wed, 16 Oct 2024 14:56:39 +0200 "Anthony Harivel" wrote: > Hi Igor, > > Igor Mammedov, Oct 16, 2024 at 13:52: > > On Wed, 22 May 2024 17:34:49 +0200 > > Anthony Harivel wrote: > > > >> Dear maintainers, > >> > >> First of all, thank you very much for your review of my patch > >> [1].

[PATCH v2 0/8] Introduce MIPS64r6 target

2024-10-18 Thread Aleksandar Rakic
This patch series introduces support for the MIPS64r6 target in QEMU, bringing the latest architecture features and improvements to the MIPS target. In addition to the new target, this series also includes several bug fixes that have been in use internally for years within the MIPS ecosystem. The

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Fri, Oct 18, 2024 at 10:51:03AM -0300, Fabiano Rosas wrote: >> Daniel P. Berrangé writes: >> >> > On Fri, Oct 18, 2024 at 10:46:55AM +0100, Peter Maydell wrote: >> >> On Fri, 18 Oct 2024 at 10:01, Daniel P. Berrangé >> >> wrote: >> >> > >> >> > On Thu, Oct 17,

Re: [PATCH v2] ui/console-vc: Silence warning about sprintf() on OpenBSD

2024-10-18 Thread Michael Tokarev
15.10.2024 14:25, Thomas Huth wrote: The linker on OpenBSD complains: ld: warning: console-vc.c:824 (../src/ui/console-vc.c:824)([...]): warning: sprintf() is often misused, please use snprintf() Using g_strdup_printf() is certainly better here, so let's switch to that function instead. R

[PATCH 07/13] rust: modernize #[derive(Object)] for ELF platforms

2024-10-18 Thread Paolo Bonzini
Some newer ABI implementations do not provide .ctors; and while some linkers rewrite .ctors into .init_array, not all of them do. Use the newer .init_array ABI, which works more reliably, and apply it to all non-Apple, non-Windows platforms. This is similar to how the ctor crate operates; without

[PATCH 04/13] rust: do not use --no-size_t-is-usize

2024-10-18 Thread Paolo Bonzini
This not necessary and makes it harder to write code that is portable between 32- and 64-bit systems: it adds extra casts even though size_of, align_of or offset_of already return the right type. Signed-off-by: Paolo Bonzini --- meson.build | 1 - rust/qemu-api/src/definitio

[PATCH 06/13] rust: remove unused macro module_init!

2024-10-18 Thread Paolo Bonzini
Registering the object is now done by the #[derive(Object)] macro. Signed-off-by: Paolo Bonzini --- rust/qemu-api/src/definitions.rs | 43 1 file changed, 43 deletions(-) diff --git a/rust/qemu-api/src/definitions.rs b/rust/qemu-api/src/definitions.rs index 49ac

[PATCH 09/13] rust: clean up define_property macro

2024-10-18 Thread Paolo Bonzini
Use the "struct update" syntax to initialize most of the fields to zero, and simplify the handmade type-checking of $name. Signed-off-by: Paolo Bonzini --- rust/qemu-api/src/device_class.rs | 29 ++--- 1 file changed, 6 insertions(+), 23 deletions(-) diff --git a/rust/qe

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Fri, Oct 18, 2024 at 10:51:08AM -0300, Fabiano Rosas wrote: >> Daniel P. Berrangé writes: >> >> > On Thu, Oct 17, 2024 at 01:29:35PM -0300, Fabiano Rosas wrote: >> >> Daniel P. Berrangé writes: >> >> >> >> > On Thu, Oct 17, 2024 at 11:32:11AM -0300, Fabiano Ros

Re: [PATCH] Migration: Add trace points for vmstate handler insertion/removal

2024-10-18 Thread Fabiano Rosas
Peter Xu writes: > SaveStateEntry has lots of magics internally, on alias_id, get_id() being > able to overwrite the original idstr, compat fields, ID_ANY, and so on. It > may not be always clear that what all these fields are being registered for > some device we care. > > Add trace points for

[PATCH 02/13] meson: remove repeated search for rust_root_crate.sh

2024-10-18 Thread Paolo Bonzini
Avoid repeated lines of the form Program scripts/rust/rust_root_crate.sh found: YES (/home/pbonzini/work/upstream/qemu/scripts/rust/rust_root_crate.sh) in the meson logs. Reviewed-by: Junjie Mao Signed-off-by: Paolo Bonzini --- meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[PATCH] Migration: Add trace points for vmstate handler insertion/removal

2024-10-18 Thread Peter Xu
SaveStateEntry has lots of magics internally, on alias_id, get_id() being able to overwrite the original idstr, compat fields, ID_ANY, and so on. It may not be always clear that what all these fields are being registered for some device we care. Add trace points for SaveStateEntry insertions/remo

Re: [PATCH V1 0/4] Arch agnostic ACPI changes to support vCPU Hotplug (on Archs like ARM)

2024-10-18 Thread Igor Mammedov
On Mon, 14 Oct 2024 20:22:01 +0100 Salil Mehta wrote: > Certain CPU architecture specifications [1][2][3] prohibit changes to the CPUs > *presence* after the kernel has booted. This is because many system > initializations depend on the exact CPU count at boot time and do not expect > it > to ch

Re: [PATCH RFC 0/5] hw/cxl: Type 2 Device RFC

2024-10-18 Thread Zhi Wang
On 17/10/2024 19.57, Cédric Le Goater wrote: > External email: Use caution opening links or attachments > > > Hello, > > On 5/18/23 04:45, Ira Weiny wrote: >> Type 2 devices are not yet a reality.  Developing core kernel support >> is difficult without some test device to model against. >> >> De

Re: [PATCH V1 3/4] hw/acpi: Reflect ACPI vCPU {present,enabled} states in ACPI _STA.{PRES,ENA} Bits

2024-10-18 Thread Igor Mammedov
On Fri, 18 Oct 2024 13:12:52 +0800 Zhao Liu wrote: > Hi Salil, > > On Mon, Oct 14, 2024 at 08:22:04PM +0100, Salil Mehta wrote: > > Date: Mon, 14 Oct 2024 20:22:04 +0100 > > From: Salil Mehta > > Subject: [PATCH V1 3/4] hw/acpi: Reflect ACPI vCPU {present,enabled} states > > in ACPI _STA.{PRES

Re: [PATCH 0/2] fix backup-discard-source test for XFS

2024-10-18 Thread Kevin Wolf
Am 03.10.2024 um 08:39 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi Kevin! > > Now I revisit my old series, and looking here I see that I forget add you > into CC. > > Does it still make sense? Oops, I missed this one indeed. Thanks, applied to the block branch. Kevin

Re: [PATCH 02/16] meson: remove repeated search for rust_root_crate.sh

2024-10-18 Thread Zhao Liu
On Tue, Oct 15, 2024 at 03:17:20PM +0200, Paolo Bonzini wrote: > Date: Tue, 15 Oct 2024 15:17:20 +0200 > From: Paolo Bonzini > Subject: [PATCH 02/16] meson: remove repeated search for rust_root_crate.sh > X-Mailer: git-send-email 2.46.2 > > Avoid repeated lines of the form > > Program scripts/ru

Re: [PATCH RFC 0/5] hw/cxl: Type 2 Device RFC

2024-10-18 Thread Alejandro Lucero Palau
On 10/18/24 15:49, Zhi Wang wrote: On 17/10/2024 19.57, Cédric Le Goater wrote: External email: Use caution opening links or attachments Hello, On 5/18/23 04:45, Ira Weiny wrote: Type 2 devices are not yet a reality.  Developing core kernel support is difficult without some test device to

Re: [PATCH] hw/sd/sdcard: Allow user creation of eMMCs

2024-10-18 Thread Peter Maydell
On Tue, 15 Oct 2024 at 14:57, Jan Luebbe wrote: > > For testing eMMC-specific functionality (such as handling boot > partitions), it would be very useful to attach them to generic VMs such > as x86_64 via the sdhci-pci device: > ... > -drive if=none,id=emmc-drive,file=emmc.img,format=raw \ > -d

Re: [PATCH 06/16] rust: do not use OnceLock for properties

2024-10-18 Thread Zhao Liu
On Tue, Oct 15, 2024 at 03:17:24PM +0200, Paolo Bonzini wrote: > Date: Tue, 15 Oct 2024 15:17:24 +0200 > From: Paolo Bonzini > Subject: [PATCH 06/16] rust: do not use OnceLock for properties > X-Mailer: git-send-email 2.46.2 > > Properties are initialized lazily but always accessed within the big

Re: [PATCH] hw/arm: add Quanta GSZ bmc machine

2024-10-18 Thread Peter Maydell
On Mon, 7 Oct 2024 at 18:17, Titus Rwantare wrote: > > This patch adds the quanta-gsz-bmc target, a current Google machine of > the day. This machine will be used as a platform to enable features such > as the PECI bmc interface, and Intel eSPI virtual wire interface in > QEMU. > > Signed-off-by:

Re: [PATCH 07/16] rust: use std::os::raw instead of core::ffi

2024-10-18 Thread Zhao Liu
On Tue, Oct 15, 2024 at 03:17:25PM +0200, Paolo Bonzini wrote: > Date: Tue, 15 Oct 2024 15:17:25 +0200 > From: Paolo Bonzini > Subject: [PATCH 07/16] rust: use std::os::raw instead of core::ffi > X-Mailer: git-send-email 2.46.2 > > core::ffi::c_* types were introduced in Rust 1.64.0. Use the old

Re: [RFC PATCH 00/16] rust: allow older versions of rustc and bindgen

2024-10-18 Thread Paolo Bonzini
On 10/18/24 15:31, Daniel P. Berrangé wrote: On Tue, Oct 15, 2024 at 03:17:18PM +0200, Paolo Bonzini wrote: On top of this, the required version of bindgen is still too new for Debian 12 and Ubuntu 22.04. This is fixed by the last four patches. This is an RFC for two reasons. First, because i

Re: [PATCH] tests/qtest: Raise the ide-test timeout

2024-10-18 Thread Peter Maydell
On Tue, 15 Oct 2024 at 12:37, Peter Maydell wrote: > > The ide-test occasionally times out: on the system I run > vm-build-openbsd on, it usually takes about 18 seconds, but > occasionally hits the 60s timeout, likely when the host machine is > under heavy load. I have also seen this test hit its

Re: [RFC PATCH 00/16] rust: allow older versions of rustc and bindgen

2024-10-18 Thread Kevin Wolf
Am 18.10.2024 um 17:43 hat Paolo Bonzini geschrieben: > On 10/18/24 15:31, Daniel P. Berrangé wrote: > > On Tue, Oct 15, 2024 at 03:17:18PM +0200, Paolo Bonzini wrote: > > > On top of this, the required version of bindgen is still too new > > > for Debian 12 and Ubuntu 22.04. This is fixed by the

Re: [PATCH] Migration: Add trace points for vmstate handler insertion/removal

2024-10-18 Thread Peter Xu
On Fri, Oct 18, 2024 at 10:44:26AM -0400, Peter Xu wrote: > SaveStateEntry has lots of magics internally, on alias_id, get_id() being > able to overwrite the original idstr, compat fields, ID_ANY, and so on. It > may not be always clear that what all these fields are being registered for > some de

Re: [RFC PATCH] cli: add connect-gpios option

2024-10-18 Thread Octavian Purdila
On Fri, Oct 18, 2024 at 9:09 AM Peter Maydell wrote: > > On Fri, 18 Oct 2024 at 17:05, Daniel P. Berrangé wrote: > > > > On Fri, Oct 18, 2024 at 04:38:24PM +0100, Peter Maydell wrote: > > > On Thu, 10 Oct 2024 at 18:39, Octavian Purdila wrote: > > > > > > > > From: Valentin Ghita > > > > > > >

Re: [PATCH v2 5/6] virtio-gpu: Support asynchronous fencing

2024-10-18 Thread Dmitry Osipenko
On 10/18/24 08:28, Akihiko Odaki wrote: >> +static void virgl_write_context_fence(void *opaque, uint32_t ctx_id, >> +  uint32_t ring_idx, uint64_t fence) >> +{ >> +    VirtIOGPU *g = opaque; > > What about taking the BQL here instead of having a QEMUBH? That wi

[PATCH] configure: Replace literally printed '\n' with newline

2024-10-18 Thread Kevin Wolf
The idea here was to leave an empty line before the message, but by default, echo prints '\n' literally instead of interpreting it. Use a separate echo without parameter instead like in other places in the script. Fixes: 6fdc5bc173188f5e4942616b16d589500b874a15 Signed-off-by: Kevin Wolf --- conf

Re: [PATCH v6 0/3] Add support for the RAPL MSRs series

2024-10-18 Thread Daniel P . Berrangé
On Fri, Oct 18, 2024 at 02:25:26PM +0200, Igor Mammedov wrote: > On Wed, 16 Oct 2024 14:56:39 +0200 > "Anthony Harivel" wrote: > > > Hi Igor, > > > > Igor Mammedov, Oct 16, 2024 at 13:52: > > > On Wed, 22 May 2024 17:34:49 +0200 > > > Anthony Harivel wrote: > > > > > >> Dear maintainers, > >

Re: [RFC PATCH 00/16] rust: allow older versions of rustc and bindgen

2024-10-18 Thread Kevin Wolf
Am 15.10.2024 um 15:17 hat Paolo Bonzini geschrieben: > This includes a few fixes to the Rust build system machinery, and > removes constructs that were added or stabilized after version 1.63.0: Most of this series looks harmless in the sense that we need to write some workaround code in a single

Re: [PATCH] spapr: nested: Add support for DPDES SPR in GSB for TCG L0

2024-10-18 Thread Amit Machhiwal
Hi Harsh, Thanks for looking into this patch. My comments are below: On 2024/10/18 02:13 PM, Harsh Prateek Bora wrote: > Hi Amit, > > On 10/18/24 10:47, Harsh Prateek Bora wrote: > > Hi Amit, > > > > On 10/17/24 16:30, Amit Machhiwal wrote: > > > The DPDES support for doorbell emulation and han

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Fri, Oct 18, 2024 at 10:46:55AM +0100, Peter Maydell wrote: >> On Fri, 18 Oct 2024 at 10:01, Daniel P. Berrangé wrote: >> > >> > On Thu, Oct 17, 2024 at 01:29:35PM -0300, Fabiano Rosas wrote: >> > > Daniel P. Berrangé writes: >> > > >> > > > On Thu, Oct 17, 2024

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Thu, Oct 17, 2024 at 01:29:35PM -0300, Fabiano Rosas wrote: >> Daniel P. Berrangé writes: >> >> > On Thu, Oct 17, 2024 at 11:32:11AM -0300, Fabiano Rosas wrote: >> >> Recent changes to how we invoke the migration tests have >> >> (intentionally) caused them to no

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Daniel P . Berrangé
On Fri, Oct 18, 2024 at 10:51:03AM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > On Fri, Oct 18, 2024 at 10:46:55AM +0100, Peter Maydell wrote: > >> On Fri, 18 Oct 2024 at 10:01, Daniel P. Berrangé > >> wrote: > >> > > >> > On Thu, Oct 17, 2024 at 01:29:35PM -0300, Fabiano Rosa

Re: [PATCH] meson.build: Remove ncurses workaround for OpenBSD

2024-10-18 Thread Michael Tokarev
12.10.2024 06:38, Brad Smith wrote: meson.build: Remove ncurses workaround for OpenBSD OpenBSD 7.5 has upgraded to ncurses 6.4. Queued to qemu-trivial tree, thanks! /mjt

Re: [PATCH] stubs: remove stubs/qdev.c

2024-10-18 Thread Zhao Liu
On Fri, Oct 18, 2024 at 04:33:33PM +0200, Paolo Bonzini wrote: > Date: Fri, 18 Oct 2024 16:33:33 +0200 > From: Paolo Bonzini > Subject: [PATCH] stubs: remove stubs/qdev.c > X-Mailer: git-send-email 2.46.2 > > qapi_event_send_device_deleted is always included (together > with the rest of QAPI) in

Re: [PATCH] replace error_setg(&error_fatal, ...) with error_report()

2024-10-18 Thread Michael Tokarev
08.10.2024 01:27, Tudor Gheorghiu wrote: According to include/qapi/error.h: * Please don't error_setg(&error_fatal, ...), use error_report() and * exit(), because that's more obvious. Patch updates all instances of error_setg(&error_fatal, ...) with error_report(...), adds the explicit exit(1) a

  1   2   >