Re: [PULL 08/20] virtio-net: Add only one queue pair when realizing

2024-10-17 Thread Jason Wang
On Mon, Oct 14, 2024 at 11:16 PM Laurent Vivier wrote: > > On 14/10/2024 10:30, Laurent Vivier wrote: > > Hi Akihiko, > > > > On 04/06/2024 09:37, Jason Wang wrote: > >> From: Akihiko Odaki > >> > >> Multiqueue usage is not negotiated yet when realizing. If more than > >> one queue is added and t

Re: [PULL 08/20] virtio-net: Add only one queue pair when realizing

2024-10-17 Thread Laurent Vivier
On 17/10/2024 08:59, Jason Wang wrote: On Mon, Oct 14, 2024 at 11:16 PM Laurent Vivier wrote: On 14/10/2024 10:30, Laurent Vivier wrote: Hi Akihiko, On 04/06/2024 09:37, Jason Wang wrote: From: Akihiko Odaki Multiqueue usage is not negotiated yet when realizing. If more than one queue is

Re: [PULL 08/20] virtio-net: Add only one queue pair when realizing

2024-10-17 Thread Akihiko Odaki
On 2024/10/17 16:32, Laurent Vivier wrote: On 17/10/2024 08:59, Jason Wang wrote: On Mon, Oct 14, 2024 at 11:16 PM Laurent Vivier wrote: On 14/10/2024 10:30, Laurent Vivier wrote: Hi Akihiko, On 04/06/2024 09:37, Jason Wang wrote: From: Akihiko Odaki Multiqueue usage is not negotiated ye

Re: [PATCH v3 1/8] target/riscv: Add Ssdbltrp CSRs handling

2024-10-17 Thread Clément Léger
On 17/10/2024 10:35, Clément Léger wrote: > > > On 16/10/2024 11:40, LIU Zhiwei wrote: >> >> On 2024/10/14 19:22, Clément Léger wrote: >>> Add ext_ssdbltrp in RISCVCPUConfig and implement MSTATUS.SDT, >>> {H|M}ENVCFG.DTE and modify the availability of MTVAL2 based on the >>> presence of the Ss

Re: [PATCH] vhost-user: fix shared object return values

2024-10-17 Thread Albert Esteve
On Thu, Oct 17, 2024 at 10:44 AM Daniel P. Berrangé wrote: > > On Wed, Oct 16, 2024 at 11:06:06AM +0200, Albert Esteve wrote: > > VHOST_USER_BACKEND_SHARED_OBJECT_ADD and > > VHOST_USER_BACKEND_SHARED_OBJECT_REMOVE state > > in the spec that they return 0 for successful > > operations, non-zero ot

Re: [PULL 13/25] target/i386: convert CMPXCHG8B/CMPXCHG16B to new decoder

2024-10-17 Thread Paolo Bonzini
On Wed, Oct 16, 2024 at 6:37 PM Philippe Mathieu-Daudé wrote: > On s390x the cdrom-test generates: > > tcg/s390x/tcg-target.c.inc:1284:tgen_cmp2: code should not be reached Backend bug, sent "[PATCH] tcg/s390x: fix constraint for 32-bit TSTEQ/TSTNE" to fix it. Paolo

[PATCH] linux-user: Trace rt_sigprocmask's sigsets

2024-10-17 Thread Ilya Leoshkevich
Add a function for formatting target sigsets. It can be useful for other syscalls in the future, so put it into the beginning of strace.c. For simplicity, do not implement the strace's ~[] output syntax. Add a rt_sigprocmask return handler. Example outputs: 4072707 rt_sigprocmask(SIG_BLOCK,[

[PATCH] tcg/s390x: fix constraint for 32-bit TSTEQ/TSTNE

2024-10-17 Thread Paolo Bonzini
32-bit TSTEQ and TSTNE is subject to the same constraints as for 64-bit, but setcond_i32 and negsetcond_i32 were incorrectly using TCG_CT_CONST ("i") instead of TCG_CT_CONST_CMP ("C"). Adjust the constraint and make tcg_target_const_match use the same sequence as tgen_cmp2: first check if the cons

Re: [PULL 08/20] virtio-net: Add only one queue pair when realizing

2024-10-17 Thread Laurent Vivier
On 17/10/2024 11:07, Akihiko Odaki wrote: On 2024/10/17 16:32, Laurent Vivier wrote: On 17/10/2024 08:59, Jason Wang wrote: On Mon, Oct 14, 2024 at 11:16 PM Laurent Vivier wrote: On 14/10/2024 10:30, Laurent Vivier wrote: Hi Akihiko, On 04/06/2024 09:37, Jason Wang wrote: From: Akihiko Od

Re: [PATCH] vhost-user: fix shared object return values

2024-10-17 Thread Daniel P . Berrangé
On Thu, Oct 17, 2024 at 11:12:32AM +0200, Albert Esteve wrote: > On Thu, Oct 17, 2024 at 10:44 AM Daniel P. Berrangé > wrote: > > > > On Wed, Oct 16, 2024 at 11:06:06AM +0200, Albert Esteve wrote: > > > VHOST_USER_BACKEND_SHARED_OBJECT_ADD and > > > VHOST_USER_BACKEND_SHARED_OBJECT_REMOVE state >

Re: [PATCH] vhost-user: fix shared object return values

2024-10-17 Thread Albert Esteve
On Thu, Oct 17, 2024 at 11:18 AM Daniel P. Berrangé wrote: > > On Thu, Oct 17, 2024 at 11:12:32AM +0200, Albert Esteve wrote: > > On Thu, Oct 17, 2024 at 10:44 AM Daniel P. Berrangé > > wrote: > > > > > > On Wed, Oct 16, 2024 at 11:06:06AM +0200, Albert Esteve wrote: > > > > VHOST_USER_BACKEND_S

Re: [PATCH v2 1/5] hw/resettable: Add SOFT reset type

2024-10-17 Thread Peter Maydell
On Wed, 16 Oct 2024 at 22:24, Bernhard Beschow wrote: > > This is a preparation for the next patch. > > Signed-off-by: Bernhard Beschow > --- > include/hw/resettable.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/hw/resettable.h b/include/hw/resettable.h > index fd862f1e9f..0

Re: [PATCH v4 07/19] pc-bios/s390-ccw: Remove panics from ISO IPL path

2024-10-17 Thread Thomas Huth
On 17/10/2024 03.47, jro...@linux.ibm.com wrote: From: Jared Rossi Remove panic-on-error from IPL ISO El Torito specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code. Signed-off-by: Jared Rossi --- ... diff

Re: [PATCH] vhost-user: fix shared object return values

2024-10-17 Thread Stefano Garzarella
On Wed, Oct 16, 2024 at 11:06:06AM +0200, Albert Esteve wrote: VHOST_USER_BACKEND_SHARED_OBJECT_ADD and VHOST_USER_BACKEND_SHARED_OBJECT_REMOVE state in the spec that they return 0 for successful operations, non-zero otherwise. However, implementation relies on the return types of the virtio-dmab

Re: [PATCH v2 3/8] target/riscv: Implement Ssdbltrp exception handling

2024-10-17 Thread Clément Léger
On 17/10/2024 06:29, Alistair Francis wrote: > On Mon, Oct 14, 2024 at 5:43 PM Clément Léger wrote: >> >> >> >> On 11/10/2024 05:22, Alistair Francis wrote: >>> On Wed, Sep 25, 2024 at 9:59 PM Clément Léger wrote: When the Ssdbltrp ISA extension is enabled, if a trap happens in S-mod

Re: [PATCH] crypto/hash-afalg: Fix broken build

2024-10-17 Thread Markus Armbruster
Cédric Le Goater writes: > On 10/17/24 08:47, Markus Armbruster wrote: >> Fux build broken by semantic conflict with commit >> 8f525028bc6 (qapi/crypto: Rename QCryptoAFAlg to QCryptoAFAlgo). >> Fixes: 90c3dc60735a (crypto/hash-afalg: Implement new hash API) >> Signed-off-by: Markus Armbruster >

RE: [PATCH v2] intel_iommu: Introduce property "x-stale-tm" to control Transient Mapping (TM) field

2024-10-17 Thread Duan, Zhenzhong
>-Original Message- >From: Jason Wang >Subject: Re: [PATCH v2] intel_iommu: Introduce property "x-stale-tm" to control >Transient Mapping (TM) field > >On Thu, Oct 10, 2024 at 3:57 PM Zhenzhong Duan >wrote: >> >> VT-d spec removed Transient Mapping (TM) field from second-level page-tabl

Re: [PATCH] vhost-user: fix shared object return values

2024-10-17 Thread Albert Esteve
Albert Esteve Senior Software Engineer Red Hat aest...@redhat.com On Thu, Oct 17, 2024 at 9:38 AM Stefano Garzarella wrote: > > On Wed, Oct 16, 2024 at 11:06:06AM +0200, Albert Esteve wrote: > >VHOST_USER_BACKEND_SHARED_OBJECT_ADD and > >VHOST_USER_BACKEND_SHARED_OBJECT_REMOVE state > >in th

Re: [PATCH v3 1/8] target/riscv: Add Ssdbltrp CSRs handling

2024-10-17 Thread Clément Léger
On 16/10/2024 11:40, LIU Zhiwei wrote: > > On 2024/10/14 19:22, Clément Léger wrote: >> Add ext_ssdbltrp in RISCVCPUConfig and implement MSTATUS.SDT, >> {H|M}ENVCFG.DTE and modify the availability of MTVAL2 based on the >> presence of the Ssdbltrp ISA extension. >> >> Signed-off-by: Clément Lég

Re: [PATCH v4 09/19] pc-bios/s390-ccw: Remove panics from SCSI IPL path

2024-10-17 Thread Thomas Huth
On 17/10/2024 03.47, jro...@linux.ibm.com wrote: From: Jared Rossi Remove panic-on-error from virtio-scsi IPL specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code. Signed-off-by: Jared Rossi --- pc-bios/s39

Re: [PATCH] tcg/s390x: fix constraint for 32-bit TSTEQ/TSTNE

2024-10-17 Thread Paolo Bonzini
On 10/17/24 12:00, Peter Maydell wrote: On Thu, 17 Oct 2024 at 10:14, Paolo Bonzini wrote: 32-bit TSTEQ and TSTNE is subject to the same constraints as for 64-bit, but setcond_i32 and negsetcond_i32 were incorrectly using TCG_CT_CONST ("i") instead of TCG_CT_CONST_CMP ("C"). Adjust the constr

[PATCH v2] hw/riscv: Add Microblaze V 32bit virt board

2024-10-17 Thread Sai Pavan Boddu
Add a basic board with interrupt controller (intc), timer, serial (uartlite), small memory called LMB@0 (128kB) and DDR@0x8000 (configured via command line eg. -m 2g). This is basic configuration which matches HW generated out of AMD Vivado (design tools). But initial configuration is going bey

Re: [PATCH v2] tests/functional: Convert most Aspeed machine tests

2024-10-17 Thread Thomas Huth
On 17/10/2024 09.09, Cédric Le Goater wrote: On 10/17/24 08:06, Thomas Huth wrote: On 16/10/2024 22.38, Cédric Le Goater wrote: This is a simple conversion of the tests with some cleanups and adjustments to match the new test framework. Replace the zephyr image MD5 hashes with SHA256 hashes whi

Re: [PATCH] crypto/hash-afalg: Fix broken build

2024-10-17 Thread Daniel P . Berrangé
On Thu, Oct 17, 2024 at 08:54:04AM +0200, Cédric Le Goater wrote: > On 10/17/24 08:47, Markus Armbruster wrote: > > Fux build broken by semantic conflict with commit > > 8f525028bc6 (qapi/crypto: Rename QCryptoAFAlg to QCryptoAFAlgo). > > > > Fixes: 90c3dc60735a (crypto/hash-afalg: Implement new h

Re: [PATCH v6] i386/cpu: fixup number of addressable IDs for logical processors in the physical package

2024-10-17 Thread Xiaoyao Li
On 10/14/2024 11:36 AM, Zhao Liu wrote: On 10/9/2024 11:56 AM, Chuang Xu wrote: When QEMU is started with: -cpu host,migratable=on,host-cache-info=on,l3-cache=off -smp 180,sockets=2,dies=1,cores=45,threads=2 On Intel platform: CPUID.01H.EBX[23:16] is defined as "max number of addressable IDs fo

Re: [PATCH v4 2/2] tpm_emulator: Read control channel response in 2 passes

2024-10-17 Thread Daniel P . Berrangé
On Wed, Oct 16, 2024 at 01:51:29PM -0400, Stefan Berger wrote: > Error responses from swtpm are typically only 4 bytes long with the > exception of a few commands that return more bytes. Therefore, read the > entire response in 2 steps and stop if the first few bytes indicate an > error response wi

Re: [PATCH] meson.build: Remove ncurses workaround for OpenBSD

2024-10-17 Thread Daniel P . Berrangé
Cc'ing qemu-trivial On Fri, Oct 11, 2024 at 11:38:55PM -0400, Brad Smith wrote: > meson.build: Remove ncurses workaround for OpenBSD > > OpenBSD 7.5 has upgraded to ncurses 6.4. > > Signed-off-by: Brad Smith > --- > meson.build | 2 +- > ui/curses.c | 2 +- > 2 files changed, 2 insertions(+),

Re: [PATCH 0/1] Insert LibSPDM in QEMU enabling in-tree compilation

2024-10-17 Thread Daniel P . Berrangé
On Thu, Oct 17, 2024 at 02:00:35PM +1000, Alistair Francis wrote: > On Thu, Oct 17, 2024 at 2:35 AM htafr wrote: > > > > (I) Summary > > === > > > > This patch is the beginning of the support of the Security Protocol and > > D

Re: [PATCH] tcg/s390x: fix constraint for 32-bit TSTEQ/TSTNE

2024-10-17 Thread Peter Maydell
On Thu, 17 Oct 2024 at 10:14, Paolo Bonzini wrote: > > 32-bit TSTEQ and TSTNE is subject to the same constraints as > for 64-bit, but setcond_i32 and negsetcond_i32 were incorrectly > using TCG_CT_CONST ("i") instead of TCG_CT_CONST_CMP ("C"). > > Adjust the constraint and make tcg_target_const_ma

Re: [PATCH 10/16] rust: introduce alternative implementation of offset_of!

2024-10-17 Thread Paolo Bonzini
On Thu, Oct 17, 2024 at 7:35 AM Junjie Mao wrote: > Paolo Bonzini writes: > > offset_of! was stabilized in Rust 1.77.0. Use an alternative implemenation > > that was found on the Rust forums, and whose author agreed to license as > > MIT for use in QEMU. > > > > The alternative allows only one l

Re: [PATCH] vhost-user: fix shared object return values

2024-10-17 Thread Daniel P . Berrangé
On Wed, Oct 16, 2024 at 11:06:06AM +0200, Albert Esteve wrote: > VHOST_USER_BACKEND_SHARED_OBJECT_ADD and > VHOST_USER_BACKEND_SHARED_OBJECT_REMOVE state > in the spec that they return 0 for successful > operations, non-zero otherwise. However, > implementation relies on the return types > of the v

Re: [PATCH v6] i386/cpu: fixup number of addressable IDs for logical processors in the physical package

2024-10-17 Thread Zhao Liu
On Thu, Oct 17, 2024 at 04:18:06PM +0800, Xiaoyao Li wrote: > Date: Thu, 17 Oct 2024 16:18:06 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH v6] i386/cpu: fixup number of addressable IDs for > logical processors in the physical package > > On 10/14/2024 11:36 AM, Zhao Liu wrote: > > > > > On 10/

Re: [PATCH RFC V5 00/30] Support of Virtual CPU Hotplug for ARMv8 Arch

2024-10-17 Thread Gavin Shan
Hi Salil, The issues reported against on RFCv3 are still existing. I'm listing them as below. (1) Guest fails to start due to SVE initialization /home/gavin/sandbox/qemu.main/build/qemu-system-aarch64 \ -accel kvm -machine virt,gic-version=host,nvdimm=on \

Re: [PATCH v2] tests/functional: Convert most Aspeed machine tests

2024-10-17 Thread Cédric Le Goater
On 10/17/24 08:06, Thomas Huth wrote: On 16/10/2024 22.38, Cédric Le Goater wrote: This is a simple conversion of the tests with some cleanups and adjustments to match the new test framework. Replace the zephyr image MD5 hashes with SHA256 hashes while at it. The SDK tests depend on a ssh class

Re: [PATCH] migration/dirtyrate: Silence warning about strcpy() on OpenBSD

2024-10-17 Thread Yong Huang
On Thu, Oct 17, 2024 at 1:40 PM Thomas Huth wrote: > On 16/10/2024 18.22, Daniel P. Berrangé wrote: > > On Wed, Oct 16, 2024 at 06:07:12PM +0200, Thomas Huth wrote: > >> The linker on OpenBSD complains: > >> > >> ld: warning: dirtyrate.c:447 (../src/migration/dirtyrate.c:447)(...): > >> warni

Re: [PATCH v2] intel_iommu: Introduce property "x-stale-tm" to control Transient Mapping (TM) field

2024-10-17 Thread Jason Wang
On Thu, Oct 10, 2024 at 3:57 PM Zhenzhong Duan wrote: > > VT-d spec removed Transient Mapping (TM) field from second-level page-tables > and treat the field as Reserved(0) since revision 3.2. > > Changing the field as reserved(0) will break backward compatibility, so > introduce a property "x-stal

Re: [PATCH v4 08/19] pc-bios/s390-ccw: Remove panics from ECKD IPL path

2024-10-17 Thread Thomas Huth
On 17/10/2024 03.47, jro...@linux.ibm.com wrote: From: Jared Rossi Remove panic-on-error from ECKD block device IPL specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code. Signed-off-by: Jared Rossi --- pc-bi

Re: [PATCH] migration/dirtyrate: Silence warning about strcpy() on OpenBSD

2024-10-17 Thread Peter Maydell
On Thu, 17 Oct 2024 at 06:41, Thomas Huth wrote: > > On 16/10/2024 18.22, Daniel P. Berrangé wrote: > > On Wed, Oct 16, 2024 at 06:07:12PM +0200, Thomas Huth wrote: > >> The linker on OpenBSD complains: > >> > >> ld: warning: dirtyrate.c:447 (../src/migration/dirtyrate.c:447)(...): > >> warnin

Re: [PATCH] vhost-user: fix shared object return values

2024-10-17 Thread Daniel P . Berrangé
On Thu, Oct 17, 2024 at 11:28:56AM +0200, Albert Esteve wrote: > On Thu, Oct 17, 2024 at 11:18 AM Daniel P. Berrangé > wrote: > > > > On Thu, Oct 17, 2024 at 11:12:32AM +0200, Albert Esteve wrote: > > > On Thu, Oct 17, 2024 at 10:44 AM Daniel P. Berrangé > > > wrote: > > > > > > > > On Wed, Oct

Re: [PATCH] vhost-user: fix shared object return values

2024-10-17 Thread Stefano Garzarella
On Thu, Oct 17, 2024 at 10:27:30AM +0200, Albert Esteve wrote: Albert Esteve Senior Software Engineer Red Hat aest...@redhat.com On Thu, Oct 17, 2024 at 9:38 AM Stefano Garzarella wrote: On Wed, Oct 16, 2024 at 11:06:06AM +0200, Albert Esteve wrote: >VHOST_USER_BACKEND_SHARED_OBJECT_ADD

Re: [PULL 08/20] virtio-net: Add only one queue pair when realizing

2024-10-17 Thread Akihiko Odaki
On 2024/10/17 18:17, Laurent Vivier wrote: On 17/10/2024 11:07, Akihiko Odaki wrote: On 2024/10/17 16:32, Laurent Vivier wrote: On 17/10/2024 08:59, Jason Wang wrote: On Mon, Oct 14, 2024 at 11:16 PM Laurent Vivier wrote: On 14/10/2024 10:30, Laurent Vivier wrote: Hi Akihiko, On 04/06/202

Re: [PATCH v4 1/2] tpm: Use new ptm_cap_n structure for PTM_GET_CAPABILITY

2024-10-17 Thread Daniel P . Berrangé
On Wed, Oct 16, 2024 at 01:51:28PM -0400, Stefan Berger wrote: > Use the new ptm_cap_n structure for getting the PTM_GET_CAPABILITY response > from swtpm. Previously only 17 bits could possibly have been set in ptm_cap > (=uint64_t) in big endian order and those bits are now found in the 2nd ^^

Re: [PULL 00/25] x86 and KVM patches for 2024-10-15

2024-10-17 Thread Peter Maydell
On Tue, 15 Oct 2024 at 15:17, Paolo Bonzini wrote: > > The following changes since commit aa54f5be44be786636a5d51cc1612ad208a24849: > > tests: update lcitool to fix freebsd py311-yaml rename (2024-10-14 15:54:24 > +0100) > > are available in the Git repository at: > > https://gitlab.com/bonzi

Re: [PATCH v4 11/19] pc-bios/s390-ccw: Remove panics from Netboot IPL path

2024-10-17 Thread Thomas Huth
On 17/10/2024 03.47, jro...@linux.ibm.com wrote: From: Jared Rossi Remove panic-on-error from Netboot specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code. Signed-off-by: Jared Rossi --- pc-bios/s390-ccw/s3

[PATCH] spapr: nested: Add support for DPDES SPR in GSB for TCG L0

2024-10-17 Thread Amit Machhiwal
The DPDES support for doorbell emulation and handling for KVM on PAPR guests was added in Linux via [1]. Subsequently, a new GSB element for DPDES was added in Linux; the same has been missing in QEMU L0. Add support for DPDES register's APIv2 GSB element and required handling in `spapr_nested.c`.

Re: [PATCH v2 3/6] target/riscv: Add support for Control Transfer Records extension CSRs.

2024-10-17 Thread Rajnesh Kanwal
On Tue, Aug 27, 2024 at 10:28 AM Frank Chang wrote: > > Rajnesh Kanwal 於 2024年6月19日 週三 下午11:27寫道: > > > > This commit adds support for [m|s|vs]ctrcontrol, sctrstatus and > > sctrdepth CSRs handling. > > > > Signed-off-by: Rajnesh Kanwal > > --- > > target/riscv/cpu.h | 5 ++ > > target/ri

Re: [PATCH v4 19/19] tests/qtest: Add s390x boot order tests to cdrom-test.c

2024-10-17 Thread Thomas Huth
On 17/10/2024 03.47, jro...@linux.ibm.com wrote: From: Jared Rossi Add two new qtests to verify that a valid IPL device can successfully boot after failed IPL attempts from one or more invalid devices. cdrom-test/as-fallback-device: Defines the primary boot target as a device that is invalid f

Re: possible deprecation and removal of some old QEMU Arm machine types (pxa2xx, omap, sa1110)

2024-10-17 Thread Peter Maydell
On Tue, 15 Oct 2024 at 19:12, Guenter Roeck wrote: > Please let me know if https://github.com/groeck/linux-test-downloads.git > meets your needs. For now I added 'collie'. I'll add more after it is > in a state that is useful for you. Yes, that's great, exactly what we need. I've put together a Q

[PATCH 0/2] linux-user/ppc: Fix sigmask endianness issue in sigreturn

2024-10-17 Thread Ilya Leoshkevich
Hi, This series fixes an issue where an emulated ppc64le process running on s390x attempting to wake up a sigwait()ing thread would instead terminate itself. Patch 1 is the fix, patch 2 is a testcase extracted from the real-world scenario. Best regards, Ilya Ilya Leoshkevich (2): linux-user/pp

[PATCH 1/2] linux-user/ppc: Fix sigmask endianness issue in sigreturn

2024-10-17 Thread Ilya Leoshkevich
do_setcontext() copies the target sigmask without endianness handling and then uses target_to_host_sigset_internal(), which expects a byte-swapped one. Use target_to_host_sigset() instead. Fixes: bcd4933a23f1 ("linux-user: ppc signal handling") Signed-off-by: Ilya Leoshkevich --- linux-user/ppc/

[PATCH 2/2] tests/tcg: Test that sigreturn() does not corrupt the signal mask

2024-10-17 Thread Ilya Leoshkevich
Add a small test to prevent regressions. Signed-off-by: Ilya Leoshkevich --- tests/tcg/multiarch/sigreturn-sigmask.c | 51 + 1 file changed, 51 insertions(+) create mode 100644 tests/tcg/multiarch/sigreturn-sigmask.c diff --git a/tests/tcg/multiarch/sigreturn-sigmask.c

Re: [PATCH v4 16/19] s390x: Rebuild IPLB for SCSI device directly from DIAG308

2024-10-17 Thread Thomas Huth
On 17/10/2024 03.47, jro...@linux.ibm.com wrote: From: Jared Rossi Because virtio-scsi type devices use a non-architected IPLB pbt code they cannot be set and stored normally. Instead, the IPLB must be rebuilt during re-ipl. As s390x does not natively support multiple boot devices, the devno f

Re: [QEMU PATCH] hw/cxl/cxl-mailbox-util: Fix output buffer index update when retrieving DC extents

2024-10-17 Thread Jonathan Cameron via
On Tue, 15 Oct 2024 11:51:26 -0700 nifan@gmail.com wrote: > From: Fan Ni > > In the function of retrieving DC extents (cmd_dcd_get_dyn_cap_ext_list), > the output buffer index was not correctly updated while iterating the > extent list on the device, leaving the extents returned incorrect ex

[PATCH v2 04/31] block: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- block.c | 8 block/blkdebug.c | 6 +++--- block/blkio.c| 2 +- block/blklogwrites.c | 4

[PATCH v2 00/31] include: move include/qapi/qmp/ to include/qobject/

2024-10-17 Thread Daniel P . Berrangé
To repeat the 1st patch commit message... The general expectation is that header files should follow the same file/path naming scheme as the corresponding source file. There are various historical exceptions to this practice in QEMU, with one of the most notable being the include/qapi/qmp/ directo

[PATCH v2 24/31] target: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- target/arm/arm-qmp-cmds.c | 2 +- target/i386/cpu-apic.c| 2 +- target/i386/cpu-sysemu.c | 2 +- target/i386/monitor.c | 2 +- targe

[PATCH v2 17/31] qom: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- qom/object.c| 10 +- qom/object_interfaces.c | 6 +++--- qom/qom-hmp-cmds.c | 4 ++-- qom/qom-qmp-cmds.c | 2 +- 4 files changed, 11 insertions(+), 11 delet

[PATCH v2 20/31] scsi: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- scsi/qemu-pr-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scsi/qemu-pr-helper.c b/scsi/qemu-pr-helper.c index c6c6347e9b..b69dd982d6 100644 --- a/scsi/qemu-p

[PATCH v2 23/31] system: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- system/device_tree.c | 2 +- system/dirtylimit.c| 2 +- system/qdev-monitor.c | 6 +++--- system/rtc.c | 1 + system/runstate-hmp-cmds.c | 2 +- system/vl.c

[PATCH v2 08/31] dump: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- dump/dump-hmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dump/dump-hmp-cmds.c b/dump/dump-hmp-cmds.c index d9340427c3..21023db6fd 100644 --- a/dump/dump-hmp-

[PATCH v2 27/31] ui: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- ui/ui-hmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/ui-hmp-cmds.c b/ui/ui-hmp-cmds.c index 26c8ced1f2..980a8bbc51 100644 --- a/ui/ui-hmp-cmds.c +++ b/ui/

[PATCH v2 30/31] qga: remove unused qerror.h header

2024-10-17 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- qga/commands-bsd.c | 1 - qga/commands-linux.c | 1 - qga/commands-posix.c | 1 - 3 files changed, 3 deletions(-) diff --git a/qga/commands-bsd.c b/qga/commands-bsd.c index 9ce48af311..94ff6fee6a 100644 --- a/qga/commands-bsd.c +++ b/qga/commands-bsd.c @@

[PATCH v2 26/31] trace: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- trace/trace-hmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trace/trace-hmp-cmds.c b/trace/trace-hmp-cmds.c index d38dd600de..45f4335ff5 100644 --- a/trace/tr

[PATCH v2 06/31] chardev: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- chardev/char-hmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chardev/char-hmp-cmds.c b/chardev/char-hmp-cmds.c index 287c2b1bcd..8e9e1c1c02 100644 --- a/chard

[PATCH v2 19/31] scripts: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- scripts/qapi/commands.py | 6 +++--- scripts/qapi/events.py | 2 +- scripts/qapi/introspect.py | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/scripts/qapi/comm

[PATCH v2 07/31] docs: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- docs/devel/qapi-code-gen.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst index 583207a8ec..ea26b8b473

[PATCH v2 10/31] include: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- include/block/qdict.h | 2 +- include/qobject/qbool.h | 2 +- include/qobject/qdict.h | 2 +- include/qobject/qlist.h | 2 +- include/qobject/qnull.h | 2 +- include/qobject/qnu

Re: [PULL 00/33] Endianness cleanup patches for 2024-10-15

2024-10-17 Thread Peter Maydell
On Tue, 15 Oct 2024 at 16:47, Philippe Mathieu-Daudé wrote: > > The following changes since commit c155d13167c6ace099e351e28125f9eb3694ae27: > > Merge tag 'chr-pull-request' of https://gitlab.com/marcandre.lureau/qemu > into staging (2024-10-15 10:30:43 +0100) > > are available in the Git repos

[PATCH v2 15/31] qga: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- qga/guest-agent-core.h | 2 +- qga/main.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/qga/guest-agent-core.h b/qga/guest-agent-core.h index b4e7c5

Re: [PATCH v4 17/19] pc-bios/s390x: Enable multi-device boot loop

2024-10-17 Thread Thomas Huth
On 17/10/2024 03.47, jro...@linux.ibm.com wrote: From: Jared Rossi Allow attempts to boot from multiple IPL devices. If the first device fails to IPL, select the pre-built IPLB for the next device in the boot order and attempt to IPL from it. Continue this process until IPL is successful or the

[PATCH v2 28/31] util: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- util/keyval.c | 6 +++--- util/qemu-config.c | 4 ++-- util/qemu-option.c | 8 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/util/keyval.c b/util/keyval.c ind

[PATCH v2 21/31] stats: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- stats/stats-hmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stats/stats-hmp-cmds.c b/stats/stats-hmp-cmds.c index 1f91bf8bd5..b93b471b1b 100644 --- a/stats/st

[PATCH v2 16/31] qobject: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- qobject/block-qdict.c | 8 qobject/json-parser-int.h | 2 +- qobject/json-parser.c | 12 ++-- qobject/json-writer.c | 2 +- qobject/qbool.c|

[PATCH v2 18/31] replay: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- replay/replay-debugging.c | 2 +- replay/replay-snapshot.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/replay/replay-debugging.c b/replay/replay-debugging.c inde

[PATCH] pcie: enable Extended tag field capability

2024-10-17 Thread Marcin Juszkiewicz
pci_set_long(exp_cap + PCI_EXP_LNKCAP, (port << PCI_EXP_LNKCAP_PN_SHIFT) | --- base-commit: f774a677507966222624a9b2859f06ede7608100 change-id: 20241017-pcie-extend-a6a9de74dbd0 Best regards, -- Marcin Juszkiewicz

Re: [PATCH 0/1] Insert LibSPDM in QEMU enabling in-tree compilation

2024-10-17 Thread Ágatha Freitas
On Thu, Oct 17, 2024 at 7:00 AM Daniel P. Berrangé wrote: > On Thu, Oct 17, 2024 at 02:00:35PM +1000, Alistair Francis wrote: > > On Thu, Oct 17, 2024 at 2:35 AM htafr wrote: > > > > > > (I) Summary > > > > === > > > > > > T

Re: [PATCH 0/1] Insert LibSPDM in QEMU enabling in-tree compilation

2024-10-17 Thread Daniel P . Berrangé
On Thu, Oct 17, 2024 at 10:37:21AM -0300, Ágatha Freitas wrote: > On Thu, Oct 17, 2024 at 7:00 AM Daniel P. Berrangé > wrote: > > > On Thu, Oct 17, 2024 at 02:00:35PM +1000, Alistair Francis wrote: > > > On Thu, Oct 17, 2024 at 2:35 AM htafr wrote: > > > > > > > > (I) Summary > > > > > > ===

[PATCH v2 05/31] backends: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- backends/cryptodev-hmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backends/cryptodev-hmp-cmds.c b/backends/cryptodev-hmp-cmds.c index 4f7220bb13..01396d227c

[PATCH v2 31/31] system: remove unused qerror.h header

2024-10-17 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- system/rtc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/system/rtc.c b/system/rtc.c index e3bc2095f9..216d2aee3a 100644 --- a/system/rtc.c +++ b/system/rtc.c @@ -25,7 +25,6 @@ #include "qemu/osdep.h" #include "qemu/cutils.h" #include "qapi/error.h"

[PATCH v2 22/31] stubs: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- stubs/qmp-command-available.c | 2 +- stubs/qmp-quit.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/stubs/qmp-command-available.c b/stubs/qmp-command-

[PATCH v2 01/31] include: move include/qapi/qmp/ to include/qobject/

2024-10-17 Thread Daniel P . Berrangé
The general expectation is that header files should follow the same file/path naming scheme as the corresponding source file. There are various historical exceptions to this practice in QEMU, with one of the most notable being the include/qapi/qmp/ directory. Most of the headers there correspond to

[PATCH v2 03/31] authz: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- authz/listfile.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/authz/listfile.c b/authz/listfile.c index 45a60e987d..d31d9103f7 100644 --- a/authz/listfile.c +++ b

[PATCH v2 02/31] audio: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- audio/audio-hmp-cmds.c | 2 +- audio/audio.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/audio/audio-hmp-cmds.c b/audio/audio-hmp-cmds.c index c9608b715b

[PATCH v2 11/31] migration: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- migration/dirtyrate.c | 2 +- migration/migration-hmp-cmds.c | 2 +- migration/migration.c | 2 +- migration/migration.h | 2 +- migration/options.c|

[PATCH v2 09/31] hw: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- hw/arm/aspeed_ast27x0.c | 2 +- hw/arm/mps2-tz.c| 2 +- hw/arm/mps2.c | 2 +- hw/arm/mps3r.c | 2 +- hw/arm/sbsa-ref.c

[PATCH v2 13/31] net: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- net/net-hmp-cmds.c | 2 +- net/net.c | 2 +- net/slirp.c| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/net-hmp-cmds.c b/net/net-hmp-cmds.c index

[PATCH v2 12/31] monitor: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- monitor/hmp-cmds-target.c | 2 +- monitor/hmp-cmds.c | 2 +- monitor/hmp.c | 4 ++-- monitor/monitor-internal.h | 4 ++-- monitor/monitor.c | 2 +- monitor/qe

[PATCH v2 25/31] tests: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- tests/qtest/adm1266-test.c| 4 ++-- tests/qtest/adm1272-test.c| 4 ++-- tests/qtest/ahci-test.c | 2 +- tests/qtest/arm-cpu-features.c

[PATCH v2 29/31] qapi: remove header file compatibility symlinks

2024-10-17 Thread Daniel P . Berrangé
All code is converted to the new 'qobject/' import path, so the temporary header file compatibility symlinks are now redundant. Signed-off-by: Daniel P. Berrangé --- qapi/qmp/dispatch.h| 1 - qapi/qmp/json-parser.h | 1 - qapi/qmp/json-writer.h | 1 - qapi/qmp/qbool.h | 1 - qapi/qmp/q

[PATCH v2 14/31] qapi: adapt to new import path for qobject data type headers

2024-10-17 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- qapi/qapi-clone-visitor.c | 2 +- qapi/qapi-dealloc-visitor.c | 2 +- qapi/qapi-forward-visitor.c | 14 +++--- qapi/qmp-dispatch.c | 8 qapi/qmp-event.

Re: [PATCH v3 7/7] i386/cpu: add has_caches flag to check smp_cache configuration

2024-10-17 Thread Jonathan Cameron via
RESEND as rejected by server (header issue, hopefully fixed) On Sat, 12 Oct 2024 18:44:29 +0800 Zhao Liu wrote: > From: Alireza Sanaee > > Add has_caches flag to SMPCompatProps, which helps in avoiding > extra checks for every single layer of caches in x86 (and ARM in > future). > > Signed-of

Re: [PATCH v3 1/7] hw/core: Make CPU topology enumeration arch-agnostic

2024-10-17 Thread Jonathan Cameron via
RESEND (sorry for noise). Quotes in email address issue meant the server bounced it. On Thu, 17 Oct 2024 09:52:27 +0100 Jonathan Cameron wrote: > On Sat, 12 Oct 2024 18:44:23 +0800 > Zhao Liu wrote: > > > Cache topology needs to be defined based on CPU topology levels. Thus, > > define CPU top

Re: [PATCH v3 0/7] Introduce SMP Cache Topology

2024-10-17 Thread Jonathan Cameron via
RESEND (again, sorry) as didn't reach list. Issue some stray " in various email addresses. On Sat, 12 Oct 2024 18:44:22 +0800 Zhao Liu wrote: > Hi all, > > Compared with v2 [1], the changes in v3 are quite minor, and most of > patches (except for patch 1 and 7) have received Jonathan’s R/b (tha

Re: [PATCH v4 0/2] riscv: char: Avoid dropped charecters

2024-10-17 Thread Thomas Huth
On 10/09/2024 06.54, Alistair Francis wrote: This series fixes: https://gitlab.com/qemu-project/qemu/-/issues/2114 This converts the RISC-V charecter device callers of qemu_chr_fe_write() to either use qemu_chr_fe_write_all() or to call qemu_chr_fe_write() async and act on the return value. v4:

Re: [PATCH v4 7/8] tests/unit/test-char: add unit test for the `mux-be` multiplexer

2024-10-17 Thread Roman Penyaev
Hi Marc-André, On Wed, Oct 16, 2024 at 1:36 PM Marc-André Lureau wrote: > > Hi > > On Wed, Oct 16, 2024 at 2:28 PM Roman Penyaev wrote: > > > > The test is trivial: several backends, 1 `mux-be`, 1 frontend > > do the buffer write and read. Pipe is used for EAGAIN verification. > > > > Signed-off

Re: [PATCH] hw/sd/omap_mmc: Don't use sd_cmd_type_t

2024-10-17 Thread Guenter Roeck
On 10/17/24 09:27, Peter Maydell wrote: In commit 1ab08790bb75e4 we did some refactoring of the SD card implementation, which included a rearrangement of the sd_cmd_type_t enum values. Unfortunately we didn't notice that this enum is not used solely inside the SD card model itself, but is also u

Re: [PATCH v4 5/6] migration: Support periodic RAMBlock dirty bitmap sync

2024-10-17 Thread Peter Xu
On Thu, Oct 17, 2024 at 02:42:54PM +0800, yong.hu...@smartx.com wrote: > +void cpu_throttle_dirty_sync_timer_tick(void *opaque) > +{ > +static uint64_t prev_sync_cnt; We may need to reset this in case migration got cancelled and invoked again, to make sure it keeps working in the 2nd run. > +

Re: [Stable-9.1.1 00/49] Patch Round-up for stable 9.1.1, freeze on 2024-10-16 (frozen)

2024-10-17 Thread Michael Tokarev
On 17.10.2024 20:47, Paolo Bonzini wrote: My next pull request includes a few more: https://gitlab.com/bonzini/qemu/-/commit/15d955975bd484c2c66af0d6daaa02a7d04d2256.patch https://gitlab.com/bonzini/qemu/-/commit/64e0e63ea16aa0122dc0c41a0679da0ae4616208.patch https://gitlab.com/bonzini/qemu/-/c

Re: [PATCH] Fix calculation of minimum in colo_compare_tcp

2024-10-17 Thread Stefan Weil via
It looks like nobody has sent a pull request for this fix up to now. Is it trivial enough for qemu-trivial? And maybe qemu-stable could also apply it to older versions. Stefan W. Am 10.09.24 um 04:38 schrieb Zhang, Chen: -Original Message- From: Stefan Weil Sent: Tuesday, September 10

Re: [PATCH v6 09/12] migration/multifd: Enable DSA offloading in multifd sender path.

2024-10-17 Thread Fabiano Rosas
Yichen Wang writes: > From: Hao Xiang > > Multifd sender path gets an array of pages queued by the migration > thread. It performs zero page checking on every page in the array. > The pages are classfied as either a zero page or a normal page. This > change uses Intel DSA to offload the zero pag

  1   2   3   >