[PATCH 0/2] dockerfiles, gitlab-ci: add CI job using nightly Rust

2024-10-07 Thread Paolo Bonzini
Right now only Fedora 39 and 40 (with updates) are able to compile QEMU with Rust enabled. Full CI enablement requires further work to reduce the minimum supported version of the compiler, and is not a requirement until Rust is turned on by default. Since a CI job based on nightly Rust will be nee

[PATCH 1/2] dockerfiles: add a Dockerfile using a nightly Rust toolchain

2024-10-07 Thread Paolo Bonzini
This will be useful in order to test QEMU's Rust code with nightly clippy. It can also be used to check that the code builds, until the minimum supported Rust version is lowered enough to allow enabling Rust in other Dockerfiles too. Use a separate container, instead of the Fedora one, to avoid t

[PATCH 2/2] gitlab-ci: add Rust-enabled CI job

2024-10-07 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- .gitlab-ci.d/buildtest.yml | 13 + .gitlab-ci.d/containers.yml | 6 ++ 2 files changed, 19 insertions(+) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index 669c980c4b4..a92e731d6af 100644 --- a/.gitlab-ci.d/buildtest.yml

Re: [PATCH 16/16] tests: add basic -display dbus Map.Unix test

2024-10-07 Thread Akihiko Odaki
On 2024/10/07 21:42, Marc-André Lureau wrote: Hi On Sat, Oct 5, 2024 at 12:32 PM Akihiko Odaki wrote: On 2024/10/03 20:22, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Only check we eventually get a shared memory scanout. Signed-off-by: Marc-André Lureau --- tests/qtest/

[PATCH] hw/arm: add Quanta GSZ bmc machine

2024-10-07 Thread Titus Rwantare
This patch adds the quanta-gsz-bmc target, a current Google machine of the day. This machine will be used as a platform to enable features such as the PECI bmc interface, and Intel eSPI virtual wire interface in QEMU. Signed-off-by: Titus Rwantare --- hw/arm/npcm7xx_boards.c | 140 ++

[PATCH v3 0/2] meson: ensure we enable CMPXCHG128 on x86_64

2024-10-07 Thread Paolo Bonzini
Alex discovered that CMPXCHG128 was not enabled when building for x86_64, resulting in slow execution for wide atomic instructions, creating a huge contention when combined with a high number of cpus (found while booting android aarch64 guest on x86_64 host). The problem is that even though we e

[PATCH 1/2] meson: define qemu_isa_flags

2024-10-07 Thread Paolo Bonzini
Create a separate variable for compiler flags that enable specific instruction set extensions, so that they can be used with cc.compiles/cc.links. Note that -mfpmath=sse is a code generation option but it does not enable new instructions, therefore I did not make it part of qemu_isa_flags. Sugges

[PATCH 2/2] meson: ensure -mcx16 is passed when detecting ATOMIC128

2024-10-07 Thread Paolo Bonzini
Moving -mcx16 out of CPU_CFLAGS caused the detection of ATOMIC128 to fail, because flags have to be specified by hand in cc.compiles and cc.links invocations (why oh why??). Ensure that these tests enable all the instruction set extensions that will be used to build the emulators. Fixes: c2bf2ccb

Re: [PATCH v3 0/2] meson: ensure we enable CMPXCHG128 on x86_64

2024-10-07 Thread Michael Tokarev
07.10.2024 20:23, Paolo Bonzini wrote: Alex discovered that CMPXCHG128 was not enabled when building for x86_64, resulting in slow execution for wide atomic instructions, creating a huge contention when combined with a high number of cpus (found while booting android aarch64 guest on x86_64 host

Re: [PATCH 2/5] i386/cpu: add IsDefined flag to smp-cache property

2024-10-07 Thread Zhao Liu
Hi Ali, On Thu, Sep 12, 2024 at 02:38:26PM +0100, Alireza Sanaee wrote: > Date: Thu, 12 Sep 2024 14:38:26 +0100 > From: Alireza Sanaee > Subject: [PATCH 2/5] i386/cpu: add IsDefined flag to smp-cache property > X-Mailer: git-send-email 2.34.1 > > This commit adds IsDefined flag to the object and

Re: [PATCH v1 0/6] Support virtio-gpu DRM native context

2024-10-07 Thread Dmitry Osipenko
On 10/7/24 12:48, Akihiko Odaki wrote: > On 2024/10/07 8:23, Dmitry Osipenko wrote: >> This patchset adds DRM native context support to VirtIO-GPU on Qemu. >> It's based on the pending Venus v17 patches [1] that bring host blobs >> support to virtio-gpu-gl device. > > Hi Dmitry, > > Thank you for

Re: [PATCH 12/16] ui/surface: allocate shared memory on !win32

2024-10-07 Thread Akihiko Odaki
On 2024/10/07 20:47, Marc-André Lureau wrote: On Sat, Oct 5, 2024 at 12:59 PM Akihiko Odaki wrote: On 2024/10/03 20:22, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Use qemu_memfd_alloc() to allocate the display surface memory, which will fallback on tmpfile/mmap() on systems

Re: [PATCH] docs/system/cpu-hotplug: Update example's socket-id/core-id

2024-10-07 Thread Igor Mammedov
On Thu, 3 Oct 2024 15:54:45 +0100 Peter Maydell wrote: > On Fri, 20 Sept 2024 at 11:45, Igor Mammedov wrote: > > > > On Thu, 19 Sep 2024 13:34:54 +0100 > > Peter Maydell wrote: > > > > > On Tue, 10 Sept 2024 at 10:38, Peter Maydell > > > wrote: > > > > > > > > On Tue, 10 Sept 2024 at 10:0

Re: [PATCH v4] i386/cpu: fixup number of addressable IDs for logical processors in the physical package

2024-10-07 Thread Igor Mammedov
On Mon, 7 Oct 2024 16:13:44 +0800 Chuang Xu wrote: > When QEMU is started with: > -cpu host,migratable=on,host-cache-info=on,l3-cache=off > -smp 180,sockets=2,dies=1,cores=45,threads=2 > > Try to execute "cpuid -1 -l 1 -r" in guest, we'll obtain a value of 90 for > CPUID.01H.EBX[23:16], while t

Re: [PATCH v3 13/14] hw/vmapple/virtio-blk: Add support for apple virtio-blk

2024-10-07 Thread Phil Dennis-Jordan
On Sat, 5 Oct 2024 at 07:47, Akihiko Odaki wrote: > On 2024/09/28 17:57, Phil Dennis-Jordan wrote: > > From: Alexander Graf > > > > Apple has its own virtio-blk PCI device ID where it deviates from the > > official virtio-pci spec slightly: It puts a new "apple type" > > field at a static offset

Re: [PATCH v2 00/25] misc: Use explicit endian LD/ST API

2024-10-07 Thread Richard Henderson
On 10/7/24 00:52, Pierre Muller wrote: While we have never supported rx or riscv in big-endian, but there's no reason that we can't, and those target/ patches make things harder. Since target/ will *always* have TARGET_BIG_ENDIAN available, I don't see that we're saving anything there.   Isn

Re: [PATCH 1/2] meson: define qemu_isa_flags

2024-10-07 Thread Richard Henderson
On 10/7/24 01:43, Paolo Bonzini wrote: Create a separate variable for compiler flags that enable specific instruction set extensions, so that they can be used with cc.compiles/cc.links. Note that -mfpmath=sse is a code generation option but it does not enable new instructions, therefore I did no

[PATCH] hw/char/pl011: Use correct masks for IBRD and FBRD

2024-10-07 Thread Peter Maydell
In commit b88cfee90268cad we defined masks for the IBRD and FBRD integer and fractional baud rate divider registers, to prevent the guest from writing invalid values which could cause division-by-zero. Unfortunately we got the mask values the wrong way around: the FBRD register is six bits and the

Re: [PATCH 2/2] meson: ensure -mcx16 is passed when detecting ATOMIC128

2024-10-07 Thread Richard Henderson
On 10/7/24 01:43, Paolo Bonzini wrote: Moving -mcx16 out of CPU_CFLAGS caused the detection of ATOMIC128 to fail, because flags have to be specified by hand in cc.compiles and cc.links invocations (why oh why??). Ensure that these tests enable all the instruction set extensions that will be used

Re: [PATCH] target/loongarch: Support 4K page size

2024-10-07 Thread Michael Tokarev
23.10.2023 05:40, Song Gao wrote: The LoongArch kernel supports 4K page size. Change TARGET_PAGE_BITS to 12. This change appears to have 2 issues. First, the subject is misleading, - it does not only introduces support for 4K page size, it actually *switches* to 4K page size. But this is sor

Re: [PATCH 1/2] meson: define qemu_isa_flags

2024-10-07 Thread Paolo Bonzini
On Mon, Oct 7, 2024 at 4:46 PM Richard Henderson wrote: > > - qemu_common_flags = ['-march=i486'] + qemu_common_flags > > + qemu_isa_flags = ['-march=i486'] > > Use += ? Here the qemu_isa_flags are known to be empty. > > - qemu_common_flags = ['-mcx16'] + qemu_common_flags > > + qemu

[PULL 04/12] rust: add bindgen step as a meson dependency

2024-10-07 Thread Paolo Bonzini
From: Manos Pitsidianakis Add bindings_rs target for generating rust bindings to target-independent qemu C APIs. The bindings need be created before any rust crate that uses them is compiled. The bindings.rs file will end up in BUILDDIR/bindings.rs and have the same name as a target: ninja b

[PULL 03/12] configure, meson: detect Rust toolchain

2024-10-07 Thread Paolo Bonzini
Include the correct path and arguments to rustc in the native and cross files (native compilation is needed for procedural macros). Based on the host architecture and OS, the compiler and optionally the argument to --cpu, the Rust target triple can be detected automatically for either a native or

[PULL 01/12] docs: Mark "gluster" support in QEMU as deprecated

2024-10-07 Thread Thomas Huth
According to https://marc.info/?l=fedora-devel-list&m=171934833215726 the GlusterFS development effectively ended. Thus mark it as deprecated in QEMU, so we can remove it in a future release if the project does not gain momentum again. Acked-by: Niels de Vos Acked-by: Markus Armbruster Message-I

[PULL 08/12] hw/s390x: Use explicit big-endian LD/ST API

2024-10-07 Thread Thomas Huth
From: Philippe Mathieu-Daudé The S390X architecture uses big endianness. Directly use the big-endian LD/ST API. Mechanical change using: $ end=be; \ for acc in uw w l q tul; do \ sed -i -e "s/ld${acc}_p(/ld${acc}_${end}_p(/" \ -e "s/st${acc}_p(/st${acc}_${end}_p(/" \

[PULL 00/12] CI fixes and various clean-ups

2024-10-07 Thread Thomas Huth
The following changes since commit b5ab62b3c0050612c7f9b0b4baeb44ebab42775a: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2024-10-04 19:28:37 +0100) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2024-10-07 for you t

[PULL 07/12] target/m68k: Use explicit big-endian LD/ST API

2024-10-07 Thread Thomas Huth
From: Philippe Mathieu-Daudé The M68K architecture uses big endianness. Directly use the big-endian LD/ST API. Mechanical change using: $ end=be; \ for acc in uw w l q tul; do \ sed -i -e "s/ld${acc}_p(/ld${acc}_${end}_p(/" \ -e "s/st${acc}_p(/st${acc}_${end}_p(/" \

[PULL 04/12] disas: Remove CRIS disassembler

2024-10-07 Thread Thomas Huth
From: Philippe Mathieu-Daudé We just removed the CRIS target, the disassembler is now dead code. Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240904143603.52934-15-phi...@linaro.org> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- MAINTAINERS |5 - meson.build

[PULL 12/12] tests/functional: Bump timeout of some tests

2024-10-07 Thread Thomas Huth
These tests occasionally time out when the host system is under heavy load. Increase the timeout setting to allow for more headroom here. Message-ID: <20241002140212.350467-1-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/functional/meson.build | 9 ++--- 1 file changed, 6 insertions

[PULL 09/12] target/s390x: Replace ldtul_p() -> ldq_p()

2024-10-07 Thread Thomas Huth
From: Philippe Mathieu-Daudé The S390X target is only built for 64-bit. Using ldtul_p() is pointless, replace by ldq_p(). Mechanical change doing: $ sed -i -e 's/ldtul_p/ldq_p/' $(git grep -wl ldtul_p target/s390x/) Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Mess

[PULL 03/12] .gitlab-ci.d/cirrus: Add manual testing of macOS 15 (Sequoia)

2024-10-07 Thread Thomas Huth
From: Philippe Mathieu-Daudé Upgrade libvirt-ci so it covers macOS 15. Add a manual entry (QEMU_JOB_OPTIONAL: 1) to test on Sequoia release. Refresh the lci-tool generated files. Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240917085058.1740-4-phi...@linaro.org> [thuth: Fix image names

[PULL 11/12] tests/functional: Switch back to the gitlab URLs for the advent calendar tests

2024-10-07 Thread Thomas Huth
Shortly after we switched to the original URLs on qemu-advent-calendar.org, the server went offline - looks like we are better off using the gitlab URLs again instead. Message-ID: <20241007083649.204886-1-th...@redhat.com> Reviewed-by: Manos Pitsidianakis Signed-off-by: Thomas Huth --- tests/fu

[PULL 06/12] hw/m68k: Use explicit big-endian LD/ST API

2024-10-07 Thread Thomas Huth
From: Philippe Mathieu-Daudé The M68K architecture uses big endianness. Directly use the big-endian LD/ST API. Mechanical change using: $ end=be; \ for acc in uw w l q tul; do \ sed -i -e "s/ld${acc}_p(/ld${acc}_${end}_p(/" \ -e "s/st${acc}_p(/st${acc}_${end}_p(/" \

Re: [RFC V2 PATCH 02/11] acpi: Implement control method sleep button

2024-10-07 Thread Igor Mammedov
On Fri, 27 Sep 2024 14:38:57 -0400 Annie Li wrote: > The control method sleep button is added, as well as its GPE event > handler. > > Co-developed-by: Miguel Luis > Signed-off-by: Annie Li > --- > hw/acpi/control_method_device.c | 54 + > hw/acpi/meson.build

Re: [PULL 00/12] CI fixes and various clean-ups

2024-10-07 Thread Peter Maydell
On Mon, 7 Oct 2024 at 14:43, Peter Maydell wrote: > > On Mon, 7 Oct 2024 at 12:50, Thomas Huth wrote: > > > > The following changes since commit b5ab62b3c0050612c7f9b0b4baeb44ebab42775a: > > > > Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging > > (2024-10-04 19:28:37 +

Re: [PATCH v3 12/14] hw/vmapple/cfg: Introduce vmapple cfg region

2024-10-07 Thread Phil Dennis-Jordan
On Sat, 5 Oct 2024 at 07:35, Akihiko Odaki wrote: > On 2024/09/28 17:57, Phil Dennis-Jordan wrote: > > From: Alexander Graf > > > > Instead of device tree or other more standardized means, VMApple passes > > platform configuration to the first stage boot loader in a binary encoded > > format tha

Re: [PATCH V2 02/13] migration: cpr-state

2024-10-07 Thread Peter Xu
On Mon, Sep 30, 2024 at 12:40:33PM -0700, Steve Sistare wrote: > CPR must save state that is needed after QEMU is restarted, when devices > are realized. Thus the extra state cannot be saved in the migration stream, > as objects must already exist before that stream can be loaded. Instead, > defi

Re: [PATCH v2 5/7] i386/cpu: Support thread and module level cache topology

2024-10-07 Thread Zhao Liu
On Tue, Sep 17, 2024 at 10:05:08AM +0100, Jonathan Cameron wrote: > Date: Tue, 17 Sep 2024 10:05:08 +0100 > From: Jonathan Cameron > Subject: Re: [PATCH v2 5/7] i386/cpu: Support thread and module level cache > topology > X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) > > On Sun,

[PATCH v4 1/3] xilink_zynq: Add various missing unimplemented devices

2024-10-07 Thread Chao Liu
Add xilinx zynq board memory mapping is implemented in the device. Remove a ignore_memory_transaction_failures concurrently. See: ug585-Zynq-7000-TRM manual B.3 (Module Summary) Signed-off-by: Chao Liu --- hw/arm/xilinx_zynq.c | 71 +++- 1 file changed, 7

[PATCH v4 3/3] xilink-zynq-devcfg: Avoid disabling devcfg memory region during initialization

2024-10-07 Thread Chao Liu
During the initialization phase, we've encountered an issue where the UNLOCK register is inadvertently cleared. This results in devcfg MR being disabled, which in turn leads to unexpected memory access exceptions when attempting subsequent accesses to the devcfg register. This behavior is not consi

[PATCH v4 2/3] xilink-zynq-devcfg: Fix up for memory address range size not set correctly

2024-10-07 Thread Chao Liu
Signed-off-by: Chao Liu --- hw/dma/xlnx-zynq-devcfg.c | 2 +- include/hw/dma/xlnx-zynq-devcfg.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/dma/xlnx-zynq-devcfg.c b/hw/dma/xlnx-zynq-devcfg.c index b8544d0731..e5eff9abc0 100644 --- a/hw/dma/xlnx-zynq-devcfg.c

Re: [PULL 00/12] Rust initial PoC + meson changes for 2024-10-07

2024-10-07 Thread Daniel P . Berrangé
On Mon, Oct 07, 2024 at 01:26:52PM +0200, Paolo Bonzini wrote: > On Mon, Oct 7, 2024 at 1:11 PM Daniel P. Berrangé wrote: > > The current dockerfiles don't include rust, and I see nothing > > here updating them to add rust, so how is any of this getting > > test coverage ? > > > > Even though this

Re: [PATCH 12/16] ui/surface: allocate shared memory on !win32

2024-10-07 Thread Marc-André Lureau
On Sat, Oct 5, 2024 at 12:59 PM Akihiko Odaki wrote: > > On 2024/10/03 20:22, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Use qemu_memfd_alloc() to allocate the display surface memory, which > > will fallback on tmpfile/mmap() on systems without memfd, and allow to > >

Re: [PATCH 16/16] tests: add basic -display dbus Map.Unix test

2024-10-07 Thread Marc-André Lureau
Hi On Sat, Oct 5, 2024 at 12:32 PM Akihiko Odaki wrote: > > On 2024/10/03 20:22, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Only check we eventually get a shared memory scanout. > > > > Signed-off-by: Marc-André Lureau > > --- > > tests/qtest/dbus-display-test.c |

Re: [RFC V2 PATCH 01/11] acpi: hmp/qmp: Add hmp/qmp support for system_sleep

2024-10-07 Thread Igor Mammedov
On Fri, 27 Sep 2024 14:38:56 -0400 Annie Li wrote: > Followng hmp/qmp commands are implemented for pressing virtual > sleep button, > > hmp: system_sleep > qmp: { "execute": "system_sleep" } > > These commands put the guest into suspend or other power states > depending on the power settings in

Re: [RFC v2 1/2] vhost-vdpa: Implement IOVA->GPA tree

2024-10-07 Thread Eugenio Perez Martin
On Mon, Oct 7, 2024 at 5:38 PM Jonah Palmer wrote: > > > > On 10/7/24 9:51 AM, Eugenio Perez Martin wrote: > > On Fri, Oct 4, 2024 at 8:48 PM Jonah Palmer wrote: > >> > >> > >> > >> On 10/4/24 11:17 AM, Eugenio Perez Martin wrote: > >>> On Fri, Oct 4, 2024 at 2:45 PM Jonah Palmer > >>> wrote: >

Re: [PATCH] hw/char/pl011: Use correct masks for IBRD and FBRD

2024-10-07 Thread Alex Bennée
Peter Maydell writes: > In commit b88cfee90268cad we defined masks for the IBRD and FBRD > integer and fractional baud rate divider registers, to prevent the > guest from writing invalid values which could cause division-by-zero. > Unfortunately we got the mask values the wrong way around: the FB

[Stable-9.1.1 20/32] target/hppa: Fix random 32-bit linux-user crashes

2024-10-07 Thread Michael Tokarev
From: Helge Deller The linux-user hppa target crashes randomly for me since commit 081a0ed188d8 ("target/hppa: Do not mask in copy_iaoq_entry"). That commit dropped the masking of the IAOQ addresses while copying them from other registers and instead keeps them with all 64 bits up until the full

[Stable-9.1.1 24/32] tcg: Fix iteration step in 32-bit gvec operation

2024-10-07 Thread Michael Tokarev
From: TANG Tiancheng The loop in the 32-bit case of the vector compare operation was incorrectly incrementing by 8 bytes per iteration instead of 4 bytes. This caused the function to process only half of the intended elements. Cc: qemu-sta...@nongnu.org Fixes: 9622c697d1 (tcg: Add gvec compare w

[Stable-9.1.1 29/32] target/arm: Avoid target_ulong for physical address lookups

2024-10-07 Thread Michael Tokarev
From: Ard Biesheuvel target_ulong is typedef'ed as a 32-bit integer when building the qemu-system-arm target, and this is smaller than the size of an intermediate physical address when LPAE is being used. Given that Linux may place leaf level user page tables in high memory when built for LPAE,

[Stable-9.1.1 06/32] tests/docker: remove debian-armel-cross

2024-10-07 Thread Michael Tokarev
From: Alex Bennée As debian-11 transitions to LTS we are starting to have problems building the image. While we could update to a later Debian building a 32 bit QEMU without modern floating point is niche host amongst the few remaining 32 bit hosts we regularly build for. For now we still have ar

[Stable-9.1.1 28/32] block/reqlist: allow adding overlapping requests

2024-10-07 Thread Michael Tokarev
From: Fiona Ebner Allow overlapping request by removing the assert that made it impossible. There are only two callers: 1. block_copy_task_create() It already asserts the very same condition before calling reqlist_init_req(). 2. cbw_snapshot_read_lock() There is no need to have read requests

[Stable-9.1.1 02/32] iotests: fix expected output from gnutls

2024-10-07 Thread Michael Tokarev
From: Daniel P. Berrangé Error reporting from gnutls was improved by: commit 57941c9c86357a6a642f9ee3279d881df4043b6d Author: Daniel P. Berrangé Date: Fri Mar 15 14:07:58 2024 + crypto: push error reporting into TLS session I/O APIs This has the effect of changing the output f

[Stable-9.1.1 21/32] target/ppc: Fix migration of CPUs with TLB_EMB TLB type

2024-10-07 Thread Michael Tokarev
From: Arman Nabiev In vmstate_tlbemb a cut-and-paste error meant we gave this vmstate subsection the same "cpu/tlb6xx" name as the vmstate_tlb6xx subsection. This breaks migration load for any CPU using the TLB_EMB CPU type, because when we see the "tlb6xx" name in the incoming data we try to int

[Stable-9.1.1 07/32] tests/docker: update debian i686 and mipsel images to bookworm

2024-10-07 Thread Michael Tokarev
From: Alex Bennée Whatever issues there were which stopped these being updates when the rest were have now been resolved. However mips64el continues to be broken so don't update it here. Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20240

Re: [PATCH 02/10] linux-user: Fix parse_elf_properties GNU0_MAGIC check

2024-10-07 Thread Philippe Mathieu-Daudé
On 5/10/24 20:33, Richard Henderson wrote: Comparing a string of 4 bytes only works in little-endian. Adjust bulk bswap to only apply to the note payload. Perform swapping of the note header manually; the magic is defined so that it does not need a runtime swap. Fixes: 83f990eb5adb ("linux-user

Re: [PATCH 06/10] linux-user: Correct print_sockaddr() format

2024-10-07 Thread Philippe Mathieu-Daudé
On 5/10/24 20:33, Richard Henderson wrote: From: Philippe Mathieu-Daudé When the %addr argument can not be accessed, a double comma is logged (the final qemu_log call prepend a comma). Move the comma from the final qemu_log to the preceeding switch cases that had omitted it. Signed-off-by: Ph

Re: [PATCH v2 01/21] accel/tcg: Assert noreturn from write-only page for atomics

2024-10-07 Thread Helge Deller
On 10/5/24 22:05, Richard Henderson wrote: There should be no "just in case"; the page is already in the tlb, and known to be not readable. Signed-off-by: Richard Henderson Reviewed-by: Helge Deller --- accel/tcg/cputlb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

Re: [PATCH V2 02/13] migration: cpr-state

2024-10-07 Thread Steven Sistare
On 10/7/2024 10:14 AM, Peter Xu wrote: On Mon, Sep 30, 2024 at 12:40:33PM -0700, Steve Sistare wrote: CPR must save state that is needed after QEMU is restarted, when devices are realized. Thus the extra state cannot be saved in the migration stream, as objects must already exist before that st

Re: [PATCH V2 09/13] migration: cpr-transfer save and load

2024-10-07 Thread Steven Sistare
On 10/7/2024 12:47 PM, Peter Xu wrote: On Mon, Sep 30, 2024 at 12:40:40PM -0700, Steve Sistare wrote: Add functions to create a QEMUFile based on a unix URI, for saving or loading, for use by cpr-transfer mode to preserve CPR state. Signed-off-by: Steve Sistare Reviewed-by: Peter Xu There'

Re: [PATCH V2 03/13] migration: save cpr mode

2024-10-07 Thread Steven Sistare
On 10/7/2024 11:18 AM, Peter Xu wrote: On Mon, Sep 30, 2024 at 12:40:34PM -0700, Steve Sistare wrote: Save the mode in CPR state, so the user does not need to explicitly specify it for the target. Modify migrate_mode() so it returns the incoming mode on the target. Signed-off-by: Steve Sistare

Re: [PATCH V2 01/13] machine: alloc-anon option

2024-10-07 Thread Steven Sistare
On 10/7/2024 11:36 AM, Peter Xu wrote: On Mon, Sep 30, 2024 at 12:40:32PM -0700, Steve Sistare wrote: diff --git a/system/trace-events b/system/trace-events index 074d001..4669411 100644 --- a/system/trace-events +++ b/system/trace-events @@ -47,3 +47,6 @@ dirtylimit_vcpu_execute(int cpu_index,

Re: [PATCH V2 08/13] migration: VMSTATE_FD

2024-10-07 Thread Steven Sistare
On 10/7/2024 12:36 PM, Peter Xu wrote: On Mon, Sep 30, 2024 at 12:40:39PM -0700, Steve Sistare wrote: Define VMSTATE_FD for declaring a file descriptor field in a VMStateDescription. Signed-off-by: Steve Sistare --- include/migration/vmstate.h | 9 + migration/vmstate-types.c | 3

Re: [PATCH] hw/arm: add Quanta GSZ bmc machine

2024-10-07 Thread Ben Dooks
On 2024-10-07 18:17, Titus Rwantare wrote: This patch adds the quanta-gsz-bmc target, a current Google machine of the day. This machine will be used as a platform to enable features such as the PECI bmc interface, and Intel eSPI virtual wire interface in QEMU. Signed-off-by: Titus Rwantare

Re: [PATCH] hw/char/pl011: Use correct masks for IBRD and FBRD

2024-10-07 Thread Philippe Mathieu-Daudé
On 7/10/24 11:47, Peter Maydell wrote: In commit b88cfee90268cad we defined masks for the IBRD and FBRD integer and fractional baud rate divider registers, to prevent the guest from writing invalid values which could cause division-by-zero. Unfortunately we got the mask values the wrong way aroun

Re: [PATCH v2 13/25] target/sh4: Use explicit little-endian LD/ST API

2024-10-07 Thread Philippe Mathieu-Daudé
On 4/10/24 13:30, Philippe Mathieu-Daudé wrote: Since commit 73ceb12960e ("Remove the unused sh4eb target") we only build the SH4 architecture for little endianness. Directly use the little-endian LD/ST API. Mechanical change using: $ end=le; \ for acc in uw w l q tul; do \ sed -

Re: [PATCH 3/3] scripts: forbid use of arbitrary SPDX tags besides license identifiers

2024-10-07 Thread Philippe Mathieu-Daudé
On 7/10/24 12:45, Daniel P. Berrangé wrote: While SPDX-License-Identifier is a well known SPDX tag, there are a great many more besides that[1]. This are around making machine readable metadata available to the 'reuse' tool and similar for things like author names, copyright owners, and much more

Re: [PATCH] hw/arm: add Quanta GSZ bmc machine

2024-10-07 Thread Titus Rwantare
Ack. There are devices that get attached to these muxes. I need to send another revision of the patches in https://lists.gnu.org/archive/html/qemu-devel/2023-02/msg01514.html, but for the moment. This patch can go in separately from that series. -Titus On Mon, 7 Oct 2024 at 12:16, Ben Dooks wrot

Re: [PATCH v1 0/2] GTK/SDL fixes for a black screen displayed by virtio-gpu

2024-10-07 Thread Dmitry Osipenko
On 10/7/24 22:26, Michael Tokarev wrote: > 07.10.2024 02:43, Dmitry Osipenko wrote: >> Hi, >> >> This patchset fixes black screen displayed by Qemu using virtio-gpu. >> There is a race condition bug with a timer that disables display output >> after it has been enabled by virtio-gpu. The problem is

Re: [PATCH v1 1/1] hw/xen: Avoid use of uninitialized bufioreq_evtchn

2024-10-07 Thread Stefano Stabellini
On Mon, 7 Oct 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Avoid use of uninitialized bufioreq_evtchn. It should only > be used if buffered IOREQs are enabled. > > Resolves: Coverity CID 1563383 > Reported-by: Peter Maydell > Signed-off-by: Edgar E. Iglesias Acked-by: Stefan

Re: [RFC v2 1/2] vhost-vdpa: Implement IOVA->GPA tree

2024-10-07 Thread Si-Wei Liu
On 10/7/2024 6:51 AM, Eugenio Perez Martin wrote: On Fri, Oct 4, 2024 at 8:48 PM Jonah Palmer wrote: On 10/4/24 11:17 AM, Eugenio Perez Martin wrote: On Fri, Oct 4, 2024 at 2:45 PM Jonah Palmer wrote: Implements the IOVA->GPA tree for handling mapping, unmapping, and translations for gu

[PATCH v2] tests/functional: Switch back to the gitlab URLs for the advent calendar tests

2024-10-07 Thread Thomas Huth
Shortly after we switched to the original URLs on qemu-advent-calendar.org, the server went offline - looks like we are better off using the gitlab URLs again instead. Signed-off-by: Thomas Huth --- v2: Drop the wrong change to the test_microblazeel_s3adsp1800.py file tests/functional/test_arm

Re: [PATCH v2 6/7] i386/cpu: Update cache topology with machine's configuration

2024-10-07 Thread Zhao Liu
Hi Ali, [snip] > > + > > +/* > > + * TODO: Add a SMPCompatProps.has_caches flag to avoid useless > > Updates > > + * if user didn't set smp_cache. > > + */ > Hi Zhao, > > Thanks for sending this patchset so quickly. I really appreciate the > TODO already :) Welcome! And I'm also

[PATCH] net/tap-win32: Fix gcc 14 format truncation errors

2024-10-07 Thread Bernhard Beschow
The patch fixes the following errors generated by GCC 14.2: ../src/net/tap-win32.c:343:19: error: '%s' directive output may be truncated writing up to 255 bytes into a region of size 176 [-Werror=format-truncation=] 343 | "%s\\%s\\Connection", | ^~ 344 |

Re: [PATCH v1 5/6] virtio-gpu: Support asynchronous fencing

2024-10-07 Thread Akihiko Odaki
On 2024/10/07 8:23, Dmitry Osipenko wrote: Support asynchronous fencing feature of virglrenderer. It allows Qemu to handle fence as soon as it's signalled instead of periodically polling the fence status. This feature is required for enabling DRM context support in Qemu because legacy fencing mod

Re: [PATCH v1 6/6] virtio-gpu: Support DRM native context

2024-10-07 Thread Akihiko Odaki
On 2024/10/07 8:23, Dmitry Osipenko wrote: Add support for DRM native contexts to VirtIO-GPU. DRM context is enabled using a new virtio-gpu-gl device option "drm=true". Unlike Virgl and Venus contexts that operate on application API level, DRM native contexts work on a kernel UAPI level. This lo

Re: [PATCH 2/2] gdbstub: Apply breakpoints only to the selected PID

2024-10-07 Thread Alex Bennée
Roque Arcudia Hernandez writes: > In the context of using the remote gdb with multiple > processes/inferiors (multi cluster machine) a given breakpoint will > target an specific inferior. Current implementation of > tcg_insert_breakpoint and tcg_remove_breakpoint apply a given > breakpoint to all

Re: [PATCH v2 00/25] misc: Use explicit endian LD/ST API

2024-10-07 Thread Pierre Muller
Le 05/10/2024 à 03:39, Richard Henderson a écrit : On 10/4/24 09:30, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (25): gdbstub/helpers: Have ldtul_p() definition use ldn_p() target/hexagon: Replace ldtul_p() -> ldl_p() target/alpha: Replace ldtul_p() -> ldq_p() target

[PATCH v2 0/2] meson: ensure we enable CMPXCHG128 on x86_64

2024-10-07 Thread Paolo Bonzini
Alex discovered that CMPXCHG128 was not enabled when building for x86_64, resulting in slow execution for wide atomic instructions, creating a huge contention when combined with a high number of cpus (found while booting android aarch64 guest on x86_64 host). The problem is that even though we e

Re: [PATCH 11/16] hw/sparc: Use explicit big-endian LD/ST API

2024-10-07 Thread Clément Chigot
On Fri, Oct 4, 2024 at 1:43 AM Philippe Mathieu-Daudé wrote: > > The SPARC architecture uses big endianness. Directly use > the big-endian LD/ST API. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sparc/leon3.c | 42 +- > hw/sparc/sun4m.c | 6 ++

Re: [PATCH v2] virtio-gpu: Add definition for resource_uuid feature

2024-10-07 Thread Marc-André Lureau
Hi On Mon, Oct 7, 2024 at 11:00 AM Dorinda Bassey wrote: > > Add the VIRTIO_GPU_F_RESOURCE_UUID feature to enable the assignment > of resources UUIDs for export to other virtio devices. > > Signed-off-by: Dorinda Bassey Reviewed-by: Marc-André Lureau > --- > hw/display/vhost-user-gpu.c|

[PATCH v4] i386/cpu: fixup number of addressable IDs for logical processors in the physical package

2024-10-07 Thread Chuang Xu
When QEMU is started with: -cpu host,migratable=on,host-cache-info=on,l3-cache=off -smp 180,sockets=2,dies=1,cores=45,threads=2 Try to execute "cpuid -1 -l 1 -r" in guest, we'll obtain a value of 90 for CPUID.01H.EBX[23:16], while the expected value is 128. And Try to execute "cpuid -1 -l 4 -r" in

Re: [PATCH v1 2/6] ui/sdl2: Implement dpy dmabuf functions

2024-10-07 Thread Akihiko Odaki
On 2024/10/07 8:23, Dmitry Osipenko wrote: From: Pierre-Eric Pelloux-Prayer If EGL is used, we can rely on dmabuf to import textures without doing copies. To get this working on X11, we use the existing SDL hint: SDL_HINT_VIDEO_X11_FORCE_EGL (because dmabuf can't be used with GLX). Signed-off

Re: [PATCH v1 1/6] ui/sdl2: Restore original context after new context creation

2024-10-07 Thread Akihiko Odaki
On 2024/10/07 8:23, Dmitry Osipenko wrote: SDL API changes GL context to a newly created GL context, which differs from other GL providers that don't switch context. Change SDL backend to restore the original GL context. This allows Qemu's virtio-gpu to support new virglrenderer async-fencing fea

Re: [PATCH v2] tests/functional: Switch back to the gitlab URLs for the advent calendar tests

2024-10-07 Thread Manos Pitsidianakis
On Mon, 07 Oct 2024 11:36, Thomas Huth wrote: Shortly after we switched to the original URLs on qemu-advent-calendar.org, the server went offline - looks like we are better off using the gitlab URLs again instead. Signed-off-by: Thomas Huth --- v2: Drop the wrong change to the test_microblazee

Re: [PATCH v2] virtio-gpu: Add definition for resource_uuid feature

2024-10-07 Thread Manos Pitsidianakis
On Mon, 07 Oct 2024 10:00, Dorinda Bassey wrote: Add the VIRTIO_GPU_F_RESOURCE_UUID feature to enable the assignment of resources UUIDs for export to other virtio devices. Signed-off-by: Dorinda Bassey --- hw/display/vhost-user-gpu.c| 4 hw/display/virtio-gpu-base.c | 3 +++ include/h

Re: [PATCH v1 0/6] Support virtio-gpu DRM native context

2024-10-07 Thread Akihiko Odaki
On 2024/10/07 8:23, Dmitry Osipenko wrote: This patchset adds DRM native context support to VirtIO-GPU on Qemu. It's based on the pending Venus v17 patches [1] that bring host blobs support to virtio-gpu-gl device. Hi Dmitry, Thank you for submitting this series. [1] https://lore.kernel.or

Re: [PATCH] qapi, machine-qmp-cmds.c: query-accelerator support

2024-10-07 Thread Markus Armbruster
Daniel P. Berrangé writes: > Markus: QAPI design Qs for you at the bottom > > On Wed, Sep 25, 2024 at 10:19:33AM -0300, Daniel Henrique Barboza wrote: >> >> >> On 9/19/24 9:22 AM, Daniel P. Berrangé wrote: >> > On Thu, Sep 19, 2024 at 08:20:56AM -0300, Daniel Henrique Barboza wrote: >> > > Add

Re: [PATCH v2 0/2] meson: ensure we enable CMPXCHG128 on x86_64

2024-10-07 Thread Alex Bennée
Paolo Bonzini writes: > Alex discovered that CMPXCHG128 was not enabled when building for > x86_64, resulting in slow execution for wide atomic instructions, > creating a huge contention when combined with a high number of cpus > (found while booting android aarch64 guest on x86_64 host). > > The

[PATCH v2] virtio-gpu: Add definition for resource_uuid feature

2024-10-07 Thread Dorinda Bassey
Add the VIRTIO_GPU_F_RESOURCE_UUID feature to enable the assignment of resources UUIDs for export to other virtio devices. Signed-off-by: Dorinda Bassey --- hw/display/vhost-user-gpu.c| 4 hw/display/virtio-gpu-base.c | 3 +++ include/hw/virtio/virtio-gpu.h | 3 +++ 3 files changed, 1

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-10-07 Thread Yu Zhang
Sure, as we talked at the KVM Forum, a possible approach is to set up two VMs on a physical host, configure the SoftRoCE, and run the migration test in two nested VMs to ensure that the migration data traffic goes through the emulated RDMA hardware. I will continue with this and let you know. On

Re: [PATCH 05/16] ui/dbus: fix filtering all update messages

2024-10-07 Thread Marc-André Lureau
Hi Akihiko On Sat, Oct 5, 2024 at 12:44 PM Akihiko Odaki wrote: > > On 2024/10/03 20:22, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Filtering pending messages when a new scanout is given shouldn't discard > > pending cursor changes, for example. > > > > Since filterin

Re: [PATCH v2 0/2] meson: ensure we enable CMPXCHG128 on x86_64

2024-10-07 Thread Michael Tokarev
07.10.2024 11:43, Paolo Bonzini wrote: Alex discovered that CMPXCHG128 was not enabled when building for x86_64, resulting in slow execution for wide atomic instructions, creating a huge contention when combined with a high number of cpus (found while booting android aarch64 guest on x86_64 host

Re: [PATCH v2 01/23] hw/ppc/e500: Do not leak struct boot_info

2024-10-07 Thread Bernhard Beschow
Am 6. Oktober 2024 16:56:52 UTC schrieb BALATON Zoltan : >On Sat, 5 Oct 2024, Bernhard Beschow wrote: >> The struct is allocated once with g_new0() but never free()'d. Fix the >> leakage >> by adding an attribute to struct PPCE500MachineState which avoids the >> allocation. >> >> While at it r

Re: [PATCH 3/3] .gitlab-ci.d/cirrus: Add manual testing of macOS 15 (Sequoia)

2024-10-07 Thread Thomas Huth
On 17/09/2024 14.52, Daniel P. Berrangé wrote: On Tue, Sep 17, 2024 at 10:50:58AM +0200, Philippe Mathieu-Daudé wrote: Upgrade libvirt-ci so it covers macOS 15. Add a manual entry (QEMU_JOB_OPTIONAL: 1) to test on Sequoia release. Refresh the lci-tool generated files. Signed-off-by: Philippe Ma

Re: [PATCH 3/3] .gitlab-ci.d/cirrus: Add manual testing of macOS 15 (Sequoia)

2024-10-07 Thread Daniel P . Berrangé
On Mon, Oct 07, 2024 at 11:10:20AM +0200, Thomas Huth wrote: > On 17/09/2024 14.52, Daniel P. Berrangé wrote: > > On Tue, Sep 17, 2024 at 10:50:58AM +0200, Philippe Mathieu-Daudé wrote: > > > Upgrade libvirt-ci so it covers macOS 15. Add a manual entry > > > (QEMU_JOB_OPTIONAL: 1) to test on Sequoi

Re: [PATCH] meson: ensure we enable CMPXCHG128 on x86_64

2024-10-07 Thread Daniel P . Berrangé
On Fri, Oct 04, 2024 at 03:01:23PM -0700, Pierrick Bouvier wrote: > Alex discovered that CMPXCHG128 was not enabled when building for > x86_64, resulting in slow execution for wide atomic instructions, > creating a huge contention when combined with a high number of cpus > (found while booting andr

[PATCH 1/2] meson: define qemu_isa_flags

2024-10-07 Thread Paolo Bonzini
Create a separate variable for compiler flags that enable specific instruction set extensions, so that they can be used with cc.compiles/cc.links. Note that -mfpmath=sse is a code generation option but it does not enable new instructions, therefore I did not make it part of qemu_isa_flags. Sugges

[PATCH 2/2] meson: ensure -mcx16 is passed when detecting ATOMIC128

2024-10-07 Thread Paolo Bonzini
Moving -mcx16 out of CPU_CFLAGS caused the detection of ATOMIC128 to fail, because flags have to be specified by hand in cc.compiles and cc.links invocations (why oh why??). Ensure that these tests enable all the instruction set extensions that will be used to build the emulators. Fixes: c2bf2ccb

Re: [PATCH v3 01/14] hw/display/apple-gfx: Introduce ParavirtualizedGraphics.Framework support

2024-10-07 Thread Akihiko Odaki
On 2024/10/06 19:39, Phil Dennis-Jordan wrote: On Thu, 3 Oct 2024 at 09:09, Akihiko Odaki > wrote: On 2024/10/02 22:33, Phil Dennis-Jordan wrote: > > >      > +#include "apple-gfx.h" >      > +#include "monitor/monitor.h" >      >

  1   2   3   4   >