Re: [PATCH v3 5/5] block: add test non-active commit with zeroed data

2024-10-02 Thread Vladimir Sementsov-Ogievskiy
On 01.09.24 17:24, Vincent Vanlaer wrote: Signed-off-by: Vincent Vanlaer --- tests/qemu-iotests/315 | 95 ++ tests/qemu-iotests/315.out | 54 ++ Please place new tests in tests/qemu-iotests/tests, with human readable name, somethin

Re: [PATCH v1 0/3] pc-bios/s390-ccw: Small Makefile improvements

2024-10-02 Thread Thomas Huth
On 01/10/2024 17.36, Marc Hartmayer wrote: Jens Remus (2): pc-bios/s390-ccw: Clarify alignment is in bytes pc-bios/s390-ccw: Don't generate TEXTRELs Marc Hartmayer (1): pc-bios/s390-ccw: Introduce `EXTRA_LDFLAGS` pc-bios/s390-ccw/netboot.mak | 2 +- pc-bios/s390-ccw/Makefile|

Re: [PATCH] qemu-keymap: Release local allocation references

2024-10-02 Thread Michael Tokarev
23.07.2024 11:49, Akihiko Odaki wrote: Commit 2523baf7fb4d ("qemu-keymap: Make references to allocations static") made references to allocations static to ensure LeakSanitizer can track them. This trick unfortunately did not work with gcc version 14.0.1; that compiler is clever enough to know tha

Re: [PATCH v2 0/2] kvm: Improve register failure reports for migration

2024-10-02 Thread Paolo Bonzini
Queued, thanks. Paolo

Corrupt VNC display for 1366x768

2024-10-02 Thread Simon Rowe
I've been trying to track down the cause of a glitch that affects guest VNC consoles when the resolution is set to 1366x768. This results in a "stair case" effect where each successive row is offset to the right by a handful of pixels. I believe this is related to the fact that the horizontal re

Re: Corrupt VNC display for 1366x768

2024-10-02 Thread Daniel P . Berrangé
On Wed, Oct 02, 2024 at 11:09:13AM +, Simon Rowe wrote: > I've been trying to track down the cause of a glitch that affects guest VNC > consoles when the resolution is set to 1366x768. This results in a "stair > case" effect where each successive row is offset to the right by a handful of >

Re: [PULL 00/54] target-arm queue

2024-10-02 Thread Peter Maydell
On Tue, 1 Oct 2024 at 17:39, Peter Maydell wrote: > > This pullreq has a few miscellaneous fixes, plus the > non-controversial (and largely reviewed) parts of my > series removing deprecated arm boards. (The rest of that > series I will send out a v2 for once this lands.) > > -- PMM > > The follow

Re: [PULL 00/22] -Werror=maybe-uninitialized fixes

2024-10-02 Thread Peter Maydell
On Wed, 2 Oct 2024 at 09:45, Marc-André Lureau wrote: > > Hi > > On Wed, Oct 2, 2024 at 12:43 PM Thomas Huth wrote: >> >> On 02/10/2024 10.36, marcandre.lur...@redhat.com wrote: >> > From: Marc-André Lureau >> > >> > The following changes since commit >> > 718780d20470c66a3a36d036b29148d5809dc8

[PATCH] qga: skip bind mounts in fs list

2024-10-02 Thread Jean-Louis Dupond
The filesystem list in build_fs_mount_list should skip bind mounts. This because we end up in locking situations when doing fsFreeze. Like mentioned in [1] and [2]. Next to that, the build_fs_mount_list call did a fallback via build_fs_mount_list_from_mtab if mountinfo did not exist. There it skip

Re: [PATCH v1 0/3] pc-bios/s390-ccw: Small Makefile improvements

2024-10-02 Thread Marc Hartmayer
On Wed, Oct 02, 2024 at 11:57 AM +0200, Thomas Huth wrote: > On 01/10/2024 17.36, Marc Hartmayer wrote: >> >> Jens Remus (2): >>pc-bios/s390-ccw: Clarify alignment is in bytes >>pc-bios/s390-ccw: Don't generate TEXTRELs >> >> Marc Hartmayer (1): >>pc-bios/s390-ccw: Introduce `EXTRA_L

Re: [PATCH] net: Remove deadcode

2024-10-02 Thread Thomas Huth
On 18/09/2024 22.52, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" net_hub_port_find is unused since 2018's commit af1a5c3eb4 ("net: Remove the deprecated "vlan" parameter") qemu_receive_packet_iov is unused since commit ffbd2dbd8e ("e1000e: Perform software segmentation for loo

Re: [PATCH] q35: Remove unused mch_mcfg_base

2024-10-02 Thread Thomas Huth
On 18/09/2024 02.51, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" mch_mcfg_base has been unused since it was added by 6f1426ab0f ("ich9: APIs for pc guest info") back in 2013. Remove it. Signed-off-by: Dr. David Alan Gilbert --- hw/pci-host/q35.c | 10 -- incl

Re: [PATCH] hw/xen: Remove deadcode

2024-10-02 Thread Thomas Huth
On 17/09/2024 02.22, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" xen_be_copy_grant_refs is unused since 2019's 19f87870ba ("xen: remove the legacy 'xen_disk' backend") xen_config_dev_console is unused since 2018's 6d7c06c213 ("Remove broken Xen PV domain builder") Remove them

Re: [PATCH] hw/char: Remove unused serial_set_frequency

2024-10-02 Thread Thomas Huth
On 18/09/2024 16.41, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" serial_set_frequnecy has been unused since it was added in 2009: 038eaf82c8 ("serial: Add interface to set reference oscillator frequency") It looks like the 'baudbase' is now a property anyway so the wrapper isn't

Re: [PATCH] util/iova-tree: Remove deadcode

2024-10-02 Thread Thomas Huth
On 18/09/2024 16.25, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" iova_tree_find_address, and iova_tree_foreach have never been used since the code was originally added by: eecf5eedbd ("util: implement simple iova tree") Remove them. Signed-off-by: Dr. David Alan Gilbert --- i

Re: [PATCH] hw/net/net_rx_pkt: Remove deadcode

2024-10-02 Thread Thomas Huth
On 19/09/2024 00.51, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" net_rx_pkt_get_l3_hdr_offset and net_rx_pkt_get_iovec_len haven't been used since they were added. Remove them. Signed-off-by: Dr. David Alan Gilbert --- hw/net/net_rx_pkt.c | 13 - hw/net/net_rx_pkt.h

Re: [PATCH] linux-user: Remove unused handle_vm86_fault

2024-10-02 Thread Thomas Huth
On 18/09/2024 16.15, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" handle_vm86_fault has been unused since: 1ade5b2fed ("linux-user/i386: Split out maybe_handle_vm86_trap") Remove it, and it's local macros. Signed-off-by: Dr. David Alan Gilbert --- linux-user/user-internals.h |

Re: [PATCH] hw: Remove unused fw_cfg_init_io

2024-10-02 Thread Thomas Huth
On 18/09/2024 14.35, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" fw_cfg_init_io has been unused since 918a7f706b ("i386: load kernel on xen using DMA") Remove it. Signed-off-by: Dr. David Alan Gilbert --- hw/nvram/fw_cfg.c | 5 - include/hw/nvram/fw_cfg.h | 1 -

Re: [PATCH] ui/cursor: remove cursor_get_mono_image

2024-10-02 Thread Thomas Huth
On 17/09/2024 02.23, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" cursor_get_mono_image has been unused since 2018's 0015ca5cba ("ui: remove support for SDL1.2 in favour of SDL2") Remove it. Signed-off-by: Dr. David Alan Gilbert --- include/ui/console.h | 1 - ui/cursor.c

Re: [PATCH] vhost: Remove unused vhost_dev_{load|save}_inflight

2024-10-02 Thread Thomas Huth
On 18/09/2024 14.10, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" vhost_dev_load_inflight and vhost_dev_save_inflight have been unused since they were added in 2019 by: 5ad204bf2a ("vhost-user: Support transferring inflight buffer between qemu and backend") Remove them, and their h

Re: [PATCH] block-backend: Remove deadcode

2024-10-02 Thread Thomas Huth
On 17/09/2024 02.20, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" blk_by_public last use was removed in 2017 by c61791fc23 ("block: add aio_context field in ThrottleGroupMember") blk_activate last use was removed earlier this year by eef0bae3a7 ("migration: Remove block migrati

Re: [PATCH] remote: Remove unused remote_iohub_finalize

2024-10-02 Thread Thomas Huth
On 19/09/2024 18.58, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" remote_iohub_finalize has never been used. Remove it. Signed-off-by: Dr. David Alan Gilbert --- hw/remote/iohub.c | 13 - include/hw/remote/iohub.h | 1 - 2 files changed, 14 deletions(-) di

Re: [PATCH] hw/pci: Remove unused pcie_chassis_find_slot

2024-10-02 Thread Thomas Huth
On 19/09/2024 01.47, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" pcie_chassis_find_slot has been unused since it was added. Remove it. Signed-off-by: Dr. David Alan Gilbert --- hw/pci/pcie_port.c | 10 -- include/hw/pci/pcie_port.h | 1 - 2 files changed, 11 d

Re: [PATCH] replay: Remove unused replay_disable_events

2024-10-02 Thread Thomas Huth
On 19/09/2024 01.40, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" replay_disable_events has been unused since 2019's c8aa7895eb ("replay: don't drain/flush bdrv queue while RR is working") Remove it. Signed-off-by: Dr. David Alan Gilbert --- include/sysemu/replay.h | 2 -- re

Re: [PATCH] hw/net/rocker: Remove unused rocker_fp_ports

2024-10-02 Thread Thomas Huth
On 19/09/2024 01.14, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" rocker_fp_ports hasn't been used since it was added back in 2015. Remove it. Signed-off-by: Dr. David Alan Gilbert --- hw/net/rocker/rocker.c | 5 - hw/net/rocker/rocker.h | 1 - 2 files changed, 6 deletions(-

Capstone v6-Alpha is released

2024-10-02 Thread Rot127
We are very happy to announce the release of Capstone v6-Alpha1. Although it is marked as Alpha, it runs just as stable and has at least the same quality as any other release before. In fact, it should be even better because we improved our testing significantly (clang-tidy, ASAN, Valgrind, tes

Re: [PATCH 0/3] QOM: little improvements to object_resolve_path*()

2024-10-02 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: More than 255 vcpus Windows VM setup without viommu ?

2024-10-02 Thread Igor Mammedov
On Mon, 30 Sep 2024 16:50:21 +0100 David Woodhouse wrote: > On Sat, 2024-09-28 at 15:59 +0100, David Woodhouse wrote: > > On Tue, 2024-07-02 at 05:17 +, Sandesh Patel wrote: > > > > > > The error is due to invalid MSIX routing entry passed to KVM. > > > > > > The VM boots fine if we attac

Re: [PATCH v3 20/22] block: fix -Werror=maybe-uninitialized false-positive

2024-10-02 Thread Kevin Wolf
Am 30.09.2024 um 10:14 hat marcandre.lur...@redhat.com geschrieben: > From: Marc-André Lureau > > ../block/file-posix.c:1405:17: error: ‘zoned’ may be used uninitialized > [-Werror=maybe-uninitialized] > 1405 | if (ret < 0 || zoned == BLK_Z_NONE) { > > Signed-off-by: Marc-André Lureau Re

[PULL 00/22] -Werror=maybe-uninitialized fixes

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit 718780d20470c66a3a36d036b29148d5809dc855: Merge tag 'pull-nvme-20241001' of https://gitlab.com/birkelund/qemu into staging (2024-10-01 11:34:07 +0100) are available in the Git repository at: https://gitlab.com/marcandre.lureau/qem

[PULL 11/22] block/block-copy: fix -Werror=maybe-uninitialized false-positive

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau ../block/block-copy.c:591:12: error: ‘ret’ may be used uninitialized [-Werror=maybe-uninitialized] Signed-off-by: Marc-André Lureau Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/block-copy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/blo

[PULL 01/22] util/coroutine: fix -Werror=maybe-uninitialized false-positive

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau ../util/qemu-coroutine.c:150:8: error: ‘batch’ may be used uninitialized [-Werror=maybe-uninitialized] Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Hajnoczi --- util/qemu-coroutine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qemu

[PULL 04/22] nbd: fix -Werror=maybe-uninitialized false-positive

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau ../nbd/client-connection.c:419:8: error: ‘wait_co’ may be used uninitialized [-Werror=maybe-uninitialized] Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- nbd/client-connection.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbd/clie

[PULL 09/22] hw/vhost-scsi: fix -Werror=maybe-uninitialized

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau ../hw/scsi/vhost-scsi.c:173:12: error: ‘ret’ may be used uninitialized [-Werror=maybe-uninitialized] It can be reached when num_queues=0. It probably doesn't make much sense to instantiate a vhost-scsi with 0 IO queues though. For now, make vhost_scsi_set_workers() retur

[PULL 03/22] hw/qxl: fix -Werror=maybe-uninitialized false-positives

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau ../hw/display/qxl.c:1352:5: error: ‘pci_region’ may be used uninitialized [-Werror=maybe-uninitialized] ../hw/display/qxl.c:1365:22: error: ‘pci_start’ may be used uninitialized [-Werror=maybe-uninitialized] Signed-off-by: Marc-André Lureau Reviewed-by: Manos Pitsidian

[PULL 07/22] block/stream: fix -Werror=maybe-uninitialized false-positives

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau ../block/stream.c:193:19: error: ‘unfiltered_bs’ may be used uninitialized [-Werror=maybe-uninitialized] ../block/stream.c:176:5: error: ‘len’ may be used uninitialized [-Werror=maybe-uninitialized] trace/trace-block.h:906:9: error: ‘ret’ may be used uninitialized [-Wer

[PULL 15/22] linux-user/hppa: fix -Werror=maybe-uninitialized false-positive

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau ../linux-user/hppa/cpu_loop.c: In function ‘hppa_lws’: ../linux-user/hppa/cpu_loop.c:106:17: error: ‘ret’ may be used uninitialized [-Werror=maybe-uninitialized] 106 | env->gr[28] = ret; Add g_assert_not_reached() to help compiler, as suggested by Laurent. Signed-

[PULL 08/22] hw/ahci: fix -Werror=maybe-uninitialized false-positive

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau ../hw/ide/ahci.c:989:58: error: ‘tbl_entry_size’ may be used uninitialized [-Werror=maybe-uninitialized] Signed-off-by: Marc-André Lureau Reviewed-by: Manos Pitsidianakis --- hw/ide/ahci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ide/ah

[PULL 13/22] hw/virtio-blk: fix -Werror=maybe-uninitialized false-positive

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau ../hw/block/virtio-blk.c:1212:12: error: ‘rq’ may be used uninitialized [-Werror=maybe-uninitialized] Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Hajnoczi Reviewed-by: Stefano Garzarella --- hw/block/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PULL 02/22] util/timer: fix -Werror=maybe-uninitialized false-positive

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau ../util/qemu-timer.c:198:24: error: ‘expire_time’ may be used uninitialized [-Werror=maybe-uninitialized] ../util/qemu-timer.c:476:8: error: ‘rearm’ may be used uninitialized [-Werror=maybe-uninitialized] Signed-off-by: Marc-André Lureau Reviewed-by: Manos Pitsidianaki

[PULL 19/22] hw/virtio: freeing leaked memory from vhost_svq_get_buf in vhost_svq_poll

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau vhost_svq_get_buf() may return a VirtQueueElement that should be freed. Signed-off-by: Marc-André Lureau Reviewed-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost-shadow-virt

[PULL 12/22] migration: fix -Werror=maybe-uninitialized false-positives

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau ../migration/dirtyrate.c:186:5: error: ‘records’ may be used uninitialized [-Werror=maybe-uninitialized] ../migration/dirtyrate.c:168:12: error: ‘gen_id’ may be used uninitialized [-Werror=maybe-uninitialized] ../migration/migration.c:2273:5: error: ‘file’ may be used un

[PULL 21/22] fsdep/9p: fix -Werror=maybe-uninitialized false-positive

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau ../fsdev/9p-iov-marshal.c:93:23: error: ‘val’ may be used uninitialized [-Werror=maybe-uninitialized] and similar Signed-off-by: Marc-André Lureau Reviewed-by: Christian Schoenebeck --- fsdev/9p-iov-marshal.c | 15 --- 1 file changed, 12 insertions(+), 3 d

[PULL 16/22] target/loongarch: fix -Werror=maybe-uninitialized false-positive

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau ../target/loongarch/gdbstub.c:55:20: error: ‘val’ may be used uninitialized [-Werror=maybe-uninitialized] 55 | return gdb_get_reg32(mem_buf, val); |^~~ ../target/loongarch/gdbstub.c:39:18: note: ‘val’ was de

[PULL 18/22] hw/virtio: fix -Werror=maybe-uninitialized

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau ../hw/virtio/vhost-shadow-virtqueue.c:545:13: error: ‘r’ may be used uninitialized [-Werror=maybe-uninitialized] Set `r` to 0 at every loop, since we don't check vhost_svq_get_buf() return value. Signed-off-by: Marc-André Lureau Reviewed-by: Stefano Garzarella --- hw

[PULL 06/22] block/mirror: fix -Werror=maybe-uninitialized false-positive

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau ../block/mirror.c:404:5: error: ‘ret’ may be used uninitialized [-Werror=maybe-uninitialized] ../block/mirror.c:895:12: error: ‘ret’ may be used uninitialized [-Werror=maybe-uninitialized] ../block/mirror.c:578:12: error: ‘ret’ may be used uninitialized [-Werror=maybe-u

[PULL 10/22] hw/sdhci: fix -Werror=maybe-uninitialized false-positive

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau ../hw/sd/sdhci.c:846:16: error: ‘res’ may be used uninitialized [-Werror=maybe-uninitialized] False-positive, because "length" is non-null. Signed-off-by: Marc-André Lureau Reviewed-by: Alex Bennée --- hw/sd/sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[PULL 20/22] block: fix -Werror=maybe-uninitialized false-positive

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau ../block/file-posix.c:1405:17: error: ‘zoned’ may be used uninitialized [-Werror=maybe-uninitialized] 1405 | if (ret < 0 || zoned == BLK_Z_NONE) { Signed-off-by: Marc-André Lureau Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/file-posix.c | 2 +- 1 file cha

[PULL 17/22] tests: fix -Werror=maybe-uninitialized false-positive

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau ../tests/unit/test-block-iothread.c:773:17: error: ‘job’ may be used uninitialized [-Werror=maybe-uninitialized] /usr/include/glib-2.0/glib/gtestutils.h:73:53: error: ‘ret’ may be used uninitialized [-Werror=maybe-uninitialized] Signed-off-by: Marc-André Lureau Reviewe

[PULL 05/22] block/mirror: fix -Werror=maybe-uninitialized false-positive

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau ../block/mirror.c:1066:22: error: ‘iostatus’ may be used uninitialized [-Werror=maybe-uninitialized] Signed-off-by: Marc-André Lureau Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block

[PULL 14/22] migration: fix -Werror=maybe-uninitialized false-positive

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau ../migration/ram.c:1873:23: error: ‘dirty’ may be used uninitialized [-Werror=maybe-uninitialized] When 'block' != NULL, 'dirty' is initialized. Signed-off-by: Marc-André Lureau Acked-by: Peter Xu --- migration/ram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PULL 22/22] qom/object: fix -Werror=maybe-uninitialized

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau object_resolve_path_type() sets *ambiguousp only when it is. Fixes: 81c48dd79655 (hw/i386/acpi: Add object_resolve_type_unambiguous to improve modularity) Signed-off-by: Marc-André Lureau Reviewed-by: Vladimir Sementsov-Ogievskiy --- qom/object.c | 2 +- 1 file change

Re: [PULL 03/22] hw/qxl: fix -Werror=maybe-uninitialized false-positives

2024-10-02 Thread Thomas Huth
On 02/10/2024 10.36, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau ../hw/display/qxl.c:1352:5: error: ‘pci_region’ may be used uninitialized [-Werror=maybe-uninitialized] ../hw/display/qxl.c:1365:22: error: ‘pci_start’ may be used uninitialized [-Werror=maybe-uninitialized] Sign

Re: [PATCH v3 21/22] qom/object: fix -Werror=maybe-uninitialized

2024-10-02 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Wed, Oct 2, 2024 at 10:21 AM Markus Armbruster wrote: [...] >> Two ways to fix: >> >> 1. Find all callers that don't, and fix them. Your first hunk is then >>superfluous. Your second hunk fixes the one you already found. >> > > Imho, that's not a goo

Re: [PATCH v3 02/14] hw/display/apple-gfx: Adds PCI implementation

2024-10-02 Thread Akihiko Odaki
On 2024/09/28 17:57, Phil Dennis-Jordan wrote: This change wires up the PCI variant of the paravirtualised graphics device, mainly useful for x86-64 macOS guests, implemented by macOS's ParavirtualizedGraphics.framework. It builds on code shared with the vmapple/mmio variant of the PVG device. S

Re: [PATCH v3 03/14] ui/cocoa: Adds non-app runloop on main thread mode

2024-10-02 Thread Akihiko Odaki
On 2024/09/28 17:57, Phil Dennis-Jordan wrote: Various system frameworks on macOS and other Apple platforms require a main runloop to be processing events on the process’s main thread. The Cocoa UI’s requirement to run the process as a Cocoa application automatically enables this runloop, but it

Re: [PATCH v1] linux-user: Add option to run `execve`d programs through QEMU

2024-10-02 Thread Ilya Leoshkevich
On Fri, 2024-08-30 at 15:36 -0700, Noah Goldstein wrote: > The new option '-qemu-children' makes it so that on `execve` the > child > process will be launch by the same `qemu` executable that is > currently > running along with its current commandline arguments. > > The motivation for the change i

[PATCH 2/3] qom: set *ambiguous on all paths

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau So the caller contract is simpler. Signed-off-by: Marc-André Lureau --- qom/object.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qom/object.c b/qom/object.c index 0adbef2946..222804dcfb 100644 --- a/qom/object.c +++ b/qom/object.c @@ -2201,6 +2201,9 @@ Object

[PATCH 3/3] qom: update object_resolve_path*() documentation

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau - update doc to reflect that @ambiguous is now set true or false on failure - specify that @ambiguous is nullable - use some gtk-doc annotations Signed-off-by: Marc-André Lureau --- include/qom/object.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[PATCH 1/3] qom: rename object_resolve_path_type() "ambiguousp"

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau Make it match the function declaration & documentation. Signed-off-by: Marc-André Lureau --- qom/object.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qom/object.c b/qom/object.c index 28c5b66eab..0adbef2946 100644 --- a/qom/object.c ++

Re: [PATCH v3 1/5] linux-user: Correct print_sockaddr() format

2024-10-02 Thread Ilya Leoshkevich
On Wed, 2024-08-07 at 14:43 +0200, Philippe Mathieu-Daudé wrote: > When the %addr argument can not be accessed, a double comma > is logged (the final qemu_log call prepend a comma). Call > print_raw_param with last=1 to avoid the extra comma. > Remove spurious space. > > Signed-off-by: Philippe Ma

[PATCH 0/3] QOM: little improvements to object_resolve_path*()

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau Hi, Some improvements suggested by Markus during the review of "[PATCH v3 21/22] qom/object: fix -Werror=maybe-uninitialized". Marc-André Lureau (3): qom: rename object_resolve_path_type() "ambiguousp" qom: set *ambiguous on all paths qom: update object_resolve_pat

[PULL 06/10] qapi/rocker: Supply missing member documentation

2024-10-02 Thread Markus Armbruster
Since we neglect to document the argument of query-rocker and query-rocker-ports, their description in the QEMU QMP Reference manual is "Not documented". Fix that. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Message-ID: <2024092545.2248881-7-arm...@redhat.com> ---

[PULL 05/10] qapi/pci: Supply missing member documentation

2024-10-02 Thread Markus Armbruster
Since we neglect to document a member of PciMemoryRegion, its description in the QEMU QMP Reference manual is "Not documented". Fix that. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Message-ID: <2024092545.2248881-6-arm...@redhat.com> Reviewed-by: Michael S. Tsirkin

[PULL 10/10] qapi/block-core: Drop drive-backup's "Any other error" documentation

2024-10-02 Thread Markus Armbruster
We've always been rather lax about documenting errors. Many "Errors" sections are obviously not exhaustive. Only drive-backup is explicit about this: "Any other error returns a GenericError". Not useful. Drop. Signed-off-by: Markus Armbruster Message-ID: <20240911132459.2548063-3-arm...@redha

Re: [PATCH v5] testing: bump mips64el cross to bookworm and fix package list

2024-10-02 Thread Daniel P . Berrangé
On Wed, Oct 02, 2024 at 10:03:33AM +0200, Thomas Huth wrote: > From: Alex Bennée > > The mips64el cross setup is very broken for bullseye which has now > entered LTS support so is unlikely to be fixed. While we still can't > build the container with all packages for bookworm due to a single > mis

[PULL 08/10] qapi: Document QCryptodevBackendServiceType

2024-10-02 Thread Markus Armbruster
From: zhenwei pi QCryptodevBackendServiceType was introduced by bc304a6442e (cryptodev: Introduce server type in QAPI). However there is a lack of member description. Reported-by: Markus Armbruster Signed-off-by: zhenwei pi Reviewed-by: Markus Armbruster [Drop QCryptodevBackendServiceType fro

[PULL 07/10] qapi/cxl: Supply missing member documentation

2024-10-02 Thread Markus Armbruster
Since we neglect to document a member of CxlCorErrorType, its description in the QEMU QMP Reference manual is "Not documented". Fix that. Signed-off-by: Markus Armbruster Message-ID: <2024092545.2248881-8-arm...@redhat.com> --- qapi/cxl.json| 3 +++ qapi/pragma.json | 1 - 2 files chang

[PULL 09/10] qapi: Drop "with an explanation" from error descriptions

2024-10-02 Thread Markus Armbruster
All errors come with an explanation, namely the human-readable error message in the error response's @desc member. Drop the redundant "with an explanation" phrase. Signed-off-by: Markus Armbruster Message-ID: <20240911132459.2548063-2-arm...@redhat.com> Reviewed-by: Eric Blake --- qapi/block-c

[PATCH v3] docs: Mark "gluster" support in QEMU as deprecated

2024-10-02 Thread Thomas Huth
According to https://marc.info/?l=fedora-devel-list&m=171934833215726 the GlusterFS development effectively ended. Thus mark it as deprecated in QEMU, so we can remove it in a future release if the project does not gain momentum again. Acked-by: Niels de Vos Acked-by: Markus Armbruster Signed-of

Re: [PATCH 06/13] tests/tcg/plugins: Use the ld/st_endian_p() API

2024-10-02 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Refactor to use the recently introduced ld/st_endian_p() API > No logical change intended. > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v2 07/15] acpi/ghes: Change the type for source_id

2024-10-02 Thread Igor Mammedov
On Tue, 1 Oct 2024 09:03:44 +0200 Mauro Carvalho Chehab wrote: > HEST source ID is actually a 16-bit value add here spec/ver/chapter/table reference as a confirmation of above statement. > Signed-off-by: Mauro Carvalho Chehab > Reviewed-by: Jonathan Cameron > --- > hw/acpi/ghes-stub.c|

Re: {PATCH] accel/tcg: Fix CPU specific unaligned behaviour

2024-10-02 Thread Alex Bennée
Peter Maydell writes: > On Wed, 2 Oct 2024 at 16:35, Alex Bennée wrote: >> >> Helge Deller writes: >> >> > When the emulated CPU reads or writes to a memory location >> > a) for which no read/write permissions exists, *and* >> > b) the access happens unaligned (non-natural alignment), >> > then

Re: [PULL 00/22] -Werror=maybe-uninitialized fixes

2024-10-02 Thread Marc-André Lureau
Hi On Wed, Oct 2, 2024 at 12:43 PM Thomas Huth wrote: > On 02/10/2024 10.36, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > The following changes since commit > 718780d20470c66a3a36d036b29148d5809dc855: > > > >Merge tag 'pull-nvme-20241001' of https://gitlab.com/birk

Re: [PULL 00/22] -Werror=maybe-uninitialized fixes

2024-10-02 Thread Thomas Huth
On 02/10/2024 10.36, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau The following changes since commit 718780d20470c66a3a36d036b29148d5809dc855: Merge tag 'pull-nvme-20241001' of https://gitlab.com/birkelund/qemu into staging (2024-10-01 11:34:07 +0100) are available in the Gi

Re: [PATCH v1 00/14] s390x: virtio-mem support

2024-10-02 Thread Janosch Frank
On 10/1/24 10:54 AM, David Hildenbrand wrote: On 30.09.24 23:49, Halil Pasic wrote: On Fri, 27 Sep 2024 20:29:19 +0200 David Hildenbrand wrote: On 27.09.24 20:20, Halil Pasic wrote: On Wed, 11 Sep 2024 21:09:27 +0200 David Hildenbrand wrote: [...] That is a valid point. But IMHO the ben

Re: {PATCH] accel/tcg: Fix CPU specific unaligned behaviour

2024-10-02 Thread Helge Deller
On 10/2/24 17:47, Peter Maydell wrote: On Wed, 2 Oct 2024 at 16:35, Alex Bennée wrote: Helge Deller writes: When the emulated CPU reads or writes to a memory location a) for which no read/write permissions exists, *and* b) the access happens unaligned (non-natural alignment), then the CPU s

Re: [PATCH v2 08/17] migration: Add load_finish handler and associated functions

2024-10-02 Thread Maciej S. Szmigiero
On 1.10.2024 23:30, Peter Xu wrote: On Tue, Oct 01, 2024 at 10:41:14PM +0200, Maciej S. Szmigiero wrote: On 30.09.2024 23:57, Peter Xu wrote: On Mon, Sep 30, 2024 at 09:25:54PM +0200, Maciej S. Szmigiero wrote: On 27.09.2024 02:53, Peter Xu wrote: On Fri, Sep 27, 2024 at 12:34:31AM +0200, Mac

Re: [PULL 3/5] block/reqlist: allow adding overlapping requests

2024-10-02 Thread Vladimir Sementsov-Ogievskiy
On 01.10.24 19:28, Michael Tokarev wrote: 30.09.2024 11:43, Vladimir Sementsov-Ogievskiy wrote: From: Fiona Ebner Allow overlapping request by removing the assert that made it impossible. There are only two callers: 1. block_copy_task_create() It already asserts the very same condition befor

Re: [PATCH v3 3/5] linux-user: Factor print_buf_len() out

2024-10-02 Thread Ilya Leoshkevich
On Wed, 2024-08-07 at 14:43 +0200, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- >  linux-user/strace.c | 13 + >  1 file changed, 9 insertions(+), 4 deletions(-) Reviewed-by: Ilya Leoshkevich

Re: [PATCH 0/2] Finish eliminating QERR_UNSUPPORTED

2024-10-02 Thread Markus Armbruster
Queued.

Re: [PATCH v3 4/5] linux-user: Add strace for sendto()

2024-10-02 Thread Ilya Leoshkevich
On Wed, 2024-08-07 at 14:43 +0200, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- >  linux-user/strace.c    | 15 +++ >  linux-user/strace.list |  2 +- >  2 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/linux-user/strace.c b/linux-user/str

Re: [PATCH v3 2/5] linux-user: Display sockaddr buffer as pointer

2024-10-02 Thread Ilya Leoshkevich
On Wed, 2024-08-07 at 14:43 +0200, Philippe Mathieu-Daudé wrote: > Rather than 'raw param', display as pointer to get > "NULL" instead of "0x". > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Richard Henderson Reviewed-by: Ilya Leoshkevich

[PULL 02/10] qapi/common: Supply missing member documentation

2024-10-02 Thread Markus Armbruster
Since we neglect to document the members of GrabToggleKeys, their description in the QEMU QMP Reference manual is "Not documented". Fix that. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Message-ID: <2024092545.2248881-3-arm...@redhat.com> --- qapi/common.json | 14

[PULL 04/10] qapi/introspect: Supply missing member documentation

2024-10-02 Thread Markus Armbruster
Since we neglect to document the members of JSONType, their description in the QEMU QMP Reference manual is "Not documented". Fix that. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-ID: <2024092545.2248881-5-arm...@redhat.com> --- qapi/introspect.json | 16 ++

[PULL 03/10] qapi/crypto: Supply missing member documentation

2024-10-02 Thread Markus Armbruster
Since we neglect to document the members of QCryptoAkCipherKeyType, their description in the QEMU QMP Reference manual is "Not documented". Fix that. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Message-ID: <2024092545.2248881-4-arm...@redhat.com> --- qapi/crypto.js

[PULL 01/10] qapi/char: Supply missing member documentation

2024-10-02 Thread Markus Armbruster
Since we neglect to document several members of ChardevBackendKind, their description in the QEMU QMP Reference manual is "Not documented". Fix that, and improve the existing member documentation. Signed-off-by: Markus Armbruster Message-ID: <2024092545.2248881-2-arm...@redhat.com> --- qapi

[PULL 00/10] QAPI patches patches for 2024-10-02

2024-10-02 Thread Markus Armbruster
The following changes since commit 718780d20470c66a3a36d036b29148d5809dc855: Merge tag 'pull-nvme-20241001' of https://gitlab.com/birkelund/qemu into staging (2024-10-01 11:34:07 +0100) are available in the Git repository at: https://repo.or.cz/qemu/armbru.git tags/pull-qapi-2024-10-02 for

[PATCH v5] testing: bump mips64el cross to bookworm and fix package list

2024-10-02 Thread Thomas Huth
From: Alex Bennée The mips64el cross setup is very broken for bullseye which has now entered LTS support so is unlikely to be fixed. While we still can't build the container with all packages for bookworm due to a single missing dependency that will hopefully get fixed in due course. For the sake

Re: [PATCH v3 21/22] qom/object: fix -Werror=maybe-uninitialized

2024-10-02 Thread Vladimir Sementsov-Ogievskiy
On 01.10.24 18:22, Marc-André Lureau wrote: Hi Vladimir On Tue, Oct 1, 2024 at 6:06 PM Vladimir Sementsov-Ogievskiy mailto:vsement...@yandex-team.ru>> wrote: On 30.09.24 11:14, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau mailto:mar

Re: [PATCH v3 21/22] qom/object: fix -Werror=maybe-uninitialized

2024-10-02 Thread Marc-André Lureau
Hi On Wed, Oct 2, 2024 at 10:21 AM Markus Armbruster wrote: > > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > object_resolve_path_type() didn't always set *ambiguousp. > > > > Signed-off-by: Marc-André Lureau > > Fixes: 81c48dd79655 (hw/i386/acpi: Add object_resolve_

[PATCH] linux-user/elfload.c: keep GNU0_MAGIC in host byte order

2024-10-02 Thread Michael Tokarev
Other places of this file operate in host byte order. Only this constant is defined as little-endian. This does not work, for example, on s390x host when running an arm64 binary: qemu-arm64: /usr/bin/busybox: Invalid note in PT_GNU_PROPERTY This change is tested on all combinations of host/gue

Re: [PATCH v3 4/5] block: allow commit to unmap zero blocks

2024-10-02 Thread Vladimir Sementsov-Ogievskiy
On 01.09.24 17:24, Vincent Vanlaer wrote: Non-active block commits do not discard blocks only containing zeros, causing images to lose sparseness after the commit. This commit fixes that by writing zero blocks using blk_co_pwrite_zeroes rather than writing them out as any other arbitrary data. S

Re: [PATCH v2 08/17] migration: Add load_finish handler and associated functions

2024-10-02 Thread Peter Xu
On Wed, Oct 02, 2024 at 10:11:33PM +0200, Maciej S. Szmigiero wrote: > On 1.10.2024 23:30, Peter Xu wrote: > > On Tue, Oct 01, 2024 at 10:41:14PM +0200, Maciej S. Szmigiero wrote: > > > On 30.09.2024 23:57, Peter Xu wrote: > > > > On Mon, Sep 30, 2024 at 09:25:54PM +0200, Maciej S. Szmigiero wrote:

[PULL v2 00/22] -Werror=maybe-uninitialized fixes

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit 062cfce8d4c077800d252b84c65da8a2dd03fd6f: Merge tag 'pull-target-arm-20241001' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-10-01 17:40:25 +0100) are available in the Git repository at: https://gitlab.com

Re: [PATCH v2 14/15] acpi/ghes: better name the offset of the hardware error firmware

2024-10-02 Thread Igor Mammedov
On Tue, 1 Oct 2024 09:03:51 +0200 Mauro Carvalho Chehab wrote: > The hardware error firmware is where HEST error structures are > stored. Those can be GHESv2, but they can also be other types. > > Better name the location of the hardware error. > > No functional changes. > > Signed-off-by: Ma

Re: [PATCH v2 12/15] acpi/ghes: don't crash QEMU if ghes GED is not found

2024-10-02 Thread Igor Mammedov
On Tue, 1 Oct 2024 09:03:49 +0200 Mauro Carvalho Chehab wrote: > Instead, produce an error and continue working s//make error handling within ... consistent, i.e. instead abort just print a error in case ... / > > Signed-off-by: Mauro Carvalho Chehab > --- > hw/acpi/ghes.c | 5 - >

[PULL 2/5] configs: Fix typo in the sh4-softmmu devices config file

2024-10-02 Thread Thomas Huth
This is the config file for the little endian target, so there should not be a "eb" in here. Message-ID: <20240920161045.84622-1-th...@redhat.com> Reviewed-by: Richard Henderson Reviewed-by: Yoshinori Sato Signed-off-by: Thomas Huth --- configs/devices/sh4-softmmu/default.mak | 2 +- 1 file ch

[PULL 4/5] qemu-timer: Remove unused timer functions

2024-10-02 Thread Thomas Huth
From: "Dr. David Alan Gilbert" qemu_clock_get_main_loop_timerlist and timerlist_get_clock have been unused since they were originally added in ff83c66ecc ("aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList") Remove them. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Bernhar

[PULL 0/5] Fix mips64el CI job + some other misc patches

2024-10-02 Thread Thomas Huth
The following changes since commit 718780d20470c66a3a36d036b29148d5809dc855: Merge tag 'pull-nvme-20241001' of https://gitlab.com/birkelund/qemu into staging (2024-10-01 11:34:07 +0100) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2024-10-02 f

  1   2   >