[PATCH] contrib/plugins: ensure build does not pick up a system copy of plugin header

2024-09-20 Thread Brad Smith
contrib/plugins: ensure build does not pick up a system copy of plugin header With the ordering of the header path if a copy of QEMU is installed it will pickup the system copy of the header before the build paths copy and the build will fail. Signed-off-by: Brad Smith --- contrib/plugins/Makef

Re: [PATCH v2] target-i386: Walk NPT in guest real mode

2024-09-20 Thread Richard Henderson
On 9/20/24 18:10, Alexander Graf wrote: +/* No paging (real mode), let's assemble a fake 1:1 1GiB PTE */ Comment is out of date. :-) Otherwise, Reviewed-by: Richard Henderson r~

Re: [PATCH v3] i386/cpu: fixup number of addressable IDs for logical processors in the physical package

2024-09-20 Thread Igor Mammedov
On Fri, 20 Sep 2024 02:29:46 +0800 Zhao Liu wrote: > Hi Chuang and Igor, > > Sorry for late reply, > > On Wed, Sep 18, 2024 at 09:18:15PM +0800, Chuang Xu wrote: > > Date: Wed, 18 Sep 2024 21:18:15 +0800 > > From: Chuang Xu > > Subject: [PATCH v3] i386/cpu: fixup number of addressable IDs for

[PULL 09/22] hw/display: Fix mirrored output in dm163

2024-09-20 Thread Michael Tokarev
From: Inès Varhol DM163 is an emulated 8x8 LED matrix. This commit flips the image horizontally so it's rendered the same way as on the hardware. Signed-off-by: Inès Varhol Signed-off-by: Michael Tokarev --- hw/display/dm163.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PULL 20/22] license: Update deprecated SPDX tag LGPL-2.0+ to LGPL-2.0-or-later

2024-09-20 Thread Michael Tokarev
From: Philippe Mathieu-Daudé The 'LGPL-2.0+' license identifier has been deprecated since license list version 2.0rc2 [1] and replaced by the 'LGPL-2.0-or-later' [2] tag. [1] https://spdx.org/licenses/LGPL-2.0+.html [2] https://spdx.org/licenses/LGPL-2.0-or-later.html Mechanical patch running:

[PULL 12/22] util/cutils: Remove unused qemu_get_exec_dir

2024-09-20 Thread Michael Tokarev
From: "Dr. David Alan Gilbert" qemu_get_exec_dir has been unused since commit: 5bebe03f51 ("util/cutils: Clean up global variable shadowing in get_relocated_path()") Remove it, and fix up a comment that pointed to it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Michael Tokarev Signe

[PATCH V3] arm/kvm: add support for MTE

2024-09-20 Thread Ganapatrao Kulkarni
Extend the 'mte' property for the virt machine to cover KVM as well. For KVM, we don't allocate tag memory, but instead enable the capability. If MTE has been enabled, we need to disable migration, as we do not yet have a way to migrate the tags as well. Therefore, MTE will stay off with KVM unles

Re: [PATCH] tests/qemu-iotests/testenv: Use the "r2d" machine for sh4/sh4eb

2024-09-20 Thread Thomas Huth
On 20/09/2024 10.06, Yoshinori Sato wrote: On Wed, 18 Sep 2024 04:43:50 +0900, Thomas Huth wrote: Commit 0ea0538fae516f9b4 removed the default machine of the sh4 binaries, so a lot of iotests are failing now without such a default machine. Teach the iotest harness to use the "r2d" machine inste

[PATCH v6 0/1] linux-user: add openat2 support in linux-user

2024-09-20 Thread Michael Vogt
Hi, This is v6 of the openat2 support in linux-user. Thanks agan for the excellent feedback from Laurent Vivier on v5. This version is very close to v5 and only fixes the small details that I overlooked in my previous patch (sorry for that). This time I hopefully also fixed my git send email setu

[PATCH v6 1/1] linux-user: add openat2 support in linux-user

2024-09-20 Thread Michael Vogt
This commit adds support for the `openat2()` syscall in the `linux-user` userspace emulator. It is implemented by extracting a new helper `maybe_do_fake_open()` out of the exiting `do_guest_openat()` and share that with the new `do_guest_openat2()`. Unfortunately we cannot just make do_guest_opena

Re: [PATCH] target/ppc: Fix lxvx/stxvx facility check

2024-09-20 Thread Ilya Leoshkevich
On Thu, 2024-09-19 at 13:36 +0200, Claudio Fontana wrote: > ping, adding Richard. > > We will need to include this downstream because of the breakage its > lack causes. > It is already reviewed by me, but some TCG maintainer indicating it > will be included in some queue would help, > > Thanks, >

Re: [PATCH v5 0/3] vhost-user-blk: live resize additional APIs

2024-09-20 Thread Vladimir Sementsov-Ogievskiy
On 11.09.24 12:51, Michael S. Tsirkin wrote: On Tue, Jun 25, 2024 at 03:18:40PM +0300, Vladimir Sementsov-Ogievskiy wrote: v5: 03: drop extra check on is is runstate running Causes build failures when generating qdoc. https://gitlab.com/mstredhat/qemu/-/jobs/7792086965 Sorry for a delay,

[PATCH v6 1/3] qdev-monitor: add option to report GenericError from find_device_state

2024-09-20 Thread Vladimir Sementsov-Ogievskiy
Here we just prepare for the following patch, making possible to report GenericError as recommended. This patch doesn't aim to prevent further use of DeviceNotFound by future interfaces: - find_device_state() is used in blk_by_qdev_id() and qmp_get_blk() functions, which may lead to spread of

[PATCH v6 3/3] qapi: introduce device-sync-config

2024-09-20 Thread Vladimir Sementsov-Ogievskiy
Add command to sync config from vhost-user backend to the device. It may be helpful when VHOST_USER_SLAVE_CONFIG_CHANGE_MSG failed or not triggered interrupt to the guest or just not available (not supported by vhost-user server). Command result is racy if allow it during migration. Let's not allo

[PATCH v6 0/3] vhost-user-blk: live resize additional APIs

2024-09-20 Thread Vladimir Sementsov-Ogievskiy
v6: tiny fix: add document comment for sync_config field to fix qdoc generation. Also, add r-b and a-b marks. Vladimir Sementsov-Ogievskiy (3): qdev-monitor: add option to report GenericError from find_device_state vhost-user-blk: split vhost_user_blk_sync_config() qapi: introduce device-syn

[PULL 10/22] envlist: Remove unused envlist_parse

2024-09-20 Thread Michael Tokarev
From: "Dr. David Alan Gilbert" envlist_parse, envlist_parse_set, envlist_parse_unset were added in 2009 but never used, see: 04a6dfebb6 ("linux-user: Add generic env variable handling") Remove them. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Michael Tokarev Signed-off-by: Michael To

qemu-devel@nongnu.org

2024-09-20 Thread Michael Tokarev
Since we are always building with LFS enabled, in particular with -D_FILE_OFFSET_BITS=64, we should always have struct flock mapped to the 64bit variant (with off64_t), and F_GETLK mapped to F_GETLK64 etc, automatically. So there should be no need to explicitly use the "64" suffix for these things

[PULL 11/22] hw/sysbus: Remove unused sysbus_mmio_unmap

2024-09-20 Thread Michael Tokarev
From: "Dr. David Alan Gilbert" The last use of sysbus_mmio_unmap was removed by 981b1c6266 ("spapr/xive: rework the mapping the KVM memory regions") Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Daniel P. Berrangé Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev

[PULL 01/22] mark with for-crc32 in a consistent manner

2024-09-20 Thread Michael Tokarev
in many cases, is only included for crc32 function, and in some of them, there's a comment saying that, but in a different way. In one place (hw/net/rtl8139.c), there was another #include added between the comment and include. Make all such comments to be on the same line as #include, make it c

[PULL 00/22] Trivial patches for 2024-09-20

2024-09-20 Thread Michael Tokarev
The following changes since commit 01dc65a3bc262ab1bec8fe89775e9bbfa627becb: Merge tag 'pull-target-arm-20240919' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-09-19 14:15:15 +0100) are available in the Git repository at: https://gitlab.com/mjt0k/qemu.git tags/pull-

Re: [PATCH v6 1/1] linux-user: add openat2 support in linux-user

2024-09-20 Thread Laurent Vivier
Le 20/09/2024 à 11:22, Michael Vogt a écrit : This commit adds support for the `openat2()` syscall in the `linux-user` userspace emulator. It is implemented by extracting a new helper `maybe_do_fake_open()` out of the exiting `do_guest_openat()` and share that with the new `do_guest_openat2()`.

[PATCH v6] ptp: Add support for the AMZNC10C 'vmclock' device

2024-09-20 Thread David Woodhouse
From: David Woodhouse The vmclock device addresses the problem of live migration with precision clocks. The tolerances of a hardware counter (e.g. TSC) are typically around ±50PPM. A guest will use NTP/PTP/PPS to discipline that counter against an external source of 'real' time, and track the pre

Re: [RFC] Virtualizing tagged disaggregated memory capacity (app specific, multi host shared)

2024-09-20 Thread Gregory Price
> > 2. Coarse grained memory increases for 'normal' memory. > > Can use memory hot-plug. Recovery of capacity likely to only be > > possible on > > VM shutdown. > > Is there are reason "movable" (ZONE_MOVABLE) is not an option, at least in > some setups? If not, why? > This seems like a

[PATCH 08/10] hw/intc/loongarch_extioi: Inherit from loongarch_extioi_common

2024-09-20 Thread Bibo Mao
Set TYPE_LOONGARCH_EXTIOI inherit from TYPE_LOONGARCH_EXTIOI_COMMON object, it shares vmsate and property of TYPE_LOONGARCH_EXTIOI_COMMON, and has its own realize() function. Signed-off-by: Bibo Mao --- hw/intc/loongarch_extioi.c| 37 ++--- hw/intc/loongarch_extio

[PATCH 01/10] include: Add loongarch_extioi_common header file

2024-09-20 Thread Bibo Mao
Add common header file include/hw/intc/loongarch_extioi_common.h, and move some macro definition from include/hw/intc/loongarch_extioi.h to the common header file. Signed-off-by: Bibo Mao --- include/hw/intc/loongarch_extioi.h| 50 +-- include/hw/intc/loongarch_extioi_com

[PATCH 05/10] hw/intc/loongarch_extioi: Add common realize interface

2024-09-20 Thread Bibo Mao
Add common realize function, it is only to check validity of property. Signed-off-by: Bibo Mao --- hw/intc/loongarch_extioi.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/hw/intc/loongarch_extioi.c b/hw/intc/loongarch_extioi.c index 409d4a85da..8ac246c2e

[PATCH 09/10] hw/intc/loongarch_extioi: Add pre_save interface

2024-09-20 Thread Bibo Mao
Add vmstate pre_save interface, which can be used extioi kvm driver in future. Signed-off-by: Bibo Mao --- hw/intc/loongarch_extioi_common.c | 13 + include/hw/intc/loongarch_extioi_common.h | 1 + 2 files changed, 14 insertions(+) diff --git a/hw/intc/loongarch_extioi_comm

[PATCH 03/10] include: Rename LoongArchExtIOI with LoongArchExtIOICommonState

2024-09-20 Thread Bibo Mao
Rename structure LoongArchExtIOI with LoongArchExtIOICommonState, since it is defined in file loongarch_extioi_common.h Signed-off-by: Bibo Mao --- include/hw/intc/loongarch_extioi.h| 1 + include/hw/intc/loongarch_extioi_common.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)

[PATCH 06/10] hw/intc/loongarch_extioi: Add unrealize interface

2024-09-20 Thread Bibo Mao
For loongarch extioi emulation driver, add unrealize interface and remove instance_finalize interface and move the code to unrealize interface. Signed-off-by: Bibo Mao --- hw/intc/loongarch_extioi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/intc/loongarch_extio

[PATCH 04/10] hw/intc/loongarch_extioi: Rename LoongArchExtIOI with LoongArchExtIOICommonState

2024-09-20 Thread Bibo Mao
With some structure such as vmstate and property, rename LoongArchExtIOI with LoongArchExtIOICommonState, these common structure will be moved to common file. Signed-off-by: Bibo Mao --- hw/intc/loongarch_extioi.c | 41 +++--- 1 file changed, 25 insertions(+), 16

[PATCH 00/10] hw/intc/loongarch_extioi: Split into extioi common and extioi

2024-09-20 Thread Bibo Mao
In order to support irqchip_in_kenrel method, split loongarch extioi emulation driver into two parts, extioi common and extioi TCG driver. LoongArch extioi common driver includes vmstate and property interface, also vmstate load and store interface is defined in extioi common driver. In future Loo

[PATCH 10/10] hw/intc/loongarch_extioi: Code cleanup about loongarch_extioi

2024-09-20 Thread Bibo Mao
Remove definition about LoongArchExtIOI and LOONGARCH_EXTIOI, and replace them with LoongArchExtIOICommonState and macro LOONGARCH_EXTIOI_COMMON separately. Also remove unnecessary header files. Signed-off-by: Bibo Mao --- hw/intc/loongarch_extioi.c | 31 ++ i

[PATCH 07/10] hw/intc/loongarch_extioi: Add common file loongarch_extioi_common

2024-09-20 Thread Bibo Mao
Add new common file loongarch_extioi_common.c, and move vmstate and property structure to common file. Signed-off-by: Bibo Mao --- hw/intc/loongarch_extioi.c| 60 + hw/intc/loongarch_extioi_common.c | 63 +++ 2 files changed, 65 ins

[PATCH 02/10] include: Move struct LoongArchExtIOI to header file loongarch_extioi_common

2024-09-20 Thread Bibo Mao
Move definiton of structure LoongArchExtIOI from header file loongarch_extioi.h to file loongarch_extioi_common.h. Signed-off-by: Bibo Mao --- include/hw/intc/loongarch_extioi.h| 26 -- include/hw/intc/loongarch_extioi_common.h | 27 +++ 2 files ch

Re: [PATCH v3 0/5] license: Fix typos and update SPDX tags

2024-09-20 Thread Michael Tokarev
On 11.09.2024 18:12, Philippe Mathieu-Daudé wrote: Series fully reviewed (thanks Thomas & Richard) Since v2: . Updated few missed "2 | 3+" expressions Since v1: . Updated regex to cover all GPL-2.0* cases. - Fix a pair of typos - Upgrade the deprecated GPL-2.0+/LGPL-2.0+ SPDX tags to GPL-2.

[PULL 16/22] target/hexagon: Rename macros.inc -> macros.h.inc

2024-09-20 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Since commits 139c1837db ("meson: rename included C source files to .c.inc") and 0979ed017f ("meson: rename .inc.h files to .h.inc"), EMU standard procedure for included header files is to use *.h.inc. Besides, since commit 6a0057aa22 ("docs/devel: make a statement a

Re: [PATCH] target/arm: Correct ID_AA64ISAR1_EL1 value for neoverse-v1

2024-09-20 Thread Michael Tokarev
On 20.09.2024 11:10, Marcin Juszkiewicz wrote: W dniu 17.09.2024 o 18:13, Peter Maydell pisze: The Neoverse-V1 TRM is a bit confused about the layout of the ID_AA64ISAR1_EL1 register, and so its table 3-6 has the wrong value for this ID register.  Trust instead section 3.2.74's list of which fie

Re: [PATCH v4 02/12] tcg/riscv: Add basic support for vector

2024-09-20 Thread Markus Armbruster
Daniel Henrique Barboza writes: > Hi Zhiwei, > > As Rixchard already pointed out, we must have a "Signed-off-by" tag with the > "author" of > the patch, and it must be the exact spelling. So in this case: > > Signed-off-by: Swung0x48 I'm afraid we need a legal name here, not a nickname. > Mor

Re: [PATCH v4 02/12] tcg/riscv: Add basic support for vector

2024-09-20 Thread LIU Zhiwei
On 2024/9/20 12:01, 0x48 Swung wrote: Hey everyone! Late to the party. Life happens sometimes ;) Just discovered this patch and this mail list, and I'd like to provide some background story here. I originally provided my initial implementation in a downstream repo last year, namely https://gi

Re: [PATCH] hw/ppc: fix decrementer with BookE timers

2024-09-20 Thread Clément Chigot
Hi Cédric, On Tue, Aug 27, 2024 at 7:40 PM Cédric Le Goater wrote: > > Hello Clément, > > On 7/15/24 10:46, Clément Chigot wrote: > > The BookE decrementer stops at 0, meaning that it won't decremented > > towards "negative" values. > > However, the current logic is inverted: decr is updated sole

Re: [PATCH v2 08/17] migration: Add load_finish handler and associated functions

2024-09-20 Thread Maciej S. Szmigiero
On 19.09.2024 23:11, Peter Xu wrote: On Thu, Sep 19, 2024 at 09:49:10PM +0200, Maciej S. Szmigiero wrote: On 9.09.2024 22:03, Peter Xu wrote: On Tue, Aug 27, 2024 at 07:54:27PM +0200, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" load_finish SaveVMHandler allows migration code to po

Re: [PATCH v2 06/17] migration: Add save_live_complete_precopy_{begin,end} handlers

2024-09-20 Thread Maciej S. Szmigiero
On 19.09.2024 22:54, Peter Xu wrote: On Thu, Sep 19, 2024 at 09:47:53PM +0200, Maciej S. Szmigiero wrote: On 9.09.2024 21:08, Peter Xu wrote: On Mon, Sep 09, 2024 at 08:32:45PM +0200, Maciej S. Szmigiero wrote: On 9.09.2024 19:59, Peter Xu wrote: On Thu, Sep 05, 2024 at 04:45:48PM +0300, Avih

Re: [PATCH v2 12/17] migration/multifd: Device state transfer support - send side

2024-09-20 Thread Maciej S. Szmigiero
On 19.09.2024 23:17, Peter Xu wrote: On Thu, Sep 19, 2024 at 09:49:43PM +0200, Maciej S. Szmigiero wrote: On 10.09.2024 21:48, Peter Xu wrote: On Wed, Aug 28, 2024 at 09:41:17PM -0300, Fabiano Rosas wrote: +size_t multifd_device_state_payload_size(void) +{ +return sizeof(MultiFDDeviceState

[PATCH 6/6] linux-user: update syscall.tbl to Linux v6.11

2024-09-20 Thread Laurent Vivier
Updated running scripts/update-syscalltbl.sh Signed-off-by: Laurent Vivier --- linux-user/arm/syscall.tbl | 1 + linux-user/i386/syscall_32.tbl | 7 --- linux-user/x86_64/syscall_64.tbl | 8 +--- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/linux-user/arm/sysca

Re: [PATCH v2 06/17] migration: Add save_live_complete_precopy_{begin,end} handlers

2024-09-20 Thread Peter Xu
On Fri, Sep 20, 2024 at 05:22:54PM +0200, Maciej S. Szmigiero wrote: > On 19.09.2024 22:54, Peter Xu wrote: > > On Thu, Sep 19, 2024 at 09:47:53PM +0200, Maciej S. Szmigiero wrote: > > > On 9.09.2024 21:08, Peter Xu wrote: > > > > On Mon, Sep 09, 2024 at 08:32:45PM +0200, Maciej S. Szmigiero wrote:

[PATCH v2] target-i386: Walk NPT in guest real mode

2024-09-20 Thread Alexander Graf
When translating virtual to physical address with a guest CPU that supports nested paging (NPT), we need to perform every page table walk access indirectly through the NPT, which we correctly do. However, we treat real mode (no page table walk) special: In that case, we currently just skip any wal

[PATCH] configs: Fix typo in the sh4-softmmu devices config file

2024-09-20 Thread Thomas Huth
This is the config file for the little endian target, so there should not be a "eb" in here. Signed-off-by: Thomas Huth --- configs/devices/sh4-softmmu/default.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/devices/sh4-softmmu/default.mak b/configs/devices/sh4-s

Re: [PATCH v2 08/17] migration: Add load_finish handler and associated functions

2024-09-20 Thread Peter Xu
On Fri, Sep 20, 2024 at 05:23:08PM +0200, Maciej S. Szmigiero wrote: > On 19.09.2024 23:11, Peter Xu wrote: > > On Thu, Sep 19, 2024 at 09:49:10PM +0200, Maciej S. Szmigiero wrote: > > > On 9.09.2024 22:03, Peter Xu wrote: > > > > On Tue, Aug 27, 2024 at 07:54:27PM +0200, Maciej S. Szmigiero wrote:

Re: [PATCH 2/2] migration/multifd: Fix rb->receivedmap cleanup race

2024-09-20 Thread Elena Ufimtseva
On Fri, Sep 13, 2024 at 3:07 PM Fabiano Rosas wrote: > Fix a segmentation fault in multifd when rb->receivedmap is cleared > too early. > > After commit 5ef7e26bdb ("migration/multifd: solve zero page causing > multiple page faults"), multifd started using the rb->receivedmap > bitmap, which belo

Re: [PATCH v2 0/7] Migration deadcode removal

2024-09-20 Thread Peter Xu
On Thu, Sep 19, 2024 at 02:46:19PM +0100, d...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > This is a set of deadcode removal around migration > found by looking for unused symbols. > > v2 >Don't remove the zero-blocks capability yet >add Fabiano's deprecation text patch. >

Re: [PATCH] hw/ppc: fix decrementer with BookE timers

2024-09-20 Thread Cédric Le Goater
Hello Clément, Unless I'm wrong this patch has not been queued yet. Is there any reason for this ? I don't think there was a PPC PR yet. We are just starting the QEMU 9.2 cycle [*]. Since this is a fix that applies on older releases, may be we could have a PR in not too long. Thanks, C. [*]

Re: [PATCH] tests/migration-test: Wait for cancellation sooner in multifd cancel

2024-09-20 Thread Peter Xu
On Fri, Sep 20, 2024 at 06:13:02PM +0200, Juraj Marcin wrote: > The source QEMU might not finish the cancellation of the migration > before we start setting up the next attempt. During the setup, the > test_migrate_start() function and others might need to interact with the > source in a way that i

Re: [PATCH 08/25] hw/i2c: add support for flexcomm i2c

2024-09-20 Thread Octavian Purdila
On Thu, Sep 19, 2024 at 2:36 AM Peter Maydell wrote: > > On Wed, 18 Sept 2024 at 22:31, Corey Minyard wrote: > > Generally it's frowned upon to have a ton of extra stuff that's not > > used. I would think some is ok, like defining bits in registers that > > aren't used yet, but I have no idea ho

Re: [PATCH 08/25] hw/i2c: add support for flexcomm i2c

2024-09-20 Thread Corey Minyard
Thanks, this all looks good to me. And FIELD() is the right way to go, as Peter said. -corey On Fri, Sep 20, 2024 at 1:03 PM Octavian Purdila wrote: > > On Thu, Sep 19, 2024 at 2:36 AM Peter Maydell > wrote: > > > > On Wed, 18 Sept 2024 at 22:31, Corey Minyard wrote: > > > Generally it's fro

[PATCH 2/6] linux-user,openrisc: move to syscalltbl file

2024-09-20 Thread Laurent Vivier
Since kernel v6.11 openrisc has moved from syscall_nr.h file to syscall.tbl (See 77122bf9e3df ("openrisc: convert to generic syscall table")) Update linux-user scripts to be able to retrieve syscall numbers from linux syscall.tbl instead of syscall_nr.h. New syscall.tbl is imported from linux v6.1

Re: [PATCH] tests/functional: Convert the powernv tests from boot_linux_console.py

2024-09-20 Thread Cédric Le Goater
On 9/20/24 17:03, Thomas Huth wrote: Move the tests into the already existing test_ppc64_powernv.py file. Signed-off-by: Thomas Huth Reviewed-by: Cédric Le Goater Thanks, C. --- Based-on: 20240919185749.71222-1-th...@redhat.com tests/avocado/boot_linux_console.py| 46 -

[PATCH] tests/migration-test: Wait for cancellation sooner in multifd cancel

2024-09-20 Thread Juraj Marcin
The source QEMU might not finish the cancellation of the migration before we start setting up the next attempt. During the setup, the test_migrate_start() function and others might need to interact with the source in a way that is not possible unless the migration is fully canceled. For example, se

Re: [PATCH v2 0/5] Interrupt Remap support for emulated amd viommu

2024-09-20 Thread Alejandro Jimenez
Hi Santosh, On 9/16/24 10:31, Santosh Shukla wrote: Series adds following feature support for emulated amd vIOMMU 1) Pass Through(PT) mode 2) Interrupt Remapping(IR) mode 1) PT mode Introducing the shared 'nodma' memory region that can be aliased by all the devices in the PT mode. Shared memor

Re: [PATCH v2 2/5] amd_iommu: Add support for pass though mode

2024-09-20 Thread Alejandro Jimenez
Hi Santosh, On 9/16/24 10:31, Santosh Shukla wrote: From: Suravee Suthikulpanit Introduce 'nodma' shared memory region to support PT mode so that for each device, we only create an alias to shared memory region when DMA-remapping is disabled. Signed-off-by: Suravee Suthikulpanit Signed-off-b

Re: [PATCH v2 4/5] amd_iommu: Send notification when invaldate interrupt entry cache

2024-09-20 Thread Alejandro Jimenez
In subject: s/invaldate/invalidate/ On 9/16/24 10:31, Santosh Shukla wrote: From: Suravee Suthikulpanit In order to support AMD IOMMU interrupt remapping emulation with PCI pass-through devices, QEMU needs to notify VFIO when guest IOMMU driver updates and invalidate the guest interrupt remapp

Re: [PATCH v2 5/5] amd_iommu: Check APIC ID > 255 for XTSup

2024-09-20 Thread Alejandro Jimenez
On 9/16/24 10:31, Santosh Shukla wrote: From: Suravee Suthikulpanit The XTSup mode enables x2APIC support for AMD IOMMU, which is needed to support vcpu w/ APIC ID > 255. Signed-off-by: Suravee Suthikulpanit Signed-off-by: Santosh Shukla --- v2: - Fixed non-kvm build issue by adding a che

[PATCH] tests/functional: Convert the powernv tests from boot_linux_console.py

2024-09-20 Thread Thomas Huth
Move the tests into the already existing test_ppc64_powernv.py file. Signed-off-by: Thomas Huth --- Based-on: 20240919185749.71222-1-th...@redhat.com tests/avocado/boot_linux_console.py| 46 -- tests/functional/test_ppc64_powernv.py | 42 +-- 2 f

[PATCH 1/6] linux-user,aarch64: move to syscalltbl file

2024-09-20 Thread Laurent Vivier
Since kernel v6.11 aarch64 has moved from syscall_nr.h file to syscall_64.tbl (See e632bca07c8e ("arm64: generate 64-bit syscall.tbl")) Update linux-user scripts to be able to retrieve syscall numbers from linux syscall_64.tbl instead of syscall_nr.h. New syscall_64.tbl is imported from linux v6.1

[PATCH 4/6] linux-user,hexagon: move to syscalltbl file

2024-09-20 Thread Laurent Vivier
Since kernel v6.11 hexagon has moved from syscall_nr.h file to syscall.tbl (36d69c29759e ("hexagon: use new system call table")) Update linux-user scripts to be able to retrieve syscall numbers from linux syscall.tbl instead of syscall_nr.h. New syscall.tbl is imported from linux v6.11 using updat

[PATCH 3/6] linux-user,riscv: move to syscalltbl file

2024-09-20 Thread Laurent Vivier
Since kernel v6.11 riscv has moved from syscall_nr.h file to syscall.tbl (3db80c999deb ("riscv: convert to generic syscall table")) Update linux-user scripts to be able to retrieve syscall numbers from linux syscall.tbl instead of syscall_nr.h. New syscall.tbl is imported from linux v6.11 using up

[PATCH 0/6] linux-user: move all remaining archs to syscalltbl

2024-09-20 Thread Laurent Vivier
linux v6.11 has moved all the remaining archs to syscalltbl, update QEMU accordingly. Remove scripts/gensyscalls.sh that is now useless. Update headers to v6.11 Based-on: <20240918074256.720617-1-laur...@vivier.eu> Laurent Vivier (6): linux-user,aarch64: move to syscalltbl file linux-user,o

[PATCH 5/6] linux-user,loongarch: move to syscalltbl file

2024-09-20 Thread Laurent Vivier
Since kernel v6.11 loongarch has moved from syscall_nr.h file to syscall.tbl (26a3b85bac08 ("loongarch: convert to generic syscall table")) Update linux-user scripts to be able to retrieve syscall numbers from linux syscall.tbl instead of syscall_nr.h. New syscall.tbl is imported from linux v6.11

Re: [PATCH v2 12/17] migration/multifd: Device state transfer support - send side

2024-09-20 Thread Peter Xu
On Fri, Sep 20, 2024 at 05:23:20PM +0200, Maciej S. Szmigiero wrote: > On 19.09.2024 23:17, Peter Xu wrote: > > On Thu, Sep 19, 2024 at 09:49:43PM +0200, Maciej S. Szmigiero wrote: > > > On 10.09.2024 21:48, Peter Xu wrote: > > > > On Wed, Aug 28, 2024 at 09:41:17PM -0300, Fabiano Rosas wrote: > >

[PATCH v6 2/3] vhost-user-blk: split vhost_user_blk_sync_config()

2024-09-20 Thread Vladimir Sementsov-Ogievskiy
Split vhost_user_blk_sync_config() out from vhost_user_blk_handle_config_change(), to be reused in the following commit. Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Raphael Norwitz --- hw/block/vhost-user-blk.c | 26 +++--- 1 file changed, 19 insertions(+), 7 delet

[PATCH] migration/multifd: receive channel socket needs to be set to non-blocking

2024-09-20 Thread Yuchen
When the migration network is disconnected, the source qemu can exit normally with an error, but the destination qemu is always blocked in recvmsg(), causes the destination qemu main thread to be blocked. The destination qemu block stack: Thread 13 (Thread 0x7f0178bfa640 (LWP 1895906) "multifdrecv

Re: [PATCH 0/2] misc: Rename included template headers using '.inc' suffix

2024-09-20 Thread Michael Tokarev
On 10.09.2024 14:28, Philippe Mathieu-Daudé wrote: Follow Coding Style: If you do use template header files they should be named with the ``.c.inc`` or ``.h.inc`` suffix to make it clear they are being included for expansion. Philippe Mathieu-Daudé (2): target/hexagon: Rename macros

[PULL 03/22] linux-user/syscall.c: eliminate other explicit LFS usages

2024-09-20 Thread Michael Tokarev
Since we alwasy build with LFS enabled, and with -D_FILE_OFFSET_BITS=64 in particular, there is no need to use 64bit versions of various system calls and constants, regular ones will do just fine. Eliminate a few last uses of the following constructs in linux-user/syscall.c: off64_t ftruncate6

[PULL 08/22] hw/virtio/Kconfig: Include vhost-user-scmi only on arm targets

2024-09-20 Thread Michael Tokarev
From: Thomas Huth The System Control and Management Interface is specific to arm machines, so don't include this device in non-arm targets. Signed-off-by: Thomas Huth Reviewed-by: Milan Zamazal Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/virtio/Kconfig | 2 +- 1 file

[PULL 18/22] tests/functional: Correct typo in test_netdev_ethtool.py SPDX tag

2024-09-20 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Cc: Alex Bennée Fixes: 9f95111474 ("tests/avocado: re-factor igb test to avoid timeouts") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: Michael Tokarev --- tests/functional/test_netdev_ethtool.py | 2

[PULL 15/22] tests/functional: Put the or1k_sim test into the slow category

2024-09-20 Thread Michael Tokarev
From: Thomas Huth Looks like a copy-n-paste mistake while adding the or1k_sim test here: The test downloads an asset from the internet, so it should be in the thorough category, not in the quick one. Signed-off-by: Thomas Huth Signed-off-by: Michael Tokarev --- tests/functional/meson.build |

[PULL 06/22] hw/loongarch/virt: Add description for virt machine type

2024-09-20 Thread Michael Tokarev
From: Bibo Mao The description about virt machine type is removed by mistake, add new description here. Here is output result with command "./qemu-system-loongarch64 -M help" Supported machines are: none empty machine virt QEMU LoongArch Virtual Machine (default)

Re: [PATCH] docs/system/cpu-hotplug: Update example's socket-id/core-id

2024-09-20 Thread Igor Mammedov
On Thu, 19 Sep 2024 13:34:54 +0100 Peter Maydell wrote: > On Tue, 10 Sept 2024 at 10:38, Peter Maydell wrote: > > > > On Tue, 10 Sept 2024 at 10:03, Igor Mammedov wrote: > > > > > > On Mon, 19 Aug 2024 15:43:03 +0100 > > > Peter Maydell wrote: > > > > @@ -83,34 +83,32 @@ vCPU hotplug > > >

[PULL 14/22] tests/qemu-iotests/testenv: Use the "r2d" machine for sh4/sh4eb

2024-09-20 Thread Michael Tokarev
From: Thomas Huth Commit 0ea0538fae516f9b4 removed the default machine of the sh4 binaries, so a lot of iotests are failing now without such a default machine. Teach the iotest harness to use the "r2d" machine instead to fix this problem. Signed-off-by: Thomas Huth Signed-off-by: Michael Tokare

[PULL 04/22] ppc: fix incorrect spelling of PowerMac

2024-09-20 Thread Michael Tokarev
From: Tejas Vipin PowerMac is spelled as PowerMAC (Media Access Control) in some places. This is misleading. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2297 Signed-off-by: Tejas Vipin Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev

[PULL 05/22] hw/mips/jazz: fix typo in in-built NIC alias

2024-09-20 Thread Michael Tokarev
From: Mark Cave-Ayland Commit e104edbb9d ("hw/mips/jazz: use qemu_find_nic_info()") contained a typo in the NIC alias which caused initialisation of the in-built dp83932 NIC to fail when using the normal -nic user,model=dp83932 command line. Fixes: e104edbb9d ("hw/mips/jazz: use qemu_find_nic_in

[PULL 13/22] tests/qemu-iotests/testenv: Use the "virt" machine for or1k

2024-09-20 Thread Michael Tokarev
From: Thomas Huth When compiling QEMU just with "--target-list=or1k-softmmu", there are 8 iotests failing that try to use PCI devices - but the default or1k machine does not have a PCI bus. The "virt" machine is better suited for running the iotests than the or1k default machine since it provides

[PULL 19/22] license: Simplify GPL-2.0-or-later license descriptions

2024-09-20 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Since the "2 | 3+" expression can be simplified as "2+", it is pointless to mention the GPLv3 license. Add the corresponding SPDX identifier to remove all doubt. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Signed-

[PULL 22/22] license: Update deprecated SPDX tag GPL-2.0 to GPL-2.0-only

2024-09-20 Thread Michael Tokarev
From: Philippe Mathieu-Daudé The 'GPL-2.0' license identifier has been deprecated since license list version 3.0 [1] and replaced by the 'GPL-2.0-only' tag [2]. [1] https://spdx.org/licenses/GPL-2.0.html [2] https://spdx.org/licenses/GPL-2.0-only.html Mechanical patch running: $ sed -i -e s/

[PULL 07/22] tests/unit: Really build pbkdf test on macOS

2024-09-20 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Fix a typo to run the pbkdf crypto cipher tests on macOS. $ make check-unit ... 87/102 qemu:unit / test-crypto-pbkdf OK 2.35s 17 subtests passed Fixes: ebe0302ac8 ("tests/unit: build pbkdf test on macOS") Signed-off-by: Philippe Mathieu-Daudé Rev

[PULL 17/22] tests/bench: Rename test_akcipher_keys.inc -> test_akcipher_keys.c.inc

2024-09-20 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Since commit 139c1837db ("meson: rename included C source files to .c.inc"), QEMU standard procedure for included C files is to use *.c.inc. Besides, since commit 6a0057aa22 ("docs/devel: make a statement about includes") this is documented in the Coding Style: If

[PULL 21/22] license: Update deprecated SPDX tag GPL-2.0+ to GPL-2.0-or-later

2024-09-20 Thread Michael Tokarev
From: Philippe Mathieu-Daudé The 'GPL-2.0+' license identifier has been deprecated since license list version 2.0rc2 [1] and replaced by the 'GPL-2.0-or-later' [2] tag. [1] https://spdx.org/licenses/GPL-2.0+.html [2] https://spdx.org/licenses/GPL-2.0-or-later.html Mechanical patch running: $

Re: [PATCH] tests/qemu-iotests/testenv: Use the "r2d" machine for sh4/sh4eb

2024-09-20 Thread Yoshinori Sato
On Wed, 18 Sep 2024 04:43:50 +0900, Thomas Huth wrote: > > Commit 0ea0538fae516f9b4 removed the default machine of the sh4 > binaries, so a lot of iotests are failing now without such a default > machine. Teach the iotest harness to use the "r2d" machine instead > to fix this problem. > > Signed-

Re: [PATCH] target/arm: Correct ID_AA64ISAR1_EL1 value for neoverse-v1

2024-09-20 Thread Marcin Juszkiewicz
W dniu 17.09.2024 o 18:13, Peter Maydell pisze: The Neoverse-V1 TRM is a bit confused about the layout of the ID_AA64ISAR1_EL1 register, and so its table 3-6 has the wrong value for this ID register. Trust instead section 3.2.74's list of which fields are set. This means that we stop incorrectl

Re: [PATCH v4 02/12] tcg/riscv: Add basic support for vector

2024-09-20 Thread Daniel Henrique Barboza
Hi Zhiwei, On 9/11/24 10:26 AM, LIU Zhiwei wrote: From: Swung0x48 The RISC-V vector instruction set utilizes the LMUL field to group multiple registers, enabling variable-length vector registers. This implementation uses only the first register number of each group while reserving the other re

Re: [PATCH] migration/multifd: receive channel socket needs to be set to non-blocking

2024-09-20 Thread Peter Xu
On Fri, Sep 20, 2024 at 10:05:42AM +, Yuchen wrote: > When the migration network is disconnected, the source > qemu can exit normally with an error, but the destination > qemu is always blocked in recvmsg(), causes the destination > qemu main thread to be blocked. > > The destination qemu bloc

Re: [PATCH 2/2] hw/sparc/leon3: add second uart with extended interrupt usage

2024-09-20 Thread Nikita Shushura
Forgot to add 'Signed-off-by', so can be deleted. Sent with Proton Mail secure email. On Saturday, September 21st, 2024 at 1:48 AM, Nikita Shushura wrote: > --- > hw/sparc/leon3.c | 63 +++- > 1 file changed, 46 insertions(+), 17 deletions(-) > >

Re: [PATCH 1/2] hw/intc/grlib_irqmp: add support for extended interrupts

2024-09-20 Thread Nikita Shushura
Forgot to add 'Signed-off-by', so can be deleted. Sent with Proton Mail secure email. On Saturday, September 21st, 2024 at 1:48 AM, Nikita Shushura wrote: > --- > hw/intc/grlib_irqmp.c | 68 +++ > 1 file changed, 49 insertions(+), 19 deletions(-) > >

[PATCH 1/2] hw/intc/grlib_irqmp: add support for extended interrupts

2024-09-20 Thread Nikita Shushura
--- hw/intc/grlib_irqmp.c | 68 +++ 1 file changed, 49 insertions(+), 19 deletions(-) diff --git a/hw/intc/grlib_irqmp.c b/hw/intc/grlib_irqmp.c index 37ac63fd80..2fd76dd1b4 100644 --- a/hw/intc/grlib_irqmp.c +++ b/hw/intc/grlib_irqmp.c @@ -1,8 +1,6 @@ /*

[PATCH 2/2] hw/sparc/leon3: add second uart with extended interrupt usage

2024-09-20 Thread Nikita Shushura
Signed-off-by: Nikita Shushura --- hw/sparc/leon3.c | 63 +++- 1 file changed, 46 insertions(+), 17 deletions(-) diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c index 6aaa04cb19..c559854e5e 100644 --- a/hw/sparc/leon3.c +++ b/hw/sparc/leon3.c @@ -54,1

[PATCH 2/2] hw/sparc/leon3: add second uart with extended interrupt usage

2024-09-20 Thread Nikita Shushura
--- hw/sparc/leon3.c | 63 +++- 1 file changed, 46 insertions(+), 17 deletions(-) diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c index 6aaa04cb19..c559854e5e 100644 --- a/hw/sparc/leon3.c +++ b/hw/sparc/leon3.c @@ -54,10 +54,14 @@ #define LEON3_PROM_

[PATCH 1/2] hw/intc/grlib_irqmp: add support for extended interrupts

2024-09-20 Thread Nikita Shushura
Signed-off-by: Nikita Shushura --- hw/intc/grlib_irqmp.c | 68 +++ 1 file changed, 49 insertions(+), 19 deletions(-) diff --git a/hw/intc/grlib_irqmp.c b/hw/intc/grlib_irqmp.c index 37ac63fd80..2fd76dd1b4 100644 --- a/hw/intc/grlib_irqmp.c +++ b/hw/intc/gr