[PATCH 16/25] system/qtest: add APIS to check for memory access failures

2024-09-18 Thread Octavian Purdila
Add read*/write*_fail qtest APIs to check for memory access failures. Signed-off-by: Octavian Purdila --- tests/qtest/libqtest-single.h | 92 +++ tests/qtest/libqtest.h| 76 + system/qtest.c| 44 ++---

[PATCH 18/25] tests/qtest: add flexcomm usart tests

2024-09-18 Thread Octavian Purdila
Add flexcomm usart polling and irq unit tests. Signed-off-by: Octavian Purdila --- tests/qtest/flexcomm-usart-test.c | 316 ++ tests/qtest/meson.build | 3 +- 2 files changed, 318 insertions(+), 1 deletion(-) create mode 100644 tests/qtest/flexcomm-usart-

[PATCH 05/25] hw/misc: add support for flexcomm

2024-09-18 Thread Octavian Purdila
Add support for NXP's FLEXCOMM device model. FLEXCOMM is a generic serial communication module which support multiple functions: UART, SPI and I2C. These are configurable at runtime. An abstract FlexcomFunction class is created that will be extended for specific functions. Each function has a ded

[PATCH 25/25] tests/qtest: add tests for RT500's clock controller

2024-09-18 Thread Octavian Purdila
Add test to exercise clocks set and clear, system PLL initialization, audio PLL initialization, systick and ostimer clock source selection. Signed-off-by: Octavian Purdila --- tests/qtest/rt500-clkctl-test.c | 195 tests/qtest/meson.build | 1 + 2 files

Re: [PATCH] tests/qtest: Add XIVE tests for the powernv10 machine

2024-09-18 Thread Mike Kowal
On 9/18/2024 10:46 AM, Cédric Le Goater wrote: Hello, On 9/16/24 20:23, Michael Kowal wrote: From: Frederic Barrat These XIVE tests include: - General interrupt IRQ tests that:    - enable and trigger an interrupt    - acknowledge the interrupt    - end of interrupt processing - Test the Pul

[PATCH 24/25] systems/qtest: add device clock APIs

2024-09-18 Thread Octavian Purdila
Add qtest APIs to check the device clock frequency. Signed-off-by: Octavian Purdila --- include/hw/qdev-clock.h | 10 +++ tests/qtest/libqtest-single.h | 24 + tests/qtest/libqtest.h| 22 +++ hw/core/qdev-clock.c | 2 +- system/qtest.c

Re: [PATCH 08/25] hw/i2c: add support for flexcomm i2c

2024-09-18 Thread Octavian Purdila
On Wed, Sep 18, 2024 at 1:17 PM Corey Minyard wrote: > > On Wed, Sep 18, 2024 at 12:22:36PM -0700, Octavian Purdila wrote: > > Add support for NXP's flexcomm i2c. It does not support slave mode or > > DMA. > > > > The patch includes an automatically generated header which contains > > the register

[PULL 04/18] plugins: save value during memory accesses

2024-09-18 Thread Alex Bennée
From: Pierrick Bouvier Different code paths handle memory accesses: - tcg generated code - load/store helpers - atomic helpers This value is saved in cpu->neg.plugin_mem_value_{high,low}. Values are written only for accessed word size (upper bits are not set). Atomic operations are doing read/w

[PULL 16/18] plugins: add plugin API to read guest memory

2024-09-18 Thread Alex Bennée
From: Rowan Hart Signed-off-by: Rowan Hart Reviewed-by: Pierrick Bouvier Message-Id: <20240827215329.248434-2-rowanbh...@gmail.com> [AJB: tweaked cpu_memory_rw_debug call] Signed-off-by: Alex Bennée Message-Id: <20240916085400.1046925-17-alex.ben...@linaro.org> diff --git a/include/qemu/qemu-

[PULL 03/18] contrib/plugins: control flow plugin

2024-09-18 Thread Alex Bennée
This is a simple control flow tracking plugin that uses the latest inline and conditional operations to detect and track control flow changes. It is currently an exercise at seeing how useful the changes are. Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée Message-Id: <20240916085400.10

[PULL 00/18] tcg plugins (deprecations, mem apis, contrib plugins)

2024-09-18 Thread Alex Bennée
The following changes since commit 2b81c046252fbfb375ad30632362fc16e6e22bd5: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2024-09-17 14:02:18 +0100) are available in the Git repository at: https://gitlab.com/stsquad/qemu.git tags/pull-tcg-plugin-memory-18

[PULL 02/18] deprecation: don't enable TCG plugins by default with TCI

2024-09-18 Thread Alex Bennée
The softmmu memory instrumentation test sees so many more accesses than a normal translated host and its really not worth fixing up. Lets deprecate this odd configuration and save on the CI cycles. Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée Message-Id: <20240916085400.1046925-3-ale

[PULL 18/18] contrib/plugins: avoid hanging program

2024-09-18 Thread Alex Bennée
Although we asks for instructions per second we work in quanta and that cannot be 0. Fail to load the plugin instead and report the minimum IPS we can handle. Reported-by: Elisha Hollander Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Reviewed-by: Pierrick Bouvier Message-Id: <2024

[PULL 05/18] plugins: extend API to get latest memory value accessed

2024-09-18 Thread Alex Bennée
From: Pierrick Bouvier This value can be accessed only during a memory callback, using new qemu_plugin_mem_get_value function. Returned value can be extended when QEMU will support accesses wider than 128 bits. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1719 Resolves: https://gitla

[PULL 13/18] tests/tcg: add a system test to check memory instrumentation

2024-09-18 Thread Alex Bennée
At first I thought I could compile the user-mode test for system mode however we already have a fairly comprehensive test case for system mode in "memory" so lets use that. As tracking every access will quickly build up with "print-access" we add a new mode to track groups of reads and writes to r

[PULL 15/18] contrib/plugins: Add a plugin to generate basic block vectors

2024-09-18 Thread Alex Bennée
From: Akihiko Odaki SimPoint is a widely used tool to find the ideal microarchitecture simulation points so Valgrind[2] and Pin[3] support generating basic block vectors for use with them. Let's add a corresponding plugin to QEMU too. Note that this plugin has a different goal with tests/plugin/

[PULL 01/18] deprecation: don't enable TCG plugins by default on 32 bit hosts

2024-09-18 Thread Alex Bennée
The existing plugins already liberally use host pointer stuffing for passing user data which will fail when doing 64 bit guests on 32 bit hosts. We should discourage this by officially deprecating support and adding another nail to the 32 bit host coffin. Reviewed-by: Pierrick Bouvier Signed-off-

[PULL 06/18] tests/tcg: add mechanism to run specific tests with plugins

2024-09-18 Thread Alex Bennée
From: Pierrick Bouvier Only multiarch tests are run with plugins, and we want to be able to run per-arch test with plugins too. Tested-by: Xingtao Yao Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20240724194708.1843704-4-pierrick.bouv...@linaro.org> Signed-off-b

[PULL 17/18] plugins: add option to dump write argument to syscall plugin

2024-09-18 Thread Alex Bennée
From: Rowan Hart Signed-off-by: Rowan Hart Reviewed-by: Pierrick Bouvier Tested-by: Pierrick Bouvier Message-Id: <20240827215329.248434-3-rowanbh...@gmail.com> [AJB: tweak fmt string for vaddr] Signed-off-by: Alex Bennée Message-Id: <20240916085400.1046925-18-alex.ben...@linaro.org> diff --g

[PULL 11/18] tests/tcg: only read/write 64 bit words on 64 bit systems

2024-09-18 Thread Alex Bennée
While the compilers will generally happily synthesise a 64 bit value for you on 32 bit systems it doesn't exercise anything on QEMU. It also makes it hard to accurately compare the accesses to test_data when instrumenting. Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée Message-Id: <202

[PULL 12/18] tests/tcg: ensure s390x-softmmu output redirected

2024-09-18 Thread Alex Bennée
The multiarch system tests output serial data which should be redirected to the "output" chardev rather than echoed to the console. Comment the use of EXTFLAGS variable while we are at it. Acked-by: Ilya Leoshkevich Reviewed-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <2024091608540

[PULL 09/18] tests/tcg/multiarch: add test for plugin memory access

2024-09-18 Thread Alex Bennée
From: Pierrick Bouvier Add an explicit test to check expected memory values are read/written. 8,16,32 load/store are tested for all arch. 64,128 load/store are tested for aarch64/x64. atomic operations (8,16,32,64) are tested for x64 only. By default, atomic accesses are non atomic if a single c

[PULL 10/18] tests/tcg: clean up output of memory system test

2024-09-18 Thread Alex Bennée
This is useful information when debugging memory issues so lets improve by: - include the ptr address for u8 fills (like the others) - indicate the number of operations for reads and writes - explicitly note when we are flushing - move the fill printf to after the reset Reviewed-by: Pierr

[PULL 08/18] tests/tcg/plugins/mem: add option to print memory accesses

2024-09-18 Thread Alex Bennée
From: Pierrick Bouvier By using "print-accesses=true" option, mem plugin will now print every value accessed, with associated size, type (store vs load), symbol, instruction address and phys/virt address accessed. Reviewed-by: Richard Henderson Reviewed-by: Xingtao Yao Signed-off-by: Pierrick

[PULL 14/18] util/timer: avoid deadlock when shutting down

2024-09-18 Thread Alex Bennée
When we shut down a guest we disable the timers. However this can cause deadlock if the guest has queued some async work that is trying to advance system time and spins forever trying to wind time forward. Pay attention to the return code and bail early if we can't wind time forward. Reported-by:

[PULL 07/18] tests/tcg: allow to check output of plugins

2024-09-18 Thread Alex Bennée
From: Pierrick Bouvier A specific plugin test can now read and check a plugin output, to ensure it contains expected values. Tested-by: Xingtao Yao Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20240724194708.1843704-5-pierrick.bouv...@linaro.org> Signed-off-by:

Re: [PATCH -next] fw_cfg: Constify struct kobj_type

2024-09-18 Thread Gabriel L. Somlo
On Wed, Sep 04, 2024 at 09:17:43AM +0800, Hongbo Li wrote: > This 'struct kobj_type' is not modified. It is only used in > kobject_init_and_add() which takes a 'const struct kobj_type *ktype' > parameter. > > Constifying this structure and moving it to a read-only section, > and this can increase

[PATCH] sockets: Remove deadcode

2024-09-18 Thread dave
From: "Dr. David Alan Gilbert" socket_remote_address hasn't been used since it was added in 17c55decec ("sockets: add helpers for creating SocketAddress from a socket") inet_connect hasn't been used since 2017's 8ecc2f9eab ("sheepdog: Use SocketAddress and socket_connect()") Remove them. S

[PATCH] usb-hub: Add support for v2.0 hubs

2024-09-18 Thread Guenter Roeck
When adding a high speed USB device to the USB hub supported by qemu, it is added in full speed mode. Here is an example for a storage device. /: Bus 001.Port 001: Dev 001, Class=root_hub, Driver=platform-uhci/2p, 12M |__ Port 002: Dev 002, If 0, Class=Hub, Driver=hub/8p, 12M |__ Port

[PATCH] replay: Remove unused replay_disable_events

2024-09-18 Thread dave
From: "Dr. David Alan Gilbert" replay_disable_events has been unused since 2019's c8aa7895eb ("replay: don't drain/flush bdrv queue while RR is working") Remove it. Signed-off-by: Dr. David Alan Gilbert --- include/sysemu/replay.h | 2 -- replay/replay-events.c | 9 - 2 files chang

[PATCH] hw/pci: Remove unused pcie_chassis_find_slot

2024-09-18 Thread dave
From: "Dr. David Alan Gilbert" pcie_chassis_find_slot has been unused since it was added. Remove it. Signed-off-by: Dr. David Alan Gilbert --- hw/pci/pcie_port.c | 10 -- include/hw/pci/pcie_port.h | 1 - 2 files changed, 11 deletions(-) diff --git a/hw/pci/pcie_port.c b/hw/

Re: [PATCH 19/25] hw/misc: add i2c-tester

2024-09-18 Thread Corey Minyard
On Wed, Sep 18, 2024 at 04:03:12PM -0700, Octavian Purdila wrote: > On Wed, Sep 18, 2024 at 1:06 PM Corey Minyard wrote: > > > > On Wed, Sep 18, 2024 at 12:22:47PM -0700, Octavian Purdila wrote: > > > Add a simple i2c peripheral to be used for testing I2C device > > > models. The peripheral has a

[PATCH] io/channel-socket: Remove unused qio_channel_socket_dgram_async

2024-09-18 Thread dave
From: "Dr. David Alan Gilbert" qio_channel_socket_dgram_async has been unused since it was originally added in 2015. Remove it. Signed-off-by: Dr. David Alan Gilbert --- include/io/channel-socket.h | 29 io/channel-socket.c | 54 ---

Re: Xilinx Zynq 7000 Start of CPU1

2024-09-18 Thread Sebastian Huber
- Am 18. Sep 2024 um 11:13 schrieb Sebastian Huber sebastian.hu...@embedded-brains.de: > Hello, > > I recently added the support for CPU1 to the xilinx-zynq-a9 machine > (hw/arm/xilinx_zynq.c). However, the reset behaviour doesn't match exactly > with > the hardware. After a system reset (S

[PULL v2 4/6] softmmu/physmem.c: Keep transaction attribute in address_space_map()

2024-09-18 Thread Peter Xu
From: "Fea.Wang" The follow-up transactions may use the data in the attribution, so keep the value of attribution from the function parameter just as flatview_translate() above. Signed-off-by: Fea.Wang Cc: qemu-sta...@nongnu.org Fixes: f26404fbee ("Make address_space_map() take a MemTxAttrs arg

[PULL v2 3/6] migration/multifd: Fix loop conditions in multifd_zstd_send_prepare and multifd_zstd_recv

2024-09-18 Thread Peter Xu
From: Stefan Weil GitHub's CodeQL reports four critical errors which are fixed by this commit: Unsigned difference expression compared to zero An expression (u - v > 0) with unsigned values u, v is only false if u == v, so all changed expressions did not work as expected. Signed-off-by: St

[PULL v2 0/6] Migration 20240917 patches

2024-09-18 Thread Peter Xu
The following changes since commit 2b81c046252fbfb375ad30632362fc16e6e22bd5: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2024-09-17 14:02:18 +0100) are available in the Git repository at: https://gitlab.com/peterx/qemu.git tags/migration-20240917-pull-re

[PULL v2 6/6] migration/multifd: Fix rb->receivedmap cleanup race

2024-09-18 Thread Peter Xu
From: Fabiano Rosas Fix a segmentation fault in multifd when rb->receivedmap is cleared too early. After commit 5ef7e26bdb ("migration/multifd: solve zero page causing multiple page faults"), multifd started using the rb->receivedmap bitmap, which belongs to ram.c and is initialized and *freed*

Re: [RFC PATCH] contrib/plugins: avoid hanging program

2024-09-18 Thread Pierrick Bouvier
On 9/13/24 10:38, Alex Bennée wrote: Although we asks for instructions per second we work in quanta and that cannot be 0. Fail to load the plugin instead and report the minimum IPS we can handle. Signed-off-by: Alex Bennée Reported-by: Elisha Hollander --- contrib/plugins/ips.c | 5 + 1

[PATCH 12/25] hw/misc: add support for RT500's reset controller

2024-09-18 Thread Octavian Purdila
The RT500 reset controller has two instances that have the same register layout but with different fields for some registers. The model only provides set and clear functionality for the various reset lines which is common for both instances. Because of that only one type is implemented for both co

[PATCH 17/25] tests/qtest: add flexcomm tests

2024-09-18 Thread Octavian Purdila
Add flexcomm function selection unit tests. Signed-off-by: Octavian Purdila --- tests/qtest/flexcomm-test.c | 82 + tests/qtest/meson.build | 1 + 2 files changed, 83 insertions(+) create mode 100644 tests/qtest/flexcomm-test.c diff --git a/tests/qtest/

[PATCH 07/25] hw/char: add support for flexcomm usart

2024-09-18 Thread Octavian Purdila
Add support for NXP's flexcomm usart. It supports interupts and FIFO access but no DMA. The patch includes an automatically generated header which contains the register layout and helpers. The header can be regenerated with the svd-flexcomm-usart target when the build is configured with --enable-

[PATCH 04/25] Add mcux-soc-svd subproject

2024-09-18 Thread Octavian Purdila
Add mcux-soc-svd subproject that contains SVD files that are going to be used to generate C header with register layout definitions and other helpers to create device models. Guard the subproject by a configuration option since it is rarely going to be used - whenever new headers will be generated

[PATCH 23/25] tests/qtest: add tests for flexcomm spi

2024-09-18 Thread Octavian Purdila
From: Sebastian Ene Add master and loopback tests for flexcomm spi. Signed-off-by: Sebastian Ene [tavip: add master mode test, convert to qtest] Signed-off-by: Octavian Purdila --- tests/qtest/flexcomm-spi-test.c | 145 tests/qtest/meson.build | 2 +-

[PATCH 19/25] hw/misc: add i2c-tester

2024-09-18 Thread Octavian Purdila
Add a simple i2c peripheral to be used for testing I2C device models. The peripheral has a fixed number of registers that can be read and written. Signed-off-by: Octavian Purdila --- include/hw/misc/i2c_tester.h | 30 ++ hw/misc/i2c_tester.c | 109 +++

[PATCH 01/25] fifo32: add peek function

2024-09-18 Thread Octavian Purdila
Add fifo32_peek() that returns the first element from the queue without popping it. Signed-off-by: Octavian Purdila --- include/qemu/fifo32.h | 28 1 file changed, 28 insertions(+) diff --git a/include/qemu/fifo32.h b/include/qemu/fifo32.h index 4e9fd1b5ef..9de18073

[PATCH 00/25] NXP i.MX RT595

2024-09-18 Thread Octavian Purdila
This patch set adds support for NXP's RT500 MCU [1] and the RT595 EVK[2]. More RT500 device models will be submitted in future patch sets. This is a minimal patch set that allows running the NXP MCU SDK hello world example[4]. The patch set introduces a (python) tool that generates C header files

[PATCH 06/25] hw/misc/flexcomm.c: add common fifo functionality

2024-09-18 Thread Octavian Purdila
FLEXCOMM SPI and USART share FIFO functionality. Add common helper functions to avoid code duplication. Signed-off-by: Octavian Purdila --- include/hw/misc/flexcomm.h | 2 + include/hw/misc/flexcomm_function.h | 8 +++ hw/misc/flexcomm.c | 83 +

[PATCH 22/25] hw/misc: add spi-tester

2024-09-18 Thread Octavian Purdila
Add a simple SPI peripheral that echoes back received data. Useful for testing SPI controllers. Signed-off-by: Octavian Purdila --- include/hw/misc/spi_tester.h | 32 + hw/misc/spi_tester.c | 67 hw/misc/Kconfig | 5 +++

Re: [PATCH 08/25] hw/i2c: add support for flexcomm i2c

2024-09-18 Thread Octavian Purdila
On Wed, Sep 18, 2024 at 2:31 PM Corey Minyard wrote: > > On Wed, Sep 18, 2024 at 02:04:58PM -0700, Octavian Purdila wrote: > > On Wed, Sep 18, 2024 at 1:17???PM Corey Minyard wrote: > > > > > > On Wed, Sep 18, 2024 at 12:22:36PM -0700, Octavian Purdila wrote: > > > > Add support for NXP's flexcom

vm events, userspace, the vmgenid driver, and the future [was: the uevent revert thread]

2024-09-18 Thread Jason A. Donenfeld
[broadened subject line and added relevant parties to cc list] On Tue, Sep 17, 2024 at 10:55:20PM +0200, Alexander Graf wrote: > What is still open are user space applications that require event based > notification on VM clone events - and *only* VM clone events. This > mostly caters for tools

[PATCH] hw/net/net_rx_pkt: Remove deadcode

2024-09-18 Thread dave
From: "Dr. David Alan Gilbert" net_rx_pkt_get_l3_hdr_offset and net_rx_pkt_get_iovec_len haven't been used since they were added. Remove them. Signed-off-by: Dr. David Alan Gilbert --- hw/net/net_rx_pkt.c | 13 - hw/net/net_rx_pkt.h | 9 - 2 files changed, 22 deletions(-)

Re: vm events, userspace, the vmgenid driver, and the future [was: the uevent revert thread]

2024-09-18 Thread Alexander Graf
On 19.09.24 00:27, Jason A. Donenfeld wrote: [broadened subject line and added relevant parties to cc list] On Tue, Sep 17, 2024 at 10:55:20PM +0200, Alexander Graf wrote: What is still open are user space applications that require event based notification on VM clone events - and *only* VM cl

Re: [PATCH 19/25] hw/misc: add i2c-tester

2024-09-18 Thread Octavian Purdila
On Wed, Sep 18, 2024 at 1:06 PM Corey Minyard wrote: > > On Wed, Sep 18, 2024 at 12:22:47PM -0700, Octavian Purdila wrote: > > Add a simple i2c peripheral to be used for testing I2C device > > models. The peripheral has a fixed number of registers that can be > > read and written. > > Why is this

[PATCH] hw/net/rocker: Remove unused rocker_fp_ports

2024-09-18 Thread dave
From: "Dr. David Alan Gilbert" rocker_fp_ports hasn't been used since it was added back in 2015. Remove it. Signed-off-by: Dr. David Alan Gilbert --- hw/net/rocker/rocker.c | 5 - hw/net/rocker/rocker.h | 1 - 2 files changed, 6 deletions(-) diff --git a/hw/net/rocker/rocker.c b/hw/net/ro

Re: [PATCH 0/2] tcg: Fix branch/label link during plugin expansion

2024-09-18 Thread Pierrick Bouvier
On 9/13/24 03:23, Alex Bennée wrote: Richard Henderson writes: On 9/10/24 14:23, Richard Henderson wrote: With tcg_last_op(), we always get the last op of the stream. With TCGContext.emit_before_op, the most recently emitted op is no longer the last op. Instead, pass the op being emitted back

[PATCH 03/25] scripts: add script to generate C header files from SVD XML files

2024-09-18 Thread Octavian Purdila
From: Stefan Stanacar The CMSIS System View Description format(CMSIS-SVD) is an XML based description of Arm Cortex-M microcontrollers provided and maintained by sillicon vendors. It includes details such as peripherals registers (down to bitfields), peripheral register block addresses, reset val

Re: [PATCH v2 18/18] contrib/plugins: avoid hanging program

2024-09-18 Thread Pierrick Bouvier
On 9/16/24 01:54, Alex Bennée wrote: Although we asks for instructions per second we work in quanta and that cannot be 0. Fail to load the plugin instead and report the minimum IPS we can handle. Signed-off-by: Alex Bennée Reported-by: Elisha Hollander Reviewed-by: Richard Henderson --- con

Re: [PATCH v2 14/18] util/timer: avoid deadlock when shutting down

2024-09-18 Thread Pierrick Bouvier
On 9/16/24 01:53, Alex Bennée wrote: When we shut down a guest we disable the timers. However this can cause deadlock if the guest has queued some async work that is trying to advance system time and spins forever trying to wind time forward. Pay attention to the return code and bail early if we

Re: [PATCH v2 13/18] tests/tcg: add a system test to check memory instrumentation

2024-09-18 Thread Pierrick Bouvier
On 9/16/24 01:53, Alex Bennée wrote: At first I thought I could compile the user-mode test for system mode however we already have a fairly comprehensive test case for system mode in "memory" so lets use that. As tracking every access will quickly build up with "print-access" we add a new mode t

[PATCH 11/25] hw/ssi: add support for flexspi

2024-09-18 Thread Octavian Purdila
This is mostly a stub which completes SPI transactions as noops by masking out the error interrupts and never clearing the IPCMDDONE interrupt. Although incomplete, this allows software that uses NXP's mcuxpresso SDK to run the SDK board initialization functions. It also supports AHB memory acces

[PATCH 08/25] hw/i2c: add support for flexcomm i2c

2024-09-18 Thread Octavian Purdila
Add support for NXP's flexcomm i2c. It does not support slave mode or DMA. The patch includes an automatically generated header which contains the register layout and helpers. The header can be regenerated with the svd-flexcomm-i2c target when the build is configured with --enable-mcux-soc-svd.

[PATCH 14/25] hw/arm: add RT595-EVK board

2024-09-18 Thread Octavian Purdila
Add basic support for the RT595-EVK board, enough to be able to run the NXP's microXpresso SDK hello world example. Signed-off-by: Octavian Purdila --- hw/arm/rt595-evk.c | 64 ++ hw/arm/Kconfig | 5 hw/arm/meson.build | 1 + 3 files changed

[PATCH 13/25] hw/arm: add basic support for the RT500 SoC

2024-09-18 Thread Octavian Purdila
Add basic support for the RT500 SoC. It supports enough peripherals to run the NXP's microXpresso SDK hello world example. The patch includes an automatically generated header which contains peripheral base addreses and interrupt numbers. The header can be regenerated with the svd-rt500 target wh

[PATCH 09/25] hw/ssi: add support for flexcomm spi

2024-09-18 Thread Octavian Purdila
From: Sebastian Ene Add support for NXP's flexcomm spi. It supports FIFO access, interrupts and master mode only. It does not support DMA. The patch includes an automatically generated header which contains the register layout and helpers. The header can be regenerated with the svd-flexcomm-spi

[PATCH 21/25] hw/ssi: allow NULL realize callbacks for peripherals

2024-09-18 Thread Octavian Purdila
Signed-off-by: Octavian Purdila --- hw/ssi/ssi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/ssi/ssi.c b/hw/ssi/ssi.c index 3f357e8f16..d1f3ce7c22 100644 --- a/hw/ssi/ssi.c +++ b/hw/ssi/ssi.c @@ -105,7 +105,9 @@ static void ssi_peripheral_realize(DeviceState *dev, Er

[PATCH 02/25] tests/unit: add fifo32 tests

2024-09-18 Thread Octavian Purdila
Add push/pop and peek tests for fifo32. Signed-off-by: Octavian Purdila --- tests/unit/test-fifo.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/tests/unit/test-fifo.c b/tests/unit/test-fifo.c index 14153c41fa..d0e05ba95c 100644 --- a/tests/unit/

Re: [PATCH V2] arm/kvm: add support for MTE

2024-09-18 Thread Gustavo Romero
Hi Ganapatrao, On 9/12/24 06:16, Ganapatrao Kulkarni wrote: Extend the 'mte' property for the virt machine to cover KVM as well. For KVM, we don't allocate tag memory, but instead enable the capability. If MTE has been enabled, we need to disable migration, as we do not yet have a way to migrat

Re: [PULL 0/6] Migration 20240917 patches

2024-09-18 Thread Peter Maydell
On Tue, 17 Sept 2024 at 22:56, Peter Xu wrote: > > The following changes since commit 2b81c046252fbfb375ad30632362fc16e6e22bd5: > > Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into > staging (2024-09-17 14:02:18 +0100) > > are available in the Git repository at: > > htt

Re: [PATCH] ppc/spapr: remove deprecated machines specific code

2024-09-18 Thread Harsh Prateek Bora
Hi Cedric, On 9/17/24 12:31, Cédric Le Goater wrote: Hello Harsh, On 9/17/24 08:03, Harsh Prateek Bora wrote: Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing the arch specific code for the now deprecated machine t

Re: [PATCH v16 02/13] hw/ppc/spapr_pci: Do not create DT for disabled PCI device

2024-09-18 Thread Harsh Prateek Bora
On 9/18/24 19:57, Cédric Le Goater wrote: Hello, Adding :   Harsh for QEMU/PPC pseries machine,   Shivaprasad for KVM/PPC VFIO and IOMMU support. Could you please give us your feedback on these changes ? Thanks, C.  On 9/13/24 05:44, Akihiko Odaki wrote: Disabled means it is a disa

RE: [PATCH v2 00/48] Use g_assert_not_reached instead of (g_)assert(0, false)

2024-09-18 Thread Xingtao Yao (Fujitsu)
> >> -- > >> 2.39.2 > >> > > > > Which one did you find? Using which grep command? Sorry, I made a mistake. I haven't found anything new yet.

Re: [PATCH V2] arm/kvm: add support for MTE

2024-09-18 Thread Gustavo Romero
Hi Cornelia and Ganapatrao, On 9/17/24 11:13, Cornelia Huck wrote: On Thu, Sep 12 2024, Ganapatrao Kulkarni wrote: Extend the 'mte' property for the virt machine to cover KVM as well. For KVM, we don't allocate tag memory, but instead enable the capability. If MTE has been enabled, we need

[PATCH v3 05/34] qobject: replace assert(0) with g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier --- qobject/qlit.c | 2 +- qobject/qnum.c | 8 ---

[PATCH v3 00/34] Use g_assert_not_reached instead of (g_)assert(0, false)

2024-09-18 Thread Pierrick Bouvier
This series cleans up all usages of assert/g_assert who are supposed to stop execution of QEMU. We replace those by g_assert_not_reached(). It was suggested recently when cleaning codebase to build QEMU with gcc and tsan: https://lore.kernel.org/qemu-devel/54bb02a6-1b12-460a-97f6-3f478ef76...@lina

[PATCH v3 14/34] target/i386/kvm: replace assert(false) with g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- target/i386/kvm/kvm.c | 4 ++-- 1 fil

[PATCH v3 28/34] hw/pci: remove return after g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/pci/pci-stub.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/

[PATCH v3 09/34] hw/net: replace assert(false) with g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/net/e1000e_core.c | 2 +- hw/net/igb_core.c| 2 +- hw/net/net_rx_pk

[PATCH v3 04/34] migration: replace assert(0) with g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu Signed-off-by: Pierrick Bouvier --- migration/migration-hmp-cmds.c | 2 +- migration/postc

[PATCH v3 07/34] block: replace assert(false) with g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier --- block/qcow2.c | 2 +- 1 file changed, 1 insertion

[PATCH v3 15/34] accel/tcg: remove break after g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- accel/tcg/plugin-gen.c | 1 - 1 file changed, 1 deletion(-) diff --git a/

[PATCH v3 01/34] hw/acpi: replace assert(0) with g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/acpi/aml-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v3 02/34] hw/arm: replace assert(0) with g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/arm/highbank.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[PATCH v3 26/34] hw/hyperv: remove return after g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/hyperv/hyperv_testdev.c | 1 - hw/hyperv/vmbus.c | 3 --- 2 fi

[PATCH v3 27/34] hw/net: remove return after g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/net/e1000e_core.c | 2 -- hw/net/igb_core.c| 2 -- hw/net/vmxnet3.c

[PATCH v3 31/34] qobject: remove return after g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- qobject/qnum.c | 4 1 file changed, 4 deletions(-) diff --git a/qobj

[PATCH v3 34/34] scripts/checkpatch.pl: emit error when using assert(false)

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- scripts/checkpatch.pl | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v3 30/34] migration: remove return after g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Signed-off-by: Pierrick Bouvier --- migration/dirtyrate.c| 1 - migration/postcopy-ram.c | 7 --- migration/ram.c | 2 -- 3 f

[PATCH v3 20/34] hw/tpm: remove break after g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/tpm/tpm_spapr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/t

[PATCH v3 16/34] block: remove break after g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Richard W.M. Jones Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier --- block/ssh.c | 1

[PATCH v3 03/34] hw/net: replace assert(0) with g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/net/i82596.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH v3 24/34] tcg/loongarch64: remove break after g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- tcg/loongarch64/tcg-target.c.inc | 1 - 1 file changed, 1 deletion(-) dif

[PATCH v3 23/34] fpu: remove break after g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- fpu/softfloat-parts.c.inc | 2 -- 1 file changed, 2 deletions(-) diff --g

[PATCH v3 32/34] qom: remove return after g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- qom/object.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qom/object

[PATCH v3 29/34] hw/ppc: remove return after g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Cédric Le Goater Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/ppc/ppc.c | 1 - hw/ppc/spapr_e

[PATCH v3 25/34] include/qemu: remove return after g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- include/qemu/pmem.h | 1 - 1 file changed, 1 deletion(-) diff --git a/inc

[PATCH v3 12/34] hw/ppc: replace assert(false) with g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Daniel Henrique Barboza Signed-off-by: Pierrick Bouvier --- hw/ppc/spapr_events.c | 2 +- 1 file

[PATCH v3 11/34] hw/pci: replace assert(false) with g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/pci/pci-stub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-

[PATCH v3 21/34] target/arm: remove break after g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- target/arm/hyp_gdbstub.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v3 22/34] target/riscv: remove break after g_assert_not_reached()

2024-09-18 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Daniel Henrique Barboza Signed-off-by: Pierrick Bouvier --- target/riscv/monitor.c

  1   2   3   >