Re: [PATCH] ppc/spapr: remove deprecated machines specific code

2024-09-17 Thread Cédric Le Goater
Hello Harsh, On 9/17/24 08:03, Harsh Prateek Bora wrote: Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as deprecated with reasons mentioned in its commit log. Removing the arch specific code for the now deprecated machine types. Suggested-by: Cédric Le Goater Signed-off-by: H

Re: [PATCH v3 0/5] vhost-user: Add SHMEM_MAP/UNMAP requests

2024-09-17 Thread Albert Esteve
On Mon, Sep 16, 2024 at 7:57 PM Stefan Hajnoczi wrote: > This patch series could use tests. The first two patches seem broken and > testing would have revealed that the memory allocation and pointers are > not quite right. > My bad. Previous version of the patch I did test with a device that I'v

Re: [RFC PATCH v3 01/24] fifo32: add peek function

2024-09-17 Thread Octavian Purdila
e On Fri, Sep 6, 2024 at 4:53 AM Philippe Mathieu-Daudé wrote: > > Hi Octavian, > Hi Philippe, > On 27/8/24 08:45, Octavian Purdila wrote: > > Add fifo32_peek() that returns the first element from the queue > > without popping it. > > > > Signed-off-by: Octavian Purdila > > --- > > include

Re: [PATCH v3 0/5] vhost-user: Add SHMEM_MAP/UNMAP requests

2024-09-17 Thread Stefan Hajnoczi
On Tue, Sep 17, 2024 at 09:05:34AM +0200, Albert Esteve wrote: > On Mon, Sep 16, 2024 at 7:57 PM Stefan Hajnoczi wrote: > > > This patch series could use tests. The first two patches seem broken and > > testing would have revealed that the memory allocation and pointers are > > not quite right. >

Re: [PATCH v2 1/2] acpi: ged: Add macro for acpi sleep control register

2024-09-17 Thread Igor Mammedov
On Sat, 14 Sep 2024 10:25:45 +0800 maobibo wrote: > On 2024/9/13 下午8:41, Igor Mammedov wrote: > > On Wed, 11 Sep 2024 11:09:21 +0800 > > Bibo Mao wrote: > > > >> Macro definition is added for acpi sleep control register, so that > >> ged emulation driver can use this, also it can be used in F

Re: [PATCH v2 12/18] tests/tcg: ensure s390x-softmmu output redirected

2024-09-17 Thread Thomas Huth
On 16/09/2024 10.53, Alex Bennée wrote: The multiarch system tests output serial data which should be redirected to the "output" chardev rather than echoed to the console. Comment the use of EXTFLAGS variable while we are at it. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth

Re: [PATCH v3 3/5] vhost_user: Add frontend command for shmem config

2024-09-17 Thread Stefan Hajnoczi
On Thu, Sep 12, 2024 at 04:53:33PM +0200, Albert Esteve wrote: > The frontend can use this command to retrieve > VIRTIO Shared Memory Regions configuration from > the backend. The response contains the number of > shared memory regions, their size, and shmid. > > This is useful when the frontend i

Re: [PATCH v3 3/5] vhost_user: Add frontend command for shmem config

2024-09-17 Thread Stefan Hajnoczi
On Thu, Sep 12, 2024 at 04:53:33PM +0200, Albert Esteve wrote: > The frontend can use this command to retrieve > VIRTIO Shared Memory Regions configuration from > the backend. The response contains the number of > shared memory regions, their size, and shmid. > > This is useful when the frontend i

Re: [PATCH 0/1] hw/nvme: add atomic write support

2024-09-17 Thread Klaus Jensen
On Aug 20 09:11, Alan Adamson wrote: > Since there is work in the Linux NVMe Driver community to add Atomic Write > support, it would be desirable to be able to test it with qemu nvme emulation. > > This patch will focus on supporting NVMe controller atomic write parameters > (AWUN and > AWUPF)

[PATCH] hw/block: fix uint32 overflow

2024-09-17 Thread Dmitry Frolov
The product bs->bl.zone_size * (bs->bl.nr_zones - 1) may overflow uint32. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Dmitry Frolov --- hw/block/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block

[PATCH] hw/cxl: fix uint32 overflow cxl-mailbox-utils.c

2024-09-17 Thread Dmitry Frolov
The sum offset + length may overflow uint32. Since this sum is compared with uint64_t return value of get_lsa_size(), it makes sense to choose uint64_t type for offset and length. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Dmitry Frolov --- hw/cxl/cxl-mailb

Re: [PATCH] tests/unit: Really build pbkdf test on macOS

2024-09-17 Thread Daniel P . Berrangé
On Tue, Sep 17, 2024 at 08:57:36AM +0200, Philippe Mathieu-Daudé wrote: > Fix a typo to run the pbkdf crypto cipher tests on macOS. > > $ make check-unit >... >87/102 qemu:unit / test-crypto-pbkdf OK 2.35s 17 subtests > passed > > Fixes: ebe0302ac8 ("tests/unit: build pbkdf

Re: [PATCH v3 4/5] vhost-user-dev: Add cache BAR

2024-09-17 Thread Stefan Hajnoczi
On Thu, Sep 12, 2024 at 04:53:34PM +0200, Albert Esteve wrote: > Add a cache BAR in the vhost-user-device > into which files can be directly mapped. > > The number, shmid, and size of the VIRTIO Shared > Memory subregions is retrieved through a get_shmem_config > message sent by the vhost-user-bas

Re: [PATCH] hostmem: Apply merge property after the memory region is initialized

2024-09-17 Thread David Hildenbrand
On 16.09.24 01:31, Gavin Shan wrote: The semantic change has been introduced by commit 5becdc0ab0 ("hostmem: simplify the code for merge and dump properties") even it clarifies that no senmatic change has been introduced. After the commit, the merge property can be applied even the corresponding

Re: [PATCH v3 4/5] vhost-user-dev: Add cache BAR

2024-09-17 Thread Stefan Hajnoczi
On Thu, Sep 12, 2024 at 04:53:34PM +0200, Albert Esteve wrote: > @@ -331,6 +333,37 @@ static void vub_device_realize(DeviceState *dev, Error > **errp) > do_vhost_user_cleanup(vdev, vub); > } > > +ret = vub->vhost_dev.vhost_ops->vhost_get_shmem_config(&vub->vhost_dev, > +

Re: [PULL 0/4] Edk2 stable202408 20240916 patches

2024-09-17 Thread Gerd Hoffmann
Hi, > acpi-test: Warning! SSDT binary file mismatch. Actual Address has changed due to firmware size change. I'll respin with acpi test data updates included. take care, Gerd

Re: [PATCH v3 4/5] vhost-user-dev: Add cache BAR

2024-09-17 Thread Stefan Hajnoczi
On Tue, 17 Sept 2024 at 10:33, Stefan Hajnoczi wrote: > > On Thu, Sep 12, 2024 at 04:53:34PM +0200, Albert Esteve wrote: > > @@ -331,6 +333,37 @@ static void vub_device_realize(DeviceState *dev, Error > > **errp) > > do_vhost_user_cleanup(vdev, vub); > > } > > > > +ret = vub->vh

[PULL 1/7] tests/acpi: allow acpi test data updates

2024-09-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8bf4..00137acabc71 100644 --- a/tests/qtest/bios-tables-test-al

[PULL 4/7] roms: Support compile the efi bios for loongarch

2024-09-17 Thread Gerd Hoffmann
From: Xianglai Li Added loongarch UEFI BIOS support to compiled scripts. UEFI code images require 16M alignment, flash images require 16M alignment, under the loongarch architecture.This is agreed upon when the firmware is loaded in QEMU under Loongarch. The naming of UEFI under loongarch r

[PULL 6/7] tests/acpi: update aarch64/virt/SSDT.memhp

2024-09-17 Thread Gerd Hoffmann
Address (and checksum) change due to firmware image size change. DefinitionBlock ("", "SSDT", 1, "BOCHS ", "NVDIMM", 0x0001) [ ... ] -Name (MEMA, 0x43C8) +Name (MEMA, 0x43DA) Signed-off-by: Gerd Hoffmann --- tests/data/acpi/aarch64/virt/SSDT.memhp | Bin 1817 -> 1817 bytes

[PULL 2/7] update submodule and version file to edk2-stable202408

2024-09-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- roms/edk2 | 2 +- roms/edk2-version | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/roms/edk2 b/roms/edk2 index edc6681206c1..b158dad150bf 16 --- a/roms/edk2 +++ b/roms/edk2 @@ -1 +1 @@ -Subproject commit edc6681206c1a8791981a2

[PULL 7/7] tests/acpi: disallow acpi test data updates

2024-09-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index 00137acabc71..dfb8523c8bf4 100644 --- a/tests/qtest/bios-tables-test-all

[PULL 0/7] Edk2 stable202408 20240917 patches

2024-09-17 Thread Gerd Hoffmann
The following changes since commit ea9cdbcf3a0b8d5497cddf87990f1b39d8f3bb0a: Merge tag 'hw-misc-20240913' of https://github.com/philmd/qemu into staging (2024-09-15 18:27:40 +0100) are available in the Git repository at: https://gitlab.com/kraxel/qemu.git tags/edk2-stable20240

[PATCH 0/3] ci: Replace macOS coverage from release 13 to 15

2024-09-17 Thread Philippe Mathieu-Daudé
macOS 15 "Sequoia" was just released. Add support and coverage. According to our support policy, we stop supporting the previous major release two years after the the new major release has been published. macOS 13 (Ventura) was released on October 2022: time to drop it (well, in 2 weeks, but postin

[PATCH 1/3] tests/unit: Really build pbkdf test on macOS

2024-09-17 Thread Philippe Mathieu-Daudé
Fix a typo to run the pbkdf crypto cipher tests on macOS. $ make check-unit ... 87/102 qemu:unit / test-crypto-pbkdf OK 2.35s 17 subtests passed Fixes: ebe0302ac8 ("tests/unit: build pbkdf test on macOS") Signed-off-by: Philippe Mathieu-Daudé --- tests/unit/test-crypto-pbkdf.

[PATCH 3/3] .gitlab-ci.d/cirrus: Add manual testing of macOS 15 (Sequoia)

2024-09-17 Thread Philippe Mathieu-Daudé
Upgrade libvirt-ci so it covers macOS 15. Add a manual entry (QEMU_JOB_OPTIONAL: 1) to test on Sequoia release. Refresh the lci-tool generated files. Signed-off-by: Philippe Mathieu-Daudé --- Pending libvirt-ci MR 501: https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/501 CI job: https://g

[PATCH 2/3] .gitlab-ci.d/cirrus: Drop support for macOS 13 (Ventura)

2024-09-17 Thread Philippe Mathieu-Daudé
macOS 15 "Sequoia" was released on September 16, 2024 [1]. According to QEMU's support policy, we stop supporting the previous major release two years after the the new major release has been published. Time to remove support for macOS 13 (Ventura, released on October 2022, [2]). Promote the macO

Re: [PATCH 1/3] tests/unit: Really build pbkdf test on macOS

2024-09-17 Thread Philippe Mathieu-Daudé
Oops, this patch wasn't meant for this series, already posted & reviewed: https://lore.kernel.org/qemu-devel/20240917065736.27883-1-phi...@linaro.org/ On Tue, 17 Sept 2024 at 10:51, Philippe Mathieu-Daudé wrote: > > Fix a typo to run the pbkdf crypto cipher tests on macOS. > > $ make check-unit

Re: [PATCH] hw/loongarch/virt: Add description for virt machine type

2024-09-17 Thread Michael Tokarev
On 13.09.2024 12:52, Bibo Mao wrote: The description about virt machine type is removed by mistake, add new description here. Here is output result with command "./qemu-system-loongarch64 -M help" Supported machines are: none empty machine virt QEMU LoongArch Virt

Re: [PATCH v10 05/21] acpi/ghes: better handle source_id and notification

2024-09-17 Thread Igor Mammedov
On Sat, 14 Sep 2024 08:13:26 +0200 Mauro Carvalho Chehab wrote: > GHES has two fields with somewhat meanings: if 'somewhat' means similar, than it's not. type is defining a way OSPM is notified about error while source_id id fw/hw defined arbitrary number that specify a concrete error reporting

Re: [PATCH] tests/unit: Really build pbkdf test on macOS

2024-09-17 Thread Michael Tokarev
On 17.09.2024 11:20, Daniel P. Berrangé wrote: On Tue, Sep 17, 2024 at 08:57:36AM +0200, Philippe Mathieu-Daudé wrote: Fix a typo to run the pbkdf crypto cipher tests on macOS. $ make check-unit ... 87/102 qemu:unit / test-crypto-pbkdf OK 2.35s 17 subtests passed Fixes: e

Re: [PATCH] hw/virtio/Kconfig: Include vhost-user-scmi only on arm targets

2024-09-17 Thread Michael Tokarev
On 13.09.2024 16:18, Thomas Huth wrote: The System Control and Management Interface is specific to arm machines, so don't include this device in non-arm targets. Picked up for trivial-patches tree, thanks! /mjt

Re: [PATCH] hw/display: Fix mirrored output in dm163

2024-09-17 Thread Michael Tokarev
On 15.09.2024 15:57, Inès Varhol wrote: DM163 is an emulated 8x8 LED matrix. This commit flips the image horizontally so it's rendered the same way as on the hardware. Picked this one up for trivial-patches, as it is, - I've no idea if it is correct or not :) This is an interesting device, I w

Re: [PATCH v10 02/21] acpi/generic_event_device: Update GHES migration to cover hest addr

2024-09-17 Thread Igor Mammedov
On Sat, 14 Sep 2024 08:13:23 +0200 Mauro Carvalho Chehab wrote: > The GHES migration logic at GED should now support HEST table > location too. > > Increase migration version and change needed to check for both > ghes_addr_le and hest_addr_le But I don't think it will work like this (but I might

Re: [PATCH] hw/xen: Remove deadcode

2024-09-17 Thread Anthony PERARD
On Tue, Sep 17, 2024 at 01:22:12AM +0100, d...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > xen_be_copy_grant_refs is unused since 2019's > 19f87870ba ("xen: remove the legacy 'xen_disk' backend") > > xen_config_dev_console is unused since 2018's > 6d7c06c213 ("Remove broken Xen P

Re: [PATCH v10 03/21] acpi/ghes: get rid of ACPI_HEST_SRC_ID_RESERVED

2024-09-17 Thread Igor Mammedov
On Sat, 14 Sep 2024 08:13:24 +0200 Mauro Carvalho Chehab wrote: > This is just duplicating ACPI_GHES_ERROR_SOURCE_COUNT, which > has a better name. So, drop the duplication. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Igor Mammedov > --- > hw/acpi/ghes.c | 7 ++- > inc

Re: [PATCH] hw/cxl: fix uint32 overflow cxl-mailbox-utils.c

2024-09-17 Thread Jonathan Cameron via
On Tue, 17 Sep 2024 11:09:16 +0300 Dmitry Frolov wrote: > The sum offset + length may overflow uint32. Since this sum is > compared with uint64_t return value of get_lsa_size(), it makes > sense to choose uint64_t type for offset and length. > > Found by Linux Verification Center (linuxtesting.o

Re: [PATCH v10 04/21] acpi/ghes: simplify acpi_ghes_record_errors() code

2024-09-17 Thread Igor Mammedov
On Sat, 14 Sep 2024 08:13:25 +0200 Mauro Carvalho Chehab wrote: > if physical_address is not defined, just return with an error > set. no need to mention that, as it's what does now. > > That reduces the ident of the function and prepares it for > the next changes. > > No functional changes.

Re: [PATCH v10 01/21] acpi/ghes: add a firmware file with HEST address

2024-09-17 Thread Igor Mammedov
On Sat, 14 Sep 2024 08:13:22 +0200 Mauro Carvalho Chehab wrote: > Store HEST table address at GPA, placing its content at > hest_addr_le variable. say here why (just short description and pointing to the next patch that would do that) > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Igo

Re: [PATCH] hw/display: Fix mirrored output in dm163

2024-09-17 Thread Peter Maydell
On Tue, 17 Sept 2024 at 10:11, Michael Tokarev wrote: > > On 15.09.2024 15:57, Inès Varhol wrote: > > DM163 is an emulated 8x8 LED matrix. This commit flips the image > > horizontally so it's rendered the same way as on the hardware. > > Picked this one up for trivial-patches, as it is, - > I've n

Re: [PATCH] hw/display: Fix mirrored output in dm163

2024-09-17 Thread Michael Tokarev
On 17.09.2024 12:39, Peter Maydell wrote: This is an interesting device, I wonder if it is used by anyone? The device is used by the Arm b-l475e-iot01a board. I mean if it is actually used in practice, - there's just 1 commit for this file - it's addition in Apr this year, and that's all. If

Re: [PATCH] ui/cursor: remove cursor_get_mono_image

2024-09-17 Thread Marc-André Lureau
On Tue, Sep 17, 2024 at 4:23 AM wrote: > From: "Dr. David Alan Gilbert" > > cursor_get_mono_image has been unused since 2018's > 0015ca5cba ("ui: remove support for SDL1.2 in favour of SDL2") > > Remove it. > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: Marc-André Lureau > --- >

Re: [PATCH v3 1/5] vhost-user: Add VIRTIO Shared Memory map request

2024-09-17 Thread David Hildenbrand
On 12.09.24 16:53, Albert Esteve wrote: Add SHMEM_MAP/UNMAP requests to vhost-user to handle VIRTIO Shared Memory mappings. This request allows backends to dynamically map fds into a VIRTIO Shared Memory Region indentified by its `shmid`. Then, the fd memory is advertised to the driver as a base

Re: [PATCH] hw/block: fix uint32 overflow

2024-09-17 Thread Stefan Hajnoczi
On Tue, Sep 17, 2024 at 11:03:18AM +0300, Dmitry Frolov wrote: > The product bs->bl.zone_size * (bs->bl.nr_zones - 1) may overflow > uint32. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Dmitry Frolov > --- > hw/block/virtio-blk.c | 2 +- > 1 file chan

Re: [PATCH] hw/display: Fix mirrored output in dm163

2024-09-17 Thread Peter Maydell
On Tue, 17 Sept 2024 at 10:54, Michael Tokarev wrote: > > On 17.09.2024 12:39, Peter Maydell wrote: > > >> This is an interesting device, I wonder if it is used by anyone? > > > > The device is used by the Arm b-l475e-iot01a board. > > I mean if it is actually used in practice, - there's just 1 co

[PULL 0/8] vfio queue

2024-09-17 Thread Cédric Le Goater
The following changes since commit ea9cdbcf3a0b8d5497cddf87990f1b39d8f3bb0a: Merge tag 'hw-misc-20240913' of https://github.com/philmd/qemu into staging (2024-09-15 18:27:40 +0100) are available in the Git repository at: https://github.com/legoater/qemu/ tags/pull-vfio-20240917

[PULL 3/8] vfio/igd: support legacy mode for all known generations

2024-09-17 Thread Cédric Le Goater
From: Corvin Köhne We're soon going to add support for legacy mode to ElkhartLake and TigerLake devices. Those are gen 11 and 12 devices. At the moment, all devices identified by our igd_gen function do support legacy mode. This won't change when adding our new devices of gen 11 and 12. Therefore

[PULL 5/8] vfio/igd: add new bar0 quirk to emulate BDSM mirror

2024-09-17 Thread Cédric Le Goater
From: Corvin Köhne The BDSM register is mirrored into MMIO space at least for gen 11 and later devices. Unfortunately, the Windows driver reads the register value from MMIO space instead of PCI config space for those devices [1]. Therefore, we either have to keep a 1:1 mapping for the host and gu

[PULL 7/8] vfio/igd: don't set stolen memory size to zero

2024-09-17 Thread Cédric Le Goater
From: Corvin Köhne The stolen memory is required for the GOP (EFI) driver and the Windows driver. While the GOP driver seems to work with any stolen memory size, the Windows driver will crash if the size doesn't match the size allocated by the host BIOS. For that reason, it doesn't make sense to

[PULL 6/8] vfio/igd: add ID's for ElkhartLake and TigerLake

2024-09-17 Thread Cédric Le Goater
From: Corvin Köhne ElkhartLake and TigerLake devices were tested in legacy mode with Linux and Windows VMs. Both are working properly. It's likely that other Intel GPUs of gen 11 and 12 like IceLake device are working too. However, we're only adding known good devices for now. Signed-off-by: Cor

[PULL 1/8] hw/vfio/pci.c: Use correct type in trace_vfio_msix_early_setup()

2024-09-17 Thread Cédric Le Goater
From: Peter Maydell The tracepoint trace_vfio_msix_early_setup() uses "int" for the type of the table_bar argument, but we use this to print a uint32_t. Coverity warns that this means that we could end up treating it as a negative number. We only use this in printing the value in the tracepoint,

[PULL 2/8] vfio/igd: return an invalid generation for unknown devices

2024-09-17 Thread Cédric Le Goater
From: Corvin Köhne Intel changes it's specification quite often e.g. the location and size of the BDSM register has change for gen 11 devices and later. This causes our emulation to fail on those devices. So, it's impossible for us to use a suitable default value for unknown devices. Instead of r

[PULL 8/8] vfio/igd: correctly calculate stolen memory size for gen 9 and later

2024-09-17 Thread Cédric Le Goater
From: Corvin Köhne We have to update the calculation of the stolen memory size because we've seen devices using values of 0xf0 and above for the graphics mode select field. The new calculation was taken from the linux kernel [1]. [1] https://github.com/torvalds/linux/blob/7c626ce4bae1ac14f60076

[PULL 4/8] vfio/igd: use new BDSM register location and size for gen 11 and later

2024-09-17 Thread Cédric Le Goater
From: Corvin Köhne Intel changed the location and size of the BDSM register for gen 11 devices and later. We have to adjust our emulation for these devices to properly support them. Signed-off-by: Corvin Köhne Reviewed-by: Alex Williamson --- hw/vfio/igd.c | 31 ---

[PULL 00/17] s390x and test patches

2024-09-17 Thread Thomas Huth
Hi! The following changes since commit ea9cdbcf3a0b8d5497cddf87990f1b39d8f3bb0a: Merge tag 'hw-misc-20240913' of https://github.com/philmd/qemu into staging (2024-09-15 18:27:40 +0100) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2024-09-17

[PULL 01/17] tests/qtest/cdrom-test: Improve the machine detection in the cdrom test

2024-09-17 Thread Thomas Huth
When configuring QEMU with the --without-default-devices switch, these tests are currently failing since they assume that the "pc" and "q35" machines are always available. Add some proper checks to make the test work without these machines, too. Message-ID: <20240905191434.694440-3-th...@redhat.co

[PULL 02/17] tests/qtest/boot-order-test: Make the machine name mandatory in this test

2024-09-17 Thread Thomas Huth
Let's make sure that we always pass a machine name to the test_boot_orders() function, so we can check whether the machine is available in the binary and skip the test in case it is not included in the build. Message-ID: <20240905191434.694440-4-th...@redhat.com> Reviewed-by: Philippe Mathieu-Daud

[PULL 06/17] .gitlab-ci.d/buildtest: Build most targets in the build-without-defaults job

2024-09-17 Thread Thomas Huth
Now that all the qtests are able to deal with builds that use the "--without-default-devices" configuration switch, we can add all targets to the build-without-defaults job. But to avoid burning too much CI cycles in this job, exclude some targets where we already have similar test coverage by a re

[PULL 03/17] tests/qtest/hd-geo-test: Check for availability of "pc" machine before using it

2024-09-17 Thread Thomas Huth
In case QEMU has been configured with "--without-default-devices", the "pc" machine type might be missing in the binary. We should check for its availability before using it. Message-ID: <20240905191434.694440-5-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/qtest/hd-geo-test.c | 71

[PULL 13/17] system: Sort QEMU_ARCH_VIRTIO_PCI definition

2024-09-17 Thread Thomas Huth
From: Philippe Mathieu-Daudé Sort the QEMU_ARCH_VIRTIO_PCI to simplify adding/removing entries. Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240705124528.97471-2-phi...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Thomas Huth --- system/qdev-monitor.c | 17 +++

[PULL 17/17] .gitlab-ci.d/crossbuilds.yml: Force 'make check' to -j2 for cross-i686-tci

2024-09-17 Thread Thomas Huth
From: Peter Maydell In commit 1374ed49e1453c300 we forced the cross-i686-tci job to -j1 to see if this helped with test timeouts. It seems to help with that but on the other hand we now sometimes run into the overall 60 minute job timeout. Try -j2 instead. Signed-off-by: Peter Maydell Reviewed-

[PULL 05/17] tests/qtest: Disable numa-test if the default machine is not available

2024-09-17 Thread Thomas Huth
The numa-test needs a default machine in the target binary to work successfully, so don't try to run this test if the corresponding machine has not been enabled, e.g. when QEMU has been configured with "--without-default-devices". Message-ID: <20240905191434.694440-7-th...@redhat.com> Signed-off-b

[PULL 11/17] tests/qtest: replace assert(false) with g_assert_not_reached()

2024-09-17 Thread Thomas Huth
From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240912073921.453203-24-pierrick.bouv...

[PULL 08/17] tests/qtest: replace assert(0) with g_assert_not_reached()

2024-09-17 Thread Thomas Huth
From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Pierrick Bouvier Message-ID: <20240912073921.

[PULL 07/17] gitlab: fix logic for changing docker tag on stable branches

2024-09-17 Thread Thomas Huth
From: Daniel P. Berrangé This fixes: commit e28112d00703abd136e2411d23931f4f891c9244 Author: Daniel P. Berrangé Date: Thu Jun 8 17:40:16 2023 +0100 gitlab: stable staging branches publish containers in a separate tag Due to a copy+paste mistake, that commit included "QEMU_JOB_SKIP

[PULL 04/17] tests/qtest/meson.build: Add more CONFIG switches checks for the x86 tests

2024-09-17 Thread Thomas Huth
When configuring QEMU with "--without-default-devices", currently a lot of the x86 qtests are failing since they silently assume that a certain device or the i440fx pc machine is available. Add more checks for CONFIG switches here to not run those tests in case the corresponding device is not avail

[PULL 09/17] tests/unit: replace assert(0) with g_assert_not_reached()

2024-09-17 Thread Thomas Huth
From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240912073921.453203-14-pierrick.bouv...

[PULL 12/17] tests/qtest: remove break after g_assert_not_reached()

2024-09-17 Thread Thomas Huth
From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240912073921.453203-36-pierrick.bouv...

[PULL 14/17] system: Enable the device aliases for or1k, too

2024-09-17 Thread Thomas Huth
Now that we've got a "virt" machine for or1k that supports PCI too (commit 40fef82c4e "hw/openrisc: Add PCI bus support to virt") we can also enable the virtio device aliases like we do on other similar platforms. This will e.g. help to run the iotests with qemu-system-or1k later. Reviewed-by: Phi

[PULL 16/17] tests/functional: Move the mips64el fuloong2e test into the thorough category

2024-09-17 Thread Thomas Huth
Commit d2fce37597c2 added a test that downloads an asset from the internet, so this test should not be run by default anymore and be put into the thorough category instead. Message-ID: <20240913175140.3329083-1-th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth ---

[PULL 15/17] docs/fuzz: fix outdated mention to enable-sanitizers

2024-09-17 Thread Thomas Huth
From: Matheus Tavares Bernardino This options has been removed at cb771ac1f5 (meson: Split --enable-sanitizers to --enable-{asan, ubsan}, 2024-08-13), so let's update its last standing mention in the docs. Signed-off-by: Matheus Tavares Bernardino Reviewed-by: Brian Cain Message-ID: <0ecf4e1a

[PULL 10/17] include/hw/s390x: replace assert(false) with g_assert_not_reached()

2024-09-17 Thread Thomas Huth
From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Pierrick Bouvier Reviewed-by: Eric Farman Me

Re: [PATCH v10 06/21] acpi/ghes: Remove a duplicated out of bounds check

2024-09-17 Thread Igor Mammedov
On Sat, 14 Sep 2024 08:13:27 +0200 Mauro Carvalho Chehab wrote: > acpi_ghes_record_errors() has an assert() at the beginning > to ensure that source_id will be lower than > ACPI_GHES_ERROR_SOURCE_COUNT. Remove a duplicated check. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Igor Mamme

Re: [PATCH v1 03/14] s390x/s390-virtio-hcall: prepare for more diag500 hypercalls

2024-09-17 Thread David Hildenbrand
On 12.09.24 15:22, Nina Schoetterl-Glausch wrote: On Tue, 2024-09-10 at 19:57 +0200, David Hildenbrand wrote: Let's generalize, abstracting the virtio bits. diag500 is now a generic hypercall to handle QEMU/KVM specific things. Explicitly specify all already defined subcodes, including legacy on

Re: [PATCH v1 03/14] s390x/s390-virtio-hcall: prepare for more diag500 hypercalls

2024-09-17 Thread David Hildenbrand
On 17.09.24 12:45, David Hildenbrand wrote: On 12.09.24 15:22, Nina Schoetterl-Glausch wrote: On Tue, 2024-09-10 at 19:57 +0200, David Hildenbrand wrote: Let's generalize, abstracting the virtio bits. diag500 is now a generic hypercall to handle QEMU/KVM specific things. Explicitly specify all

[PATCH] tests/functional: Put the or1k_sim test into the slow category

2024-09-17 Thread Thomas Huth
Looks like a copy-n-paste mistake while adding the or1k_sim test here: The test downloads an asset from the internet, so it should be in the thorough category, not in the quick one. Signed-off-by: Thomas Huth --- tests/functional/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v1 03/14] s390x/s390-virtio-hcall: prepare for more diag500 hypercalls

2024-09-17 Thread David Hildenbrand
On 17.09.24 12:50, David Hildenbrand wrote: On 17.09.24 12:45, David Hildenbrand wrote: On 12.09.24 15:22, Nina Schoetterl-Glausch wrote: On Tue, 2024-09-10 at 19:57 +0200, David Hildenbrand wrote: Let's generalize, abstracting the virtio bits. diag500 is now a generic hypercall to handle QEMU

Re: [PATCH v1 06/14] s390x: introduce s390_get_memory_limit()

2024-09-17 Thread David Hildenbrand
On 16.09.24 15:20, Nina Schoetterl-Glausch wrote: On Tue, 2024-09-10 at 19:58 +0200, David Hildenbrand wrote: Let's add s390_get_memory_limit(), to query what has been successfully set via s390_set_memory_limit(). Allow setting the limit only once. Signed-off-by: David Hildenbrand Reviewed-b

[PULL 0/1] Block patches

2024-09-17 Thread Stefan Hajnoczi
The following changes since commit ea9cdbcf3a0b8d5497cddf87990f1b39d8f3bb0a: Merge tag 'hw-misc-20240913' of https://github.com/philmd/qemu into staging (2024-09-15 18:27:40 +0100) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request for you

[PULL 1/1] hw/block: fix uint32 overflow

2024-09-17 Thread Stefan Hajnoczi
From: Dmitry Frolov The product bs->bl.zone_size * (bs->bl.nr_zones - 1) may overflow uint32. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Dmitry Frolov Message-id: 20240917080356.270576-2-fro...@swemel.ru Signed-off-by: Stefan Hajnoczi --- hw/block/virtio

[PATCH v9] target/riscv/kvm/kvm-cpu.c: kvm_riscv_handle_sbi() fail with vendor-specific SBI

2024-09-17 Thread Alexei Filippov
kvm_riscv_handle_sbi() may return not supported return code to not trigger qemu abort with vendor-specific sbi. Add new error path to provide proper error in case of qemu_chr_fe_read_all() may not return sizeof(ch), because exactly zero just means we failed to read input, which can happen, so tell

Re: [PATCH v10 07/21] acpi/ghes: rework the logic to handle HEST source ID

2024-09-17 Thread Igor Mammedov
On Sat, 14 Sep 2024 08:13:28 +0200 Mauro Carvalho Chehab wrote: > The current logic is based on a lot of duct tape, with > offsets calculated based on one define with the number of > source IDs and an enum. > > Rewrite the logic in a way that it would be more resilient > of code changes, by movi

Canceled event with note: QEMU/KVM developers conference call @ Tue 17 Sept 2024 14:00 - 15:00 (BST) (qemu-devel@nongnu.org)

2024-09-17 Thread Alex Bennée
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:CANCEL BEGIN:VTIMEZONE TZID:America/New_York X-LIC-LOCATION:America/New_York BEGIN:DAYLIGHT TZOFFSETFROM:-0500 TZOFFSETTO:-0400 TZNAME:EDT DTSTART:19700308T02 RRULE:FREQ=YEARLY;BYMONTH=3;BYDA

Re: [PATCH v10 02/21] acpi/generic_event_device: Update GHES migration to cover hest addr

2024-09-17 Thread Igor Mammedov
On Sat, 14 Sep 2024 08:13:23 +0200 Mauro Carvalho Chehab wrote: > The GHES migration logic at GED should now support HEST table > location too. > > Increase migration version and change needed to check for both > ghes_addr_le and hest_addr_le. > > Signed-off-by: Mauro Carvalho Chehab > --- >

Re: [PATCH v10 08/21] acpi/ghes: Change the type for source_id

2024-09-17 Thread Igor Mammedov
On Sat, 14 Sep 2024 08:13:29 +0200 Mauro Carvalho Chehab wrote: > HEST source ID is actually a 16-bit value. Yet, make it a little > bit more generic using just an integer type. wouldn't uint16_t be better to use, to explicitly show expectations? > Signed-off-by: Mauro Carvalho Chehab > --- >

Re: [PATCH 1/1] target/riscv: enable floating point unit

2024-09-17 Thread Andrew Jones
On Mon, Sep 16, 2024 at 08:16:33PM GMT, Heinrich Schuchardt wrote: > OpenSBI enables the floating point in mstatus. For consistency QEMU/KVM > should do the same. > > Without this patch EDK II with TLS enabled crashes when hitting the first > floating point instruction while running QEMU with --ac

Re: [PATCH v10 00/21] Add ACPI CPER firmware first error injection on ARM emulation

2024-09-17 Thread Igor Mammedov
On Sat, 14 Sep 2024 08:13:21 +0200 Mauro Carvalho Chehab wrote: > This series add support for injecting generic CPER records. Such records > are generated outside QEMU via a provided script. > > On this version, the patch reworking the way offsets are calculated were > split on several other

Re: [PATCH v9] target/riscv/kvm/kvm-cpu.c: kvm_riscv_handle_sbi() fail with vendor-specific SBI

2024-09-17 Thread Andrew Jones
On Tue, Sep 17, 2024 at 02:54:33PM GMT, Alexei Filippov wrote: > kvm_riscv_handle_sbi() may return not supported return code to not > trigger qemu abort with vendor-specific sbi. > > Add new error path to provide proper error in case of > qemu_chr_fe_read_all() may not return sizeof(ch), because e

Re: [PATCH 1/2] chardev: implement backend chardev multiplexing

2024-09-17 Thread Marc-André Lureau
Hi Roman On Fri, Sep 13, 2024 at 8:37 PM Roman Penyaev wrote: > > This patch implements multiplexing capability of several backend > devices, which opens up an opportunity to use a single frontend > device on the guest, which can be manipulated from several > backend devices. > > The idea of the

Re: [PATCH 1/2] chardev: implement backend chardev multiplexing

2024-09-17 Thread Peter Maydell
On Tue, 17 Sept 2024 at 13:32, Marc-André Lureau wrote: > > Hi Roman > > On Fri, Sep 13, 2024 at 8:37 PM Roman Penyaev wrote: > > > > This patch implements multiplexing capability of several backend > > devices, which opens up an opportunity to use a single frontend > > device on the guest, which

Re: [PATCH v3 0/1] Add support for generating OpenSBI domains in the device tree

2024-09-17 Thread Andrew Jones
On Mon, Sep 09, 2024 at 01:27:05PM GMT, Alistair Francis wrote: > On Tue, Aug 6, 2024 at 7:05 AM Gregor Haas wrote: > > > > This patch series adds support for specifying OpenSBI domains on the QEMU > > command line. A simple example of what this looks like is below, including > > mapping the board

Re: [PATCH v1 06/14] s390x: introduce s390_get_memory_limit()

2024-09-17 Thread Nina Schoetterl-Glausch
On Tue, 2024-09-17 at 13:23 +0200, David Hildenbrand wrote: > On 16.09.24 15:20, Nina Schoetterl-Glausch wrote: > > On Tue, 2024-09-10 at 19:58 +0200, David Hildenbrand wrote: > > > Let's add s390_get_memory_limit(), to query what has been successfully > > > set via s390_set_memory_limit(). Allow s

Re: [PATCH 3/3] .gitlab-ci.d/cirrus: Add manual testing of macOS 15 (Sequoia)

2024-09-17 Thread Daniel P . Berrangé
On Tue, Sep 17, 2024 at 10:50:58AM +0200, Philippe Mathieu-Daudé wrote: > Upgrade libvirt-ci so it covers macOS 15. Add a manual entry > (QEMU_JOB_OPTIONAL: 1) to test on Sequoia release. Refresh the > lci-tool generated files. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Pending libvirt-ci

Re: [PATCH 1/2] chardev: implement backend chardev multiplexing

2024-09-17 Thread Peter Maydell
On Tue, 17 Sept 2024 at 13:40, Peter Maydell wrote: > > On Tue, 17 Sept 2024 at 13:32, Marc-André Lureau > wrote: > > > > Hi Roman > > > > On Fri, Sep 13, 2024 at 8:37 PM Roman Penyaev wrote: > > > > > > This patch implements multiplexing capability of several backend > > > devices, which opens

Re: [PATCH v1 03/14] s390x/s390-virtio-hcall: prepare for more diag500 hypercalls

2024-09-17 Thread Nina Schoetterl-Glausch
On Tue, 2024-09-17 at 13:02 +0200, David Hildenbrand wrote: > On 17.09.24 12:50, David Hildenbrand wrote: > > On 17.09.24 12:45, David Hildenbrand wrote: > > > On 12.09.24 15:22, Nina Schoetterl-Glausch wrote: > > > > On Tue, 2024-09-10 at 19:57 +0200, David Hildenbrand wrote: > > > > > Let's gener

Re: [PULL 00/12] aspeed queue

2024-09-17 Thread Peter Maydell
On Mon, 16 Sept 2024 at 19:58, Cédric Le Goater wrote: > > The following changes since commit ea9cdbcf3a0b8d5497cddf87990f1b39d8f3bb0a: > > Merge tag 'hw-misc-20240913' of https://github.com/philmd/qemu into staging > (2024-09-15 18:27:40 +0100) > > are available in the Git repository at: > >

Re: [PULL 0/7] Edk2 stable202408 20240917 patches

2024-09-17 Thread Peter Maydell
ilable in the Git repository at: > > https://gitlab.com/kraxel/qemu.git > tags/edk2-stable202408-20240917-pull-request > > for you to fetch changes up to 265c40becab72485caa1f4b1911ce96a98657f84: > > tests/acpi: disall

Re: [PATCH v9] target/riscv/kvm/kvm-cpu.c: kvm_riscv_handle_sbi() fail with vendor-specific SBI

2024-09-17 Thread Andrew Jones
On Tue, Sep 17, 2024 at 02:29:41PM GMT, Andrew Jones wrote: > On Tue, Sep 17, 2024 at 02:54:33PM GMT, Alexei Filippov wrote: > > kvm_riscv_handle_sbi() may return not supported return code to not > > trigger qemu abort with vendor-specific sbi. > > > > Add new error path to provide proper error in

Re: [PATCH 1/1] target/riscv: enable floating point unit

2024-09-17 Thread Heinrich Schuchardt
On 17.09.24 14:13, Andrew Jones wrote: On Mon, Sep 16, 2024 at 08:16:33PM GMT, Heinrich Schuchardt wrote: OpenSBI enables the floating point in mstatus. For consistency QEMU/KVM should do the same. Without this patch EDK II with TLS enabled crashes when hitting the first floating point instruct

Re: [PATCH v4 0/1] linux-user: add openat2 support in linux-user

2024-09-17 Thread Michael Vogt
friendly ping (see also https://patchew.org/QEMU/cover.1725607795.git.mv...@redhat.com/) Please let me know if there is anything I can do to make this easier to review or if I should split or help otherwise. On Fri, Sep 6, 2024 at 9:39 AM Michael Vogt wrote: > Hi, > > This is v4 of the openat2

  1   2   3   >