Re: [PATCH v2 0/2] Postcopy migration and vhost-user errors

2024-09-11 Thread Prasad Pandit
Hello Michael, On Tue, 10 Sept 2024 at 22:40, Michael S. Tsirkin wrote: > So are we going to see a version with BQL? === diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index cdf9af4a4b..96ac0ed93b 100644 --- a/hw/virtio/vhost-user.c +++ b/hw/virtio/vhost-user.c @@ -2079,6 +2079,7 @

Re: [PATCH v1] chardev: introduce 'reconnect-ms' and deprecate 'reconnect'

2024-09-11 Thread Daniil Tatianin
Ping :) I think this one should be good to go now! On 9/5/24 11:57 AM, Daniil Tatianin wrote: The 'reconnect' option only allows to specify the time in seconds, which is way too long for certain workflows. We have a lightweight disk backend server, which takes about 20ms to live update, but due

Re: [PATCH 07/39] hw/watchdog: replace assert(0) with g_assert_not_reached()

2024-09-11 Thread Richard W.M. Jones
On Tue, Sep 10, 2024 at 03:15:34PM -0700, Pierrick Bouvier wrote: > Signed-off-by: Pierrick Bouvier > --- > hw/watchdog/watchdog.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/watchdog/watchdog.c b/hw/watchdog/watchdog.c > index 955046161bf..d0ce3c4ac55 100644 > --

Re: [PATCH 25/39] block: remove break after g_assert_not_reached()

2024-09-11 Thread Richard W.M. Jones
On Tue, Sep 10, 2024 at 03:15:52PM -0700, Pierrick Bouvier wrote: > Signed-off-by: Pierrick Bouvier > --- > block/ssh.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/block/ssh.c b/block/ssh.c > index 27d582e0e3d..871e1d47534 100644 > --- a/block/ssh.c > +++ b/block/ssh.c > @@ -474,7 +4

RE: [PATCH v3 03/17] intel_iommu: Add a placeholder variable for scalable modern mode

2024-09-11 Thread Duan, Zhenzhong
>-Original Message- >From: CLEMENT MATHIEU--DRIF >Subject: Re: [PATCH v3 03/17] intel_iommu: Add a placeholder variable for >scalable modern mode > > > >On 11/09/2024 07:22, Zhenzhong Duan wrote: >> Caution: External email. Do not open attachments or click links, unless this >email comes

Re: [PATCH 00/39] Use g_assert_not_reached instead of (g_)assert(0,false)

2024-09-11 Thread Philippe Mathieu-Daudé
On 11/9/24 00:15, Pierrick Bouvier wrote: Pierrick Bouvier (39): docs/spin: replace assert(0) with g_assert_not_reached() hw/acpi: replace assert(0) with g_assert_not_reached() hw/arm: replace assert(0) with g_assert_not_reached() hw/char: replace assert(0) with g_assert_not_reached(

RE: [PATCH v3 00/17] intel_iommu: Enable stage-1 translation for emulated device

2024-09-11 Thread Duan, Zhenzhong
Hi Clement, Thanks for your review. Hoping it could be accepted in the foreseeable future. Thanks Zhenzhong >-Original Message- >From: CLEMENT MATHIEU--DRIF >Subject: Re: [PATCH v3 00/17] intel_iommu: Enable stage-1 translation for >emulated device > >Hi Zhenzhong, > >Thanks for posting

Re: [PATCH v2] target/riscv: Add support for machine specific pmu's events

2024-09-11 Thread Aleksei Filippov
On 08.07.2024 16:42, Philippe Mathieu-Daudé wrote: Hi Aleksei, On 8/7/24 11:46, Aleksei Filippov wrote: On 25.06.2024 21:18, Richard Henderson wrote: On 6/25/24 07:46, Alexei Filippov wrote: Was added call backs for machine specific pmu events. Simplify monitor functions by adding new hash

[PATCH] Update FreeBSD CI jobs FreeBSD 14.1

2024-09-11 Thread Thomas Huth
The current FreeBSD CI jobs are failing installation since the "opencv" package is now missing there. Updating to 14.1 fixes the issue. Signed-off-by: Thomas Huth --- Here's the output of a successful run: https://gitlab.com/thuth/qemu/-/jobs/7795460644 .gitlab-ci.d/cirrus.yml

Re: [PATCH 0/2] Move net backend cleanup to NIC cleanup

2024-09-11 Thread Eugenio Perez Martin
On Tue, Sep 10, 2024 at 5:46 AM Jason Wang wrote: > > On Tue, Sep 10, 2024 at 11:41 AM Si-Wei Liu wrote: > > > > Hi Jason, > > > > It seems this series wasn't applied successfully, I still cannot see it > > from the latest tree. Any idea? > > It breaks make check. > > Eugenio, would you want to f

Re: [RFC 1/2] vhost-vdpa: Decouple the IOVA allocator

2024-09-11 Thread Si-Wei Liu
On 9/9/2024 11:22 PM, Eugenio Perez Martin wrote: On Tue, Sep 10, 2024 at 7:30 AM Si-Wei Liu wrote: Sorry for the delayed response, it seems I missed the email reply for some reason during the long weekend. On 9/2/2024 4:09 AM, Eugenio Perez Martin wrote: On Fri, Aug 30, 2024 at 11:05 PM S

[PATCH] qemu/ui: set swap interval explicitly when OpenGL is enabled

2024-09-11 Thread gert . wollny
From: Gert Wollny Before 176e3783f2ab (ui/sdl2: OpenGL window context) SDL_CreateRenderer was called unconditionally setting the swap interval to 0. Since SDL_CreateRenderer is now no longer called when OpenGL is enabled, the swap interval is no longer set explicitly and vsync handling depends on

Re: [Bug Report] smmuv3 event 0x10 report when running virtio-blk-pci

2024-09-11 Thread Eric Auger
Hi, On 9/10/24 03:24, Zhou Wang via wrote: > On 2024/9/9 22:31, Peter Maydell wrote: >> On Mon, 9 Sept 2024 at 15:22, Zhou Wang via wrote: >>> Hi All, >>> >>> When I tested mainline qemu(commit 7b87a25f49), it reports smmuv3 event 0x10 >>> during kernel booting up. >> Does it still do this if you

Re: [PATCH] Update FreeBSD CI jobs FreeBSD 14.1

2024-09-11 Thread Li-Wen Hsu
On Wed, Sep 11, 2024 at 5:02 PM Thomas Huth wrote: > The current FreeBSD CI jobs are failing installation since the > "opencv" package is now missing there. Updating to 14.1 fixes > the issue. > > Signed-off-by: Thomas Huth > Reviewed-by: Li-Wen Hsu > --- > Here's the output of a successful

Re: [PATCH 34/39] target/riscv: remove break after g_assert_not_reached()

2024-09-11 Thread Daniel Henrique Barboza
On 9/10/24 7:16 PM, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- Reviewed-by: Daniel Henrique Barboza target/riscv/monitor.c | 1 - target/riscv/insn_trans/trans_rvv.c.inc | 2 -- 2 files changed, 3 deletions(-) diff --git a/target/riscv/monitor.c b/t

[PULL v2 24/24] Update FreeBSD CI jobs FreeBSD 14.1

2024-09-11 Thread Thomas Huth
The current FreeBSD CI jobs are failing installation since the "opencv" package is now missing there. Updating to 14.1 fixes the issue. Message-Id: <20240911090149.286257-1-th...@redhat.com> Reviewed-by: Li-Wen Hsu Signed-off-by: Thomas Huth --- .gitlab-ci.d/cirrus.yml

[PULL v2 00/24] Tests and misc patches

2024-09-11 Thread Thomas Huth
Hi Peter! The following changes since commit a66f28df650166ae8b50c992eea45e7b247f4143: Merge tag 'migration-20240909-pull-request' of https://gitlab.com/peterx/qemu into staging (2024-09-10 11:19:22 +0100) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull

Re: [PATCH for-9.2 v15 04/11] s390x/pci: Check for multifunction after device realization

2024-09-11 Thread Cédric Le Goater
+Matthew +Eric Side note for the maintainers : Before this change, the igb device, which is multifunction, was working fine under Linux. Was there a fix in Linux since : 57da367b9ec4 ("s390x/pci: forbid multifunction pci device") 6069bcdeacee ("s390x/pci: Move some hotplug checks to the pr

[PULL v2 23/24] tests/functional/qemu_test: Use Python hashlib instead of external programs

2024-09-11 Thread Thomas Huth
Some systems (like OpenBSD) do not have the sha256sum or sha512sum programs installed by default, or use different names for those. Use the Python hashlib instead so we don't have to rely on the external programs. Reported-by: Peter Maydell Message-ID: <20240910201742.239559-1-th...@redhat.com> R

Re: [PATCH 20/39] hw/ppc: replace assert(false) with g_assert_not_reached()

2024-09-11 Thread Daniel Henrique Barboza
On 9/10/24 7:15 PM, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- Reviewed-by: Daniel Henrique Barboza hw/ppc/spapr_events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c index cb05874..38ac1cb7866 1

Re: [PATCH 11/39] target/ppc: replace assert(0) with g_assert_not_reached()

2024-09-11 Thread Daniel Henrique Barboza
On 9/10/24 7:15 PM, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/ppc/dfp_helper.c | 8 target/ppc/mmu_helper.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target/ppc/dfp_helper.c b/target/ppc/dfp_helper.c index 5967ea07a92..6ef31a4

Re: [PATCH v2 0/2] Postcopy migration and vhost-user errors

2024-09-11 Thread Michael S. Tsirkin
On Wed, Sep 11, 2024 at 12:44:59PM +0530, Prasad Pandit wrote: > Hello Michael, > > On Tue, 10 Sept 2024 at 22:40, Michael S. Tsirkin wrote: > > So are we going to see a version with BQL? > > === > diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c > index cdf9af4a4b..96ac0ed93b 100644

Re: [PATCH v5 0/3] vhost-user-blk: live resize additional APIs

2024-09-11 Thread Michael S. Tsirkin
On Tue, Jun 25, 2024 at 03:18:40PM +0300, Vladimir Sementsov-Ogievskiy wrote: > v5: > 03: drop extra check on is is runstate running Causes build failures when generating qdoc. https://gitlab.com/mstredhat/qemu/-/jobs/7792086965 > > Vladimir Sementsov-Ogievskiy (3): > qdev-monitor: add optio

Re: [PATCH for-9.2 v15 00/11] hw/pci: SR-IOV related fixes and improvements

2024-09-11 Thread Michael S. Tsirkin
On Wed, Sep 11, 2024 at 12:05:46PM +0900, Akihiko Odaki wrote: > On 2024/09/11 0:27, Michael S. Tsirkin wrote: > > On Tue, Sep 10, 2024 at 04:13:14PM +0200, Cédric Le Goater wrote: > > > On 9/10/24 15:34, Michael S. Tsirkin wrote: > > > > On Tue, Sep 10, 2024 at 03:21:54PM +0200, Cédric Le Goater w

Re: [PATCH] qemu/ui: set swap interval explicitly when OpenGL is enabled

2024-09-11 Thread Marc-André Lureau
On Wed, Sep 11, 2024 at 1:15 PM wrote: > From: Gert Wollny > > Before 176e3783f2ab (ui/sdl2: OpenGL window context) > SDL_CreateRenderer was called unconditionally setting > the swap interval to 0. Since SDL_CreateRenderer is now no > longer called when OpenGL is enabled, the swap interval is >

Re: [PATCH for-9.2 v15 00/11] hw/pci: SR-IOV related fixes and improvements

2024-09-11 Thread Cédric Le Goater
Better to fix than to guess if there are users, I think. Yes, but it will require some knowledge of s390x, which I cannot provide. Commit 57da367b9ec4 ("s390x/pci: forbid multifunction pci device") says having a multifunction device will make the guest spin forever. That is not what Cédric obs

Re: [PATCH 16/39] hw/hyperv: replace assert(false) with g_assert_not_reached()

2024-09-11 Thread Maciej S. Szmigiero
On 11.09.2024 00:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/hyperv/hyperv_testdev.c | 6 +++--- hw/hyperv/vmbus.c | 12 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/hyperv/hyperv_testdev.c b/hw/hyperv/hyperv_testdev.c index

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-11 Thread Michael S. Tsirkin
On Tue, Sep 10, 2024 at 11:36:08PM +0200, Mattias Nissler wrote: > On Tue, Sep 10, 2024 at 6:40 PM Michael S. Tsirkin wrote: > > > > On Tue, Sep 10, 2024 at 06:10:50PM +0200, Mattias Nissler wrote: > > > On Tue, Sep 10, 2024 at 5:44 PM Peter Maydell > > > wrote: > > > > > > > > On Tue, 10 Sept 2

Re: [PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-09-11 Thread Peter Maydell
On Wed, 11 Sept 2024 at 07:27, Jacob Abrams wrote: > On 9/10/24 02:34, Peter Maydell wrote: > > If we make the .impl and .valid changes, then the result is > > that we permit 16 bit writes to come through to the read > > and write functions. Since we don't make any changes to > > those functions t

Re: [PATCH] arm/kvm: add support for MTE

2024-09-11 Thread Peter Maydell
On Wed, 11 Sept 2024 at 07:50, Ganapatrao Kulkarni wrote: > > > > On 10-09-2024 05:53 pm, Peter Maydell wrote: > > On Tue, 10 Sept 2024 at 12:57, Ganapatrao Kulkarni > > wrote: > >> On 16-07-2024 09:15 pm, Peter Maydell wrote: > >>> Since Cornelia first wrote the patch this is based on, we've > >

Re: [PATCH v3 00/17] intel_iommu: Enable stage-1 translation for emulated device

2024-09-11 Thread Michael S. Tsirkin
On Wed, Sep 11, 2024 at 08:43:10AM +, Duan, Zhenzhong wrote: > Hi Clement, > > Thanks for your review. Hoping it could be accepted in the foreseeable future. > > Thanks > Zhenzhong the comments are minor, so just keep iterating. > >-Original Message- > >From: CLEMENT MATHIEU--DRIF

Re: [RFC 1/2] vhost-vdpa: Decouple the IOVA allocator

2024-09-11 Thread Eugenio Perez Martin
On Wed, Sep 11, 2024 at 11:06 AM Si-Wei Liu wrote: > > > > On 9/9/2024 11:22 PM, Eugenio Perez Martin wrote: > > On Tue, Sep 10, 2024 at 7:30 AM Si-Wei Liu wrote: > >> Sorry for the delayed response, it seems I missed the email reply for > >> some reason during the long weekend. > >> > >> On 9/2/

Re: [PATCH] hw/intc/arm_gic: fix spurious level triggered interrupts

2024-09-11 Thread Jan Klötzke
On Fri, 2024-09-06 at 13:50 +0100, Peter Maydell wrote: > On Mon, 2 Sept 2024 at 13:32, Jan Klötzke > wrote: > > > > Level triggered interrupts are pending when either the interrupt line > > is asserted or the interrupt was made pending by a GICD_ISPENDRn write. > > Making a level triggered inte

Re: [PATCH for-9.2 v15 04/11] s390x/pci: Check for multifunction after device realization

2024-09-11 Thread Akihiko Odaki
On 2024/09/11 18:38, Cédric Le Goater wrote: +Matthew +Eric Side note for the maintainers : Before this change, the igb device, which is multifunction, was working fine under Linux. Was there a fix in Linux since :   57da367b9ec4 ("s390x/pci: forbid multifunction pci device")   6069bcdeacee

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-11 Thread Mattias Nissler
On Wed, Sep 11, 2024 at 12:24 PM Michael S. Tsirkin wrote: > > On Tue, Sep 10, 2024 at 11:36:08PM +0200, Mattias Nissler wrote: > > On Tue, Sep 10, 2024 at 6:40 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Sep 10, 2024 at 06:10:50PM +0200, Mattias Nissler wrote: > > > > On Tue, Sep 10, 2024 a

Re: SDL2 keyboard fixes on Windows

2024-09-11 Thread Bernhard Beschow
Am 9. September 2024 06:12:23 UTC schrieb "Volker Rümelin" : >The Windows keys do not work properly with the SDL backend on Windows. >Patch 1/3 improves the situation. However, it's impossible to solve the >problem completely, as there is no way to grab the Windows keys. The >Windows keys are r

Re: [PATCH] hw/smbios: support for type 7 (cache information)

2024-09-11 Thread Michael S. Tsirkin
On Sun, Aug 11, 2024 at 10:45:38AM +, Hal Martin wrote: > This patch adds support for SMBIOS type 7 (Cache Information) to qemu. > > level: cache level (1-8) > size: cache size in bytes > > Example usage: > -smbios type=7,level=1,size=0x8000 > > Signed-off-by: Hal Martin A bunch of style i

Re: [PATCH for-9.2 v15 04/11] s390x/pci: Check for multifunction after device realization

2024-09-11 Thread Michael S. Tsirkin
On Wed, Sep 11, 2024 at 07:58:15PM +0900, Akihiko Odaki wrote: > On 2024/09/11 18:38, Cédric Le Goater wrote: > > +Matthew +Eric > > > > Side note for the maintainers : > > > > Before this change, the igb device, which is multifunction, was working > > fine under Linux. > > > > Was there a fix i

[PATCH v2 3/8] qapi/crypto: Supply missing member documentation

2024-09-11 Thread Markus Armbruster
Since we neglect to document the members of QCryptoAkCipherKeyType, their description in the QEMU QMP Reference manual is "Not documented". Fix that. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé --- qapi/crypto.json | 4 qapi/pragma.json | 1 - 2 files changed, 4 i

[PATCH v2 6/8] qapi/rocker: Supply missing member documentation

2024-09-11 Thread Markus Armbruster
Since we neglect to document the argument of query-rocker and query-rocker-ports, their description in the QEMU QMP Reference manual is "Not documented". Fix that. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé --- qapi/pragma.json | 4 +--- qapi/rocker.json | 4 2 f

[PATCH v2 4/8] qapi/introspect: Supply missing member documentation

2024-09-11 Thread Markus Armbruster
Since we neglect to document the members of JSONType, their description in the QEMU QMP Reference manual is "Not documented". Fix that. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- qapi/introspect.json | 16 qapi/pragma.json | 1 - 2 files changed, 16 inse

[PATCH v2 7/8] qapi/cxl: Supply missing member documentation

2024-09-11 Thread Markus Armbruster
Since we neglect to document a member of CxlCorErrorType, its description in the QEMU QMP Reference manual is "Not documented". Fix that. Signed-off-by: Markus Armbruster --- qapi/cxl.json| 3 +++ qapi/pragma.json | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/qapi/cxl

[PATCH v2 0/8] qapi: Supply some of the missing member documentation

2024-09-11 Thread Markus Armbruster
This series gets a few of modules off the pragma documentation-exceptions list of shame that require minimal effort. Many undocumented members still remain: module type or command #missing audio

[PATCH v2 2/8] qapi/common: Supply missing member documentation

2024-09-11 Thread Markus Armbruster
Since we neglect to document the members of GrabToggleKeys, their description in the QEMU QMP Reference manual is "Not documented". Fix that. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé --- qapi/common.json | 14 +- qapi/pragma.json | 1 - 2 files changed,

[PATCH v2 1/8] qapi/char: Supply missing member documentation

2024-09-11 Thread Markus Armbruster
Since we neglect to document several members of ChardevBackendKind, their description in the QEMU QMP Reference manual is "Not documented". Fix that, and improve the existing member documentation. Signed-off-by: Markus Armbruster --- qapi/char.json | 44 ---

[PATCH v2 5/8] qapi/pci: Supply missing member documentation

2024-09-11 Thread Markus Armbruster
Since we neglect to document a member of PciMemoryRegion, its description in the QEMU QMP Reference manual is "Not documented". Fix that. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé --- qapi/pci.json| 2 ++ qapi/pragma.json | 1 - 2 files changed, 2 insertions(+),

[PATCH v2 8/8] qapi: Document QCryptodevBackendServiceType

2024-09-11 Thread Markus Armbruster
From: zhenwei pi QCryptodevBackendServiceType was introduced by bc304a6442e (cryptodev: Introduce server type in QAPI). However there is a lack of member description. Reported-by: Markus Armbruster Signed-off-by: zhenwei pi Reviewed-by: Markus Armbruster [Drop QCryptodevBackendServiceType fro

Re: [PATCH v1 01/14] s390x/s390-virtio-ccw: don't crash on weird RAM sizes

2024-09-11 Thread Janosch Frank
On 9/10/24 7:57 PM, David Hildenbrand wrote: KVM is not happy when starting a VM with weird RAM sizes: # qemu-system-s390x --enable-kvm --nographic -m 1234K qemu-system-s390x: kvm_set_user_memory_region: KVM_SET_USER_MEMORY_REGION failed, slot=0, start=0x0, size=0x244000: Invalid argu

Re: [PATCH v2 5/8] qapi/pci: Supply missing member documentation

2024-09-11 Thread Michael S. Tsirkin
On Wed, Sep 11, 2024 at 01:25:42PM +0200, Markus Armbruster wrote: > Since we neglect to document a member of PciMemoryRegion, its > description in the QEMU QMP Reference manual is "Not documented". Fix > that. > > Signed-off-by: Markus Armbruster > Reviewed-by: Philippe Mathieu-Daudé Reviewed

Re: [PATCH RFC V3 01/29] arm/virt,target/arm: Add new ARMCPU {socket,cluster,core,thread}-id property

2024-09-11 Thread Jonathan Cameron via
On Tue, 10 Sep 2024 12:01:05 +0100 Salil Mehta wrote: > HI Zhao, A few trivial comments inline. > > > From: Zhao Liu > > Sent: Monday, September 9, 2024 4:28 PM > > To: Salil Mehta > > > > On Wed, Sep 04, 2024 at 05:37:21PM +, Salil Mehta wrote: > > > Date: Wed, 4 Sep 2024 17:37

[PATCH v2] hw/intc/arm_gic: fix spurious level triggered interrupts

2024-09-11 Thread Jan Klötzke
On GICv2 and later, level triggered interrupts are pending when either the interrupt line is asserted or the interrupt was made pending by a GICD_ISPENDRn write. Making a level triggered interrupt pending by software persists until either the interrupt is acknowledged or cleared by writing GICD_ICP

Re: [PATCH v1 00/14] s390x: virtio-mem support

2024-09-11 Thread Janosch Frank
On 9/10/24 7:57 PM, David Hildenbrand wrote: This series introduces a new diag(500) "STORAGE LIMIT" subcode that will be documented at [2] once this+kernel part go upstream. Why not in Documentation/virt/kvm/s390/? s390-diag.rst is very similar already. I'd rather have it in a shared and bigge

Re: [PATCH 1/3] ui/sdl2: reenable the SDL2 Windows keyboard hook procedure

2024-09-11 Thread Philippe Mathieu-Daudé
Hi Volker, On 9/9/24 21:38, Volker Rümelin wrote: Am 09.09.24 um 09:26 schrieb Marc-André Lureau: Hi On Mon, Sep 9, 2024 at 10:22 AM Volker Rümelin wrote: Windows only: The libSDL2 Windows message loop needs the libSDL2 Windows low level keyboard hook procedure to grab the left and right Wi

Re: [RFC PATCH v2 1/5] vhost-user: Add VIRTIO Shared Memory map request

2024-09-11 Thread Albert Esteve
On Thu, Sep 5, 2024 at 6:45 PM Stefan Hajnoczi wrote: > On Tue, Sep 03, 2024 at 01:54:12PM +0200, Albert Esteve wrote: > > On Tue, Sep 3, 2024 at 11:54 AM Albert Esteve > wrote: > > > > > > > > > > > On Thu, Jul 11, 2024 at 9:45 AM Stefan Hajnoczi > > > wrote: > > > > > >> On Fri, Jun 28, 2024

Re: [PATCH v1 01/14] s390x/s390-virtio-ccw: don't crash on weird RAM sizes

2024-09-11 Thread Thomas Huth
On 10/09/2024 19.57, David Hildenbrand wrote: KVM is not happy when starting a VM with weird RAM sizes: # qemu-system-s390x --enable-kvm --nographic -m 1234K qemu-system-s390x: kvm_set_user_memory_region: KVM_SET_USER_MEMORY_REGION failed, slot=0, start=0x0, size=0x244000: Invalid arg

Re: [PATCH 1/3] ui/sdl2: reenable the SDL2 Windows keyboard hook procedure

2024-09-11 Thread Philippe Mathieu-Daudé
On 11/9/24 13:57, Philippe Mathieu-Daudé wrote: Hi Volker, On 9/9/24 21:38, Volker Rümelin wrote: Am 09.09.24 um 09:26 schrieb Marc-André Lureau: Hi On Mon, Sep 9, 2024 at 10:22 AM Volker Rümelin wrote: Windows only: The libSDL2 Windows message loop needs the libSDL2 Windows low level key

Re: [PATCH] qemu/ui: set swap interval explicitly when OpenGL is enabled

2024-09-11 Thread Philippe Mathieu-Daudé
On 11/9/24 11:14, gert.wol...@collabora.com wrote: From: Gert Wollny Before 176e3783f2ab (ui/sdl2: OpenGL window context) SDL_CreateRenderer was called unconditionally setting the swap interval to 0. Since SDL_CreateRenderer is now no longer called when OpenGL is enabled, the swap interval is n

[PULL 03/56] hw/intc/loongson_ipi: Remove unused headers

2024-09-11 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Bibo Mao Tested-by: Bibo Mao Acked-by: Song Gao Reviewed-by: Richard Henderson Reviewed-by: Jiaxun Yang Tested-by: Jiaxun Yang Message-Id: <20240718133312.10324-19-phi...@linaro.org> --- hw/intc/loongson_ipi.c | 9 - 1 file changed,

[PULL 01/56] hw/pci-host/designware: Declare CPU QOM types using DEFINE_TYPES() macro

2024-09-11 Thread Philippe Mathieu-Daudé
When multiple QOM types are registered in the same file, it is simpler to use the the DEFINE_TYPES() macro. In particular because type array declared with such macro are easier to review. Remove a pointless structure declaration in "designware.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-b

[PULL 00/56] Misc HW & UI patches

2024-09-11 Thread Philippe Mathieu-Daudé
gs/hw-misc-20240911 for you to fetch changes up to d6bda15a00b46778e577c95c77f066f95ed58e07: ui: remove break after g_assert_not_reached() (2024-09-11 13:54:06 +0200) Misc HW & UI patches - Remove deprecated SH4 SHIX machine TC581

[PULL 05/56] hw/block: Remove TC58128 NAND EEPROM

2024-09-11 Thread Philippe Mathieu-Daudé
The TC58128 NAND EEPROM is not user creatable and needs to be instanciated in the code via tc58128_init(). Only the SHIX machine was using it, and it was removed in the previous commit. Since the TC58128 has no more users, remove it too. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter M

[PULL 02/56] hw/pci-host/designware: Add 'host_mem' variable for clarity

2024-09-11 Thread Philippe Mathieu-Daudé
designware_pcie_root_realize() uses get_system_memory() as the "host side memory region", as opposed to the "PCI side" one. Introduce the 'host_mem' variable for clarity. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Gustavo Romero Message-Id: <20231012121857.318

[PULL 12/56] hw/cris: Remove image loader helper

2024-09-11 Thread Philippe Mathieu-Daudé
No more CRIS machine uses cris_load_image(), remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Acked-by: Edgar E. Iglesias Message-ID: <20240904143603.52934-7-phi...@linaro.org> --- hw/cris/boot.h | 16 --- hw/cris/boot.c |

[PULL 06/56] hw/sh4: Remove sh7750_register_io_device() helper

2024-09-11 Thread Philippe Mathieu-Daudé
sh7750_register_io_device() was only used by the TC58128 NAND EEPROM which has been removed in the previous commit. Remove it as unused code. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Yoshinori Sato Message-ID: <20240903153959.18392-4-phi...@linaro.org> ---

[PULL 15/56] hw/net: Remove TYPE_ETRAX_FS_ETH device

2024-09-11 Thread Philippe Mathieu-Daudé
We just removed the single machine using it (axis-dev88). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Acked-by: Edgar E. Iglesias Message-ID: <20240904143603.52934-10-phi...@linaro.org> --- include/hw/cris/etraxfs.h | 36 -- hw/net/etraxfs_et

[PULL 08/56] tests/tcg: Remove CRIS bare test files

2024-09-11 Thread Philippe Mathieu-Daudé
We are going to remove the CRIS target. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Acked-by: Edgar E. Iglesias Message-ID: <20240904143603.52934-3-phi...@linaro.org> --- MAINTAINERS | 1 - tests/tcg/cris/bare/sys.c

[PULL 10/56] linux-user: Remove support for CRIS target

2024-09-11 Thread Philippe Mathieu-Daudé
As per the deprecation notice in commit c7bbef4023: The CRIS architecture was pulled from Linux in 4.17 and the compiler is no longer packaged in any distro making it harder to run the `check-tcg` tests. Unless we can improve the testing situation there is a chance the code will bitrot w

[PULL 20/56] seccomp: Remove check for CRIS host

2024-09-11 Thread Philippe Mathieu-Daudé
As per the deprecation notice in commit c7bbef4023: The CRIS architecture was pulled from Linux in 4.17 and the compiler is no longer packaged in any distro [...]. It is now unlikely QEMU is build on CRIS host. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Ric

[PULL 18/56] system: Remove support for CRIS target

2024-09-11 Thread Philippe Mathieu-Daudé
We are about to remove the CRIS target, so remove the sysemu part. This remove the CRIS 'none' machine. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Acked-by: Edgar E. Iglesias Message-ID: <20240904143603.52934-13-phi...@linaro.org> --- configs

[PULL 09/56] buildsys: Remove CRIS cross container

2024-09-11 Thread Philippe Mathieu-Daudé
We removed the cross compiled CRIS tests in the previous commit. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Acked-by: Edgar E. Iglesias Message-ID: <20240904143603.52934-4-phi...@linaro.org> --- configure

[PULL 04/56] hw/sh4: Remove the deprecated SHIX machine

2024-09-11 Thread Philippe Mathieu-Daudé
The SHIX machine is deprecated since v9.0 (commit 322b038c94 "target/sh4: Deprecate the shix machine"). Time to remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Yoshinori Sato Message-ID: <20240903153959.18392-2-phi...@linaro.org> --- MAINTAINERS

[PULL 07/56] tests/tcg: Remove CRIS libc test files

2024-09-11 Thread Philippe Mathieu-Daudé
We never compiled / ran these tests. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Acked-by: Edgar E. Iglesias Message-ID: <20240904143603.52934-2-phi...@linaro.org> --- tests/tcg/cris/libc/crisutils.h | 76 -- tests/tcg/c

[PULL 31/56] MAINTAINERS: Add myself as a reviewer of VT-d

2024-09-11 Thread Philippe Mathieu-Daudé
From: CLEMENT MATHIEU--DRIF Signed-off-by: Clément Mathieu--Drif Acked-by: Jason Wang Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin Message-ID: <20240820095112.61510-1-clement.mathieu--d...@eviden.com> Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file ch

[PULL 16/56] hw/dma: Remove ETRAX_FS DMA device

2024-09-11 Thread Philippe Mathieu-Daudé
We just removed the single machine calling etraxfs_dmac_init() (the axis-dev88 machine). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Acked-by: Edgar E. Iglesias Message-ID: <20240904143603.52934-11-phi...@linaro.org> --- MAINTAINERS

[PULL 11/56] hw/cris: Remove the axis-dev88 machine

2024-09-11 Thread Philippe Mathieu-Daudé
This machine was deprecated for the v9.0 release in commit c7bbef4023 ("docs: mark CRIS support as deprecated"). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Acked-by: Edgar E. Iglesias Message-ID: <20240904143603.52934-6-phi...@linaro.org> ---

[PULL 30/56] hw/char/pl011: Rename RX FIFO methods

2024-09-11 Thread Philippe Mathieu-Daudé
In preparation of having a TX FIFO, rename the RX FIFO methods. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20240719181041.49545-12-phi...@linaro.org> --- hw/char/pl011.c | 12 ++-- hw/char/trace-events | 4 ++-- 2 fi

[PULL 43/56] tests/unit: Comment FIFO8 tests

2024-09-11 Thread Philippe Mathieu-Daudé
Add comments describing how the FIFO evolves during each test. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland Message-Id: <20240906132909.78886-4-phi...@linaro.org> --- tests/unit/test-fifo.c | 188 - 1 file changed, 187 insertions(+)

[PULL 24/56] hw/char/pl011: Move pl011_put_fifo() earlier

2024-09-11 Thread Philippe Mathieu-Daudé
Avoid forward-declaring pl011_put_fifo() by moving it earlier. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Message-Id: <20240719181041.49545-4-phi...@linaro.org> --- hw/char/pl011.c | 46 ++ 1 file changed, 22 insertions(+), 24 de

[PULL 22/56] hw/audio/virtio-sound: fix heap buffer overflow

2024-09-11 Thread Philippe Mathieu-Daudé
From: Volker Rümelin Currently, the guest may write to the device configuration space, whereas the virtio sound device specification in chapter 5.14.4 clearly states that the fields in the device configuration space are driver-read-only. Remove the set_config function from the virtio_snd class.

[PULL 52/56] system: replace assert(0) with g_assert_not_reached()

2024-09-11 Thread Philippe Mathieu-Daudé
From: Pierrick Bouvier Signed-off-by: Pierrick Bouvier Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240910221606.1817478-11-pierrick.bouv...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé --- system/rtc.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PULL 36/56] fifo8: rename fifo8_pop_buf() to fifo8_peekpop_buf()

2024-09-11 Thread Philippe Mathieu-Daudé
From: Mark Cave-Ayland The fifo8_pop_buf() function will soon also be used for peek operations, so rename the function accordingly. Create a new fifo8_pop_buf() wrapper function that can be used by existing callers. Signed-off-by: Mark Cave-Ayland Reviewed-by: Octavian Purdila Reviewed-by: Ali

[PULL 33/56] fifo8: introduce head variable for fifo8_peekpop_bufptr()

2024-09-11 Thread Philippe Mathieu-Daudé
From: Mark Cave-Ayland Rather than operate on fifo->head directly, introduce a new head variable which is set to the value of fifo->head and use it instead. This is to allow future adjustment of the head position within the internal FIFO buffer. Signed-off-by: Mark Cave-Ayland Reviewed-by: Octa

[PULL 42/56] tests/unit: Expand test_fifo8_peek_buf_wrap() coverage

2024-09-11 Thread Philippe Mathieu-Daudé
Test fifo8_peek_buf() can fill a buffer with wrapped data. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland Message-Id: <20240906132909.78886-3-phi...@linaro.org> --- tests/unit/test-fifo.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/unit

[PULL 38/56] fifo8: add fifo8_peek_buf() function

2024-09-11 Thread Philippe Mathieu-Daudé
From: Mark Cave-Ayland This is a wrapper function around fifo8_peekpop_buf() that allows the caller to peek into the FIFO, including handling the case where there is a wraparound of the internal FIFO buffer. Signed-off-by: Mark Cave-Ayland Reviewed-by: Octavian Purdila Reviewed-by: Alistair Fr

[PULL 49/56] hw/gpio: remove break after g_assert_not_reached()

2024-09-11 Thread Philippe Mathieu-Daudé
From: Pierrick Bouvier Signed-off-by: Pierrick Bouvier Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240910221606.1817478-28-pierrick.bouv...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé --- hw/gpio/nrf51_gpio.c | 1 - 1 file changed, 1 deletion(-) d

[PULL 27/56] hw/char/pl011: Extract pl011_write_txdata() from pl011_write()

2024-09-11 Thread Philippe Mathieu-Daudé
When implementing FIFO, this code will become more complex. Start by factoring it out to a new pl011_write_txdata() function. No functional change intended. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Message-Id: <20240719181041.49545-7-phi...@linaro.org> --- hw/char/pl011.c

[PULL 14/56] hw/char: Remove TYPE_ETRAX_FS_SERIAL device

2024-09-11 Thread Philippe Mathieu-Daudé
We just removed the single machine using it (axis-dev88). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Acked-by: Edgar E. Iglesias Message-ID: <20240904143603.52934-9-phi...@linaro.org> --- include/hw/cris/etraxfs.h | 18 --- hw/char/etraxfs_s

[PULL 23/56] hw/char/pl011: Remove unused 'readbuff' field

2024-09-11 Thread Philippe Mathieu-Daudé
Since its introduction in commit cdbdb648b7 ("ARM Versatile Platform Baseboard emulation.") PL011State::readbuff as never been used. Remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Message-Id: <20240719181041.49545-3-phi...@linaro.org> --- include/hw/char/pl011.h | 1

[PULL 13/56] hw/intc: Remove TYPE_ETRAX_FS_PIC device

2024-09-11 Thread Philippe Mathieu-Daudé
We just removed the single machine using it (axis-dev88). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Acked-by: Edgar E. Iglesias Message-ID: <20240904143603.52934-8-phi...@linaro.org> --- hw/intc/etraxfs_pic.c | 172 --

[PULL 56/56] ui: remove break after g_assert_not_reached()

2024-09-11 Thread Philippe Mathieu-Daudé
From: Pierrick Bouvier Signed-off-by: Pierrick Bouvier Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240910221606.1817478-37-pierrick.bouv...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé --- ui/qemu-pixman.c | 1 - 1 file changed, 1 deletion(-) diff

[PULL 26/56] hw/char/pl011: Split RX/TX path of pl011_reset_fifo()

2024-09-11 Thread Philippe Mathieu-Daudé
To be able to reset the RX or TX FIFO separately, split pl011_reset_fifo() in two. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20240719181041.49545-6-phi...@linaro.org> --- hw/char/pl011.c | 19 ++- 1 file changed,

[PULL 28/56] hw/char/pl011: Extract pl011_read_rxdata() from pl011_read()

2024-09-11 Thread Philippe Mathieu-Daudé
To keep MemoryRegionOps read/write handlers with similar logic, factor pl011_read_txdata() out of pl011_read(), similar to what the previous commit did to pl011_write(). No functional change intended. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <2024071918104

[PULL 17/56] hw/timer: Remove TYPE_ETRAX_FS_TIMER device

2024-09-11 Thread Philippe Mathieu-Daudé
We just removed the single machine using it (axis-dev88). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Acked-by: Edgar E. Iglesias Message-ID: <20240904143603.52934-12-phi...@linaro.org> --- MAINTAINERS | 8 - hw/timer

[PULL 44/56] hw/char/escc: convert Sun mouse to use QemuInputHandler

2024-09-11 Thread Philippe Mathieu-Daudé
From: Mark Cave-Ayland Update the Sun mouse implementation to use QemuInputHandler instead of the legacy qemu_add_mouse_event_handler() function. Note that this conversion adds extra sunmouse_* members to ESCCChannelState but they are not added to the migration stream (similar to the Sun keyboar

[PULL 45/56] hw/input/adb-mouse: convert to use QemuInputHandler

2024-09-11 Thread Philippe Mathieu-Daudé
From: Mark Cave-Ayland Update the ADB mouse implementation to use QemuInputHandler instead of the legacy qemu_add_mouse_event_handler() function. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240907173700.348818-1-mark.cave-ayl...@ilande.co.uk> [PMD: Add co

Re: [PATCH] hw/intc/arm_gic: fix spurious level triggered interrupts

2024-09-11 Thread Peter Maydell
On Wed, 11 Sept 2024 at 11:54, Jan Klötzke wrote: > > On Fri, 2024-09-06 at 13:50 +0100, Peter Maydell wrote: > > On Mon, 2 Sept 2024 at 13:32, Jan Klötzke > > wrote: > > > > > > Level triggered interrupts are pending when either the interrupt line > > > is asserted or the interrupt was made pen

[PULL 53/56] ui/sdl2: release all modifiers

2024-09-11 Thread Philippe Mathieu-Daudé
From: Volker Rümelin Each virtual console in the SDL2 frontend has a key state map. When switching windows with GUI keys we have to release all pressed modifier keys in the currently active window, because after the switch the now inactive window no longer receives the key release events. To rep

[PULL 34/56] fifo8: add skip parameter to fifo8_peekpop_bufptr()

2024-09-11 Thread Philippe Mathieu-Daudé
From: Mark Cave-Ayland The skip parameter specifies the number of bytes to be skipped from the current FIFO head before the peek or pop operation. Signed-off-by: Mark Cave-Ayland Reviewed-by: Alistair Francis Reviewed-by: Octavian Purdila Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philip

[PULL 48/56] hw/watchdog: replace assert(0) with g_assert_not_reached()

2024-09-11 Thread Philippe Mathieu-Daudé
From: Pierrick Bouvier Signed-off-by: Pierrick Bouvier Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard W.M. Jones Message-ID: <20240910221606.1817478-8-pierrick.bouv...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé --- hw/watchdog/watchdog.c | 2 +

[PULL 47/56] hw/core: replace assert(0) with g_assert_not_reached()

2024-09-11 Thread Philippe Mathieu-Daudé
From: Pierrick Bouvier Signed-off-by: Pierrick Bouvier Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240910221606.1817478-6-pierrick.bouv...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé --- hw/core/numa.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

  1   2   3   4   >