Re: [PATCH 06/12] tcg/optimize: Fold movcond with true and false values identical

2024-09-10 Thread Philippe Mathieu-Daudé
On 8/9/24 04:26, Richard Henderson wrote: Fold "x = cond ? y : y" to "x = y". Signed-off-by: Richard Henderson --- tcg/optimize.c | 5 + 1 file changed, 5 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v3 04/14] tcg/riscv: Add riscv vset{i}vli support

2024-09-10 Thread LIU Zhiwei
On 2024/9/10 12:34, Richard Henderson wrote: On 9/9/24 19:46, LIU Zhiwei wrote:     lmul = type - riscv_lg2_vlenb;     if (lmul < -3) {     /* Host VLEN >= 1024 bits. */     vlmul = VLMUL_M1; I am not sure if we should use VLMUL_MF8, Perhaps.  See below.     } else if (lmul < 3) {

Re: [PATCH 11/12] tcg/i386: Add predicate parameters to tcg_out_evex_opc

2024-09-10 Thread Philippe Mathieu-Daudé
On 8/9/24 04:26, Richard Henderson wrote: Extend tcg_out_evex_opc to handle the predicate and zero-merging parameters of the evex prefix. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c.inc | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu

Re: [PATCH v2 06/10 2/4] target/s390x: Use deposit to set psw_mask in save_link_info

2024-09-10 Thread Philippe Mathieu-Daudé
On 10/9/24 01:50, Richard Henderson wrote: On 9/9/24 16:19, Philippe Mathieu-Daudé wrote: From: Richard Henderson Signed-off-by: Richard Henderson Message-ID: <20240605215739.4758-7-richard.hender...@linaro.org> [PMD: Split patch, part 2/4] Signed-off-by: Philippe Mathieu-Daudé ---   target/

Re: [PATCH 0/2] Solve vt82c686 qemu_irq leak.

2024-09-10 Thread Michael S. Tsirkin
On Sat, Jun 29, 2024 at 10:01:52PM +0200, BALATON Zoltan wrote: > This is an alternative appriach to solve the qemu_irq leak in > vt82c686. Allowing embedding an irq and init it in place like done > with other objects may allow cleaner fix for similar issues and I also > plan to use this for adding

Re: [RFC PATCH v2 5/5] vhost_user: Implement mem_read/mem_write handlers

2024-09-10 Thread Albert Esteve
On Thu, Sep 5, 2024 at 9:18 PM Stefan Hajnoczi wrote: > On Wed, Sep 04, 2024 at 03:01:06PM +0200, Albert Esteve wrote: > > On Thu, Jul 11, 2024 at 10:55 AM Stefan Hajnoczi > > wrote: > > > > > On Fri, Jun 28, 2024 at 04:57:10PM +0200, Albert Esteve wrote: > > > > Implement function handlers for

Re: [PATCH v4 2/2] hw/char: sifive_uart: Print uart characters async

2024-09-10 Thread Philippe Mathieu-Daudé
On 10/9/24 06:54, Alistair Francis wrote: The current approach of using qemu_chr_fe_write() and ignoring the return values results in dropped characters [1]. Let's update the SiFive UART to use a async sifive_uart_xmit() function to transmit the characters and apply back pressure to the guest wi

Re: [PATCH v4 1/2] hw/char: riscv_htif: Use blocking qemu_chr_fe_write_all

2024-09-10 Thread Philippe Mathieu-Daudé
On 10/9/24 06:54, Alistair Francis wrote: The current approach of using qemu_chr_fe_write() and ignoring the return values results in dropped characters [1]. Ideally we want to report FIFO status to the guest, but the HTIF isn't a real UART, so we don't really have a way to do that. Instead let'

Re: check-functional skipUnless failure

2024-09-10 Thread Thomas Huth
On 10/09/2024 08.41, Philippe Mathieu-Daudé wrote: On 10/9/24 05:58, Richard Henderson wrote: [rth@cfarm120 bld]$ make check-functional [1/2] Generating tests/functional/func-precache-m68k-m68k_nextcube with a custom command (wrapped by meson to set env) FAILED: tests/functional/m68k-m68k_next

[PATCH] tests/functional: Fix bad usage of has_cmd

2024-09-10 Thread Thomas Huth
has_cmd returns a tuple, not a boolean value. This fixes a crash when e.g. "tesseract" is not available in the test_m68k_nextcube test. Reported-by: Richard Henderson Signed-off-by: Thomas Huth --- tests/functional/qemu_test/cmd.py | 6 +++--- tests/functional/qemu_test/tesseract.py | 3 +

Re: [PATCH] tests/functional: Fix bad usage of has_cmd

2024-09-10 Thread Daniel P . Berrangé
On Tue, Sep 10, 2024 at 09:58:20AM +0200, Thomas Huth wrote: > has_cmd returns a tuple, not a boolean value. This fixes a crash when > e.g. "tesseract" is not available in the test_m68k_nextcube test. > > Reported-by: Richard Henderson > Signed-off-by: Thomas Huth > --- > tests/functional/qemu_

Re: [PATCH] Add vhost-user-spi and vhost-user-spi-pci devices

2024-09-10 Thread Haixu Cui
On 9/2/2024 6:15 PM, Alex Bennée wrote: Haixu Cui writes: Hi Alex, Thanks a lot for your comments, please refer to my response below. On 8/28/2024 1:14 AM, Alex Bennée wrote: Haixu Cui writes: Apologies for the delay in getting to this. This work is based on the virtio-spi spec, v

Re: [PATCH] docs/system/cpu-hotplug: Update example's socket-id/core-id

2024-09-10 Thread Igor Mammedov
On Mon, 19 Aug 2024 15:43:03 +0100 Peter Maydell wrote: > At some point the way we allocate socket-id and core-id to CPUs > by default changed; update the example of how to do CPU hotplug > and unplug so the example commands work again. The differences > in the sample input and output are: > * t

[RFC 1/6] accel/kvm: SIGBUS handler should also deal with si_addr_lsb

2024-09-10 Thread “William Roche
From: William Roche The SIGBUS signal siginfo reporting a HW memory error provides a si_addr_lsb fields with an indication of the impacted memory page size. This information should be used to track the hwpoisoned page sizes. Signed-off-by: William Roche --- accel/kvm/kvm-all.c| 6 -- a

[RFC 3/6] system/physmem: Remap memory pages on reset based on the page size

2024-09-10 Thread “William Roche
From: William Roche When the VM reboots, a memory reset is performed calling qemu_ram_remap() on all hwpoisoned pages. We take into account the recorded page size to adjust the size and location of the memory hole. In case of a largepage used, we also need to punch a hole in the backend file to r

[RFC 4/6] system: Introducing hugetlbfs largepage RAS feature

2024-09-10 Thread “William Roche
From: William Roche We need to deal with hugetlbfs memory large pages facing HW errors, to increase the probability to survive a memory poisoning. When an error is detected, the platform kernel marks the entire hugetlbfs large page as "poisoned" and reports the event to all potential users using

[RFC 0/6] hugetlbfs largepage RAS project

2024-09-10 Thread “William Roche
From: William Roche Hello, This is a Qemu RFC to introduce the possibility to deal with hardware memory errors impacting hugetlbfs memory backed VMs. When using hugetlbfs large pages, any large page location being impacted by an HW memory error results in poisoning the entire page, suddenly maki

[RFC 5/6] system/hugetlb_ras: Handle madvise SIGBUS signal on listener

2024-09-10 Thread “William Roche
From: William Roche madvise MADV_HWPOISON can generate a SIGBUS when called, so the listener thread (the caller) needs to deal with this signal. The signal handler recognizes a thread specific variable allowing it to directly exit when generated from this thread. Signed-off-by: William Roche --

[RFC 6/6] system/hugetlb_ras: Replay lost BUS_MCEERR_AO signals on VM resume

2024-09-10 Thread “William Roche
From: William Roche In case the SIGBUS handler is triggered by a BUS_MCEERR_AO signal and this handler needs to exit to let the VM pause during the memory mapping change, this SIGBUS won't be regenerated when the VM resumes. In this case we take note of this signal before exiting the handler to r

[RFC 2/6] accel/kvm: Keep track of the HWPoisonPage sizes

2024-09-10 Thread “William Roche
From: William Roche Add the page size information to the hwpoison_page_list elements. Signed-off-by: William Roche --- accel/kvm/kvm-all.c | 11 +++ include/sysemu/kvm.h | 3 ++- include/sysemu/kvm_int.h | 3 ++- target/arm/kvm.c | 5 +++-- target/i386/kvm/kvm.c

Re: [PATCH] virtio-9p: remove virtfs-proxy-helper

2024-09-10 Thread Christian Schoenebeck via
On Thursday, September 5, 2024 10:22:59 AM CEST Paolo Bonzini wrote: > It has been deprecated since 8.1; remove it and suggest using permission > mapping > or virtiofsd. virtfs-proxy-helper is just one component and (implementation detail) being removed. So I would change the commit log to: 9p

Re: [PATCH for-9.2 v15 00/11] hw/pci: SR-IOV related fixes and improvements

2024-09-10 Thread Michael S. Tsirkin
On Fri, Aug 23, 2024 at 02:00:37PM +0900, Akihiko Odaki wrote: > Supersedes: <20240714-rombar-v2-0-af1504ef5...@daynix.com> > ("[PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto") > > I submitted a RFC series[1] to add support for SR-IOV emulation to > virtio-net-pci. During the development of

Re: [Bug Report] smmuv3 event 0x10 report when running virtio-blk-pci

2024-09-10 Thread Mostafa Saleh
On Tue, Sep 10, 2024 at 2:51 AM Zhou Wang wrote: > > On 2024/9/9 22:47, Mostafa Saleh wrote: > > Hi Zhou, > > > > On Mon, Sep 9, 2024 at 3:22 PM Zhou Wang via wrote: > >> > >> Hi All, > >> > >> When I tested mainline qemu(commit 7b87a25f49), it reports smmuv3 event > >> 0x10 > >> during kernel b

Re: [PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-09-10 Thread Peter Maydell
On Mon, 9 Sept 2024 at 18:40, Philippe Mathieu-Daudé wrote: > > Hi, > > (Cc'ing Arnaud & Inès who are listed as maintainers) > > On 6/9/24 18:12, Peter Maydell wrote: > > On Mon, 2 Sept 2024 at 14:38, Jacob Abrams wrote: > >> > >> These changes allow the official STM32L4xx HAL UART driver to func

Re: [PATCH for-9.2 v15 00/11] hw/pci: SR-IOV related fixes and improvements

2024-09-10 Thread Akihiko Odaki
On 2024/09/10 18:21, Michael S. Tsirkin wrote: On Fri, Aug 23, 2024 at 02:00:37PM +0900, Akihiko Odaki wrote: Supersedes: <20240714-rombar-v2-0-af1504ef5...@daynix.com> ("[PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto") I submitted a RFC series[1] to add support for SR-IOV emulation to v

Re: [PATCH] docs/system/cpu-hotplug: Update example's socket-id/core-id

2024-09-10 Thread Peter Maydell
On Tue, 10 Sept 2024 at 10:03, Igor Mammedov wrote: > > On Mon, 19 Aug 2024 15:43:03 +0100 > Peter Maydell wrote: > > > At some point the way we allocate socket-id and core-id to CPUs > > by default changed; update the example of how to do CPU hotplug > > and unplug so the example commands work a

[PATCH v5 1/4] tests: use default cpu for aarch64/sbsa-ref

2024-09-10 Thread Marcin Juszkiewicz
We want to run tests using default cpu without having to remember which Arm core is it. Change Neoverse-N1 (old default) test to use default cpu (Neoverse-N2 at the moment). Signed-off-by: Marcin Juszkiewicz --- tests/functional/test_aarch64_sbsaref.py | 18 ++ 1 file changed, 1

[PATCH v5 3/4] tests: expand timeout information for aarch64/sbsa-ref

2024-09-10 Thread Marcin Juszkiewicz
'Test might timeout' means nothing. Replace it with useful information that it is emulation of pointer authentication what makes this test run too long. Signed-off-by: Marcin Juszkiewicz --- tests/functional/test_aarch64_sbsaref.py | 15 ++- 1 file changed, 10 insertions(+), 5 deleti

[PATCH v5 2/4] tests: add FreeBSD tests for aarch64/sbsa-ref

2024-09-10 Thread Marcin Juszkiewicz
FreeBSD has longer support cycle for stable release (14.x EoL in 2028) than OpenBSD (7.3 we use is already EoL). Also bugfixes are backported so we can stay on 14.x for longer. Signed-off-by: Marcin Juszkiewicz --- tests/functional/test_aarch64_sbsaref.py | 43 +++- 1

[PATCH v5 4/4] tests: drop OpenBSD tests for aarch64/sbsa-ref

2024-09-10 Thread Marcin Juszkiewicz
OpenBSD 7.3 we use is EoL. Both 7.4 and 7.5 releases do not work on anything above Neoverse-N1 due to PAC emulation: https://marc.info/?l=openbsd-arm&m=171050428327850&w=2 OpenBSD 7.6 is not yet released. Signed-off-by: Marcin Juszkiewicz --- tests/functional/test_aarch64_sbsaref.py | 44 -

[PATCH v5 0/4] tests: updates for aarch64/sbsa-ref

2024-09-10 Thread Marcin Juszkiewicz
We want test to run on default cpu settings. For now it is plain Neoverse-N2 but we are considering either disabling PAuth or going with 'impdef' way. We want to have some non-Linux OS in testing in case one of changes keep Linux booting but crash elsewhere. So far OpenBSD was used for it but we m

[RFC RESEND 5/6] system/hugetlb_ras: Handle madvise SIGBUS signal on listener

2024-09-10 Thread “William Roche
From: William Roche madvise MADV_HWPOISON can generate a SIGBUS when called, so the listener thread (the caller) needs to deal with this signal. The signal handler recognizes a thread specific variable allowing it to directly exit when generated from this thread. Signed-off-by: William Roche --

[RFC RESEND 4/6] system: Introducing hugetlbfs largepage RAS feature

2024-09-10 Thread “William Roche
From: William Roche We need to deal with hugetlbfs memory large pages facing HW errors, to increase the probability to survive a memory poisoning. When an error is detected, the platform kernel marks the entire hugetlbfs large page as "poisoned" and reports the event to all potential users using

[RFC RESEND 3/6] system/physmem: Remap memory pages on reset based on the page size

2024-09-10 Thread “William Roche
From: William Roche When the VM reboots, a memory reset is performed calling qemu_ram_remap() on all hwpoisoned pages. We take into account the recorded page size to adjust the size and location of the memory hole. In case of a largepage used, we also need to punch a hole in the backend file to r

[RFC RESEND 2/6] accel/kvm: Keep track of the HWPoisonPage sizes

2024-09-10 Thread “William Roche
From: William Roche Add the page size information to the hwpoison_page_list elements. Signed-off-by: William Roche --- accel/kvm/kvm-all.c | 11 +++ include/sysemu/kvm.h | 3 ++- include/sysemu/kvm_int.h | 3 ++- target/arm/kvm.c | 5 +++-- target/i386/kvm/kvm.c

[RFC RESEND 6/6] system/hugetlb_ras: Replay lost BUS_MCEERR_AO signals on VM resume

2024-09-10 Thread “William Roche
From: William Roche In case the SIGBUS handler is triggered by a BUS_MCEERR_AO signal and this handler needs to exit to let the VM pause during the memory mapping change, this SIGBUS won't be regenerated when the VM resumes. In this case we take note of this signal before exiting the handler to r

[RFC RESEND 1/6] accel/kvm: SIGBUS handler should also deal with si_addr_lsb

2024-09-10 Thread “William Roche
From: William Roche The SIGBUS signal siginfo reporting a HW memory error provides a si_addr_lsb fields with an indication of the impacted memory page size. This information should be used to track the hwpoisoned page sizes. Signed-off-by: William Roche --- accel/kvm/kvm-all.c| 6 -- a

[RFC RESEND 0/6] hugetlbfs largepage RAS project

2024-09-10 Thread “William Roche
From: William Roche Apologies for the noise; resending as I missed CC'ing the maintainers of the changed files Hello, This is a Qemu RFC to introduce the possibility to deal with hardware memory errors impacting hugetlbfs memory backed VMs. When using hugetlbfs large pages, any large page loc

Re: [PATCH for-9.2 00/53] arm: Drop deprecated boards

2024-09-10 Thread Peter Maydell
On Mon, 9 Sept 2024 at 16:02, Peter Maydell wrote: > > On Mon, 9 Sept 2024 at 15:55, Guenter Roeck wrote: > > > > On 9/9/24 06:40, Philippe Mathieu-Daudé wrote: > > > Hi, > > > > > > On 3/9/24 18:06, Peter Maydell wrote: > > >> This patchset removes the various Arm machines which we deprecated >

Re: [PATCH] virtio-9p: remove virtfs-proxy-helper

2024-09-10 Thread Christian Schoenebeck via
On Tuesday, September 10, 2024 11:16:55 AM CEST Christian Schoenebeck wrote: > On Thursday, September 5, 2024 10:22:59 AM CEST Paolo Bonzini wrote: > > It has been deprecated since 8.1; remove it and suggest using permission > > mapping > > or virtiofsd. > > virtfs-proxy-helper is just one compon

RE: [PATCH RFC V3 01/29] arm/virt,target/arm: Add new ARMCPU {socket,cluster,core,thread}-id property

2024-09-10 Thread Salil Mehta via
HI Zhao, > From: Zhao Liu > Sent: Monday, September 9, 2024 4:28 PM > To: Salil Mehta > > On Wed, Sep 04, 2024 at 05:37:21PM +, Salil Mehta wrote: > > Date: Wed, 4 Sep 2024 17:37:21 + > > From: Salil Mehta > > Subject: RE: [PATCH RFC V3 01/29] arm/virt,target/arm: Add new ARMCP

Re: check-functional skipUnless failure

2024-09-10 Thread Philippe Mathieu-Daudé
On 10/9/24 09:36, Thomas Huth wrote: On 10/09/2024 08.41, Philippe Mathieu-Daudé wrote: line 16, in tesseract_available (stdout, stderr, ret) = run_cmd([ 'tesseract', '--version'])    File "/home/rth/qemu/src/tests/functional/qemu_test/cmd.py", line 69, in run_cmd subp = subprocess.P

Re: [PATCH] tests/functional: Fix bad usage of has_cmd

2024-09-10 Thread Philippe Mathieu-Daudé
On 10/9/24 09:58, Thomas Huth wrote: has_cmd returns a tuple, not a boolean value. This fixes a crash when e.g. "tesseract" is not available in the test_m68k_nextcube test. Reported-by: Richard Henderson Signed-off-by: Thomas Huth --- tests/functional/qemu_test/cmd.py | 6 +++--- test

Re: check-functional skipUnless failure

2024-09-10 Thread Peter Maydell
On Tue, 10 Sept 2024 at 08:37, Thomas Huth wrote: > > On 10/09/2024 08.41, Philippe Mathieu-Daudé wrote: > > While looking at this, I'm surprised to notice has_cmd() actually > > *runs* the command by calling run_cmd(). I'd have expected it solely > > checks for binary presence and RX perms, avoid

Re: [RFC 2/2] target/riscv: rvv: improve performance of RISC-V vector loads and stores on large amounts of data.

2024-09-10 Thread Paolo Savini
Thanks for the feedback Richard, I'm working on the endianness. Could you please give me more details about the atomicity issues you are referring to? Best wishes Paolo On 7/27/24 08:15, Richard Henderson wrote: On 7/18/24 01:30, Paolo Savini wrote: This patch optimizes the emulation of unit

[PATCH 1/2] target/hexagon: Rename macros.inc -> macros.h.inc

2024-09-10 Thread Philippe Mathieu-Daudé
Since commits 139c1837db ("meson: rename included C source files to .c.inc") and 0979ed017f ("meson: rename .inc.h files to .h.inc"), EMU standard procedure for included header files is to use *.h.inc. Besides, since commit 6a0057aa22 ("docs/devel: make a statement about includes") this is documen

[PATCH 0/2] misc: Rename included template headers using '.inc' suffix

2024-09-10 Thread Philippe Mathieu-Daudé
Follow Coding Style: If you do use template header files they should be named with the ``.c.inc`` or ``.h.inc`` suffix to make it clear they are being included for expansion. Philippe Mathieu-Daudé (2): target/hexagon: Rename macros.inc -> macros.h.inc tests/bench: Rename test_akcipher_

[PATCH 2/2] tests/bench: Rename test_akcipher_keys.inc -> test_akcipher_keys.c.inc

2024-09-10 Thread Philippe Mathieu-Daudé
Since commit 139c1837db ("meson: rename included C source files to .c.inc"), QEMU standard procedure for included C files is to use *.c.inc. Besides, since commit 6a0057aa22 ("docs/devel: make a statement about includes") this is documented in the Coding Style: If you do use template header fil

Re: [PATCH v2 00/17] intel_iommu: Enable stage-1 translation for emulated device

2024-09-10 Thread CLEMENT MATHIEU--DRIF
Hi Zhenzhong, Do you plan to post a v3 for this series? Thanks >cmd On 05/08/2024 08:27, Zhenzhong Duan wrote: > Caution: External email. Do not open attachments or click links, unless this > email comes from a known sender and you know the content is safe. > > > Hi, > > Per Jason Wang's sugge

Re: [RFC RESEND 0/6] hugetlbfs largepage RAS project

2024-09-10 Thread David Hildenbrand
On 10.09.24 12:02, “William Roche wrote: From: William Roche Hi, Apologies for the noise; resending as I missed CC'ing the maintainers of the changed files Hello, This is a Qemu RFC to introduce the possibility to deal with hardware memory errors impacting hugetlbfs memory backed VMs. W

Re: [PATCH for-9.2 v15 00/11] hw/pci: SR-IOV related fixes and improvements

2024-09-10 Thread Michael S. Tsirkin
On Tue, Sep 10, 2024 at 06:33:01PM +0900, Akihiko Odaki wrote: > On 2024/09/10 18:21, Michael S. Tsirkin wrote: > > On Fri, Aug 23, 2024 at 02:00:37PM +0900, Akihiko Odaki wrote: > > > Supersedes: <20240714-rombar-v2-0-af1504ef5...@daynix.com> > > > ("[PATCH v2 0/4] hw/pci: Convert rom_bar into OnO

[PATCH 0/5] license: Fix typos and update deprecated SPDX tags

2024-09-10 Thread Philippe Mathieu-Daudé
- Fix a pair of typos - Upgrade the deprecated GPL-2.0+/LGPL-2.0+ SPDX tags to GPL-2.0-only / GPL-2.0-or-later / LGPL-2.0-or-later. Philippe Mathieu-Daudé (5): NSIS: Simplify license description tests/functional: Correct typo in test_netdev_ethtool.py SPDX tag license: Update deprecated S

[PATCH 3/5] license: Update deprecated SPDX tag LGPL-2.0+ to LGPL-2.0-or-later

2024-09-10 Thread Philippe Mathieu-Daudé
The 'LGPL-2.0+' license identifier has been deprecated since license list version 2.0rc2 [1] and replaced by the 'LGPL-2.0-or-later' [2] tag. [1] https://spdx.org/licenses/LGPL-2.0+.html [2] https://spdx.org/licenses/LGPL-2.0-or-later.html Mechanical patch running: $ sed -i -e s/LGPL-2.0+/LGPL

[PATCH 5/5] license: Update deprecated SPDX tag GPL-2.0 to GPL-2.0-only

2024-09-10 Thread Philippe Mathieu-Daudé
The 'GPL-2.0' license identifier has been deprecated since license list version 3.0 [1] and replaced by the 'GPL-2.0-only' tag [2]. [1] https://spdx.org/licenses/GPL-2.0.html [2] https://spdx.org/licenses/GPL-2.0-only.html Mechanical patch running: $ sed -i -e s/GPL-2.0/GPL-2.0-only/ \ $(g

[PATCH 4/5] license: Update deprecated SPDX tag GPL-2.0+ to GPL-2.0-or-later

2024-09-10 Thread Philippe Mathieu-Daudé
The 'GPL-2.0+' license identifier has been deprecated since license list version 2.0rc2 [1] and replaced by the 'GPL-2.0-or-later' [2] tag. [1] https://spdx.org/licenses/GPL-2.0+.html [2] https://spdx.org/licenses/GPL-2.0-or-later.html Mechanical patch running: $ sed -i -e s/GPL-2.0+/GPL-2.0-o

[PATCH 1/5] NSIS: Simplify license description

2024-09-10 Thread Philippe Mathieu-Daudé
Since the "2 | 3+" expression can be simplified as "2+", it is pointless to mention the GPLv3 license. Add the corresponding SPDX identifier to remove all doubt. Signed-off-by: Philippe Mathieu-Daudé --- qemu.nsi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qemu.nsi b/

[PATCH 2/5] tests/functional: Correct typo in test_netdev_ethtool.py SPDX tag

2024-09-10 Thread Philippe Mathieu-Daudé
Cc: Alex Bennée Fixes: 9f95111474 ("tests/avocado: re-factor igb test to avoid timeouts") Signed-off-by: Philippe Mathieu-Daudé --- tests/functional/test_netdev_ethtool.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functional/test_netdev_ethtool.py b/tests/functio

Re: [PATCH 2/5] tests/functional: Correct typo in test_netdev_ethtool.py SPDX tag

2024-09-10 Thread Thomas Huth
On 10/09/2024 13.51, Philippe Mathieu-Daudé wrote: Cc: Alex Bennée Fixes: 9f95111474 ("tests/avocado: re-factor igb test to avoid timeouts") Signed-off-by: Philippe Mathieu-Daudé --- tests/functional/test_netdev_ethtool.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t

Re: [PATCH] arm/kvm: add support for MTE

2024-09-10 Thread Ganapatrao Kulkarni
Hi Peter, On 16-07-2024 09:15 pm, Peter Maydell wrote: In target/arm/cpu.c:arm_cpu_realizefn() there is this code: if (cpu_isar_feature(aa64_mte, cpu)) { /* * The architectural range of GM blocksize is 2-6, however qemu * doesn't support blocksize of 2 (see

Re: [PATCH v2] hw/i386/intel_iommu: Block CFI when necessary

2024-09-10 Thread Michael S. Tsirkin
On Mon, Jul 08, 2024 at 06:08:16PM +0800, Yuke Peng wrote: > According to Intel VT-d specification 5.1.4, CFI must be blocked when > Extended Interrupt Mode is enabled or Compatibility format interrupts > are disabled. > > Signed-off-by: Yuke Peng The rename is fine. The issue with the patch is

Re: [PATCH 1/5] NSIS: Simplify license description

2024-09-10 Thread Thomas Huth
On 10/09/2024 13.51, Philippe Mathieu-Daudé wrote: Since the "2 | 3+" expression can be simplified as "2+", it is pointless to mention the GPLv3 license. Add the corresponding SPDX identifier to remove all doubt. Signed-off-by: Philippe Mathieu-Daudé --- qemu.nsi | 4 +++- 1 file changed, 3

[PATCH v2] memory: notify hypervisor of all eventfds during listener (de)registration

2024-09-10 Thread Ani Sinha
When a new listener for an address space is registered, the hypervisor must be informed of all existing eventfds for that address space by calling eventfd_add() for that listener. Similarly, when a listener is de-registered from an address space, the hypervisor must be informed of all existing even

Re: [PATCH 3/5] license: Update deprecated SPDX tag LGPL-2.0+ to LGPL-2.0-or-later

2024-09-10 Thread Thomas Huth
On 10/09/2024 13.51, Philippe Mathieu-Daudé wrote: The 'LGPL-2.0+' license identifier has been deprecated since license list version 2.0rc2 [1] and replaced by the 'LGPL-2.0-or-later' [2] tag. [1] https://spdx.org/licenses/LGPL-2.0+.html [2] https://spdx.org/licenses/LGPL-2.0-or-later.html Mech

Re: [PATCH 5/5] license: Update deprecated SPDX tag GPL-2.0 to GPL-2.0-only

2024-09-10 Thread Philippe Mathieu-Daudé
On 10/9/24 13:51, Philippe Mathieu-Daudé wrote: The 'GPL-2.0' license identifier has been deprecated since license list version 3.0 [1] and replaced by the 'GPL-2.0-only' tag [2]. [1] https://spdx.org/licenses/GPL-2.0.html [2] https://spdx.org/licenses/GPL-2.0-only.html Mechanical patch running

Re: [PATCH 4/5] license: Update deprecated SPDX tag GPL-2.0+ to GPL-2.0-or-later

2024-09-10 Thread Thomas Huth
On 10/09/2024 13.51, Philippe Mathieu-Daudé wrote: The 'GPL-2.0+' license identifier has been deprecated since license list version 2.0rc2 [1] and replaced by the 'GPL-2.0-or-later' [2] tag. [1] https://spdx.org/licenses/GPL-2.0+.html [2] https://spdx.org/licenses/GPL-2.0-or-later.html Mechanic

Re: [PATCH 5/5] license: Update deprecated SPDX tag GPL-2.0 to GPL-2.0-only

2024-09-10 Thread Thomas Huth
On 10/09/2024 13.51, Philippe Mathieu-Daudé wrote: The 'GPL-2.0' license identifier has been deprecated since license list version 3.0 [1] and replaced by the 'GPL-2.0-only' tag [2]. [1] https://spdx.org/licenses/GPL-2.0.html [2] https://spdx.org/licenses/GPL-2.0-only.html Mechanical patch runn

Re: [PATCH 5/5] license: Update deprecated SPDX tag GPL-2.0 to GPL-2.0-only

2024-09-10 Thread Thomas Huth
On 10/09/2024 14.04, Philippe Mathieu-Daudé wrote: On 10/9/24 13:51, Philippe Mathieu-Daudé wrote: The 'GPL-2.0' license identifier has been deprecated since license list version 3.0 [1] and replaced by the 'GPL-2.0-only' tag [2]. [1] https://spdx.org/licenses/GPL-2.0.html [2] https://spdx.org/

Re: [PATCH 2/2] .gitlab-ci.d/crossbuilds.yml: Force 'make check' single threaded for cross-i686-tci

2024-09-10 Thread Thomas Huth
On 06/09/2024 20.07, Peter Maydell wrote: The cross-i686-tci CI job is persistently flaky with various tests hitting timeouts. One theory for why this is happening is that we're running too many tests in parallel and so sometimes a test gets starved of CPU and isn't able to complete within the t

Re: [PATCH v4 0/5] gdbstub: Add support for MTE in system mode

2024-09-10 Thread Alex Bennée
Gustavo Romero writes: > This patchset makes handle_q_memtag, handle_q_isaddresstagged, and > handle_Q_memtag stubs build for system mode, allowing all GDB > 'memory-tag' subcommands to work with QEMU gdbstub on aarch64 system > mode, resolving: > > https://gitlab.com/qemu-project/qemu/-/issues/6

Re: [PATCH 2/2] .gitlab-ci.d/crossbuilds.yml: Force 'make check' single threaded for cross-i686-tci

2024-09-10 Thread Peter Maydell
On Tue, 10 Sept 2024 at 13:13, Thomas Huth wrote: > > On 06/09/2024 20.07, Peter Maydell wrote: > > The cross-i686-tci CI job is persistently flaky with various tests > > hitting timeouts. One theory for why this is happening is that we're > > running too many tests in parallel and so sometimes a

Re: [PATCH] arm/kvm: add support for MTE

2024-09-10 Thread Peter Maydell
On Tue, 10 Sept 2024 at 12:57, Ganapatrao Kulkarni wrote: > On 16-07-2024 09:15 pm, Peter Maydell wrote: > > Since Cornelia first wrote the patch this is based on, we've > > landed gdbstub support for MTE (so gdb can find out which > > addresses in the memory map have tags and read and write > > t

[PATCH v2 0/5] license: Fix typos and update SPDX tags

2024-09-10 Thread Philippe Mathieu-Daudé
Series fully reviewed (thanks Thomas!) Since v1: . Updated regex to cover all GPL-2.0* cases. - Fix a pair of typos - Upgrade the deprecated GPL-2.0+/LGPL-2.0+ SPDX tags to GPL-2.0-only / GPL-2.0-or-later / LGPL-2.0-or-later. Philippe Mathieu-Daudé (5): NSIS: Simplify license description t

[PATCH v2 1/5] NSIS: Simplify license description

2024-09-10 Thread Philippe Mathieu-Daudé
Since the "2 | 3+" expression can be simplified as "2+", it is pointless to mention the GPLv3 license. Add the corresponding SPDX identifier to remove all doubt. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- qemu.nsi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[PATCH v2 3/5] license: Update deprecated SPDX tag LGPL-2.0+ to LGPL-2.0-or-later

2024-09-10 Thread Philippe Mathieu-Daudé
The 'LGPL-2.0+' license identifier has been deprecated since license list version 2.0rc2 [1] and replaced by the 'LGPL-2.0-or-later' [2] tag. [1] https://spdx.org/licenses/LGPL-2.0+.html [2] https://spdx.org/licenses/LGPL-2.0-or-later.html Mechanical patch running: $ sed -i -e s/LGPL-2.0+/LGPL

[PATCH v2 2/5] tests/functional: Correct typo in test_netdev_ethtool.py SPDX tag

2024-09-10 Thread Philippe Mathieu-Daudé
Cc: Alex Bennée Fixes: 9f95111474 ("tests/avocado: re-factor igb test to avoid timeouts") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- tests/functional/test_netdev_ethtool.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functional/test_netdev_e

[PATCH v2 5/5] license: Update deprecated SPDX tag GPL-2.0 to GPL-2.0-only

2024-09-10 Thread Philippe Mathieu-Daudé
The 'GPL-2.0' license identifier has been deprecated since license list version 3.0 [1] and replaced by the 'GPL-2.0-only' tag [2]. [1] https://spdx.org/licenses/GPL-2.0.html [2] https://spdx.org/licenses/GPL-2.0-only.html Mechanical patch running: $ sed -i -e s/GPL-2.0/GPL-2.0-only/ \ $(g

Re: [PATCH v2 12/29] target/arm: Convert FMOVI (scalar, immediate) to decodetree

2024-09-10 Thread Peter Maydell
On Mon, 9 Sept 2024 at 23:24, Philippe Mathieu-Daudé wrote: > > On 9/9/24 18:22, Richard Henderson wrote: > > Reviewed-by: Peter Maydell > > I wonder, maybe you mispasted my previous R-b tags > with Peter's? > https://lore.kernel.org/qemu-devel/37096dc8-7827-4a4c-a27b-4f8343aa9...@linaro.org/ I

[PATCH v2 4/5] license: Update deprecated SPDX tag GPL-2.0+ to GPL-2.0-or-later

2024-09-10 Thread Philippe Mathieu-Daudé
The 'GPL-2.0+' license identifier has been deprecated since license list version 2.0rc2 [1] and replaced by the 'GPL-2.0-or-later' [2] tag. [1] https://spdx.org/licenses/GPL-2.0+.html [2] https://spdx.org/licenses/GPL-2.0-or-later.html Mechanical patch running: $ sed -i -e s/GPL-2.0+/GPL-2.0-o

[PATCH v10 6/9] meson.build: add HAVE_GLIB_WITH_ALIGNED_ALLOC flag

2024-09-10 Thread Manos Pitsidianakis
Rust crates, introduced from the next commit onwards, can optionally use the glib allocator API and need to know whether g_aligned_alloc etc are available. This commit adds a define in config_host_data that depends on glib version >= 2.72. Reviewed-by: Alex Bennée Signed-off-by: Manos Pitsidiana

[PATCH v10 0/9] Add Rust build support, ARM PL011 device impl

2024-09-10 Thread Manos Pitsidianakis
WARNING: This series contains a patch with blob diffs and thus problems may arise with your patch workflow. The revision is available at https://gitlab.com/epilys/qemu/-/tree/rust-v10 for you to fetch. rust-v10 head: 29f226178b5af97612cc8d1c8401959c6f41f027 Hello everyone, This series adds: - b

[RFC PATCH V2 5/5] hw/loongarch: Add KVM pch msi device support

2024-09-10 Thread Xianglai Li
Added pch_msi interrupt controller handling during kernel emulation of irq chip. Signed-off-by: Xianglai Li --- Cc: Paolo Bonzini Cc: Song Gao Cc: Jiaxun Yang Cc: Huacai Chen Cc: "Michael S. Tsirkin" Cc: Cornelia Huck Cc: k...@vger.kernel.org Cc: Bibo Mao Cc: Xianglai Li hw/intc/loongar

[PATCH v10 2/9] build-sys: Add rust feature option

2024-09-10 Thread Manos Pitsidianakis
Add rust feature in meson.build, configure, to prepare for adding Rust code in the followup commits. Signed-off-by: Manos Pitsidianakis Reviewed-by: Alex Bennée --- MAINTAINERS | 5 + meson.build | 22 +- Kconfig

[PATCH v10 8/9] rust: add utility procedural macro crate

2024-09-10 Thread Manos Pitsidianakis
This commit adds a helper crate library, qemu-api-macros for derive (and other procedural) macros to be used along qemu-api. It needs to be a separate library because in Rust, procedural macros, or macros that can generate arbitrary code, need to be special separate compilation units. Only one ma

[PATCH v10 4/9] rust: add bindgen step as a meson dependency

2024-09-10 Thread Manos Pitsidianakis
Add bindings_rs target for generating rust bindings to target-independent qemu C APIs. The bindings need be created before any rust crate that uses them is compiled. The bindings.rs file will end up in BUILDDIR/bindings.rs and have the same name as a target: ninja bindings.rs Signed-off-by: P

[PATCH v10 9/9] rust: add PL011 device model

2024-09-10 Thread Manos Pitsidianakis
This commit adds a re-implementation of hw/char/pl011.c in Rust. How to build: 1. Configure a QEMU build with: --enable-system --target-list=aarch64-softmmu --enable-rust 2. Launching a VM with qemu-system-aarch64 should use the Rust version of the pl011 device Co-authored-by: Junjie Mao

[RFC PATCH V2 2/5] hw/loongarch: Add KVM IPI device support

2024-09-10 Thread Xianglai Li
Added ipi interrupt controller for kvm emulation. The main process is to send the command word for creating an ipi device to the kernel. When the VM is saved, the ioctl obtains the ipi interrupt controller data in the kernel and saves it. When the VM is recovered, the saved data is sent to the kern

[PULL 01/22] meson: Split --enable-sanitizers to --enable-{asan, ubsan}

2024-09-10 Thread Thomas Huth
From: Richard Henderson We do not always want both address and undefined behavior sanitizers running at the same time. For the gitlab custom-runners, drop to only --enable-ubsan. These jobs are not run by default, but as will be obvious in the next patch, we don't run ASan on x86 either, and it

[PATCH v10 7/9] rust: add crate to expose bindings and interfaces

2024-09-10 Thread Manos Pitsidianakis
Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and provides some declaration macros for symbols visible to the rest of QEMU. Co-authored-by: Junjie Mao Co-authored-by: Paolo Bonzini Signed-off-by: Junjie Mao Signed-off-by: Paolo Bonzini Signed-off-by: Manos Pitsidianakis

[RFC PATCH V2 4/5] hw/loongarch: Add KVM pch pic device support

2024-09-10 Thread Xianglai Li
Added pch_pic interrupt controller for kvm emulation. The main process is to send the command word for creating an pch_pic device to the kernel, Delivers the pch pic interrupt controller configuration register base address to the kernel. When the VM is saved, the ioctl obtains the pch_pic interrupt

[PATCH v10 3/9] configure, meson: detect Rust toolchain

2024-09-10 Thread Manos Pitsidianakis
From: Paolo Bonzini Include the correct path and arguments to rustc in the native and cross files (native compilation is needed for procedural macros). Based on the host architecture and OS, the compiler and optionally the argument to --cpu, the Rust target triple can be detected automatically f

[PULL 19/22] tests/functional: Convert the m68k MCF5208EVB Avocado test

2024-09-10 Thread Thomas Huth
We've got to do_test_advcal_2018() here now that the test resides in a separate file. Also switch back to the original URL (since the site did not vanish as originally expected) and update the hashsum to use SHA256. Message-ID: <20240906180549.792832-14-th...@redhat.com> Tested-by: Philippe Mathie

[RFC PATCH V2 3/5] hw/loongarch: Add KVM extioi device support

2024-09-10 Thread Xianglai Li
Added extioi interrupt controller for kvm emulation. The main process is to send the command word for creating an extioi device to the kernel. When the VM is saved, the ioctl obtains the related data of the extioi interrupt controller in the kernel and saves it. When the VM is recovered, the saved

[RFC PATCH V2 1/5] include: Add macro definitions needed for interrupt controller kvm emulation

2024-09-10 Thread Xianglai Li
Add macro definitions needed for interrupt controller kvm emulation. Signed-off-by: Xianglai Li --- Cc: Paolo Bonzini Cc: Song Gao Cc: Jiaxun Yang Cc: Huacai Chen Cc: "Michael S. Tsirkin" Cc: Cornelia Huck Cc: k...@vger.kernel.org Cc: Bibo Mao Cc: Xianglai Li include/hw/intc/loongarch_e

[PULL 02/22] meson: Move -fsanitize=undefined into normal configuraton

2024-09-10 Thread Thomas Huth
From: Richard Henderson With 8e466dd09246 and 23ef50ae2d0c, we disable function pointer sanitization in CI because the qemu code base does not support it. We must disable this for normal usage of --enable-ubsan as well, so move it there. Append options rather than prepend, since all of this requ

[PATCH v10 5/9] .gitattributes: add Rust diff and merge attributes

2024-09-10 Thread Manos Pitsidianakis
Set rust source code to diff=rust (built-in with new git versions) and merge=binary for Cargo.lock files (they should not be merged but auto-generated by cargo) Reviewed-by: Alex Bennée Reviewed-by: Zhao Liu Signed-off-by: Manos Pitsidianakis --- .gitattributes | 3 +++ 1 file changed, 3 inser

[PULL 00/22] Tests and misc patches

2024-09-10 Thread Thomas Huth
The following changes since commit 7bbadc60b58b742494555f06cd342311ddab9351: Merge tag 'crypto-fixes-pull-request' of https://gitlab.com/berrange/qemu into staging (2024-09-09 15:19:32 +0100) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2024-09

[PULL 16/22] tests/functional: Convert Aarch64 Raspi3 avocado tests

2024-09-10 Thread Thomas Huth
From: Philippe Mathieu-Daudé Straight forward conversion. Update the SHA1 hashes to SHA256 hashes since SHA1 should not be used anymore nowadays. Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240826221058.75126-4-phi...@linaro.org> [thuth: Use the LinuxKernelTest class] Message-ID: <2024

[PULL 06/22] MAINTAINERS: Remove myself from the Meson section

2024-09-10 Thread Thomas Huth
The Meson section has plenty of reviewers, and in order to reduce the load on my Inbox a little bit, I'm stepping back as a reviewer here. Message-ID: <20240906155900.742157-1-th...@redhat.com> Signed-off-by: Thomas Huth --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAIN

[PULL 13/22] tests/functional: Convert nanomips Malta avocado tests

2024-09-10 Thread Thomas Huth
From: Philippe Mathieu-Daudé Straight forward conversion. Update the SHA1 hashes to SHA256 hashes since SHA1 should not be used anymore nowadays. $ QEMU_TEST_ALLOW_UNTRUSTED_CODE=1 \ make check-functional-mipsel ... ▶ 4/4 test_mipsel_malta.MaltaMachineConsole.test_mips_malta32el_n

[PULL 07/22] tests/functional: Add the LinuxKernelTest for testing the Linux boot process

2024-09-10 Thread Thomas Huth
Copy the LinuxKernelTest from tests/acceptance/boot_linux_console.py to be able to convert the related tests to the functional test framework in the following patches. Message-ID: <20240906180549.792832-2-th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests

  1   2   3   4   5   >