Re: [PULL 01/28] hw/intc/loongson_ipi: Rename LoongsonIPI -> LoongsonIPIState

2024-08-07 Thread maobibo
Philippe, I checkout the latest code, it works well. Thanks for your efforts. Regards Bibo Mao On 2024/8/6 下午8:51, Philippe Mathieu-Daudé wrote: From: Bibo Mao We'll have to add LoongsonIPIClass in few commits, so rename LoongsonIPI as LoongsonIPIState for clarity. Signed-off-by: Bibo Mao

Re: [PATCH v5 4/7] acpi/ghes: Support GPIO error source

2024-08-07 Thread Mauro Carvalho Chehab
Em Tue, 6 Aug 2024 11:32:19 +0200 Igor Mammedov escreveu: > > @@ -327,6 +330,9 @@ static void build_ghes_v2(GArray *table_data, int > > source_id, BIOSLinker *linker) > > */ > > build_ghes_hw_error_notification(table_data, ACPI_GHES_NOTIFY_SEA); > > break; > > +ca

Re: [PULL 01/28] hw/intc/loongson_ipi: Rename LoongsonIPI -> LoongsonIPIState

2024-08-07 Thread Philippe Mathieu-Daudé
On 7/8/24 09:14, maobibo wrote: Philippe, I checkout the latest code, it works well. Thanks for your efforts. Thanks! It took quite some time, but in the end I believe the commit will be easier to review / bisect in case of problem. Regards Bibo Mao

Re: [RFC PATCH-for-9.1? 1/2] target/arm: Move qmp_query_gic_capabilities() to hw/intc/

2024-08-07 Thread Philippe Mathieu-Daudé
On 7/8/24 07:12, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: qmp_query_gic_capabilities() is not specific to the ARM architecture but to the GIC device which is modelled in hw/intc/, so move the code there for clarity. No logical change intended. Signed-off-by: Philippe Mathieu-Da

Re: [PATCH] target/riscv: Add a property to set vl to ceil(AVL/2)

2024-08-07 Thread Jason Chien
ping Jason Chien 於 2024年7月23日 週二 上午1:50寫道: > RVV spec allows implementations to set vl with values within > [ceil(AVL/2),VLMAX] when VLMAX < AVL < 2*VLMAX. This commit adds a > property "rvv_vl_half_avl" to enable setting vl = ceil(AVL/2). This > behavior helps identify compiler issues and bugs.

Re: [RFC PATCH-for-9.1? 1/2] target/arm: Move qmp_query_gic_capabilities() to hw/intc/

2024-08-07 Thread Philippe Mathieu-Daudé
On 7/8/24 05:46, Richard Henderson wrote: On 8/7/24 00:19, Philippe Mathieu-Daudé wrote: qmp_query_gic_capabilities() is not specific to the ARM architecture but to the GIC device which is modelled in hw/intc/, so move the code there for clarity. But the GIC is certainly arm architecture speci

Re: [PATCH 3/5] ebpf: add formal error reporting to all APIs

2024-08-07 Thread Philippe Mathieu-Daudé
On 6/8/24 17:20, Daniel P. Berrangé wrote: On Tue, Aug 06, 2024 at 05:11:55PM +0200, Philippe Mathieu-Daudé wrote: On 6/8/24 16:56, Daniel P. Berrangé wrote: The eBPF code is currently reporting error messages through trace events. Trace events are fine for debugging, but they are not to be con

Re: [PATCH 3/5] ebpf: add formal error reporting to all APIs

2024-08-07 Thread Philippe Mathieu-Daudé
On 7/8/24 09:37, Philippe Mathieu-Daudé wrote: On 6/8/24 17:20, Daniel P. Berrangé wrote: On Tue, Aug 06, 2024 at 05:11:55PM +0200, Philippe Mathieu-Daudé wrote: On 6/8/24 16:56, Daniel P. Berrangé wrote: The eBPF code is currently reporting error messages through trace events. Trace events ar

Re: [PATCH v2 13/13] target/riscv: Enable PMU related extensions to preferred rule

2024-08-07 Thread Atish Kumar Patra
On Tue, Aug 6, 2024 at 7:01 PM Alistair Francis wrote: > > On Wed, Aug 7, 2024 at 2:06 AM Daniel Henrique Barboza > wrote: > > > > > > > > On 8/6/24 5:46 AM, Andrew Jones wrote: > > > On Tue, Jul 23, 2024 at 04:30:10PM GMT, Atish Patra wrote: > > >> Counter delegation/configuration extension requ

Re: [PATCH v2 12/13] target/riscv: Add a preferred ISA extension rule

2024-08-07 Thread Atish Kumar Patra
On Mon, Aug 5, 2024 at 6:48 PM Alistair Francis wrote: > > On Wed, Jul 24, 2024 at 9:32 AM Atish Patra wrote: > > > > In addition to the implied rule, a preferred rule will be useful > > where an ISA extension may require a list of ISA extension to be > > enabled to use all the features defined i

Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-07 Thread Mauro Carvalho Chehab
Em Tue, 6 Aug 2024 16:31:13 +0200 Igor Mammedov escreveu: > PS: > looking at the code, ACPI_GHES_MAX_RAW_DATA_LENGTH is 1K > and it is the total size of a error block for a error source. > > However acpi_hest_ghes.rst (3) says it should be 4K, > am I mistaken? Maybe Jonathan knows better, but I

Re: [PATCH v2 07/13] target/riscv: Add counter delegation/configuration support

2024-08-07 Thread Atish Kumar Patra
On Mon, Aug 5, 2024 at 6:21 PM Alistair Francis wrote: > > On Wed, Jul 24, 2024 at 9:32 AM Atish Patra wrote: > > > > From: Kaiwen Xue > > > > The Smcdeleg/Ssccfg adds the support for counter delegation via > > S*indcsr and Ssccfg. > > > > It also adds a new shadow CSR scountinhibit and menvcfg

Re: [PATCH v2 04/13] target/riscv: Support generic CSR indirect access

2024-08-07 Thread Atish Kumar Patra
On Mon, Aug 5, 2024 at 5:15 PM Alistair Francis wrote: > > On Wed, Jul 24, 2024 at 9:32 AM Atish Patra wrote: > > > > From: Kaiwen Xue > > > > This adds the indirect access registers required by sscsrind/smcsrind > > and the operations on them. Note that xiselect and xireg are used for > > both

Re: [PATCH v2 01/13] target/riscv: Add properties for Indirect CSR Access extension

2024-08-07 Thread Atish Kumar Patra
On Wed, Jul 31, 2024 at 2:24 AM Alistair Francis wrote: > > On Sat, Jul 27, 2024 at 11:33 AM Atish Kumar Patra > wrote: > > > > On Fri, Jul 26, 2024 at 12:42 AM Alistair Francis > > wrote: > > > > > > On Wed, Jul 24, 2024 at 9:31 AM Atish Patra wrote: > > > > > > > > From: Kaiwen Xue > > > >

Re: [PATCH v2 03/13] target/riscv: Enable S*stateen bits for AIA

2024-08-07 Thread Atish Kumar Patra
On Mon, Aug 5, 2024 at 5:12 PM Alistair Francis wrote: > > On Wed, Jul 24, 2024 at 9:31 AM Atish Patra wrote: > > > > As per the ratified AIA spec v1.0, three stateen bits control AIA CSR > > access. > > > > Bit 60 controls the indirect CSRs > > Bit 59 controls the most AIA CSR state > > Bit 58 c

Re: [RFC PATCH-for-9.1? 1/2] target/arm: Move qmp_query_gic_capabilities() to hw/intc/

2024-08-07 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 7/8/24 07:12, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> qmp_query_gic_capabilities() is not specific to the ARM >>> architecture but to the GIC device which is modelled in >>> hw/intc/, so move the code there for clarity. No logical >>

[PATCH v1 2/3] target/i386: Add VMX control bits for nested FRED support

2024-08-07 Thread Xin Li (Intel)
Add definitions of 1) VM-exit activate secondary controls bit 2) VM-entry load FRED bit which are required to enable nested FRED. Reviewed-by: Zhao Liu Signed-off-by: Xin Li (Intel) --- target/i386/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu

[PATCH v1 1/3] target/i386: Delete duplicated macro definition CR4_FRED_MASK

2024-08-07 Thread Xin Li (Intel)
Macro CR4_FRED_MASK is defined twice, delete one. Signed-off-by: Xin Li (Intel) --- target/i386/cpu.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index c6cc035df3..118ef9cb68 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -267,12 +267

Re: [RFC PATCH-for-9.1? 2/2] hw/intc/arm_gic: Only provide query-gic-capabilities when GIC built-in

2024-08-07 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > When configuring QEMU with --without-default-devices and > not including machines using a GIC, the GIC model is not > built in but the 'query-gic-capabilities' command still > returns false hopes about GIC: > > {"execute": "query-gic-capabilities"} > {"return"

[PATCH v1 3/3] target/i386: Raise the highest index value used for any VMCS encoding

2024-08-07 Thread Xin Li (Intel)
From: Lei Wang Because the index value of the VMCS field encoding of FRED injected-event data (one of the newly added VMCS fields for FRED transitions), 0x52, is larger than any existing index value, raise the highest index value used for any VMCS encoding to 0x52. Because the index value of the

[PATCH v1 0/3] target/i386: Add nested FRED support

2024-08-07 Thread Xin Li (Intel)
This patch set adds nested FRED support to allow KVM to run a nested guest with FRED enabled. Lei Wang (1): target/i386: Raise the highest index value used for any VMCS encoding Xin Li (Intel) (2): target/i386: Delete duplicated macro definition CR4_FRED_MASK target/i386: Add VMX control b

[PATCH 1/3] linux-user: Display sockaddr buffer as pointer

2024-08-07 Thread Philippe Mathieu-Daudé
Rather than 'raw param', display as pointer to get "NULL" instead of "0x". Remove spurious space. Signed-off-by: Philippe Mathieu-Daudé --- linux-user/strace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index b4d10981

[PATCH 0/3] linux-user: Trace sendto/recvfrom

2024-08-07 Thread Philippe Mathieu-Daudé
Strace format added while debugging https://gitlab.com/qemu-project/qemu/-/issues/2485 Philippe Mathieu-Daudé (3): linux-user: Display sockaddr buffer as pointer linux-user: Add strace for sendto() linux-user: Add strace for recvfrom() linux-user/strace.c| 38 ++

[PATCH 2/3] linux-user: Add strace for sendto()

2024-08-07 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- linux-user/strace.c| 15 +++ linux-user/strace.list | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 7064afb486..f55b62f0c9 100644 --- a/linux-user/strace.c +++ b/linux

[PATCH 3/3] linux-user: Add strace for recvfrom()

2024-08-07 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- RFC: Not sure about get_user_ualx() use here --- linux-user/strace.c| 19 +++ linux-user/strace.list | 2 +- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index f55b62f0c9..f0

Re: [PATCH for-9.2 v6 02/12] hw/riscv: add riscv-iommu-bits.h

2024-08-07 Thread Jason Chien
On 2024/8/1 下午 11:43, Daniel Henrique Barboza wrote: From: Tomasz Jeznach This header will be used by the RISC-V IOMMU emulation to be added in the next patch. Due to its size it's being sent in separate for an easier review. One thing to notice is that this header can be replaced by the fut

Re: [PATCH v2] hw/ppc: Implement -dtb support for PowerNV

2024-08-07 Thread Aditya Gupta
Hi Cedric, Sorry for the late reply. On 01/08/24 15:22, Cédric Le Goater wrote: On 8/1/24 10:51, Aditya Gupta wrote: Currently any device tree passed with -dtb option in QEMU, was ignored by the PowerNV code. Read and pass the passed -dtb to the kernel, thus enabling easier debugging with cu

Re: [PATCH v2] scripts/checkpatch: more checks on files imported from Linux

2024-08-07 Thread Alex Bennée
Stefano Garzarella writes: > If a file imported from Linux is touched, emit a warning and suggest > using scripts/update-linux-headers.sh. > > Also check that updating imported files from Linux are not mixed with > other changes, in which case emit an error. > > Signed-off-by: Stefano Garzarella

Re: [RFC PATCH-for-9.1? 2/2] hw/intc/arm_gic: Only provide query-gic-capabilities when GIC built-in

2024-08-07 Thread Philippe Mathieu-Daudé
On 7/8/24 10:18, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: When configuring QEMU with --without-default-devices and not including machines using a GIC, the GIC model is not built in but the 'query-gic-capabilities' command still returns false hopes about GIC: {"execute": "que

Re: [PATCH 3/5] ebpf: add formal error reporting to all APIs

2024-08-07 Thread Daniel P . Berrangé
On Wed, Aug 07, 2024 at 09:37:00AM +0200, Philippe Mathieu-Daudé wrote: > On 6/8/24 17:20, Daniel P. Berrangé wrote: > > On Tue, Aug 06, 2024 at 05:11:55PM +0200, Philippe Mathieu-Daudé wrote: > > > On 6/8/24 16:56, Daniel P. Berrangé wrote: > > > > The eBPF code is currently reporting error messag

[RFC PATCH] qapi: Generate QAPI files using qapi/ for generated header paths

2024-08-07 Thread Philippe Mathieu-Daudé
QAPI script generates headers under the qapi/ directory, so use this prefix in generated header paths, keeping all QAPI under the qapi/ namespace. Signed-off-by: Philippe Mathieu-Daudé --- Ideally I'd also remove "CPPFLAGS+=-I qapi" in this patch but I couldn't figure out where meson adds it... -

Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-07 Thread Jonathan Cameron via
On Wed, 7 Aug 2024 09:47:50 +0200 Mauro Carvalho Chehab wrote: > Em Tue, 6 Aug 2024 16:31:13 +0200 > Igor Mammedov escreveu: > > > PS: > > looking at the code, ACPI_GHES_MAX_RAW_DATA_LENGTH is 1K > > and it is the total size of a error block for a error source. > > > > However acpi_hest_ghes.r

Re: [RFC PATCH] qapi: Generate QAPI files using qapi/ for generated header paths

2024-08-07 Thread Daniel P . Berrangé
On Wed, Aug 07, 2024 at 11:34:06AM +0200, Philippe Mathieu-Daudé wrote: > QAPI script generates headers under the qapi/ directory, > so use this prefix in generated header paths, keeping > all QAPI under the qapi/ namespace. Err that's not always the case is it ? For the main QMP schema, it gener

Re: [PATCH 8/8] qemu-options: Add the description of smp-cache object

2024-08-07 Thread Zhao Liu
Hi Markus, Just a kindly ping. Hopefully we can continue this discussion when you're free. Regards, Zhao On Fri, Aug 02, 2024 at 03:58:02PM +0800, Zhao Liu wrote: > Date: Fri, 2 Aug 2024 15:58:02 +0800 > From: Zhao Liu > Subject: Re: [PATCH 8/8] qemu-options: Add the description of smp-cache >

Re: [PATCH v2 2/2] qom/object, accel-system: add support to Accel globals

2024-08-07 Thread Daniel Henrique Barboza
On 7/31/24 3:30 AM, Markus Armbruster wrote: I apologize for the delay. Daniel Henrique Barboza writes: We're not honouring KVM options that are provided by any -accel option aside from the first. In this example: qemu-system-riscv64 -accel kvm,riscv-aia=emul (...) \ -accel kvm,riscv

Re: [PATCH RFC V3 00/29] Support of Virtual CPU Hotplug for ARMv8 Arch

2024-08-07 Thread Gavin Shan
Hi Salil, With this series and latest upstream Linux kernel (host), I ran into core dump as below. I'm not sure if it's a known issue or not. # uname -r 6.11.0-rc2-gavin+ # /home/gavin/sandbox/qemu.main/build/qemu-system-aarch64 -accel kvm \ -machine virt,gic-version=host,nvdimm=on -cpu host

Re: [PATCH 1/4] reset: Use ResetType for qemu_devices_reset() and MachineClass->reset()

2024-08-07 Thread Juraj Marcin
On Tue, Aug 6, 2024 at 6:40 PM David Hildenbrand wrote: > > On 06.08.24 18:07, Juraj Marcin wrote: > > Currently, both qemu_devices_reset() and MachineClass->reset() use > > ShutdownCause for the reason of the reset. However, the Resettable > > interface uses ResetState, so ShutdownCause needs to

Re: [RFC PATCH] qapi: Generate QAPI files using qapi/ for generated header paths

2024-08-07 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Aug 07, 2024 at 11:34:06AM +0200, Philippe Mathieu-Daudé wrote: >> QAPI script generates headers under the qapi/ directory, >> so use this prefix in generated header paths, keeping >> all QAPI under the qapi/ namespace. > > Err that's not always the case is it

Re: [PATCH 1/3] linux-user: Display sockaddr buffer as pointer

2024-08-07 Thread Richard Henderson
On 8/7/24 18:35, Philippe Mathieu-Daudé wrote: Rather than 'raw param', display as pointer to get "NULL" instead of "0x". Remove spurious space. Signed-off-by: Philippe Mathieu-Daudé --- linux-user/strace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richa

Re: [PATCH 2/3] linux-user: Add strace for sendto()

2024-08-07 Thread Richard Henderson
On 8/7/24 18:35, Philippe Mathieu-Daudé wrote: +#ifdef TARGET_NR_sendto +static void +print_sendto(CPUArchState *cpu_env, const struct syscallname *name, + abi_long arg0, abi_long arg1, abi_long arg2, + abi_long arg3, abi_long arg4, abi_long arg5) +{ +print_syscall_pro

Re: [PATCH 3/3] linux-user: Add strace for recvfrom()

2024-08-07 Thread Richard Henderson
On 8/7/24 18:35, Philippe Mathieu-Daudé wrote: +#ifdef TARGET_NR_recvfrom +static void +print_recvfrom(CPUArchState *cpu_env, const struct syscallname *name, + abi_long arg0, abi_long arg1, abi_long arg2, + abi_long arg3, abi_long arg4, abi_long arg5) +{ +abi_ulong

Re: [PATCH v3 0/2] RISC-V: Add preliminary textra trigger CSR functions

2024-08-07 Thread Alistair Francis
On Wed, Aug 7, 2024 at 3:24 PM Alvin Che-Chia Chang(張哲嘉) wrote: > > Hello Alistair, > > > -Original Message- > > From: Alistair Francis > > Sent: Wednesday, July 24, 2024 10:40 AM > > To: Alvin Che-Chia Chang(張哲嘉) > > Cc: qemu-ri...@nongnu.org; qemu-devel@nongnu.org; > > alistair.fran...

Re: [RFC PATCH] qapi: Generate QAPI files using qapi/ for generated header paths

2024-08-07 Thread Daniel P . Berrangé
On Wed, Aug 07, 2024 at 12:50:26PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Wed, Aug 07, 2024 at 11:34:06AM +0200, Philippe Mathieu-Daudé wrote: > >> QAPI script generates headers under the qapi/ directory, > >> so use this prefix in generated header paths, keeping >

Re: [RFC PATCH-for-9.1? 2/2] hw/intc/arm_gic: Only provide query-gic-capabilities when GIC built-in

2024-08-07 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 7/8/24 10:18, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> When configuring QEMU with --without-default-devices and >>> not including machines using a GIC, the GIC model is not >>> built in but the 'query-gic-capabilities' command still >

Re: [RFC PATCH] qapi: Generate QAPI files using qapi/ for generated header paths

2024-08-07 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Aug 07, 2024 at 12:50:26PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: [...] >> > It is confusing that we have both shared stuff and QMP schema >> > only stuff under the same location. >> >> Which stuff in which location? > > There are mu

Re: [RFC PATCH 04/23] hw/arm: add SVD file for NXP i.MX RT595

2024-08-07 Thread Philippe Mathieu-Daudé
On 6/8/24 22:31, Octavian Purdila wrote: On Tue, Aug 6, 2024 at 7:06 AM Alex Bennée wrote: Octavian Purdila writes: Picked from: https://github.com/nxp-mcuxpresso/mcux-soc-svd/blob/main/MIMXRT595S/MIMXRT595S_cm33.xml NOTE: the file is truncated to keep the email size reasonable. Please us

Re: [RFC PATCH] qapi: Generate QAPI files using qapi/ for generated header paths

2024-08-07 Thread Daniel P . Berrangé
On Wed, Aug 07, 2024 at 01:21:25PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Wed, Aug 07, 2024 at 12:50:26PM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > > [...] > > >> > It is confusing that we have both shared stuff and QMP schema > >> > only

[PATCH 2/6] Makefile: trigger re-configure on updated pythondeps

2024-08-07 Thread Alex Bennée
If we add additional deps for meson we need to ensure we trigger a reconfigure to make sure everything is set up. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20240731140232.22193-1-alex.ben...@linaro.org> --- v2 - split line with

[PATCH 6/6] scripts/checkpatch: more checks on files imported from Linux

2024-08-07 Thread Alex Bennée
From: Stefano Garzarella If a file imported from Linux is touched, emit a warning and suggest using scripts/update-linux-headers.sh. Also check that updating imported files from Linux are not mixed with other changes, in which case emit an error. Signed-off-by: Stefano Garzarella Reviewed-by:

[PATCH 5/6] configure: Fix GDB version detection for GDB_HAS_MTE

2024-08-07 Thread Alex Bennée
From: Gustavo Romero The test gdbstub/test-mte.py requires a GDB version that supports the qIsAddressTagged packet. According to GDB NEWS [0], this packet was first made available in the GDB 15.1 release, not in 15.0, so this commit fixes it in configure. [0] https://www.sourceware.org/gdb/news/

[PATCH 0/6] A few more fixes for 9.1

2024-08-07 Thread Alex Bennée
Nothing major here. We have a tweak to the Makefile to properly trigger re-configure with new python dependencies. A number of tweaks to the GDB version detection for MTE and an update to checkpatch. I'll collect any other misc patches if they are pointed out to me. Alex Bennée (1): Makefile:

[PATCH 1/6] tests/avocado: Re-enable gdbsim-r5f562n8 testing U-Boot

2024-08-07 Thread Alex Bennée
From: Philippe Mathieu-Daudé We disabled all RX tests on commit 9b45cc9931 ("docs/devel: rationalise unstable gitlab tests under FLAKY_TESTS") for being flaky. However I don't recall the U-Boot test to fail (the problematic line checking the 'version' string is already commented out), and I'm run

[PATCH 3/6] configure: Fix arch detection for GDB_HAS_MTE

2024-08-07 Thread Alex Bennée
From: Gustavo Romero GDB_HAS_MTE must only be set if GDB supports the aarch64 arch, so the test if "aarch64" string is present must be against GDB-related '$gdb_arches' variable and not against '$arch' variable. Signed-off-by: Gustavo Romero Message-Id: <20240804161850.2646299-2-gustavo.rom...@

[PATCH 4/6] configure: Avoid use of param. expansion when using gdb_version

2024-08-07 Thread Alex Bennée
From: Gustavo Romero $gdb_version is now used in more than one conditional case and its usage in such cases may increase in the future. Therefore, avoid using shell parameter expansion when using it by setting gdb_version to its final form. Signed-off-by: Gustavo Romero Message-Id: <20240804161

Re: [RFC PATCH] qapi: Generate QAPI files using qapi/ for generated header paths

2024-08-07 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Aug 07, 2024 at 01:21:25PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Wed, Aug 07, 2024 at 12:50:26PM +0200, Markus Armbruster wrote: >> >> Daniel P. Berrangé writes: >> >> [...] >> >> >> > It is confusing that we have both s

Re: [RFC PATCH] qapi: Generate QAPI files using qapi/ for generated header paths

2024-08-07 Thread Philippe Mathieu-Daudé
On 7/8/24 14:01, Markus Armbruster wrote: Daniel P. Berrangé writes: On Wed, Aug 07, 2024 at 01:21:25PM +0200, Markus Armbruster wrote: Daniel P. Berrangé writes: On Wed, Aug 07, 2024 at 12:50:26PM +0200, Markus Armbruster wrote: Daniel P. Berrangé writes: [...] It is confusing that

Re: [PATCH 2/3] linux-user: Add strace for sendto()

2024-08-07 Thread Philippe Mathieu-Daudé
On 7/8/24 12:55, Richard Henderson wrote: On 8/7/24 18:35, Philippe Mathieu-Daudé wrote: +#ifdef TARGET_NR_sendto +static void +print_sendto(CPUArchState *cpu_env, const struct syscallname *name, + abi_long arg0, abi_long arg1, abi_long arg2, + abi_long arg3, abi_long arg

[PATCH v2 0/4] linux-user: Trace sendto/recvfrom

2024-08-07 Thread Philippe Mathieu-Daudé
Since v1: - Add/use print_buf_len (rth) Strace format added while debugging https://gitlab.com/qemu-project/qemu/-/issues/2485 Philippe Mathieu-Daudé (4): linux-user: Display sockaddr buffer as pointer linux-user: Factor print_buf_len() out linux-user: Add strace for sendto() linux-user:

[PATCH v2 4/4] linux-user: Add strace for recvfrom()

2024-08-07 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- linux-user/strace.c| 19 +++ linux-user/strace.list | 2 +- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 98ef26b917..d76907fdc9 100644 --- a/linux-user/strace.c +++ b/l

[PATCH v2 3/4] linux-user: Add strace for sendto()

2024-08-07 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- linux-user/strace.c| 15 +++ linux-user/strace.list | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 210ff86afc..98ef26b917 100644 --- a/linux-user/strace.c +++ b/linux

[PATCH v2 2/4] linux-user: Factor print_buf_len() out

2024-08-07 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- linux-user/strace.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 80f64ff40c..210ff86afc 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -1655,6 +1655,13 @@

[PATCH v2 1/4] linux-user: Display sockaddr buffer as pointer

2024-08-07 Thread Philippe Mathieu-Daudé
Rather than 'raw param', display as pointer to get "NULL" instead of "0x". Remove spurious space. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- linux-user/strace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/strace.c b/li

[PATCH v3 3/5] linux-user: Factor print_buf_len() out

2024-08-07 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- linux-user/strace.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 80f64ff40c..210ff86afc 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -1655,6 +1655,13 @@

[PATCH v3 1/5] linux-user: Correct print_sockaddr() format

2024-08-07 Thread Philippe Mathieu-Daudé
When the %addr argument can not be accessed, a double comma is logged (the final qemu_log call prepend a comma). Call print_raw_param with last=1 to avoid the extra comma. Remove spurious space. Signed-off-by: Philippe Mathieu-Daudé --- linux-user/strace.c | 4 ++-- 1 file changed, 2 insertions(

[PATCH v3 5/5] linux-user: Add strace for recvfrom()

2024-08-07 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- linux-user/strace.c| 19 +++ linux-user/strace.list | 2 +- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 98ef26b917..d76907fdc9 100644 --- a/linux-user/strace.c +++ b/l

[PATCH v3 4/5] linux-user: Add strace for sendto()

2024-08-07 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- linux-user/strace.c| 15 +++ linux-user/strace.list | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 210ff86afc..98ef26b917 100644 --- a/linux-user/strace.c +++ b/linux

[PATCH 1/1] target/i386: Fix arguments for vmsr_read_thread_stat()

2024-08-07 Thread Anthony Harivel
Snapshot of the stat utime and stime for each thread, taken before and after the pause, must be stored in separate locations Signed-off-by: Anthony Harivel --- target/i386/kvm/kvm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/i386/kvm/kvm.c b/target/i386/kv

[PATCH v3 0/5] linux-user: Trace sendto/recvfrom

2024-08-07 Thread Philippe Mathieu-Daudé
Since v2: - Do not squash 2 first patches... Since v1: - Add/use print_buf_len (rth) Strace format added while debugging https://gitlab.com/qemu-project/qemu/-/issues/2485 Philippe Mathieu-Daudé (5): linux-user: Correct print_sockaddr() format linux-user: Display sockaddr buffer as pointer

[PATCH 0/1] Fix energy calcultation in RAPL MSR

2024-08-07 Thread Anthony Harivel
Hi Paolo, The value reported by the calculation was looking very wrong to me. This should fix it for good. Calculated value appears now way more accurate from what is expected from the feature: with "-smp 4": [...] # modprobe intel_rapl_msr.ko intel_rapl_common: Found RAPL domain package inte

[PATCH v3 2/5] linux-user: Display sockaddr buffer as pointer

2024-08-07 Thread Philippe Mathieu-Daudé
Rather than 'raw param', display as pointer to get "NULL" instead of "0x". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- linux-user/strace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 73f

Re: [PATCH] migration: Refine the convergence detection

2024-08-07 Thread Peter Xu
On Wed, Aug 07, 2024 at 02:46:29PM +0800, Yong Huang wrote: > I still think dropping the dirty_rate_high_cnt is a refinement. If migration > has a precise detection of convergence, what do you think of it? Maybe; I don't think I thought through those yet.. If so that'll make sense to be based on

[PATCH] hw/core/ptimer: fix timer zero period condition

2024-08-07 Thread Jianzhou Yue via
The real period is zero when both period and period_frac are zero. Check the method ptimer_set_freq, if freq is larger than 1000 MHz, the period is zero, but the period_frac is not, in this case, the ptimer will work but the current code incorrectly recognizes that the ptimer is disabled. Resolves

[PATCH] virtio/vhost-user: fix qemu crash when hotunplug vhost-user-net device

2024-08-07 Thread yaozhenguo
When hotplug and hotunplug vhost-user-net device quickly. qemu will crash. BT is as below: 0 __pthread_kill_implementation () at /usr/lib64/libc.so.6 1 raise () at /usr/lib64/libc.so.6 2 abort () at /usr/lib64/libc.so.6 3 try_dequeue () at ../util/rcu.c:235 4 call_rcu_thread (opaque=opaque@en

Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-07 Thread Mauro Carvalho Chehab
Em Wed, 7 Aug 2024 10:34:36 +0100 Jonathan Cameron escreveu: > On Wed, 7 Aug 2024 09:47:50 +0200 > Mauro Carvalho Chehab wrote: > > > Em Tue, 6 Aug 2024 16:31:13 +0200 > > Igor Mammedov escreveu: > > > > > PS: > > > looking at the code, ACPI_GHES_MAX_RAW_DATA_LENGTH is 1K > > > and it is th

RE: [PATCH RFC V3 00/29] Support of Virtual CPU Hotplug for ARMv8 Arch

2024-08-07 Thread Salil Mehta via
Hi Gavin, Let me figure out this. Have you also included the below patch along with the architecture agnostic patch-set accepted in this Qemu cycle? https://lore.kernel.org/all/20240801142322.3948866-3-peter.mayd...@linaro.org/ Thanks Salil. > From: Gavin Shan > Sent: Wednesday, August 7, 2

Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-07 Thread Igor Mammedov
On Wed, 7 Aug 2024 10:34:36 +0100 Jonathan Cameron wrote: > On Wed, 7 Aug 2024 09:47:50 +0200 > Mauro Carvalho Chehab wrote: > > > Em Tue, 6 Aug 2024 16:31:13 +0200 > > Igor Mammedov escreveu: > > > > > PS: > > > looking at the code, ACPI_GHES_MAX_RAW_DATA_LENGTH is 1K > > > and it is the t

Re: [PATCH 2/2] qemu-img: CVE-XXX Sanitize untrusted output from NBD server

2024-08-07 Thread Stefan Hajnoczi
On Fri, Aug 02, 2024 at 11:41:35PM +0200, Philippe Mathieu-Daudé wrote: > On 2/8/24 21:26, Eric Blake wrote: > > Error messages from an NBD server must be treated as untrusted; a > > malicious server can inject escape sequences to try and trigger RCE > > flaws via escape sequences to whatever termi

Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-07 Thread Igor Mammedov
On Wed, 7 Aug 2024 15:23:57 +0200 Mauro Carvalho Chehab wrote: > Em Wed, 7 Aug 2024 10:34:36 +0100 > Jonathan Cameron escreveu: > > > On Wed, 7 Aug 2024 09:47:50 +0200 > > Mauro Carvalho Chehab wrote: > > > > > Em Tue, 6 Aug 2024 16:31:13 +0200 > > > Igor Mammedov escreveu: > > > > >

Updated invitation: QEMU/KVM developers conference call @ Every 2 weeks from 14:00 to 15:00 on Tuesday from Tue 6 Aug to Tue 20 Aug (BST) (qemu-devel@nongnu.org)

2024-08-07 Thread Alex Bennée
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VTIMEZONE TZID:America/New_York X-LIC-LOCATION:America/New_York BEGIN:DAYLIGHT TZOFFSETFROM:-0500 TZOFFSETTO:-0400 TZNAME:EDT DTSTART:19700308T02 RRULE:FREQ=YEARLY;BYMONTH=3;BYD

Updated invitation: QEMU/KVM developers conference call @ Every 2 weeks from 14:00 to 15:00 on Tuesday (BST) (qemu-devel@nongnu.org)

2024-08-07 Thread Alex Bennée
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VTIMEZONE TZID:America/New_York X-LIC-LOCATION:America/New_York BEGIN:DAYLIGHT TZOFFSETFROM:-0500 TZOFFSETTO:-0400 TZNAME:EDT DTSTART:19700308T02 RRULE:FREQ=YEARLY;BYMONTH=3;BYD

Re: [PATCH v1 1/3] target/i386: Delete duplicated macro definition CR4_FRED_MASK

2024-08-07 Thread Zhao Liu
On Wed, Aug 07, 2024 at 01:18:10AM -0700, Xin Li (Intel) wrote: > Date: Wed, 7 Aug 2024 01:18:10 -0700 > From: "Xin Li (Intel)" > Subject: [PATCH v1 1/3] target/i386: Delete duplicated macro definition > CR4_FRED_MASK > X-Mailer: git-send-email 2.45.2 > > Macro CR4_FRED_MASK is defined twice, d

Re: [PATCH v5 6/7] acpi/ghes: add support for generic error injection via QAPI

2024-08-07 Thread Jonathan Cameron via
On Tue, 6 Aug 2024 16:31:13 +0200 Igor Mammedov wrote: > On Fri, 2 Aug 2024 23:44:01 +0200 > Mauro Carvalho Chehab wrote: > > > Provide a generic interface for error injection via GHESv2. > > > > This patch is co-authored: > > - original ghes logic to inject a simple ARM record by Shiju J

Re: [PATCH v1 3/3] target/i386: Raise the highest index value used for any VMCS encoding

2024-08-07 Thread Zhao Liu
Hi Xin, On Wed, Aug 07, 2024 at 01:18:12AM -0700, Xin Li (Intel) wrote: > Date: Wed, 7 Aug 2024 01:18:12 -0700 > From: "Xin Li (Intel)" > Subject: [PATCH v1 3/3] target/i386: Raise the highest index value used for > any VMCS encoding > X-Mailer: git-send-email 2.45.2 > > From: Lei Wang > > B

Re: [PATCH v1 2/3] target/i386: Add VMX control bits for nested FRED support

2024-08-07 Thread Zhao Liu
Hi Xin, On Wed, Aug 07, 2024 at 01:18:11AM -0700, Xin Li (Intel) wrote: > Date: Wed, 7 Aug 2024 01:18:11 -0700 > From: "Xin Li (Intel)" > Subject: [PATCH v1 2/3] target/i386: Add VMX control bits for nested FRED > support > X-Mailer: git-send-email 2.45.2 > > Add definitions of > 1) VM-exit

Re: [PATCH] migration: Refine the convergence detection

2024-08-07 Thread Yong Huang
On Wed, Aug 7, 2024 at 8:59 PM Peter Xu wrote: > On Wed, Aug 07, 2024 at 02:46:29PM +0800, Yong Huang wrote: > > I still think dropping the dirty_rate_high_cnt is a refinement. If > migration > > has a precise detection of convergence, what do you think of it? > > Maybe; I don't think I thought t

[RFC PATCH] target/i386: allow access_ptr to force slow path on failed probe

2024-08-07 Thread Alex Bennée
When we are using TCG plugin memory callbacks probe_access_internal will return TLB_MMIO to force the slow path for memory access. This results in probe_access returning NULL but the x86 access_ptr function happily accepts an empty haddr resulting in segfault hilarity. Check for an empty haddr to

RE: [PATCH RFC V3 00/29] Support of Virtual CPU Hotplug for ARMv8 Arch

2024-08-07 Thread Salil Mehta via
Hi Gavin, I tested ARM arch specific patches with the latest Qemu which contains below mentioned fix and I cannot reproduce the crash. I used kernel linux-6.11-rc2 and it booted successfully. Though I did see a kernel crash on attempting to hotplug first vCPU. (qemu) device_add host-arm-cpu,id

Re: [RFC PATCH] target/i386: allow access_ptr to force slow path on failed probe

2024-08-07 Thread Alexandre IOOSS
On 8/7/24 18:02, Alex Bennée wrote: When we are using TCG plugin memory callbacks probe_access_internal will return TLB_MMIO to force the slow path for memory access. This results in probe_access returning NULL but the x86 access_ptr function happily accepts an empty haddr resulting in segfault h

Re: [RFC PATCH-for-9.1? 1/2] target/arm: Move qmp_query_gic_capabilities() to hw/intc/

2024-08-07 Thread Peter Maydell
On Wed, 7 Aug 2024 at 04:46, Richard Henderson wrote: > > On 8/7/24 00:19, Philippe Mathieu-Daudé wrote: > > qmp_query_gic_capabilities() is not specific to the ARM > > architecture but to the GIC device which is modelled in > > hw/intc/, so move the code there for clarity. > > But the GIC is cert

Re: [RFC v3 3/3] vhost: Allocate memory for packed vring

2024-08-07 Thread Eugenio Perez Martin
On Fri, Aug 2, 2024 at 1:22 PM Sahil Siddiq wrote: > > Allocate memory for the packed vq format and support > packed vq in the SVQ "start" and "stop" operations. > > Signed-off-by: Sahil Siddiq > --- > Changes v2 -> v3: > * vhost-shadow-virtqueue.c > (vhost_svq_memory_packed): New function >

Re: [RFC PATCH-for-9.1? 2/2] hw/intc/arm_gic: Only provide query-gic-capabilities when GIC built-in

2024-08-07 Thread Peter Maydell
On Wed, 7 Aug 2024 at 12:10, Markus Armbruster wrote: > Having to manually include a configuration header like CONFIG_DEVICES > wherever you use configuration symbols strikes me as unadvisable when > uses include checking for definedness, such as #ifdef: silent miscompile > when you forget to incl

Re: [RFC PATCH 04/23] hw/arm: add SVD file for NXP i.MX RT595

2024-08-07 Thread Octavian Purdila
On Wed, Aug 7, 2024 at 4:24 AM Philippe Mathieu-Daudé wrote: > > On 6/8/24 22:31, Octavian Purdila wrote: > > On Tue, Aug 6, 2024 at 7:06 AM Alex Bennée wrote: > >> > >> Octavian Purdila writes: > >> > >>> Picked from: > >>> > >>> https://github.com/nxp-mcuxpresso/mcux-soc-svd/blob/main/MIMXRT59

Re: [RFC v3 1/3] vhost: Introduce packed vq and add buffer elements

2024-08-07 Thread Eugenio Perez Martin
On Fri, Aug 2, 2024 at 1:22 PM Sahil Siddiq wrote: > > This is the first patch in a series to add support for packed > virtqueues in vhost_shadow_virtqueue. This patch implements the > insertion of available buffers in the descriptor area. It takes > into account descriptor chains, but does not co

Re: [RFC v3 0/3] Add packed virtqueue to shadow virtqueue

2024-08-07 Thread Eugenio Perez Martin
On Fri, Aug 2, 2024 at 1:22 PM Sahil Siddiq wrote: > > Hi, > > Here's a new patch series that incorporates all > the suggested changes from v2. > > I have tried my best to deduplicate the implementation. > Please let me know if I have missed something. > I think they are in good shape :). > I'll

Re: [PATCH for-9.1] tcg/ppc: Sync tcg_out_test and constraints

2024-08-07 Thread Philippe Mathieu-Daudé
On 7/8/24 06:08, Richard Henderson wrote: Ensure the code structure is the same for matching constraints and emitting code, lest we allow constants that cannot be trivially tested. Cc: qemu-sta...@nongnu.org Fixes: ad788aebbab ("tcg/ppc: Support TCG_COND_TST{EQ,NE}") Resolves: https://gitlab.com

Re: [PATCH 0/2] target/i386: Fix carry flag for BLSI

2024-08-07 Thread Philippe Mathieu-Daudé
On 7/8/24 07:41, Richard Henderson wrote: On 8/1/24 17:58, Richard Henderson wrote: Fix #2175. r~ Richard Henderson (2):    target/i386: Split out gen_prepare_val_nz    target/i386: Fix carry flag for BLSI   target/i386/cpu.h    |  5 +   target/i386/tcg/cc_helper.c

Re: [PATCH v2 7/9] tests/avocado/tuxrun_baselines.py: use Avocado's zstd support

2024-08-07 Thread Cleber Rosa
On Tue, Aug 6, 2024 at 2:20 PM Marcin Juszkiewicz wrote: > > On 6.08.2024 19:31, Cleber Rosa wrote: > > +@skipUnless(archive._probe_zstd_cmd(), > > +'Could not find "zstd", or it is not able to properly ' > > +'decompress decompress the rootfs') > > One "decompr

Re: [PATCH v2 8/9] tests/avocado/machine_aarch64_sbsaref.py: allow for rw usage of image

2024-08-07 Thread Cleber Rosa
On Tue, Aug 6, 2024 at 3:30 PM Philippe Mathieu-Daudé wrote: > > On 6/8/24 19:31, Cleber Rosa wrote: > > When the OpenBSD based tests are run in parallel, the previously > > single instance of the image would become corrupt. Let's give each > > test its own snapshot. > > > > Suggested-by: Alex Be

[PATCH v4 3/7] nbd/server: CVE-2024-7409: Change default max-connections to 100

2024-08-07 Thread Eric Blake
Allowing an unlimited number of clients to any web service is a recipe for a rudimentary denial of service attack: the client merely needs to open lots of sockets without closing them, until qemu no longer has any more fds available to allocate. For qemu-nbd, we default to allowing only 1 connecti

[PATCH v4 5/7] nbd/server: CVE-2024-7409: Close stray client sockets at shutdown

2024-08-07 Thread Eric Blake
A malicious client can attempt to connect to an NBD server, and then intentionally delay progress in the handshake, including if it does not know the TLS secrets. Although this behavior can be bounded by the max-connections parameter, the QMP nbd-server-start currently defaults to unlimited incomi

  1   2   3   >