Sorry for the late reply.
On Wed, Jul 31, 2024 at 4:01 AM Peter Xu wrote:
> On Wed, Jul 24, 2024 at 07:39:29PM +0800, Hyman Huang wrote:
> > Currently, the convergence algorithm determines that the migration
> > cannot converge according to the following principle:
> > The dirty pages generated
On 2024/08/05 15:39, Michael S. Tsirkin wrote:
On Sun, Aug 04, 2024 at 06:01:36PM +0900, Akihiko Odaki wrote:
Supersedes: <20240714-rombar-v2-0-af1504ef5...@daynix.com>
("[PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto")
I submitted a RFC series[1] to add support for SR-IOV emulation to
v
On 2024/08/04 22:08, Peter Xu wrote:
On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki wrote:
On 2024/08/03 1:26, Peter Xu wrote:
On Sat, Aug 03, 2024 at 12:54:51AM +0900, Akihiko Odaki wrote:
I'm not sure if I read it right. Perhaps you meant something more generic
than -platform but s
On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki wrote:
> I suggest disabling all offload features of virtio-net with 9.2.
Yea ... no.
> I want to keep things consistent so I want to disable all at once. This
> change will be very uncomfortable for us, who are implementing offload
> featur
Markus Armbruster writes:
> Sweep the entire documentation again. Last done in commit
> 209e64d9edf (qapi: Refill doc comments to conform to current
> conventions).
>
> To check the generated documentation does not change, I compared the
> generated HTML before and after this commit with "wdiff
On 2024/08/05 16:30, Michael S. Tsirkin wrote:
On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki wrote:
I suggest disabling all offload features of virtio-net with 9.2.
Yea ... no.
I want to keep things consistent so I want to disable all at once. This
change will be very uncomfortable
Josh Junon writes:
> Fixes higher-half address parsing for QMP commands
> `[p]memsave`.
>
> Signed-off-by: Josh Junon
Queued for 9.1. Thanks!
Sweep the entire documentation again. Last done in commit
209e64d9edf (qapi: Refill doc comments to conform to current
conventions).
To check the generated documentation does not change, I compared the
generated HTML before and after this commit with "wdiff -3". Finds no
differences. Comparing
From: Josh Junon
Fixes higher-half address parsing for QMP commands
`[p]memsave`.
Signed-off-by: Josh Junon
Message-ID: <20240802140704.13591-1-ju...@oro.sh>
Reviewed-by: Markus Armbruster
[Subject tweaked, and one PRId64 updated to PRIu64]
Signed-off-by: Markus Armbruster
---
qapi/machine.j
The following changes since commit f9851d2ffef59b3a7f39513469263ab3b019480f:
Merge tag 'migration-20240802-pull-request' of
https://gitlab.com/farosas/qemu into staging (2024-08-03 07:26:26 +1000)
are available in the Git repository at:
https://repo.or.cz/qemu/armbru.git tags/pull-qapi-2024
PowerMac is spelled as PowerMAC (Media Access Control) in some places.
This is misleading.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2297
Signed-off-by: Tejas Vipin
---
docs/system/ppc/powermac.rst | 4 ++--
hw/ppc/mac_newworld.c| 2 +-
hw/ppc/mac_oldworld.c| 2 +-
Add the missing devices 1b36:000c (PCIe root port) and 1b36:000e
(PCIe-to-PCI bridge).
Signed-off-by: George Matsumura
---
docs/specs/pci-ids.rst | 4
1 file changed, 4 insertions(+)
diff --git a/docs/specs/pci-ids.rst b/docs/specs/pci-ids.rst
index c0a3dec2e7..0de13de1e4 100644
--- a/docs
This fixes the markup of the PCI and PCIe Expander Bridge entries to be
consistent with the rest of the file.
Signed-off-by: George Matsumura
---
docs/specs/pci-ids.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/specs/pci-ids.rst b/docs/specs/pci-ids.rst
index 0
On Mon, Aug 05, 2024 at 04:53:52PM +0900, Akihiko Odaki wrote:
> On 2024/08/05 16:30, Michael S. Tsirkin wrote:
> > On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki wrote:
> > > I suggest disabling all offload features of virtio-net with 9.2.
> >
> > Yea ... no.
> >
> > > I want to keep th
Hi Tejas,
On 5/8/24 09:01, Tejas Vipin wrote:
PowerMac is spelled as PowerMAC (Media Access Control) in some places.
This is misleading.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2297
Signed-off-by: Tejas Vipin
---
docs/system/ppc/powermac.rst | 4 ++--
hw/ppc/mac_newworld.c
On Mon, Aug 05, 2024 at 04:10:02PM +0900, Akihiko Odaki wrote:
> On 2024/08/05 15:39, Michael S. Tsirkin wrote:
> > On Sun, Aug 04, 2024 at 06:01:36PM +0900, Akihiko Odaki wrote:
> > > Supersedes: <20240714-rombar-v2-0-af1504ef5...@daynix.com>
> > > ("[PATCH v2 0/4] hw/pci: Convert rom_bar into OnO
On 2024/08/05 17:23, Michael S. Tsirkin wrote:
On Mon, Aug 05, 2024 at 04:53:52PM +0900, Akihiko Odaki wrote:
On 2024/08/05 16:30, Michael S. Tsirkin wrote:
On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki wrote:
I suggest disabling all offload features of virtio-net with 9.2.
Yea ...
On 04.08.24 17:43, Peter Xu wrote:
On Mon, Jul 22, 2024 at 10:59:47AM +0200, David Hildenbrand wrote:
So I wonder whether there's comparison between exec() and transfer mode
that you recently proposed.
I'm asking because exec() (besides all the rest of things that I dislike on
it in this approa
Supersedes: <20240714-rombar-v2-0-af1504ef5...@daynix.com>
("[PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto")
I submitted a RFC series[1] to add support for SR-IOV emulation to
virtio-net-pci. During the development of the series, I fixed some
trivial bugs and made improvements that I think
A PF may automatically create VFs and the PF may be function 0.
Signed-off-by: Akihiko Odaki
---
hw/ppc/spapr_pci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index f63182a03c41..ed4454bbf79e 100644
--- a/hw/ppc/spapr_pci.c
+++
Disabled means it is a disabled SR-IOV VF or it is powered off, and
hidden from the guest.
Signed-off-by: Akihiko Odaki
---
hw/ppc/spapr_pci.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index 7cf9904c3546..f63182a03c41 100644
--- a/hw/ppc/spap
Disable SR-IOV VF devices by reusing code to power down PCI devices
instead of removing them when the guest requests to disable VFs. This
allows to realize devices and report VF realization errors at PF
realization time.
Signed-off-by: Akihiko Odaki
---
include/hw/pci/pci.h| 5 ---
incl
pcie_sriov doesn't have code to restore its state after migration, but
igb, which uses pcie_sriov, naively claimed its migration capability.
Add code to register VFs after migration and fix igb migration.
Fixes: 3a977deebe6b ("Intrdocue igb device emulation")
Signed-off-by: Akihiko Odaki
---
in
pci_new() aborts when creating a VF with a function number equals to or
is greater than PCI_DEVFN_MAX.
Signed-off-by: Akihiko Odaki
---
docs/pcie_sriov.txt | 8 +---
include/hw/pci/pcie_sriov.h | 5 +++--
hw/net/igb.c| 13 ++---
hw/nvme/ctrl.c |
vfio_pci_size_rom() distinguishes whether rombar is explicitly set to 1
by checking dev->opts, bypassing the QOM property infrastructure.
Use -1 as the default value for rombar to tell if the user explicitly
set it to 1. The property is also converted from unsigned to signed.
-1 is signed so it is
The SR-IOV PFs set the multifunction bits during device realization so
check them after that. This forbids adding SR-IOV devices to s390x.
Signed-off-by: Akihiko Odaki
---
hw/s390x/s390-pci-bus.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/hw/s390x/s390-pci
It is no longer used.
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Markus Armbruster
---
include/hw/qdev-core.h | 4
hw/core/qdev.c | 1 -
system/qdev-monitor.c | 12 +++-
3 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/i
On Thu, Jul 18, 2024 at 11:56:33AM -0400, Peter Xu wrote:
> Steve,
>
> On Sun, Jun 30, 2024 at 12:40:23PM -0700, Steve Sistare wrote:
> > What?
>
> Thanks for trying out with the cpr-transfer series. I saw that that series
> missed most of the cc list here, so I'm attaching the link here:
>
> h
A device gets automatically unrealized when being unparented.
Signed-off-by: Akihiko Odaki
---
hw/pci/pcie_sriov.c | 4
1 file changed, 4 deletions(-)
diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sriov.c
index e9b23221d713..499becd5273f 100644
--- a/hw/pci/pcie_sriov.c
+++ b/hw/pci/pcie_
Release VFs failed to realize just as we do in unregister_vfs().
Fixes: 7c0fa8dff811 ("pcie: Add support for Single Root I/O Virtualization
(SR/IOV)")
Signed-off-by: Akihiko Odaki
---
hw/pci/pcie_sriov.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sri
The renamed state will not only represent powering state of PFs, but
also represent SR-IOV VF enablement in the future.
Signed-off-by: Akihiko Odaki
---
include/hw/pci/pci.h| 7 ++-
include/hw/pci/pci_device.h | 2 +-
hw/pci/pci.c| 14 +++---
hw/pci/pci_host
num_vfs is not migrated so use PCI_SRIOV_CTRL_VFE and PCI_SRIOV_NUM_VF
instead.
Signed-off-by: Akihiko Odaki
---
include/hw/pci/pcie_sriov.h | 1 -
hw/pci/pcie_sriov.c | 38 +++---
hw/pci/trace-events | 2 +-
3 files changed, 28 insertions(+), 13
On 05.08.24 11:52, David Hildenbrand wrote:
On 04.08.24 17:43, Peter Xu wrote:
On Mon, Jul 22, 2024 at 10:59:47AM +0200, David Hildenbrand wrote:
So I wonder whether there's comparison between exec() and transfer mode
that you recently proposed.
I'm asking because exec() (besides all the rest
On Mon, Aug 05, 2024 at 06:37:58PM +0900, Akihiko Odaki wrote:
> If cross-migrate=off, QEMU can still migrate on the same host (checkpoint
> and restart). QEMU can also migrate across hosts if the user ensures they
> are on the same platform.
What is so special about checkpoint/restart? I guess we
Am 20.07.2024 um 12:13 hat Amjad Alsharafi geschrieben:
> When reading with `read_cluster` we get the `mapping` with
> `find_mapping_for_cluster` and then we call `open_file` for this
> mapping.
> The issue appear when its the same file, but a second cluster that is
> not immediately after it, imag
On Sun, Aug 04, 2024 at 01:04:20PM GMT, luzhixing12345 wrote:
add a ref link to Memory region description
add extra type(64 bits) to Log description structure fields
fix ’s to 's
---
docs/interop/vhost-user.rst | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
Plea
Am 20.07.2024 um 12:13 hat Amjad Alsharafi geschrieben:
> These patches fix some bugs found when modifying files in vvfat.
> First, there was a bug when writing to the cluster 2 or above of a file, it
> will copy the cluster before it instead, so, when writing to cluster=2, the
> content of cluster
On Sun, Aug 04, 2024 at 10:23:53PM GMT, luzhixing12345 wrote:
rewrite with if-else instead of goto
Why?
IMHO was better before this patch with a single error path.
and I have a question, in two incorrent cases
- need reply but no reply_requested
- no need reply but has reply_requested
sho
Am 30.07.2024 um 11:47 hat Andrey Drobyshev geschrieben:
> Apparently 'qemu-img info' doesn't report the backing file format field
> for qed (as it does for qcow2):
>
> $ qemu-img create -f qed base.qed 1M && qemu-img create -f qed -b base.qed -F
> qed top.qed 1M
> $ qemu-img create -f qcow2 base
When cross compiling QEMU configured with --static, I've been getting
configure errors like the following:
Build-time dependency glib-2.0 found: NO
../target/hexagon/meson.build:303:15: ERROR: Dependency lookup for glib-2.0
with method 'pkgconfig' failed: Could not generate libs for glib
Am 18.07.2024 um 21:46 hat Denis V. Lunev geschrieben:
> On 7/18/24 17:51, Kevin Wolf wrote:
> > Am 16.07.2024 um 16:41 hat Andrey Drobyshev geschrieben:
> > > From: "Denis V. Lunev"
> > >
> > > We have observed that some clusters in the QCOW2 files are zeroed
> > > while preallocation filter is
Hi,
OpenSBI v1.5.1, a bug fix release launched shortly after v1.5, contains
several bug fixes that we ended up missing in our refresh to v1.5 a
couple of weeks ago.
It's a purely bug fix update from what we already have in v1.5, so I
believe we're justified into doing this update during the bug f
A new minor version of OpenSBI was just released after our bump to
OpenSBI 1.5. It contains significant bug fixes that it's worth doing
a new update for QEMU 9.1.
Submodule roms/opensbi 455de672dd..43cace6c36:
> lib: sbi: check result of pmp_get() in is_pmp_entry_mapped()
> lib: sbi: fwft: fix
Am 16.07.2024 um 16:41 hat Andrey Drobyshev geschrieben:
> The testcase simply creates a 64G image with 1M clusters, generates a list
> of 1M aligned offsets and feeds aio_write commands with those offsets to
> qemu-io run with '--aio native --nocache'. Then we check the data
> written at each of
> With normal SIB, index == 4 indicates no index.
> With VSIB, there is no exception for VR4/VR12.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2474
> Signed-off-by: Richard Henderson
Thanks very much, patch queued.
Paolo
On 8/5/24 13:59, Kevin Wolf wrote:
Am 18.07.2024 um 21:46 hat Denis V. Lunev geschrieben:
On 7/18/24 17:51, Kevin Wolf wrote:
Am 16.07.2024 um 16:41 hat Andrey Drobyshev geschrieben:
From: "Denis V. Lunev"
We have observed that some clusters in the QCOW2 files are zeroed
while preallocation
From: Richard Henderson
With normal SIB, index == 4 indicates no index.
With VSIB, there is no exception for VR4/VR12.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2474
Signed-off-by: Richard Henderson
Link:
https://lore.kernel.org/r/20240805003130.1421051-3-richard.hender...@linaro
The following changes since commit c4d242501a61093a8b80ee8f6dd071c5110a100c:
Merge tag 'net-pull-request' of https://github.com/jasowang/qemu into staging
(2024-08-02 15:53:54 +1000)
are available in the Git repository at:
https://gitlab.com/bonzini/qemu.git tags/for-upstream
for you to fe
The vcek-disabled property of the sev-snp-guest object is misspelled
vcek-required (which I suppose would use the opposite polarity) in
the call to object_class_property_add_bool(). Fix it.
Reported-by: Zixi Chen
Reviewed-by: Pankaj Gupta
Signed-off-by: Paolo Bonzini
---
target/i386/sev.c | 2
Am 16.07.2024 um 16:41 hat Andrey Drobyshev geschrieben:
> The script is basically a wrapper around "filefrag" utility. This might
> be used to map virtual offsets within the file to the underlying block
> device offsets. In addition, a chunk size might be specified, in which
> case a list of suc
On Mon, Aug 05, 2024 at 02:22:47PM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > This allows us to include multiple QAPI schemas in the same file.
> >
> > Signed-off-by: Daniel P. Berrangé
>
> I figure you had reason to simultaneously include headers generated for
> multipl
Daniel P. Berrangé writes:
> The "special_features" field / parameter holds the subset of schema
> features that are for internal code use. Specifically 'DEPRECATED'
> and 'UNSTABLE'.
>
> This special casing of internal features is going to be removed, so
> prepare for that by renaming to 'featur
Daniel P. Berrangé writes:
> This updates the QAPI code generation to refer to 'features' instead
> of 'special_features', in preparation for generalizing their exposure.
>
> Signed-off-by: Daniel P. Berrangé
Have you considered squashing this into the previous patch?
[...]
> diff --git a/scr
Daniel P. Berrangé writes:
> This more clearly distinguishes the feature constants from other
> QAPI constants.
>
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Markus Armbruster
Daniel P. Berrangé writes:
> When we shortly expose all feature names to code, it will be valid to
> include a '-', which must be translated to a '_' for the enum constants.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> scripts/qapi/gen.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(
Philippe Mathieu-Daudé writes:
> We disabled all RX tests on commit 9b45cc9931 ("docs/devel:
> rationalise unstable gitlab tests under FLAKY_TESTS") for
> being flaky. However I don't recall the U-Boot test to fail
> (the problematic line checking the 'version' string is already
> commented out),
Daniel P. Berrangé writes:
> This allows us to include multiple QAPI schemas in the same file.
>
> Signed-off-by: Daniel P. Berrangé
I figure you had reason to simultaneously include headers generated for
multiple schemas. Do tell :)
On 5/8/24 08:54, Yoshinori Sato wrote:
On Fri, 02 Aug 2024 02:23:32 +0900,
Philippe Mathieu-Daudé wrote:
We disabled all RX tests on commit 9b45cc9931 ("docs/devel:
rationalise unstable gitlab tests under FLAKY_TESTS") for
being flaky. However I don't recall the U-Boot test to fail
(the problem
On 8/5/24 3:04 PM, Kevin Wolf wrote:
> Am 16.07.2024 um 16:41 hat Andrey Drobyshev geschrieben:
>> The testcase simply creates a 64G image with 1M clusters, generates a list
>> of 1M aligned offsets and feeds aio_write commands with those offsets to
>> qemu-io run with '--aio native --nocache'. Th
Philippe Mathieu-Daudé writes:
> On 5/8/24 08:54, Yoshinori Sato wrote:
>> On Fri, 02 Aug 2024 02:23:32 +0900,
>> Philippe Mathieu-Daudé wrote:
>>>
>>> We disabled all RX tests on commit 9b45cc9931 ("docs/devel:
>>> rationalise unstable gitlab tests under FLAKY_TESTS") for
>>> being flaky. Howeve
On 8/5/24 3:29 PM, Kevin Wolf wrote:
> Am 16.07.2024 um 16:41 hat Andrey Drobyshev geschrieben:
>> The script is basically a wrapper around "filefrag" utility. This might
>> be used to map virtual offsets within the file to the underlying block
>> device offsets. In addition, a chunk size might b
Daniel P. Berrangé writes:
> On Mon, Aug 05, 2024 at 02:22:47PM +0200, Markus Armbruster wrote:
>> Daniel P. Berrangé writes:
>>
>> > This allows us to include multiple QAPI schemas in the same file.
>> >
>> > Signed-off-by: Daniel P. Berrangé
>>
>> I figure you had reason to simultaneously i
Gustavo Romero writes:
> The main goal of this tiny series is to bump from 15.0. to 15.1 the GDB
> version used for setting GDB_HAS_MTE=y to correctly detect GDB versions
> that support all the packets necessary to run the QEMU gdbstub MTE tests
> in user mode, resolving issue 2447 [0].
>
> I too
Queued, thanks.
Paolo
Alyssa Ross writes:
> When cross compiling QEMU configured with --static, I've been getting
> configure errors like the following:
>
> Build-time dependency glib-2.0 found: NO
>
> ../target/hexagon/meson.build:303:15: ERROR: Dependency lookup for
> glib-2.0 with method 'pkgconfig' failed
On Mon, Aug 05, 2024 at 03:11:12PM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Mon, Aug 05, 2024 at 02:22:47PM +0200, Markus Armbruster wrote:
> >> Daniel P. Berrangé writes:
> >>
> >> > This allows us to include multiple QAPI schemas in the same file.
> >> >
> >> > Si
Am 05.08.2024 um 14:56 hat Andrey Drobyshev geschrieben:
> On 8/5/24 3:04 PM, Kevin Wolf wrote:
> > Am 16.07.2024 um 16:41 hat Andrey Drobyshev geschrieben:
> >> The testcase simply creates a 64G image with 1M clusters, generates a list
> >> of 1M aligned offsets and feeds aio_write commands with t
Daniel P. Berrangé writes:
> On Mon, Aug 05, 2024 at 03:11:12PM +0200, Markus Armbruster wrote:
>> Daniel P. Berrangé writes:
>>
>> > On Mon, Aug 05, 2024 at 02:22:47PM +0200, Markus Armbruster wrote:
>> >> Daniel P. Berrangé writes:
>> >>
>> >> > This allows us to include multiple QAPI schem
On 8/5/2024 5:49 AM, Alyssa Ross wrote:
When cross compiling QEMU configured with --static, I've been getting
configure errors like the following:
Build-time dependency glib-2.0 found: NO
../target/hexagon/meson.build:303:15: ERROR: Dependency lookup for
glib-2.0 with method 'pkgco
On Thu, 1 Aug 2024 15:15:44 +0200
Mauro Carvalho Chehab wrote:
> Em Tue, 30 Jul 2024 13:26:20 +0200
> Igor Mammedov escreveu:
>
> > On Tue, 30 Jul 2024 09:29:37 +0100
> > Peter Maydell wrote:
> >
> > > On Tue, 30 Jul 2024 at 08:26, Igor Mammedov wrote:
> > >
> > > >
> > > > On Mon, 22
On 8/5/2024 8:57 AM, Brian Cain wrote:
On 8/5/2024 5:49 AM, Alyssa Ross wrote:
When cross compiling QEMU configured with --static, I've been getting
configure errors like the following:
Build-time dependency glib-2.0 found: NO
../target/hexagon/meson.build:303:15: ERROR: Dependenc
add a ref link to Memory region description, improve type description
add extra type(64 bits) to Log description structure fields
fix ’s to 's
Signed-off-by: luzhixing12345
---
docs/interop/vhost-user.rst | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --
It's not just tests. QAPI-related headers have deteriorated, and pull
in too much. I'll try to clean this up. Thanks!
Em Mon, 5 Aug 2024 16:04:39 +0200
Igor Mammedov escreveu:
> On Thu, 1 Aug 2024 15:15:44 +0200
> Mauro Carvalho Chehab wrote:
>
> > Em Tue, 30 Jul 2024 13:26:20 +0200
> > Igor Mammedov escreveu:
> >
> > > On Tue, 30 Jul 2024 09:29:37 +0100
> > > Peter Maydell wrote:
> > >
> > > > On Tu
Signed-off-by: luzhixing12345
>On Sun, Aug 04, 2024 at 10:23:53PM GMT, luzhixing12345 wrote:
>>rewrite with if-else instead of goto
>
>Why?
>
>IMHO was better before this patch with a single error path.
I think this if-else version is more clear for me, and it's good to
keep things the way they
On Mon, Aug 05, 2024 at 11:27:27PM +0800, luzhixing12345 wrote:
> Signed-off-by: luzhixing12345
>
> >On Sun, Aug 04, 2024 at 10:23:53PM GMT, luzhixing12345 wrote:
> >>rewrite with if-else instead of goto
> >
> >Why?
> >
> >IMHO was better before this patch with a single error path.
>
> I think t
On 05/08/24, Brian Cain wrote:
>
> On 8/5/2024 8:57 AM, Brian Cain wrote:
> >
> > On 8/5/2024 5:49 AM, Alyssa Ross wrote:
> > > When cross compiling QEMU configured with --static, I've been getting
> > > configure errors like the following:
> > >
> > > Build-time dependency glib-2.0 found:
Removes old implemention in the gcrypt hash driver. Will
be replaced with a new implementation in accordance
with the accumulative hashing changes in the patch series.
Signed-off-by: Alejandro Zeise
---
crypto/hash-gcrypt.c | 66 +---
1 file changed, 1 ins
Removes old implemention in the GLib hash driver. Will
be replaced with a new implementation in accordance
with the accumulative hashing changes in the patch series.
Signed-off-by: Alejandro Zeise
---
crypto/hash-glib.c | 53 ++
1 file changed, 2 inser
Implements the new hashing API in the GLib hash driver.
Supports creating/destroying a context, updating the context
with input data and obtaining an output hash.
Signed-off-by: Alejandro Zeise
---
crypto/hash-glib.c | 77 +-
1 file changed, 76 inserti
The goal of this patch series is to fix accumulative hashing support in the
Aspeed HACE module. The issue that stemmed this patch was a failure to boot an
OpenBMC image using the "ast2600-evb" machine. The U-boot
2019.04 loader failed to verify image hashes.
These incorrect image hashes given by
Removes old implemention in the nettle hash driver. Will
be replaced with a new implementation in accordance
with the accumulative hashing changes in the patch series.
Signed-off-by: Alejandro Zeise
---
crypto/hash-nettle.c | 52 +---
1 file changed, 1 ins
Removes old implemention in the gnutls hash driver. Will
be replaced with a new implementation in accordance
with the accumulative hashing changes in the patch series.
Signed-off-by: Alejandro Zeise
---
crypto/hash-gnutls.c | 46 +---
1 file changed, 1 ins
Updates the AFAlg hash driver to support the new accumulative
hashing changes as part of the patch series.
Implements opening/closing of contexts, updating hash data
and finalizing the hash digest.
Signed-off-by: Alejandro Zeise
---
crypto/hash-afalg.c | 154 +---
Implements the new hashing API in the gnutls hash driver.
Supports creating/destroying a context, updating the context
with input data and obtaining an output hash.
Signed-off-by: Alejandro Zeise
---
crypto/hash-gnutls.c | 76
1 file changed, 76 inser
Changes the hash API to support accumulative hashing.
Hash objects are created with "qcrypto_hash_new",
updated with data with "qcrypto_hash_update", and
the hash obtained with "qcrypto_hash_finalize".
These changes bring the hashing API more in line with the
hmac API.
Signed-off-by: Alejandro Ze
Make the Aspeed HACE module use the new qcrypto accumulative hashing functions
when in scatter-gather accumulative mode. A hash context will maintain a
"running-hash" as each scatter-gather chunk is received.
Previously each scatter-gather "chunk" was cached
so the hash could be computed once the
Added an accumulative hashing test. Checks for functionality of
the new hash create, update, finalize and free functions.
Signed-off-by: Alejandro Zeise
---
tests/unit/test-crypto-hash.c | 50 +++
1 file changed, 50 insertions(+)
diff --git a/tests/unit/test-cryp
Implements the new hashing API in the gcrypt hash driver.
Supports creating/destroying a context, updating the context
with input data and obtaining an output hash.
Signed-off-by: Alejandro Zeise
---
crypto/hash-gcrypt.c | 78
1 file changed, 78 inser
Implements the new hashing API in the nettle hash driver.
Supports creating/destroying a context, updating the context
with input data and obtaining an output hash.
Signed-off-by: Alejandro Zeise
---
crypto/hash-nettle.c | 81
1 file changed, 81 inser
Tally icounts for basic blocks. The data is useful for producing
human-readable topblocks reports, and for creating simpoints to guide
accurate & efficient machine simulation runs.
QEMU's The Tiny Code Generator creates TCG blocks in a way that is
expedient for JIT translation but does not conform
On Fri, 2 Aug 2024 23:43:57 +0200
Mauro Carvalho Chehab wrote:
> Adds a Generic Event Device to handle generic hardware error
> events, supporting General Purpose Event (GPE) as specified at
> ACPI 6.5 specification at 18.3.2.7.2:
> https://uefi.org/specs/ACPI/6.5/18_Platform_Error_Interfaces.ht
On Fri, 2 Aug 2024 23:43:58 +0200
Mauro Carvalho Chehab wrote:
Do we need to rename this now there is a GED involved?
Is it even technically a GPIO any more?
Spec says in 18.3.2.7
HW-reduced ACPI platforms signal the error using a GPIO
interrupt or another interrupt declared under
a generic eve
On Fri, 2 Aug 2024 23:43:59 +0200
Mauro Carvalho Chehab wrote:
> From: Jonathan Cameron
>
> Add error notification to GHES v2 using the GPIO source.
The gpio / external interrupt follows through.
>
> [mchehab: do some cleanups at ACPI_HEST_SRC_ID_* checks]
>
> Signed-off-by: Jonathan Camer
On Fri, 2 Aug 2024 23:44:00 +0200
Mauro Carvalho Chehab wrote:
> Creates a QMP command to be used for generic ACPI APEI hardware error
> injection (HEST) via GHESv2.
>
> The actual GHES code will be added at the followup patch.
>
> Signed-off-by: Mauro Carvalho Chehab
Looks good to me.
Review
On Fri, 2 Aug 2024 23:44:01 +0200
Mauro Carvalho Chehab wrote:
> Provide a generic interface for error injection via GHESv2.
>
> This patch is co-authored:
> - original ghes logic to inject a simple ARM record by Shiju Jose;
> - generic logic to handle block addresses by Jonathan Camero
From: Bibo Mao
In preparation to extract common IPI code in few commits,
extract loongson_ipi_common_realize().
Signed-off-by: Bibo Mao
[PMD: Extracted from bigger commit, added commit description]
Co-Developed-by: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Bibo
From: Bibo Mao
We'll have to add LoongsonIPIClass in few commits,
so rename LoongsonIPI as LoongsonIPIState for clarity.
Signed-off-by: Bibo Mao
[PMD: Extracted from bigger commit, added commit description]
Co-Developed-by: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Reviewed
(series fully reviewed, patches 1-15 will be posted
tomorrow in pull request)
Since v5:
- Add missing .class_size / .instance_size to
avoid heap-buffer-ovf
Since v4:
- Fix build failure due to rebase (Song)
- Loongarch -> LoongArch (Song)
- Added Song's tags
Since v3:
- Use DEFINE_TYPES() mac
From: Bibo Mao
Introduce LOONGSON_IPI_COMMON stubs, QDev parent of LOONGSON_IPI.
Signed-off-by: Bibo Mao
[PMD: Extracted from bigger commit, added commit description]
Co-Developed-by: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Bibo Mao
Tested-by: Bibo Mao
Acke
1 - 100 of 216 matches
Mail list logo
