Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-07-31 Thread Xiaoyao Li
On 7/24/2024 6:29 PM, Manish wrote: Thanks Igor On 24/07/24 2:30 pm, Igor Mammedov wrote: !---|    CAUTION: External Email |---! On Wed, 24 Jul 2024 07:52:26 + "

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-31 Thread Daniel P . Berrangé
On Tue, Jul 30, 2024 at 05:32:48PM -0400, Michael S. Tsirkin wrote: > On Tue, Jul 30, 2024 at 04:03:53PM -0400, Peter Xu wrote: > > On Tue, Jul 30, 2024 at 03:22:50PM -0400, Michael S. Tsirkin wrote: > > > This is not what we did historically. Why should we start now? > > > > It's a matter of whet

Re: [PATCH v3 4/7] acpi/ghes: Add a logic to handle block addresses and FW first ARM processor error injection

2024-07-31 Thread Mauro Carvalho Chehab
Em Tue, 30 Jul 2024 13:17:09 +0200 Igor Mammedov escreveu: > On Mon, 22 Jul 2024 08:45:56 +0200 > Mauro Carvalho Chehab wrote: > > that's quite a bit of code that in 99% won't ever be used > (assuming error injection testing scenario), > not to mention it's a hw depended one and governed by dif

Re: [PULL 00/96] ppc-for-9.1-2 queue

2024-07-31 Thread Nicholas Piggin
On Mon Jul 29, 2024 at 7:43 PM AEST, Philippe Mathieu-Daudé wrote: > Hi Nick, > > On 26/7/24 01:52, Nicholas Piggin wrote: > > Apologies this is so late after soft-freeze, apologies. I was waiting > > on "accel/kvm: Extract common KVM vCPU {creation,parking} code" to be > > merged upstream [...] >

Re: [PATCH v6 0/5] Power11 support for QEMU [PSeries]

2024-07-31 Thread Nicholas Piggin
Hey Aditya, Thanks for this, I think since we're past the hard freeze it may have to wait until next release. If it was simply a new PRV maybe it could be squeezed in, but since it has this PCR tangle then it's a bit non-trivial. Apologies I didn't get to reviewing it earlier, will get it in 9.2.

Re: [PATCH v4 6/6] acpi/ghes: Add a logic to inject ARM processor CPER

2024-07-31 Thread Markus Armbruster
Mauro Carvalho Chehab writes: > Em Mon, 29 Jul 2024 17:31:09 +0100 > Jonathan Cameron escreveu: > >> On Mon, 29 Jul 2024 15:21:10 +0200 >> Mauro Carvalho Chehab wrote: > > ... > >> Markus suggested: >> >> > A target-specific command like this one should be conditional. Try >> > this: >> > >>

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-31 Thread Michael S. Tsirkin
On Wed, Jul 31, 2024 at 08:04:24AM +0100, Daniel P. Berrangé wrote: > On Tue, Jul 30, 2024 at 05:32:48PM -0400, Michael S. Tsirkin wrote: > > On Tue, Jul 30, 2024 at 04:03:53PM -0400, Peter Xu wrote: > > > On Tue, Jul 30, 2024 at 03:22:50PM -0400, Michael S. Tsirkin wrote: > > > > This is not what

Re: [PATCH v2 2/2] qom/object, accel-system: add support to Accel globals

2024-07-31 Thread Andrew Jones
On Wed, Jul 31, 2024 at 08:30:46AM GMT, Markus Armbruster wrote: > I apologize for the delay. > > Daniel Henrique Barboza writes: > > > We're not honouring KVM options that are provided by any -accel option > > aside from the first. In this example: > > > > qemu-system-riscv64 -accel kvm,riscv-a

Re: [PATCH v4 2/6] arm/virt: Wire up GPIO error source for ACPI / GHES

2024-07-31 Thread Zhao Liu
On Wed, Jul 31, 2024 at 07:21:58AM +0200, Mauro Carvalho Chehab wrote: [snip] > > The name looks inconsistent with the style of other MachineClass virtual > > methods. What about the name like "notify_xxx"? And pls add the comment > > about this new method. > > > > BTW, I found this method is ca

Re: [PATCH] hvf: arm: Allow creating VMs with > 63GB of RAM on macOS 15+

2024-07-31 Thread Peter Maydell
On Tue, 30 Jul 2024 at 22:53, Danny Canter wrote: > > Thanks Peter! > > For the macOS 13 comment just so I’m clear, you’re saying the minimum we > support is > 13 now so the conditional compilation for those isn’t required anymore as > well? I suppose > that tracks given the wording that we supp

[PATCH v2] hw/acpi/ich9: Add periodic and swsmi timer

2024-07-31 Thread Dominic Prinz
This patch implements the periodic and the swsmi ICH9 chipset timer. They are especially useful when prototyping UEFI firmware (e.g. with EDK2's OVMF) using QEMU. For backwards compatibility, the compat properties "x-smi-swsmi-timer", and "x-smi-periodic-timer" are introduced. Additionally, write

Re: [PATCH] target/arm: Handle denormals correctly for FMOPA (widening)

2024-07-31 Thread Peter Maydell
On Tue, 30 Jul 2024 at 23:36, Richard Henderson wrote: > > On 7/31/24 01:58, Peter Maydell wrote: > > -void HELPER(sme_fmopa_h)(void *vza, void *vzn, void *vzm, void *vpn, > > - void *vpm, void *vst, uint32_t desc) > > +void HELPER(sme_fmopa_h)(CPUARMState *env, > > +

Re: [PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto

2024-07-31 Thread Markus Armbruster
Akihiko Odaki writes: > rom_bar is tristate but was defined as uint32_t so convert it into > OnOffAuto to clarify that. For compatibility, a uint32 value set via > QOM will be converted into OnOffAuto. > > Signed-off-by: Akihiko Odaki I agree making property "rombar" an integer was a design mis

Re: [PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto

2024-07-31 Thread Michael S. Tsirkin
On Wed, Jul 31, 2024 at 10:32:19AM +0200, Markus Armbruster wrote: > Whether it would be worth your trouble and mine just to clean up > "rombar" seems highly dubious, though. Exactly. -- MST

Re: [PATCH] target/hexagon: define a v66 CPU

2024-07-31 Thread Philippe Mathieu-Daudé
On 31/7/24 03:09, Brian Cain wrote: For now, v66 behavior is the same as other CPUs. Signed-off-by: Brian Cain --- target/hexagon/cpu-qom.h | 1 + target/hexagon/cpu.c | 2 ++ 2 files changed, 3 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] target/hexagon: switch to dc set_props() list

2024-07-31 Thread Philippe Mathieu-Daudé
On 31/7/24 03:12, Brian Cain wrote: Define a hexagon_cpu_properties list to match the idiom used by other targets. Signed-off-by: Brian Cain --- target/hexagon/cpu.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 2/2] qom/object, accel-system: add support to Accel globals

2024-07-31 Thread Markus Armbruster
Andrew Jones writes: > On Wed, Jul 31, 2024 at 08:30:46AM GMT, Markus Armbruster wrote: >> I apologize for the delay. >> >> Daniel Henrique Barboza writes: >> >> > We're not honouring KVM options that are provided by any -accel option >> > aside from the first. In this example: >> > >> > qemu-

[PATCH v7 3/5] net/tap: Factorize fd closing after forking

2024-07-31 Thread Clément Léger
The same code is used twice to actually close all open file descriptors after forking. Factorize it in a single place. Signed-off-by: Clément Léger Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- net/tap.c | 27 +-- 1 file changed, 13 insertions(+

[PATCH v7 4/5] qemu/osdep: Add excluded fd parameter to qemu_close_all_open_fd()

2024-07-31 Thread Clément Léger
In order for this function to be usable by tap.c code, add a list of file descriptors that should not be closed. Signed-off-by: Clément Léger --- include/qemu/osdep.h| 8 ++- system/async-teardown.c | 2 +- util/oslib-posix.c | 107 ++-- 3 files c

[PATCH v7 2/5] qemu/osdep: Split qemu_close_all_open_fd() and add fallback

2024-07-31 Thread Clément Léger
In order to make it cleaner, split qemu_close_all_open_fd() logic into multiple subfunctions (close with close_range(), with /proc/self/fd and fallback). Signed-off-by: Clément Léger --- util/oslib-posix.c | 50 ++ 1 file changed, 37 insertions(+), 13

[PATCH v7 0/5] qemu/osdep: add a qemu_close_all_open_fd() helper

2024-07-31 Thread Clément Léger
Since commit 03e471c41d8b ("qemu_init: increase NOFILE soft limit on POSIX"), the maximum number of file descriptors that can be opened are raised to nofile.rlim_max. On recent debian distro, this yield a maximum of 1073741816 file descriptors. Now, when forking to start qemu-bridge-helper, this ac

[PATCH v7 1/5] qemu/osdep: Move close_all_open_fds() to oslib-posix

2024-07-31 Thread Clément Léger
Move close_all_open_fds() in oslib-posix, rename it qemu_close_all_open_fds() and export it. Signed-off-by: Clément Léger Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- include/qemu/osdep.h| 7 +++ system/async-teardown.c | 37 +-

[PATCH v7 5/5] net/tap: Use qemu_close_all_open_fd()

2024-07-31 Thread Clément Léger
Instead of using a slow implementation to close all open fd after forking, use qemu_close_all_open_fd(). Signed-off-by: Clément Léger Reviewed-by: Richard Henderson --- net/tap.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/net/tap.c b/net/tap.c index 7

RE: [PATCH] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark logic

2024-07-31 Thread Salil Mehta via
Hello, A quick check and a gentle reminder, has this patch been accepted? Best regards Salil. > From: Igor Mammedov > Sent: Friday, July 26, 2024 10:34 AM > To: Salil Mehta > > On Thu, 25 Jul 2024 15:51:32 +0100 > Salil Mehta wrote: > > > Loop should exit prematurely on successfully

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-07-31 Thread John Levon
On Wed, Jul 31, 2024 at 03:02:15PM +0800, Xiaoyao Li wrote: > > Windows does not expect 0x1f to be present for any CPU model. But if it > > is exposed to the guest, it expects non-zero values. > > Please fix Windows! A ticket has been filed with MSFT, we are aware this is a guest bug. But that

Re: [PATCH v3 4/7] acpi/ghes: Add a logic to handle block addresses and FW first ARM processor error injection

2024-07-31 Thread Jonathan Cameron via
On Wed, 31 Jul 2024 09:11:33 +0200 Mauro Carvalho Chehab wrote: > Em Tue, 30 Jul 2024 13:17:09 +0200 > Igor Mammedov escreveu: > > > On Mon, 22 Jul 2024 08:45:56 +0200 > > Mauro Carvalho Chehab wrote: > > > > that's quite a bit of code that in 99% won't ever be used > > (assuming error inject

Re: [PATCH v5 0/8] virtio-net: add support for SR-IOV emulation

2024-07-31 Thread Cédric Le Goater
On 7/30/24 19:56, Michael S. Tsirkin wrote: On Tue, Jul 30, 2024 at 09:26:20PM +0900, Akihiko Odaki wrote: On 2024/07/30 20:37, Michael S. Tsirkin wrote: On Mon, Jul 15, 2024 at 02:19:06PM +0900, Akihiko Odaki wrote: Based-on: <20240714-rombar-v2-0-af1504ef5...@daynix.com> ("[PATCH v2 0/4] hw/

Re: [PATCH v2 01/13] target/riscv: Add properties for Indirect CSR Access extension

2024-07-31 Thread Alistair Francis
On Sat, Jul 27, 2024 at 11:33 AM Atish Kumar Patra wrote: > > On Fri, Jul 26, 2024 at 12:42 AM Alistair Francis > wrote: > > > > On Wed, Jul 24, 2024 at 9:31 AM Atish Patra wrote: > > > > > > From: Kaiwen Xue > > > > > > This adds the properties for sxcsrind. Definitions of new registers and >

Re: [PATCH RFC v4 0/7] virtio-net: add support for SR-IOV emulation

2024-07-31 Thread Yui Washizu
On 2024/07/15 14:15, Akihiko Odaki wrote: On 2024/05/16 11:00, Yui Washizu wrote: On 2024/04/28 18:05, Akihiko Odaki wrote: Based-on: <20240315-reuse-v9-0-67aa69af4...@daynix.com> ("[PATCH for 9.1 v9 00/11] hw/pci: SR-IOV related fixes and improvements") Introduction This se

Re: [PATCH] target/riscv: Add asserts for out-of-bound access

2024-07-31 Thread Alistair Francis
On Sat, Jul 27, 2024 at 11:36 AM Atish Kumar Patra wrote: > > On Thu, Jul 25, 2024 at 10:12 PM Alistair Francis > wrote: > > > > On Wed, Jul 24, 2024 at 6:33 PM Atish Patra wrote: > > > > > > Coverity complained about the possible out-of-bounds access with > > > counter_virt/counter_virt_prev b

Re: [PATCH 1/1] target/riscv: Remove redundant insn length check for zama16b

2024-07-31 Thread Alistair Francis
On Thu, Jul 25, 2024 at 11:53 AM LIU Zhiwei wrote: > > > On 2024/7/23 13:59, Richard Henderson wrote: > > On 7/23/24 15:29, LIU Zhiwei wrote: > >> The more detailed information about its meaning is in priviledged > >> 1.13 specification. More exactly, in 3.6.4. Misaligned Atomicity > >> Granule PM

Re: [PATCH 01/18] qapi: Smarter camel_to_upper() to reduce need for 'prefix'

2024-07-31 Thread Kevin Wolf
Am 30.07.2024 um 10:10 hat Markus Armbruster geschrieben: > camel_to_upper() converts its argument from camel case to upper case > with '_' between words. Used for generated enumeration constant > prefixes. > > When some of the words are spelled all caps, where exactly to insert > '_' is guesswor

Re: [PATCH] target/riscv: Add asserts for out-of-bound access

2024-07-31 Thread Peter Maydell
On Sat, 27 Jul 2024 at 02:36, Atish Kumar Patra wrote: > > On Thu, Jul 25, 2024 at 10:12 PM Alistair Francis > wrote: > > > > On Wed, Jul 24, 2024 at 6:33 PM Atish Patra wrote: > > > > > > Coverity complained about the possible out-of-bounds access with > > > counter_virt/counter_virt_prev beca

Re: [PATCH 11/18] qapi/crypto: Rename QCryptoHashAlgorithm to *Algo, and drop prefix

2024-07-31 Thread Daniel P . Berrangé
On Tue, Jul 30, 2024 at 02:26:49PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Tue, Jul 30, 2024 at 10:10:25AM +0200, Markus Armbruster wrote: > >> QAPI's 'prefix' feature can make the connection between enumeration > >> type and its constants less than obvious. It's be

Re: [RFC PATCH v5 0/8] Add Rust support, implement ARM PL011

2024-07-31 Thread Manos Pitsidianakis
On Fri, 26 Jul 2024 12:26, Manos Pitsidianakis wrote: On Fri, 26 Jul 2024 at 11:19, Paolo Bonzini wrote: As I said, I don't see the point in discussing this more, and I'm not going to unless you provide a clear pointer to documentation that states the opposite. Same here. Next patch serie

Re: QEMU unexpectedly closed the monitor

2024-07-31 Thread Alex Bennée
Itaru Kitayama writes: > Hi Alex, > >> On Jul 30, 2024, at 22:25, Alex Bennée wrote: >> >> Itaru Kitayama writes: >> >>> Hi, >>> >>> Executing virt-install with the following options: >>> >>> sudo virt-install --machine=virt --arch=aarch64 --name=test8 --disk >>> path=/var/lib/libvirt/image

Re: [RFC 0/2] Identify aliased maps in vdpa SVQ iova_tree

2024-07-31 Thread Eugenio Perez Martin
On Tue, Jul 30, 2024 at 2:32 PM Jonah Palmer wrote: > > > > On 7/30/24 7:00 AM, Eugenio Perez Martin wrote: > > On Tue, Jul 30, 2024 at 10:48 AM Jason Wang wrote: > >> > >> On Mon, Jul 29, 2024 at 6:05 PM Eugenio Perez Martin > >> wrote: > >>> > >>> On Wed, Jul 24, 2024 at 7:00 PM Jonah Palmer

Re: [PATCH] roms/opensbi: Update to v1.5

2024-07-31 Thread Daniel Henrique Barboza
On 7/29/24 7:31 PM, Heinrich Schuchardt wrote: On 7/15/24 19:15, Daniel Henrique Barboza wrote: Update OpenSBI and the pre-built opensbi32 and opensbi64 images to v1.5. The following commits were included in v1.5: 455de67 include: Bump-up version to 1.5 (...) Signed-off-by: Daniel Henr

[PATCH] target/ppc: Set ctx->opcode for decode_insn32()

2024-07-31 Thread Ilya Leoshkevich
divdu (without a dot) sometimes updates cr0, even though it shouldn't. The reason is that gen_op_arith_divd() checks Rc(ctx->opcode), which is not initialized. This field is initialized only for instructions that go through decode_legacy(), and not decodetree. There already was a similar issue fix

Re: [RFC PATCH 0/6] Enable shared device assignment

2024-07-31 Thread Xu Yilun
On Fri, Jul 26, 2024 at 09:08:51AM +0200, David Hildenbrand wrote: > On 26.07.24 07:02, Tian, Kevin wrote: > > > From: David Hildenbrand > > > Sent: Thursday, July 25, 2024 10:04 PM > > > > > > > Open > > > > > > > > Implementing a RamDiscardManager to notify VFIO of page conversions > > > >

Re: QEMU unexpectedly closed the monitor

2024-07-31 Thread Peter Maydell
On Wed, 31 Jul 2024 at 10:52, Alex Bennée wrote: > You then need to manually strip out all the various chardevs for libvirt > control sockets and you can an equivalent command line you can run from > the console. One thing that did jump out as a bit weird to me was: > > -rtc base=utc -no-shutdown

Re: [PATCH v3 4/7] acpi/ghes: Add a logic to handle block addresses and FW first ARM processor error injection

2024-07-31 Thread Mauro Carvalho Chehab
Em Wed, 31 Jul 2024 09:57:19 +0100 Jonathan Cameron escreveu: > On Wed, 31 Jul 2024 09:11:33 +0200 > Mauro Carvalho Chehab wrote: > > > Em Tue, 30 Jul 2024 13:17:09 +0200 > > Igor Mammedov escreveu: > > > > > On Mon, 22 Jul 2024 08:45:56 +0200 > > > Mauro Carvalho Chehab wrote: > > > > >

Re: QEMU unexpectedly closed the monitor

2024-07-31 Thread Daniel P . Berrangé
On Wed, Jul 31, 2024 at 11:29:01AM +0100, Peter Maydell wrote: > On Wed, 31 Jul 2024 at 10:52, Alex Bennée wrote: > > You then need to manually strip out all the various chardevs for libvirt > > control sockets and you can an equivalent command line you can run from > > the console. One thing that

Re: [RFC PATCH v5 0/8] Add Rust support, implement ARM PL011

2024-07-31 Thread Paolo Bonzini
On Wed, Jul 31, 2024 at 11:50 AM Manos Pitsidianakis wrote: > > On Fri, 26 Jul 2024 12:26, Manos Pitsidianakis > wrote: > >On Fri, 26 Jul 2024 at 11:19, Paolo Bonzini wrote: > >> As I said, I don't see the point in discussing this more, and I'm not > >> going to unless you provide a clear point

Re: [RFC PATCH 0/6] Enable shared device assignment

2024-07-31 Thread David Hildenbrand
On 31.07.24 09:12, Xu Yilun wrote: On Fri, Jul 26, 2024 at 09:08:51AM +0200, David Hildenbrand wrote: On 26.07.24 07:02, Tian, Kevin wrote: From: David Hildenbrand Sent: Thursday, July 25, 2024 10:04 PM Open Implementing a RamDiscardManager to notify VFIO of page conversions causes chan

[PULL 05/10] target/i386/cpu: Add dependencies of CPUID 0x12 leaves

2024-07-31 Thread Paolo Bonzini
From: Zhao Liu As SDM stated, CPUID 0x12 leaves depend on CPUID_7_0_EBX_SGX (SGX feature word). Since FEAT_SGX_12_0_EAX, FEAT_SGX_12_0_EBX and FEAT_SGX_12_1_EAX define multiple feature words, add the dependencies of those registers to report the warning to user if SGX is absent. Signed-off-by:

[PULL 03/10] target/i386/cpu: Remove unnecessary SGX feature words checks

2024-07-31 Thread Paolo Bonzini
From: Zhao Liu CPUID.0x7.0.ebx and CPUID.0x7.0.ecx leaves have been expressed as the feature word lists, and the Host capability support has been checked in x86_cpu_filter_features(). Therefore, such checks on SGX feature "words" are redundant, and the follow-up adjustments to those feature "wor

[PULL 02/10] target/i386: Change unavail from u32 to u64

2024-07-31 Thread Paolo Bonzini
From: Xiong Zhang The feature word 'r' is a u64, and "unavail" is a u32, the operation 'r &= ~unavail' clears the high 32 bits of 'r'. This causes many vmx cases in kvm-unit-tests to fail. Changing 'unavail' from u32 to u64 fixes this issue. Resolves: https://gitlab.com/qemu-project/qemu/-/issue

[PULL 01/10] tests/vm/openbsd: Install tomli

2024-07-31 Thread Paolo Bonzini
From: Richard Henderson OpenBSD still defaults to python 3.10, therefore tomli is now required by configure. Signed-off-by: Richard Henderson Link: https://lore.kernel.org/r/20240729051244.436851-1-richard.hender...@linaro.org Signed-off-by: Paolo Bonzini --- tests/vm/openbsd | 1 + 1 file

[PULL 09/10] qemu-vmsr-helper: fix socket loop breakage

2024-07-31 Thread Paolo Bonzini
Between v5 and v6 of the series, the socket loop of qemu-vmsr-helper was changed to allow sending multiple requests on the same socket. Unfortunately, the condition of the while loop is botched and the loop will never be entered. Clean it up, and also unify the handling of error reporting. Si

[PULL 04/10] target/i386/cpu: Explicitly express SGX_LC and SGX feature words dependency

2024-07-31 Thread Paolo Bonzini
From: Zhao Liu At present, cpu_x86_cpuid() silently masks off SGX_LC if SGX is absent. This is not proper because the user is not told about the dependency between the two. So explicitly define the dependency between SGX_LC and SGX feature words, so that user could get a warning when SGX_LC is

[PULL 00/10] i386, tests/vm changes for QEMU 9.1-rc

2024-07-31 Thread Paolo Bonzini
The following changes since commit 4e56e89d6c81589cc47cf5811f570c67889bd18a: Update version for v9.1.0-rc0 release (2024-07-31 16:21:21 +1000) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to 2a99c2ba822ef9758d739ff

Re: [RFC PATCH 0/6] Enable shared device assignment

2024-07-31 Thread David Hildenbrand
Sorry for the late reply! Current users must skip it, yes. How private memory would have to be handled, and who would handle it, is rather unclear. Again, maybe we'd want separate RamDiscardManager for private and shared memory (after all, these are two separate memory backends). We also cons

[PULL 07/10] target/i386: Fix typo that assign same value twice

2024-07-31 Thread Paolo Bonzini
From: Anthony Harivel Should fix: CID 1558553 Signed-off-by: Anthony Harivel Link: https://lore.kernel.org/r/20240726102632.1324432-2-ahari...@redhat.com Signed-off-by: Paolo Bonzini --- target/i386/kvm/kvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/

[PULL 10/10] qemu-vmsr-helper: implement --verbose/-v

2024-07-31 Thread Paolo Bonzini
Similar to qemu-pr-helper, do not print errors from the socket handling loop unless a --verbose or -v option is provided explicitly on the command line. Signed-off-by: Paolo Bonzini --- tools/i386/qemu-vmsr-helper.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/to

[PULL 08/10] target/i386: Clean up error cases for vmsr_read_thread_stat()

2024-07-31 Thread Paolo Bonzini
From: Anthony Harivel Fix leaking memory of file handle in case of error Erase unused "pid = -1" Add clearer error_report Should fix Coverity CID 1558557. Signed-off-by: Anthony Harivel Link: https://lore.kernel.org/r/20240726102632.1324432-3-ahari...@redhat.com Signed-off-by: Paolo Bonzini -

[PULL 06/10] target/i386/cpu: Mask off SGX/SGX_LC feature words for non-PC machine

2024-07-31 Thread Paolo Bonzini
From: Zhao Liu Only PC machine supports SGX, so mask off SGX related feature words for non-PC machine (microvm). Signed-off-by: Zhao Liu Link: https://lore.kernel.org/r/20240730045544.2516284-5-zhao1@intel.com Signed-off-by: Paolo Bonzini --- include/hw/i386/sgx-epc.h | 1 + hw/i386/sgx-

Re: [PATCH 1/1] target/riscv: Remove redundant insn length check for zama16b

2024-07-31 Thread LIU Zhiwei
On 2024/7/31 17:38, Alistair Francis wrote: On Thu, Jul 25, 2024 at 11:53 AM LIU Zhiwei wrote: On 2024/7/23 13:59, Richard Henderson wrote: On 7/23/24 15:29, LIU Zhiwei wrote: The more detailed information about its meaning is in priviledged 1.13 specification. More exactly, in 3.6.4. Misa

Re: [PATCH] hw/arm/mps2-tz.c: fix RX/TX interrupts order

2024-07-31 Thread Peter Maydell
On Tue, 30 Jul 2024 at 08:32, wrote: > > From: Marco Palumbi > > The order of the RX and TX interrupts are swapped. > This commit fixes the order as per the following documents: > * https://developer.arm.com/documentation/dai0505/latest/ > * https://developer.arm.com/documentation/dai0521/lates

Re: [PATCH] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark logic

2024-07-31 Thread Peter Maydell
On Wed, 31 Jul 2024 at 09:49, Salil Mehta wrote: > > Hello, > > A quick check and a gentle reminder, has this patch been accepted? Thanks for the ping. I'm doing a target-arm pullreq tomorrow so I'll take it via my queue. -- PMM

Re: [PATCH] linux-user/main: Allow setting tb-size

2024-07-31 Thread Philippe Mathieu-Daudé
On 30/7/24 23:54, Ilya Leoshkevich wrote: While qemu-system can set tb-size using -accel tcg,tb-size=n, there is no similar knob for qemu-user. Add one in a way similar to how one-insn-per-tb is already handled. Signed-off-by: Ilya Leoshkevich --- linux-user/main.c | 12 1 file

Re: [PATCH 3/8] target/arm: Pass env pointer through to gvec_bfdot helper

2024-07-31 Thread Peter Maydell
On Wed, 31 Jul 2024 at 02:36, Richard Henderson wrote: > > On 7/31/24 02:03, Peter Maydell wrote: > > Pass the env pointer through to the gvec_bfdot helper, > > so we can use it to add support for FEAT_EBF16. > > > > Signed-off-by: Peter Maydell > > --- > > target/arm/helper.h | 4

[PATCH v2 3/4] scsi-disk: Add warning comments that host_status errors take a shortcut

2024-07-31 Thread Kevin Wolf
scsi_block_sgio_complete() has surprising behaviour in that there are error cases in which it directly completes the request and never calls the passed callback. In the current state of the code, this doesn't seem to result in bugs, but with future code changes, we must be careful to never rely on

[PATCH v2 0/4] scsi-block: Fix error handling with r/werror=stop

2024-07-31 Thread Kevin Wolf
Running validation tests in Windows 2019's Failover Cluster Manager fails in two different ways when run with rerror/werror=stop: 1. It runs into an assertion failure because the sgio-based I/O path takes shortcuts in its error handling that skip necessary cleanup 2. RESERVATION_CONFLICT is tr

RE: [PATCH] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark logic

2024-07-31 Thread Salil Mehta via
> From: Peter Maydell > Sent: Wednesday, July 31, 2024 12:39 PM > To: Salil Mehta > > On Wed, 31 Jul 2024 at 09:49, Salil Mehta wrote: > > > > Hello, > > > > A quick check and a gentle reminder, has this patch been accepted? > > Thanks for the ping. I'm doing a target-arm pullreq to

Re: [PATCH 6/8] target/arm: Prepare bfdotadd() callers for FEAT_EBF support

2024-07-31 Thread Peter Maydell
On Wed, 31 Jul 2024 at 02:48, Richard Henderson wrote: > > On 7/31/24 02:03, Peter Maydell wrote: > > @@ -2790,7 +2790,7 @@ DO_MMLA_B(gvec_usmmla_b, do_usmmla_b) > >* BFloat16 Dot Product > >*/ > > > > -float32 bfdotadd(float32 sum, uint32_t e1, uint32_t e2) > > +bool is_ebf(CPUARMState *e

[PATCH v2 4/4] scsi-disk: Always report RESERVATION_CONFLICT to guest

2024-07-31 Thread Kevin Wolf
In the case of scsi-block, RESERVATION_CONFLICT is not a backend error, but indicates that the guest tried to make a request that it isn't allowed to execute. Pass the error to the guest so that it can decide what to do with it. Without this, if we stop the VM in response to a RESERVATION_CONFLICT

[PATCH v2 2/4] scsi-block: Don't skip callback for sgio error status/driver_status

2024-07-31 Thread Kevin Wolf
Instead of calling into scsi_handle_rw_error() directly from scsi_block_sgio_complete() and skipping the normal callback, go through the normal cleanup path by calling the callback with a positive error value. The important difference here is not only that the code path is cleaner, but that the ca

[PATCH v2 1/4] scsi-disk: Use positive return value for status in dma_readv/writev

2024-07-31 Thread Kevin Wolf
In some error cases, scsi_block_sgio_complete() never calls the passed callback, but directly completes the request. This leads to bugs because its error paths are not exact copies of what the callback would normally do. In preparation to fix this, allow passing positive return values to the callb

Re: [PATCH] arm/kvm: add support for MTE

2024-07-31 Thread Ganapatrao Kulkarni
On 29-07-2024 04:10 pm, Ganapatrao Kulkarni wrote: On 29-07-2024 03:44 pm, Alex Bennée wrote: Ganapatrao Kulkarni writes: Hi Peter, [Apologies for the delayed response] On 16-07-2024 09:15 pm, Peter Maydell wrote: On Tue, 9 Jul 2024 at 07:05, Ganapatrao Kulkarni wrote: Extend the

Re: [RFC 1/2] target/riscv: rvv: reduce the overhead for simple RISC-V vector unit-stride loads and stores

2024-07-31 Thread Daniel Henrique Barboza
On 7/27/24 4:13 AM, Richard Henderson wrote: On 7/18/24 01:30, Paolo Savini wrote: From: Helene CHELIN This patch improves the performance of the emulation of the RVV unit-stride loads and stores in the following cases: - when the data being loaded/stored per iteration amounts to 8 bytes o

Re: [PATCH] target/ppc: Set ctx->opcode for decode_insn32()

2024-07-31 Thread Philippe Mathieu-Daudé
On 31/7/24 12:07, Ilya Leoshkevich wrote: divdu (without a dot) sometimes updates cr0, even though it shouldn't. The reason is that gen_op_arith_divd() checks Rc(ctx->opcode), which is not initialized. This field is initialized only for instructions that go through decode_legacy(), and not decode

Re: [PATCH v3 01/24] python: Install pycotap in our venv if necessary

2024-07-31 Thread Philippe Mathieu-Daudé
On 30/7/24 19:03, Daniel P. Berrangé wrote: From: Thomas Huth The upcoming functional tests will require pycotap for providing TAP output from the python-based tests. Since we want to be able to run some of the tests offline by default, too, let's install it along with meson in our venv if nece

Re: [PATCH v3 04/24] tests/Makefile.include: Increase the level of indentation in the help text

2024-07-31 Thread Philippe Mathieu-Daudé
On 30/7/24 19:03, Daniel P. Berrangé wrote: From: Thomas Huth The next patch is going to add some entries that need more space between the command and the help text, so let's increase the indentation here first. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests/Makef

Re: [PATCH v3 06/24] tests/functional: Convert simple avocado tests into standalone python tests

2024-07-31 Thread Philippe Mathieu-Daudé
On 30/7/24 19:03, Daniel P. Berrangé wrote: From: Thomas Huth These test are rather simple and don't need any modifications apart from adjusting the "from avocado_qemu" line. To ease debugging, make the files executable and add a shebang line and Python '__main__' handling, too, so that these t

Re: [PATCH v3 02/24] tests/functional: Add base classes for the upcoming pytest-based tests

2024-07-31 Thread Philippe Mathieu-Daudé
On 30/7/24 19:03, Daniel P. Berrangé wrote: From: Thomas Huth The file is mostly a copy of the tests/avocado/avocado_qemu/__init__.py file with some adjustments to get rid of the Avocado dependencies (i.e. we also have to drop the LinuxSSHMixIn and LinuxTest for now). The emulator binary and b

Re: [PATCH v3 07/24] tests/functional: Convert avocado tests that just need a small adjustment

2024-07-31 Thread Philippe Mathieu-Daudé
On 30/7/24 19:03, Daniel P. Berrangé wrote: From: Thomas Huth These simple tests can be converted to stand-alone tests quite easily, e.g. by just setting the machine to 'none' now manually or by adding "-cpu" command line parameters, since we don't support the corresponding avocado tags in the

Re: [PATCH v3 16/24] tests/functional: Convert the riscv_opensbi avocado test into a standalone test

2024-07-31 Thread Philippe Mathieu-Daudé
On 30/7/24 19:03, Daniel P. Berrangé wrote: From: Thomas Huth The avocado test defined test functions for both, riscv32 and riscv64. Since we can run the whole file with multiple targets in the new framework, we can now consolidate the functions so we have to only define one function per machin

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-31 Thread Peter Xu
On Wed, Jul 31, 2024 at 03:41:00AM -0400, Michael S. Tsirkin wrote: > On Wed, Jul 31, 2024 at 08:04:24AM +0100, Daniel P. Berrangé wrote: > > On Tue, Jul 30, 2024 at 05:32:48PM -0400, Michael S. Tsirkin wrote: > > > On Tue, Jul 30, 2024 at 04:03:53PM -0400, Peter Xu wrote: > > > > On Tue, Jul 30, 2

Re: [PATCH] iotests/024: exclude 'backing file format' field from the output

2024-07-31 Thread Philippe Mathieu-Daudé
On 30/7/24 11:47, Andrey Drobyshev wrote: Apparently 'qemu-img info' doesn't report the backing file format field for qed (as it does for qcow2): $ qemu-img create -f qed base.qed 1M && qemu-img create -f qed -b base.qed -F qed top.qed 1M $ qemu-img create -f qcow2 base.qcow2 1M && qemu-img cre

[Bug 2072564] Re: qemu-aarch64-static segfaults running ldconfig.real (amd64 host)

2024-07-31 Thread Michał Fita
I'm using quemu to tweak Armbian Jammy images for Raspberry Pi 5 (so it would have ldconfig from 22.04) and I have signal 11 when libc reconfiguration is triggered by apt. What you may find interesting running the same process of updates on the same base image on Ubuntu 22.04 (which has qemu 6.2)

[RFC PATCH] hw/ppc: Implement -dtb support for PowerNV

2024-07-31 Thread Aditya Gupta
Currently any device tree passed with -dtb option in QEMU, was ignored by the PowerNV code. Read and pass the passed -dtb to the kernel, thus enabling easier debugging with custom DTBs. The existing behaviour when -dtb is 'not' passed, is preserved as-is. But when a '-dtb' is passed, it complete

Re: [RFC PATCH] hw/ppc: Implement -dtb support for PowerNV

2024-07-31 Thread Daniel P . Berrangé
On Wed, Jul 31, 2024 at 06:52:35PM +0530, Aditya Gupta wrote: > Currently any device tree passed with -dtb option in QEMU, was ignored > by the PowerNV code. > > Read and pass the passed -dtb to the kernel, thus enabling easier > debugging with custom DTBs. > > The existing behaviour when -dtb is

Silent parameters for Qemu installer

2024-07-31 Thread Prachi Patil
Hello team, We are 3rd party patch provider like PatchMyPC or ManageEngine. We are providing similar services to our customers. For more details you may refer https://adaptiva.com/products/autonomous-patch. Can you please provide us if there are any command line parameters for selecting below

[PATCH] util: retry open() when it gets interrupted by a signal

2024-07-31 Thread Philipp Reisner
As with many syscalls, open() might be interrupted by a signal. The experienced logfile entry is: qemu-system-x86_64: -device virtio-blk-pci,bus=pci.0,addr=0x7,drive=libvirt-2-format,id=virtio-disk0,bootindex=2,write-cache=on,serial=1b990c4d13b74a4e90ea: Could not open '/dev/drbd1003': Interrup

[PATCH] qmp: Fix higher half vaddrs for [p]memsave

2024-07-31 Thread Josh Junon
Previously, int64_t's were used when parsing virtual / physical addresses for the [p]memsave commands over QMP (HMP was unaffected). This caused issues when the virtual addresses were in the higher half of a 64-bit address space, as various portions of the parsing code would consider them out of bo

Re: [RFC PATCH] hw/ppc: Implement -dtb support for PowerNV

2024-07-31 Thread Aditya Gupta
Hi Daniel, Thank you for the review. On 24/07/31 02:34PM, Daniel P. Berrangé wrote: > On Wed, Jul 31, 2024 at 06:52:35PM +0530, Aditya Gupta wrote: > > Currently any device tree passed with -dtb option in QEMU, was ignored > > by the PowerNV code. > > > > Read and pass the passed -dtb to the ker

Re: [PATCH] qdev-monitor: QAPIfy QMP device_add

2024-07-31 Thread Peter Krempa
On Tue, Jul 09, 2024 at 16:27:22 +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > The QMP device_add monitor command converts the QDict arguments to > > QemuOpts and then back again to QDict. This process only supports scalar > > types. Device properties like virtio-blk-pci's iothr

Re: [PATCH] util: retry open() when it gets interrupted by a signal

2024-07-31 Thread David Hildenbrand
On 31.07.24 15:25, Philipp Reisner wrote: As with many syscalls, open() might be interrupted by a signal. The experienced logfile entry is: qemu-system-x86_64: -device virtio-blk-pci,bus=pci.0,addr=0x7,drive=libvirt-2-format,id=virtio-disk0,bootindex=2,write-cache=on,serial=1b990c4d13b74a4e90e

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-07-31 Thread Manish
On 30/07/24 6:39 pm, Igor Mammedov wrote: !---| CAUTION: External Email |---! On Mon, 29 Jul 2024 19:42:39 +0700 Manish wrote: On 29/07/24 7:18 pm, Igor Mammed

[RFC PATCH] Makefile: trigger re-configure on updated pythondeps

2024-07-31 Thread Alex Bennée
If we add additional deps for meson we need to ensure we trigger a reconfigure to make sure everything is set up. Signed-off-by: Alex Bennée --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 02a257584b..0281a883a1 100644 --- a/Makefile +++

Re: [RFC 0/2] Identify aliased maps in vdpa SVQ iova_tree

2024-07-31 Thread Jonah Palmer
On 7/31/24 5:56 AM, Eugenio Perez Martin wrote: On Tue, Jul 30, 2024 at 2:32 PM Jonah Palmer wrote: On 7/30/24 7:00 AM, Eugenio Perez Martin wrote: On Tue, Jul 30, 2024 at 10:48 AM Jason Wang wrote: On Mon, Jul 29, 2024 at 6:05 PM Eugenio Perez Martin wrote: On Wed, Jul 24, 2024 at

Re: [PATCH] util: retry open() when it gets interrupted by a signal

2024-07-31 Thread Daniel P . Berrangé
On Wed, Jul 31, 2024 at 03:25:24PM +0200, Philipp Reisner wrote: > As with many syscalls, open() might be interrupted by a signal. > > The experienced logfile entry is: > > qemu-system-x86_64: -device > virtio-blk-pci,bus=pci.0,addr=0x7,drive=libvirt-2-format,id=virtio-disk0,bootindex=2,write-ca

Re: [PATCH v3 02/24] tests/functional: Add base classes for the upcoming pytest-based tests

2024-07-31 Thread Alex Bennée
Daniel P. Berrangé writes: > From: Thomas Huth > > The file is mostly a copy of the tests/avocado/avocado_qemu/__init__.py > file with some adjustments to get rid of the Avocado dependencies (i.e. > we also have to drop the LinuxSSHMixIn and LinuxTest for now). > > The emulator binary and build

Re: [PATCH] util: retry open() when it gets interrupted by a signal

2024-07-31 Thread Peter Maydell
On Wed, 31 Jul 2024 at 15:11, Daniel P. Berrangé wrote: > > On Wed, Jul 31, 2024 at 03:25:24PM +0200, Philipp Reisner wrote: > > As with many syscalls, open() might be interrupted by a signal. > > > > The experienced logfile entry is: > > > > qemu-system-x86_64: -device > > virtio-blk-pci,bus=pci

[PATCH 0/7] block: Miscellaneous minor Coverity fixes

2024-07-31 Thread Peter Maydell
This patchset is a collection of fixes for minor Coverity reported issues. In all cases, there isn't a user-visible problem, but the Coverity issue pointed up somewhere where we could clean up the code or make it a bit more obvious to a human reader what the intent was. Only lightly tested (with "

[PATCH 2/7] block/gluster: Use g_autofree for string in qemu_gluster_parse_json()

2024-07-31 Thread Peter Maydell
In the loop in qemu_gluster_parse_json() we do: char *str = NULL; for(...) { str = g_strdup_printf(...); ... if (various errors) { goto out; } ... g_free(str); str = NULL; } return 0; out: various cleanups;

[PATCH 1/7] block/vdi.c: Avoid potential overflow when calculating size of write

2024-07-31 Thread Peter Maydell
In vdi_co_pwritev() we multiply a sector count by SECTOR_SIZE to get the size to write in bytes. Coverity notes that this means that we do the multiply as a 32x32->32 multiply before converting to 64 bits, which has the potential to overflow. This is very unlikely to happen, since the block map ha

[PATCH 5/7] hw/block/fdc-isa: Assert that isa_fdc_get_drive_max_chs() found something

2024-07-31 Thread Peter Maydell
Coverity complains about an overflow in isa_fdc_get_drive_max_chs() that can happen if the loop over fd_formats never finds a match, because we initialize *maxc to 0 and then at the end of the function decrement it. This can't ever actually happen because fd_formats has at least one entry for each

[PATCH 6/7] hw/ide/pci.c: Remove dead code from bmdma_prepare_buf()

2024-07-31 Thread Peter Maydell
Coverity notes that the code at the end of the loop in bmdma_prepare_buf() is unreachable. This is because in commit 9fbf0fa81fca8f527 ("ide: remove hardcoded 2GiB transactional limit") we removed the only codepath in the loop which could "break" out of it, but didn't notice that this meant we sho

  1   2   >