Re: [PATCH v1 01/17] intel_iommu: Use the latest fault reasons defined by spec

2024-07-29 Thread Yi Liu
On 2024/7/18 16:16, Zhenzhong Duan wrote: From: Yu Zhang Spec revision 3.0 or above defines more detailed fault reasons for scalable mode. So introduce them into emulation code, see spec section 7.1.2 for details. Note spec revision has no relation with VERSION register, Guest kernel should no

Re: [PATCH for-9.1] tests/vm/openbsd: Install tomli

2024-07-29 Thread Paolo Bonzini
Queued, thanks. I adjust the commit message to point out that OpenBSD still has Python 3.10 (tomli is not needed starting from 3.11). Paolo

Re: [PULL v2 25/25] qga/linux: Add new api 'guest-network-get-route'

2024-07-29 Thread Konstantin Kostiuk
Hi Peter, How to see the full coverity report? In https://gitlab.com/qemu-project/qemu/-/artifacts, I see only job.log Do you expect to fix these errors for the 9.1 release? Best Regards, Konstantin Kostiuk. On Thu, Jul 25, 2024 at 1:12 PM Peter Maydell wrote: > On Tue, 23 Jul 2024 at 08:03,

Re: [PATCH] RISC-V: Remove riscv_cpu_claim_interrupts()

2024-07-29 Thread LIU Zhiwei
On 2024/7/29 14:07, Alvin Che-Chia Chang(張哲嘉) wrote: Hi Zhiwei, -Original Message- From: LIU Zhiwei Sent: Monday, July 29, 2024 1:47 PM To: Alvin Che-Chia Chang(張哲嘉) ; qemu-ri...@nongnu.org; qemu-devel@nongnu.org Cc: alistair.fran...@wdc.com; bin.m...@windriver.com; liwei1...@gmail.c

Re: [RFC v2 1/3] vhost: Introduce packed vq and add buffer elements

2024-07-29 Thread Eugenio Perez Martin
On Sun, Jul 28, 2024 at 7:37 PM Sahil wrote: > > Hi, > > On Friday, July 26, 2024 7:18:28 PM GMT+5:30 Eugenio Perez Martin wrote: > > On Fri, Jul 26, 2024 at 11:58 AM Sahil Siddiq wrote: > > > This is the first patch in a series to add support for packed > > > virtqueues in vhost_shadow_virtqueue

Re: [PATCH] hw/ppc: fix decrementer with BookE timers

2024-07-29 Thread Clément Chigot
Hi, Gentle ping + CC missing maintainers. Thanks Clément On Mon, Jul 15, 2024 at 10:46 AM Clément Chigot wrote: > > The BookE decrementer stops at 0, meaning that it won't decremented > towards "negative" values. > However, the current logic is inverted: decr is updated solely when > the result

Re: [PATCH v1 01/17] intel_iommu: Use the latest fault reasons defined by spec

2024-07-29 Thread Michael S. Tsirkin
On Mon, Jul 29, 2024 at 03:39:03PM +0800, Yi Liu wrote: > On 2024/7/18 16:16, Zhenzhong Duan wrote: > > From: Yu Zhang > > > > Spec revision 3.0 or above defines more detailed fault reasons for > > scalable mode. So introduce them into emulation code, see spec > > section 7.1.2 for details. > >

Re: The question about migration/checkpointing

2024-07-29 Thread Alex Bennée
Sergei Lyubski writes: > Hi guys, > > My name is Sergey. My company uses QEMU for CPU performance > simulation/evaluaton. > Sorry, I found your emails in QEMU relatively recent commits into ram.c . > Why ram.c . Because I see some weirdness in > the behavior. > > Our goal is : >

Re: [PATCH v5 05/11] exec/ioport: Add portio_list_set_address()

2024-07-29 Thread Philippe Mathieu-Daudé
On 14/1/24 13:39, Bernhard Beschow wrote: Some SuperI/O devices such as the VIA south bridges or the PC87312 controller are able to relocate their SuperI/O functions. Add a convenience function for implementing this in the VIA south bridges. This convenience function relies on previous simplific

Re: [PATCH v5 11/11] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2024-07-29 Thread Philippe Mathieu-Daudé
On 14/1/24 13:39, Bernhard Beschow wrote: The VIA south bridges are able to relocate and toggle (enable or disable) their SuperI/O functions. So far this is hardcoded such that all functions are always enabled and are located at fixed addresses. Some PC BIOSes seem to probe for I/O occupancy bef

Re: [PULL v2 25/25] qga/linux: Add new api 'guest-network-get-route'

2024-07-29 Thread Peter Maydell
On Mon, 29 Jul 2024 at 08:40, Konstantin Kostiuk wrote: > > Hi Peter, > > How to see the full coverity report? In > https://gitlab.com/qemu-project/qemu/-/artifacts, I see only job.log > Do you expect to fix these errors for the 9.1 release? Coverity errors are in https://scan.coverity.com/proje

Re: [PATCH v1 01/17] intel_iommu: Use the latest fault reasons defined by spec

2024-07-29 Thread Yi Liu
On 2024/7/29 16:42, Michael S. Tsirkin wrote: On Mon, Jul 29, 2024 at 03:39:03PM +0800, Yi Liu wrote: On 2024/7/18 16:16, Zhenzhong Duan wrote: From: Yu Zhang Spec revision 3.0 or above defines more detailed fault reasons for scalable mode. So introduce them into emulation code, see spec s

Re: [PATCH] util/cpuinfo: Make use of elf_aux_info(3) on OpenBSD

2024-07-29 Thread Philippe Mathieu-Daudé
Hi Brad, On 28/7/24 05:58, Brad Smith wrote: util/cpuinfo: Make use of elf_aux_info(3) on OpenBSD Signed-off-by: Brad Smith --- meson.build| 8 util/cpuinfo-aarch64.c | 9 ++--- util/cpuinfo-ppc.c | 5 +++-- util/getauxval.c | 2 +- 4 files changed, 18

Re: [PATCH] arm/kvm: add support for MTE

2024-07-29 Thread Ganapatrao Kulkarni
Hi Peter, [Apologies for the delayed response] On 16-07-2024 09:15 pm, Peter Maydell wrote: On Tue, 9 Jul 2024 at 07:05, Ganapatrao Kulkarni wrote: Extend the 'mte' property for the virt machine to cover KVM as well. For KVM, we don't allocate tag memory, but instead enable the capability

Re: [PATCH v2] scripts/qcow2-to-stdout.py: Add script to write qcow2 images to stdout

2024-07-29 Thread Alberto Garcia
On Sun 28 Jul 2024 01:01:07 AM +03, Nir Soffer wrote: >> +def bitmap_set(bitmap, idx): >> +bitmap[int(idx / 8)] |= 1 << (idx % 8) > > Should use floor division operator (//): > > bitmap[idx // 8] |= 1 << (idx % 8) > > Same for bitmap_test(). Right, also for all other cases of int(foo / bar

Re: [PULL 00/96] ppc-for-9.1-2 queue

2024-07-29 Thread Philippe Mathieu-Daudé
Hi Nick, On 26/7/24 01:52, Nicholas Piggin wrote: Apologies this is so late after soft-freeze, apologies. I was waiting on "accel/kvm: Extract common KVM vCPU {creation,parking} code" to be merged upstream [...] When we have dependencies like that we can ping the maintainer or ask if he/she is

[PATCH 2/4] scsi-block: Don't skip callback for sgio error status/driver_status

2024-07-29 Thread Kevin Wolf
Instead of calling into scsi_handle_rw_error() directly from scsi_block_sgio_complete() and skipping the normal callback, go through the normal cleanup path by calling the callback with a positive error value. The important difference here is not only that the code path is cleaner, but that the ca

[PATCH 3/4] scsi-disk: Add warning comments that host_status errors take a shortcut

2024-07-29 Thread Kevin Wolf
scsi_block_sgio_complete() has surprising behaviour in that there are error cases in which it directly completes the request and never calls the passed callback. In the current state of the code, this doesn't seem to result in bugs, but with future code changes, we must be careful to never rely on

[PATCH 0/4] scsi-block: Fix error handling with r/werror=stop

2024-07-29 Thread Kevin Wolf
Running validation tests in Windows 2019's Failover Cluster Manager fails in two different ways when run with rerror/werror=stop: 1. It runs into an assertion failure because the sgio-based I/O path takes shortcuts in its error handling that skip necessary cleanup 2. RESERVATION_CONFLICT is tr

[PATCH 4/4] scsi-disk: Always report RESERVATION_CONFLICT to guest

2024-07-29 Thread Kevin Wolf
RESERVATION_CONFLICT is not a backend error, but indicates that the guest tried to make a request that it isn't allowed to execute. Pass the error to the guest so that it can decide what to do with it. Without this, if we stop the VM in response to a RESERVATION_CONFLICT, it can happen that the VM

[PATCH 1/4] scsi-disk: Use positive return value for status in dma_readv/writev

2024-07-29 Thread Kevin Wolf
In some error cases, scsi_block_sgio_complete() never calls the passed callback, but directly completes the request. This leads to bugs because its error paths are not exact copies of what the callback would normally do. In preparation to fix this, allow passing positive return values to the callb

Re: [PATCH v1] target/s390x: move @deprecated-props to CpuModelExpansion Info

2024-07-29 Thread David Hildenbrand
On 27.07.24 08:02, Markus Armbruster wrote: Collin Walling writes: The @deprecated-props array did not make any sense to be a member of the CpuModelInfo struct, since this field would only be populated by a query-cpu-model-expansion response and ignored otherwise. Doesn't query-cpu-model-bas

Re: [RFC 0/2] Identify aliased maps in vdpa SVQ iova_tree

2024-07-29 Thread Eugenio Perez Martin
On Wed, Jul 24, 2024 at 7:00 PM Jonah Palmer wrote: > > > > On 5/13/24 11:56 PM, Jason Wang wrote: > > On Mon, May 13, 2024 at 5:58 PM Eugenio Perez Martin > > wrote: > >> > >> On Mon, May 13, 2024 at 10:28 AM Jason Wang wrote: > >>> > >>> On Mon, May 13, 2024 at 2:28 PM Eugenio Perez Martin > >

Re: [PULL 15/96] ppc/pnv: Implement POWER9 LPC PSI serirq outputs and auto-clear function

2024-07-29 Thread Cédric Le Goater
On 7/26/24 01:52, Nicholas Piggin wrote: The POWER8 LPC ISA device irqs all get combined and reported to the line connected the PSI LPCHC irq. POWER9 changed this so only internal LPC host controller irqs use that line, and the device irqs get routed to 4 new lines connected to PSI SERIRQ0-3. PO

Re: [PATCH] arm/kvm: add support for MTE

2024-07-29 Thread Alex Bennée
Ganapatrao Kulkarni writes: > Hi Peter, > > > [Apologies for the delayed response] > > On 16-07-2024 09:15 pm, Peter Maydell wrote: >> On Tue, 9 Jul 2024 at 07:05, Ganapatrao Kulkarni >> wrote: >>> >>> Extend the 'mte' property for the virt machine to cover KVM as >>> well. For KVM, we don't all

Re: [PULL 17/96] ppc/pnv: Implement ADU access to LPC space

2024-07-29 Thread Cédric Le Goater
On 7/26/24 01:52, Nicholas Piggin wrote: One of the functions of the ADU is indirect memory access engines that send and receive data via ADU registers. This implements the ADU LPC memory access functionality sufficiently for IBM proprietary firmware to access the UART and print characters to th

Re: [PATCH 03/13] tests/avocado/intel_iommu.py: increase timeout

2024-07-29 Thread Daniel P . Berrangé
On Fri, Jul 26, 2024 at 09:44:28AM -0400, Cleber Rosa wrote: > Based on many runs, the average run time for these 4 tests is around > 250 seconds, with 320 seconds being the ceiling. In any way, the > default 120 seconds timeout is inappropriate in my experience. > Let's increase the timeout so th

Re: [PULL 38/96] hw/ssi: Extend SPI model

2024-07-29 Thread Cédric Le Goater
On 7/26/24 01:53, Nicholas Piggin wrote: From: Chalapathi V In this commit SPI shift engine and sequencer logic is implemented. Shift engine performs serialization and de-serialization according to the control by the sequencer and according to the setup defined in the configuration registers. S

Re: [PATCH 05/13] tests/avocado: machine aarch64: standardize location and RO access

2024-07-29 Thread Daniel P . Berrangé
On Fri, Jul 26, 2024 at 09:44:30AM -0400, Cleber Rosa wrote: > The tests under machine_aarch64_virt.py and machine_aarch64_sbsaref.py > should not be writing to the ISO files. By adding "media=cdrom" the > "ro" is autmatically set. > > While at it, let's use a single code style and hash for the I

Re: [PATCH] arm/kvm: add support for MTE

2024-07-29 Thread Ganapatrao Kulkarni
On 29-07-2024 03:44 pm, Alex Bennée wrote: Ganapatrao Kulkarni writes: Hi Peter, [Apologies for the delayed response] On 16-07-2024 09:15 pm, Peter Maydell wrote: On Tue, 9 Jul 2024 at 07:05, Ganapatrao Kulkarni wrote: Extend the 'mte' property for the virt machine to cover KVM as we

[PATCH v3] ptp: Add vDSO-style vmclock support

2024-07-29 Thread David Woodhouse
From: David Woodhouse The vmclock "device" provides a shared memory region with precision clock information. By using shared memory, it is safe across Live Migration. Like the KVM PTP clock, this can convert TSC-based cross timestamps into KVM clock values. Unlike the KVM PTP clock, it does so o

Re: [PATCH 06/13] tests/avocado: use more distinct names for assets

2024-07-29 Thread Daniel P . Berrangé
On Fri, Jul 26, 2024 at 09:44:31AM -0400, Cleber Rosa wrote: > Avocado's asset system will deposit files in a cache organized either > by their original location (the URI) or by their names. Because the > cache (and the "by_name" sub directory) is common across tests, it's a > good idea to make th

Re: [PATCH 07/13] tests/avocado/kvm_xen_guest.py: cope with asset RW requirements

2024-07-29 Thread Daniel P . Berrangé
On Fri, Jul 26, 2024 at 09:44:32AM -0400, Cleber Rosa wrote: > Some of these tests actually require the root filesystem image, > obtained through Avocado's asset feature and kept in a common cache > location, to be writable. > > This makes a distinction between the tests that actually have this >

Re: [PATCH 08/13] testa/avocado: test_arm_emcraft_sf2: handle RW requirements for asset

2024-07-29 Thread Daniel P . Berrangé
On Fri, Jul 26, 2024 at 09:44:33AM -0400, Cleber Rosa wrote: > The asset used in the mentioned test gets truncated before it's used > in the test. This means that the file gets modified, and thus the > asset's expected hash doesn't match anymore. This causes cache misses > and re-downloads every

Re: [PATCH 09/13] tests/avocado/boot_xen.py: fetch kernel during test setUp()

2024-07-29 Thread Daniel P . Berrangé
On Fri, Jul 26, 2024 at 09:44:34AM -0400, Cleber Rosa wrote: > The kernel is a common blob used in all tests. By moving it to the > setUp() method, the "fetch asset" plugin will recognize the kernel and > attempt to fetch it and cache it before the tests are started. The other tests don't call f

Re: [PATCH 10/13] tests/avocado/tuxrun_baselines.py: use Avocado's zstd support

2024-07-29 Thread Daniel P . Berrangé
On Fri, Jul 26, 2024 at 09:44:35AM -0400, Cleber Rosa wrote: > Signed-off-by: Cleber Rosa > --- > tests/avocado/tuxrun_baselines.py | 16 ++-- > 1 file changed, 6 insertions(+), 10 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -

Re: [PATCH 11/13] tests/avocado/machine_aarch64_sbsaref.py: allow for rw usage of image

2024-07-29 Thread Daniel P . Berrangé
On Fri, Jul 26, 2024 at 09:44:36AM -0400, Cleber Rosa wrote: > When the OpenBSD based tests are run in parallel, the previously > single instance of the image would become corrupt. Let's give each > test its own copy. > > Signed-off-by: Cleber Rosa > --- > tests/avocado/machine_aarch64_sbsaref.

Re: [PATCH 12/13] Bump avocado to 103.0

2024-07-29 Thread Daniel P . Berrangé
On Fri, Jul 26, 2024 at 09:44:37AM -0400, Cleber Rosa wrote: > This bumps Avocado to latest the LTS release. > > An LTS release is one that can receive bugfixes and guarantees > stability for a much longer period and has incremental minor releases > made. > > Even though the 103.0 LTS release is

Re: [PATCH v3 7/7] acpi/ghes: extend arm error injection logic

2024-07-29 Thread Mauro Carvalho Chehab
Em Fri, 26 Jul 2024 14:22:25 +0100 Jonathan Cameron escreveu: > On Mon, 22 Jul 2024 08:45:59 +0200 > Mauro Carvalho Chehab wrote: > > > Enrich CPER error injection logic for ARM processor to allow > > setting values to from UEFI 2.10 tables N.16 and N.17. > > > > It should be noticed that, wi

Re: [PATCH v3 7/7] acpi/ghes: extend arm error injection logic

2024-07-29 Thread Mauro Carvalho Chehab
Em Thu, 25 Jul 2024 12:03:46 +0200 Markus Armbruster escreveu: > Mauro Carvalho Chehab writes: > > > Enrich CPER error injection logic for ARM processor to allow > > setting values to from UEFI 2.10 tables N.16 and N.17. > > > > It should be noticed that, with such change, all arguments are >

Re: [PATCH v3 4/7] acpi/ghes: Add a logic to handle block addresses and FW first ARM processor error injection

2024-07-29 Thread Mauro Carvalho Chehab
Em Fri, 26 Jul 2024 13:44:12 +0100 Jonathan Cameron escreveu: > On Mon, 22 Jul 2024 08:45:56 +0200 > Mauro Carvalho Chehab wrote: > > > From: Jonathan Cameron > > > > 1. Some GHES functions require handling addresses. Add a helper function > >to support it. > > > > 2. Add support for ACP

Re: [PATCH 01/13] tests/avocado: mips: fallback to HTTP given certificate expiration

2024-07-29 Thread Philippe Mathieu-Daudé
On 26/7/24 15:44, Cleber Rosa wrote: The SSL certificate installed at mipsdistros.mips.com has expired: 0 s:CN = mipsdistros.mips.com i:C = US, O = Amazon, OU = Server CA 1B, CN = Amazon a:PKEY: rsaEncryption, 2048 (bit); sigalg: RSA-SHA256 v:NotBefore: Dec 23 00:00:00 2019 GMT; NotAfter

Re: [PATCH 06/13] tests/avocado: use more distinct names for assets

2024-07-29 Thread Philippe Mathieu-Daudé
On 29/7/24 12:49, Daniel P. Berrangé wrote: On Fri, Jul 26, 2024 at 09:44:31AM -0400, Cleber Rosa wrote: Avocado's asset system will deposit files in a cache organized either by their original location (the URI) or by their names. Because the cache (and the "by_name" sub directory) is common ac

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-07-29 Thread Igor Mammedov
On Wed, 24 Jul 2024 23:00:13 +0800 Zhao Liu wrote: > Hi Igor, > > On Wed, Jul 24, 2024 at 02:54:32PM +0200, Igor Mammedov wrote: > > Date: Wed, 24 Jul 2024 14:54:32 +0200 > > From: Igor Mammedov > > Subject: Re: [PATCH v1] target/i386: Always set leaf 0x1f > > X-Mailer: Claws Mail 4.3.0 (GTK 3.

Re: [PATCH 4/4] scsi-disk: Always report RESERVATION_CONFLICT to guest

2024-07-29 Thread Kevin Wolf
Am 29.07.2024 um 13:55 hat Paolo Bonzini geschrieben: > On Mon, Jul 29, 2024 at 11:47 AM Kevin Wolf wrote: > > RESERVATION_CONFLICT is not a backend error, but indicates that the > > guest tried to make a request that it isn't allowed to execute. Pass the > > error to the guest so that it can deci

Re: [PATCH v3 4/7] acpi/ghes: Add a logic to handle block addresses and FW first ARM processor error injection

2024-07-29 Thread Mauro Carvalho Chehab
Em Thu, 25 Jul 2024 11:48:12 +0200 Markus Armbruster escreveu: > Mauro Carvalho Chehab writes: > > > From: Jonathan Cameron > > > > 1. Some GHES functions require handling addresses. Add a helper function > >to support it. > > > > 2. Add support for ACPI CPER (firmware-first) ARM processor

Re: [PATCH v2 1/3] block/commit: implement final flush

2024-07-29 Thread Kevin Wolf
Am 19.07.2024 um 12:35 hat Vladimir Sementsov-Ogievskiy geschrieben: > On 18.07.24 22:22, Kevin Wolf wrote: > > Am 26.06.2024 um 16:50 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > Actually block job is not completed without the final flush. It's > > > rather unexpected to have broken target

Re: [PATCH 07/13] tests/avocado/kvm_xen_guest.py: cope with asset RW requirements

2024-07-29 Thread David Woodhouse
On Mon, 2024-07-29 at 11:58 +0100, Daniel P. Berrangé wrote: > On Fri, Jul 26, 2024 at 09:44:32AM -0400, Cleber Rosa wrote: > > Some of these tests actually require the root filesystem image, > > obtained through Avocado's asset feature and kept in a common cache > > location, to be writable. Hm,

[RFC] pythondeps: Split sphinx_rtd_theme into its own group

2024-07-29 Thread Peter Maydell
Currently we have "sphinx" and "sphinx_rtd_theme" in a single group in pythondeps.toml. This means that mkvenv will try to install them both at once, which doesn't work if sphinx_rtd_theme depends on a version of Sphinx which is newer than the system one, even if the "sphinx" we're installing at th

Re: [PATCH 12/13] Bump avocado to 103.0

2024-07-29 Thread Philippe Mathieu-Daudé
On 26/7/24 15:44, Cleber Rosa wrote: This bumps Avocado to latest the LTS release. An LTS release is one that can receive bugfixes and guarantees stability for a much longer period and has incremental minor releases made. Even though the 103.0 LTS release is pretty a rewrite of Avocado when com

Re: [PATCH 4/4] scsi-disk: Always report RESERVATION_CONFLICT to guest

2024-07-29 Thread Paolo Bonzini
Il lun 29 lug 2024, 14:20 Kevin Wolf ha scritto: > Apparently both oVirt and Kubevirt unconditionally use the stop policy, > so I'm afraid in this case we must acknowledge that our expectations > don't match reality. > Yeah, of course. If I understand correctly, not having a pr-manager could me

Re: [PATCH 4/4] scsi-disk: Always report RESERVATION_CONFLICT to guest

2024-07-29 Thread Paolo Bonzini
On Mon, Jul 29, 2024 at 11:47 AM Kevin Wolf wrote: > RESERVATION_CONFLICT is not a backend error, but indicates that the > guest tried to make a request that it isn't allowed to execute. Pass the > error to the guest so that it can decide what to do with it. This is only true of scsi-block (thoug

Re: [PATCH V2 01/11] machine: alloc-anon option

2024-07-29 Thread Igor Mammedov
On Sat, 20 Jul 2024 16:28:25 -0400 Steven Sistare wrote: > On 7/16/2024 5:19 AM, Igor Mammedov wrote: > > On Sun, 30 Jun 2024 12:40:24 -0700 > > Steve Sistare wrote: > > > >> Allocate anonymous memory using mmap MAP_ANON or memfd_create depending > >> on the value of the anon-alloc machine pr

Re: [PATCH 05/13] tests/avocado: machine aarch64: standardize location and RO access

2024-07-29 Thread Cleber Rosa
On Mon, Jul 29, 2024 at 6:34 AM Daniel P. Berrangé wrote: > > On Fri, Jul 26, 2024 at 09:44:30AM -0400, Cleber Rosa wrote: > > The tests under machine_aarch64_virt.py and machine_aarch64_sbsaref.py > > should not be writing to the ISO files. By adding "media=cdrom" the > > "ro" is autmatically se

Re: [PATCH v2 01/23] python: Install pycotap in our venv if necessary

2024-07-29 Thread Philippe Mathieu-Daudé
On 24/7/24 19:52, Thomas Huth wrote: The upcoming functional tests will require pycotap for providing TAP output from the python-based tests. Since we want to be able to run some of the tests offline by default, too, let's install it along with meson in our venv if necessary (it's size is only 5

Re: [PATCH v2 02/23] tests/functional: Add base classes for the upcoming pytest-based tests

2024-07-29 Thread Philippe Mathieu-Daudé
On 24/7/24 19:52, Thomas Huth wrote: The file is mostly a copy of the tests/avocado/avocado_qemu/__init__.py file with some adjustments to get rid of the Avocado dependencies (i.e. we also have to drop the LinuxSSHMixIn and LinuxTest for now). The emulator binary and build directory are now pass

Re: [PATCH v2 04/23] tests/functional: Prepare the meson build system for the functional tests

2024-07-29 Thread Philippe Mathieu-Daudé
On 24/7/24 19:52, Thomas Huth wrote: Provide a meson.build file for the upcoming python-based functional tests, and add some wrapper glue targets to the tests/Makefile.include file. We are going to use two "speed" modes for the functional tests: The "quick" tests can be run at any time (i.e. also

[PATCH] docs/sphinx/depfile.py: Handle env.doc2path() returning a Path not a str

2024-07-29 Thread Peter Maydell
In newer versions of Sphinx the env.doc2path() API is going to change to return a Path object rather than a str. This was originally visible in Sphinx 8.0.0rc1, but has been rolled back for the final 8.0.0 release. However it will probably emit a deprecation warning and is likely to change for good

Re: [PATCH v2 05/23] tests/functional: Convert simple avocado tests into standalone python tests

2024-07-29 Thread Philippe Mathieu-Daudé
On 25/7/24 13:58, Philippe Mathieu-Daudé wrote: On 24/7/24 19:52, Thomas Huth wrote: These test are rather simple and don't need any modifications apart from adjusting the "from avocado_qemu" line. To ease debugging, make the files executable and add a shebang line and Python '__main__' handling

Re: [PATCH v2 06/23] tests/functional: Convert avocado tests that just need a small adjustment

2024-07-29 Thread Philippe Mathieu-Daudé
On 25/7/24 14:04, Philippe Mathieu-Daudé wrote: On 24/7/24 19:52, Thomas Huth wrote: These simple tests can be converted to stand-alone tests quite easily, e.g. by just setting the machine to 'none' now manually or by adding "-cpu" command line parameters, since we don't support the correspondin

Re: [PULL 38/96] hw/ssi: Extend SPI model

2024-07-29 Thread Cédric Le Goater
On 7/26/24 01:53, Nicholas Piggin wrote: +static void transfer(PnvSpi *s, PnvXferBuffer *payload) +{ +uint32_t tx; +uint32_t rx; +PnvXferBuffer *rsp_payload = NULL; + +rsp_payload = pnv_spi_xfer_buffer_new(); +for (int offset = 0; offset < payload->len; offset += s->transfer_l

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-07-29 Thread Manish
On 29/07/24 7:18 pm, Igor Mammedov wrote: !---| CAUTION: External Email |---! On Wed, 24 Jul 2024 23:00:13 +0800 Zhao Liu wrote: Hi Igor, On Wed, Jul 24, 2024

Re: [PATCH v1 00/11] Convert avocado tests to normal Python unittests

2024-07-29 Thread Daniel P . Berrangé
On Thu, Jul 25, 2024 at 10:21:54AM -0400, Cleber Rosa wrote: > On Tue, Jul 16, 2024 at 7:28 AM Thomas Huth wrote: > > There have been several attempts to update the test suite in QEMU > > to a newer version of Avocado, but so far no attempt has successfully > > been merged yet. > > > > So, we've

Re: [PATCH v2 13/23] tests/functional: Convert the x86_cpu_model_versions test

2024-07-29 Thread Philippe Mathieu-Daudé
On 24/7/24 19:52, Thomas Huth wrote: Nothing thrilling in here, it's just a straight forward conversion. Signed-off-by: Thomas Huth --- tests/functional/meson.build | 1 + .../test_x86_cpu_model_versions.py} | 63 ++- 2 files changed, 20 insertion

Re: [PATCH v3 4/7] acpi/ghes: Add a logic to handle block addresses and FW first ARM processor error injection

2024-07-29 Thread Mauro Carvalho Chehab
Em Fri, 26 Jul 2024 13:46:46 +0100 Jonathan Cameron escreveu: > A few quick replies from me. > I'm sure Mauro will add more info. > > > > + 'tlb-error', > > > + 'bus-error', > > > + 'micro-arch-error'] > > > +} > > > + > > > +## > > > +# @arm-inject-error: > > > +#

[PATCH] hw/i386/amd_iommu: Do not depend on any pci cap ordering

2024-07-29 Thread Ugur Usug
Currently, pci capabilities are inserted in the reverse order capabilities are added (see 'pci_add_capability'). amd_iommu hardware pci realization depends on this implicitly. It assumes that the first capability added will be the last one (at the tail) and its respective 'PCI_CAP_LIST_NEXT' is zer

Re: [PATCH v2 15/23] tests/functional: Convert the riscv_opensbi avocado test into a standalone test

2024-07-29 Thread Philippe Mathieu-Daudé
On 24/7/24 19:52, Thomas Huth wrote: The avocado test defined test functions for both, riscv32 and riscv64. Since we can run the whole file with multiple targets in the new framework, we can now consolidate the functions so we have to only define one function per machine now. Signed-off-by: Thom

Re: [PULL 38/96] hw/ssi: Extend SPI model

2024-07-29 Thread Peter Maydell
On Mon, 29 Jul 2024 at 11:33, Cédric Le Goater wrote: > > On 7/26/24 01:53, Nicholas Piggin wrote: > > From: Chalapathi V > > > > In this commit SPI shift engine and sequencer logic is implemented. > > Shift engine performs serialization and de-serialization according to the > > control by the se

[PATCH v4 4/6] acpi/ghes: update comments to point to newer ACPI specs

2024-07-29 Thread Mauro Carvalho Chehab
There is one reference to ACPI 4.0 and several references to ACPI 6.x versions. Update them to point to ACPI 6.5 whenever possible. There's one reference that was kept pointing to ACPI 6.4, though, with HEST revision 1. ACPI 6.5 now defines HEST revision 2, and defined a new way to handle source

[PATCH v4 3/6] target/arm: preserve mpidr value

2024-07-29 Thread Mauro Carvalho Chehab
There is a logic at helper to properly fill the mpidr information. This is needed for ARM Processor error injection, so store the value inside a cpu opaque value, to allow it to be used. Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Jonathan Cameron --- target/arm/cpu.h| 1 + target/ar

[PATCH v4 5/6] acpi/ghes: Support GPIO error source.

2024-07-29 Thread Mauro Carvalho Chehab
From: Jonathan Cameron Add error notification to GHES v2 using the GPIO source. Signed-off-by: Jonathan Cameron Signed-off-by: Mauro Carvalho Chehab --- hw/acpi/ghes.c | 8 ++-- include/hw/acpi/ghes.h | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/acpi/gh

[PATCH v4 1/6] arm/virt: place power button pin number on a define

2024-07-29 Thread Mauro Carvalho Chehab
Having magic numbers inside the code is not a good idea, as it is error-prone. So, instead, create a macro with the number definition. Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Jonathan Cameron --- hw/arm/virt-acpi-build.c | 6 +++--- hw/arm/virt.c| 7 --- include/hw/arm

[PATCH v4 2/6] arm/virt: Wire up GPIO error source for ACPI / GHES

2024-07-29 Thread Mauro Carvalho Chehab
From: Jonathan Cameron Creates a Generic Event Device (GED) as specified at ACPI 6.5 specification at 18.3.2.7.2: https://uefi.org/specs/ACPI/6.5/18_Platform_Error_Interfaces.html#event-notification-for-generic-error-sources with HID PNP0C33. The PNP0C33 device is used to report hardware errors

[PATCH v4 0/6] Add ACPI CPER firmware first error injection for Arm Processor

2024-07-29 Thread Mauro Carvalho Chehab
Testing OS kernel ACPI APEI CPER support is tricky, as one depends on having hardware with special-purpose BIOS and/or hardware. With QEMU, it becomes a lot easier, as it can be done via QMP. This series add support for ARM Processor CPER error injection, according with ACPI 6.x and UEFI 2.9A/2.1

[PATCH v4 6/6] acpi/ghes: Add a logic to inject ARM processor CPER

2024-07-29 Thread Mauro Carvalho Chehab
Add an ACPI APEI GHES error injection logic for ARM processor CPER, allowing to set fields at from UEFI spec 2.10 tables N.16 and N.17 to any valid value. As some GHES functions require handling addresses, add a helper function to support it. Before starting erorr inject, the QAPI requires to neg

Re: [PATCH 02/13] tests/avocado: mips: add hint for fetchasset plugin

2024-07-29 Thread Philippe Mathieu-Daudé
On 26/7/24 15:44, Cleber Rosa wrote: Avocado's fetchasset plugin runs before the actual Avocado job (and any test). It analyses the test's code looking for occurrences of "self.fetch_asset()" in the either the actual test or setUp() method. It's not able to fully analyze all code, though. The w

Re: [PATCH v4 03/17] backends/igvm: Add IGVM loader and configuration

2024-07-29 Thread Stefano Garzarella
On Wed, Jul 03, 2024 at 12:05:41PM GMT, Roy Hopkins wrote: Adds an IGVM loader to QEMU which processes a given IGVM file and applies the directives within the file to the current guest configuration. The IGVM loader can be used to configure both confidential and non-confidential guests. For conf

Re: [PATCH] docs/sphinx/depfile.py: Handle env.doc2path() returning a Path not a str

2024-07-29 Thread Philippe Mathieu-Daudé
On 29/7/24 14:05, Peter Maydell wrote: In newer versions of Sphinx the env.doc2path() API is going to change to return a Path object rather than a str. This was originally visible in Sphinx 8.0.0rc1, but has been rolled back for the final 8.0.0 release. However it will probably emit a deprecation

Re: [PATCH v4 11/17] docs/system: Add documentation on support for IGVM

2024-07-29 Thread Stefano Garzarella
On Wed, Jul 03, 2024 at 12:05:49PM GMT, Roy Hopkins wrote: IGVM support has been implemented for Confidential Guests that support AMD SEV and AMD SEV-ES. Add some documentation that gives some background on the IGVM format and how to use it to configure a confidential guest. Signed-off-by: Roy H

Re: query dirty areas according to bitmap via QMP or qemu-nbd

2024-07-29 Thread Fiona Ebner
Am 26.07.24 um 17:38 schrieb Eric Blake: > On Fri, Jul 26, 2024 at 04:16:41PM GMT, Fiona Ebner wrote: >> Hi, >> >> sorry if I'm missing the obvious, but is there a way to get the dirty >> areas according to a dirty bitmap via QMP? I mean as something like >> offset + size + dirty-flag triples. In m

Re: [PATCH v5] osdep: add a qemu_close_all_open_fd() helper

2024-07-29 Thread Philippe Mathieu-Daudé
Hi Clément, On 26/7/24 09:54, Clément Léger wrote: Since commit 03e471c41d8b ("qemu_init: increase NOFILE soft limit on POSIX"), the maximum number of file descriptors that can be opened are raised to nofile.rlim_max. On recent debian distro, this yield a maximum of 1073741816 file descriptors.

Re: [PATCH v1 00/11] Convert avocado tests to normal Python unittests

2024-07-29 Thread Cleber Rosa
On Mon, Jul 29, 2024 at 8:44 AM Daniel P. Berrangé wrote: > > On Thu, Jul 25, 2024 at 10:21:54AM -0400, Cleber Rosa wrote: > > On Tue, Jul 16, 2024 at 7:28 AM Thomas Huth wrote: > > > There have been several attempts to update the test suite in QEMU > > > to a newer version of Avocado, but so far

Re: [PATCH v1] target/s390x: move @deprecated-props to CpuModelExpansion Info

2024-07-29 Thread Markus Armbruster
David Hildenbrand writes: > On 27.07.24 08:02, Markus Armbruster wrote: >> Collin Walling writes: >> >>> The @deprecated-props array did not make any sense to be a member of the >>> CpuModelInfo struct, since this field would only be populated by a >>> query-cpu-model-expansion response and ign

Re: [PATCH v5] osdep: add a qemu_close_all_open_fd() helper

2024-07-29 Thread Clément Léger
On 29/07/2024 16:00, Philippe Mathieu-Daudé wrote: > Hi Clément, > > On 26/7/24 09:54, Clément Léger wrote: >> Since commit 03e471c41d8b ("qemu_init: increase NOFILE soft limit on >> POSIX"), the maximum number of file descriptors that can be opened are >> raised to nofile.rlim_max. On recent d

Re: [PATCH v1] target/s390x: move @deprecated-props to CpuModelExpansion Info

2024-07-29 Thread David Hildenbrand
The simplest way to address 4 is to tack 'if': 'TARGET_S390X' to @deprecated-props. diff --git a/qapi/machine-target.json b/qapi/machine-target.json index 09dec2b9bb..0be95d559c 100644 --- a/qapi/machine-target.json +++ b/qapi/machine-target.json @@ -253,7 +253,7 @@ ## { 'struct': 'CpuMod

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Peter Xu
On Mon, Jul 29, 2024 at 01:45:12PM +0900, Akihiko Odaki wrote: > On 2024/07/29 12:50, Jason Wang wrote: > > On Sun, Jul 28, 2024 at 11:19 PM Akihiko Odaki > > wrote: > > > > > > On 2024/07/27 5:47, Peter Xu wrote: > > > > On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Berrangé wrote: > > >

Re: [PATCH v7] docs: add test for firmware.json QAPI

2024-07-29 Thread Philippe Mathieu-Daudé
On 24/7/24 14:45, Thomas Weißschuh wrote: To make sure that the QAPI description stays valid, add a testcase. Suggested-by: Philippe Mathieu-Daudé Link: https://lore.kernel.org/qemu-devel/d9ce0234-4beb-4b90-b14c-76810d3b8...@linaro.org/ Reviewed-by: Daniel P. Berrangé Acked-by: Markus Armbrus

Re: [PATCH v3 4/7] acpi/ghes: Add a logic to handle block addresses and FW first ARM processor error injection

2024-07-29 Thread Markus Armbruster
Mauro Carvalho Chehab writes: > Em Thu, 25 Jul 2024 11:48:12 +0200 > Markus Armbruster escreveu: > >> Mauro Carvalho Chehab writes: >> >> > From: Jonathan Cameron >> > >> > 1. Some GHES functions require handling addresses. Add a helper function >> >to support it. >> > >> > 2. Add support

Re: [PATCH v1] target/s390x: move @deprecated-props to CpuModelExpansion Info

2024-07-29 Thread Markus Armbruster
David Hildenbrand writes: The simplest way to address 4 is to tack 'if': 'TARGET_S390X' to @deprecated-props. >>> >>> diff --git a/qapi/machine-target.json b/qapi/machine-target.json >>> index 09dec2b9bb..0be95d559c 100644 >>> --- a/qapi/machine-target.json >>> +++ b/qapi/machine-t

Re: [PATCH 10/13] tests/avocado/tuxrun_baselines.py: use Avocado's zstd support

2024-07-29 Thread Philippe Mathieu-Daudé
On 26/7/24 15:44, Cleber Rosa wrote: Signed-off-by: Cleber Rosa --- tests/avocado/tuxrun_baselines.py | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/tests/avocado/tuxrun_baselines.py b/tests/avocado/tuxrun_baselines.py index 736e4aa289..bd02e88ed6 10064

Re: [PATCH 00/13] Bump Avocado to 103.0 LTS and update tests for compatibility and new features

2024-07-29 Thread Philippe Mathieu-Daudé
On 26/7/24 15:44, Cleber Rosa wrote: Cleber Rosa (13): tests/avocado: mips: fallback to HTTP given certificate expiration tests/avocado: mips: add hint for fetchasset plugin tests/avocado/intel_iommu.py: increase timeout tests/avocado: add cdrom permission related tests tests/avoc

Re: [PATCH] docs/sphinx/depfile.py: Handle env.doc2path() returning a Path not a str

2024-07-29 Thread Philippe Mathieu-Daudé
On 29/7/24 15:36, Philippe Mathieu-Daudé wrote: On 29/7/24 14:05, Peter Maydell wrote: In newer versions of Sphinx the env.doc2path() API is going to change to return a Path object rather than a str. This was originally visible in Sphinx 8.0.0rc1, but has been rolled back for the final 8.0.0 rel

[PATCH 00/14] Various fixes and tweaks for 9.1-rc0/1

2024-07-29 Thread Alex Bennée
As usual during soft freeze I switch to cleaning up the various niggles and bugs which have accumulated over the years. Aside from some test build tweaks and some useful tools for debugging CI failures I've also moved tests/plugin to tests/tcg/plugins to better align with contrib/plugins and clear

[PATCH 14/14] plugin/loader: handle basic help query

2024-07-29 Thread Alex Bennée
As the list of options isn't fixed we do all the parsing by hand. Without any named arguments we automatically fill the "file" option with the value give so check if it is requesting help and dump some basic usage text. Signed-off-by: Alex Bennée --- plugins/loader.c | 8 +++- 1 file changed

[PATCH 13/14] contrib/plugins: add compat for g_memdup2

2024-07-29 Thread Alex Bennée
We were premature if bumping this because some of our builds are still on older glibs. Just copy the compat handler for now and we can remove it later. Signed-off-by: Alex Bennée Fixes: ee293103b0 (plugins: update lockstep to use g_memdup2) Resolves: https://gitlab.com/qemu-project/qemu/-/issues/

[PATCH 04/14] tests/tcg/loongarch64: Use --no-warn-rwx-segments to link system tests

2024-07-29 Thread Alex Bennée
From: Richard Henderson Recent debian cross-linker for loongarch issues ld: warning: hello has a LOAD segment with RWX permissions This is partially related to tests/tcg/loongarch64/system/kernel.ld, but is not fixed by explicitly adding a single LOAD PHDR. Disable the warning, since it does

[PATCH 08/14] tests/avocado: remove tcg_plugins virt_mem_icount test

2024-07-29 Thread Alex Bennée
Since 4f8d886085 (tests/plugin/mem: migrate to new per_vcpu API) this test was skipping due to not being able to run callback and inline memory instrumentation at the same time. However b480f7a621 (tests/plugin: add test plugin for inline operations) tests for all this matching up so we don't need

Re: [PATCH v2 00/23] Convert avocado tests to normal Python unittests

2024-07-29 Thread Philippe Mathieu-Daudé
On 25/7/24 01:35, Richard Henderson wrote: On 7/25/24 03:52, Thomas Huth wrote: I'll say again that the download *must* be handled separately from the test with timeout. This is an absolute show-stopper. Queuing patches not related to assets downloading (1-6, 13, 15 and 23).

[PATCH 01/14] gitlab: record installed packages in /packages.txt in containers

2024-07-29 Thread Alex Bennée
From: Daniel P. Berrangé The lcitool created containers save the full distro package list details into /packages.txt. The idea is that build jobs will 'cat' this file, so that the build log has a record of what packages were used. This is important info, because when it comes to debug failures, t

[PATCH 06/14] docs/devel: update the testing introduction

2024-07-29 Thread Alex Bennée
Move the mention of "check-help" up to the intro text and also mention the meson test integration. Signed-off-by: Alex Bennée --- docs/devel/testing.rst | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst inde

  1   2   3   >