RE: [PATCH 00/13] make range overlap check more readable

2024-07-22 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Monday, July 22, 2024 2:43 PM > To: Yao, Xingtao/姚 幸涛 ; qemu-devel@nongnu.org > Subject: Re: [PATCH 00/13] make range overlap check more readable > > Hi Yao, > > On 22/7/24 06:07, Yao Xingtao via wrote: > > Currently, some com

[PULL 01/25] qga: drop blocking of guest-get-memory-block-size command

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé This command has never existed in tree, since it was renamed to guest-get-memory-block-info before being merged. Reviewed-by: Manos Pitsidianakis Reviewed-by: Konstantin Kostiuk Signed-off-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Message-ID: <202407

[PULL 00/25] Misc QEMU-GA patches 2024-07-22

2024-07-22 Thread Konstantin Kostiuk
The following changes since commit 23fa74974d8c96bc95cbecc0d4e2d90f984939f6: Merge tag 'pull-target-arm-20240718' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-07-19 07:02:17 +1000) are available in the Git repository at: https://github.com/kostyanf14/qemu.git tags/

[PULL 05/25] qga: move linux disk/cpu stats command impls to commands-linux.c

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé The qmp_guest_{diskstats,cpustats} command impls in commands-posix.c are surrounded by '#ifdef __linux__' so should instead live in commands-linux.c This also removes a "#ifdef CONFIG_LINUX" that was nested inside a "#ifdef __linux__". Reviewed-by: Philippe Mathieu-Daud

Re: [RFC PATCH] cxl: avoid duplicating report from MCE & device

2024-07-22 Thread Shiyang Ruan via
在 2024/7/20 0:04, Dave Jiang 写道: On 7/1/24 7:12 PM, Shiyang Ruan wrote: 在 2024/6/25 21:56, Shiyang Ruan 写道: 在 2024/6/22 1:51, Dan Williams 写道: Shiyang Ruan wrote: Background: Since CXL device is a memory device, while CPU consumes a poison page of CXL device, it always triggers a MCE

[PULL 02/25] qga: move linux vcpu command impls to commands-linux.c

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé The qmp_guest_set_vcpus and qmp_guest_get_vcpus command impls in commands-posix.c are surrounded by '#ifdef __linux__' so should instead live in commands-linux.c Reviewed-by: Manos Pitsidianakis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Konstantin Kostiuk Signe

[PULL 03/25] qga: move linux suspend command impls to commands-linux.c

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé The qmp_guest_suspend_{disk,ram,hybrid} command impls in commands-posix.c are surrounded by '#ifdef __linux__' so should instead live in commands-linux.c Reviewed-by: Manos Pitsidianakis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Konstantin Kostiuk Signed-off-by

[PULL 16/25] qga: conditionalize schema for commands requiring utmpx

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé Rather than creating stubs for every command that just return QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to fully exclude generation of the get-users command on POSIX platforms lacking required APIs. The command will be rejected at QMP dispatch time instead

[PULL 13/25] qga: conditionalize schema for commands requiring fsfreeze

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé Rather than creating stubs for every command that just return QERR_UNSUPPORTED, use 'if' conditions in the schema to fully exclude generation of the filesystem freezing commands on POSIX platforms lacking the required APIs. The command will be rejected at QMP dispatch ti

[PULL 04/25] qga: move linux fs/disk command impls to commands-linux.c

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé The qmp_guest_{fstrim, get_fsinfo, get_disks} command impls in commands-posix.c are surrounded by '#ifdef __linux__' so should instead live in commands-linux.c Reviewed-by: Manos Pitsidianakis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Konstantin Kostiuk Signed-

[PULL 19/25] qga: move declare of QGAConfig struct to top of file

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé It is referenced by QGAState already, and it is clearer to declare all data types at the top of the file, rather than have them mixed with code later. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Konstantin Kostiuk Signed-off-by: Daniel P. Berrangé Reviewed-by: Ma

[PULL 24/25] guest-agent: document allow-rpcs in config file section

2024-07-22 Thread Konstantin Kostiuk
From: Thomas Lamprecht While the `allow-rpcs` option is documented in the CLI options section, it was missing in the section about the configuration file syntax. And while it's mentioned that "the list of keys follows the command line options", having `block-rpcs` there but not `allow-rpcs` seem

[PULL 09/25] qga: conditionalize schema for commands unsupported on non-Linux POSIX

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé Rather than creating stubs for every command that just return QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to fully exclude generation of the commands on non-Linux POSIX platforms The command will be rejected at QMP dispatch time instead, avoiding reimplement

[PULL 12/25] qga: conditionalize schema for commands only supported on Windows

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé Rather than creating stubs for every command that just return QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to fully exclude generation of the commands on non-Windows. The command will be rejected at QMP dispatch time instead, avoiding reimplementing rejection

[PULL 14/25] qga: conditionalize schema for commands requiring fstrim

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé Rather than creating stubs for every command that just return QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to fully exclude generation of the filesystem trimming commands on POSIX platforms lacking required APIs. The command will be rejected at QMP dispatch t

[PULL 10/25] qga: conditionalize schema for commands requiring getifaddrs

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé Rather than creating stubs for every comamnd that just return QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to fully exclude generation of the network interface command on POSIX platforms lacking getifaddrs(). The command will be rejected at QMP dispatch time

Re: [PATCH 12/13] dump: make range overlap check more readable

2024-07-22 Thread Marc-André Lureau
On Mon, Jul 22, 2024 at 8:10 AM Yao Xingtao wrote: > use ranges_overlap() instead of open-coding the overlap check to improve > the readability of the code. > > Signed-off-by: Yao Xingtao > Reviewed-by: Marc-André Lureau > --- > dump/dump.c | 12 > 1 file changed, 8 insertions(

[PULL 25/25] qga/linux: Add new api 'guest-network-get-route'

2024-07-22 Thread Konstantin Kostiuk
From: Dehan Meng The Route information of the Linux VM needs to be used by administrators and users when debugging network problems and troubleshooting. Signed-off-by: Dehan Meng Reviewed-by: Konstantin Kostiuk Message-ID: <20240613092802.346246-2-dem...@redhat.com> Signed-off-by: Konstantin K

[PULL 17/25] qga: conditionalize schema for commands not supported on other UNIX

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé Rather than creating stubs for every command that just return QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to fully exclude generation of the commands on other UNIX. The command will be rejected at QMP dispatch time instead, avoiding reimplementing rejection

[PULL 11/25] qga: conditionalize schema for commands requiring linux/win32

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé Some commands were blocked based on CONFIG_FSFREEZE, but their impl had nothing todo with CONFIG_FSFREEZE, and were instead either Linux-only, or Win+Linux-only. Rather than creating stubs for every command that just return QERR_UNSUPPORTED, use 'if' conditions in the QA

[PULL 07/25] qga: move CONFIG_FSFREEZE/TRIM to be meson defined options

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé Defining these at the meson level allows them to be used a conditional tests in the QAPI schemas. Signed-off-by: Daniel P. Berrangé Reviewed-by: Konstantin Kostiuk Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240712132459.3974109-8-berra...@redhat.com> Signed-of

[PULL 18/25] qga: don't disable fsfreeze commands if vss_init fails

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé The fsfreeze commands are already written to report an error if vss_init() fails. Reporting a more specific error message is more helpful than a generic "command is disabled" message, which cannot between an admin config decision and lack of platform support. Reviewed-by

[PULL 21/25] qga: allow configuration file path via the cli

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé Allowing the user to set the QGA_CONF environment variable to change the default configuration file path is very unusual practice, made more obscure since this ability is not documented. This introduces the more normal '-c PATH' / '--config=PATH' command line argument a

[PULL 15/25] qga: conditionalize schema for commands requiring libudev

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé Rather than creating stubs for every command that just return QERR_UNSUPPORTED, use 'if' conditions in the schema to fully exclude generation of the filesystem trimming commands on POSIX platforms lacking required APIs. The command will be rejected at QMP dispatch time i

[PULL 23/25] qga/commands-posix: Make ga_wait_child() return boolean

2024-07-22 Thread Konstantin Kostiuk
From: Zhao Liu Make ga_wait_child() return boolean and check the returned boolean in ga_run_command() instead of dereferencing @errp. Cc: Michael Roth Cc: Konstantin Kostiuk Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Zhao Liu Reviewed-by: Konstantin Kostiuk Message-ID: <202407161623

[PULL 06/25] qga: move linux memory block command impls to commands-linux.c

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé The qmp_guest_{set,get}_{memory_blocks,block_info} command impls in commands-posix.c are surrounded by '#ifdef __linux__' so should instead live in commands-linux.c This also removes a "#ifdef CONFIG_LINUX" that was nested inside a "#ifdef __linux__". Reviewed-by: Phili

[PULL 22/25] qga: centralize logic for disabling/enabling commands

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé It is confusing having many different pieces of code enabling and disabling commands, and it is not clear that they all have the same semantics, especially wrt prioritization of the block/allow lists. The code attempted to prevent the user from setting both the block and

[PULL 08/25] qga: conditionalize schema for commands unsupported on Windows

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé Rather than creating stubs for every command that just return QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to fully exclude generation of the commands on Windows. The command will be rejected at QMP dispatch time instead, avoiding reimplementing rejection by

[PULL 20/25] qga: remove pointless 'blockrpcs_key' variable

2024-07-22 Thread Konstantin Kostiuk
From: Daniel P. Berrangé This variable was used to support back compat for the old config file key name, and became redundant after the following change: commit a7a2d636ae4549ef0551134d4bf8e084a14431c4 Author: Philippe Mathieu-Daudé Date: Thu May 30 08:36:43 2024 +0200 qga: Remove

Re: [PATCH] chardev/char-win-stdio.c: restore old console mode

2024-07-22 Thread Marc-André Lureau
Hi On Mon, Jul 22, 2024 at 12:01 AM songziming wrote: > If I use `-serial stdio` on Windows, after QEMU exits, the terminal > could not handle arrow keys and tab any more. Because stdio backend > on Windows sets console mode to virtual terminal input when starts, > but does not restore the old m

[PATCH 0/2] Don't initialize HOST_IOMMU_DEVICE with mdev

2024-07-22 Thread Zhenzhong Duan
This fixes a potential issue with mdev that fails to initialize HOST_IOMMU_DEVICE. Reason is mdev isn't physical device and doesn't support IOMMU_GET_HW_INFO. I thought ap/ccw are all mdev type and need a fix. This series depends on a patch from Joao which fixes the same for vfio-pci. See https:

[PATCH 1/2] vfio/ap: Don't initialize HOST_IOMMU_DEVICE with mdev

2024-07-22 Thread Zhenzhong Duan
mdevs aren't "physical" devices and when asking for backing IOMMU info, it fails the entire provisioning of the guest. Fix that by setting vbasedev->mdev true so skipping HostIOMMUDevice initialization in the presence of mdevs. Fixes: 930589520128 ("vfio/iommufd: Implement HostIOMMUDeviceClass::re

[PATCH 2/2] vfio/ccw: Don't initialize HOST_IOMMU_DEVICE with mdev

2024-07-22 Thread Zhenzhong Duan
mdevs aren't "physical" devices and when asking for backing IOMMU info, it fails the entire provisioning of the guest. Fix that by setting vbasedev->mdev true so skipping HostIOMMUDevice initialization in the presence of mdevs. Fixes: 930589520128 ("vfio/iommufd: Implement HostIOMMUDeviceClass::re

Re: [PATCH 07/13] qtest/fuzz: make range overlap check more readable

2024-07-22 Thread Philippe Mathieu-Daudé
On 22/7/24 06:07, Yao Xingtao via wrote: use ranges_overlap() instead of open-coding the overlap check to improve the readability of the code. Signed-off-by: Yao Xingtao --- tests/qtest/fuzz/generic_fuzz.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathie

Re: [PATCH 06/13] aspeed_smc: make range overlap check more readable

2024-07-22 Thread Philippe Mathieu-Daudé
On 22/7/24 06:07, Yao Xingtao via wrote: use ranges_overlap() instead of open-coding the overlap check to improve the readability of the code. Signed-off-by: Yao Xingtao --- hw/ssi/aspeed_smc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé T

Re: [PATCH 11/13] crypto/block-luks: make range overlap check more readable

2024-07-22 Thread Philippe Mathieu-Daudé
On 22/7/24 06:07, Yao Xingtao via wrote: use ranges_overlap() instead of open-coding the overlap check to improve the readability of the code. Signed-off-by: Yao Xingtao --- crypto/block-luks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé Tes

Re: [PATCH 0/8] Introduce SMP Cache Topology

2024-07-22 Thread Zhao Liu
Hi Daniel and Markus, A gentle ping. Would you kindly have a look at this version of the API design? If it could meet your satisfaction, I’ll continue iterating. Thanks, Zhao On Thu, Jul 04, 2024 at 11:15:55AM +0800, Zhao Liu wrote: > Date: Thu, 4 Jul 2024 11:15:55 +0800 > From: Zhao Liu > Subj

Re: [PULL 06/27] iotests/{024, 271}: add testcases for qemu-img rebase

2024-07-22 Thread Thomas Huth
On 31/10/2023 19.58, Kevin Wolf wrote: From: Andrey Drobyshev As the previous commit changes the logic of "qemu-img rebase" (it's using write alignment now), let's add a couple more test cases which would ensure it works correctly. In particular, the following scenarios: 024: add test case fo

Re: [PATCH 09/13] system/memory_mapping: make range overlap check more readable

2024-07-22 Thread Philippe Mathieu-Daudé
On 22/7/24 06:07, Yao Xingtao wrote: use ranges_overlap() instead of open-coding the overlap check to improve the readability of the code. Signed-off-by: Yao Xingtao --- system/memory_mapping.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/system/memory_mapping.c b/

Re: [PATCH v5] virtio-pci: Fix the use of an uninitialized irqfd

2024-07-22 Thread Jason Wang
Hi Cindy On Fri, Jul 19, 2024 at 1:25 PM Cindy Lu wrote: > > The crash was reported in MAC OS and NixOS, here is the link for this bug > https://gitlab.com/qemu-project/qemu/-/issues/2334 > https://gitlab.com/qemu-project/qemu/-/issues/2321 > > In this bug, they are using the virtio_input device.

Re: [PATCH] tests: increase timeout per instance of bios-tables-test

2024-07-22 Thread Thomas Huth
On 16/07/2024 14.59, Igor Mammedov wrote: CI often fails 'cross-i686-tci' job due to runner slowness Log shows that test almost complete, with a few remaining when bios-tables-test timeout hits: 19/270 qemu:qtest+qtest-aarch64 / qtest-aarch64/bios-tables-test TIMEOUT610.02s kil

Re: [PATCH 00/13] make range overlap check more readable

2024-07-22 Thread Philippe Mathieu-Daudé
On 22/7/24 08:59, Xingtao Yao (Fujitsu) wrote: -Original Message- From: Philippe Mathieu-Daudé Sent: Monday, July 22, 2024 2:43 PM To: Yao, Xingtao/姚 幸涛 ; qemu-devel@nongnu.org Subject: Re: [PATCH 00/13] make range overlap check more readable Hi Yao, On 22/7/24 06:07, Yao Xingtao vi

RE: [PATCH 00/13] make range overlap check more readable

2024-07-22 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Monday, July 22, 2024 3:37 PM > To: Yao, Xingtao/姚 幸涛 ; qemu-devel@nongnu.org > Subject: Re: [PATCH 00/13] make range overlap check more readable > > On 22/7/24 08:59, Xingtao Yao (Fujitsu) wrote: > > > > > >> -Original Mes

Re: [PATCH] tests: increase timeout per instance of bios-tables-test

2024-07-22 Thread Michael S. Tsirkin
On Mon, Jul 22, 2024 at 09:35:17AM +0200, Thomas Huth wrote: > On 16/07/2024 14.59, Igor Mammedov wrote: > > CI often fails 'cross-i686-tci' job due to runner slowness > > Log shows that test almost complete, with a few remaining > > when bios-tables-test timeout hits: > > > >19/270 qemu:qtest

Re: [PATCH 0/8] Introduce SMP Cache Topology

2024-07-22 Thread Michael S. Tsirkin
On Mon, Jul 22, 2024 at 03:33:37PM +0800, Zhao Liu wrote: > Hi Daniel and Markus, > > A gentle ping. Would you kindly have a look at this version of the API > design? If it could meet your satisfaction, I’ll continue iterating. > > Thanks, > Zhao I'm not really a QMP guy, you want Markus. --

Re: [PATCH 11/13] crypto/block-luks: make range overlap check more readable

2024-07-22 Thread Daniel P . Berrangé
On Mon, Jul 22, 2024 at 12:07:40AM -0400, Yao Xingtao wrote: > use ranges_overlap() instead of open-coding the overlap check to improve > the readability of the code. > > Signed-off-by: Yao Xingtao > --- > crypto/block-luks.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by

Re: [PATCH] hw/i2c/mpc_i2c.c: Fix mmio region size

2024-07-22 Thread Philippe Mathieu-Daudé
+Amit & Andrew On 22/7/24 00:55, BALATON Zoltan wrote: The last register of this device is at offset 0x14 occupying 8 bits so to cover it the mmio region needs to be 0x15 bytes long. Also correct the name of the field storing this register value to match the register name. Signed-off-by: BALATO

Re: [PATCH 1/2] util/getauxval: Ensure setting errno if not found

2024-07-22 Thread Vivian Wang
On 7/22/24 08:18, Xingtao Yao (Fujitsu) wrote: > >> -Original Message- >> From: qemu-devel-bounces+yaoxt.fnst=fujitsu@nongnu.org >> On Behalf Of Vivian >> Wang >> Sent: Sunday, July 21, 2024 5:08 PM >> To: qemu-devel@nongnu.org >> Cc: Vivian Wang ; Richard Henderson ; >> Laurent Vivier

Re: [PATCH qemu] ui/gtk: Reuse input event slots for GdkEventTouch

2024-07-22 Thread Marc-André Lureau
Hi Adding Sergio in CC, who wrote that code. I don't have means to test it, which also limits my understanding and ability to check this. On Sat, Jul 20, 2024 at 11:58 PM ~katharine_chui wrote: > From: Katharine Chui > > There seems to be no guarantee as to how GdkEventTouch.sequence > would p

Re: [PATCH v5] virtio-pci: Fix the use of an uninitialized irqfd

2024-07-22 Thread Cindy Lu
On Mon, 22 Jul 2024 at 15:24, Jason Wang wrote: > > Hi Cindy > > On Fri, Jul 19, 2024 at 1:25 PM Cindy Lu wrote: > > > > The crash was reported in MAC OS and NixOS, here is the link for this bug > > https://gitlab.com/qemu-project/qemu/-/issues/2334 > > https://gitlab.com/qemu-project/qemu/-/issu

Re: [PATCH v3] chardev: add path option for pty backend

2024-07-22 Thread Marc-André Lureau
Hi Octavian, You should send a new version with the changes requested by Markus. (we might miss 9.1 though) On Thu, Jul 18, 2024 at 1:48 PM Markus Armbruster wrote: > Peter Maydell writes: > > > On Thu, 18 Jul 2024 at 07:15, Markus Armbruster > wrote: > >> > >> Looks like this one fell throug

Re: [PATCH v5 05/13] vfio/iommufd: Introduce auto domain creation

2024-07-22 Thread Joao Martins
On 22/07/2024 06:16, Duan, Zhenzhong wrote: >> -Original Message- >> From: Joao Martins >> Subject: [PATCH v5 05/13] vfio/iommufd: Introduce auto domain creation >> >> There's generally two modes of operation for IOMMUFD: >> >> 1) The simple user API which intends to perform relatively sim

Re: [PATCH v5 06/13] vfio/{iommufd,container}: Remove caps::aw_bits

2024-07-22 Thread Joao Martins
On 22/07/2024 06:22, Duan, Zhenzhong wrote: > > >> -Original Message- >> From: Joao Martins >> Subject: [PATCH v5 06/13] vfio/{iommufd,container}: Remove caps::aw_bits >> >> Remove caps::aw_bits which requires the bcontainer::iova_ranges being >> initialized after device is actually atta

[PATCH] tests/avocado/machine_aspeed.py: Increase timeout for TPM test

2024-07-22 Thread Cédric Le Goater
On some runners, test_arm_ast2600_evb_buildroot_tpm can take longer than 90s to complete. Increase timeout for these. Reported-by: Thomas Huth Signed-off-by: Cédric Le Goater --- tests/avocado/machine_aspeed.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/avocado/ma

Re: [PATCH V2 00/11] Live update: cpr-exec

2024-07-22 Thread David Hildenbrand
On 18.07.24 17:56, Peter Xu wrote: Steve, On Sun, Jun 30, 2024 at 12:40:23PM -0700, Steve Sistare wrote: What? Thanks for trying out with the cpr-transfer series. I saw that that series missed most of the cc list here, so I'm attaching the link here: https://lore.kernel.org/r/1719776648-435

Re: [PATCH] tests/avocado/machine_aspeed.py: Increase timeout for TPM test

2024-07-22 Thread Thomas Huth
On 22/07/2024 10.55, Cédric Le Goater wrote: On some runners, test_arm_ast2600_evb_buildroot_tpm can take longer than 90s to complete. Increase timeout for these. Reported-by: Thomas Huth Signed-off-by: Cédric Le Goater --- tests/avocado/machine_aspeed.py | 2 +- 1 file changed, 1 insertion

Re: [PATCH V2 01/11] machine: alloc-anon option

2024-07-22 Thread David Hildenbrand
On 20.07.24 22:28, Steven Sistare wrote: On 7/16/2024 5:19 AM, Igor Mammedov wrote: On Sun, 30 Jun 2024 12:40:24 -0700 Steve Sistare wrote: Allocate anonymous memory using mmap MAP_ANON or memfd_create depending on the value of the anon-alloc machine property. This affects memory-backend-ram

Re: [PATCH v5 09/13] vfio/iommufd: Probe and request hwpt dirty tracking capability

2024-07-22 Thread Joao Martins
On 22/07/2024 07:05, Duan, Zhenzhong wrote: > > >> -Original Message- >> From: Joao Martins >> Subject: [PATCH v5 09/13] vfio/iommufd: Probe and request hwpt dirty >> tracking capability >> >> In preparation to using the dirty tracking UAPI, probe whether the IOMMU >> supports dirty trac

Re: [PATCH 09/13] system/memory_mapping: make range overlap check more readable

2024-07-22 Thread David Hildenbrand
On 22.07.24 06:07, Yao Xingtao wrote: use ranges_overlap() instead of open-coding the overlap check to improve the readability of the code. Signed-off-by: Yao Xingtao --- system/memory_mapping.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/system/memory_mapping.c b

[PATCH 2/2] nvme/ctrl: remove useless type cast

2024-07-22 Thread Yao Xingtao via
The type of req->cmd is NvmeCmd, cast the pointer of this type to NvmeCmd* is useless. Signed-off-by: Yao Xingtao --- hw/nvme/ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 5b1b0cabcfc3..221818f551cd 100644 --- a/hw/nvme/ctrl.c ++

[PATCH 0/2] remove useless type cast

2024-07-22 Thread Yao Xingtao via
Currently the pattern in scripts/coccinelle/typecast.cocci is used to remove the useless type cast. Use the following command to find out the use cases and remove the useless type case: $ spatch --macro-file scripts/cocci-macro-file.h \ --sp-file ./scripts/coccinelle/typecast.cocci \

Re: [PATCH v5 0/5] Power11 support for QEMU [PSeries]

2024-07-22 Thread Aditya Gupta
Any comments on this ? This series is containing only the pseries support for Power11, hence independent of skiboot patches. powernv is on hold till skiboot changes are released. Thanks, Aditya Gupta On 06/06/24 17:46, Aditya Gupta wrote: Overview Split "Power11 support for

[PATCH] chardev/char-win-stdio.c: restore old console mode

2024-07-22 Thread songziming
Hi I've updated the patch. Now it only reset mode if handle is valid. Signed-off-by: Ziming Song --- chardev/char-win-stdio.c | 5 + 1 file changed, 5 insertions(+) diff --git a/chardev/char-win-stdio.c b/chardev/char-win-stdio.c index 1a18999..13325ca 100644 --- a/chardev/char-win-stdio

[PATCH 1/2] mips/loongson3_virt: remove useless type cast

2024-07-22 Thread Yao Xingtao via
The type of kernel_entry, kernel_low and kernel_high is uint64_t, cast the pointer of this type to uint64_t* is useless. Signed-off-by: Yao Xingtao --- hw/mips/loongson3_virt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/mips/loongson3_virt.c b/hw/mips/loongson3_vi

Re: [PATCH 2/2] vfio/ccw: Don't initialize HOST_IOMMU_DEVICE with mdev

2024-07-22 Thread Joao Martins
On 22/07/2024 08:07, Zhenzhong Duan wrote: > mdevs aren't "physical" devices and when asking for backing IOMMU info, > it fails the entire provisioning of the guest. Fix that by setting > vbasedev->mdev true so skipping HostIOMMUDevice initialization in the > presence of mdevs. > > Fixes: 93058952

Re: [PATCH 1/2] vfio/ap: Don't initialize HOST_IOMMU_DEVICE with mdev

2024-07-22 Thread Joao Martins
On 22/07/2024 08:07, Zhenzhong Duan wrote: > mdevs aren't "physical" devices and when asking for backing IOMMU info, > it fails the entire provisioning of the guest. Fix that by setting > vbasedev->mdev true so skipping HostIOMMUDevice initialization in the > presence of mdevs. > > Fixes: 93058952

Re: [PATCH] ppc/pnv: Update Power10's cfam id to use Power10 DD2

2024-07-22 Thread Aditya Gupta
Hello, Any comments on this change ? Though this isn't urgent and won't change behaviour much, mainly other than skiboot recognising the chip as P10 DD2. Thanks - Aditya Gupta On 02/05/24 13:51, Cédric Le Goater wrote: On 5/2/24 08:27, Aditya Gupta wrote: Power10 DD1.0 was dropped in:

RE: [PATCH 1/2] util/getauxval: Ensure setting errno if not found

2024-07-22 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: Vivian Wang > Sent: Monday, July 22, 2024 4:24 PM > To: Yao, Xingtao/姚 幸涛 ; qemu-devel@nongnu.org > Cc: Richard Henderson ; Laurent Vivier > Subject: Re: [PATCH 1/2] util/getauxval: Ensure setting errno if not found > > On 7/22/24 08:18, Xingtao Yao (Fujits

Re: [PATCH] chardev/char-win-stdio.c: restore old console mode

2024-07-22 Thread Marc-André Lureau
On Mon, Jul 22, 2024 at 1:19 PM songziming wrote: > Hi > > I've updated the patch. > > Now it only reset mode if handle is valid. > > you lost the commit message, and the subject does not' have a version tag (see https://www.qemu.org/docs/master/devel/submitting-a-patch.html#when-resending-patche

Re: [PATCH 0/2] Don't initialize HOST_IOMMU_DEVICE with mdev

2024-07-22 Thread Eric Auger
Hi Zhenzhong, On 7/22/24 09:07, Zhenzhong Duan wrote: > This fixes a potential issue with mdev that fails to initialize > HOST_IOMMU_DEVICE. > Reason is mdev isn't physical device and doesn't support IOMMU_GET_HW_INFO. > > I thought ap/ccw are all mdev type and need a fix. > > This series depends

Re: [PULL 21/26] hw/arm/smmu: Refactor SMMU OAS

2024-07-22 Thread Peter Maydell
On Sat, 20 Jul 2024 at 23:07, Mostafa Saleh wrote: > > Hi Peter, > > On Sat, Jul 20, 2024 at 04:05:40PM +0100, Peter Maydell wrote: > > On Thu, 18 Jul 2024 at 14:20, Peter Maydell > > wrote: > > > > > > From: Mostafa Saleh > > > > > > SMMUv3 OAS is currently hardcoded in the code to 44 bits, fo

Re: [PATCH v5 00/18] SMMUv3 nested translation support

2024-07-22 Thread Peter Maydell
On Sat, 20 Jul 2024 at 23:11, Mostafa Saleh wrote: > > Hi Peter, > > On Fri, Jul 19, 2024 at 04:57:18PM +0100, Peter Maydell wrote: > > On Fri, 19 Jul 2024 at 16:36, Julien Grall wrote: > > > > > > Hi, > > > > > > On 18/07/2024 10:43, Julien Grall wrote: > > > > Hi Eric, > > > > > > > > On 17/07/

Re: [PATCH qemu] [hw/char/bcm2835_aux] Fix receive FIFO filling up (raspi3)

2024-07-22 Thread Peter Maydell
[Added missing cc of qemu-devel] On Mon, 22 Jul 2024 at 07:33, Philippe Mathieu-Daudé wrote: > > On 21/7/24 18:13, ~fvanhovell wrote: > > From: Frederik van Hövell > > > > When a bare-metal application on the raspi3 board reads the > > AUX_MU_STAT_REG MMIO register while the device's buffer is >

Re: [RFC PATCH v4 2/2] tests/qtest: QTest example for RISC-V CSR register

2024-07-22 Thread Thomas Huth
On 03/07/2024 10.19, Ivan Klokov wrote: Added demo for reading CSR register from qtest environment. Signed-off-by: Ivan Klokov --- tests/qtest/meson.build | 2 + tests/qtest/riscv-csr-test.c | 86 2 files changed, 88 insertions(+) create mode 100

Re: [PATCH] tests: increase timeout per instance of bios-tables-test

2024-07-22 Thread Igor Mammedov
On Mon, 22 Jul 2024 09:35:17 +0200 Thomas Huth wrote: > On 16/07/2024 14.59, Igor Mammedov wrote: > > CI often fails 'cross-i686-tci' job due to runner slowness > > Log shows that test almost complete, with a few remaining > > when bios-tables-test timeout hits: > > > >19/270 qemu:qtest+qtes

Re: [RFC PATCH v4 1/2] target/riscv: Add RISC-V CSR qtest support

2024-07-22 Thread Thomas Huth
On 03/07/2024 10.19, Ivan Klokov wrote: The RISC-V architecture supports the creation of custom CSR-mapped devices. It would be convenient to test them in the same way as MMIO-mapped devices. To do this, a new call has been added to read/write CSR registers. Signed-off-by: Ivan Klokov --- tar

Re: [PATCH 0/2] Don't initialize HOST_IOMMU_DEVICE with mdev

2024-07-22 Thread Cédric Le Goater
On 7/22/24 09:07, Zhenzhong Duan wrote: This fixes a potential issue with mdev that fails to initialize HOST_IOMMU_DEVICE. Reason is mdev isn't physical device and doesn't support IOMMU_GET_HW_INFO. I thought ap/ccw are all mdev type and need a fix. This series depends on a patch from Joao whi

[PATCH v2] chardev/char-win-stdio.c: restore old console mode

2024-07-22 Thread songziming
If I use `-serial stdio` on Windows, after QEMU exits, the terminal could not handle arrow keys and tab any more. Because stdio backend on Windows sets console mode to virtual terminal input when starts, but does not restore the old mode when finalize. This small patch saves the old console mode a

Re: [PATCH] hw/i2c/mpc_i2c.c: Fix mmio region size

2024-07-22 Thread BALATON Zoltan
On Mon, 22 Jul 2024, Philippe Mathieu-Daudé wrote: +Amit & Andrew On 22/7/24 00:55, BALATON Zoltan wrote: The last register of this device is at offset 0x14 occupying 8 bits so to cover it the mmio region needs to be 0x15 bytes long. Also correct the name of the field storing this register valu

[PATCH] target/i386: Always set leaf 0x1f

2024-07-22 Thread manish.mishra
QEMU does not set 0x1f in case VM does not have extended CPU topology and expects guests to fallback to 0xb. Some versions of windows i.e. windows 10, 11 does not like this behavior and expects this leaf to be populated. This is observed with windows VMs with secure boot, uefi and HyperV role enabl

[PATCH] hw/arm/smmuv3: Assert input to oas2bits() is valid

2024-07-22 Thread Mostafa Saleh
Coverity has spotted a possible problem with the OAS handling (CID 1558464), where the error return of oas2bits() -1 is not checked, which can cause an overflow in oas value. oas2bits() is only called with valid inputs, harden the function to assert that. Reported-By: Peter Maydell Link: https:

Re: [PATCH] hw/arm/smmuv3: Assert input to oas2bits() is valid

2024-07-22 Thread Philippe Mathieu-Daudé
On 22/7/24 12:35, Mostafa Saleh wrote: Coverity has spotted a possible problem with the OAS handling (CID 1558464), where the error return of oas2bits() -1 is not checked, which can cause an overflow in oas value. oas2bits() is only called with valid inputs, harden the function to assert that.

Re: [PATCH 3/3] util/fifo8: Introduce fifo8_change_capacity()

2024-07-22 Thread Philippe Mathieu-Daudé
On 19/7/24 22:21, Mark Cave-Ayland wrote: On 19/07/2024 16:16, Philippe Mathieu-Daudé wrote: FIFOs can be resized at runtime. Introduce the fifo8_change_capacity() method to do that. When capacity is changed, the FIFO must be reset. Signed-off-by: Philippe Mathieu-Daudé ---   include/qemu/fif

Re: [PATCH] hw/arm/smmuv3: Assert input to oas2bits() is valid

2024-07-22 Thread Eric Auger
On 7/22/24 12:35, Mostafa Saleh wrote: > Coverity has spotted a possible problem with the OAS handling > (CID 1558464), where the error return of oas2bits() -1 is not > checked, which can cause an overflow in oas value. > > oas2bits() is only called with valid inputs, harden the function > to as

[PULL 01/16] testing: bump to latest libvirt-ci

2024-07-22 Thread Alex Bennée
This brings in the latest python mappings for the BSD updates. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20240718094523.1198645-2-alex.ben...@linaro.org> diff --git a/.gitlab-ci.d/cirrus/freebsd-13.vars b/.gitlab-ci.d/cirrus/freebsd-13.vars index 3785afca36..2

[PULL 04/16] plugins/stoptrigger: TCG plugin to stop execution under conditions

2024-07-22 Thread Alex Bennée
From: Simon Hamelin This new plugin allows to stop emulation using conditions on the emulation state. By setting this plugin arguments, it is possible to set an instruction count limit and/or trigger address(es) to stop at. The code returned at emulation exit can be customized. This plugin demon

[PULL 05/16] plugins: fix mem callback array size

2024-07-22 Thread Alex Bennée
From: Pierrick Bouvier data was correctly copied, but size of array was not set (g_array_sized_new only reserves memory, but does not set size). As a result, callbacks were not called for code path relying on plugin_register_vcpu_mem_cb(). Found when trying to trigger mem access callbacks for a

[PULL 07/16] plugins/execlog.c: correct dump of registers values

2024-07-22 Thread Alex Bennée
From: Frédéric Pétrot Register values are dumped as 'sz' chunks of two nibbles in the execlog plugin, sz was 1 too big. Signed-off-by: Frédéric Pétrot Reviewed-by: Pierrick Bouvier Message-Id: <20240620083805.73603-1-frederic.pet...@univ-grenoble-alpes.fr> Signed-off-by: Alex Bennée Message-I

[PULL 09/16] target/m68k: Add semihosting stub

2024-07-22 Thread Alex Bennée
From: Philippe Mathieu-Daudé Since the SEMIHOSTING feature is optional, we need a stub to link when it is disabled. Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20240717105723.58965-3-phi...@linaro.org> Signed-off-by: Alex Bennée Message-Id: <20240718094523.1

[PULL 02/16] tests/avocado: Remove non-working sparc leon3 test

2024-07-22 Thread Alex Bennée
From: Thomas Huth The test has been marked as broken more than 4 years ago, and so far nobody ever cared to fix it. Thus let's simply remove it now ... if somebody ever needs it again, they can restore the file from an older version of QEMU. Signed-off-by: Thomas Huth Reviewed-by: Clément Chigo

[PULL 15/16] semihosting: Restrict to TCG

2024-07-22 Thread Alex Bennée
From: Philippe Mathieu-Daudé Semihosting currently uses the TCG probe_access API. It is pointless to have it in the binary when TCG isn't. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20240717105723.58965-9-phi...@linaro.org> Signed-off-by: Alex Bennée Mes

[PULL 12/16] target/mips: Restrict semihosting to TCG

2024-07-22 Thread Alex Bennée
From: Philippe Mathieu-Daudé Semihosting currently uses the TCG probe_access API. To prepare for encoding the TCG dependency in Kconfig, do not enable it unless TCG is available. Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Anton Johansson Message-Id: <202407

[PULL 10/16] target/mips: Add semihosting stub

2024-07-22 Thread Alex Bennée
From: Philippe Mathieu-Daudé Since the SEMIHOSTING feature is optional, we need a stub to link when it is disabled. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20240717105723.58965-4-phi...@linaro.org> Signed-off-by: Alex Bennée Message-Id: <20240718094523.1198645-11-alex.ben...@linaro.

[PULL 03/16] gdbstub: Re-factor gdb command extensions

2024-07-22 Thread Alex Bennée
Coverity reported a memory leak (CID 1549757) in this code and its admittedly rather clumsy handling of extending the command table. Instead of handing over a full array of the commands lets use the lighter weight GPtrArray and simply test for the presence of each entry as we go. This avoids compli

[PULL 08/16] semihosting: Include missing 'gdbstub/syscalls.h' header

2024-07-22 Thread Alex Bennée
From: Philippe Mathieu-Daudé "semihosting/syscalls.h" requires definitions from "gdbstub/syscalls.h", include it in order to avoid: include/semihosting/syscalls.h:23:38: error: unknown type name 'gdb_syscall_complete_cb' void semihost_sys_open(CPUState *cs, gdb_syscall_complete_cb complete,

[PULL 11/16] target/m68k: Restrict semihosting to TCG

2024-07-22 Thread Alex Bennée
From: Philippe Mathieu-Daudé The semihosting feature depends on TCG (due to the probe_access API access). Although TCG is the single accelerator currently available for the m68k target, use the Kconfig "imply" directive which is more correct (if we were to support a different accel). Reported-by

[PULL 00/16] Final bits for 9.1-rc0 (docker, plugins, gdbstub, semihosting)

2024-07-22 Thread Alex Bennée
warn: No match for commit c135d5eaafe7aa2533da663d8e5a34a424b71eb9 found at https://gitlab.com/stsquad/qemu.git warn: Are you sure you pushed 'pull-target-arm-20240711-209-gc135d5eaaf' there? The following changes since commit a7ddb48bd1363c8bcdf42776d320289c42191f01: Merge tag 'pull-aspeed-202

[PULL 16/16] tests/tcg/aarch64: Fix test-mte.py

2024-07-22 Thread Alex Bennée
From: Richard Henderson Python 3.12 warns: TESTgdbstub MTE support on aarch64 /home/rth/qemu/src/tests/tcg/aarch64/gdbstub/test-mte.py:21: SyntaxWarning: invalid escape sequence '\(' PATTERN_0 = "Memory tags for address 0x[0-9a-f]+ match \(0x[0-9a-f]+\)." Double up the \ to pass one th

[PULL 06/16] tests/plugins: use qemu_plugin_outs for inline stats

2024-07-22 Thread Alex Bennée
Using bare printf's in plugins is perfectly acceptable but they do rather mess up the output of "make check-tcg". Convert the printfs to use g_string and then output with the plugin output helper which will already be captured to .pout files by the test harness. Reviewed-by: Pierrick Bouvier Revi

Re: [PATCH v4 6/6] virtio: Add VIRTIO_F_IN_ORDER property definition

2024-07-22 Thread Eugenio Perez Martin
On Sat, Jul 20, 2024 at 9:16 PM Michael S. Tsirkin wrote: > > On Wed, Jul 10, 2024 at 08:55:19AM -0400, Jonah Palmer wrote: > > Extend the virtio device property definitions to include the > > VIRTIO_F_IN_ORDER feature. > > > > The default state of this feature is disabled, allowing it to be > > e

  1   2   3   4   5   >