Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

On 16/07/2024 20.03, Paolo Bonzini wrote: Il mar 16 lug 2024, 18:45 John Snow > ha scritto: My only ask is that we keep the tests running in the custom venv environment we set up at build time Yes, they do, however pytest should also be added to pythondeps.t

Re: [PATCH 3/6] virtio-iommu: Free [host_]resv_ranges on unset_iommu_devices

Hi Zhenzhong, On 7/17/24 05:06, Duan, Zhenzhong wrote: > >> -Original Message- >> From: Eric Auger >> Subject: [PATCH 3/6] virtio-iommu: Free [host_]resv_ranges on >> unset_iommu_devices >> >> We are currently missing the deallocation of the [host_]resv_regions >> in case of hot unplug. A

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

On Wed, Jul 17, 2024 at 9:32 AM Thomas Huth wrote: > > There is the pycotap dependency to produce TAP from pytest, but that's > > probably something small enough to be vendored. > > The next version is only depending on pycotap now. I'm installing it in the > venv there that we also install when r

Re: [PATCH v2 6/9] qapi: convert "Example" sections without titles

John Snow writes: > Use the no-option form of ".. qmp-example::" to convert any Examples > that do not have any form of caption or explanation whatsoever. Note > that in a few cases, example sections are split into two or more > separate example blocks. This is only done stylistically to create a

Re: [PATCH] Manpage: Update description of 'user=username' for '-run-with'

thanks for your helping Best, Boqiao On Tue, Jul 16, 2024 at 5:00 PM Paolo Bonzini wrote: > > Manpage: the description of '-runs' didn't show this parameter will use > > setuid, so the customer might get confused when 'elevateprivileges=deny' > is > > used. Since '-runas' is going to be depreca

Re: [PATCH v2 9/9] qapi: remove "Example" doc section

John Snow writes: > Fully eliminate the "Example" sections in QAPI doc blocks now that they > have all been converted to arbitrary rST syntax using the > ".. qmp-example::" directive. Update tests to match. > > Migrating to the new syntax > --- > > The old "Example:" or "E

RE: [PATCH 3/6] virtio-iommu: Free [host_]resv_ranges on unset_iommu_devices

>-Original Message- >From: Eric Auger >Subject: Re: [PATCH 3/6] virtio-iommu: Free [host_]resv_ranges on >unset_iommu_devices > >Hi Zhenzhong, > >On 7/17/24 05:06, Duan, Zhenzhong wrote: >> >>> -Original Message- >>> From: Eric Auger >>> Subject: [PATCH 3/6] virtio-iommu: Free [

Re: [PATCH v4] mc146818rtc: add a way to generate RTC interrupts via QMP

On 5/29/24 6:27 PM, Philippe Mathieu-Daudé wrote: On 29/5/24 16:34, Markus Armbruster wrote: Daniil Tatianin writes: On 5/29/24 4:39 PM, Philippe Mathieu-Daudé wrote: On 29/5/24 14:43, Daniil Tatianin wrote: On 5/29/24 3:36 PM, Philippe Mathieu-Daudé wrote: On 29/5/24 14:03, Markus Armb

Re: [RFC 0/4] Added Interrupt controller emulation for loongarch kvm

On Wed, Jul 17 2024, Xianglai Li wrote: > Before this, the interrupt controller simulation has been completed > in the user mode program. In order to reduce the loss caused by frequent > switching of the virtual machine monitor from kernel mode to user mode > when the guest accesses the interrupt

Re: [PATCH v1 00/11] Convert avocado tests to normal Python unittests

On 16/07/2024 19.03, Thomas Huth wrote: On 16/07/2024 18.51, Daniel P. Berrangé wrote: On Tue, Jul 16, 2024 at 01:26:03PM +0200, Thomas Huth wrote: ... So instead of trying to update the python-based test suite in QEMU to a newer version of Avocado, we should maybe try to better integrate it w

[ANNOUNCE] QEMU 9.0.2 Stable released

Hi everyone, The QEMU v9.0.2 stable release is now available. You can grab the tarball from our download page here: https://www.qemu.org/download/#source https://download.qemu.org/qemu-9.0.2.tar.xz https://download.qemu.org/qemu-9.0.2.tar.xz.sig (signature) v9.0.2 is now tagged in the of

[ANNOUNCE] QEMU 8.2.6 Stable released

Hi everyone, The QEMU v8.2.6 stable release is now available. You can grab the tarball from our download page here: https://www.qemu.org/download/#source https://download.qemu.org/qemu-8.2.6.tar.xz https://download.qemu.org/qemu-8.2.6.tar.xz.sig (signature) v8.2.6 is now tagged in the of

Re: [RFC PATCH v4] ptp: Add vDSO-style vmclock support

On Tue, 2024-07-16 at 13:54 +0200, Peter Hilber wrote: > On 08.07.24 11:27, David Woodhouse wrote: > > + > > +   /* > > +    * Time according to time_type field above. > > +    */ > > +   uint64_t time_sec;  /* Seconds since time_type epoch */ > > +   uint64_t time_f

Re: [RFC PATCH v4] ptp: Add vDSO-style vmclock support

On Tue, 2024-07-16 at 15:20 +0200, Peter Hilber wrote: > On 16.07.24 14:32, David Woodhouse wrote: > > On 16 July 2024 12:54:52 BST, Peter Hilber > > wrote: > > > On 11.07.24 09:50, David Woodhouse wrote: > > > > On Thu, 2024-07-11 at 09:25 +0200, Peter Hilber wrote: > > > > > > > > > > IMHO thi

Re: [PATCH] qapi/qom: Document feature unstable of @x-vfio-user-server

Markus Armbruster writes: > Commit 8f9a9259d32c added ObjectType member @x-vfio-user-server with > feature unstable, but neglected to explain why it is unstable. Do > that now. > > Fixes: 8f9a9259d32c (vfio-user: define vfio-user-server object) > Cc: Elena Ufimtseva > Cc: John G Johnson > Cc:

Re: [RFC PATCH] gdbstub: Re-factor gdb command extensions

Richard Henderson writes: > On 7/17/24 02:55, Alex Bennée wrote: >>> Are you expecting the same GdbCmdParseEntry object to be registered >>> multiple times? Can we fix that at a higher level? >> Its basically a hack to deal with the fact everything is tied to the >> CPUObject so we register ever

Re: [PATCH v1 00/11] Convert avocado tests to normal Python unittests

On Wed, Jul 17, 2024 at 10:04:19AM +0200, Thomas Huth wrote: > On 16/07/2024 19.03, Thomas Huth wrote: > > On 16/07/2024 18.51, Daniel P. Berrangé wrote: > > > On Tue, Jul 16, 2024 at 01:26:03PM +0200, Thomas Huth wrote: > > ... > > > > So instead of trying to update the python-based test suite in

Re: [PATCH v1 00/11] Convert avocado tests to normal Python unittests

On 17/07/2024 10.37, Daniel P. Berrangé wrote: On Wed, Jul 17, 2024 at 10:04:19AM +0200, Thomas Huth wrote: On 16/07/2024 19.03, Thomas Huth wrote: On 16/07/2024 18.51, Daniel P. Berrangé wrote: On Tue, Jul 16, 2024 at 01:26:03PM +0200, Thomas Huth wrote: ... So instead of trying to update t

Re: [PATCH 0/2] Postcopy migration and vhost-user errors

On Tue, Jul 16, 2024 at 06:02:50PM -0400, Peter Xu wrote: > On Tue, Jul 16, 2024 at 03:44:54PM +0530, Prasad Pandit wrote: > > Hello Peter, > > > > On Mon, 15 Jul 2024 at 19:10, Peter Xu wrote: > > > IMHO it's better we debug and fix all the issues before merging this one, > > > otherwise we may

[PATCH v2] pci-bridge: avoid linking a single downstream port more than once

Since the downstream port is not checked, two slots can be linked to a single port. However, this can prevent the driver from detecting the device properly. It is necessary to ensure that a downstream port is not linked more than once. Links: https://lore.kernel.org/qemu-devel/oszpr01mb6453bc61d

Re: Re: [PATCH v9 09/10] hw/nvme: add reservation protocal command

Hi, Thank you for your support. 1. I will add a guide on how to get a simple test at next patch. 2. I think hostid is stored locally like cntlid, but I can't find a way to get the host ID. Is it correct to get it through qmp_query_uuid() method? Using spdk as target will not fail, but it will sh

Re: [PATCH v4 07/12] vfio/{iommufd,container}: Initialize HostIOMMUDeviceCaps during attach_device()

On 17/07/2024 03:05, Duan, Zhenzhong wrote: > > >> -Original Message- >> From: Joao Martins >> Subject: [PATCH v4 07/12] vfio/{iommufd,container}: Initialize >> HostIOMMUDeviceCaps during attach_device() >> >> Fetch IOMMU hw raw caps behind the device and thus move the >> HostIOMMUDevice

Re: [PATCH v4 05/12] vfio/iommufd: Introduce auto domain creation

On 17/07/2024 03:18, Duan, Zhenzhong wrote: > > >> -Original Message- >> From: Joao Martins >> Subject: [PATCH v4 05/12] vfio/iommufd: Introduce auto domain creation >> >> There's generally two modes of operation for IOMMUFD: >> >> * The simple user API which intends to perform relativel

Re: [PATCH v4 05/12] vfio/iommufd: Introduce auto domain creation

On 17/07/2024 03:52, Duan, Zhenzhong wrote: > > >> -Original Message- >> From: Joao Martins >> Subject: Re: [PATCH v4 05/12] vfio/iommufd: Introduce auto domain >> creation >> >> On 16/07/2024 17:44, Joao Martins wrote: >>> On 16/07/2024 17:04, Eric Auger wrote: Hi Joao, O

Re: [PATCH v4 09/12] vfio/iommufd: Implement VFIOIOMMUClass::set_dirty_tracking support

On 17/07/2024 03:24, Duan, Zhenzhong wrote: > > >> -Original Message- >> From: Joao Martins >> Subject: [PATCH v4 09/12] vfio/iommufd: Implement >> VFIOIOMMUClass::set_dirty_tracking support >> >> ioctl(iommufd, IOMMU_HWPT_SET_DIRTY_TRACKING, arg) is the UAPI that >> enables or disables

Re: [PATCH v3] osdep: add a qemu_close_all_open_fd() helper

On 16/07/2024 16:46, Philippe Mathieu-Daudé wrote: > Hi Clément, > > On 16/7/24 16:39, Clément Léger wrote: >> Since commit 03e471c41d8b ("qemu_init: increase NOFILE soft limit on >> POSIX"), the maximum number of file descriptors that can be opened are >> raised to nofile.rlim_max. On recent d

Re: [PATCH v3] osdep: add a qemu_close_all_open_fd() helper

On 16/07/2024 17:52, Richard Henderson wrote: > On 7/17/24 00:39, Clément Léger wrote: >> +    /* Restrict the range as we found fds matching >> start/end */ >> +    if (i == skip_start) >> +    skip_start++; >> +    else if (i

Re: [PATCH 04/11] tests/functional: Add python-based tests to the meson build system

On 16/07/2024 17.15, Fabiano Rosas wrote: Thomas Huth writes: Integrate the new python-based test framework with the meson build system. Since these tests now require the pycotap module, make sure that it gets installed in the venv. The changes to the meson.build files are partly based on an

Re: [PATCH v2 0/4] Reconstruct loongson ipi driver

On 2024/7/16 下午2:40, Philippe Mathieu-Daudé wrote: On 16/7/24 03:29, maobibo wrote: On 2024/7/16 上午9:04, maobibo wrote: On 2024/7/15 下午11:17, Philippe Mathieu-Daudé wrote: On 4/7/24 05:37, Bibo Mao wrote: Now loongson ipi and loongarch ipi share the same code with different macro, loon

Re: [PATCH v4 05/12] vfio/iommufd: Introduce auto domain creation

On 7/17/24 11:09, Joao Martins wrote: On 17/07/2024 03:52, Duan, Zhenzhong wrote: -Original Message- From: Joao Martins Subject: Re: [PATCH v4 05/12] vfio/iommufd: Introduce auto domain creation On 16/07/2024 17:44, Joao Martins wrote: On 16/07/2024 17:04, Eric Auger wrote: Hi Joa

Re: [PATCH v4 05/12] vfio/iommufd: Introduce auto domain creation

On 17/07/2024 10:28, Cédric Le Goater wrote: >>> @@ -224,6 +300,11 @@ static void iommufd_cdev_detach_container(VFIODevice *vbasedev, >>>   { >>>   Error *err = NULL; >>> >>> +    if (vbasedev->hwpt) { >>> +    iommufd_cdev_autodomains_put(vbasedev, container);

Re: [PATCH v4 11/12] vfio/migration: Don't block migration device dirty tracking is unsupported

On 17/07/2024 03:38, Duan, Zhenzhong wrote: > > >> -Original Message- >> From: Joao Martins >> Subject: [PATCH v4 11/12] vfio/migration: Don't block migration device dirty >> tracking is unsupported >> >> By default VFIO migration is set to auto, which will support live >> migration if t

[PATCH] scripts/checkpatch: emit a warning if an imported file is touched

If a file imported from Linux is touched, emit a warning and suggest using scripts/update-linux-headers.sh Signed-off-by: Stefano Garzarella --- scripts/checkpatch.pl | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl

RE: [PATCH v4 05/12] vfio/iommufd: Introduce auto domain creation

>-Original Message- >From: Joao Martins >Subject: Re: [PATCH v4 05/12] vfio/iommufd: Introduce auto domain >creation > >On 17/07/2024 03:52, Duan, Zhenzhong wrote: >> >> >>> -Original Message- >>> From: Joao Martins >>> Subject: Re: [PATCH v4 05/12] vfio/iommufd: Introduce auto

Re: [PATCH 01/17] target/arm: Use tcg_gen_extract2_i64 for EXT

On 17/7/24 08:08, Richard Henderson wrote: The extract2 tcg op performs the same operation as the do_ext64 function. Signed-off-by: Richard Henderson --- target/arm/tcg/translate-a64.c | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) Reviewed-by: Philippe Math

Re: [PATCH] scripts/checkpatch: emit a warning if an imported file is touched

On Wed, Jul 17, 2024 at 11:37:52AM +0200, Stefano Garzarella wrote: > If a file imported from Linux is touched, emit a warning and suggest > using scripts/update-linux-headers.sh > > Signed-off-by: Stefano Garzarella > --- > scripts/checkpatch.pl | 14 -- > 1 file changed, 12 inserti

Re: [PATCH v4 05/12] vfio/iommufd: Introduce auto domain creation

On 17/07/2024 10:48, Duan, Zhenzhong wrote: > > >> -Original Message- >> From: Joao Martins >> Subject: Re: [PATCH v4 05/12] vfio/iommufd: Introduce auto domain >> creation >> >> On 17/07/2024 03:52, Duan, Zhenzhong wrote: >>> >>> -Original Message- From: Joao Martins

Re: [PATCH 02/17] target/arm: Convert EXT to decodetree

On 17/7/24 08:08, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/arm/tcg/translate-a64.c | 121 + target/arm/tcg/a64.decode | 5 ++ 2 files changed, 53 insertions(+), 73 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 03/17] target/arm: Convert TBL, TBX to decodetree

On 17/7/24 08:08, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/arm/tcg/translate-a64.c | 47 ++ target/arm/tcg/a64.decode | 4 +++ 2 files changed, 18 insertions(+), 33 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] scripts/checkpatch: emit a warning if an imported file is touched

On Wed, Jul 17 2024, Stefano Garzarella wrote: > If a file imported from Linux is touched, emit a warning and suggest > using scripts/update-linux-headers.sh > > Signed-off-by: Stefano Garzarella > --- > scripts/checkpatch.pl | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(

Re: [PATCH 08/17] target/arm: Convert FMOVI (scalar, immediate) to decodetree

On 17/7/24 08:08, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/arm/tcg/translate-a64.c | 74 -- target/arm/tcg/a64.decode | 4 ++ 2 files changed, 30 insertions(+), 48 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 11/17] target/arm: Fix whitespace near gen_srshr64_i64

On 17/7/24 08:08, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/arm/tcg/gengvec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 17/17] target/arm: Push tcg_rnd into handle_shri_with_rndacc

On 17/7/24 08:09, Richard Henderson wrote: We always pass the same value for round; compute it within common code. Signed-off-by: Richard Henderson --- target/arm/tcg/translate-a64.c | 32 ++-- 1 file changed, 6 insertions(+), 26 deletions(-) Reviewed-by: Philip

Re: [PATCH v2 2/8] aspeed: Load eMMC first boot area as a boot rom

On 17/7/24 08:30, Cédric Le Goater wrote: From: Cédric Le Goater The first boot area partition (64K) of the eMMC device should contain an initial boot loader (u-boot SPL). Load it as a ROM only if an eMMC device is available to boot from but no flash device is. Signed-off-by: Cédric Le Goater

RE: [PATCH v4 05/12] vfio/iommufd: Introduce auto domain creation

>-Original Message- >From: Joao Martins >Subject: Re: [PATCH v4 05/12] vfio/iommufd: Introduce auto domain >creation > >On 17/07/2024 03:18, Duan, Zhenzhong wrote: >> >> >>> -Original Message- >>> From: Joao Martins >>> Subject: [PATCH v4 05/12] vfio/iommufd: Introduce auto doma

Re: [PATCH v2 0/8] aspeed: Add boot from eMMC support (AST2600)

On 17/7/24 08:30, Cédric Le Goater wrote: Cédric Le Goater (8): aspeed: Change type of eMMC device aspeed: Load eMMC first boot area as a boot rom aspeed/scu: Add boot-from-eMMC HW strapping bit for AST2600 SoC aspeed: Introduce a AspeedSoCClass 'boot_from_emmc' handler aspeed: Tu

Re: [PATCH v2 5/8] aspeed: Tune eMMC device properties to reflect HW strapping

On 17/7/24 08:30, Cédric Le Goater wrote: From: Cédric Le Goater When the boot-from-eMMC HW strapping bit is set, use the 'boot-config' property to set the boot config register to boot from the first boot area partition of the eMMC device. Also set the boot partition size of the device. Signed

Re: [PATCH v2] pci-bridge: avoid linking a single downstream port more than once

Hi Yao, On 17/7/24 10:56, Yao Xingtao via wrote: Since the downstream port is not checked, two slots can be linked to a single port. However, this can prevent the driver from detecting the device properly. It is necessary to ensure that a downstream port is not linked more than once. Links: h

Re: [PATCH v2 0/2] system: Enable the device aliases for or1k, too

Philippe Mathieu-Daudé (1): system: Sort QEMU_ARCH_VIRTIO_PCI definition Thomas Huth (1): system: Enable the device aliases for or1k, too Thanks, series queued.

Re: [PATCH v2] qga/commands-posix: Make ga_wait_child() return boolean

Hi Konstantin, If there are no other patches on your guest-agent queue, I can take this patch in my next pull request. Regards, Phil. On 16/7/24 18:23, Zhao Liu wrote: Make ga_wait_child() return boolean and check the returned boolean in ga_run_command() instead of dereferencing @errp. Cc: M

Re: [PATCH v2] target/s390x: filter deprecated properties based on model expansion type

On 16.07.24 19:32, Collin Walling wrote: As s390 CPU models progress and deprecated properties are dropped outright, it will be cumbersome for management apps to query the host for a comprehensive list of deprecated properties that will need to be disabled on older models. To remedy this, the que

Re: [PATCH 0/5] qapi: Doc comment cleanups

Queued.

Re: [PATCH 04/14] qapi: add a 'command-features' pragma

On Tue, Jul 16, 2024 at 08:08:42PM +0200, Markus Armbruster wrote: > Sorry for the delay; too many distractions, and I needed a good think. > > Daniel P. Berrangé writes: > > > On Fri, Jul 12, 2024 at 10:50:54AM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Fri

Re: [PATCH v2 0/9] qapi: convert example sections to qmp-example rST directives

John Snow writes: > This patchset focuses on converting example sections to rST directives > using a new `.. qmp-example::` directive. Queued, thanks!

[PULL 07/14] docs/qapidoc: factor out do_parse()

From: John Snow Factor out the compatibility parser helper into a base class, so it can be shared by other directives. Signed-off-by: John Snow Reviewed-by: Markus Armbruster Message-ID: <20240717021312.606116-3-js...@redhat.com> Signed-off-by: Markus Armbruster --- docs/sphinx/qapidoc.py |

[PULL 02/14] qapi/pci: Clean up documentation around PciDeviceClass

PciDeviceInfo's doc comment has a note on PciDeviceClass member @desc. Since the note applies always, not just within PciDeviceInfo, merge it into PciDeviceClass's description of member @desc. Signed-off-by: Markus Armbruster Message-ID: <2024072228.2140606-2-arm...@redhat.com> Reviewed-by: M

[PULL 09/14] docs/qapidoc: add QMP highlighting to annotated qmp-example blocks

From: John Snow For any code literal blocks inside of a qmp-example directive, apply and enforce the QMP lexer/highlighter to those blocks. This way, you won't need to write: ``` .. qmp-example:: :annotated: Blah blah .. code-block:: QMP -> { "lorem": "ipsum" } ``` But instea

[PULL 13/14] qapi: convert "Example" sections with longer prose

From: John Snow These examples require longer explanations or have explanations that require markup to look reasonable when rendered and so use the longer form of the ".. qmp-example::" directive. By using the :annotated: option, the content in the example block is assumed *not* to be a code blo

[PULL 04/14] qapi/machine: Clarify query-uuid value when none has been specified

When no UUID has been specified, query-uuid returns {"UUID": "----"} The doc comment calls this "a null UUID", which I find less than clear. RFC 9562 calls it "the nil UUID (all zeroes)", so use that instead. Signed-off-by: Markus Armbruster Message-ID: <202

[PULL 12/14] qapi: convert "Example" sections with titles

From: John Snow When an Example section has a brief explanation, convert it to a qmp-example:: section using the :title: option. Rule of thumb: If the title can fit on a single line and requires no rST markup, it's a good candidate for using the :title: option of qmp-example. In this patch, tra

[PULL 14/14] qapi: remove "Example" doc section

From: John Snow Fully eliminate the "Example" sections in QAPI doc blocks now that they have all been converted to arbitrary rST syntax using the ".. qmp-example::" directive. Update tests to match. Migrating to the new syntax --- The old "Example:" or "Examples:" sectio

[PULL 08/14] docs/qapidoc: create qmp-example directive

From: John Snow This is a directive that creates a syntactic sugar for creating "Example" boxes very similar to the ones already used in the bitmaps.rst document, please see e.g. https://www.qemu.org/docs/master/interop/bitmaps.html#creation-block-dirty-bitmap-add In its simplest form, when a cu

[PULL 05/14] qapi/sockets: Move deprecation note out of SocketAddress doc comment

Doc comments are reference documentation for users of QMP. SocketAddress's doc comment contains a deprecation note advising developers to use SocketAddress for new code. Irrelevant for users of QMP. Move the note out of the doc comment. Signed-off-by: Markus Armbruster Message-ID: <20240722

[PULL 00/14] QAPI patches patches for 2024-07-17

The following changes since commit e2f346aa98646e84eabe0256f89d08e89b1837cf: Merge tag 'sdmmc-20240716' of https://github.com/philmd/qemu into staging (2024-07-17 07:59:31 +1000) are available in the Git repository at: https://repo.or.cz/qemu/armbru.git tags/pull-qapi-2024-07-17 for you to

Re: [PATCH 3/3] semihosting: Restrict to TCG

On 19/6/24 09:49, Paolo Bonzini wrote: On Wed, Jun 12, 2024 at 3:13 PM Philippe Mathieu-Daudé wrote: Building qemu-system-mips configured with --without-default-devices: Undefined symbols for architecture arm64: "_qemu_semihosting_console_write", referenced from: _mips_semihosting

[PULL 10/14] docs/sphinx: add CSS styling for qmp-example directive

From: Harmonie Snow Add CSS styling for qmp-example directives to increase readability and consistently style all example blocks. Signed-off-by: Harmonie Snow Signed-off-by: John Snow Acked-by: Markus Armbruster Message-ID: <20240717021312.606116-6-js...@redhat.com> Signed-off-by: Markus Armb

[PULL 11/14] qapi: convert "Example" sections without titles

From: John Snow Use the no-option form of ".. qmp-example::" to convert any Examples that do not have any form of caption or explanation whatsoever. Note that in a few cases, example sections are split into two or more separate example blocks. This is only done stylistically to create a delineati

[PULL 06/14] qapi/ui: Drop note on naming of SpiceQueryMouseMode

Doc comments are reference documentation for users of QMP. SpiceQueryMouseMode's doc comment contains a note explaining why it's not named SpiceMouseMode: spice/enums.h has it already. Irrelevant for users of QMP; delete the note. Signed-off-by: Markus Armbruster Message-ID: <2024072228.2140

[PULL 01/14] qapi/qom: Document feature unstable of @x-vfio-user-server

Commit 8f9a9259d32c added ObjectType member @x-vfio-user-server with feature unstable, but neglected to explain why it is unstable. Do that now. Fixes: 8f9a9259d32c (vfio-user: define vfio-user-server object) Cc: Elena Ufimtseva Cc: John G Johnson Cc: Jagannathan Raman Cc: qemu-sta...@nongnu.o

[PULL 03/14] qapi/machine: Clean up documentation around CpuInstanceProperties

CpuInstanceProperties' doc comment describes its members as properties to be passed to device_add when hot-plugging a CPU. This was in fact the initial use of this type, with query-hotpluggable-cpus: letting management applications find out what properties need to be passed with device_add to hot-

[PATCH v4 0/8] semihosting: Restrict to TCG

v4: Address Paolo's comment v3: Address Anton's comment v2: Address Paolo's comment Semihosting currently uses the TCG probe_access API, so it is pointless to have it in the binary when TCG isn't. It could be implemented for other accelerators, but work need to be done. Meanwhile, do not enable i

[PATCH v4 8/8] semihosting: Restrict to TCG

Semihosting currently uses the TCG probe_access API. It is pointless to have it in the binary when TCG isn't. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- semihosting/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/semihosting/Kconfig b/semihosting/Kconfi

[PATCH v4 5/8] target/mips: Restrict semihosting to TCG

Semihosting currently uses the TCG probe_access API. To prepare for encoding the TCG dependency in Kconfig, do not enable it unless TCG is available. Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Anton Johansson --- target/mips/Kconfig | 2 +- 1 file changed, 1

[PATCH v4 6/8] target/riscv: Restrict semihosting to TCG

Semihosting currently uses the TCG probe_access API. To prepare for encoding the TCG dependency in Kconfig, do not enable it unless TCG is available. Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Anton Johansson --- target/riscv/Kconfig | 4 ++-- 1 file changed

[PATCH v4 3/8] target/mips: Add semihosting stub

Since the SEMIHOSTING feature is optional, we need a stub to link when it is disabled. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tcg/sysemu/semihosting-stub.c | 15 +++ target/mips/tcg/sysemu/meson.build| 6 -- 2 files changed, 19 insertions(+), 2 deletions(-

[PATCH v4 4/8] target/m68k: Restrict semihosting to TCG

The semihosting feature depends on TCG (due to the probe_access API access). Although TCG is the single accelerator currently available for the m68k target, use the Kconfig "imply" directive which is more correct (if we were to support a different accel). Reported-by: Anton Johansson Signed-off-b

[PATCH v4 1/8] semihosting: Include missing 'gdbstub/syscalls.h' header

"semihosting/syscalls.h" requires definitions from "gdbstub/syscalls.h", include it in order to avoid: include/semihosting/syscalls.h:23:38: error: unknown type name 'gdb_syscall_complete_cb' void semihost_sys_open(CPUState *cs, gdb_syscall_complete_cb complete,

[PATCH v4 7/8] target/xtensa: Restrict semihosting to TCG

The semihosting feature depends on TCG (due to the probe_access API access). Although TCG is the single accelerator currently available for the xtensa target, use the Kconfig "imply" directive which is more correct (if we were to support a different accel). Reported-by: Anton Johansson Signed-off

[PATCH v4 2/8] target/m68k: Add semihosting stub

Since the SEMIHOSTING feature is optional, we need a stub to link when it is disabled. Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé --- target/m68k/semihosting-stub.c | 15 +++ target/m68k/meson.build| 5 - 2 files changed, 19 insertions(+), 1 delet

[PATCH 08/26] hw/display/apple-gfx: Adds migration blocker

Although the underlying ParavirtualizedGraphics.framework does support state (de-)serialisation, this is currently not yet integrated. We therefore add a migration blocker for now. Signed-off-by: Phil Dennis-Jordan --- hw/display/apple-gfx.m | 16 1 file changed, 16 insertions(+

[PATCH 15/26] hw/display/apple-gfx: Separates generic & vmapple-specific functionality

The apple-gfx paravirtualised graphics device can be used in a MMIO mode with the 'vmapple' arm64 machine model, but also as a PCI device, especially on x86-64 VMs. There are some significant differences between these implementations, but even more shared functionality. This change prepares for a

[PATCH v2 7/8] hw/display/apple-gfx: Adds configurable mode list

This change adds a property 'display_modes' on the graphics device which permits specifying a list of display modes. (screen resolution and refresh rate) PCI variant of apple-gfx only for the moment. Signed-off-by: Phil Dennis-Jordan --- hw/display/apple-gfx-pci.m | 43 ++- hw/display/

[PATCH 07/26] hw/display/apple-gfx: Makes set_mode thread & memory safe

When the set_mode callback was invoked outside of the BQL, there could be a race condition swapping out the resized render target texture and VRAM. set_mode may be called inside or out of the BQL depending on context (reentrant from a MMIO write or not) so we need to check locking state first. Sig

[PATCH 24/26] hw/display/apple-gfx: Adds configurable mode list

This change adds a property 'display_modes' on the graphics device which permits specifying a list of display modes. (screen resolution and refresh rate) PCI variant of apple-gfx only for the moment. Signed-off-by: Phil Dennis-Jordan --- hw/display/apple-gfx-pci.m | 43 ++- hw/display/

[PATCH 23/26] hw/display/apple-gfx: Host GPU picking improvements

During startup of the PV graphics device, we need to specify the host GPU to use for PV acceleration of the guest's graphics operations. On a host system, this is trivial: pick the only one. The MTLCreateSystemDefaultDevice() function will do the right thing in this case. It gets a little more co

[PATCH 01/26] hw/vmapple/apple-gfx: Introduce ParavirtualizedGraphics.Framework support

From: Alexander Graf MacOS provides a framework (library) that allows any vmm to implement a paravirtualized 3d graphics passthrough to the host metal stack called ParavirtualizedGraphics.Framework (PVG). The library abstracts away almost every aspect of the paravirtualized device model and only

[PATCH 04/26] hw/display/apple-gfx: uses DEFINE_TYPES macro

Switches the device definition to the more modern macro variants. Signed-off-by: Phil Dennis-Jordan --- hw/display/apple-gfx.m | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/hw/display/apple-gfx.m b/hw/display/apple-gfx.m index 3b437e2519..87bcdcd98e

[PATCH 20/26] hw/display/apple-gfx: Fixes cursor hotspot handling

The ParavirtualizedGraphics framework provides the cursor's hotspot, this change actually passes that information through to Qemu's cursor handling. This change also seizes the opportunity to make other cursor related code conform to coding standards. Signed-off-by: Phil Dennis-Jordan --- hw/di

[PATCH 06/26] hw/display/apple-gfx: Removes dead/superfluous code

This removes a few chunks of code that do nothing useful. * MAX_MRS was not used anywhere. * The MMIO offset switch block had only a default case. * Generating mip maps for the texture is a waste of time as the texture is only used for read-out to a system memory buffer. * The trace range c

[PATCH 25/26] MAINTAINERS: Add myself as maintainer for apple-gfx, reviewer for HVF

I'm happy to take responsibility for the macOS PV graphics code. As HVF patches don't seem to get much attention at the moment, I'm also adding myself as designated reviewer for HVF and x86 HVF to try and improve that. I anticipate that the resulting workload should be covered by the funding I'm r

[PATCH 03/26] hw/display/apple-gfx: Moved from hw/vmapple/

The macOS PV graphics device is useful outside the (as yet incomplete) vmapple machine type, so this patch moves it to hw/display. Signed-off-by: Phil Dennis-Jordan --- hw/display/Kconfig | 4 hw/{vmapple => display}/apple-gfx.m | 0 hw/display/meson.build |

[PATCH 19/26] ui/cocoa: Adds non-app runloop on main thread mode

Various system frameworks on macOS and other Apple platforms require a main runloop to be processing events on the process’s main thread. The Cocoa UI’s requirement to run the process as a Cocoa application automatically enables this runloop, but it can be useful to have the runloop handling events

[PATCH 26/26] hw/display/apple-gfx: Removes UI pointer support check

The dpy_cursor_define_supported() check is destined for removal when the last UI frontend without cursor support (cocoa) gains cursor integration. This patch is required to reconcile with that change. Signed-off-by: Phil Dennis-Jordan --- hw/display/apple-gfx.m | 24 1 f

[PATCH 13/26] hw/display/apple-gfx: Defines PGTask_s struct instead of casting

The struct PGTask_s is only forward-declared by the macOS ParavirtualizedGraphics.framework and treated as opaque, which means client code can safely provide its own definition. This change does exactly that, renaming struct AppleGFXTask to PGTask_s, but keeping the original typedef name. The upsh

[PATCH 18/26] hw/display/apple-gfx: Adds PCI implementation

This change wires up the PCI variant of the paravirtualised graphics device, mainly useful for x86-64 macOS guests, implemented by macOS's ParavirtualizedGraphics.framework. It builds on the shared code previously split from the vmapple MMIO variant of the device. Signed-off-by: Phil Dennis-Jordan

[PATCH 17/26] hw/display/apple-gfx: Asynchronous rendering and graphics update

This change avoids doing expensive rendering while holding the BQL. Rendering with the lock held is not only inefficient, it can also cause deadlocks when the PV Graphics framework’s encode... method causes a (synchronous) call to a callback, which in turn tries to acquire the BQL. Signed-off-by:

[PATCH 21/26] hw/display/apple-gfx: Implements texture syncing for non-UMA GPUs

Renderable Metal textures are handled differently depending on whether the GPU uses a unified memory architecture (no physical distinction between VRAM and system RAM, CPU and GPU share the memory bus) or not. (Traditional discrete GPU with its own VRAM) In the discrete GPU case, textures must be

[PATCH v2 2/8] hw/display/apple-gfx: Adds PCI implementation

This change wires up the PCI variant of the paravirtualised graphics device, mainly useful for x86-64 macOS guests, implemented by macOS's ParavirtualizedGraphics.framework. It builds on code shared with the vmapple/mmio variant of the PVG device. Signed-off-by: Phil Dennis-Jordan --- hw/display

[PATCH 02/26] hw/vmapple/apple-gfx: BQL renaming update

Since the original apple-gfx code was written, the BQL functions have been renamed. This change updates the apple-gfx code to use the new names. Signed-off-by: Phil Dennis-Jordan --- hw/vmapple/apple-gfx.m | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff

[PATCH 05/26] hw/display/apple-gfx: native -> little endian memory ops

This is considered best practice. Signed-off-by: Phil Dennis-Jordan --- hw/display/apple-gfx.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/apple-gfx.m b/hw/display/apple-gfx.m index 87bcdcd98e..8b0459f969 100644 --- a/hw/display/apple-gfx.m +++ b/hw/display/app

  1   2   3   4   >