On 7/15/24 20:33, Michael Kowal wrote:
Made changes to some structure and define elements to ease review in
next patchset.
Signed-off-by: Michael Kowal
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
hw/intc/pnv_xive2.c | 30 +++---
1 file changed, 15 insertions
On 7/15/24 20:33, Michael Kowal wrote:
From: Frederic Barrat
Fail VST entry address computation if firmware doesn't define a descriptor
for one of the Virtualization Structure Tables (VST), there's no point in
trying to compute the address of its entry. Abort the operation and log
an error.
S
On 7/15/24 20:33, Michael Kowal wrote:
From: Frederic Barrat
Enable NVG and NVC VST tables for index compression which indicates the number
of bits the address is shifted to the right for the table accesses.
The compression values are defined as:
- No compression
0001 - 1 bit shift
On 7/15/24 20:33, Michael Kowal wrote:
From: Frederic Barrat
Both the virtualization layer (VC) and presentation layer (PC) need to
be configured to access the VSTs. Since the information is redundant,
the xive model combines both into one set of tables and only the
definitions going through th
On 7/15/24 20:33, Michael Kowal wrote:
From: Frederic Barrat
Set Translation Table for the NVC port space is missing. The xive model
doesn't take into account the remapping of IO operations via the Set
Translation Table but firmware is allowed to define it for the Notify
Virtual Crowd (NVC), l
On 7/15/24 20:33, Michael Kowal wrote:
From: Frederic Barrat
Moving xive2_nvp_pic_print_info() align with the other "pic_print_info"
functions and allows us to call functions internal to xive2.c.
In XIVE Gen 2 there were some minor changes to the TIMA header that were
updated when printed.
Ad
On 7/15/24 20:33, Michael Kowal wrote:
From: Nicholas Piggin
Adds support for writing a completion notification byte in memory
whenever a cache flush or queue sync inject operation is requested by
software. QEMU does not cache any of the XIVE data that is in memory and
therefore it simply writ
qemu_get_runtime_dir() returns a dynamically allocated directory path
that is appropriate for storing runtime files. It corresponds to "run"
directory in Unix.
With a tree-wide search, it was found that there are several cases
where such a functionality is implemented so let's have one as a common
qemu_get_runtime_dir() provides QEMU-specific fallback of runtime
directory.
Signed-off-by: Akihiko Odaki
Message-Id: <20230921075425.16738-9-akihiko.od...@daynix.com>
---
ui/spice-app.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/spice-app.c b/ui/spice-app.c
index
On 7/15/24 20:33, Michael Kowal wrote:
From: Frederic Barrat
XIVE offers a 'cache watch facility', which allows software to read/update
a potentially cached table entry with no software lock. There's one such
facility in the Virtualization Controller (VC) to update the ESB and END
entries and o
qemu_get_runtime_dir() is used to construct the default state directory.
Signed-off-by: Akihiko Odaki
Message-Id: <20230921075425.16738-5-akihiko.od...@daynix.com>
---
qga/main.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/qga/main.c b/qga/main.c
index f4d5f15bb3
qemu_get_runtime_dir() is used to construct the default paths.
Signed-off-by: Akihiko Odaki
Message-Id: <20230921075425.16738-6-akihiko.od...@daynix.com>
---
scsi/qemu-pr-helper.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scsi/qemu-pr-helper.c b/scsi/qemu-pr-helpe
There are no users of the function anymore.
Signed-off-by: Akihiko Odaki
Message-Id: <20230921075425.16738-8-akihiko.od...@daynix.com>
---
include/qemu/osdep.h | 8
util/oslib-posix.c | 6 --
util/oslib-win32.c | 10 --
3 files changed, 24 deletions(-)
diff --git a/in
qemu_get_runtime_dir() is used to construct the path to module upgrades.
Signed-off-by: Akihiko Odaki
Message-Id: <20230921075425.16738-7-akihiko.od...@daynix.com>
---
util/module.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/util/module.c b/util/module.c
index 32e26316
qemu_get_runtime_dir() returns a dynamically allocated directory path
that is appropriate for storing runtime files. It corresponds to "run"
directory in Unix.
With a tree-wide search, it was found that there are several cases
where such a functionality is implemented so let's have one as a common
qemu_get_runtime_dir() is used to construct the default PID file path.
Signed-off-by: Akihiko Odaki
Message-Id: <20230921075425.16738-3-akihiko.od...@daynix.com>
---
contrib/ivshmem-server/main.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/contrib/iv
On 7/15/24 20:33, Michael Kowal wrote:
From: Frederic Barrat
The cache watch facility uses the same register interface to handle
entries in the NVP, NVG and NVC tables. A bit-field in the 'watchX
specification' register tells the table type. So far, that bit-field
was not read and the code assu
Fiona Ebner writes:
> Commit 9876359990 ("hw/scsi/lsi53c895a: add timer to scripts
> processing") reduced the maximum allowed instruction count by
> a factor of 100 all the way down to 100.
>
> This causes the "Check Point R81.20 Gaia" appliance [0] to fail to
> boot after fully finishing the ins
On 2024/7/15 16:21, Zhao Liu wrote:
For qemu_open_old(), osdep.h said:
Don't introduce new usage of this function, prefer the following
qemu_open/qemu_create that take an "Error **errp".
So replace qemu_open_old() with qemu_open().
Cc: Yi Liu
Cc: Eric Auger
Cc: Zhenzhong Duan
Signed-off-b
16.07.2024 10:27, Akihiko Odaki wrote:
qemu_get_runtime_dir() returns a dynamically allocated directory path
that is appropriate for storing runtime files. It corresponds to "run"
directory in Unix.
Since runtime dir is always used with a filename within, how about
char *qemu_get_runtime_pat
>-Original Message-
>From: Joao Martins
>Subject: [PATCH v4 00/12] hw/iommufd: IOMMUFD Dirty Tracking
>
>This small series adds support for IOMMU dirty tracking support via the
>IOMMUFD backend. The hardware capability is available on most recent x86
>hardware. The series is divided orga
Setting 'pmu' does not make sense for CPU types emulating physical
CPUs.
Signed-off-by: Akihiko Odaki
---
target/arm/cpu.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index 14d4eca12740..8c180c679ce2 100644
--- a/target/arm/cpu.c
+++ b/target/ar
kvm-steal-time and sve properties are added for KVM even if the
corresponding features are not available. Always add pmu property too.
Signed-off-by: Akihiko Odaki
---
target/arm/cpu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index
target/arm/kvm.c checked PMU availability but claimed PMU is
available even if it is not. In fact, Asahi Linux supports KVM but lacks
PMU support. Only advertise PMU availability only when it is really
available.
Fixes: dc40d45ebd8e ("target/arm/kvm: Move kvm_arm_get_host_cpu_features and
unexpor
target/arm/kvm.c checked PMU availability but claimed PMU is
available even if it is not. In fact, Asahi Linux supports KVM but lacks
PMU support. Only advertise PMU availability only when it is really
available.
Fixes: dc40d45ebd8e ("target/arm/kvm: Move kvm_arm_get_host_cpu_features and
unexpor
hvf currently does not support PMU.
Signed-off-by: Akihiko Odaki
---
target/arm/cpu.c | 4
1 file changed, 4 insertions(+)
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index 8c180c679ce2..9e1d15701468 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -1603,6 +1603,10 @@ static vo
Asahi Linux supports KVM but lacks PMU support.
Signed-off-by: Akihiko Odaki
---
tests/qtest/arm-cpu-features.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/tests/qtest/arm-cpu-features.c b/tests/qtest/arm-cpu-features.c
index 966c65d5c3e4..cfd6f7735354 10064
Queued, thanks.
Paolo
Queued, thanks.
Paolo
Queued, thanks.
Paolo
Queued, thanks.
Paolo
Queued, thanks.
Paolo
Queued, thanks.
Paolo
Queued, thanks.
Paolo
On 16/7/24 08:42, Zhenzhong Duan wrote:
When ram_block_discard_require() fails, errno is passed to error_setg_errno().
It's a stale value or 0 which is unrelated to ram_block_discard_require().
As ram_block_discard_require() already returns -EBUSY in failure case,
use it as errno for error_setg_
On 16/7/24 08:46, Philippe Mathieu-Daudé wrote:
On 16/7/24 00:01, Mark Cave-Ayland wrote:
On 15/07/2024 07:48, Philippe Mathieu-Daudé wrote:
On 14/7/24 00:42, Mark Cave-Ayland wrote:
The transfer size check was originally added to prevent consecutive
DMA TI
commands from causing an assert() d
> Manpage: the description of '-runs' didn't show this parameter will use
> setuid, so the customer might get confused when 'elevateprivileges=deny' is
> used. Since '-runas' is going to be deprecated and replaced by this
> parameter in the coming qemu9.1, add the message here.
Queued, thanks. I
On 7/16/24 01:08, Pierrick Bouvier wrote:
On 7/15/24 01:09, Simon Hamelin wrote:
Hello Pierrick,
Could you share a bit more information on the final goal, if possible?
Is that used for fuzzing binaries, security analysis, or other things?
I'm currently using this plugin for security analy
On 16/7/24 10:28, Akihiko Odaki wrote:
Asahi Linux supports KVM but lacks PMU support.
Signed-off-by: Akihiko Odaki
---
tests/qtest/arm-cpu-features.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
On 16/7/24 10:28, Akihiko Odaki wrote:
kvm-steal-time and sve properties are added for KVM even if the
corresponding features are not available. Always add pmu property too.
Signed-off-by: Akihiko Odaki
---
target/arm/cpu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-b
On Sun, 30 Jun 2024 12:40:24 -0700
Steve Sistare wrote:
> Allocate anonymous memory using mmap MAP_ANON or memfd_create depending
> on the value of the anon-alloc machine property. This affects
> memory-backend-ram objects, guest RAM created with the global -m option
> but without an associated
Hello Joao
On 7/12/24 13:46, Joao Martins wrote:
In preparation to skip initialization of the HostIOMMUDevice for mdev,
extract the checks that validate if a device is an mdev into helpers.
A vfio_set_mdev() is created, and subsystems consult VFIODevice::mdev
to check if it's mdev or not.
Sign
On 7/12/24 13:46, Joao Martins wrote:
mdevs aren't "physical" devices and when asking for backing IOMMU info, it
fails the entire provisioning of the guest. Fix that by skipping
HostIOMMUDevice initialization in the presence of mdevs, and skip setting
an iommu device when it is known to be an mde
On 16/7/24 10:28, Akihiko Odaki wrote:
target/arm/kvm.c checked PMU availability but claimed PMU is
available even if it is not. In fact, Asahi Linux supports KVM but lacks
PMU support. Only advertise PMU availability only when it is really
available.
Fixes: dc40d45ebd8e ("target/arm/kvm: Move k
On 7/12/24 13:46, Joao Martins wrote:
The helper will be able to fetch vendor agnostic IOMMU capabilities
supported both by hardware and software. Right now it is only iommu dirty
tracking.
Signed-off-by: Joao Martins
Reviewed-by: Zhenzhong Duan
Reviewed-by: Cédric Le Goater
Thanks,
C.
On 16/07/2024 09:20, Duan, Zhenzhong wrote:
>
>
>> -Original Message-
>> From: Joao Martins
>> Subject: [PATCH v4 00/12] hw/iommufd: IOMMUFD Dirty Tracking
>>
>> This small series adds support for IOMMU dirty tracking support via the
>> IOMMUFD backend. The hardware capability is availab
On 7/12/24 13:46, Joao Martins wrote:
In preparation to implement auto domains have the attach function
return the errno it got during domain attach instead of a bool.
-EINVAL is tracked to track domain incompatibilities, and decide whether
to create a new IOMMU domain.
Signed-off-by: Joao Mart
On 2024/07/16 17:06, Michael Tokarev wrote:
16.07.2024 10:27, Akihiko Odaki wrote:
qemu_get_runtime_dir() returns a dynamically allocated directory path
that is appropriate for storing runtime files. It corresponds to "run"
directory in Unix.
Since runtime dir is always used with a filename wi
On 16/07/2024 10:21, Cédric Le Goater wrote:
> Hello Joao
>
> On 7/12/24 13:46, Joao Martins wrote:
>> In preparation to skip initialization of the HostIOMMUDevice for mdev,
>> extract the checks that validate if a device is an mdev into helpers.
>>
>> A vfio_set_mdev() is created, and subsystems
Extracted from the patch that TaiseiIto tested.
While not sufficient to fix their problems, this is a step in the
right direction.
Paolo Bonzini (2):
hpet: fix clamping of period
hpet: fix HPET_TN_SETVAL for high 32-bits of the comparator
hw/timer/hpet.c | 25 -
1 fi
When writing a new period, the clamping should use a maximum value
rather than a bit mask. Also, when writing the high bits new_val
is shifted right by 32, so the maximum allowed period should also
be shifted right.
Signed-off-by: Paolo Bonzini
---
hw/timer/hpet.c | 6 --
1 file changed, 4
Commit 3787324101b ("hpet: Fix emulation of HPET_TN_SETVAL (Jan Kiszka)",
2009-04-17) applied the fix only to the low 32-bits of the comparator, but
it should be done for the high bits as well. Otherwise, the high 32-bits
of the comparator cannot be written and they remain fixed to 0x.
Co
On Tue, 16 Jul 2024 at 09:28, Akihiko Odaki wrote:
>
> Setting 'pmu' does not make sense for CPU types emulating physical
> CPUs.
>
> Signed-off-by: Akihiko Odaki
> ---
> target/arm/cpu.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/target/arm/cpu.c b/target/arm/cpu.c
> index
On Tue, 16 Jul 2024 at 09:48, Paolo Bonzini wrote:
>
> Queued, thanks.
Could you add
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2438
to the commit message?
thanks
-- PMM
On 7/12/24 13:46, Joao Martins wrote:
There's generally two modes of operation for IOMMUFD:
* The simple user API which intends to perform relatively simple things
with IOMMUs e.g. DPDK. It generally creates an IOAS and attach to VFIO
and mainly performs IOAS_MAP and UNMAP.
* The native IOMMUFD
16.07.2024 12:32, Akihiko Odaki wrote:
On 2024/07/16 17:06, Michael Tokarev wrote:
Since runtime dir is always used with a filename within, how about
char *qemu_get_runtime_path(const char *filename)
which return RUNTIME_DIR/filename instead of just RUNTIME_DIR ?
I'm not sure. Such a fu
1b889d6e39c3 ("virtio-iommu: Clear IOMMUDevice when VFIO
device is unplugged" fixes the VFIO hotplug/hotunplug/hotplug
sequence by clearing the IOMMUDevice which backs the VFIO device.
However this brings other troubles such as a memory corruption.
Even when fixing some cleanups that were missed o
We are currently missing the deallocation of the [host_]resv_regions
in case of hot unplug. Also to make things more simple let's rule
out the case where multiple HostIOMMUDevices would be aliased and
attached to the same IOMMUDevice. This allows to remove the handling
of conflicting Host reserved
We currently miss the removal of the endpoint in case of detach.
Signed-off-by: Eric Auger
---
hw/virtio/virtio-iommu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c
index 2de41ab412..440dfa6e92 100644
--- a/hw/virtio/virtio-iommu.c
+++ b
Add a trace point on virtio_iommu_detach_endpoint_from_domain().
Signed-off-by: Eric Auger
---
hw/virtio/virtio-iommu.c | 1 +
hw/virtio/trace-events | 1 +
2 files changed, 2 insertions(+)
diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c
index 440dfa6e92..59ef4fb217 100644
--
This reverts commit 1b889d6e39c32d709f1114699a014b381bcf1cb1.
There are different problems with that tentative fix:
- Some resources are left dangling (resv_regions,
host_resv_ranges) and memory subregions are left attached to
the root MR although freed as embedded in the sdev IOMMUDevice.
Fi
Trace when VFIO gets notified about the deletion of an IOMMU MR.
Also trace the name of the region in the add_iommu trace message.
Signed-off-by: Eric Auger
---
hw/vfio/common.c | 3 ++-
hw/vfio/trace-events | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/vfio/comm
Now we have switched to PCIIOMMUOps to convey host IOMMU information,
the host reserved regions are transmitted when the PCIe topology is
built. This happens way before the virtio-iommu driver calls the probe
request. So let's remove the probe_done flag that allowed to check
the probe was not done
On 16/07/2024 10:39, Cédric Le Goater wrote:
> On 7/12/24 13:46, Joao Martins wrote:
>> There's generally two modes of operation for IOMMUFD:
>>
>> * The simple user API which intends to perform relatively simple things
>> with IOMMUs e.g. DPDK. It generally creates an IOAS and attach to VFIO
>> an
On 16.07.24 08:42, Zhenzhong Duan wrote:
When ram_block_discard_require() fails, errno is passed to error_setg_errno().
It's a stale value or 0 which is unrelated to ram_block_discard_require().
As ram_block_discard_require() already returns -EBUSY in failure case,
use it as errno for error_setg
On Tue, 16 Jul 2024 03:38:29 +
Salil Mehta wrote:
> Hi Igor,
>
> On 15/07/2024 15:11, Igor Mammedov wrote:
> > On Mon, 15 Jul 2024 14:19:12 +
> > Salil Mehta wrote:
> >
> >>> From: qemu-arm-bounces+salil.mehta=huawei@nongnu.org >>> arm-bounces+salil.mehta=huawei@nongnu.o
On Tue, Jul 16, 2024 at 04:27:31PM +0900, Akihiko Odaki wrote:
> qemu_get_runtime_dir() returns a dynamically allocated directory path
> that is appropriate for storing runtime files. It corresponds to "run"
> directory in Unix.
>
> With a tree-wide search, it was found that there are several case
On Tue, Jul 16, 2024 at 11:06:57AM +0300, Michael Tokarev wrote:
> 16.07.2024 10:27, Akihiko Odaki wrote:
> > qemu_get_runtime_dir() returns a dynamically allocated directory path
> > that is appropriate for storing runtime files. It corresponds to "run"
> > directory in Unix.
>
> Since runtime di
Hello Peter,
On Mon, 15 Jul 2024 at 19:10, Peter Xu wrote:
> IMHO it's better we debug and fix all the issues before merging this one,
> otherwise we may overlook something.
* Well we don't know where the issue is, not sure where the fix may go
in, ex. if the issue turns out to be how virsh(1) i
On 7/12/24 13:46, Joao Martins wrote:
In preparation to moving HostIOMMUDevice realize() being able to called
early during attach_device(), remove properties that rely on container
being initialized.
This means removing caps::aw_bits which requires the
bcontainer::iova_ranges to be inititalized
On Mon, 15 Jul 2024 at 18:57, Peter Xu wrote:
> I think it shouldn't be a major deal in most cases, if the extended cycles
> only cover a bunch of instructions. In special case we can still use
> WITH_QEMU_LOCK_GUARD, but I'd start with the simple first and only switch
> if necessary.
* Okay, wil
On 7/12/24 13:46, Joao Martins wrote:
Fetch IOMMU hw raw caps behind the device and thus move the
HostIOMMUDevice::realize() to be done during the attach of the device. It
allows it to cache the information obtained from IOMMU_GET_HW_INFO from
iommufd early on. However, while legacy HostIOMMUDevi
On Mon, 15 Jul 2024 22:41:21 +0530
Sunil V L wrote:
> As per the requirement ACPI_080 in the RISC-V Boot and Runtime Services
> (BRS) specification [1], PLIC and APLIC should be in namespace as well.
> So, add them using the defined HID.
>
> [1] - https://github.com/riscv-non-isa/riscv-brs/blob
On Mon, 15 Jul 2024 22:41:22 +0530
Sunil V L wrote:
> The requirement ACPI_060 in the RISC-V BRS specification [1], requires
> NS16550 compatible UART to have the HID RSCV0003. So, update the HID for
> the UART.
>
> [1] - https://github.com/riscv-non-isa/riscv-brs/commits/main/acpi.adoc
this sho
On Mon, 15 Jul 2024 22:41:24 +0530
Sunil V L wrote:
> Currently, PCI link devices (PNP0C0F) are always created within the
> scope of the PCI root bridge. However, RISC-V needs these link devices
> to be created outside to ensure the probing order in the OS. This
> matches the example given in the
On Sat, 13 Jul 2024 at 17:04, SamJakob wrote:
>
> It is common practice when implementing double-buffering
> on VideoCore to do so by multiplying the height of the
> virtual buffer by the number of virtual screens desired
> (i.e., two - in the case of double-bufferr
On 16/07/2024 11:20, Cédric Le Goater wrote:
> On 7/12/24 13:46, Joao Martins wrote:
>> Fetch IOMMU hw raw caps behind the device and thus move the
>> HostIOMMUDevice::realize() to be done during the attach of the device. It
>> allows it to cache the information obtained from IOMMU_GET_HW_INFO from
On Sun, 14 Jul 2024 at 11:43, Akihiko Odaki wrote:
>
> Signed-off-by: Akihiko Odaki
> ---
> target/arm/gdbstub.c | 9 ++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/target/arm/gdbstub.c b/target/arm/gdbstub.c
> index c3a9b5eb1ed2..03f77362efc1 100644
> --- a/target/
On Tue, Jul 16, 2024 at 11:56 AM Daniel P. Berrangé wrote:
>
> On Tue, Jul 16, 2024 at 11:06:57AM +0300, Michael Tokarev wrote:
> > 16.07.2024 10:27, Akihiko Odaki wrote:
> > > qemu_get_runtime_dir() returns a dynamically allocated directory path
> > > that is appropriate for storing runtime files
On 7/13/24 13:54, TaiseiIto wrote:
Before this commit, there are 3 problems about HPET timer interrupts. First,
HPET periodic timers cause a too early interrupt before HPET main counter
value reaches a value written its comparator value register. Second,
disabled HPET timers whose comparator valu
On 2024/07/16 18:53, Daniel P. Berrangé wrote:
On Tue, Jul 16, 2024 at 04:27:31PM +0900, Akihiko Odaki wrote:
qemu_get_runtime_dir() returns a dynamically allocated directory path
that is appropriate for storing runtime files. It corresponds to "run"
directory in Unix.
With a tree-wide search,
On Tue, Jul 16, 2024 at 07:52:00PM +0900, Akihiko Odaki wrote:
> On 2024/07/16 18:53, Daniel P. Berrangé wrote:
> > On Tue, Jul 16, 2024 at 04:27:31PM +0900, Akihiko Odaki wrote:
> > > qemu_get_runtime_dir() returns a dynamically allocated directory path
> > > that is appropriate for storing runtim
Peter Maydell writes:
> On Sun, 14 Jul 2024 at 11:43, Akihiko Odaki wrote:
>>
>> Signed-off-by: Akihiko Odaki
>> ---
>> target/arm/gdbstub.c | 9 ++---
>> 1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/target/arm/gdbstub.c b/target/arm/gdbstub.c
>> index c3a9b5eb1ed2..0
[Note: References are present at the last after the revision history]
Virtual CPU hotplug support is being added across various architectures [1][3].
This series adds various code bits common across all architectures:
1. vCPU creation and Parking code refactor [Patch 1]
2. Update ACPI GED framewo
CPU ctrl-dev MMIO region length could be used in ACPI GED and various other
architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more
appropriate common header file.
Signed-off-by: Salil Mehta
Reviewed-by: Alex Bennée
Reviewed-by: Jonathan Cameron
Reviewed-by: Gavin Shan
Review
CPUs Control device(\\_SB.PCI0) register interface for the x86 arch is IO port
based and existing CPUs AML code assumes _CRS objects would evaluate to a system
resource which describes IO Port address. But on ARM arch CPUs control
device(\\_SB.PRES) register interface is memory-mapped hence _CRS ob
OSPM evaluates _EVT method to map the event. The CPU hotplug event eventually
results in start of the CPU scan. Scan figures out the CPU and the kind of
event(plug/unplug) and notifies it back to the guest. Update the GED AML _EVT
method with the call to method \\_SB.CPUS.CSCN (via \\_SB.GED.CSCN)
KVM vCPU creation is done once during the vCPU realization when Qemu vCPU thread
is spawned. This is common to all the architectures as of now.
Hot-unplug of vCPU results in destruction of the vCPU object in QOM but the
corresponding KVM vCPU object in the Host KVM is not destroyed as KVM doesn't
Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also
involves destruction of the CPU AddressSpace. Add common function to help
destroy the CPU AddressSpace.
Signed-off-by: Salil Mehta
Tested-by: Vishnu Pajjuri
Reviewed-by: Gavin Shan
Tested-by: Xianglai Li
Tested-by: Miguel
ACPI GED (as described in the ACPI 6.4 spec) uses an interrupt listed in the
_CRS object of GED to intimate OSPM about an event. Later then demultiplexes the
notified event by evaluating ACPI _EVT method to know the type of event. Use
ACPI GED to also notify the guest kernel about any CPU hot(un)pl
Add common function to help unregister the GDB register space. This shall be
done in context to the CPU unrealization.
Note: These are common functions exported to arch specific code. For example,
for ARM this code is being referred in associated arch specific patch-set:
Link:
https://lore.kerne
The Avocado v88 that we use in QEMU is already on a life support
system: It is not supported by upstream anymore, and with the latest
versions of Python, it won't work anymore since it depends on the
"imp" module that has been removed in Python 3.12.
There have been several attempts to update the
Now that we've got a working fetch_asset() function, we can convert
some Avocado tests that use this function for downloading their
required files.
Signed-off-by: Thomas Huth
---
MAINTAINERS | 12 +++
tests/functional/meson.build | 25 ++
These test are rather simple and don't need any modifications apart
from adjusting the "from avocado_qemu" line. To ease debugging, make
the files executable and add a shebang line and Python '__main__'
handling, too, so that these tests can now be run by executing them
directly.
Signed-off-by: Th
On 2024/07/16 19:54, Daniel P. Berrangé wrote:
On Tue, Jul 16, 2024 at 07:52:00PM +0900, Akihiko Odaki wrote:
On 2024/07/16 18:53, Daniel P. Berrangé wrote:
On Tue, Jul 16, 2024 at 04:27:31PM +0900, Akihiko Odaki wrote:
qemu_get_runtime_dir() returns a dynamically allocated directory path
that
Create log files for each test separately, one file that contains
the basic logging and one that contains the console output.
Signed-off-by: Thomas Huth
---
tests/functional/qemu_test/__init__.py | 24 +++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/tests/f
These tests use archive.lzma_uncompress() from the Avocado utils,
so provide a small helper function for this, based on the
standard lzma module from Python instead.
And while we're at it, replace the MD5 hashes in the topology test
with proper SHA256 hashes, since MD5 should not be used anymore
n
Integrate the new python-based test framework with the meson build
system. Since these tests now require the pycotap module, make
sure that it gets installed in the venv.
The changes to the meson.build files are partly based on an earlier
patch by Ani Sinha (but heavily modified by Thomas Huth e.g
Now that we converted many tests from the "check-avocado" test suite
to the "check-functional" test suite, we should make sure that these
also get tested in the CI.
Signed-off-by: Thomas Huth
---
.gitlab-ci.d/buildtest-template.yml | 3 +-
.gitlab-ci.d/buildtest.yml | 60 ++
These simple tests can be converted to stand-alone tests quite easily,
e.g. by just setting the machine to 'none' now manually or by adding
"-cpu" command line parameters, since we don't support the corresponding
avocado tags in the new python test framework.
Signed-off-by: Thomas Huth
---
.../t
1 - 100 of 426 matches
Mail list logo
