Re: Disassembler location

2024-07-11 Thread Rot127
Fyi please note that LoongArch support was recently added to Capstone (https://github.com/capstone-engine/capstone/pull/2349). Also, if you want to add support for a new architecture in Capstone and it is supported in LLVM, you can use our new Auto-Sync updater. See https://github.com/capstone

Re: [PATCH] MAINTAINERS: add Edgar as Xen maintainer

2024-07-11 Thread Edgar E. Iglesias
On Wed, Jul 10, 2024 at 10:28 PM Stefano Stabellini wrote: > Add Edgar as Xen subsystem maintainer in QEMU. Edgar has been a QEMU > maintainer for years, and has already made key changes to one of the > most difficult areas of the Xen subsystem (the mapcache). > > Edgar volunteered helping us mai

Re: [PATCH] MAINTAINERS: add Edgar as Xen maintainer

2024-07-11 Thread Paul Durrant
On 10/07/2024 22:28, Stefano Stabellini wrote: Add Edgar as Xen subsystem maintainer in QEMU. Edgar has been a QEMU maintainer for years, and has already made key changes to one of the most difficult areas of the Xen subsystem (the mapcache). Edgar volunteered helping us maintain the Xen subsyst

[PATCH] loader: remove load_image_gzipped function as its not used anywhere

2024-07-11 Thread Ani Sinha
load_image_gzipped() does not seem to be used anywhere. Remove it. Signed-off-by: Ani Sinha --- hw/core/loader.c| 13 - include/hw/loader.h | 4 +--- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index a3bea1e718..c04fae55c0 1

Re: [RFC PATCH v4] ptp: Add vDSO-style vmclock support

2024-07-11 Thread Peter Hilber via
On 10.07.24 18:01, David Woodhouse wrote: > On Wed, 2024-07-10 at 15:07 +0200, Peter Hilber wrote: >> On 08.07.24 11:27, David Woodhouse wrote: >>> From: David Woodhouse >>> >>> The vmclock "device" provides a shared memory region with precision clock >>> information. By using shared memory, it is

Re: More than 255 vcpus Windows VM setup without viommu ?

2024-07-11 Thread David Woodhouse
On Mon, 2024-07-08 at 10:13 +0100, David Woodhouse wrote: > On Wed, 2024-07-03 at 16:01 +, Sandesh Patel wrote: > > > > > > Interesting. What exactly has Windows *done* in those MSI entries? > > > That might give a clue about how to support it. I repeated my experiment with interrupt-only rem

[PATCH v1] virtio-snd: check for invalid param shift operands

2024-07-11 Thread Manos Pitsidianakis
When setting the parameters of a PCM stream, we compute the bit flag with the format and rate values as shift operand to check if they are set in supported_formats and supported_rates. If the guest provides a format/rate value which when shifting 1 results in a value bigger than the number of bits

Re: [PATCH v3 00/10] hw/vfio: IOMMUFD Dirty Tracking

2024-07-11 Thread Cédric Le Goater
Hello Joao, On 7/8/24 4:34 PM, Joao Martins wrote: This small series adds support for IOMMU dirty tracking support via the IOMMUFD backend. The hardware capability is available on most recent x86 hardware. The series is divided organized as follows: * Patch 1: Fixes a regression into mdev suppo

Re: [RFC PATCH v2 1/5] vhost-user: Add VIRTIO Shared Memory map request

2024-07-11 Thread Stefan Hajnoczi
On Fri, Jun 28, 2024 at 04:57:06PM +0200, Albert Esteve wrote: > Add SHMEM_MAP/UNMAP requests to vhost-user to > handle VIRTIO Shared Memory mappings. > > This request allows backends to dynamically map > fds into a VIRTIO Shared Memory Region indentified > by its `shmid`. Then, the fd memory is a

[PATCH] smbios: make memory device size configurable per Machine

2024-07-11 Thread Igor Mammedov
Currently SMBIOS maximum memory device chunk is capped at 16Gb, which is fine for the most cases (QEMU uses it to describe initial RAM (type 17 SMBIOS table entries)). However when starting guest with terabytes of RAM this leads to too many memory device structures, which eventually upsets linux ke

Re: [RFC PATCH v4] ptp: Add vDSO-style vmclock support

2024-07-11 Thread David Woodhouse
On Thu, 2024-07-11 at 09:25 +0200, Peter Hilber wrote: > > IMHO this phrasing is better, since it directly refers to the state of the > structure. Thanks. I'll update it. > AFAIU if there would be abnormal delays in store buffers, causing some > driver to still see the old clock for some time, t

Re: [PATCH] contrib/elf2dmp: a workaround for the buggy msvcrt.dll!fwrite

2024-07-11 Thread Akihiko Odaki
On 2024/07/10 17:02, hellord wrote: On Tue, Jul 9, 2024 at 10:39 PM Peter Maydell mailto:peter.mayd...@linaro.org>> wrote: > +#define MAX_CHUNK_SIZE (128 * 1024 * 1024) I think we could add a comment here, something like: /*  * Maximum size to fwrite() to the output

[PULL 0/9] loongarch-to-apply queue

2024-07-11 Thread Song Gao
-loongarch-20240711 for you to fetch changes up to 78341408e705e1b8dc92eaae2071ae0023d586b0: target/loongarch: Fix cpu_reset set wrong CSR_CRMD (2024-07-11 15:56:50 +0800) pull-loongarc

[PULL 6/9] target/loongarch/kvm: Add software breakpoint support

2024-07-11 Thread Song Gao
From: Bibo Mao With KVM virtualization, debug exception is injected to guest kernel rather than host for normal break intruction. Here hypercall instruction with special code is used for sw breakpoint usage, and detailed instruction comes from kvm kernel with user API KVM_REG_LOONGARCH_DEBUG_INST

[PULL 3/9] hw/loongarch: Modify flash block size to 256K

2024-07-11 Thread Song Gao
From: Xianglai Li loongarch added a common library for edk2 to parse flash base addresses through fdt. For compatibility with other architectures, the flash block size in qemu is now changed to 256k. Signed-off-by: Xianglai Li Reviewed-by: Song Gao Message-Id: <20240624033319.999631-1-lixiang.

[PULL 5/9] MAINTAINERS: Add myself as a reviewer of LoongArch virt machine

2024-07-11 Thread Song Gao
From: Jiaxun Yang I would like to be informed on changes made to the LoongArch virt machine. I'm fairly familiar with Loongson-3 series platform hardware and doing firmwre (U-Boot) development as hobbyist on LoongArch virt platform, so I believe I can give positive review input to changes on tha

[PULL 1/9] hw/loongarch/boot.c: fix out-of-bound reading

2024-07-11 Thread Song Gao
From: Dmitry Frolov memcpy() is trying to READ 512 bytes from memory, pointed by info->kernel_cmdline, which was (presumable) allocated by g_strdup(""); Found with ASAN, making check with enabled sanitizers. Signed-off-by: Dmitry Frolov Reviewed-by: Song Gao Message-Id: <20240628123910.577740-

[PULL 4/9] hw/loongarch/virt: Remove unused assignment

2024-07-11 Thread Song Gao
From: Bibo Mao There is abuse usage about local variable gap. Remove duplicated assignment and solve Coverity reported error. Resolves: Coverity CID 1546441 Fixes: 3cc451cbce ("hw/loongarch: Refine fwcfg memory map") Signed-off-by: Bibo Mao Reviewed-by: Song Gao Message-Id: <20240612033637.167

[PULL 9/9] target/loongarch: Fix cpu_reset set wrong CSR_CRMD

2024-07-11 Thread Song Gao
After cpu_reset, DATF in CSR_CRMD is 0, DATM is 0. See the manual[1] 6.4. [1]: https://github.com/loongson/LoongArch-Documentation/releases/download/2023.04.20/LoongArch-Vol1-v1.10-EN.pdf Signed-off-by: Song Gao Reviewed-by: Bibo Mao Message-Id: <20240705021839.1004374-2-gaos...@loongson.cn>

[PULL 8/9] target/loongarch: Set CSR_PRCFG1 and CSR_PRCFG2 values

2024-07-11 Thread Song Gao
We set the value of register CSR_PRCFG3, but left out CSR_PRCFG1 and CSR_PRCFG2. Set CSR_PRCFG1 and CSR_PRCFG2 according to the default values of the physical machine. Signed-off-by: Song Gao Reviewed-by: Bibo Mao Message-Id: <20240705021839.1004374-1-gaos...@loongson.cn> --- target/loongarch/c

[PULL 2/9] hw/loongarch: Change the tpm support by default

2024-07-11 Thread Song Gao
From: Xianglai Li Add devices that support tpm by default, Fixed incomplete tpm acpi table information. Signed-off-by: Xianglai Li Reviewed-by: Song Gao Message-Id: <20240624032300.999157-1-lixiang...@loongson.cn> Signed-off-by: Song Gao --- hw/loongarch/Kconfig | 1 + hw/loongarch/acpi

[PULL 7/9] target/loongarch: Remove avail_64 in trans_srai_w() and simplify it

2024-07-11 Thread Song Gao
From: Feiyang Chen Since srai.w is a valid instruction on la32, remove the avail_64 check and simplify trans_srai_w(). Fixes: c0c0461e3a06 ("target/loongarch: Add avail_64 to check la64-only instructions") Reviewed-by: Richard Henderson Signed-off-by: Feiyang Chen Message-Id: <20240628033357.

Re: [RFC PATCH v2 2/5] vhost_user: Add frontend command for shmem config

2024-07-11 Thread Stefan Hajnoczi
On Fri, Jun 28, 2024 at 04:57:07PM +0200, Albert Esteve wrote: > The frontend can use this command to retrieve > VIRTIO Shared Memory Regions configuration from > the backend. The response contains the number of > shared memory regions, their size, and shmid. > > This is useful when the frontend i

Re: [RFC PATCH v4 2/7] rust: add bindgen step as a meson dependency

2024-07-11 Thread Zhao Liu
On Wed, Jul 10, 2024 at 04:50:10PM +0200, Paolo Bonzini wrote: > Date: Wed, 10 Jul 2024 16:50:10 +0200 > From: Paolo Bonzini > Subject: Re: [RFC PATCH v4 2/7] rust: add bindgen step as a meson dependency > > On Wed, Jul 10, 2024 at 4:48 PM Zhao Liu wrote: > > > > On Tue, Jul 09, 2024 at 02:28:38

Re: [RFC PATCH v2 2/5] vhost_user: Add frontend command for shmem config

2024-07-11 Thread Stefan Hajnoczi
On Fri, Jun 28, 2024 at 04:57:07PM +0200, Albert Esteve wrote: > The frontend can use this command to retrieve > VIRTIO Shared Memory Regions configuration from > the backend. The response contains the number of > shared memory regions, their size, and shmid. > > This is useful when the frontend i

Re: [PATCH ats_vtd v5 20/22] pci: add a pci-level API for ATS

2024-07-11 Thread Minwoo Im
On 24-07-10 05:17:42, CLEMENT MATHIEU--DRIF wrote: > > > On 09/07/2024 23:17, Minwoo Im wrote: > > Caution: External email. Do not open attachments or click links, unless > > this email comes from a known sender and you know the content is safe. > > > > > > On 24-07-09 11:58:53, CLEMENT MATHIEU-

Re: [PATCH] smbios: make memory device size configurable per Machine

2024-07-11 Thread Philippe Mathieu-Daudé
Hi Igor, On 11/7/24 09:48, Igor Mammedov wrote: Currently SMBIOS maximum memory device chunk is capped at 16Gb, which is fine for the most cases (QEMU uses it to describe initial RAM (type 17 SMBIOS table entries)). However when starting guest with terabytes of RAM this leads to too many memory

Re: [PATCH v1] virtio-snd: check for invalid param shift operands

2024-07-11 Thread Philippe Mathieu-Daudé
On 11/7/24 09:38, Manos Pitsidianakis wrote: When setting the parameters of a PCM stream, we compute the bit flag with the format and rate values as shift operand to check if they are set in supported_formats and supported_rates. If the guest provides a format/rate value which when shifting 1 re

Re: [RFC PATCH v2 3/5] vhost-user-dev: Add cache BAR

2024-07-11 Thread Stefan Hajnoczi
On Fri, Jun 28, 2024 at 04:57:08PM +0200, Albert Esteve wrote: > Add a cache BAR in the vhost-user-device > into which files can be directly mapped. > > The number, shmid, and size of the VIRTIO Shared > Memory subregions is retrieved through a get_shmem_config > message sent by the vhost-user-bas

Re: [PATCH v3 00/10] hw/vfio: IOMMUFD Dirty Tracking

2024-07-11 Thread Joao Martins
On 11/07/2024 08:41, Cédric Le Goater wrote: > Hello Joao, > > On 7/8/24 4:34 PM, Joao Martins wrote: >> This small series adds support for IOMMU dirty tracking support via the >> IOMMUFD backend. The hardware capability is available on most recent x86 >> hardware. The series is divided organized

Re: [PATCH V13 4/8] hw/acpi: Update GED _EVT method AML with CPU scan

2024-07-11 Thread Igor Mammedov
On Thu, 11 Jul 2024 03:29:40 + Salil Mehta wrote: > Hi Igor, > > > On 06/07/2024 14:28, Igor Mammedov wrote: > > On Fri, 7 Jun 2024 12:56:45 +0100 > > Salil Mehta wrote: > > > >> OSPM evaluates _EVT method to map the event. The CPU hotplug event > >> eventually > >> results in start of

Re: [PATCH] MAINTAINERS: add Edgar as Xen maintainer

2024-07-11 Thread Anthony PERARD
On Wed, Jul 10, 2024 at 01:28:52PM -0700, Stefano Stabellini wrote: > Add Edgar as Xen subsystem maintainer in QEMU. Edgar has been a QEMU > maintainer for years, and has already made key changes to one of the > most difficult areas of the Xen subsystem (the mapcache). > > Edgar volunteered helpin

Re: [PATCH v2 09/15] memory: Do not create circular reference with subregion

2024-07-11 Thread Akihiko Odaki
On 2024/07/09 1:40, Peter Xu wrote: On Mon, Jul 08, 2024 at 10:06:44AM +0200, Philippe Mathieu-Daudé wrote: On 6/7/24 13:59, Akihiko Odaki wrote: On 2024/07/03 2:44, Peter Xu wrote: On Thu, Jun 27, 2024 at 10:37:52PM +0900, Akihiko Odaki wrote: A memory region does not use their own reference

Re: [PATCH] smbios: make memory device size configurable per Machine

2024-07-11 Thread Igor Mammedov
On Thu, 11 Jul 2024 10:19:27 +0200 Philippe Mathieu-Daudé wrote: > Hi Igor, > > On 11/7/24 09:48, Igor Mammedov wrote: > > Currently SMBIOS maximum memory device chunk is capped at 16Gb, > > which is fine for the most cases (QEMU uses it to describe initial > > RAM (type 17 SMBIOS table entries)

Re: [PATCH] smbios: make memory device size configurable per Machine

2024-07-11 Thread Daniel P . Berrangé
On Thu, Jul 11, 2024 at 09:48:22AM +0200, Igor Mammedov wrote: > Currently SMBIOS maximum memory device chunk is capped at 16Gb, > which is fine for the most cases (QEMU uses it to describe initial > RAM (type 17 SMBIOS table entries)). > However when starting guest with terabytes of RAM this leads

Re: [PATCH v5 0/3] vhost-user-blk: live resize additional APIs

2024-07-11 Thread Vladimir Sementsov-Ogievskiy
ping. Markus, Eric, could someone give an ACC for QAPI part? On 25.06.24 15:18, Vladimir Sementsov-Ogievskiy wrote: v5: 03: drop extra check on is is runstate running Vladimir Sementsov-Ogievskiy (3): qdev-monitor: add option to report GenericError from find_device_state vhost-user-blk:

Re: [RFC PATCH v2 4/5] vhost_user: Add MEM_READ/WRITE backend requests

2024-07-11 Thread Stefan Hajnoczi
On Fri, Jun 28, 2024 at 04:57:09PM +0200, Albert Esteve wrote: > With SHMEM_MAP messages, sharing descriptors between > devices will cause that these devices do not see the > mappings, and fail to access these memory regions. > > To solve this, introduce MEM_READ/WRITE requests > that will get tri

Re: [PATCH] arm/kvm: add support for MTE

2024-07-11 Thread Ganapatrao Kulkarni
On 10-07-2024 09:12 pm, Cornelia Huck wrote: On Mon, Jul 08 2024, Ganapatrao Kulkarni wrote: Extend the 'mte' property for the virt machine to cover KVM as well. For KVM, we don't allocate tag memory, but instead enable the capability. If MTE has been enabled, we need to disable migration

Re: [RFC PATCH v2 5/5] vhost_user: Implement mem_read/mem_write handlers

2024-07-11 Thread Stefan Hajnoczi
On Fri, Jun 28, 2024 at 04:57:10PM +0200, Albert Esteve wrote: > Implement function handlers for memory read and write > operations. > > Signed-off-by: Albert Esteve > --- > hw/virtio/vhost-user.c | 34 ++ > 1 file changed, 30 insertions(+), 4 deletions(-) > > di

Re: [RFC PATCH v2 0/5] vhost-user: Add SHMEM_MAP/UNMAP requests

2024-07-11 Thread Stefan Hajnoczi
On Fri, Jun 28, 2024 at 04:57:05PM +0200, Albert Esteve wrote: > Hi all, > > v1->v2: > - Corrected typos and clarifications from > first review > - Added SHMEM_CONFIG frontend request to > query VIRTIO shared memory regions from > backends > - vhost-user-device to use SHMEM_CONFIG > to req

Re: [PATCH v3 1/2] qemu-iotest/245: Add missing discard=unmap

2024-07-11 Thread Stefan Hajnoczi
On Fri, Jun 28, 2024 at 11:20:57PM +0300, Nir Soffer wrote: > The test works since we punch holes by default even when opening the > image without discard=on or discard=unmap. Fix the test to enable > discard. > --- > tests/qemu-iotests/245 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v3 2/2] Consider discard option when writing zeros

2024-07-11 Thread Stefan Hajnoczi
On Fri, Jun 28, 2024 at 11:20:58PM +0300, Nir Soffer wrote: > When opening an image with discard=off, we punch hole in the image when > writing zeroes, making the image sparse. This breaks users that want to > ensure that writes cannot fail with ENOSPACE by using fully allocated > images[1]. > > b

Re: [PATCH v3 0/2] Consider discard option when writing zeros

2024-07-11 Thread Stefan Hajnoczi
On Fri, Jun 28, 2024 at 11:20:56PM +0300, Nir Soffer wrote: > Punch holes only when the image is opened with discard=on or discard=unmap. > > Tested by: > - new write-zeroes-unmap iotest on xfs, ext4, and tmpfs > - tests/qemu-iotests/check -raw > - tests/qemu-iotests/check -qcow2 > > Changes sinc

[PULL 0/2] Block patches

2024-07-11 Thread Stefan Hajnoczi
The following changes since commit 59084feb256c617063e0dbe7e64821ae8852d7cf: Merge tag 'pull-aspeed-20240709' of https://github.com/legoater/qemu into staging (2024-07-09 07:13:55 -0700) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request fo

[PULL 1/2] qemu-iotest/245: Add missing discard=unmap

2024-07-11 Thread Stefan Hajnoczi
From: Nir Soffer The test works since we punch holes by default even when opening the image without discard=on or discard=unmap. Fix the test to enable discard. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/245 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/q

[PULL 2/2] Consider discard option when writing zeros

2024-07-11 Thread Stefan Hajnoczi
From: Nir Soffer When opening an image with discard=off, we punch hole in the image when writing zeroes, making the image sparse. This breaks users that want to ensure that writes cannot fail with ENOSPACE by using fully allocated images[1]. bdrv_co_pwrite_zeroes() correctly disables BDRV_REQ_MA

Re: [PATCH] smbios: make memory device size configurable per Machine

2024-07-11 Thread Igor Mammedov
On Thu, 11 Jul 2024 09:43:46 +0100 Daniel P. Berrangé wrote: > On Thu, Jul 11, 2024 at 09:48:22AM +0200, Igor Mammedov wrote: > > Currently SMBIOS maximum memory device chunk is capped at 16Gb, > > which is fine for the most cases (QEMU uses it to describe initial > > RAM (type 17 SMBIOS table en

[PATCH] chardev: add a mutex to protect IOWatchPoll::src

2024-07-11 Thread Sergey Dyasli
After 038b4217884c ("Revert "chardev: use a child source for qio input source"") we've been observing the "iwp->src == NULL" assertion triggering periodically during the initial capabilities querying by libvirtd. One of possible backtraces: Thread 1 (Thread 0x7f16cd4f0700 (LWP 43858)): 0 __GI_rai

[PATCH 2/6] acpi/ghes: Support GPIO error source.

2024-07-11 Thread Mauro Carvalho Chehab
From: Jonathan Cameron Add error notification to GHES v2 using the GPIO source. Signed-off-by: Jonathan Cameron Signed-off-by: Mauro Carvalho Chehab --- hw/acpi/ghes.c | 8 ++-- include/hw/acpi/ghes.h | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/acpi/gh

[PATCH 4/6] target/arm: preserve mpidr value

2024-07-11 Thread Mauro Carvalho Chehab
There is a logic at helper to properly fill the mpidr information. This is needed for ARM Processor error injection, so store the value inside a cpu opaque value, to allow it to be used. Signed-off-by: Mauro Carvalho Chehab --- target/arm/cpu.h| 1 + target/arm/helper.c | 10 -- 2 f

[PATCH 5/6] acpi/ghes: update comments to point to newer ACPI specs

2024-07-11 Thread Mauro Carvalho Chehab
There is one reference to ACPI 4.0 and several references to ACPI 6.x versions. Update them to point to ACPI 6.5 whenever possible. There's one reference that was kept pointing to ACPI 6.4, though, with HEST revision 1. ACPI 6.5 now defines HEST revision 2, and defined a new way to handle source

[PATCH 6/6] acpi/ghes: extend arm error injection logic

2024-07-11 Thread Mauro Carvalho Chehab
Enrich CPER error injection logic for ARM processor to allow setting values to from UEFI 2.10 tables N.16 and N.17. It should be noticed that, with such change, all arguments are now optional, so, once QMP is negotiated with: { "execute": "qmp_capabilities" } the simplest way to generat

[PATCH 1/6] arm/virt: Wire up GPIO error source for ACPI / GHES

2024-07-11 Thread Mauro Carvalho Chehab
From: Jonathan Cameron Creates a GED - Generic Event Device and set a GPIO to be used or error injection. Signed-off-by: Jonathan Cameron Signed-off-by: Mauro Carvalho Chehab --- hw/arm/virt-acpi-build.c | 29 + hw/arm/virt.c| 12 +++- include/h

[PATCH 3/6] acpi/ghes: Add a logic to handle block addresses and FW first ARM processor error injection

2024-07-11 Thread Mauro Carvalho Chehab
From: Jonathan Cameron 1. Some GHES functions require handling addresses. Add a helper function to support it. 2. Add support for ACPI CPER (firmware-first) ARM processor error injection. Compliance with N.2.4.4 ARM Processor Error Section in UEFI 2.6 and upper specs, using error type bit en

[PATCH 0/6] Add ACPI CPER firmware first error injection for Arm Processor

2024-07-11 Thread Mauro Carvalho Chehab
Testing OS kernel ACPI APEI CPER support is tricky, as one depends on having hardware with special-purpose BIOS and/or hardware. With QEMU, it becomes a lot easier, as it can be done via QMP. This series add support for ARM Processor CPER error injection, according with ACPI 6.x and UEFI 2.9A/2.1

Re: [PULL 0/9] loongarch-to-apply queue

2024-07-11 Thread Philippe Mathieu-Daudé
https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20240711 for you to fetch changes up to 78341408e705e1b8dc92eaae2071ae0023d586b0: target/loongarch: Fix cpu_reset set wrong CSR_CRMD (2024-07-11 15:56:50 +0800) pull-loongarc

Re: [PATCH v2] plugins/stoptrigger: TCG plugin to stop execution under conditions

2024-07-11 Thread Alex Bennée
Simon Hamelin writes: > This new plugin allows to stop emulation using conditions on the > emulation state. By setting this plugin arguments, it is possible > to set an instruction count limit and/or trigger address(es) to stop at. > The code returned at emulation exit can be customized. > > This

Re: [RESEND PATCH 0/6] target/arm: AdvSIMD decodetree conversion, part 3

2024-07-11 Thread Peter Maydell
On Tue, 9 Jul 2024 at 01:06, Richard Henderson wrote: > > [Sorry about the @qemu.prg typo; resend for anyone replying.] > > A small set, but better than waiting for a larger set. > It's a good stopping point, finishing the convertion of > > disas_simd_three_reg_diff > disas_simd_scalar_three_r

Re: [PATCH] MAINTAINERS: add Edgar as Xen maintainer

2024-07-11 Thread Alex Bennée
Stefano Stabellini writes: > Add Edgar as Xen subsystem maintainer in QEMU. Edgar has been a QEMU > maintainer for years, and has already made key changes to one of the > most difficult areas of the Xen subsystem (the mapcache). > > Edgar volunteered helping us maintain the Xen subsystem in QEMU

Re: [PATCH 1/1] target/arm: calculate cache sizes properly

2024-07-11 Thread Peter Maydell
On Wed, 10 Jul 2024 at 18:35, Marcin Juszkiewicz wrote: > > Neoverse-V1 TRM says that NumSets are [27:13] not :32 like in code. NumSets in fields [27:13] is the 32-bit CCSIDR_EL1 format (i.e. what you have when FEAT_CCIDX is not implemented). The make_ccsidr64() function provides the 64-bit CCSID

RE: [PATCH v3 00/10] hw/vfio: IOMMUFD Dirty Tracking

2024-07-11 Thread Duan, Zhenzhong
>-Original Message- >From: Joao Martins >Subject: Re: [PATCH v3 00/10] hw/vfio: IOMMUFD Dirty Tracking > >On 11/07/2024 08:41, Cédric Le Goater wrote: >> Hello Joao, >> >> On 7/8/24 4:34 PM, Joao Martins wrote: >>> This small series adds support for IOMMU dirty tracking support via the >

Re: [PATCH] loader: remove load_image_gzipped function as its not used anywhere

2024-07-11 Thread Peter Maydell
On Thu, 11 Jul 2024 at 08:25, Ani Sinha wrote: > > load_image_gzipped() does not seem to be used anywhere. Remove it. > > Signed-off-by: Ani Sinha > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v3 00/10] hw/vfio: IOMMUFD Dirty Tracking

2024-07-11 Thread Joao Martins
On 11/07/2024 11:22, Duan, Zhenzhong wrote: > > >> -Original Message- >> From: Joao Martins >> Subject: Re: [PATCH v3 00/10] hw/vfio: IOMMUFD Dirty Tracking >> >> On 11/07/2024 08:41, Cédric Le Goater wrote: >>> Hello Joao, >>> >>> On 7/8/24 4:34 PM, Joao Martins wrote: This small s

Re: [PATCH 1/1] target/arm: calculate cache sizes properly

2024-07-11 Thread Marcin Juszkiewicz
On 11.07.2024 12:19, Peter Maydell wrote: On Wed, 10 Jul 2024 at 18:35, Marcin Juszkiewicz wrote: Neoverse-V1 TRM says that NumSets are [27:13] not :32 like in code. NumSets in fields [27:13] is the 32-bit CCSIDR_EL1 format (i.e. what you have when FEAT_CCIDX is not implemented). The make_cc

Re: [PATCH V13 4/8] hw/acpi: Update GED _EVT method AML with CPU scan

2024-07-11 Thread Salil Mehta
On 11/07/2024 08:34, Igor Mammedov wrote: On Thu, 11 Jul 2024 03:29:40 + Salil Mehta wrote: Hi Igor, On 06/07/2024 14:28, Igor Mammedov wrote: On Fri, 7 Jun 2024 12:56:45 +0100 Salil Mehta wrote: OSPM evaluates _EVT method to map the event. The CPU hotplug event eventually result

Re: [RFC PATCH v2 0/5] vhost-user: Add SHMEM_MAP/UNMAP requests

2024-07-11 Thread Alyssa Ross
Adding David Stevens, who implemented SHMEM_MAP and SHMEM_UNMAP in crosvm a couple of years ago. David, I'd be particularly interested for your thoughts on the MEM_READ and MEM_WRITE commands, since as far as I know crosvm doesn't implement anything like that. The discussion leading to those bein

Re: [PATCH v48 00/12] hw/sd/sdcard: Add eMMC support

2024-07-11 Thread Cédric Le Goater
Hello, On 7/10/24 4:13 PM, Philippe Mathieu-Daudé wrote: Tag to test Aspeed tree: https://gitlab.com/philmd/qemu/-/tags/aspeed_emmc-v8 I gave this branch a try and the rainier machine boots correctly with a baked emmc image : Tested-by: Cédric Le Goater However, I am seeing a *lot* of

Re: [PATCH] smbios: make memory device size configurable per Machine

2024-07-11 Thread Michael S. Tsirkin
On Thu, Jul 11, 2024 at 09:48:22AM +0200, Igor Mammedov wrote: > Currently SMBIOS maximum memory device chunk is capped at 16Gb, > which is fine for the most cases (QEMU uses it to describe initial > RAM (type 17 SMBIOS table entries)). > However when starting guest with terabytes of RAM this leads

[PATCH 0/5] qapi: Doc comment cleanups

2024-07-11 Thread Markus Armbruster
Markus Armbruster (5): qapi/pci: Clean up documentation around PciDeviceClass qapi/machine: Clean up documentation around CpuInstanceProperties qapi/machine: Clarify query-uuid value when none has been specified qapi/sockets: Move deprecation note out of SocketAddress doc comment qapi/ui:

[PATCH 1/5] qapi/pci: Clean up documentation around PciDeviceClass

2024-07-11 Thread Markus Armbruster
PciDeviceInfo's doc comment has a note on PciDeviceClass member @desc. Since the note applies always, not just within PciDeviceInfo, merge it into PciDeviceClass's description of member @desc. Signed-off-by: Markus Armbruster --- qapi/pci.json | 6 ++ 1 file changed, 2 insertions(+), 4 delet

[PATCH 5/5] qapi/ui: Drop note on naming of SpiceQueryMouseMode

2024-07-11 Thread Markus Armbruster
Doc comments are reference documentation for users of QMP. SpiceQueryMouseMode's doc comment contains a note explaining why it's not named SpiceMouseMode: spice/enums.h has it already. Irrelevant for users of QMP; delete the note. Signed-off-by: Markus Armbruster --- qapi/ui.json | 2 -- 1 file

[PATCH 2/5] qapi/machine: Clean up documentation around CpuInstanceProperties

2024-07-11 Thread Markus Armbruster
CpuInstanceProperties' doc comment describes its members as properties to be passed to device_add when hot-plugging a CPU. This was in fact the initial use of this type, with query-hotpluggable-cpus: letting management applications find out what properties need to be passed with device_add to hot-

[PATCH 3/5] qapi/machine: Clarify query-uuid value when none has been specified

2024-07-11 Thread Markus Armbruster
When no UUID has been specified, query-uuid returns {"UUID": "----"} The doc comment calls this "a null UUID", which I find less than clear. Change it to "an all-zero UUID". Signed-off-by: Markus Armbruster --- qapi/machine.json | 5 ++--- 1 file changed, 2

Re: More than 255 vcpus Windows VM setup without viommu ?

2024-07-11 Thread David Woodhouse
On Thu, 2024-07-11 at 08:26 +0100, David Woodhouse wrote: > > I used identical command lines on both, and on each host I got the same > result with all of '-cpu host', '-cpu EPYC' and -cpu Skylake-Server'. > It's the *host* that makes the difference, not the CPUID presented to > the guest. Actual

Re: [PATCH] chardev: add a mutex to protect IOWatchPoll::src

2024-07-11 Thread Paolo Bonzini
On 7/11/24 11:51, Sergey Dyasli wrote: After 038b4217884c ("Revert "chardev: use a child source for qio input source"") we've been observing the "iwp->src == NULL" assertion triggering periodically during the initial capabilities querying by libvirtd. One of possible backtraces: Hi Sergey, tha

[PATCH 4/5] qapi/sockets: Move deprecation note out of SocketAddress doc comment

2024-07-11 Thread Markus Armbruster
Doc comments are reference documentation for users of QMP. SocketAddress's doc comment contains a deprecation note advising developers to use SocketAddress for new code. Irrelevant for users of QMP. Move the note out of the doc comment. Signed-off-by: Markus Armbruster --- qapi/sockets.json |

RE: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-11 Thread Wang, Wei W
On Friday, July 5, 2024 9:34 PM, Peter Xu wrote: > On Fri, Jul 05, 2024 at 10:22:23AM +, Wang, Wei W wrote: > > On Thursday, July 4, 2024 11:59 PM, Peter Xu wrote: > > > On Thu, Jul 04, 2024 at 03:10:27PM +, Wang, Wei W wrote: > > > > > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c i

Re: [PATCH] virtio: Always reset vhost devices

2024-07-11 Thread Hanna Czenczek
On 10.07.24 15:39, Matias Ezequiel Vara Larsen wrote: Hello Hanna, On Wed, Jul 10, 2024 at 01:23:10PM +0200, Hanna Czenczek wrote: Requiring `vhost_started` to be true for resetting vhost devices in `virtio_reset()` seems like the wrong condition: Most importantly, the preceding `virtio_set_sta

Re: [PATCH] virtio: Always reset vhost devices

2024-07-11 Thread Hanna Czenczek
On 10.07.24 18:28, Stefan Hajnoczi wrote: On Wed, 10 Jul 2024 at 13:25, Hanna Czenczek wrote: Requiring `vhost_started` to be true for resetting vhost devices in `virtio_reset()` seems like the wrong condition: Most importantly, the preceding `virtio_set_status(vdev, 0)` call will (for vhost de

Re: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-11 Thread Daniel P . Berrangé
On Wed, Jul 03, 2024 at 10:49:12PM +0800, Wei Wang wrote: > When enforce_cpuid is set to false, the guest is launched with a filtered > set of features, meaning that unsupported features by the host are removed > from the guest's vCPU model. This could cause issues for live migration. > For example

Re: More than 255 vcpus Windows VM setup without viommu ?

2024-07-11 Thread Sandesh Patel
Thanks David for all the analysis. > On 11 Jul 2024, at 4:53 PM, David Woodhouse wrote: > > On Thu, 2024-07-11 at 08:26 +0100, David Woodhouse wrote: >> >> I used identical command lines on both, and on each host I got the same >> result with all of '-cpu host', '-cpu EPYC' and -cpu Skylake-Ser

Re: [PATCH v4 05/13] hw/pci: Add a busnr property to pci_props and use for acpi/gi

2024-07-11 Thread Igor Mammedov
On Tue, 2 Jul 2024 14:14:10 +0100 Jonathan Cameron wrote: > Using a property allows us to hide the internal details of the PCI device > from the code to build a SRAT Generic Initiator Affinity Structure with > PCI Device Handle. > > Suggested-by: Igor Mammedov > Signed-off-by: Jonathan Cameron

Re: [PATCH 1/6] arm/virt: Wire up GPIO error source for ACPI / GHES

2024-07-11 Thread Michael S. Tsirkin
On Thu, Jul 11, 2024 at 11:52:03AM +0200, Mauro Carvalho Chehab wrote: > From: Jonathan Cameron > > Creates a GED - Generic Event Device and set a GPIO to > be used or error injection. > > Signed-off-by: Jonathan Cameron > Signed-off-by: Mauro Carvalho Chehab > --- > hw/arm/virt-acpi-build.c

[RFC PATCH 0/8] Convert avocado tests to normal Python unittests

2024-07-11 Thread Thomas Huth
The Avocado v88 that we use in QEMU is already on a life support system: It is not supported by upstream anymore, and with the latest versions of Python, it won't work anymore since it depends on the "imp" module that has been removed in Python 3.12. There have been several attempts to update the

[RFC PATCH 1/8] tests/pytest: Add base classes for the upcoming pytest-based tests

2024-07-11 Thread Thomas Huth
The file is a copy of the tests/avocado/avocado_qemu/__init__.py file with some adjustments to get rid of the Avocado dependencies (i.e. we also have to drop the LinuxSSHMixIn and LinuxTest for now). The emulator binary, source and build directory are now passed via environment variables that will

[RFC PATCH 6/8] tests/pytest: Convert some tests that download files via fetch_asset()

2024-07-11 Thread Thomas Huth
Now that we've got a working fetch_asset() function, we can convert some Avocado tests that use this function for downloading their required files. Signed-off-by: Thomas Huth --- tests/pytest/meson.build | 16 +++ .../test_machine_arm_n8x0.py} | 2

[RFC PATCH 2/8] tests/pytest: Convert some simple avocado tests into pytests

2024-07-11 Thread Thomas Huth
These test are rather simple and don't need any modifications apart from adjusting the "from avocado_qemu" line. These tests can now be run directly via "pytest" by setting the PYTHONPATH environment variable to the python folder of QEMU and by providing the QEMU binary via the PYTEST_QEMU_BINARY e

[RFC PATCH 8/8] tests/pytest: Convert avocado test that needed avocado.utils.archive

2024-07-11 Thread Thomas Huth
Instead of using the "archive" module from avocado.utils, switch these tests to use the new wrapper function that is based on the "tarfile" module instead. Signed-off-by: Thomas Huth --- tests/pytest/meson.build | 5 + .../test_arm_canona1100.py}| 1

[RFC PATCH 7/8] tests/pytest: Add a function for extracting files from an archive

2024-07-11 Thread Thomas Huth
Some Avocado-based tests use the "archive" module from avocado.utils to extract files from an archive. To be able to use these tests without Avocado, we have to provide our own function for extracting files. Fortunately, there is already the tarfile module that will provide us with this functionali

[RFC PATCH 4/8] tests/pytest: add pytest to the meson build system

2024-07-11 Thread Thomas Huth
From: Ani Sinha Integrate the pytest framework with the meson build system. This will make meson run all the pytests under the pytest directory. Signed-off-by: Ani Sinha [thuth: Removed the acpi-bits and adjusted for converted avocado tests instead] Signed-off-by: Thomas Huth --- tests/Makefi

[RFC PATCH 5/8] tests_pytest: Implement fetch_asset() method for downloading assets

2024-07-11 Thread Thomas Huth
In the pytests, we cannot use the fetch_asset() function from Avocado anymore, so we have to provide our own implementation now instead. Thus add such a function based on the _download_with_cache() function from tests/vm/basevm.py for this purpose. Signed-off-by: Thomas Huth --- tests/pytest/qem

[RFC PATCH 3/8] tests/pytest: Convert info_usernet and version test with small adjustments

2024-07-11 Thread Thomas Huth
These two simple tests can be converted to a pytest quite easily, we just have to set the machine to 'none' now manually since we don't support the avocado tags here yet. Signed-off-by: Thomas Huth --- .../info_usernet.py => pytest/test_info_usernet.py} | 6 ++ tests/{avocado/version.p

Re: [PATCH 1/6] arm/virt: Wire up GPIO error source for ACPI / GHES

2024-07-11 Thread Peter Maydell
On Thu, 11 Jul 2024 at 12:54, Michael S. Tsirkin wrote: > > On Thu, Jul 11, 2024 at 11:52:03AM +0200, Mauro Carvalho Chehab wrote: > > From: Jonathan Cameron > > > > Creates a GED - Generic Event Device and set a GPIO to > > be used or error injection. > > > > Signed-off-by: Jonathan Cameron > >

Re: Avocado 88.1 vs Python 3.12

2024-07-11 Thread Thomas Huth
On 10/07/2024 01.45, Richard Henderson wrote: On 7/9/24 09:26, Philippe Mathieu-Daudé wrote: On 9/7/24 17:41, Richard Henderson wrote: Hi guys, I have reinstalled my development box to ubuntu 24 (because the Rust support is better than my previous install; ho hum).  I thought I had tested ev

[PATCH v3 1/2] copy-before-write: allow specifying minimum cluster size

2024-07-11 Thread Fiona Ebner
In the context of backup fleecing, discarding the source will not work when the fleecing image has a larger granularity than the one used for block-copy operations (can happen if the backup target has smaller cluster size), because cbw_co_pdiscard_snapshot() will align down the discard requests and

[PATCH v3 2/2] backup: add minimum cluster size to performance options

2024-07-11 Thread Fiona Ebner
In the context of backup fleecing, discarding the source will not work when the fleecing image has a larger granularity than the one used for block-copy operations (can happen if the backup target has smaller cluster size), because cbw_co_pdiscard_snapshot() will align down the discard requests and

[PATCH v3 0/2] backup: allow specifying minimum cluster size

2024-07-11 Thread Fiona Ebner
Discussion for v2: https://lore.kernel.org/qemu-devel/20240528120114.344416-1-f.eb...@proxmox.com/ Changes in v3: * Pass min_cluster_size option directly without checking has_min_cluster_size, because the default is 0 anyways. * Calculate maximum of passed-in argument and default once at the b

RE: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-11 Thread Wang, Wei W
On Thursday, July 11, 2024 7:48 PM, Daniel P. Berrangé wrote: > On Wed, Jul 03, 2024 at 10:49:12PM +0800, Wei Wang wrote: > > When enforce_cpuid is set to false, the guest is launched with a > > filtered set of features, meaning that unsupported features by the > > host are removed from the guest's

Re: [PATCH v4 06/13] acpi/pci: Move Generic Initiator object handling into acpi/pci.*

2024-07-11 Thread Igor Mammedov
On Tue, 2 Jul 2024 14:14:11 +0100 Jonathan Cameron wrote: > Whilst ACPI SRAT Generic Initiator Afinity Structures are able to refer to > both PCI and ACPI Device Handles, the QEMU implementation only implements > the PCI Device Handle case. For now move the code into the existing > hw/acpi/pci.c

Re: [PATCH v4 05/13] hw/pci: Add a busnr property to pci_props and use for acpi/gi

2024-07-11 Thread Igor Mammedov
On Thu, 11 Jul 2024 13:53:31 +0200 Igor Mammedov wrote: > On Tue, 2 Jul 2024 14:14:10 +0100 > Jonathan Cameron wrote: > > > Using a property allows us to hide the internal details of the PCI device > > from the code to build a SRAT Generic Initiator Affinity Structure with > > PCI Device Handle

  1   2   3   4   >