Re: [PATCH v2 06/15] ppc/vof: Fix unaligned FDT property access

2024-07-05 Thread Nicholas Piggin
On Fri Jul 5, 2024 at 3:12 PM AEST, David Gibson wrote: > On Fri, Jul 05, 2024 at 02:40:19PM +1000, Nicholas Piggin wrote: > > On Fri Jul 5, 2024 at 11:41 AM AEST, David Gibson wrote: > > > On Fri, Jul 05, 2024 at 11:18:47AM +1000, Nicholas Piggin wrote: > > > > On Thu Jul 4, 2024 at 10:15 PM AEST,

Re: [PATCH 00/14] rust: example of bindings code for Rust in QEMU

2024-07-05 Thread Paolo Bonzini
On Thu, Jul 4, 2024 at 9:26 PM Pierrick Bouvier wrote: > > Patches 9-10 deal with how to define new subclasses in Rust. They are > > a lot less polished and less ready. There is probably a lot of polish > > that could be applied to make the code look nicer, but I guess there is > > always time t

RE: [PATCH v3 0/4] Implement using Intel QAT to offload ZLIB

2024-07-05 Thread Liu, Yuan1
> -Original Message- > From: Peter Xu > Sent: Thursday, July 4, 2024 11:36 PM > To: Liu, Yuan1 > Cc: Wang, Yichen ; Paolo Bonzini > ; Daniel P. Berrangé ; Eduardo > Habkost ; Marc-André Lureau > ; Thomas Huth ; Philippe > Mathieu-Daudé ; Fabiano Rosas ; Eric > Blake ; Markus Armbruster ;

Re: [PATCH v8 00/13] vhost-user: support any POSIX system (tested on macOS, FreeBSD, OpenBSD)

2024-07-05 Thread Stefano Garzarella
On Wed, Jul 03, 2024 at 06:49:30PM GMT, Michael S. Tsirkin wrote: On Tue, Jun 18, 2024 at 12:00:30PM +0200, Stefano Garzarella wrote: As discussed with Michael and Markus [1], this version also includes the patch on which v7 depended to simplify the merge in Michael's tree. The series is all re

[PATCH v2 03/40] tracepoints: move physmem trace points

2024-07-05 Thread Alex Bennée
They don't need to be in the global trace-events file and can have a local trace header. Also add address_space_map tracepoint for tracking mapping behaviour. Message-Id: <20240628124258.832466-5-alex.ben...@linaro.org> Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - droppe

[PATCH v2 09/40] tests/tcg/aarch64: Explicitly specify register width

2024-07-05 Thread Alex Bennée
From: Akihiko Odaki clang version 18.1.6 assumes a register is 64-bit by default and complains if a 32-bit value is given. Explicitly specify register width when passing a 32-bit value. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20240627-tcg-v2-3-1690a8133...

[PATCH v2 20/40] gitlab: don't bother with KVM for TCI builds

2024-07-05 Thread Alex Bennée
In fact any other accelerator would be pointless as the point is to exercise the TCI accelerator anyway. Signed-off-by: Alex Bennée --- .gitlab-ci.d/buildtest.yml | 2 +- .gitlab-ci.d/crossbuilds.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.d/buildtest.

[PATCH v2 04/40] hw/core: ensure kernel_end never gets used undefined

2024-07-05 Thread Alex Bennée
Really the problem here is the return values of fit_load_[kernel|fdt]() are a little all over the place. However we don't want to somehow get through not having set kernel_end and having it just be random unused data. The compiler complained on an --enable-gcov build: In file included from ../.

[PATCH v2 02/40] testing: restore some testing for i686

2024-07-05 Thread Alex Bennée
The commit 4f9a8315e6 (gitlab-ci.d/crossbuilds: Drop the i386 system emulation job) was a little too aggressive dropping testing for 32 bit system builds. Partially revert but using the debian-i686 cross build images this time as fedora has deprecated the 32 bit stuff. As the SEV breakage gets in

[PATCH v2 07/40] tests/tcg: Adjust variable defintion from cc-option

2024-07-05 Thread Alex Bennée
From: Richard Henderson Define the variable to the compiler flag used, not "y". This avoids replication of the compiler flag itself. Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-3-richard.hender...@linaro.org> Signed-off-by: Alex Bennée --- t

[PATCH v2 01/40] tests/lcitool: fix debian-i686-cross toolchain prefix

2024-07-05 Thread Alex Bennée
I guess we never noticed and tried to build with this cross image. Fix the toolchain prefix so we actually build 32 bit images. Message-Id: <20240628124258.832466-2-alex.ben...@linaro.org> Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/debian-i686-cross.d

[PATCH v2 06/40] tests/tcg/minilib: Constify digits in print_num

2024-07-05 Thread Alex Bennée
From: Richard Henderson This avoids a memcpy to the stack when compiled with clang. Since we don't enable optimization, nor provide memcpy, this results in an undefined symbol error at link time. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Akihiko Odaki M

[PATCH v2 10/40] tests/tcg/aarch64: Fix irg operand type

2024-07-05 Thread Alex Bennée
From: Akihiko Odaki irg expects 64-bit integers. Passing a 32-bit integer results in compilation failure with clang version 18.1.6. Signed-off-by: Akihiko Odaki Message-Id: <20240627-tcg-v2-4-1690a8133...@daynix.com> Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-6-richard.hende

[PATCH v2 15/40] tests/tcg/arm: Use -fno-integrated-as for test-arm-iwmmxt

2024-07-05 Thread Alex Bennée
From: Richard Henderson Clang does not support IWMXT instructions. Fall back to the external assembler. Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-11-richard.hender...@linaro.org> Signed-off-by: Alex Bennée --- tests/tcg/arm/Makefile.target

[PATCH v2 11/40] tests/tcg/aarch64: Do not use x constraint

2024-07-05 Thread Alex Bennée
From: Akihiko Odaki clang version 18.1.6 does not support x constraint for AArch64. Use w instead. Signed-off-by: Akihiko Odaki Message-Id: <20240627-tcg-v2-5-1690a8133...@daynix.com> Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-7-richard.hender...@linaro.org> Signed-off-by: A

[PATCH v2 17/40] tests/tcg/arm: Use -march and -mfpu for fcvt

2024-07-05 Thread Alex Bennée
From: Richard Henderson Clang requires the architecture to be set properly in order to assemble the half-precision instructions. Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-13-richard.hender...@linaro.org> Signed-off-by: Alex Bennée --- test

[PATCH v2 00/40] July maintainer updates (32bit, testing, plugins, gdbstub)

2024-07-05 Thread Alex Bennée
Hi, This is a grab bag of fixes and clean-ups as we swiftly approach the soft freeze deadline. The i386 TCG fix has been dropped now rth's TCG clean-ups have been merged. I've also taken a series from Richard that built on Akihiko's TCG test cleanups. There is one new fix I came across when doing

[PATCH v2 18/40] tests/tcg/arm: Use vmrs/vmsr instead of mcr/mrc

2024-07-05 Thread Alex Bennée
From: Richard Henderson Clang 14 generates /home/rth/qemu/src/tests/tcg/arm/fcvt.c:431:9: error: invalid operand for instruction asm("mrc p10, 7, r1, cr1, cr0, 0\n\t" ^ :1:6: note: instantiated into assembly here mrc p10, 7, r1, cr1, cr0, 0 ^ /home/rth/qemu/src/t

[PATCH v2 22/40] test/plugins: preserve the instruction record over translations

2024-07-05 Thread Alex Bennée
We are interested in the particular instruction so we should use a stable record for it. We could bring this down to physical address but for now vaddr + disas seems to do the trick. Signed-off-by: Alex Bennée --- tests/plugin/insn.c | 76 ++--- 1 file cha

[PATCH v2 27/40] plugins: Ensure vCPU index is assigned in init/exit hooks

2024-07-05 Thread Alex Bennée
From: Philippe Mathieu-Daudé Since vCPUs are hashed by their index, this index can't be uninitialized (UNASSIGNED_CPU_INDEX). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Message-Id: <20240606124010.2460-2-phi...@linaro.org> Signed-off-by: Alex Bennée --- plugins/core.

[PATCH v2 29/40] accel/tcg: Move qemu_plugin_vcpu_init__async() to plugins/

2024-07-05 Thread Alex Bennée
From: Philippe Mathieu-Daudé Calling qemu_plugin_vcpu_init__async() on the vCPU thread is a detail of plugins, not relevant to TCG vCPU management. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Pierrick Bouvier Message-Id: <20240606124010.2460-4-phi...@lina

[PATCH v2 12/40] tests/tcg/aarch64: Add -fno-integrated-as for sme

2024-07-05 Thread Alex Bennée
From: Richard Henderson The only use of SME is inline assembly. Both gcc and clang only support SME with very recent releases; by deferring detection to the assembler we get better test coverage. Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-8-

[PATCH v2 28/40] plugins: Free CPUPluginState before destroying vCPU state

2024-07-05 Thread Alex Bennée
From: Philippe Mathieu-Daudé cpu::plugin_state is allocated in cpu_common_initfn() when the vCPU state is created. Release it in cpu_common_finalize() when we are done. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Message-Id: <20240606124010.2460-3-phi...@linaro.org> Sig

[PATCH v2 31/40] gdbstub: Move GdbCmdParseEntry into a new header file

2024-07-05 Thread Alex Bennée
From: Gustavo Romero Move GdbCmdParseEntry and its associated types into a separate header file to allow the use of GdbCmdParseEntry and other gdbstub command functions outside of gdbstub.c. Since GdbCmdParseEntry and get_param are now public, kdoc GdbCmdParseEntry and rename get_param to gdb_ge

[PATCH v2 39/40] gdbstub: Add support for MTE in user mode

2024-07-05 Thread Alex Bennée
From: Gustavo Romero This commit implements the stubs to handle the qIsAddressTagged, qMemTag, and QMemTag GDB packets, allowing all GDB 'memory-tag' subcommands to work with QEMU gdbstub on aarch64 user mode. It also implements the get/set functions for the special GDB MTE register 'tag_ctl', us

[PATCH v2 08/40] tests/tcg/aarch64: Drop -fno-tree-loop-distribute-patterns

2024-07-05 Thread Alex Bennée
From: Richard Henderson This option is not supported by clang, and is not required in order to get sve code generation with gcc 12. Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-4-richard.hender...@linaro.org> Signed-off-by: Alex Bennée --- te

[PATCH v2 05/40] tests/docker: Specify --userns keep-id for Podman

2024-07-05 Thread Alex Bennée
From: Akihiko Odaki Previously we are always specifying -u $(UID) to match the UID in the container with one outside. This causes a problem with rootless Podman. Rootless Podman remaps user IDs in the container to ones controllable for the current user outside. The -u option instructs Podman to

[PATCH v2 30/40] gdbstub: Clean up process_string_cmd

2024-07-05 Thread Alex Bennée
From: Gustavo Romero Change 'process_string_cmd' to return true on success and false on failure, instead of 0 and -1. Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20240628050

[PATCH v2 16/40] tests/tcg/arm: Manually register allocate half-precision numbers

2024-07-05 Thread Alex Bennée
From: Akihiko Odaki Clang does not allow specifying an integer as the value of a single precision register. Explicitly move value from a general register. Signed-off-by: Akihiko Odaki [rth: Use one single inline asm block.] Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-

[PATCH v2 37/40] gdbstub: Pass CPU context to command handler

2024-07-05 Thread Alex Bennée
From: Gustavo Romero Allow passing the current CPU context to command handlers via user_ctx when the handler requires it. Signed-off-by: Gustavo Romero Signed-off-by: Alex Bennée Message-Id: <20240628050850.536447-9-gustavo.rom...@linaro.org> --- include/gdbstub/commands.h | 3 +++ gdbstub/gd

[PATCH v2 35/40] target/arm: Factor out code for setting MTE TCF0 field

2024-07-05 Thread Alex Bennée
From: Gustavo Romero Factor out the code used for setting the MTE TCF0 field from the prctl code into a convenient function. Other subsystems, like gdbstub, need to set this field as well, so keep it as a separate function to avoid duplication and ensure consistency in how this field is set acros

[PATCH v2 24/40] plugins/lockstep: make mixed-mode safe

2024-07-05 Thread Alex Bennée
The ExecState is shared across the socket and if we want to compare say 64 bit and 32 bit binaries we need the two to use the same sizes for things. Message-Id: <20240628124258.832466-11-alex.ben...@linaro.org> Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- contrib/plugins/lockst

[PATCH v2 32/40] gdbstub: Add support for target-specific stubs

2024-07-05 Thread Alex Bennée
From: Gustavo Romero Currently, it's not possible to have stubs specific to a given target, even though there are GDB features which are target-specific, like, for instance, memory tagging. This commit introduces gdb_extend_qsupported_features, gdb_extend_query_table, and gdb_extend_set_table fu

[PATCH v2 36/40] gdbstub: Make hex conversion function non-internal

2024-07-05 Thread Alex Bennée
From: Gustavo Romero Make gdb_hextomem non-internal so it's not confined to use only in gdbstub.c. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20240628050850.536447-8-gustavo.rom...@linaro.org> --- gdbstub/internals.h| 1 - inc

[PATCH v2 34/40] target/arm: Make some MTE helpers widely available

2024-07-05 Thread Alex Bennée
From: Gustavo Romero Make the MTE helpers allocation_tag_mem_probe, load_tag1, and store_tag1 available to other subsystems. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20240628050850.536447-6-gustav

[PATCH v2 19/40] linux-user/main: Suppress out-of-range comparison warning for clang

2024-07-05 Thread Alex Bennée
From: Richard Henderson For arm32 host and arm64 guest we get .../main.c:851:32: error: result of comparison of constant 70368744177664 with expression of type 'unsigned long' is always false [-Werror,-Wtautological-constant-out-of-range-compare] if (TASK_UNMAPPED_BASE < reserved_va) {

[PATCH v2 13/40] tests/tcg/arm: Fix fcvt result messages

2024-07-05 Thread Alex Bennée
From: Akihiko Odaki The test cases for "converting double-precision to single-precision" emits float but the result variable was typed as uint32_t and corrupted the printed values. Propertly type it as float. Signed-off-by: Akihiko Odaki Fixes: 8ec8a55e3fc9 ("tests/tcg/arm: add fcvt test cases

[PATCH v2 21/40] test/plugin: make insn plugin less noisy by default

2024-07-05 Thread Alex Bennée
While the match functionality is useful lets make the verbosity optional while we are actually running. Signed-off-by: Alex Bennée --- tests/plugin/insn.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/tests/plugin/insn.c b/tests/plugin

[PATCH v2 25/40] plugins/lockstep: mention the one-insn-per-tb option

2024-07-05 Thread Alex Bennée
This really helps with lockstep although its super slow on big jobs. Signed-off-by: Alex Bennée --- contrib/plugins/lockstep.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c index 761bcdf363..353bf12dfb 100644 --- a/c

RE: [PATCH v3 2/3] intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo

2024-07-05 Thread Duan, Zhenzhong
>-Original Message- >From: CLEMENT MATHIEU--DRIF >Subject: [PATCH v3 2/3] intel_iommu: fix type of the mask field in >VTDIOTLBPageInvInfo > >From: Clément Mathieu--Drif > >VTDIOTLBPageInvInfo.mask might not fit in an uint8_t. >Moreover, this field is used in binary operations with 64-bi

[PATCH v2 14/40] tests/tcg/arm: Drop -N from LDFLAGS

2024-07-05 Thread Alex Bennée
From: Richard Henderson This is redudant with a linker script, and is not supported by clang. Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-10-richard.hender...@linaro.org> Signed-off-by: Alex Bennée --- tests/tcg/arm/Makefile.softmmu-target |

[PATCH v2 26/40] plugins/lockstep: clean-up output

2024-07-05 Thread Alex Bennée
We were repeating information which wasn't super clear. As we already will have dumped the last failing PC just note the divergence and dump the previous instruction log. Signed-off-by: Alex Bennée --- contrib/plugins/lockstep.c | 16 1 file changed, 8 insertions(+), 8 deletions

RE: [PATCH v3 1/3] intel_iommu: fix FRCD construction macro.

2024-07-05 Thread Duan, Zhenzhong
>-Original Message- >From: CLEMENT MATHIEU--DRIF >Subject: [PATCH v3 1/3] intel_iommu: fix FRCD construction macro. > >From: Clément Mathieu--Drif > >The constant must be unsigned, otherwise the two's complement >overrides the other fields when a PASID is present. > >Fixes: 1b2b12376c8a

[PATCH v2 38/40] gdbstub: Use true to set cmd_startswith

2024-07-05 Thread Alex Bennée
From: Gustavo Romero cmd_startswith is a boolean so use 'true' to set it instead of 1. Signed-off-by: Gustavo Romero Signed-off-by: Alex Bennée Message-Id: <20240628050850.536447-10-gustavo.rom...@linaro.org> --- gdbstub/gdbstub.c | 80 +++ 1 file c

Re: [PATCH v8 00/13] vhost-user: support any POSIX system (tested on macOS, FreeBSD, OpenBSD)

2024-07-05 Thread Michael S. Tsirkin
On Fri, Jul 05, 2024 at 10:39:33AM +0200, Stefano Garzarella wrote: > On Wed, Jul 03, 2024 at 06:49:30PM GMT, Michael S. Tsirkin wrote: > > On Tue, Jun 18, 2024 at 12:00:30PM +0200, Stefano Garzarella wrote: > > > As discussed with Michael and Markus [1], this version also includes the > > > patch

Re: [PATCH v2 20/40] gitlab: don't bother with KVM for TCI builds

2024-07-05 Thread Thomas Huth
On 05/07/2024 10.40, Alex Bennée wrote: In fact any other accelerator would be pointless as the point is to exercise the TCI accelerator anyway. Signed-off-by: Alex Bennée --- .gitlab-ci.d/buildtest.yml | 2 +- .gitlab-ci.d/crossbuilds.yml | 2 +- 2 files changed, 2 insertions(+), 2 delet

Re: Question about OS/2 support under QEMU....

2024-07-05 Thread Alex Bennée
Roderick Klein writes: > Hello > > Recently a bug was opened to get QEMU to support OS/2 again (newer > versions of OS/2). > https://gitlab.com/qemu-project/qemu/-/issues/2198 > > I would like to point out a company from the US supports a current > version of OS/2 called ArcaOS. I was trying to

RE: [PATCH v3 3/3] intel_iommu: make types match

2024-07-05 Thread Duan, Zhenzhong
>-Original Message- >From: CLEMENT MATHIEU--DRIF >Subject: [PATCH v3 3/3] intel_iommu: make types match > >From: Clément Mathieu--Drif > >The 'level' field in vtd_iotlb_key is an unsigned integer. >We don't need to store level as an int in vtd_lookup_iotlb. > >Signed-off-by: Clément Mat

Re: [PATCH v3 2/3] intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo

2024-07-05 Thread Michael S. Tsirkin
On Fri, Jul 05, 2024 at 05:03:17AM +, CLEMENT MATHIEU--DRIF wrote: > From: Clément Mathieu--Drif > > VTDIOTLBPageInvInfo.mask might not fit in an uint8_t. I think what you mean is that is assigned values that might not fit it's u8 ATM so of course it fits. > Moreover, this field is use

[PATCH v2 40/40] tests/tcg/aarch64: Add MTE gdbstub tests

2024-07-05 Thread Alex Bennée
From: Gustavo Romero Add tests to exercise the MTE stubs. The tests will only run if a version of GDB that supports MTE is available in the test environment. Signed-off-by: Gustavo Romero [AJB: re-base and checkpatch fixes] Signed-off-by: Alex Bennée Message-Id: <20240628050850.536447-12-gusta

[PATCH v2 23/40] plugins/lockstep: preserve sock_path

2024-07-05 Thread Alex Bennée
We can't assign sock_path directly from the autofree'd GStrv, take a copy. Signed-off-by: Alex Bennée --- contrib/plugins/lockstep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c index 237543b43a..111ec3fa27 100644 ---

[PATCH v2 33/40] target/arm: Fix exception case in allocation_tag_mem_probe

2024-07-05 Thread Alex Bennée
From: Gustavo Romero If page in 'ptr_access' is inaccessible and probe is 'true' allocation_tag_mem_probe should not throw an exception, but currently it does, so fix it. Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-

[PATCH] system: Enable the device aliases for or1k, too

2024-07-05 Thread Thomas Huth
Now that we've got a "virt" machine for or1k that supports PCI, too, we can also enable the virtio device aliases like we do on other similar platforms. This will e.g. help to run the iotests with qemu-system-or1k later. While we're at it, sort QEMU_ARCH_LOONGARCH alphabetically into the list. Si

About VFIO Device Pass-through on Qemu.

2024-07-05 Thread tugouxp
Hi folks: I have a questions about device vfio pass-through usage snarios, PCI device pass-throug for example. did the GPA that host physical memory mapped to Guest vcpu through MMU must be identical with the IOVA that host physical memory mapped to gust device thourgh iommu? if so, that

Re: [PATCH] meson: Update meson-buildoptions.sh

2024-07-05 Thread Daniel P . Berrangé
On Fri, Jul 05, 2024 at 01:49:03PM +0800, Zhao Liu wrote: > Update meson-buildoptions.sh to stay in sync with meson_options.txt. > > Signed-off-by: Zhao Liu > --- > scripts/meson-buildoptions.sh | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Daniel P. Berran

Re: [PATCH v3 3/3] intel_iommu: make types match

2024-07-05 Thread CLEMENT MATHIEU--DRIF
On 05/07/2024 10:51, Duan, Zhenzhong wrote: > Caution: External email. Do not open attachments or click links, unless this > email comes from a known sender and you know the content is safe. > > >> -Original Message- >> From: CLEMENT MATHIEU--DRIF >> Subject: [PATCH v3 3/3] intel_iommu:

Re: [PATCH 1/3] hw/cxl: Get rid of unused cfmw_list

2024-07-05 Thread Jonathan Cameron via
On Fri, 5 Jul 2024 02:29:34 + "Zhijian Li (Fujitsu)" wrote: > On 05/07/2024 10:15, Zhao Liu wrote: > >> There is a new user for cfmw_list now > >> https://lore.kernel.org/qemu-devel/20240704093404.1848132-1-zhao1@linux.intel.com/ > >> > >> So I think we should drop this patch. > > > Hi

Re: [PATCH v3 3/3] intel_iommu: make types match

2024-07-05 Thread Michael S. Tsirkin
On Fri, Jul 05, 2024 at 09:24:50AM +, CLEMENT MATHIEU--DRIF wrote: > > > On 05/07/2024 10:51, Duan, Zhenzhong wrote: > > Caution: External email. Do not open attachments or click links, unless > > this email comes from a known sender and you know the content is safe. > > > > > >> -Origin

Re: [PATCH v2 04/40] hw/core: ensure kernel_end never gets used undefined

2024-07-05 Thread Manos Pitsidianakis
On Fri, 5 Jul 2024 at 11:41, Alex Bennée wrote: > > Really the problem here is the return values of fit_load_[kernel|fdt]() are a > little all over the place. However we don't want to somehow get > through not having set kernel_end and having it just be random unused > data. > > The compiler compl

Re: [PATCH v3 2/3] intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo

2024-07-05 Thread CLEMENT MATHIEU--DRIF
On 05/07/2024 10:51, Michael S. Tsirkin wrote: Caution: External email. Do not open attachments or click links, unless this email comes from a known sender and you know the content is safe. On Fri, Jul 05, 2024 at 05:03:17AM +, CLEMENT MATHIEU--DRIF wrote: From: Clément Mathieu--Drif <

Re: [RFC PATCH] hw/core: ensure kernel_end never gets used undefined

2024-07-05 Thread Aleksandar Rikalo
On Thu, Jul 4, 2024 at 2:49 PM Alex Bennée wrote: > > Really the problem here is the return values of fit_load_[kernel|fdt]() are a > little all over the place. However we don't want to somehow get > through not having set kernel_end and having it just be random unused > data. > > The compiler com

Re: [PATCH v2 23/40] plugins/lockstep: preserve sock_path

2024-07-05 Thread Manos Pitsidianakis
On Fri, 5 Jul 2024 at 11:57, Alex Bennée wrote: > > We can't assign sock_path directly from the autofree'd GStrv, take a > copy. > > Signed-off-by: Alex Bennée > --- > contrib/plugins/lockstep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/plugins/lockstep.c b

Re: [PATCH v2 21/40] test/plugin: make insn plugin less noisy by default

2024-07-05 Thread Manos Pitsidianakis
On Fri, 5 Jul 2024 at 11:49, Alex Bennée wrote: > > While the match functionality is useful lets make the verbosity > optional while we are actually running. > > Signed-off-by: Alex Bennée > --- > tests/plugin/insn.c | 36 +--- > 1 file changed, 21 insertions(+),

Re: [PATCH v2 38/40] gdbstub: Use true to set cmd_startswith

2024-07-05 Thread Manos Pitsidianakis
On Fri, 5 Jul 2024 at 11:49, Alex Bennée wrote: > > From: Gustavo Romero > > cmd_startswith is a boolean so use 'true' to set it instead of 1. > > Signed-off-by: Gustavo Romero > Signed-off-by: Alex Bennée > Message-Id: <20240628050850.536447-10-gustavo.rom...@linaro.org> > --- > gdbstub/gdbst

Re: [PATCH v1 0/8] PRI support for VT-d

2024-07-05 Thread cmd
On 05/07/2024 08:20, Yi Liu wrote: On 2024/7/5 13:13, CLEMENT MATHIEU--DRIF wrote: On 05/07/2024 05:03, Yi Liu wrote: Caution: External email. Do not open attachments or click links, unless this email comes from a known sender and you know the content is safe. On 2024/5/30 20:24, CLEMENT

Re: [PATCH v2 25/40] plugins/lockstep: mention the one-insn-per-tb option

2024-07-05 Thread Manos Pitsidianakis
On Fri, 5 Jul 2024 at 11:48, Alex Bennée wrote: > > This really helps with lockstep although its super slow on big jobs. > > Signed-off-by: Alex Bennée > --- > contrib/plugins/lockstep.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/contrib/plugins/lockstep.c b/contr

[PATCH v8] virtio-net: Fix network stall at the host side waiting for kick

2024-07-05 Thread Wencheng Yang
From: thomas Patch 06b12970174 ("virtio-net: fix network stall under load") added double-check to test whether the available buffer size can satisfy the request or not, in case the guest has added some buffers to the avail ring simultaneously after the first check. It will be lucky if the availab

Re: [PATCH v2 35/40] target/arm: Factor out code for setting MTE TCF0 field

2024-07-05 Thread Manos Pitsidianakis
On Fri, 5 Jul 2024 at 11:47, Alex Bennée wrote: > > From: Gustavo Romero > > Factor out the code used for setting the MTE TCF0 field from the prctl > code into a convenient function. Other subsystems, like gdbstub, need to > set this field as well, so keep it as a separate function to avoid > dup

Re: [PATCH v2 37/40] gdbstub: Pass CPU context to command handler

2024-07-05 Thread Manos Pitsidianakis
On Fri, 5 Jul 2024 at 11:47, Alex Bennée wrote: > > From: Gustavo Romero > > Allow passing the current CPU context to command handlers via user_ctx > when the handler requires it. > > Signed-off-by: Gustavo Romero > Signed-off-by: Alex Bennée > Message-Id: <20240628050850.536447-9-gustavo.rom..

Re: [PATCH v8] virtio-net: Fix network stall at the host side waiting for kick

2024-07-05 Thread Michael S. Tsirkin
On Fri, Jul 05, 2024 at 06:05:02PM +0800, Wencheng Yang wrote: > From: thomas > > Patch 06b12970174 ("virtio-net: fix network stall under load") > added double-check to test whether the available buffer size > can satisfy the request or not, in case the guest has added > some buffers to the avail

Re: [PATCH v8] virtio-net: Fix network stall at the host side waiting for kick

2024-07-05 Thread Michael S. Tsirkin
On Fri, Jul 05, 2024 at 06:05:02PM +0800, Wencheng Yang wrote: > From: thomas > > Patch 06b12970174 ("virtio-net: fix network stall under load") > added double-check to test whether the available buffer size > can satisfy the request or not, in case the guest has added > some buffers to the avail

Re: [PATCH v2 22/40] test/plugins: preserve the instruction record over translations

2024-07-05 Thread Manos Pitsidianakis
On Fri, 5 Jul 2024 at 11:43, Alex Bennée wrote: > > We are interested in the particular instruction so we should use a > stable record for it. We could bring this down to physical address but > for now vaddr + disas seems to do the trick. > > Signed-off-by: Alex Bennée > --- > tests/plugin/insn.

Re: [PATCH v3 2/3] intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo

2024-07-05 Thread Michael S. Tsirkin
On Fri, Jul 05, 2024 at 09:52:48AM +, CLEMENT MATHIEU--DRIF wrote: > > > On 05/07/2024 10:51, Michael S. Tsirkin wrote: > > Caution: External email. Do not open attachments or click links, unless > this email comes from a known sender and you know the content is safe. > > > On Fri

Re: [PATCH v6 08/10] hw/nvme: enable ONCS and rescap function

2024-07-05 Thread Stefan Hajnoczi
On Thu, Jul 04, 2024 at 08:20:31PM +0200, Stefan Hajnoczi wrote: > On Thu, Jun 13, 2024 at 03:13:25PM +0800, Changqi Lu wrote: > > This commit enables ONCS to support the reservation > > function at the controller level. Also enables rescap > > function in the namespace by detecting the supported r

RE: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-05 Thread Wang, Wei W
On Thursday, July 4, 2024 11:59 PM, Peter Xu wrote: > On Thu, Jul 04, 2024 at 03:10:27PM +, Wang, Wei W wrote: > > > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c index > > > > 4c2e6f3a71..7db4fe4ead 100644 > > > > --- a/target/i386/cpu.c > > > > +++ b/target/i386/cpu.c > > > > @@ -8258,

Re: [PATCH v2 3/4] ui/cocoa: Add cursor composition

2024-07-05 Thread Phil Dennis-Jordan
I've just tried to rebase my own patches on top of this work and noticed the following typo: On Thu, 27 Jun 2024 at 13:17, Akihiko Odaki wrote: > static void cocoa_refresh(DisplayChangeListener *dcl); > +static void cocoa_mouse_set(DisplayChangeListener *dcl, int x, int y, int > on); The abov

[PATCH v7 06/10] block/nvme: add reservation command protocol constants

2024-07-05 Thread Changqi Lu
Add constants for the NVMe persistent command protocol. The constants include the reservation command opcode and reservation type values defined in section 7 of the NVMe 2.0 specification. Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi --- include/block/nvme.h | 61

[PATCH v7 03/10] scsi/constant: add persistent reservation in/out protocol constants

2024-07-05 Thread Changqi Lu
Add constants for the persistent reservation in/out protocol in the scsi/constant module. The constants include the persistent reservation command, type, and scope values defined in sections 6.13 and 6.14 of the SCSI Primary Commands-4 (SPC-4) specification. Signed-off-by: Changqi Lu Signed-off-b

[PATCH v7 00/10] Support persistent reservation operations

2024-07-05 Thread Changqi Lu
Hi, Patch v7 has been modified. Thanks again to Stefan for reviewing the code. v6->v7: - Add buferlen size check at SCSI layer. - Add pr_cap calculation in bdrv_merge_limits() function at block layer, so the ugly bs->file->bs->bl.pr_cap in scsi and nvme layers was changed to bs->bl.pr_cap. -

[PATCH v7 02/10] block/raw: add persistent reservation in/out driver

2024-07-05 Thread Changqi Lu
Add persistent reservation in/out operations for raw driver. The following methods are implemented: bdrv_co_pr_read_keys, bdrv_co_pr_read_reservation, bdrv_co_pr_register, bdrv_co_pr_reserve, bdrv_co_pr_release, bdrv_co_pr_clear and bdrv_co_pr_preempt. Signed-off-by: Changqi Lu Signed-off-by: zhe

[PATCH v7 07/10] hw/nvme: add helper functions for converting reservation types

2024-07-05 Thread Changqi Lu
This commit introduces two helper functions that facilitate the conversion between the reservation types used in the NVME protocol and those used in the block layer. Reviewed-by: Stefan Hajnoczi Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi --- hw/nvme/nvme.h | 84 +++

[PATCH v7 10/10] block/iscsi: add persistent reservation in/out driver

2024-07-05 Thread Changqi Lu
Add persistent reservation in/out operations for iscsi driver. The following methods are implemented: bdrv_co_pr_read_keys, bdrv_co_pr_read_reservation, bdrv_co_pr_register, bdrv_co_pr_reserve, bdrv_co_pr_release, bdrv_co_pr_clear and bdrv_co_pr_preempt. Signed-off-by: Changqi Lu Signed-off-by: z

[PATCH v7 05/10] hw/scsi: add persistent reservation in/out api for scsi device

2024-07-05 Thread Changqi Lu
Add persistent reservation in/out operations in the SCSI device layer. By introducing the persistent reservation in/out api, this enables the SCSI device to perform reservation-related tasks, including querying keys, querying reservation status, registering reservation keys, initiating and releasin

[PATCH v7 01/10] block: add persistent reservation in/out api

2024-07-05 Thread Changqi Lu
Add persistent reservation in/out operations at the block level. The following operations are included: - read_keys:retrieves the list of registered keys. - read_reservation: retrieves the current reservation status. - register: registers a new reservation key. - reserve:

[PATCH v7 04/10] scsi/util: add helper functions for persistent reservation types conversion

2024-07-05 Thread Changqi Lu
This commit introduces two helper functions that facilitate the conversion between the persistent reservation types used in the SCSI protocol and those used in the block layer. Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi Reviewed-by: Stefan Hajnoczi --- include/scsi/utils.h | 8 +

[PATCH v7 09/10] hw/nvme: add reservation protocal command

2024-07-05 Thread Changqi Lu
Add reservation acquire, reservation register, reservation release and reservation report commands in the nvme device layer. By introducing these commands, this enables the nvme device to perform reservation-related tasks, including querying keys, querying reservation status, registering reservati

[PATCH v7 08/10] hw/nvme: enable ONCS and rescap function

2024-07-05 Thread Changqi Lu
This commit enables ONCS to support the reservation function at the controller level. Also enables rescap function in the namespace by detecting the supported reservation function in the backend driver. Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi --- hw/nvme/ctrl.c | 3 ++- hw/nvm

[PATCH v4 3/4] intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo

2024-07-05 Thread CLEMENT MATHIEU--DRIF
From: Clément Mathieu--Drif The mask we are trying to store into VTDIOTLBPageInvInfo.mask might not fit in an uint8_t. Use uint64_t to avoid overflows Signed-off-by: Clément Mathieu--Drif --- hw/i386/intel_iommu_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/

[PATCH v4 1/4] intel_iommu: fix FRCD construction macro

2024-07-05 Thread CLEMENT MATHIEU--DRIF
From: Clément Mathieu--Drif The constant must be unsigned, otherwise the two's complement overrides the other fields when a PASID is present. Fixes: 1b2b12376c8a ("intel-iommu: PASID support") Signed-off-by: Clément Mathieu--Drif Reviewed-by: Yi Liu Reviewed-by: Zhenzhong Duan --- hw/i386/i

[PATCH v4 2/4] intel_iommu: move VTD_FRCD_PV and VTD_FRCD_PP declarations

2024-07-05 Thread CLEMENT MATHIEU--DRIF
From: Clément Mathieu--Drif These 2 macros are for high 64-bit of the FRCD registers. Declarations have to be moved accordingly. Signed-off-by: Clément Mathieu--Drif --- hw/i386/intel_iommu_internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/intel_iommu_i

[PATCH v4 4/4] intel_iommu: make types match

2024-07-05 Thread CLEMENT MATHIEU--DRIF
From: Clément Mathieu--Drif The 'level' field in vtd_iotlb_key is an unsigned integer. We don't need to store level as an int in vtd_lookup_iotlb. This is not an issue by itself, but using unsigned here seems cleaner. Signed-off-by: Clément Mathieu--Drif --- hw/i386/intel_iommu.c | 2 +- 1 fi

[PATCH v4 0/4] VT-d minor fixes

2024-07-05 Thread CLEMENT MATHIEU--DRIF
From: Clément Mathieu--Drif Various fixes for VT-d This series contains fixes that will be necessary when adding in-guest (fully emulated) SVM support. v4 - Move declarations of VTD_FRCD_PV and VTD_FRCD_PP - intel_iommu: make types match: - edit commit message to explain that we

[PATCH qemu v2 0/3] hw/cxl: Misc minor improvements

2024-07-05 Thread Jonathan Cameron via
v2: Switch patch 1 from a patch that removes the cfmws_list element of CXLState to a fix that makes use of it to fix a crash. Now based on master as precursors merged. Before pushing on to more significant features a few unrelated patches doing tidying up + one to avoid people setting the

[PATCH v2 1/3] hw/cxl/cxl-host: Fix segmentation fault when getting cxl-fmw property

2024-07-05 Thread Jonathan Cameron via
From: Zhao Liu QEMU crashes (Segmentation fault) when getting cxl-fmw property via qmp: (QEMU) qom-get path=machine property=cxl-fmw This issue is caused by accessing wrong callback (opaque) type in machine_get_cfmw(). cxl_machine_init() sets the callback as `CXLState *` type but machine_get_c

Re: [PATCH qemu 0/3] hw/cxl: Misc minor improvements

2024-07-05 Thread Jonathan Cameron via
On Tue, 2 Jul 2024 15:34:22 +0100 Jonathan Cameron wrote: > Before pushing on to more significant features a few unrelated patches > doing tidying up + one to avoid people setting the memory backend both > for a CXL type 3 device and as normal RAM in an attempt to get SRAT to > cover it correctly

[PATCH v2 3/3] hw/cxl: Check for multiple mappings of memory backends.

2024-07-05 Thread Jonathan Cameron via
Similar protection to that provided for -numa memdev=x to make sure that memory used to back a type3 device is not also mapped as normal RAM, or for multiple type3 devices. This is an easy footgun to remove and seems multiple people have run into it. Signed-off-by: Jonathan Cameron --- hw/mem/c

Re: [PATCH] hw/cxl/cxl-host: Fix guest crash when getting cxl-fmw property

2024-07-05 Thread Jonathan Cameron via
On Fri, 5 Jul 2024 02:39:51 + "Zhijian Li (Fujitsu)" wrote: > On 04/07/2024 17:34, Zhao Liu wrote: > > From: Zhao Liu > > > > Guest crashes (Segmentation fault) when getting cxl-fmw property via > > qmp: > > > > IMO, it's fair to say "Guest crashes" which generally means the guest kerne

[PATCH v2 2/3] hw/cxl/cxl-mailbox-utils: remove unneeded mailbox output payload space zeroing

2024-07-05 Thread Jonathan Cameron via
From: Fan Ni The whole mailbox output payload space is already zeroed after copying out the input payload, which happens before processing the specific mailbox command: https://elixir.bootlin.com/qemu/v8.2.1/source/hw/cxl/cxl-device-utils.c#L204 Signed-off-by: Fan Ni Link: https://lore.kernel.o

Re: [PULL 17/20] target/arm: Do memory type alignment check when translation disabled

2024-07-05 Thread Bernhard Beschow
Am 27. Mai 2024 17:49:26 UTC schrieb Bernhard Beschow : > > >Am 27. Mai 2024 16:20:44 UTC schrieb Richard Henderson >: >>On 5/27/24 08:29, Bernhard Beschow wrote: >>> I think the kernel's output indicates that the MMU is active: >>> >>>[7e849b05] *pgd=2c552831, *pte=109eb34f, *ppte=109eb83

[PATCH qemu 0/4] hw/cxl: Add support for scan media.

2024-07-05 Thread Jonathan Cameron via
Now DCD is upstream, a number of sets that were dependent on it, that have otherwise been in a good state for a long time, are (hopefully) ready to upstream. I was also holding back series that were less critical for kernel testing to make sure they didn't distract from the progress of Dynamic Cap

  1   2   3   >