Re: [PATCH v4] hw/audio/virtio-snd: Always use little endian audio format

23.04.2024 00:18, Philippe Mathieu-Daudé wrote: The VIRTIO Sound Device conforms with the Virtio spec v1.2, thus only use little endianness. Remove the suspicious target_words_bigendian() noticed during code review. Cc: qemu-sta...@nongnu.org Fixes: eb9ad377bb ("virtio-sound: handle control mes

Re: [PATCH 3/3] ui/cocoa: Adds support for mouse cursors

On 2024/06/10 23:00, Phil Dennis-Jordan wrote: On Sun, 9 Jun 2024 at 11:06, Akihiko Odaki > wrote: Thanks for working on ui/cocoa, but I already have submitted a patch for this particular problem: https://patchew.org/QEMU/20240318-cursor-v1-0-0bbe

Re: Examining device state via monitor for debugging (was: [PATCH 0/2] hw/misc/mos6522: Do not open-code hmp_info_human_readable_text())

On Tue, Jun 11, 2024 at 07:49:12AM +0200, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > > > Officialise the QMP command, use the existing > > hmp_info_human_readable_text() helper. > > I'm not sure "officialise" is a word :) > > Taking a step back... "info via" and its new QMP co

[PATCH v8 4/7] migration/multifd: add qpl compression method

add the Query Processing Library (QPL) compression method Introduce the qpl as a new multifd migration compression method, it can use In-Memory Analytics Accelerator(IAA) to accelerate compression and decompression, which can not only reduce network bandwidth requirement but also reduce host compr

[PATCH v8 2/7] migration/multifd: put IOV initialization into compression method

Different compression methods may require different numbers of IOVs. Based on streaming compression of zlib and zstd, all pages will be compressed to a data block, so two IOVs are needed for packet header and compressed data block. Signed-off-by: Yuan Liu Reviewed-by: Nanhai Zou Reviewed-by: Fab

[PATCH v8 5/7] migration/multifd: implement initialization of qpl compression

during initialization, a software job is allocated to each channel for software path fallabck when the IAA hardware is unavailable or the hardware job submission fails. If the IAA hardware is available, multiple hardware jobs are allocated for batch processing. Signed-off-by: Yuan Liu Reviewed-by

[PATCH v8 3/7] configure: add --enable-qpl build option

add --enable-qpl and --disable-qpl options to enable and disable the QPL compression method for multifd migration. The Query Processing Library (QPL) is an open-source library that supports data compression and decompression features. It is based on the deflate compression algorithm and use Intel

[PATCH v8 7/7] tests/migration-test: add qpl compression test

add qpl to compression method test for multifd migration the qpl compression supports software path and hardware path(IAA device), and the hardware path is used first by default. If the hardware path is unavailable, it will automatically fallback to the software path for testing. Signed-off-by: Y

[PATCH v8 1/7] docs/migration: add qpl compression feature

add Intel Query Processing Library (QPL) compression method introduction Signed-off-by: Yuan Liu Reviewed-by: Nanhai Zou Reviewed-by: Fabiano Rosas Acked-by: Peter Xu --- docs/devel/migration/features.rst| 1 + docs/devel/migration/qpl-compression.rst | 260 +++

[PATCH v8 6/7] migration/multifd: implement qpl compression and decompression

QPL compression and decompression will use IAA hardware path if the IAA hardware is available. Otherwise the QPL library software path is used. The hardware path will automatically fall back to QPL software path if the IAA queues are busy. In some scenarios, this may happen frequently, such as con

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

On Mon, Jun 10, 2024 at 11:29:36PM +0300, Manos Pitsidianakis wrote: > On Mon, 10 Jun 2024 22:37, Pierrick Bouvier > wrote: > > > The staticlib artifact contains a bunch of mangled .o objects? > > > == > > > [staticlibmangledobjects] Bac

Re: Examining device state via monitor for debugging

On 11/06/2024 07:58, Manos Pitsidianakis wrote: On Tue, 11 Jun 2024 at 09:11, Mark Cave-Ayland wrote: On 11/06/2024 06:49, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: Officialise the QMP command, use the existing hmp_info_human_readable_text() helper. I'm not sure "official

Re: [PATCH 18/20] qga: add note about where to disable commands for a platform

Daniel P. Berrangé writes: > Any command that is known to be unimplemented on a given build target > must be disabled using a QAPI schema conditional. Only use dynamidc Suggest "should be disabled", for consistency with the comment below. s/dynamidc/dynamic/ > disabling for commands that requi

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

On 10/6/24 21:59, Stefan Hajnoczi wrote: On Mon, 10 Jun 2024 at 14:23, Manos Pitsidianakis wrote: Should QEMU provide wrapping Rust APIs over QEMU internals? --- [qemuprovidewrappingrustapis] Back to [TOC] My personal opinion is no, wi

Re: Examining device state via monitor for debugging

On 11/06/2024 08:57, Daniel P. Berrangé wrote: On Tue, Jun 11, 2024 at 07:49:12AM +0200, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: Officialise the QMP command, use the existing hmp_info_human_readable_text() helper. I'm not sure "officialise" is a word :) Taking a step back.

Re: [PATCH 2/3] target: Set TCGCPUOps::cpu_exec_halt to target's has_work implementation

On 3/6/24 18:09, Peter Maydell wrote: Currently the TCGCPUOps::cpu_exec_halt method is optional, and if it is not set then the default is to call the CPUClass::has_work method (which has an identical function signature). We would like to make the cpu_exec_halt method mandatory so we can remove t

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

On Mon, Jun 10, 2024 at 09:22:35PM +0300, Manos Pitsidianakis wrote: > What are the issues with not using the compiler, rustc, directly? > - > [whataretheissueswith] Back to [TOC] > > 1. Tooling >Mostly writing up the build-sys to

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

On Mon, Jun 10, 2024 at 09:22:35PM +0300, Manos Pitsidianakis wrote: > Hello everyone, > > This is an early draft of my work on implementing a very simple device, > in this case the ARM PL011 (which in C code resides in hw/char/pl011.c > and is used in hw/arm/virt.c). looking at the diffstat:

[PATCH] meson: Remove libumad dependence

RDMA based migration has no dependence on libumad, libibverbs and librdmacm are enough. libumad was used by rdmacm-mux which has been already removed. It's remained mistakenly. Fixes: 1dfd42c4264b ("hw/rdma: Remove deprecated pvrdma device and rdmacm-mux helper") Cc: Philippe Mathieu-Daudé Signe

Re: [PATCH 3/3] accel/tcg: Make TCGCPUOps::cpu_exec_halt mandatory

Hi Peter, On 3/6/24 18:09, Peter Maydell wrote: Now that all targets set TCGCPUOps::cpu_exec_halt, we can make it mandatory and remove the fallback handling that calls cpu_has_work. Signed-off-by: Peter Maydell --- include/hw/core/tcg-cpu-ops.h | 9 ++--- accel/tcg/cpu-exec.c |

Re: [PATCH 1/3] target/arm: Set arm_v7m_tcg_ops cpu_exec_halt to arm_cpu_exec_halt()

On 3/6/24 18:09, Peter Maydell wrote: In commit a96edb687e76 we set the cpu_exec_halt field of the TCGCPUOps arm_tcg_ops to arm_cpu_exec_halt(), but we left the arm_v7m_tcg_ops struct unchanged. That isn't wrong, because for M-profile FEAT_WFxT doesn't exist and the default handling for "no cpu_

Re: Examining device state via monitor for debugging (was: [PATCH 0/2] hw/misc/mos6522: Do not open-code hmp_info_human_readable_text())

On Tue, 11 Jun 2024 at 06:50, Markus Armbruster wrote: > > Philippe Mathieu-Daudé writes: > > > Officialise the QMP command, use the existing > > hmp_info_human_readable_text() helper. > > I'm not sure "officialise" is a word :) > > Taking a step back... "info via" and its new QMP counterpart >

Re: [PATCH 3/3] accel/tcg: Make TCGCPUOps::cpu_exec_halt mandatory

On Tue, 11 Jun 2024 at 09:25, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 3/6/24 18:09, Peter Maydell wrote: > > Now that all targets set TCGCPUOps::cpu_exec_halt, we can make it > > mandatory and remove the fallback handling that calls cpu_has_work. > > > > Signed-off-by: Peter Maydell >

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

On Mon, Jun 10, 2024 at 04:47:33PM -0400, Stefan Hajnoczi wrote: > On Mon, 10 Jun 2024 at 16:27, Manos Pitsidianakis > wrote: > > > > On Mon, 10 Jun 2024 22:59, Stefan Hajnoczi wrote: > > >> Should QEMU use third-party dependencies? > > >> - > > >> [shouldq

Re: Examining device state via monitor for debugging

On Tue, Jun 11, 2024 at 09:13:00AM +0100, Mark Cave-Ayland wrote: > On 11/06/2024 08:57, Daniel P. Berrangé wrote: > > > On Tue, Jun 11, 2024 at 07:49:12AM +0200, Markus Armbruster wrote: > > > Philippe Mathieu-Daudé writes: > > > > > > > Officialise the QMP command, use the existing > > > > hmp

Re: [PATCH 18/20] qga: add note about where to disable commands for a platform

On Tue, Jun 11, 2024 at 10:08:20AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > Any command that is known to be unimplemented on a given build target > > must be disabled using a QAPI schema conditional. Only use dynamidc > > Suggest "should be disabled", for consistency wi

Re: qemu-riscv32 usermode still broken?

Hi Alistair, > > Ok! > > So on my x86 machine I see this > > --- SIGCHLD {si_signo=SIGCHLD, si_code=CLD_EXITED, si_pid=285545, > si_uid=1000, si_status=0, si_utime=0, si_stime=0} --- > wait4(-1, [{WIFEXITED(s) && WEXITSTATUS(s) == 0}], > WNOHANG|WSTOPPED|WCONTINUED, NULL) = 285545 > wait4(-1,

Re: [PATCH v3 1/1] qga/linux: Add new api 'guest-network-get-route'

On Thu, Feb 29, 2024 at 8:48 AM Dehan Meng wrote: > The Route information of the Linux VM needs to be used > by administrators and users when debugging network problems > and troubleshooting. > > Signed-off-by: Dehan Meng > --- > qga/commands-posix.c | 81 +++

Re: [PATCH] meson: Remove libumad dependence

On 11/6/24 10:24, zhenwei pi wrote: RDMA based migration has no dependence on libumad, libibverbs and librdmacm are enough. libumad was used by rdmacm-mux which has been already removed. It's remained mistakenly. Great! Please also update tests/lcitool/projects/qemu.yml, with that: Reviewed-by

Re: [PATCH 08/20] qga: conditionalize schema for commands unsupported on Windows

Daniel P. Berrangé writes: > Rather than creating stubs for every command that just return > QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to > fully exclude generation of the commands on Windows. > > The command will be rejected at QMP dispatch time instead, > avoiding reimplementing

Re: [PATCH] meson: Remove libumad dependence

On 11/6/24 11:09, Philippe Mathieu-Daudé wrote: On 11/6/24 10:24, zhenwei pi wrote: RDMA based migration has no dependence on libumad, libibverbs and librdmacm are enough. libumad was used by rdmacm-mux which has been already removed. It's remained mistakenly. Great! Please also update tests/

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

Daniel P. Berrangé writes: > On Mon, Jun 10, 2024 at 11:29:36PM +0300, Manos Pitsidianakis wrote: >> On Mon, 10 Jun 2024 22:37, Pierrick Bouvier >> wrote: >> > > The staticlib artifact contains a bunch of mangled .o objects? >> > > ==

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

Pierrick Bouvier writes: > On 6/10/24 13:29, Manos Pitsidianakis wrote: >> On Mon, 10 Jun 2024 22:37, Pierrick Bouvier >> wrote: >>> Hello Manos, >>> >>> Excellent work, and thanks for posting this RFC! >>> >>> IMHO, having patches 2 and 5 splitted is a bit confusing, and exposing >>> (tempora

[PATCH v2 1/1] meson: Remove libibumad dependence

RDMA based migration has no dependence on libumad. libibverbs and librdmacm are enough. libumad was used by rdmacm-mux which has been already removed. It's remained mistakenly. Fixes: 1dfd42c4264b ("hw/rdma: Remove deprecated pvrdma device and rdmacm-mux helper") Cc: Philippe Mathieu-Daudé Signe

[PATCH v2 0/1] meson: Remove libibumad dependence

v1 -> v2: remove libibumad from tests/lcitool/projects/qemu.yml v1: remove libibumad dependence Zhenwei Pi (1): meson: Remove libibumad dependence meson.build | 4 +--- tests/lcitool/projects/qemu.yml | 1 - 2 files changed, 1 insertion(+), 4 deletions(-) -- 2.34.1

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

On Tue, Jun 11, 2024 at 09:22:44AM +0100, Daniel P. Berrangé wrote: > Date: Tue, 11 Jun 2024 09:22:44 +0100 > From: "Daniel P. Berrangé" > Subject: Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust > > On Mon, Jun 10, 2024 at 09:22:35PM +0300, Manos Pitsidianakis wrote: > > Hello everyone, > >

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

Stefan Hajnoczi writes: > On Mon, 10 Jun 2024 at 16:27, Manos Pitsidianakis > wrote: >> >> On Mon, 10 Jun 2024 22:59, Stefan Hajnoczi wrote: >> >> >> >> 1. Tooling >> >>Mostly writing up the build-sys tooling to do so. Ideally we'd >> >>compile everything without cargo but rustc direct

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

On Tue, Jun 11, 2024 at 09:18:25AM +0100, Daniel P. Berrangé wrote: > Date: Tue, 11 Jun 2024 09:18:25 +0100 > From: "Daniel P. Berrangé" > Subject: Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust > > On Mon, Jun 10, 2024 at 09:22:35PM +0300, Manos Pitsidianakis wrote: > > What are the issues w

Re: [PATCH v2 1/1] meson: Remove libibumad dependence

On 11/6/24 11:27, zhenwei pi wrote: RDMA based migration has no dependence on libumad. libibverbs and librdmacm are enough. libumad was used by rdmacm-mux which has been already removed. It's remained mistakenly. Fixes: 1dfd42c4264b ("hw/rdma: Remove deprecated pvrdma device and rdmacm-mux help

Re: [PATCH 3/3] accel/tcg: Make TCGCPUOps::cpu_exec_halt mandatory

On 11/6/24 10:36, Peter Maydell wrote: On Tue, 11 Jun 2024 at 09:25, Philippe Mathieu-Daudé wrote: Hi Peter, On 3/6/24 18:09, Peter Maydell wrote: Now that all targets set TCGCPUOps::cpu_exec_halt, we can make it mandatory and remove the fallback handling that calls cpu_has_work. Signed-off

Re: [PATCH] hw/usb: Introduce x-query-usbhost QMP command

On 10/6/24 10:33, Daniel P. Berrangé wrote: On Mon, Jun 10, 2024 at 08:38:47AM +0200, Philippe Mathieu-Daudé wrote: This is a counterpart to the HMP "info usbhost" command. It is being added with an "x-" prefix because this QMP command is intended as an adhoc debugging tool and will thus not be

Re: [PATCH v3 0/5] semihosting: Restrict to TCG

Philippe Mathieu-Daudé writes: > v3: Address Anton's comment > v2: Address Paolo's comment > > Semihosting currently uses the TCG probe_access API, > so it is pointless to have it in the binary when TCG > isn't. > > It could be implemented for other accelerators, but > work need to be done. Meanw

Re: [PATCH v3 00/13] riscv: QEMU RISC-V IOMMU Support

Hi Zhiwei, On 6/10/24 10:51 PM, LIU Zhiwei wrote: Hi Daniel, I want to know if we can use the IOMMU and IOPMP at the same time. AFAIK we can. They're not mutually exclusive since they offer protection and isolation at different layers/stages. The relationship between them is more similar

[PATCH v2 0/3] hw/usb: Introduce x-query-usbhost QMP command

Since v1: - Consider modules (Daniel) - Remove monitor_register_hmp Philippe Mathieu-Daudé (3): hw/usb: Remove unused 'host.h' header hw/usb: Introduce x-query-usbhost QMP command monitor: Remove monitor_register_hmp() qapi/machine.json | 18 +++ hw/usb/host-libusb.h

[PATCH v2 2/3] hw/usb: Introduce x-query-usbhost QMP command

This is a counterpart to the HMP "info usbhost" command. It is being added with an "x-" prefix because this QMP command is intended as an adhoc debugging tool and will thus not be modelled in QAPI as fully structured data, nor will it have long term guaranteed stability. The existing HMP command is

[PATCH v2 3/3] monitor: Remove monitor_register_hmp()

Previous commit removed the last use of monitor_register_hmp(), remove it so new commands are implemented using monitor_register_hmp_info_hrt(). Signed-off-by: Philippe Mathieu-Daudé --- include/monitor/monitor.h | 2 -- monitor/hmp-target.c | 16 2 files changed, 18 delet

[PATCH v2 1/3] hw/usb: Remove unused 'host.h' header

Since commit 99761176ee ("usb: Remove legacy -usbdevice options (host, serial, disk and net)") hw/usb/host.h is not used, remove it. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Thomas Huth --- hw/usb/host.h | 44 1 file changed, 44 deletions(-) de

[RFC PATCH v2 0/5] Implement ARM PL011 in Rust

Changes from v1->v2: - Create bindgen target first, then add commit for device (thanks Pierrick) - Create a special named generated.rs for each target as compilation would fail if more than one targets were defined. The generated.rs target names would clash. - Add more descriptive commit m

[RFC PATCH v2 1/5] build-sys: Add rust feature option

Add options for Rust in meson_options.txt, meson.build, configure to prepare for adding Rust code in the followup commits. `rust` is a reserved meson name, so we have to use an alternative. `with_rust` was chosen. A cargo_wrapper.py script is added that is heavily based on the work of Marc-André

[RFC PATCH v2 3/5] rust: add PL011 device model

This commit adds a re-implementation of hw/char/pl011.c in Rust. It uses generated Rust bindings (produced by `ninja aarch64-softmmu-generated.rs`) to register itself as a QOM type/class. How to build: 1. Make sure rust, cargo and bindgen (cargo install bindgen-cli) are installed 2. Configure

[RFC PATCH v2 4/5] DO NOT MERGE: add rustdoc build for gitlab pages

Deploy the generated rustdocs for my personal rust qemu fork on gitlab. The URL is: https://rust-for-qemu-epilys-aebb06ca9f9adfe6584811c14ae44156501d935ba4.gitlab.io/pl011/index.html Signed-off-by: Manos Pitsidianakis --- .gitlab-ci.d/buildtest.yml | 64 +++---

[RFC PATCH v2 2/5] rust: add bindgen step as a meson dependency

Add mechanism to generate rust hw targets that depend on a custom bindgen target for rust bindings to C. This way bindings will be created before the rust crate is compiled. The bindings will end up in BUILDDIR/{target}-generated.rs and have the same name as a target: ninja aarch64-softmmu-gene

[RFC PATCH v2 5/5] DO NOT MERGE: replace TYPE_PL011 with x-pl011-rust in arm virt machine

Convenience patch for testing the rust device. Signed-off-by: Manos Pitsidianakis --- hw/arm/virt.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 3c93c0c0a6..f33b58ae0d 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -912,7 +912,11 @@ static void c

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

On Tue, 11 Jun 2024 11:22, "Daniel P. Berrangé" wrote: On Mon, Jun 10, 2024 at 09:22:35PM +0300, Manos Pitsidianakis wrote: Hello everyone, This is an early draft of my work on implementing a very simple device, in this case the ARM PL011 (which in C code resides in hw/char/pl011.c and is us

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

On Tue, 11 Jun 2024 12:45, Zhao Liu wrote: On Tue, Jun 11, 2024 at 09:22:44AM +0100, Daniel P. Berrangé wrote: On Mon, Jun 10, 2024 at 09:22:35PM +0300, Manos Pitsidianakis wrote: > Hello everyone, > > This is an early draft of my work on implementing a very simple device, > in this case the

[PATCH v3 0/2] meson: Remove libibumad dependence

v2 -> v3: - refresh lcitool after removing libibumad v1 -> v2: - remove libibumad from tests/lcitool/projects/qemu.yml v1: - remove libibumad dependence Zhenwei Pi (2): meson: Remove libibumad dependence test: Remove libibumad dependence meson.build

[PATCH v3 1/2] meson: Remove libibumad dependence

RDMA based migration has no dependence on libumad. libibverbs and librdmacm are enough. libumad was used by rdmacm-mux which has been already removed. It's remained mistakenly. Fixes: 1dfd42c4264b ("hw/rdma: Remove deprecated pvrdma device and rdmacm-mux helper") Cc: Philippe Mathieu-Daudé Signe

[PATCH v3 2/2] test: Remove libibumad dependence

Remove libibumad dependence from the test environment. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: zhenwei pi --- scripts/ci/setup/ubuntu/ubuntu-2204-aarch64.yaml | 1 - scripts/ci/setup/ubuntu/ubuntu-2204-s390x.yaml| 1 - tests/docker/dockerfiles/debian-amd64-cross.docker

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

On Tue, 11 Jun 2024 11:18, "Daniel P. Berrangé" wrote: On Mon, Jun 10, 2024 at 09:22:35PM +0300, Manos Pitsidianakis wrote: What are the issues with not using the compiler, rustc, directly? - [whataretheissueswith] Back to [TOC] 1

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

On Mon, Jun 10, 2024 at 11:29:36PM +0300, Manos Pitsidianakis wrote: > On Mon, 10 Jun 2024 22:37, Pierrick Bouvier > wrote: > > Hello Manos, > > > > On 6/10/24 11:22, Manos Pitsidianakis wrote: > > > Hello everyone, > > > > > > This is an early draft of my work on implementing a very simple dev

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

On Tue, 11 Jun 2024 13:57, "Daniel P. Berrangé" wrote: On Mon, Jun 10, 2024 at 11:29:36PM +0300, Manos Pitsidianakis wrote: On Mon, 10 Jun 2024 22:37, Pierrick Bouvier wrote: > Hello Manos, > > On 6/10/24 11:22, Manos Pitsidianakis wrote: > > Hello everyone, > > > > This is an early draft o

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

On Tue, Jun 11, 2024 at 01:58:10PM +0300, Manos Pitsidianakis wrote: > On Tue, 11 Jun 2024 13:57, "Daniel P. Berrangé" wrote: > > On Mon, Jun 10, 2024 at 11:29:36PM +0300, Manos Pitsidianakis wrote: > > > On Mon, 10 Jun 2024 22:37, Pierrick Bouvier > > > wrote: > > > > Hello Manos, > > > > > On

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

On Tue, 11 Jun 2024 14:09, "Daniel P. Berrangé" wrote: On Tue, Jun 11, 2024 at 01:58:10PM +0300, Manos Pitsidianakis wrote: On Tue, 11 Jun 2024 13:57, "Daniel P. Berrangé" wrote: > On Mon, Jun 10, 2024 at 11:29:36PM +0300, Manos Pitsidianakis wrote: > > On Mon, 10 Jun 2024 22:37, Pierrick Bouv

Re: [PATCH] qtest/x86/numa-test: do not use the obsolete 'pentium' cpu

This patch has been successfully tested. After running the numa-test binary, now -cpu max is being used instead of the obsolete 'pentium' one. # starting QEMU: exec /home/qemu/build/qemu-system-x86_64 -qtest unix:/tmp/qtest-16915.sock -qtest-log /dev/null -chardev socket,path=/tmp/qtest-16915.qmp,

Re: [PATCH v3 0/2] meson: Remove libibumad dependence

On 11/6/24 12:54, zhenwei pi wrote: Zhenwei Pi (2): meson: Remove libibumad dependence test: Remove libibumad dependence Series: Reviewed-by: Philippe Mathieu-Daudé Thanks!

Re: [RFC PATCH] migration/savevm: do not schedule snapshot_save_job_bh in qemu_aio_context

Am 06.06.24 um 20:36 schrieb Stefan Hajnoczi: > On Wed, Jun 05, 2024 at 02:08:48PM +0200, Fiona Ebner wrote: >> The fact that the snapshot_save_job_bh() is scheduled in the main >> loop's qemu_aio_context AioContext means that it might get executed >> during a vCPU thread's aio_poll(). But saving o

[PATCH v2] hw/arm/virt: Avoid unexpected warning from Linux guest on host with Fujitsu CPUs

Multiple warning messages and corresponding backtraces are observed when Linux guest is booted on the host with Fujitsu CPUs. One of them is shown as below. [0.032443] [ cut here ] [0.032446] uart-pl011 900.pl011: ARCH_DMA_MINALIGN smaller than CTR_EL0.CWG (128

Re: [PATCH v2] hw/arm/virt: Avoid unexpected warning from Linux guest on host with Fujitsu CPUs

On Tue, 11 Jun 2024 at 13:12, Zhenyu Zhang wrote: > > Multiple warning messages and corresponding backtraces are observed when Linux > guest is booted on the host with Fujitsu CPUs. One of them is shown as below. > > [0.032443] [ cut here ] > [0.032446] uart-pl011 9

Re: [PATCH v4] hw/audio/virtio-snd: Always use little endian audio format

On 11/6/24 09:15, Michael Tokarev wrote: 23.04.2024 00:18, Philippe Mathieu-Daudé wrote: The VIRTIO Sound Device conforms with the Virtio spec v1.2, thus only use little endianness. Remove the suspicious target_words_bigendian() noticed during code review. Cc: qemu-sta...@nongnu.org Fixes: eb9

Re: Examining device state via monitor for debugging (was: [PATCH 0/2] hw/misc/mos6522: Do not open-code hmp_info_human_readable_text())

* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Tue, 11 Jun 2024 at 06:50, Markus Armbruster wrote: > > > > Philippe Mathieu-Daudé writes: > > > > > Officialise the QMP command, use the existing > > > hmp_info_human_readable_text() helper. > > > > I'm not sure "officialise" is a word :) >

[PATCH v1] virtio-iommu: add error check before assert

A fuzzer case discovered by Zheyu Ma causes an assert failure. Add a check before the assert, and respond with an error before moving on to the next queue element. To reproduce the failure: cat << EOF | \ qemu-system-x86_64 \ -display none -machine accel=qtest -m 512M -machine q35 -nodefaults \

Re: [PATCH v3] i386/cpu: fixup number of addressable IDs for processor cores in the physical package

Queued, thanks. Paolo

Re: [PATCH v2 1/3] hw/usb: Remove unused 'host.h' header

On Tue, Jun 11, 2024 at 12:23:03PM +0200, Philippe Mathieu-Daudé wrote: > Since commit 99761176ee ("usb: Remove legacy -usbdevice options > (host, serial, disk and net)") hw/usb/host.h is not used, remove > it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: Thomas Huth > --- > hw/usb/hos

Re: [PATCH 0/3] snp: fix coverity reported issues

Queued, thanks. Paolo

Re: [PATCH v2 2/3] hw/usb: Introduce x-query-usbhost QMP command

On Tue, Jun 11, 2024 at 12:23:04PM +0200, Philippe Mathieu-Daudé wrote: > This is a counterpart to the HMP "info usbhost" command. It is being > added with an "x-" prefix because this QMP command is intended as an > adhoc debugging tool and will thus not be modelled in QAPI as fully > structured da

Re: [PATCH v2 3/3] monitor: Remove monitor_register_hmp()

On Tue, Jun 11, 2024 at 12:23:05PM +0200, Philippe Mathieu-Daudé wrote: > Previous commit removed the last use of monitor_register_hmp(), > remove it so new commands are implemented using > monitor_register_hmp_info_hrt(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/monitor/monitor

Re: [PATCH] tests/qtest/fuzz: fix memleak in qos_fuzz.c

ping https://patchew.org/QEMU/20240521103106.119021-3-fro...@swemel.ru/ On 21.05.2024 13:31, Dmitry Frolov wrote: Found with fuzzing for qemu-8.2, but also relevant for master Signed-off-by: Dmitry Frolov --- tests/qtest/fuzz/qos_fuzz.c | 1 + 1 file changed, 1 insertion(+) diff --git a/t

Re: [PATCH v4 2/4] vvfat: Fix usage of `info.file.offset`

On Mon, Jun 10, 2024 at 06:49:43PM +0200, Kevin Wolf wrote: > Am 05.06.2024 um 02:58 hat Amjad Alsharafi geschrieben: > > The field is marked as "the offset in the file (in clusters)", but it > > was being used like this > > `cluster_size*(nums)+mapping->info.file.offset`, which is incorrect. > >

Re: [PATCH] tests/qtest/fuzz/virtio_net_fuzz.c: fix virtio_net_fuzz_multi

ping https://patchew.org/QEMU/20240523102813.396750-2-fro...@swemel.ru/ On 23.05.2024 13:28, Dmitry Frolov wrote: If QTestState was already CLOSED due to error, calling qtest_clock_step() afterwards makes no sense and only raises false-crash with message: "assertion timer != NULL failed". Sign

Re: [PATCH] hw/net/virtio-net.c: fix crash in iov_copy()

ping https://patchew.org/QEMU/20240527133140.218300-2-fro...@swemel.ru/ On 27.05.2024 16:31, Dmitry Frolov wrote: A crash found while fuzzing device virtio-net-socket-check-used. Assertion "offset == 0" in iov_copy() fails if less than guest_hdr_len bytes were transmited. Signed-off-by: Dmitry

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

Hi there :) On 11/06/2024 12:58, Manos Pitsidianakis wrote: On Tue, 11 Jun 2024 13:57, "Daniel P. Berrangé" wrote: On Mon, Jun 10, 2024 at 11:29:36PM +0300, Manos Pitsidianakis wrote: On Mon, 10 Jun 2024 22:37, Pierrick Bouvier wrote: > Hello Manos, > > On 6/10/24 11:22, Manos Pitsidianakis

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

Daniel P. Berrangé writes: > On Tue, Jun 11, 2024 at 01:58:10PM +0300, Manos Pitsidianakis wrote: >> On Tue, 11 Jun 2024 13:57, "Daniel P. Berrangé" wrote: >> > On Mon, Jun 10, 2024 at 11:29:36PM +0300, Manos Pitsidianakis wrote: >> > > On Mon, 10 Jun 2024 22:37, Pierrick Bouvier >> > > wrote:

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

Hello Antonio! On Tue, 11 Jun 2024 15:45, Antonio Caggiano wrote: Hi there :) On 11/06/2024 12:58, Manos Pitsidianakis wrote: On Tue, 11 Jun 2024 13:57, "Daniel P. Berrangé" wrote: On Mon, Jun 10, 2024 at 11:29:36PM +0300, Manos Pitsidianakis wrote: On Mon, 10 Jun 2024 22:37, Pierrick Bouvi

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

On Tue, Jun 11, 2024 at 01:51:13PM +0100, Alex Bennée wrote: > Daniel P. Berrangé writes: > > > On Tue, Jun 11, 2024 at 01:58:10PM +0300, Manos Pitsidianakis wrote: > >> On Tue, 11 Jun 2024 13:57, "Daniel P. Berrangé" > >> wrote: > >> > On Mon, Jun 10, 2024 at 11:29:36PM +0300, Manos Pitsidiana

[PATCH v2] qapi: clarify that the default is backend dependent

The default value of the @share option of the @MemoryBackendProperties really depends on the backend type, so let's document the default values in the same place where we define the option to avoid dispersing the information. Cc: David Hildenbrand Suggested-by: Markus Armbruster Signed-off-by: S

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

On Mon, Jun 10, 2024 at 10:47 PM Stefan Hajnoczi wrote: > On Mon, 10 Jun 2024 at 16:27, Manos Pitsidianakis > wrote: > > > > On Mon, 10 Jun 2024 22:59, Stefan Hajnoczi wrote: > > >> What are the issues with not using the compiler, rustc, directly? > > >> -

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

On Tue, Jun 11, 2024 at 10:22 AM Daniel P. Berrangé wrote: > > On Mon, Jun 10, 2024 at 09:22:35PM +0300, Manos Pitsidianakis wrote: > > Hello everyone, > > > > This is an early draft of my work on implementing a very simple device, > > in this case the ARM PL011 (which in C code resides in hw/char

Re: [PATCH 08/20] qga: conditionalize schema for commands unsupported on Windows

Daniel P. Berrangé writes: > Rather than creating stubs for every command that just return > QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to > fully exclude generation of the commands on Windows. > > The command will be rejected at QMP dispatch time instead, > avoiding reimplementing

Re: [PATCH 08/20] qga: conditionalize schema for commands unsupported on Windows

On Tue, Jun 11, 2024 at 03:55:37PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > Rather than creating stubs for every command that just return > > QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to > > fully exclude generation of the commands on Windows. > > > > The

Re: [RFC PATCH] migration/savevm: do not schedule snapshot_save_job_bh in qemu_aio_context

On Tue, Jun 11, 2024 at 02:08:49PM +0200, Fiona Ebner wrote: > Am 06.06.24 um 20:36 schrieb Stefan Hajnoczi: > > On Wed, Jun 05, 2024 at 02:08:48PM +0200, Fiona Ebner wrote: > >> The fact that the snapshot_save_job_bh() is scheduled in the main > >> loop's qemu_aio_context AioContext means that it

Re: [RFC PATCH v1 1/6] build-sys: Add rust feature option

On Mon, Jun 10, 2024 at 09:22:36PM +0300, Manos Pitsidianakis wrote: > Add options for Rust in meson_options.txt, meson.build, configure to > prepare for adding Rust code in the followup commits. > > `rust` is a reserved meson name, so we have to use an alternative. > `with_rust` was chosen. > >

Re: [PATCH] hw/net/virtio-net.c: fix crash in iov_copy()

Дмитрий Фролов writes: > ping > > https://patchew.org/QEMU/20240527133140.218300-2-fro...@swemel.ru/ > > On 27.05.2024 16:31, Dmitry Frolov wrote: >> A crash found while fuzzing device virtio-net-socket-check-used. >> Assertion "offset == 0" in iov_copy() fails if less than guest_hdr_len bytes >>

Re: [PATCH v2] qapi: clarify that the default is backend dependent

Stefano Garzarella writes: > The default value of the @share option of the @MemoryBackendProperties > really depends on the backend type, so let's document the default > values in the same place where we define the option to avoid > dispersing the information. > > Cc: David Hildenbrand > Suggest

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

On Tue, Jun 11, 2024 at 03:16:19PM +0200, Paolo Bonzini wrote: > On Tue, Jun 11, 2024 at 10:22 AM Daniel P. Berrangé > wrote: > > > > On Mon, Jun 10, 2024 at 09:22:35PM +0300, Manos Pitsidianakis wrote: > > > Hello everyone, > > > > > > This is an early draft of my work on implementing a very sim

Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust

On Tue, Jun 11, 2024 at 01:41:57PM +0300, Manos Pitsidianakis wrote: > Date: Tue, 11 Jun 2024 13:41:57 +0300 > From: Manos Pitsidianakis > Subject: Re: [RFC PATCH v1 0/6] Implement ARM PL011 in Rust > > > Currently, pl011 exclusively occupies a cargo as a package. In the > > future, will other Ru

Re: [RFC PATCH v1 1/6] build-sys: Add rust feature option

Stefan Hajnoczi writes: > On Mon, Jun 10, 2024 at 09:22:36PM +0300, Manos Pitsidianakis wrote: >> Add options for Rust in meson_options.txt, meson.build, configure to >> prepare for adding Rust code in the followup commits. >> >> `rust` is a reserved meson name, so we have to use an alternative.

[PULL 03/25] i386/sev: fix unreachable code coverity issue

From: Pankaj Gupta Set 'finish->id_block_en' early, so that it is properly reset. Fixes coverity CID 1546887. Fixes: 7b34df4426 ("i386/sev: Introduce 'sev-snp-guest' object") Signed-off-by: Pankaj Gupta Message-ID: <20240607183611.100-2-pankaj.gu...@amd.com> Signed-off-by: Paolo Bonzini -

[PULL 02/25] i386/cpu: fixup number of addressable IDs for processor cores in the physical package

From: Chuang Xu When QEMU is started with: -cpu host,host-cache-info=on,l3-cache=off \ -smp 2,sockets=1,dies=1,cores=1,threads=2 Guest can't acquire maximum number of addressable IDs for processor cores in the physical package from CPUID[04H]. When creating a CPU topology of 1 core per package,

[PULL 04/25] i386/sev: Move SEV_COMMON null check before dereferencing

From: Pankaj Gupta Fixes Coverity CID 1546886. Fixes: 9861405a8f ("i386/sev: Invoke launch_updata_data() for SEV class") Signed-off-by: Pankaj Gupta Message-ID: <20240607183611.100-3-pankaj.gu...@amd.com> Signed-off-by: Paolo Bonzini --- target/i386/sev.c | 3 ++- 1 file changed, 2 insert

[PULL 16/25] target/i386: replace read_crN helper with read_cr8

All other control registers are stored plainly in CPUX86State. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- target/i386/helper.h | 2 +- target/i386/tcg/sysemu/misc_helper.c | 20 +--- target/i386/tcg/emit.c.inc | 2 +- 3 files chan

  1   2   >