RE: [PATCH v7 1/7] docs/migration: add qpl compression feature

2024-06-06 Thread Liu, Yuan1
> -Original Message- > From: Fabiano Rosas > Sent: Thursday, June 6, 2024 4:00 AM > To: Liu, Yuan1 ; pet...@redhat.com; > pbonz...@redhat.com; marcandre.lur...@redhat.com; berra...@redhat.com; > th...@redhat.com; phi...@linaro.org > Cc: qemu-devel@nongnu.org; Liu, Yuan1 ; Zou, Nanhai > ; s

RE: [PATCH 5/7] migration/multifd: Add UADK based compression and decompression

2024-06-06 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: Fabiano Rosas > Sent: Wednesday, June 5, 2024 7:57 PM > To: Shameerali Kolothum Thodi ; > pet...@redhat.com; yuan1@intel.com > Cc: qemu-devel@nongnu.org; Linuxarm ; linwenkai > (C) ; zhangfei@linaro.org; huangchenghai > > Subject: Re: [PATCH 5/7] mi

Re: [PULL 07/20] virtio-net: Do not propagate ebpf-rss-fds errors

2024-06-06 Thread Daniel P . Berrangé
On Thu, Jun 06, 2024 at 05:14:20AM +0900, Akihiko Odaki wrote: > On 2024/06/05 19:23, Daniel P. Berrangé wrote: > > On Tue, Jun 04, 2024 at 03:37:42PM +0800, Jason Wang wrote: > > > From: Akihiko Odaki > > > > > > Propagating ebpf-rss-fds errors has several problems. > > > > > > First, it makes

Re: [PULL 07/20] virtio-net: Do not propagate ebpf-rss-fds errors

2024-06-06 Thread Akihiko Odaki
On 2024/06/06 16:14, Daniel P. Berrangé wrote: On Thu, Jun 06, 2024 at 05:14:20AM +0900, Akihiko Odaki wrote: On 2024/06/05 19:23, Daniel P. Berrangé wrote: On Tue, Jun 04, 2024 at 03:37:42PM +0800, Jason Wang wrote: From: Akihiko Odaki Propagating ebpf-rss-fds errors has several problems.

Re: [PATCH v4 0/5] backends/hostmem: Report more errors on failures

2024-06-06 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH] scsi-disk: Don't silently truncate serial number

2024-06-06 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH] stubs/meson: Fix qemuutil build when --disable-system

2024-06-06 Thread Paolo Bonzini
On 6/5/24 17:25, Zhao Liu wrote: Compiling without system, user, tools or guest-agent fails with the following error message: ./configure --disable-system --disable-user --disable-tools \ --disable-guest-agent error message: /usr/bin/ld: libqemuutil.a.p/util_error-report.c.o: in function `erro

Re: [PATCH] stubs/meson: Fix qemuutil build when --disable-system

2024-06-06 Thread Zhao Liu
On Thu, Jun 06, 2024 at 09:41:47AM +0200, Paolo Bonzini wrote: > Date: Thu, 6 Jun 2024 09:41:47 +0200 > From: Paolo Bonzini > Subject: Re: [PATCH] stubs/meson: Fix qemuutil build when --disable-system > > On 6/5/24 17:25, Zhao Liu wrote: > > Compiling without system, user, tools or guest-agent fa

Re: [PULL 07/20] virtio-net: Do not propagate ebpf-rss-fds errors

2024-06-06 Thread Daniel P . Berrangé
On Thu, Jun 06, 2024 at 04:19:11PM +0900, Akihiko Odaki wrote: > On 2024/06/06 16:14, Daniel P. Berrangé wrote: > > On Thu, Jun 06, 2024 at 05:14:20AM +0900, Akihiko Odaki wrote: > > > On 2024/06/05 19:23, Daniel P. Berrangé wrote: > > > > On Tue, Jun 04, 2024 at 03:37:42PM +0800, Jason Wang wrote:

RE: [PATCH v3] mem/cxl_type3: support 3, 6, 12 and 16 interleave ways

2024-06-06 Thread Xingtao Yao (Fujitsu)
ping again. > -Original Message- > From: Yao, Xingtao/姚 幸涛 > Sent: Friday, May 24, 2024 5:31 PM > To: Yao, Xingtao/姚 幸涛 ; > jonathan.came...@huawei.com; fan...@samsung.com > Cc: qemu-devel@nongnu.org > Subject: RE: [PATCH v3] mem/cxl_type3: support 3, 6, 12 and 16 interleave ways > > pin

Re: [PATCH 01/20] qga: drop blocking of guest-get-memory-block-size command

2024-06-06 Thread Manos Pitsidianakis
On Tue, 04 Jun 2024 16:49, "Daniel P. Berrangé" wrote: This command has never existed in tree, since it was renamed to guest-get-memory-block-info before being merged. Signed-off-by: Daniel P. Berrangé --- Reviewed-by: Manos Pitsidianakis qga/commands-posix.c | 2 +- qga/commands-win32.c |

[PATCH 0/2] python: expect a working python3-tomli package for Python <3.11

2024-06-06 Thread Paolo Bonzini
pythondeps.toml is parsed using either Python's embedded tomllib parser new in Python 3.11, or the external tomli library for older versions. The latter however was absent in Ubuntu 20.04, so we include a copy of the wheel in python/wheels. (For Debian bullseye, it is included in the backports rep

[PATCH 2/2] python: mkvenv: remove ensure command

2024-06-06 Thread Paolo Bonzini
This was used to bootstrap the venv with a TOML parser, after which ensuregroup is used. Now that we expect it to be present as a system package (either tomli or, for Python 3.11, tomllib), it is not needed anymore. Note that this means that, when implemented, the hypothetical "isolated" mode tha

[PATCH 1/2] Revert "python: use vendored tomli"

2024-06-06 Thread Paolo Bonzini
Now that Ubuntu 20.04 is not included anymore, there is no need to ship it as part of QEMU; Ubuntu 22.04 includes it and Leap users anyway need to install all the required dependencies from PyPI. This mostly reverts commit ec77ee7634de123b7c899739711000fd21dab68b, with just some changes to the wor

Re: [PATCH 02/20] qga: move linux vcpu command impls to commands-linux.c

2024-06-06 Thread Manos Pitsidianakis
On Tue, 04 Jun 2024 16:49, "Daniel P. Berrangé" wrote: The qmp_guest_set_vcpus and qmp_guest_get_vcpus command impls in commands-posix.c are surrounded by '#ifdef __linux__' so should instead live in commands-linux.c Signed-off-by: Daniel P. Berrangé --- Reviewed-by: Manos Pitsidianakis

Re: [PATCH 03/20] qga: move linux suspend command impls to commands-linux.c

2024-06-06 Thread Manos Pitsidianakis
On Tue, 04 Jun 2024 16:49, "Daniel P. Berrangé" wrote: The qmp_guest_suspend_{disk,ram,hybrid} command impls in commands-posix.c are surrounded by '#ifdef __linux__' so should instead live in commands-linux.c Signed-off-by: Daniel P. Berrangé --- Reviewed-by: Manos Pitsidianakis qga/comm

Re: [PATCH 04/20] qga: move linux fs/disk command impls to commands-linux.c

2024-06-06 Thread Manos Pitsidianakis
On Tue, 04 Jun 2024 16:49, "Daniel P. Berrangé" wrote: The qmp_guest_{fstrim, get_fsinfo, get_disks} command impls in commands-posix.c are surrounded by '#ifdef __linux__' so should instead live in commands-linux.c Signed-off-by: Daniel P. Berrangé --- Reviewed-by: Manos Pitsidianakis qg

Re: [PATCH v3 0/7] hvf x86 correctness and efficiency improvements

2024-06-06 Thread Paolo Bonzini
Queued, thanks. Thanks for persisting! It sucks that the hv_vcpu_interrupt() API docs are not clear, but your tests are great. The self-interrupt one is the case that I was most worried about, and you're covering it. Sorry for being a pain for nothing, at least retrospectively. Paolo

Re: linux-user emulation hangs during fork

2024-06-06 Thread Andreas Schwab
Which ruby? $ ruby --version ruby 3.3.1 (2024-04-23 revision c56cd86388) [x86_64-linux-gnu] -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH v3 3/3] ui+display: rename is_buffer_shared() -> surface_is_allocated()

2024-06-06 Thread Paul Durrant
On 05/06/2024 14:14, Gerd Hoffmann wrote: Boolean return value is reversed, to align with QEMU_ALLOCATED_FLAG, so all callers must be adapted. Also rename share_surface variable in vga_draw_graphic() to reduce confusion. No functional change. Suggested-by: Marc-André Lureau Signed-off-by: Ger

[PATCH] docs: i386: pc: Avoid mentioning limit of maximum vCPUs

2024-06-06 Thread Zhao Liu
Different versions of PC machine support different maximum vCPUs, and even different features have limits on the maximum number of vCPUs ( For example, if x2apic is not enabled in the TCG case, the maximum of 255 vCPUs are supported). It is difficult to list the maximum vCPUs under all restriction

kvm crash with virtiofs

2024-06-06 Thread Miklos Szeredi
Hi, I get the below crash when running virtio-fs on fedora 39. Note: weirdly this makes chrome running on the host also crash. Eric Sandeen also reported some bad behavior of virtio-fs on fc39, which might be related. Versions: kernel-6.8.4-200.fc39.x86_64 qemu-kvm-8.1.3-5.fc39.x86_64 virtiofsd

Re: [PATCH] docs: i386: pc: Avoid mentioning limit of maximum vCPUs

2024-06-06 Thread Daniel P . Berrangé
On Thu, Jun 06, 2024 at 04:54:36PM +0800, Zhao Liu wrote: > Different versions of PC machine support different maximum vCPUs, and > even different features have limits on the maximum number of vCPUs ( > For example, if x2apic is not enabled in the TCG case, the maximum of > 255 vCPUs are supported)

Re: [PATCH v3 0/7] hvf x86 correctness and efficiency improvements

2024-06-06 Thread Phil Dennis-Jordan
On Thu, 6 Jun 2024 at 10:24, Paolo Bonzini wrote: > Queued, thanks. Thanks - also for reviewing, etc.! > Thanks for persisting! It sucks that the hv_vcpu_interrupt() API docs > are not clear, but your tests are great. The self-interrupt one is > the case that I was most worried about, and you'

Re: [PATCH v3 4/6] target/i386: add support for VMX FRED controls

2024-06-06 Thread Paolo Bonzini
On 11/9/23 08:20, Xin Li wrote: Add VMX FRED controls used to enable save/load of FRED MSRs. Tested-by: Shan Kang Signed-off-by: Xin Li --- scripts/kvm/vmxcap | 3 +++ target/i386/cpu.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/kvm/vmxcap b/scripts/kvm/

Re: [PATCH] docs: i386: pc: Avoid mentioning limit of maximum vCPUs

2024-06-06 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH v2 0/6] target/i386: Misc cleanup on KVM PV defs and outdated comments

2024-06-06 Thread Zhao Liu
Hi Paolo, Just a ping for this cleanup series. Thanks, Zhao On Mon, May 06, 2024 at 04:51:47PM +0800, Zhao Liu wrote: > Date: Mon, 6 May 2024 16:51:47 +0800 > From: Zhao Liu > Subject: [PATCH v2 0/6] target/i386: Misc cleanup on KVM PV defs and > outdated comments > X-Mailer: git-send-email 2.

Re: [PATCH v5 0/3] Fix MCE handling on AMD hosts

2024-06-06 Thread Paolo Bonzini
Queued, thanks. I added a note to the commit message in the third patch: By the time the MCE reaches the guest, the overflow has been handled by the host and has not caused a shutdown, so include the bit unconditionally. Advertising of SUCCOR and OVERFLOW_RECOV in KVM would still be nic

Re: [PATCH v6 09/19] vfio/iommufd: Implement HostIOMMUDeviceClass::realize() handler

2024-06-06 Thread Eric Auger
Hi Zhenzhong, On 6/3/24 08:10, Zhenzhong Duan wrote: > It calls iommufd_backend_get_device_info() to get host IOMMU > related information and translate it into HostIOMMUDeviceCaps > for query with .get_cap(). > > Introduce macro VTD_MGAW_FROM_CAP to get MGAW which equals to > (aw_bits - 1). > > Sig

Re: [PATCH qemu ] hw/acpi: Fix big endian host creation of Generic Port Affinity Structures

2024-06-06 Thread Jonathan Cameron via
On Wed, 5 Jun 2024 19:38:18 -0400 "Michael S. Tsirkin" wrote: > On Wed, Jun 05, 2024 at 07:04:55PM +0100, Jonathan Cameron wrote: > > Treating the HID as an integer caused it to get bit reversed > > on big endian hosts running little endian guests. Treat it > > as a character array instead. > >

Re: [PATCH v6 09/19] vfio/iommufd: Implement HostIOMMUDeviceClass::realize() handler

2024-06-06 Thread Eric Auger
On 6/6/24 11:26, Eric Auger wrote: > Hi Zhenzhong, > On 6/3/24 08:10, Zhenzhong Duan wrote: >> It calls iommufd_backend_get_device_info() to get host IOMMU >> related information and translate it into HostIOMMUDeviceCaps >> for query with .get_cap(). >> >> Introduce macro VTD_MGAW_FROM_CAP to ge

[PATCH] machine, hostmem: improve error messages for unsupported features

2024-06-06 Thread Paolo Bonzini
Detect early unsupported MADV_MERGEABLE and MADV_DONTDUMP, and print a clearer error message that points to the deficiency of the host. Cc: Michal Privoznik Signed-off-by: Paolo Bonzini --- backends/hostmem.c | 16 hw/core/machine.c | 9 + 2 files changed, 25 insertio

[PATCH] hostmem: simplify the code

2024-06-06 Thread Paolo Bonzini
No semantic change, just simpler control flow. Signed-off-by: Paolo Bonzini --- backends/hostmem.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/backends/hostmem.c b/backends/hostmem.c index 37be93c8bb3..33baca6a974 100644 --- a/backends/hostmem.c

Re: [PATCH v2 1/9] tcg: Introduce INDEX_op_plugin_pc

2024-06-06 Thread Alex Bennée
Richard Henderson writes: > Add an opcode to find a code address within the current insn, > for later use with unwinding. Generate the code generically > using tcg_reg_alloc_do_movi. > > Reviewed-by: Pierrick Bouvier > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Benné

Re: [PATCH v2 2/9] accel/tcg: Set CPUState.plugin_ra before all plugin callbacks

2024-06-06 Thread Alex Bennée
Richard Henderson writes: > Store a host code address to use with the tcg unwinder when called > from a plugin. Generate one such store per guest insn that uses > a plugin callback. > > Reviewed-by: Pierrick Bouvier > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v2 3/9] accel/tcg: Return the TranslationBlock from cpu_unwind_state_data

2024-06-06 Thread Alex Bennée
Richard Henderson writes: > Adjust the i386 get_memio_eip function to use tb->cflags instead > of tcg_cflags_has, which is technically more correct. > > Reviewed-by: Pierrick Bouvier > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v2 4/9] plugins: Introduce TCGCPUOps callbacks for mid-tb register reads

2024-06-06 Thread Alex Bennée
Richard Henderson writes: > Certain target registers are not updated continuously within > the translation block. For normal exception handling we use > unwind info to re-generate the correct value when required. > Leverage that same info for reading those registers for plugins. > > All targets

Re: [PATCH 3/3] hw/riscv/virt-acpi-build.c: Update the HID of RISC-V UART

2024-06-06 Thread Sunil V L
Hi Igor, On Wed, Jun 05, 2024 at 04:48:14PM +0200, Igor Mammedov wrote: > On Tue, 28 May 2024 13:01:03 +0530 > Sunil V L wrote: > > > RISC-V is going to use new HID RSCV0003 for generi UART. So, update the > > HID. > > where does it come from? > > > > > Signed-off-by: Sunil V L > > --- > > h

Re: [PATCH v2 7/9] target/i386: Implement TCGCPUOps for plugin register reads

2024-06-06 Thread Alex Bennée
Richard Henderson writes: > Reviewed-by: Pierrick Bouvier > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PATCH 3/4] target/i386: fix SP when taking a memory fault during POP

2024-06-06 Thread Mark Cave-Ayland
When OS/2 Warp configures its segment descriptors, many of them are configured with the P flag clear to allow for a fault-on-demand implementation. In the case where the stack value is POPped into the segment registers, the SP is incremented before calling gen_helper_load_seg() to validate the s

[PATCH 1/4] target/i386: use local X86DecodedOp in gen_POP()

2024-06-06 Thread Mark Cave-Ayland
This will make subsequent changes a little easier to read. Signed-off-by: Mark Cave-Ayland --- target/i386/tcg/emit.c.inc | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/i386/tcg/emit.c.inc b/target/i386/tcg/emit.c.inc index e990141454..a89f8e0ebb 100644 --- a/ta

[PATCH 4/4] target/i386: fix size of EBP writeback in gen_enter()

2024-06-06 Thread Mark Cave-Ayland
The calculation of FrameTemp is done using the size indicated by mo_pushpop() before being written back to EBP, but the final writeback to EBP is done using the size indicated by mo_stacksize(). In the case where mo_pushpop() is MO_32 and mo_stacksize() is MO_16 then the final writeback to EBP is

[PATCH 2/4] target/i386: use gen_writeback() within gen_POP()

2024-06-06 Thread Mark Cave-Ayland
Instead of directly implementing the writeback using gen_op_st_v(), use the existing gen_writeback() function. Suggested-by: Paolo Bonzini Signed-off-by: Mark Cave-Ayland --- target/i386/tcg/emit.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/tcg/emit.c.in

[PATCH 0/4] target/i386: fixes for OS/2 Warp

2024-06-06 Thread Mark Cave-Ayland
This series contains two fixes which allow booting OS/2 Warp in QEMU with TCG (currently it only boots with KVM). Patches 1 and 2 are tidy-ups which prepare for the POP SP fix in patch 3, whilst patch 4 is the final fix for ENTER that allows my test image to boot successfully. Signed-off-by: Mark

Re: [PATCH] hostmem: simplify the code

2024-06-06 Thread Philippe Mathieu-Daudé
On 6/6/24 11:37, Paolo Bonzini wrote: No semantic change, just simpler control flow. Signed-off-by: Paolo Bonzini --- backends/hostmem.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: Unexpected error in rme_configure_one() at ../target/arm/kvm-rme.c:159

2024-06-06 Thread Gavin Shan
On 6/6/24 15:05, Gavin Shan wrote: Even the edk2 for the guest can be built successfully, but I'm not able to try it because I'm unable to bring up the host now. I tried to rebuild the environment from scratch, the host runs into crash inside EDK2 unfortunately...   TF-RMM:   https://git.cod

RE: [PATCH v6 09/19] vfio/iommufd: Implement HostIOMMUDeviceClass::realize() handler

2024-06-06 Thread Duan, Zhenzhong
Hi Eric, >-Original Message- >From: Eric Auger >Subject: Re: [PATCH v6 09/19] vfio/iommufd: Implement >HostIOMMUDeviceClass::realize() handler > > > >On 6/6/24 11:26, Eric Auger wrote: >> Hi Zhenzhong, >> On 6/3/24 08:10, Zhenzhong Duan wrote: >>> It calls iommufd_backend_get_device_info(

Re: [PATCH v2 4/9] plugins: Introduce TCGCPUOps callbacks for mid-tb register reads

2024-06-06 Thread Alex Bennée
Alex Bennée writes: > Richard Henderson writes: > >> Certain target registers are not updated continuously within >> the translation block. For normal exception handling we use >> unwind info to re-generate the correct value when required. >> Leverage that same info for reading those registers

[PATCH v11 1/2] virtio-pci: only reset pm state during resetting

2024-06-06 Thread Jiqian Chen
Fix bug imported by 27ce0f3afc9dd ("fix Power Management Control Register for PCI Express virtio devices" After this change, observe that QEMU may erroneously clear the power status of the device, or may erroneously clear non writable registers, such as NO_SOFT_RESET, etc. Only state of PM_CTRL

[PATCH] tracetool: Remove unused vcpu.py script

2024-06-06 Thread Philippe Mathieu-Daudé
vcpu.py is pointless since commit 89aafcf2a7 ("trace: remove code that depends on setting vcpu"), remote it. Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 1 - scripts/tracetool/__init__.py | 8 + scripts/tracetool/vcpu.py | 59 --

[PATCH v11 0/2] S3 support

2024-06-06 Thread Jiqian Chen
Hi all, This is the v11 patch to support S3. v11 makes below changes: * patch#1 no changes. * patch#2 add "x-" prefix to pcie-pm-no-soft-reset and add old machine compability. Best regards, Jiqian Chen v10 makes below changes: * patch#1 change the description of commit message. * patch#2 no c

[PATCH v11 2/2] virtio-pci: implement No_Soft_Reset bit

2024-06-06 Thread Jiqian Chen
In current code, when guest does S3, virtio-gpu are reset due to the bit No_Soft_Reset is not set. After resetting, the display resources of virtio-gpu are destroyed, then the display can't come back and only show blank after resuming. Implement No_Soft_Reset bit of PCI_PM_CTRL register, then gues

[PATCH] target/s390x: Fix tracing header path in TCG mem_helper.c

2024-06-06 Thread Philippe Mathieu-Daudé
Commit c9274b6bf0 ("target/s390x: start moving TCG-only code to tcg/") moved mem_helper.c, but the trace-events file is still in the parent directory, so is the generated trace.h. Signed-off-by: Philippe Mathieu-Daudé --- Ideally we should only use trace events from current directory. --- target

[PATCH 0/5] trace: Remove and forbid newline characters in event format

2024-06-06 Thread Philippe Mathieu-Daudé
Trace events aren't designed to be multi-lines. Few format use the newline character: remove it and forbid further uses. Philippe Mathieu-Daudé (5): backends/tpm: Remove newline character in trace event hw/sh4: Remove newline character in trace events hw/usb: Remove newline character in trac

[PATCH 1/5] backends/tpm: Remove newline character in trace event

2024-06-06 Thread Philippe Mathieu-Daudé
Split the 'tpm_util_show_buffer' event in two to avoid using a newline character. Signed-off-by: Philippe Mathieu-Daudé --- backends/tpm/tpm_util.c | 5 +++-- backends/tpm/trace-events | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/backends/tpm/tpm_util.c b/backends/tp

[PATCH 4/5] hw/vfio: Remove newline character in trace events

2024-06-06 Thread Philippe Mathieu-Daudé
Trace events aren't designed to be multi-lines. Remove the newline characters. Signed-off-by: Philippe Mathieu-Daudé --- hw/vfio/trace-events | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vfio/trace-events b/hw/vfio/trace-events index 64161bf6f4..e16179b507 100644 --

[PATCH 5/5] tracetool: Forbid newline character in event format

2024-06-06 Thread Philippe Mathieu-Daudé
Events aren't designed to be multi-lines. Multiple events can be used instead. Prevent that format using multi-lines by forbidding the newline character. Signed-off-by: Philippe Mathieu-Daudé --- scripts/tracetool/__init__.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/tracetoo

[PATCH 3/5] hw/usb: Remove newline character in trace events

2024-06-06 Thread Philippe Mathieu-Daudé
Trace events aren't designed to be multi-lines. Remove the newline characters. Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/trace-events | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/usb/trace-events b/hw/usb/trace-events index fd7b90d70c..46732717a9 100644 ---

[PATCH 2/5] hw/sh4: Remove newline character in trace events

2024-06-06 Thread Philippe Mathieu-Daudé
Trace events aren't designed to be multi-lines. Remove the newline character which doesn't bring much value. Signed-off-by: Philippe Mathieu-Daudé --- hw/sh4/trace-events | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sh4/trace-events b/hw/sh4/trace-events index 4b61c

Re: [PATCH 0/3] virtio-gpu: Enable virglrenderer backend for rutabaga

2024-06-06 Thread Alex Bennée
Weifeng Liu writes: > Greetings, > > I'd like to introduce you my attempt to enable virglrenderer backend for > rutabaga empowered virtio-gpu device. I am aware that there have been > effort in supporting venus in virtio-gpu-virgl.c [1], but there is no > reason to prevent us from leveraging the

Re: [PATCH v5 25/65] i386/tdx: Add property sept-ve-disable for tdx-guest object

2024-06-06 Thread Daniel P . Berrangé
Copying Zhenzhong Duan as my point relates to the proposed libvirt TDX patches. On Thu, Feb 29, 2024 at 01:36:46AM -0500, Xiaoyao Li wrote: > Bit 28 of TD attribute, named SEPT_VE_DISABLE. When set to 1, it disables > EPT violation conversion to #VE on guest TD access of PENDING pages. > > Some

[PATCH RFC] hw/arm/virt: Avoid unexpected warning from Linux guest on host with Fujitsu CPUs

2024-06-06 Thread Zhenyu Zhang
Multiple warning messages and corresponding backtraces are observed when Linux guest is booted on the host with Fujitsu CPUs. One of them is shown as below. [0.032443] [ cut here ] [0.032446] uart-pl011 900.pl011: ARCH_DMA_MINALIGN smaller than CTR_EL0.CWG (128

Re: Unexpected error in rme_configure_one() at ../target/arm/kvm-rme.c:159

2024-06-06 Thread Jean-Philippe Brucker
On Thu, Jun 06, 2024 at 03:05:02PM +1000, Gavin Shan wrote: > > This commit moves the page tables from .rodata to .data. When linking > > IdMap.obj into ArmPlatformPrePeiCore.dll, the alignment of the .text > > section changes from 0x1000 to 0x800. This change comes from the linker > > script putti

Re: [PATCH] hw/net: cadence_gem: fix: type2_compare_x_word_0 error

2024-06-06 Thread Edgar E. Iglesias
On Thu, Jun 6, 2024 at 12:00 PM Andrew.Yuan wrote: > In the Cadence IP for Gigabit Ethernet MAC Part Number: IP7014 IP > Rev: R1p12 - Doc Rev: 1.3 User Guide, the specification for the > type2_compare_x_word_0 register is as follows: > The byte stored in bits [23:16] is compared a

Re: [PATCH] tracetool: Remove unused vcpu.py script

2024-06-06 Thread Daniel P . Berrangé
On Thu, Jun 06, 2024 at 12:26:31PM +0200, Philippe Mathieu-Daudé wrote: > vcpu.py is pointless since commit 89aafcf2a7 ("trace: > remove code that depends on setting vcpu"), remote it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > meson.build | 1 - > scripts/tracetool/__i

Re: [PATCH 1/5] backends/tpm: Remove newline character in trace event

2024-06-06 Thread Daniel P . Berrangé
On Thu, Jun 06, 2024 at 12:39:39PM +0200, Philippe Mathieu-Daudé wrote: > Split the 'tpm_util_show_buffer' event in two to avoid > using a newline character. > > Signed-off-by: Philippe Mathieu-Daudé > --- > backends/tpm/tpm_util.c | 5 +++-- > backends/tpm/trace-events | 3 ++- > 2 files chan

Re: [PATCH 2/5] hw/sh4: Remove newline character in trace events

2024-06-06 Thread Daniel P . Berrangé
On Thu, Jun 06, 2024 at 12:39:40PM +0200, Philippe Mathieu-Daudé wrote: > Trace events aren't designed to be multi-lines. Remove > the newline character which doesn't bring much value. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sh4/trace-events | 4 ++-- > 1 file changed, 2 insertions(

Re: [PATCH 3/5] hw/usb: Remove newline character in trace events

2024-06-06 Thread Daniel P . Berrangé
On Thu, Jun 06, 2024 at 12:39:41PM +0200, Philippe Mathieu-Daudé wrote: > Trace events aren't designed to be multi-lines. > Remove the newline characters. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/usb/trace-events | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed

Re: [PATCH 4/5] hw/vfio: Remove newline character in trace events

2024-06-06 Thread Daniel P . Berrangé
On Thu, Jun 06, 2024 at 12:39:42PM +0200, Philippe Mathieu-Daudé wrote: > Trace events aren't designed to be multi-lines. > Remove the newline characters. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/vfio/trace-events | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-

Re: [PATCH 5/5] tracetool: Forbid newline character in event format

2024-06-06 Thread Daniel P . Berrangé
On Thu, Jun 06, 2024 at 12:39:43PM +0200, Philippe Mathieu-Daudé wrote: > Events aren't designed to be multi-lines. Multiple events > can be used instead. Prevent that format using multi-lines > by forbidding the newline character. > > Signed-off-by: Philippe Mathieu-Daudé > --- > scripts/tracet

Re: [PATCH] spapr: Migrate ail-mode-3 spapr cap

2024-06-06 Thread Michael Tokarev
06.05.2024 14:56, Nicholas Piggin wrote: This cap did not add the migration code when it was introduced. This results in migration failure when changing the default using the command line. Cc: qemu-sta...@nongnu.org Fixes: ccc5a4c5e10 ("spapr: Add SPAPR_CAP_AIL_MODE_3 for AIL mode 3 support for

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-06-06 Thread Leon Romanovsky
On Wed, Jun 05, 2024 at 10:00:24AM +, Gonglei (Arei) wrote: > > > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Wednesday, June 5, 2024 3:57 PM > > To: Gonglei (Arei) > > Cc: qemu-devel@nongnu.org; pet...@redhat.com; yu.zh...@ionos.com; > > mgal

[PULL 02/12] docs/devel: update references to centos to non-versioned container

2024-06-06 Thread Alex Bennée
>From the website: "After May 31, 2024, CentOS Stream 8 will be archived and no further updates will be provided." We have updated a few bits but there are still references that need fixing. Rather than bump I've replaced them with references to the Debian image so we don't have to bump at the ne

[PULL 05/12] scripts/ci: remove CentOS bits from common build-environment

2024-06-06 Thread Alex Bennée
Although I've just removed the CentOS specific build-environment its probably a bit too confusing to have multiple distros mixed up in one place. Prior to moving clean-up what will be just for ubuntu. Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20240603175328.3823123-6

[PULL 08/12] .gitlab-ci.d/buildtest.yml: Use -fno-sanitize=function in the clang-system job

2024-06-06 Thread Alex Bennée
From: Thomas Huth The latest version of Clang (version 18 from Fedora 40) now reports bad function pointer casts as undefined behavior. Unfortunately, we are still doing this in quite a lot of places in the QEMU code and some of them are not easy to fix. So for the time being, temporarily switch

[PULL 04/12] tests/vm: remove plain centos image

2024-06-06 Thread Alex Bennée
This isn't really used and we have lighter weight docker containers for testing this stuff directly. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20240603175328.3823123-5-alex.ben...@linaro.org> diff --git a/tests/vm/Makefile.include b/tests/v

[PULL 06/12] docs/ci: clean-up references for consistency

2024-06-06 Thread Alex Bennée
Document we have split up build-environment by distro and update the references that exist in the code base to be correct. Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20240603175328.3823123-7-alex.ben...@linaro.org> diff --git a/docs/devel/ci-runners.rst.inc b/docs/de

[PULL 09/12] tests/lcitool: Bump to latest libvirt-ci and update Fedora and Alpine version

2024-06-06 Thread Alex Bennée
From: Thomas Huth Update to the latest version of lcitool. It dropped support for Fedora 38 and Alpine 3.18, so we have to update these to newer versions here, too. Python 3.12 dropped the "imp" module which we still need for running Avocado. Fortunately Fedora 40 still ships with a work-around

[PULL 01/12] ci: remove centos-steam-8 customer runner

2024-06-06 Thread Alex Bennée
This broke since eef0bae3a7 (migration: Remove block migration) but even after that was addressed it still fails to complete. As it will shortly be EOL lets to remove the runner definition and the related ansible setup bits. We still have centos9 docker images build and test. Reviewed-by: Richard

[PULL 00/12] testing cleanups (ci, vm, lcitool, ansible)

2024-06-06 Thread Alex Bennée
The following changes since commit db2feb2df8d19592c9859efb3f682404e0052957: Merge tag 'pull-misc-20240605' of https://gitlab.com/rth7680/qemu into staging (2024-06-05 14:17:01 -0700) are available in the Git repository at: https://gitlab.com/stsquad/qemu.git tags/pull-maintainer-june24-060

[PULL 12/12] scripts/ci: drive ubuntu/build-environment.yml from lcitool

2024-06-06 Thread Alex Bennée
Now lcitool can write the package list for us we no longer need to duplicate the information directly in build-environment. Signed-off-by: Alex Bennée Message-Id: <20240603175328.3823123-13-alex.ben...@linaro.org> diff --git a/scripts/ci/setup/ubuntu/build-environment.yml b/scripts/ci/setup/ubu

[PULL 11/12] tests/lcitool: generate package lists for ansible

2024-06-06 Thread Alex Bennée
With the new ability to output YAML we can build the package list for our ansible setup scripts. We will integrate them in the next commit. Signed-off-by: Alex Bennée Message-Id: <20240603175328.3823123-12-alex.ben...@linaro.org> diff --git a/scripts/ci/setup/ubuntu/ubuntu-2204-aarch64.yaml b/s

[PULL 10/12] tests/lcitool: Install mingw-w64-tools for the Windows cross-builds

2024-06-06 Thread Alex Bennée
From: Thomas Huth Beside g++ we also need the mingw-w64-tools for properly building the code in qga/vss-win32/ , so let's install that package now, too. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Message-Id: <20240601070543.37786-5-th...@red

[PULL 03/12] tests/vm: update centos.aarch64 image to 9

2024-06-06 Thread Alex Bennée
As Centos Stream 8 goes out of support we need to update. To do this powertools is replaced by crb and we don't over specify the python3 we want. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20240603175328.3823123-4-alex.ben...@linaro.org> dif

[PULL 07/12] tests/lcitool: Delete obsolete centos-stream-8.yml file

2024-06-06 Thread Alex Bennée
From: Thomas Huth We've missed to delete this file when removing support for CentOS 8. Since the current upstream version of the lcitool removed support for CentOS 8 now, too, we have to remove the file before updating. Signed-off-by: Thomas Huth Reviewed-by: Daniel P. Berrangé Message-Id: <20

Re: [PATCH v2 1/3] hw/dma: Enhance error handling in loading description

2024-06-06 Thread Edgar E. Iglesias
On Tue, Jun 4, 2024 at 9:10 AM Fea.Wang wrote: > Loading a description from memory may cause a bus-error. In this > case, the DMA should stop working, set the error flag, and return > the failure value. > > When calling the loading a description function, it should be noticed > that the function

Re: [PATCH RFC] hw/arm/virt: Avoid unexpected warning from Linux guest on host with Fujitsu CPUs

2024-06-06 Thread Peter Maydell
On Thu, 6 Jun 2024 at 11:48, Zhenyu Zhang wrote: > > Multiple warning messages and corresponding backtraces are observed when Linux > guest is booted on the host with Fujitsu CPUs. One of them is shown as below. > > [0.032443] [ cut here ] > [0.032446] uart-pl011 90

Re: [PATCH] target/s390x: Fix tracing header path in TCG mem_helper.c

2024-06-06 Thread Ilya Leoshkevich
On Thu, 2024-06-06 at 12:30 +0200, Philippe Mathieu-Daudé wrote: > Commit c9274b6bf0 ("target/s390x: start moving TCG-only code > to tcg/") moved mem_helper.c, but the trace-events file is > still in the parent directory, so is the generated trace.h. > > Signed-off-by: Philippe Mathieu-Daudé > --

Re: [PATCH] hw/net: cadence_gem: fix: type2_compare_x_word_0 error

2024-06-06 Thread Peter Maydell
On Thu, 6 Jun 2024 at 12:04, Edgar E. Iglesias wrote: > > On Thu, Jun 6, 2024 at 12:00 PM Andrew.Yuan > wrote: >> >> In the Cadence IP for Gigabit Ethernet MAC Part Number: IP7014 IP >> Rev: R1p12 - Doc Rev: 1.3 User Guide, the specification for the >> type2_compare_x_word_0 register i

Re: [PATCH] target/s390x: Fix tracing header path in TCG mem_helper.c

2024-06-06 Thread Peter Maydell
On Thu, 6 Jun 2024 at 11:30, Philippe Mathieu-Daudé wrote: > > Commit c9274b6bf0 ("target/s390x: start moving TCG-only code > to tcg/") moved mem_helper.c, but the trace-events file is > still in the parent directory, so is the generated trace.h. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

[PATCH v5 5/5] target/ppc: Fix regression due to Power10 and Power11 having same PCR

2024-06-06 Thread Aditya Gupta
Power11 has the same PCR (Processor Compatibility Register) value, as Power10. Due to this, QEMU considers Power11 as a valid compat-mode for Power10, ie. earlier it was possible to run QEMU with '-M pseries,max-compat-mode=power11 --cpu power10' Same PCR also introduced a regression where `-M p

[PATCH v5 1/5] target/ppc: reduce code duplication across Power9/10 init code

2024-06-06 Thread Aditya Gupta
From: Harsh Prateek Bora Power9/10 initialization code consists of a lot of logical OR of various flag bits as supported by respective Power platform during its initialization, most of which is duplicated and only selected bits are added or removed as needed with each new platform support being a

[PATCH v5 3/5] ppc/pseries: Add Power11 cpu type

2024-06-06 Thread Aditya Gupta
Add sPAPR CPU Core definition for Power11 Cc: David Gibson (reviewer:sPAPR (pseries)) Cc: Harsh Prateek Bora (reviewer:sPAPR (pseries)) Cc: Cédric Le Goater Cc: Daniel Henrique Barboza Cc: Frédéric Barrat Cc: Harsh Prateek Bora Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas P

[PATCH v5 0/5] Power11 support for QEMU [PSeries]

2024-06-06 Thread Aditya Gupta
Overview Split "Power11 support for QEMU" into 2 patch series: pseries & powernv. This patch series is for pseries support for Power11. As Power11 core is same as Power10, hence much of the code has been reused from Power10. Power11 was added in Linux in: commit c2ed087ed35c ("po

[PATCH v5 4/5] target/ppc: Introduce 'PowerPCCPUClass::logical_pvr'

2024-06-06 Thread Aditya Gupta
Introduce 'PnvChipClass::logical_pvr' to know corresponding logical PVR of a PowerPC CPU. This helps to have a one-to-one mapping between PVR and logical PVR for a CPU, and used in a later commit to handle cases where PCR of two generations of Power chip is same, which causes regressions with compa

[PATCH v5 2/5] target/ppc: Add Power11 DD2.0 processor

2024-06-06 Thread Aditya Gupta
Add CPU target code to add support for new Power11 Processor. Power11 core is same as Power10, hence reuse functions defined for Power10. Cc: Cédric Le Goater Cc: Daniel Henrique Barboza Cc: Frédéric Barrat Cc: Harsh Prateek Bora Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas

Re: [PATCH v5 0/5] Power11 support for QEMU [PSeries]

2024-06-06 Thread Aditya Gupta
Hello Nick & Cedric, Based on your comments on considering the pseries for 9.1, and having to wait for skiboot parts for powernv, I have split the patch series into pseries and powernv. There might be little delay in posting the powernv part, where I am still looking into having power11's in

[PATCH v5 00/10] Support persistent reservation operations

2024-06-06 Thread Changqi Lu
Hi, patchv5 has been modified. Sincerely hope that everyone can help review the code and provide some suggestions. v4->v5: - Fixed a memory leak bug at hw/nvme/ctrl.c. v3->v4: - At the nvme layer, the two patches of enabling the ONCS function and enabling rescap are combined into one. - At t

[PATCH v5 07/10] hw/nvme: add helper functions for converting reservation types

2024-06-06 Thread Changqi Lu
This commit introduces two helper functions that facilitate the conversion between the reservation types used in the NVME protocol and those used in the block layer. Reviewed-by: Stefan Hajnoczi Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi --- hw/nvme/nvme.h | 80 +++

[PATCH v5 03/10] scsi/constant: add persistent reservation in/out protocol constants

2024-06-06 Thread Changqi Lu
Add constants for the persistent reservation in/out protocol in the scsi/constant module. The constants include the persistent reservation command, type, and scope values defined in sections 6.13 and 6.14 of the SCSI Primary Commands-4 (SPC-4) specification. Signed-off-by: Changqi Lu Signed-off-b

  1   2   3   >