Re: [RFC PATCH 09/10] ppc/pnv: Implement POWER10 PC xscom registers for direct controls

2024-05-29 Thread Cédric Le Goater
On 5/26/24 14:26, Nicholas Piggin wrote: The PC unit in the processor core contains xscom registers that provide low level status and control of the CPU. This implements "direct controls" sufficient for OPAL (skiboot) firmware use, which is to stop threads and send them non-maskable IPIs in the

Re: [RFC PATCH 10/10] ppc/pnv: Add an LPAR per core machine option

2024-05-29 Thread Cédric Le Goater
On 5/26/24 14:26, Nicholas Piggin wrote: Recent POWER CPUs can operate in "LPAR per core" or "LPAR per thread" modes. In per-core mode, some SPRs and IPI doorbells are shared between threads in a core. In per-thread mode, supervisor and user state is not shared between threads. OpenPOWER systems

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-29 Thread Jinpu Wang
On Wed, May 29, 2024 at 8:08 AM Greg Sword wrote: > > On Wed, May 29, 2024 at 12:33 PM Jinpu Wang wrote: > > > > On Wed, May 29, 2024 at 4:43 AM Gonglei (Arei) > > wrote: > > > > > > Hi, > > > > > > > -Original Message- > > > > From: Peter Xu [mailto:pet...@redhat.com] > > > > Sent: Tue

Re: [PATCH] Issue #2294 | Machine microvm doesn't run under Xen accel for x86_64

2024-05-29 Thread Paolo Bonzini
On 5/28/24 12:23, Will Gyda wrote: Issue #2294: Machine microvm doesn't run under Xen accel for qemu-system-x86_64. Solution: microvm is now not build if only Xen is available. This does not fix the issue that microvm does not start with a Xen accelerator. I think it would be better to try an

Re: [PATCH] tests/libqos: Add loongarch virt machine node

2024-05-29 Thread Thomas Huth
On 28/05/2024 10.20, Bibo Mao wrote: Add loongarch virt machine to the graph. It is a modified copy of the existing riscv virtmachine in riscv-virt-machine.c It contains a generic-pcihost controller, and an extra function loongarch_config_qpci_bus() to configure GPEX pci host controller informat

Re: [PATCH] tests/qtest: Add numa test for loongarch system

2024-05-29 Thread Thomas Huth
On 28/05/2024 10.21, Bibo Mao wrote: Add numa test case for loongarch system, it passes to run with command "make check-qtest". Signed-off-by: Bibo Mao --- tests/qtest/meson.build | 2 +- tests/qtest/numa-test.c | 53 + 2 files changed, 54 insertions

Re: [PATCH v2 1/4] MAINTAINERS: drop audio maintainership

2024-05-29 Thread Volker Rümelin
Am 28.05.24 um 12:02 schrieb Gerd Hoffmann: > Hi, > >>> virtio-snd >>> -M: Gerd Hoffmann >>> -R: Manos Pitsidianakis >>> +M: Manos Pitsidianakis >>> +R: Matias Ezequiel Vara Larsen >>> S: Supported >>> F: hw/audio/virtio-snd.c >>> F: hw/audio/virtio-snd-pci.c >> While extra reviewers are

Re: [PATCH v4 0/4] Fix sanitizer errors with clang 18.1.1

2024-05-29 Thread Thomas Huth
On 24/05/2024 07.35, Akihiko Odaki wrote: I upgraded my Fedora Asahi Remix from 39 to 40 and found new sanitizer errors with clang it ships so here are fixes. The patch "meson: Drop the .fa library prefix" may have a broad impact to the build system so please tell me if you have a concern with i

Re: [PATCH] fuzz: disable leak-detection for oss-fuzz builds

2024-05-29 Thread Thomas Huth
On 27/05/2024 16.59, Alexander Bulekov wrote: When we are building for OSS-Fuzz, we want to ensure that the fuzzer targets are actually created, regardless of leaks. Leaks will be detected by the subsequent tests of the individual fuzz-targets. Signed-off-by: Alexander Bulekov --- scripts/oss

Re: [PATCH] linux-user: Add ioctl for BLKBSZSET

2024-05-29 Thread Michael Vogt
Friendly ping I tested the patch as part of cross architecture build (using qemu-user) with bootc-image-builder in https://github.com/osbuild/bootc-image-builder/pull/342 (not sure that is relevant, but I wanted to mention that it is working for my test-case). On Tue, Apr 23, 2024 at 5:25 PM Mich

Re: [PATCH] tests/libqos: Add loongarch virt machine node

2024-05-29 Thread maobibo
Thomas, Thanks for reviewing the patch. On 2024/5/29 下午3:10, Thomas Huth wrote: On 28/05/2024 10.20, Bibo Mao wrote: Add loongarch virt machine to the graph. It is a modified copy of the existing riscv virtmachine in riscv-virt-machine.c It contains a generic-pcihost controller, and an extra

Re: [RFC v2 1/2] target/loongarch: Add loongson binary translation feature

2024-05-29 Thread maobibo
On 2024/5/28 下午8:56, gaosong wrote: 在 2024/5/28 上午9:07, maobibo 写道: Hi Philippe, Thanks for reviewing my patch. I reply inline. On 2024/5/27 下午6:37, Philippe Mathieu-Daudé wrote: Hi Bibo, On 27/5/24 10:35, Bibo Mao wrote: Loongson Binary Translation (LBT) is used to accelerate binary tra

Re: [PATCH] Issue #2294 | Machine microvm doesn't run under Xen accel for x86_64

2024-05-29 Thread Vilhelm Gyda
@philmd commented on gitlab: Discussed with @epilys on IRC, only Xen machines (xenpv/xenfv) configure Xen so can run under it. But if we want to make it work under Xen. Any ideas how to move in that direction? On Wed, May 29, 2024 at 12:37 PM Paolo Bonzini wrote: > > On 5/28/24 12:23, Will Gyda

RE: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-29 Thread Gonglei (Arei)
> -Original Message- > From: Greg Sword [mailto:gregswo...@gmail.com] > Sent: Wednesday, May 29, 2024 2:06 PM > To: Jinpu Wang > Subject: Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling > > On Wed, May 29, 2024 at 12:33 PM Jinpu Wang > wrote: > > > > On Wed, May 29,

Re: [PATCH 1/1] prealloc: add truncate mode for prealloc filter

2024-05-29 Thread Denis V. Lunev
On 5/29/24 04:33, Wang, Lei wrote: On 5/1/2024 1:05, Denis V. Lunev via wrote: Preallocate filter allows to implement really interesting setups. Assume that we have * shared block device, f.e. iSCSI LUN, implemented with some HW device * clustered LVM on top of it * QCOW2 image stored inside LV

Re: [PATCH v4 14/16] aspeed/soc: fix incorrect dram size for AST2700

2024-05-29 Thread Cédric Le Goater
Hello Jamin On 5/27/24 10:02, Jamin Lin wrote: AST2700 dram size calculation is not back compatible AST2600. According to the DDR capacity hardware behavior, if users write the data to address which is beyond the ram size, it would write the data to address 0. For example: a. sdram base address

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-29 Thread Jinpu Wang
Hi Gonglei, On Wed, May 29, 2024 at 10:31 AM Gonglei (Arei) wrote: > > > > > -Original Message- > > From: Greg Sword [mailto:gregswo...@gmail.com] > > Sent: Wednesday, May 29, 2024 2:06 PM > > To: Jinpu Wang > > Subject: Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

Re: [RFC 0/6] scripts: Rewrite simpletrace printer in Rust

2024-05-29 Thread Mads Ynddal
>> Maybe later, Rust-simpletrace and python-simpletrace can differ, e.g. >> the former goes for performance and the latter for scalability. > > Rewriting an existing, maintained component without buy-in from the > maintainers is risky. Mads is the maintainer of simpletrace.py and I am > the over

RE: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-29 Thread Gonglei (Arei)
> -Original Message- > From: Jinpu Wang [mailto:jinpu.w...@ionos.com] > Sent: Wednesday, May 29, 2024 5:18 PM > To: Gonglei (Arei) > Cc: Greg Sword ; Peter Xu ; > Yu Zhang ; Michael Galaxy ; > Elmar Gerdes ; zhengchuan > ; Daniel P. Berrangé ; > Markus Armbruster ; Zhijian Li (Fujitsu) >

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-29 Thread Jinpu Wang
On Wed, May 29, 2024 at 11:35 AM Gonglei (Arei) wrote: > > > > -Original Message- > > From: Jinpu Wang [mailto:jinpu.w...@ionos.com] > > Sent: Wednesday, May 29, 2024 5:18 PM > > To: Gonglei (Arei) > > Cc: Greg Sword ; Peter Xu ; > > Yu Zhang ; Michael Galaxy ; > > Elmar Gerdes ; zhengch

[PATCH 0/7] Live migration acceleration with UADK

2024-05-29 Thread Shameer Kolothum via
Hi, This series adds support for UADK library based hardware acceleration for live migration. UADK[0] is a general-purpose user space accelerator framework that uses shared virtual addressing (SVA) to provide a unified programming interface for hardware acceleration of cryptographic and compressio

Re: [PATCH v7 1/9] vfio: Add Error** argument to .set_dirty_page_tracking() handler

2024-05-29 Thread Cédric Le Goater
On 5/29/24 08:26, Markus Armbruster wrote: I had a look at this before I realized it's already in. I'm sending this out not to demand any change, but only to point out an issue to be avoided in future work. Cédric Le Goater writes: We will use the Error object to improve error reporting in t

[PATCH 2/7] configure: Add uadk option

2024-05-29 Thread Shameer Kolothum via
Add --enable-uadk and --disable-uadk options to enable and disable UADK compression accelerator. This is for using UADK based hardware accelerators for live migration. Signed-off-by: Shameer Kolothum --- meson.build | 14 ++ meson_options.txt | 2 ++ sc

[PATCH 7/7] tests/migration-test: add uadk compression test

2024-05-29 Thread Shameer Kolothum via
Signed-off-by: Shameer Kolothum --- tests/qtest/migration-test.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 0f75ed7c49..4104b41f66 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migrat

[PATCH 5/7] migration/multifd: Add UADK based compression and decompression

2024-05-29 Thread Shameer Kolothum via
Uses UADK wd_do_comp_sync() API to (de)compress a normal page using hardware accelerator. Signed-off-by: Shameer Kolothum --- migration/multifd-uadk.c | 132 ++- 1 file changed, 130 insertions(+), 2 deletions(-) diff --git a/migration/multifd-uadk.c b/migrati

[PATCH 3/7] migration/multifd: add uadk compression framework

2024-05-29 Thread Shameer Kolothum via
Adds the skeleton to support uadk compression method. Complete functionality will be added in subsequent patches. Signed-off-by: Shameer Kolothum --- hw/core/qdev-properties-system.c | 2 +- migration/meson.build| 1 + migration/multifd-uadk.c | 20 mig

[PATCH 1/7] docs/migration: add uadk compression feature

2024-05-29 Thread Shameer Kolothum via
Document UADK(User Space Accelerator Development Kit) library details and how to use that for migration. Signed-off-by: Shameer Kolothum --- docs/devel/migration/uadk-compression.rst | 144 ++ 1 file changed, 144 insertions(+) create mode 100644 docs/devel/migration/uadk-com

[PATCH 4/7] migration/multifd: Add UADK initialization

2024-05-29 Thread Shameer Kolothum via
Initialize UADK session and allocate buffers required. The actual compression/decompression will only be done in a subsequent patch. Signed-off-by: Shameer Kolothum --- migration/multifd-uadk.c | 207 ++- 1 file changed, 206 insertions(+), 1 deletion(-) diff

[PATCH 6/7] migration/multifd: Switch to no compression when no hardware support

2024-05-29 Thread Shameer Kolothum via
Send raw packets over if UADK hardware support is not available. This is to satisfy  Qemu qtest CI which may run on platforms that don't have UADK hardware support. Subsequent patch will add support for uadk migration qtest. Signed-off-by: Shameer Kolothum --- migration/multifd-uadk.c | 89 +

RE: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-29 Thread Gonglei (Arei)
Hi, > -Original Message- > > > > https://lore.kernel.org/qemu-devel/CAMGffEn-DKpMZ4tA71MJYdyemg0Zda > > > > > > 15 > > > > > > > > wvaqk81vxtkzx-l...@mail.gmail.com/ > > > > > > > > > > > > > > > > Appreciate a lot for everyone helping on the testings. > > > > > > > > > > > > > > > > > Inf

Re: [PATCH] Issue #2294 | Machine microvm doesn't run under Xen accel for x86_64

2024-05-29 Thread Manos Pitsidianakis
On Wed, 29 May 2024 at 11:25, Vilhelm Gyda wrote: > > @philmd commented on gitlab: Discussed with @epilys on IRC, only Xen > machines (xenpv/xenfv) configure Xen so can run under it. > > But if we want to make it work under Xen. Any ideas how to move in > that direction? We'd have to specify what

Re: block snapshot issue with RBD

2024-05-29 Thread Fiona Ebner
Hi, Am 28.05.24 um 20:19 schrieb Jin Cao: > Hi Ilya > > On 5/28/24 11:13 AM, Ilya Dryomov wrote: >> On Mon, May 27, 2024 at 9:06 PM Jin Cao wrote: >>> >>> Supplementary info: VM is paused after "migrate" command. After being >>> resumed with "cont", snapshot_delete_blkdev_internal works again, w

Re: [PATCH 12/14] target/s390x: Simplify per_ifetch, per_check_exception

2024-05-29 Thread Thomas Huth
On 02/05/2024 07.44, Richard Henderson wrote: Set per_address and ilen in per_ifetch; this is valid for all PER exceptions and will last until the end of the instruction. Therefore we don't need to give the same data to per_check_exception. Signed-off-by: Richard Henderson # Conflicts: #

Re: [PATCH] Issue #2294 | Machine microvm doesn't run under Xen accel for x86_64

2024-05-29 Thread Manos Pitsidianakis
On Tue, 28 May 2024 13:23, Will Gyda wrote: Issue #2294: Machine microvm doesn't run under Xen accel for qemu-system-x86_64. Solution: microvm is now not build if only Xen is available. Signed-off-by: Will Gyda I suggest rewording the commit title to something like "i386: remove microvm

Re: tests/avocado: Add LoongArch machine start test

2024-05-29 Thread Thomas Huth
On 15/05/2023 13.19, Song Gao wrote: Add a new test in tests/avocado to check LoongArch virt machine start. Reviewed-by: Thomas Huth Signed-off-by: Song Gao Reviewed-by: Cédric Le Goater Message-Id: <20230513012744.1885728-1-gaos...@loongson.cn> --- MAINTAINERS| 1 +

Re: [PATCH 1/2] Revert "monitor: use aio_co_reschedule_self()"

2024-05-29 Thread Fiona Ebner
CC-ing stable since 1f25c172f83704e350c0829438d832384084a74d is in 9.0.0 Am 06.05.24 um 21:06 schrieb Stefan Hajnoczi: > Commit 1f25c172f837 ("monitor: use aio_co_reschedule_self()") was a code > cleanup that uses aio_co_reschedule_self() instead of open coding > coroutine rescheduling. > > Bug R

Re: [RFC PATCH 08/10] ppc/pnv: Invert the design for big-core machine modelling

2024-05-29 Thread Harsh Prateek Bora
Hi Nick, On 5/26/24 17:56, Nicholas Piggin wrote: POWER9 and POWER10 machines come in two variants, "big-core" and "small-core". Big core machines are SMT8 from the software point of view, but in the low level platform topology ("xscom registers and pervasive addressing"), these look more like

Re: [PULL 6/9] virtio-gpu: fix v2 migration

2024-05-29 Thread Fiona Ebner
CC-ing stable, because this already is an issue in 9.0.0 Am 23.05.24 um 00:20 schrieb Fabiano Rosas: > From: Marc-André Lureau > > Commit dfcf74fa ("virtio-gpu: fix scanout migration post-load") broke > forward/backward version migration. Versioning of nested VMSD structures > is not straightfor

[PULL 05/22] target/s390x: Disable conditional branch-to-next for PER

2024-05-29 Thread Thomas Huth
From: Richard Henderson For PER, we require a conditional call to helper_per_branch for the conditional branch. Fold the remaining optimization into a call to helper_goto_direct, which will take care of the remaining gbea adjustment. Reviewed-by: Ilya Leoshkevich Signed-off-by: Richard Henders

[PULL 03/22] target/s390x: Update CR9 bits

2024-05-29 Thread Thomas Huth
From: Richard Henderson Update from the PoO 14th edition. Signed-off-by: Richard Henderson Reviewed-by: Thomas Huth Reviewed-by: Ilya Leoshkevich Message-ID: <20240502054417.234340-4-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/cpu.h | 18 +++

[PULL 09/22] target/s390x: Raise exception from helper_per_branch

2024-05-29 Thread Thomas Huth
From: Richard Henderson Drop from argument, since gbea has always been updated with this address. Add ilen argument for setting int_pgm_ilen. Use update_cc_op before calling per_branch. By raising the exception here, we need not call per_check_exception later, which means we can clean up the no

[PULL 13/22] target/s390x: Adjust check of noreturn in translate_one

2024-05-29 Thread Thomas Huth
From: Richard Henderson If help_op is not set, ret == DISAS_NEXT. Shift the test up from surrounding help_wout, help_cout to skipping to out, as we do elsewhere in the function. Signed-off-by: Richard Henderson Message-ID: <20240502054417.234340-14-richard.hender...@linaro.org> Signed-off-by: T

[PULL 07/22] target/s390x: Simplify help_branch

2024-05-29 Thread Thomas Huth
From: Richard Henderson Always use a tcg branch, instead of movcond. The movcond was not a bad idea before PER was added, but since then we have either 2 or 3 actions to perform on each leg of the branch, and multiple movcond is inefficient. Reorder the taken branch to be fallthrough of the tcg

[PULL 10/22] target/s390x: Raise exception from per_store_real

2024-05-29 Thread Thomas Huth
From: Richard Henderson At this point the instruction is complete and there's nothing left to do but raise the exception. With this change we need not make two helper calls for this event. Signed-off-by: Richard Henderson Message-ID: <20240502054417.234340-11-richard.hender...@linaro.org> Sign

[PULL 04/22] target/s390x: Record separate PER bits in TB flags

2024-05-29 Thread Thomas Huth
From: Richard Henderson Record successful-branching, instruction-fetching, and store-using-real-address. The other PER bits are not used during translation. Having checked these at translation time, we can remove runtime tests from the helpers. Signed-off-by: Richard Henderson Reviewed-by: Il

[PULL 02/22] target/s390x: Move cpu_get_tb_cpu_state out of line

2024-05-29 Thread Thomas Huth
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Thomas Huth Reviewed-by: Ilya Leoshkevich Message-ID: <20240502054417.234340-3-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/cpu.h | 23 ++- target/s390x/cpu.c | 22 +

[PULL 15/22] fuzz: specify audiodev for usb-audio

2024-05-29 Thread Thomas Huth
From: Alexander Bulekov Fixes test-failure on Fedora 40 CI. Reported-by: Thomas Huth Signed-off-by: Alexander Bulekov Reviewed-by: Thomas Huth Message-ID: <20240527040711.311865-1-alx...@bu.edu> Signed-off-by: Thomas Huth --- tests/qtest/fuzz/generic_fuzz_configs.h | 3 ++- 1 file changed,

[PULL 14/22] tests/tcg/s390x: Add per.S

2024-05-29 Thread Thomas Huth
From: Richard Henderson Add a small test to avoid regressions. Signed-off-by: Richard Henderson Acked-by: Ilya Leoshkevich Tested-by: Ilya Leoshkevich Message-ID: <20240502054417.234340-15-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- tests/tcg/s390x/Makefile.softmmu-target |

[PULL 17/22] hw/s390x: Remove unused macro VMSTATE_ADAPTER_ROUTES

2024-05-29 Thread Thomas Huth
It's not used anywhere, so let's simply remove it. Message-ID: <20240527121351.211266-1-th...@redhat.com> Reviewed-by: Cédric Le Goater Reviewed-by: Eric Farman Signed-off-by: Thomas Huth --- include/hw/s390x/s390_flic.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/hw/s390x/s3

[PULL 12/22] target/s390x: Simplify per_ifetch, per_check_exception

2024-05-29 Thread Thomas Huth
From: Richard Henderson Set per_address and ilen in per_ifetch; this is valid for all PER exceptions and will last until the end of the instruction. Therefore we don't need to give the same data to per_check_exception. Signed-off-by: Richard Henderson Message-ID: <20240502054417.234340-13-rich

[PULL 21/22] lockable: Do not cast function pointers

2024-05-29 Thread Thomas Huth
From: Akihiko Odaki -fsanitize=undefined complains if function pointers are casted. It also prevents enabling the strict mode of CFI which is currently disabled with -fsanitize-cfi-icall-generalize-pointers. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2345 Signed-off-by: Akihiko Odak

[PULL 06/22] target/s390x: Introduce help_goto_indirect

2024-05-29 Thread Thomas Huth
From: Richard Henderson Add a small helper to handle unconditional indirect jumps. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Ilya Leoshkevich Signed-off-by: Richard Henderson Message-ID: <20240502054417.234340-7-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390

[PULL 08/22] target/s390x: Split per_breaking_event from per_branch_*

2024-05-29 Thread Thomas Huth
From: Richard Henderson The breaking-event-address register is updated regardless of PER being enabled. Reviewed-by: Ilya Leoshkevich Signed-off-by: Richard Henderson Message-ID: <20240502054417.234340-9-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/tcg/translate.

[PULL 11/22] target/s390x: Fix helper_per_ifetch flags

2024-05-29 Thread Thomas Huth
From: Richard Henderson CPU state is read on the exception path. Fixes: 83bb161299c ("target-s390x: PER instruction-fetch nullification event support") Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-ID: <20240502054417.234340-12-richard.hender...@linaro.org> Signed-of

[PULL 16/22] fuzz: disable leak-detection for oss-fuzz builds

2024-05-29 Thread Thomas Huth
From: Alexander Bulekov When we are building for OSS-Fuzz, we want to ensure that the fuzzer targets are actually created, regardless of leaks. Leaks will be detected by the subsequent tests of the individual fuzz-targets. Signed-off-by: Alexander Bulekov Reviewed-by: Philippe Mathieu-Daudé Me

[PULL 18/22] scripts/update-linux-headers.sh: Remove temporary directory inbetween

2024-05-29 Thread Thomas Huth
We are reusing the same temporary directory for installing the headers of all targets, so there could be stale files here when switching from one target to another. Make sure to delete the folder before installing a new set of target headers into it. Message-ID: <20240527060243.12647-1-th...@redha

[PULL 01/22] target/s390x: Do not use unwind for per_check_exception

2024-05-29 Thread Thomas Huth
From: Richard Henderson Using exception unwind via tcg_s390_program_interrupt, we discard the current value of psw.addr, which discards the result of a branch. Pass in the address of the next instruction, which may not be sequential. Pass in ilen, which we would have gotten from unwind and is p

[PULL 22/22] qapi: Do not cast function pointers

2024-05-29 Thread Thomas Huth
From: Akihiko Odaki Using -fsanitize=undefined with Clang v18 causes an error if function pointers are casted: qapi/qapi-clone-visitor.c:188:5: runtime error: call to function visit_type_SocketAddress through pointer to incorrect function type 'bool (*)(struct Visitor *, const char *, void **

[PULL 19/22] scripts/update-linux-headers.sh: Fix the path of setup_data.h

2024-05-29 Thread Thomas Huth
When running the update-linx-headers.sh script, it currently fails with: scripts/update-linux-headers.sh: line 73: .../qemu/standard-headers/asm-x86/setup_data.h: No such file or directory The "include" folder is obviously missing here - no clue how this could have worked before? Fixes: 66210a1

[PULL 20/22] qemu-keymap: Make references to allocations static

2024-05-29 Thread Thomas Huth
From: Akihiko Odaki LeakSanitizer complains about allocations whose references are held only by automatic variables. It is possible to free them to suppress the complaints, but it is a chore to make sure they are freed in all exit paths so make them static instead. Signed-off-by: Akihiko Odaki

Re: [PATCH] Issue #2294 | Machine microvm doesn't run under Xen accel for x86_64

2024-05-29 Thread Vilhelm Gyda
On Wed, May 29, 2024 at 3:58 PM Manos Pitsidianakis wrote: > What about TCG? Will it be available if we only build with tcg? I will try doing this, and report back, and will make the suggested changes, and re-submit. On Wed, May 29, 2024 at 3:58 PM Manos Pitsidianakis wrote: > > On Tue, 28 May

[PULL 00/22] s390x, build-oss-fuzz and Clang -fsanitize=undefined fixes

2024-05-29 Thread Thomas Huth
Hi Richard! The following changes since commit 79d7475f39f1b0f05fcb159f5cdcbf162340dc7e: Merge tag 'pull-block-jobs-2024-04-29-v2' of https://gitlab.com/vsementsov/qemu into staging (2024-05-28 11:28:34 -0700) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/

Re: block snapshot issue with RBD

2024-05-29 Thread Kevin Wolf
Am 29.05.2024 um 12:14 hat Fiona Ebner geschrieben: > I bisected this issue to d3007d348a ("block: Fix crash when loading > snapshot on inactive node"). > > > diff --git a/block/snapshot.c b/block/snapshot.c > > index ec8cf4810b..c4d40e80dd 100644 > > --- a/block/snapshot.c > > +++ b/block/snapsho

Re: [PATCH] tests/tcg/s390x: Allow specifying extra QEMU options on the command line

2024-05-29 Thread Thomas Huth
On 22/05/2024 20.38, Ilya Leoshkevich wrote: The use case for this is `make check-tcg EXTFLAGS="-accel kvm"`, which allows validating the system TCG testcases on real hardware. EXTFLAGS name is borrowed from tests/tcg/xtensa/Makefile.softmmu-target. While at it, use += instead of = in order to be

Re: [PATCH 3/7] migration/multifd: add uadk compression framework

2024-05-29 Thread Markus Armbruster
Please cc: maintainers on patches. You can use scripts/get_maintainer.pl to find them. Shameer Kolothum via writes: > Adds the skeleton to support uadk compression method. > Complete functionality will be added in subsequent patches. > > Signed-off-by: Shameer Kolothum [...] > diff --git a/q

Re: [PATCH v7 3/8] xen: Add xen_mr_is_memory()

2024-05-29 Thread Edgar E. Iglesias
On Mon, May 27, 2024 at 6:25 PM Philippe Mathieu-Daudé wrote: > Hi Edgar, > > On 24/5/24 12:51, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Add xen_mr_is_memory() to abstract away tests for the > > xen_memory MR. > > > > No functional changes. > > > > Signed-off-by: Edgar E. I

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-29 Thread Haris Iqbal
Hello, I am part of the storage kernel team which develops and maintains the RDMA block storage in IONOS. We work closely with Jinpu/Yu, and currently I am supporting Jinpu with this Qemu RDMA work. On Wed, May 29, 2024 at 11:49 AM Gonglei (Arei) via wrote: > > Hi, > > > -Original Message---

Re: [PATCH v4] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-05-29 Thread Markus Armbruster
Daniil Tatianin writes: > This can be used to force-synchronize the time in guest after a long > stop-cont pause, which can be useful for serverless-type workload. > > Also add a comment to highlight the fact that this (and one other QMP > command) only works for the MC146818 RTC controller. > >

Re: [PATCH 5/5] contrib/plugins: add ips plugin example for cost modeling

2024-05-29 Thread Alex Bennée
Pierrick Bouvier writes: (Added Philip to CC) > On 5/28/24 12:57, Alex Bennée wrote: >> Pierrick Bouvier writes: >> >>> On 5/28/24 12:14, Alex Bennée wrote: Pierrick Bouvier writes: > This plugin uses the new time control interface to make decisions > about the state of time

Re: [PATCH 1/1] vhost-vsock: add VIRTIO_F_RING_PACKED to feaure_bits

2024-05-29 Thread Halil Pasic
On Tue, 28 May 2024 11:25:51 +0800 Jason Wang wrote: > > 5) Based on the following, I would very much prefer a per device list of > > features with the semantic "hey QEMU can do that feature without any > > specialized vhost-device support (e.g. like VIRTIO_SCSI_F_CHANGE)" > > Indeed the curre

Re: [PATCH 1/5] sysemu: add set_virtual_time to accel ops

2024-05-29 Thread Philippe Mathieu-Daudé
On 17/5/24 00:20, Pierrick Bouvier wrote: From: Alex Bennée We are about to remove direct calls to individual accelerators for this information and will need a central point for plugins to hook into time changes. From: Alex Bennée Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daud

Re: [PATCH 3/3] backends/hostmem: Round up memory size for qemu_madvise() and mbind()

2024-05-29 Thread David Hildenbrand
On 29.05.24 08:48, Michal Prívozník wrote: On 5/28/24 18:47, David Hildenbrand wrote: Am 28.05.24 um 18:15 schrieb Michal Privoznik: ./build/qemu-system-x86_64 \ -m size=8389632k,slots=16,maxmem=2560k \ -object '{"qom-type":"memory-backend-file","id":"ram-node0","mem-path":"hugepages2M","pr

Re: [PATCH v4] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-05-29 Thread Daniil Tatianin
Thanks for the review Markus! I will fix the wording and add a "Bug:" clause for the next revision. On 5/29/24 3:03 PM, Markus Armbruster wrote: Daniil Tatianin writes: This can be used to force-synchronize the time in guest after a long stop-cont pause, which can be useful for serverless-ty

Re: [PATCH v4] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-05-29 Thread Philippe Mathieu-Daudé
On 29/5/24 14:03, Markus Armbruster wrote: Daniil Tatianin writes: This can be used to force-synchronize the time in guest after a long stop-cont pause, which can be useful for serverless-type workload. Also add a comment to highlight the fact that this (and one other QMP command) only works

Re: [PATCH v4] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-05-29 Thread Daniil Tatianin
On 5/29/24 3:36 PM, Philippe Mathieu-Daudé wrote: On 29/5/24 14:03, Markus Armbruster wrote: Daniil Tatianin writes: This can be used to force-synchronize the time in guest after a long stop-cont pause, which can be useful for serverless-type workload. Also add a comment to highlight the fa

Re: [PATCH V2 0/3] improve -overcommit cpu-pm=on|off

2024-05-29 Thread Igor Mammedov
On Tue, 28 May 2024 11:16:59 -0700 "Chen, Zide" wrote: > On 5/28/2024 2:23 AM, Igor Mammedov wrote: > > On Fri, 24 May 2024 13:00:14 -0700 > > Zide Chen wrote: > > > >> Currently, if running "-overcommit cpu-pm=on" on hosts that don't > >> have MWAIT support, the MWAIT/MONITOR feature is adve

Re: [PATCH 1/1] vhost-vsock: add VIRTIO_F_RING_PACKED to feaure_bits

2024-05-29 Thread Halil Pasic
On Tue, 28 May 2024 17:32:26 +0200 Stefano Garzarella wrote: > >1) The uses is explicitly asking for a vhost device and giving the user > >a non vhost device is not an option. > > I didn't get this point :-( can you elaborate? I was thinking along the lines: QEMU gets told what devices to pro

Re: [PATCH v5 01/23] hw/i386/pc: Deprecate 2.4 to 2.12 pc-i440fx machines

2024-05-29 Thread Igor Mammedov
On Wed, 29 May 2024 07:15:17 +0200 Philippe Mathieu-Daudé wrote: > Similarly to the commit c7437f0ddb "docs/about: Mark the > old pc-i440fx-2.0 - 2.3 machine types as deprecated", > deprecate the 2.4 to 2.12 machines. > > Suggested-by: Thomas Huth > Signed-off-by: Philippe Mathieu-Daudé > Revi

[PATCH v4 4/4] hw/nvme: Expand VI/VQ resource to uint32

2024-05-29 Thread Minwoo Im
VI and VQ resources cover queue resources in each VFs in SR-IOV. Current maximum I/O queue pair size is 0x, we can expand them to cover the full number of I/O queue pairs. This patch also fixed Identify Secondary Controller List overflow due to expand of number of secondary controllers. Revie

Re: [PATCH] tests/qtest/migrate-test: Add a postcopy memfile test

2024-05-29 Thread Fabiano Rosas
Nicholas Piggin writes: > Postcopy requires userfaultfd support, which requires tmpfs if a memory > file is used. > > This adds back support for /dev/shm memory files, but adds preallocation > to skip environments where that mount is limited in size. > > Signed-off-by: Nicholas Piggin > --- > >

[PATCH v4 1/4] hw/nvme: add Identify Endurance Group List

2024-05-29 Thread Minwoo Im
Commit 73064edfb864 ("hw/nvme: flexible data placement emulation") intorudced NVMe FDP feature to nvme-subsys and nvme-ctrl with a single endurance group #1 supported. This means that controller should return proper identify data to host with Identify Endurance Group List (CNS 19h). But, yes, onl

[PATCH v4 0/4] hw/nvme: FDP and SR-IOV enhancements

2024-05-29 Thread Minwoo Im
Hello, This is v4 patchset to increase number of virtual functions for NVMe SR-IOV. Please consider the following change notes per version. This patchset has been tested with the following simple script more than 127 VFs. -device nvme-subsys,id=subsys0 \ -device ioh3420,id=rp2,mu

Re: [PATCH v5 02/23] hw/i386/pc: Remove deprecated pc-i440fx-2.0 machine

2024-05-29 Thread Igor Mammedov
On Wed, 29 May 2024 07:15:18 +0200 Philippe Mathieu-Daudé wrote: > The pc-i440fx-2.0 machine was deprecated for the 8.2 > release (see commit c7437f0ddb "docs/about: Mark the > old pc-i440fx-2.0 - 2.3 machine types as deprecated"), > time to remove it. > > Signed-off-by: Philippe Mathieu-Daudé

[PATCH v4 3/4] hw/nvme: Allocate sec-ctrl-list as a dynamic array

2024-05-29 Thread Minwoo Im
To prevent further bumping up the number of maximum VF te support, this patch allocates a dynamic array (NvmeCtrl *)->sec_ctrl_list based on number of VF supported by sriov_max_vfs property. Signed-off-by: Minwoo Im --- hw/nvme/ctrl.c | 8 +--- hw/nvme/nvme.h | 5 ++--- hw/nvme/subsys.c

[PATCH v4 2/4] hw/nvme: separate identify data for sec. ctrl list

2024-05-29 Thread Minwoo Im
Secondary controller list for virtualization has been managed by Identify Secondary Controller List data structure with NvmeSecCtrlList where up to 127 secondary controller entries can be managed. The problem hasn't arisen so far because NVME_MAX_VFS has been 127. This patch separated identify da

Re: [PATCH 1/1] arm/sbsa-ref: move to Neoverse-N2 as default

2024-05-29 Thread Leif Lindholm
On 2024-05-23 17:53, Marcin Juszkiewicz wrote: Moving to Neoverse-N2 gives us several cpu features to use for expanding our platform: - branch target identification - pointer authentication - RME for confidential computing - RNG for EFI_PROTOCOL_RNG - SVE being enabled by default We do not go f

Re: [PATCH 1/1] tests/avocado: update sbsa-ref firmware

2024-05-29 Thread Leif Lindholm
On 2024-05-28 19:29, Marcin Juszkiewicz wrote: Partial support for NUMA setup: - cpu nodes - memory nodes Used versions: - Trusted Firmware v2.11.0 - Tianocore EDK2 stable202405 - Tianocore EDK2 Platforms code commit 4bbd0ed Firmware is built using Debian 'bookworm' cross toolchain (gcc 12.2.0

Re: [PATCH v5 03/23] hw/usb/hcd-xhci: Remove XHCI_FLAG_FORCE_PCIE_ENDCAP flag

2024-05-29 Thread Igor Mammedov
On Wed, 29 May 2024 07:15:19 +0200 Philippe Mathieu-Daudé wrote: > XHCI_FLAG_FORCE_PCIE_ENDCAP was only used by the > pc-i440fx-2.0 machine, which got removed. Remove it > and simplify usb_xhci_pci_realize(). > > Reviewed-by: Thomas Huth > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Z

Re: [PATCH v5 04/23] hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST flag

2024-05-29 Thread Igor Mammedov
On Wed, 29 May 2024 07:15:20 +0200 Philippe Mathieu-Daudé wrote: > XHCI_FLAG_SS_FIRST was only used by the pc-i440fx-2.0 machine, > which got removed. Remove it and simplify various functions in > hcd-xhci.c. > > Reviewed-by: Thomas Huth > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Z

Re: [PATCH 1/2] Revert "monitor: use aio_co_reschedule_self()"

2024-05-29 Thread Kevin Wolf
Am 29.05.2024 um 12:33 hat Fiona Ebner geschrieben: > CC-ing stable since 1f25c172f83704e350c0829438d832384084a74d is in 9.0.0 Good point, I'm also updating the commit message in my tree to add a Cc: line. Thanks for catching this, Fiona! Kevin

Re: [PULL 6/9] virtio-gpu: fix v2 migration

2024-05-29 Thread Fabiano Rosas
Fiona Ebner writes: > CC-ing stable, because this already is an issue in 9.0.0 > Thank you for pointing this out. I was expecting b4 to find the tag, but I just now noticed that the CC was added by Peter as a reply to the message and not originally via the patch headers, so I should have added i

[PATCH] io/channel-socket: Fix -fsanitize=undefined problem with latest Clang

2024-05-29 Thread Thomas Huth
Casting function pointers from one type to another causes undefined behavior errors when compiling with -fsanitize=undefined with Clang v18: $ QTEST_QEMU_BINARY=./qemu-system-mips64 tests/qtest/netdev-socket TAP version 13 # random seed: R02S4424f4f460de783fdd3d72c5571d3adc 1..10 # Start of m

Re: [PATCH v2 03/67] target/arm: Reject incorrect operands to PLD, PLDW, PLI

2024-05-29 Thread Peter Maydell
On Tue, 28 May 2024 at 18:36, Richard Henderson wrote: > > On 5/28/24 06:18, Peter Maydell wrote: > > On Sat, 25 May 2024 at 00:25, Richard Henderson > > wrote: > >> > >> For all, rm == 15 is invalid. > >> Prior to v8, thumb with rm == 13 is invalid. > >> For PLDW, rn == 15 is invalid. > > > >> F

[QEMU][PATCH 1/1] hw/net/can: Fix sorting of the tx queue

2024-05-29 Thread Shiva sagar Myana
Returning an uint32_t casted to a gint from g_cmp_ids causes the tx queue to become wrongly sorted when executing g_slist_sort. Fix this by always returning -1 or 1 from g_cmp_ids based on the ID comparison instead. Also, if two message IDs are the same, sort them by using their index and transmit

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-29 Thread Greg Sword
On Wed, May 29, 2024 at 12:33 PM Jinpu Wang wrote: > > On Wed, May 29, 2024 at 4:43 AM Gonglei (Arei) > wrote: > > > > Hi, > > > > > -Original Message- > > > From: Peter Xu [mailto:pet...@redhat.com] > > > Sent: Tuesday, May 28, 2024 11:55 PM > > > > > > Exactly, not so compelling, as I

[PATCH] hw/s390x: prevent potential NULL dereference

2024-05-29 Thread Oleg Sviridov
Pointer, returned from function 's390_ipl_get_iplb_pv', may be NULL and is dereferenced immediately after. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Oleg Sviridov --- hw/s390x/ipl.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff -

[PATCH] pci-bridge/xio3130_downstream: fix invalid link speed and link width

2024-05-29 Thread Nam Cao
Set link width to x1 and link speed to 2.5 Gb/s as specified by the datasheet. Without this, these fields in the link status register read zero, which is incorrect. This problem appeared since 3d67447fe7c2 ("pcie: Fill PCIESlot link fields to support higher speeds and widths"), which allows PCIe s

[PATCH] hw/net: prevent potential NULL dereference

2024-05-29 Thread Oleg Sviridov
Pointer, returned from function 'spapr_vio_find_by_reg', may be NULL and is dereferenced immediately after. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Oleg Sviridov --- hw/net/spapr_llan.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/net/spap

Re: [PATCH 1/1] tests/avocado: update sbsa-ref firmware

2024-05-29 Thread Marcin Juszkiewicz
W dniu 29.05.2024 o 15:12, Leif Lindholm pisze: On 2024-05-28 19:29, Marcin Juszkiewicz wrote: Partial support for NUMA setup: - cpu nodes - memory nodes Used versions: - Trusted Firmware v2.11.0 - Tianocore EDK2 stable202405 - Tianocore EDK2 Platforms code commit 4bbd0ed Firmware is built us

Re: [PATCH v4] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-05-29 Thread Philippe Mathieu-Daudé
On 29/5/24 14:43, Daniil Tatianin wrote: On 5/29/24 3:36 PM, Philippe Mathieu-Daudé wrote: On 29/5/24 14:03, Markus Armbruster wrote: Daniil Tatianin writes: This can be used to force-synchronize the time in guest after a long stop-cont pause, which can be useful for serverless-type workloa

  1   2   3   >