[PULL 58/63] target/i386/host-cpu: Consolidate the use of warn_report_once()

2024-04-23 Thread Paolo Bonzini
From: Zhao Liu Use warn_report_once() to get rid of the static local variable "warned". Signed-off-by: Zhao Liu Message-ID: <20240327103951.3853425-2-zhao1@linux.intel.com> Signed-off-by: Paolo Bonzini --- target/i386/host-cpu.c | 11 --- 1 file changed, 4 insertions(+), 7 deletio

Re: hppa-firmware.img missing build-id

2024-04-23 Thread Daniel P . Berrangé
On Tue, Apr 23, 2024 at 05:07:17PM +0200, Helge Deller wrote: > On 4/23/24 16:58, Cole Robinson wrote: > > On 4/23/24 10:11 AM, Cole Robinson wrote: > > > Hi, > > > > > > hppa-firmware.img and hppa-firmware64.img in qemu.git are missing ELF > > > build-id annotations. rpm builds on Fedora will err

[PULL 14/63] memory-device: move stubs out of stubs/

2024-04-23 Thread Paolo Bonzini
Since the memory-device stubs are needed exactly when the Kconfig symbols are not needed, move them to hw/mem/. Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-ID: <20240408155330.522792-15-pbonz...@redhat.com> Signed-off-by: Paolo Bonzin

[PULL 45/63] i386/sev: Add 'legacy-vm-type' parameter for SEV guest objects

2024-04-23 Thread Paolo Bonzini
From: Michael Roth QEMU will currently automatically make use of the KVM_SEV_INIT2 API for initializing SEV and SEV-ES guests verses the older KVM_SEV_INIT/KVM_SEV_ES_INIT interfaces. However, the older interfaces will silently avoid sync'ing FPU/XSAVE state to the VMSA prior to encryption, thus

[PULL 11/63] hw/virtio: move stubs out of stubs/

2024-04-23 Thread Paolo Bonzini
Since the virtio memory device stubs are needed exactly when the Kconfig symbol is not enabled, they can be placed in hw/virtio/ and conditionalized on CONFIG_VIRTIO_MD. Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Message-ID: <20240408155330.522792-12-pbonz...@redhat.com> Signed-

[PULL 60/63] target/i386/cpu: Merge the warning and error messages for AMD HT check

2024-04-23 Thread Paolo Bonzini
From: Zhao Liu Currently, the difference between warn_report_once() and error_report_once() is the former has the "warning:" prefix, while the latter does not have a similar level prefix. At the meantime, considering that there is no error handling logic here, and the purpose of error_report_onc

[PULL 07/63] hw/core: Move system emulation files to system_ss

2024-04-23 Thread Paolo Bonzini
hotplug.c, qdev-hotplug.c and reset.c are not used by user emulation and need not be included in hwcore_ss. Move them to system_ss, where they belong, by letting the linker pull in the stubs when needed. Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Message-ID: <20240408155330.522

[PULL 54/63] physmem: Introduce ram_block_discard_guest_memfd_range()

2024-04-23 Thread Paolo Bonzini
From: Xiaoyao Li When memory page is converted from private to shared, the original private memory is back'ed by guest_memfd. Introduce ram_block_discard_guest_memfd_range() for discarding memory in guest_memfd. Based on a patch by Isaku Yamahata . Signed-off-by: Xiaoyao Li Reviewed-by: David

[PULL 37/63] scripts/update-linux-headers: Add bits.h to file imports

2024-04-23 Thread Paolo Bonzini
From: Michael Roth Signed-off-by: Michael Roth Signed-off-by: Paolo Bonzini --- scripts/update-linux-headers.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh index d48856f9e24..5f20434d5c5 100755 --- a/scri

[PULL 29/63] pci-host/q35: Move PAM initialization above SMRAM initialization

2024-04-23 Thread Paolo Bonzini
From: Isaku Yamahata In mch_realize(), process PAM initialization before SMRAM initialization so that later patch can skill all the SMRAM related with a single check. Signed-off-by: Isaku Yamahata Signed-off-by: Xiaoyao Li Signed-off-by: Michael Roth Message-ID: <20240320083945.991426-18-mich

[PULL 59/63] target/i386/cpu: Consolidate the use of warn_report_once()

2024-04-23 Thread Paolo Bonzini
From: Zhao Liu The difference between error_printf() and error_report() is the latter may contain more information, such as the name of the program ("qemu-system-x86_64"). Thus its variant error_report_once() and warn_report()'s variant warn_report_once() can be used here to print the informatio

[PULL 15/63] colo: move stubs out of stubs/

2024-04-23 Thread Paolo Bonzini
Since the colo stubs are needed exactly when the build options are not enabled, move them together with the code they stub. Signed-off-by: Paolo Bonzini Message-ID: <20240408155330.522792-16-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- stubs/colo.c => migration/colo-stubs.c | 0 stub

[PULL 41/63] KVM: remove kvm_arch_cpu_check_are_resettable

2024-04-23 Thread Paolo Bonzini
Board reset requires writing a fresh CPU state. As far as KVM is concerned, the only thing that blocks reset is that CPU state is encrypted; therefore, kvm_cpus_are_resettable() can simply check if that is the case. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- include/s

[PULL 32/63] confidential guest support: Add kvm_init() and kvm_reset() in class

2024-04-23 Thread Paolo Bonzini
From: Xiaoyao Li Different confidential VMs in different architectures all have the same needs to do their specific initialization (and maybe resetting) stuffs with KVM. Currently each of them exposes individual *_kvm_init() functions and let machine code or kvm code to call it. To facilitate th

[PULL 61/63] accel/tcg/icount-common: Consolidate the use of warn_report_once()

2024-04-23 Thread Paolo Bonzini
From: Zhao Liu Use warn_report_once() to get rid of the static local variable "notified". Signed-off-by: Zhao Liu Message-ID: <20240418100716.1085491-1-zhao1@linux.intel.com> Signed-off-by: Paolo Bonzini --- accel/tcg/icount-common.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletion

[PULL 43/63] target/i386: Implement mc->kvm_type() to get VM type

2024-04-23 Thread Paolo Bonzini
KVM is introducing a new API to create confidential guests, which will be used by TDX and SEV-SNP but is also available for SEV and SEV-ES. The API uses the VM type argument to KVM_CREATE_VM to identify which confidential computing technology to use. Since there are no other expected uses of VM t

[PULL 40/63] KVM: track whether guest state is encrypted

2024-04-23 Thread Paolo Bonzini
So far, KVM has allowed KVM_GET/SET_* ioctls to execute even if the guest state is encrypted, in which case they do nothing. For the new API using VM types, instead, the ioctls will fail which is a safer and more robust approach. The new API will be the only one available for SEV-SNP and TDX, but

[PULL 36/63] scripts/update-linux-headers: Add setup_data.h to import list

2024-04-23 Thread Paolo Bonzini
From: Michael Roth Data structures like struct setup_data have been moved to a separate setup_data.h header which bootparam.h relies on. Add setup_data.h to the cp_portable() list and sync it along with the other header files. Note that currently struct setup_data is stripped away as part of gen

[PULL 03/63] ebpf: Restrict to system emulation

2024-04-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé eBPF is not used in user emulation. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-ID: <20240404194757.9343-2-phi...@linaro.org> Signed-off-by: Paolo Bonzini Message-ID: <20240408155330.522792-4-pbonz...@redhat.com> Signed-off-by: Pao

[PULL 49/63] RAMBlock: Add support of KVM private guest memfd

2024-04-23 Thread Paolo Bonzini
From: Xiaoyao Li Add KVM guest_memfd support to RAMBlock so both normal hva based memory and kvm guest memfd based private memory can be associated in one RAMBlock. Introduce new flag RAM_GUEST_MEMFD. When it's set, it calls KVM ioctl to create private guest_memfd during RAMBlock setup. Allocat

[PULL 16/63] stubs: split record/replay stubs further

2024-04-23 Thread Paolo Bonzini
replay.c symbols are only needed by user mode emulation, with the exception of replay_mode that is needed by both user mode emulation (by way of qemu_guest_getrandom) and block layer tools (by way of util/qemu-timer.c). Since it is needed by libqemuutil rather than specific files that are part of

[PULL 47/63] trace/kvm: Split address space and slot id in trace_kvm_set_user_memory()

2024-04-23 Thread Paolo Bonzini
From: Xiaoyao Li The upper 16 bits of kvm_userspace_memory_region::slot are address space id. Parse it separately in trace_kvm_set_user_memory(). Signed-off-by: Xiaoyao Li Message-ID: <20240229063726.610065-5-xiaoyao...@intel.com> Signed-off-by: Paolo Bonzini --- accel/kvm/kvm-all.c| 5 ++

[PULL 26/63] target/i386: Introduce Icelake-Server-v7 to enable TSX

2024-04-23 Thread Paolo Bonzini
From: Zhenzhong Duan When start L2 guest with both L1/L2 using Icelake-Server-v3 or above, QEMU reports below warning: "warning: host doesn't support requested feature: MSR(10AH).taa-no [bit 8]" Reason is QEMU Icelake-Server-v3 has TSX feature disabled but enables taa-no bit. It's meaningless t

[PULL 39/63] runstate: skip initial CPU reset if reset is not actually possible

2024-04-23 Thread Paolo Bonzini
Right now, the system reset is concluded by a call to cpu_synchronize_all_post_reset() in order to sync any changes that the machine reset callback applied to the CPU state. However, for VMs with encrypted state such as SEV-ES guests (currently the only case of guests with non-resettable CPUs) thi

[PULL 19/63] vga: optimize computation of dirty memory region

2024-04-23 Thread Paolo Bonzini
The depth == 0 and depth == 15 have to be special cased because width * depth / 8 does not provide the correct scanline length. However, thanks to the recent reorganization of vga_draw_graphic() the correct value of VRAM bits per pixel is available in "bits". Use it (via the same "bwidth" computat

[PULL 24/63] kvm: add support for guest physical bits

2024-04-23 Thread Paolo Bonzini
From: Gerd Hoffmann Query kvm for supported guest physical address bits, in cpuid function 8008, eax[23:16]. Usually this is identical to host physical address bits. With NPT or EPT being used this might be restricted to 48 (max 4-level paging address space size) even if the host cpu suppor

[PULL 42/63] target/i386: introduce x86-confidential-guest

2024-04-23 Thread Paolo Bonzini
Introduce a common superclass for x86 confidential guest implementations. It will extend ConfidentialGuestSupportClass with a method that provides the VM type to be passed to KVM_CREATE_VM. Signed-off-by: Paolo Bonzini --- target/i386/confidential-guest.h | 40 t

[PULL 52/63] HostMem: Add mechanism to opt in kvm guest memfd via MachineState

2024-04-23 Thread Paolo Bonzini
From: Xiaoyao Li Add a new member "guest_memfd" to memory backends. When it's set to true, it enables RAM_GUEST_MEMFD in ram_flags, thus private kvm guest_memfd will be allocated during RAMBlock allocation. Memory backend's @guest_memfd is wired with @require_guest_memfd field of MachineState. I

[PULL 46/63] hw/i386/sev: Use legacy SEV VM types for older machine types

2024-04-23 Thread Paolo Bonzini
From: Michael Roth Newer 9.1 machine types will default to using the KVM_SEV_INIT2 API for creating SEV/SEV-ES going forward. However, this API results in guest measurement changes which are generally not expected for users of these older guest types and can cause disruption if they switch to a n

[PULL 25/63] i386/kvm: Move architectural CPUID leaf generation to separate helper

2024-04-23 Thread Paolo Bonzini
From: Sean Christopherson Move the architectural (for lack of a better term) CPUID leaf generation to a separate helper so that the generation code can be reused by TDX, which needs to generate a canonical VM-scoped configuration. For now this is just a cleanup, so keep the function static. Sig

[PULL 55/63] kvm: handle KVM_EXIT_MEMORY_FAULT

2024-04-23 Thread Paolo Bonzini
From: Chao Peng Upon an KVM_EXIT_MEMORY_FAULT exit, userspace needs to do the memory conversion on the RAMBlock to turn the memory into desired attribute, switching between private and shared. Currently only KVM_MEMORY_EXIT_FLAG_PRIVATE in flags is valid when KVM_EXIT_MEMORY_FAULT happens. Note

[PULL 20/63] vga: move dirty memory region code together

2024-04-23 Thread Paolo Bonzini
Take into account split screen mode close to wrap around, which is the other special case for dirty memory region computation. Signed-off-by: Paolo Bonzini --- hw/display/vga.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/display/vga.c b/hw/display/vga.c index 7

[PULL 06/63] util/qemu-config: Extract QMP commands to qemu-config-qmp.c

2024-04-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé QMP is irrelevant for user emulation. Extract the code related to QMP in a different source file, which won't be build for user emulation binaries. This avoid pulling pointless code. Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240404194757.9343-5-phi...@lin

[PULL 31/63] hw/i386/acpi: Set PCAT_COMPAT bit only when pic is not disabled

2024-04-23 Thread Paolo Bonzini
From: Xiaoyao Li A value 1 of PCAT_COMPAT (bit 0) of MADT.Flags indicates that the system also has a PC-AT-compatible dual-8259 setup, i.e., the PIC. When PIC is not enabled (pic=off) for x86 machine, the PCAT_COMPAT bit needs to be cleared. The PIC probe should then print: [0.155970] U

[PULL 23/63] target/i386: add guest-phys-bits cpu property

2024-04-23 Thread Paolo Bonzini
From: Gerd Hoffmann Allows to set guest-phys-bits (cpuid leaf 8008, eax[23:16]) via -cpu $model,guest-phys-bits=$nr. Signed-off-by: Gerd Hoffmann Message-ID: <20240318155336.156197-3-kra...@redhat.com> Reviewed-by: Zhao Liu Signed-off-by: Paolo Bonzini --- target/i386/cpu.h | 8

[PULL 63/63] target/i386/translate.c: always write 32-bits for SGDT and SIDT

2024-04-23 Thread Paolo Bonzini
From: Mark Cave-Ayland The various Intel CPU manuals claim that SGDT and SIDT can write either 24-bits or 32-bits depending upon the operand size, but this is incorrect. Not only do the Intel CPU manuals give contradictory information between processor revisions, but this information doesn't even

Re: [PATCH intel_iommu 3/7] intel_iommu: make types match

2024-04-23 Thread CLEMENT MATHIEU--DRIF
On 23/04/2024 10:19, Philippe Mathieu-Daudé wrote: > > On 23/4/24 07:05, CLEMENT MATHIEU--DRIF wrote: >> >> On 22/04/2024 19:03, Philippe Mathieu-Daudé wrote: >>> On 22/4/24 17:52, CLEMENT MATHIEU--DRIF wrote: The 'level' field in vtd_iotlb_key is an uint8_t. We don't need to store level

[PULL 09/63] stubs: remove obsolete stubs

2024-04-23 Thread Paolo Bonzini
These file define functions are are not called from common code anymore. Delete those functions and, if applicable, the entire files. Signed-off-by: Paolo Bonzini Acked-by: Richard Henderson Message-ID: <20240408155330.522792-10-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- include/sy

[PULL 62/63] pythondeps.toml: warn about updates needed to docs/requirements.txt

2024-04-23 Thread Paolo Bonzini
docs/requirements.txt is expected by readthedocs and should be in sync with pythondeps.toml. Add a comment to both. Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- docs/requirements.txt | 3 +++ pythondeps.toml | 1 + 2 files changed, 4 inse

[PULL 18/63] stubs: move monitor_fdsets_cleanup with other fdset stubs

2024-04-23 Thread Paolo Bonzini
Even though monitor_get_fd() has to remain separate because it is mocked by tests/unit/test-util-sockets, monitor_fdsets_cleanup() is logically part of the stubs for monitor/fds.c, so move it there. Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Message-ID: <20240408155330.522792-19

[PULL 05/63] yank: only build if needed

2024-04-23 Thread Paolo Bonzini
The yank feature is not used in user emulation. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-ID: <20240408155330.522792-6-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- util/meson.build | 2

[PULL 33/63] i386/sev: Switch to use confidential_guest_kvm_init()

2024-04-23 Thread Paolo Bonzini
From: Xiaoyao Li Use confidential_guest_kvm_init() instead of calling SEV specific sev_kvm_init(). This allows the introduction of multiple confidential-guest-support subclasses for different x86 vendors. As a bonus, stubs are not needed anymore since there is no direct call from target/i386/kvm

[PULL 28/63] target/i386: Export RFDS bit to guests

2024-04-23 Thread Paolo Bonzini
From: Pawan Gupta Register File Data Sampling (RFDS) is a CPU side-channel vulnerability that may expose stale register value. CPUs that set RFDS_NO bit in MSR IA32_ARCH_CAPABILITIES indicate that they are not vulnerable to RFDS. Similarly, RFDS_CLEAR indicates that CPU is affected by RFDS, and h

[PULL 35/63] s390: Switch to use confidential_guest_kvm_init()

2024-04-23 Thread Paolo Bonzini
From: Xiaoyao Li Use unified confidential_guest_kvm_init() for consistency with other architectures. Signed-off-by: Xiaoyao Li Message-Id: <20240229060038.606591-1-xiaoyao...@intel.com> Signed-off-by: Paolo Bonzini --- target/s390x/kvm/pv.h | 14 -- hw/s390x/s390-virtio-ccw.c

[PULL 22/63] hw: Add compat machines for 9.1

2024-04-23 Thread Paolo Bonzini
Add 9.1 machine types for arm/i440fx/m68k/q35/s390x/spapr. Reviewed-by: Cornelia Huck Acked-by: Thomas Huth Reviewed-by: Harsh Prateek Bora Reviewed-by: Zhao Liu Cc: Gavin Shan Signed-off-by: Paolo Bonzini --- include/hw/boards.h| 3 +++ include/hw/i386/pc.h | 3 +++ hw/arm/

[PULL 44/63] target/i386: SEV: use KVM_SEV_INIT2 if possible

2024-04-23 Thread Paolo Bonzini
Implement support for the KVM_X86_SEV_VM and KVM_X86_SEV_ES_VM virtual machine types, and the KVM_SEV_INIT2 function of KVM_MEMORY_ENCRYPT_OP. These replace the KVM_SEV_INIT and KVM_SEV_ES_INIT functions, and have several advantages: - sharing the initialization sequence with SEV-SNP and TDX - a

[PULL 27/63] target/i386: Add new CPU model SierraForest

2024-04-23 Thread Paolo Bonzini
From: Tao Su According to table 1-2 in Intel Architecture Instruction Set Extensions and Future Features (rev 051) [1], SierraForest has the following new features which have already been virtualized: - CMPCCXADD CPUID.(EAX=7,ECX=1):EAX[bit 7] - AVX-IFMA CPUID.(EAX=7,ECX=1):EAX[bit 23] - AVX-VNN

[PULL 13/63] ramfb: move stubs out of stubs/

2024-04-23 Thread Paolo Bonzini
Since the ramfb stubs are needed exactly when the Kconfig symbols are not needed, move them to hw/display/ and compile them when ramfb.c is absent. Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-ID: <20240408155330.522792-14-pbonz...@redh

[PATCH] linux-user: Add ioctl for BLKBSZSET

2024-04-23 Thread Michael Vogt
Tiny patch to add the ioctl wrapper definition for BLKBSZSET. Signed-off-by: Michael Vogt --- linux-user/ioctls.h | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h index d508d0c04a..3b41128fd7 100644 --- a/linux-user/ioctls.h +++ b/linux-user/ioctls.h

Re: [PULL 25/63] i386/kvm: Move architectural CPUID leaf generation to separate helper

2024-04-23 Thread Xiaoyao Li
On 4/23/2024 11:09 PM, Paolo Bonzini wrote: From: Sean Christopherson Move the architectural (for lack of a better term) CPUID leaf generation to a separate helper so that the generation code can be reused by TDX, which needs to generate a canonical VM-scoped configuration. For now this is jus

Re: [PATCH 0/6] Add ivshmem-flat device

2024-04-23 Thread Bill Mills
Hi Markus, On 4/23/24 6:39 AM, Markus Armbruster wrote: Gustavo Romero writes: Hi Markus, Thanks for interesting in the ivshmem-flat device. Bill Mills (cc:ed) is the best person to answer your question, so please find his answer below. On 2/28/24 3:29 AM, Markus Armbruster wrote: Gustavo

Re: [PATCH RFC 00/26] Multifd 🔀 device state transfer support with VFIO consumer

2024-04-23 Thread Maciej S. Szmigiero
On 18.04.2024 22:02, Peter Xu wrote: On Thu, Apr 18, 2024 at 08:14:15PM +0200, Maciej S. Szmigiero wrote: On 18.04.2024 12:39, Daniel P. Berrangé wrote: On Thu, Apr 18, 2024 at 11:50:12AM +0200, Maciej S. Szmigiero wrote: On 17.04.2024 18:35, Daniel P. Berrangé wrote: On Wed, Apr 17, 2024 at

Re: [PATCH RFC 00/26] Multifd 🔀 device state transfer support with VFIO consumer

2024-04-23 Thread Maciej S. Szmigiero
On 19.04.2024 17:31, Peter Xu wrote: On Fri, Apr 19, 2024 at 11:07:21AM +0100, Daniel P. Berrangé wrote: On Thu, Apr 18, 2024 at 04:02:49PM -0400, Peter Xu wrote: On Thu, Apr 18, 2024 at 08:14:15PM +0200, Maciej S. Szmigiero wrote: I think one of the reasons for these results is that mixed (RA

Re: [PATCH 6.6.y] virtio_net: Do not send RSS key if it is not supported

2024-04-23 Thread Greg KH
On Mon, Apr 22, 2024 at 08:18:03AM -0700, Vlad Poenaru wrote: > From: Breno Leitao > > commit 059a49aa2e25c58f90b50151f109dd3c4cdb3a47 upstream. > Now queued up, thanks. greg k-h

Re: [PATCH v2 01/15] exec/memtxattr: add process identifier to the transaction attributes

2024-04-23 Thread Frank Chang
Reviewed-by: Frank Chang Daniel Henrique Barboza 於 2024年3月8日 週五 上午12:04寫道: > > From: Tomasz Jeznach > > Extend memory transaction attributes with process identifier to allow > per-request address translation logic to use requester_id / process_id > to identify memory mapping (e.g. enabling IOMM

Patch "virtio_net: Do not send RSS key if it is not supported" has been added to the 6.6-stable tree

2024-04-23 Thread gregkh
This is a note to let you know that I've just added the patch titled virtio_net: Do not send RSS key if it is not supported to the 6.6-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Problems (timeouts) when testing usb-ohci with qemu

2024-04-23 Thread Guenter Roeck
Hi, when testing usb-ohci with qemu's pci-ohci emulation, I keep getting random usb interface timeouts. Sometimes the usb_hub_wq times out. [9.555666] Waiting for root device /dev/sda... [ 62.452625] INFO: task kworker/0:2:42 blocked for more than 30 seconds. [ 62.453036] Tainted: G

Re: [PATCH v3 1/2] cxl/core: correct length of DPA field masks

2024-04-23 Thread Ira Weiny
Shiyang Ruan wrote: > The length of Physical Address in General Media Event Record/DRAM Event > Record is 64-bit, so the field mask should be defined as such length. > Otherwise, this causes cxl_general_media and cxl_dram tracepoints to > mask off the upper-32-bits of DPA addresses. The cxl_poison

Re: [PATCH v3 1/2] cxl/core: correct length of DPA field masks

2024-04-23 Thread Dan Williams
Shiyang Ruan wrote: > The length of Physical Address in General Media Event Record/DRAM Event > Record is 64-bit, so the field mask should be defined as such length. > Otherwise, this causes cxl_general_media and cxl_dram tracepoints to > mask off the upper-32-bits of DPA addresses. The cxl_poison

Re: [PATCH v8 00/11] Support blob memory and venus on qemu

2024-04-23 Thread Dmitry Osipenko
On 4/23/24 11:30, Alex Bennée wrote: > Dmitry Osipenko writes: > >> Hello, >> >> This series enables Vulkan Venus context support on virtio-gpu. >> >> All virglrender and almost all Linux kernel prerequisite changes >> needed by Venus are already in upstream. For kernel there is a pending >> KVM

Re: Problems (timeouts) when testing usb-ohci with qemu

2024-04-23 Thread Alan Stern
On Tue, Apr 23, 2024 at 10:04:17AM -0700, Guenter Roeck wrote: > Hi, > > when testing usb-ohci What is usb-ohci? Do you mean ohci-hcd? > with qemu's pci-ohci emulation, I keep getting > random usb interface timeouts. Sometimes the usb_hub_wq times out. ... > Sometimes there is an i/o scheduli

Re: [PATCH v3 1/2] cxl/core: correct length of DPA field masks

2024-04-23 Thread Alison Schofield
On Wed, Apr 17, 2024 at 03:50:52PM +0800, Shiyang Ruan wrote: > The length of Physical Address in General Media Event Record/DRAM Event > Record is 64-bit, so the field mask should be defined as such length. > Otherwise, this causes cxl_general_media and cxl_dram tracepoints to > mask off the upper

Re: [PATCH v8 09/11] virtio-gpu: Resource UUID

2024-04-23 Thread Dmitry Osipenko
On 4/19/24 12:29, Akihiko Odaki wrote: > On 2024/04/19 4:00, Dmitry Osipenko wrote: >> From: Antonio Caggiano >> >> Enable resource UUID feature and implement command resource assign UUID. >> UUID feature availability is mandatory for Vulkan Venus context. >> >> UUID is intended for sharing dmabuf

Re: [PATCH 00/22] configs: switch boards to "default y"

2024-04-23 Thread Fabiano Rosas
Paolo Bonzini writes: > Some boards, notably ARM boards that use TCG, are already using > "default y". This was done to remove TCG-only boards from > a KVM-only build in commit 29d9efca16 (2023-04-26). > > This series converts all other boards to that, so that the requirements > of each board ar

Re: [PATCH v3 2/2] cxl/core: add poison creation event handler

2024-04-23 Thread Ira Weiny
Shiyang Ruan wrote: > Currently driver only traces cxl events, poison creation (for both vmem > and pmem type) on cxl memdev is silent. OS needs to be notified then it > could handle poison pages in time. Per CXL spec, the device error event > could be signaled through FW-First and OS-First metho

Re: [PATCH 03/22] arm: switch boards to "default y"

2024-04-23 Thread Fabiano Rosas
Paolo Bonzini writes: > For ARM targets, boards that require TCG are already using "default y". > Switch ARM_VIRT to the same selection mechanism. > > No changes to generated config-devices.mak file. > > Signed-off-by: Paolo Bonzini > --- > configs/devices/arm-softmmu/default.mak | 3 ++- > hw/

Re: [PATCH 00/22] configs: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Il mar 23 apr 2024, 19:57 Fabiano Rosas ha scritto: > > There is an important difference in that Kconfig symbols for boards > > have to be enabled in a --without-default-devices build, similar to > > devices. > > And how do we make that happen? > Before building you edit configs/devices/ to set

Re: [PATCH 03/22] arm: switch boards to "default y"

2024-04-23 Thread Philippe Mathieu-Daudé
Hi Fabiano, On 23/4/24 20:02, Fabiano Rosas wrote: Paolo Bonzini writes: For ARM targets, boards that require TCG are already using "default y". Switch ARM_VIRT to the same selection mechanism. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs/devi

Re: [PATCH] Add zh_TW Traditional Chinese translation

2024-04-23 Thread Peter Dave Hello
Hi PMM, Zhao & Daniel, Thank you for all your help; I wonder if the copyright can just belong to this project because the copyright to me personally in the open source world just to deal with somebody violets the license. Otherwise, I'm more copyleft. What do you think? Best, Peter On Thursd

Re: [PATCH 03/22] arm: switch boards to "default y"

2024-04-23 Thread Fabiano Rosas
Philippe Mathieu-Daudé writes: > Hi Fabiano, > > On 23/4/24 20:02, Fabiano Rosas wrote: >> Paolo Bonzini writes: >> >>> For ARM targets, boards that require TCG are already using "default y". >>> Switch ARM_VIRT to the same selection mechanism. >>> >>> No changes to generated config-devices.mak

Re: [PATCH 03/22] arm: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Il mar 23 apr 2024, 20:12 Philippe Mathieu-Daudé ha scritto: > Hi Fabiano, > > On 23/4/24 20:02, Fabiano Rosas wrote: > > Paolo Bonzini writes: > > > >> For ARM targets, boards that require TCG are already using "default y". > >> Switch ARM_VIRT to the same selection mechanism. > >> > >> No chan

Re: [PATCH 00/27] Add qapi-domain Sphinx extension

2024-04-23 Thread John Snow
On Tue, Apr 23, 2024, 3:48 AM Markus Armbruster wrote: > John Snow writes: > > > On Mon, Apr 22, 2024 at 12:38 PM John Snow wrote: > >> > >> On Mon, Apr 22, 2024 at 5:20 AM Markus Armbruster > wrote: > >> > > >> > John Snow writes: > >> > > >> > > On Fri, Apr 19, 2024, 10:45 AM Markus Armbrus

Re: [PATCH v3 2/2] cxl/core: add poison creation event handler

2024-04-23 Thread Dan Williams
Shiyang Ruan wrote: > Currently driver only traces cxl events, poison creation (for both vmem > and pmem type) on cxl memdev is silent. As it should be. > OS needs to be notified then it could handle poison pages in time. No, it was always the case that latent poison is an "action optional" even

Re: hppa-firmware.img missing build-id

2024-04-23 Thread Helge Deller
On 4/23/24 17:10, Daniel P. Berrangé wrote: On Tue, Apr 23, 2024 at 05:07:17PM +0200, Helge Deller wrote: On 4/23/24 16:58, Cole Robinson wrote: On 4/23/24 10:11 AM, Cole Robinson wrote: Hi, hppa-firmware.img and hppa-firmware64.img in qemu.git are missing ELF build-id annotations. rpm builds

RE: [PATCH v10 2/6] ui/console: new dmabuf.h and dmabuf.c for QemuDmaBuf struct and helpers

2024-04-23 Thread Kim, Dongwon
Hi Daniel, > -Original Message- > From: Daniel P. Berrangé > Sent: Tuesday, April 23, 2024 7:07 AM > To: Kim, Dongwon > Cc: qemu-devel@nongnu.org; marcandre.lur...@redhat.com; > phi...@linaro.org > Subject: Re: [PATCH v10 2/6] ui/console: new dmabuf.h and dmabuf.c for > QemuDmaBuf struct

Re: [PATCH 03/22] arm: switch boards to "default y"

2024-04-23 Thread Fabiano Rosas
Paolo Bonzini writes: > Il mar 23 apr 2024, 20:12 Philippe Mathieu-Daudé ha > scritto: > >> Hi Fabiano, >> >> On 23/4/24 20:02, Fabiano Rosas wrote: >> > Paolo Bonzini writes: >> > >> >> For ARM targets, boards that require TCG are already using "default y". >> >> Switch ARM_VIRT to the same se

Re: [PATCH v10 2/6] ui/console: new dmabuf.h and dmabuf.c for QemuDmaBuf struct and helpers

2024-04-23 Thread Daniel P . Berrangé
On Tue, Apr 23, 2024 at 07:05:20PM +, Kim, Dongwon wrote: > Hi Daniel, > > > -Original Message- > > From: Daniel P. Berrangé > > Sent: Tuesday, April 23, 2024 7:07 AM > > To: Kim, Dongwon > > Cc: qemu-devel@nongnu.org; marcandre.lur...@redhat.com; > > phi...@linaro.org > > Subject: R

[PATCH] Kconfig: kvm: allow building without any board

2024-04-23 Thread Paolo Bonzini
KVM code might have to call functions on the PCIDevice that is passed to kvm_arch_fixup_msi_route(). This fails in the case where --without-default-devices is used and no board is configured. While this is not really a useful configuration, and therefore setting up stubs for CONFIG_PCI is overkil

Re: [PATCH 11/22] meson: make target endianneess available to Kconfig

2024-04-23 Thread Fabiano Rosas
Paolo Bonzini writes: > Some targets use "default y" for boards to filter out those that require > TCG. For consistency we are switching all other targets to do the same. > MIPS boards may only be available for big-endian or only for > little-endian emulators, add a symbol so that this can be de

Re: [PATCH] Kconfig: kvm: allow building without any board

2024-04-23 Thread Philippe Mathieu-Daudé
On 23/4/24 21:17, Paolo Bonzini wrote: KVM code might have to call functions on the PCIDevice that is passed to kvm_arch_fixup_msi_route(). This fails in the case where --without-default-devices is used and no board is configured. While this is not really a useful configuration, and therefore s

Re: [PATCH] target/i386/translate.c: always write 32-bits for SGDT and SIDT

2024-04-23 Thread Mark Cave-Ayland
On 23/04/2024 10:18, Paolo Bonzini wrote: On Mon, Apr 22, 2024 at 9:10 PM Volker Rümelin wrote: Am 20.04.24 um 07:40 schrieb Mark Cave-Ayland: Current documentation agrees that all 32 bits are written, so I don't think you need this comment: Ah that's good to know the docs are now correct.

Re: [PATCH 3/3] target/arm: Default to 1GHz cntfrq for 'max' and new CPUs

2024-04-23 Thread Philippe Mathieu-Daudé
(+Markus for qdev properties; one inlined comment) On 19/4/24 20:46, Peter Maydell wrote: In previous versions of the Arm architecture, the frequency of the generic timers as reported in CNTFRQ_EL0 could be any IMPDEF value, and for QEMU we picked 62.5MHz, giving a timer tick period of 16ns. In

Re: [PATCH v3 1/2] cxl/core: correct length of DPA field masks

2024-04-23 Thread Ira Weiny
Alison Schofield wrote: > On Wed, Apr 17, 2024 at 03:50:52PM +0800, Shiyang Ruan wrote: [snip] > > diff --git a/drivers/cxl/core/trace.h b/drivers/cxl/core/trace.h > > index e5f13260fc52..cdfce932d5b1 100644 > > --- a/drivers/cxl/core/trace.h > > +++ b/drivers/cxl/core/trace.h > > @@ -253,7 +253,

[PATCH v2 1/3] cpu-models: add "disable-deprecated-feats" option to cpu model expansion

2024-04-23 Thread Collin Walling
This optional parameter for query-cpu-model-expansion enables CPU model features flagged as deprecated to appear in the resulting list of properties. This commit does not add support beyond adding a new argument to the query. All queries with this option present will result in an error claiming th

[PATCH v2 0/3] query-cpu-model-expansion: add disable-deprecated-feats arg

2024-04-23 Thread Collin Walling
The current implementation of query-cpu-model-expansion is lacking a way to conditionally retrieve CPU models with properties (i.e. features) that are flagged as deprecated set to disabled. To remedy this, a new optional boolean "disable-deprecated-feats" argument has been added to the query. Here

Re: Problems (timeouts) when testing usb-ohci with qemu

2024-04-23 Thread Guenter Roeck
Hi Alan, On 4/23/24 10:30, Alan Stern wrote: On Tue, Apr 23, 2024 at 10:04:17AM -0700, Guenter Roeck wrote: Hi, when testing usb-ohci What is usb-ohci? Do you mean ohci-hcd? with qemu's pci-ohci emulation, I keep getting random usb interface timeouts. Sometimes the usb_hub_wq times out.

[PATCH v2 3/3] target/s390x: flag te and cte as deprecated

2024-04-23 Thread Collin Walling
Add the CONSTRAINT_TRANSACTIONAL_EXE (cte) and TRANSACTIONAL_EXE (te) to the list of deprecated features. Signed-off-by: Collin Walling --- target/s390x/cpu_features.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c index efafc9711

[PATCH v2 2/3] target/s390x: add support for "disable-deprecated-feats" expansion option

2024-04-23 Thread Collin Walling
Retain a list of deprecated features disjoint from any particular CPU model. When a query-cpu-model-expansion is provided with the "disable-deprecated-feats" option set, the resulting properties list will include all deprecated features paired with false. Example: { ... "bpb": false, "cssk

Re: [PATCH v5 1/5] hw/display : Add device DM163

2024-04-23 Thread Philippe Mathieu-Daudé
Hi Inès, On 21/4/24 16:02, Inès Varhol wrote: This device implements the IM120417002 colors shield v1.1 for Arduino (which relies on the DM163 8x3-channel led driving logic) and features a simple display of an 8x8 RGB matrix. The columns of the matrix are driven by the DM163 and the rows are dri

[PATCH 6.6 152/158] virtio_net: Do not send RSS key if it is not supported

2024-04-23 Thread Greg Kroah-Hartman
6.6-stable review patch. If anyone has any objections, please let me know. -- From: Breno Leitao commit 059a49aa2e25c58f90b50151f109dd3c4cdb3a47 upstream. There is a bug when setting the RSS options in virtio_net that can break the whole machine, getting the kernel into an inf

Re: [PATCH RFC 00/26] Multifd 🔀 device state transfer support with VFIO consumer

2024-04-23 Thread Peter Xu
On Tue, Apr 23, 2024 at 06:15:35PM +0200, Maciej S. Szmigiero wrote: > On 19.04.2024 17:31, Peter Xu wrote: > > On Fri, Apr 19, 2024 at 11:07:21AM +0100, Daniel P. Berrangé wrote: > > > On Thu, Apr 18, 2024 at 04:02:49PM -0400, Peter Xu wrote: > > > > On Thu, Apr 18, 2024 at 08:14:15PM +0200, Macie

Re: [RFC 1/2] iova_tree: add an id member to DMAMap

2024-04-23 Thread Si-Wei Liu
On 4/22/2024 1:49 AM, Eugenio Perez Martin wrote: On Sat, Apr 20, 2024 at 1:50 AM Si-Wei Liu wrote: On 4/19/2024 1:29 AM, Eugenio Perez Martin wrote: On Thu, Apr 18, 2024 at 10:46 PM Si-Wei Liu wrote: On 4/10/2024 3:03 AM, Eugenio Pérez wrote: IOVA tree is also used to track the mappi

Re: [PATCH RFC 00/26] Multifd 🔀 device state transfer support with VFIO consumer

2024-04-23 Thread Maciej S. Szmigiero
On 24.04.2024 00:20, Peter Xu wrote: On Tue, Apr 23, 2024 at 06:15:35PM +0200, Maciej S. Szmigiero wrote: On 19.04.2024 17:31, Peter Xu wrote: On Fri, Apr 19, 2024 at 11:07:21AM +0100, Daniel P. Berrangé wrote: On Thu, Apr 18, 2024 at 04:02:49PM -0400, Peter Xu wrote: On Thu, Apr 18, 2024 at

Re: [PATCH RFC 00/26] Multifd 🔀 device state transfer support with VFIO consumer

2024-04-23 Thread Peter Xu
On Tue, Apr 23, 2024 at 06:14:18PM +0200, Maciej S. Szmigiero wrote: > We don't lose any genericity since by default the transfer is done via > mixed RAM / device state multifd channels from a shared pool. > > It's only when x-multifd-channels-device-state is set to value > 0 then > the requested

[PATCH 00/24] Misc PPC exception and BookE MMU clean ups

2024-04-23 Thread BALATON Zoltan
This series does some further clean up mostly around BookE MMU to untangle it from other MMU models. It also contains some other changes that I've come up with while working on this. The first 3 patches are from the last exception handling clean up series that were dropped due to some error on CI b

[PATCH 11/24] target/ppc/mmu_common.c: Split off real mode cases in get_physical_address_wtlb()

2024-04-23 Thread BALATON Zoltan
The real mode handling is identical in the remaining switch cases. Split off these common real mode cases into a separate conditional to leave only the else branches in the switch that are different. Signed-off-by: BALATON Zoltan --- target/ppc/mmu_common.c | 34 +

[PATCH 02/24] target/ppc: Move patching nip from exception handler to helper_scv

2024-04-23 Thread BALATON Zoltan
From: Nicholas Piggin Unlike sc, for scv a facility unavailable interrupt must be generated if FSCR[SCV]=0 so we can't raise the exception with nip set to next instruction but we can move advancing nip if the FSCR check passes to helper_scv so the exception handler does not need to change it. [b

[PATCH 22/24] target/ppc/mmu_common.c: Remove BookE handling from get_physical_address_wtlb()

2024-04-23 Thread BALATON Zoltan
This function is no longer called for BookE MMU model so remove parts related to it. This has uncovered a few may be used uninitialised warnings that are also fixed. Signed-off-by: BALATON Zoltan --- target/ppc/mmu_common.c | 25 + 1 file changed, 5 insertions(+), 20 dele

[PATCH 24/24] target/ppc/mmu_common.c: Move BookE MMU functions together

2024-04-23 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan --- target/ppc/mmu_common.c | 300 1 file changed, 150 insertions(+), 150 deletions(-) diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c index ad64ec1647..18e49aa2f1 100644 --- a/target/ppc/mmu_common.c +++ b/tar

[PATCH 13/24] target/ppc/mmu_common.c: Simplify mmubooke_get_physical_address()

2024-04-23 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan --- target/ppc/mmu_common.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c index 843f909619..d40ddb6fc3 100644 --- a/target/ppc/mmu_common.c +++ b/target/ppc/mmu_common.

<    1   2   3   >