Re: [PATCH v9 13/20] virtio-net: Return an error when vhost cannot enable RSS

2024-04-20 Thread Yuri Benditovich
On Tue, Apr 16, 2024 at 9:54 AM Akihiko Odaki wrote: > > On 2024/04/16 13:00, Jason Wang wrote: > > On Mon, Apr 15, 2024 at 10:05 PM Yuri Benditovich > > wrote: > >> > >> On Wed, Apr 3, 2024 at 2:11 PM Akihiko Odaki > >> wrote: > >>> > >>> vhost requires eBPF for RSS. When eBPF is not available

Re: [PATCH 0/3] Remove useless architecture prefix from the CPU list

2024-04-20 Thread David Hildenbrand
On 20.04.24 07:46, Thomas Huth wrote: Printing an architecture prefix in front of each CPU name is not helpful at all: It is confusing for the users since they don't know whether they have to specify these letters for the "-cpu" parameter, too, and it also takes some precious space in the dense o

Re: [PATCH 5/8] target/ppc: Move multiply fixed-point insns (64-bit operands) to decodetree.

2024-04-20 Thread Richard Henderson
On 4/19/24 02:25, Chinmay Rath wrote: Hi Richard, On 4/17/24 00:06, Richard Henderson wrote: On 4/15/24 23:39, Chinmay Rath wrote: +static bool trans_MADDHDU(DisasContext *ctx, arg_MADDHDU *a) ... +    tcg_gen_movi_i64(t1, 0); Drop the movi. +    tcg_gen_add2_i64(t1, cpu_gpr[a->vrt], lo,

Re: [PATCH] target/riscv: Use get_address() to get address with Zicbom extensions

2024-04-20 Thread Richard Henderson
On 4/19/24 04:05, Philippe Mathieu-Daudé wrote: We need to use get_address() to get an address from cpu_gpr[], since $zero is "special" (NULL). Fixes: e05da09b7c ("target/riscv: implement Zicbom extension") Reported-by: Zhiwei Jiang (姜智伟) Signed-off-by: Philippe Mathieu-Daudé --- target/riscv/

Re: [PATCH 0/3] Remove useless architecture prefix from the CPU list

2024-04-20 Thread Richard Henderson
On 4/19/24 22:46, Thomas Huth wrote: Thomas Huth (3): target/i386/cpu: Remove "x86" prefix from the CPU list target/s390x/cpu_models: Rework the output of "-cpu help" target/ppc/cpu_init: Remove "PowerPC" prefix from the CPU list Reviewed-by: Richard Henderson r~

Re: [PATCH v2 0/4] Sparc CPU naming and help text improvements

2024-04-20 Thread Richard Henderson
On 4/19/24 01:48, Thomas Huth wrote: Thomas Huth (4): target/sparc/cpu: Rename the CPU models with a "+" in their names target/sparc/cpu: Avoid spaces by default in the CPU names docs/system/target-sparc: Improve the Sparc documentation docs/about: Deprecate the old "UltraSparc" CPU n

Re: [PATCH] tests/unit: Remove debug statements in test-nested-aio-poll.c

2024-04-20 Thread Richard Henderson
On 4/19/24 01:58, Philippe Mathieu-Daudé wrote: We are running this test since almost a year; it is safe to remove its debug statements, which clutter CI jobs output: ▶ 88/100 /nested-aio-poll OK io_read 0x16bb26158 io_poll_true 0x16bb26158 > io_poll_ready io

Re: [PATCH 0/3] Remove useless architecture prefix from the CPU list

2024-04-20 Thread Michael Tokarev
20.04.2024 08:46, Thomas Huth: Printing an architecture prefix in front of each CPU name is not helpful at all: It is confusing for the users since they don't know whether they have to specify these letters for the "-cpu" parameter, too, and it also takes some precious space in the dense output o

Re: [PATCH 2/3] target/arm: Refactor default generic timer frequency handling

2024-04-20 Thread Richard Henderson
On 4/19/24 11:46, Peter Maydell wrote: The generic timer frequency is settable by board code via a QOM property "cntfrq", but otherwise defaults to 62.5MHz. The way this is done includes some complication resulting from how this was originally a fixed value with no QOM property. Clean it up:

Re: [PATCH 3/3] target/arm: Default to 1GHz cntfrq for 'max' and new CPUs

2024-04-20 Thread Richard Henderson
On 4/19/24 11:46, Peter Maydell wrote: In previous versions of the Arm architecture, the frequency of the generic timers as reported in CNTFRQ_EL0 could be any IMPDEF value, and for QEMU we picked 62.5MHz, giving a timer tick period of 16ns. In Armv8.6, the architecture standardized this frequenc

xlnx-versal-virt machine in qemu

2024-04-20 Thread abhijeet rajmane
Hi, I have booted up the xlnx-versal-virt machine using qemu-system-aarch64. I wanted to work with can device that has been modelled with this device. I have used the xilinx_can.c driver for this device and can see two can controllers. The problem is I am not able to see any interrupts in /proc/int

Re: cross-i686-tci CI job is flaky again (timeouts): can somebody who cares about TCI investigate?

2024-04-20 Thread Stefan Weil via
Am 16.04.24 um 14:17 schrieb Stefan Weil: Am 16.04.24 um 14:10 schrieb Peter Maydell: The cross-i686-tci job is flaky again, with persistent intermittent failures due to jobs timing out. [...] Some of these timeouts are very high -- no test should be taking 10 minutes, even given TCI and a sl

Re: [PATCH v7 00/12] Enabling DCD emulation support in Qemu

2024-04-20 Thread Gregory Price
On Fri, Apr 19, 2024 at 11:43:14AM -0700, fan wrote: > On Fri, Apr 19, 2024 at 02:24:36PM -0400, Gregory Price wrote: > > > > added review to all patches, will hopefully be able to add a Tested-by > > tag early next week, along with a v1 RFC for MHD bit-tracking. > > > > We've been testing v5/v6

Re: [PATCH 01/24] exec: Declare MMUAccessType type in 'mmu-access-type.h' header

2024-04-20 Thread Richard Henderson
On 4/18/24 12:25, Philippe Mathieu-Daudé wrote: The MMUAccessType enum is declared in "hw/core/cpu.h". "hw/core/cpu.h" contains declarations related to CPUState and CPUClass. Some source files only require MMUAccessType and don't need to pull in all CPU* declarations. In order to simplify, create

Re: [PATCH 02/24] exec: Declare CPUBreakpoint/CPUWatchpoint type in 'breakpoint.h' header

2024-04-20 Thread Richard Henderson
On 4/18/24 12:25, Philippe Mathieu-Daudé wrote: The CPUBreakpoint and CPUWatchpoint structures are declared in "hw/core/cpu.h", which contains declarations related to CPUState and CPUClass. Some source files only require the BP/WP definitions and don't need to pull in all CPU* API. In order to si

Re: [PATCH 03/24] hw/core: Avoid including the full 'hw/core/cpu.h' in 'tcg-cpu-ops.h'

2024-04-20 Thread Richard Henderson
On 4/18/24 12:25, Philippe Mathieu-Daudé wrote: Only include what is required, avoiding the full CPUState API from the huge "hw/core/cpu.h" header. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/tcg-cpu-ops.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by:

Re: [PATCH 04/24] exec: Restrict TCG specific declarations of 'cputlb.h'

2024-04-20 Thread Richard Henderson
On 4/18/24 12:25, Philippe Mathieu-Daudé wrote: Avoid TCG specific declarations being used from non-TCG accelerators. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/cputlb.h | 5 + 1 file changed, 5 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH] target/arm: fix MPIDR value for ARM CPUs with SMT

2024-04-20 Thread Richard Henderson
On 4/19/24 11:31, Dorjoy Chowdhury wrote: + +/* + * Instantiate a temporary CPU object to build mp_affinity + * of the possible CPUs. + */ +cpuobj = object_new(ms->cpu_type); +armcpu = ARM_CPU(cpuobj); + for (n = 0; n < ms->possible_cpus->len; n++) { ms->po