Re: [PATCH v4] target/riscv: Implement dynamic establishment of custom decoder

2024-04-02 Thread Huang Tao
This is a ping to the patch below. https://patchew.org/QEMU/20240314092158.65866-1-eric.hu...@linux.alibaba.com/ On 2024/3/14 17:21, Huang Tao wrote: In this patch, we modify the decoder to be a freely composable data structure instead of a hardcoded one. It can be dynamically builded up accord

Re: [PATCH 0/2] P11 support for QEMU

2024-04-02 Thread Aditya Gupta
Hello Cédric, > > > <...snip...> > > > > > > Please run ./scripts/get_maintainer.pl when sending a series. qemu-ppc > > > should be > > > in Cc: > > > > Tried it now, For some reason, get_maintainer.pl shows no maintainers: > > > > $ ./scripts/get_maintainer.pl -f > > 0002-ppc-powernv11-

Re: [PATCH v3] target/riscv: Fix the element agnostic function problem

2024-04-02 Thread Huang Tao
This is a ping to the patch below. https://patchew.org/QEMU/20240325021654.6594-1-eric.hu...@linux.alibaba.com/ On 2024/3/25 10:16, Huang Tao wrote: In RVV and vcrypto instructions, the masked and tail elements are set to 1s using vext_set_elems_1s function if the vma/vta bit is set. It is t

RE: [PATCH] migration: Yield coroutine when receiving MIG_CMD_POSTCOPY_LISTEN

2024-04-02 Thread Wang, Wei W
On Tuesday, April 2, 2024 12:13 AM, Peter Xu wrote: > On Fri, Mar 29, 2024 at 08:54:07AM +, Wang, Wei W wrote: > > On Friday, March 29, 2024 11:32 AM, Wang, Lei4 wrote: > > > When using the post-copy preemption feature to perform post-copy > > > live migration, the below scenario could lead to

RE: [PATCH] migration: Yield coroutine when receiving MIG_CMD_POSTCOPY_LISTEN

2024-04-02 Thread Wang, Wei W
On Tuesday, April 2, 2024 2:56 PM, Wang, Lei4 wrote: > On 4/2/2024 0:13, Peter Xu wrote:> On Fri, Mar 29, 2024 at 08:54:07AM +, > Wang, Wei W wrote: > >> On Friday, March 29, 2024 11:32 AM, Wang, Lei4 wrote: > >>> When using the post-copy preemption feature to perform post-copy > >>> live migra

[PATCH 0/1] Solve zero page causing multiple page faults

2024-04-02 Thread Yuan Liu
1. Description of multiple page faults for received zero pages a. -mem-prealloc feature and hugepage backend are not enabled on the destination b. After receiving the zero pages, the destination first determines if the current page content is 0 via buffer_is_zero, this may cau

[PATCH 1/1] migration/multifd: solve zero page causing multiple page faults

2024-04-02 Thread Yuan Liu
Implemented recvbitmap tracking of received pages in multifd. If the zero page appears for the first time in the recvbitmap, this page is not checked and set. If the zero page has already appeared in the recvbitmap, there is no need to check the data but directly set the data to 0, because it is

RE: [PATCH 0/1] Solve zero page causing multiple page faults

2024-04-02 Thread Liu, Yuan1
> -Original Message- > From: Liu, Yuan1 > Sent: Monday, April 1, 2024 11:41 PM > To: pet...@redhat.com; faro...@suse.de > Cc: qemu-devel@nongnu.org; hao.xi...@bytedance.com; > bryan.zh...@bytedance.com; Liu, Yuan1 ; Zou, Nanhai > > Subject: [PATCH 0/1] Solve zero page causing multiple pag

Re: [PATCH for-9.0] tests/qtest: Fix STM32L4x5 GPIO test on 32-bit

2024-04-02 Thread Cédric Le Goater
On 3/29/24 13:50, Philippe Mathieu-Daudé wrote: Hi Cédric, Thomas, On 29/3/24 10:27, Cédric Le Goater wrote: The test mangles the GPIO address and the pin number in the qtest_add_data_func data parameter. Doing so, it assumes that the host pointer size is always 64-bit, which breaks on 32-bit :

[PATCH] hw/i386/acpi: Set PCAT_COMPAT bit only when pic is not disabled

2024-04-02 Thread Xiaoyao Li
Set MADT.FLAGS[bit 0].PCAT_COMPAT based on x86ms->pic. Signed-off-by: Xiaoyao Li --- hw/i386/acpi-common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/i386/acpi-common.c b/hw/i386/acpi-common.c index 20f19269da40..0cc2919bb851 100644 --- a/hw/i386/acpi-common.c +++

Re: [PATCH 0/2] P11 support for QEMU

2024-04-02 Thread Cédric Le Goater
On 4/2/24 09:00, Aditya Gupta wrote: Hello Cédric, <...snip...> Please run ./scripts/get_maintainer.pl when sending a series. qemu-ppc should be in Cc: Tried it now, For some reason, get_maintainer.pl shows no maintainers: $ ./scripts/get_maintainer.pl -f 0002-ppc-powernv11-add-base-

Re: vhost-user-blk reconnect issue

2024-04-02 Thread Li Feng
Hi, I tested it today and there is indeed a problem in this scenario. It seems that the first version of the patch is the best and can handle all scenarios. With this patch, the previously merged patches are no longer useful. I will revert this patch and submit a new fix. Do you have any comme

Re: [PATCH v2 1/1] nbd/server: do not poll within a coroutine context

2024-04-02 Thread Zhu Yangyang via
On Mon, 1 Apr 2024 11:33:09AM -0500, Eric Blake wrote: > On Mon, Apr 01, 2024 at 08:41:20PM +0800, Zhu Yangyang wrote: > > Coroutines are not supposed to block. Instead, they should yield. > > > > Fixes: f95910f ("nbd: implement TLS support in the protocol negotiation") > > Signed-off-by: Zhu Yang

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-04-02 Thread Gerd Hoffmann
On Fri, Mar 29, 2024 at 10:19:09AM +, Bernhard Beschow wrote: > > In theory you could pass `-M acpi=off` to not instantiate the PIIX4 > ACPI function, essentially turning the Frankenstein-PIIX4 SB into a > PIIX3. However, this also removes SMI registers used by SeaBIOS to > handle SMM setup wh

Re: [PATCH for-9.0] tests/qtest: Fix STM32L4x5 GPIO test on 32-bit

2024-04-02 Thread Peter Maydell
On Fri, 29 Mar 2024 at 09:28, Cédric Le Goater wrote: > > The test mangles the GPIO address and the pin number in the > qtest_add_data_func data parameter. Doing so, it assumes that the host > pointer size is always 64-bit, which breaks on 32-bit : > > ../tests/qtest/stm32l4x5_gpio-test.c: In func

Re: [PATCH 06/19] block/stream: fix -Werror=maybe-uninitialized false-positives

2024-04-02 Thread Marc-André Lureau
Hi On Fri, Mar 29, 2024 at 12:35 PM Vladimir Sementsov-Ogievskiy wrote: > > On 28.03.24 13:20, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > ../block/stream.c:193:19: error: ‘unfiltered_bs’ may be used uninitialized > > [-Werror=maybe-uninitialized] > > ../block/stream.

Re: [PATCH] raspi4b: Reduce RAM to 1Gb on 32-bit hosts

2024-04-02 Thread Peter Maydell
On Fri, 29 Mar 2024 at 15:02, Cédric Le Goater wrote: > > Change the board revision number and RAM size to 1Gb on 32-bit hosts. > On these systems, RAM has a 2047 MB limit and this breaks the tests. > > Fixes: 7785e8ea2204 ("hw/arm: Introduce Raspberry PI 4 machine") > Signed-off-by: Cédric Le Goa

Re: [PATCH 1/2] CXL/cxl_type3: add first_dvsec_offset() helper

2024-04-02 Thread Jonathan Cameron via
On Tue, 2 Apr 2024 09:46:46 +0800 Li Zhijian wrote: > It helps to figure out where the first dvsec register is located. In > addition, replace offset and size hardcore with existing macros. > > Signed-off-by: Li Zhijian I agree we should be using the macros. The offset calc is a bit specific

Re: [PATCH 2/2] CXL/cxl_type3: reset DVSEC CXL Control in ct3d_reset

2024-04-02 Thread Jonathan Cameron via
On Tue, 2 Apr 2024 09:46:47 +0800 Li Zhijian wrote: > After the kernel commit > 0cab68720598 ("cxl/pci: Fix disabling memory if DVSEC CXL Range does not > match a CFMWS window") Fixes tag seems appropriate. > CXL type3 devices cannot be enabled again after the reboot because this > flag was n

Re: [PATCH 09/19] hw/sdhci: fix -Werror=maybe-uninitialized false-positive

2024-04-02 Thread Marc-André Lureau
Hi On Thu, Mar 28, 2024 at 3:31 PM Philippe Mathieu-Daudé wrote: > > On 28/3/24 11:20, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > ../hw/sd/sdhci.c:846:16: error: ‘res’ may be used uninitialized > > [-Werror=maybe-uninitialized] > > > > False-positive, because "length

Re: [PATCH v6 1/2] qga: Refactor common functions between POSIX and Windows implementation

2024-04-02 Thread Philippe Mathieu-Daudé
On 29/3/24 16:31, aidan_le...@selinc.com wrote: From: aidaleuc "In preparation of a Windows implementation, move the non-POSIX specific code to commands-common-ssh." Signed-off-by: aidaleuc As in v5 (https://lore.kernel.org/qemu-devel/63600417-9187-4d0b-8bcc-db7e965ff...@linaro.org/):

Re: [PATCH v6 1/2] qga: Refactor common functions between POSIX and Windows implementation

2024-04-02 Thread Konstantin Kostiuk
On Tue, Apr 2, 2024 at 12:23 PM Philippe Mathieu-Daudé wrote: > On 29/3/24 16:31, aidan_le...@selinc.com wrote: > > From: aidaleuc > > > > "In preparation of a Windows implementation, move the > non-POSIX specific code to commands-common-ssh." > > > Signed-off-by: aidaleuc > > As in v5 > ( >

Re: [PATCH] migration: Yield coroutine when receiving MIG_CMD_POSTCOPY_LISTEN

2024-04-02 Thread Wang, Lei
On 4/2/2024 15:25, Wang, Wei W wrote:> On Tuesday, April 2, 2024 2:56 PM, Wang, Lei4 wrote: >> On 4/2/2024 0:13, Peter Xu wrote:> On Fri, Mar 29, 2024 at 08:54:07AM +, >> Wang, Wei W wrote: On Friday, March 29, 2024 11:32 AM, Wang, Lei4 wrote: > When using the post-copy preemption feat

[PULL 1/4] usb-audio: Fix invalid values in AudioControl descriptors

2024-04-02 Thread Michael Tokarev
From: Joonas Kankaala This fixes the invalid bInterfaceProtocol value 0x04 in the USB audio AudioControl descriptors. It should be zero. While Linux and Windows forgive this error, macOS 14 Sonoma does not. The usb-audio device does not appear in macOS sound settings even though the device is rec

[PULL 2/4] fpu/softfloat: Remove mention of TILE-Gx target

2024-04-02 Thread Michael Tokarev
From: Philippe Mathieu-Daudé TILE-Gx has been removed during the v6.0 release (see commit 2cc1a90166 "Remove deprecated target tilegx"), no need to mention it in the list of "supported targets". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Revi

[PULL 3/4] Fix some typos in documentation (found by codespell)

2024-04-02 Thread Michael Tokarev
From: Stefan Weil via Signed-off-by: Stefan Weil Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- docs/devel/atomics.rst | 2 +- docs/devel/ci-jobs.rst.inc | 2 +- docs/devel/clocks.rst | 2 +- docs/system/i386/sgx.rst | 2 +- qapi/qom.json | 2 +- 5 fil

[PULL 4/4] hmp: Add help information for watchdog action: inject-nmi

2024-04-02 Thread Michael Tokarev
From: Dayu Liu virsh qemu-monitor-command --hmp help information of watchdog_action missing inject-nmi which already supported in Commit 795dc6e4 Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2247 Signed-off-by: Dayu Liu Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev [M

[PULL 0/4] Trivial patches for 2024-04-02

2024-04-02 Thread Michael Tokarev
The following changes since commit 6af9d12c88b9720f209912f6e4b01fefe5906d59: Merge tag 'migration-20240331-pull-request' of https://gitlab.com/peterx/qemu into staging (2024-04-01 13:12:40 +0100) are available in the Git repository at: https://gitlab.com/mjt0k/qemu.git tags/pull-trivial-pat

Re: [RFC PATCH-for-9.1 14/21] system: Introduce QMP generic_query_cpu_definitions()

2024-04-02 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Hi Markus, > > On 26/3/24 14:28, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> Each target use a common template for qmp_query_cpu_definitions(). >>> >>> Extract it as generic_query_cpu_definitions(), keeping the >>> target-specific implement

Re: Fast booting q35 VM?

2024-04-02 Thread Philippe Mathieu-Daudé
Cc'ing qemu-devel@ On 30/3/24 10:00, Paul Menzel wrote: Dear Linux folks, Starting a QEMU q35 with Linux built with `make defconfig`     qemu7-system-x86_64 -M q35 -m 32G -enable-kvm -cpu host -smp cpus=32 -device virtio-rng-pci -net nic,model=virtio-net-pci -net user,hostfwd=tcp::22230-:2

Re: [PATCH 4/4] linux-user/syscall: do_setsockopt(): eliminate goto in switch for SO_SNDTIMEO

2024-04-02 Thread Philippe Mathieu-Daudé
On 31/3/24 12:07, Michael Tokarev wrote: There's identical code for SO_SNDTIMEO and SO_RCVTIMEO, currently implemented using an ugly goto into another switch case. Eliminate that using arithmetic if, making code flow more natural. Signed-off-by: Michael Tokarev --- linux-user/syscall.c | 11

Re: [PATCH] lsi53c895a: avoid out of bounds access to s->msg[]

2024-04-02 Thread Philippe Mathieu-Daudé
On 31/3/24 20:17, Paolo Bonzini wrote: If no bytes are there to process in the message in phase, the input data latch (s->sidl) is set to s->msg[-1]. Just do nothing since no DMA is performed. Reported-by: Chuhong Yuan Signed-off-by: Paolo Bonzini --- hw/scsi/lsi53c895a.c | 19 -

Re: Patch for qemu-project/qemu#2247 issue

2024-04-02 Thread Philippe Mathieu-Daudé
On 1/4/24 18:52, Michael Tokarev wrote: 01.04.2024 12:43, liu.d...@zte.com.cn wrote: hmp: Add help information for watchdog action: inject-nmi virsh qemu-monitor-command --hmp help information of watchdog_action missing inject-nmi which already supported in Commit 795dc6e4 Signed-off-by: Day

Re: Patch for qemu-project/qemu#2247 issue

2024-04-02 Thread Michael Tokarev
02.04.2024 12:50, Philippe Mathieu-Daudé пишет: On 1/4/24 18:52, Michael Tokarev wrote: 01.04.2024 12:43, liu.d...@zte.com.cn wrote: hmp: Add help information for watchdog action: inject-nmi virsh qemu-monitor-command --hmp help information of watchdog_action missing inject-nmi which already

Re: [PATCH 06/19] block/stream: fix -Werror=maybe-uninitialized false-positives

2024-04-02 Thread Vladimir Sementsov-Ogievskiy
On 02.04.24 12:12, Marc-André Lureau wrote: Hi On Fri, Mar 29, 2024 at 12:35 PM Vladimir Sementsov-Ogievskiy wrote: On 28.03.24 13:20, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau ../block/stream.c:193:19: error: ‘unfiltered_bs’ may be used uninitialized [-Werror=maybe-unini

Re: [PATCH] hw/i386/acpi: Set PCAT_COMPAT bit only when pic is not disabled

2024-04-02 Thread Michael S. Tsirkin
On Tue, Apr 02, 2024 at 04:25:16AM -0400, Xiaoyao Li wrote: > Set MADT.FLAGS[bit 0].PCAT_COMPAT based on x86ms->pic. > > Signed-off-by: Xiaoyao Li Please include more info in the commit log: what is the behaviour you observe, why it is wrong, how does the patch fix it, what is guest behaviour be

[PULL 4/5] tests/qtest: Fix STM32L4x5 GPIO test on 32-bit

2024-04-02 Thread Peter Maydell
From: Cédric Le Goater The test mangles the GPIO address and the pin number in the qtest_add_data_func data parameter. Doing so, it assumes that the host pointer size is always 64-bit, which breaks on 32-bit : ../tests/qtest/stm32l4x5_gpio-test.c: In function ‘test_gpio_output_mode’: ../tests/qt

[PULL 0/5] target-arm queue

2024-04-02 Thread Peter Maydell
ging (2024-04-01 13:12:40 +0100) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20240402 for you to fetch changes up to 393770d7a02135e7468018f52da610712f151ec0: raspi4b: Reduce RAM to 1Gb on 32-bit hosts (2024-04-02 10:1

[PULL 3/5] hw/intc/arm_gicv3: ICC_HPPIR* return SPURIOUS if int group is disabled

2024-04-02 Thread Peter Maydell
If the group of the highest priority pending interrupt is disabled via ICC_IGRPEN*, the ICC_HPPIR* registers should return INTID_SPURIOUS, not the interrupt ID. (See the GIC architecture specification pseudocode functions ICC_HPPIR1_EL1[] and HighestPriorityPendingInterrupt().) Make HPPIR reads h

[PULL 1/5] target/arm: take HSTR traps of cp15 accesses to EL2, not EL1

2024-04-02 Thread Peter Maydell
The HSTR_EL2 register allows the hypervisor to trap AArch32 EL1 and EL0 accesses to cp15 registers. We incorrectly implemented this so they trap to EL1 when we detect the need for a HSTR trap at code generation time. (The check in access_check_cp_reg() which we do at runtime to catch traps from E

[PULL 2/5] docs: sbsa: update specs, add dt note

2024-04-02 Thread Peter Maydell
From: Marcin Juszkiewicz Hardware of sbsa-ref board is nowadays defined by both BSA and SBSA specifications. Then BBR defines firmware interface. Added note about DeviceTree data passed from QEMU to firmware. It is very minimal and provides only data we use in firmware. Added NUMA information t

[PULL 5/5] raspi4b: Reduce RAM to 1Gb on 32-bit hosts

2024-04-02 Thread Peter Maydell
From: Cédric Le Goater Change the board revision number and RAM size to 1Gb on 32-bit hosts. On these systems, RAM has a 2047 MB limit and this breaks the tests. Fixes: 7785e8ea2204 ("hw/arm: Introduce Raspberry PI 4 machine") Signed-off-by: Cédric Le Goater Message-id: 20240329150155.357043-1-

Re: [PULL 0/4] Trivial patches for 2024-04-02

2024-04-02 Thread Peter Maydell
On Tue, 2 Apr 2024 at 10:33, Michael Tokarev wrote: > > The following changes since commit 6af9d12c88b9720f209912f6e4b01fefe5906d59: > > Merge tag 'migration-20240331-pull-request' of > https://gitlab.com/peterx/qemu into staging (2024-04-01 13:12:40 +0100) > > are available in the Git reposito

Re: [PATCH 17/19] hw/nvme: fix -Werror=maybe-uninitialized

2024-04-02 Thread Klaus Jensen
On Mar 28 14:20, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > ../hw/nvme/ctrl.c:6081:21: error: ‘result’ may be used uninitialized > [-Werror=maybe-uninitialized] > > It's not obvious that 'result' is set in all code paths. When &result is > a returned argument, it's even le

[PULL 3/4] Fix some typos in documentation (found by codespell)

2024-04-02 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- docs/devel/atomics.rst | 2 +- docs/devel/ci-jobs.rst.inc | 2 +- docs/devel/clocks.rst | 2 +- docs/system/i386/sgx.rst | 2 +- qapi/qom.json | 2 +- 5 files c

[PULL v2 0/4] Trivial patches for 2024-04-02

2024-04-02 Thread Michael Tokarev
The following changes since commit 6af9d12c88b9720f209912f6e4b01fefe5906d59: Merge tag 'migration-20240331-pull-request' of https://gitlab.com/peterx/qemu into staging (2024-04-01 13:12:40 +0100) are available in the Git repository at: https://gitlab.com/mjt0k/qemu.git tags/pull-trivial-pat

Re: [PULL 0/4] Trivial patches for 2024-04-02

2024-04-02 Thread Michael Tokarev
Author: Stefan Weil via *SIGH* This happened *again*. (you'll need to tell git log "--no-mailmap" to not get confused by the mapping we have for the last time one of these slipped through...) Now this is interesting. And this is exactly why I haven't noticed it - I did pay attention to

Re: [PATCH] MAINTAINERS: Fix error-report.c entry

2024-04-02 Thread Philippe Mathieu-Daudé
On 27/3/24 12:55, Zhao Liu wrote: From: Zhao Liu The commit 15002f60f792 ("util: rename qemu-error.c to match its header name") renamed util/qemu-error.c to util/error-report.c but missed to change the corresponding entry. To avoid get_maintainer.pl failing, update the error-report.c entry. S

Re: [PATCH] block: Remove unnecessary NULL check in bdrv_pad_request()

2024-04-02 Thread Philippe Mathieu-Daudé
On 27/3/24 20:27, Kevin Wolf wrote: Coverity complains that the check introduced in commit 3f934817 suggests that qiov could be NULL and we dereference it before reaching the check. In fact, all of the callers pass a non-NULL pointer, so just remove the misleading check. Resolves: Coverity CID 1

Re: [PATCH] gpio/pca955x: Update maintainer email address

2024-04-02 Thread Philippe Mathieu-Daudé
On 28/3/24 20:49, Glenn Miles wrote: It was noticed that my linux.vnet.ibm.com address does not always work so dropping the vnet to see if that works better. Signed-off-by: Glenn Miles --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Patch queued, thanks!

Re: [PATCH] hw/xen_evtchn: Initialize flush_kvm_routes

2024-04-02 Thread Philippe Mathieu-Daudé
On 29/3/24 12:39, Artem Chernyshev wrote: In xen_evtchn_soft_reset() variable flush_kvm_routes can be used before being initialized. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Oleg Sviridov Signed-off-by: Artem Chernyshev --- hw/i386/kvm/xen_evtchn.c |

Re: [PATCH v2] linux-user/syscall: xtensa: fix ipc_perm conversion

2024-04-02 Thread Philippe Mathieu-Daudé
On 29/3/24 23:33, Max Filippov wrote: target_ipc_perm::mode and target_ipc_perm::__seq fields are 32-bit wide on xtensa and thus need to use tswap32. The issue is spotted by the libc-test http://nsz.repo.hu/git/?p=libc-test on big-endian xtensa core. Cc: qemu-sta...@nongnu.org Fixes: a3da8be5126

[PATCH 2/2] scripts/checkpatch: Do not use mailmap

2024-04-02 Thread Philippe Mathieu-Daudé
The .mailmap file fixes mistake we already did. Do not use it when running checkpatch.pl, otherwise we might commit the very same mistakes. Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- scripts/checkpatch.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) dif

[PATCH 0/2] scripts/checkpatch: Do not use mailmap and check qemu-trivial@ author

2024-04-02 Thread Philippe Mathieu-Daudé
- qemu-trivial@ is not checked - mailmap hides the mistakes we want to catch See https://lore.kernel.org/qemu-devel/60faa39d-52e8-46f1-8bd9-9d9661794...@tls.msk.ru/ Philippe Mathieu-Daudé (2): scripts/checkpatch: Avoid author email mangled by qemu-trivial@ scripts/checkpatch: Do not use mail

[PATCH 1/2] scripts/checkpatch: Avoid author email mangled by qemu-trivial@

2024-04-02 Thread Philippe Mathieu-Daudé
Commit f5177798d8 ("scripts: report on author emails that are mangled by the mailing list") added a check for qemu-devel@ list, complete with qemu-trivial@. Signed-off-by: Philippe Mathieu-Daudé --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts

Re: TCG change broke MorphOS boot on sam460ex

2024-04-02 Thread BALATON Zoltan
On Thu, 21 Mar 2024, BALATON Zoltan wrote: On 27/2/24 17:47, BALATON Zoltan wrote: Hello, Commit 18a536f1f8 (accel/tcg: Always require can_do_io) broke booting MorphOS on sam460ex (this was before 8.2.0 and I thought I've verified it before that release but apparently missed it back then). It

[PATCH for-9.0 3/4] vga: adjust dirty memory region if pel panning is active

2024-04-02 Thread Paolo Bonzini
When pel panning is active, one more byte is read from each of the VGA memory planes. This has to be accounted in the computation of region_end, otherwise vga_draw_graphic() fails an assertion: qemu-system-i386: ../system/physmem.c:946: cpu_physical_memory_snapshot_get_dirty: Assertion `start +

[PATCH for-9.0 2/4] vga: move computation of dirty memory region later

2024-04-02 Thread Paolo Bonzini
Move the computation of region_start and region_end after the value of "bits" is known. This makes it possible to distinguish modes that support horizontal pel panning from modes that do not. Signed-off-by: Paolo Bonzini --- hw/display/vga.c | 50

[PATCH for-9.0 1/4] vga: merge conditionals on shift control register

2024-04-02 Thread Paolo Bonzini
There are two sets of conditionals using the shift control bits: one to verify the palette and adjust disp_width, one to compute the "v" and "bits" variables. Merge them into one, with the extra benefit that we now have the "bits" value available early and can use it to compute region_end. Signed

[PATCH for-9.1 5/4] vga: optimize computation of dirty memory region

2024-04-02 Thread Paolo Bonzini
The depth == 0 and depth == 15 have to be special cased because width * depth / 8 does not provide the correct scanline length. However, thanks to the recent reorganization of vga_draw_graphic() the correct value of VRAM bits per pixel is available in "bits". Use it (via the same "bwidth" computat

[PATCH for-9.0 4/4] vga: do not treat horiz pel panning value of 8 as "enabled"

2024-04-02 Thread Paolo Bonzini
Horizontal pel panning bit 3 is only used in text mode. In graphics mode, it can be treated as if it was zero, thus not extending the dirty memory region. Signed-off-by: Paolo Bonzini --- hw/display/vga.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/display/vga.c b/

[PATCH for-9.1 6/4] vga: move dirty memory region code together

2024-04-02 Thread Paolo Bonzini
Take into account split screen mode close to wrap around, which is the other special case for dirty memory region computation. Signed-off-by: Paolo Bonzini --- hw/display/vga.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/display/vga.c b/hw/display/vga.c index 7

[PATCH for-9.0 0/4] vga: fix assertion failure with 4- and 16-color modes

2024-04-02 Thread Paolo Bonzini
These patches (the first three especially) fix an assertion failure introduced by horizontal pel panning support in VGA. The assertion triggers with legacy 4- and 16-color modes, due to a mismatch between the addresses visited by vga_draw_graphic() and the region that is passed to memory_region_sn

Re: [PATCH v3 10/17] esp.c: don't assert() if FIFO empty when executing non-DMA SELATNS

2024-04-02 Thread Philippe Mathieu-Daudé
On 25/3/24 13:57, Mark Cave-Ayland wrote: On 25/03/2024 10:49, Philippe Mathieu-Daudé wrote: On 24/3/24 20:16, Mark Cave-Ayland wrote: The current logic assumes that at least 1 byte is present in the FIFO when executing a non-DMA SELATNS command, but this may not be the case if the guest exec

Re: [PATCH v3 12/17] esp.c: prevent cmdfifo overflow in esp_cdb_ready()

2024-04-02 Thread Philippe Mathieu-Daudé
On 25/3/24 13:41, Mark Cave-Ayland wrote: On 25/03/2024 10:26, Philippe Mathieu-Daudé wrote: On 24/3/24 20:17, Mark Cave-Ayland wrote: During normal use the cmdfifo will never wrap internally and cmdfifo_cdb_offset will always indicate the start of the SCSI CDB. However it is possible that a

Re: [PATCH v3 11/17] esp.c: rework esp_cdb_length() into esp_cdb_ready()

2024-04-02 Thread Philippe Mathieu-Daudé
On 24/3/24 20:17, Mark Cave-Ayland wrote: The esp_cdb_length() function is only used as part of a calculation to determine whether the cmdfifo contains an entire SCSI CDB. Rework esp_cdb_length() into a new esp_cdb_ready() function which both enables us to handle the case where scsi_cdb_length()

Re: Intention to work on GSoC project

2024-04-02 Thread Eugenio Perez Martin
On Tue, Apr 2, 2024 at 6:58 AM Sahil wrote: > > Hi, > > On Monday, April 1, 2024 11:53:11 PM IST daleyoung4...@gmail.com wrote: > > Hi, > > > > On Monday, March 25, 2024 21:20:32 CST Sahil wrote: > > > Q1. > > > Section 2.7.4 of the virtio spec [3] states that in an available > > > descriptor, the

Re: [PATCH for-9.0 1/4] vga: merge conditionals on shift control register

2024-04-02 Thread Philippe Mathieu-Daudé
On 2/4/24 13:34, Paolo Bonzini wrote: There are two sets of conditionals using the shift control bits: one to verify the palette and adjust disp_width, one to compute the "v" and "bits" variables. Merge them into one, with the extra benefit that we now have the "bits" value available early and c

Re: [PULL 0/4] Trivial patches for 2024-04-02

2024-04-02 Thread Peter Maydell
On Tue, 2 Apr 2024 at 11:41, Michael Tokarev wrote: > > > > Author: Stefan Weil via > > *SIGH* This happened *again*. > > > (you'll need to tell git log "--no-mailmap" to not get confused > > by the mapping we have for the last time one of these slipped > > through...) > > Now this is interestin

Re: [PATCH for-9.0 2/4] vga: move computation of dirty memory region later

2024-04-02 Thread Philippe Mathieu-Daudé
On 2/4/24 13:34, Paolo Bonzini wrote: Move the computation of region_start and region_end after the value of "bits" is known. This makes it possible to distinguish modes that support horizontal pel panning from modes that do not. Signed-off-by: Paolo Bonzini --- hw/display/vga.c | 50 +++

Re: [PATCH for-9.0 3/4] vga: adjust dirty memory region if pel panning is active

2024-04-02 Thread Philippe Mathieu-Daudé
On 2/4/24 13:34, Paolo Bonzini wrote: When pel panning is active, one more byte is read from each of the VGA memory planes. This has to be accounted in the computation of region_end, otherwise vga_draw_graphic() fails an assertion: qemu-system-i386: ../system/physmem.c:946: cpu_physical_memory_

Re: [PATCH 1/2] scripts/checkpatch: Avoid author email mangled by qemu-trivial@

2024-04-02 Thread Philippe Mathieu-Daudé
On 2/4/24 13:52, Peter Maydell wrote: On Tue, 2 Apr 2024 at 12:30, Philippe Mathieu-Daudé wrote: Commit f5177798d8 ("scripts: report on author emails that are mangled by the mailing list") added a check for qemu-devel@ list, complete with qemu-trivial@. Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH 1/2] scripts/checkpatch: Avoid author email mangled by qemu-trivial@

2024-04-02 Thread Philippe Mathieu-Daudé
On 2/4/24 13:53, Philippe Mathieu-Daudé wrote: On 2/4/24 13:52, Peter Maydell wrote: On Tue, 2 Apr 2024 at 12:30, Philippe Mathieu-Daudé wrote: Commit f5177798d8 ("scripts: report on author emails that are mangled by the mailing list") added a check for qemu-devel@ list, complete with qemu-tr

Re: [PULL 0/5] target-arm queue

2024-04-02 Thread Peter Maydell
Merge tag 'migration-20240331-pull-request' of > https://gitlab.com/peterx/qemu into staging (2024-04-01 13:12:40 +0100) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/p

[PATCH v2 0/2] scripts/checkpatch: Do not use mailmap and check qemu-trivial@ author

2024-04-02 Thread Philippe Mathieu-Daudé
Since v1: - Extend regexp to cover all lists (Peter) * qemu-trivial@ is not checked * mailmap hides the mistakes we want to catch See https://lore.kernel.org/qemu-devel/60faa39d-52e8-46f1-8bd9-9d9661794...@tls.msk.ru/ Philippe Mathieu-Daudé (2): scripts/checkpatch: Avoid author email mangled

Re: [PATCH 1/2] scripts/checkpatch: Avoid author email mangled by qemu-trivial@

2024-04-02 Thread Peter Maydell
On Tue, 2 Apr 2024 at 12:30, Philippe Mathieu-Daudé wrote: > > Commit f5177798d8 ("scripts: report on author emails > that are mangled by the mailing list") added a check > for qemu-devel@ list, complete with qemu-trivial@. > > Signed-off-by: Philippe Mathieu-Daudé > --- > scripts/checkpatch.pl

[PATCH v2 2/2] scripts/checkpatch: Do not use mailmap

2024-04-02 Thread Philippe Mathieu-Daudé
The .mailmap file fixes mistake we already did. Do not use it when running checkpatch.pl, otherwise we might commit the very same mistakes. Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- scripts/checkpatch.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) dif

[PATCH v2 1/2] scripts/checkpatch: Avoid author email mangled by qemu-*@nongnu.org

2024-04-02 Thread Philippe Mathieu-Daudé
Commit f5177798d8 ("scripts: report on author emails that are mangled by the mailing list") added a check for qemu-devel@ list, extend the regexp to cover more such qemu-trivial@, qemu-block@ and qemu-ppc@. Signed-off-by: Philippe Mathieu-Daudé --- scripts/checkpatch.pl | 2 +- 1 file changed, 1

Re: [PATCH v2 6/7] vdpa: move iova_tree allocation to net_vhost_vdpa_init

2024-04-02 Thread Eugenio Perez Martin
On Tue, Apr 2, 2024 at 8:19 AM Si-Wei Liu wrote: > > > > On 2/14/2024 11:11 AM, Eugenio Perez Martin wrote: > > On Wed, Feb 14, 2024 at 7:29 PM Si-Wei Liu wrote: > >> Hi Michael, > >> > >> On 2/13/2024 2:22 AM, Michael S. Tsirkin wrote: > >>> On Mon, Feb 05, 2024 at 05:10:36PM -0800, Si-Wei Liu w

Re: [PATCH] virtio-net: fix qemu set used ring flag even vhost started

2024-04-02 Thread Philippe Mathieu-Daudé
Hi Yajun, On 2/4/24 06:51, Yajun Wu wrote: When vhost-user or vhost-kernel is handling virtio net datapath, qemu "QEMU" should not touch used ring. But with vhost-user socket reconnect scenario, in a very rare case (has pending kick event). VRING_USED_F_NO_NOTIFY is set by qemu in "QEMU"

Re: [PATCH] block: Remove unnecessary NULL check in bdrv_pad_request()

2024-04-02 Thread Kevin Wolf
Am 02.04.2024 um 12:53 hat Philippe Mathieu-Daudé geschrieben: > On 27/3/24 20:27, Kevin Wolf wrote: > > Coverity complains that the check introduced in commit 3f934817 suggests > > that qiov could be NULL and we dereference it before reaching the check. > > In fact, all of the callers pass a non-N

Re: [PATCH] virtio-net: fix qemu set used ring flag even vhost started

2024-04-02 Thread Yajun Wu
On 4/2/2024 8:11 PM, Philippe Mathieu-Daudé wrote: External email: Use caution opening links or attachments Hi Yajun, On 2/4/24 06:51, Yajun Wu wrote: When vhost-user or vhost-kernel is handling virtio net datapath, qemu "QEMU" Ack. should not touch used ring. But with vhost-user socket

Re: [PATCH 1/1] migration/multifd: solve zero page causing multiple page faults

2024-04-02 Thread Fabiano Rosas
Yuan Liu writes: > Implemented recvbitmap tracking of received pages in multifd. > > If the zero page appears for the first time in the recvbitmap, this > page is not checked and set. > > If the zero page has already appeared in the recvbitmap, there is no > need to check the data but directly se

Re: [PATCH v8] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2024-04-02 Thread Kevin Wolf
Am 29.03.2024 um 04:45 hat Shaoqin Huang geschrieben: > Hi Daniel, > > On 3/25/24 16:55, Daniel P. Berrangé wrote: > > On Mon, Mar 25, 2024 at 01:35:58PM +0800, Shaoqin Huang wrote: > > > Hi Daniel, > > > > > > Thanks for your reviewing. I see your comments in the v7. > > > > > > I have some dou

[PATCH] sh4: mac.w: memory accesses are 16-bit words

2024-04-02 Thread Zack Buhman
Before this change, executing a code sequence such as: mova tblm,r0 movr0,r1 mova tbln,r0 clrs clrmac mac.w @r0+,@r1+ mac.w @r0+,@r1+ .align 4 tblm:.word 0x1234 .word 0x5678 tbln

[PATCH] Fix incorrect disassembly format for certain RISC-V instructions

2024-04-02 Thread Simeon Krastnikov
* The immediate argument to lui/auipc should be an integer in the interval [0x0, 0xf]; e.g., 'auipc 0xf' and not 'auipc -1' * The floating-point rounding mode is the last operand to the function, not the first; e.g., 'fcvt.w.s a0, fa0, rtz' and not 'fcvt.w.s rtz, a0, fa0'. Note that fcvt.

[PATCH] Makefile: preserve --jobserver-auth argument when calling ninja

2024-04-02 Thread Martin Hundebøll
Qemu wraps its call to ninja in a Makefile. Since ninja, as opposed to make, utilizes all CPU cores by default, the qemu Makefile translates the absense of a `-jN` argument into `-j1`. This breaks jobserver functionality, so update the -jN mangling to take the --jobserver-auth argument into conside

[PULL 5/7] lsi53c895a: avoid out of bounds access to s->msg[]

2024-04-02 Thread Paolo Bonzini
If no bytes are there to process in the message in phase, the input data latch (s->sidl) is set to s->msg[-1]. Just do nothing since no DMA is performed. Reported-by: Chuhong Yuan Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- hw/scsi/lsi53c895a.c | 19 --

[PULL 7/7] pc_q35: remove unnecessary m->alias assignment

2024-04-02 Thread Paolo Bonzini
The assignment is already inherited from pc-q35-8.2. Signed-off-by: Paolo Bonzini --- hw/i386/pc_q35.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index b5922b44afa..c7bc8a2041f 100644 --- a/hw/i386/pc_q35.c +++ b/hw/i386/pc_q35.c @@ -393,7 +393,6 @@ st

[PULL 6/7] lsi53c895a: detect invalid Block Move instruction

2024-04-02 Thread Paolo Bonzini
The spec for the lsi53c895a says: "If the instruction is a Block Move and a value of 0x00 is loaded into the DBC register, an illegal instruction interrupt occurs if the LSI53C895A is not in target mode, Command phase". Because QEMU only operates in initiator mode, generate the interrupt uncon

[PULL 0/7] lsi, vga fixes for 2024-04-02

2024-04-02 Thread Paolo Bonzini
The following changes since commit b9dbf6f9bf533564f6a4277d03906fcd32bb0245: Merge tag 'pull-tcg-20240329' of https://gitlab.com/rth7680/qemu into staging (2024-03-30 14:54:57 +) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fe

[PULL 3/7] vga: adjust dirty memory region if pel panning is active

2024-04-02 Thread Paolo Bonzini
When pel panning is active, one more byte is read from each of the VGA memory planes. This has to be accounted in the computation of region_end, otherwise vga_draw_graphic() fails an assertion: qemu-system-i386: ../system/physmem.c:946: cpu_physical_memory_snapshot_get_dirty: Assertion `start +

[PULL 4/7] vga: do not treat horiz pel panning value of 8 as "enabled"

2024-04-02 Thread Paolo Bonzini
Horizontal pel panning bit 3 is only used in text mode. In graphics mode, it can be treated as if it was zero, thus not extending the dirty memory region. Signed-off-by: Paolo Bonzini --- hw/display/vga.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/display/vga.c b/

[PULL 1/7] vga: merge conditionals on shift control register

2024-04-02 Thread Paolo Bonzini
There are two sets of conditionals using the shift control bits: one to verify the palette and adjust disp_width, one to compute the "v" and "bits" variables. Merge them into one, with the extra benefit that we now have the "bits" value available early and can use it to compute region_end. Review

Re: [PATCH] hw/i386/acpi: Set PCAT_COMPAT bit only when pic is not disabled

2024-04-02 Thread Xiaoyao Li
On 4/2/2024 6:02 PM, Michael S. Tsirkin wrote: On Tue, Apr 02, 2024 at 04:25:16AM -0400, Xiaoyao Li wrote: Set MADT.FLAGS[bit 0].PCAT_COMPAT based on x86ms->pic. Signed-off-by: Xiaoyao Li Please include more info in the commit log: what is the behaviour you observe, why it is wrong, how does

[PULL 2/7] vga: move computation of dirty memory region later

2024-04-02 Thread Paolo Bonzini
Move the computation of region_start and region_end after the value of "bits" is known. This makes it possible to distinguish modes that support horizontal pel panning from modes that do not. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- hw/display/vga.c | 50 +++

Re: [PATCH] sh4: mac.w: memory accesses are 16-bit words

2024-04-02 Thread Philippe Mathieu-Daudé
On 2/4/24 11:37, Zack Buhman wrote: Before this change, executing a code sequence such as: mova tblm,r0 movr0,r1 mova tbln,r0 clrs clrmac mac.w @r0+,@r1+ mac.w @r0+,@r1+ .align 4 tblm:

Re: Patch for qemu-project/qemu#2247 issue

2024-04-02 Thread Philippe Mathieu-Daudé
On 2/4/24 11:59, Michael Tokarev wrote: 02.04.2024 12:50, Philippe Mathieu-Daudé пишет: On 1/4/24 18:52, Michael Tokarev wrote: 01.04.2024 12:43, liu.d...@zte.com.cn wrote: hmp: Add help information for watchdog action: inject-nmi virsh qemu-monitor-command --hmp help information of watchdog_

Re: [PULL v2 0/4] Trivial patches for 2024-04-02

2024-04-02 Thread Peter Maydell
On Tue, 2 Apr 2024 at 11:42, Michael Tokarev wrote: > > The following changes since commit 6af9d12c88b9720f209912f6e4b01fefe5906d59: > > Merge tag 'migration-20240331-pull-request' of > https://gitlab.com/peterx/qemu into staging (2024-04-01 13:12:40 +0100) > > are available in the Git reposito

Re: [PATCH] virtio-net: fix qemu set used ring flag even vhost started

2024-04-02 Thread Philippe Mathieu-Daudé
On 2/4/24 14:41, Yajun Wu wrote: On 4/2/2024 8:11 PM, Philippe Mathieu-Daudé wrote: External email: Use caution opening links or attachments Hi Yajun, On 2/4/24 06:51, Yajun Wu wrote: When vhost-user or vhost-kernel is handling virtio net datapath, qemu "QEMU" Ack. should not touch used

  1   2   >