On Thu, Mar 28, 2024 at 12:14 PM Jason Wang wrote:
>
> On Wed, Mar 27, 2024 at 5:44 PM Cindy Lu wrote:
> >
> > On Wed, Mar 27, 2024 at 5:13 PM Jason Wang wrote:
> > >
> > > On Wed, Mar 27, 2024 at 5:12 PM Jason Wang wrote:
> > > >
> > > > On Wed, Mar 27, 2024 at 4:28 PM Cindy Lu wrote:
> > > >
On Mon, Mar 18, 2024 at 02:20:50PM +0100, Eric Auger wrote:
> Hi Michael,
>
> On 3/13/24 12:17, Michael S. Tsirkin wrote:
> > On Wed, Mar 13, 2024 at 07:54:11AM +, Duan, Zhenzhong wrote:
> >>
> >>> -Original Message-
> >>> From: Michael S. Tsirkin
> >>> Subject: Re: [PATCH v1 3/6] int
> -Original Message-
> From: Bryan Zhang
> Sent: Wednesday, March 27, 2024 6:42 AM
> To: qemu-devel@nongnu.org
> Cc: pet...@redhat.com; faro...@suse.de; Liu, Yuan1 ;
> berra...@redhat.com; Zou, Nanhai ;
> hao.xi...@linux.dev; Bryan Zhang
> Subject: [PATCH v2 2/5] migration: Add migration
Hi MST,
I modified this patch according to your comments. Do you have any other
suggestions?
On 2024/3/25 15:07, Jiqian Chen wrote:
> In current code, when guest does S3, virtio devices are reset due to
> the bit No_Soft_Reset is not set. After resetting, the display resources
> of virtio-gpu are
Stefan, to the best of my knowledge this is fully reviewed and ready
to go in - can you kindly pick it up or advise in case there's
something I missed? Thanks!
On Mon, Mar 4, 2024 at 11:25 AM Peter Xu wrote:
>
> On Mon, Mar 04, 2024 at 02:05:49AM -0800, Mattias Nissler wrote:
> > This series adds
On Wed, Mar 27, 2024 at 6:37 PM Huang, Ying wrote:
>
> "Ho-Ren (Jack) Chuang" writes:
>
> [snip]
>
> > @@ -655,6 +672,34 @@ void mt_put_memory_types(struct list_head
> > *memory_types)
> > }
> > EXPORT_SYMBOL_GPL(mt_put_memory_types);
> >
> > +/*
> > + * This is invoked via `late_initcall()` t
On Mon, Mar 25, 2024 at 03:07:24PM +0800, Jiqian Chen wrote:
> In current code, when guest does S3, virtio devices are reset due to
> the bit No_Soft_Reset is not set. After resetting, the display resources
> of virtio-gpu are destroyed, then the display can't come back and only
> show blank after
On Thu Mar 28, 2024 at 3:31 PM AEST, Nicholas Piggin wrote:
> ppc broadcast tlb flushes should be synchronised with other vCPUs,
> like all other architectures that support such operations seem to
> be doing.
>
> Fixing ppc removes the last caller of the non-synced TLB flush
> variants, we can remo
Am 27.03.2024 um 23:13 hat Eric Blake geschrieben:
> On Mon, Mar 25, 2024 at 11:50:41AM -0400, Stefan Hajnoczi wrote:
> > On Mon, Mar 25, 2024 at 05:18:50PM +0800, zhuyangyang wrote:
> > > If g_main_loop_run()/aio_poll() is called in the coroutine context,
> > > the pending coroutine may be woken u
On 2024/3/20 0:47, Peter Maydell wrote:
> On Mon, 18 Mar 2024 at 09:37, Jinjie Ruan wrote:
>>
>> Set or clear PSTATE.ALLINT on taking an exception to ELx according to the
>> SCTLR_ELx.SPINTMASK bit.
>>
>> Signed-off-by: Jinjie Ruan
>> Reviewed-by: Richard Henderson
>> ---
>> v3:
>> - Add Revi
On 2024/3/28 16:11, Michael S. Tsirkin wrote:
>
>> +VirtIOPCIProxy *proxy = VIRTIO_PCI(dev);
>> +
>> pcie_cap_deverr_reset(dev);
>> pcie_cap_lnkctl_reset(dev);
>>
>> -pci_set_word(dev->config + dev->exp.pm_cap + PCI_PM_CTRL, 0);
>> +if (proxy->flags & V
On Wed, Mar 27, 2024 at 11:55:48AM +0100, Philippe Mathieu-Daudé wrote:
> The whole RDMA subsystem was deprecated in commit e9a54265f5
> ("hw/rdma: Deprecate the pvrdma device and the rdma subsystem")
> released in v8.2. Time to remove it.
>
> Keep the RAM_SAVE_FLAG_HOOK definition since it might
On Wednesday, March 27, 2024 3:20:09 PM CET Daniel Henrique Barboza wrote:
> Hi,
>
> In this new version we took a different approach after the discussions
> we had in [1]. The tests are now untouched, and we're addressing the root
> cause directly: the fact that we have a single temp dir for all
Vladimir Sementsov-Ogievskiy writes:
> Look at block-job-change command: we have to specify both 'id' to chose
> the job to operate on and 'type' for QAPI union be parsed. But for user
> this looks redundant: when we specify 'id', QEMU should be able to get
> corresponding job's type.
>
> This co
If a blockcommit is aborted the base image remains in RW mode, that leads
to a fail of subsequent live migration.
How to reproduce:
$ virsh snapshot-create-as vm snp1 --disk-only
*** write something to the disk inside the guest ***
$ virsh blockcommit vm vda --active --shallow && virsh blo
Vladimir Sementsov-Ogievskiy writes:
> We are going to add more parameters to change. We want to make possible
> to change only one or any subset of available options. So all the
> options should be optional.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/mirror.c | 5 +
On 3/27/24 21:52, Alex Williamson wrote:
On Wed, 27 Mar 2024 16:11:37 -0400
"Michael S. Tsirkin" wrote:
On Wed, Mar 27, 2024 at 11:39:15AM -0600, Alex Williamson wrote:
On Fri, 22 Mar 2024 12:12:10 +0530
Vinayak Kale wrote:
In case of migration, during restore operation, qemu checks con
Hello Cedric,
}
+static void pnv_phb4_fund_A_reset(PnvPHB4 *phb)
What is fund_A ?
I used 'fund_A' as an abbreviation to "Fundamental Register Set A".
Please let know if you suggest another abbreviation to name this method.
+{
+ phb->regs[PHB_LSI_SOURCE_ID >> 3] = PPC_BITMASK(4, 12)
Hi Andrew,
Can you please check the indirection table copy and ack on the patch
if the fix is correct
Thanks,
Yuri
On Wed, Mar 27, 2024 at 4:05 AM Akihiko Odaki wrote:
>
> The kernel documentation says:
> > The value stored can be of any size, however, all array elements are
> > aligned to 8 byt
Subject: all unions are type-based. Perhaps "support implicit union
tags on the wire"?
Do you need this schema language feature for folding block jobs into the
jobs abstraction, or is it just for making the wire protocol nicer in
places?
On Thu, Mar 28, 2024 at 09:02:28AM +, Chen, Jiqian wrote:
>
> On 2024/3/28 16:11, Michael S. Tsirkin wrote:
> >
> >> +VirtIOPCIProxy *proxy = VIRTIO_PCI(dev);
> >> +
> >> pcie_cap_deverr_reset(dev);
> >> pcie_cap_lnkctl_reset(dev);
> >>
> >> -pci_set_word(d
Greetings,
I am currently engaged in a project that involves emulating the LM3S811EVB
( M3 Core ) board using Xilinx QEMU (version 7.1.0) . While the emulation
process is successful, I am encountering difficulties in attaching GNU
Debugger (GDB) or GDB-multiarch to the ELF file being executed on t
On Thu, Mar 28, 2024 at 07:43:06AM +0100, Thomas Huth wrote:
> On 27/03/2024 11.55, Philippe Mathieu-Daudé wrote:
> > The whole RDMA subsystem was deprecated in commit e9a54265f5
> > ("hw/rdma: Deprecate the pvrdma device and the rdma subsystem")
> > released in v8.2. Time to remove it.
> >
> > Ke
Hi Paolo,
Just meet typos when compiling ;-)
On Mon, Mar 25, 2024 at 03:14:20PM +0100, Paolo Bonzini wrote:
> Date: Mon, 25 Mar 2024 15:14:20 +0100
> From: Paolo Bonzini
> Subject: [PATCH for-9.1 v5 1/3] hw: Add compat machines for 9.1
> X-Mailer: git-send-email 2.44.0
[snip]
> diff --git a/hw
On Thu Mar 28, 2024 at 6:12 PM AEST, Nicholas Piggin wrote:
> On Thu Mar 28, 2024 at 3:31 PM AEST, Nicholas Piggin wrote:
> > ppc broadcast tlb flushes should be synchronised with other vCPUs,
> > like all other architectures that support such operations seem to
> > be doing.
> >
> > Fixing ppc rem
On 28.03.24 12:40, Markus Armbruster wrote:
Subject: all unions are type-based. Perhaps "support implicit union
tags on the wire"?
Yes, sounds good.
Do you need this schema language feature for folding block jobs into the
jobs abstraction, or is it just for making the wire protocol nicer in
From: Marc-André Lureau
Hi,
Depending on -Doptimization=, GCC (13.2.1 here) produces different
maybe-uninitialized warnings:
- g: produces -Werror=maybe-uninitialized errors
- 0: clean build
- 1: produces -Werror=maybe-uninitialized errors
- 2: clean build
- 3: produces few -Werror=maybe-uniniti
From: Marc-André Lureau
../util/qemu-coroutine.c:150:8: error: ‘batch’ may be used uninitialized
[-Werror=maybe-uninitialized]
Signed-off-by: Marc-André Lureau
---
util/qemu-coroutine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/qemu-coroutine.c b/util/qemu-corou
From: Marc-André Lureau
../nbd/client-connection.c:419:8: error: ‘wait_co’ may be used uninitialized
[-Werror=maybe-uninitialized]
Signed-off-by: Marc-André Lureau
---
nbd/client-connection.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/nbd/client-connection.c b/nbd/cli
From: Marc-André Lureau
../hw/display/qxl.c:1352:5: error: ‘pci_region’ may be used uninitialized
[-Werror=maybe-uninitialized]
../hw/display/qxl.c:1365:22: error: ‘pci_start’ may be used uninitialized
[-Werror=maybe-uninitialized]
Signed-off-by: Marc-André Lureau
---
hw/display/qxl.c | 4 ++
From: Marc-André Lureau
../block/mirror.c:1066:22: error: ‘iostatus’ may be used uninitialized
[-Werror=maybe-uninitialized]
Signed-off-by: Marc-André Lureau
---
block/mirror.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/mirror.c b/block/mirror.c
index 1bdce3b657
From: Marc-André Lureau
../util/qemu-timer.c:198:24: error: ‘expire_time’ may be used uninitialized
[-Werror=maybe-uninitialized]
../util/qemu-timer.c:476:8: error: ‘rearm’ may be used uninitialized
[-Werror=maybe-uninitialized]
Signed-off-by: Marc-André Lureau
---
util/qemu-timer.c | 6 +++-
From: Marc-André Lureau
../hw/scsi/vhost-scsi.c:173:12: error: ‘ret’ may be used uninitialized
[-Werror=maybe-uninitialized]
It can be reached when num_queues=0. It probably doesn't make much sense
to instantiate a vhost-scsi with 0 IO queues though. For now, make
vhost_scsi_set_workers() retur
From: Marc-André Lureau
../block/stream.c:193:19: error: ‘unfiltered_bs’ may be used uninitialized
[-Werror=maybe-uninitialized]
../block/stream.c:176:5: error: ‘len’ may be used uninitialized
[-Werror=maybe-uninitialized]
trace/trace-block.h:906:9: error: ‘ret’ may be used uninitialized
[-Wer
From: Marc-André Lureau
../hw/ide/ahci.c:989:58: error: ‘tbl_entry_size’ may be used uninitialized
[-Werror=maybe-uninitialized]
Signed-off-by: Marc-André Lureau
---
hw/ide/ahci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index bfefad2
From: Marc-André Lureau
../hw/sd/sdhci.c:846:16: error: ‘res’ may be used uninitialized
[-Werror=maybe-uninitialized]
False-positive, because "length" is non-null.
Signed-off-by: Marc-André Lureau
---
hw/sd/sdhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/sd/sdh
From: Marc-André Lureau
../hw/rdma/rdma_backend.c:129:8: error: ‘ne’ may be used uninitialized
[-Werror=maybe-uninitialized]
Signed-off-by: Marc-André Lureau
---
hw/rdma/rdma_backend.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_ba
From: Marc-André Lureau
../migration/block.c:966:16: error: ‘ret’ may be used uninitialized
[-Werror=maybe-uninitialized]
Given that "cluster_size" must be <= BLK_MIG_BLOCK_SIZE, the previous
loop is entered at least once, so 'ret' is assigned a value in all conditions.
Signed-off-by: Marc-And
From: Marc-André Lureau
../migration/dirtyrate.c:186:5: error: ‘records’ may be used uninitialized
[-Werror=maybe-uninitialized]
../migration/dirtyrate.c:168:12: error: ‘gen_id’ may be used uninitialized
[-Werror=maybe-uninitialized]
../migration/migration.c:2273:5: error: ‘file’ may be used un
From: Marc-André Lureau
../migration/ram.c:1873:23: error: ‘dirty’ may be used uninitialized
[-Werror=maybe-uninitialized]
When 'block' != NULL, 'dirty' is initialized.
Signed-off-by: Marc-André Lureau
---
migration/ram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mi
From: Marc-André Lureau
../hw/block/virtio-blk.c:1212:12: error: ‘rq’ may be used uninitialized
[-Werror=maybe-uninitialized]
Signed-off-by: Marc-André Lureau
---
hw/block/virtio-blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-
From: Marc-André Lureau
../plugins/loader.c:405:15: error: ‘ctx’ may be used uninitialized
[-Werror=maybe-uninitialized]
Signed-off-by: Marc-André Lureau
---
plugins/loader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/plugins/loader.c b/plugins/loader.c
index 9768b78e
From: Marc-André Lureau
../tests/unit/test-block-iothread.c:773:17: error: ‘job’ may be used
uninitialized [-Werror=maybe-uninitialized]
/usr/include/glib-2.0/glib/gtestutils.h:73:53: error: ‘ret’ may be used
uninitialized [-Werror=maybe-uninitialized]
Signed-off-by: Marc-André Lureau
---
te
From: Marc-André Lureau
../hw/nvme/ctrl.c:6081:21: error: ‘result’ may be used uninitialized
[-Werror=maybe-uninitialized]
It's not obvious that 'result' is set in all code paths. When &result is
a returned argument, it's even less clear.
Looking at various assignments, 0 seems to be a suitabl
From: Marc-André Lureau
../hw/virtio/vhost-shadow-virtqueue.c:545:13: error: ‘r’ may be used
uninitialized [-Werror=maybe-uninitialized]
'&r' is not guaranteed to be assigned when calling -Werror=maybe-uninitialized.
Signed-off-by: Marc-André Lureau
---
hw/virtio/vhost-shadow-virtqueue.c | 2
From: Marc-André Lureau
vhost_svq_get_buf() may return a VirtQueueElement that should be freed.
It's unclear to me if the vhost_svq_get_buf() call should always return NULL.
Signed-off-by: Marc-André Lureau
---
hw/virtio/vhost-shadow-virtqueue.c | 4 +++-
1 file changed, 3 insertions(+), 1 de
Hi Daniel,
My apologies for all the missed feedback in v2.
I'll be more organized for my next iteration.
For this specific comment below, I would like to make sure I'm testing
the right way.
> > diff --git a/meson.build b/meson.build
> > index b375248a7614..376da49b60ab 100644
> > --- a/mes
Hi Hanna and Kevin,
any updates?
On Mon, Mar 11, 2024 at 02:29:25PM +0100, Markus Armbruster wrote:
> Thomas Weißschuh writes:
>
> > Only a small subset of all blockdev drivers make sense for firmware
> > images. Introduce and use a new enum to represent this.
> >
> > This also reduces the depe
> On 27 Mar 2024, at 19:43, Roy Hopkins wrote:
>
> On Wed, 2024-03-27 at 18:58 +0530, Ani Sinha wrote:
>>
>>
>>> On 27 Feb 2024, at 20:20, Roy Hopkins wrote:
>>>
>>> When using an IGVM file the configuration of the system firmware is
>>> defined by IGVM directives contained in the file. Th
Am 27.03.24 um 20:27 schrieb Kevin Wolf:
> Coverity complains that the check introduced in commit 3f934817 suggests
> that qiov could be NULL and we dereference it before reaching the check.
> In fact, all of the callers pass a non-NULL pointer, so just remove the
> misleading check.
>
> Resolves:
On 3/28/24 14:20, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
../plugins/loader.c:405:15: error: ‘ctx’ may be used uninitialized
[-Werror=maybe-uninitialized]
Signed-off-by: Marc-André Lureau
---
plugins/loader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
On Thu Mar 28, 2024 at 8:15 PM AEST, Nicholas Piggin wrote:
> On Thu Mar 28, 2024 at 6:12 PM AEST, Nicholas Piggin wrote:
> > On Thu Mar 28, 2024 at 3:31 PM AEST, Nicholas Piggin wrote:
> > > ppc broadcast tlb flushes should be synchronised with other vCPUs,
> > > like all other architectures that
Hi all,
This is the v8 patch to support S3.
v8 makes below changes:
* Add a new patch#1 to fix a problem import by
27ce0f3afc9dd25d21b43bbce505157afd93d111,
the right action is that only the state of PM_CTRL can be clear when
resetting.
* patch#2 is the original patch to implement No_Soft_Reset
In current code, when guest does S3, virtio devices are reset due to
the bit No_Soft_Reset is not set. After resetting, the display resources
of virtio-gpu are destroyed, then the display can't come back and only
show blank after resuming.
Implement No_Soft_Reset bit of PCI_PM_CTRL register, then
Fix bug imported by 27ce0f3afc9dd25d21b43bbce505157afd93d111
(fix Power Management Control Register for PCI Express virtio devices)
Only state of PM_CTRL is writable.
Only when flag VIRTIO_PCI_FLAG_INIT_PM is set, need to reset state.
Signed-off-by: Jiqian Chen
---
hw/virtio/virtio-pci.c | 8 ++
On 28.03.24 12:15, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Look at block-job-change command: we have to specify both 'id' to chose
the job to operate on and 'type' for QAPI union be parsed. But for user
this looks redundant: when we specify 'id', QEMU should be able to ge
On Thu, Mar 28, 2024 at 11:27:50AM +0100, Anthony Harivel wrote:
> Hi Daniel,
>
> My apologies for all the missed feedback in v2.
> I'll be more organized for my next iteration.
>
> For this specific comment below, I would like to make sure I'm testing
> the right way.
>
> > > diff --git a/
On Thu, 28 Mar 2024 at 08:57, Jinjie Ruan via wrote:
>
>
>
> On 2024/3/20 0:47, Peter Maydell wrote:
> > On Mon, 18 Mar 2024 at 09:37, Jinjie Ruan wrote:
> >>
> >> Set or clear PSTATE.ALLINT on taking an exception to ELx according to the
> >> SCTLR_ELx.SPINTMASK bit.
> >>
> >> Signed-off-by: Jinj
BTW, if I download qemu8.0(https://download.qemu.org/qemu-8.0.0.tar.xz),
compile and install it in my ubuntu22.04, launch vm with the same
command(just update --machine to be "pc"), the host cpu usage is not
high, it seems to be a bug in QEMU6
Also, I have another question, for disk iotune or
On 28.03.24 12:24, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
We are going to add more parameters to change. We want to make possible
to change only one or any subset of available options. So all the
options should be optional.
Signed-off-by: Vladimir Sementsov-Ogievskiy
-
On Thu, Mar 28, 2024 at 06:39:03PM +0800, Jiqian Chen wrote:
> In current code, when guest does S3, virtio devices are reset due to
> the bit No_Soft_Reset is not set. After resetting, the display resources
> of virtio-gpu are destroyed, then the display can't come back and only
> show blank after
> On 28 Mar 2024, at 16:04, Ani Sinha wrote:
>
>
>
>> On 27 Mar 2024, at 19:43, Roy Hopkins wrote:
>>
>> On Wed, 2024-03-27 at 18:58 +0530, Ani Sinha wrote:
>>>
>>>
On 27 Feb 2024, at 20:20, Roy Hopkins wrote:
When using an IGVM file the configuration of the system firmw
On 27/3/24 20:27, Kevin Wolf wrote:
Coverity complains that the check introduced in commit 3f934817 suggests
that qiov could be NULL and we dereference it before reaching the check.
In fact, all of the callers pass a non-NULL pointer, so just remove the
misleading check.
Resolves: Coverity CID 1
On 28/3/24 11:20, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
../hw/sd/sdhci.c:846:16: error: ‘res’ may be used uninitialized
[-Werror=maybe-uninitialized]
False-positive, because "length" is non-null.
Signed-off-by: Marc-André Lureau
---
hw/sd/sdhci.c | 2 +-
1 file chang
On 2024/3/28 18:57, Michael S. Tsirkin wrote:
> On Thu, Mar 28, 2024 at 06:39:03PM +0800, Jiqian Chen wrote:
>> In current code, when guest does S3, virtio devices are reset due to
>> the bit No_Soft_Reset is not set. After resetting, the display resources
>> of virtio-gpu are destroyed, then the d
Hi Phil,
I've been staring myself blind trying to deal with
qemu_tcg_mttcg_enabled()/icount_enabled() and I'm wondering if you have
an ideas.
I'm leaning towards moving these globals to some TCG accelerator
specific state (TCGState?) that's initialized once we know how many/what
cpus are in the s
Hi Zhao,
On 28/3/24 04:44, Zhao Liu wrote:
Hi Philippe,
On Wed, Mar 27, 2024 at 10:51:21AM +0100, Philippe Mathieu-Daudé wrote:
Date: Wed, 27 Mar 2024 10:51:21 +0100
From: Philippe Mathieu-Daudé
Subject: [PATCH-for-9.1 v2 19/21] hw/i386/pc: Remove 2.3 and deprecate 2.4
to 2.7 pc-i440fx mach
Hi all,
I've reviewed and checked - this patch is necessary!
Acked-by: and...@daynix.com
On Thu, Mar 28, 2024 at 11:39 AM Yuri Benditovich
wrote:
>
> Hi Andrew,
> Can you please check the indirection table copy and ack on the patch
> if the fix is correct
>
> Thanks,
> Yuri
>
> On Wed, Mar 27, 2
On Thu, Mar 28, 2024 at 11:08:58AM +, Chen, Jiqian wrote:
> On 2024/3/28 18:57, Michael S. Tsirkin wrote:
> > On Thu, Mar 28, 2024 at 06:39:03PM +0800, Jiqian Chen wrote:
> >> In current code, when guest does S3, virtio devices are reset due to
> >> the bit No_Soft_Reset is not set. After reset
On Mon, Mar 25, 2024 at 05:18:50PM +0800, zhuyangyang via wrote:
> If g_main_loop_run()/aio_poll() is called in the coroutine context,
> the pending coroutine may be woken up repeatedly, and the co_queue_wakeup
> may be disordered.
>
> When the poll() syscall exited in g_main_loop_run()/aio_poll()
On 28/3/24 10:06, Daniel P. Berrangé wrote:
On Wed, Mar 27, 2024 at 11:55:48AM +0100, Philippe Mathieu-Daudé wrote:
The whole RDMA subsystem was deprecated in commit e9a54265f5
("hw/rdma: Deprecate the pvrdma device and the rdma subsystem")
released in v8.2. Time to remove it.
Keep the RAM_SAVE
On Thu, Mar 28, 2024 at 01:57:27PM +0100, Philippe Mathieu-Daudé wrote:
> On 28/3/24 10:06, Daniel P. Berrangé wrote:
> > On Wed, Mar 27, 2024 at 11:55:48AM +0100, Philippe Mathieu-Daudé wrote:
> > > The whole RDMA subsystem was deprecated in commit e9a54265f5
> > > ("hw/rdma: Deprecate the pvrdma
Since v1:
- split in 3 (Thomas)
- justify gluster removal
Philippe Mathieu-Daudé (3):
hw/rdma: Remove pvrdma device and rdmacm-mux helper
migration: Remove RDMA protocol handling
block/gluster: Remove RDMA protocol handling
MAINTAINERS | 17 -
docs/about
GlusterFS+RDMA has been deprecated 8 years ago in commit
0552ff2465 ("block/gluster: deprecate rdma support"):
gluster volfile server fetch happens through unix and/or tcp,
it doesn't support volfile fetch over rdma. The rdma code may
actually mislead, so to make sure things do not break, fo
On 28/3/24 06:31, Nicholas Piggin wrote:
These are no longer used.
tlb_flush_all_cpus: removed in previous patch
tlb_flush_page_all_cpus: removed in previous patch
tlb_flush_page_bits_by_mmuidx_all_cpus: never used
tlb_flush_page_by_mmuidx_all_cpus: never used
tlb_flush_page_bits_by_mmuidx_all
On 28/3/24 06:31, Nicholas Piggin wrote:
With mttcg, broadcast tlbie instructions do not wait until other vCPUs
have been kicked out of TCG execution before they complete (including
necessary subsequent tlbsync, etc., instructions). This is contrary to
the ISA, and it permits other vCPUs to use t
On 28/3/24 11:37, Nicholas Piggin wrote:
On Thu Mar 28, 2024 at 8:15 PM AEST, Nicholas Piggin wrote:
On Thu Mar 28, 2024 at 6:12 PM AEST, Nicholas Piggin wrote:
On Thu Mar 28, 2024 at 3:31 PM AEST, Nicholas Piggin wrote:
ppc broadcast tlb flushes should be synchronised with other vCPUs,
like a
On Mär 06 2024, Alistair Francis wrote:
> On Sun, Mar 3, 2024 at 8:34 PM Andreas Schwab wrote:
>>
>> On Jan 28 2024, Michael Tokarev wrote:
>>
>> > From: Richard Henderson
>> >
>> > A typo in sizeof_reg put the registers at the wrong offset.
>> >
>> > Simplify the expressions to use positive add
There are several places where postcopy_start() fails without setting
errp. This can cause a null pointer de-reference, as in case of error,
the caller of postcopy_start() copies/prints the error set in errp.
Fix it by setting errp in all of postcopy_start() error paths.
Fixes: 908927db28ea ("mig
After commit 9425ef3f990a ("migration: Use migrate_has_error() in
close_return_path_on_source()"), close_return_path_on_source() assumes
that migration error is set if an error occurs during migration.
This may not be true if migration errors in migration_completion(). For
example, if qemu_savevm_
We need the latest fixes for the lcitool to be able to properly
update our CentOS docker file to CentOS Stream 9.
Signed-off-by: Thomas Huth
---
tests/lcitool/libvirt-ci | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/lcitool/libvirt-ci b/tests/lcitool/libvirt-ci
index
In the QEMU 9.1 development cycle, we can drop the support for
Ubuntu 20.04 and CentOS 8 since the following major versions of
these distributions are available since 2 years already.
This allows us to bump the minimum version of glib to 2.66 which
comes with a nice set of URI parsing functions. B
RHEL 9 (and thus also the derivatives) are available since two years
now, so according to QEMU's support policy, we can drop the active
support for the previous major version 8 now.
Thus upgrade our CentOS Stream container to major version 9 now.
Signed-off-by: Thomas Huth
---
.gitlab-ci.d/build
Since version 2.66, glib has useful URI parsing functions, too.
Use those instead of the QEMU-internal ones to be finally able
to get rid of the latter.
Cc: integrat...@gluster.org
Signed-off-by: Thomas Huth
---
block/gluster.c | 63 +
1 file chang
Since Ubuntu 22.04 is now available since two years, we can stop
actively supporting the previous LTS version of Ubuntu now.
Signed-off-by: Thomas Huth
---
tests/docker/dockerfiles/ubuntu2004.docker | 157 -
tests/lcitool/refresh | 1 -
2 files changed,
Now that we switched all consumers of the URI code to use the URI
parsing functions from glib instead, we can remove our internal
URI parsing code since it is not used anymore.
Signed-off-by: Thomas Huth
---
include/qemu/uri.h | 99 ---
util/uri.c | 1466 ---
Since version 2.66, glib has useful URI parsing functions, too.
Use those instead of the QEMU-internal ones to be finally able
to get rid of the latter. The g_uri_get_host() also takes care
of removing the square brackets from IPv6 addresses, so we can
drop that part of the QEMU code now, too.
Sig
Since version 2.66, glib has useful URI parsing functions, too.
Use those instead of the QEMU-internal ones to be finally able
to get rid of the latter.
Signed-off-by: Thomas Huth
---
block/ssh.c | 69 +++--
1 file changed, 40 insertions(+), 29 del
Now that we dropped support for CentOS 8 and Ubuntu 20.04, we can
look into bumping the glib version to a new minimum for further
clean-ups. According to repology.org, available versions are:
CentOS Stream 9: 2.66.7
Debian 11: 2.66.8
Fedora 38: 2.74.1
Freebsd:
Since version 2.66, glib has useful URI parsing functions, too.
Use those instead of the QEMU-internal ones to be finally able
to get rid of the latter.
Signed-off-by: Thomas Huth
---
block/nfs.c | 102 ++--
1 file changed, 52 insertions(+), 50 del
Hello,
This small series fixes two migration bugs I stumbled upon recently.
Comments are welcome, thanks for reviewing.
Avihai Horon (2):
migration: Set migration error in migration_completion()
migration/postcopy: Ensure postcopy_start() sets errp if it fails
migration/migration.c | 18 +++
On 27/03/2024 07:09, Gerd Hoffmann wrote:
On Tue, Mar 26, 2024 at 01:30:48PM +, Mark Cave-Ayland wrote:
Heh I've actually been using isapc over the past couple of weeks to fire up
some old programs in a Windows 3 VM :)
I'm wondering why these use cases can't simply use the 'pc' machine
ty
On Thu, Mar 28, 2024 at 03:06:05PM +0100, Thomas Huth wrote:
> Since version 2.66, glib has useful URI parsing functions, too.
> Use those instead of the QEMU-internal ones to be finally able
> to get rid of the latter.
>
> Signed-off-by: Thomas Huth
> ---
> block/ssh.c | 69
On Thu, Mar 28, 2024 at 03:06:03PM +0100, Thomas Huth wrote:
> Since version 2.66, glib has useful URI parsing functions, too.
> Use those instead of the QEMU-internal ones to be finally able
> to get rid of the latter. The g_uri_get_host() also takes care
> of removing the square brackets from IPv
Philippe Mathieu-Daudé writes:
> The whole RDMA subsystem was deprecated in commit e9a54265f5
> ("hw/rdma: Deprecate the pvrdma device and the rdma subsystem")
> released in v8.2.
>
> Remove:
> - RDMA handling from migration
> - dependencies on libibumad, libibverbs and librdmacm
>
> Keep the R
On Thu, Mar 28, 2024 at 2:19 AM Alistair Francis wrote:
>
> On Wed, Mar 27, 2024 at 9:19 PM Conor Dooley wrote:
> >
> > Christoph linked here on his submission to Linux of a fix for this, so I
> > am reviving this to leave a couple comments :)
> >
> > On Thu, Feb 15, 2024 at 02:24:02PM +1000, Ali
On Thu, Mar 28, 2024 at 02:20:37PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> ../nbd/client-connection.c:419:8: error: ‘wait_co’ may be used uninitialized
> [-Werror=maybe-uninitialized]
>
> Signed-off-by: Marc-André Lureau
> ---
> nbd/client-connection.c | 2 +-
>
On Thu, Mar 28, 2024 at 02:20:33PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Hi,
>
> Depending on -Doptimization=, GCC (13.2.1 here) produces different
> maybe-uninitialized warnings:
> - g: produces -Werror=maybe-uninitialized errors
> - 0: clean build
> - 1: produ
On Mon, 25 Mar 2024 at 08:53, Jinjie Ruan wrote:
>
> Add the NMIAR CPU interface registers which deal with acknowledging NMI.
>
> When introduce NMI interrupt, there are some updates to the semantics for the
> register ICC_IAR1_EL1 and ICC_HPPIR1_EL1. For ICC_IAR1_EL1 register, it
> should return
On Thu, Mar 28, 2024 at 03:06:03PM +0100, Thomas Huth wrote:
> Since version 2.66, glib has useful URI parsing functions, too.
> Use those instead of the QEMU-internal ones to be finally able
> to get rid of the latter. The g_uri_get_host() also takes care
> of removing the square brackets from IPv
1 - 100 of 241 matches
Mail list logo
