On Tue, Mar 26, 2024 at 01:30:48PM +, Mark Cave-Ayland wrote:
> Heh I've actually been using isapc over the past couple of weeks to fire up
> some old programs in a Windows 3 VM :)
I'm wondering why these use cases can't simply use the 'pc' machine
type?
The early pci chipsets of the 90-ies h
On Mon, May 22, 2023 at 05:11:39PM -0700, Dan Williams wrote:
> Yasunori Gotou (Fujitsu) wrote:
[...]
Hi, all
There was some confusions about CXL device hotplug when I recently
tried to use Qemu to emulate CXL device hotplug and verify the relevant
functions of kernel.
> > Q1) Can PCIe hotplug d
When a memory device, such as CXL1.1 type3 memory, is emulated as
normal memory (E820_TYPE_RAM), the memory device is indistinguishable
from normal DRAM in terms of memory tiering with the current implementation.
The current memory tiering assigns all detected normal memory nodes
to the same DRAM t
Since different memory devices require finding, allocating, and putting
memory types, these common steps are abstracted in this patch,
enhancing the scalability and conciseness of the code.
Signed-off-by: Ho-Ren (Jack) Chuang
---
drivers/dax/kmem.c | 20 ++--
include/li
The current implementation treats emulated memory devices, such as
CXL1.1 type3 memory, as normal DRAM when they are emulated as normal memory
(E820_TYPE_RAM). However, these emulated devices have different
characteristics than traditional DRAM, making it important to
distinguish them. Thus, we mod
On 26/3/24 23:22, Richard Henderson wrote:
The 'sign' computation is attempting to locate the sign bit that has
been repeated, so that we can test if that bit is known zero. That
computation can be zero if there are no known sign repetitions.
Cc: qemu-sta...@nongnu.org
Fixes: 93a967fbb57 ("tcg/
On Mon, Mar 25, 2024 at 03:14:20PM +0100, Paolo Bonzini wrote:
> Date: Mon, 25 Mar 2024 15:14:20 +0100
> From: Paolo Bonzini
> Subject: [PATCH for-9.1 v5 1/3] hw: Add compat machines for 9.1
> X-Mailer: git-send-email 2.44.0
>
> Add 9.1 machine types for arm/i440fx/m68k/q35/s390x/spapr.
>
> Cc:
On 26/3/24 18:28, Thomas Huth wrote:
On 26/03/2024 18.10, Philippe Mathieu-Daudé wrote:
Compilers are clever enough to inline code when necessary.
The only case we accept an inline function is static in
header (we use C, not C++).
Add the -Wstatic-in-inline CPPFLAG to prevent public and
I th
Hi Paolo,
On Mon, Mar 25, 2024 at 03:14:21PM +0100, Paolo Bonzini wrote:
> Date: Mon, 25 Mar 2024 15:14:21 +0100
> From: Paolo Bonzini
> Subject: [PATCH for-9.1 v5 2/3] target/i386: add guest-phys-bits cpu
> property
> X-Mailer: git-send-email 2.44.0
>
> From: Gerd Hoffmann
>
> Allows to set
On Wed, Mar 27, 2024 at 2:03 PM Cindy Lu wrote:
>
> On Wed, Mar 27, 2024 at 11:05 AM Jason Wang wrote:
> >
> > Hi Cindy:
> >
> > On Wed, Mar 27, 2024 at 9:29 AM Cindy Lu wrote:
> > >
> > > we need a crash in Non-standard image, here is the jira for this
> > > https://issues.redhat.com/browse/RH
On 27/03/2024 06.41, Harsh Prateek Bora wrote:
On 3/26/24 21:32, Peter Maydell wrote:
On Tue, 12 Mar 2024 at 17:11, Nicholas Piggin wrote:
From: Harsh Prateek Bora
Introduce the nested PAPR hcalls:
- H_GUEST_GET_STATE which is used to get state of a nested guest or
a guest VCP
Hi Paolo,
On Mon, Mar 25, 2024 at 03:14:22PM +0100, Paolo Bonzini wrote:
> Date: Mon, 25 Mar 2024 15:14:22 +0100
> From: Paolo Bonzini
> Subject: [PATCH for-9.1 v5 3/3] kvm: add support for guest physical bits
> X-Mailer: git-send-email 2.44.0
[snip]
> static bool kvm_cpu_realizefn(CPUState *c
On Wed, Mar 27, 2024 at 3:54 PM Jason Wang wrote:
>
> On Wed, Mar 27, 2024 at 2:03 PM Cindy Lu wrote:
> >
> > On Wed, Mar 27, 2024 at 11:05 AM Jason Wang wrote:
> > >
> > > Hi Cindy:
> > >
> > > On Wed, Mar 27, 2024 at 9:29 AM Cindy Lu wrote:
> > > >
> > > > we need a crash in Non-standard imag
rue"
test "$tcg" != enabled && meson_option_add "-Dtcg=$tcg"
+ test "$sanitizers" = yes && meson_option_add -Dsanitizers=true
run_meson() {
NINJA=$ninja $meson setup "$@" "$PWD" "$source_path"
}
---
base-commit: ba49d760eb04630e7b15f423ebecf6c871b8f77b
change-id: 20240327-werror-5d2e974c3d7d
Best regards,
--
Akihiko Odaki
It is incorrect to have the VIRTIO_NET_HDR_F_NEEDS_CSUM set when
checksum offloading is disabled so clear the bit.
TCP/UDP checksum is usually offloaded when the peer requires virtio
headers because they can instruct the peer to compute checksum. However,
igb disables TX checksum offloading when a
On Tuesday, March 26, 2024 6:47:17 PM CET Daniel Henrique Barboza wrote:
> On 3/26/24 14:05, Greg Kurz wrote:
> > On Tue, 26 Mar 2024 10:26:04 -0300
> > Daniel Henrique Barboza wrote:
> >
> >> The local 9p driver in virtio-9p-test.c its temporary dir right at the
> >> start of qos-test (via virti
On Tuesday, March 26, 2024 5:07:16 PM CET Daniel Henrique Barboza wrote:
>
> On 3/26/24 12:55, Greg Kurz wrote:
> > Bom dia Daniel !
>
> Bonne après-midi !
>
> >
> > On Tue, 26 Mar 2024 10:26:03 -0300
> > Daniel Henrique Barboza wrote:
> >
> >> Hi,
> >>
> >> Thomas reported in [1] a problem t
On Wed, Mar 20, 2024 at 3:45 AM Xiaoyao Li wrote:
> If users pass configuration like "-cpu
> qemu64,phys-bits=52,host-phys-bits-limit=45", the cpu->guest_phys_bits
> will be set to 45. I think this is not what we want, though the usage
> seems insane.
>
> We can guard it as
>
> if (cpu->host_phy
On Tue, Mar 26, 2024 at 4:48 PM Xiaoyao Li wrote:
> So, this requires confidential guests to call
> kvm_mark_guest_state_protected() in its machine_init_done notifier callback?
>
> But for TDX, the guest_state is protected at the beginning, not some
> time later when machine_init_done.
Good point
On Wed, Mar 27, 2024 at 4:28 PM Cindy Lu wrote:
>
> On Wed, Mar 27, 2024 at 3:54 PM Jason Wang wrote:
> >
> > On Wed, Mar 27, 2024 at 2:03 PM Cindy Lu wrote:
> > >
> > > On Wed, Mar 27, 2024 at 11:05 AM Jason Wang wrote:
> > > >
> > > > Hi Cindy:
> > > >
> > > > On Wed, Mar 27, 2024 at 9:29 AM
On Wed, Mar 27, 2024 at 5:12 PM Jason Wang wrote:
>
> On Wed, Mar 27, 2024 at 4:28 PM Cindy Lu wrote:
> >
> > On Wed, Mar 27, 2024 at 3:54 PM Jason Wang wrote:
> > >
> > > On Wed, Mar 27, 2024 at 2:03 PM Cindy Lu wrote:
> > > >
> > > > On Wed, Mar 27, 2024 at 11:05 AM Jason Wang wrote:
> > > >
On 6/3/24 17:41, Thomas Huth wrote:
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
The pc-i440fx-2.0 machine was deprecated for the 8.2
release (see commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated"),
time to remove it.
Signed-off-by: Philippe Math
On 3/26/24 18:10, Philippe Mathieu-Daudé wrote:
Compilers are clever enough to inline code when necessary.
The only case we accept an inline function is static in
header (we use C, not C++).
Add the -Wstatic-in-inline CPPFLAG to prevent public and
inline function to be added in the code base.
On Tue, Mar 26, 2024 at 03:36:52PM +0100, David Hildenbrand wrote:
On 26.03.24 15:34, Eric Blake wrote:
On Tue, Mar 26, 2024 at 02:39:27PM +0100, Stefano Garzarella wrote:
In vu_message_write() we use sendmsg() to send the message header,
then a write() to send the payload.
If sendmsg() fails
On Tue, Mar 26, 2024 at 09:36:54AM -0500, Eric Blake wrote:
On Tue, Mar 26, 2024 at 02:39:28PM +0100, Stefano Garzarella wrote:
libvhost-user will panic when receiving VHOST_USER_GET_INFLIGHT_FD
message if MFD_ALLOW_SEALING is not defined, since it's not able
to create a memfd.
VHOST_USER_GET_I
I was wondering if we could see some partial sendmsg()/write
succeeding. Meaning, we transferred some bytes but not all, and we'd
actually need to loop ...
Yep, true, but I would fix it in another patch/series if you agree.
Absolutely.
--
Cheers,
David / dhildenb
Similar to what was done with fs_create_dir() in the previous patch, and
for the same reasons, let's consolidate fs_create_file() and
fs_unlinkat_file() in a single test that has the same coverage:
- fs_create_file() is removed;
- rename fs_unlinkat_file() to fs_create_unlinkat_file();
- change
Add a '_path' call in all variables that are receiving a full path via
virtio_9p_test_path().
Aside from being more accurate with what the variable represents, this
will allow us to use 'new_dir' and 'real_path' and so on to parametrize
test values in the next patch.
Signed-off-by: Daniel Henriqu
We've consolidated all local 9p tests but the hardlink ones. To make
fs_unlinkat_hardlink() to act exactly like fs_hardlink_file() we added
the g_assert(st_link...) checks in fs_unlinkat_hardlink() as well.
After that:
- remove fs_hardlink_file(). Rename fs_unlinkat_hardlink() to
fs_create_unli
The local 9p driver in virtio-9p-test.c its temporary dir right at the
start of qos-test (via virtio_9p_create_local_test_dir()) and only
deletes it after qos-test is finished (via
virtio_9p_remove_local_test_dir()).
This means that any qos-test machine that ends up running virtio-9p-test
local te
On Wed, Mar 27, 2024 at 5:12 PM Jason Wang wrote:
>
> On Wed, Mar 27, 2024 at 4:28 PM Cindy Lu wrote:
> >
> > On Wed, Mar 27, 2024 at 3:54 PM Jason Wang wrote:
> > >
> > > On Wed, Mar 27, 2024 at 2:03 PM Cindy Lu wrote:
> > > >
> > > > On Wed, Mar 27, 2024 at 11:05 AM Jason Wang wrote:
> > > >
Commit 558f5c42ef gated the local tests with g_test_slow() to skip them
in 'make check'. The reported issue back then was this following CI
problem:
https://lists.nongnu.org/archive/html/qemu-devel/2020-11/msg05510.html
This problem ended up being fixed when the recently added risc-v machine
node
All local 9p tests creates a different dir inside tempdir, where '01' is
the dir for the first test, '02' the dir fot the second test and so on.
We want to make tests autoclean themselves while also consolidating
them in fewer tests, but this will incur a lot of dir changes that will
be unpleasant
Hi,
In this new version I added a handful of patches to make it easier to
review, as suggested by Greg in v1.
Thomas, the changes made aren't negligible so I didn't add your
Tested-by. You're more than welcome to give this version a try :)
The first 2 patches are needed to ease the burden of ind
fs_unlinkat_symlink() does the same thing as fs_symlink_file() while
also removing the created symlink. We also want every test to not leave
stuff behind after each run to avoid subsequential runs to fail.
We can achieve all that by:
- remove fs_unlinkat_symlink(). fs_unlinkat_symlink() is now na
On 6/3/24 19:30, Thomas Huth wrote:
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
X86CPU::kvm_no_smi_migration was only used by the
pc-i440fx-2.3 machine, which got removed. Remove it
and simplify kvm_put_vcpu_events().
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/cpu.h | 3
On 3/27/24 05:47, Christian Schoenebeck wrote:
On Tuesday, March 26, 2024 6:47:17 PM CET Daniel Henrique Barboza wrote:
On 3/26/24 14:05, Greg Kurz wrote:
On Tue, 26 Mar 2024 10:26:04 -0300
Daniel Henrique Barboza wrote:
The local 9p driver in virtio-9p-test.c its temporary dir right at t
On Wed, Mar 27, 2024 at 5:13 PM Jason Wang wrote:
>
> On Wed, Mar 27, 2024 at 5:12 PM Jason Wang wrote:
> >
> > On Wed, Mar 27, 2024 at 4:28 PM Cindy Lu wrote:
> > >
> > > On Wed, Mar 27, 2024 at 3:54 PM Jason Wang wrote:
> > > >
> > > > On Wed, Mar 27, 2024 at 2:03 PM Cindy Lu wrote:
> > > >
On Tue, Mar 26, 2024 at 09:40:12AM -0500, Eric Blake wrote:
On Tue, Mar 26, 2024 at 02:39:29PM +0100, Stefano Garzarella wrote:
In vhost-user-server we set all fd received from the other peer
in non-blocking mode. For some of them (e.g. memfd, shm_open, etc.)
if we fail, it's not really a proble
Missing review: 4-6, 10-12, 16, 19-20
Since v1:
- Addressed Zhao and Thomas review comments
- Removal around ICH9 acpi_memory_hotplug (Thomas)
Kill legacy code, because we need to evolve.
I ended there via dynamic machine -> ICH9 -> legacy ACPI...
This should also help Igor cleanups:
http://lor
XHCI_FLAG_FORCE_PCIE_ENDCAP was only used by the
pc-i440fx-2.0 machine, which got removed. Remove it
and simplify usb_xhci_pci_realize().
Reviewed-by: Thomas Huth
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/hcd-xhci.h | 1 -
hw/usb/hcd-xhci-nec.c | 2 --
hw/usb/hcd-xhci-pci.c | 3 +--
XHCI_FLAG_SS_FIRST was only used by the pc-i440fx-2.0 machine,
which got removed. Remove it and simplify various functions in
hcd-xhci.c.
Reviewed-by: Thomas Huth
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/hcd-xhci.h | 3 +--
hw/usb/hcd-xhci-nec.c | 2 --
hw/usb/hcd-xhci-pci.c | 1
The pc-i440fx-2.0 machine was deprecated for the 8.2
release (see commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated"),
time to remove it.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20240305134221.30924-2-phi...@linaro.org
acpi_memory_hotplug::is_enabled is set to %true once via
ich9_lpc_initfn() -> ich9_pm_add_properties(). No need to
check it, so remove now dead code.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/acpi/ich9.c | 28 ++--
1 file changed, 6 insertions(+), 22 deletions(-)
diff
No external code sets the 'memory-hotplug-support'
property, remove it.
Suggested-by: Thomas Huth
Signed-off-by: Philippe Mathieu-Daudé
---
hw/acpi/ich9.c | 18 --
1 file changed, 18 deletions(-)
diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
index 573d032e8e..9b605af21a 100644
-
PCMachineClass::enforce_aligned_dimm was only used by the
pc-i440fx-2.1 machine, which got removed. It is now always
true. Remove it, simplifying pc_get_device_memory_range().
Update the comment in Avocado test_phybits_low_pse36().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/pc.h
'legacy_align' is always NULL, remove it.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20240305134221.30924-11-phi...@linaro.org>
---
include/hw/mem/pc-dimm.h | 3 +--
hw/arm/virt.c| 2 +-
hw/i386/pc.c | 2 +-
hw/loongarch/virt.c | 2 +
PCMachineClass::legacy_acpi_table_size was only used by the
pc-i440fx-2.0 machine, which got removed. Remove it and simplify
acpi_build().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/pc.h | 1 -
hw/i386/acpi-build.c | 62 +---
2 files change
The pc-i440fx-2.1 machine was deprecated for the 8.2
release (see commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated"),
time to remove it.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20240305134221.30924-7-phi...@linaro.org
PCMachineClass::smbios_uuid_encoded was only used by the
pc-i440fx-2.1 machine, which got removed. It is now always
true, remove it.
Reviewed-by: Thomas Huth
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/pc.h | 1 -
hw/i386/fw_cfg.c | 3 +--
hw/i386/pc.c | 1 -
3 files c
'uuid_encoded' is always NULL, remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/firmware/smbios.h | 3 +--
hw/arm/virt.c| 3 +--
hw/i386/fw_cfg.c | 2 +-
hw/loongarch/virt.c | 2 +-
hw/riscv/virt.c | 2 +-
hw/smbios/smbios.c
'legacy_align' is always NULL, remove it, simplifying
memory_device_pre_plug().
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20240305134221.30924-12-phi...@linaro.org>
---
include/hw/mem/memory-device.h | 2 +-
hw/i386/pc.c | 3 +--
hw/mem/memo
x86_cpu_change_kvm_default() was only used out of kvm-cpu.c by
the pc-i440fx-2.1 machine, which got removed. Make it static,
and remove its declaration. "kvm-cpu.h" is now empty, remove it.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20240305134221.30924-8-phi...@
'smbios_encode_uuid' is always true, remove it,
simplifying smbios_encode_uuid().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/smbios/smbios.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c
index 8261eb716f..3b7703489d 100644
PCMachineClass::resizable_acpi_blob was only used by the
pc-i440fx-2.2 machine, which got removed. It is now always
true. Remove it, simplifying acpi_build().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/pc.h | 3 ---
hw/i386/acpi-build.c | 10 --
hw/i386/pc.c | 1
X86CPU::kvm_no_smi_migration was only used by the
pc-i440fx-2.3 machine, which got removed. Remove it
and simplify kvm_put_vcpu_events().
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/cpu.h | 3 ---
target/i386/cpu.c | 2 --
target/i386/kvm/kvm.c | 7 +--
3 files changed, 1 i
AcpiBuildState::rsdp is always NULL, remove it,
simplifying acpi_build_update().
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20240305134221.30924-16-phi...@linaro.org>
---
hw/i386/acpi-build.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --g
The pc-i440fx-2.2 machine was deprecated for the 8.2
release (see commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated"),
time to remove it.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20240305134221.30924-13-phi...@linaro.or
PCMachineClass::acpi_data_size was only used by the pc-i440fx-2.0
machine, which got removed. Since it is constant, replace the class
field by a definition.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20240305134221.30924-19-phi...@linaro.org>
---
include/hw/i386
The pc-i440fx-2.3 machine was deprecated for the 8.2
release (see commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated"),
time to remove it. Similarly to the cited commit,
deprecate the 2.4 to 2.7 machines.
Signed-off-by: Philippe Mathieu-Daudé
---
docs/abo
PCMachineClass::rsdp_in_ram was only used by the
pc-i440fx-2.2 machine, which got removed. It is
now always true. Remove it, simplifying acpi_setup().
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20240305134221.30924-15-phi...@linaro.org>
---
include/hw/i386/pc.h
Hello Cedric,
}
+static void pnv_phb4_fund_A_reset(PnvPHB4 *phb)
What is fund_A ?
I used 'fund_A' as an abbreviation to "Fundamental Register Set A".
Please let know if you suggest another abbreviation to name this method.
+{
+ phb->regs[PHB_LSI_SOURCE_ID >> 3] = PPC_BITMASK(4, 12)
The th.mxstatus CSR can be used to identify available custom extension
on T-Head CPUs. The CSR is documented here:
https://github.com/T-head-Semi/thead-extension-spec/pull/45
An important property of this patch is, that the th.mxstatus MAEE field
is not set (indicating that XTheadMaee is not ava
26.03.2024 12:56, Alistair Francis пишет:
On Tue, Mar 26, 2024 at 7:53 PM Michael Tokarev wrote:
On 24.03.2024 21:12, Daniel Henrique Barboza wrote:
On 3/24/24 12:07, Michael Tokarev wrote:
Unfortunately this doesn't quite work, the following changes
fail to apply to 8.2:
929e521a47 targe
On Wednesday, March 27, 2024 10:33:27 AM CET Daniel Henrique Barboza wrote:
> On 3/27/24 05:47, Christian Schoenebeck wrote:
> > On Tuesday, March 26, 2024 6:47:17 PM CET Daniel Henrique Barboza wrote:
> >> On 3/26/24 14:05, Greg Kurz wrote:
> >>> On Tue, 26 Mar 2024 10:26:04 -0300
> >>> Daniel Hen
On Tue, Mar 26, 2024 at 03:45:52PM +0100, David Hildenbrand wrote:
+mode = 0;
+oflag = O_RDWR | O_CREAT | O_EXCL;
+backend_name = host_memory_backend_get_name(backend);
+
+/*
+ * Some operating systems allow creating anonymous POSIX shared memory
+ * objects (e.g. FreeBSD
v2 changes:
- store version information in git
Gerd Hoffmann (3):
edk2: get version + date from git submodule
edk2: commit version info
edk2/seabios: use common extra version
roms/Makefile | 25 ++---
roms/edk2-version | 2 ++
2 files changed, 20 insertions(+), 7
Turned out hard-coding version and date in the Makefile wasn't a bright
idea. Updating it on edk2 updates is easily forgotten. Fetch the info
from git instead. Store in edk2-version, so this can be committed to
the repo and is present in tarballs too.
Signed-off-by: Gerd Hoffmann
---
roms/Mak
From: Zhao Liu
Hi Paolo and list,
In i386, there're 2 cases useing static variables to implement warning
only once.
So consolidate the use of warn_report_once() in i386 part. (Based on
the commit 5012e522aca1 "Update version for v9.0.0-rc1 release")
Thanks and Best Regards,
Zhao
---
Zhao Liu (
From: Zhao Liu
Currently, the difference between warn_report_once() and
error_report_once() is the former has the "warning:" prefix, while the
latter does not have a similar level prefix.
At the meantime, considering that there is no error handling logic here,
and the purpose of error_report_onc
From: Zhao Liu
The difference between error_printf() and error_report() is the latter
may contain more information, such as the name of the program
("qemu-system-x86_64").
Thus its variant error_report_once() and warn_report()'s variant
warn_report_once() can be used here to print the informatio
Hello Zhenzhong,
On 3/19/24 12:58, Duan, Zhenzhong wrote:
Hi Cédric,
-Original Message-
From: Cédric Le Goater
Sent: Tuesday, March 19, 2024 4:17 PM
To: Duan, Zhenzhong ; qemu-
de...@nongnu.org
Cc: alex.william...@redhat.com; eric.au...@redhat.com;
pet...@redhat.com; jasow...@redhat.c
From: Zhao Liu
Use warn_report_once() to get rid of the static local variable "warned".
Signed-off-by: Zhao Liu
---
target/i386/host-cpu.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/target/i386/host-cpu.c b/target/i386/host-cpu.c
index 92ecb7254b83..280e427
Bring a bit more consistency into the naming.
Signed-off-by: Gerd Hoffmann
---
roms/Makefile | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/roms/Makefile b/roms/Makefile
index 783a5cab4f4c..dfed2b216a1e 100644
--- a/roms/Makefile
+++ b/roms/Makefile
@@ -41,8 +41,8
Signed-off-by: Gerd Hoffmann
---
roms/edk2-version | 2 ++
1 file changed, 2 insertions(+)
create mode 100644 roms/edk2-version
diff --git a/roms/edk2-version b/roms/edk2-version
new file mode 100644
index ..1594ed8c4de9
--- /dev/null
+++ b/roms/edk2-version
@@ -0,0 +1,2 @@
+EDK2_ST
Hi Yajun,
On Mon, Mar 25, 2024 at 10:54:13AM +, Yajun Wu wrote:
Hi experts,
With latest QEMU (8.2.90), we find two vhost-user-blk backend reconnect
failure scenarios:
Do you know if has it ever worked and so it's a regression, or have we
always had this problem?
Thanks,
Stefano
1. D
On 27/03/24 2:37 am, Fabiano Rosas wrote:
Het Gala writes:
Some comments, mostly just thinking out loud...
For --> migrate
//
//O:/...
For --> validate
///O:/O:/
/O:/O:/...
Do we need an optional 'capability' element? I'm not sure how practical
is to leave that as 'others', because t
On Tue, Mar 26, 2024 at 05:16:32PM +0100, Igor Mammedov wrote:
> On Tue, 26 Mar 2024 14:29:58 +0100
> Philippe Mathieu-Daudé wrote:
>
> > Hi Igor,
> >
> > On 26/3/24 14:08, Thomas Huth wrote:
> > >
> > > s/iaspc/isapc/ in the subject
> > >
> > > On 26/03/2024 13.51, Igor Mammedov wrote:
> >
void memory_device_pre_plug(MemoryDeviceState *md, MachineState *ms,
-const uint64_t *legacy_align, Error **errp)
+Error **errp)
{
const MemoryDeviceClass *mdc = MEMORY_DEVICE_GET_CLASS(md);
Error *local_err = NULL;
@@ -388,14
Christoph linked here on his submission to Linux of a fix for this, so I
am reviving this to leave a couple comments :)
On Thu, Feb 15, 2024 at 02:24:02PM +1000, Alistair Francis wrote:
> On Mon, Feb 5, 2024 at 6:37 PM Christoph Müllner
> wrote:
> > On Mon, Feb 5, 2024 at 3:42 AM Alistair Francis
Hi,
Depending -Doptimization=, I get different results (GCC 13.2.1)
- g: produces -Werror=maybe-uninitialized errors
- 0: clean build
- 1: produces -Werror=maybe-uninitialized errors
- 2: clean build
- 3: produces few -Werror=maybe-uninitialized errors
- s: produces -Werror=maybe-uninitialized err
On 3/27/24 07:14, Christian Schoenebeck wrote:
On Wednesday, March 27, 2024 10:33:27 AM CET Daniel Henrique Barboza wrote:
On 3/27/24 05:47, Christian Schoenebeck wrote:
On Tuesday, March 26, 2024 6:47:17 PM CET Daniel Henrique Barboza wrote:
On 3/26/24 14:05, Greg Kurz wrote:
On Tue, 26 M
From: Zhao Liu
When vreport() was introduced, there was no prefix for error-level
(REPORT_TYPE_ERROR) report. The original reason is "To maintain
compatibility we don't add anything here" as Alistair said in his
RFC v3 series [1].
This was done in the context of inheriting the original error_rep
On 27.03.24 10:51, Philippe Mathieu-Daudé wrote:
'legacy_align' is always NULL, remove it.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20240305134221.30924-11-phi...@linaro.org>
---
I was really confused for a second until I saw that this series is
dependent
From: Zhao Liu
The commit 15002f60f792 ("util: rename qemu-error.c to match its header
name") renamed util/qemu-error.c to util/error-report.c but missed to
change the corresponding entry.
To avoid get_maintainer.pl failing, update the error-report.c entry.
Signed-off-by: Zhao Liu
---
MAINTAI
On Wed, Mar 27, 2024 at 03:28:08PM +0400, Marc-André Lureau wrote:
> Hi,
>
> Depending -Doptimization=, I get different results (GCC 13.2.1)
> - g: produces -Werror=maybe-uninitialized errors
> - 0: clean build
> - 1: produces -Werror=maybe-uninitialized errors
> - 2: clean build
> - 3: produces f
On Tue, Nov 14, 2023 at 03:38:01PM +0100, Philippe Mathieu-Daudé wrote:
> Only call xen_register_framebuffer() when Xen is enabled.
>
> Signed-off-by: Philippe Mathieu-Daudé
I don't think this patch is very useful but it's fine, so:
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On 27.03.24 11:23, Stefano Garzarella wrote:
On Tue, Mar 26, 2024 at 03:45:52PM +0100, David Hildenbrand wrote:
+mode = 0;
+oflag = O_RDWR | O_CREAT | O_EXCL;
+backend_name = host_memory_backend_get_name(backend);
+
+/*
+ * Some operating systems allow creating anonymous POSI
On Tue, Nov 14, 2023 at 03:38:04PM +0100, Philippe Mathieu-Daudé wrote:
> All these stubs are protected by a 'if (xen_enabled())' check.
Are you sure? There's still nothing that prevent a compiler from wanting
those, I don't think.
Sure, often compilers will remove dead code in `if(0){...}`, but
On Wednesday, March 27, 2024 12:28:17 PM CET Daniel Henrique Barboza wrote:
> On 3/27/24 07:14, Christian Schoenebeck wrote:
> > On Wednesday, March 27, 2024 10:33:27 AM CET Daniel Henrique Barboza wrote:
> >> On 3/27/24 05:47, Christian Schoenebeck wrote:
> >>> On Tuesday, March 26, 2024 6:47:17 P
On Wed, 27 Mar 2024 13:26:45 +0100
Christian Schoenebeck wrote:
> On Wednesday, March 27, 2024 12:28:17 PM CET Daniel Henrique Barboza wrote:
> > On 3/27/24 07:14, Christian Schoenebeck wrote:
> > > On Wednesday, March 27, 2024 10:33:27 AM CET Daniel Henrique Barboza
> > > wrote:
> > >> On 3/27/
On 27/03/2024 12.46, Zhao Liu wrote:
From: Zhao Liu
When vreport() was introduced, there was no prefix for error-level
(REPORT_TYPE_ERROR) report. The original reason is "To maintain
compatibility we don't add anything here" as Alistair said in his
RFC v3 series [1].
This was done in the conte
Remove the Nios II machines and the system emulation code
(deprecated since v8.2 in commit 9997771bc1 "target/nios2:
Deprecate the Nios II architecture").
Cc: Marek Vasut
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 4 -
docs/about/deprecated.rst
On 3/27/24 09:26, Christian Schoenebeck wrote:
On Wednesday, March 27, 2024 12:28:17 PM CET Daniel Henrique Barboza wrote:
On 3/27/24 07:14, Christian Schoenebeck wrote:
On Wednesday, March 27, 2024 10:33:27 AM CET Daniel Henrique Barboza wrote:
On 3/27/24 05:47, Christian Schoenebeck wrote
On 27/3/24 10:26, Paolo Bonzini wrote:
On 3/26/24 18:10, Philippe Mathieu-Daudé wrote:
Compilers are clever enough to inline code when necessary.
The only case we accept an inline function is static in
header (we use C, not C++).
Add the -Wstatic-in-inline CPPFLAG to prevent public and
inline
On 27/3/24 13:35, Philippe Mathieu-Daudé wrote:
Remove the Nios II machines and the system emulation code
(deprecated since v8.2 in commit 9997771bc1 "target/nios2:
Deprecate the Nios II architecture").
Cc: Marek Vasut
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS
On Wed, Mar 27, 2024 at 01:36:07PM +0100, Thomas Huth wrote:
[snip]
> Sounds like a good idea to me, but I think you should then also remove
> the hard-coded "error:" strings in the various error_reports():
Thanks Thomas! I missed this case, will remove these hard-code prefix
first.
> $ grep -r
On Wed, Mar 27, 2024 at 10:51:03AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 27 Mar 2024 10:51:03 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 v2 01/21] hw/i386/pc: Remove deprecated
> pc-i440fx-2.0 machine
> X-Mailer: git-send-email 2.41.0
>
> The pc-i440fx-2.0 machine
On Wed, Mar 27, 2024 at 10:51:04AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 27 Mar 2024 10:51:04 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 v2 02/21] hw/usb/hcd-xhci: Remove
> XHCI_FLAG_FORCE_PCIE_ENDCAP flag
> X-Mailer: git-send-email 2.41.0
>
> XHCI_FLAG_FORCE_PCIE
kvm_riscv_handle_sbi() may return not supported return code to not trigger
qemu abort with vendor-specific sbi.
Added SBI related return code's defines.
Signed-off-by: Alexei Filippov
Fixes: 4eb47125 ("target/riscv: Handle KVM_EXIT_RISCV_SBI exit")
Reviewed-by: Daniel Henrique Barboza
Reviewed-
1 - 100 of 223 matches
Mail list logo
