Re: [PATCH v2 2/3] target/hppa: Move diag argument handling to decodetree

2024-03-26 Thread Helge Deller
On 3/26/24 19:10, Richard Henderson wrote: Split trans_diag into per-operation functions. Signed-off-by: Richard Henderson Reviewed-by: Helge Deller Helge --- target/hppa/insns.decode | 8 +++- target/hppa/translate.c | 34 +- 2 files changed, 28

Re: [PATCH v2 3/3] target/hppa: Fix diag instructions to set/restore shadow registers

2024-03-26 Thread Helge Deller
On 3/26/24 19:10, Richard Henderson wrote: The 32-bit 7300LC CPU and the 64-bit PCX-W 8500 CPU use different I initially should have used the correct naming in my patch. So this sentence above should read: The 32-bit PA-7300LC (PCX-L2) CPU and the 64-bit PA8700 (PCX-W2) CPU use different

Re: [PATCH] tests/qtest: Standardize qtest function caller strings.

2024-03-26 Thread Fabiano Rosas
Het Gala writes: Some comments, mostly just thinking out loud... > For --> migrate > // > //O:/... > > For --> validate > ///O:/O:/ > /O:/O:/... Do we need an optional 'capability' element? I'm not sure how practical is to leave that as 'others', because that puts it at the end of the str

[PATCH for-9.0] tcg/optimize: Fix sign_mask for logical right-shift

2024-03-26 Thread Richard Henderson
The 'sign' computation is attempting to locate the sign bit that has been repeated, so that we can test if that bit is known zero. That computation can be zero if there are no known sign repetitions. Cc: qemu-sta...@nongnu.org Fixes: 93a967fbb57 ("tcg/optimize: Propagate sign info for shifting")

[PATCH v2 2/5] migration: Add migration parameters for QATzip

2024-03-26 Thread Bryan Zhang
Adds support for migration parameters to control QATzip compression level and to enable/disable software fallback when QAT hardware is unavailable. This is a preparatory commit for a subsequent commit that will actually use QATzip compression. Signed-off-by: Bryan Zhang Signed-off-by: Hao Xiang

[PATCH v2 1/5] meson: Introduce 'qatzip' feature to the build system

2024-03-26 Thread Bryan Zhang
Add a 'qatzip' feature, which is automatically disabled, and which depends on the QATzip library if enabled. Signed-off-by: Bryan Zhang Signed-off-by: Hao Xiang --- meson.build | 10 ++ meson_options.txt | 2 ++ scripts/meson-buildoptions.sh | 3 +++ 3 fi

[PATCH v2 3/5] migration: Introduce unimplemented 'qatzip' compression method

2024-03-26 Thread Bryan Zhang
Adds support for 'qatzip' as an option for the multifd compression method parameter, but copy-pastes the no-op logic to leave the actual methods effectively unimplemented. This is in preparation of a subsequent commit that will implement actually using QAT for compression and decompression. Signed

[PATCH v2 4/5] migration: Implement 'qatzip' methods using QAT

2024-03-26 Thread Bryan Zhang
Uses QAT to offload deflate compression and decompression in the 'qatzip' compression method for multifd migration. Signed-off-by: Bryan Zhang Signed-off-by: Hao Xiang --- migration/multifd-qatzip.c | 331 + 1 file changed, 298 insertions(+), 33 deletions(-)

[PATCH v2 5/5] tests/migration: Add integration test for 'qatzip' compression method

2024-03-26 Thread Bryan Zhang
Adds an integration test for 'qatzip'. Signed-off-by: Bryan Zhang Signed-off-by: Hao Xiang --- Revision: This commit now does some parameter setting to test that changing the 'multifd-qatzip-level' parameter works, and to enable software fallback so that the QATzip test can be run even if the te

[ANNOUNCE] QEMU 9.0.0-rc1 is now available

2024-03-26 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the second release candidate for the QEMU 9.0 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu.org/qemu-9.0.0-rc1.tar.xz http://download.qemu

RE: [PATCH v3] contrib/plugins/execlog: Fix compiler warning

2024-03-26 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Tuesday, March 26, 2024 8:04 PM > To: Peter Maydell > Cc: Pierrick Bouvier ; Yao, Xingtao/姚 幸涛 > ; qemu-devel@nongnu.org; alex.ben...@linaro.org; > erdn...@crans.org; ma.mando...@gmail.com > Subject: Re: [PATCH v3] contrib/plug

Re: [PATCH v2 1/2] hw/xen: detect when running inside stubdomain

2024-03-26 Thread Marek Marczykowski-Górecki
On Tue, Mar 26, 2024 at 05:06:50PM +, Anthony PERARD wrote: > On Tue, Mar 05, 2024 at 08:12:29PM +0100, Marek Marczykowski-Górecki wrote: > > diff --git a/hw/xen/xen-legacy-backend.c b/hw/xen/xen-legacy-backend.c > > index 124dd5f3d6..6bd4e6eb2f 100644 > > --- a/hw/xen/xen-legacy-backend.c > >

[RFC 0/2] disable the configuration interrupt for the unsupported device

2024-03-26 Thread Cindy Lu
we need a crash in Non-standard image, here is the jira for this https://issues.redhat.com/browse/RHEL-28522 The root cause of the issue is that an IRQFD was used without initialization.. During the booting process of the Vyatta image, the behavior of the called function in qemu is as follows:

[RFC 2/2] virtio-pci: check if the configure interrupt enable

2024-03-26 Thread Cindy Lu
If config_irq_enabled is not true, it means that configure interrupt is not supported. Therefore, the config vector will not be handled during the interrupt process. Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 41 +++-- 1 file changed, 23 insertions(+

[RFC 1/2] virtio-net: disable the configure interrupt for not support device

2024-03-26 Thread Cindy Lu
Only the vdpa device support configure interrupt, we need to disable the configure interrupt process in all other device. In order to achieve this, I added a check in the virtio_net_device_realize(). When the peer's type is vdpa, the value of config_irq_enabled in the structure VirtIODevice will se

[PATCH] mem/cxl_type3: fix hpa to dpa logic

2024-03-26 Thread Yao Xingtao via
In 3, 6, 12 interleave ways, we could not access cxl memory properly, and when the process is running on it, a 'segmentation fault' error will occur. According to the CXL specification '8.2.4.20.13 Decoder Protection', there are two branches to convert HPA to DPA: b1: Decoder[m].IW < 8 (for 1, 2,

[PATCH for 9.1 v3 0/2] meson: Fix MESONINTROSPECT parsing

2024-03-26 Thread Akihiko Odaki
: Paolo Bonzini Cc: Cleber Rosa Cc: John Snow Cc: Michael Tokarev Changes in v3: - Ensured meson>=1.4.0 on Windows. - Link to v2: https://lore.kernel.org/r/20240326-meson-v2-0-d9f900377...@daynix.com Changes in v2: - Added patch "buildsys: Bump known good meson version to v1.4.0".

[PATCH for 9.1 v3 2/2] meson: Fix MESONINTROSPECT parsing

2024-03-26 Thread Akihiko Odaki
The arguments in MESONINTROSPECT are quoted with shlex.quote() so it must be parsed with shlex.split(). meson<1.4.0 quotes arguments in MESONINTROSPECT with the Windows-specific format on the platform, which is incompatible with shlex.split(). meson>=1.4.0 uses shlex.quote() also on the platform a

[PATCH v2 1/2] virtio-net: Fix vhost virtqueue notifiers for RSS

2024-03-26 Thread Akihiko Odaki
virtio_net_guest_notifier_pending() and virtio_net_guest_notifier_mask() checked VIRTIO_NET_F_MQ to know there are multiple queues, but VIRTIO_NET_F_RSS also enables multiple queues. Refer to n->multiqueue, which is set to true either of VIRTIO_NET_F_MQ or VIRTIO_NET_F_RSS is enabled. Fixes: 68b0a

[PATCH v2 2/2] ebpf: Fix indirections table setting

2024-03-26 Thread Akihiko Odaki
The kernel documentation says: > The value stored can be of any size, however, all array elements are > aligned to 8 bytes. https://www.kernel.org/doc/html/v6.8/bpf/map_array.html Fixes: 333b3e5fab75 ("ebpf: Added eBPF map update through mmap.") Signed-off-by: Akihiko Odaki --- ebpf/ebpf_rss.c |

[PATCH v2 0/2] virtio-net: Fix RSS

2024-03-26 Thread Akihiko Odaki
Some recent changes made RSS unfunctional so here are fixes. Signed-off-by: Akihiko Odaki --- Changes in v2: - Fixed a potential problem with big-endian hosts. - Link to v1: https://lore.kernel.org/r/20240326-vhost-v1-0-09bd85b1b...@daynix.com --- Akihiko Odaki (2): virtio-net: Fix vhost

RE: [PATCH v5 1/7] docs/migration: add qpl compression feature

2024-03-26 Thread Liu, Yuan1
> -Original Message- > From: Peter Xu > Sent: Wednesday, March 27, 2024 1:58 AM > To: Liu, Yuan1 > Cc: faro...@suse.de; qemu-devel@nongnu.org; hao.xi...@bytedance.com; > bryan.zh...@bytedance.com; Zou, Nanhai > Subject: Re: [PATCH v5 1/7] docs/migration: add qpl compression feature > >

Re: [PATCH net v2 2/2] virtio_net: Do not send RSS key if it is not supported

2024-03-26 Thread Heng Qi
在 2024/3/26 下午11:19, Breno Leitao 写道: There is a bug when setting the RSS options in virtio_net that can break the whole machine, getting the kernel into an infinite loop. Running the following command in any QEMU virtual machine with virtionet will reproduce this problem: # ethtool -X

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-26 Thread Jason Wang
On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki wrote: > > On 2024/03/26 15:51, Jason Wang wrote: > > On Sun, Mar 24, 2024 at 4:32 PM Akihiko Odaki > > wrote: > >> > >> It is incorrect to have the VIRTIO_NET_HDR_F_NEEDS_CSUM set when > >> checksum offloading is disabled so clear the bit. Set the >

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-26 Thread Akihiko Odaki
On 2024/03/27 11:50, Jason Wang wrote: On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki wrote: On 2024/03/26 15:51, Jason Wang wrote: On Sun, Mar 24, 2024 at 4:32 PM Akihiko Odaki wrote: It is incorrect to have the VIRTIO_NET_HDR_F_NEEDS_CSUM set when checksum offloading is disabled so clear

Re: [RFC 1/2] virtio-net: disable the configure interrupt for not support device

2024-03-26 Thread Jason Wang
On Wed, Mar 27, 2024 at 9:29 AM Cindy Lu wrote: > > Only the vdpa device support configure interrupt, we need to disable the > configure interrupt process in all other device. I think we need to tweak the terminology here at least. It's not about configure interrupt, it's about whether or not we

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-26 Thread Jason Wang
On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki wrote: > > On 2024/03/27 11:50, Jason Wang wrote: > > On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki > > wrote: > >> > >> On 2024/03/26 15:51, Jason Wang wrote: > >>> On Sun, Mar 24, 2024 at 4:32 PM Akihiko Odaki > >>> wrote: > > It is in

Re: [PATCH for-9.1 v5 2/3] target/i386: add guest-phys-bits cpu property

2024-03-26 Thread Xiaoyao Li
On 3/25/2024 10:14 PM, Paolo Bonzini wrote: From: Gerd Hoffmann Allows to set guest-phys-bits (cpuid leaf 8008, eax[23:16]) via -cpu $model,guest-phys-bits=$nr. Signed-off-by: Gerd Hoffmann Message-ID: <20240318155336.156197-3-kra...@redhat.com> Signed-off-by: Paolo Bonzini Reviewed-by

Re: [RFC 0/2] disable the configuration interrupt for the unsupported device

2024-03-26 Thread Jason Wang
Hi Cindy: On Wed, Mar 27, 2024 at 9:29 AM Cindy Lu wrote: > > we need a crash in Non-standard image, here is the jira for this > https://issues.redhat.com/browse/RHEL-28522 > The root cause of the issue is that an IRQFD was used without initialization.. > > During the booting process of the Vyat

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-26 Thread Akihiko Odaki
On 2024/03/27 11:59, Jason Wang wrote: On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki wrote: On 2024/03/27 11:50, Jason Wang wrote: On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki wrote: On 2024/03/26 15:51, Jason Wang wrote: On Sun, Mar 24, 2024 at 4:32 PM Akihiko Odaki wrote: It is inc

[PATCH v3 0/2] Changes necessary to work inside Xen device model stubdomain

2024-03-26 Thread Marek Marczykowski-Górecki
This is minimal set of changes necessary to run Xen device model inside a stubdomain and still support PCI passthrough. Marek Marczykowski-Górecki (2): hw/xen: detect when running inside stubdomain xen: fix stubdom PCI addr hw/i386/xen/xen-hvm.c| 22 +++- hw/xen/xen-host-pci-

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-26 Thread Jason Wang
On Wed, Mar 27, 2024 at 11:05 AM Akihiko Odaki wrote: > > On 2024/03/27 11:59, Jason Wang wrote: > > On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki > > wrote: > >> > >> On 2024/03/27 11:50, Jason Wang wrote: > >>> On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki > >>> wrote: > > On 2024

[PATCH v3 1/2] hw/xen: detect when running inside stubdomain

2024-03-26 Thread Marek Marczykowski-Górecki
Introduce global xen_is_stubdomain variable when qemu is running inside a stubdomain instead of dom0. This will be relevant for subsequent patches, as few things like accessing PCI config space need to be done differently. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v3: - move to xen

[PATCH v3 2/2] xen: fix stubdom PCI addr

2024-03-26 Thread Marek Marczykowski-Górecki
When running in a stubdomain, the config space access via sysfs needs to use BDF as seen inside stubdomain (connected via xen-pcifront), which is different from the real BDF. For other purposes (hypercall parameters etc), the real BDF needs to be used. Get the in-stubdomain BDF by looking up releva

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-26 Thread Akihiko Odaki
On 2024/03/27 12:06, Jason Wang wrote: On Wed, Mar 27, 2024 at 11:05 AM Akihiko Odaki wrote: On 2024/03/27 11:59, Jason Wang wrote: On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki wrote: On 2024/03/27 11:50, Jason Wang wrote: On Tue, Mar 26, 2024 at 3:04 PM Akihiko Odaki wrote: On 2024/

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-26 Thread Jason Wang
On Wed, Mar 27, 2024 at 11:11 AM Akihiko Odaki wrote: > > On 2024/03/27 12:06, Jason Wang wrote: > > On Wed, Mar 27, 2024 at 11:05 AM Akihiko Odaki > > wrote: > >> > >> On 2024/03/27 11:59, Jason Wang wrote: > >>> On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki > >>> wrote: > > On 202

Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-26 Thread Akihiko Odaki
On 2024/03/27 12:24, Jason Wang wrote: On Wed, Mar 27, 2024 at 11:11 AM Akihiko Odaki wrote: On 2024/03/27 12:06, Jason Wang wrote: On Wed, Mar 27, 2024 at 11:05 AM Akihiko Odaki wrote: On 2024/03/27 11:59, Jason Wang wrote: On Wed, Mar 27, 2024 at 10:53 AM Akihiko Odaki wrote: On 2024

[PATCH v5 0/2] Improved Memory Tier Creation for CPUless NUMA Nodes

2024-03-26 Thread Ho-Ren (Jack) Chuang
When a memory device, such as CXL1.1 type3 memory, is emulated as normal memory (E820_TYPE_RAM), the memory device is indistinguishable from normal DRAM in terms of memory tiering with the current implementation. The current memory tiering assigns all detected normal memory nodes to the same DRAM t

[PATCH v5 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-03-26 Thread Ho-Ren (Jack) Chuang
The current implementation treats emulated memory devices, such as CXL1.1 type3 memory, as normal DRAM when they are emulated as normal memory (E820_TYPE_RAM). However, these emulated devices have different characteristics than traditional DRAM, making it important to distinguish them. Thus, we mod

[PATCH v5 1/2] memory tier: dax/kmem: introduce an abstract layer for finding, allocating, and putting memory types

2024-03-26 Thread Ho-Ren (Jack) Chuang
Since different memory devices require finding, allocating, and putting memory types, these common steps are abstracted in this patch, enhancing the scalability and conciseness of the code. Signed-off-by: Ho-Ren (Jack) Chuang --- drivers/dax/kmem.c | 20 ++-- include/li

Re: [PULL 35/38] spapr: nested: Introduce H_GUEST_[GET|SET]_STATE hcalls.

2024-03-26 Thread Harsh Prateek Bora
On 3/26/24 21:32, Peter Maydell wrote: On Tue, 12 Mar 2024 at 17:11, Nicholas Piggin wrote: From: Harsh Prateek Bora Introduce the nested PAPR hcalls: - H_GUEST_GET_STATE which is used to get state of a nested guest or a guest VCPU. The value field for each element in the requ

Re: [PATCH v5 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-03-26 Thread Huang, Ying
"Ho-Ren (Jack) Chuang" writes: > The current implementation treats emulated memory devices, such as > CXL1.1 type3 memory, as normal DRAM when they are emulated as normal memory > (E820_TYPE_RAM). However, these emulated devices have different > characteristics than traditional DRAM, making it im

Re: [PATCH v2 0/4] linux-user: Fix shmat(NULL) for h != g

2024-03-26 Thread Richard Henderson
On 3/25/24 09:22, Ilya Leoshkevich wrote: v1: https://lore.kernel.org/qemu-devel/20240325153313.526888-1-...@linux.ibm.com/ v1 -> v2: Remove an unnecessary ifdef, add R-Bs (Richard). Hi, I noticed that while shmat() now works with /proc/self/maps, shmat(NULL) got broken. This series fixes that

Re: [PATCH-for-9.1 v2 3/3] exec: Rename NEED_CPU_H -> COMPILING_PER_TARGET

2024-03-26 Thread Richard Henderson
On 3/22/24 06:14, Philippe Mathieu-Daudé wrote: 'NEED_CPU_H' guard target-specific code; it is defined by meson altogether with the 'CONFIG_TARGET' definition. Rename NEED_CPU_H as COMPILING_PER_TARGET to clarify its meaning. Mechanical change running: $ sed -i s/NEED_CPU_H/COMPILING_PER_TARG

Re: [PATCH-for-9.1 v2 1/3] gdbstub: Simplify #ifdef'ry in helpers.h

2024-03-26 Thread Richard Henderson
On 3/22/24 06:14, Philippe Mathieu-Daudé wrote: Slightly simplify by checking NEED_CPU_H definition in header. Signed-off-by: Philippe Mathieu-Daudé --- include/gdbstub/helpers.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) Reviewed-by: Richard Henderson r~

Re: [RFC 0/2] disable the configuration interrupt for the unsupported device

2024-03-26 Thread Cindy Lu
On Wed, Mar 27, 2024 at 11:05 AM Jason Wang wrote: > > Hi Cindy: > > On Wed, Mar 27, 2024 at 9:29 AM Cindy Lu wrote: > > > > we need a crash in Non-standard image, here is the jira for this > > https://issues.redhat.com/browse/RHEL-28522 > > The root cause of the issue is that an IRQFD was used

[PATCH] hw/virtio: Fix packed virtqueue flush used_idx

2024-03-26 Thread Wafer
For indirect descriptors the elelm->ndescs was one, For direct descriptors the elele->ndesc was the numbe of entries. elem->ndescs = (desc_cache == &indirect_desc_cache) ? 1 : elem_entries; When flushing multiple elemes, the used_idx should be added to all the privious numeric entry value. Signed

Re: [External] Re: [PATCH v5 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-03-26 Thread Ho-Ren (Jack) Chuang
On Tue, Mar 26, 2024 at 10:52 PM Huang, Ying wrote: > > "Ho-Ren (Jack) Chuang" writes: > > > The current implementation treats emulated memory devices, such as > > CXL1.1 type3 memory, as normal DRAM when they are emulated as normal memory > > (E820_TYPE_RAM). However, these emulated devices have

<    1   2   3