Re: [PATCH v5 5/7] migration/multifd: implement initialization of qpl compression

2024-03-20 Thread Peter Xu
On Wed, Mar 20, 2024 at 03:02:59PM +, Liu, Yuan1 wrote: > > > +static int alloc_zbuf(QplData *qpl, uint8_t chan_id, Error **errp) > > > +{ > > > +int flags = MAP_PRIVATE | MAP_POPULATE | MAP_ANONYMOUS; > > > +uint32_t size = qpl->job_num * qpl->data_size; > > > +uint8_t *buf; > > >

Re: [PATCH 0/9] Introduce support for IGVM files

2024-03-20 Thread Ani Sinha
> On 27 Feb 2024, at 20:20, Roy Hopkins wrote: > > Hi everyone, > > This initial patch series submission adds the capability to configure > confidential guests using files that conform to the Independent Guest Virtual > Machine (IGVM) file format. The series is based on the master branch comm

Re: [PATCH v5 7/7] tests/migration-test: add qpl compression test

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 03:30:40PM +, Liu, Yuan1 wrote: > > -Original Message- > > From: Daniel P. Berrangé > > Sent: Wednesday, March 20, 2024 6:46 PM > > To: Liu, Yuan1 > > Cc: pet...@redhat.com; faro...@suse.de; qemu-devel@nongnu.org; > > hao.xi...@bytedance.com; bryan.zh...@byteda

Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-03-20 Thread Mark Burton
> On 20 Mar 2024, at 16:00, Peter Maydell wrote: > > WARNING: This email originated from outside of Qualcomm. Please be wary of > any links or attachments, and do not enable macros. > > On Wed, 20 Mar 2024 at 14:10, Mark Burton wrote: >> I’d broaden this to all ’signals’ (IRQ, Reset etc) - a

Re: [PATCH 9/9] docs/system: Add documentation on support for IGVM

2024-03-20 Thread Roy Hopkins
On Mon, 2024-03-18 at 16:21 +, Daniel P. Berrangé wrote: > On Mon, Mar 18, 2024 at 03:59:31PM +, Roy Hopkins wrote: > > On Fri, 2024-03-01 at 17:10 +, Daniel P. Berrangé wrote: > > > On Tue, Feb 27, 2024 at 02:50:15PM +, Roy Hopkins wrote: > > > > IGVM support has been implemented f

Re: [PATCH v3 6/7] qga/commands-posix: don't do fork()/exec() when suspending via sysfs

2024-03-20 Thread Andrey Drobyshev
On 3/19/24 20:02, Daniel P. Berrangé wrote: > On Fri, Mar 15, 2024 at 02:29:45PM +0200, Andrey Drobyshev wrote: >> Since commit 246d76eba ("qga: guest_suspend: decoupling pm-utils and sys >> logic") pm-utils logic is running in a separate child from the sysfs >> logic. Now when suspending via sysf

Re: [PATCH v3 1/7] qga: guest-get-fsinfo: add optional 'total-bytes-root' field

2024-03-20 Thread Andrey Drobyshev
On 3/19/24 19:37, Daniel P. Berrangé wrote: > On Fri, Mar 15, 2024 at 02:29:40PM +0200, Andrey Drobyshev wrote: >> Since the commit 25b5ff1a86 ("qga: add mountpoint usage info to >> GuestFilesystemInfo") we have 2 values reported in guest-get-fsinfo: >> used = (f_blocks - f_bfree), total = (f_block

Re: [PATCH 9/9] docs/system: Add documentation on support for IGVM

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 03:45:24PM +, Roy Hopkins wrote: > On Mon, 2024-03-18 at 16:21 +, Daniel P. Berrangé wrote: > > On Mon, Mar 18, 2024 at 03:59:31PM +, Roy Hopkins wrote: > > > On Fri, 2024-03-01 at 17:10 +, Daniel P. Berrangé wrote: > > > > On Tue, Feb 27, 2024 at 02:50:15PM

Re: Intention to work on GSoC project

2024-03-20 Thread Eugenio Perez Martin
On Sat, Mar 16, 2024 at 9:27 PM Sahil wrote: > > Hi, > > Thank you for your reply. > > On Friday, March 15, 2024 4:57:39 PM IST Eugenio Perez Martin wrote: > > [...] > > > Some sections in the above docs were difficult to grasp. For the time > > > being, I have focused on those parts that I though

Re: [PATCH v3 09/49] kvm: Enable KVM_SET_USER_MEMORY_REGION2 for memslot

2024-03-20 Thread Paolo Bonzini
On 3/20/24 09:39, Michael Roth wrote: +if (cap_user_memory2 == -1) { +cap_user_memory2 = kvm_check_extension(s, KVM_CAP_USER_MEMORY2); +} + +if (!cap_user_memory2 && slot->guest_memfd >= 0) { +error_report("%s, KVM doesn't support KVM_CAP_USER_MEMORY2," +

Re: [PATCH v3 10/49] kvm: Introduce support for memory_attributes

2024-03-20 Thread Paolo Bonzini
On 3/20/24 09:39, Michael Roth wrote: From: Xiaoyao Li Introduce the helper functions to set the attributes of a range of memory to private or shared. This is necessary to notify KVM the private/shared attribute of each gpa range. KVM needs the information to decide the GPA needs to be mapped

RE: [PATCH v5 5/7] migration/multifd: implement initialization of qpl compression

2024-03-20 Thread Liu, Yuan1
> -Original Message- > From: Daniel P. Berrangé > Sent: Wednesday, March 20, 2024 11:21 PM > To: Liu, Yuan1 > Cc: pet...@redhat.com; faro...@suse.de; qemu-devel@nongnu.org; > hao.xi...@bytedance.com; bryan.zh...@bytedance.com; Zou, Nanhai > > Subject: Re: [PATCH v5 5/7] migration/multifd

[PULL 2/5] tests/avocado: update sbsa-ref firmware

2024-03-20 Thread Alex Bennée
From: Marcin Juszkiewicz We now have CI job to build those and publish in space with readable urls. Firmware is built using Debian 'bookworm' cross toolchain (gcc 12.2.0). Used versions: - Trusted Firmware v2.10.2 - Tianocore EDK2 stable202402 - Tianocore EDK2 Platforms code commit 085c2fb Si

[PULL 5/5] tests/avocado: sbsa-ref: add OpenBSD tests for misc 'max' setup

2024-03-20 Thread Alex Bennée
From: Marcin Juszkiewicz PAuth makes run timeout on CI so add tests using 'max' without it and with impdef one. Signed-off-by: Marcin Juszkiewicz Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20240318-sbsa-ref-firmware-update-v3-4-1c33b995a...@linaro.org>

[PULL 4/5] tests/avocado: sbsa-ref: add Alpine tests for misc 'max' setup

2024-03-20 Thread Alex Bennée
From: Marcin Juszkiewicz PAuth makes run timeout on CI so add tests using 'max' without it and with impdef one. Signed-off-by: Marcin Juszkiewicz Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20240318-sbsa-ref-firmware-update-v3-3-1c33b995a...@linaro.org>

[PULL 1/5] gitlab: aggressively avoid extra GIT data

2024-03-20 Thread Alex Bennée
This avoids fetching blobs and tree references for branches we are not going to worry about. Also skip tag references which are similarly not useful and keep the default --prune. This keeps the .git data to around 100M rather than the ~400M even a shallow clone takes. So we can check the savings w

[PULL 0/5] more maintainer updates (git, avocado)

2024-03-20 Thread Alex Bennée
The following changes since commit c62d54d0a8067ffb3d5b909276f7296d7df33fa7: Update version for v9.0.0-rc0 release (2024-03-19 19:13:52 +) are available in the Git repository at: https://gitlab.com/stsquad/qemu.git tags/pull-maintainer-final-for-real-this-time-200324-1 for you to fetch

[PULL 3/5] tests/avocado: drop virtio-rng from sbsa-ref tests

2024-03-20 Thread Alex Bennée
From: Marcin Juszkiewicz sbsa-ref is supposed to emulate real hardware so virtio-rng-pci does not fit here Signed-off-by: Marcin Juszkiewicz Message-Id: <20240318-sbsa-ref-firmware-update-v3-2-1c33b995a...@linaro.org> Signed-off-by: Alex Bennée diff --git a/tests/avocado/machine_aarch64_sbsar

Re: [PATCH for-9.1 v5 09/14] memory: Add Error** argument to .log_global_start() handler

2024-03-20 Thread Cédric Le Goater
On 3/20/24 15:42, Peter Xu wrote: On Wed, Mar 20, 2024 at 07:49:05AM +0100, Cédric Le Goater wrote: Modify all .log_global_start() handlers to take an Error** parameter and return a bool. Adapt memory_global_dirty_log_start() to interrupt on the first error the loop on handlers. In such case, a

[PATCH v4 2/7] qga: introduce ga_run_command() helper for guest cmd execution

2024-03-20 Thread Andrey Drobyshev
When executing guest commands in *nix environment, we repeat the same fork/exec pattern multiple times. Let's just separate it into a single helper which would also be able to feed input data into the launched process' stdin. This way we can avoid code duplication. To keep the history more bisec

[PATCH v4 7/7] qga/commands-posix: qmp_guest_set_user_password: use ga_run_command helper

2024-03-20 Thread Andrey Drobyshev
There's no need to check for the existence of the "chpasswd", "pw" executables, as the exec() call will do that for us. Signed-off-by: Andrey Drobyshev Reviewed-by: Daniel P. Berrangé --- qga/commands-posix.c | 96 ++-- 1 file changed, 13 insertions(+), 8

[PATCH v4 4/7] qga/commands-posix: qmp_guest_set_time: use ga_run_command helper

2024-03-20 Thread Andrey Drobyshev
There's no need to check for the existence of "/sbin/hwclock", the exec() call will do that for us. Signed-off-by: Andrey Drobyshev Reviewed-by: Daniel P. Berrangé --- qga/commands-posix.c | 43 +++ 1 file changed, 3 insertions(+), 40 deletions(-) diff -

[PATCH v4 6/7] qga/commands-posix: don't do fork()/exec() when suspending via sysfs

2024-03-20 Thread Andrey Drobyshev
Since commit 246d76eba ("qga: guest_suspend: decoupling pm-utils and sys logic") pm-utils logic is running in a separate child from the sysfs logic. Now when suspending via sysfs we don't really need to do that in a separate process as we only need to perform one write to /sys/power/state. Let's

[PATCH v4 5/7] qga/commands-posix: execute_fsfreeze_hook: use ga_run_command helper

2024-03-20 Thread Andrey Drobyshev
There's no need to check for the existence of the hook executable, as the exec() call will do that for us. Signed-off-by: Andrey Drobyshev Reviewed-by: Daniel P. Berrangé --- qga/commands-posix.c | 35 +++ 1 file changed, 3 insertions(+), 32 deletions(-) diff --

<    1   2   3   4