Re: [RFC PATCH v8 06/23] target/arm: Add support for Non-maskable Interrupt

2024-03-20 Thread Jinjie Ruan via
On 2024/3/20 3:26, Peter Maydell wrote: > On Tue, 19 Mar 2024 at 18:51, Richard Henderson > wrote: >> >> On 3/19/24 07:28, Peter Maydell wrote: switch (excp_idx) { +case EXCP_NMI: +pstate_unmasked = !allIntMask; +break; + +case EXCP_VN

Re: [PATCH v3 37/49] i386/sev: Add the SNP launch start context

2024-03-20 Thread Paolo Bonzini
On 3/20/24 09:39, Michael Roth wrote: From: Brijesh Singh The SNP_LAUNCH_START is called first to create a cryptographic launch context within the firmware. Signed-off-by: Brijesh Singh Signed-off-by: Michael Roth --- target/i386/sev.c| 42 +++-

Re: [PATCH RFC v3 00/49] Add AMD Secure Nested Paging (SEV-SNP) support

2024-03-20 Thread Paolo Bonzini
On 3/20/24 09:38, Michael Roth wrote: These patches implement SEV-SNP base support along with CPUID enforcement support for QEMU, and are also available at: https://github.com/amdese/qemu/commits/snp-v3-rfc they are based on top of the following patchset from Paolo: "[PATCH 0/7] target/i

[PATCH] meson: remove dead dictionary access

2024-03-20 Thread Paolo Bonzini
The "link_depends" key has not been used since commit c46f76d1586 ("meson: specify fuzz linker script as a project arg", 2020-09-08), and even before that it was only used for fork-fuzzing which we removed in commit d2e6f9272d3 ("fuzz: remove fork-fuzzing scaffolding", 2023-02-16). So, remove it f

Re: [PATCH v5 3/7] configure: add --enable-qpl build option

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 12:45:23AM +0800, Yuan Liu wrote: > add --enable-qpl and --disable-qpl options to enable and disable > the QPL compression method for multifd migration. > > the Query Processing Library (QPL) is an open-source library > that supports data compression and decompression featu

[PULL 4/6] target/i386: Revert monitor_puts() in do_inject_x86_mce()

2024-03-20 Thread Paolo Bonzini
From: Tao Su monitor_puts() doesn't check the monitor pointer, but do_inject_x86_mce() may have a parameter with NULL monitor pointer. Revert monitor_puts() in do_inject_x86_mce() to fix, then the fact that we send the same message to monitor and log is again more obvious. Fixes: bf0c50d4aa85 (m

[PULL 0/6] QEMU bug fixes for 20240320

2024-03-20 Thread Paolo Bonzini
The following changes since commit ba49d760eb04630e7b15f423ebecf6c871b8f77b: Merge tag 'pull-maintainer-final-130324-1' of https://gitlab.com/stsquad/qemu into staging (2024-03-13 15:12:14 +) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream

[PULL 1/6] target/i386: fix direction of "32-bit MMU" test

2024-03-20 Thread Paolo Bonzini
The low bit of MMU indices for x86 TCG indicates whether the processor is in 32-bit mode and therefore linear addresses have to be masked to 32 bits. However, the index was computed incorrectly, leading to possible conflicts in the TLB for any address above 4G. Analyzed-by: Mark Cave-Ayland Fixes

[PULL 3/6] vl: do not assert if sev-guest is used together with TCG

2024-03-20 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- system/vl.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/system/vl.c b/system/vl.c index 0c970cf0203..c6442229824 100644 --- a/system/vl.c +++ b/system/vl.c @@ -2676,11 +2676,10 @@ static bool qemu_machine_creation_done(Error **errp

[PULL 5/6] tests/plugins: fix use-after-free bug

2024-03-20 Thread Paolo Bonzini
rec->count.score is inside rec, which is freed before rec->count.score is. Reorder the instructions Reported by Coverity as CID 1539967. Cc: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- contrib/plugins/howvec.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[PULL 6/6] meson: remove dead dictionary access

2024-03-20 Thread Paolo Bonzini
The "link_depends" key has not been used since commit c46f76d1586 ("meson: specify fuzz linker script as a project arg", 2020-09-08), and even before that it was only used for fork-fuzzing which we removed in commit d2e6f9272d3 ("fuzz: remove fork-fuzzing scaffolding", 2023-02-16). So, remove it f

[PULL 2/6] vl: convert qemu_machine_creation_done() to Error **

2024-03-20 Thread Paolo Bonzini
Allow using Error ** to pass an error string up to qmp_x_exit_preconfig() and possibly main(). Signed-off-by: Paolo Bonzini --- system/vl.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/system/vl.c b/system/vl.c index 70f4cece7f9..0c970cf0203 100644 --- a/system/

Re: [PATCH v3 0/1] Introduce Icelake-Server-v7 to enable TSX

2024-03-20 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH v2] target/i386: Add new CPU model SierraForest

2024-03-20 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH] target/i386: Export RFDS bit to guests

2024-03-20 Thread Paolo Bonzini
Queued, thanks. Paolo

[PATCH 1/6] .travis.yml: Shorten the runtime of the problematic jobs

2024-03-20 Thread Thomas Huth
The "[s390x] GCC (other-system)" and the "[s390x] GCC check-tcg" jobs are hitting the 50 minutes timeout in Travis quite frequently since a while. To fix it, we've got to drop a lot of the targets from the target list in the jobs to make them work again. With regards to the "check-tcg" test, we c

[PATCH 5/6] .travis.yml: Remove the unused UNRELIABLE environment variable

2024-03-20 Thread Thomas Huth
This variable was used to allow jobs to fail without spoiling the overall result. But the required "allow_failures:" hunk has been accidentally removed in commit 9d03f5abed ("travis.yml: Remove the "Release tarball" job"), and it was anyway only useful while we still had the x86 jobs here around th

[PATCH 4/6] .travis.yml: Update the jobs to Ubuntu 22.04

2024-03-20 Thread Thomas Huth
According to our support policy, we'll soon drop our official support for Ubuntu 20.04 ("Focal Fossa") in QEMU. Thus we should update the Travis jobs now to a newer release (Ubuntu 22.04 - "Jammy Jellyfish") for future testing. Since all jobs are using this release now, we can drop the entries from

[PATCH 2/6] .travis.yml: Remove the unused xfslib-dev package

2024-03-20 Thread Thomas Huth
Drop the "xfslibs-dev" package which should not be necessary anymore since commit a5730b8bd3 ("block/file-posix: Simplify the XFS_IOC_DIOINFO handling"). Signed-off-by: Thomas Huth --- .travis.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index a8d1e12190..8a3a

[PATCH 3/6] Revert ".travis.yml: Cache Avocado cache"

2024-03-20 Thread Thomas Huth
This reverts commit c1073e44b46490133e16420e1784dec7bcd4e030. The Avocado tests have been removed from Travis a long time ago with commit c5008c76ee ("gitlab: add acceptance testing to system builds"), so we don't need to cache the avocado files here anymore. Signed-off-by: Thomas Huth --- .tra

Re: [PATCH v5 5/7] migration/multifd: implement initialization of qpl compression

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 12:45:25AM +0800, Yuan Liu wrote: > the qpl initialization includes memory allocation for compressed > data and the qpl job initialization. > > the qpl initialization will check whether the In-Memory Analytics > Accelerator(IAA) hardware is available, if the platform does n

[PATCH 0/6] Updates for the .travis.yml file

2024-03-20 Thread Thomas Huth
The Travis-CI has been quite neglected in recent times. I now finally found some spare minutes to fix some issues with time-outs, clean up some old cruft and update the jobs to a newer version of Ubuntu. Thomas Huth (6): .travis.yml: Shorten the runtime of the problematic jobs .travis.yml: Rem

[PATCH 6/6] .travis.yml: Do some more testing with Clang

2024-03-20 Thread Thomas Huth
We are doing a lot of cross-compilation tests with GCC in the gitlab-CI already, so we could get some more test coverage by using Clang in the Travis-CI instead. Thus let's switch two additional jobs to use Clang for compilation. Signed-off-by: Thomas Huth --- .travis.yml | 6 -- 1 file chan

Re: [PATCH v5 7/7] tests/migration-test: add qpl compression test

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 12:45:27AM +0800, Yuan Liu wrote: > add qpl to compression method test for multifd migration > > the migration with qpl compression needs to access IAA hardware > resource, please run "check-qtest" with sudo or root permission, > otherwise migration test will fail That's n

Re: [PATCH] Implement SSH commands in QEMU GA for Windows

2024-03-20 Thread Daniel P . Berrangé
On Tue, Mar 19, 2024 at 06:17:24PM +, aidan_le...@selinc.com wrote: > From: aidaleuc > > Signed-off-by: aidaleuc > --- > qga/commands-posix-ssh.c | 47 +-- > qga/commands-ssh-core.c| 52 +++ > qga/commands-ssh-core.h| 20 ++ > qga/commands-windows-ssh.c | 686 ++

Re: [PATCH 2/6] .travis.yml: Remove the unused xfslib-dev package

2024-03-20 Thread Philippe Mathieu-Daudé
On 20/3/24 11:41, Thomas Huth wrote: Drop the "xfslibs-dev" package which should not be necessary anymore since commit a5730b8bd3 ("block/file-posix: Simplify the XFS_IOC_DIOINFO handling"). Signed-off-by: Thomas Huth --- .travis.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.travis

Re: [PATCH 4/6] .travis.yml: Update the jobs to Ubuntu 22.04

2024-03-20 Thread Philippe Mathieu-Daudé
On 20/3/24 11:41, Thomas Huth wrote: According to our support policy, we'll soon drop our official support for Ubuntu 20.04 ("Focal Fossa") in QEMU. Thus we should update the Travis jobs now to a newer release (Ubuntu 22.04 - "Jammy Jellyfish") for future testing. Since all jobs are using this re

Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-03-20 Thread Philippe Mathieu-Daudé
On 20/2/24 16:19, Thomas Huth wrote: On 20/02/2024 16.08, Philippe Mathieu-Daudé wrote: Have s390x always deliver NMI to the first CPU, remove the @cpu_index argument from handler, rename API as nmi_trigger() (not monitor specific). Could you please add some rationale here why this is needed /

Re: [PATCH 4/6] .travis.yml: Update the jobs to Ubuntu 22.04

2024-03-20 Thread Peter Maydell
On Wed, 20 Mar 2024 at 11:13, Philippe Mathieu-Daudé wrote: > > On 20/3/24 11:41, Thomas Huth wrote: > > According to our support policy, we'll soon drop our official support > > for Ubuntu 20.04 ("Focal Fossa") in QEMU. Thus we should update the > > Travis jobs now to a newer release (Ubuntu 22.0

Re: [PATCH] Implement SSH commands in QEMU GA for Windows

2024-03-20 Thread Marc-André Lureau
Hi On Wed, Mar 20, 2024 at 12:39 AM wrote: > +// Converts from a standard string to a Windows wide string. > +// it is a 16-bit wide character used to store Unicode encoded as UTF-16LE/ > +// some Windows API functions require this format of the string as opposed > to just > +// the normal c cha

Re: [PATCH v3 21/49] i386/sev: Introduce "sev-common" type to encapsulate common SEV state

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 03:39:17AM -0500, Michael Roth wrote: > Currently all SEV/SEV-ES functionality is managed through a single > 'sev-guest' QOM type. With upcoming support for SEV-SNP, taking this > same approach won't work well since some of the properties/state > managed by 'sev-guest' is no

Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-03-20 Thread Mark Burton
> On 20 Mar 2024, at 12:19, Philippe Mathieu-Daudé wrote: > > WARNING: This email originated from outside of Qualcomm. Please be wary of > any links or attachments, and do not enable macros. > > On 20/2/24 16:19, Thomas Huth wrote: >> On 20/02/2024 16.08, Philippe Mathieu-Daudé wrote: >>> Hav

Re: [PATCH v3 21/49] i386/sev: Introduce "sev-common" type to encapsulate common SEV state

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 03:39:17AM -0500, Michael Roth wrote: > Currently all SEV/SEV-ES functionality is managed through a single > 'sev-guest' QOM type. With upcoming support for SEV-SNP, taking this > same approach won't work well since some of the properties/state > managed by 'sev-guest' is no

Re: [PATCH v3 22/49] i386/sev: Introduce 'sev-snp-guest' object

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 03:39:18AM -0500, Michael Roth wrote: > From: Brijesh Singh > > SEV-SNP support relies on a different set of properties/state than the > existing 'sev-guest' object. This patch introduces the 'sev-snp-guest' > object, which can be used to configure an SEV-SNP guest. For ex

Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-03-20 Thread Peter Maydell
On Wed, 20 Mar 2024 at 11:20, Philippe Mathieu-Daudé wrote: > > On 20/2/24 16:19, Thomas Huth wrote: > > On 20/02/2024 16.08, Philippe Mathieu-Daudé wrote: > >> Have s390x always deliver NMI to the first CPU, > >> remove the @cpu_index argument from handler, > >> rename API as nmi_trigger() (not m

Re: [PATCH v3 31/49] i386/sev: Update query-sev QAPI format to handle SEV-SNP

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 03:39:27AM -0500, Michael Roth wrote: > Most of the current 'query-sev' command is relevant to both legacy > SEV/SEV-ES guests and SEV-SNP guests, with 2 exceptions: > > - 'policy' is a 64-bit field for SEV-SNP, not 32-bit, and > the meaning of the bit positions has c

Re: [PATCH v3 32/49] i386/sev: Don't return launch measurements for SEV-SNP guests

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 03:39:28AM -0500, Michael Roth wrote: > For SEV-SNP guests, launch measurement is queried from within the guest > during attestation, so don't attempt to return it as part of > query-sev-launch-measure. > > Signed-off-by: Michael Roth > --- > target/i386/sev.c | 4 +++- >

Re: [PATCH v3 42/49] i386/sev: Add support for SNP CPUID validation

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 03:39:38AM -0500, Michael Roth wrote: > SEV-SNP firmware allows a special guest page to be populated with a > table of guest CPUID values so that they can be validated through > firmware before being loaded into encrypted guest memory where they can > be used in place of hyp

Re: [PATCH v3 43/49] qapi, i386: Move kernel-hashes to SevCommonProperties

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 03:39:39AM -0500, Michael Roth wrote: > From: Dov Murik > > In order to enable kernel-hashes for SNP, pull it from > SevGuestProperties to its parent SevCommonProperties so > it will be available for both SEV and SNP. > > Signed-off-by: Dov Murik > Signed-off-by: Michael

Re: [PATCH v3 47/49] hw/i386/sev: Add support to encrypt BIOS when SEV-SNP is enabled

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 03:39:43AM -0500, Michael Roth wrote: > TODO: Brijesh as author, me as co-author (vice-versa depending) > drop flash handling? we only support BIOS now A reminder that this commit message needs fixing. > > Signed-off-by: Michael Roth > --- > hw/i386/pc_sysfw.c

Re: [PATCH v3 32/49] i386/sev: Don't return launch measurements for SEV-SNP guests

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 12:15:00PM +, Daniel P. Berrangé wrote: > On Wed, Mar 20, 2024 at 03:39:28AM -0500, Michael Roth wrote: > > For SEV-SNP guests, launch measurement is queried from within the guest > > during attestation, so don't attempt to return it as part of > > query-sev-launch-measu

Re: [PATCH] Implement SSH commands in QEMU GA for Windows

2024-03-20 Thread Konstantin Kostiuk
On Tue, Mar 19, 2024 at 8:18 PM wrote: > From: aidaleuc > > Signed-off-by: aidaleuc > --- > qga/commands-posix-ssh.c | 47 +-- > qga/commands-ssh-core.c| 52 +++ > qga/commands-ssh-core.h| 20 ++ > qga/commands-windows-ssh.c | 686 + > qga/meson

Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-03-20 Thread Mark Burton
> On 20 Mar 2024, at 13:00, Peter Maydell wrote: > > WARNING: This email originated from outside of Qualcomm. Please be wary of > any links or attachments, and do not enable macros. > > On Wed, 20 Mar 2024 at 11:20, Philippe Mathieu-Daudé > wrote: >> >> On 20/2/24 16:19, Thomas Huth wrote:

Re: [PATCH v3 28/49] i386/sev: Disable SMM for SNP

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 03:39:24AM -0500, Michael Roth wrote: > SNP does not support SMM. > > Signed-off-by: Michael Roth > --- > target/i386/sev.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/target/i386/sev.c b/target/i386/sev.c > index b06c796aae..134e8f7c22 100644 > ---

Re: [PATCH v3 29/49] i386/sev: Don't disable block discarding for SNP

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 03:39:25AM -0500, Michael Roth wrote: > SEV/SEV-ES rely on pinned memory to back guest RAM so discarding > isn't actually possible. With SNP, only guest_memfd pages are used > for private guest memory, so discarding of shared memory is still > possible, so only disable disca

Re: [PATCH v3 23/49] i386/sev: Add a sev_snp_enabled() helper

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 03:39:19AM -0500, Michael Roth wrote: > Add a simple helper to check if the current guest type is SNP. Also have > SNP-enabled imply that SEV-ES is enabled as well, and fix up any places > where the sev_es_enabled() check is expecting a pure/non-SNP guest. > > Signed-off-by

Re: [PATCH v3 11/49] physmem: Introduce ram_block_discard_guest_memfd_range()

2024-03-20 Thread Xiaoyao Li
On 3/20/2024 5:37 PM, David Hildenbrand wrote: On 20.03.24 09:39, Michael Roth wrote: From: Xiaoyao Li When memory page is converted from private to shared, the original private memory is back'ed by guest_memfd. Introduce ram_block_discard_guest_memfd_range() for discarding memory in guest_mem

Re: [PATCH v5 06/65] kvm: Introduce support for memory_attributes

2024-03-20 Thread Xiaoyao Li
On 3/19/2024 10:03 AM, Wang, Lei wrote: On 2/29/2024 14:36, Xiaoyao Li wrote:> Introduce the helper functions to set the attributes of a range of memory to private or shared. This is necessary to notify KVM the private/shared attribute of each gpa range. KVM needs the information to decide the

Re: [PATCH v3 13/49] [FIXUP] "kvm: handle KVM_EXIT_MEMORY_FAULT": drop qemu_host_page_size

2024-03-20 Thread Xiaoyao Li
On 3/20/2024 4:39 PM, Michael Roth wrote: TODO: squash into "kvm: handle KVM_EXIT_MEMORY_FAULT" qemu_host_page_size has been superseded by qemu_real_host_page_size() in newer QEMU, so update the patch accordingly. I found it today as well when rebase to qemu v9.0.0-rc0. Fix it locally, will s

Re: [PATCH v3 11/49] physmem: Introduce ram_block_discard_guest_memfd_range()

2024-03-20 Thread David Hildenbrand
On 20.03.24 13:43, Xiaoyao Li wrote: On 3/20/2024 5:37 PM, David Hildenbrand wrote: On 20.03.24 09:39, Michael Roth wrote: From: Xiaoyao Li When memory page is converted from private to shared, the original private memory is back'ed by guest_memfd. Introduce ram_block_discard_guest_memfd_rang

Re: [PATCH v2] target/i386: Revert monitor_puts() in do_inject_x86_mce()

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 04:36:40PM +0800, Tao Su wrote: > monitor_puts() doesn't check the monitor pointer, but do_inject_x86_mce() > may have a parameter with NULL monitor pointer. Revert monitor_puts() in > do_inject_x86_mce() to fix, then the fact that we send the same message to > monitor and l

[PATCH] libqos/virtio.c: Correct 'flags' reading in qvirtqueue_kick

2024-03-20 Thread Zheyu Ma
In qvirtqueue_kick(), the 'flags' were previously being incorrectly read from vq->avail instead of the correct vq->used location. This update ensures 'flags' are read from the correct location as per the virtio standard. Signed-off-by: Zheyu Ma --- tests/qtest/libqos/virtio.c | 2 +- 1 file chan

Re: [PATCH 1/4] hw/nmi: Use object_child_foreach_recursive() in nmi_children()

2024-03-20 Thread Peter Maydell
On Tue, 20 Feb 2024 at 15:08, Philippe Mathieu-Daudé wrote: > > Replace object_child_foreach() and recursion by a single > object_child_foreach_recursive() call. > Propagate the returned value so callers can check it. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell thanks

Re: [PULL 32/68] hw/virtio: Add support for VDPA network simulation devices

2024-03-20 Thread Michael S. Tsirkin
On Wed, Mar 20, 2024 at 09:58:40AM +0100, Paolo Bonzini wrote: > On 3/12/24 23:27, Michael S. Tsirkin wrote: > > diff --git a/include/standard-headers/linux/virtio_pci.h > > b/include/standard-headers/linux/virtio_pci.h > > index 3e2bc2c97e..86733278ba 100644 > > --- a/include/standard-headers/lin

Re: [PATCH 1/2] tests/qtest/migration: Ignore if socket-address is missing to avoid crash below

2024-03-20 Thread Peter Xu
On Wed, Mar 20, 2024 at 10:47:18AM +0530, Het Gala wrote: > It won't crash IMO, the next function SocketAddress_to_str for a non-socket > type would return an proper error ? Both SocketAddress_to_str() and SocketAddress_to_qdict() will crash with a NULL pointer passed in right now. Thanks, -- P

Re: [PATCH 2/4] hw/s390x/virtio-ccw: Always deliver NMI to first CPU

2024-03-20 Thread Peter Maydell
On Tue, 20 Feb 2024 at 15:09, Philippe Mathieu-Daudé wrote: > > We can trigger NMI from HMP or QMP. > > QEMU maps the NMI to the s390x per-CPU 'RESTART' interrupt. > Linux guests usually setup this interrupt to trigger kdump > or crash. Such crashdump can be triggered in QEMU by HMP > "nmi" or QMP

Re: [PATCH 1/2] tests/qtest/migration: Ignore if socket-address is missing to avoid crash below

2024-03-20 Thread Fabiano Rosas
Het Gala writes: > On 20/03/24 3:27 am, Peter Xu wrote: >> On Tue, Mar 19, 2024 at 08:48:39PM +, Het Gala wrote: >>> 'object' can return NULL if there is no socket-address, such as with a >>> file migration. Then the visitor code below fails and the test crashes. >>> >>> Ignore and return NUL

Re: [PATCH 3/4] hw/nmi: Remove @cpu_index argument from NMIClass::nmi_handler()

2024-03-20 Thread Peter Maydell
On Tue, 20 Feb 2024 at 15:09, Philippe Mathieu-Daudé wrote: > > Only s390x was using the 'cpu_index' argument, but since the > previous commit it isn't anymore (it use the first cpu). > Since this argument is now completely unused, remove it. Have > the callback return a boolean indicating failure

Re: [PATCH 4/4] hw/nmi: Remove @cpu_index argument from nmi_trigger()

2024-03-20 Thread Peter Maydell
On Tue, 20 Feb 2024 at 15:09, Philippe Mathieu-Daudé wrote: > > nmi_monitor_handle() is not related to the monitor, > rename it as nmi_trigger(). > Return boolean value > indicating success / failure. The 'cpu_index' argument > is not used, remove it. > > Signed-off-by: Philippe Mathieu-Daudé >

Re: [PATCH] coroutine: cap per-thread local pool size

2024-03-20 Thread Stefan Hajnoczi
On Tue, Mar 19, 2024 at 08:10:49PM +, Daniel P. Berrangé wrote: > On Tue, Mar 19, 2024 at 01:55:10PM -0400, Stefan Hajnoczi wrote: > > On Tue, Mar 19, 2024 at 01:43:32PM +, Daniel P. Berrangé wrote: > > > On Mon, Mar 18, 2024 at 02:34:29PM -0400, Stefan Hajnoczi wrote: > > > > diff --git a/

Re: [PATCH v5 08/65] kvm: handle KVM_EXIT_MEMORY_FAULT

2024-03-20 Thread Xiaoyao Li
On 3/19/2024 10:14 AM, Wang, Lei wrote: On 2/29/2024 14:36, Xiaoyao Li wrote: From: Chao Peng When geeting KVM_EXIT_MEMORY_FAULT exit, it indicates userspace needs to do the memory conversion on the RAMBlock to turn the memory into desired attribute, i.e., private/shared. Currently only KVM_M

[PULL 1/5] ui/vc: Do not inherit the size of active console

2024-03-20 Thread marcandre . lureau
From: Akihiko Odaki A chardev-vc used to inherit the size of a graphic console when its size not explicitly specified, but it often did not make sense. If a chardev-vc is instantiated during the startup, the active graphic console has no content at the time, so it will have the size of graphic co

[PULL 3/5] ui/cocoa: Do not use console_select()

2024-03-20 Thread marcandre . lureau
From: Akihiko Odaki ui/cocoa needs to update the UI info and reset the keyboard state tracker when switching the console, or the new console will see the stale UI info or keyboard state. Previously, updating the UI info was done with cocoa_switch(), but it is meant to be called when the surface i

[PULL 2/5] ui/vnc: Do not use console_select()

2024-03-20 Thread marcandre . lureau
From: Akihiko Odaki console_select() is shared by other displays and a console_select() call from one of them triggers console switching also in ui/curses, circumventing key state reinitialization that needs to be performed in preparation and resulting in stuck keys. Use its internal state to tr

[PULL 0/5] Ui patches

2024-03-20 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit c62d54d0a8067ffb3d5b909276f7296d7df33fa7: Update version for v9.0.0-rc0 release (2024-03-19 19:13:52 +) are available in the Git repository at: https://gitlab.com/marcandre.lureau/qemu.git tags/ui-pull-request for you to fetch

[PULL 4/5] ui/curses: Do not use console_select()

2024-03-20 Thread marcandre . lureau
From: Akihiko Odaki ui/curses is the only user of console_select(). Move the implementation to ui/curses. Signed-off-by: Akihiko Odaki Reviewed-by: Marc-André Lureau Message-Id: <20240319-console-v2-4-3fd6feef3...@daynix.com> --- include/ui/console.h | 1 - ui/console-priv.h | 2 +-

[PULL 5/5] ui: compile dbus-display1.c with -fPIC as necessary

2024-03-20 Thread marcandre . lureau
From: Marc-André Lureau Building dbus-display1.c explicitly as a static library drops -fPIC by default, which may not be correct if it ends up linked to a shared library. Let the target decide how to build the unit, with or without -fPIC. This makes commit 186acfbaf7 ("tests/qtest: Depend on dbu

Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-03-20 Thread Peter Maydell
On Wed, 20 Mar 2024 at 12:31, Mark Burton wrote: > > On 20 Mar 2024, at 13:00, Peter Maydell wrote: > > What NMI probably ought to be is board-specific: so it's like > > having some notional front panel switch labeled "NMI", and the > > Do the youngsters of today know what one of those is ? >

Re: [PATCH] coroutine: cap per-thread local pool size

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 09:35:39AM -0400, Stefan Hajnoczi wrote: > On Tue, Mar 19, 2024 at 08:10:49PM +, Daniel P. Berrangé wrote: > > On Tue, Mar 19, 2024 at 01:55:10PM -0400, Stefan Hajnoczi wrote: > > > On Tue, Mar 19, 2024 at 01:43:32PM +, Daniel P. Berrangé wrote: > > > > On Mon, Mar 1

Re: [PATCH for-9.1 v5 06/14] migration: Add Error** argument to qemu_savevm_state_setup()

2024-03-20 Thread Peter Xu
On Wed, Mar 20, 2024 at 07:49:02AM +0100, Cédric Le Goater wrote: > This prepares ground for the changes coming next which add an Error** > argument to the .save_setup() handler. Callers of qemu_savevm_state_setup() > now handle the error and fail earlier setting the migration state from > MIGRATIO

Re: [PATCH 2/4] hw/s390x/virtio-ccw: Always deliver NMI to first CPU

2024-03-20 Thread David Hildenbrand
On 20.02.24 16:08, Philippe Mathieu-Daudé wrote: We can trigger NMI from HMP or QMP. QEMU maps the NMI to the s390x per-CPU 'RESTART' interrupt. Linux guests usually setup this interrupt to trigger kdump or crash. Such crashdump can be triggered in QEMU by HMP "nmi" or QMP "inject-nmi" commands.

Re: [PATCH v2] target/i386: Revert monitor_puts() in do_inject_x86_mce()

2024-03-20 Thread Peter Maydell
On Wed, 20 Mar 2024 at 13:03, Daniel P. Berrangé wrote: > > On Wed, Mar 20, 2024 at 04:36:40PM +0800, Tao Su wrote: > > monitor_puts() doesn't check the monitor pointer, but do_inject_x86_mce() > > may have a parameter with NULL monitor pointer. Revert monitor_puts() in > > do_inject_x86_mce() to

RE: [PATCH v5 3/7] configure: add --enable-qpl build option

2024-03-20 Thread Liu, Yuan1
> -Original Message- > From: Thomas Huth > Sent: Wednesday, March 20, 2024 4:57 PM > To: Liu, Yuan1 ; pet...@redhat.com; faro...@suse.de > Cc: qemu-devel@nongnu.org; hao.xi...@bytedance.com; > bryan.zh...@bytedance.com; Zou, Nanhai > Subject: Re: [PATCH v5 3/7] configure: add --enable-qpl

Re: [PATCH v2] target/i386: Revert monitor_puts() in do_inject_x86_mce()

2024-03-20 Thread Markus Armbruster
Peter Maydell writes: > On Wed, 20 Mar 2024 at 13:03, Daniel P. Berrangé wrote: >> >> On Wed, Mar 20, 2024 at 04:36:40PM +0800, Tao Su wrote: >> > monitor_puts() doesn't check the monitor pointer, but do_inject_x86_mce() >> > may have a parameter with NULL monitor pointer. Revert monitor_puts()

Re: [PATCH] configure: Fix error message when C compiler is not working

2024-03-20 Thread Thomas Huth
On 19/03/2024 14.12, Peter Maydell wrote: On Fri, 8 Mar 2024 at 06:01, Thomas Huth wrote: If you try to run the configure script on a system without a working C compiler, you get a very misleading error message: ERROR: Unrecognized host OS (uname -s reports 'Linux') We should rather tell t

Re: [PATCH 0/9] Introduce support for IGVM files

2024-03-20 Thread Roy Hopkins
On Tue, 2024-03-19 at 16:07 +0100, Stefano Garzarella wrote: > Hi Roy, > thanks for this series! > > On Tue, Feb 27, 2024 at 02:50:06PM +, Roy Hopkins wrote: > > Hi everyone, > > > > This initial patch series submission adds the capability to configure > > confidential guests using files that

Re: [PATCH 1/2] tests/qtest/migration: Ignore if socket-address is missing to avoid crash below

2024-03-20 Thread Het Gala
On 20/03/24 6:49 pm, Fabiano Rosas wrote: Het Gala writes: On 20/03/24 3:27 am, Peter Xu wrote: On Tue, Mar 19, 2024 at 08:48:39PM +, Het Gala wrote: 'object' can return NULL if there is no socket-address, such as with a file migration. Then the visitor code below fails and the test cra

RE: [PATCH v5 3/7] configure: add --enable-qpl build option

2024-03-20 Thread Liu, Yuan1
> -Original Message- > From: Daniel P. Berrangé > Sent: Wednesday, March 20, 2024 6:31 PM > To: Liu, Yuan1 > Cc: pet...@redhat.com; faro...@suse.de; qemu-devel@nongnu.org; > hao.xi...@bytedance.com; bryan.zh...@bytedance.com; Zou, Nanhai > > Subject: Re: [PATCH v5 3/7] configure: add --e

Re: [PATCH for-9.1 v5 09/14] memory: Add Error** argument to .log_global_start() handler

2024-03-20 Thread Peter Xu
On Wed, Mar 20, 2024 at 07:49:05AM +0100, Cédric Le Goater wrote: > Modify all .log_global_start() handlers to take an Error** parameter > and return a bool. Adapt memory_global_dirty_log_start() to interrupt > on the first error the loop on handlers. In such case, a rollback is > performed to stop

Re: [PATCH for-9.1 v5 10/14] migration: Introduce ram_bitmaps_destroy()

2024-03-20 Thread Peter Xu
On Wed, Mar 20, 2024 at 07:49:06AM +0100, Cédric Le Goater wrote: > We will use it in ram_init_bitmaps() to clear the allocated bitmaps when > support for error reporting is added to memory_global_dirty_log_start(). > > Signed-off-by: Cédric Le Goater Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH 2/9] backends/confidential-guest-support: Add IGVM file parameter

2024-03-20 Thread Roy Hopkins
On Tue, 2024-03-19 at 16:10 +0100, Stefano Garzarella wrote: > On Tue, Feb 27, 2024 at 02:50:08PM +, Roy Hopkins wrote: > > In order to add support for parsing IGVM files for secure virtual > > machines, a the path to an IGVM file needs to be specified as > > part of the guest configuration. It

Re: [PATCH] configure: Fix error message when C compiler is not working

2024-03-20 Thread Peter Maydell
On Wed, 20 Mar 2024 at 14:38, Thomas Huth wrote: > > On 19/03/2024 14.12, Peter Maydell wrote: > > I think I would prefer as a structure: > > > > (1) suppress the "unrecognized host CPU" message if "$host_os" == "bogus" > > (2) do the "check the C compiler works" test as its own test immediately >

Re: [PATCH for-9.1 v5 10/14] migration: Introduce ram_bitmaps_destroy()

2024-03-20 Thread Fabiano Rosas
Cédric Le Goater writes: > We will use it in ram_init_bitmaps() to clear the allocated bitmaps when > support for error reporting is added to memory_global_dirty_log_start(). > > Signed-off-by: Cédric Le Goater Reviewed-by: Fabiano Rosas

Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-03-20 Thread Mark Burton
> On 20 Mar 2024, at 14:55, Peter Maydell wrote: > > WARNING: This email originated from outside of Qualcomm. Please be wary of > any links or attachments, and do not enable macros. > > On Wed, 20 Mar 2024 at 12:31, Mark Burton wrote: >>> On 20 Mar 2024, at 13:00, Peter Maydell wrote: >>> W

Re: [PATCH for-9.1 v5 11/14] memory: Add Error** argument to the global_dirty_log routines

2024-03-20 Thread Fabiano Rosas
Cédric Le Goater writes: > Now that the log_global*() handlers take an Error** parameter and > return a bool, do the same for memory_global_dirty_log_start() and > memory_global_dirty_log_stop(). The error is reported in the callers > for now and it will be propagated in the call stack in the nex

Re: [PATCH 2/9] backends/confidential-guest-support: Add IGVM file parameter

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 02:44:17PM +, Roy Hopkins wrote: > On Tue, 2024-03-19 at 16:10 +0100, Stefano Garzarella wrote: > > On Tue, Feb 27, 2024 at 02:50:08PM +, Roy Hopkins wrote: > > > In order to add support for parsing IGVM files for secure virtual > > > machines, a the path to an IGVM

Re: [PATCH for-9.1 v5 12/14] migration: Add Error** argument to ram_state_init()

2024-03-20 Thread Fabiano Rosas
Cédric Le Goater writes: > Since the return value not exploited, follow the recommendations of > qapi/error.h and change it to a bool > > Signed-off-by: Cédric Le Goater Reviewed-by: Fabiano Rosas

Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-03-20 Thread Peter Maydell
On Wed, 20 Mar 2024 at 14:10, Mark Burton wrote: > I’d broaden this to all ’signals’ (IRQ, Reset etc) - and I guess > similar statements apply, with the “bridge” between the function > and the GPIO mechanism moved closer or further from the originator(s) > of the activity. > > The issue isn’t my “

Re: [PATCH for-9.1 v5 13/14] migration: Add Error** argument to xbzrle_init()

2024-03-20 Thread Fabiano Rosas
Cédric Le Goater writes: > Since the return value (-ENOMEM) is not exploited, follow the > recommendations of qapi/error.h and change it to a bool > > Signed-off-by: Cédric Le Goater Reviewed-by: Fabiano Rosas

RE: [PATCH v5 5/7] migration/multifd: implement initialization of qpl compression

2024-03-20 Thread Liu, Yuan1
> -Original Message- > From: Daniel P. Berrangé > Sent: Wednesday, March 20, 2024 6:42 PM > To: Liu, Yuan1 > Cc: pet...@redhat.com; faro...@suse.de; qemu-devel@nongnu.org; > hao.xi...@bytedance.com; bryan.zh...@bytedance.com; Zou, Nanhai > > Subject: Re: [PATCH v5 5/7] migration/multifd:

Re: [PULL 0/8] Misc fixes patches

2024-03-20 Thread Peter Maydell
On Tue, 19 Mar 2024 at 20:22, Daniel P. Berrangé wrote: > > The following changes since commit c62d54d0a8067ffb3d5b909276f7296d7df33fa7: > > Update version for v9.0.0-rc0 release (2024-03-19 19:13:52 +) > > are available in the Git repository at: > > https://gitlab.com/berrange/qemu tags/m

Re: [PULL 0/9] target/hppa fixes for 9.0

2024-03-20 Thread Peter Maydell
On Wed, 20 Mar 2024 at 00:33, Richard Henderson wrote: > > The following changes since commit c62d54d0a8067ffb3d5b909276f7296d7df33fa7: > > Update version for v9.0.0-rc0 release (2024-03-19 19:13:52 +) > > are available in the Git repository at: > > https://gitlab.com/rth7680/qemu.git tags

Re: [PULL 0/3] loongarch fixes for 9.0

2024-03-20 Thread Peter Maydell
osong/qemu.git tags/pull-loongarch-20240320 > > for you to fetch changes up to 77642f92c0b71a105aba2a4d03bc62328eae703b: > > target/loongarch: Fix qemu-loongarch64 hang when executing 'll.d $t0, $t0, > 0' (2024-03-20 10:20:08 +0800) > > --

Re: [PATCH for-9.1 v5 14/14] migration: Modify ram_init_bitmaps() to report dirty tracking errors

2024-03-20 Thread Fabiano Rosas
Cédric Le Goater writes: > The .save_setup() handler has now an Error** argument that we can use > to propagate errors reported by the .log_global_start() handler. Do > that for the RAM. The caller qemu_savevm_state_setup() will store the > error under the migration stream for later detection in

Re: [PATCH for-9.1 v5 11/14] memory: Add Error** argument to the global_dirty_log routines

2024-03-20 Thread Peter Xu
On Wed, Mar 20, 2024 at 07:49:07AM +0100, Cédric Le Goater wrote: > Now that the log_global*() handlers take an Error** parameter and > return a bool, do the same for memory_global_dirty_log_start() and > memory_global_dirty_log_stop(). The error is reported in the callers > for now and it will be

Re: [PATCH v5 2/7] migration/multifd: put IOV initialization into compression method

2024-03-20 Thread Fabiano Rosas
Yuan Liu writes: > Different compression methods may require different numbers of IOVs. > Based on streaming compression of zlib and zstd, all pages will be > compressed to a data block, so two IOVs are needed for packet header > and compressed data block. > > Signed-off-by: Yuan Liu > Reviewed-

Re: [PATCH v5 5/7] migration/multifd: implement initialization of qpl compression

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 03:02:59PM +, Liu, Yuan1 wrote: > > -Original Message- > > From: Daniel P. Berrangé > > Sent: Wednesday, March 20, 2024 6:42 PM > > To: Liu, Yuan1 > > Cc: pet...@redhat.com; faro...@suse.de; qemu-devel@nongnu.org; > > hao.xi...@bytedance.com; bryan.zh...@byteda

RE: [PATCH v5 7/7] tests/migration-test: add qpl compression test

2024-03-20 Thread Liu, Yuan1
> -Original Message- > From: Daniel P. Berrangé > Sent: Wednesday, March 20, 2024 6:46 PM > To: Liu, Yuan1 > Cc: pet...@redhat.com; faro...@suse.de; qemu-devel@nongnu.org; > hao.xi...@bytedance.com; bryan.zh...@bytedance.com; Zou, Nanhai > > Subject: Re: [PATCH v5 7/7] tests/migration-te

Re: [PATCH v2] target/i386: Revert monitor_puts() in do_inject_x86_mce()

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 03:34:43PM +0100, Markus Armbruster wrote: > Peter Maydell writes: > > > On Wed, 20 Mar 2024 at 13:03, Daniel P. Berrangé > > wrote: > >> > >> On Wed, Mar 20, 2024 at 04:36:40PM +0800, Tao Su wrote: > >> > monitor_puts() doesn't check the monitor pointer, but do_inject_x

RE: [PATCH v5 2/7] migration/multifd: put IOV initialization into compression method

2024-03-20 Thread Liu, Yuan1
> -Original Message- > From: Fabiano Rosas > Sent: Wednesday, March 20, 2024 11:19 PM > To: Liu, Yuan1 ; pet...@redhat.com > Cc: qemu-devel@nongnu.org; hao.xi...@bytedance.com; > bryan.zh...@bytedance.com; Liu, Yuan1 ; Zou, Nanhai > > Subject: Re: [PATCH v5 2/7] migration/multifd: put IOV

<    1   2   3   4   >