Hi Cédric,
On 3/6/24 14:34, Cédric Le Goater wrote:
> We will use the Error object to improve error reporting in the
> .log_global*() handlers of VFIO. Add documentation while at it.
>
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Cédric Le Goater
> ---
>
> Changes in v3:
>
> - Use
Hi Cédric,
On 3/6/24 14:34, Cédric Le Goater wrote:
> This allows to update the Error argument of the VFIO log_global_start()
> handler. Errors detected when device level logging is started will be
> propagated up to qemu_savevm_state_setup() when the ram save_setup()
> handler is executed.
>
> T
Hi Vitaly,
On Tue, Mar 05, 2024 at 05:42:04PM +0100, Vitaly Kuznetsov wrote:
> Date: Tue, 5 Mar 2024 17:42:04 +0100
> From: Vitaly Kuznetsov
> Subject: [PATCH RESEND v3 3/3] docs/system: Add recommendations to Hyper-V
> enlightenments doc
>
> While hyperv.rst already has all currently implemen
Xiaoyao Li writes:
> On 2/29/2024 9:25 PM, Markus Armbruster wrote:
>> Xiaoyao Li writes:
>>
>>> On 2/29/2024 4:37 PM, Markus Armbruster wrote:
Xiaoyao Li writes:
> From: Isaku Yamahata
>
> Three sha384 hash values, mrconfigid, mrowner and mrownerconfig, of a TD
> ca
On 3/6/24 14:34, Cédric Le Goater wrote:
> This improves error reporting in the log_global_stop() VFIO handler.
>
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Cédric Le Goater
> ---
>
> Changes in v4:
>
> - Dropped log_global_stop() and log_global_sync() changes
>
> Changes
Hi Cédric,
On 3/6/24 14:34, Cédric Le Goater wrote:
> Add an Error** argument to vfio_migration_set_state() and adjust
> callers, including vfio_save_setup(). The error will be propagated up
> to qemu_savevm_state_setup() where the save_setup() handler is
> executed.
>
> Modify vfio_vmstate_chang
On 3/6/24 04:57, Peter Xu wrote:
On Tue, Mar 05, 2024 at 03:43:41PM +0100, Markus Armbruster wrote:
Peter Maydell writes:
On Mon, 4 Mar 2024 at 13:52, Maksim Davydov wrote:
The following changes since commit e1007b6bab5cf97705bf4f2aaec1f607787355b8:
Merge tag 'pull-request-2024-03-01'
On 3/6/24 14:34, Cédric Le Goater wrote:
> Use vmstate_save_state_with_err() to improve error reporting in the
> callers and store a reported error under the migration stream. Add
> documentation while at it.
>
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Cédric Le Goater
> ---
> i
Vladimir Sementsov-Ogievskiy writes:
> This "hotpluggable" here is misleading. Actually we check is object a
> device or not. Let's drop the word.
>
> SUggested-by: Markus Armbruster
"Suggested"
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> system/qdev-monitor.c | 2 +-
> 1 file chan
On 06.03.24 16:44, Fiona Ebner wrote:
Am 29.02.24 um 13:47 schrieb Fiona Ebner:
Am 29.02.24 um 12:48 schrieb Vladimir Sementsov-Ogievskiy:
On 29.02.24 13:11, Fiona Ebner wrote:
The iotest creates a new target image for each incremental sync which
only records the diff relative to the previous
On 3/7/24 00:45, Sunil V L wrote:
On Thu, Mar 07, 2024 at 11:33:25AM +1000, Alistair Francis wrote:
On Thu, Mar 7, 2024 at 4:59 AM Daniel Henrique Barboza
wrote:
Hi,
This patch break check-qtest, most specifically 'bios-table'test', for aarch64.
I found this while running riscv-to-apply.n
On 3/6/24 14:34, Cédric Le Goater wrote:
> Let the callers do the error reporting. Add documentation while at it.
>
> Signed-off-by: Cédric Le Goater
> ---
> include/hw/vfio/vfio-common.h | 4 +-
> include/hw/vfio/vfio-container-base.h | 17 +++-
> hw/vfio/common.c
On 3/4/24 22:47, LIU Zhiwei wrote:
On 2024/2/29 2:51, Atish Patra wrote:
Privilege mode filtering can also be emulated for cycle/instret by
tracking host_ticks/icount during each privilege mode switch. This
patch implements that for both cycle/instret and mhpmcounters. The
first one requires
On 3/4/24 23:01, LIU Zhiwei wrote:
On 2024/2/29 2:51, Atish Patra wrote:
From: Kaiwen Xue
This adds the properties for ISA extension smcntrpmf. Patches
implementing it will follow.
Signed-off-by: Atish Patra
Signed-off-by: Kaiwen Xue
---
target/riscv/cpu.c | 2 ++
target/riscv/cpu
On 3/6/24 14:34, Cédric Le Goater wrote:
> vfio_save_complete_precopy() currently returns before doing the trace
> event. Change that.
>
> Signed-off-by: Cédric Le Goater
> ---
> hw/vfio/migration.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/hw/vfio/migration.c b/hw/vfio/migr
Hi Cédric,
On 3/6/24 14:34, Cédric Le Goater wrote:
> vfio_set_migration_error() sets the 'return' error on the migration
> stream if a migration is in progress. To improve error reporting, add
> a new Error* argument to also set the Error object on the migration
> stream, if a migration is progre
On Thu, 7 Mar 2024 03:03:02 +
Ankit Agrawal wrote:
> >>
> >> [1] ACPI Spec 6.3, Section 5.2.16.6
> >> [2] ACPI Spec 6.3, Table 5.80
> >>
> >> Cc: Jonathan Cameron
> >> Cc: Alex Williamson
> >> Cc: Cedric Le Goater
> >> Signed-off-by: Ankit Agrawal
> >
> > I guess we gloss over the bisec
On 3/6/24 14:34, Cédric Le Goater wrote:
> This will prepare ground for future changes adding an Error** argument
> to the save_setup() handler. We need to make sure that on failure,
> vfio_save_setup() always sets a new error.
>
> Reviewed-by: Fabiano Rosas
> Signed-off-by: Cédric Le Goater
On Tue, Jan 30, 2024 at 03:48:38PM -0800, dongwon@intel.com wrote:
> From: Dongwon Kim
>
> A new flag "visible" is added to show visibility status of the gfx console.
> The flag is set to 'true' when the VC is visible but set to 'false' when
> it is hidden or closed. When the VC is invisible,
On Thu, 7 Mar 2024 10:58:56 +1000
Alistair Francis wrote:
> The Security Protocol and Data Model (SPDM) Specification defines
> messages, data objects, and sequences for performing message exchanges
> over a variety of transport and physical media.
> -
> https://www.dmtf.org/sites/default/file
Zhao Liu writes:
> Hi Vitaly,
>
> On Tue, Mar 05, 2024 at 05:42:04PM +0100, Vitaly Kuznetsov wrote:
>> Date: Tue, 5 Mar 2024 17:42:04 +0100
>> From: Vitaly Kuznetsov
>> Subject: [PATCH RESEND v3 3/3] docs/system: Add recommendations to Hyper-V
>> enlightenments doc
>>
>> While hyperv.rst alre
On Thu, Feb 01, 2024 at 06:48:58PM +, Kim, Dongwon wrote:
> Hi Marc-André,
>
> Thanks for your feedback. Yes, you are right, rendering doesn't stop on
> Ubuntu system
> as it has preview even after the window is minimized. But this is not always
> the case.
> Some simple windows managers don
Vladimir Sementsov-Ogievskiy writes:
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> system/qdev-monitor.c | 15 +++
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c
> index 9febb743f1..cf7481e416 100644
> --- a/
On Wed, Jan 31, 2024 at 11:12:57AM +0400, Marc-André Lureau wrote:
> Hi
>
> On Wed, Jan 31, 2024 at 3:50 AM wrote:
> >
> > From: Dongwon Kim
> >
> > UI size is set to 0 when the VC is invisible, which will prevent
> > the further scanout update by notifying the guest that the display
> > is not
On Tue, Mar 05, 2024 at 04:18:18PM +0400, Marc-André Lureau wrote:
> Hi Kim
>
> I am uncomfortable with the series in general.
>
> Not only we don't have the means to draw dmabuf/scanout "when
> required", so resuming drawing won't work until the guest draws (this
> is already a problem but you a
Vladimir Sementsov-Ogievskiy writes:
> Add command to sync config from vhost-user backend to the device. It
> may be helpful when VHOST_USER_SLAVE_CONFIG_CHANGE_MSG failed or not
> triggered interrupt to the guest or just not available (not supported
> by vhost-user server).
>
> Signed-off-by: Vl
On 06.03.24 16:34, Cédric Le Goater wrote:
The purpose is to record a potential error in the migration stream if
qemu_savevm_state_setup() fails. Most of the current .save_setup()
handlers can be modified to use the Error argument instead of managing
their own and calling locally error_report().
On Wed, Mar 06, 2024 at 10:28:22PM -0800, Justinien Bouron wrote:
> Depending on your use-case, it might be inconvenient to have qemu grab
> the input device immediately upon starting the guest, especially if the
> guest takes a while to start in which case it may take a few seconds
> before being
Vladimir Sementsov-Ogievskiy writes:
> Command result is racy if allow it during migration. Let's allow the
> sync only in RUNNING state.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
If I understand this correctly, the previous commit introduces a race,
and this one fixes it.
We normally av
Vladimir Sementsov-Ogievskiy writes:
> Send a new event when guest reads virtio-pci config after
> virtio_notify_config() call.
>
> That's useful to check that guest fetched modified config, for example
> after resizing disk backend.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
[...]
> diff
On 07.03.24 12:46, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
system/qdev-monitor.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c
index 9f
On 07.03.24 12:54, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Add command to sync config from vhost-user backend to the device. It
may be helpful when VHOST_USER_SLAVE_CONFIG_CHANGE_MSG failed or not
triggered interrupt to the guest or just not available (not supported
by vh
On 7/3/24 04:23, Taylor Simpson wrote:
This data structure is not used
Signed-off-by: Taylor Simpson
---
target/hexagon/opcodes.c| 7
target/hexagon/README | 1 -
target/hexagon/gen_shortcode.py | 63 -
target/hexagon/meson.build
On 7/3/24 04:23, Taylor Simpson wrote:
The attribinfo data structure is not used
Adjust the command-line arguments to the python scripts
Add hex_common.read_common_files for TCG/helper generation scripts
Signed-off-by: Taylor Simpson
---
target/hexagon/gen_analyze_funcs.py | 21 ++
On 7/3/24 01:58, Alistair Francis wrote:
From: Huai-Cheng Kuo
SPDM enables authentication, attestation and key exchange to assist in
providing infrastructure security enablement. It's a standard published
by the DMTF [1].
SPDM supports multiple transports, including PCIe DOE and MCTP.
This pat
Hi Alistair, Wilfred,
On 7/3/24 01:58, Alistair Francis wrote:
From: Wilfred Mallawa
Setup Data Object Exchance (DOE) as an extended capability for the NVME
controller and connect SPDM to it (CMA) to it.
Signed-off-by: Wilfred Mallawa
Signed-off-by: Alistair Francis
Reviewed-by: Jonathan Ca
include/qapi/error.h says:
> We recommend
> * bool-valued functions return true on success / false on failure,
> ...
Signed-off-by: Akihiko Odaki
---
contrib/elf2dmp/addrspace.h | 4 ++--
contrib/elf2dmp/addrspace.c | 8
contrib/elf2dmp/main.c | 47 +--
elf2dmp sometimes fails to work with partially corrupted dumps, and also
emits warnings when sanitizers are in use. This series are collections
of changes to improve the situation.
Signed-off-by: Akihiko Odaki
---
Changes in v4:
- Remove unnecessary !! idiom (Peter Maydell)
- Link to v3:
https:/
pa_space_create() used to return an integer to propagate error, but
it never fails so let it return void.
Signed-off-by: Akihiko Odaki
---
contrib/elf2dmp/addrspace.h | 2 +-
contrib/elf2dmp/addrspace.c | 4 +---
contrib/elf2dmp/main.c | 5 +
3 files changed, 3 insertions(+), 8 deletion
Destroy PA space even if paging base couldn't be found, fixing memory
leak.
Signed-off-by: Akihiko Odaki
Reviewed-by: Peter Maydell
---
contrib/elf2dmp/main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/contrib/elf2dmp/main.c b/contrib/elf2dmp/main.c
index 9347b0cd5a2d
They are always evaluated to 1.
Signed-off-by: Akihiko Odaki
Reviewed-by: Peter Maydell
---
contrib/elf2dmp/pdb.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/contrib/elf2dmp/pdb.c b/contrib/elf2dmp/pdb.c
index 40991f5f4c34..abf17c2e7c12 100644
--- a/contr
include/qapi/error.h says:
> We recommend
> * bool-valued functions return true on success / false on failure,
> ...
Signed-off-by: Akihiko Odaki
---
contrib/elf2dmp/download.h | 2 +-
contrib/elf2dmp/download.c | 10 +-
contrib/elf2dmp/main.c | 2 +-
3 files changed, 7 insertions(
Callers of elf64_getphdr() and elf_getphdrnum() assume phdrs are
accessible.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2202
Signed-off-by: Akihiko Odaki
---
contrib/elf2dmp/qemu_elf.c | 8
1 file changed, 8 insertions(+)
diff --git a/contrib/elf2dmp/qemu_elf.c b/contrib/e
rol64() is roubust against too large shift values and fixes UBSan
warnings.
Signed-off-by: Akihiko Odaki
Reviewed-by: Peter Maydell
---
contrib/elf2dmp/main.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/contrib/elf2dmp/main.c b/contrib/elf2dmp/main.c
index 32dc8b
A common construct in contrib/elf2dmp is to set "err" flag and goto
in error paths. In such a construct, there is only one successful path
while there are several error paths, so it will be more simpler to
initialize "err" flag set, and clear it in the successful path.
Signed-off-by: Akihiko Odaki
The relevant value may be unaligned and is little-endian.
Signed-off-by: Akihiko Odaki
---
contrib/elf2dmp/pdb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/contrib/elf2dmp/pdb.c b/contrib/elf2dmp/pdb.c
index 1c5051425185..492aca4434c8 100644
--- a/contrib/elf2dmp/pdb.c
This fixes crashes with truncated dumps.
Signed-off-by: Akihiko Odaki
Reviewed-by: Peter Maydell
---
contrib/elf2dmp/qemu_elf.c | 87 +-
1 file changed, 55 insertions(+), 32 deletions(-)
diff --git a/contrib/elf2dmp/qemu_elf.c b/contrib/elf2dmp/qemu_
This makes elf2dmp more robust against corrupted inputs.
Signed-off-by: Akihiko Odaki
Reviewed-by: Peter Maydell
---
contrib/elf2dmp/addrspace.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/contrib/elf2dmp/addrspace.c b/contrib/elf2dmp/addrspace.c
index e01860d15b07.
This removes the need to enumarate QEMUCPUState twice and saves code.
Signed-off-by: Akihiko Odaki
Reviewed-by: Peter Maydell
---
contrib/elf2dmp/qemu_elf.c | 25 -
1 file changed, 8 insertions(+), 17 deletions(-)
diff --git a/contrib/elf2dmp/qemu_elf.c b/contrib/elf2dm
Let fill_context() continue even if it fails to fill contexts of some
CPUs. A dump may still contain valuable information even if it lacks
contexts of some CPUs due to dump corruption or a failure before
starting CPUs.
Signed-off-by: Akihiko Odaki
Reviewed-by: Peter Maydell
---
contrib/elf2dmp/
include/qapi/error.h says:
> We recommend
> * bool-valued functions return true on success / false on failure,
> ...
Signed-off-by: Akihiko Odaki
---
contrib/elf2dmp/qemu_elf.h | 2 +-
contrib/elf2dmp/main.c | 2 +-
contrib/elf2dmp/qemu_elf.c | 32
3 files
On 7/3/24 08:32, Eric Auger wrote:
Hi Philippe,
On 3/6/24 21:44, Philippe Mathieu-Daudé wrote:
On 6/3/24 21:32, Eric Auger wrote:
We are missing an entry for the virtio-iommu-pci device. Add the
information on which machine it is currently supported and document
the new granule option.
Signed
include/qapi/error.h says:
> We recommend
> * bool-valued functions return true on success / false on failure,
> ...
Signed-off-by: Akihiko Odaki
---
contrib/elf2dmp/main.c | 63 +-
1 file changed, 32 insertions(+), 31 deletions(-)
diff --git a/co
Signed-off-by: Akihiko Odaki
Reviewed-by: Peter Maydell
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 65dfdc9677e4..d25403f3709b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3583,6 +3583,7 @@ F: util/iova-tree.c
elf2dmp
M: Viktor Prutya
include/qapi/error.h says:
> We recommend
> * bool-valued functions return true on success / false on failure,
> ...
Signed-off-by: Akihiko Odaki
---
contrib/elf2dmp/pdb.h | 2 +-
contrib/elf2dmp/main.c | 2 +-
contrib/elf2dmp/pdb.c | 50 +-
3
elf2dmp assumes little endian host in many places. Build it only for
little endian hosts until they are fixed.
Signed-off-by: Akihiko Odaki
---
contrib/elf2dmp/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/elf2dmp/meson.build b/contrib/elf2dmp/meson.buil
Not checking PA resolution failure can result in NULL deference.
Signed-off-by: Akihiko Odaki
Reviewed-by: Peter Maydell
---
contrib/elf2dmp/addrspace.c | 46 -
1 file changed, 29 insertions(+), 17 deletions(-)
diff --git a/contrib/elf2dmp/addrspace.
On 7/3/24 11:20, Akihiko Odaki wrote:
pa_space_create() used to return an integer to propagate error, but
it never fails so let it return void.
Signed-off-by: Akihiko Odaki
---
contrib/elf2dmp/addrspace.h | 2 +-
contrib/elf2dmp/addrspace.c | 4 +---
contrib/elf2dmp/main.c | 5 +
On 7/3/24 11:20, Akihiko Odaki wrote:
include/qapi/error.h says:
We recommend
* bool-valued functions return true on success / false on failure,
...
Signed-off-by: Akihiko Odaki
---
contrib/elf2dmp/addrspace.h | 4 ++--
contrib/elf2dmp/addrspace.c | 8
contrib/elf2dmp/main.c
On 7/3/24 11:20, Akihiko Odaki wrote:
The relevant value may be unaligned and is little-endian.
Fixes: 231f6a7d66 ("elf2dmp: rework PDB_STREAM_INDEXES::segments obtaining")
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Akihiko Odaki
---
contrib/elf2dmp/pdb.c | 3 ++-
1 file changed
On 7/3/24 11:20, Akihiko Odaki wrote:
Signed-off-by: Akihiko Odaki
Reviewed-by: Peter Maydell
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
Reviewed-by: Philippe Mathieu-Daudé
On 7/3/24 11:20, Akihiko Odaki wrote:
rol64() is roubust against too large shift values and fixes UBSan
warnings.
Signed-off-by: Akihiko Odaki
Reviewed-by: Peter Maydell
---
contrib/elf2dmp/main.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
Reviewed-by: Philippe Mathieu-
On 3/7/24 10:53, Vladimir Sementsov-Ogievskiy wrote:
On 06.03.24 16:34, Cédric Le Goater wrote:
The purpose is to record a potential error in the migration stream if
qemu_savevm_state_setup() fails. Most of the current .save_setup()
handlers can be modified to use the Error argument instead of m
On 3/7/24 11:21, Philippe Mathieu-Daudé wrote:
> On 7/3/24 08:32, Eric Auger wrote:
>> Hi Philippe,
>>
>> On 3/6/24 21:44, Philippe Mathieu-Daudé wrote:
>>> On 6/3/24 21:32, Eric Auger wrote:
We are missing an entry for the virtio-iommu-pci device. Add the
information on which machine
On 3/5/24 04:38, Jamin Lin wrote:
-Original Message-
From: Cédric Le Goater
Sent: Monday, March 4, 2024 11:54 PM
To: Jamin Lin ; Peter Maydell
; Andrew Jeffery ;
Joel Stanley ; Alistair Francis ; open
list:ASPEED BMCs ; open list:All patches CC here
Cc: Troy Lee ; Yunlin Tang
Subject:
On Thu, 7 Mar 2024 at 01:03, yb liu wrote:
>
> Thanks a lot for you respond me soon!
> The exact instruction is mrc, and the exception happended in early boot
> process. I have no idea to how to debug this error because it happended in
> code_gen_prologue.
That's a system register access. If yo
This patch moves the below instructions to decodetree specification :
f{add, sub, mul, div, re, rsqrte, madd, msub, nmadd, nmsub}[s][.] : A-form
ft{div, sqrt} : X-form
With this patch, all the floating-point arithmetic instructions have
On Wed, Mar 6, 2024 at 8:34 AM Michael S. Tsirkin wrote:
>
> On Wed, Mar 06, 2024 at 08:07:31AM +0100, Eugenio Perez Martin wrote:
> > On Wed, Mar 6, 2024 at 6:34 AM Jason Wang wrote:
> > >
> > > On Tue, Mar 5, 2024 at 3:46 AM Jonah Palmer
> > > wrote:
> > > >
> > > > The goal of these patches
On 3/7/2024 4:39 PM, Markus Armbruster wrote:
Xiaoyao Li writes:
On 2/29/2024 9:25 PM, Markus Armbruster wrote:
Xiaoyao Li writes:
On 2/29/2024 4:37 PM, Markus Armbruster wrote:
Xiaoyao Li writes:
From: Isaku Yamahata
Three sha384 hash values, mrconfigid, mrowner and mrownerconfig, o
On 2/29/2024 9:28 PM, Markus Armbruster wrote:
Xiaoyao Li writes:
On 2/29/2024 4:40 PM, Markus Armbruster wrote:
Xiaoyao Li writes:
From: Isaku Yamahata
Add property "quote-generation-socket" to tdx-guest, which is a property
of type SocketAddress to specify Quote Generation Service(QGS)
On 2/29/2024 4:51 PM, Markus Armbruster wrote:
Xiaoyao Li writes:
Integrate TDX's TDX_REPORT_FATAL_ERROR into QEMU GuestPanic facility
Originated-from: Isaku Yamahata
Signed-off-by: Xiaoyao Li
---
Changes in v5:
- mention additional error information in gpa when it presents;
- refine the do
On 07.03.24 13:31, Cédric Le Goater wrote:
On 3/7/24 10:53, Vladimir Sementsov-Ogievskiy wrote:
On 06.03.24 16:34, Cédric Le Goater wrote:
The purpose is to record a potential error in the migration stream if
qemu_savevm_state_setup() fails. Most of the current .save_setup()
handlers can be mod
On 07.03.24 12:57, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Command result is racy if allow it during migration. Let's allow the
sync only in RUNNING state.
Signed-off-by: Vladimir Sementsov-Ogievskiy
If I understand this correctly, the previous commit introduces a rac
On 07.03.24 13:01, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Send a new event when guest reads virtio-pci config after
virtio_notify_config() call.
That's useful to check that guest fetched modified config, for example
after resizing disk backend.
Signed-off-by: Vladimir
On Wed, 6 Mar 2024 at 14:42, Alex Bennée wrote:
>
> The following changes since commit db596ae19040574e41d086e78469014191d7d7fc:
>
> Merge tag 'pull-target-arm-20240305' of
> https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-03-05
> 13:54:54 +)
>
> are available in the Git
On Tue, 14 Nov 2023 18:31, Philippe Mathieu-Daudé wrote:
Use TARGET_PAGE_SIZE to calculate TARGET_PAGE_ALIGN.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i386/xen/xen-hvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
index f
Peter Xu writes:
> On Tue, Mar 05, 2024 at 04:56:29PM -0300, Fabiano Rosas wrote:
>> Commit bc38feddeb ("io: fsync before closing a file channel") added a
>> fsync/fdatasync at the closing point of the QIOChannelFile to ensure
>> integrity of the migration stream in case of QEMU crash.
>>
>> The
From: Prasad Pandit
Libaio defines IO_CMD_FDSYNC command to sync all outstanding
asynchronous I/O operations, by flushing out file data to the
disk storage.
Enable linux-aio to submit such aio request. This helps to
reduce latency induced via pthread_create calls by
thread-pool (aio=threads).
S
On Tue, 14 Nov 2023 18:31, Philippe Mathieu-Daudé wrote:
We are going to replace TARGET_PAGE_MASK by a
runtime variable. In order to reduce code duplication,
propagate TARGET_PAGE_MASK to get_physmapping() and
xen_phys_offset_to_gaddr().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i386/xen/xe
On Tue, 14 Nov 2023 18:31, Philippe Mathieu-Daudé wrote:
In order to build this file once for all targets, replace:
TARGET_PAGE_BITS -> qemu_target_page_bits()
TARGET_PAGE_SIZE -> qemu_target_page_size()
TARGET_PAGE_MASK -> -qemu_target_page_size()
Signed-off-by: Philippe Mathieu-Daudé
---
On Tue, 14 Nov 2023 18:31, Philippe Mathieu-Daudé wrote:
There can only be a single xen_memory_listener definition
in a qemu-system binary.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/xen/xen-hvm-common.h | 1 +
hw/arm/xen_arm.c| 2 +-
hw/i386/xen/xen-hvm.c | 2
On Tue, 14 Nov 2023 18:31, Philippe Mathieu-Daudé wrote:
In a pair of commit we are going to call xen_read_physmap()
out of hw/i386/xen/xen-hvm.c.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/xen/xen-hvm-common.h | 1 +
hw/i386/xen/xen-hvm.c | 4 ++--
2 files changed, 3 inserti
On Tue, 14 Nov 2023 18:31, Philippe Mathieu-Daudé wrote:
xen_read_physmap() is the first function requiring
xen_physmap QLIST being initialized. Move the init
call there.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i386/xen/xen-hvm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
di
On Tue, 14 Nov 2023 18:31, Philippe Mathieu-Daudé wrote:
Extract non-x86 specific code out of xen-hvm.c,
to xen-hvm-common.c. For now this new file is
only build for x86 targets.
s/build/built
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i386/xen/xen-hvm-common.c | 473
The doc title did not match the actual definition.
Fixes: 2720ceda05 ("docs: expand firmware descriptor to allow flash without
NVRAM")
Signed-off-by: Thomas Weißschuh
Reviewed-by: Philippe Mathieu-Daudé
---
docs/interop/firmware.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
The QAPI generator now validates the alignment and rejects this file.
Signed-off-by: Thomas Weißschuh
---
docs/interop/firmware.json | 384 ++---
1 file changed, 192 insertions(+), 192 deletions(-)
diff --git a/docs/interop/firmware.json b/docs/interop/fi
The included files are part of the toplevel QAPI directory and need to
be included from there.
Signed-off-by: Thomas Weißschuh
---
docs/interop/firmware.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json
index 54a1
To make sure that the QAPI description stays valid add a testcase.
Suggested-by: Philippe Mathieu-Daudé
Link:
https://lore.kernel.org/qemu-devel/d9ce0234-4beb-4b90-b14c-76810d3b8...@linaro.org/
Signed-off-by: Thomas Weißschuh
---
docs/meson.build | 5 +
1 file changed, 5 insertions(+)
dif
The files included by firmware.json use names that do not satisfy the
generators requirements.
By including pragma.json these errors are suppressed.
Signed-off-by: Thomas Weißschuh
---
docs/interop/firmware.json | 2 ++
1 file changed, 2 insertions(+)
diff --git a/docs/interop/firmware.json b/d
docs/interop/firmware.json is currently not usable with qapi-gen.py due
to various non-functional issues.
Fix those issue to provide compatibility.
Signed-off-by: Thomas Weißschuh
---
Changes in v2:
- Add review tag from Philippe
- Add Fixes tag (Philippe)
- Add testcase (Philippe)
- Link to v1:
On 3/7/24 09:09, Eric Auger wrote:
Hi Cédric,
On 3/6/24 14:34, Cédric Le Goater wrote:
We will use the Error object to improve error reporting in the
.log_global*() handlers of VFIO. Add documentation while at it.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Cédric Le Goater
---
Cha
On Tue, 14 Nov 2023 18:31, Philippe Mathieu-Daudé wrote:
hw/i386/xen/xen-hvm-common.c content is target agnostic,
and should be common to all targets. Merge both files.
Remove the now unnecessary xen_register_framebuffer() stub.
ARM targets now inherit the common xen_memory_listener.
Signed-of
On Tue, 14 Nov 2023 18:31, Philippe Mathieu-Daudé wrote:
xen_arch_set_memory() is not arch-specific anymore. Being
called once, inline it in xen_set_memory().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/xen/xen-hvm-common.h | 3 -
hw/xen/xen-hvm-common.c | 104 +++
> > > @@ -868,16 +974,24 @@ static int cxl_type3_hpa_to_as_and_dpa(CXLType3Dev
> > > *ct3d,
> > > AddressSpace **as,
> > > uint64_t *dpa_offset)
> > > {
> > > -MemoryRegion *vmr = NULL, *pmr = NULL;
> > > +Mem
On 07.03.24 08:36, Wu, Fei2 wrote:
On 3/6/2024 9:26 PM, Wu, Fei wrote:
On 3/5/2024 1:58 PM, Wu, Fei wrote:
On 3/5/2024 3:43 AM, Daniel Henrique Barboza wrote:
On 3/4/24 07:25, Fei Wu wrote:
The harts requirements of RISC-V server platform [1] require RVA23 ISA
profile support, plus Sv48, Sv
On Wed, 6 Mar 2024 13:39:50 -0800
fan wrote:
> > > +}
> > > +if (len2) {
> > > +cxl_insert_extent_to_extent_list(extent_list,
> > > dpa + len,
> > > + len2, NULL, 0);
> > > +
Het Gala writes:
> On 06/03/24 9:31 pm, Fabiano Rosas wrote:
>> Het Gala writes:
>>
>>> On 06/03/24 8:06 pm, Fabiano Rosas wrote:
Het Gala writes:
> Add a migrate_set_ports() function that from each QDict, fills in
> the port in case it was 0 in the test.
> Handle a list
> > > +static void cxl_destroy_dc_regions(CXLType3Dev *ct3d)
> > > +{
> > > +CXLDCExtent *ent;
> > > +
> > > +while (!QTAILQ_EMPTY(&ct3d->dc.extents)) {
> > > +ent = QTAILQ_FIRST(&ct3d->dc.extents);
> > > +cxl_remove_extent_from_extent_list(&ct3d->dc.extents, ent);
> >
>
Cédric Le Goater writes:
> This will prepare ground for future changes adding an Error** argument
> to the save_setup() handler. We need to make sure that on failure,
> ram_save_setup() sets a new error.
>
> Signed-off-by: Cédric Le Goater
Reviewed-by: Fabiano Rosas
...
> > > +list = records;
> > > +extents = g_new0(CXLDCExtentRaw, num_extents);
> > > +while (list) {
> > > +CXLDCExtent *ent;
> > > +bool skip_extent = false;
> > > +
> > > +offset = list->value->offset;
> > > +len = list->value->len;
> > > +
> > > +
1 - 100 of 325 matches
Mail list logo
