From: Bryan Zhang
Some glue code was missing, so that using `qmp_migrate_set_parameters`
to set `multifd-zstd-level` or `multifd-zlib-level` did not work. This
commit adds the glue code to fix that.
Signed-off-by: Bryan Zhang
---
migration/options.c | 12
1 file changed, 12 insert
On Fri, Mar 01, 2024 at 03:58:59AM +, Bryan Zhang wrote:
> From: Bryan Zhang
>
> There is some glue code missing, such that the
> `qmp_migrate_set_parameters` function does not properly update the
> `multifd_zstd_level` and `multifd_zlib_level` parameters. This patch
> adds the glue code and
On Thu, Feb 15, 2024 at 02:28:15PM +, Jonathan Cameron wrote:
> Precursor to factoring out the inner loops for reuse.
>
> Signed-off-by: Jonathan Cameron
Reviewed-by: Peter Xu
--
Peter Xu
On Thu, Feb 15, 2024 at 02:28:16PM +, Jonathan Cameron wrote:
> This code will be reused for the address_space_cached accessors
> shortly.
>
> Also reduce scope of result variable now we aren't directly
> calling this in the loop.
>
> Signed-off-by: Jonathan Cameron
> ---
> system/physmem.c
On Fri, Mar 01, 2024 at 01:29:04PM +0800, Peter Xu wrote:
> On Thu, Feb 15, 2024 at 02:28:16PM +, Jonathan Cameron wrote:
> > This code will be reused for the address_space_cached accessors
> > shortly.
> >
> > Also reduce scope of result variable now we aren't directly
> > calling this in the
On Thu, Feb 29, 2024 at 07:38:06PM +, Bernhard Beschow wrote:
>
>
> Am 26. Februar 2024 21:59:07 UTC schrieb Bernhard Beschow :
> >As reported by Volker [1], commit 6f6ad2b24582 "hw/i386/pc: Confine system
> >
> >flash handling to pc_sysfw" causes a regression when specifying the property
> >
On Thu, Feb 15, 2024 at 02:28:17PM +, Jonathan Cameron wrote:
Can we rename the subject?
physmem: Fix wrong MR in large address_space_read/write_cached_slow()
IMHO "wrong MR" is misleading, as the MR was wrong only because the address
passed over is wrong at the first place. Perhaps s/MR/
Hao Xiang writes:
> On Wed, Feb 28, 2024 at 10:01 PM Markus Armbruster wrote:
>>
>> Hao Xiang writes:
>>
>> > On Wed, Feb 28, 2024 at 1:52 AM Markus Armbruster
>> > wrote:
>> >>
>> >> Hao Xiang writes:
>> >>
>> >> > This change extends the MigrationStatus interface to track zero pages
>> >>
BALATON Zoltan writes:
> On Thu, 29 Feb 2024, Sven Schnelle wrote:
>> BALATON Zoltan writes:
>> Yes, i changed it to describe the new method:
>>
>>/*
>> * Some windows drivers make the device spin waiting for a memory location
>> * to change. If we have executed more than LSI_MAX_INS
Steve Sistare writes:
> Re-wrap the cpr-reboot documentation to 70 columns, use '@' for
> cpr-reboot references, capitalize COLO and VFIO, and tweak the
> wording.
>
> Suggested-by: Markus Armbruster
> Signed-off-by: Steve Sistare
> ---
> qapi/migration.json | 36 +++---
> >> You have added drawers, books here. Were they missing before?
> >>
> >
> > ...so yes, I think those 2 parameters are missed at this place.
>
> ok. If there is another revision then add a line about this change in the
> commit message. Otherwise it is fine.
>
> Reviewed-by: Babu Moger
>
Su
On Fri, Mar 01, 2024 at 06:57:32AM +0100, Markus Armbruster wrote:
> Upper case "QEMU", please. More of the same below.
Fixed five occurances in my queue, attached R-b.
https://gitlab.com/peterx/qemu/-/commit/87a2848715f5fc4fa114574dbbf7a5564cb4cdd7
Thanks!
--
Peter Xu
> > @@ -832,6 +832,7 @@ static void ivshmem_write_config(PCIDevice *pdev,
> > uint32_t address,
> > static void ivshmem_common_realize(PCIDevice *dev, Error **errp)
> > {
> > +ERRP_GUARD();
> > IVShmemState *s = IVSHMEM_COMMON(dev);
> > Error *err = NULL;
>
> Please remove "er
> > @@ -220,6 +220,7 @@ static int vhost_scsi_set_workers(VHostSCSICommon *vsc,
> > bool per_virtqueue)
> > static void vhost_scsi_realize(DeviceState *dev, Error **errp)
> > {
> > +ERRP_GUARD();
> > VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(dev);
> > VHostSCSICommon *vsc = VHO
> > diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
> > index a63d990e4e8e..1a1c09612271 100644
> > --- a/target/s390x/cpu_models.c
> > +++ b/target/s390x/cpu_models.c
> > @@ -503,6 +503,7 @@ static void error_prepend_missing_feat(const char
> > *name, void *opaque)
> > static
Hi Alex,
I hit the following warnings (with "./configure --enable-werror"):
/qemu/contrib/plugins/execlog.c: In function ‘registers_init’:
/qemu/contrib/plugins/execlog.c:330:17: warning: ‘g_pattern_match_string’ is
deprecated: Use 'g_pattern_spec_match_string' instead
[-Wdeprecated-declaration
Peter Xu writes:
> On Thu, Feb 29, 2024 at 12:29:54PM -0300, Fabiano Rosas wrote:
>> Based-on: 74aa0fb297 (migration: options incompatible with cpr) #
>> peterx/migration-next
>>
>> Hi,
>>
>> In this v6:
>>
>> - Minor fixes to 17/23 and 19/23
>
> The whole set looks good to me now. I plan to
Hao Xiang writes:
> This new parameter controls where the zero page checking is running.
> 1. If this parameter is set to 'legacy', zero page checking is
> done in the migration main thread.
> 2. If this parameter is set to 'none', zero page checking is disabled.
>
> Signed-off-by: Hao Xiang
QA
Hao Xiang writes:
> 1. Add zero_pages field in MultiFDPacket_t.
> 2. Implements the zero page detection and handling on the multifd
> threads for non-compression, zlib and zstd compression backends.
> 3. Added a new value 'multifd' in ZeroPageDetection enumeration.
> 4. Handle migration QEMU9.0 -
NXP PCF8574 and compatible ICs are simple I2C GPIO expanders.
PCF8574 incorporates quasi-bidirectional IO, and simple
communication protocol, when IO read is I2C byte read, and
IO write is I2C byte write. User can think of it as
open-drain port, when line high state is input and line low
state is o
On 18/01/2024 15.48, Zhao Liu wrote:
From: Zhao Liu
Use MAX_CPUS/MIN_CPUS micros in invalid topology case. This gives us the
s/micros/macros/
Apart from that typo, FWIW:
Reviewed-by: Thomas Huth
flexibility to change the maximum and minimum CPU limits.
Signed-off-by: Zhao Liu
---
test
On 18/01/2024 15.48, Zhao Liu wrote:
From: Zhao Liu
PC mahine is trying to support up to 4096 vCPUs [1], so it's necessary
s/mahine/machine/
to bump max_cpus in test-smp-parse to 4096 to cover the topological
needs of future machines.
[1]:
https://lore.kernel.org/qemu-devel/20231208122611
Hao Xiang writes:
> This change extends the MigrationStatus interface to track zero pages
> and zero bytes counter.
>
> Signed-off-by: Hao Xiang
[...]
> diff --git a/qapi/migration.json b/qapi/migration.json
> index ca9561fbf1..03b850bab7 100644
> --- a/qapi/migration.json
> +++ b/qapi/migrati
On Thu, Feb 29, 2024 at 9:32 AM Stefano Garzarella wrote:
>
> Hi Sahil,
>
> On Sun, Feb 25, 2024 at 10:38 PM Sahil wrote:
> >
> > Hi,
> >
> > My name is Sahil and I go by the pseudonym 'valdaarhun' on Github. I have
> > never contributed to QEMU before but I have used it a few times as an end
> >
Hi Thomas,
On Fri, Mar 01, 2024 at 08:40:54AM +0100, Thomas Huth wrote:
> Date: Fri, 1 Mar 2024 08:40:54 +0100
> From: Thomas Huth
> Subject: Re: [PATCH 2/8] tests/unit/test-smp-parse.c: Bump max_cpus to 4096
>
> On 18/01/2024 15.48, Zhao Liu wrote:
> > From: Zhao Liu
> >
> > PC mahine is tryi
On Thu, Feb 29, 2024 at 07:03:36AM +0100, Markus Armbruster wrote:
> Steven Sistare writes:
>
> > Just a reminder, after our further discussion in the V1 thread,
> > this patch is still what I propose, no updates needed.
> >
> > Markus, I think Peter is looking for your blessing on the new
> > f
On 18/01/2024 15.48, Zhao Liu wrote:
From: Zhao Liu
Currently, -smp supports 2 more new levels: book and drawer.
It is necessary to consider the effects of book and drawer in the test
cases to ensure that the calculations are correct. This is also the
preparation to add new book and drawer tes
On 18/01/2024 15.48, Zhao Liu wrote:
From: Zhao Liu
Although book was introduced to -smp along with drawer by s390 machine,
as a general topology level in QEMU that may be reused by other arches
in the future, it is desirable to cover this parameter's parsing in a
separate case.
Signed-off-by:
On 18/01/2024 15.48, Zhao Liu wrote:
From: Zhao Liu
Although drawer was introduced to -smp along with book by s390 machine,
as a general topology level in QEMU that may be reused by other arches
in the future, it is desirable to cover this parameter's parsing in a
separate case.
Signed-off-by:
301 - 329 of 329 matches
Mail list logo
