[PULL 06/17] i386/cpuid: Decrease cpuid_i when skipping CPUID leaf 1F

From: Xiaoyao Li Existing code misses a decrement of cpuid_i when skip leaf 0x1F. There's a blank CPUID entry(with leaf, subleaf as 0, and all fields stuffed 0s) left in the CPUID array. It conflicts with correct CPUID leaf 0. Signed-off-by: Xiaoyao Li Reviewed-by:Yang Weijiang Message-ID: <2

[PULL 00/17] Build, x86 patches for 2024-02-16

The following changes since commit 3ff11e4dcabe2b5b4c26e49d741018ec326f127f: Merge tag 'pull-target-arm-20240215' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-02-15 17:36:30 +) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for

[PULL 05/17] physmem: replace function name with __func__ in ram_block_discard_range()

From: Xiaoyao Li Use __func__ to avoid hard-coded function name. Signed-off-by: Xiaoyao Li Reviewed-by: David Hildenbrand Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240125023328.2520888-1-xiaoyao...@intel.com> Signed-off-by: Paolo Bonzini --- system/physmem.c | 38 +-

[PULL 04/17] i386/pc: Drop pc_machine_kvm_type()

From: Xiaoyao Li pc_machine_kvm_type() was introduced by commit e21be724eaf5 ("i386/xen: add pc_machine_kvm_type to initialize XEN_EMULATE mode") to do Xen specific initialization by utilizing kvm_type method. commit eeedfe6c6316 ("hw/xen: Simplify emulated Xen platform init") moves the Xen spec

[PULL 01/17] i386/cpu: Clear FEAT_XSAVE_XSS_LO/HI leafs when CPUID_EXT_XSAVE is not available

From: Xiaoyao Li Leaf FEAT_XSAVE_XSS_LO and FEAT_XSAVE_XSS_HI also need to be cleared when CPUID_EXT_XSAVE is not set. Fixes: 301e90675c3f ("target/i386: Enable support for XSAVES based features") Signed-off-by: Xiaoyao Li Reviewed-by: Yang Weijiang Message-ID: <20240115091325.1904229-2-xiaoya

[PULL 03/17] target/i386: Add support of KVM_FEATURE_ASYNC_PF_VMEXIT for guest

From: Xiaoyao Li KVM_FEATURE_ASYNC_PF_VMEXIT has been introduced for years, however QEMU doesn't support expose it to guest. Add support for it. Signed-off-by: Xiaoyao Li Message-ID: <20231024083354.1171308-1-xiaoyao...@intel.com> Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 2 +- 1 f

[PULL 10/17] isa-superio: validate floppy.count value

Ensure that the value is valid; it can only be zero or one. And never create a floppy disk controller if it is zero. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- hw/isa/isa-superio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/isa/isa-superi

[PULL 08/17] i386/cpuid: Move leaf 7 to correct group

From: Xiaoyao Li CPUID leaf 7 was grouped together with SGX leaf 0x12 by commit b9edbadefb9e ("i386: Propagate SGX CPUID sub-leafs to KVM") by mistake. SGX leaf 0x12 has its specific logic to check if subleaf (starting from 2) is valid or not by checking the bit 0:3 of corresponding EAX is 1 or

[PULL 02/17] i386/cpu: Mask with XCR0/XSS mask for FEAT_XSAVE_XCR0_HI and FEAT_XSAVE_XSS_HI leafs

From: Xiaoyao Li The value of FEAT_XSAVE_XCR0_HI leaf and FEAT_XSAVE_XSS_HI leaf also need to be masked by XCR0 and XSS mask respectively, to make it logically correct. Fixes: 301e90675c3f ("target/i386: Enable support for XSAVES based features") Signed-off-by: Xiaoyao Li Reviewed-by: Yang Weij

[PULL 11/17] smc37c669: remove useless is_enabled functions

Calls to is_enabled are bounded to indices that actually exist in the SuperIO device. Therefore, the is_enabled functions in smc37c669 are not doing anything and they can be removed. Reviewed-by: Bernhard Beschow Signed-off-by: Paolo Bonzini --- hw/isa/smc37c669-superio.c | 18

[PULL 09/17] mips: remove unnecessary "select PTIMER"

There is no use of ptimer functions in mips_cps.c or any other related code. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- hw/mips/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig index 505381a0bba..ab61af209a0 100644 --- a/hw/m

[PULL 16/17] usb: inline device creation functions

Allow boards to use the device creation functions even if USB itself is not available; of course the functions will fail inexorably, but this can be okay if the calls are conditional on the existence of some USB host controller device. This is for example the case for hw/mips/loongson3_virt.c. Ac

[PULL 14/17] i386: xen: fix compilation --without-default-devices

The xenpv machine type requires XEN_BUS, so select it. Signed-off-by: Paolo Bonzini --- accel/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/accel/Kconfig b/accel/Kconfig index a30cf2eb483..794e0d18d21 100644 --- a/accel/Kconfig +++ b/accel/Kconfig @@ -16,3 +16,4 @@ config KVM conf

[PULL 12/17] configure: do not create legacy symlinks

With more than three years since Meson was introduced in the build system, people have had quite some time to move away from the foo-softmmu/qemu-system-* and foo-linux-user/qemu-* symbolic links. Remove them, and with them another instance of the "softmmu" name for system emulators. Reviewed-by

[PULL 13/17] configure: put all symlink creation together

Cc: Thomas Huth Signed-off-by: Paolo Bonzini --- configure | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 9cdb5a6818b..3cd736b139f 100755 --- a/configure +++ b/configure @@ -1538,6 +1538,11 @@ for f in $LINKS ; do fi done +# use

[PULL 15/17] target/i386: Generate an illegal opcode exception on cmp instructions with lock prefix

From: Ziqiao Kong target/i386: As specified by Intel Manual Vol2 3-180, cmp instructions are not allowed to have lock prefix and a `UD` should be raised. Without this patch, s1->T0 will be uninitialized and used in the case OP_CMPL. Signed-off-by: Ziqiao Kong Message-ID: <20240215095015.570748-

[PULL 17/17] ci: Fix again build-previous-qemu

The build-previous-qemu job is now trying to fetch from the upstream repository, but the tag is only fetched into FETCH_HEAD: $ git remote add upstream https://gitlab.com/qemu-project/qemu 00:00 $ git fetch upstream $QEMU_PREV_VERSION 00:02 warning: redirecting to https://gitlab.com/qemu-project/q

[PATCH] MAINTAINERS: Remove myself as reviewer from PPC

PPC maintainership has been a side activity for the last 2 years and it is time to let go some of it now that Nick has taken over. Signed-off-by: Cédric Le Goater --- MAINTAINERS | 3 --- 1 file changed, 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index a74d73960c0a..f5a4e4745c92 1006

[PULL 07/17] i386/cpuid: Remove subleaf constraint on CPUID leaf 1F

From: Xiaoyao Li No such constraint that subleaf index needs to be less than 64. Signed-off-by: Xiaoyao Li Reviewed-by:Yang Weijiang Message-ID: <20240125024016.2521244-3-xiaoyao...@intel.com> Signed-off-by: Paolo Bonzini --- target/i386/kvm/kvm.c | 4 1 file changed, 4 deletions(-) di

Re: [PATCH v2] target/i386/kvm: Refine VMX controls setting for backward compatibility

On 11/27/2023 11:43 AM, EwanHai wrote: Commit 4a910e1 ("target/i386: do not set unsupported VMX secondary execution controls") implemented a workaround for hosts that have specific CPUID features but do not support the corresponding VMX controls, e.g., hosts support RDSEED but do not support RDSE

[PATCH v4 00/15] Nested PAPR API (KVM on PowerVM)

There is an existing Nested-HV API to enable nested guests on powernv machines. However, that is not supported on pseries/PowerVM LPARs. This patch series implements required hcall interfaces to enable nested guests with KVM on PowerVM. Unlike Nested-HV, with this API, entire L2 state is retained b

[PATCH v4 02/15] spapr: nested: move nested part of spapr_get_pate into spapr_nested.c

Most of the nested code has already been moved to spapr_nested.c This logic inside spapr_get_pate is related to nested guests and better suited for spapr_nested.c, hence moving there. Signed-off-by: Harsh Prateek Bora Reviewed-by: Nicholas Piggin --- include/hw/ppc/spapr_nested.h | 3 ++- hw/p

[PATCH v4 01/15] spapr: nested: register nested-hv api hcalls only for cap-nested-hv

Since cap-nested-hv is an optional capability, it makes sense to register api specfic hcalls only when respective capability is enabled. This requires to introduce a new API to unregister hypercalls to maintain sanity across guest reboot since caps are re-applied across reboots and re-registeration

[PATCH v4 05/15] spapr: nested: Document Nested PAPR API

Adding initial documentation about Nested PAPR API to describe the set of APIs and its usage. Also talks about the Guest State Buffer elements and it's format which is used between L0/L1 to communicate L2 state. Signed-off-by: Michael Neuling Signed-off-by: Harsh Prateek Bora --- docs/devel/nes

[PATCH v4 12/15] spapr: nested: Use correct source for parttbl info for nested PAPR API.

For nested PAPR API, we use SpaprMachineStateNestedGuest struct to store partition table info, use the same in spapr_get_pate_nested() via helper. Signed-off-by: Michael Neuling Signed-off-by: Harsh Prateek Bora --- include/hw/ppc/spapr_nested.h | 4 hw/ppc/spapr.c| 2 ++

[PATCH v4 10/15] spapr: nested: Initialize the GSB elements lookup table.

Nested PAPR API provides a standard Guest State Buffer (GSB) format with unique IDs for each guest state element for which get/set state is supported by the API. Some of the elements are read-only and/or guest-wide. Introducing helper routines for state exchange of each of the nested guest state el

[PATCH v4 11/15] spapr: nested: Introduce H_GUEST_[GET|SET]_STATE hcalls.

Introduce the nested PAPR hcalls: - H_GUEST_GET_STATE which is used to get state of a nested guest or a guest VCPU. The value field for each element in the request is ignored and on success, will be updated to reflect current state. - H_GUEST_SET_STATE which is used to modify th

[PATCH v4 08/15] spapr: nested: Introduce H_GUEST_CREATE_VCPU hcall.

Introduce the nested PAPR hcall H_GUEST_CREATE_VCPU which is used to create and initialize the specified VCPU resource for the previously created guest. Each guest can have multiple VCPUs upto max 2048. All VCPUs for a guest gets deallocated on guest delete. Signed-off-by: Michael Neuling Signed-

[PATCH v4 14/15] spapr: nested: Introduce cap-nested-papr for Nested PAPR API

Introduce a SPAPR capability cap-nested-papr which enables nested PAPR API for nested guests. This new API is to enable support for KVM on PowerVM and the support in Linux kernel has already merged upstream. Signed-off-by: Michael Neuling Signed-off-by: Harsh Prateek Bora --- include/hw/ppc/spa

[PATCH v4 15/15] spapr: nested: Set the PCR when logical PVR is set

From: Amit Machhiwal In APIv1, KVM L0 sets the PCR, while in the nested papr APIv2, this doesn't work as the PCR can't be set via the guest state buffer; the logical PVR is set via the GSB though. This change sets the PCR whenever the logical PVR is set via the GSB. Also, unlike the other regist

[PATCH v4 06/15] spapr: nested: Introduce H_GUEST_[GET|SET]_CAPABILITIES hcalls.

Introduce the nested PAPR hcalls: - H_GUEST_GET_CAPABILITIES which is used to query the capabilities of the API and the L2 guests it provides. - H_GUEST_SET_CAPABILITIES which is used to set the Guest API capabilities that the Host Partition supports and may use. [amachhiw: support for p9

[PATCH v4 03/15] spapr: nested: Introduce SpaprMachineStateNested to store related info.

Currently, nested_ptcr is being used by existing nested-hv API to store nested guest related info. This need to be organised to extend support for the nested PAPR API which would need to store additional info related to nested guests in next series of patches. Signed-off-by: Michael Neuling Signe

Re: [PATCH 07/15] qga/qapi-schema: Clean up documentation of guest-set-memory-blocks

Reviewed-by: Konstantin Kostiuk On Mon, Feb 5, 2024 at 9:47 AM Markus Armbruster wrote: > The command's doc comment describes the argument, but it's not marked > up as such. Easy enough to fix. > > Signed-off-by: Markus Armbruster > --- > qga/qapi-schema.json | 19 ++- > 1 fi

[PATCH v4 04/15] spapr: nested: keep nested-hv related code restricted to its API.

spapr_exit_nested and spapr_get_pate_nested_hv contains code which is specific to nested-hv API. Isolating code flows based on API helps extending it to be used with different API as well. Signed-off-by: Harsh Prateek Bora Suggested-by: Nicholas Piggin --- include/hw/ppc/spapr_nested.h | 4 +++

[PATCH v4 07/15] spapr: nested: Introduce H_GUEST_[CREATE|DELETE] hcalls.

Introduce the nested PAPR hcalls: - H_GUEST_CREATE which is used to create and allocate resources for nested guest being created. - H_GUEST_DELETE which is used to delete and deallocate resources for the nested guest being deleted. It also supports deleting all nested guests at once using a

[PATCH v4 13/15] spapr: nested: Introduce H_GUEST_RUN_VCPU hcall.

The H_GUEST_RUN_VCPU hcall is used to start execution of a Guest VCPU. The Hypervisor will update the state of the Guest VCPU based on the input buffer, restore the saved Guest VCPU state, and start its execution. The Guest VCPU can stop running for numerous reasons including HCALLs, hypervisor ex

[PATCH v4 09/15] spapr: nested: Extend nested_ppc_state for nested PAPR API

Currently, nested_ppc_state stores a certain set of registers and works with nested_[load|save]_state() for state transfer as reqd for nested-hv API. Extending these with additional registers state as reqd for nested PAPR API. Signed-off-by: Harsh Prateek Bora Suggested-by: Nicholas Piggin ---

Re: [PATCH] MAINTAINERS: Remove myself as reviewer from PPC

On Tue, Feb 20, 2024 at 09:09:56AM +0100, Cédric le Goater wrote: > PPC maintainership has been a side activity for the last 2 years and > it is time to let go some of it now that Nick has taken over. > > Signed-off-by: Cédric Le Goater Thanks for all your contributions Cédric. > --- > MAINTAI

[PATCH v1 05/21] loongson3: correct typos

Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- hw/mips/loongson3_bootp.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/mips/loongson3_bootp.h b/hw/mips/loongson3_bootp.h index d525ab745a

[PATCH v1 00/21] Trivial tree wide typo fixes

Correct typos automatically found with the `typos` tool Manos Pitsidianakis (21): docs: correct typos tests: correct typos Xen headers: correct typos accel/tcg: correct typos loongson3: correct typos ppc: correct typos sh4: correct typos include/exe

[PATCH v1 18/21] hexagon: correct typos

Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- target/hexagon/idef-parser/macros.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hexagon/idef-parser/macros.inc b/target/hexagon/idef-p

[PATCH v1 08/21] include/exec/memory.h: correct typos

Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- include/exec/memory.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 177be23db7..8626a355b3 100

[PATCH v1 16/21] qemu-options.hx: correct typos

Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 8547254dbf..9be1e5817c 100644 --- a/qemu

[PATCH v1 06/21] ppc: correct typos

Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- include/hw/ppc/ppc4xx.h | 2 +- hw/ppc/ppc405.h | 2 +- target/ppc/translate/vmx-impl.c.inc | 2 +- 3 files changed, 3 insertions(+), 3

[PATCH v1 01/21] docs: correct typos

Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- docs/devel/ci-jobs.rst.inc | 2 +- docs/devel/docs.rst | 2 +- docs/devel/testing.rst | 2 +- docs/interop/prl-xml.txt| 2 +- docs/int

[PATCH v1 19/21] m68k: correct typos

Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- target/m68k/cpu.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target/m68k/cpu.h b/target/m68k/cpu.h index aca4aa610b..57e3b6d3ce 100644 -

[PATCH v1 13/21] hw/riscv/virt.h: correct typos

Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- include/hw/riscv/virt.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/hw/riscv/virt.h b/include/hw/riscv/virt.h index f89790fd58..3db8

[PATCH v1 15/21] qapi/ui: correct typos

Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- qapi/ui.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi/ui.json b/qapi/ui.json index b6d7e142b7..1448eaca73 100644 --- a/qapi/ui.json

[PATCH v1 07/21] sh4: correct typos

Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- hw/sh4/sh7750_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sh4/sh7750_regs.h b/hw/sh4/sh7750_regs.h index edb5d18f00..946ad7b3aa 100644

[PATCH v2 2/7] hw/ide: Split qdev.c into ide-bus.c and ide-dev.c

qdev.c is a mixture between IDE bus specific functions and IDE device functions. Let's split it up to make it more obvious which part is related to bus handling and which part is related to device handling. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- hw/ide/ide-bus.c

[PATCH v1 21/21] target/sparc: correct typos

Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- target/sparc/asi.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/sparc/asi.h b/target/sparc/asi.h index 3270ed0c7f..a66829674b 1006

[PATCH v2 3/7] hw/ide: Move IDE DMA related definitions to a separate header ide-dma.h

These definitions are required outside of the hw/ide/ code, too, so lets's move them from internal.h to a new header called ide-dma.h. Signed-off-by: Thomas Huth --- include/hw/ide/ide-dma.h | 37 + include/hw/ide/internal.h | 29 +

[PATCH v1 04/21] accel/tcg: correct typos

Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- accel/tcg/ldst_atomicity.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/ldst_atomicity.c.inc b/accel/tcg/ldst_atomicity.c.inc index

Re: [PATCH v4 2/7] qapi: Make parameter 'file' optional for BlockdevCreateOptionsLUKS

Yong Huang writes: > On Tue, Feb 20, 2024 at 2:31 PM Markus Armbruster wrote: > >> yong.hu...@smartx.com writes: >> >> > From: Hyman Huang >> > >> > To support detached LUKS header creation, make the existing 'file' >> > field in BlockdevCreateOptionsLUKS optional. >> > >> > Signed-off-by: Hyma

[PATCH v1 02/21] tests: correct typos

Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- tests/avocado/acpi-bits/bits-tests/smbios.py2 | 2 +- tests/avocado/mem-addr-space-check.py | 6 +++--- tests/avocado/reverse_debugging.py| 2 +- 3

[PATCH v2 7/7] hw/ide: Stop exposing internal.h to non-IDE files

include/hw/ide/internal.h is currently included by include/hw/ide/pci.h and thus exposed to a lot of files that are not part of the IDE subsystem. Stop including internal.h there and use the appropriate new headers ide-bus.h and ide-dma.h instead. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by

[PATCH v2 5/7] hw/ide: Move IDE bus related definitions to a new header ide-bus.h

Let's consolidate the public IDE bus related functions in a separate header. Signed-off-by: Thomas Huth --- include/hw/ide/ide-bus.h | 42 +++ include/hw/ide/internal.h | 40 + 2 files changed, 43 insertions(+), 39 deletion

[PATCH v1 03/21] Xen headers: correct typos

Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- include/hw/xen/interface/arch-x86/xen-x86_64.h | 2 +- include/hw/xen/interface/arch-x86/xen.h| 2 +- include/hw/xen/interface/event_channel.h | 2 +- inc

[PATCH v2 0/7] hw/ide: Clean up hw/ide/qdev.c and include/hw/ide/internal.h

While trying to make it possible to compile-out the CompactFlash IDE device in downstream distributions (first patch), we noticed that there are more things in the IDE code that could use a proper clean up: First, hw/ide/qdev.c is quite a mix between IDE BUS specific functions and (disk) device sp

[PATCH v1 20/21] s390x: correct typos

Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- target/s390x/cpu_features_def.h.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/cpu_features_def.h.inc b/target/s390x/cpu_features

[PATCH v1 11/21] hw/cxl/cxl_device.h: correct typos

Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- include/hw/cxl/cxl_device.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/hw/cxl/cxl_device.h b/include/hw/cxl/cxl_device.h index d8e1

[PATCH v2 4/7] hw/ide: Move IDE device related definitions to ide-dev.h

Unentangle internal.h by moving public IDE device related definitions to ide-dev.h. Signed-off-by: Thomas Huth --- include/hw/ide/ide-dev.h | 143 +- include/hw/ide/internal.h | 143 +- hw/ide/ide-dev.c | 1 + 3

[PATCH v2 1/7] hw/ide: Add the possibility to disable the CompactFlash device in the build

For distros like downstream RHEL, it would be helpful to allow to disable the CompactFlash device. For making this possible, we need a separate Kconfig switch for this device, and the code should reside in a separate file. Let's also introduce a new header ide-dev.h which can be used to collect def

[PATCH v2 6/7] hw/ide: Remove the include/hw/ide.h legacy file

There was only one prototype left in this legacy file. Move it to ide-dev.h to finally get rid of it. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- MAINTAINERS | 1 - include/hw/ide.h | 9 - include/hw/ide/ide-dev.h | 2 ++ include/hw/ide/int

[PATCH v1 12/21] hw/net/npcm_gmac.h: correct typos

Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- include/hw/net/npcm_gmac.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/hw/net/npcm_gmac.h b/include/hw/net/npcm_gmac.h index f2d9f08

[PATCH v1 17/21] ci/gitlab-pipeline-status: correct typos

Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- scripts/ci/gitlab-pipeline-status | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/ci/gitlab-pipeline-status b/scripts/ci/gitlab-pipeline-st

Re: [PATCH 08/15] qga/qapi-schema: Clean up documentation of guest-set-vcpus

Reviewed-by: Konstantin Kostiuk On Mon, Feb 5, 2024 at 9:47 AM Markus Armbruster wrote: > The command's doc comment describes the argument, but it's not marked > up as such. Easy enough to fix. > > Signed-off-by: Markus Armbruster > --- > qga/qapi-schema.json | 20 ++-- > 1 f

Re: [PATCH v1 02/21] tests: correct typos

Reviewed-by: Pavel Dovgalyuk On 20.02.2024 11:52, Manos Pitsidianakis wrote: Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- tests/avocado/acpi-bits/bits-tests/smbios.py2 | 2 +- tests/avocado/mem-addr-space-ch

[PATCH v1 10/21] hw/arm/omap.h: correct typos

Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- include/hw/arm/omap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/arm/omap.h b/include/hw/arm/omap.h index 067e9419f7..2f59220c0e 100

[PATCH v1 09/21] include/exec/plugin-gen.h: correct typos

Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- include/exec/plugin-gen.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/exec/plugin-gen.h b/include/exec/plugin-gen.h index c4552b5061..b1

[PATCH v1 14/21] pc-bios/README: correct typos

Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- pc-bios/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pc-bios/README b/pc-bios/README index 4189bb28cc..b8a0210d24 100644 --- a/pc-bios/REA

[RFC 2/8] hw/core: Move CPU topology enumeration into arch-agnostic file

From: Zhao Liu Cache topology needs to be defined based on CPU topology levels. Thus, move CPU topology enumeration into a common header. To match the general topology naming style, rename CPU_TOPO_LEVEL_SMT and CPU_TOPO_LEVEL_PACKAGE to CPU_TOPO_LEVEL_THREAD and CPU_TOPO_LEVEL_SOCKET. Also, en

[RFC 5/8] i386/cpu: Support thread and module level cache topology

From: Zhao Liu Allows cache to be defined at the thread and module level. This increases flexibility for x86 users to customize their cache topology. Signed-off-by: Zhao Liu --- target/i386/cpu.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target/i386/cpu.c b

[RFC 1/8] hw/core: Rename CpuTopology to CPUTopology

From: Zhao Liu Use CPUTopology to honor the generic style of CPU capitalization abbreviations. Signed-off-by: Zhao Liu --- hw/s390x/cpu-topology.c | 6 +++--- include/hw/boards.h | 8 include/hw/s390x/cpu-topology.h | 6 +++--- tests/unit/test-smp-parse.c |

[RFC 7/8] i386/pc: Support cache topology in -smp for PC machine

From: Zhao Liu Signed-off-by: Zhao Liu --- hw/i386/pc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 25124a077eea..76148c3337cf 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1848,6 +1848,9 @@ static void pc_machine_class_init(ObjectClass *oc, void

[RFC 8/8] qemu-options: Add the cache topology description of -smp

From: Zhao Liu Signed-off-by: Zhao Liu --- qemu-options.hx | 54 ++--- 1 file changed, 47 insertions(+), 7 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 70eaf3256685..85c78c99a3b0 100644 --- a/qemu-options.hx +++ b/qemu-options.hx

[RFC 6/8] i386/cpu: Update cache topology with machine's configuration

From: Zhao Liu User will configure SMP cache topology via -smp. For this case, update the x86 CPUs' cache topology with user's configuration in MachineState. Signed-off-by: Zhao Liu --- target/i386/cpu.c | 21 + 1 file changed, 21 insertions(+) diff --git a/target/i386/cp

[RFC 4/8] hw/core: Add cache topology options in -smp

From: Zhao Liu Add "l1d-cache", "l1i-cache". "l2-cache", and "l3-cache" options in -smp to define the cache topology for SMP system. Signed-off-by: Zhao Liu --- hw/core/machine-smp.c | 128 ++ hw/core/machine.c | 4 ++ qapi/machine.json | 14 +

[RFC 3/8] hw/core: Define cache topology for machine

From: Zhao Liu Define the cache topology based on CPU topology level for two reasons: 1. In practice, a cache will always be bound to the CPU container (either private in the CPU container or shared among multiple containers), and CPU container is often expressed in terms of CPU topolog

[RFC 0/8] Introduce SMP Cache Topology

From: Zhao Liu Hi list, This's our proposal for supporting (SMP) cache topology in -smp as the following example: -smp 32,sockets=2,dies=2,modules=2,cores=2,threads=2,maxcpus=32,\ l1d-cache=core,l1i-cache=core,l2-cache=core,l3-cache=die With the new cache topology options ("l1d-cache", "l

Re: [PATCH v4 2/7] qapi: Make parameter 'file' optional for BlockdevCreateOptionsLUKS

On Tue, Feb 20, 2024 at 4:56 PM Markus Armbruster wrote: > Yong Huang writes: > > > On Tue, Feb 20, 2024 at 2:31 PM Markus Armbruster > wrote: > > > >> yong.hu...@smartx.com writes: > >> > >> > From: Hyman Huang > >> > > >> > To support detached LUKS header creation, make the existing 'file' >

[PATCH v2 1/2] block: m25p80: Add support of mt35xu02gbba

Add Micro 2Gb OSPI flash part with sfdp data. Signed-off-by: Sai Pavan Boddu Reviewed-by: Francisco Iglesias --- hw/block/m25p80_sfdp.h | 1 + hw/block/m25p80.c | 3 +++ hw/block/m25p80_sfdp.c | 36 3 files changed, 40 insertions(+) diff --git a/hw/b

[PATCH v2 2/2] arm: xlnx-versal-virt: Add machine property ospi-flash

This property allows users to change flash model on command line as below. ex: "-M xlnx-versal-virt,ospi-flash=mt35xu02gbba" Signed-off-by: Sai Pavan Boddu --- hw/arm/xlnx-versal-virt.c | 44 ++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git

[PATCH v2 0/2] OSPI updates

Add a new 2Gib octal flash mt35xu02gbba. Add an interface for versal virt board to swap the default flash. Changes for V2: Added type checks for provided flash part name. Sai Pavan Boddu (2): block: m25p80: Add support of mt35xu02gbba arm: xlnx-versal-virt: Add machine property ospi-flash

Re: [PATCH v4 2/7] qapi: Make parameter 'file' optional for BlockdevCreateOptionsLUKS

Yong Huang writes: > On Tue, Feb 20, 2024 at 4:56 PM Markus Armbruster wrote: > >> Yong Huang writes: >> >> > On Tue, Feb 20, 2024 at 2:31 PM Markus Armbruster >> wrote: >> > >> >> yong.hu...@smartx.com writes: >> >> >> >> > From: Hyman Huang >> >> > >> >> > To support detached LUKS header cr

Re: [PATCH v1 15/21] qapi/ui: correct typos

Manos Pitsidianakis writes: > Correct typos automatically found with the `typos` tool > > > Signed-off-by: Manos Pitsidianakis > --- > qapi/ui.json | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qapi/ui.json b/qapi/ui.json > index b

Re: [PATCH v7 2/3] hw/isa/lpc_ich9: add broadcast SMI feature

On 2/20/24 08:58, Philippe Mathieu-Daudé wrote: > Hi Laszlo, Igor, Gerd, > > (old patch, now commit 5ce45c7a2b) > > On 26/1/17 02:44, Laszlo Ersek wrote: >> The generic edk2 SMM infrastructure prefers >> EFI_SMM_CONTROL2_PROTOCOL.Trigger() to inject an SMI on each >> processor. If >> Trigger() on

Re: [PATCH v4 2/7] qapi: Make parameter 'file' optional for BlockdevCreateOptionsLUKS

On Tue, Feb 20, 2024 at 5:47 PM Markus Armbruster wrote: > Yong Huang writes: > > > On Tue, Feb 20, 2024 at 4:56 PM Markus Armbruster > wrote: > > > >> Yong Huang writes: > >> > >> > On Tue, Feb 20, 2024 at 2:31 PM Markus Armbruster > >> wrote: > >> > > >> >> yong.hu...@smartx.com writes: > >

Re: [PATCH v1 04/21] accel/tcg: correct typos

Manos Pitsidianakis writes: > Correct typos automatically found with the `typos` tool > > > Signed-off-by: Manos Pitsidianakis Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v1 01/21] docs: correct typos

Manos Pitsidianakis writes: > Correct typos automatically found with the `typos` tool > > > Signed-off-by: Manos Pitsidianakis Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v2 3/3] tests/qtest: Add testcase for BCM2835 BSC

Hi Thomas, Do you want me to add an SPDX line to the other two commits or will just this one suffice? On Tue, Feb 20, 2024 at 9:45 AM Thomas Huth wrote: > On 19/02/2024 23.59, Rayhan Faizel wrote: > > Simple testcase for validating proper operation of read and write for all > > three BSC contro

Re: [PATCH v4 2/5] hw/virtio: document SharedObject structures

On Mon, 19 Feb 2024 16:34, Albert Esteve wrote: Change VirtioSharedObject value type from a generic pointer to a union storing the different supported underlying types, which makes naming less confusing. With the update, use the chance to add kdoc to both the SharedObjectType enum and VirtioSha

Re: [PATCH v1 01/21] docs: correct typos

On Tue, Feb 20, 2024 at 10:52:08AM +0200, Manos Pitsidianakis wrote: > Correct typos automatically found with the `typos` tool > > > Signed-off-by: Manos Pitsidianakis Acked-by: Michael S. Tsirkin > --- > docs/devel/ci-jobs.rst.inc | 2 +- > docs/devel/do

Re: [PATCH v4 3/5] hw/virtio: change dmabuf mutex to QemuMutex

Hello Albert, This is a point of confusion for me; Volker recently pointed out in a patch for virtio-snd that all its code runs under the BQL. Is this code ever called without BQL, for example do the backend read/write functions from vhost-user.c run without the BQL? On Mon, 19 Feb 2024 16:34

Re: [PATCH v3 08/20] qapi/schema: add type narrowing to lookup_type()

John Snow writes: > This function is a bit hard to type as-is; mypy needs some assertions to > assist with the type narrowing. > > Signed-off-by: John Snow > --- > scripts/qapi/schema.py | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/scripts/qapi/schema.py b/scripts

Re: [PATCH v4 4/5] hw/virtio: cleanup shared resources

On Mon, 19 Feb 2024 16:34, Albert Esteve wrote: Ensure that we cleanup all virtio shared resources when the vhost devices is cleaned up (after a hot unplug, or a crash). To do so, we add a new function to the virtio_dmabuf API called `virtio_dmabuf_vhost_cleanup`, which loop through the table a

Re: [PATCH v2 3/3] tests/qtest: Add testcase for BCM2835 BSC

On 20/02/2024 11.30, Rayhan Faizel wrote: Hi Thomas, Do you want me to add an SPDX line to the other two commits or will just this one suffice? I think it wouldn't hurt to add them to the new files there, too, but there's no rule in the QEMU development process that you have to do it, so it

Re: [PATCH RFCv2 2/8] vfio/iommufd: Introduce auto domain creation

On 19/02/2024 08:58, Avihai Horon wrote: > Hi Joao, > > On 12/02/2024 15:56, Joao Martins wrote: >> External email: Use caution opening links or attachments >> >> >> There's generally two modes of operation for IOMMUFD: >> >> * The simple user API which intends to perform relatively simple things

Re: [PATCH v1 19/21] m68k: correct typos

On 20/02/2024 09.52, Manos Pitsidianakis wrote: Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- target/m68k/cpu.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target/m68k/cpu.h b/tar

Re: [PATCH v1 20/21] s390x: correct typos

On 20/02/2024 09.52, Manos Pitsidianakis wrote: Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- target/s390x/cpu_features_def.h.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x

  1   2   3   4   5   >