Re: [PATCH 3/5] hw/acpi/ich9: Include missing headers

2024-02-19 Thread Philippe Mathieu-Daudé
On 20/2/24 03:33, Zhao Liu wrote: Hi Philippe, On Mon, Feb 19, 2024 at 03:14:09PM +0100, Philippe Mathieu-Daudé wrote: Date: Mon, 19 Feb 2024 15:14:09 +0100 From: Philippe Mathieu-Daudé Subject: [PATCH 3/5] hw/acpi/ich9: Include missing headers X-Mailer: git-send-email 2.41.0 The ICH9LPCPMReg

[PATCH v2] virtio-pci: correctly set virtio pci queue mem multiplier

2024-02-19 Thread Srujana Challa
Currently, virtio_pci_queue_mem_mult function always returns 4K when VIRTIO_PCI_FLAG_PAGE_PER_VQ is set. But this won't work for vhost vdpa when host has page size other than 4K. This patch introduces a new property(page-per-vdpa-vq) for vdpa use case to fix the same. Signed-off-by: Srujana Challa

Re: [PATCH 5/5] hw/i386/q35: Include missing 'hw/acpi/acpi.h' header

2024-02-19 Thread Philippe Mathieu-Daudé
On 20/2/24 03:45, Zhao Liu wrote: Hi Philippe, On Mon, Feb 19, 2024 at 03:14:11PM +0100, Philippe Mathieu-Daudé wrote: Date: Mon, 19 Feb 2024 15:14:11 +0100 From: Philippe Mathieu-Daudé Subject: [PATCH 5/5] hw/i386/q35: Include missing 'hw/acpi/acpi.h' header X-Mailer: git-send-email 2.41.0 "

Re: [PATCH V3 09/13] migration: notifier error checking

2024-02-19 Thread Peter Xu
On Thu, Feb 08, 2024 at 10:54:02AM -0800, Steve Sistare wrote: > Check the status returned by migration notifiers and report errors. > If notifiers fail, call the notifiers again so they can clean up. > None of the notifiers return an error status at this time. > > Signed-off-by: Steve Sistare >

Re: [PATCH 3/7] hw/ide: Move IDE device related definitions to ide-dev.h

2024-02-19 Thread Philippe Mathieu-Daudé
On 19/2/24 20:17, Thomas Huth wrote: On 19/02/2024 12.32, Philippe Mathieu-Daudé wrote: On 19/2/24 11:49, Thomas Huth wrote: Let's start to unentangle internal.h by moving public IDE device related definitions to ide-dev.h. Signed-off-by: Thomas Huth ---   include/hw/ide/ide-dev.h  | 145

Re: [PATCH 1/5] hw/isa/meson.build: Sort alphabetically

2024-02-19 Thread Philippe Mathieu-Daudé
On 18/2/24 14:16, Bernhard Beschow wrote: Fixes: fbd758008f0f "hw/isa: extract FDC37M81X to a separate file" Signed-off-by: Bernhard Beschow --- hw/isa/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé $ git grep -i alphab docs/devel/bu

Re: [PATCH 4/5] hw/i386/pc: Inline i8042_setup_a20_line() and remove it

2024-02-19 Thread Philippe Mathieu-Daudé
On 18/2/24 14:17, Bernhard Beschow wrote: This function is used once in the pc machines. Remove it since it contains one line only. Signed-off-by: Bernhard Beschow --- include/hw/input/i8042.h | 1 - hw/i386/pc.c | 2 +- hw/input/pckbd.c | 5 - 3 files changed, 1 in

Re: [PATCH V3 10/13] migration: stop vm for cpr

2024-02-19 Thread Peter Xu
On Thu, Feb 08, 2024 at 10:54:03AM -0800, Steve Sistare wrote: > When migration for cpr is initiated, stop the vm and set state > RUN_STATE_FINISH_MIGRATE before ram is saved. This eliminates the > possibility of ram and device state being out of sync, and guarantees > that a guest in the suspende

Re: [PATCH v4 2/7] qapi: Make parameter 'file' optional for BlockdevCreateOptionsLUKS

2024-02-19 Thread Yong Huang
On Tue, Feb 20, 2024 at 2:31 PM Markus Armbruster wrote: > yong.hu...@smartx.com writes: > > > From: Hyman Huang > > > > To support detached LUKS header creation, make the existing 'file' > > field in BlockdevCreateOptionsLUKS optional. > > > > Signed-off-by: Hyman Huang > > Reviewed-by: Daniel

Re: [PATCH v2] virtio-pci: correctly set virtio pci queue mem multiplier

2024-02-19 Thread Michael S. Tsirkin
On Tue, Feb 20, 2024 at 12:39:35PM +0530, Srujana Challa wrote: > Currently, virtio_pci_queue_mem_mult function always returns 4K > when VIRTIO_PCI_FLAG_PAGE_PER_VQ is set. But this won't > work for vhost vdpa when host has page size other than 4K. > This patch introduces a new property(page-per-vd

Re: [PATCH V3 00/13] allow cpr-reboot for vfio

2024-02-19 Thread Peter Xu
On Thu, Feb 08, 2024 at 10:53:53AM -0800, Steve Sistare wrote: > Allow cpr-reboot for vfio if the guest is in the suspended runstate. The > guest drivers' suspend methods flush outstanding requests and re-initialize > the devices, and thus there is no device state to save and restore. The > user

Re: [PATCH v7 2/3] hw/isa/lpc_ich9: add broadcast SMI feature

2024-02-19 Thread Philippe Mathieu-Daudé
Hi Laszlo, Igor, Gerd, (old patch, now commit 5ce45c7a2b) On 26/1/17 02:44, Laszlo Ersek wrote: The generic edk2 SMM infrastructure prefers EFI_SMM_CONTROL2_PROTOCOL.Trigger() to inject an SMI on each processor. If Trigger() only brings the current processor into SMM, then edk2 handles it in th

<    1   2   3   4