[PATCH v9 3/6] ui/cocoa: Let the platform toggle fullscreen

It allows making the window full screen by clicking full screen button provided by the platform (the left-top green button) and save some code. Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 424 ++--- 1 file changed, 208 insertions(+), 216

[PATCH v9 4/6] ui/cocoa: Make window resizable

The window will be resizable when zoom-to-fit is on. Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/cocoa.m b/ui/cocoa.m index 5d21ce143671..754539937ffe 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -1379,8 +1379,10 @@ - (void)zoomToFit:(id)

[PATCH v9 6/6] ui/cocoa: Remove stretch_video flag

Evaluate [normalWindow styleMask] & NSWindowStyleMaskResizable instead. Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 93e761f09c6e..e68f418d9e42 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@

[PATCH v9 5/6] ui/cocoa: Call console_select() with the BQL

console_select() can be called anytime so explicitly take the BQL. Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 754539937ffe..93e761f09c6e 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -1391,7 +1391

[PATCH 0/7] hw/i386: Cleanups around 'hw/i386/pc.h'

Trivial patches removing uses of "hw/i386/pc.h". Philippe Mathieu-Daudé (7): target/i386/monitor: Remove unused 'hw/i386/pc.h' header hw/timer: Move HPET_INTCAP definition to "hpet.h" hw/isa/lpc_ich9: Remove unused 'hw/i386/pc.h' hw/i386/acpi: Declare pc_madt_cpu_entry() in 'acpi-common.h'

[PATCH 7/7] hw/acpi/cpu_hotplug: Include 'x86.h' instead of 'pc.h'

X86 CPU hotplug isn't specific to PC machines. Signed-off-by: Philippe Mathieu-Daudé --- hw/acpi/cpu_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/acpi/cpu_hotplug.c b/hw/acpi/cpu_hotplug.c index f7fe905e0a..83b8bc5deb 100644 --- a/hw/acpi/cpu_hotplug.c +++ b/h

[PATCH 1/7] target/i386/monitor: Remove unused 'hw/i386/pc.h' header

Signed-off-by: Philippe Mathieu-Daudé --- target/i386/monitor.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/i386/monitor.c b/target/i386/monitor.c index 950ff9ccbc..3a281dab02 100644 --- a/target/i386/monitor.c +++ b/target/i386/monitor.c @@ -33,7 +33,6 @@ #include "qapi/error.h"

Re: [PATCH RFCv2 2/8] vfio/iommufd: Introduce auto domain creation

On 12/02/2024 13:56, Joao Martins wrote: > diff --git a/backends/iommufd.c b/backends/iommufd.c > index 8486894f1b3f..2970135af4b9 100644 > --- a/backends/iommufd.c > +++ b/backends/iommufd.c > @@ -211,6 +211,35 @@ int iommufd_backend_unmap_dma(IOMMUFDBackend *be, > uint32_t ioas_id, > return

[PATCH 6/7] hw/acpi/cpu_hotplug: Include 'pci_device.h' instead of 'pci.h'

cpu_hotplug.c only needs the PCI *device* definitions. Signed-off-by: Philippe Mathieu-Daudé --- hw/acpi/cpu_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/acpi/cpu_hotplug.c b/hw/acpi/cpu_hotplug.c index 6f78db0ccb..f7fe905e0a 100644 --- a/hw/acpi/cpu_hotplug.c

[PATCH 5/7] hw/i386/port92: Add missing 'hw/isa/isa.h' header

TYPE_PORT92 inherits TYPE_ISA_DEVICE, so need to include "hw/isa/isa.h" to get its declarations (currently we indirectly include this header via "hw/i386/pc.h"). Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/port92.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/port92.c b/hw/i

[PATCH 4/7] hw/i386/acpi: Declare pc_madt_cpu_entry() in 'acpi-common.h'

Since pc_madt_cpu_entry() is only used by: - hw/i386/acpi-build.c // single call - hw/i386/acpi-common.c // definition there is no need to expose it outside of hw/i386/. Declare it in "acpi-common.h". acpi-build.c doesn't need "hw/i386/pc.h" anymore. Signed-off-by: Philippe Mathieu-Daudé ---

Re: [EXT] Re: [PATCH] virtio-pci: correctly set virtio pci queue mem multiplier

On Tue, Feb 13, 2024 at 11:50:34AM +, Srujana Challa wrote: > > Subject: [EXT] Re: [PATCH] virtio-pci: correctly set virtio pci queue mem > > multiplier > > > > External Email > > > > -- > > On Mon, Feb 12, 2024 at 01:22:33PM

[PATCH 3/7] hw/isa/lpc_ich9: Remove unused 'hw/i386/pc.h'

Commit c461f3e382 ("hw/acpi/acpi_dev_interface: Remove now unused madt_cpu virtual method") removed the need for "hw/i386/pc.h". Signed-off-by: Philippe Mathieu-Daudé --- hw/isa/lpc_ich9.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index 3924eec483..

[PATCH 2/7] hw/timer: Move HPET_INTCAP definition to "hpet.h"

HPET_INTCAP is specific to TYPE_HPET, so define it there. hpet.c doesn't need to include "hw/i386/pc.h" anymore. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h| 2 -- include/hw/timer/hpet.h | 2 ++ hw/timer/hpet.c | 1 - 3 files changed, 2 insertions(+), 3 deletions(

Re: [PATCH v3 2/7] hw/pci: Determine if rombar is explicitly enabled

On 2024/02/13 19:52, Michael S. Tsirkin wrote: On Mon, Feb 12, 2024 at 07:20:30PM +0900, Akihiko Odaki wrote: vfio determines if rombar is explicitly enabled by inspecting QDict. Inspecting QDict is not nice because QDict is untyped and depends on the details on the external interface. Add an in

Re: [PATCH v3 6/7] pcie_sriov: Reuse SR-IOV VF device instances

On 2024/02/13 20:01, Michael S. Tsirkin wrote: On Mon, Feb 12, 2024 at 07:20:34PM +0900, Akihiko Odaki wrote: Disable SR-IOV VF devices by reusing code to power down PCI devices instead of removing them when the guest requests to disable VFs. This allows to realize devices and report VF realizat

Re: [PATCH v3 6/7] pcie_sriov: Reuse SR-IOV VF device instances

On 2024/02/13 17:51, Minwoo Im wrote: -Original Message- From: qemu-block-bounces+minwoo.im.dev=gmail@nongnu.org On Behalf Of Akihiko Odaki Sent: Monday, February 12, 2024 7:21 PM To: Philippe Mathieu-Daudé ; Michael S. Tsirkin ; Marcel Apfelbaum ; Alex Williamson ; Cédric Le Goater

RE: [EXT] Re: [PATCH] virtio-pci: correctly set virtio pci queue mem multiplier

> Subject: Re: [EXT] Re: [PATCH] virtio-pci: correctly set virtio pci queue mem > multiplier > > On Tue, Feb 13, 2024 at 11:50:34AM +, Srujana Challa wrote: > > > Subject: [EXT] Re: [PATCH] virtio-pci: correctly set virtio pci > > > queue mem multiplier > > > > > > External Email > > > > > > -

Re: [PATCH v3 11/11] hw/sparc64/cpu: Initialize GPIO before realizing CPU devices

On 9/2/24 23:01, Mark Cave-Ayland wrote: On 09/02/2024 11:34, Peter Maydell wrote: On Thu, 8 Feb 2024 at 18:14, Philippe Mathieu-Daudé wrote: Inline cpu_create() in order to call qdev_init_gpio_in_named_with_opaque() before the CPU is realized. Signed-off-by: Philippe Mathieu-Daudé ---   h

[PATCH v4 02/12] hw/rx/rx62n: Reduce inclusion of 'qemu/units.h'

"qemu/units.h" is not used in the "hw/rx/rx62n.h" header, include it in the source where it is. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Yoshinori Sato --- include/hw/rx/rx62n.h | 1 - hw/rx/rx-gdbsim.c | 1 + hw/rx/rx62n.c | 1 + 3 files change

[PATCH v4 00/12] hw: Strengthen SysBus & QBus API

Missing review: 4, 12 Since v1: - Addressed Zoltan review comments - Addressed Mark suggestion - Added R-b tags Hi, This series ensure following is called *before* a device is realized: - qbus_new() - sysbus_init_mmio() - qdev_init_gpio_in_named_with_opaque() and these are called *after* it is:

[PATCH v4 01/12] hw/ide/ich9: Use AHCIPCIState typedef

QEMU coding style recommend using structure typedefs: https://www.qemu.org/docs/master/devel/style.html#typedefs Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell --- hw/ide/ich.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ide/ich.c b/hw/ide/ich.

[PATCH v4 04/12] hw/i386/q35: Realize LPC PCI function before accessing it

We should not wire IRQs on unrealized device. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc_q35.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 7ca3f465e0..b7c69d55d6 100644 --- a/hw/i386/pc_q35.c +++ b/hw/i386/pc_q35.c

[PATCH v4 10/12] hw/sparc/leon3: Pass DeviceState opaque argument to leon3_set_pil_in()

By passing a DeviceState context to a QDev IRQ handler, we can simplify and use qdev_init_gpio_in_named() instead of qdev_init_gpio_in_named_with_opaque(). Suggested-by: Mark Cave-Ayland Signed-off-by: Philippe Mathieu-Daudé --- hw/sparc/leon3.c | 10 -- 1 file changed, 4 insertions(+),

[PATCH v4 03/12] hw/rx/rx62n: Only call qdev_get_gpio_in() when necessary

Instead of filling an array of all the possible IRQs, only call qdev_get_gpio_in() when an IRQ is used. Remove the array from RX62NState. Doing so we avoid calling qdev_get_gpio_in() on an unrealized device. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Yoshinori

[PATCH v4 05/12] hw/ppc/prep: Realize ISA bridge before accessing it

We should not wire IRQs on unrealized device. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Mark Cave-Ayland --- hw/ppc/prep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c index 1a6cd05c61..4eb5477069 100644 -

[PATCH v4 06/12] hw/misc/macio: Realize IDE controller before accessing it

We should not wire IRQs on unrealized device. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland --- hw/misc/macio/macio.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/misc/macio/macio.c b/hw/misc/macio/macio.c index c9f22f8515..3f449f91c0 100

[PATCH v4 09/12] hw/sparc/leon3: Realize GRLIB IRQ controller before accessing it

We should not wire IRQs on unrealized device. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Mark Cave-Ayland --- hw/sparc/leon3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c index 2dfb742566..0df5fc

[PATCH v4 12/12] hw/sparc64/cpu: Initialize GPIO before realizing CPU devices

Inline cpu_create() in order to call qdev_init_gpio_in_named_with_opaque() before the CPU is realized. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Mark Cave-Ayland --- hw/sparc64/sparc64.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/

[PATCH v4 11/12] hw/sparc/leon3: Initialize GPIO before realizing CPU devices

Inline cpu_create() in order to call qdev_init_gpio_in_named_with_opaque() before the CPU is realized. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Mark Cave-Ayland --- hw/sparc/leon3.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw

[PATCH v4 07/12] hw/sh4/r2d: Realize IDE controller before accessing it

We should not wire IRQs on unrealized device. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Yoshinori Sato --- hw/sh4/r2d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sh4/r2d.c b/hw/sh4/r2d.c index e9f316a6ce..c73e8f49b8 100644 --- a/

[PATCH v4 08/12] hw/sparc/sun4m: Realize DMA controller before accessing it

We should not wire IRQs on unrealized device. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Mark Cave-Ayland --- hw/sparc/sun4m.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c index e782c8ec7a..d52

Re: [PATCH v4 04/12] hw/i386/q35: Realize LPC PCI function before accessing it

On 2/13/24 14:03, Philippe Mathieu-Daudé wrote: We should not wire IRQs on unrealized device. Signed-off-by: Philippe Mathieu-Daudé > --- hw/i386/pc_q35.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 7ca3f465e0..b7c69d

Re: [PATCH v4 12/12] hw/sparc64/cpu: Initialize GPIO before realizing CPU devices

On 2/13/24 14:03, Philippe Mathieu-Daudé wrote: Inline cpu_create() in order to call qdev_init_gpio_in_named_with_opaque() before the CPU is realized. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Mark Cave-Ayland --- hw/sparc64/sparc64.c | 4 +++- 1 file

Re: [PULL 0/4] Character device backend patches for 2024-02-12

Peter Maydell writes: > On Mon, 12 Feb 2024 at 08:51, Markus Armbruster wrote: >> >> I offered Marc-André to do this pull request, and he accepted. >> >> The following changes since commit 5d1fc614413b10dd94858b07a1b2e26b1aa0296c: >> >> Merge tag 'migration-staging-pull-request' of >> https:/

Re: [PATCH v3 0/3] Adjust the output of x-query-virtio-status

"Michael S. Tsirkin" writes: > On Fri, Feb 02, 2024 at 10:32:14PM +0800, Hyman Huang wrote: >> Sorry for the late post of version 3. The modifications are as follows: >> >> v3: >> - Rebase on master >> - Use the refined commit message furnished by Markus for [PATCH v2 1/2] >> - Drop the [PATCH

Re: possible deprecation and removal of some old QEMU Arm machine types (pxa2xx, omap, sa1110)

W dniu 12.02.2024 o 15:36, Guenter Roeck pisze: The machines I have in mind are: PXA2xx machines: akita    Sharp SL-C1000 (Akita) PDA (PXA270) borzoi   Sharp SL-C3100 (Borzoi) PDA (PXA270) connex   Gumstix Connex (PXA255) mainstone    Mainstone II (P

Re: [PATCH 87/88] esp.c: switch TypeInfo registration to use DEFINE_TYPES() macro

On 12/1/24 13:54, Mark Cave-Ayland wrote: The use of the DEFINE_TYPES() macro will soon be recommended over the use of calling type_init() directly. Signed-off-by: Mark Cave-Ayland --- hw/scsi/esp.c | 39 +-- 1 file changed, 17 insertions(+), 22 deletions(

Re: [PATCH v3 6/7] pcie_sriov: Reuse SR-IOV VF device instances

On 2024/02/13 17:51, Minwoo Im wrote: -Original Message- From: qemu-block-bounces+minwoo.im.dev=gmail@nongnu.org On Behalf Of Akihiko Odaki Sent: Monday, February 12, 2024 7:21 PM To: Philippe Mathieu-Daudé ; Michael S. Tsirkin ; Marcel Apfelbaum ; Alex Williamson ; Cédric Le Goater

Re: [PATCH 37/88] esp.c: introduce esp_get_phase() function

On 12/1/24 13:53, Mark Cave-Ayland wrote: Make use of this new function in all places where the SCSI phase bits are manually masked from the ESP_RSTAT register. Signed-off-by: Mark Cave-Ayland --- hw/scsi/esp.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-)

Re: [PATCH v7] ui/cocoa: Use NSWindow's ability to resize

://patchew.org/QEMU/20240213-cocoa-v9-0-d5a5e1bf0...@daynix.com/ Regards, Akihiko Odaki Wiadomość napisana przez Akihiko Odaki <mailto:akihiko.od...@daynix.com>> w dniu 19.12.2023, o godz. 13:12: On 2023/12/19 0:07, Rene Engel wrote: --- Ursprüngliche Nachricht --- Von: Akih

Re: [PULL 00/18] QAPI patches patches for 2024-02-12

On Mon, 12 Feb 2024 at 09:14, Markus Armbruster wrote: > > The following changes since commit 5d1fc614413b10dd94858b07a1b2e26b1aa0296c: > > Merge tag 'migration-staging-pull-request' of > https://gitlab.com/peterx/qemu into staging (2024-02-09 11:22:20 +) > > are available in the Git reposi

Re: [PATCH 1/4] chardev/parallel: Don't close stdin on inappropriate device

Markus Armbruster writes: > The __linux__ version of qemu_chr_open_pp_fd() tries to claim the > parport device with a PPCLAIM ioctl(). On success, it stores the file > descriptor in the chardev object, and returns success. On failure, it > closes the file descriptor, and returns failure. > > ch

Re: [PATCH 08/14] vfio: Use new Error** argument in vfio_save_setup()

On 12/02/2024 19:54, Cédric Le Goater wrote: External email: Use caution opening links or attachments On 2/12/24 10:17, Avihai Horon wrote: Hi Cedric, On 07/02/2024 15:33, Cédric Le Goater wrote: External email: Use caution opening links or attachments Add an Error** argument to vfio_mig

Re: [PATCH 0/7] hw/i386: Cleanups around 'hw/i386/pc.h'

On 13:01 Tue 13 Feb , Philippe Mathieu-Daudé wrote: > Trivial patches removing uses of "hw/i386/pc.h". > > Philippe Mathieu-Daudé (7): > target/i386/monitor: Remove unused 'hw/i386/pc.h' header > hw/timer: Move HPET_INTCAP definition to "hpet.h" > hw/isa/lpc_ich9: Remove unused 'hw/i386/

Re: [PATCH v3 5/7] pcie_sriov: Validate NumVFs

On 2024/02/13 19:59, Michael S. Tsirkin wrote: On Mon, Feb 12, 2024 at 07:20:33PM +0900, Akihiko Odaki wrote: The guest may write NumVFs greater than TotalVFs and that can lead to buffer overflow in VF implementations. Fixes: 7c0fa8dff811 ("pcie: Add support for Single Root I/O Virtualization

Re: [RFC PATCH] target/ppc: Move add and subf type fixed-point arithmetic instructions to decodetree

Hi Richard, On 2/13/24 03:51, Richard Henderson wrote: On 2/9/24 01:35, Chinmay Rath wrote: +&Z23_tab_cy rt ra rb cy +@Z23_tab_cy .. rt:5 ra:5 rb:5 cy:2 . &Z23_tab_cy ... +ADDEX   01 . . . .. 10101010 -  @Z23_tab_cy ... +static bool trans_ADDEX(D

RE: [PATCH v3 6/7] pcie_sriov: Reuse SR-IOV VF device instances

> -Original Message- > From: qemu-block-bounces+minwoo.im.dev=gmail@nongnu.org bounces+minwoo.im.dev=gmail@nongnu.org> On Behalf Of Akihiko Odaki > Sent: Monday, February 12, 2024 7:21 PM > To: Philippe Mathieu-Daudé ; Michael S. Tsirkin > ; Marcel Apfelbaum ; Alex > Williamson ; C

Re: possible deprecation and removal of some old QEMU Arm machine types (pxa2xx, omap, sa1110)

Hi, On Tue, Feb 13, 2024 at 02:42:29PM +0100, Marcin Juszkiewicz wrote: > > > > The one SA1110 machine: > > > > > > collie   Sharp SL-5500 (Collie) PDA (SA-1110) > > > > > I do test collie. > > Can you share kernel/initrd/config? I wanted to boot something at 20th > anniversary of

[PATCH RFC] target: riscv: Add Svvptc extension support

The Svvptc extension describes a uarch that does not cache invalid TLB entries: that's the case for qemu so there is nothing particular to implement other than the introduction of this extension, which is done here. Signed-off-by: Alexandre Ghiti --- That's an RFC since the extension has not bee

Re: possible deprecation and removal of some old QEMU Arm machine types (pxa2xx, omap, sa1110)

On Mon, 12 Feb 2024 at 14:36, Guenter Roeck wrote: > On 2/12/24 04:32, Peter Maydell wrote: > > The machines I have in mind are: > > > > PXA2xx machines: > > > > akitaSharp SL-C1000 (Akita) PDA (PXA270) > > borzoi Sharp SL-C3100 (Borzoi) PDA (PXA270) > > connex

QEMU Community Call 13th Feb [Minutes]

Attendees: - Philippe Mathieu-Daudé - Markus Armbruster - Anton Johansson - Manos Pitsidianakis - Paul Walmsley & SiFive QEMU team Notes: - Discussion on introducing a WIRING step in QDEV realization steps https://lore.kernel.org/all/20240209123226.32576-1-phi...@linaro.org/ Bus-based devices

Re: [PATCH RFC] target: riscv: Add Svvptc extension support

On Tue, Feb 13, 2024 at 03:53:08PM +0100, Alexandre Ghiti wrote: > The Svvptc extension describes a uarch that does not cache invalid TLB > entries: that's the case for qemu so there is nothing particular to > implement other than the introduction of this extension, which is done > here. > > Signe

Re: [PATCH 4/4] hw/arm/stellaris: Add missing QOM 'SoC' parent

On 1/2/24 17:46, Peter Maydell wrote: On Tue, 30 Jan 2024 at 19:03, Philippe Mathieu-Daudé wrote: QDev objects created with qdev_new() need to manually add their parent relationship with object_property_add_child(). Since we don't model the SoC, just use a QOM container. Signed-off-by: Phili

Re: possible deprecation and removal of some old QEMU Arm machine types (pxa2xx, omap, sa1110)

On Tue, Feb 13, 2024 at 03:14:21PM +, Peter Maydell wrote: > On Mon, 12 Feb 2024 at 14:36, Guenter Roeck wrote: > > On 2/12/24 04:32, Peter Maydell wrote: > > > The machines I have in mind are: > > > > > > PXA2xx machines: > > > > > > akitaSharp SL-C1000 (Akita) PDA (PXA270) >

Re: [PATCH 3/4] hw/arm/stellaris: Add missing QOM 'machine' parent

On 1/2/24 17:28, Peter Maydell wrote: On Tue, 30 Jan 2024 at 19:03, Philippe Mathieu-Daudé wrote: QDev objects created with qdev_new() need to manually add their parent relationship with object_property_add_child(). Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/stellaris.c | 4 1

Re: [PATCH v3 0/3] VIRTIO-IOMMU: Introduce an aw-bits option

On Tue, Feb 13, 2024 at 11:38:06AM +0100, Eric Auger wrote: > Hi Michael, > On 2/13/24 11:35, Michael S. Tsirkin wrote: > > On Thu, Feb 08, 2024 at 11:10:16AM +0100, Eric Auger wrote: > >> In [1] and [2] we attempted to fix a case where a VFIO-PCI device > >> protected with a virtio-iommu is assign

[PATCH] ci: Fix again build-previous-qemu

The build-previous-qemu job is now trying to fetch from the upstream repository, but the tag is only fetched into FETCH_HEAD: $ git remote add upstream https://gitlab.com/qemu-project/qemu 00:00 $ git fetch upstream $QEMU_PREV_VERSION 00:02 warning: redirecting to https://gitlab.com/qemu-project/q

[PATCH v3 0/9] mips: do not list individual devices from configs/

Back when Kconfig was introduced, the individual dependencies for MIPS boards were never added to hw/mips/Kconfig. Do it now. To simplify the task, include a couple cleanups to the SuperIO chip configuration symbols, as well as a change that makes USB device creation available even when building

[PATCH v3 1/9] usb: inline device creation functions

Allow boards to use the device creation functions even if USB itself is not available; of course the functions will fail inexorably, but this can be okay if the calls are conditional on the existence of some USB host controller device. This is for example the case for hw/mips/loongson3_virt.c. Ac

Re: [PULL 00/12] Hppa64 patches

On Mon, 12 Feb 2024 at 23:49, wrote: > > From: Helge Deller > > The following changes since commit 39a6e4f87e7b75a45b08d6dc8b8b7c2954c87440: > > Merge tag 'pull-qapi-2024-02-03' of https://repo.or.cz/qemu/armbru into > staging (2024-02-03 13:31:58 +) > > are available in the Git repository

[PATCH v3 5/9] isa: specify instance_size in isa_superio_type_info

Right now all subclasses of TYPE_ISA_SUPERIO have to specify an instance_size, because the ISASuperIODevice struct adds fields to ISADevice but the type does not include the increased instance size. Failure to do so results in an access past the bounds of struct ISADevice as soon as isa_superio_re

[PATCH v3 3/9] hw/mips/Kconfig: Remove ISA dependencies from MIPSsim board

From: Bernhard Beschow The board doesn't have a working ISA bus, only some I/O space. Selecting ISA_BUS and including hw/isa/isa.h is not necessary. Signed-off-by: Bernhard Beschow Message-ID: <20230109204124.102592-3-shen...@gmail.com> Signed-off-by: Paolo Bonzini --- hw/mips/mipssim.c | 7 +

[PATCH v3 6/9] isa: extract FDC37M81X to a separate file

isa-superio.c currently defines a SuperIO chip that is not used by any other user of the file. Extract the chip to a separate file. Reviewed-by: BALATON Zoltan Reviewed-by: Bernhard Beschow Signed-off-by: Paolo Bonzini --- hw/isa/fdc37m81x-superio.c | 32 hw/i

Re: [PATCH 2/4] hw/arm/stellaris: Convert I2C controller to Resettable interface

On 1/2/24 17:24, Peter Maydell wrote: On Tue, 30 Jan 2024 at 19:03, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/stellaris.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) @@ -658,8 +661,6 @@ static void stellaris_i2c_init(Object *obj)

[PATCH v3 4/9] isa: fix ISA_SUPERIO dependencies

ISA_SUPERIO does not provide an ISA bus, so it should not select the symbol: instead it requires one. Among its users, VT82C686 is the only one that is a PCI-ISA bridge and does not already select ISA_BUS. Reviewed-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Bernhard Bes

[PATCH v3 2/9] isa: clean up Kconfig selections for ISA_SUPERIO

All users of ISA_SUPERIO include a floppy disk controller, serial port and parallel port via the automatic creation mechanism of isa-superio.c. Select the symbol and remove it from the dependents. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- hw/isa/Kconfig | 13 -

[PATCH v3 7/9] mips: allow compiling out CONFIG_MIPS_ITU

itc_reconfigure() is referenced from TCG, compile out the helpers that reference env->itu if CONFIG_MIPS_ITU is not defined. This makes it possible to build a QEMU binary that only includes boards without a CPS device (only Malta and Boston create one). Signed-off-by: Paolo Bonzini --- target/mi

[PATCH v3 9/9] mips: do not list individual devices from configs/

Add new "select" and "imply" directives if needed. The resulting config-devices.mak files are the same as before. Note that builds without default devices will become much smaller than before; for this reason, it's necessary to use only the bare minimum of USB functions, in particular only those

[PATCH v2 0/4] hw/arm/stellaris: QOM/QDev cleanups

Since v1: - Rebased - Split I2C reset as enter/hold/exit (Peter) - Added R-b tags Gustavo wants to access the QOM path of an input IRQ line from the NVIC, but since the device is orphan he ends up with this nasty path [*]: -device ivshmem-flat,chardev=ivshmem_flat,x-irq-qompath='/machine/unatt

[PATCH v2 1/4] hw/arm/stellaris: Convert ADC controller to Resettable interface

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell --- hw/arm/stellaris.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c index 34c5a86ac2..4fa857970b 100644 --- a/hw/arm/stellaris.c +++ b/hw/arm/stellaris.c @@ -773,

[PATCH v2 2/4] hw/arm/stellaris: Convert I2C controller to Resettable interface

Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/stellaris.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c index 4fa857970b..d3a12fe51c 100644 --- a/hw/arm/stellaris.c +++ b/hw/a

[PATCH v2 4/4] hw/arm/stellaris: Add missing QOM 'SoC' parent

QDev objects created with qdev_new() need to manually add their parent relationship with object_property_add_child(). Since we don't model the SoC, just use a QOM container. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell --- hw/arm/stellaris.c | 11 ++- 1 file changed

[PATCH v2 3/4] hw/arm/stellaris: Add missing QOM 'machine' parent

QDev objects created with qdev_new() need to manually add their parent relationship with object_property_add_child(). This commit plug the devices which aren't part of the SoC; they will be plugged into a SoC container in the next one. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter May

Re: [EXT] Re: [PATCH] virtio-pci: correctly set virtio pci queue mem multiplier

On Tue, Feb 13, 2024 at 12:37:36PM +, Srujana Challa wrote: > > Subject: Re: [EXT] Re: [PATCH] virtio-pci: correctly set virtio pci queue > > mem > > multiplier > > > > On Tue, Feb 13, 2024 at 11:50:34AM +, Srujana Challa wrote: > > > > Subject: [EXT] Re: [PATCH] virtio-pci: correctly set

Re: [PATCH 0/7] hw/i386: Cleanups around 'hw/i386/pc.h'

On Tue, Feb 13, 2024 at 01:01:45PM +0100, Philippe Mathieu-Daudé wrote: > Trivial patches removing uses of "hw/i386/pc.h". How did you test that it's indeed unused? > Philippe Mathieu-Daudé (7): > target/i386/monitor: Remove unused 'hw/i386/pc.h' header > hw/timer: Move HPET_INTCAP definition

[PATCH v3 8/9] mips/loongson3_virt: do not require CONFIG_USB

Once the Kconfig for hw/mips is cleaned up, it will be possible to build a binary that does not include any USB host controller and therefore that does not include the code guarded by CONFIG_USB. While the simpler creation functions such as usb_create_simple can be inlined, this is not true of usb

Re: [PATCH 2/4] tests/qtest: Reorganize common code in ivshmem-test

On 27/11/23 06:20, Gustavo Romero wrote: This commit reorganizes the ivshmem-test qtest by moving common structs, functions, and code that can be utilized by other ivshmem qtests into two new files: ivshmem-utils.h and ivshmem-utils.c. Enum Reg, struct ServerThread, and mktempshm() have been rel

Re: [PATCH] hw/dma: Pass parent object to i8257_dma_init()

On 2/13/24 01:44, Philippe Mathieu-Daudé wrote: Set I8257 instances parent (migration isn't affected). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/dma/i8257.h | 2 +- hw/dma/i82374.c| 2 +- hw/dma/i8257.c | 4 +++- hw/i386/pc_piix.c | 2 +- hw/isa/lpc_ich9.c

Re: [PATCH 0/7] hw/i386: Cleanups around 'hw/i386/pc.h'

On 13/2/24 16:55, Michael S. Tsirkin wrote: On Tue, Feb 13, 2024 at 01:01:45PM +0100, Philippe Mathieu-Daudé wrote: Trivial patches removing uses of "hw/i386/pc.h". How did you test that it's indeed unused? I put and #error in hw/i386/pc.h and built :) (I'm trying to remove the PC dependency

Re: [PATCH v2 6/7] vdpa: move iova_tree allocation to net_vhost_vdpa_init

On Tue, Feb 13, 2024 at 11:22 AM Michael S. Tsirkin wrote: > > On Mon, Feb 05, 2024 at 05:10:36PM -0800, Si-Wei Liu wrote: > > Hi Eugenio, > > > > I thought this new code looks good to me and the original issue I saw with > > x-svq=on should be gone. However, after rebase my tree on top of this, >

Re: [RFC PATCH 1/2] hw/cxl/type3: add missing flag bit for GMER

On Fri, 9 Feb 2024 19:54:11 +0800 Shiyang Ruan wrote: > The "Volatile" should be set if current device is a volatile memory. > Per CXL Spec r3.0 8.2.9.2.1.1, Table 8-43. Whilst true, we haven't previously adjusted the injected record to conform to the device. I don't think there is anything pr

Re: [RFC PATCH 2/2] hw/cxl/type3: send a GMER while injecting poison

On Fri, 9 Feb 2024 19:54:12 +0800 Shiyang Ruan wrote: > Send a signal to OS to let it able to handle the poison range. > > TODO: This is an rough draft, will add more parameters for > qmp_cxl_inject_poison() to set to GMER. I wonder if that's the best plan or if we should think about providing

Re: [PATCH 1/9] hw/i386/q35: Use DEVICE() cast macro with PCIDevice object

On 2/12/24 22:11, Philippe Mathieu-Daudé wrote: QDev API provides the DEVICE() macro to access the 'qdev' parent field of the PCIDevice structure. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc_q35.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Hender

Re: [PATCH 2/9] hw/ide/ahci: Expose AHCIPCIState structure

On 2/12/24 22:11, Philippe Mathieu-Daudé wrote: In order to be able to QOM-embed a structure, we need its full definition. Move it from "ahci_internal.h" to the new "hw/ide/ahci-pci.h" header. Signed-off-by: Philippe Mathieu-Daudé --- hw/ide/ahci_internal.h| 8 include/hw/ide/ah

Re: [RFC PATCH 00/11] target/mips: Remove I6500 CPU definition

On 9/2/24 10:05, Philippe Mathieu-Daudé wrote: Alternative to: https://lore.kernel.org/qemu-devel/20240209085347.8446-1-phi...@linaro.org/ If the I6500 can not be tested or its support is incomplete, there is no point in wasting energy maintaining it. Philippe Mathieu-Daudé (11): target/mips:

Re: [PATCH 3/9] hw/ide/ahci: Rename AHCI PCI function as 'pdev'

On 2/12/24 22:11, Philippe Mathieu-Daudé wrote: We want to access AHCIPCIState::ahci field. In order to keep the code simple (avoiding &ahci->ahci), rename the current 'ahci' variable as 'pdev' Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc_q35.c | 15 --- hw/mips/boston.c |

Re: [PATCH 4/9] hw/ide/ahci: Inline ahci_get_num_ports()

On 2/12/24 22:11, Philippe Mathieu-Daudé wrote: Introduce the 'ich9' variable and inline ahci_get_num_ports(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/ide/ahci.h | 1 - hw/i386/pc_q35.c | 6 -- hw/ide/ahci.c | 8 hw/mips/boston.c | 6 -- 4 f

Re: [PATCH 5/9] hw/ide/ahci: Pass AHCI context to ahci_ide_create_devs()

On 2/12/24 22:11, Philippe Mathieu-Daudé wrote: Since ahci_ide_create_devs() is not PCI specific, pass it an AHCIState argument instead of PCIDevice. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/ide/ahci.h | 2 +- hw/i386/pc_q35.c | 2 +- hw/ide/ahci.c | 5 + hw/mip

Re: [PATCH 6/9] hw/ide/ahci: Convert AHCIState::ports to unsigned

On 2/12/24 22:11, Philippe Mathieu-Daudé wrote: AHCIState::ports should be unsigned. Besides, we never check it for negative value. It is unlikely it was ever used with more than INT32_MAX ports, so it is safe to convert it to unsigned. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/ide/

Re: [PATCH 7/9] hw/ide/ahci: Do not pass 'ports' argument to ahci_realize()

On 2/12/24 22:11, Philippe Mathieu-Daudé wrote: Explicitly set AHCIState::ports before calling ahci_realize(). Signed-off-by: Philippe Mathieu-Daudé --- hw/ide/ahci_internal.h | 2 +- hw/ide/ahci.c | 9 + hw/ide/ich.c | 3 ++- 3 files changed, 8 insertions(+), 6 d

Re: [PATCH 8/9] hw/ide/ahci: Remove SysbusAHCIState::num_ports field

On 2/12/24 22:11, Philippe Mathieu-Daudé wrote: No need to duplicate AHCIState::ports, directly access it. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/ide/ahci.h | 1 - hw/ide/ahci.c | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Richard Henderson

Re: [RFC PATCH 5/5] cxl/core: add poison injection event handler

> + > +void cxl_event_handle_record(struct cxl_memdev *cxlmd, > + enum cxl_event_log_type type, > + enum cxl_event_type event_type, > + const uuid_t *uuid, union cxl_event *evt) > +{ > + if (event_type == CXL_CPER_EVEN

Re: [PULL 00/15] Trivial patches for 2024-02-13

On Tue, 13 Feb 2024 at 08:03, Michael Tokarev wrote: > > The following changes since commit 5005aed8a7e728d028efb40e243ecfc2b4f3df3a: > > Merge tag 'pull-maintainer-updates-090224-1' of > https://gitlab.com/stsquad/qemu into staging (2024-02-12 14:14:10 +) > > are available in the Git repos

Re: [PATCH v4 00/12] hw: Strengthen SysBus & QBus API

On 2/13/24 03:03, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (12): hw/ide/ich9: Use AHCIPCIState typedef hw/rx/rx62n: Reduce inclusion of 'qemu/units.h' hw/rx/rx62n: Only call qdev_get_gpio_in() when necessary hw/i386/q35: Realize LPC PCI function before accessing it hw/p

Re: [PATCH v1 01/15] libvhost-user: Fix msg_region->userspace_addr computation

On Fri, Feb 02, 2024 at 10:53:18PM +0100, David Hildenbrand wrote: > We barely had mmap_offset set in the past. With virtio-mem and > dynamic-memslots that will change. > > In vu_add_mem_reg() and vu_set_mem_table_exec_postcopy(), we are > performing pointer arithmetics, which is wrong. Wrong how

Re: [PATCH v1 00/15] libvhost-user: support more memslots and cleanup memslot handling code

On Fri, Feb 02, 2024 at 10:53:17PM +0100, David Hildenbrand wrote: > This series adds support for more memslots (509) to libvhost-user, to > make it fully compatible with virtio-mem that uses up to 256 memslots > accross all memory devices in "dynamic-memslot" mode (more details > in patch #3). B

Re: [PATCH v4 04/12] hw/i386/q35: Realize LPC PCI function before accessing it

On Tue, 13 Feb 2024, Philippe Mathieu-Daudé wrote: We should not wire IRQs on unrealized device. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: BALATON Zoltan --- hw/i386/pc_q35.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35

Re: [PATCH v4 06/12] hw/misc/macio: Realize IDE controller before accessing it

On Tue, 13 Feb 2024, Philippe Mathieu-Daudé wrote: We should not wire IRQs on unrealized device. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland Reviewed-by: BALATON Zoltan --- hw/misc/macio/macio.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --

Re: [PATCH v3 8/9] hw/cxl/events: Add qmp interfaces to add/release dynamic capacity extents

> diff --git a/qapi/cxl.json b/qapi/cxl.json > index 8cc4c72fa9..6b631f64f1 100644 > --- a/qapi/cxl.json > +++ b/qapi/cxl.json > @@ -25,7 +25,8 @@ >'data': ['informational', > 'warning', > 'failure', > - 'fatal'] > + 'fatal', > + 'dyncap'] >

  1   2   3   4   >