Re: [PATCH v2 3/3] virtio-blk: Use ioeventfd_attach in start_ioeventfd

2024-02-10 Thread Michael Tokarev
09.02.2024 20:11, Hanna Czenczek : The mentioned comit is v8.2.0-812-gd3f6f294ae, - ie, past 8.2. Is this new change still relevant for stable? Sorry again. :/ There's nothing to be sorry about here - it's regular work, and is quite good at it, - I just asked to be sure, maybe I misundersto

Re: [PATCH 0/2] block: Allow concurrent BB context changes

2024-02-10 Thread Michael Tokarev
09.02.2024 19:51, Hanna Czenczek : On 09.02.24 15:08, Michael Tokarev wrote: 02.02.2024 17:47, Hanna Czenczek : Hi, Without the AioContext lock, a BB's context may kind of change at any time (unless it has a root node, and I/O requests are pending). That also means that its own context (BlockB

Re: [PATCH] hw/i386/kvm/ioapic: Replace magic '24' value by proper definition

2024-02-10 Thread Michael Tokarev
09.02.2024 22:01, Philippe Mathieu-Daudé: Replace '24' -> KVM_IOAPIC_NUM_PINS. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/kvm/ioapic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/kvm/ioapic.c b/hw/i386/kvm/ioapic.c index 409d0c8c76..b96fe84eed 100644 --

Re: [PULL 26/34] migration/multifd: Join the TLS thread

2024-02-10 Thread Michael Tokarev
08.02.2024 06:05, pet...@redhat.com : From: Fabiano Rosas We're currently leaking the resources of the TLS thread by not joining it and also overwriting the p->thread pointer altogether. Fixes: a1af605bd5 ("migration/multifd: fix hangup with TLS-Multifd due to blocking handshake") Cc: qemu-st

Re: [PULL 26/34] migration/multifd: Join the TLS thread

2024-02-10 Thread Michael Tokarev
10.02.2024 12:18, Michael Tokarev: 08.02.2024 06:05, pet...@redhat.com : From: Fabiano Rosas We're currently leaking the resources of the TLS thread by not joining it and also overwriting the p->thread pointer altogether. Fixes: a1af605bd5 ("migration/multifd: fix hangup with TLS-Multifd due

[PATCH v2 1/6] hw/pci: Determine if rombar is explicitly enabled

2024-02-10 Thread Akihiko Odaki
vfio determines if rombar is explicitly enabled by inspecting QDict. Inspecting QDict is not nice because QDict is untyped and depends on the details on the external interface. Add an infrastructure to determine if rombar is explicitly enabled to hw/pci. PCIDevice::rom_bar is changed to have -1 by

[PATCH v2 4/6] pcie_sriov: Validate NumVFs

2024-02-10 Thread Akihiko Odaki
The guest may write NumVFs greater than TotalVFs and that can lead to buffer overflow in VF implementations. Fixes: 7c0fa8dff811 ("pcie: Add support for Single Root I/O Virtualization (SR/IOV)") Signed-off-by: Akihiko Odaki --- hw/pci/pcie_sriov.c | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH v2 0/6] hw/pci: SR-IOV related fixes and improvements

2024-02-10 Thread Akihiko Odaki
I submitted a RFC series[1] to add support for SR-IOV emulation to virtio-net-pci. During the development of the series, I fixed some trivial bugs and made improvements that I think are independently useful. This series extracts those fixes and improvements from the RFC series. Below is an explanat

[PATCH v2 3/6] hw/qdev: Remove opts member

2024-02-10 Thread Akihiko Odaki
It is no longer used. Signed-off-by: Akihiko Odaki --- include/hw/qdev-core.h | 4 hw/core/qdev.c | 1 - system/qdev-monitor.c | 12 +++- 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index 151d9682380d..6b

[PATCH v2 2/6] vfio: Avoid inspecting option QDict for rombar

2024-02-10 Thread Akihiko Odaki
Use pci_rom_bar_explicitly_enabled() to determine if rombar is explicitly enabled. Signed-off-by: Akihiko Odaki --- hw/vfio/pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index d7fe06715c4b..44178ac9355f 100644 --- a/hw/vfio/pci.c +++ b/

[PATCH v2 5/6] pcie_sriov: Reuse SR-IOV VF device instances

2024-02-10 Thread Akihiko Odaki
Disable SR-IOV VF devices by reusing code to power down PCI devices instead of removing them when the guest requests to disable VFs. This allows to realize devices and report VF realization errors at PF realization time. Signed-off-by: Akihiko Odaki --- docs/pcie_sriov.txt | 8 ++-- in

[PATCH v2 6/6] pcie_sriov: Release VFs failed to realize

2024-02-10 Thread Akihiko Odaki
Release VFs failed to realize just as we do in unregister_vfs(). Fixes: 7c0fa8dff811 ("pcie: Add support for Single Root I/O Virtualization (SR/IOV)") Signed-off-by: Akihiko Odaki --- hw/pci/pcie_sriov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sri

Re: [PATCH] hw/hppa/Kconfig: Fix building with "configure --without-default-devices"

2024-02-10 Thread Thomas Huth
On 09/02/2024 21.42, Philippe Mathieu-Daudé wrote: On 9/2/24 20:46, BALATON Zoltan wrote: On Fri, 9 Feb 2024, Helge Deller wrote: On 2/9/24 19:55, Thomas Huth wrote: When running "configure" with "--without-default-devices", building of qemu-system-hppa currently fails with:   /usr/bin/ld: li

Re: [PATCH] target/arm: Don't get MDCR_EL2 in pmu_counter_enabled() before checking ARM_FEATURE_PMU

2024-02-10 Thread Richard Henderson
On 2/8/24 05:33, Peter Maydell wrote: It doesn't make sense to read the value of MDCR_EL2 on a non-A-profile CPU, and in fact if you try to do it we will assert: #6 0x74b95e96 in __GI___assert_fail (assertion=0x565a8c70 "!arm_feature(env, ARM_FEATURE_M)", file=0x565a6e5c ".

Re: [PATCH] system: Move memory_ldst.c.inc to system

2024-02-10 Thread Richard Henderson
On 2/8/24 14:05, BALATON Zoltan wrote: This file is only used by system/physmem.c so move them together. Signed-off-by: BALATON Zoltan --- memory_ldst.c.inc => system/memory_ldst.c.inc | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename memory_ldst.c.inc => system/memory_ldst.c.inc

Re: [RFC PATCH 00/11] target/mips: Remove I6500 CPU definition

2024-02-10 Thread Richard Henderson
On 2/8/24 23:05, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (11): target/mips: Remove helpers accessing SAAR registers hw/misc/mips: Reduce itc_reconfigure() scope target/mips: Remove MIPSITUState::itu field target/mips: Remove CPUMIPSState::saarp field hw/misc/mips_itu:

Re: [PATCH v2 02/12] target/hppa: Add "diag 0x101" for console output support

2024-02-10 Thread Richard Henderson
On 2/9/24 01:56, del...@kernel.org wrote: From: Helge Deller For debugging purposes at the early stage of the bootup process, the SeaBIOS-hppa firmware sometimes needs to output characters to the serial console. Note that the serial console is the default output method for parisc machines. At t

Re: [PATCH v2 03/12] hw/pci-host/astro: Avoid aborting on access failure

2024-02-10 Thread Richard Henderson
On 2/9/24 01:56, del...@kernel.org wrote: From: Helge Deller Instead of stopping the emulation, report a MEMTX_DECODE_ERROR if the OS tries to access non-existent registers. Signed-off-by: Helge Deller --- hw/pci-host/astro.c | 27 +++ 1 file changed, 11 insertions(+)

Re: [PATCH v3 05/17] plugins: scoreboard API

2024-02-10 Thread Richard Henderson
On 2/6/24 19:59, Pierrick Bouvier wrote: Why a hash table?  All you want is to be able to iterate through all, and add/remove easily.  Seems like QLIST from would be better, and the QLIST_ENTRY member would make struct qemu_plugin_scoreboard useful. Thought that having O(1) removal was a ni