Jason Wang 于2024年2月7日周三 11:17写道：
>
> On Tue, Feb 6, 2024 at 4:31 PM Stefano Garzarella wrote:
> >
> > On Tue, Feb 06, 2024 at 10:47:40AM +0800, Jason Wang wrote:
> > >On Mon, Feb 5, 2024 at 6:51 PM Stefano Garzarella
> > >wrote:
> > >>
> > >> On Fri, Feb 02, 2024 at 02:25:21PM +0100, Kevin Wolf
On Wed, Feb 07, 2024 at 10:32:31AM +0300, Michael Tokarev wrote:
> This option was not documented.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1240
> Signed-off-by: Michael Tokarev
> ---
> qemu-nbd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qemu-nbd.c b/qemu-nbd.
Copy qemu-devel.
On Wed, Feb 07, 2024 at 04:07:40PM +0800, Peter Xu wrote:
> Hi,
>
> I'm sending this email just to leave a generic comment to the recent
> migration efforts to enable these new Intel technologies.
>
> The relevant patchsets (latest version so far) we're discussing are:
>
> [P
On Mon, Feb 05, 2024 at 08:46:55AM +0100, Markus Armbruster wrote:
> Missed in commit 9bc6e893b72 (qapi: Normalize version references x.y.0
> to just x.y).
>
> Signed-off-by: Markus Armbruster
> ---
> docs/devel/qapi-code-gen.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Revie
The original implementation sets $pc to the address read from the jump
vector table first and links $ra with the address of the next instruction
after the updated $pc. After jumping to the updated $pc and executing the
next ret instruction, the program jumps to $ra, which is in the same
function cu
On Mon, Feb 05, 2024 at 08:46:56AM +0100, Markus Armbruster wrote:
> Missed in commit a937b6aa739 (qapi: Reformat doc comments to conform
> to current conventions).
>
> Signed-off-by: Markus Armbruster
> ---
> docs/devel/qapi-code-gen.rst | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions
On Mon, Feb 05, 2024 at 08:46:57AM +0100, Markus Armbruster wrote:
> The description of @bins ends with a literal block:
>
> # @bins: list of io request counts corresponding to histogram
> # intervals, one more element than @boundaries has. For the
> # example above, @bins may
On Mon, Feb 05, 2024 at 08:46:58AM +0100, Markus Armbruster wrote:
> docs/devel/qapi-code-gen demands that the "second and subsequent lines
> of sections other than "Example"/"Examples" should be indented".
> Commit a937b6aa739q (qapi: Reformat doc comments to conform to current
> conventions) miss
On Mon, Feb 05, 2024 at 08:46:59AM +0100, Markus Armbruster wrote:
> QAPISchemaGenRSTVisitor._nodes_for_members() has a special case to
> auto-generate documentation for a union tag member of implicit (enum)
> type that lacks documentation.
>
> This was useful for simple unions, where the tag memb
On Mon, Feb 05, 2024 at 08:47:00AM +0100, Markus Armbruster wrote:
> The QAPI generator forces you to document your stuff. Except for
> command arguments, event data, and members of enum and object types:
> these the generator silently "documents" as "Not documented".
>
> We can't require proper
On Mon, Feb 05, 2024 at 08:47:01AM +0100, Markus Armbruster wrote:
> The command's doc comment describes the argument, but it's not marked
> up as such. Easy enough to fix.
>
> Signed-off-by: Markus Armbruster
> ---
> qga/qapi-schema.json | 19 ++-
> 1 file changed, 10 insertion
On Mon, Feb 05, 2024 at 08:47:02AM +0100, Markus Armbruster wrote:
> The command's doc comment describes the argument, but it's not marked
> up as such. Easy enough to fix.
>
> Signed-off-by: Markus Armbruster
> ---
> qga/qapi-schema.json | 20 ++--
> 1 file changed, 10 insertio
On Mon, Feb 05, 2024 at 08:47:03AM +0100, Markus Armbruster wrote:
> Add missing return member documentation of guest-get-disks,
> guest-get-devices, guest-get-diskstats, and guest-get-cpustats.
>
> The NVMe SMART information returned by guest-getdisks remains
> undocumented. Add a TODO there.
>
On Mon, Feb 05, 2024 at 08:47:04AM +0100, Markus Armbruster wrote:
> The command's doc comment describes the argument, but it's not marked
> up as such. Easy enough to fix.
>
> Signed-off-by: Markus Armbruster
> ---
> qapi/pragma.json | 3 +--
> qapi/yank.json | 2 +-
> 2 files changed, 2 ins
On Mon, Feb 05, 2024 at 08:47:05AM +0100, Markus Armbruster wrote:
> The type's doc comment describes its member, but it's not marked up as
> such. Easy enough to fix.
>
> Signed-off-by: Markus Armbruster
> ---
> qapi/dump.json | 2 +-
> qapi/pragma.json | 1 -
> 2 files changed, 1 insertion(
On Mon, Feb 05, 2024 at 08:47:06AM +0100, Markus Armbruster wrote:
> The conversion of simple to flat unions left the @data members
> undocumented. Add documentation where it's trivial. Copy verbatim
> from the wrapped type's description where possible.
>
> Leftovers: String (to be taken care of
Thank you very much for your reminder and the rapid updates to the
multifd function. I will incorporate your suggestions into the next
version (IAA Accelerated Live Migration solution).
Regarding the QAT and DSA optimization, my colleagues and I have
already started reviewing and testing them, a
On Mon, Feb 05, 2024 at 08:47:07AM +0100, Markus Armbruster wrote:
> SocketAddress branch @fd is documented in enum SocketAddressType,
> unlike the other branches. That's because the branch's type is String
> from common.json.
>
> Use a local copy of String, so we can put the documentation in the
On Mon, Feb 05, 2024 at 08:47:08AM +0100, Markus Armbruster wrote:
> Use of String is problematic, because it results in awkward interface
> documentation. The previous commit cleaned up one instance.
>
> Move String out of common.json next to its remaining users in net.json
> to discourage reuse
On Mon, Feb 05, 2024 at 08:47:09AM +0100, Markus Armbruster wrote:
> Low-hanging fruit, and except for StatsFilter, the only members of
> these unions lacking documentation.
>
> Signed-off-by: Markus Armbruster
> ---
> qapi/block-core.json | 12
> qapi/block-export.json | 2 ++
>
On Wed, Feb 07, 2024 at 12:37:15 +0800, Peter Xu wrote:
> On Wed, Feb 07, 2024 at 12:13:10PM +0800, Peter Xu wrote:
> > On Tue, Feb 06, 2024 at 11:19:04PM +, Hao Xiang wrote:
> > > This change extends the MigrationStatus interface to track zero pages
> > > and zero bytes counter.
> > >
> > > S
On Wed, Feb 07, 2024 at 11:17:34AM +0800, Jason Wang wrote:
On Tue, Feb 6, 2024 at 4:31 PM Stefano Garzarella wrote:
On Tue, Feb 06, 2024 at 10:47:40AM +0800, Jason Wang wrote:
>On Mon, Feb 5, 2024 at 6:51 PM Stefano Garzarella wrote:
>>
>> On Fri, Feb 02, 2024 at 02:25:21PM +0100, Kevin Wolf
On 6/2/24 14:29, Peter Maydell wrote:
The MPS SCC device has a lot of different flavours for the various
different MPS FPGA images, which look mostly similar but have
differences in how particular registers are handled. Currently we
deal with this with a lot of open-coded checks on scc_partno(),
On Wed, Feb 07, 2024 at 04:05:29PM +0800, Cindy Lu wrote:
Jason Wang 于2024年2月7日周三 11:17写道：
On Tue, Feb 6, 2024 at 4:31 PM Stefano Garzarella wrote:
>
> On Tue, Feb 06, 2024 at 10:47:40AM +0800, Jason Wang wrote:
> >On Mon, Feb 5, 2024 at 6:51 PM Stefano Garzarella
wrote:
> >>
> >> On Fri, F
On 6/2/24 14:29, Peter Maydell wrote:
The MPS2 SCC device is broadly the same for all FPGA images, but has
minor differences in the behaviour of the CFG registers depending on
the image. In many cases we don't really care about the functionality
controlled by these registers and a reads-as-writte
On 6/2/24 14:29, Peter Maydell wrote:
The AN536 is another FPGA image for the MPS3 development board. Unlike
the existing FPGA images we already model, this board uses a Cortex-R
family CPU, and it does not use any equivalent to the M-profile
"Subsystem for Embedded" SoC-equivalent that we model
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: BALATON Zoltan
Message-Id: <20231011132427.65001-2-phi...@linaro.org>
---
hw/ppc/ppc440_pcix.c | 1 -
hw/ppc/ppc4xx_pci.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/hw/ppc/ppc440_pcix.c b/hw/ppc/ppc440_pcix.c
index df4ee374d0..d84418c
v2:
- Squashed 2 patches (Zoltan)
v1:
- Move ppc4xx_pci.c/ppc440_pcix.c from hw/ppc/ to hw/pci-host/
- Build them once for all targets
If it is convenient for PPC maintainers I can queue
this via my misc-hw tree.
Thanks,
Phil.
Philippe Mathieu-Daudé (4):
hw/ppc/ppc4xx_pci: Remove unused "hw/
ppc440_pcix.c is moved from the target specific ppc_ss[] meson
source set to pci_ss[] which is common to all targets: the
object is built once.
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS| 2 +-
hw/{ppc => pci-host}/ppc440_pcix.c | 0
hw/pci-host/Kconfig
ppc4xx_pci.c is moved from the target specific ppc_ss[] meson
source set to pci_ss[] which is common to all targets: the
object is built once.
Declare PPC4XX_PCI selector in pci-host/Kconfig.
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 1 +
hw/{ppc => pci-host}
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: BALATON Zoltan
Message-Id: <20231011132427.65001-3-phi...@linaro.org>
---
MAINTAINERS | 1 +
include/hw/pci-host/ppc4xx.h | 17 +
include/hw/ppc/ppc4xx.h | 5 -
hw/ppc/ppc440_bamboo.c | 1 +
hw/
On 07/02/2024 10.12, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: BALATON Zoltan
Message-Id: <20231011132427.65001-2-phi...@linaro.org>
---
hw/ppc/ppc440_pcix.c | 1 -
hw/ppc/ppc4xx_pci.c | 1 -
2 files changed, 2 deletions(-)
Reviewed-by: Thomas Huth
On 07/02/2024 10.12, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: BALATON Zoltan
Message-Id: <20231011132427.65001-3-phi...@linaro.org>
---
MAINTAINERS | 1 +
include/hw/pci-host/ppc4xx.h | 17 +
include/hw/ppc/ppc4xx.h
On 07/02/2024 10.12, Philippe Mathieu-Daudé wrote:
ppc4xx_pci.c is moved from the target specific ppc_ss[] meson
source set to pci_ss[] which is common to all targets: the
object is built once.
Declare PPC4XX_PCI selector in pci-host/Kconfig.
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAI
vhost_vdpa_set_vring_ready() could already fail, but if Linux's
patch [1] will be merged, it may fail with more chance if
userspace does not activate virtqueues before DRIVER_OK when
VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK is not negotiated.
So better check its return value anyway.
[1]
https://lo
Support specification Version 1.0.0-draft4 rapid-k model.
The specification url:
https://github.com/riscv-non-isa/iopmp-spec/blob/main/riscv_iopmp_specification.pdf
The memory transaction from source devices connected to IOPMP will be
checked by IOPMP rule. The method of connecting the source devi
On 06.02.24 17:53, Stefan Hajnoczi wrote:
On Fri, Feb 02, 2024 at 03:47:53PM +0100, Hanna Czenczek wrote:
Hi,
Without the AioContext lock, a BB's context may kind of change at any
time (unless it has a root node, and I/O requests are pending). That
also means that its own context (BlockBackend
This series implements IOPMP specification v1.0.0-draft4 rapid-k model and add
IOPMP device to RISC-V virt machine.
Patch 1 add config STREAM make other device can reuse /hw/core/stream.c, IOPMP
implementation will use it. Patch 2 implement IOPMP deivce. Patch 3 add IOPMP
device to RISC-V virt mac
Make other device can use /hw/core/stream.c by select this config.
Reviewed-by: Alistair Francis
Signed-off-by: Ethan Chen
---
hw/Kconfig | 1 +
hw/core/Kconfig | 3 +++
hw/core/meson.build | 2 +-
3 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/Kconfig b/hw/Kconfi
If a source device is connected to the IOPMP device, its memory
transaction will be checked by the IOPMP rule.
When using RISC-V virt machine option "iopmp=on", the generic PCIe host
bridge connects to IOPMP. The PCI devices on the bridge will connect to
IOPMP with default source id(SID) from PCI
On 07/02/2024 10.12, Philippe Mathieu-Daudé wrote:
ppc440_pcix.c is moved from the target specific ppc_ss[] meson
source set to pci_ss[] which is common to all targets: the
object is built once.
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS| 2 +-
hw/{ppc => p
Am 06.02.2024 um 17:44 hat Eugenio Perez Martin geschrieben:
> On Mon, Feb 5, 2024 at 2:49 PM Kevin Wolf wrote:
> >
> > Am 05.02.2024 um 13:22 hat Eugenio Perez Martin geschrieben:
> > > On Fri, Feb 2, 2024 at 2:25 PM Kevin Wolf wrote:
> > > >
> > > > VDUSE requires that virtqueues are first enab
On 07/02/2024 06:29, Alexander Monakov wrote:
> On Tue, 6 Feb 2024, Elena Ufimtseva wrote:
>> Hello Alexander
>>
>> On Tue, Feb 6, 2024 at 12:50 PM Alexander Monakov
>> wrote:
>>
>>> Thanks to early checks in the inline buffer_is_zero wrapper, the SIMD
>>> routines are invoked much more rarely in
On Wed, Feb 07, 2024 at 11:18:54AM +0100, Kevin Wolf wrote:
Am 06.02.2024 um 17:44 hat Eugenio Perez Martin geschrieben:
On Mon, Feb 5, 2024 at 2:49 PM Kevin Wolf wrote:
>
> Am 05.02.2024 um 13:22 hat Eugenio Perez Martin geschrieben:
> > On Fri, Feb 2, 2024 at 2:25 PM Kevin Wolf wrote:
> > >
Right now all subclasses of TYPE_ISA_SUPERIO have to specify an instance_size,
because the ISASuperIODevice struct adds fields to ISADevice but the type does
not include the increased instance size. Failure to do so results in an access
past the bounds of struct ISADevice as soon as isa_superio_re
Allow boards to use the device creation functions even if USB itself
is not available; of course the functions will fail inexorably, but
this can be okay if the calls are conditional on the existence of
some USB host controller device. This is for example the case for
hw/mips/loongson3_virt.c.
Ac
Add new "select" and "imply" directives if needed. The resulting
config-devices.mak files are the same as before.
Signed-off-by: Paolo Bonzini
---
configs/devices/mips-softmmu/common.mak | 28 +++-
configs/devices/mips64el-softmmu/default.mak | 3 ---
hw/mips/loongson3_vir
itc_reconfigure() is referenced from TCG, provide a stub if needed.
This makes it possible to build a QEMU binary that only includes
boards without a CPS device (only Malta and Boston create one).
Signed-off-by: Paolo Bonzini
---
hw/mips/mips_itu-stub.c | 26 ++
hw/mips/m
Back when Kconfig was introduced, the individual dependencies for MIPS
boards were never added to hw/mips/Kconfig. Do it now.
To simplify the task, include a couple cleanups to the SuperIO chip
configuration symbols, as well as a change that makes USB device
creation available even when building
All users of ISA_SUPERIO include a floppy disk controller, serial port
and parallel port via the automatic creation mechanism of isa-superio.c.
Select the symbol and remove it from the dependents.
Reviewed-by: Richard Henderson
Signed-off-by: Paolo Bonzini
---
hw/isa/Kconfig | 13 -
ISA_SUPERIO does not provide an ISA bus, so it should not select the symbol:
instead it requires one. Among its users, VT82C686 is the only one that
is a PCI-ISA bridge and does not already select ISA_BUS.
Signed-off-by: Paolo Bonzini
---
hw/isa/Kconfig | 3 ++-
1 file changed, 2 insertions(+),
From: Bernhard Beschow
The board doesn't seem to have an ISA bus at all.
Signed-off-by: Bernhard Beschow
Message-ID: <20230109204124.102592-3-shen...@gmail.com>
Signed-off-by: Paolo Bonzini
---
hw/mips/mipssim.c | 1 -
hw/mips/Kconfig | 3 +--
2 files changed, 1 insertion(+), 3 deletions(-)
isa-superio.c currently defines a SuperIO chip that is not used
by any other user of the faile. Extract the chip to a separate file.
Signed-off-by: Paolo Bonzini
---
hw/isa/fdc37m81x-superio.c | 32
hw/isa/isa-superio.c | 18 --
hw/isa/Kcon
On 12/09/2023 22:18, John Allen wrote:
> In the event that a guest process attempts to access memory that has
> been poisoned in response to a deferred uncorrected MCE, an AMD system
> will currently generate a SIGBUS error which will result in the entire
> guest being shutdown. Ideally, we only wa
On Fri, Feb 02, 2024 at 10:53:17PM +0100, David Hildenbrand wrote:
This series adds support for more memslots (509) to libvhost-user, to
make it fully compatible with virtio-mem that uses up to 256 memslots
accross all memory devices in "dynamic-memslot" mode (more details
in patch #3).
One simp
On Wed, Dec 6, 2023 at 1:57 AM Alistair Francis wrote:
>
> On Mon, Nov 27, 2023 at 12:37 AM Christoph Muellner
> wrote:
> >
> > From: Christoph Müllner
> >
> > Upstream Linux recently added RISC-V Zicboz support to the hwprobe API.
> > This patch introduces this for QEMU's user space emulator.
>
This series syncs the hwprobe keys with those available in the upstream
kernel repository with the exception of Ztso, which is not supported in
QEMU as of now.
The first patch is a resend (sent on Nov 27), as it should have been
picked up on Dec 6, but seems to got lost.
Christoph Müllner (2):
Upstream Linux recently added many additional keys to the hwprobe API.
This patch adds support for all of them with the exception of Ztso,
which is currently not supported in QEMU.
Signed-off-by: Christoph Müllner
---
linux-user/syscall.c | 98
1 file
Upstream Linux recently added RISC-V Zicboz support to the hwprobe API.
This patch introduces this for QEMU's user space emulator.
Signed-off-by: Christoph Müllner
---
linux-user/syscall.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index e3
From: Palmer Dabbelt
The Ztso extension is already ratified, this adds it as a CPU property
and adds various fences throughout the port in order to allow TSO
targets to function on weaker hosts. We need no fences for AMOs as
they're already SC, the places we need barriers are described.
These fe
The first patch of this series picks up an earlier v2 Ztso patch from Palmer,
which can be found here:
https://patchwork.kernel.org/project/qemu-devel/patch/20220917072635.11616-1-pal...@rivosinc.com/
This patch did not apply cleanly but the necessary changes were trivial.
There was a request to
This patch exposes Ztso via hwprobe in QEMU's user space emulator.
Signed-off-by: Christoph Müllner
---
linux-user/syscall.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 3ba20f99ad..24fa11d946 100644
--- a/linux-user/syscall.c
+++ b/lin
On Wed, 7 Feb 2024, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: BALATON Zoltan
Message-Id: <20231011132427.65001-3-phi...@linaro.org>
---
MAINTAINERS | 1 +
include/hw/pci-host/ppc4xx.h | 17 +
include/hw/ppc/ppc4xx.h |
On Wed, 7 Feb 2024, Philippe Mathieu-Daudé wrote:
ppc440_pcix.c is moved from the target specific ppc_ss[] meson
source set to pci_ss[] which is common to all targets: the
object is built once.
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS| 2 +-
hw/{ppc => pci-ho
On 1/18/24 14:27, Denis V. Lunev wrote:
On 12/28/23 11:12, Alexander Ivanov wrote:
Now dirty bitmaps can be loaded but there is no their saving. Add
code for
dirty bitmap storage.
Signed-off-by: Alexander Ivanov
---
block/parallels-ext.c | 168 ++
On Wed, 7 Feb 2024, Paolo Bonzini wrote:
ISA_SUPERIO does not provide an ISA bus, so it should not select the symbol:
instead it requires one. Among its users, VT82C686 is the only one that
is a PCI-ISA bridge and does not already select ISA_BUS.
Signed-off-by: Paolo Bonzini
Reviewed-by: BAL
On Wed, 7 Feb 2024, Paolo Bonzini wrote:
isa-superio.c currently defines a SuperIO chip that is not used
by any other user of the faile. Extract the chip to a separate file.
Typo: faile -> file?
Regards,
BALATON Zoltan
Signed-off-by: Paolo Bonzini
---
hw/isa/fdc37m81x-superio.c | 32 ++
On Wed, 7 Feb 2024, Paolo Bonzini wrote:
itc_reconfigure() is referenced from TCG, provide a stub if needed.
This makes it possible to build a QEMU binary that only includes
boards without a CPS device (only Malta and Boston create one).
Signed-off-by: Paolo Bonzini
---
hw/mips/mips_itu-stub.c
On Wed, 7 Feb 2024, Paolo Bonzini wrote:
Add new "select" and "imply" directives if needed. The resulting
config-devices.mak files are the same as before.
Signed-off-by: Paolo Bonzini
---
configs/devices/mips-softmmu/common.mak | 28 +++-
configs/devices/mips64el-softmmu/de
The testcase contains :
- `test_idr_reset_value()` :
Checks the reset values of MODER, OTYPER, PUPDR, ODR and IDR.
- `test_gpio_output_mode()` :
Checks that writing a bit in register ODR results in the corresponding
pin rising or lowering, if this pin is configured in output mode.
- `test_gpio_inpu
This patch adds a new device STM32L4x5 GPIO device and is part
of a series implementing the STM32L4x5 with a few peripherals.
Changes from v3 :
- replacing occurences of '16' with the correct macro `GPIO_NUM_PINS`
- updating copyright year
- rebasing on latest version of STM32L4x5 RCC
Changes fro
Features supported :
- the 8 STM32L4x5 GPIOs are initialized with their reset values
(except IDR, see below)
- input mode : setting a pin in input mode "externally" (using input
irqs) results in an out irq (transmitted to SYSCFG)
- output mode : setting a bit in ODR sets the corresponding o
Signed-off-by: Arnaud Minier
Signed-off-by: Inès Varhol
---
include/hw/arm/stm32l4x5_soc.h | 2 +
hw/arm/stm32l4x5_soc.c | 78 --
hw/arm/Kconfig | 3 +-
3 files changed, 68 insertions(+), 15 deletions(-)
diff --git a/include/hw/arm/stm32
Peter Xu writes:
> On Tue, Feb 06, 2024 at 06:51:12PM -0300, Fabiano Rosas wrote:
>> Based-on: 20240202102857.110210-1-pet...@redhat.com
>> [PATCH v2 00/23] migration/multifd: Refactor ->send_prepare() and cleanups
>> https://lore.kernel.org/r/20240202102857.110210-1-pet...@redhat.com
>>
>> Hi,
This will be useful to report errors at a higher level, mostly in VFIO
today.
Signed-off-by: Cédric Le Goater
---
include/migration/register.h | 2 +-
hw/vfio/migration.c | 2 +-
migration/ram.c | 2 +-
migration/savevm.c | 10 ++
4 files changed, 9 ins
Modify memory_global_dirty_log_start() and memory_global_dirty_log_stop()
to also take an Error** parameter and report the error in the callers.
Aside from error reporting, there should be no functional changes.
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Paul Durrant
Cc: Michael S. Tsirkin
Hello,
The motivation behind these changes is to improve error reporting to
the upper management layer (libvirt) with a more detailed error, this
to let it decide, depending on the reported error, whether to try
migration again later. It would be useful in cases where migration
fails due to lack o
In case of error, close_return_path_on_source() can perform a shutdown
to exit the return-path thread. However, in migrate_fd_cleanup(),
'to_dst_file' is closed before calling close_return_path_on_source()
and the shutdown fails, leaving the source and destination waiting for
an event to occur.
C
Use vmstate_save_state_with_err() to improve error reporting in the
callers.
Signed-off-by: Cédric Le Goater
---
include/hw/vfio/vfio-common.h | 2 +-
hw/vfio/migration.c | 18 --
hw/vfio/pci.c | 5 +++--
3 files changed, 16 insertions(+), 9 deletions(
vfio_save_complete_precopy() currently returns before doing the trace
event. Change that.
Signed-off-by: Cédric Le Goater
---
hw/vfio/migration.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
index
fb264c1ef57bbbde4306901e5449e0dfbd0ce3b7..cc5b7
This allows to update the Error argument of the VFIO log_global_start()
handler. Errors detected when device level logging is started will be
propagated up to qemu_savevm_state_setup() when the ram save_setup()
handler is executed.
The vfio_set_migration_error() call becomes redudant. Remove it.
close_return_path_on_source() retrieves the migration error from the
the QEMUFile '->to_dst_file' to know if a shutdown is required. This
shutdown is required to exit the return-path thread. However, in
migrate_fd_cleanup(), '->to_dst_file' is cleaned up before calling
close_return_path_on_source()
The purpose is to record a potential error in the migration stream if
qemu_savevm_state_setup() fails. Most of the current .save_setup()
handlers can be modified to use the Error argument instead of managing
their own and calling locally error_report(). The following patches
will introduce such cha
vfio_set_migration_error() sets the 'return' error on the migration
stream if a migration is in progress. To improve error reporting, add
a new Error* argument to also set the Error object on the migration
stream.
Signed-off-by: Cédric Le Goater
---
hw/vfio/common.c | 50
We will use the Error object to improve error reporting in the
.log_global*() handlers of VFIO.
Signed-off-by: Cédric Le Goater
---
include/hw/vfio/vfio-container-base.h | 4 ++--
hw/vfio/common.c | 4 ++--
hw/vfio/container-base.c | 4 ++--
hw/vfio/container.c
This improves error reporting in the log_global_stop() VFIO handler.
Signed-off-by: Cédric Le Goater
---
hw/vfio/common.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index
a5d53e67efaa921e89ad918390a22506c7b1ed66..
The .save_setup() handler has now an Error** argument that we can use
to propagate errors reported by the .log_global_start() handler. Do
that for the RAM. qemu_savevm_state_setup() will store the error under
the migration stream for later detection in the migration sequence.
Signed-off-by: Cédric
Add an Error** argument to vfio_migration_set_state() and adjust
callers, including vfio_save_setup(). The error will be propagated up
to qemu_savevm_state_setup() where the save_setup() handler is
executed.
Signed-off-by: Cédric Le Goater
---
hw/vfio/migration.c | 62 +++
This will help detect issues regarding I/O channels usage.
Signed-off-by: Cédric Le Goater
---
migration/qemu-file.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index
94231ff2955c80b3d0fab11a40510d34c334a826..b69e0c62e2fc
Am 06.02.2024 um 20:06 hat Stefan Hajnoczi geschrieben:
> v2:
> - Add comment in Patch 3 explaining why bounds check assertion [Manos]
> - Remove redundant nested if in Patch 1 [Hanna]
>
> Hanna reviewed the iothread-vq-mapping patches after they were applied to
> qemu.git. This series consists of
Il mer 7 feb 2024, 14:16 BALATON Zoltan ha scritto:
> On Wed, 7 Feb 2024, Paolo Bonzini wrote:
> > itc_reconfigure() is referenced from TCG, provide a stub if needed.
> > This makes it possible to build a QEMU binary that only includes
> > boards without a CPS device (only Malta and Boston create
Il mer 7 feb 2024, 14:18 BALATON Zoltan ha scritto:
> > if (defaults_enabled() && object_class_by_name("pci-ohci")) {
> > pci_create_simple(pci_bus, -1, "pci-ohci");
> > -usb_create_simple(usb_bus_find(-1), "usb-kbd");
> > -usb_create_simple(usb_bus_find(-1), "usb-tabl
Am 02.02.2024 um 15:47 hat Hanna Czenczek geschrieben:
> Hi,
>
> Without the AioContext lock, a BB's context may kind of change at any
> time (unless it has a root node, and I/O requests are pending). That
> also means that its own context (BlockBackend.ctx) and that of its root
> node can differ
Am 05.02.2024 um 16:40 hat Daniel P. Berrangé geschrieben:
> Creating an instance of the 'TestEnv' class will create a temporary
> directory. This dir is only deleted, however, in the __exit__ handler
> invoked by a context manager.
>
> In dry-run mode, we don't use the TestEnv via a context manag
Am 05.02.2024 um 16:51 hat Daniel P. Berrangé geschrieben:
> If something goes wrong causing the iotests not to cleanup their
> temporary directory, it is useful if the dir had an identifying
> name to show what is to blame.
>
> Signed-off-by: Daniel P. Berrangé
Thanks, applied to the block bran
Am 06.02.2024 um 15:04 hat Stefan Hajnoczi geschrieben:
> QEMU's coding style generally forbids C99 mixed declarations.
>
> Signed-off-by: Stefan Hajnoczi
Thanks, applied to the block branch.
Kevin
On 06/02/24, Taylor Simpson wrote:
> Currently, we pass env to every generated helper. When the semantics of
> the instruction only depend on the arguments, this is unnecessary and
> adds extra overhead to the helper call.
>
> Changes in v2
> - Separate patches to pass P0 and SP explici
Ilya Leoshkevich writes:
> v2: https://lists.gnu.org/archive/html/qemu-devel/2024-02/msg00890.html
> v2 -> v3: Structure the meson check similar to have_asan_fiber;
> Reduce the context size a little (Philippe).
>
> v1: https://lists.gnu.org/archive/html/qemu-devel/2024-01/msg05155.html
Pierrick Bouvier writes:
> This series adds a new thread-safe API to declare inline operation
> inside plugins. As well, it removes the existing non thread-safe API,
> and migrates all existing plugins to use it.
I've cherry-picked 3 and 4 into plugins/next so I can re-base the
registers work. I
Alex Bennée writes:
> Pierrick Bouvier writes:
>
>> This series adds a new thread-safe API to declare inline operation
>> inside plugins. As well, it removes the existing non thread-safe API,
>> and migrates all existing plugins to use it.
>
> I've cherry-picked 3 and 4 into plugins/next so I ca
1 - 100 of 266 matches
Mail list logo
