Re: [PATCH v3 0/4] Add BHRB Facility Support

2024-02-05 Thread Nicholas Piggin
On Tue Sep 26, 2023 at 3:43 AM AEST, Glenn Miles wrote: > This is a series of patches for adding support for the Branch History > Rolling Buffer (BHRB) facility. This was added to the Power ISA > starting with version 2.07. Changes were subsequently made in version > 3.1 to limit BHRB recording t

Re: [PATCH] tests/cdrom-test: Add cdrom test for LoongArch virt machine

2024-02-05 Thread maobibo
On 2024/2/5 下午3:47, Thomas Huth wrote: On 05/02/2024 03.13, Bibo Mao wrote: The cdrom test skips to execute on LoongArch system with command "make check" Are you sure the test is marked with "skip"? ... it should at least test with the "none" machine...? With the latest code, cdrom testcas

Re: [PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64

2024-02-05 Thread Eric Auger
Hi, On 2/2/24 11:51, Peter Maydell wrote: > On Thu, 1 Feb 2024 at 23:50, Peter Xu wrote: >> Fabiano, I think you forgot to reply-to-all.. adding back the list and >> people in the loop. >> >> On Thu, Feb 01, 2024 at 10:12:44AM -0300, Fabiano Rosas wrote: >>> Peter Xu writes: >>> On Wed, Jan

Re: [PATCH v2 2/2] target/riscv: Support xtheadmaee for thead-c906

2024-02-05 Thread Christoph Müllner
On Mon, Feb 5, 2024 at 3:42 AM Alistair Francis wrote: > > On Sun, Feb 4, 2024 at 3:44 PM LIU Zhiwei > wrote: > > > > This patch set fix the regression on kernel pointed by Björn Töpel in > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg1018232.html. > > > > thead-c906 uses some flags i

Re: [PATCH v3 2/4] target/ppc: Add recording of taken branches to BHRB

2024-02-05 Thread Nicholas Piggin
On Tue Sep 26, 2023 at 3:43 AM AEST, Glenn Miles wrote: > This commit continues adding support for the Branch History > Rolling Buffer (BHRB) as is provided starting with the P8 > processor and continuing with its successors. This commit > is limited to the recording and filtering of taken branche

[PATCH 2/2] MAINTAINERS: Cover qapi/stats.json

2024-02-05 Thread Markus Armbruster
Commit aa09b3d5f8e (stats: Move QMP commands from monitor/ to stats/) created section Stats, but neglected to add qapi/stats.json to it. Fix that. Signed-off-by: Markus Armbruster --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 00ada764a7..9103

[PATCH 0/2] MAINTAINERS: Cover qapi/ better

2024-02-05 Thread Markus Armbruster
Markus Armbruster (2): MAINTAINERS: Cover qapi/cxl.json MAINTAINERS: Cover qapi/stats.json MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) -- 2.43.0

[PATCH 1/2] MAINTAINERS: Cover qapi/cxl.json

2024-02-05 Thread Markus Armbruster
Commit 415442a1b4a (hw/mem/cxl_type3: Add CXL RAS Error Injection Support.) created qapi/cxl.json without adding it to MAINTAINERS. Fix that. Cc: Ben Widawsky Cc: Jonathan Cameron Cc: Fan Ni Signed-off-by: Markus Armbruster --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/

Re: [PATCH v2 1/3] virtio-iommu: Add an option to define the input range width

2024-02-05 Thread Cédric Le Goater
On 2/1/24 17:32, Eric Auger wrote: aw-bits is a new option that allows to set the bit width of the input address range. This value will be used as a default for the device config input_range.end. By default it is set to 64 bits which is the current value. Signed-off-by: Eric Auger --- v1 -> v

Re: [PATCH v2 2/3] virtio-iommu: Trace domain range limits as unsigned int

2024-02-05 Thread Cédric Le Goater
On 2/1/24 17:32, Eric Auger wrote: Use %u format to trace domain_range limits. Signed-off-by: Eric Auger Reviewed-by: Cédric Le Goater Thanks, C. --- hw/virtio/trace-events | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/trace-events b/hw/virtio/trace-e

[v0 0/2] uart base and hardcode boot address 0

2024-02-05 Thread Jamin Lin via
v0: 1. support uart controller both 0 and 1 base 2. fix hardcode boot address 0 Jamin Lin (2): aspeed: support uart controller both 0 and 1 base aspeed: fix hardcode boot address 0 hw/arm/aspeed.c | 12 hw/arm/aspeed_ast10x0.c | 1 + hw/arm/aspeed_ast2400.c

[PATCH v0 2/2] aspeed: fix hardcode boot address 0

2024-02-05 Thread Jamin Lin via
In the previous design of QEMU model for ASPEED SOCs, it set the boot address at 0 which was the hardcode setting for ast10x0, ast2600, ast2500 and ast2400. According to the design of ast2700, it has bootmcu which is used for executing SPL and initialize DRAM, then, CPUs(cortex-a35) execute u-boot

[PATCH v0 1/2] aspeed: support uart controller both 0 and 1 base

2024-02-05 Thread Jamin Lin via
According to the design of ASPEED SOCS, the uart controller is 1 base for ast10x0, ast2600, ast2500 and ast2400. However, the uart controller is 0 base for ast2700. To support uart controller both 0 and 1 base, adds uasrt_bases parameter in AspeedSoCClass and set the default uart controller 1 base

Re: [PATCH v11 0/3] gdbstub and TCG plugin improvements

2024-02-05 Thread Alex Bennée
Akihiko Odaki writes: > On 2024/02/03 22:58, Alex Bennée wrote: >> Akihiko Odaki writes: >> >>> On 2024/02/03 20:08, Alex Bennée wrote: Akihiko Odaki writes: > This series extracts fixes and refactorings that can be applied > independently from "[PATCH v9 00/23] plugins: Allo

Re: [PATCH v2 3/3] hw: Set virtio-iommu aw-bits default value on pc_q35_9.0 and arm virt

2024-02-05 Thread Cédric Le Goater
On 2/1/24 17:32, Eric Auger wrote: Currently the default input range can extend to 64 bits. On x86, when the virtio-iommu protects vfio devices, the physical iommu may support only 39 bits. Let's set the default to 39, as done for the intel-iommu. On ARM we set 48b as a default (matching SMMUv3 S

Re: [PATCH 4/4] qapi/char: Deprecate backend type "memory"

2024-02-05 Thread Ján Tomko
On a Saturday in 2024, Markus Armbruster wrote: It's an alias for "ringbuf" we kept for backward compatibility; see commit 3a1da42eb35 (qapi: Rename ChardevBackend member "memory" to "ringbuf"). Deprecation is long overdue. Signed-off-by: Markus Armbruster --- docs/about/deprecated.rst | 8 +++

RE: [PATCH v0] aspeed: support uart controller both 0 and 1 base

2024-02-05 Thread Jamin Lin
> -Original Message- > From: Jamin Lin > Sent: Monday, February 5, 2024 4:18 PM > To: Cédric Le Goater ; Peter Maydell > ; Andrew Jeffery ; > Joel Stanley ; open list:ASPEED BMCs > ; open list:All patches CC here > > Cc: Troy Lee ; Jamin Lin > > Subject: [PATCH v0] aspeed: support uart c

Re: [PATCH v3 0/3] Virtio dmabuf improvements

2024-02-05 Thread Albert Esteve
Friendly reminder & bump Is this series waiting to be picked up, or is there anything left to do? BR, Albert On Tue, Jan 9, 2024 at 1:56 PM Albert Esteve wrote: > v1: https://www.mail-archive.com/qemu-devel@nongnu.org/msg1005257.html > v2: https://www.mail-archive.com/qemu-devel@nongnu.org/

Re: Re: [PATCH] tests/tcg: Fix the /proc/self/mem probing in the PROT_NONE gdbstub test

2024-02-05 Thread Ilya Leoshkevich
On Sat, Feb 03, 2024 at 11:48:44PM +0300, Michael Tokarev wrote: > 01.02.2024 01:02, Ilya Leoshkevich wrote: > > The `if not probe_proc_self_mem` check never passes, because > > probe_proc_self_mem is a function object, which is a truthy value. > > Add parentheses in order to perform a function cal

Re: [PATCH v11 0/3] gdbstub and TCG plugin improvements

2024-02-05 Thread Pierrick Bouvier
On 2/5/24 13:31, Alex Bennée wrote: Akihiko Odaki writes: On 2024/02/03 22:58, Alex Bennée wrote: Akihiko Odaki writes: On 2024/02/03 20:08, Alex Bennée wrote: Akihiko Odaki writes: This series extracts fixes and refactorings that can be applied independently from "[PATCH v9 00/23] plu

Re: [PULL 00/47] nic-config.for-upstream queue

2024-02-05 Thread Thomas Huth
On 05/02/2024 07.56, Thomas Huth wrote: On 02/02/2024 16.40, Peter Maydell wrote: On Fri, 2 Feb 2024 at 15:36, David Woodhouse wrote: On Fri, 2024-02-02 at 15:32 +, Peter Maydell wrote: This fails "make check' because some of the qom-test and test-hmp checks fail when the QEMU binary se

Re: [PATCH v2 1/3] virtio-iommu: Add an option to define the input range width

2024-02-05 Thread Jean-Philippe Brucker
Hi Eric, On Thu, Feb 01, 2024 at 05:32:22PM +0100, Eric Auger wrote: > aw-bits is a new option that allows to set the bit width of > the input address range. This value will be used as a default for > the device config input_range.end. By default it is set to 64 bits > which is the current value.

Re: [GIT PULL 5/8] util: Add write-only "node-affinity" property for ThreadContext

2024-02-05 Thread Claudio Fontana
Hi, turning pages back in time, noticed that in recent qemu-img binaries we include an ELF dependency on libnuma.so that seems unused. I think it stems from this commit: commit 10218ae6d006f76410804cc4dc690085b3d008b5 Author: David Hildenbrand Date: Fri Oct 14 15:47:17 2022 +0200 util:

Re: [PATCH 2/2] migration: Fix return-path thread exit

2024-02-05 Thread Cédric Le Goater
On 2/5/24 04:37, Peter Xu wrote: On Fri, Feb 02, 2024 at 12:11:09PM -0300, Fabiano Rosas wrote: Cédric Le Goater writes: On 2/2/24 15:42, Fabiano Rosas wrote: Cédric Le Goater writes: In case of error, close_return_path_on_source() can perform a shutdown to exit the return-path thread. H

Re: [PATCH v2 1/3] virtio-iommu: Add an option to define the input range width

2024-02-05 Thread Cédric Le Goater
On 2/5/24 10:14, Cédric Le Goater wrote: On 2/1/24 17:32, Eric Auger wrote: aw-bits is a new option that allows to set the bit width of the input address range. This value will be used as a default for the device config input_range.end. By default it is set to 64 bits which is the current value.

Re: [PULL 06/14] ci: Add a migration compatibility test job

2024-02-05 Thread Daniel P . Berrangé
On Mon, Feb 05, 2024 at 11:25:13AM +0800, Peter Xu wrote: > On Fri, Feb 02, 2024 at 10:47:05AM -0300, Fabiano Rosas wrote: > > Peter Maydell writes: > > > > > On Mon, 29 Jan 2024 at 03:04, wrote: > > >> > > >> From: Fabiano Rosas > > >> > > >> The migration tests have support for being passed t

Re: [PATCH v2] qemu_init: increase NOFILE soft limit on POSIX

2024-02-05 Thread Daniel P . Berrangé
On Fri, Feb 02, 2024 at 09:35:19AM +0100, Fiona Ebner wrote: > Am 18.12.23 um 11:13 schrieb Fiona Ebner: > > In many configurations, e.g. multiple vNICs with multiple queues or > > with many Ceph OSDs, the default soft limit of 1024 is not enough. > > QEMU is supposed to work fine with file descrip

Re: [PATCH 0/2] migration: Fix return-path thread exit

2024-02-05 Thread Daniel P . Berrangé
On Fri, Feb 02, 2024 at 05:53:39PM +0800, Peter Xu wrote: > On Thu, Feb 01, 2024 at 07:48:51PM +0100, Cédric Le Goater wrote: > > Hello, > > Hi, Cédric, > > Thanks for the patches. > > > > > Today, close_return_path_on_source() can perform a shutdown to exit > > the return-path thread if an err

Re: [PULL 06/14] ci: Add a migration compatibility test job

2024-02-05 Thread Peter Xu
On Mon, Feb 05, 2024 at 10:22:35AM +, Daniel P. Berrangé wrote: > On Mon, Feb 05, 2024 at 11:25:13AM +0800, Peter Xu wrote: > > On Fri, Feb 02, 2024 at 10:47:05AM -0300, Fabiano Rosas wrote: > > > Peter Maydell writes: > > > > > > > On Mon, 29 Jan 2024 at 03:04, wrote: > > > >> > > > >> From

Re: [PATCH v0 1/2] aspeed: support uart controller both 0 and 1 base

2024-02-05 Thread Cédric Le Goater
Hello Jamin, On 2/5/24 10:14, Jamin Lin wrote: According to the design of ASPEED SOCS, the uart controller is 1 base for ast10x0, ast2600, ast2500 and ast2400. However, the uart controller is 0 base for ast2700. To support uart controller both 0 and 1 base, adds uasrt_bases parameter in AspeedS

Re: [PULL 06/14] ci: Add a migration compatibility test job

2024-02-05 Thread Daniel P . Berrangé
On Mon, Feb 05, 2024 at 06:45:23PM +0800, Peter Xu wrote: > On Mon, Feb 05, 2024 at 10:22:35AM +, Daniel P. Berrangé wrote: > > On Mon, Feb 05, 2024 at 11:25:13AM +0800, Peter Xu wrote: > > > On Fri, Feb 02, 2024 at 10:47:05AM -0300, Fabiano Rosas wrote: > > > > Peter Maydell writes: > > > >

Re: [PATCH] vdpa-dev: Fix initialisation order to restore VDUSE compatibility

2024-02-05 Thread Stefano Garzarella
On Fri, Feb 02, 2024 at 02:25:21PM +0100, Kevin Wolf wrote: VDUSE requires that virtqueues are first enabled before the DRIVER_OK status flag is set; with the current API of the kernel module, it is impossible to enable the opposite order in our block export code because userspace is not notified

Re: [PULL 00/47] nic-config.for-upstream queue

2024-02-05 Thread Peter Maydell
On Mon, 5 Feb 2024 at 10:11, Thomas Huth wrote: > > On 05/02/2024 07.56, Thomas Huth wrote: > > On 02/02/2024 16.40, Peter Maydell wrote: > >> On Fri, 2 Feb 2024 at 15:36, David Woodhouse wrote: > >>> > >>> On Fri, 2024-02-02 at 15:32 +, Peter Maydell wrote: > > This fails "make che

Re: [PULL 05/13] linux-user: Use walk_memory_regions for open_self_maps

2024-02-05 Thread Richard Purdie
On Mon, 2024-02-05 at 13:05 +1000, Richard Henderson wrote: > On 1/26/24 23:52, Richard Purdie wrote: > > On Fri, 2024-01-26 at 16:33 +0300, Michael Tokarev wrote: > > > 26.01.2024 16:03, Richard Purdie wrote: > > > > I've run into a problem with this change. > > > > > > > > We (Yocto Project) upg

Re: [PATCH 5/5] migration/multifd: Add a synchronization point for channel creation

2024-02-05 Thread Avihai Horon
On 05/02/2024 8:20, Peter Xu wrote: External email: Use caution opening links or attachments On Fri, Feb 02, 2024 at 04:11:28PM -0300, Fabiano Rosas wrote: It is possible that one of the multifd channels fails to be created at multifd_new_send_channel_async() while the rest of the channel cr

Re: [PATCH v11 0/3] gdbstub and TCG plugin improvements

2024-02-05 Thread Alex Bennée
Pierrick Bouvier writes: > On 2/5/24 13:31, Alex Bennée wrote: >> Akihiko Odaki writes: >> >>> On 2024/02/03 22:58, Alex Bennée wrote: Akihiko Odaki writes: > On 2024/02/03 20:08, Alex Bennée wrote: >> Akihiko Odaki writes: >> >>> This series extracts fixes and refac

[PATCH v2 01/11] gdbstub: Support disablement in a multi-threaded process

2024-02-05 Thread Ilya Leoshkevich
The upcoming follow-fork-mode child support will require disabling gdbstub in the parent process, which may have multiple threads (which are represented as CPUs). Loop over all CPUs in order to remove watchpoints and disable single-step. Move the respective code into a separate function. Signed-o

[PATCH v2 07/11] gdbstub: Introduce gdb_handle_query_supported_user()

2024-02-05 Thread Ilya Leoshkevich
The upcoming follow-fork-mode child support requires advertising the fork-events feature, which is user-specific. Introduce a user-specific hook for this. Signed-off-by: Ilya Leoshkevich --- gdbstub/gdbstub.c | 12 +--- gdbstub/internals.h | 1 + gdbstub/user.c | 4 3 files

[PATCH v2 06/11] gdbstub: Call gdbserver_fork() both in parent and in child

2024-02-05 Thread Ilya Leoshkevich
The upcoming follow-fork-mode child support requires post-fork message exchange between the parent and the child. Prepare gdbserver_fork() for this purpose. Rename it to gdbserver_fork_end() to better reflect its purpose. Signed-off-by: Ilya Leoshkevich --- bsd-user/main.c| 3 ++- gdbstu

[PATCH v2 00/11] gdbstub: Implement follow-fork-mode child

2024-02-05 Thread Ilya Leoshkevich
Based-on: <20240202152506.279476-1-...@linux.ibm.com> ("[PATCH v3 0/5] gdbstub: Implement catching syscalls") v1: https://lists.gnu.org/archive/html/qemu-devel/2024-01/msg06646.html v1 -> v2: Factor out a number of prep patches; Add a state transition diagram comment (Alex). Im

[PATCH v2 11/11] tests/tcg: Add two follow-fork-mode tests

2024-02-05 Thread Ilya Leoshkevich
Add follow-fork-mode child and and follow-fork-mode parent tests. Check for the obvious pitfalls, such as lingering breakpoints, catchpoints, and single-step mode. Signed-off-by: Ilya Leoshkevich --- tests/tcg/multiarch/Makefile.target | 17 +- tests/tcg/multiarch/follow-fork-mode.

[PATCH v2 10/11] gdbstub: Implement follow-fork-mode child

2024-02-05 Thread Ilya Leoshkevich
Currently it's not possible to use gdbstub for debugging linux-user code that runs in a forked child, which is normally done using the `set follow-fork-mode child` GDB command. Purely on the protocol level, the missing piece is the fork-events feature. However, a deeper problem is supporting $Hg s

[PATCH v2 05/11] {linux,bsd}-user: Pass pid to gdbserver_fork()

2024-02-05 Thread Ilya Leoshkevich
The upcoming follow-fork-mode child support requires knowing the child pid. Pass it down. Signed-off-by: Ilya Leoshkevich --- bsd-user/main.c| 2 +- gdbstub/user.c | 2 +- include/gdbstub/user.h | 2 +- linux-user/main.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(

[PATCH v2 02/11] {linux,bsd}-user: Update ts_tid after fork()

2024-02-05 Thread Ilya Leoshkevich
Currently ts_tid contains the parent tid after fork(), which is not correct. So far it has not affected anything, but the upcoming follow-fork-mode child support relies on the correct value, so fix it. Signed-off-by: Ilya Leoshkevich --- bsd-user/main.c | 1 + linux-user/main.c | 1 + 2 files

[PATCH v2 03/11] gdbstub: Introduce gdbserver_fork_start()

2024-02-05 Thread Ilya Leoshkevich
The upcoming follow-fork-mode child support requires knowing when fork() is about to happen in order to initialize its state. Add a hook for that. Signed-off-by: Ilya Leoshkevich --- bsd-user/main.c| 1 + gdbstub/user.c | 4 include/gdbstub/user.h | 5 + linux-user/main.

[PATCH v2 04/11] {linux,bsd}-user: Pass pid to fork_end()

2024-02-05 Thread Ilya Leoshkevich
The upcoming follow-fork-mode child support requires knowing the child pid. Pass it down. Signed-off-by: Ilya Leoshkevich --- bsd-user/freebsd/os-proc.h | 6 +++--- bsd-user/main.c | 4 +++- bsd-user/qemu.h | 2 +- linux-user/main.c | 4 +++- linux-user/syscall

[PATCH v2 08/11] gdbstub: Introduce gdb_handle_set_thread_user()

2024-02-05 Thread Ilya Leoshkevich
The upcoming follow-fork-mode child support needs to perform certain actions when GDB switches between the stopped parent and the stopped child. Introduce a user-specific hook for this. Signed-off-by: Ilya Leoshkevich --- gdbstub/gdbstub.c | 11 +-- gdbstub/internals.h | 1 + gdbstub/

[PATCH v2 09/11] gdbstub: Introduce gdb_handle_detach_user()

2024-02-05 Thread Ilya Leoshkevich
The upcoming follow-fork-mode child support needs to perform certain actions when GDB detaches from the stopped parent or the stopped child. Introduce a user-specific hook for this. Signed-off-by: Ilya Leoshkevich --- gdbstub/gdbstub.c | 6 ++ gdbstub/internals.h | 1 + gdbstub/user.c

Re: [PATCH] hw: riscv: Allow large kernels to boot by moving the initrd further way in RAM

2024-02-05 Thread Daniel Henrique Barboza
On 2/5/24 04:00, Alexandre Ghiti wrote: Currently, the initrd is placed at 128MB, which overlaps with the kernel when it is large (for example syzbot kernels are). From the kernel side, there is no reason we could not push the initrd further away in memory to accomodate large kernels, so move

Re: [PATCH] vdpa-dev: Fix initialisation order to restore VDUSE compatibility

2024-02-05 Thread Eugenio Perez Martin
On Fri, Feb 2, 2024 at 2:25 PM Kevin Wolf wrote: > > VDUSE requires that virtqueues are first enabled before the DRIVER_OK > status flag is set; with the current API of the kernel module, it is > impossible to enable the opposite order in our block export code because > userspace is not notified w

Re: [PATCH] MAINTAINERS: Switch to my Enfabrica email

2024-02-05 Thread Alex Bennée
Raphael Norwitz writes: > I'd prefer to use my new work email so this change updates MAINTAINERS > with it. > > Signed-off-by: Raphael Norwitz Reviewed-by: Alex Bennée > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > ind

Re: [PATCH v4 3/4] tests/tcg/s390x: Test CONVERT TO DECIMAL

2024-02-05 Thread Thomas Huth
On 02/02/2024 15.11, Ilya Leoshkevich wrote: Check the CVD's, CVDY's, and CVDG's corner cases. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.target | 1 + tests/tcg/s390x/cvd.c | 63 + 2 files changed, 64 insertions(+) create mode

Re: Dynamic & heterogeneous machines, initial configuration: problems

2024-02-05 Thread Daniel P . Berrangé
On Wed, Jan 31, 2024 at 09:14:21PM +0100, Markus Armbruster wrote: > == What users want for initial configuration == > > 1. QMP only > >Management applications need to use QMP for monitoring anyway. They >may want to use it for initial configuration, too. Libvirt does. > >They stil

Re: [PATCH 5/5] migration/multifd: Add a synchronization point for channel creation

2024-02-05 Thread Peter Xu
On Mon, Feb 05, 2024 at 01:10:14PM +0200, Avihai Horon wrote: > > On 05/02/2024 8:20, Peter Xu wrote: > > External email: Use caution opening links or attachments > > > > > > On Fri, Feb 02, 2024 at 04:11:28PM -0300, Fabiano Rosas wrote: > > > It is possible that one of the multifd channels fail

Re: [PATCH v3 1/3] hw/virtio: check owner for removing objects

2024-02-05 Thread Alex Bennée
Albert Esteve writes: > Shared objects lack spoofing protection. > For VHOST_USER_BACKEND_SHARED_OBJECT_REMOVE messages > received by the vhost-user interface, any backend was > allowed to remove entries from the shared table just > by knowing the UUID. Only the owner of the entry > shall be allo

Re: [PATCH] tests/cdrom-test: Add cdrom test for LoongArch virt machine

2024-02-05 Thread Philippe Mathieu-Daudé
Hi Bibo, On 5/2/24 03:13, Bibo Mao wrote: The cdrom test skips to execute on LoongArch system with command "make check", this patch enables cdrom test for LoongArch virt machine platform. With this patch, cdrom test passes to run on LoongArch virt machine type. Signed-off-by: Bibo Mao --- t

Re: [PULL 00/39] tcg patch queue

2024-02-05 Thread Peter Maydell
ilable in the Git repository at: > > https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20240205 > > for you to fetch changes up to 867db6870a6f5d4e0915822d6a84e665bec1f22e: > > tcg/tci: Support TCG_COND_TST{EQ,NE} (2024-02-03 23:53:49 +) > > --

Re: [PATCH] vdpa-dev: Fix initialisation order to restore VDUSE compatibility

2024-02-05 Thread Kevin Wolf
Am 02.02.2024 um 14:25 hat Kevin Wolf geschrieben: > VDUSE requires that virtqueues are first enabled before the DRIVER_OK > status flag is set; with the current API of the kernel module, it is > impossible to enable the opposite order in our block export code because > userspace is not notified wh

Re: [PATCH v0 1/2] aspeed: support uart controller both 0 and 1 base

2024-02-05 Thread Philippe Mathieu-Daudé
On 5/2/24 11:46, Cédric Le Goater wrote: Hello Jamin, On 2/5/24 10:14, Jamin Lin wrote: According to the design of ASPEED SOCS, the uart controller is 1 base for ast10x0, ast2600, ast2500 and ast2400. However, the uart controller is 0 base for ast2700. To support uart controller both 0 and 1 b

Re: [PATCH v0 2/2] aspeed: fix hardcode boot address 0

2024-02-05 Thread Philippe Mathieu-Daudé
Hi Jamin, On 5/2/24 10:14, Jamin Lin via wrote: In the previous design of QEMU model for ASPEED SOCs, it set the boot address at 0 which was the hardcode setting for ast10x0, ast2600, ast2500 and ast2400. According to the design of ast2700, it has bootmcu which is used for executing SPL and ini

Re: NVME hotplug support ?

2024-02-05 Thread Damien Hedde
On 1/29/24 16:35, Hannes Reinecke wrote: On 1/29/24 14:13, Damien Hedde wrote: On 1/24/24 08:47, Hannes Reinecke wrote: On 1/24/24 07:52, Philippe Mathieu-Daudé wrote: Hi Hannes, [+Markus as QOM/QDev rubber duck] On 23/1/24 13:40, Hannes Reinecke wrote: On 1/23/24 11:59, Damien Hedde wr

Re: [PATCH v0 2/2] aspeed: fix hardcode boot address 0

2024-02-05 Thread Cédric Le Goater
On 2/5/24 10:14, Jamin Lin wrote: In the previous design of QEMU model for ASPEED SOCs, it set the boot address at 0 which was the hardcode setting for ast10x0, ast2600, ast2500 and ast2400. According to the design of ast2700, it has bootmcu which is used for executing SPL and initialize DRAM, t

Re: [PATCH] hw: riscv: Allow large kernels to boot by moving the initrd further way in RAM

2024-02-05 Thread Alexandre Ghiti
Hi Daniel, On Mon, Feb 5, 2024 at 1:17 PM Daniel Henrique Barboza wrote: > > > > On 2/5/24 04:00, Alexandre Ghiti wrote: > > Currently, the initrd is placed at 128MB, which overlaps with the kernel > > when it is large (for example syzbot kernels are). From the kernel side, > > there is no reason

Re: [PATCH 2/3] hw/arm : Connect DM163 to STM32L4x5

2024-02-05 Thread Philippe Mathieu-Daudé
Hi Inès, On 26/1/24 20:31, Inès Varhol wrote: Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- hw/arm/Kconfig | 1 + hw/arm/stm32l4x5_soc.c | 55 +- include/hw/arm/stm32l4x5_soc.h | 3 ++ 3 files changed, 58 insertions(+

Re: [PATCH] vdpa-dev: Fix initialisation order to restore VDUSE compatibility

2024-02-05 Thread Kevin Wolf
Am 05.02.2024 um 13:22 hat Eugenio Perez Martin geschrieben: > On Fri, Feb 2, 2024 at 2:25 PM Kevin Wolf wrote: > > > > VDUSE requires that virtqueues are first enabled before the DRIVER_OK > > status flag is set; with the current API of the kernel module, it is > > impossible to enable the opposi

Re: [PATCH 3/3] tests/qtest : Add testcase for DM163

2024-02-05 Thread Philippe Mathieu-Daudé
Hi Inès, On 26/1/24 20:31, Inès Varhol wrote: `test_dm163_bank()` Checks that the pin "sout" of the DM163 led driver outputs the values received on pin "sin" with the expected latency (depending on the bank). `test_dm163_gpio_connection()` Check that changes to relevant STM32L4x5 GPIO pins are

Re: [PATCH v3 3/6] target/riscv: add remaining named features

2024-02-05 Thread Andrew Jones
On Fri, Feb 02, 2024 at 12:21:51PM -0300, Daniel Henrique Barboza wrote: > The RVA22U64 and RVA22S64 profiles mandates certain extensions that, > until now, we were implying that they were available. > > We can't do this anymore since named features also has a riscv,isa > entry. Let's add them to

Re: [PATCH 0/3] Add device DM163 (led driver, matrix colors shield & display)

2024-02-05 Thread Philippe Mathieu-Daudé
Hi Inès, On 26/1/24 20:31, Inès Varhol wrote: This device implements the IM120417002 colors shield v1.1 for Arduino (which relies on the DM163 8x3-channel led driving logic) and features a simple display of an 8x8 RGB matrix. This color shield can be plugged on the Arduino board (or the B-L475E

Re: [PATCH 0/2] MAINTAINERS: Cover qapi/ better

2024-02-05 Thread Philippe Mathieu-Daudé
On 5/2/24 09:47, Markus Armbruster wrote: Markus Armbruster (2): MAINTAINERS: Cover qapi/cxl.json MAINTAINERS: Cover qapi/stats.json Series: Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v4 4/4] tests/tcg/s390x: Test CONVERT TO BINARY

2024-02-05 Thread Thomas Huth
On 02/02/2024 15.12, Ilya Leoshkevich wrote: Check the CVB's, CVBY's, and CVBG's corner cases. Co-developed-by: Pavel Zbitskiy Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.target | 1 + tests/tcg/s390x/cvb.c | 102 2 files change

Re: [PATCH v2 23/23] migration/multifd: Optimize sender side to be lockless

2024-02-05 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Feb 02, 2024 at 06:34:08PM -0300, Fabiano Rosas wrote: >> pet...@redhat.com writes: >> >> > From: Peter Xu >> > >> > When reviewing my attempt to refactor send_prepare(), Fabiano suggested we >> > try out with dropping the mutex in multifd code [1]. >> > >> > I though

Re: [GIT PULL 5/8] util: Add write-only "node-affinity" property for ThreadContext

2024-02-05 Thread David Hildenbrand
On 05.02.24 11:14, Claudio Fontana wrote: Hi, Hi Claudio, turning pages back in time, noticed that in recent qemu-img binaries we include an ELF dependency on libnuma.so that seems unused. I think it stems from this commit: commit 10218ae6d006f76410804cc4dc690085b3d008b5 Author: David Hi

[RFC PATCH 00/11 qemu] arm/acpi/pci/cxl: ACPI based FW First error injection.

2024-02-05 Thread Jonathan Cameron via
I've had a version of this code for many years (and occasionally mention it as test platform for kernel patches) and it keeps coming in handy, so time to share the CXL version. What is this? - ACPI + UEFI specs define a means of notifying the OS of errors that firmware has handled (gathered up d

[RFC PATCH 01/11] hw/pci: Add pcie_find_dvsec() utility.

2024-02-05 Thread Jonathan Cameron via
Simple search code used to find first instance of a PCIe Designated Vendor-Specific Extended Capability. Signed-off-by: Jonathan Cameron --- include/hw/pci/pcie.h | 1 + hw/pci/pcie.c | 24 2 files changed, 25 insertions(+) diff --git a/include/hw/pci/pcie.h b/

[RFC PATCH 02/11] hw/acpi: Allow GPEX _OSC to keep fw first control of AER and CXL errors.

2024-02-05 Thread Jonathan Cameron via
Signed-off-by: Jonathan Cameron --- include/hw/acpi/cxl.h | 2 +- include/hw/pci-host/gpex.h | 1 + hw/acpi/cxl-stub.c | 2 +- hw/acpi/cxl.c | 31 +++ hw/i386/acpi-build.c | 2 +- hw/pci-host/gpex-acpi.c| 17 +++-- hw

[RFC PATCH 03/11] arm/virt: Add fw-first-ras property.

2024-02-05 Thread Jonathan Cameron via
Provide a machine parameter to request firmware first RAS handling and no hand over to the OS via _OSC. Includes a bug fix as register access is not in CDW5 but only in CXW4 (OS support field). Signed-off-by: Jonathan Cameron --- include/hw/arm/virt.h| 1 + hw/acpi/cxl.c| 3 --

[RFC PATCH 04/11] acpi/ghes: Support GPIO error source.

2024-02-05 Thread Jonathan Cameron via
Signed-off-by: Jonathan Cameron --- include/hw/acpi/ghes.h | 1 + hw/acpi/ghes.c | 8 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/include/hw/acpi/ghes.h b/include/hw/acpi/ghes.h index 674f6958e9..4f1ab1a73a 100644 --- a/include/hw/acpi/ghes.h +++ b/include/hw/a

[RFC PATCH 05/11] arm/virt: Wire up GPIO error source for ACPI / GHES

2024-02-05 Thread Jonathan Cameron via
Includes creation of a GED - Generic Event Device Signed-off-by: Jonathan Cameron --- include/hw/boards.h | 1 + hw/arm/virt-acpi-build.c | 29 + hw/arm/virt.c| 12 +++- 3 files changed, 37 insertions(+), 5 deletions(-) diff --git a/include/

[RFC PATCH 06/11] acpi: pci/cxl: Stash the OSC control parameters.

2024-02-05 Thread Jonathan Cameron via
Allow QEMU to know what was successfully requested by the OS via _OSC. Note this handling is very minimal and assumes last written Control parameters were accepted (which they should be if the OS is obeying the rules for negotiating this stuff). Signed-off-by: Jonathan Cameron --- include/hw/ac

[RFC PATCH 07/11] pci/aer: Support firmware first error injection via GHESv2

2024-02-05 Thread Jonathan Cameron via
If the machine supports firmware first error injection enable those flows. Signed-off-by: Jonathan Cameron --- include/hw/acpi/ghes.h | 3 + hw/acpi/ghes-stub.c| 4 + hw/acpi/ghes.c | 250 +++-- hw/pci/pcie_aer.c | 35 -- 4 files chan

[RFC PATCH 08/11] hw/pci/aer: Default to error handling on.

2024-02-05 Thread Jonathan Cameron via
This should be dependent on the platform supporting FW first. Signed-off-by: Jonathan Cameron --- hw/pci/pcie.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 9f1ca718b5..4f04a1702a 100644 --- a/hw/pci/pcie.c +++ b/hw/pci/pcie.c @@ -304,6 +304,12 @@

[RFC PATCH 09/11] cxl/ras: Set registers to sensible state for FW first ras

2024-02-05 Thread Jonathan Cameron via
Even if we are doing native RAS, until the point where the OS requests it via an _OSC the firmware may well be handling any errors from CXL devices. As such configure them as if a firmware has been doing so. Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-component-utils.c | 4 ++-- 1 file chang

[RFC PATCH 10/11] cxl/type3: FW first protocol error injection.

2024-02-05 Thread Jonathan Cameron via
Note this is only hooked up to type 3 device so far. Injection via the same interface as for native errors. e.g. { "execute": "cxl-inject-uncorrectable-errors", "arguments": { "path": "/machine/peripheral/cxl-pmem2", "errors": [ { "type": "cache-address-parity",

[RFC PATCH 11/11] cxl/type3: Add firmware first error reporting for general media events.

2024-02-05 Thread Jonathan Cameron via
Initial code for Firmware First injection of general media events. PoC level only - issue to be solved include: * Mapping to CPER error types (recoverable etc). * Some record details are tricky to establish so for now are not provided. Signed-off-by: Jonathan Cameron --- include/hw/acpi/ghes.h

Re: [PATCH v2 23/23] migration/multifd: Optimize sender side to be lockless

2024-02-05 Thread Peter Xu
On Mon, Feb 05, 2024 at 11:10:34AM -0300, Fabiano Rosas wrote: > > (maybe I can repost this single patch in-place to avoid another round of > > mail bombs..) > > Sure. I've got the final version attached here. Feel free to have a look, thanks. >From 6ba337320430feae4ce9d3d906ea19f68430642

Re: [PATCH v0 1/2] aspeed: support uart controller both 0 and 1 base

2024-02-05 Thread Cédric Le Goater
On 2/5/24 11:46, Cédric Le Goater wrote: Hello Jamin, On 2/5/24 10:14, Jamin Lin wrote: According to the design of ASPEED SOCS, the uart controller is 1 base for ast10x0, ast2600, ast2500 and ast2400. However, the uart controller is 0 base for ast2700. To support uart controller both 0 and 1 b

Re: [PATCH 3/3] meson: Disable CONFIG_NOTIFY1 on FreeBSD

2024-02-05 Thread Warner Losh
On Wed, Jan 31, 2024 at 9:42 AM Daniel P. Berrangé wrote: > On Wed, Jan 31, 2024 at 05:24:10PM +0100, Philippe Mathieu-Daudé wrote: > > Hi, > > > > Warner, do you remember what this is about? > > > > ( > https://cgit.freebsd.org/ports/commit/emulators/qemu-devel/files/patch-util_meson.build?id=2a

Re: [PATCH 3/3] meson: Disable CONFIG_NOTIFY1 on FreeBSD

2024-02-05 Thread Daniel P . Berrangé
On Mon, Feb 05, 2024 at 08:23:41AM -0700, Warner Losh wrote: > On Wed, Jan 31, 2024 at 9:42 AM Daniel P. Berrangé > wrote: > > > On Wed, Jan 31, 2024 at 05:24:10PM +0100, Philippe Mathieu-Daudé wrote: > > > Hi, > > > > > > Warner, do you remember what this is about? > > > > > > ( > > https://cgit

[PATCH] iotests: fix leak of tmpdir in dry-run mode

2024-02-05 Thread Daniel P . Berrangé
Creating an instance of the 'TestEnv' class will create a temporary directory. This dir is only deleted, however, in the __exit__ handler invoked by a context manager. In dry-run mode, we don't use the TestEnv via a context manager, so were leaking the temporary directory. Since meson invokes 'che

Re: [PATCH 5/5] migration/multifd: Add a synchronization point for channel creation

2024-02-05 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Feb 05, 2024 at 01:10:14PM +0200, Avihai Horon wrote: >> >> On 05/02/2024 8:20, Peter Xu wrote: >> > External email: Use caution opening links or attachments >> > >> > >> > On Fri, Feb 02, 2024 at 04:11:28PM -0300, Fabiano Rosas wrote: >> > > It is possible that one

Re: [PATCH] iotests: fix leak of tmpdir in dry-run mode

2024-02-05 Thread Peter Maydell
On Mon, 5 Feb 2024 at 15:41, Daniel P. Berrangé wrote: > > Creating an instance of the 'TestEnv' class will create a temporary > directory. This dir is only deleted, however, in the __exit__ handler > invoked by a context manager. > > In dry-run mode, we don't use the TestEnv via a context manager

[PATCH] iotests: give tempdir an identifying name

2024-02-05 Thread Daniel P . Berrangé
If something goes wrong causing the iotests not to cleanup their temporary directory, it is useful if the dir had an identifying name to show what is to blame. Signed-off-by: Daniel P. Berrangé --- tests/qemu-iotests/testenv.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [PATCH] iotests: fix leak of tmpdir in dry-run mode

2024-02-05 Thread Michael Tokarev
05.02.2024 18:40, Daniel P. Berrangé : Creating an instance of the 'TestEnv' class will create a temporary directory. This dir is only deleted, however, in the __exit__ handler invoked by a context manager. In dry-run mode, we don't use the TestEnv via a context manager, so were leaking the temp

Re: [PATCH 3/3] meson: Disable CONFIG_NOTIFY1 on FreeBSD

2024-02-05 Thread Ilya Leoshkevich
On Mon, 2024-02-05 at 15:31 +, Daniel P. Berrangé wrote: > On Mon, Feb 05, 2024 at 08:23:41AM -0700, Warner Losh wrote: > > On Wed, Jan 31, 2024 at 9:42 AM Daniel P. Berrangé > > > > wrote: > > > > > On Wed, Jan 31, 2024 at 05:24:10PM +0100, Philippe Mathieu-Daudé > > > wrote: > > > > Hi, > >

Re: [PATCH 3/3] meson: Disable CONFIG_NOTIFY1 on FreeBSD

2024-02-05 Thread Kyle Evans
On 2/5/24 09:31, Daniel P. Berrangé wrote: On Mon, Feb 05, 2024 at 08:23:41AM -0700, Warner Losh wrote: On Wed, Jan 31, 2024 at 9:42 AM Daniel P. Berrangé wrote: On Wed, Jan 31, 2024 at 05:24:10PM +0100, Philippe Mathieu-Daudé wrote: > [... snip ...] On 25/1/24 20:48, Ilya Leoshkevich wrote

Re: [GIT PULL 5/8] util: Add write-only "node-affinity" property for ThreadContext

2024-02-05 Thread Claudio Fontana
Hello David, It would seem to me that a lot of the calling code like qemu_prealloc_mem for example should be sysemu-only, not used for tools, or user mode either right? And the thread_context.c itself should also be sysemu-only, correct? Thanks, Claudio On 2/5/24 15:15, David Hildenbrand wrot

Re: [PATCH v2 1/3] virtio-iommu: Add an option to define the input range width

2024-02-05 Thread Eric Auger
Hi Jean, On 2/5/24 11:13, Jean-Philippe Brucker wrote: > Hi Eric, > > On Thu, Feb 01, 2024 at 05:32:22PM +0100, Eric Auger wrote: >> aw-bits is a new option that allows to set the bit width of >> the input address range. This value will be used as a default for >> the device config input_range.end

Re: [PATCH v2 3/3] hw: Set virtio-iommu aw-bits default value on pc_q35_9.0 and arm virt

2024-02-05 Thread Eric Auger
On 2/5/24 10:33, Cédric Le Goater wrote: > On 2/1/24 17:32, Eric Auger wrote: >> Currently the default input range can extend to 64 bits. On x86, >> when the virtio-iommu protects vfio devices, the physical iommu >> may support only 39 bits. Let's set the default to 39, as done >> for the intel-

Re: [PATCH] iotests: give tempdir an identifying name

2024-02-05 Thread Michael Tokarev
05.02.2024 18:51, Daniel P. Berrangé wrote: If something goes wrong causing the iotests not to cleanup their temporary directory, it is useful if the dir had an identifying name to show what is to blame. Signed-off-by: Daniel P. Berrangé Revieved-by: Michael Tokarev Thank you again for the

Re: [PATCH v8 1/5] ebpf: Added eBPF map update through mmap.

2024-02-05 Thread Andrew Melnichenko
Hi all, I'll revert the license changes and leave SPDX ids only for new files. On Tue, Jan 30, 2024 at 12:38 PM Daniel P. Berrangé wrote: > > On Thu, Jan 25, 2024 at 03:06:50PM +0200, Andrew Melnychenko wrote: > > Changed eBPF map updates through mmaped array. > > Mmaped arrays provide direct acc

  1   2   3   >