[PATCH v2 0/2] support unaligned access for some xHCI registers

2024-02-01 Thread Tomoyuki HIROSE
v1 -> v2: * Improved the calculation of addresses and masks in memory.c. According to xHCI spec rev 1.2, unaligned access to xHCI Host Controller Capability Registers are not prohibited. But current implementation does not support unaligned access to 'MemoryRegion'. These patches contain 2 changes

[PATCH v2 1/2] system/memory.c: support unaligned access

2024-02-01 Thread Tomoyuki HIROSE
The previous code ignored 'impl.unaligned' and handled unaligned accesses as is. But this implementation cannot emulate specific registers of some devices that allow unaligned access such as xHCI Host Controller Capability Registers. This commit checks 'impl.unaligned' and if it is false, QEMU emul

[PATCH v2 2/2] hw/usb/hcd-xhci.c: allow unaligned access to Capability Registers

2024-02-01 Thread Tomoyuki HIROSE
According to xHCI spec rev 1.2, unaligned access to xHCI Host Controller Capability Registers is not prohibited. In Addition, the limit of access size is also unspecified. Actually, some real devices allow unaligned access and 8-byte access to these registers. This commit makes it possible to unali

[PATCH 2/4] hw/isa/pc87312: Consolidate the use of device_class_set_parent_realize()

2024-02-01 Thread Zhao Liu
From: Zhao Liu Use device_class_set_parent_realize() to set parent realize() directly. Signed-off-by: Zhao Liu --- hw/isa/pc87312.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/isa/pc87312.c b/hw/isa/pc87312.c index ee23f3e164df..64dd17b537f2 100644 --- a/hw/isa/p

[PATCH 0/4] Consolidate the use of device_class_set_parent_realize()

2024-02-01 Thread Zhao Liu
From: Zhao Liu Hi list, Now we already have the device_class_set_parent_realize() to set parent realize(), thus clean up the places where that helper was forgotten. Regards, Zhao --- Zhao Liu (4): hw/isa/vt82c686: Consolidate the use of device_class_set_parent_realize() hw/isa/pc87312:

[PATCH 3/4] hw/intc/s390_flic: Consolidate the use of device_class_set_parent_realize()

2024-02-01 Thread Zhao Liu
From: Zhao Liu Use device_class_set_parent_realize() to set parent realize() directly. Signed-off-by: Zhao Liu --- hw/intc/s390_flic_kvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/intc/s390_flic_kvm.c b/hw/intc/s390_flic_kvm.c index 4d5cbb2a2fb6..baaa30dcb734

[PATCH 1/4] hw/isa/vt82c686: Consolidate the use of device_class_set_parent_realize()

2024-02-01 Thread Zhao Liu
From: Zhao Liu Use device_class_set_parent_realize() to set parent realize() directly. Signed-off-by: Zhao Liu --- hw/isa/vt82c686.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index d3e0f6d01fb6..a99eae4f6333 100644 --- a/hw/is

[PATCH 4/4] hw/arm/smmuv3: Consolidate the use of device_class_set_parent_realize()

2024-02-01 Thread Zhao Liu
From: Zhao Liu Use device_class_set_parent_realize() to set parent realize() directly. Signed-off-by: Zhao Liu --- hw/arm/smmuv3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c index 68eeef3e1d4c..b3d8642a4990 100644 --- a/hw/arm/smmu

[PATCH] hw/ide: Add the possibility to disable the CompactFlash device in the build

2024-02-01 Thread Thomas Huth
For distros like downstream RHEL, it would be helpful to allow to disable the CompactFlash device. For making this possible, we need a separate Kconfig switch for this device, and the code should reside in a separate file. Signed-off-by: Thomas Huth --- hw/ide/qdev-ide.h | 41 ++

Re: [PATCH 4/4] hw/arm/smmuv3: Consolidate the use of device_class_set_parent_realize()

2024-02-01 Thread Thomas Huth
On 01/02/2024 09.40, Zhao Liu wrote: From: Zhao Liu Use device_class_set_parent_realize() to set parent realize() directly. Signed-off-by: Zhao Liu --- hw/arm/smmuv3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c index 68eeef3e1d

Re: [PATCH 3/4] hw/intc/s390_flic: Consolidate the use of device_class_set_parent_realize()

2024-02-01 Thread Thomas Huth
On 01/02/2024 09.40, Zhao Liu wrote: From: Zhao Liu Use device_class_set_parent_realize() to set parent realize() directly. Signed-off-by: Zhao Liu --- hw/intc/s390_flic_kvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/intc/s390_flic_kvm.c b/hw/intc/s390_fl

Re: [PATCH 2/4] hw/isa/pc87312: Consolidate the use of device_class_set_parent_realize()

2024-02-01 Thread Thomas Huth
On 01/02/2024 09.40, Zhao Liu wrote: From: Zhao Liu Use device_class_set_parent_realize() to set parent realize() directly. Signed-off-by: Zhao Liu --- hw/isa/pc87312.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/isa/pc87312.c b/hw/isa/pc87312.c index ee23f3e

Re: [PATCH 1/4] hw/isa/vt82c686: Consolidate the use of device_class_set_parent_realize()

2024-02-01 Thread Thomas Huth
On 01/02/2024 09.40, Zhao Liu wrote: From: Zhao Liu Use device_class_set_parent_realize() to set parent realize() directly. Signed-off-by: Zhao Liu --- hw/isa/vt82c686.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index d3e0

[PATCH v6] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2024-02-01 Thread Shaoqin Huang
The KVM_ARM_VCPU_PMU_V3_FILTER provides the ability to let the VMM decide which PMU events are provided to the guest. Add a new option `kvm-pmu-filter` as -cpu sub-option to set the PMU Event Filtering. Without the filter, all PMU events are exposed from host to guest by default. The usage of the n

Re: [PATCH v4 37/47] hw/net/lasi_i82596: Re-enable build

2024-02-01 Thread Thomas Huth
On 26/01/2024 18.25, David Woodhouse wrote: From: David Woodhouse When converting to the shiny build-system-du-jour, a typo prevented the last_i82596 driver from being built. Correct the config option name to re-enable the build. And include "sysemu/sysemu.h" so it actually builds. Fixes: b141

Re: [PATCH v8 00/21] Introduce smp.modules for x86 in QEMU

2024-02-01 Thread Daniel P . Berrangé
On Thu, Feb 01, 2024 at 10:57:32AM +0800, Zhao Liu wrote: > Hi Daniel, > > On Wed, Jan 31, 2024 at 10:28:42AM +, Daniel P. Berrangé wrote: > > Date: Wed, 31 Jan 2024 10:28:42 + > > From: "Daniel P. Berrangé" > > Subject: Re: [PATCH v8 00/21] Introduce smp.modules for x86 in QEMU > > > >

Re: [PATCH 03/14] migration/multifd: Drop MultiFDSendParams.quit, cleanup error paths

2024-02-01 Thread Peter Xu
On Wed, Jan 31, 2024 at 12:05:08PM -0300, Fabiano Rosas wrote: > pet...@redhat.com writes: > > > From: Peter Xu > > > > Multifd send side has two fields to indicate error quits: > > > > - MultiFDSendParams.quit > > - &multifd_send_state->exiting > > > > Merge them into the global one. The re

Re: [PULL 11/33] scsi: only access SCSIDevice->requests from one thread

2024-02-01 Thread Hanna Czenczek
On 31.01.24 11:17, Kevin Wolf wrote: Am 29.01.2024 um 17:30 hat Hanna Czenczek geschrieben: I don’t like using drain as a form of lock specifically against AioContext changes, but maybe Stefan is right, and we should use it in this specific case to get just the single problem fixed.  (Though it’

Re: [PATCH 04/14] migration/multifd: Postpone reset of MultiFDPages_t

2024-02-01 Thread Peter Xu
On Wed, Jan 31, 2024 at 12:27:51PM -0300, Fabiano Rosas wrote: > > +/* Reset a MultiFDPages_t* object for the next use */ > > +static void multifd_pages_reset(MultiFDPages_t *pages) > > +{ > > +/* > > + * We don't need to touch offset[] array, because it will be > > + * overwritten late

Re: [PATCH 12/14] migration/multifd: multifd_send_prepare_header()

2024-02-01 Thread Peter Xu
On Wed, Jan 31, 2024 at 06:32:54PM -0300, Fabiano Rosas wrote: > > +if (!use_zero_copy_send) { > > +/* > > + * Only !zero_copy needs the header in IOV; zerocopy will > > + * send it separately. > > Could use the same spelling for both men

Re: Re: why various devices are loading x86 roms on non-x86 architectures?

2024-02-01 Thread Gerd Hoffmann
Hi, > There are also some PPC machines that have BIOS emulator in firmware and > would need the ROM to init the device but these have problems with QEMU's > gcc compiled ROMs that contain i386 opcodes and can't run these. That used to be standard practice in linux. Before we got kernel mode se

Re: [PATCH 1/6] vdpa: check for iova tree initialized at net_client_start

2024-02-01 Thread Eugenio Perez Martin
On Wed, Jan 31, 2024 at 11:07 AM Si-Wei Liu wrote: > > Hi Eugenio, > > Maybe there's some patch missing, but I saw this core dump when x-svq=on > is specified while waiting for the incoming migration on destination host: > > (gdb) bt > #0 0x5643b24cc13c in vhost_iova_tree_map_alloc (tree=0x0,

Re: [PATCH 13/14] migration/multifd: Move header prepare/fill into send_prepare()

2024-02-01 Thread Peter Xu
On Wed, Jan 31, 2024 at 06:42:57PM -0300, Fabiano Rosas wrote: > pet...@redhat.com writes: > > > From: Peter Xu > > > > This patch redefines the interfacing of ->send_prepare(). It further > > simplifies multifd_send_thread() especially on zero copy. > > > > Now with the new interface, we requir

Re: [PULL 11/33] scsi: only access SCSIDevice->requests from one thread

2024-02-01 Thread Kevin Wolf
Am 01.02.2024 um 10:43 hat Hanna Czenczek geschrieben: > On 31.01.24 11:17, Kevin Wolf wrote: > > Am 29.01.2024 um 17:30 hat Hanna Czenczek geschrieben: > > > I don’t like using drain as a form of lock specifically against AioContext > > > changes, but maybe Stefan is right, and we should use it in

Re: [PATCH v4 33/47] hw/m68k/q800: use qemu_find_nic_info()

2024-02-01 Thread Thomas Huth
On 31/01/2024 15.18, David Woodhouse wrote: On Wed, 2024-01-31 at 13:18 +0100, Thomas Huth wrote: @@ -386,14 +382,21 @@ static void q800_machine_init(MachineState *machine)     * 08:00:07 Apple     * (Q800 use the last one)     */ -    nd_table[0].macaddr.a[0] = 0x08; -    nd_ta

[PATCH v2 1/3] Hexagon (target/hexagon) Analyze reads before writes

2024-02-01 Thread Taylor Simpson
We divide gen_analyze_funcs.py into 3 phases Declare the operands Analyze the register reads Analyze the register writes We also create special versions of ctx_log_*_read for new operands Check that the operand is written before the read This is a precursor to improving the analys

[PATCH v2 0/3] Hexagon (target/hexagon) Enable more short-circuit packets

2024-02-01 Thread Taylor Simpson
This patch series improves the set of packets that can short-circuit the commit packet logic and write the results directly during the execution of each instruction in the packet. The key observation is that checking for overlap between register reads and writes is different from read-after-write.

[PATCH v2 2/3] Hexagon (target/hexagon) Enable more short-circuit packets (scalar core)

2024-02-01 Thread Taylor Simpson
Look for read-after-write instead of overlap of reads and writes Here is an example with overalp but no read-after-write: 0x000200fc: 0x38103876 { R0 = add(R0,R1); R6 = add(R6,R7) } BEFORE: 000200fc mov_i32 loc2,$0x0 mov_i32 loc2,r0 add_i32 loc3,loc2,r1 mov_i32 loc2,loc3

[PATCH v2 3/3] Hexagon (target/hexagon) Enable more short-circuit packets (HVX)

2024-02-01 Thread Taylor Simpson
Look for read-after-write instead of overlap of reads and writes HVX instructions with helpers have pass-by-reference semantics, so we check for overlaps of reads and writes within the same instruction. Signed-off-by: Taylor Simpson --- target/hexagon/translate.h | 88 +

Re: [PULL 11/33] scsi: only access SCSIDevice->requests from one thread

2024-02-01 Thread Hanna Czenczek
On 01.02.24 11:21, Kevin Wolf wrote: Am 01.02.2024 um 10:43 hat Hanna Czenczek geschrieben: On 31.01.24 11:17, Kevin Wolf wrote: Am 29.01.2024 um 17:30 hat Hanna Czenczek geschrieben: I don’t like using drain as a form of lock specifically against AioContext changes, but maybe Stefan is right,

Re: [PATCH 07/14] migration/multifd: Simplify locking in sender thread

2024-02-01 Thread Peter Xu
On Wed, Jan 31, 2024 at 05:21:06PM -0300, Fabiano Rosas wrote: > pet...@redhat.com writes: > > > From: Peter Xu > > > > The sender thread will yield the p->mutex before IO starts, trying to not > > block the requester thread. This may be unnecessary lock optimizations, > > because the requester

Re: [PATCH 09/88] esp: update TC check logic in do_dma_pdma_cb() to check for TC == 0

2024-02-01 Thread Paolo Bonzini
On Fri, Jan 12, 2024 at 1:55 PM Mark Cave-Ayland wrote: > > Invert the logic so that the end of DMA transfer check becomes one that checks > for TC == 0 in the from device path in do_dma_pdma_cb(). > > Signed-off-by: Mark Cave-Ayland > --- > hw/scsi/esp.c | 24 +++- > 1 file

RE: FW: [PATCH] vhost-user: add VIRTIO_F_IN_ORDER and VIRTIO_F_NOTIFICATION_DATA feature

2024-02-01 Thread Wentao Jia
Hi, Eugenio Thanks for you comments It is a dilemma, our team mainly work on smartNIC vDPA, features implementation in the QEMU emulated devices is a certain workload for us. I have a proposal, clear these features except vhost, it will not affect emulated devices, do you agree the change? par

Re: [PULL 0/5] Block patches

2024-02-01 Thread Peter Maydell
On Tue, 30 Jan 2024 at 21:51, Stefan Hajnoczi wrote: > > The following changes since commit 11be70677c70fdccd452a3233653949b79e97908: > > Merge tag 'pull-vfio-20240129' of https://github.com/legoater/qemu into > staging (2024-01-29 10:53:56 +) > > are available in the Git repository at: > >

Re: [PULL 00/21] Trivial patches for 2024-01-31

2024-02-01 Thread Peter Maydell
On Wed, 31 Jan 2024 at 11:57, Michael Tokarev wrote: > > The following changes since commit 11be70677c70fdccd452a3233653949b79e97908: > > Merge tag 'pull-vfio-20240129' of https://github.com/legoater/qemu into > staging (2024-01-29 10:53:56 +) > > are available in the Git repository at: > >

Re: [PATCH v2] block/blkio: Make s->mem_region_alignment be 64 bits

2024-02-01 Thread Michael Tokarev
30.01.2024 15:20, Richard W.M. Jones : With GCC 14 the code failed to compile on i686 (and was wrong for any version of GCC): ../block/blkio.c: In function ‘blkio_file_open’: ../block/blkio.c:857:28: error: passing argument 3 of ‘blkio_get_uint64’ from incompatible pointer type [-Wincompatible-

Re: [PATCH 09/88] esp: update TC check logic in do_dma_pdma_cb() to check for TC == 0

2024-02-01 Thread Mark Cave-Ayland
On 01/02/2024 10:46, Paolo Bonzini wrote: On Fri, Jan 12, 2024 at 1:55 PM Mark Cave-Ayland wrote: Invert the logic so that the end of DMA transfer check becomes one that checks for TC == 0 in the from device path in do_dma_pdma_cb(). Signed-off-by: Mark Cave-Ayland --- hw/scsi/esp.c | 24

Re: [PATCH 09/88] esp: update TC check logic in do_dma_pdma_cb() to check for TC == 0

2024-02-01 Thread Paolo Bonzini
Il gio 1 feb 2024, 12:25 Mark Cave-Ayland ha scritto: > On 01/02/2024 10:46, Paolo Bonzini wrote: > > > On Fri, Jan 12, 2024 at 1:55 PM Mark Cave-Ayland > > wrote: > >> > >> Invert the logic so that the end of DMA transfer check becomes one that > checks > >> for TC == 0 in the from device path

Re: [PATCH] pflash: fix sectors vs bytes confusion in blk_pread_nonzeroes()

2024-02-01 Thread Michael Tokarev
30.01.2024 03:27, Stefan Hajnoczi wrote: The following expression is incorrect because blk_pread_nonzeroes() deals in units of bytes, not sectors: bytes = MIN(size - offset, BDRV_REQUEST_MAX_SECTORS) ^^^ BDRV_REQUEST_MAX_BYTES is the appropr

Re: [PATCH] kconfig: use "select" to enable semihosting

2024-02-01 Thread Alex Bennée
Paolo Bonzini writes: > Just like all other dependencies, these can be expressed in Kconfig > files rather than in the default configurations. Queued to semihosting/next, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 0/3] gdbstub: Implement follow-fork-mode child

2024-02-01 Thread Alex Bennée
Ilya Leoshkevich writes: > Based-on: <20240116094411.216665-1-...@linux.ibm.com> > > Hi, > > I needed to debug a linux-user crash between fork() and exec() [1] and > realized that gdbstub does not allow this. This series lifts this > restriction (one still cannot debug past exec() though). Patch

Re: FW: [PATCH] vhost-user: add VIRTIO_F_IN_ORDER and VIRTIO_F_NOTIFICATION_DATA feature

2024-02-01 Thread Eugenio Perez Martin
On Thu, Feb 1, 2024 at 11:48 AM Wentao Jia wrote: > > Hi, Eugenio > > Thanks for you comments > > It is a dilemma, our team mainly work on smartNIC vDPA, features > implementation in the QEMU emulated devices is a certain workload for us. That's understandable. > I have a proposal, clear these

Re: [PATCH 1/3] gdbstub: Refactor fork() handling

2024-02-01 Thread Alex Bennée
Ilya Leoshkevich writes: > Prepare for implementing follow-fork-mode child: > * Introduce gdbserver_fork_start(), which for now is a no-op. > * Rename gdbserver_fork() to gdbserver_fork_end(), call it in both > parent and child processes, and pass the fork()'s return value to it. > * Factor out

Re: building qemu on a system with libxkbcommon installed but not xkeyboard-config produces an core dump

2024-02-01 Thread Michael Tokarev
31.01.2024 11:13, Zhang Wen: With this patch, qemu requires keyboard-config when libxkbcommon is found on the system. So if the qemu is configured when libxkbcommon is installed but not keyboard-config, the configure stage will produce an error message, thus avoid coredump in the build stage. I

Re: [PATCH 2/3] gdbstub: Implement follow-fork-mode child

2024-02-01 Thread Alex Bennée
Ilya Leoshkevich writes: > Currently it's not possible to use gdbstub for debugging linux-user > code that runs in a forked child, which is normally done using the `set > follow-fork-mode child` GDB command. Purely on the protocol level, the > missing piece is the fork-events feature. > > However

Re: [PATCH v3 00/21] plugin updates (register access) for 9.0 (pre-PR?)

2024-02-01 Thread Alex Bennée
Alex Bennée writes: > Akihiko requested the register support not be merged in its current > state so it's time for another round of review. I've made a few tweaks > to simplify the register and CPU tracking code in execlog and removed > some stale API functions. However from my point of view its

[PATCH 5/5] kconfig: use "select" to enable semihosting

2024-02-01 Thread Alex Bennée
From: Paolo Bonzini Just like all other dependencies, these can be expressed in Kconfig files rather than in the default configurations. Signed-off-by: Paolo Bonzini Acked-by: Alistair Francis Message-Id: <20240129115809.1039924-1-pbonz...@redhat.com> Signed-off-by: Alex Bennée --- configs/d

[PATCH 1/5] tests/docker: Add sqlite3 module to openSUSE Leap container

2024-02-01 Thread Alex Bennée
From: Fabiano Rosas Avocado needs sqlite3: Failed to load plugin from module "avocado.plugins.journal": ImportError("Module 'sqlite3' is not installed. Use: sudo zypper install python311 to install it") >From 'zypper info python311': "This package supplies rich command line features pro

[PATCH 0/5] maintainer updates for 9.0 (docker, plugin tests, deprecation, elf, semihosting)

2024-02-01 Thread Alex Bennée
A fairly random collection of fixes in this tree. I've still got a report of openbsd rebuilding which is confusing me but I didn't want to hold up getting eyes on real fixes. The plugins register support may get added to the PR if it gets any review. The following need review: Revert "hw/elf_o

[PATCH 4/5] Revert "hw/elf_ops: Ignore loadable segments with zero size"

2024-02-01 Thread Alex Bennée
This regressed qemu-system-xtensa: TESTtest_load_store on xtensa qemu-system-xtensa: Some ROM regions are overlapping These ROM regions might have been loaded by direct user request or by default. They could be BIOS/firmware images, a guest kernel, initrd or some other file loaded i

[PATCH 2/5] docs: mark CRIS support as deprecated

2024-02-01 Thread Alex Bennée
This might be premature but while streamling the avocado tests I realised the only tests we have are "check-tcg" ones. The aging fedora-criss-cross image works well enough for developers but can't be used in CI as we need supported build platforms to build QEMU. Does this mean the writing is on th

[PATCH 3/5] configure: run plugin TCG tests again

2024-02-01 Thread Alex Bennée
From: Paolo Bonzini Commit 39fb3cfc28b ("configure: clean up plugin option handling", 2023-10-18) dropped the CONFIG_PLUGIN line from tests/tcg/config-host.mak, due to confusion caused by the shadowing of $config_host_mak. However, TCG tests were still expecting it. Oops. Put it back, in the m

Re: [PATCH] hw/ide: Add the possibility to disable the CompactFlash device in the build

2024-02-01 Thread BALATON Zoltan
On Thu, 1 Feb 2024, Thomas Huth wrote: For distros like downstream RHEL, it would be helpful to allow to disable the CompactFlash device. For making this possible, we need a separate Kconfig switch for this device, and the code should reside in a separate file. Signed-off-by: Thomas Huth --- hw

Re: [PATCH 5/5] kconfig: use "select" to enable semihosting

2024-02-01 Thread Thomas Huth
On 01/02/2024 13.28, Alex Bennée wrote: From: Paolo Bonzini Just like all other dependencies, these can be expressed in Kconfig files rather than in the default configurations. Signed-off-by: Paolo Bonzini Acked-by: Alistair Francis Message-Id: <20240129115809.1039924-1-pbonz...@redhat.com>

Re: [PATCH 2/5] docs: mark CRIS support as deprecated

2024-02-01 Thread Thomas Huth
On 01/02/2024 13.28, Alex Bennée wrote: This might be premature but while streamling the avocado tests I s/streamling/streamlining/ ? realised the only tests we have are "check-tcg" ones. The aging fedora-criss-cross image works well enough for developers but can't be s/criss/cris/ used i

Re: building qemu on a system with libxkbcommon installed but not xkeyboard-config produces an core dump

2024-02-01 Thread Michael Tokarev
01.02.2024 15:11, Michael Tokarev wrote: 31.01.2024 11:13, Zhang Wen: With this patch, qemu requires keyboard-config when libxkbcommon is found on the system. So if the qemu is configured when libxkbcommon is installed but not keyboard-config, the configure stage will produce an error message, t

Re: [PATCH] hw/ide: Add the possibility to disable the CompactFlash device in the build

2024-02-01 Thread Thomas Huth
On 01/02/2024 13.39, BALATON Zoltan wrote: On Thu, 1 Feb 2024, Thomas Huth wrote: For distros like downstream RHEL, it would be helpful to allow to disable the CompactFlash device. For making this possible, we need a separate Kconfig switch for this device, and the code should reside in a separa

Re: [PATCH 4/5] Revert "hw/elf_ops: Ignore loadable segments with zero size"

2024-02-01 Thread Thomas Huth
On 01/02/2024 13.28, Alex Bennée wrote: This regressed qemu-system-xtensa: TESTtest_load_store on xtensa qemu-system-xtensa: Some ROM regions are overlapping These ROM regions might have been loaded by direct user request or by default. They could be BIOS/firmware images, a gu

Re: [PATCH] hw/ide: Add the possibility to disable the CompactFlash device in the build

2024-02-01 Thread BALATON Zoltan
On Thu, 1 Feb 2024, Thomas Huth wrote: On 01/02/2024 13.39, BALATON Zoltan wrote: On Thu, 1 Feb 2024, Thomas Huth wrote: For distros like downstream RHEL, it would be helpful to allow to disable the CompactFlash device. For making this possible, we need a separate Kconfig switch for this device

Re: [PATCH 00/14] migration/multifd: Refactor ->send_prepare() and cleanups

2024-02-01 Thread Avihai Horon
On 01/02/2024 7:47, Peter Xu wrote: External email: Use caution opening links or attachments On Wed, Jan 31, 2024 at 07:49:51PM -0300, Fabiano Rosas wrote: pet...@redhat.com writes: From: Peter Xu This patchset contains quite a few refactorings to current multifd: - It picked up some

Re: building qemu on a system with libxkbcommon installed but not xkeyboard-config produces an core dump

2024-02-01 Thread Peter Maydell
On Thu, 1 Feb 2024 at 12:50, Michael Tokarev wrote: > > 01.02.2024 15:11, Michael Tokarev wrote: > > 31.01.2024 11:13, Zhang Wen: > >> With this patch, qemu requires keyboard-config when libxkbcommon is found > >> on the system. So if the qemu is configured when libxkbcommon is installed > >> but

Re: FW: [PATCH] vhost-user: add VIRTIO_F_IN_ORDER and VIRTIO_F_NOTIFICATION_DATA feature

2024-02-01 Thread Michael S. Tsirkin
On Thu, Feb 01, 2024 at 10:47:56AM +, Wentao Jia wrote: > Hi, Eugenio > > Thanks for you comments > > It is a dilemma, our team mainly work on smartNIC vDPA, features > implementation in the QEMU emulated devices is a certain workload for > us. In this case the implementation is mostly trivi

Re: building qemu on a system with libxkbcommon installed but not xkeyboard-config produces an core dump

2024-02-01 Thread Michael Tokarev
01.02.2024 15:57, Peter Maydell пишет: On Thu, 1 Feb 2024 at 12:50, Michael Tokarev wrote: 01.02.2024 15:11, Michael Tokarev wrote: 31.01.2024 11:13, Zhang Wen: With this patch, qemu requires keyboard-config when libxkbcommon is found on the system. So if the qemu is configured when libxkbc

Re: [PATCH 4/5] Revert "hw/elf_ops: Ignore loadable segments with zero size"

2024-02-01 Thread Peter Maydell
On Thu, 1 Feb 2024 at 12:30, Alex Bennée wrote: > > This regressed qemu-system-xtensa: > > TESTtest_load_store on xtensa > qemu-system-xtensa: Some ROM regions are overlapping > These ROM regions might have been loaded by direct user request or by > default. > They could be BIOS/fir

Crash with CXL + TCG on 8.2: Was Re: qemu cxl memory expander shows numa_node -1

2024-02-01 Thread Jonathan Cameron via
On Tue, 30 Jan 2024 13:50:18 +0530 Sajjan Rao wrote: > Hi Jonathan, > > The QEMU command line in the original email has been corrected back in > August 2023 based on the subsequent responses. > > My current QEMU command line reads like below. As you can see I am not > assigning numa to the CXL

Re: Crash with CXL + TCG on 8.2: Was Re: qemu cxl memory expander shows numa_node -1

2024-02-01 Thread Peter Maydell
On Thu, 1 Feb 2024 at 13:04, Jonathan Cameron via wrote: > > root@localhost:~/devmem2# numactl --membind=1 touch a > qemu: fatal: cpu_io_recompile: could not find TB for pc=(nil) Can you run QEMU under gdb and give the backtrace when it stops on the abort() ? That will probably have a helpful

Re: [PATCH 0/5] buses: switch to 3-phase-reset

2024-02-01 Thread Peter Maydell
On Fri, 19 Jan 2024 at 16:35, Peter Maydell wrote: > This patchset switches the handful of bus types that implement a > reset method over to using the 3-phase-reset APIs, and then removes > the transitional infrastructure from the core bus class that was > supporting the ability to have bus types

Re: [External] Re: [PATCH 0/5] migration/multifd: Prerequisite cleanups for ongoing work

2024-02-01 Thread Fabiano Rosas
Hao Xiang writes: > On Wed, Jan 31, 2024 at 5:19 AM Fabiano Rosas wrote: >> >> Peter Xu writes: >> >> > On Mon, Jan 29, 2024 at 09:51:06AM -0300, Fabiano Rosas wrote: >> >> Peter Xu writes: >> >> >> >> > On Mon, Jan 29, 2024 at 01:41:01AM +, Liu, Yuan1 wrote: >> >> >> Because this change h

Re: [PATCH 03/14] migration/multifd: Drop MultiFDSendParams.quit, cleanup error paths

2024-02-01 Thread Fabiano Rosas
Peter Xu writes: > On Wed, Jan 31, 2024 at 12:05:08PM -0300, Fabiano Rosas wrote: >> pet...@redhat.com writes: >> >> > From: Peter Xu >> > >> > Multifd send side has two fields to indicate error quits: >> > >> > - MultiFDSendParams.quit >> > - &multifd_send_state->exiting >> > >> > Merge th

Re: [PATCH 5/5] hw/core: Remove transitional infrastructure from BusClass

2024-02-01 Thread Peter Maydell
On Wed, 31 Jan 2024 at 03:44, Zhao Liu wrote: > > On Fri, Jan 19, 2024 at 04:35:12PM +, Peter Maydell wrote: > > Date: Fri, 19 Jan 2024 16:35:12 + > > From: Peter Maydell > > Subject: [PATCH 5/5] hw/core: Remove transitional infrastructure from > > BusClass > > X-Mailer: git-send-email 2

Re: [PATCH] hw/pci-host/raven.c: Mark raven_io_ops as implementing unaligned accesses

2024-02-01 Thread Peter Maydell
On Tue, 23 Jan 2024 at 11:03, Cédric Le Goater wrote: > > On 1/12/24 14:46, Peter Maydell wrote: > > The raven_io_ops MemoryRegionOps is the only one in the source tree > > which sets .valid.unaligned to indicate that it should support > > unaligned accesses and which does not also set .impl.unali

Re: [PATCH v2 0/3] virt: wire up NS EL2 virtual timer IRQ

2024-02-01 Thread Peter Maydell
Ping for code review, please? thanks -- PMM On Mon, 22 Jan 2024 at 14:35, Peter Maydell wrote: > > This patchset wires up the NS EL2 virtual timer IRQ on the virt > board, similarly to what commit 058262e0a8b2 did for the sbsa-ref board. > > Version 1 was an RFC patchset, originally sent back in

Re: [PATCH 0/2] system: Fix handling of '-serial none -serial something'

2024-02-01 Thread Peter Maydell
On Mon, 22 Jan 2024 at 16:36, Peter Maydell wrote: > > (This patchset fixes a bug reported by Bohdan Kostiv at > https://lore.kernel.org/qemu-devel/caa3sv1lq8ydunlcb5wqlvzjshffru0usbl_yyjw_m+db2ph...@mail.gmail.com/ > -- my patch 1 avoids a bug in his suggested change, and > patch 2 is new, impro

Re: [PATCH] hw/pci-host/raven.c: Mark raven_io_ops as implementing unaligned accesses

2024-02-01 Thread Cédric Le Goater
On 2/1/24 14:32, Peter Maydell wrote: On Tue, 23 Jan 2024 at 11:03, Cédric Le Goater wrote: On 1/12/24 14:46, Peter Maydell wrote: The raven_io_ops MemoryRegionOps is the only one in the source tree which sets .valid.unaligned to indicate that it should support unaligned accesses and which do

Re: [PATCH v4] doc/sphinx/hxtool.py: add optional label argument to SRST directive

2024-02-01 Thread Peter Maydell
On Tue, 30 Jan 2024 at 19:04, David Woodhouse wrote: > > From: David Woodhouse > > We can't just embed labels directly into files like qemu-options.hx which > are included from multiple top-level rST files, because Sphinx sees the > labels as duplicate: https://github.com/sphinx-doc/sphinx/issues

[PATCH v6 6/6] target/riscv: Enable updates for pointer masking variables and thus enable pointer masking extension

2024-02-01 Thread Alexey Baturo
From: Alexey Baturo Signed-off-by: Alexey Baturo Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 9 + 1 file changed, 9 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index ded84f2e09..23d1692b59 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -

Re: Crash with CXL + TCG on 8.2: Was Re: qemu cxl memory expander shows numa_node -1

2024-02-01 Thread Jonathan Cameron via
On Thu, 1 Feb 2024 13:12:23 + Peter Maydell wrote: > On Thu, 1 Feb 2024 at 13:04, Jonathan Cameron via > wrote: > > > > > > > > root@localhost:~/devmem2# numactl --membind=1 touch a > > qemu: fatal: cpu_io_recompile: could not find TB for pc=(nil) > > Can you run QEMU under gdb and

[PATCH v6 2/6] target/riscv: Add new CSR fields for S{sn, mn, m}pm extensions as part of Zjpm v0.8

2024-02-01 Thread Alexey Baturo
From: Alexey Baturo Signed-off-by: Alexey Baturo Reviewed-by: Alistair Francis --- target/riscv/cpu.h | 8 target/riscv/cpu_bits.h | 3 +++ target/riscv/cpu_cfg.h | 3 +++ target/riscv/csr.c | 11 +++ target/riscv/machine.c | 10 +++--- target/riscv/pmp.c

[PATCH v6 4/6] target/riscv: Add pointer masking tb flags

2024-02-01 Thread Alexey Baturo
From: Alexey Baturo Signed-off-by: Alexey Baturo Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/cpu.h| 3 +++ target/riscv/cpu_helper.c | 3 +++ target/riscv/translate.c | 5 + 3 files changed, 11 insertions(+) diff --git a/target/riscv/cpu.h b/ta

Re: [PATCH v3 0/9] hw/arm: Check for CPU types in machine_run_board_init()

2024-02-01 Thread Peter Maydell
On Mon, 29 Jan 2024 at 15:18, Philippe Mathieu-Daudé wrote: > > Series fully reviewed. > > Since v2: > - Rebased > - Remove default_cpu_type (Richard) > - Added R-b tags > > Since v1: > - Add missing QOM parent for CPU cores > - Dropped Aspeed changes (Cédric) > > Following Gavin recent CPU type e

[PATCH v6 3/6] target/riscv: Add helper functions to calculate current number of masked bits for pointer masking

2024-02-01 Thread Alexey Baturo
From: Alexey Baturo Signed-off-by: Alexey Baturo Reviewed-by: Alistair Francis --- target/riscv/cpu.h| 4 +++ target/riscv/cpu_helper.c | 58 +++ 2 files changed, 62 insertions(+) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index e03ff300

[PATCH v6 0/6] Pointer Masking update for Zjpm v0.8

2024-02-01 Thread Alexey Baturo
From: Alexey Baturo Hi, This patch series is rebased on https://github.com/alistair23/qemu/tree/riscv-to-apply.next Thanks [v5]: This patch series targets Zjpm v0.8 extension. The spec itself could be found here: https://github.com/riscv/riscv-j-extension/blob/8088461d8d66a7676872b61c908cbe

[PATCH v6 5/6] target/riscv: Update address modify functions to take into account pointer masking

2024-02-01 Thread Alexey Baturo
From: Alexey Baturo Signed-off-by: Alexey Baturo Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/translate.c | 22 -- target/riscv/vector_helper.c | 13 + 2 files changed, 29 insertions(+), 6 deletions(-) diff --git a/target/

[PATCH v6 1/6] target/riscv: Remove obsolete pointer masking extension code.

2024-02-01 Thread Alexey Baturo
From: Alexey Baturo Zjpm v0.8 is almost frozen and it's much simplier compared to the existing one: The newer version doesn't allow to specify custom mask or base for masking. Instead it allows only certain options for masking top bits. Signed-off-by: Alexey Baturo Acked-by: Alistair Francis

Re: [PULL 11/33] scsi: only access SCSIDevice->requests from one thread

2024-02-01 Thread Hanna Czenczek
On 31.01.24 21:35, Stefan Hajnoczi wrote: On Fri, Jan 26, 2024 at 04:24:49PM +0100, Hanna Czenczek wrote: On 26.01.24 14:18, Kevin Wolf wrote: Am 25.01.2024 um 18:32 hat Hanna Czenczek geschrieben: On 23.01.24 18:10, Kevin Wolf wrote: Am 23.01.2024 um 17:40 hat Hanna Czenczek geschrieben: On

[PULL 02/17] hw/arm/aspeed: Remove dead code

2024-02-01 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé Remove copy/paste typo from commit 6c323aba40 ("hw/arm/aspeed: Adding new machine Tiogapass in QEMU"). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Reviewed-by: Richard Henderson Reviewed-by: Gavin Shan Signed-off-by: Cédric Le Goater ---

[PULL 01/17] tests/avocado/machine_aspeed.py: Update buildroot images to 2023.11

2024-02-01 Thread Cédric Le Goater
Compared to mainline buildroot, these images have some customization : - Linux version is bumped to 6.6.3 and built with a custom config - U-Boot is switched to the one provided by OpenBMC for more support - defconfigs extra tools for dev See branch [1] for more details. There are a few changes

[PULL 04/17] hw/arm/aspeed: Init CPU defaults in a common helper

2024-02-01 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé Rework aspeed_soc_num_cpus() as a new init_cpus_defaults() helper to reduce code duplication. Reviewed-by: Cédric Le Goater Reviewed-by: Richard Henderson Reviewed-by: Gavin Shan Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Cédric Le Goater --- hw/arm/a

[PULL 08/17] hw/fsi: Introduce IBM's scratchpad device

2024-02-01 Thread Cédric Le Goater
From: Ninad Palsule This is a part of patchset where IBM's Flexible Service Interface is introduced. The scratchpad provides a set of non-functional registers. The firmware is free to use them, hardware does not support any special management support. The scratchpad registers can be read or writ

[PULL 03/17] hw/arm/aspeed: Set default CPU count using aspeed_soc_num_cpus()

2024-02-01 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé Since commit b7f1a0cb76 ("arm/aspeed: Compute the number of CPUs from the SoC definition") Aspeed machines use the aspeed_soc_num_cpus() helper to set the number of CPUs. Use it for the ast1030-evb (commit 356b230ed1 "aspeed/soc: Add AST1030 support") and supermicrox

[PULL 12/17] hw/fsi: Introduce IBM's FSI master

2024-02-01 Thread Cédric Le Goater
From: Ninad Palsule This is a part of patchset where IBM's Flexible Service Interface is introduced. This commit models the FSI master. CFAM is hanging out of FSI master which is a bus controller. The FSI master: A controller in the platform service processor (e.g. BMC) driving CFAM engine acc

[PULL 15/17] hw/fsi: Added qtest

2024-02-01 Thread Cédric Le Goater
From: Ninad Palsule Added basic qtests for FSI model. Signed-off-by: Ninad Palsule Acked-by: Thomas Huth [ clg: aspeed-fsi-test.c -> aspeed_fsi-test.c to match other filenames ] Signed-off-by: Cédric Le Goater --- tests/qtest/aspeed_fsi-test.c | 205 ++ tests/

[PULL 17/17] hw/fsi: Update MAINTAINER list

2024-02-01 Thread Cédric Le Goater
From: Ninad Palsule Add maintainer for IBM FSI model Signed-off-by: Ninad Palsule Reviewed-by: Cédric Le Goater [ clg: - slight change in commit log - fixed file list ] Signed-off-by: Cédric Le Goater --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAI

[PULL 05/17] hw/arm/aspeed: Introduce aspeed_soc_cpu_type() helper

2024-02-01 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé In order to alter AspeedSoCClass::cpu_type in the next commit, introduce the aspeed_soc_cpu_type() helper to retrieve the per-SoC CPU type from AspeedSoCClass. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Reviewed-by: Richard Henderson Revie

[PULL v2 00/17] aspeed queue

2024-02-01 Thread Cédric Le Goater
The following changes since commit bd2e12310b18b51aefbf834e6d54989fd175976f: Merge tag 'qga-pull-2024-01-30' of https://github.com/kostyanf14/qemu into staging (2024-01-30 15:53:46 +) are available in the Git repository at: https://github.com/legoater/qemu/ tags/pull-aspee

[PULL 09/17] hw/fsi: Introduce IBM's FSI Bus

2024-02-01 Thread Cédric Le Goater
From: Ninad Palsule This is a part of patchset where FSI bus is introduced. The FSI bus is a simple bus where FSI master is attached. Signed-off-by: Andrew Jeffery Signed-off-by: Ninad Palsule Reviewed-by: Cédric Le Goater [ clg: - removed include/hw/fsi/engine-scratchpad.h and hw/f

[PULL 13/17] hw/fsi: Aspeed APB2OPB & On-chip peripheral bus

2024-02-01 Thread Cédric Le Goater
From: Ninad Palsule This is a part of patchset where IBM's Flexible Service Interface is introduced. An APB-to-OPB bridge enabling access to the OPB from the ARM core in the AST2600. Hardware limitations prevent the OPB from being directly mapped into APB, so all accesses are indirect through th

[PULL 10/17] hw/fsi: Introduce IBM's fsi-slave model

2024-02-01 Thread Cédric Le Goater
From: Ninad Palsule This is a part of patchset where IBM's Flexible Service Interface is introduced. The FSI slave: The slave is the terminal point of the FSI bus for FSI symbols addressed to it. Slaves can be cascaded off of one another. The slave's configuration registers appear in address spa

[PULL 16/17] hw/fsi: Added FSI documentation

2024-02-01 Thread Cédric Le Goater
From: Ninad Palsule Documentation for IBM FSI model. Signed-off-by: Ninad Palsule Reviewed-by: Cédric Le Goater [ clg : - Removed source file list - Fixed aspeed machine reference ] Signed-off-by: Cédric Le Goater --- docs/specs/fsi.rst | 122 +++

[PULL 07/17] hw/fsi: Introduce IBM's Local bus

2024-02-01 Thread Cédric Le Goater
From: Ninad Palsule This is a part of patchset where IBM's Flexible Service Interface is introduced. The LBUS is modelled to maintain mapped memory for the devices. The memory is mapped after CFAM config, peek table and FSI slave registers. Signed-off-by: Andrew Jeffery Signed-off-by: Ninad Pa

  1   2   3   4   >