Re: [RFC PATCH v3 18/30] migration/multifd: Allow receiving pages without packets

2024-01-16 Thread Peter Xu
On Mon, Nov 27, 2023 at 05:26:00PM -0300, Fabiano Rosas wrote: > Currently multifd does not need to have knowledge of pages on the > receiving side because all the information needed is within the > packets that come in the stream. > > We're about to add support to fixed-ram migration, which canno

Re: [RFC PATCH v3 19/30] migration/ram: Ignore multifd flush when doing fixed-ram migration

2024-01-16 Thread Peter Xu
On Mon, Nov 27, 2023 at 05:26:01PM -0300, Fabiano Rosas wrote: > Some functionalities of multifd are incompatible with the 'fixed-ram' > migration format. > > The MULTIFD_FLUSH flag in particular is not used because in fixed-ram > there is no sinchronicity between migration source and destination

Re: [PATCH] coroutine-ucontext: Save fake stack for pooled coroutine

2024-01-16 Thread Marc-André Lureau
Hi On Mon, Jan 15, 2024 at 10:49 PM Stefan Hajnoczi wrote: > > On Fri, Jan 12, 2024 at 07:36:19PM +0900, Akihiko Odaki wrote: > > Coroutine may be pooled even after COROUTINE_TERMINATE if > > CONFIG_COROUTINE_POOL is enabled and fake stack should be saved in > > such a case to keep AddressSanitiz

[Qemu-arm] Windows11 guest Fast startup cannot work

2024-01-16 Thread yezengruan via
Hi, I want to improve the startup speed of Windows VM. On the x86 architecture, QEMU's Windows11 VM can enable the Fast startup function, but it cannot work on the ARM architecture. By the way, the Fast startup function of Windows on ARM physical machines can work normally. Is there anything

Re: [PATCH] target/i386/kvm: call kvm_put_vcpu_events() before kvm_put_nested_state()

2024-01-16 Thread Vitaly Kuznetsov
As I'm the addressee of the ping for some reason ... :-) the fix looks good to me but I'm not sure about all the consequences of moving kvm_put_vcpu_events() to an earlier stage. Max, Paolo, please take a look! Eiichi Tsukata writes: > Ping. > >> On Nov 8, 2023, at 10:12, Eiichi Tsukata wrote:

[PATCH v2 0/2] gdbstub: Implement catching syscalls

2024-01-16 Thread Ilya Leoshkevich
Based-on: <20240116003551.75168-1-...@linux.ibm.com> ([PATCH v3 0/3] linux-user: Allow gdbstub to ignore page protection) v1: https://lists.gnu.org/archive/html/qemu-devel/2024-01/msg02911.html v1 -> v2: Avoid touching the system gdbstub. Advertise QCatchSyscalls+ only on Linux. Hi, I

[PATCH v2 1/2] gdbstub: Implement catching syscalls

2024-01-16 Thread Ilya Leoshkevich
GDB supports stopping on syscall entry and exit using the "catch syscall" command. It relies on 3 packets, which are currently not supported by QEMU: * qSupported:QCatchSyscalls+ [1] * QCatchSyscalls: [2] * T05syscall_entry: and T05syscall_return: [3] Implement generation and handling of these pa

[PATCH v2 2/2] tests/tcg: Add the syscall catchpoint gdbstub test

2024-01-16 Thread Ilya Leoshkevich
Check that adding/removing syscall catchpoints works. Signed-off-by: Ilya Leoshkevich --- tests/tcg/multiarch/Makefile.target | 10 +++- tests/tcg/multiarch/catch-syscalls.c | 51 ++ tests/tcg/multiarch/gdbstub/catch-syscalls.py | 52 +++ 3 file

Re: [PATCH 5/5] qemu-options: Remove the deprecated -singlestep option

2024-01-16 Thread Philippe Mathieu-Daudé
On 16/1/24 07:27, Markus Armbruster wrote: Daniel P. Berrangé writes: On Mon, Jan 15, 2024 at 05:39:19PM +, Peter Maydell wrote: On Mon, 15 Jan 2024 at 13:54, Thomas Huth wrote: On 12/01/2024 16.39, Philippe Mathieu-Daudé wrote: Hi Thomas +Laurent & Peter On 12/1/24 11:00, Thomas Hu

Re: [PATCH v2] configure: Add linux header compile support for LoongArch

2024-01-16 Thread Philippe Mathieu-Daudé
On 16/1/24 02:39, Bibo Mao wrote: When compiling qemu with system KVM mode for LoongArch, header files in directory linux-headers/asm-loongarch should be used firstly. Otherwise it fails to find kvm.h on system with old glibc, since latest kernel header files are not installed. This patch adds l

Re: [PATCH 5/5] qemu-options: Remove the deprecated -singlestep option

2024-01-16 Thread Thomas Huth
On 16/01/2024 10.46, Philippe Mathieu-Daudé wrote: On 16/1/24 07:27, Markus Armbruster wrote: Daniel P. Berrangé writes: On Mon, Jan 15, 2024 at 05:39:19PM +, Peter Maydell wrote: On Mon, 15 Jan 2024 at 13:54, Thomas Huth wrote: On 12/01/2024 16.39, Philippe Mathieu-Daudé wrote: Hi T

Re: [PATCH v2 1/3] hw/arm: Add EHCI/OHCI controllers to Allwinner R40 and Bananapi board

2024-01-16 Thread Philippe Mathieu-Daudé
On 15/1/24 19:27, Guenter Roeck wrote: Allwinner R40 supports two USB host ports shared between a USB 2.0 EHCI host controller and a USB 1.1 OHCI host controller. Add support for both of them. If machine USB support is not enabled, create unimplemented devices for the USB memory ranges to avoid

Re: [PATCH v2 3/3] hw/arm: Add watchdog timer to Allwinner H40 and Bananapi board

2024-01-16 Thread Philippe Mathieu-Daudé
Hi, (Cc'ing Li, Strahinja and Niek) On 15/1/24 19:27, Guenter Roeck wrote: Add watchdog timer support to Allwinner-H40 and Bananapi. The watchdog timer is added as an overlay to the Timer module memory map. I'm confused by these registers from TYPE_AW_A10_PIT and the TYPE_AW_WDT implementatio

Re: [PATCH] qemu/osdep: Add huge page aligned support on LoongArch platform

2024-01-16 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: Re: [PATCH 1/3] hw/arm: Add EHCI/OHCI controllers to Allwinner R40 and Bananapi board

2024-01-16 Thread Gerd Hoffmann
On Mon, Jan 15, 2024 at 08:12:29AM -0800, Guenter Roeck wrote: > On 1/15/24 03:02, Philippe Mathieu-Daudé wrote: > > On 13/1/24 20:16, Guenter Roeck wrote: > > > If machine USB support is not enabled, create unimplemented devices > > > for the USB memory ranges to avoid crashes when booting Linux.

Re: [PATCH v15 0/9] rutabaga_gfx + gfxstream

2024-01-16 Thread Alyssa Ross
Hi Gurchetan, Gurchetan Singh writes: > - As mentioned in v14: > * AEMU: d6e6b99 "Delete VpxFrameParser.cpp" > * gfxstream: 2131f78d Merge "gfxstream: add egl & gles deps.." > > are the proposed v.0.1.2 release points. If those commits are sufficient > for packaging AEMU + gfxstream, le

[PULL 08/22] gdbstub: Use GDBFeature for gdb_register_coprocessor

2024-01-16 Thread Alex Bennée
From: Akihiko Odaki This is a tree-wide change to introduce GDBFeature parameter to gdb_register_coprocessor(). The new parameter just replaces num_regs and xml parameters for now. GDBFeature will be utilized to simplify XML lookup in a following change. Signed-off-by: Akihiko Odaki Acked-by: A

[PULL 01/22] hw/riscv: Use misa_mxl instead of misa_mxl_max

2024-01-16 Thread Alex Bennée
From: Akihiko Odaki The effective MXL value matters when booting. Signed-off-by: Akihiko Odaki Message-Id: <20240103173349.398526-23-alex.ben...@linaro.org> Message-Id: <20231213-riscv-v7-1-a760156a3...@daynix.com> Signed-off-by: Alex Bennée diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c inde

[PULL 05/22] target/arm: Use GDBFeature for dynamic XML

2024-01-16 Thread Alex Bennée
From: Akihiko Odaki In preparation for a change to use GDBFeature as a parameter of gdb_register_coprocessor(), convert the internal representation of dynamic feature from plain XML to GDBFeature. Signed-off-by: Akihiko Odaki Acked-by: Richard Henderson Message-Id: <20240103173349.398526-27-al

[PULL 03/22] target/riscv: Move misa_mxl_max to class

2024-01-16 Thread Alex Bennée
From: Akihiko Odaki misa_mxl_max is common for all instances of a RISC-V CPU class so they are better put into class. Signed-off-by: Akihiko Odaki Message-Id: <20240103173349.398526-25-alex.ben...@linaro.org> Message-Id: <20231213-riscv-v7-3-a760156a3...@daynix.com> [AJB: fixed merge conflicts]

[PULL 22/22] docs/devel: document some plugin assumptions

2024-01-16 Thread Alex Bennée
While we attempt to hide implementation details from the plugin we shouldn't be totally obtuse. Let the user know what they can and can't expect with the various instrumentation options. Message-Id: <20240103173349.398526-44-alex.ben...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Ale

[PULL 06/22] target/ppc: Use GDBFeature for dynamic XML

2024-01-16 Thread Alex Bennée
From: Akihiko Odaki In preparation for a change to use GDBFeature as a parameter of gdb_register_coprocessor(), convert the internal representation of dynamic feature from plain XML to GDBFeature. Signed-off-by: Akihiko Odaki Reviewed-by: Richard Henderson Message-Id: <20240103173349.398526-28

[PULL 19/22] contrib/plugins: extend execlog to track register changes

2024-01-16 Thread Alex Bennée
With the new plugin register API we can now track changes to register values. Currently the implementation is fairly dumb which will slow down if a large number of register values are being tracked. This could be improved by only instrumenting instructions which mention registers we are interested

[PULL 02/22] target/riscv: Remove misa_mxl validation

2024-01-16 Thread Alex Bennée
From: Akihiko Odaki It is initialized with a simple assignment and there is little room for error. In fact, the validation is even more complex. Signed-off-by: Akihiko Odaki Acked-by: LIU Zhiwei Reviewed-by: Daniel Henrique Barboza Acked-by: Alistair Francis Message-Id: <20240103173349.39852

[PULL 20/22] contrib/plugins: optimise the register value tracking

2024-01-16 Thread Alex Bennée
This adds an additional flag which attempts to optimise the register tracking by only instrumenting instructions which are likely to change its value. This relies on the disassembler showing up the register names in disassembly so is only enabled when asked for. Message-Id: <20240103173349.398526-

[PULL 09/22] gdbstub: Use GDBFeature for GDBRegisterState

2024-01-16 Thread Alex Bennée
From: Akihiko Odaki Simplify GDBRegisterState by replacing num_regs and xml members with one member that points to GDBFeature. Signed-off-by: Akihiko Odaki Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20240103173349.398526-31-alex.ben...@linaro.org> Message-Id: <2

[PULL 04/22] target/riscv: Validate misa_mxl_max only once

2024-01-16 Thread Alex Bennée
From: Akihiko Odaki misa_mxl_max is now a class member and initialized only once for each class. This also moves the initialization of gdb_core_xml_file which will be referenced before realization in the future. Signed-off-by: Akihiko Odaki Message-Id: <20240103173349.398526-26-alex.ben...@lina

[PULL 07/22] target/riscv: Use GDBFeature for dynamic XML

2024-01-16 Thread Alex Bennée
From: Akihiko Odaki In preparation for a change to use GDBFeature as a parameter of gdb_register_coprocessor(), convert the internal representation of dynamic feature from plain XML to GDBFeature. Signed-off-by: Akihiko Odaki Message-Id: <20240103173349.398526-29-alex.ben...@linaro.org> Message

[PULL 00/22] gdb cleanups and tcg plugin register access

2024-01-16 Thread Alex Bennée
The following changes since commit 977542ded7e6b28d2bc077bcda24568c716e393c: Merge tag 'pull-testing-updates-120124-2' of https://gitlab.com/stsquad/qemu into staging (2024-01-12 14:02:53 +) are available in the Git repository at: https://gitlab.com/stsquad/qemu.git tags/pull-registers-

[PULL 16/22] gdbstub: expose api to find registers

2024-01-16 Thread Alex Bennée
Expose an internal API to QEMU to return all the registers for a vCPU. The list containing the details required to called gdb_read_register(). Based-on: <20231025093128.33116-15-akihiko.od...@daynix.com> Cc: Akihiko Odaki Message-Id: <20240103173349.398526-38-alex.ben...@linaro.org> Signed-off-by

[PULL 14/22] gdbstub: Add members to identify registers to GDBFeature

2024-01-16 Thread Alex Bennée
From: Akihiko Odaki These members will be used to help plugins to identify registers. The added members in instances of GDBFeature dynamically generated by CPUs will be filled in later changes. Signed-off-by: Akihiko Odaki Message-Id: <20240103173349.398526-36-alex.ben...@linaro.org> Message-Id

[PULL 10/22] gdbstub: Change gdb_get_reg_cb and gdb_set_reg_cb

2024-01-16 Thread Alex Bennée
From: Akihiko Odaki Align the parameters of gdb_get_reg_cb and gdb_set_reg_cb with the gdb_read_register and gdb_write_register members of CPUClass to allow to unify the logic to access registers of the core and coprocessors in the future. Signed-off-by: Akihiko Odaki Reviewed-by: Alex Bennée

[PULL 21/22] docs/devel: lift example and plugin API sections up

2024-01-16 Thread Alex Bennée
This makes them a bit more visible in the TCG emulation menu rather than hiding them away bellow the ToC limit. Message-Id: <20240103173349.398526-43-alex.ben...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé diff --git a/docs/devel/tcg

[PULL 11/22] gdbstub: Simplify XML lookup

2024-01-16 Thread Alex Bennée
From: Akihiko Odaki Now we know all instances of GDBFeature that is used in CPU so we can traverse them to find XML. This removes the need for a CPU-specific lookup function for dynamic XMLs. Signed-off-by: Akihiko Odaki Reviewed-by: Alex Bennée Message-Id: <20240103173349.398526-33-alex.ben..

[PULL 12/22] gdbstub: Infer number of core registers from XML

2024-01-16 Thread Alex Bennée
From: Akihiko Odaki GDBFeature has the num_regs member so use it where applicable to remove magic numbers. Signed-off-by: Akihiko Odaki Message-Id: <20240103173349.398526-34-alex.ben...@linaro.org> Message-Id: <20231213-gdb-v17-8-777047380...@daynix.com> Signed-off-by: Alex Bennée diff --git

[PULL 13/22] hw/core/cpu: Remove gdb_get_dynamic_xml member

2024-01-16 Thread Alex Bennée
From: Akihiko Odaki This function is no longer used. Signed-off-by: Akihiko Odaki Reviewed-by: Alex Bennée Message-Id: <20240103173349.398526-35-alex.ben...@linaro.org> Message-Id: <20231213-gdb-v17-9-777047380...@daynix.com> Signed-off-by: Alex Bennée diff --git a/include/hw/core/cpu.h b/in

[PULL 18/22] contrib/plugins: fix imatch

2024-01-16 Thread Alex Bennée
We can't directly save the ephemeral imatch from argv as that memory will get recycled. Message-Id: <20240103173349.398526-40-alex.ben...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé diff --git a/contrib/plugins/execlog.c b/cont

[PULL 17/22] plugins: add an API to read registers

2024-01-16 Thread Alex Bennée
We can only request a list of registers once the vCPU has been initialised so the user needs to use either call the get function on vCPU initialisation or during the translation phase. We don't expose the reg number to the plugin instead hiding it behind an opaque handle. This allows for a bit of

[PULL 15/22] plugins: Use different helpers when reading registers

2024-01-16 Thread Alex Bennée
From: Akihiko Odaki This avoids optimizations incompatible when reading registers. Signed-off-by: Akihiko Odaki Reviewed-by: Pierrick Bouvier Message-Id: <20240103173349.398526-37-alex.ben...@linaro.org> Message-Id: <20231213-gdb-v17-12-777047380...@daynix.com> Signed-off-by: Alex Bennée Revi

Re: [PATCH v2 09/19] qapi/schema: allow resolve_type to be used for built-in types

2024-01-16 Thread Markus Armbruster
John Snow writes: > allow resolve_type to be used for both built-in and user-specified > type definitions. In the event that the type cannot be resolved, assert > that 'info' and 'what' were both provided in order to create a usable > QAPISemError. > > In practice, 'info' will only be None for bu

Re: [PATCH 2/2] virtio-gpu: fix scanout migration post-load

2024-01-16 Thread Sebastian Ott
On Mon, 15 Jan 2024, marcandre.lur...@redhat.com wrote: +scanout->ds = qemu_create_displaysurface_pixman(res->image); +if (!scanout->ds) { +return -EINVAL; +} "qemu_create_displaysurface_pixman() never returns NULL." ;-)

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

2024-01-16 Thread Fiona Ebner
Am 15.01.24 um 13:00 schrieb Marc-André Lureau: >>> >>> The trouble is when qemu_clipboard_update() is called without data & >>> without a request callback set. We shouldn't allow that as we have no >>> means to get the clipboard data then. >>> >> >> In the above scenario, I'm pretty sure ther

Re: [PATCH v2 11/19] qapi/schema: fix QAPISchemaArrayType.check's call to resolve_type

2024-01-16 Thread Markus Armbruster
John Snow writes: > Adjust the expression at the callsite to eliminate weak type > introspection that believes this value can resolve to QAPISourceInfo; it > cannot. What do you mean by "weak type introspection"? mypy being underpowered? > Signed-off-by: John Snow > --- > scripts/qapi/schema

Re: [PATCH] virtio-iommu: Use qemu_real_host_page_mask as default page_size_mask

2024-01-16 Thread Jean-Philippe Brucker
On Thu, Dec 21, 2023 at 08:45:05AM -0500, Eric Auger wrote: > We used to set default page_size_mask to qemu_target_page_mask() but > with VFIO assignment it makes more sense to use the actual host page mask > instead. > > So from now on qemu_real_host_page_mask() will be used as a default. > To be

[PATCH v2 1/8] sparc/grlib: split out the headers for each peripherals

2024-01-16 Thread Clément Chigot
... and move them in their right hardware directory. Update Copyright and add SPDX-License-Identifier at the same time. Co-developed-by: Frederic Konrad Signed-off-by: Clément Chigot --- hw/char/grlib_apbuart.c | 6 ++-- hw/intc/grlib_irqmp.c | 6

[PATCH v2 0/8] sparc/leon3: Add support for -smp

2024-01-16 Thread Clément Chigot
V2 modifications - Patch1: Add SPDX copyright tags. - Patch3: Add defines for MP_STATUS fields. Improve comments. - Patch4: Improve a comment. - Patch6: Dropped as already merged. --- This series allows leon3 emulations to record up 4 CPUs. It requires some enhancements in the grlib_irqmp de

[PATCH v2 4/8] intc/grlib_irqmp: implements multicore irq

2024-01-16 Thread Clément Chigot
Now there is an ncpus property, use it in order to deliver the IRQ to multiple CPU. Co-developed-by: Frederic Konrad Signed-off-by: Clément Chigot --- hw/intc/grlib_irqmp.c | 43 ++- hw/sparc/leon3.c | 3 ++- include/hw/intc/grlib_irqmp.h |

[PATCH v2 2/8] intc/grlib_irqmp: add ncpus property

2024-01-16 Thread Clément Chigot
This adds a "ncpus" property to the "grlib-irqmp" device to be used later, this required a little refactoring of how we initialize the device (ie: use realize instead of init). Co-developed-by: Frederic Konrad Signed-off-by: Clément Chigot Reviewed-by: Philippe Mathieu-Daudé --- hw/intc/grlib_

[PATCH v2 3/8] intc/grlib_irqmp: implements the multiprocessor status register

2024-01-16 Thread Clément Chigot
This implements the multiprocessor status register in grlib-irqmp and bind it to a start signal, which will be later wired in leon3-generic to start a cpu. The EIRQ and BA bits are not implemented. Based on https://gaisler.com/doc/gr712rc-usermanual.pdf, §8.3.5. Co-developed-by: Frederic Konrad

[PATCH v2 6/8] leon3: implement multiprocessor

2024-01-16 Thread Clément Chigot
This allows to register more than one CPU on the leon3_generic machine. Co-developed-by: Frederic Konrad Signed-off-by: Clément Chigot --- hw/sparc/leon3.c | 106 +-- 1 file changed, 74 insertions(+), 32 deletions(-) diff --git a/hw/sparc/leon3.c b/h

[PATCH v2 7/8] leon3: check cpu_id in the tiny bootloader

2024-01-16 Thread Clément Chigot
Now that SMP is possible, the asr17 must be checked in the little boot code or the secondary CPU will reinitialize the Timer and the Uart. Co-developed-by: Frederic Konrad Signed-off-by: Clément Chigot --- hw/sparc/leon3.c | 22 -- 1 file changed, 20 insertions(+), 2 deletio

[PATCH v2 8/8] MAINTAINERS: replace Fabien by myself as Leon3 maintainer

2024-01-16 Thread Clément Chigot
CC: Fabien Chouteau Signed-off-by: Clément Chigot Reviewed-by: Fabien Chouteau --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index b406fb20c0..b4e78e7748 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1708,7 +1708,7 @@ F: hw/rtc/su

[PATCH v2 5/8] target/sparc: implement asr17 feature for smp

2024-01-16 Thread Clément Chigot
This allows the guest program to know its cpu id. Co-developed-by: Frederic Konrad Signed-off-by: Clément Chigot Reviewed-by: Richard Henderson --- target/sparc/helper.c| 16 target/sparc/helper.h| 1 + target/sparc/translate.c | 13 +++-- 3 files changed, 20

Re: [PATCH 27/35] target/arm: Report VNCR_EL2 based faults correctly

2024-01-16 Thread Jonathan Cameron via
On Mon, 18 Dec 2023 11:32:57 + Peter Maydell wrote: > If FEAT_NV2 redirects a system register access to a memory offset > from VNCR_EL2, that access might fault. In this case we need to > report the correct syndrome information: > * Data Abort, from same-EL > * no ISS information > * the

Re: [PATCH 27/35] target/arm: Report VNCR_EL2 based faults correctly

2024-01-16 Thread Peter Maydell
On Tue, 16 Jan 2024 at 13:09, Jonathan Cameron wrote: > > On Mon, 18 Dec 2023 11:32:57 + > Peter Maydell wrote: > > > If FEAT_NV2 redirects a system register access to a memory offset > > from VNCR_EL2, that access might fault. In this case we need to > > report the correct syndrome informat

Re: [PATCH v3 40/46] hw/s390x/s390-virtio-ccw: use qemu_create_nic_device()

2024-01-16 Thread Thomas Huth
On 08/01/2024 21.27, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- hw/s390x/s390-virtio-ccw.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 1169e20b94..202c37813

Re: [PATCH v3 22/46] hw/arm/aspeed: use qemu_configure_nic_device()

2024-01-16 Thread Cédric Le Goater
On 1/8/24 21:26, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- hw/arm/aspeed.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index cc59176563..bed5e4f40b 100644 --- a/hw/arm/aspeed.c +++ b/hw/

Re: [PATCH v2 12/19] qapi/schema: assert info is present when necessary

2024-01-16 Thread Markus Armbruster
John Snow writes: > QAPISchemaInfo instances are sometimes defined as an Optional > field/argument because built-in definitions don't *have* a source > definition. As a consequence, there are a few places where we need to > assert that it's present because the root entity definition can only > en

Re: [RFC PATCH v3 13/30] migration/multifd: Add outgoing QIOChannelFile support

2024-01-16 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Nov 27, 2023 at 05:25:55PM -0300, Fabiano Rosas wrote: >> Allow multifd to open file-backed channels. This will be used when >> enabling the fixed-ram migration stream format which expects a >> seekable transport. >> >> The QIOChannel read and write methods will use th

Re: [PATCH v4 04/21] parallels: Limit search in parallels_mark_used to the last marked claster

2024-01-16 Thread Denis V. Lunev
On 12/28/23 11:12, Alexander Ivanov wrote: There is no necessity to search to the end of the bitmap. Limit the search area as cluster_index + count. Add cluster_end variable to avoid its calculation in a few places. Signed-off-by: Alexander Ivanov --- block/parallels.c | 9 + 1 file

Re: [PATCH v4 05/21] parallels: Add parallels_mark_unused() helper

2024-01-16 Thread Denis V. Lunev
On 12/28/23 11:12, Alexander Ivanov wrote: Add a helper to set unused areas in the used bitmap. Signed-off-by: Alexander Ivanov --- block/parallels.c | 18 ++ block/parallels.h | 2 ++ 2 files changed, 20 insertions(+) diff --git a/block/parallels.c b/block/parallels.c ind

Re: [PATCH v6 1/2] qom: new object to associate device to numa node

2024-01-16 Thread Ankit Agrawal
>> > >> > Given that, an alternative proposal that I think would work >> > for you would be to add a 'placeholder' memory node definition >> > in SRAT (so allow 0 size explicitly - might need a new SRAT >> > entry to avoid backwards compat issues). >> >> Putting all the PCI/GI/... complexity aside,

Re: [PATCH 0/2] i386/cpu: Two minor fixes for x86_cpu_enable_xsave_components()

2024-01-16 Thread Zhao Liu
Hi Xiaoyao, On Mon, Jan 15, 2024 at 04:13:23AM -0500, Xiaoyao Li wrote: > Date: Mon, 15 Jan 2024 04:13:23 -0500 > From: Xiaoyao Li > Subject: [PATCH 0/2] i386/cpu: Two minor fixes for > x86_cpu_enable_xsave_components() > X-Mailer: git-send-email 2.34.1 > > The two bugs were introduced when xsa

[PATCH] xen: Drop out of coroutine context xen_invalidate_map_cache_entry

2024-01-16 Thread Peng Fan (OSS)
From: Peng Fan xen_invalidate_map_cache_entry is not expected to run in a coroutine. Without this, there is crash: signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44 threadid=) at pthread_kill.c:78 at /usr/src/debug/glibc/2.38+git-r0/sysdeps/posix/raise.c:26 fmt=0xf

​[Qemu-arm] Windows 11 guest Fast startup cannot work

2024-01-16 Thread 叶增软
Hi, I want to improve the startup speed of Windows VM. On the x86 architecture, QEMU's Windows11 VM can enable the Fast startup function, but it cannot work on the ARM architecture. In addition, Windows can also enable the Fast startup function on the ARM host. Is there anything missing in QE

Assistance Required for QEMU Hardfault Error with Cortex-M33 on MPS2AN505

2024-01-16 Thread sanjana gogte
I hope this message finds you well. I am reaching out to seek your expertise regarding a persistent issue I have encountered while working with QEMU, specifically a hardfault error when emulating the MPS2AN505 with a Cortex-M33 core. I have been grappling with this issue for some time and am unsur

​[Qemu-arm] Windows 11 guest Fast startup cannot work

2024-01-16 Thread 叶增软
Hi, I want to improve the startup speed of Windows VM. On the x86 architecture, QEMU's Windows11 VM can enable the Fast startup function, but it cannot work on the ARM architecture. In addition, Windows can also enable the Fast startup function on the ARM host. Is there anything missing in QE

Re: [PATCH v4 06/21] parallels: Move host clusters allocation to a separate function

2024-01-16 Thread Denis V. Lunev
On 12/28/23 11:12, Alexander Ivanov wrote: For parallels images extensions we need to allocate host clusters without any connection to BAT. Move host clusters allocation code to parallels_allocate_host_clusters(). This function can be called not only from coroutines so all the *_co_* functions w

Re: [PATCH v4 07/21] parallels: Set data_end value in parallels_check_leak()

2024-01-16 Thread Denis V. Lunev
On 12/28/23 11:12, Alexander Ivanov wrote: In parallels_check_leak() we change file size but don't correct data_end field of BDRVParallelsState structure. Fix it. Signed-off-by: Alexander Ivanov --- block/parallels.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/parallels.c b/blo

Re: Assistance Required for QEMU Hardfault Error with Cortex-M33 on MPS2AN505

2024-01-16 Thread Peter Maydell
On Tue, 16 Jan 2024 at 14:16, sanjana gogte wrote: > > I hope this message finds you well. I am reaching out to seek your expertise > regarding a persistent issue I have encountered while working with QEMU, > specifically a hardfault error when emulating the MPS2AN505 with a Cortex-M33 > core.

Re: [PATCH v4 08/21] parallels: Recreate used bitmap in parallels_check_leak()

2024-01-16 Thread Denis V. Lunev
On 12/28/23 11:12, Alexander Ivanov wrote: In parallels_check_leak() file can be truncated. In this case the used bitmap would not comply to the file. Recreate the bitmap after file truncation. Signed-off-by: Alexander Ivanov --- block/parallels.c | 8 1 file changed, 8 insertions(+

Re: [PATCH v4 09/21] parallels: Add a note about used bitmap in parallels_check_duplicate()

2024-01-16 Thread Denis V. Lunev
On 12/28/23 11:12, Alexander Ivanov wrote: In parallels_check_duplicate() We use a bitmap for duplication detection. This bitmap is not related to used_bmap field in BDRVParallelsState. Add a comment about it to avoid confusion. Signed-off-by: Alexander Ivanov --- block/parallels.c | 5 -

Re: [PATCH v4 10/21] parallels: Create used bitmap even if checks needed

2024-01-16 Thread Denis V. Lunev
On 12/28/23 11:12, Alexander Ivanov wrote: All the checks were fixed to work with used bitmap. Create used bitmap in parallels_open() even if need_check is true. Signed-off-by: Alexander Ivanov --- block/parallels.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git

Re: [PATCH] virtio-iommu: Use qemu_real_host_page_mask as default page_size_mask

2024-01-16 Thread Eric Auger
Hi Jean, On 1/16/24 13:53, Jean-Philippe Brucker wrote: > On Thu, Dec 21, 2023 at 08:45:05AM -0500, Eric Auger wrote: >> We used to set default page_size_mask to qemu_target_page_mask() but >> with VFIO assignment it makes more sense to use the actual host page mask >> instead. >> >> So from now o

Re: [PATCH v4 12/21] parallels: Let image extensions work in RW mode

2024-01-16 Thread Denis V. Lunev
On 12/28/23 11:12, Alexander Ivanov wrote: Now we support extensions saving and can let to work with them in read-write mode. Signed-off-by: Alexander Ivanov --- block/parallels-ext.c | 4 block/parallels.c | 17 - 2 files changed, 4 insertions(+), 17 deletions(-)

Re: [PATCH 27/35] target/arm: Report VNCR_EL2 based faults correctly

2024-01-16 Thread Jonathan Cameron via
On Tue, 16 Jan 2024 13:20:33 + Peter Maydell wrote: > On Tue, 16 Jan 2024 at 13:09, Jonathan Cameron > wrote: > > > > On Mon, 18 Dec 2023 11:32:57 + > > Peter Maydell wrote: > > > > > If FEAT_NV2 redirects a system register access to a memory offset > > > from VNCR_EL2, that access mi

Re: [PATCH v2 13/19] qapi/schema: split "checked" field into "checking" and "checked"

2024-01-16 Thread Markus Armbruster
John Snow writes: > differentiate between "actively in the process of checking" and > "checking has completed". This allows us to clean up the types of some > internal fields such as QAPISchemaObjectType's members field which > currently uses "None" as a test for determining if check has been run

Re: [PATCH 27/35] target/arm: Report VNCR_EL2 based faults correctly

2024-01-16 Thread Peter Maydell
On Tue, 16 Jan 2024 at 14:50, Jonathan Cameron wrote: > > On Tue, 16 Jan 2024 13:20:33 + > Peter Maydell wrote: > > Bisecting to this patch is a bit weird because at this point > > in the series emulation of FEAT_NV2 should be disabled and > > the code being added should never be used. You co

[PULL 19/21] hw/timer: fix systick trace message

2024-01-16 Thread Peter Maydell
From: Samuel Tardieu Signed-off-by: Samuel Tardieu Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Message-id: 20240109184508.3189599-1-...@rfc1149.net Fixes: ff68dacbc786 ("armv7m: Split systick out from NVIC") Signed-off-by: Peter Maydell --- hw/timer/trace-events | 2 +- 1

[PULL 09/21] tests/qtest: Add STM32L4x5 SYSCFG QTest testcase

2024-01-16 Thread Peter Maydell
From: Inès Varhol Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol Message-id: 20240109194438.70934-4-ines.var...@telecom-paris.fr Signed-off-by: Peter Maydell --- tests/qtest/stm32l4x5_

[PULL 05/21] hw/arm: Connect STM32L4x5 EXTI to STM32L4x5 SoC

2024-01-16 Thread Peter Maydell
From: Inès Varhol Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol Message-id: 20240109160658.311932-3-ines.var...@telecom-paris.fr Signed-off-by: Peter Maydell --- include/hw/arm/stm

[PULL 02/21] target/arm: arm_pamax() no longer needs to do feature propagation

2024-01-16 Thread Peter Maydell
In arm_pamax(), we need to cope with the virt board calling this function on a CPU object which has been inited but not realize. We used to do propagation of feature-flag implications (such as "V7VE implies LPAE") at realize, so we have some code in arm_pamax() which manually checks for both V7VE a

[PULL 03/21] docs/system/arm/virt.rst: Improve 'highmem' option docs

2024-01-16 Thread Peter Maydell
Improve the 'highmem' option docs to note that by default we assume that a 32-bit kernel on an LPAE-capable CPU has LPAE enabled, and what the consequences are. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Reviewed-by: Eric Auger Message-id: 20240109170834.1387457-1-peter.mayd...@linar

[PULL 14/21] hw/arm: Add GMAC devices to NPCM7XX SoC

2024-01-16 Thread Peter Maydell
From: Hao Wu Change-Id: Id8a3461fb5042adc4c3fd6f4fbd1ca0d33e22565 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting Message-id: 20240110234232.4116804-6-nabiheste...@google.com Signed-off-by: Peter Maydell Reviewed-by: Peter Maydell --- include/hw/arm/npcm7xx.h |

[PULL 11/21] hw/arm: Add PCI mailbox module to Nuvoton SoC

2024-01-16 Thread Peter Maydell
This patch wires the PCI mailbox module to Nuvoton SoC. Change-Id: I14c42c628258804030f0583889882842bde0d972 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting Message-id: 20240110234232.4116804-3-nabiheste...@google.com [PMM: moved some changes incorrectly in previous

[PULL 20/21] hw/arm/virt: Consolidate valid CPU types

2024-01-16 Thread Peter Maydell
From: Gavin Shan It's found that some of the CPU type names in the array of valid CPU types are invalid because their corresponding classes aren't registered, as reported by Peter Maydell. [gshan@gshan build]$ ./qemu-system-arm -machine virt -cpu cortex-a9 qemu-system-arm: Invalid CPU model: cor

[PULL 01/21] docs/devel/docs: Document .hx file syntax

2024-01-16 Thread Peter Maydell
We don't currently document the syntax of .hx files anywhere except in a few comments at the top of individual .hx files. We don't even have somewhere in the developer docs where we could do this. Add a new files docs/devel/docs.rst which can be a place to document how our docs build process works

[PULL 04/21] hw/misc: Implement STM32L4x5 EXTI

2024-01-16 Thread Peter Maydell
From: Inès Varhol Although very similar to the STM32F4xx EXTI, STM32L4x5 EXTI generates more than 32 event/interrupt requests and thus uses more registers than STM32F4xx EXTI which generates 23 event/interrupt requests. Acked-by: Alistair Francis Signed-off-by: Arnaud Minier Signed-off-by: Inè

[PULL 08/21] hw/arm: Connect STM32L4x5 SYSCFG to STM32L4x5 SoC

2024-01-16 Thread Peter Maydell
From: Inès Varhol The SYSCFG input GPIOs aren't connected yet. When the STM32L4x5 GPIO device will be implemented, its output GPIOs will be connected to the SYSCFG input GPIOs. Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Arnaud Minier Signed-off-by: In

[PULL 00/21] target-arm queue

2024-01-16 Thread Peter Maydell
mu-arm.git tags/pull-target-arm-20240116 for you to fetch changes up to 7ec39730a9cc443c752d4cad2bf1c00467551ef5: load_elf: fix iterator's type for elf file processing (2024-01-15 17:14:22 +) target-arm queue: * docs/devel

[PULL 15/21] tests/qtest: Creating qtest for GMAC Module

2024-01-16 Thread Peter Maydell
From: Nabih Estefan Diaz - Created qtest to check initialization of registers in GMAC Module. - Implemented test into Build File. Change-Id: I8b2fe152d3987a7eec4cf6a1d25ba92e75a5391d Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting Message-id: 20240110234232.4116804-7-nabiheste...@googl

[PULL 13/21] hw/net: Add NPCMXXX GMAC device

2024-01-16 Thread Peter Maydell
This patch implements the basic registers of GMAC device and sets registers for networking functionalities. Tested: The following message shows up with the change: Broadcom BCM54612E stmmac-0:00: attached PHY driver [Broadcom BCM54612E] (mii_bus:phy_addr=stmmac-0:00, irq=POLL) stmmaceth f0802000.

[PULL 07/21] hw/misc: Implement STM32L4x5 SYSCFG

2024-01-16 Thread Peter Maydell
From: Inès Varhol Acked-by: Alistair Francis Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol Message-id: 20240109194438.70934-2-ines.var...@telecom-paris.fr Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- docs/system/arm/b-l475e-iot01a.rst | 2 +- include/hw/misc/stm32

[PULL 16/21] hw/net: GMAC Rx Implementation

2024-01-16 Thread Peter Maydell
From: Nabih Estefan Diaz - Implementation of Receive function for packets - Implementation for reading and writing from and to descriptors in memory for Rx When RX starts, we need to flush the queued packets so that they can be received by the GMAC device. Without this it won't work with TAP N

[PULL 21/21] load_elf: fix iterator's type for elf file processing

2024-01-16 Thread Peter Maydell
From: Anastasia Belova j is used while loading an ELF file to byteswap segments' data. If data is larger than 2GB an overflow may happen. So j should be elf_word. This commit fixes a minor bug: it's unlikely anybody is trying to load ELF files with 2GB+ segments for wrong-endianness targets, but

[PULL 17/21] hw/net: GMAC Tx Implementation

2024-01-16 Thread Peter Maydell
From: Nabih Estefan Diaz - Implementation of Transmit function for packets - Implementation for reading and writing from and to descriptors in memory for Tx NOTE: This function implements the steps detailed in the datasheet for transmitting messages from the GMAC. Added relevant trace-events

[PULL 18/21] tests/qtest: Adding PCS Module test to GMAC Qtest

2024-01-16 Thread Peter Maydell
From: Nabih Estefan Diaz - Add PCS Register check to npcm_gmac-test Change-Id: I34821beb5e0b1e89e2be576ab58eabe41545af12 Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting Message-id: 20240110234232.4116804-11-nabiheste...@google.com Signed-off-by: Peter Maydell Reviewed-by: Peter Maydell

[PULL 06/21] tests/qtest: Add STM32L4x5 EXTI QTest testcase

2024-01-16 Thread Peter Maydell
From: Inès Varhol Reviewed-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol Message-id: 20240109160658.311932-4-ines.var...@telecom-paris.fr Signed-off-by: Peter Maydell --- tests/qtest/stm32l4x5_exti-test.c | 524

[PULL 12/21] hw/misc: Add qtest for NPCM7xx PCI Mailbox

2024-01-16 Thread Peter Maydell
From: Hao Wu This patches adds a qtest for NPCM7XX PCI Mailbox module. It sends read and write requests to the module, and verifies that the module contains the correct data after the requests. Change-Id: I2e1dbaecf8be9ec7eab55cb54f7fdeb0715b8275 Signed-off-by: Hao Wu Signed-off-by: Nabih Estef

[PULL 10/21] hw/misc: Add Nuvoton's PCI Mailbox Module

2024-01-16 Thread Peter Maydell
From: Hao Wu The PCI Mailbox Module is a high-bandwidth communcation module between a Nuvoton BMC and CPU. It features 16KB RAM that are both accessible by the BMC and core CPU. and supports interrupt for both sides. This patch implements the BMC side of the PCI mailbox module. Communication wit

  1   2   3   >