Re: [PATCH v2 06/14] block: remove AioContext locking

2023-12-20 Thread Kevin Wolf
Am 19.12.2023 um 21:04 hat Stefan Hajnoczi geschrieben: > On Tue, 19 Dec 2023 at 10:59, Kevin Wolf wrote: > > > > Am 05.12.2023 um 19:20 hat Stefan Hajnoczi geschrieben: > > > This is the big patch that removes > > > aio_context_acquire()/aio_context_release() from the block layer and > > > affect

Re: [PATCH v2 04/14] aio: make aio_context_acquire()/aio_context_release() a no-op

2023-12-20 Thread Kevin Wolf
Am 19.12.2023 um 22:23 hat Stefan Hajnoczi geschrieben: > The following hack makes the test pass but there are larger safety > issues that I'll need to look at on Wednesday: I see, you're taking the same approach as in the SCSI layer: Don't make things thread-safe, but just always access them from

[PULL 08/19] target: Restrict 'sysemu/reset.h' to system emulation

2023-12-20 Thread Thomas Huth
From: Philippe Mathieu-Daudé vCPU "reset" is only possible with system emulation. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Warner Losh Reviewed-by: Song Gao Message-ID: <20231212113640.30287-5-phi...@linaro.org> Reviewed-by: Thomas Huth Reviewed-by: Zhao Liu Signed-off-by: Thomas

[PULL 04/19] system/qtest: Restrict QTest API to system emulation

2023-12-20 Thread Thomas Huth
From: Philippe Mathieu-Daudé Outside of system emulation, only qtest_enabled() can be used. Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20231212113016.29808-3-phi...@linaro.org> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- include/sysemu/qtest.h | 2 ++ 1 file changed, 2 in

[PULL 15/19] qemu-options: Clarify handling of commas in options parameters

2023-12-20 Thread Thomas Huth
From: Yihuan Pan Provide explicit guidance on dealing with option parameters as arbitrary strings containing commas, such as in "file=my,file" and "string=a,b". The updated documentation emphasizes the need to double commas when they appear within such parameters. Resolves: https://gitlab.com/qe

[PULL 10/19] hw: Replace anti-social QOM type names (again)

2023-12-20 Thread Thomas Huth
From: Markus Armbruster QOM type names containing ',' result in awful UI. We got rid of them in v6.0.0 (commit e178113ff64 hw: Replace anti-social QOM type names). A few have crept back since: xlnx,cframe-reg xlnx,efuse xlnx,pmc-efuse-cache xlnx,versal-cfu-apb xlnx,versal-cf

[PULL 01/19] hw: Add compat machines for 9.0

2023-12-20 Thread Thomas Huth
From: Cornelia Huck Add 9.0 machine types for arm/i440fx/m68k/q35/s390x/spapr. Signed-off-by: Cornelia Huck Message-ID: <20231120094259.1191804-1-coh...@redhat.com> Acked-by: Thomas Huth Reviewed-by: Harsh Prateek Bora Reviewed-by: Gavin Shan Acked-by: Eric Farman # s390x Signed-off-by: Th

[PULL 05/19] hw/ppc/spapr_hcall: Remove unused 'exec/exec-all.h' included header

2023-12-20 Thread Thomas Huth
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20231212113640.30287-2-phi...@linaro.org> Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: Thomas Huth --- hw/ppc/spapr_hcall.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/ppc/spap

[PULL 03/19] system/qtest: Include missing 'hw/core/cpu.h' header

2023-12-20 Thread Thomas Huth
From: Philippe Mathieu-Daudé "hw/core/cpu.h" declares 'first_cpu'. Include it to avoid when unrelated headers are refactored: system/qtest.c:548:33: error: use of undeclared identifier 'first_cpu' address_space_write(first_cpu->as, addr, MEMTXATTRS_UNSPECIFIED,

[PULL 07/19] hw/s390x/ipl: Remove unused 'exec/exec-all.h' included header

2023-12-20 Thread Thomas Huth
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20231212113640.30287-4-phi...@linaro.org> Reviewed-by: Eric Farman Signed-off-by: Thomas Huth --- hw/s390x/ipl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index 515dcf51b5.

[PULL 13/19] qom/object: Limit type names to alphanumerical and some few special characters

2023-12-20 Thread Thomas Huth
QOM names currently don't have any enforced naming rules. This can be problematic, e.g. when they are used on the command line for the "-device" option (where the comma is used to separate properties). To avoid that such problematic type names come in again, let's restrict the set of acceptable cha

[PULL 02/19] MAINTAINERS: Add some more vmware-related files to the corresponding section

2023-12-20 Thread Thomas Huth
These files are obviously related to Vmware emulation, so let's list them in the corresponding section in the MAINTAINERS file. Message-ID: <20231107102738.14797-1-th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- MAINTAINERS | 5 + 1 file changed, 5 inser

[PULL 12/19] tests/unit/test-io-task: Rename "qemu:dummy" to avoid colon in the name

2023-12-20 Thread Thomas Huth
Type names should not contain special characters like ":" (so that they are easier to use with QAPI and other parts). We are going to forbid such names in an upcoming patch. Thus let's replace the ":" here with a "-". Reviewed-by: "Daniel P. Berrangé" Reviewed-by: Philippe Mathieu-Daudé Message-

[PULL 06/19] hw/misc/mips_itu: Remove unnecessary 'exec/exec-all.h' header

2023-12-20 Thread Thomas Huth
From: Philippe Mathieu-Daudé mips_itu.c only requires declarations from "hw/core/cpu.h" and "cpu.h". Avoid including the huge "exec/exec-all.h" header. Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20231212113640.30287-3-phi...@linaro.org> Reviewed-by: Thomas Huth Signed-off-by: Thomas Hu

[PULL 00/19] First batch of misc patches for QEMU 9.0

2023-12-20 Thread Thomas Huth
Hi! The following changes since commit bd00730ec0f621706d0179768436f82c39048499: Open 9.0 development tree (2023-12-19 09:46:22 -0500) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2023-12-20 for you to fetch changes up to 17b2ecc331eab274d448

[PULL 09/19] docs/system/arm: Fix for rename of type "xlnx.bbram-ctrl"

2023-12-20 Thread Thomas Huth
From: Markus Armbruster Fixes: b65b4b7ae3c8 (xlnx-bbram: hw/nvram: Use dot in device type name) Signed-off-by: Markus Armbruster [thuth: Use longhand syntax to avoid problems with the "." in the name] Reviewed-by: Peter Maydell Message-ID: <20231117114457.177308-2-th...@redhat.com> Acked-by: Al

[PULL 18/19] tests/unit/test-qmp-event: Simplify event emission check

2023-12-20 Thread Thomas Huth
From: Markus Armbruster The generated qapi_event_send_FOO() call an event emitter function. It's test_qapi_event_emit() in this test. It compares the actual event to the expected event, and sets a flag to record it was called. The test functions set expected data and clear the flag before callin

[PULL 14/19] tests/qtest/migration-test: Fix analyze-migration.py for s390x

2023-12-20 Thread Thomas Huth
The migration stream on s390x contains data for the storage_attributes which the analyze-migration.py cannot handle yet. Add the basic code for handling this, so we can re-enable the check in the migration-test. Message-ID: <20231120113951.162090-1-th...@redhat.com> Reviewed-by: Fabiano Rosas Sig

[PULL 19/19] tests/unit/test-qmp-event: Replace fixture by global variables

2023-12-20 Thread Thomas Huth
From: Markus Armbruster The fixture buys us exactly nothing, as we need a global variable anyway, for test_qapi_event_emit(). Drop it. Signed-off-by: Markus Armbruster Reviewed-by: Thomas Huth Message-ID: <20231122072456.2518816-4-arm...@redhat.com> Signed-off-by: Thomas Huth --- tests/unit

[PULL 11/19] memory: Remove "qemu:" prefix from the "qemu:ram-discard-manager" type name

2023-12-20 Thread Thomas Huth
Type names should not contain special characters like ":". Let's remove the whole prefix here since it does not really seem to be helpful to have such a prefix here. The type name is only used internally for an interface type, so the renaming should not affect the user interface or migration. Revi

[PULL 16/19] tests/qtest/npcm7xx_pwm-test: Only do full testing in slow mode

2023-12-20 Thread Thomas Huth
The npcm7xx_pwm-test can take quite a while when running with --enable-debug on a loaded system. The tests here are quite repetitive - by default it should be fine if we only execute some of them and only execute all when running in slow testing mode. Message-ID: <20231215143524.49241-1-th...@redh

[PULL 17/19] tests/unit/test-qmp-event: Drop superfluous mutex

2023-12-20 Thread Thomas Huth
From: Markus Armbruster Mutex @test_event_lock is held from fixture setup to teardown, protecting global variable @test_event_data. But tests always run one after the other, so this is superfluous. It also confuses Coverity. Drop the mutex. Fixes: CID 1527425 Signed-off-by: Markus Armbruster

Re: TCP/telnet serial port not working in QEMU 8.1.3

2023-12-20 Thread Alex Bennée
Dave Blanchard writes: > I just "upgraded" from QEMU 6.1.0 to 8.1.3 only to find that the > -serial telnet/tcp option is no longer working. The following message > is printed, and there's a 'connection refused' with the telnet > program. Nmap shows no ports open. > > qemu-system-x86_64: -serial t

Re: [PATCH] target/i386: Fix physical address truncation when PAE is enabled

2023-12-20 Thread Michael Brown
On 20/12/2023 04:22, Richard Henderson wrote: On 12/18/23 23:56, Michael Brown wrote: The address translation logic in get_physical_address() will currently truncate physical addresses to 32 bits unless long mode is enabled. This is incorrect when using physical address extensions (PAE) outside

[PATCH] arm_gic: Implement GICC_AIAR, GICC_AEOIR and GICC_AHPPIR

2023-12-20 Thread Andrei Homescu
From: Arve Hjønnevåg Implement aliased registers so group 1 interrupts can be used in secure mode. GICC_AEOIR is only implemented as a direct alias to GICC_EOIR for now as gic_complete_irq does not currently check if the cpu is in secure mode. Upstreamed from https://r.android.com/705890 and ht

Questions regarding the still unpublished qemu series https://github.com/yiliu1765/qemu/tree/zhenzhong/wip/iommufd_nesting_rfcv1

2023-12-20 Thread Joel Granados
Hello Everyone While running https://github.com/yiliu1765/qemu/tree/zhenzhong/wip/iommufd_nesting_rfcv1 I have come across particular code path that seems odd: I'm hitting an assert in softmmu/memory.c:1994 after calling a notification from vtd_flt_page_walk_level. The code in memory.c:1994 make

[PATCH v2 03/11] next-cube.c: update mmio_ops to properly use modern memory API

2023-12-20 Thread Mark Cave-Ayland
The old QEMU memory accessors used in the original NextCube patch series had separate functions for 1, 2 and 4 byte accessors. When the series was finally merged a simple wrapper function was written to dispatch the memory accesses using the original functions. Convert mmio_ops to use the memory A

[PATCH v2 01/11] next-cube.c: add dummy Ethernet register to allow diagnostic to timeout

2023-12-20 Thread Mark Cave-Ayland
Add a dummy register at address 0x6000 in the MMIO memory region to allow the initial diagnostic test to timeout rather than getting stuck in a loop continuously writing "en_write: tx not ready" to the console. Signed-off-by: Mark Cave-Ayland Tested-by: Thomas Huth --- hw/m68k/next-cube.c | 4 +

[PATCH v2 02/11] next-cube.c: don't pulse SCSI DMA IRQ upon reception of FLUSH command

2023-12-20 Thread Mark Cave-Ayland
Normally a DMA FLUSH command is used to ensure that data is completely written to the device and/or memory, so remove the pulse of the SCSI DMA IRQ if a DMA FLUSH command is received. This enables the NeXT ROM monitor to start to load from a SCSI disk. Signed-off-by: Mark Cave-Ayland Reviewed-by:

[PATCH v2 04/11] next-cube.c: update scr_ops to properly use modern memory API

2023-12-20 Thread Mark Cave-Ayland
The old QEMU memory accessors used in the original NextCube patch series had separate functions for 1, 2 and 4 byte accessors. When the series was finally merged a simple wrapper function was written to dispatch the memory accesses using the original functions. Convert scr_ops to use the memory AP

[PATCH v2 11/11] next-cube.c: move machine MemoryRegions into NeXTState

2023-12-20 Thread Mark Cave-Ayland
These static memory regions are contained within the machine and do not need to be dynamically allocated. Signed-off-by: Mark Cave-Ayland Reviewed-by: Thomas Huth --- hw/m68k/next-cube.c | 38 +- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a

[PATCH v2 07/11] next-cube.c: move static phase variable to NextRtc

2023-12-20 Thread Mark Cave-Ayland
The phase variable represents part of the state machine used to clock data out of the NextRtc device. Note that this is a migration break for the NeXTRtc struct, but as nothing will currently boot then we simply bump the migration version for now. Signed-off-by: Mark Cave-Ayland Reviewed-by: Tho

[PATCH v2 05/11] next-cube.c: update and improve dma_ops

2023-12-20 Thread Mark Cave-Ayland
Rename dma_ops to next_dma_ops and the read/write functions to next_dma_read() and next_dma_write() respectively, mark next_dma_ops as DEVICE_BIG_ENDIAN and also improve the consistency of the val variable in next_dma_read() and next_dma_write(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Thoma

[PATCH v2 08/11] next-cube.c: move static old_scr2 variable to NeXTPC

2023-12-20 Thread Mark Cave-Ayland
Move the old_scr2 variable to NeXTPC so that the old SCR2 register state is stored along with the current SCR2 state. Since the SCR2 register is 32-bits wide, convert old_scr2 to uint32_t and update the SCR2 register access code to allow unaligned writes. Note that this is a migration break, but

[PATCH v2 00/11] next-cube: various tidy-ups and improvements

2023-12-20 Thread Mark Cave-Ayland
This series contains some tidy-ups/improvements for the next-cube machine with the aim of bringing the code up-to-date with our latest coding guidelines. The main aim of the series is to bring the memory accessors up-to-date with the memory API and improve some of basic machine modelling. There ar

[PATCH] Fix iATU num viewports manipulation

2023-12-20 Thread Shlomo Pongratz
The number of iATU ports in the RP emulation is 4. This value is exported via register at address 0x900 The specification states that the value in the resisetr is 1 less then the actual number. the Linux kernel routine dw_pcie_iatu_detect in drivers/pci/controller/dwc/pcie-designware.c follows the

[PATCH v2 10/11] next-cube.c: remove val and size arguments from nextscr2_write()

2023-12-20 Thread Mark Cave-Ayland
These are now redundant with the scr2 and old_scr2 fields in NeXTPC. Rename the function from nextscr2_write() to next_scr2_rtc_update() to better reflect its purpose. At the same time replace the manual bit manipulation with the extract32() and deposit32() functions. Signed-off-by: Mark Cave-Ayla

[PATCH v2 06/11] next-cube.c: move static led variable to NeXTPC

2023-12-20 Thread Mark Cave-Ayland
The state of the led is stored in the SCR2 register which is part of the NeXTPC device. Note that this is a migration break for the NeXTPC device, but as nothing will currently boot then we simply bump the migration version for now. Signed-off-by: Mark Cave-Ayland Reviewed-by: Thomas Huth ---

[PATCH v2 09/11] next-cube.c: move LED logic to new next_scr2_led_update() function

2023-12-20 Thread Mark Cave-Ayland
Ensure that the LED status is updated by calling next_scr2_led_update() whenever the SC2 register is written. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cub

Re: [PATCH v2 04/14] aio: make aio_context_acquire()/aio_context_release() a no-op

2023-12-20 Thread Stefan Hajnoczi
On Wed, 20 Dec 2023 at 04:32, Kevin Wolf wrote: > > Am 19.12.2023 um 22:23 hat Stefan Hajnoczi geschrieben: > > The following hack makes the test pass but there are larger safety > > issues that I'll need to look at on Wednesday: > > I see, you're taking the same approach as in the SCSI layer: Don

[PATCH v4 3/4] qdev: add IOThreadVirtQueueMappingList property type

2023-12-20 Thread Stefan Hajnoczi
virtio-blk and virtio-scsi devices will need a way to specify the mapping between IOThreads and virtqueues. At the moment all virtqueues are assigned to a single IOThread or the main loop. This single thread can be a CPU bottleneck, so it is necessary to allow finer-grained assignment to spread the

[PATCH v4 0/4] virtio-blk: add iothread-vq-mapping parameter

2023-12-20 Thread Stefan Hajnoczi
v4: - Use DummyVirtioForceArrays naming in QAPI schema [Markus] v3: - Rebased onto Kevin's block branch - Add StringOutputVisitor "" patch to fix "info qtree" crash - Fix QAPI schema formatting [Markus] - Eliminate unnecessary local variable in get_iothread_vq_mapping_list() [Markus] virtio-blk a

[PATCH v4 1/4] qdev-properties: alias all object class properties

2023-12-20 Thread Stefan Hajnoczi
qdev_alias_all_properties() aliases a DeviceState's qdev properties onto an Object. This is used for VirtioPCIProxy types so that --device virtio-blk-pci has properties of its embedded --device virtio-blk-device object. Currently this function is implemented using qdev properties. Change the funct

[PATCH v4 4/4] virtio-blk: add iothread-vq-mapping parameter

2023-12-20 Thread Stefan Hajnoczi
Add the iothread-vq-mapping parameter to assign virtqueues to IOThreads. Store the vq:AioContext mapping in the new struct VirtIOBlockDataPlane->vq_aio_context[] field and refactor the code to use the per-vq AioContext instead of the BlockDriverState's AioContext. Reimplement --device virtio-blk-p

[PATCH v4 2/4] string-output-visitor: show structs as ""

2023-12-20 Thread Stefan Hajnoczi
StringOutputVisitor crashes when it visits a struct because ->start_struct() is NULL. Show "" instead of crashing. This is necessary because the virtio-blk-pci iothread-vq-mapping parameter that I'd like to introduce soon is a list of IOThreadMapping structs. This patch is a quick fix to solve th

[PATCH] vfio/container: Replace basename with g_path_get_basename

2023-12-20 Thread Cédric Le Goater
g_path_get_basename() is a portable utility function that has the advantage of not modifing the string argument. It also fixes a compile breakage with the Musl C library reported in [1]. [1] https://lore.kernel.org/all/20231212010228.2701544-1-raj.k...@gmail.com/ Reported-by: Khem Raj Signed-off

Re: [PATCH] vfio/container: Replace basename with g_path_get_basename

2023-12-20 Thread Eric Auger
Hi Cédric, On 12/20/23 14:53, Cédric Le Goater wrote: > g_path_get_basename() is a portable utility function that has the > advantage of not modifing the string argument. It also fixes a compile > breakage with the Musl C library reported in [1]. > > [1] https://lore.kernel.org/all/20231212010228.

Re: [PATCH V8 00/12] fix migration of suspended runstate

2023-12-20 Thread Anthony PERARD
On Mon, Dec 18, 2023 at 01:14:51PM +0800, Peter Xu wrote: > On Wed, Dec 13, 2023 at 10:35:33AM -0500, Steven Sistare wrote: > > Hi Peter, all have RB's, with all i's dotted and t's crossed - steve > > Yes this seems to be more migration related so maybe good candidate for a > pull from migration s

Re: [PATCH] vfio/container: Replace basename with g_path_get_basename

2023-12-20 Thread Zhao Liu
Hi Cédric, On Wed, Dec 20, 2023 at 02:53:02PM +0100, Cédric Le Goater wrote: > Date: Wed, 20 Dec 2023 14:53:02 +0100 > From: Cédric Le Goater > Subject: [PATCH] vfio/container: Replace basename with g_path_get_basename > X-Mailer: git-send-email 2.43.0 > > g_path_get_basename() is a portable uti

Re: [PATCH V8 00/12] fix migration of suspended runstate

2023-12-20 Thread Steven Sistare
On 12/20/2023 9:52 AM, Anthony PERARD wrote: > On Mon, Dec 18, 2023 at 01:14:51PM +0800, Peter Xu wrote: >> On Wed, Dec 13, 2023 at 10:35:33AM -0500, Steven Sistare wrote: >>> Hi Peter, all have RB's, with all i's dotted and t's crossed - steve >> >> Yes this seems to be more migration related so m

Re: Qemu resets terminal to crazy defaults

2023-12-20 Thread Fabiano Rosas
Warner Losh writes: > On Tue, Dec 19, 2023, 1:55 PM Peter Maydell > wrote: > >> On Tue, 19 Dec 2023 at 19:40, Fabiano Rosas wrote: >> > >> > Dave Blanchard writes: >> > >> > > Hello all, can you please help me to understand what Qemu is doing >> here? >> > > >> > > When connecting to the guest

Re: TCP/telnet serial port not working in QEMU 8.1.3

2023-12-20 Thread Dave Blanchard
Doesn't work for me. Fixed by "downgrading" to the 7.x series.

Re: TCP/telnet serial port not working in QEMU 8.1.3

2023-12-20 Thread Dave Blanchard
Fixed by "downgrading" to 7.x series. Something has changed in 8.x.

Re: Qemu resets terminal to crazy defaults

2023-12-20 Thread Dave Blanchard
Once it was made clear the problem was in the BIOS, it was easy to find. I've made the attached patch, but haven't yet tested it. qemu-8.1.3-dont-screw-up-terminal-settings.patch Description: Binary data

[PATCH 1/1] target/riscv: pmp: Ignore writes when RW=01 and MML=0

2023-12-20 Thread Ivan Klokov
This patch changes behavior on writing RW=01 to pmpcfg with MML=0. RWX filed is form of collective WARL with the combination of pmpcfg.RW=01 remains reserved for future standard use. According to definition of WARL writing the CSR has no other side effect. But current implementation change archite

Re: TCP/telnet serial port not working in QEMU 8.1.3

2023-12-20 Thread Michael Tokarev
20.12.2023 18:30, Dave Blanchard wrote: Fixed by "downgrading" to 7.x series. Something has changed in 8.x. Works for me exactly the same in 6.0, 7.2, 8.1[.3], and 8.2.0. /mjt

Re: TCP/telnet serial port not working in QEMU 8.1.3

2023-12-20 Thread Dave Blanchard
Congratulations!

[qemu-web PATCH] Add QEMU 8.2.0 release announcement

2023-12-20 Thread Stefan Hajnoczi
Cc: Michael Roth Signed-off-by: Stefan Hajnoczi --- _posts/2023-12-20-qemu-8-2-0.md | 29 + 1 file changed, 29 insertions(+) create mode 100644 _posts/2023-12-20-qemu-8-2-0.md diff --git a/_posts/2023-12-20-qemu-8-2-0.md b/_posts/2023-12-20-qemu-8-2-0.md new file mo

Re: [PULL 00/47] vfio queue

2023-12-20 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/19] First batch of misc patches for QEMU 9.0

2023-12-20 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/43] target-arm queue

2023-12-20 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [qemu-web PATCH] Add QEMU 8.2.0 release announcement

2023-12-20 Thread Michael Roth
Quoting Stefan Hajnoczi (2023-12-20 10:02:37) > Cc: Michael Roth > Signed-off-by: Stefan Hajnoczi > --- > _posts/2023-12-20-qemu-8-2-0.md | 29 + > 1 file changed, 29 insertions(+) > create mode 100644 _posts/2023-12-20-qemu-8-2-0.md > > diff --git a/_posts/2023-12-

[PATCH v5 16/18] mcdstub: register access added

2023-12-20 Thread Nicolas Eder
--- debug/mcdstub/mcdstub.c | 161 1 file changed, 161 insertions(+) diff --git a/debug/mcdstub/mcdstub.c b/debug/mcdstub/mcdstub.c index df97eca65b..df98453558 100644 --- a/debug/mcdstub/mcdstub.c +++ b/debug/mcdstub/mcdstub.c @@ -857,6 +857,146 @@ static

[PATCH v5 17/18] mcdstub: memory access added

2023-12-20 Thread Nicolas Eder
--- debug/mcdstub/arm_mcdstub.c | 28 + debug/mcdstub/mcdstub.c | 203 ++ include/mcdstub/arm_mcdstub.h | 15 +++ 3 files changed, 246 insertions(+) diff --git a/debug/mcdstub/arm_mcdstub.c b/debug/mcdstub/arm_mcdstub.c index ce5264a617..6eaf2d754f 10

[PATCH v5 05/18] mcdstub: memory helper functions added

2023-12-20 Thread Nicolas Eder
--- include/exec/cpu-common.h | 3 +++ include/exec/memory.h | 9 + system/memory.c | 11 +++ system/physmem.c | 26 ++ 4 files changed, 49 insertions(+) diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h index 41115

[PATCH v5 03/18] gdbstub: GDBRegisterState moved to gdbstub.h so it can be used outside of the gdbstub

2023-12-20 Thread Nicolas Eder
--- debug/gdbstub/gdbstub.c | 8 include/exec/gdbstub.h | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/debug/gdbstub/gdbstub.c b/debug/gdbstub/gdbstub.c index f43d4355c0..5df7841878 100644 --- a/debug/gdbstub/gdbstub.c +++ b/debug/gdbstub/gdbstub.c @@ -45,14

[PATCH v5 09/18] mcdstub: TCP packet plumbing added

2023-12-20 Thread Nicolas Eder
--- debug/mcdstub/mcdstub.c | 422 1 file changed, 422 insertions(+) diff --git a/debug/mcdstub/mcdstub.c b/debug/mcdstub/mcdstub.c index 0df436719e..642f3c2826 100644 --- a/debug/mcdstub/mcdstub.c +++ b/debug/mcdstub/mcdstub.c @@ -87,6 +87,320 @@ static i

[PATCH v5 14/18] mcdstub: state query added

2023-12-20 Thread Nicolas Eder
--- debug/mcdstub/mcdstub.c | 44 + 1 file changed, 44 insertions(+) diff --git a/debug/mcdstub/mcdstub.c b/debug/mcdstub/mcdstub.c index ee52830a2c..fb13958108 100644 --- a/debug/mcdstub/mcdstub.c +++ b/debug/mcdstub/mcdstub.c @@ -1406,6 +1406,43 @@ static

[PATCH v5 15/18] mcdstub: skeleton for reset handling added

2023-12-20 Thread Nicolas Eder
--- debug/mcdstub/mcdstub.c | 46 + 1 file changed, 46 insertions(+) diff --git a/debug/mcdstub/mcdstub.c b/debug/mcdstub/mcdstub.c index fb13958108..df97eca65b 100644 --- a/debug/mcdstub/mcdstub.c +++ b/debug/mcdstub/mcdstub.c @@ -826,6 +826,37 @@ static v

[PATCH v5 12/18] mcdstub: all core specific queries added

2023-12-20 Thread Nicolas Eder
--- debug/mcdstub/mcdstub.c | 365 1 file changed, 365 insertions(+) diff --git a/debug/mcdstub/mcdstub.c b/debug/mcdstub/mcdstub.c index 4095b3f8ce..e90fc81814 100644 --- a/debug/mcdstub/mcdstub.c +++ b/debug/mcdstub/mcdstub.c @@ -893,6 +893,301 @@ static

[PATCH v5 10/18] mcdstub: open and close server functions added

2023-12-20 Thread Nicolas Eder
--- debug/mcdstub/mcdstub.c | 299 1 file changed, 214 insertions(+), 85 deletions(-) diff --git a/debug/mcdstub/mcdstub.c b/debug/mcdstub/mcdstub.c index 642f3c2826..45daa38689 100644 --- a/debug/mcdstub/mcdstub.c +++ b/debug/mcdstub/mcdstub.c @@ -65,6 +6

[PATCH v5 06/18] mcdstub: -mcd start option added, mcd specific defines added

2023-12-20 Thread Nicolas Eder
--- debug/mcdstub/mcdstub.c | 203 +++ debug/mcdstub/meson.build| 12 ++ debug/meson.build| 1 + include/mcdstub/mcdstub.h| 152 +++ include/mcdstub/mcdstub_common.h | 46 +++ qemu-options.hx

[PATCH v5 00/18] first version of mcdstub

2023-12-20 Thread Nicolas Eder
SUMMARY === This patch-set introduces the first version of the mcdstub. The mcdstub is a debug interface, which enables debugging QEMU using the MCD (Multi-Core Debug) API. The mcdstub uses TCP to communicate with the host debug software. However, because MCD is merely an API, the TCP communic

[PATCH v5 18/18] mcdstub: break/watchpoints added

2023-12-20 Thread Nicolas Eder
--- debug/mcdstub/mcdstub.c | 150 1 file changed, 150 insertions(+) diff --git a/debug/mcdstub/mcdstub.c b/debug/mcdstub/mcdstub.c index 954d06c0b7..d2c505c0d6 100644 --- a/debug/mcdstub/mcdstub.c +++ b/debug/mcdstub/mcdstub.c @@ -1177,6 +1177,134 @@ stat

[PATCH v5 07/18] mcdstub: mcdserver initialization functions added

2023-12-20 Thread Nicolas Eder
--- debug/mcdstub/mcdstub.c | 154 1 file changed, 154 insertions(+) diff --git a/debug/mcdstub/mcdstub.c b/debug/mcdstub/mcdstub.c index 4d8d5d956a..0df436719e 100644 --- a/debug/mcdstub/mcdstub.c +++ b/debug/mcdstub/mcdstub.c @@ -22,9 +22,12 @@ #include

[PATCH v5 02/18] gdbstub: hex conversion functions moved to cutils.h

2023-12-20 Thread Nicolas Eder
--- debug/gdbstub/gdbstub.c | 19 ++- debug/gdbstub/internals.h | 26 -- include/qemu/cutils.h | 30 ++ 3 files changed, 40 insertions(+), 35 deletions(-) diff --git a/debug/gdbstub/gdbstub.c b/debug/gdbstub/gdbstub.c index

[PATCH v5 13/18] mcdstub: go, step and break added

2023-12-20 Thread Nicolas Eder
--- debug/mcdstub/mcdstub.c | 218 1 file changed, 218 insertions(+) diff --git a/debug/mcdstub/mcdstub.c b/debug/mcdstub/mcdstub.c index e90fc81814..ee52830a2c 100644 --- a/debug/mcdstub/mcdstub.c +++ b/debug/mcdstub/mcdstub.c @@ -28,6 +28,7 @@ #include

[ANNOUNCE] QEMU 8.2.0 is now available

2023-12-20 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the QEMU 8.2.0 release. This release contains 3200+ commits from 238 authors. You can grab the tarball from our download page here: https://www.qemu.org/download/#source The full list of changes are available at: h

[PATCH v5 08/18] cutils: qemu_strtou32 function added

2023-12-20 Thread Nicolas Eder
--- include/qemu/cutils.h | 2 ++ util/cutils.c | 30 ++ 2 files changed, 32 insertions(+) diff --git a/include/qemu/cutils.h b/include/qemu/cutils.h index 5ab1a4ffb0..14f492ba61 100644 --- a/include/qemu/cutils.h +++ b/include/qemu/cutils.h @@ -158,6 +158,8 @

[PATCH v5 11/18] mcdstub: system and core queries added

2023-12-20 Thread Nicolas Eder
--- debug/mcdstub/arm_mcdstub.c | 243 debug/mcdstub/mcdstub.c | 370 ++- debug/mcdstub/meson.build| 2 +- include/mcdstub/arm_mcdstub.h| 85 +++ include/mcdstub/mcdstub.h| 5 - include/mcdstub/mcdstub_comm

[PATCH v5 04/18] gdbstub: DebugClass added to system mode.

2023-12-20 Thread Nicolas Eder
This class is used to abstract debug features between different debuggers --- debug/common/debug.c | 33 + debug/common/meson.build | 1 + debug/gdbstub/system.c | 18 ++ debug/meson.build| 1 + include/hw/boards.h | 1 + includ

[PATCH v5 01/18] gdbstub, mcdstub: file and build structure adapted to accomodate for the mcdstub

2023-12-20 Thread Nicolas Eder
mcdstub files created including the shared header between the mcd shared library and the mcdstub. MAINTAINERS file updated --- MAINTAINERS | 11 +- debug/common/debug.c | 18 debug/common/meson.build | 0 {gdbstub => debug/

Re: [qemu-web PATCH] Add QEMU 8.2.0 release announcement

2023-12-20 Thread Stefan Hajnoczi
On Wed, 20 Dec 2023 at 11:18, Michael Roth wrote: > > Quoting Stefan Hajnoczi (2023-12-20 10:02:37) > > Cc: Michael Roth > > Signed-off-by: Stefan Hajnoczi > > --- > > _posts/2023-12-20-qemu-8-2-0.md | 29 + > > 1 file changed, 29 insertions(+) > > create mode 10064

Re: [PATCH v2] qdev: Report an error for machine without HotplugHandler

2023-12-20 Thread Zhao Liu
Hi Markus, On Wed, Dec 20, 2023 at 08:53:21AM +0100, Markus Armbruster wrote: > Date: Wed, 20 Dec 2023 08:53:21 +0100 > From: Markus Armbruster > Subject: Re: [PATCH v2] qdev: Report an error for machine without > HotplugHandler > > Akihiko Odaki writes: > > > On 2023/12/18 23:02, Markus Armb

Re: [qemu-web PATCH] Add QEMU 8.2.0 release announcement

2023-12-20 Thread Michael Roth
Quoting Stefan Hajnoczi (2023-12-20 10:32:53) > On Wed, 20 Dec 2023 at 11:18, Michael Roth wrote: > > > > Quoting Stefan Hajnoczi (2023-12-20 10:02:37) > > > Cc: Michael Roth > > > Signed-off-by: Stefan Hajnoczi > > > --- > > > _posts/2023-12-20-qemu-8-2-0.md | 29 +

Re: Qemu resets terminal to crazy defaults

2023-12-20 Thread BALATON Zoltan
On Wed, 20 Dec 2023, Fabiano Rosas wrote: Warner Losh writes: On Tue, Dec 19, 2023, 1:55 PM Peter Maydell wrote: On Tue, 19 Dec 2023 at 19:40, Fabiano Rosas wrote: Dave Blanchard writes: Hello all, can you please help me to understand what Qemu is doing here? When connecting to the

Re: [PATCH for-9.0 v2 00/10] vfio: Introduce a VFIOIOMMUClass

2023-12-20 Thread Cédric Le Goater
On 12/19/23 07:58, Cédric Le Goater wrote: Hello, The VFIO object hierarchy has some constraints because each VFIO type has a dual nature: a VFIO nature for passthrough support and a bus nature (PCI, AP, CCW, Platform) for its initial presentation. It seemed the best approach made because multi-

Re: [PATCH] vfio/container: Replace basename with g_path_get_basename

2023-12-20 Thread Cédric Le Goater
On 12/20/23 14:53, Cédric Le Goater wrote: g_path_get_basename() is a portable utility function that has the advantage of not modifing the string argument. It also fixes a compile breakage with the Musl C library reported in [1]. [1] https://lore.kernel.org/all/20231212010228.2701544-1-raj.k...@

Re: [PATCH] vfio/container: Replace basename with g_path_get_basename

2023-12-20 Thread Cédric Le Goater
Hello, On 12/20/23 16:09, Zhao Liu wrote: Hi Cédric, On Wed, Dec 20, 2023 at 02:53:02PM +0100, Cédric Le Goater wrote: Date: Wed, 20 Dec 2023 14:53:02 +0100 From: Cédric Le Goater Subject: [PATCH] vfio/container: Replace basename with g_path_get_basename X-Mailer: git-send-email 2.43.0 g_pat

Re: [PULL 00/43] target-arm queue

2023-12-20 Thread Peter Maydell
On Wed, 20 Dec 2023 at 16:03, Stefan Hajnoczi wrote: > > Applied, thanks. > > Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any > user-visible changes. Should be https://wiki.qemu.org/ChangeLog/9.0 :-) (I have just created that page and the accompanying gitlab milestone

Re: [PULL 00/43] target-arm queue

2023-12-20 Thread Stefan Hajnoczi
On Wed, 20 Dec 2023 at 12:24, Peter Maydell wrote: > > On Wed, 20 Dec 2023 at 16:03, Stefan Hajnoczi wrote: > > > > Applied, thanks. > > > > Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any > > user-visible changes. > > Should be https://wiki.qemu.org/ChangeLog/9.0 :-)

Re: [PATCH v2 08/11] next-cube.c: move static old_scr2 variable to NeXTPC

2023-12-20 Thread Thomas Huth
Am Wed, 20 Dec 2023 13:16:38 + schrieb Mark Cave-Ayland : > Move the old_scr2 variable to NeXTPC so that the old SCR2 register state is > stored along with the current SCR2 state. > > Since the SCR2 register is 32-bits wide, convert old_scr2 to uint32_t and > update the SCR2 register access c

Re: [PATCH 1/1] docs/system/riscv: document acpi parameter of virt machine

2023-12-20 Thread Heinrich Schuchardt
On 20.12.23 07:57, Sunil V L wrote: On Tue, Dec 19, 2023 at 03:38:29PM +0100, Heinrich Schuchardt wrote: Since QEMU v8.0.0 the RISC-V virt machine has a switch to disable ACPI table generation. Add it to the documentation. Fixes: 168b8c29cedb ("hw/riscv/virt: Add a switch to disable ACPI") Sign

[PATCH v2 1/1] docs/system/riscv: document acpi parameter of virt machine

2023-12-20 Thread Heinrich Schuchardt
Since QEMU v8.0.0 the RISC-V virt machine has a switch to disable ACPI table generation. Add it to the documentation. Fixes: 168b8c29cedb ("hw/riscv/virt: Add a switch to disable ACPI") Signed-off-by: Heinrich Schuchardt --- v2: mention that acpi=on is the default --- docs/system/riscv/v

Re: [PATCH v2 08/11] next-cube.c: move static old_scr2 variable to NeXTPC

2023-12-20 Thread Mark Cave-Ayland
On 20/12/2023 19:20, Thomas Huth wrote: Am Wed, 20 Dec 2023 13:16:38 + schrieb Mark Cave-Ayland : Move the old_scr2 variable to NeXTPC so that the old SCR2 register state is stored along with the current SCR2 state. Since the SCR2 register is 32-bits wide, convert old_scr2 to uint32_t and

Re: [PATCH v2 1/1] docs/system/riscv: document acpi parameter of virt machine

2023-12-20 Thread Daniel Henrique Barboza
On 12/20/23 16:34, Heinrich Schuchardt wrote: Since QEMU v8.0.0 the RISC-V virt machine has a switch to disable ACPI table generation. Add it to the documentation. Fixes: 168b8c29cedb ("hw/riscv/virt: Add a switch to disable ACPI") Signed-off-by: Heinrich Schuchardt --- Reviewed-by: Daniel

Re: [PATCH for-9.0 v2 00/10] vfio: Introduce a VFIOIOMMUClass

2023-12-20 Thread Eric Farman
On Tue, 2023-12-19 at 07:58 +0100, Cédric Le Goater wrote: > Hello, > > The VFIO object hierarchy has some constraints because each VFIO type > has a dual nature: a VFIO nature for passthrough support and a bus > nature (PCI, AP, CCW, Platform) for its initial presentation. The above caught my at

Re: [PATCH] target/i386: Fix physical address truncation when PAE is enabled

2023-12-20 Thread Richard Henderson
On 12/20/23 22:03, Michael Brown wrote: For the default case, I think it would make sense to unconditionally truncate the address to 32 bits if paging is disabled.  (I am not sure why the original commit 33dfdb5 included a test for long mode, since I do not see how it is possible to get the CPU

Re: [PULL 00/19] First batch of misc patches for QEMU 9.0

2023-12-20 Thread Alex Bennée
Stefan Hajnoczi writes: > Applied, thanks. > > Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for > any user-visible changes. might need to change the template for that ;-) -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH RFC] linux-user: Allow gdbstub to ignore page protection

2023-12-20 Thread Richard Henderson
On 12/16/23 10:24, Ilya Leoshkevich wrote: @@ -377,22 +379,42 @@ int cpu_memory_rw_debug(CPUState *cpu, vaddr addr, flags = page_get_flags(page); if (!(flags & PAGE_VALID)) return -1; +prot = ((flags & PAGE_READ) ? PROT_READ : 0) | + ((flags

  1   2   3   >