[PATCH v9 4/9] machine: Print CPU model name instead of CPU type

The names of supported CPU models instead of CPU types should be printed when the user specified CPU type isn't supported, to be consistent with the output from '-cpu ?'. Correct the error messages to print CPU model names instead of CPU type names. Signed-off-by: Gavin Shan Reviewed-by: Philipp

[PATCH v9 3/9] machine: Improve is_cpu_type_supported()

It's no sense to check the CPU type when mc->valid_cpu_types[0] is NULL, which is a program error. Raise an assert on this. A precise hint for the error message is given when mc->valid_cpu_types[0] is the only valid entry. Besides, enumeration on mc->valid_cpu_types[0] when we have mutiple valid e

[PATCH v9 6/9] hw/arm/virt: Check CPU type in machine_run_board_init()

Set mc->valid_cpu_types so that the user specified CPU type can be validated in machine_run_board_init(). We needn't to do the check by ourselves. Signed-off-by: Gavin Shan Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/arm/virt.c | 62 +++

[PATCH] migration/dirtyrate: Remove an extra parameter

vcpu_dirty_stat_collect() has an unused parameter so remove it. Signed-off-by: Wafer --- migration/dirtyrate.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index 036ac017fc..62d86b8be2 100644 --- a/migration/dirtyrate.c

Re: [PULL 0/6] riscv-to-apply queue

On Sun, Nov 26, 2023 at 7:08 AM Michael Tokarev wrote: > > 22.11.2023 08:37, Alistair Francis wrote: > ..> > > Fourth RISC-V PR for 8.2 > > > > This is a few bug fixes for the 8.2 release > > > > * Add Zicboz block size to hwprobe >

Re: [PATCH] migration/dirtyrate: Remove an extra parameter

On Mon, Dec 4, 2023 at 9:23 AM Wafer wrote: > vcpu_dirty_stat_collect() has an unused parameter so remove it. > > Signed-off-by: Wafer > --- > migration/dirtyrate.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c > in

Re: [PATCH for-8.2] target/riscv/kvm: fix shadowing in kvm_riscv_(get|put)_regs_csr

On Mon, Dec 4, 2023 at 3:00 AM Philippe Mathieu-Daudé wrote: > > On 23/11/23 11:23, Philippe Mathieu-Daudé wrote: > > On 23/11/23 11:13, Daniel Henrique Barboza wrote: > >> KVM_RISCV_GET_CSR() and KVM_RISCV_SET_CSR() use an 'int ret' variable > >> that is used to do an early 'return' if ret > 0. B

Re: [PATCH v1 1/2] hw/cxl/device: read from register values in mdev_reg_read()

On Thu, 30 Nov 2023, Jonathan Cameron wrote: If you mean generally harden the code we haven't fixed up for big endian systems then fair enough - that indeed needs doing. Yes, that was a braino, sorry for the confusion. Tricky to be sure we got it all right though unless we have a big endian

Re: [PATCH-for-9.0 2/2] target/arm/kvm: Use generic kvm_supports_guest_debug()

On 12/2/23 00:32, Philippe Mathieu-Daudé wrote: Do not open-code the generic kvm_supports_guest_debug(). Signed-off-by: Philippe Mathieu-Daudé --- target/arm/kvm64.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) Reviewed-by: Gavin Shan

Re: [PATCH-for-9.0 1/2] accel/kvm: Expose kvm_supports_guest_debug() prototype

On 12/2/23 00:32, Philippe Mathieu-Daudé wrote: kvm_supports_guest_debug() should be accessible by KVM implementations. Signed-off-by: Philippe Mathieu-Daudé --- accel/kvm/kvm-cpus.h | 1 - include/sysemu/kvm.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Gavin Shan

Re: [PATCH-for-9.0 01/25] memory: Have memory_region_init_ram_flags_nomigrate() return a boolean

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/m

Re: [PATCH-for-9.0 02/25] memory: Have memory_region_init_ram_nomigrate() handler return a boolean

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/mem

Re: [PATCH-for-9.0 03/25] memory: Have memory_region_init_rom_nomigrate() handler return a boolean

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/m

Re: [PATCH-for-9.0 04/25] memory: Simplify memory_region_init_rom_nomigrate() calls

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Mechanical change using the following coccinelle script: @@ expression mr, owner, arg3, arg4, errp; @@ - memory_region_init_rom_nomigrate(mr, owner, arg3, arg4, &errp); if ( - errp + !memory_region_init_rom_nomigrate(mr, owner,

Re: [PATCH-for-9.0 05/25] memory: Simplify memory_region_init_ram_from_fd() calls

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Mechanical change using the following coccinelle script: @@ expression mr, owner, arg3, arg4, arg5, arg6, arg7, errp; @@ - memory_region_init_ram_from_fd(mr, owner, arg3, arg4, arg5, arg6, arg7, &errp); if ( - errp + !memory_re

Re: [PATCH-for-9.0 06/25] memory: Have memory_region_init_ram() handler return a boolean

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/mem

Re: [PATCH-for-9.0 07/25] memory: Have memory_region_init_rom() handler return a boolean

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/m

Re: [PATCH-for-9.0 08/25] memory: Have memory_region_init_rom_device_nomigrate() return a boolean

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/mem

Re: [PATCH-for-9.0 09/25] memory: Simplify memory_region_init_rom_device_nomigrate() calls

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Mechanical change using the following coccinelle script: @@ expression mr, owner, arg3, arg4, arg5, arg6, errp; @@ - memory_region_init_rom_device_nomigrate(mr, owner, arg3, arg4, arg5, arg6, &errp); if ( - errp + !memory_regio

Re: [PATCH-for-9.0 10/25] memory: Have memory_region_init_rom_device() handler return a boolean

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/mem

Re: [PATCH-for-9.0 11/25] memory: Have memory_region_init_resizeable_ram() return a boolean

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/mem

Re: [PATCH-for-9.0 12/25] memory: Have memory_region_init_ram_from_file() handler return a boolean

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/mem

Re: [PATCH-for-9.0 13/25] memory: Have memory_region_init_ram_from_fd() handler return a boolean

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/mem

Re: [PATCH-for-9.0 14/25] backends: Use g_autofree in HostMemoryBackendClass::alloc() handlers

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: In preparation of having HostMemoryBackendClass::alloc() handlers return a boolean, have them use g_autofree. Signed-off-by: Philippe Mathieu-Daudé --- backends/hostmem-epc.c | 3 +-- backends/hostmem-file.c | 3 +-- backends/hostmem-memfd

Re: [PATCH-for-9.0 15/25] backends: Simplify host_memory_backend_memory_complete()

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Return early if bc->alloc is NULL. De-indent the if() ladder. Note, this avoids a pointless call to error_propagate() with errp=NULL at the 'out:' label. Change trivial when reviewed with 'git-diff --ignore-all-space'. Signed-off-by: Philippe Ma

Re: [PATCH-for-9.0 16/25] backends: Have HostMemoryBackendClass::alloc() handler return a boolean

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/h

Re: [PATCH-for-9.0 17/25] backends: Reduce variable scope in host_memory_backend_memory_complete

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Reduce the &local_err variable use and remove the 'out:' label. Signed-off-by: Philippe Mathieu-Daudé --- backends/hostmem.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Gavin Shan

Re: [PATCH-for-9.0 18/25] util/oslib: Have qemu_prealloc_mem() handler return a boolean

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/osd

Re: [PATCH-for-9.0 19/25] misc: Simplify qemu_prealloc_mem() calls

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- backends/hostmem.c | 22 +++--- hw/virtio/virtio-mem.c | 6 ++ 2 files changed, 9 insertions(+), 19 deletions(-) Reviewed-by: Gavin Shan

Re: [PATCH-for-9.0 20/25] hw: Simplify memory_region_init_ram() calls

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Mechanical change using the following coccinelle script: @@ expression mr, owner, arg3, arg4, errp; @@ - memory_region_init_ram(mr, owner, arg3, arg4, &errp); if ( - errp + !memory_region_init_ram(mr, owner, arg3, arg4, &errp)

Re: [PATCH-for-9.0 22/25] hw/sparc: Simplify memory_region_init_ram_nomigrate() calls

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Mechanical change using the following coccinelle script: @@ expression mr, owner, arg3, arg4, errp; @@ - memory_region_init_ram_nomigrate(mr, owner, arg3, arg4, &errp); if ( - errp + !memory_region_init_ram_nomigrate(mr, owner,

Re: [PATCH-for-9.0 21/25] hw/arm: Simplify memory_region_init_rom() calls

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Mechanical change using the following coccinelle script: @@ expression mr, owner, arg3, arg4, errp; @@ - memory_region_init_rom(mr, owner, arg3, arg4, &errp); if ( - errp + !memory_region_init_rom(mr, owner, arg3, arg4, &errp)

Re: [PATCH-for-9.0 23/25] hw/misc: Simplify memory_region_init_ram_from_fd() calls

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Mechanical change using the following coccinelle script: @@ expression mr, owner, arg3, arg4, arg5, arg6, arg7, errp; @@ - memory_region_init_ram_from_fd(mr, owner, arg3, arg4, arg5, arg6, arg7, &errp); if ( - errp + !memory_re

Re: [PATCH-for-9.0 25/25] hw/pci-host/raven: Propagate error in raven_realize()

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: When an Error** reference is available, it is better to propagate local errors, rather then using generic ones, which might terminate the whole QEMU process. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/raven.c | 6 -- 1 file chan

Re: [PATCH-for-9.0 24/25] hw/nvram: Simplify memory_region_init_rom_device() calls

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: Mechanical change using the following coccinelle script: @@ expression mr, owner, arg3, arg4, arg5, arg6, errp; @@ - memory_region_init_rom_device(mr, owner, arg3, arg4, arg5, arg6, &errp); if ( - errp + !memory_region_init_rom_

Re: [PATCH v3 05/70] kvm: Enable KVM_SET_USER_MEMORY_REGION2 for memslot

On 11/18/2023 4:50 AM, Isaku Yamahata wrote: On Wed, Nov 15, 2023 at 02:14:14AM -0500, Xiaoyao Li wrote: From: Chao Peng Switch to KVM_SET_USER_MEMORY_REGION2 when supported by KVM. With KVM_SET_USER_MEMORY_REGION2, QEMU can set up memory region that backend'ed both by hva-based shared memo

RE: [PATCH v2 3/4] configure: add qpl option

> -Original Message- > From: Fabiano Rosas > Sent: Saturday, December 2, 2023 1:45 AM > To: Liu, Yuan1 ; quint...@redhat.com; > pet...@redhat.com; leob...@redhat.com > Cc: qemu-devel@nongnu.org; Liu, Yuan1 ; Zou, Nanhai > > Subject: Re: [PATCH v2 3/4] configure: add qpl option > > Yuan L

[PATCH for 8.2] hw/audio/virtio-sound: mark the device as unmigratable

The virtio-sound device is currently not migratable. QEMU crashes on the source machine at some point during the migration with a segmentation fault. Even with this bug fixed, the virtio-sound device doesn't migrate the state of the audio streams. For example, running streams leave the device on t

Re: [PATCH for-8.2] ui/vnc-clipboard: fix inflate_buffer

Hi On Tue, Nov 28, 2023 at 2:52 PM Marc-André Lureau wrote: > > Hi > > On Mon, Nov 27, 2023 at 2:52 PM Fiona Ebner wrote: > > > > Am 27.11.23 um 10:15 schrieb Marc-André Lureau: > > > > > > It seems like a bug in tigervnc then. For some reason, the compressed > > > data doesn't trigger Z_STREAM_

Re: [PATCH v3 07/70] physmem: Relax the alignment check of host_startaddr in ram_block_discard_range()

On 11/20/2023 5:56 PM, David Hildenbrand wrote: On 16.11.23 03:56, Xiaoyao Li wrote: On 11/16/2023 2:20 AM, David Hildenbrand wrote: On 15.11.23 08:14, Xiaoyao Li wrote: Commit d3a5038c461 ("exec: ram_block_discard_range") introduced ram_block_discard_range() which grabs some code from ram_dis

Re: [PATCH v3 08/70] physmem: replace function name with __func__ in ram_block_discard_range()

On 11/16/2023 2:21 AM, David Hildenbrand wrote: On 15.11.23 08:14, Xiaoyao Li wrote: Use __func__ to avoid hard-coded function name. Signed-off-by: Xiaoyao Li --- That can be queued independently. Will you queue it for 9.0? for someone else? Do I need to send it separately? Reviewed-by:

Re: [PATCH for 8.2] hw/audio/virtio-sound: mark the device as unmigratable

Am 04.12.23 um 08:28 schrieb Volker Rümelin: > The virtio-sound device is currently not migratable. QEMU crashes > on the source machine at some point during the migration with a > segmentation fault. > > Even with this bug fixed, the virtio-sound device doesn't migrate > the state of the audio st

Re: [PATCH v3 07/70] physmem: Relax the alignment check of host_startaddr in ram_block_discard_range()

On 12/4/2023 3:35 PM, Xiaoyao Li wrote: On 11/20/2023 5:56 PM, David Hildenbrand wrote: On 16.11.23 03:56, Xiaoyao Li wrote: On 11/16/2023 2:20 AM, David Hildenbrand wrote: On 15.11.23 08:14, Xiaoyao Li wrote: Commit d3a5038c461 ("exec: ram_block_discard_range") introduced ram_block_discard_r

Re: [PATCH 1/3] hw/virtio: check owner for removing objects

On Tue, Nov 7, 2023 at 1:37 PM Albert Esteve wrote: > > Shared objects lack spoofing protection. > For VHOST_USER_BACKEND_SHARED_OBJECT_REMOVE messages > received by the vhost-user interface, any backend was > allowed to remove entries from the shared table just > by knowing the UUID. Only the own

Re: [PATCH v2 6/7] gitlab: build the correct microblaze target

On 01/12/2023 10.36, Alex Bennée wrote: We inadvertently built the LE target for BE tests. Fixes: 78ebc00b06 (gitlab: shuffle some targets and reduce avocado noise) Signed-off-by: Alex Bennée --- .gitlab-ci.d/buildtest.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.

<    1   2   3