[PULL 2/9] block: Fix bdrv_graph_wrlock() call in blk_remove_bs()

2023-11-21 Thread Kevin Wolf
While not all callers of blk_remove_bs() are correct in this respect, the assumption in the function is that callers hold the AioContext lock of the BlockBackend (this is required by the drain calls in it). In order to avoid deadlock in the nested event loop, bdrv_graph_wrlock() has then to be cal

[PULL 7/9] ide/pci: introduce pci_ide_update_mode() function

2023-11-21 Thread Kevin Wolf
From: Mark Cave-Ayland This function reads the value of the PCI_CLASS_PROG register for PCI IDE controllers and configures the PCI BARs and/or IDE ioports accordingly. In the case where we switch to legacy mode, the PCI BARs are set to return zero (as suggested in the "PCI IDE Controller" specif

[PULL 6/9] ide/ioport: move ide_portio_list[] and ide_portio_list2[] definitions to IDE core

2023-11-21 Thread Kevin Wolf
From: Mark Cave-Ayland These definitions are present in ioport.c which is currently only available when CONFIG_IDE_ISA is enabled. Move them to the IDE core so that they can be made available to PCI IDE controllers that support switching to legacy mode. Signed-off-by: Mark Cave-Ayland Message-I

[PULL 5/9] iotests: Test two stream jobs in a single iothread

2023-11-21 Thread Kevin Wolf
This tests two parallel stream jobs that will complete around the same time and run on two different disks in the same iothreads. It is loosely based on the bug report at https://issues.redhat.com/browse/RHEL-1761. For me, this test hangs reliably with the originally reported bug in blk_remove_bs(

[PULL for-8.2 0/2] xenfv queue

2023-11-21 Thread David Woodhouse
pull-xenfv-20231121 for you to fetch changes up to 6f7997e0047e57a9e4f6a0958569f480d07f6538: hw/xen: clean up xen_block_find_free_vdev() to avoid Coverity false positive (2023-11-21 11:45:06 +) Xen fixes for 8.2-rc1 • Disab

[PULL for-8.2 1/2] vl: disable default serial when xen-console is enabled

2023-11-21 Thread David Woodhouse
From: David Woodhouse If a Xen console is configured on the command line, do not add a default serial port. Signed-off-by: David Woodhouse Reviewed-by: Marc-André Lureau Reviewed-by: Paul Durrant --- system/vl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/system/vl.c b/system/vl.c in

[PULL for-8.2 2/2] hw/xen: clean up xen_block_find_free_vdev() to avoid Coverity false positive

2023-11-21 Thread David Woodhouse
From: David Woodhouse Coverity couldn't see that nr_existing was always going to be zero when qemu_xen_xs_directory() returned NULL in the ENOENT case (CID 1523906). Perhaps more to the point, neither could Peter at first glance. Improve the code to hopefully make it clearer to Coverity and huma

Re: [PATCH-for-9.0 02/25] memory: Have memory_region_init_ram_nomigrate() handler return a boolean

2023-11-21 Thread Manos Pitsidianakis
On Mon, 20 Nov 2023 23:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/e

Re: [PATCH-for-9.0 01/25] memory: Have memory_region_init_ram_flags_nomigrate() return a boolean

2023-11-21 Thread Manos Pitsidianakis
On Mon, 20 Nov 2023 23:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/e

Re: [PATCH-for-9.0 03/25] memory: Have memory_region_init_rom_nomigrate() handler return a boolean

2023-11-21 Thread Manos Pitsidianakis
On Mon, 20 Nov 2023 23:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/e

Re: [PATCH-for-9.0 05/25] memory: Simplify memory_region_init_ram_from_fd() calls

2023-11-21 Thread Manos Pitsidianakis
On Mon, 20 Nov 2023 23:32, Philippe Mathieu-Daudé wrote: Mechanical change using the following coccinelle script: @@ expression mr, owner, arg3, arg4, arg5, arg6, arg7, errp; @@ - memory_region_init_ram_from_fd(mr, owner, arg3, arg4, arg5, arg6, arg7, &errp); if ( - errp + !me

Re: [PATCH-for-9.0 07/25] memory: Have memory_region_init_rom() handler return a boolean

2023-11-21 Thread Manos Pitsidianakis
On Mon, 20 Nov 2023 23:32, Philippe Mathieu-Daudé wrote: Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/e

Re: [PATCH 02/19] qapi/schema: add pylint suppressions

2023-11-21 Thread Markus Armbruster
John Snow writes: > With this, pylint is happy with the file, so enable it in the > configuration. > > Signed-off-by: John Snow > --- > scripts/qapi/pylintrc | 5 - > scripts/qapi/schema.py | 4 > 2 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/scripts/qapi/pylintrc

Re: [PATCH 06/12] hw/xen: add get_frontend_path() method to XenDeviceClass

2023-11-21 Thread David Woodhouse
On Tue, 2023-10-24 at 14:29 +0100, David Woodhouse wrote: > > > > As a general rule (I'll be doing a bombing run on xen-bus once I get my > > > patch queue down into single digits) we should never check 'if (*errp)' > > > to check if a function had an error. It should *also* return a success > > >

Re: [PATCH v2 1/2] target/riscv/cpu_helper.c: Invalid exception on MMU translation stage

2023-11-21 Thread Daniel Henrique Barboza
On 11/21/23 04:17, Ivan Klokov wrote: According to RISCV privileged spec sect. 5.3.2 Virtual Address Translation Process access-fault exceptions may raise only after PMA/PMP check. Current implementation generates an access-fault for mbare mode even if there were no PMA/PMP errors. This patc

Re: [PATCH v2 2/2] target/riscv/cpu_helper.c: Fix mxr bit behavior

2023-11-21 Thread Daniel Henrique Barboza
On 11/21/23 04:17, Ivan Klokov wrote: According to RISCV Specification sect 9.5 on two stage translation when V=1 the vsstatus(mstatus in QEMU's terms) field MXR, which makes execute-only pages readable, only overrides VS-stage page protection. Setting MXR at HS-level(mstatus_hs), however, ove

QEMU developers fortnightly conference call for agenda for 2023-11-28

2023-11-21 Thread Juan Quintela
Hi This is a call for topics for the agenda for 2023-11-28. I have asked Steven Sistare to describe its plans for merging patches for CPR and other updates in place. Later, Juan. QEMU developers fortnightly conference call Tuesday 2023-11-28 ⋅ 15:00 – 16:00 Central European Time - Madrid Loc

Re: [PATCH 03/19] qapi/schema: name QAPISchemaInclude entities

2023-11-21 Thread Markus Armbruster
John Snow writes: > It simplifies typing to mandate that entities will always have a name; > to achieve this we can occasionally assign an internal name. This > alleviates errors such as: > > qapi/schema.py:287: error: Argument 1 to "__init__" of > "QAPISchemaEntity" has incompatible type "None";

Re: [PATCH 05/19] qapi/schema: make c_type() and json_type() abstract methods

2023-11-21 Thread Markus Armbruster
John Snow writes: > These methods should always return a str, it's only the default abstract > implementation that doesn't. They can be marked "abstract" by raising > NotImplementedError(), which requires subclasses to override the method > with the proper return type. > > Signed-off-by: John Sno

Re: [PATCH 04/16] hw/uefi: add var-service-guid.c

2023-11-21 Thread Laszlo Ersek
On 11/15/23 16:12, Gerd Hoffmann wrote: > Add variables for a bunch of GUIDs we will need. > > Signed-off-by: Gerd Hoffmann > --- > hw/uefi/var-service-guid.c | 61 ++ > 1 file changed, 61 insertions(+) > create mode 100644 hw/uefi/var-service-guid.c > > dif

Re: [PATCH 05/19] qapi/schema: make c_type() and json_type() abstract methods

2023-11-21 Thread Daniel P . Berrangé
On Tue, Nov 21, 2023 at 02:36:54PM +0100, Markus Armbruster wrote: > John Snow writes: > > > These methods should always return a str, it's only the default abstract > > implementation that doesn't. They can be marked "abstract" by raising > > NotImplementedError(), which requires subclasses to o

Re: [PATCH 06/19] qapi/schema: adjust type narrowing for mypy's benefit

2023-11-21 Thread Markus Armbruster
John Snow writes: > We already take care to perform some type narrowing for arg_type and > ret_type, but not in a way where mypy can utilize the result. A simple > change to use a temporary variable helps the medicine go down. > > Signed-off-by: John Snow > --- > scripts/qapi/schema.py | 17 +++

Re: [PATCH v10 08/18] target/riscv: add rva22u64 profile definition

2023-11-21 Thread Jerry Shih
On Nov 3, 2023, at 21:46, Daniel Henrique Barboza wrote: > > +/* > + * RVA22U64 defines some 'named features' or 'synthetic extensions' > + * that are cache related: Za64rs, Zic64b, Ziccif, Ziccrse, Ziccamoa > + * and Zicclsm. We do not implement caching in QEMU so we'll consider > + * all these

Re: [PATCH v10 08/18] target/riscv: add rva22u64 profile definition

2023-11-21 Thread Jerry Shih
On Nov 3, 2023, at 21:46, Daniel Henrique Barboza wrote: > QEMU implements all possible extensions of this profile. All the so > called 'synthetic extensions' described in the profile that are cache > related are ignored/assumed enabled (Za64rs, Zic64b, Ziccif, Ziccrse, > Ziccamoa, Zicclsm) since

Re: [PATCH 07/19] qapi/introspect: assert schema.lookup_type did not fail

2023-11-21 Thread Markus Armbruster
John Snow writes: > lookup_type() is capable of returning None, but introspect.py isn't > prepared for that. (And rightly so, if these built-in types are absent, > something has gone hugely wrong.) > > RFC: This is slightly cumbersome as-is, but a patch at the end of this series > tries to addres

Re: [PATCH 08/19] qapi/schema: add static typing and assertions to lookup_type()

2023-11-21 Thread Markus Armbruster
John Snow writes: > This function is a bit hard to type as-is; mypy needs some assertions to > assist with the type narrowing. > > Signed-off-by: John Snow > --- > scripts/qapi/schema.py | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/scripts/qapi/schema.py b/sc

Re: [PATCH 10/19] qapi/schema: make QAPISchemaArrayType.element_type non-Optional

2023-11-21 Thread Markus Armbruster
John Snow writes: > This field should always be present and defined. Change this to be a > runtime @property that can emit an error if it's called prior to > check(). > > This helps simplify typing by avoiding the need to interrogate the value > for None at multiple callsites. > > RFC: Yes, this

Re: [PULL v2 25/30] Hexagon HVX (target/hexagon) instruction decoding

2023-11-21 Thread Peter Maydell
On Wed, 3 Nov 2021 at 21:17, Taylor Simpson wrote: > > Add new file to target/hexagon/meson.build > > Acked-by: Richard Henderson > Signed-off-by: Taylor Simpson Hi; Coverity points out a variable written to and then overwritten before it's ever used in this function (CID 1527408): > +stati

[PATCH] target/arm: Don't implement *32_EL2 registers when EL1 is AArch64 only

2023-11-21 Thread Peter Maydell
The system registers DBGVCR32_EL2, FPEXC32_EL2, DACR32_EL2 and IFSR32_EL2 are present only to allow an AArch64 EL2 or EL3 to read and write the contents of an AArch32-only system register. The architecture requires that they are present only when EL1 can be AArch32, but we implement them unconditi

[PATCH qemu 0/1] Implement the STM32L4x5 EXTI device

2023-11-21 Thread ~aminier
This patch allows to emulate the STM32L4x5 EXTI device. It implements register access and software interruptions. This is RFC since we had troubles to make all tests pass. More precisely, the line `g_assert_true(get_irq(GPIO_0_IRQ));` fails in the software interrupts test. No irq seems to be fired

[PATCH qemu 1/1] Implement STM32L4x5 EXTI

2023-11-21 Thread ~aminier
From: Arnaud Minier Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- hw/arm/Kconfig| 1 + hw/arm/stm32l4x5_soc.c| 65 +- hw/misc/Kconfig | 3 + hw/misc/meson.build | 1 + hw/misc/stm32l4x5_exti.c | 3

Re: [PATCH-for-9.0 01/25] memory: Have memory_region_init_ram_flags_nomigrate() return a boolean

2023-11-21 Thread Peter Xu
On Mon, Nov 20, 2023 at 10:32:35PM +0100, Philippe Mathieu-Daudé wrote: > Following the example documented since commit e3fe3988d7 ("error: > Document Error API usage rules"), have cpu_exec_realizefn() s/cpu_exec_realizefn/memory_region_init_ram_nomigrate/ Similar issue for initial 3 patches (or

Re: [PATCH-for-9.0 04/25] memory: Simplify memory_region_init_rom_nomigrate() calls

2023-11-21 Thread Peter Xu
On Mon, Nov 20, 2023 at 10:32:38PM +0100, Philippe Mathieu-Daudé wrote: > Mechanical change using the following coccinelle script: > > @@ > expression mr, owner, arg3, arg4, errp; > @@ > - memory_region_init_rom_nomigrate(mr, owner, arg3, arg4, &errp); > if ( > - errp > + !memory

Re: [PATCH-for-9.0 06/25] memory: Have memory_region_init_ram() handler return a boolean

2023-11-21 Thread Peter Xu
On Mon, Nov 20, 2023 at 10:32:40PM +0100, Philippe Mathieu-Daudé wrote: > Following the example documented since commit e3fe3988d7 ("error: > Document Error API usage rules"), have cpu_exec_realizefn() (same) > return a boolean indicating whether an error is set or not. > > Signed-off-by: Philip

Re: [PATCH-for-9.0 08/25] memory: Have memory_region_init_rom_device_nomigrate() return a boolean

2023-11-21 Thread Peter Xu
On Mon, Nov 20, 2023 at 10:32:42PM +0100, Philippe Mathieu-Daudé wrote: > Following the example documented since commit e3fe3988d7 ("error: > Document Error API usage rules"), have cpu_exec_realizefn() same > return a boolean indicating whether an error is set or not. > > Signed-off-by: Philippe

Re: [PATCH-for-9.0 09/25] memory: Simplify memory_region_init_rom_device_nomigrate() calls

2023-11-21 Thread Peter Xu
On Mon, Nov 20, 2023 at 10:32:43PM +0100, Philippe Mathieu-Daudé wrote: > Mechanical change using the following coccinelle script: > > @@ > expression mr, owner, arg3, arg4, arg5, arg6, errp; > @@ > - memory_region_init_rom_device_nomigrate(mr, owner, arg3, arg4, arg5, > arg6, &errp); > if

Re: [PATCH-for-9.0 10/25] memory: Have memory_region_init_rom_device() handler return a boolean

2023-11-21 Thread Peter Xu
On Mon, Nov 20, 2023 at 10:32:44PM +0100, Philippe Mathieu-Daudé wrote: > Following the example documented since commit e3fe3988d7 ("error: > Document Error API usage rules"), have cpu_exec_realizefn() same > return a boolean indicating whether an error is set or not. > > Signed-off-by: Philippe

Re: [PATCH-for-9.0 11/25] memory: Have memory_region_init_resizeable_ram() return a boolean

2023-11-21 Thread Peter Xu
On Mon, Nov 20, 2023 at 10:32:45PM +0100, Philippe Mathieu-Daudé wrote: > Following the example documented since commit e3fe3988d7 ("error: > Document Error API usage rules"), have cpu_exec_realizefn() same > return a boolean indicating whether an error is set or not. > > Signed-off-by: Philippe

Re: [PATCH-for-9.0 13/25] memory: Have memory_region_init_ram_from_fd() handler return a boolean

2023-11-21 Thread Peter Xu
On Mon, Nov 20, 2023 at 10:32:47PM +0100, Philippe Mathieu-Daudé wrote: > Following the example documented since commit e3fe3988d7 ("error: > Document Error API usage rules"), have cpu_exec_realizefn() > return a boolean indicating whether an error is set or not. > > Signed-off-by: Philippe Mathie

Re: [PATCH-for-9.0 12/25] memory: Have memory_region_init_ram_from_file() handler return a boolean

2023-11-21 Thread Peter Xu
On Mon, Nov 20, 2023 at 10:32:46PM +0100, Philippe Mathieu-Daudé wrote: > Following the example documented since commit e3fe3988d7 ("error: > Document Error API usage rules"), have cpu_exec_realizefn() > return a boolean indicating whether an error is set or not. > > Signed-off-by: Philippe Mathie

Re: [PATCH-for-9.0 18/25] util/oslib: Have qemu_prealloc_mem() handler return a boolean

2023-11-21 Thread Peter Xu
On Mon, Nov 20, 2023 at 10:32:52PM +0100, Philippe Mathieu-Daudé wrote: > Following the example documented since commit e3fe3988d7 ("error: > Document Error API usage rules"), have cpu_exec_realizefn() > return a boolean indicating whether an error is set or not. > > Signed-off-by: Philippe Mathie

Re: [PULL 0/3] Net patches

2023-11-21 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/1] loongarch fixes for 8.2

2023-11-21 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/4] ppc queue

2023-11-21 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/5] Ui patches

2023-11-21 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/8] target-arm queue

2023-11-21 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH] Revert "tests/avocado: Enable reverse_debugging.py tests in gitlab CI"

2023-11-21 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH qemu 0/1] Implement the STM32L4x5 EXTI device

2023-11-21 Thread Philippe Mathieu-Daudé
Hi Arnaud, On 21/11/23 15:56, ~aminier wrote: This patch allows to emulate the STM32L4x5 EXTI device. It implements register access and software interruptions. Based-on: <170049810484.22920.61207457697187832...@git.sr.ht> ([RFC v3 2/2] hw/arm: Add minimal support for the B-L475E-IOT01A board

[PATCH v3] tests/tcg: finesse the registers check for "hidden" regs

2023-11-21 Thread Alex Bennée
The reason the ppc64 and s390x test where failing was because gdb hides them although they are still accessible via regnum. We can re-arrange the test a little bit and include these two arches in our test. We also need to be a bit more careful handling remote-registers as the format isn't easily p

Re: [PATCH] system: Use &error_abort in memory_region_init_ram_[device_]ptr()

2023-11-21 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH] configure: Make only once with pseudo-"in source tree" builds

2023-11-21 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH] avocado: fix Python invalid escape sequence

2023-11-21 Thread Paolo Bonzini
Queued, thanks. Paolo

RE: [PULL v2 25/30] Hexagon HVX (target/hexagon) instruction decoding

2023-11-21 Thread Brian Cain
> -Original Message- > From: qemu-devel-bounces+bcain=quicinc@nongnu.org bounces+bcain=quicinc@nongnu.org> On Behalf Of Peter Maydell > Sent: Tuesday, November 21, 2023 8:33 AM > To: Taylor Simpson > Cc: qemu-devel@nongnu.org; richard.hender...@linaro.org; f4...@amsat.org > Subj

[PULL 0/1] linux-user late fix

2023-11-21 Thread Richard Henderson
The following changes since commit c14ae763d548842c6abd1afaf5dc7ce7322ed901: Merge tag 'ui-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2023-11-21 06:25:14 -0500) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-l

[PULL 1/1] linux-user: Fix loaddr computation for some elf files

2023-11-21 Thread Richard Henderson
The file offset of the load segment is not relevant to the low address, only the beginning of the virtual address page. Cc: qemu-sta...@nongnu.org Fixes: a93934fecd4 ("elf: take phdr offset into account when calculating the program load address") Resolves: https://gitlab.com/qemu-project/qemu/-/i

Re: [PATCH 00/16] hw/uefi: add uefi variable service

2023-11-21 Thread Laszlo Ersek
On 11/20/23 17:50, Gerd Hoffmann wrote: > On Mon, Nov 20, 2023 at 12:53:45PM +0100, Alexander Graf wrote: >> Hey Gerd! >> >> On 15.11.23 16:12, Gerd Hoffmann wrote: >>> This patch adds a virtual device to qemu which the uefi firmware can use >>> to store variables. This moves the UEFI variable man

Re: [PATCH 00/16] hw/uefi: add uefi variable service

2023-11-21 Thread Daniel P . Berrangé
On Tue, Nov 21, 2023 at 04:58:44PM +0100, Laszlo Ersek wrote: > On 11/20/23 17:50, Gerd Hoffmann wrote: > > On Mon, Nov 20, 2023 at 12:53:45PM +0100, Alexander Graf wrote: > >> Hey Gerd! > >> > >> On 15.11.23 16:12, Gerd Hoffmann wrote: > >>> This patch adds a virtual device to qemu which the uefi

Re: [PATCH v3] hw/i386: fix short-circuit logic with non-optimizing builds

2023-11-21 Thread Eric Blake
On Mon, Nov 20, 2023 at 11:20:52AM +0100, Philippe Mathieu-Daudé wrote: > (Cc'ing Eric) > > On 20/11/23 10:28, Michael S. Tsirkin wrote: > > On Sun, Nov 19, 2023 at 07:34:58PM -0600, Dan Hoffman wrote: > > > As far as I can tell, yes. Any optimization level above O0 does not have > > > this > > >

Re: [PATCH 03/19] qapi/schema: name QAPISchemaInclude entities

2023-11-21 Thread John Snow
On Tue, Nov 21, 2023, 8:33 AM Markus Armbruster wrote: > John Snow writes: > > > It simplifies typing to mandate that entities will always have a name; > > to achieve this we can occasionally assign an internal name. This > > alleviates errors such as: > > > > qapi/schema.py:287: error: Argument

Re: [PATCH 05/19] qapi/schema: make c_type() and json_type() abstract methods

2023-11-21 Thread John Snow
On Tue, Nov 21, 2023, 8:43 AM Daniel P. Berrangé wrote: > On Tue, Nov 21, 2023 at 02:36:54PM +0100, Markus Armbruster wrote: > > John Snow writes: > > > > > These methods should always return a str, it's only the default > abstract > > > implementation that doesn't. They can be marked "abstract"

Re: [PATCH 05/19] qapi/schema: make c_type() and json_type() abstract methods

2023-11-21 Thread Daniel P . Berrangé
On Tue, Nov 21, 2023 at 11:28:17AM -0500, John Snow wrote: > On Tue, Nov 21, 2023, 8:43 AM Daniel P. Berrangé > wrote: > > > On Tue, Nov 21, 2023 at 02:36:54PM +0100, Markus Armbruster wrote: > > > John Snow writes: > > > > > > > These methods should always return a str, it's only the default >

Re: [PATCH v4 03/11] ppc/pnv: New powernv10-rainier machine type

2023-11-21 Thread Miles Glenn
On Tue, 2023-11-21 at 08:29 +0100, Cédric Le Goater wrote: > On 11/21/23 02:33, Nicholas Piggin wrote: > > On Tue Nov 21, 2023 at 9:51 AM AEST, Glenn Miles wrote: > > > Create a new powernv machine type, powernv10-rainier, that > > > will contain rainier-specific devices. > > > > Is the plan to ha

Re: [PATCH 06/19] qapi/schema: adjust type narrowing for mypy's benefit

2023-11-21 Thread John Snow
On Tue, Nov 21, 2023, 9:09 AM Markus Armbruster wrote: > John Snow writes: > > > We already take care to perform some type narrowing for arg_type and > > ret_type, but not in a way where mypy can utilize the result. A simple > > change to use a temporary variable helps the medicine go down. > >

RE: Instruction virtual address in TCG Plugins

2023-11-21 Thread Mikhail Tyutin
> >> > I suspect it is because of memory mappings by guest OS that changes > >> > virtual addresses for that block. > >> > > >> > I also looked at gen_empty_udata_cb() function and considered to extend > >> > plugin API to pass a program counter > >> > value as additional callback argument. I tho

Re: [PATCH 07/19] qapi/introspect: assert schema.lookup_type did not fail

2023-11-21 Thread John Snow
On Tue, Nov 21, 2023, 9:17 AM Markus Armbruster wrote: > John Snow writes: > > > lookup_type() is capable of returning None, but introspect.py isn't > > prepared for that. (And rightly so, if these built-in types are absent, > > something has gone hugely wrong.) > > > > RFC: This is slightly cum

Re: [PATCH 08/19] qapi/schema: add static typing and assertions to lookup_type()

2023-11-21 Thread John Snow
On Tue, Nov 21, 2023, 9:21 AM Markus Armbruster wrote: > John Snow writes: > > > This function is a bit hard to type as-is; mypy needs some assertions to > > assist with the type narrowing. > > > > Signed-off-by: John Snow > > --- > > scripts/qapi/schema.py | 8 ++-- > > 1 file changed, 6

Re: [PATCH 10/19] qapi/schema: make QAPISchemaArrayType.element_type non-Optional

2023-11-21 Thread John Snow
On Tue, Nov 21, 2023, 9:28 AM Markus Armbruster wrote: > John Snow writes: > > > This field should always be present and defined. Change this to be a > > runtime @property that can emit an error if it's called prior to > > check(). > > > > This helps simplify typing by avoiding the need to inter

Re: [PULL 0/9] Block layer fixes for 8.2.0-rc1

2023-11-21 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL for-8.2 0/2] xenfv queue

2023-11-21 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH] Revert "tests/avocado: Enable reverse_debugging.py tests in gitlab CI"

2023-11-21 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

[PATCH] scripts: adjust url to Coverity tools

2023-11-21 Thread Paolo Bonzini
The URL to the Coverity tools download has changed; the old one points to an obsolete version that is not supported anymore. Adjust to point to the correct and supported tools. Suggested-by: Peter Maydell Signed-off-by: Paolo Bonzini --- scripts/coverity-scan/run-coverity-scan | 4 ++-- 1 file

Re: QEMU Summit Minutes 2023

2023-11-21 Thread Alex Bennée
Peter Maydell writes: > QEMU Summit Minutes 2023 > > > As usual, we held a QEMU Summit meeting at KVM Forum. This is an > invite-only meeting for the most active maintainers and submaintainers > in the project, and we discuss various project-wide issues, usually > proces

Re: [PATCH v7 00/27] vfio: Adopt iommufd

2023-11-21 Thread Cédric Le Goater
Hello Zhenzhong On 11/21/23 09:43, Zhenzhong Duan wrote: Hi, Thanks all for giving guides and comments on previous series, this is the remaining part of the iommufd support. Besides suggested changes in v6, I'd like to highlight two changes for final review: 1. Instantiate can_be_deleted callb

Re: Instruction virtual address in TCG Plugins

2023-11-21 Thread Alex Bennée
Mikhail Tyutin writes: >> >> > I suspect it is because of memory mappings by guest OS that changes >> >> > virtual addresses for that block. >> >> > >> >> > I also looked at gen_empty_udata_cb() function and considered to extend >> >> > plugin API to pass a program counter >> >> > value as addi

Re: [PATCH] scripts: adjust url to Coverity tools

2023-11-21 Thread Peter Maydell
On Tue, 21 Nov 2023 at 17:05, Paolo Bonzini wrote: > > The URL to the Coverity tools download has changed; the old one points > to an obsolete version that is not supported anymore. Adjust to point > to the correct and supported tools. > > Suggested-by: Peter Maydell > Signed-off-by: Paolo Bonzi

[PATCH for-8.2 2/2] string-output-visitor: Support lists for non-integer types

2023-11-21 Thread Kevin Wolf
With the introduction of list-based array properties in qdev, the string output visitor has to deal with lists of non-integer elements now ('info qtree' prints all properties with the string output visitor). Currently there is no explicit support for such lists, and the resulting output is only th

[PATCH for-8.2 1/2] qdev: Fix crash in array property getter

2023-11-21 Thread Kevin Wolf
Passing an uninitialised list to visit_start_list() happens to work for the QObject output visitor because it treats the pointer as an opaque value and never dereferences it, but the string output visitor expects a valid list to check if it has more than one element. The existing code crashes with

[PATCH for-8.2 0/2] qdev array property fixes

2023-11-21 Thread Kevin Wolf
Kevin Wolf (2): qdev: Fix crash in array property getter string-output-visitor: Support lists for non-integer types hw/core/qdev-properties.c| 33 ++--- qapi/string-output-visitor.c | 24 2 files changed, 46 insertions(+), 11 deletions(

[PATCH-for-8.2? 2/6] hw/virtio: Free VirtIOIOMMUPCI::vdev.reserved_regions[] on finalize()

2023-11-21 Thread Philippe Mathieu-Daudé
Commit 0be6bfac62 ("qdev: Implement variable length array properties") added the DEFINE_PROP_ARRAY() macro with the following comment: * It is the responsibility of the device deinit code to free the * @_arrayfield memory. Commit 8077b8e549 added: DEFINE_PROP_ARRAY("reserved-regions", Virt

[PATCH-for-8.2 0/6] hw: Free DEFINE_PROP_ARRAY()'s arrays in instance_finalize()

2023-11-21 Thread Philippe Mathieu-Daudé
In few places we forget to free the array allocated by the DEFINE_PROP_ARRAY() macro handlers. Fix that. Philippe Mathieu-Daudé (6): hw/virtio: Add VirtioPCIDeviceTypeInfo::instance_finalize field hw/virtio: Free VirtIOIOMMUPCI::vdev.reserved_regions[] on finalize() hw/misc/mps2-scc: Free MP

[PATCH-for-8.2? 1/6] hw/virtio: Add VirtioPCIDeviceTypeInfo::instance_finalize field

2023-11-21 Thread Philippe Mathieu-Daudé
The VirtioPCIDeviceTypeInfo structure, added in commit a4ee4c8baa ("virtio: Helper for registering virtio device types") got extended in commit 8ea90ee690 ("virtio: add class_size") with the @class_size field. Do similarly with the @instance_finalize field. Signed-off-by: Philippe Mathieu-Daudé -

[PATCH-for-8.2? 5/6] hw/nvram/xlnx-efuse-ctrl: Free XlnxVersalEFuseCtrl[] "pg0-lock" array

2023-11-21 Thread Philippe Mathieu-Daudé
Commit 0be6bfac62 ("qdev: Implement variable length array properties") added the DEFINE_PROP_ARRAY() macro with the following comment: * It is the responsibility of the device deinit code to free the * @_arrayfield memory. Commit 9e4aa1fafe added: DEFINE_PROP_ARRAY("pg0-lock",

[PATCH-for-8.2? 4/6] hw/nvram/xlnx-efuse: Free XlnxEFuse::ro_bits[] array on finalize()

2023-11-21 Thread Philippe Mathieu-Daudé
Commit 0be6bfac62 ("qdev: Implement variable length array properties") added the DEFINE_PROP_ARRAY() macro with the following comment: * It is the responsibility of the device deinit code to free the * @_arrayfield memory. Commit 68fbcc344e added: DEFINE_PROP_ARRAY("read-only", XlnxEFuse,

[PATCH-for-8.2 6/6] hw/input/stellaris_gamepad: Free StellarisGamepad::keycodes[] array

2023-11-21 Thread Philippe Mathieu-Daudé
Commit 0be6bfac62 ("qdev: Implement variable length array properties") added the DEFINE_PROP_ARRAY() macro with the following comment: * It is the responsibility of the device deinit code to free the * @_arrayfield memory. Commit a75f336b97 added: DEFINE_PROP_ARRAY("keycodes", StellarisGam

[PATCH-for-8.2? 3/6] hw/misc/mps2-scc: Free MPS2SCC::oscclk[] array on finalize()

2023-11-21 Thread Philippe Mathieu-Daudé
Commit 0be6bfac62 ("qdev: Implement variable length array properties") added the DEFINE_PROP_ARRAY() macro with the following comment: * It is the responsibility of the device deinit code to free the * @_arrayfield memory. Commit 4fb013afcc added: DEFINE_PROP_ARRAY("oscclk", MPS2SCC, num_o

Re: [PATCH v4 03/11] ppc/pnv: New powernv10-rainier machine type

2023-11-21 Thread Miles Glenn
On Tue, 2023-11-21 at 07:46 +0100, Cédric Le Goater wrote: > On 11/21/23 00:51, Glenn Miles wrote: > > Create a new powernv machine type, powernv10-rainier, that > > will contain rainier-specific devices. > > > > Signed-off-by: Glenn Miles > > --- > > hw/ppc/pnv.c | 29 +

[ANNOUNCE] QEMU 7.2.7 Stable released

2023-11-21 Thread Michael Tokarev
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi everyone, The QEMU v7.2.7 stable release is now available. You can grab the tarball from our download page here: https://www.qemu.org/download/#source v7.2.7 is now tagged in the official qemu.git repository, and the stable-7.2 branch has be

[ANNOUNCE] QEMU 8.1.3 Stable released

2023-11-21 Thread Michael Tokarev
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi everyone, The QEMU v8.1.3 stable release is now available. You can grab the tarball from our download page here: https://www.qemu.org/download/#source v8.1.3 is now tagged in the official qemu.git repository, and the stable-8.1 branch has be

Re: [PATCH v4 03/11] ppc/pnv: New powernv10-rainier machine type

2023-11-21 Thread Cédric Le Goater
On 11/21/23 17:36, Miles Glenn wrote: On Tue, 2023-11-21 at 08:29 +0100, Cédric Le Goater wrote: On 11/21/23 02:33, Nicholas Piggin wrote: On Tue Nov 21, 2023 at 9:51 AM AEST, Glenn Miles wrote: Create a new powernv machine type, powernv10-rainier, that will contain rainier-specific devices.

Re: [PATCH v4 10/11] ppc/pnv: Add a pca9554 I2C device to powernv10-rainier

2023-11-21 Thread Cédric Le Goater
On 11/21/23 00:51, Glenn Miles wrote: For powernv10-rainier, the Power Hypervisor code expects to see a pca9554 device connected to the 3rd PNV I2C engine on port 1 at I2C address 0x25 (or left-justified address of 0x4A). This is used by the hypervisor code to detect if a "Cable Card" is present

Re: [PATCH v4 06/11] ppc/pnv: PNV I2C engines assigned incorrect XSCOM addresses

2023-11-21 Thread Cédric Le Goater
On 11/21/23 00:51, Glenn Miles wrote: The PNV I2C engines for power9 and power10 were being assigned a base XSCOM address that was off by one I2C engine's address range such that engine 0 had engine 1's address and so on. The xscom address assignment was being based on the device tree engine num

Re: [PATCH v4 07/11] ppc/pnv: Fix PNV I2C invalid status after reset

2023-11-21 Thread Cédric Le Goater
On 11/21/23 00:51, Glenn Miles wrote: The PNV I2C Controller was clearing the status register after a reset without repopulating the "upper threshold for I2C ports", "Command Complete" and the SCL/SDA input level fields. Fixed this for resets caused by a system reset as well as from writing to t

Re: [PATCH v4 08/11] ppc/pnv: Use resettable interface to reset child I2C buses

2023-11-21 Thread Cédric Le Goater
On 11/21/23 00:51, Glenn Miles wrote: The QEMU I2C buses and devices use the resettable interface for resetting while the PNV I2C controller and parent buses and devices have not yet transitioned to this new interface and use the old reset strategy. This was preventing the I2C buses and devices w

Re: [PATCH v4 03/11] ppc/pnv: New powernv10-rainier machine type

2023-11-21 Thread Cédric Le Goater
On 11/21/23 17:36, Miles Glenn wrote: On Tue, 2023-11-21 at 08:29 +0100, Cédric Le Goater wrote: On 11/21/23 02:33, Nicholas Piggin wrote: On Tue Nov 21, 2023 at 9:51 AM AEST, Glenn Miles wrote: Create a new powernv machine type, powernv10-rainier, that will contain rainier-specific devices.

Re: [PATCH v3] hw/i386: fix short-circuit logic with non-optimizing builds

2023-11-21 Thread Dan Hoffman
I'm writing a patch to clang's constant folding to address this case (doesn't seem too difficult). I'll either follow up with a link to some submissions I've made or a bug report on the project describing the issue. On Tue, Nov 21, 2023 at 10:15 AM Eric Blake wrote: > > On Mon, Nov 20, 2023 at

Re: [PATCH-for-8.2? 2/6] hw/virtio: Free VirtIOIOMMUPCI::vdev.reserved_regions[] on finalize()

2023-11-21 Thread Eric Auger
Hi Phil, On 11/21/23 18:40, Philippe Mathieu-Daudé wrote: > Commit 0be6bfac62 ("qdev: Implement variable length array properties") > added the DEFINE_PROP_ARRAY() macro with the following comment: > > * It is the responsibility of the device deinit code to free the > * @_arrayfield memory. > >

Re: [PATCH v4 03/11] ppc/pnv: New powernv10-rainier machine type

2023-11-21 Thread Miles Glenn
On Tue, 2023-11-21 at 19:26 +0100, Cédric Le Goater wrote: > On 11/21/23 17:36, Miles Glenn wrote: > > On Tue, 2023-11-21 at 08:29 +0100, Cédric Le Goater wrote: > > > On 11/21/23 02:33, Nicholas Piggin wrote: > > > > On Tue Nov 21, 2023 at 9:51 AM AEST, Glenn Miles wrote: > > > > > Create a new po

Re: [PATCH v4 05/11] ppc/pnv: Wire up pca9552 GPIO pins for PCIe hotplug power control

2023-11-21 Thread Cédric Le Goater
On 11/21/23 00:51, Glenn Miles wrote: For power10-rainier, a pca9552 device is used for PCIe slot hotplug power control by the Power Hypervisor code. The code expects that some time after it enables power to a PCIe slot by asserting one of the pca9552 GPIO pins 0-4, it should see a "power good"

Re: [PATCH v7 08/27] vfio/pci: Introduce a vfio pci hot reset interface

2023-11-21 Thread Philippe Mathieu-Daudé
Hi Zhenzhong, On 21/11/23 09:44, Zhenzhong Duan wrote: Legacy vfio pci and iommufd cdev have different process to hot reset vfio device, expand current code to abstract out pci_hot_reset callback for legacy vfio, this same interface will also be used by iommufd cdev vfio device. Rename vfio_pci

Re: [PATCH] target/arm: Don't implement *32_EL2 registers when EL1 is AArch64 only

2023-11-21 Thread Richard Henderson
On 11/21/23 08:46, Peter Maydell wrote: The system registers DBGVCR32_EL2, FPEXC32_EL2, DACR32_EL2 and IFSR32_EL2 are present only to allow an AArch64 EL2 or EL3 to read and write the contents of an AArch32-only system register. The architecture requires that they are present only when EL1 can b

<    1   2   3   >