Re: [PATCH v2 0/5] virtio-gpu: add blob migration support

2023-11-07 Thread Laszlo Ersek
On 11/6/23 11:44, Marc-André Lureau wrote: > Hi > > On Tue, Sep 19, 2023 at 7:09 PM Peter Xu wrote: >> >> On Tue, Sep 19, 2023 at 04:51:21PM +0400, Marc-André Lureau wrote: >>> Hi >>> >>> On Thu, Sep 7, 2023 at 5:15 PM wrote: From: Marc-André Lureau Hi, This is a f

[PULL 38/75] target/ppc: Move PowerPCCPUClass definition to 'cpu.h'

2023-11-07 Thread Philippe Mathieu-Daudé
The OBJECT_DECLARE_CPU_TYPE() macro forward-declares the PowerPCCPUClass type. This forward declaration is sufficient for code in hw/ to use the QOM definitions. No need to expose the structure definition. Keep it local to target/ppc/ by moving it to target/ppc/cpu.h. Suggested-by: Richard Henders

[PULL 40/75] target/ppc: Move powerpc_mmu_t definition to 'cpu.h'

2023-11-07 Thread Philippe Mathieu-Daudé
The powerpc_mmu_t definition is only used by target/ppc/, no need to expose it. Restrict it by moving it to "target/ppc/cpu.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Cédric Le Goater Message-Id: <20231013125630.95116-7-phi...@linaro.org> --- target/p

[PULL 00/75] Misc HW/UI patches for 2023-11-07

2023-11-07 Thread Philippe Mathieu-Daudé
The following changes since commit bb541a7068d2eee51a9abbe2dedcdf27298b1872: Merge tag 'pull-pa-20231106' of https://gitlab.com/rth7680/qemu into staging (2023-11-07 15:01:17 +0800) are available in the Git repository at: https://github.com/philmd/qemu.git tags/misc-cpus-2023110

[PULL 45/75] target/s390x/cpu: Restrict CPUS390XState declaration to 'cpu.h'

2023-11-07 Thread Philippe Mathieu-Daudé
"target/s390x/cpu-qom.h" has to be target-agnostic. However, it currently declares CPUS390XState, which is target-specific. Move that declaration to "cpu.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20231106114500.5269-5-phi...@linaro.org> --- target/s390x/cpu

[PULL 39/75] target/ppc: Move powerpc_excp_t definition to 'cpu.h'

2023-11-07 Thread Philippe Mathieu-Daudé
The powerpc_excp_t definition is only used by target/ppc/, no need to expose it. Restrict it by moving it to "target/ppc/cpu.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Cédric Le Goater Message-Id: <20231013125630.95116-6-phi...@linaro.org> --- target/

[PULL 36/75] target/ppc: Define powerpc_pm_insn_t in 'internal.h'

2023-11-07 Thread Philippe Mathieu-Daudé
PM instructions are only used by TCG helpers. No need to expose to other hardware. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Cédric Le Goater Message-Id: <20231013125630.95116-3-phi...@linaro.org> --- target/ppc/cpu-qom.h | 10 -- target/ppc/int

[PULL 42/75] hw/s390x/css: Have css_do_sic() take S390CPU instead of CPUS390XState

2023-11-07 Thread Philippe Mathieu-Daudé
"hw/s390x/css.h" is a header used by target-agnostic objects (such hw/s390x/virtio-ccw-gpu.c), thus can not use target-specific types, such CPUS390XState. Have css_do_sic() take S390CPU a pointer, which is target-agnostic. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-I

[PULL 73/75] MAINTAINERS: Add more guest-agent related files to the corresponding section

2023-11-07 Thread Philippe Mathieu-Daudé
From: Thomas Huth contrib/systemd/qemu-guest-agent.service, tests/data/test-qga-config and tests/data/test-qga-os-release belong to the guest agent, so make sure that these files are covered here, too. Signed-off-by: Thomas Huth Reviewed-by: Konstantin Kostiuk Message-ID: <20231107101811.14189

[PULL 68/75] hw/sd: Declare QOM types using DEFINE_TYPES() macro

2023-11-07 Thread Philippe Mathieu-Daudé
When multiple QOM types are registered in the same file, it is simpler to use the the DEFINE_TYPES() macro. In particular because type array declared with such macro are easier to review. Mechanical transformation using the following comby script: [pattern-x1] match=''' static const TypeInf

[PULL 37/75] target/ppc: Move ppc_cpu_class_by_name() declaration to 'cpu.h'

2023-11-07 Thread Philippe Mathieu-Daudé
ppc_cpu_class_by_name() is only called in target/ppc/, no need to expose outside (in particular to hw/). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Cédric Le Goater Message-Id: <20231013125630.95116-4-phi...@linaro.org> --- target/ppc/cpu-qom.h | 2 -- ta

[PULL 41/75] target/ppc: Move powerpc_input_t definition to 'cpu.h'

2023-11-07 Thread Philippe Mathieu-Daudé
The powerpc_input_t definition is only used by target/ppc/, no need to expose it. Restrict it by moving it to "target/ppc/cpu.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Cédric Le Goater Message-Id: <20231013125630.95116-8-phi...@linaro.org> --- target

[PULL 47/75] target: Move ArchCPUClass definition to 'cpu.h'

2023-11-07 Thread Philippe Mathieu-Daudé
The OBJECT_DECLARE_CPU_TYPE() macro forward-declares each ArchCPUClass type. These forward declarations are sufficient for code in hw/ to use the QOM definitions. No need to expose these structure definitions. Keep each local to their target/ by moving them to the corresponding "cpu.h" header. Sug

[PULL 51/75] hw/cpu: Clean up global variable shadowing

2023-11-07 Thread Philippe Mathieu-Daudé
Fix: hw/core/machine.c:1302:22: error: declaration shadows a variable in the global scope [-Werror,-Wshadow] const CPUArchId *cpus = possible_cpus->cpus; ^ hw/core/numa.c:69:17: error: declaration shadows a variable in the global scope [-Werror,-Wshadow] ui

[PULL 44/75] target/s390x/cpu: Restrict cpu_get_tb_cpu_state() definition to TCG

2023-11-07 Thread Philippe Mathieu-Daudé
cpu_get_tb_cpu_state() is TCG specific. Another accelerator calling it would be a bug, so restrict the definition to TCG, along with "tcg_s390x.h" header inclusion. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20231106114500.5269-4-phi...@linaro.org> --- target/s3

[PULL 43/75] hw/s390x/sclp: Have sclp_service_call[_protected]() take S390CPU*

2023-11-07 Thread Philippe Mathieu-Daudé
"hw/s390x/sclp.h" is a header used by target-agnostic objects (such hw/char/sclpconsole[-lm].c), thus can not use target-specific types, such CPUS390XState. Have sclp_service_call[_protected]() take a S390CPU pointer, which is target-agnostic. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: T

[PULL 72/75] MAINTAINERS: Add include/hw/xtensa/mx_pic.h to the XTFPGA machine section

2023-11-07 Thread Philippe Mathieu-Daudé
From: Thomas Huth These machines are the only user of the mx_pic code, so the header (which is currently "unmaintained" according to the MAINTAINERS file) should be added to this section. Signed-off-by: Thomas Huth Acked-by: Max Filippov Reviewed-by: Philippe Mathieu-Daudé Message-ID: <202311

[PULL 75/75] dump: Add close fd on error return to avoid resource leak

2023-11-07 Thread Philippe Mathieu-Daudé
From: Zongmin Zhou Reported-by: Coverity CID 1523842 (RESOURCE_LEAK) Fixes: e6549197f7 ("dump: Add command interface for kdump-raw formats") Signed-off-by: Zongmin Zhou Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20231107024417.585475-1-min_h...@163.com> Sig

Re: [PATCH 08/22] gdbstub: Add num_regs member to GDBFeature

2023-11-07 Thread Philippe Mathieu-Daudé
On 7/11/23 11:24, Alex Bennée wrote: Philippe Mathieu-Daudé writes: Hi Alex, On 6/11/23 19:50, Alex Bennée wrote: From: Akihiko Odaki Currently the number of registers exposed to GDB is written as magic numbers in code. Derive the number of registers GDB actually see from XML files to repla

Re: [PATCH 14/22] plugins: make test/example plugins work on windows

2023-11-07 Thread Greg Manning
> > A bit more important: would it make sense to include the hook *in the > > QEMU executable itself*, rather than in the DLL? If it works, it would > > be much preferrable. You still would have to add the .lib file to the > > compilation, but win32_linker.c could simply be placed in os-win32.c >

[PATCH v5] limit physical address space size

2023-11-07 Thread Gerd Hoffmann
For better compatibility with old linux kernels, see source code comment. Related (same problem in ovmf): https://github.com/tianocore/edk2/commit/c1e853769046 Cc: Claudio Fontana Signed-off-by: Gerd Hoffmann --- src/fw/paravirt.c | 8 1 file changed, 8 insertions(+) diff --git a/src

[PATCH v3 01/20] mcdstub: initial file structure for new mcdstub created. -mcd QEMU startup option added. Functions for initializing the mcdstub added. Basic helper functions for processes/cpus in the

2023-11-07 Thread Nicolas Eder
--- include/mcdstub/arm_mcdstub.h| 10 + include/mcdstub/mcdstub.h| 239 +++ include/mcdstub/mcdstub_common.h | 7 + mcdstub/mcdstub.c| 383 +++ qemu-options.hx | 18 ++ system/vl.c |

[PATCH v3 07/20] mcdstub: quitting QEMU via mcd command added

2023-11-07 Thread Nicolas Eder
--- include/mcdstub/mcdstub.h | 9 + mcdstub/mcdstub.c | 15 +++ 2 files changed, 24 insertions(+) diff --git a/include/mcdstub/mcdstub.h b/include/mcdstub/mcdstub.h index c7e34673a6..c3e9c7e9dc 100644 --- a/include/mcdstub/mcdstub.h +++ b/include/mcdstub/mcdstub.h @@

[PATCH v3 20/20] mcdstub: updated MAINTAINERS file and fully activated the mcdstub in the meson build system

2023-11-07 Thread Nicolas Eder
--- MAINTAINERS| 11 +++ mcdstub/meson.build| 15 +++ meson.build| 1 + target/arm/meson.build | 1 + 4 files changed, 28 insertions(+) create mode 100644 mcdstub/meson.build diff --git a/MAINTAINERS b/MAINTAINERS index cd8d6b140f..58decd218c 100

[PATCH v3 18/20] mcdstub: read/write to memory added: This also includes various helper functions in the QEMU memory code

2023-11-07 Thread Nicolas Eder
--- include/exec/cpu-common.h | 2 + include/exec/memory.h | 9 ++ include/mcdstub/arm_mcdstub.h | 16 include/mcdstub/mcdstub.h | 69 +++ mcdstub/mcdstub.c | 153 ++ system/memory.c | 11 +++ system/

[PATCH v3 02/20] mcdstub gdbstub: new DebugClass and DebugState introduced. They are used to abstract the debugger details behind a QOM. This is currently used in the cpu_handle_guest_debug function

2023-11-07 Thread Nicolas Eder
--- debug/debug-common.c| 42 + debug/debug-gdb.c | 24 +++ debug/debug-mcd.c | 25 gdbstub/meson.build | 4 ++-- gdbstub/system.c| 4 gdbstub/user.c | 2 ++ include/ex

[PATCH v3 05/20] mcdstub: tcp packet processing added

2023-11-07 Thread Nicolas Eder
--- include/mcdstub/mcdstub.h | 144 mcdstub/mcdstub.c | 277 ++ 2 files changed, 421 insertions(+) diff --git a/include/mcdstub/mcdstub.h b/include/mcdstub/mcdstub.h index 36058157ae..1461d0e1cb 100644 --- a/include/mcdstub/mcdstub

[PATCH v3 12/20] mcdstub: missing parse_reg_xml function for parsing gdb register xml files added

2023-11-07 Thread Nicolas Eder
--- mcdstub/mcdstub.c | 121 ++ 1 file changed, 121 insertions(+) diff --git a/mcdstub/mcdstub.c b/mcdstub/mcdstub.c index d71dff633a..3e87378b45 100644 --- a/mcdstub/mcdstub.c +++ b/mcdstub/mcdstub.c @@ -867,6 +867,127 @@ CPUState *find_cpu(uint32_t th

[PATCH v3 15/20] mcdstub: added go, break and step functionality and all corresponding functions

2023-11-07 Thread Nicolas Eder
--- include/mcdstub/mcdstub.h | 53 mcdstub/mcdstub.c | 101 ++ 2 files changed, 154 insertions(+) diff --git a/include/mcdstub/mcdstub.h b/include/mcdstub/mcdstub.h index 85ca8b3b62..0375cf7311 100644 --- a/include/mcdstub/mcdstub

[PATCH v3 04/20] mcdstub: added header with defines specific to the mcd tcp packet communication

2023-11-07 Thread Nicolas Eder
--- include/mcdstub/mcd_shared_defines.h | 108 +++ 1 file changed, 108 insertions(+) create mode 100644 include/mcdstub/mcd_shared_defines.h diff --git a/include/mcdstub/mcd_shared_defines.h b/include/mcdstub/mcd_shared_defines.h new file mode 100644 index 00..f

[PATCH v3 19/20] mcdstub: break/watchpoints added

2023-11-07 Thread Nicolas Eder
--- include/mcdstub/mcdstub.h | 46 +++ mcdstub/mcdstub.c | 116 ++ 2 files changed, 162 insertions(+) diff --git a/include/mcdstub/mcdstub.h b/include/mcdstub/mcdstub.h index c55d52d2a7..53e5926ff5 100644 --- a/include/mcdstub/mcdstub.h ++

[PATCH v3 17/20] mcdstub: reading/writing registers added

2023-11-07 Thread Nicolas Eder
--- include/mcdstub/mcdstub.h | 62 + mcdstub/mcdstub.c | 113 ++ 2 files changed, 175 insertions(+) diff --git a/include/mcdstub/mcdstub.h b/include/mcdstub/mcdstub.h index 000d832a39..6b2249f8fb 100644 --- a/include/mcdstub/mcdstu

[PATCH v3 00/20] first version of mcdstub

2023-11-07 Thread Nicolas Eder
SUMMARY === This patch-set introduces the first version of the mcdstub. The mcdstub is a debug interface, which enables debugging QEMU using the MCD (Multi-Core Debug) API. The mcdstub uses TCP to communicate with the host debug software. However, because MCD is merely an API, the TCP communic

Re: [PATCH] target/arm: mark the 32bit alias of PAR when LPAE enabled

2023-11-07 Thread Peter Maydell
On Tue, 7 Nov 2023 at 10:51, Alex Bennée wrote: > > We also mark it ARM_CP_NO_GDB so we avoid duplicate PAR's in the > system register XML we send to gdb. > > Suggested-by: > Signed-off-by: Alex Bennée > > --- > v2 > - only set ARM_CP_NO_GDB when no LPAE enabled > - also mark as AP_CP_ALIAS

[PATCH v3 16/20] mcdstub: function construct for resets added

2023-11-07 Thread Nicolas Eder
--- include/mcdstub/mcdstub.h | 8 mcdstub/mcdstub.c | 18 ++ 2 files changed, 26 insertions(+) diff --git a/include/mcdstub/mcdstub.h b/include/mcdstub/mcdstub.h index 0375cf7311..000d832a39 100644 --- a/include/mcdstub/mcdstub.h +++ b/include/mcdstub/mcdstub.h

[PATCH v3 14/20] mcdstub: missing handle_query_state function added

2023-11-07 Thread Nicolas Eder
--- mcdstub/mcdstub.c | 29 + 1 file changed, 29 insertions(+) diff --git a/mcdstub/mcdstub.c b/mcdstub/mcdstub.c index 56854c4c76..cd2f5db8e4 100644 --- a/mcdstub/mcdstub.c +++ b/mcdstub/mcdstub.c @@ -1466,3 +1466,32 @@ void handle_query_regs_c(GArray *params, void *u

[PATCH v3 06/20] mcdstub: open/close server functions and trigger/reset data added. User for initial connection with an mcd client

2023-11-07 Thread Nicolas Eder
--- include/mcdstub/mcdstub.h | 84 mcdstub/mcdstub.c | 90 +++ 2 files changed, 174 insertions(+) diff --git a/include/mcdstub/mcdstub.h b/include/mcdstub/mcdstub.h index 1461d0e1cb..c7e34673a6 100644 --- a/include/

[PATCH v3 10/20] mcdstub: state query added: this query collects information about the state of a specific core. This commit also includes mcd_vm_state_change, which is called when the cpu state chang

2023-11-07 Thread Nicolas Eder
--- include/mcdstub/mcdstub.h | 41 +++ mcdstub/mcdstub.c | 103 ++ 2 files changed, 144 insertions(+) diff --git a/include/mcdstub/mcdstub.h b/include/mcdstub/mcdstub.h index d38106e973..eb46917d00 100644 --- a/include/mcdstub/mcdstub.h ++

[PATCH v3 11/20] mcdstub: reset and trigger queries added

2023-11-07 Thread Nicolas Eder
--- include/mcdstub/mcdstub.h | 25 ++ mcdstub/mcdstub.c | 69 +++ 2 files changed, 94 insertions(+) diff --git a/include/mcdstub/mcdstub.h b/include/mcdstub/mcdstub.h index eb46917d00..62394e7c12 100644 --- a/include/mcdstub/mcdstub.h +++ b

[PATCH v3 09/20] mcdstub: open/close core added. This includes core specific data preparation: memory spaces, register groups and registers. This data preparation is done in the arm mcdstub

2023-11-07 Thread Nicolas Eder
--- include/mcdstub/arm_mcdstub.h| 81 + include/mcdstub/mcdstub.h| 26 +++ include/mcdstub/mcdstub_common.h | 52 ++ mcdstub/mcdstub.c| 111 target/arm/mcdstub.c | 278 +++ 5 files changed, 548 inserti

[PATCH v3 03/20] gdbstub: moving code so that it can be easier accessed from outside the gdbstub: fromhex and tohex functions moved to a cutils header. GDBRegisterState moved to gdbstub.h

2023-11-07 Thread Nicolas Eder
--- gdbstub/gdbstub.c | 9 + gdbstub/internals.h| 26 -- include/cutils.h | 30 ++ include/exec/gdbstub.h | 9 - 4 files changed, 39 insertions(+), 35 deletions(-) create mode 100644 include/cutils.h diff --git

[PATCH v3 08/20] mcdstub: query packet processing added and core/system querie added

2023-11-07 Thread Nicolas Eder
--- include/mcdstub/mcdstub.h | 30 + mcdstub/mcdstub.c | 70 +++ 2 files changed, 100 insertions(+) diff --git a/include/mcdstub/mcdstub.h b/include/mcdstub/mcdstub.h index c3e9c7e9dc..c4370bb177 100644 --- a/include/mcdstub/mcdstub.h +

Re: [PATCH v4 22/41] vfio/spapr: switch to spapr IOMMU BE add/del_section_window

2023-11-07 Thread Cédric Le Goater
On 11/7/23 04:06, Duan, Zhenzhong wrote: -Original Message- From: Cédric Le Goater Sent: Tuesday, November 7, 2023 1:33 AM Subject: Re: [PATCH v4 22/41] vfio/spapr: switch to spapr IOMMU BE add/del_section_window On 11/2/23 08:12, Zhenzhong Duan wrote: No fucntional change intended.

Re: [PATCH 05/22] target/arm: hide aliased MIDR from gdbstub

2023-11-07 Thread Peter Maydell
On Mon, 6 Nov 2023 at 18:51, Alex Bennée wrote: > > This is just a constant alias register with the same value as the > "other" MIDR so it serves no purpose being presented to gdbstub. > > Signed-off-by: Alex Bennée > Message-Id: <20231103195956.1998255-6-alex.ben...@linaro.org> > --- > target/a

[PATCH v3 13/20] mcdstub: added queries for memory spaces, register groups and registers

2023-11-07 Thread Nicolas Eder
--- include/mcdstub/mcdstub.h | 57 ++ mcdstub/mcdstub.c | 229 ++ 2 files changed, 286 insertions(+) diff --git a/include/mcdstub/mcdstub.h b/include/mcdstub/mcdstub.h index 62394e7c12..85ca8b3b62 100644 --- a/include/mcdstub/mcdstub.h +++ b/i

Re: [PATCH v4 25/41] Add iommufd configure option

2023-11-07 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: This adds "--enable-iommufd/--disable-iommufd" to enable or disable iommufd support, enabled by default. I don't think a configure option is the right approach. I will comment other patches to propose another solution relying on Kconfig and activating IOM

Re: [PATCH 0/4] target/s390x/cpu: Restrict CPUS390XState declaration to 'cpu.h'

2023-11-07 Thread Thomas Huth
On 07/11/2023 13.12, Philippe Mathieu-Daudé wrote: On 7/11/23 11:44, Thomas Huth wrote: On 06/11/2023 12.44, Philippe Mathieu-Daudé wrote: In order to restrict CPUS390XState declaration to "cpu.h" (both target-specific): - have the following prototypes take a S390CPU* instead:    . css_do_sic()

Re: [PATCH v4 26/41] backends/iommufd: Introduce the iommufd object

2023-11-07 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: From: Eric Auger Introduce an iommufd object which allows the interaction with the host /dev/iommu device. The /dev/iommu can have been already pre-opened outside of qemu, in which case the fd can be passed directly along with the iommufd object: This a

Re: [PATCH v2 11/12] qdev: Make netdev properties work as list elements

2023-11-07 Thread Kevin Wolf
Am 02.11.2023 um 13:55 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > The 'name' parameter of QOM setters is primarily used to specify the name > > of the currently parsed input element in the visitor interface. For > > top-level qdev properties, this is always set and matches 'pro

Re: [PATCH v4 27/41] util/char_dev: Add open_cdev()

2023-11-07 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: From: Yi Liu /dev/vfio/devices/vfioX may not exist. In that case it is still possible to open /dev/char/$major:$minor instead. Add helper function to abstract the cdev open. Suggested-by: Jason Gunthorpe Signed-off-by: Yi Liu Signed-off-by: Zhenzhong D

Re: [PULL 0/5] Ui patches

2023-11-07 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/15] xenfv.for-upstream queue

2023-11-07 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL v3 00/25] Pixman patches

2023-11-07 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/63] virtio,pc,pci: features, fixes

2023-11-07 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v4 28/41] vfio/iommufd: Implement the iommufd backend

2023-11-07 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: From: Yi Liu Add the iommufd backend. The IOMMUFD container class is implemented based on the new /dev/iommu user API. This backend obviously depends on CONFIG_IOMMUFD. So far, the iommufd backend doesn't support dirty page sync yet due to missing suppor

Re: [PATCH v4 41/41] vfio: Compile out iommufd for PPC target

2023-11-07 Thread Cédric Le Goater
On 11/2/23 08:13, Zhenzhong Duan wrote: Since PPC doesn't support IOMMUFD, make iommufd related code compiled out. Suggested-by: Cédric Le Goater Signed-off-by: Zhenzhong Duan Please drop this patch. Instead, add imply IOMMUFD in hw/{i386,s390x,arm}/Kconfig for platforms supporting IOM

Re: [PATCH] MAINTAINERS: Add artist.c to the hppa machine section

2023-11-07 Thread Helge Deller
On 11/7/23 11:30, Thomas Huth wrote: The artist graphics adapter is only used by the hppa machine, so let's add this file to the corresponding section. Signed-off-by: Thomas Huth Acked-by: Helge Deller --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MA

[PULL 02/11] hw/arm/mps2-tz: Use qdev_prop_set_array()

2023-11-07 Thread Kevin Wolf
Instead of manually setting "foo-len" and "foo[i]" properties, build a QList and use the new qdev_prop_set_array() helper to set the whole array property with a single call. Signed-off-by: Kevin Wolf Reviewed-by: Peter Maydell Message-ID: <20231030142658.182193-4-kw...@redhat.com> Signed-off-by:

[PULL 08/11] hw/rx/rx62n: Use qdev_prop_set_array()

2023-11-07 Thread Kevin Wolf
Instead of manually setting "foo-len" and "foo[i]" properties, build a QList and use the new qdev_prop_set_array() helper to set the whole array property with a single call. Signed-off-by: Kevin Wolf Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20231030142658.1821

Re: [PATCH v4 31/41] vfio/pci: Extract out a helper vfio_pci_get_pci_hot_reset_info

2023-11-07 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: This helper will be used by both legacy and iommufd backends. No functional changes intended. Signed-off-by: Zhenzhong Duan Reviewed-by: Cédric Le Goater Thanks, C. --- hw/vfio/pci.h | 3 +++ hw/vfio/pci.c | 54 ++

[PULL 01/11] hw/i386/pc: Use qdev_prop_set_array()

2023-11-07 Thread Kevin Wolf
Instead of manually setting "foo-len" and "foo[i]" properties, build a QList and use the new qdev_prop_set_array() helper to set the whole array property with a single call. Signed-off-by: Kevin Wolf Reviewed-by: Peter Maydell Message-ID: <20231030142658.182193-3-kw...@redhat.com> Signed-off-by:

[PULL 05/11] hw/arm/vexpress: Use qdev_prop_set_array()

2023-11-07 Thread Kevin Wolf
Instead of manually setting "foo-len" and "foo[i]" properties, build a QList and use the new qdev_prop_set_array() helper to set the whole array property with a single call. Signed-off-by: Kevin Wolf Reviewed-by: Peter Maydell Message-ID: <20231030142658.182193-7-kw...@redhat.com> Signed-off-by:

[PULL 09/11] qom: Add object_property_set_default_list()

2023-11-07 Thread Kevin Wolf
This function provides a default for properties that are accessed using the list visitor interface. The default is always an empty list. Signed-off-by: Kevin Wolf Reviewed-by: Peter Maydell Message-ID: <20231030142658.182193-11-kw...@redhat.com> Signed-off-by: Kevin Wolf --- include/qom/object

[PULL 10/11] qdev: Make netdev properties work as list elements

2023-11-07 Thread Kevin Wolf
The 'name' parameter of QOM setters is primarily used to specify the name of the currently parsed input element in the visitor interface. For top-level qdev properties, this is always set and matches 'prop->name'. However, for list elements it is NULL, because each element of a list doesn't have a

[PULL 06/11] hw/arm/virt: Use qdev_prop_set_array()

2023-11-07 Thread Kevin Wolf
Instead of manually setting "foo-len" and "foo[i]" properties, build a QList and use the new qdev_prop_set_array() helper to set the whole array property with a single call. Signed-off-by: Kevin Wolf Reviewed-by: Peter Maydell Message-ID: <20231030142658.182193-8-kw...@redhat.com> Signed-off-by:

Re: [PATCH V6 1/9] accel/kvm: Extract common KVM vCPU {creation,parking} code

2023-11-07 Thread Igor Mammedov
On Fri, 13 Oct 2023 11:51:21 +0100 Salil Mehta wrote: > KVM vCPU creation is done once during the initialization of the VM when Qemu > thread is spawned. This is common to all the architectures. is it really true fox x86? > > Hot-unp

[PULL 04/11] hw/arm/sbsa-ref: Use qdev_prop_set_array()

2023-11-07 Thread Kevin Wolf
Instead of manually setting "foo-len" and "foo[i]" properties, build a QList and use the new qdev_prop_set_array() helper to set the whole array property with a single call. Signed-off-by: Kevin Wolf Reviewed-by: Peter Maydell Message-ID: <20231030142658.182193-6-kw...@redhat.com> Signed-off-by:

[PULL 00/11] qdev: Make array properties user accessible again

2023-11-07 Thread Kevin Wolf
The following changes since commit bb541a7068d2eee51a9abbe2dedcdf27298b1872: Merge tag 'pull-pa-20231106' of https://gitlab.com/rth7680/qemu into staging (2023-11-07 15:01:17 +0800) are available in the Git repository at: https://repo.or.cz/qemu/kevin.git qdev-array-prop for you to fetch c

[PULL 07/11] hw/arm/xlnx-versal: Use qdev_prop_set_array()

2023-11-07 Thread Kevin Wolf
Instead of manually setting "foo-len" and "foo[i]" properties, build a QList and use the new qdev_prop_set_array() helper to set the whole array property with a single call. Signed-off-by: Kevin Wolf Reviewed-by: Peter Maydell Message-ID: <20231030142658.182193-9-kw...@redhat.com> Signed-off-by:

[PULL 03/11] hw/arm/mps2: Use qdev_prop_set_array()

2023-11-07 Thread Kevin Wolf
Instead of manually setting "foo-len" and "foo[i]" properties, build a QList and use the new qdev_prop_set_array() helper to set the whole array property with a single call. Signed-off-by: Kevin Wolf Reviewed-by: Peter Maydell Message-ID: <20231030142658.182193-5-kw...@redhat.com> Signed-off-by:

[PULL 11/11] qdev: Rework array properties based on list visitor

2023-11-07 Thread Kevin Wolf
Until now, array properties are actually implemented with a hack that uses multiple properties on the QOM level: a static "foo-len" property and after it is set, dynamically created "foo[i]" properties. In external interfaces (-device on the command line and device_add in QMP), this interface was

Re: [PATCH v4 32/41] vfio/pci: Introduce a vfio pci hot reset interface

2023-11-07 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: Legacy vfio pci and iommufd cdev have different process to hot reset vfio device, expand current code to abstract out pci_hot_reset callback for legacy vfio, this same interface will also be used by iommufd cdev vfio device. Suggested-by: Cédric Le Goater

Re: [PULL 3/8] dump: Add command interface for kdump-raw formats

2023-11-07 Thread Peter Maydell
On Fri, 3 Nov 2023 at 07:02, wrote: > > From: Stephen Brennan > > The QMP dump API represents the dump format as an enumeration. Add three > new enumerators, one for each supported kdump compression, each named > "kdump-raw-*". > > For the HMP command line, rather than adding a new flag correspon

Re: [PATCH] s390/sclp: fix SCLP facility map

2023-11-07 Thread Eric Farman
On Tue, 2023-11-07 at 10:45 +0100, Thomas Huth wrote: > On 02/11/2023 19.50, Eric Farman wrote: > > (+cc qemu-devel) > > > > On Tue, 2023-10-24 at 12:07 +0200, Heiko Carstens wrote: > > > Qemu's SCLP implementation incorrectly reports that it supports > > > CPU > > > reconfiguration. If a guest is

Re: [PATCH] scripts/cpu-x86-uarch-abi.py: Fix parameter error of cmd

2023-11-07 Thread Zhao Liu
Hi John and Cleber, Just a ping. :) Regards, Zhao On Wed, Oct 18, 2023 at 06:00:11PM +0800, Zhao Liu wrote: > Date: Wed, 18 Oct 2023 18:00:11 +0800 > From: Zhao Liu > Subject: [PATCH] scripts/cpu-x86-uarch-abi.py: Fix parameter error of cmd > X-Mailer: git-send-email 2.34.1 > > From: Zhao Liu

[PATCH] hw/mips: LOONGSON3V depends on UNIMP device

2023-11-07 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- hw/mips/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig index 66ec536e06..505381a0bb 100644 --- a/hw/mips/Kconfig +++ b/hw/mips/Kconfig @@ -46,6 +46,7 @@ config LOONGSON3V select PCI_

Re: [PULL 4/6] seabios: update binaries to git snapshot

2023-11-07 Thread Claudio Fontana
On 11/7/23 12:49, Gerd Hoffmann wrote: >> Hi, thanks for the response, >> >> just to be sure, this is a regression (it worked fine prior to the seabios >> update). > > Yes. > >> Address sizes: 43 bits physical, 48 bits virtual > > OK. > >> [0.881472] pci :00:01.0:

Re: [PATCH] scripts/cpu-x86-uarch-abi.py: Fix parameter error of cmd

2023-11-07 Thread Daniel P . Berrangé
On Wed, Oct 18, 2023 at 06:00:11PM +0800, Zhao Liu wrote: > From: Zhao Liu > > When run this script, there's the error: > > python3 scripts/cpu-x86-uarch-abi.py /tmp/qmp > Traceback (most recent call last): > File "/path-to-qemu/qemu/scripts/cpu-x86-uarch-abi.py", line 96, in > cpu = shel

[PATCH 4/4] target/s390x/arch_dump: Add arch cleanup function for PV dumps

2023-11-07 Thread Janosch Frank
PV dumps block vcpu runs until dump end is reached. If there's an error between PV dump init and PV dump end the vm will never be able to run again. One example of such an error is insufficient disk space for the dump file. Let's add a cleanup function that tries to do a dump end. The dump complet

[PATCH 1/4] dump: Set dump info function pointers to NULL

2023-11-07 Thread Janosch Frank
Better to not rely on the struct zeroing since NULL is not necessarily 0. Signed-off-by: Janosch Frank --- dump/dump.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dump/dump.c b/dump/dump.c index d355ada62e..1d38274925 100644 --- a/dump/dump.c +++ b/dump/dump.c @@ -1706,6 +1706,9 @@ st

[PATCH 0/4] dump: Arch info function pointer addition and cleanup

2023-11-07 Thread Janosch Frank
Small cleanups/fixes to the dump info function pointer assignments as well as a new function pointer for cleanup of residual state. This has come up because test managed to dump a s390 PV vm onto a disk that was too small for the dump. After the dump failed, the vm wasn't able to resume running si

[PATCH 2/4] target/s390x/dump: Remove unneeded dump info function pointer init

2023-11-07 Thread Janosch Frank
dump_state_prepare() now sets the fucntion pointers to NULL so we only need to touch them if we're going to use them. Signed-off-by: Janosch Frank --- target/s390x/arch_dump.c | 4 1 file changed, 4 deletions(-) diff --git a/target/s390x/arch_dump.c b/target/s390x/arch_dump.c index 51a2116

[PATCH 3/4] dump: Add arch cleanup function

2023-11-07 Thread Janosch Frank
Some architectures (s390x) need to cleanup after a failed dump to be able to continue to run the vm. Add a cleanup function pointer and call it if it's set. Signed-off-by: Janosch Frank --- dump/dump.c| 5 + include/sysemu/dump-arch.h | 1 + 2 files changed, 6 insertions(+)

[PULL 10/23] gdbstub: Introduce GDBFeatureBuilder

2023-11-07 Thread Alex Bennée
From: Akihiko Odaki GDBFeatureBuilder unifies the logic to generate dynamic GDBFeature. Signed-off-by: Akihiko Odaki Reviewed-by: Richard Henderson Message-Id: <20231025093128.33116-4-akihiko.od...@daynix.com> Signed-off-by: Alex Bennée Message-Id: <20231106185112.2755262-11-alex.ben...@linar

[PULL 01/23] default-configs: Add TARGET_XML_FILES definition

2023-11-07 Thread Alex Bennée
From: Akihiko Odaki loongarch64-linux-user has references to XML files so include them. Fixes: d32688ecdb ("default-configs: Add loongarch linux-user support") Signed-off-by: Akihiko Odaki Message-Id: <20231030054834.39145-6-akihiko.od...@daynix.com> Reviewed-by: Philippe Mathieu-Daudé Reviewe

[PULL 03/23] target/arm: mark the 32bit alias of PAR when LPAE enabled

2023-11-07 Thread Alex Bennée
We also mark it ARM_CP_NO_GDB so we avoid duplicate PAR's in the system register XML we send to gdb. Suggested-by: Richard Henderson Signed-off-by: Alex Bennée Reviewed-by: Peter Maydell Message-Id: <20231107105145.2916124-1-alex.ben...@linaro.org> diff --git a/target/arm/helper.c b/target/arm

[PULL 05/23] target/arm: hide aliased MIDR from gdbstub

2023-11-07 Thread Alex Bennée
This is just a constant alias register with the same value as the "other" MIDR so it serves no purpose being presented to gdbstub. Signed-off-by: Alex Bennée Reviewed-by: Peter Maydell Message-Id: <20231106185112.2755262-6-alex.ben...@linaro.org> diff --git a/target/arm/helper.c b/target/arm/he

[PULL 02/23] gdb-xml: fix duplicate register in arm-neon.xml

2023-11-07 Thread Alex Bennée
Reviewed-by: Richard Henderson Fixes: 56aebc8916 ("Add GDB XML register description support") Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20231106185112.2755262-3-alex.ben...@linaro.org> diff --git a/gdb-xml/arm-neon.xml b/gdb-xml/arm-neon.xml index 9dce0a996f..d

[PULL 00/23] Final test, gdbstub, plugin and gitdm updates for 8.2

2023-11-07 Thread Alex Bennée
The following changes since commit 462ad017ed76889d46696a3581e1b52343f9b683: Merge tag 'pixman-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2023-11-07 19:00:03 +0800) are available in the Git repository at: https://gitlab.com/stsquad/qemu.git tags/pull-halloween-o

[PULL 22/23] mailmap: fixup some more corrupted author fields

2023-11-07 Thread Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé Cc: Timothée Cocault Cc: fanwenjie Signed-off-by: Alex Bennée Message-Id: <20231106185112.2755262-22-alex.ben...@linaro.org> diff --git a/.mailmap b/.mailmap index 94f19a0ac9..e12e19f691 100644 --- a/.mailmap +++ b/.mailmap @@ -30,10 +30,12 @@ malc malc

[PULL 15/23] plugins: disable lockstep plugin on windows

2023-11-07 Thread Alex Bennée
From: Greg Manning The lockstep plugin uses unix sockets and would require a different communication mechanism to work on Windows. Signed-off-by: Greg Manning Reviewed-by: Alex Bennée Message-Id: <20231102172053.17692-4-gmann...@rapitasystems.com> Reviewed-by: Philippe Mathieu-Daudé Signed-of

[PULL 12/23] configure: tell meson and contrib_plugins about DLLTOOL

2023-11-07 Thread Alex Bennée
To cleanly handle cross-building we need to export the details of dlltool into meson's list of cross binaries and into the contrib/plugins/ make configuration. Cc: Greg Manning Reviewed-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20231106185112

[PULL 04/23] target/arm: hide all versions of DBGD[RS]AR from gdbstub

2023-11-07 Thread Alex Bennée
This avoids two duplicates being presented to gdbstub. As the registers are RAZ anyway it is unlikely their value would be of use to someone using gdbstub anyway. Acked-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20231106185112.2755262-5-alex.ben...@linaro.org> diff --git a/ta

[PULL 08/23] gdbstub: Add num_regs member to GDBFeature

2023-11-07 Thread Alex Bennée
From: Akihiko Odaki Currently the number of registers exposed to GDB is written as magic numbers in code. Derive the number of registers GDB actually see from XML files to replace the magic numbers in code later. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Ale

[PULL 13/23] plugins: add dllexport and dllimport to api funcs

2023-11-07 Thread Alex Bennée
From: Greg Manning In qemu-plugin.h, mark all API functions as __declspec(dllexport) when compiling the executables, and as __declspec(dllimport) when being used to compile plugins against. Signed-off-by: Greg Manning Reviewed-by: Alex Bennée Message-Id: <20231102172053.17692-2-gmann...@rapita

[PULL 17/23] plugins: allow plugins to be enabled on windows

2023-11-07 Thread Alex Bennée
From: Greg Manning allow plugins to be enabled in the configure script on windows. Also, add the qemu_plugin_api.lib to the installer. Signed-off-by: Greg Manning Reviewed-by: Alex Bennée Message-Id: <20231102172053.17692-5-gmann...@rapitasystems.com> Reviewed-by: Philippe Mathieu-Daudé [AJB:

[PULL 09/23] gdbstub: Introduce gdb_find_static_feature()

2023-11-07 Thread Alex Bennée
From: Akihiko Odaki This function is useful to determine the number of registers exposed to GDB from the XML name. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20231025093128.33116-3-akihiko.od...@daynix

[PULL 07/23] tests/avocado: update the tcg_plugins test

2023-11-07 Thread Alex Bennée
There are a number of things that are broken on the test currently so lets fix that up: - replace retired Debian kernel for tuxrun_baseline one - remove "detected repeat instructions test" since ea185a55 - log total counted instructions/memory accesses Acked-by: Richard Henderson Signed-of

[PULL 16/23] gitlab: add dlltool to Windows CI

2023-11-07 Thread Alex Bennée
Signed-off-by: Alex Bennée diff --git a/.gitlab-ci.d/windows.yml b/.gitlab-ci.d/windows.yml index 12a987cd71..f7645f72b7 100644 --- a/.gitlab-ci.d/windows.yml +++ b/.gitlab-ci.d/windows.yml @@ -72,6 +72,7 @@ - .\msys64\usr\bin\bash -lc "pacman -Sy --noconfirm --needed bison diffutils fl

[PULL 11/23] cpu: Call plugin hooks only when ready

2023-11-07 Thread Alex Bennée
From: Akihiko Odaki The initialization and exit hooks will not affect the state of vCPU outside TCG context, but they may depend on the state of vCPU. Therefore, it's better to call plugin hooks after the vCPU state is fully initialized and before it gets uninitialized. Signed-off-by: Akihiko Od

<    1   2   3   4   5   6   >