Re: [PATCH v4 03/33] cpu: Call object_class_dynamic_cast() once in cpu_class_by_name()

2023-11-06 Thread Igor Mammedov
On Thu, 2 Nov 2023 10:24:30 +1000 Gavin Shan wrote: > From: Philippe Mathieu-Daudé > > For all targets, the CPU class returned from CPUClass::class_by_name() > and object_class_dynamic_cast(oc, CPU_RESOLVING_TYPE) need to be > compatible. Lets apply the check in cpu_class_by_name() for once, >

[PULL 06/10] Add Hyper-V Dynamic Memory Protocol driver (hv-balloon) hot-add support

2023-11-06 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" One of advantages of using this protocol over ACPI-based PC DIMM hotplug is that it allows hot-adding memory in much smaller granularity because the ACPI DIMM slot limit does not apply. In order to enable this functionality a new memory backend needs to be created and

[PULL 02/10] Revert "hw/virtio/virtio-pmem: Replace impossible check by assertion"

2023-11-06 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" This reverts commit 5960f254dbb46f0c7a9f5f44bf4d27c19c34cb97 since the previous commit made this situation possible again. Signed-off-by: Maciej S. Szmigiero --- hw/virtio/virtio-pmem.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/virti

Re: [PATCH v2 03/10] block: Allow the wrapper script to see functions declared in qapi.h

2023-11-06 Thread Hanna Czenczek
On 09.06.23 22:19, Fabiano Rosas wrote: The following patches will add co_wrapper annotations to functions declared in qapi.h. Add that header to the set of files used by block-coroutine-wrapper.py. Signed-off-by: Fabiano Rosas --- block/meson.build | 1 + scripts/block-coro

Re: [PATCH v2 04/10] block: Temporarily mark bdrv_co_get_allocated_file_size as mixed

2023-11-06 Thread Hanna Czenczek
On 09.06.23 22:19, Fabiano Rosas wrote: Some callers of this function are about to be converted to run in coroutines, so allow it to be executed both inside and outside a coroutine while we convert all the callers. This will be reverted once all callers of bdrv_do_query_node_info run in a corout

Re: [PATCH v2 05/10] block: Convert bdrv_query_block_graph_info to coroutine

2023-11-06 Thread Hanna Czenczek
On 09.06.23 22:19, Fabiano Rosas wrote: We're converting callers of bdrv_get_allocated_file_size() to run in coroutines because that function will be made asynchronous when called (indirectly) from the QMP dispatcher. This function is a candidate because it calls bdrv_do_query_node_info(), which

Re: [PULL 0/8] Dump patches

2023-11-06 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

[PULL 00/10] Hyper-V Dynamic Memory Protocol driver (hv-balloon) pull req fixed

2023-11-06 Thread Maciej S. Szmigiero
arm into staging (2023-11-03 10:04:12 +0800) are available in the Git repository at: https://github.com/maciejsszmigiero/qemu.git tags/pull-hv-balloon-20231106 for you to fetch changes up to 00313b517d09c0b141fb32997791f911c28fd3ff: MAINTAINERS: Add an entry for Hyper-V Dynamic Memory Proto

Re: [PATCH v2 10/10] block: Add a thread-pool version of fstat

2023-11-06 Thread Hanna Czenczek
On 09.06.23 22:19, Fabiano Rosas wrote: From: João Silva The fstat call can take a long time to finish when running over NFS. Add a version of it that runs in the thread pool. Adapt one of its users, raw_co_get_allocated_file size to use the new version. That function is called via QMP under t

Re: [PULL 0/7] Migration 20231103 patches

2023-11-06 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

[PULL 07/10] qapi: Add query-memory-devices support to hv-balloon

2023-11-06 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Used by the driver to report its provided memory state information. Co-developed-by: David Hildenbrand Reviewed-by: David Hildenbrand Acked-by: Markus Armbruster Signed-off-by: Maciej S. Szmigiero --- hw/core/machine-hmp-cmds.c | 15 +++ hw/hyperv/hv-

Re: [PATCH] target/riscv: don't enable Zfa by default

2023-11-06 Thread Daniel Henrique Barboza
On 11/6/23 08:14, Jerry Zhang Jian wrote: - Zfa requires F, we should not assume all CPUs have F extension support. We do not have a case where this happen, do we? The default CPUs have F enabled (see misa_ext_cfgs[] in target/riscv/tcg/tcg-cpu.c), so zfa being enable isn't a problem for

Re: [PULL 00/21] target/sparc: Cleanup condition codes

2023-11-06 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

[PULL 05/10] Add Hyper-V Dynamic Memory Protocol driver (hv-balloon) base

2023-11-06 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" This driver is like virtio-balloon on steroids: it allows both changing the guest memory allocation via ballooning and (in the next patch) inserting pieces of extra RAM into it on demand from a provided memory backend. The actual resizing is done via ballooning interf

Re: [PATCH v2 12/16] target: Move ArchCPUClass definition to 'cpu.h'

2023-11-06 Thread Philippe Mathieu-Daudé
On 20/10/23 10:03, Zhao Liu wrote: Hi Philippe, On Fri, Oct 13, 2023 at 04:01:11PM +0200, Philippe Mathieu-Daudé wrote: Date: Fri, 13 Oct 2023 16:01:11 +0200 From: Philippe Mathieu-Daudé Subject: [PATCH v2 12/16] target: Move ArchCPUClass definition to 'cpu.h' X-Mailer: git-send-email 2.41.0

Re: [PATCH v4 00/41] vfio: Adopt iommufd

2023-11-06 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: Hi, Thanks all for giving guides and comments on previous series, here is the v4 of pure iommufd support part. Based on Cédric's suggestion, this series includes an effort to remove spapr code from container.c, now all spapr functions are moved to spapr.c

Re: [PATCH v2 09/10] block: Convert qmp_query_block() to coroutine_fn

2023-11-06 Thread Hanna Czenczek
On 09.06.23 22:19, Fabiano Rosas wrote: This is another caller of bdrv_get_allocated_file_size() that needs to be converted to a coroutine because that function will be made asynchronous when called (indirectly) from the QMP dispatcher. This QMP command is a candidate because it calls bdrv_do_qu

Re: [PATCH v2 19/35] tcg/sparc64: Implement tcg_out_extrl_i64_i32

2023-11-06 Thread Philippe Mathieu-Daudé
On 28/10/23 21:45, Richard Henderson wrote: Build fix for missing symbol. Cc: qemu-sta...@nongnu.org Fixes: b8b94ac6753 ("tcg: Split out tcg_out_extrl_i64_i32") Commit b8b94ac6753 looks correct, don't we want: Fixes: dad2f2f5af ("tcg/sparc64: Disable TCG_TARGET_HAS_extr_i64_i32") ? Signed-of

Re: [PATCH] tests/acpi/bios-tables-test: do not write new blobs unless there are changes

2023-11-06 Thread Ani Sinha
> On 06-Nov-2023, at 7:45 PM, Igor Mammedov wrote: > > On Thu, 2 Nov 2023 13:46:24 +0530 > Ani Sinha wrote: > >> When dumping table blobs using rebuild-expected-aml.sh, table blobs from all >> test variants are dumped regardless of whether there are any actual changes >> to >> the tables o

Re: [PATCH] file-posix: fix over-writing of returning zone_append offset

2023-11-06 Thread Hanna Czenczek
On 30.10.23 08:38, Naohiro Aota wrote: raw_co_zone_append() sets "s->offset" where "BDRVRawState *s". This pointer is used later at raw_co_prw() to save the block address where the data is written. When multiple IOs are on-going at the same time, a later IO's raw_co_zone_append() call over-write

Re: [PATCH] tests/acpi/bios-tables-test: do not write new blobs unless there are changes

2023-11-06 Thread Ani Sinha
> On 06-Nov-2023, at 8:43 PM, Ani Sinha wrote: > > > >> On 06-Nov-2023, at 7:45 PM, Igor Mammedov wrote: >> >> On Thu, 2 Nov 2023 13:46:24 +0530 >> Ani Sinha wrote: >> >>> When dumping table blobs using rebuild-expected-aml.sh, table blobs from all >>> test variants are dumped regardles

Re: [PATCH] target/riscv: don't enable Zfa by default

2023-11-06 Thread Jerry ZJ
We do have some cases that failed. SiFive e-series cores (https://static.dev.sifive.com/SiFive-E21-Manual-v1p0.pdf) do not have F extension (For example: rv32imc_zicsr_zifencei_zba_zbb). When we use the corresponding extension options to configure QEMU, i.e., rv32, i=true, m=true, a=true, c=tru

Re: [PATCH v2 01/35] tcg: Introduce TCG_COND_TST{EQ,NE}

2023-11-06 Thread Philippe Mathieu-Daudé
On 28/10/23 21:44, Richard Henderson wrote: Add the enumerators, adjust the helpers to match, and dump. Not supported anywhere else just yet. Signed-off-by: Richard Henderson --- docs/devel/tcg-ops.rst | 2 ++ include/tcg/tcg-cond.h | 49 -- tcg/tcg.

Re: [PATCH] Add class property to configure KVM device node to use

2023-11-06 Thread Daan De Meyer
Ping Daan On Sat, 28 Oct 2023 at 14:07, Daan De Meyer wrote: > > Anything else needed before this patch can be merged? > > Cheers, > > Daan > > On Wed, 25 Oct 2023 at 19:37, Daniel P. Berrangé wrote: > > > > On Sat, Oct 21, 2023 at 03:40:15PM +0200, Daan De Meyer wrote: > > > This allows passin

Re: [PATCH v2 04/11] qapi: golang: Generate qapi's alternate types in Go

2023-11-06 Thread Andrea Bolognani
On Mon, Oct 16, 2023 at 05:26:57PM +0200, Victor Toso wrote: > This patch handles QAPI alternate types and generates data structures > in Go that handles it. > > Alternate types are similar to Union but without a discriminator that > can be used to identify the underlying value on the wire. It is n

Re: [PATCH v2 02/35] tcg/optimize: Split out arg_is_const_val

2023-11-06 Thread Philippe Mathieu-Daudé
On 28/10/23 21:44, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/optimize.c | 38 +++--- 1 file changed, 23 insertions(+), 15 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 25/29] contrib/plugins: extend execlog to track register changes

2023-11-06 Thread Alex Bennée
Alex Bennée writes: > With the new plugin register API we can now track changes to register > values. Currently the implementation is fairly dumb which will slow > down if a large number of register values are being tracked. This > could be improved by only instrumenting instructions which mentio

Re: [PATCH] tests/acpi/bios-tables-test: do not write new blobs unless there are changes

2023-11-06 Thread Igor Mammedov
On Thu, 2 Nov 2023 13:46:24 +0530 Ani Sinha wrote: > When dumping table blobs using rebuild-expected-aml.sh, table blobs from all > test variants are dumped regardless of whether there are any actual changes to > the tables or not. This creates lot of new files for various test variants > that

[PULL 04/10] Add Hyper-V Dynamic Memory Protocol definitions

2023-11-06 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" This commit adds Hyper-V Dynamic Memory Protocol definitions, taken from hv_balloon Linux kernel driver, adapted to the QEMU coding style and definitions. Acked-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- include/hw/hyperv/dynmem-proto.h | 423

[PULL 00/12] target-arm queue

2023-11-06 Thread Peter Maydell
' of https://gitlab.com/rth7680/qemu into staging (2023-11-06 09:34:22 +0800) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20231106 for you to fetch changes up to 5722fc471296d5f042df4b005a851cc8008df0c9: target/ar

[PULL 06/12] util/filemonitor-inotify: qemu_file_monitor_watch(): assert no overflow

2023-11-06 Thread Peter Maydell
From: Vladimir Sementsov-Ogievskiy Prefer clear assertions instead of [im]possible array overflow. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Peter Maydell Reviewed-by: Maksim Davydov Message-id: 20231017125941.810461-3-vsement...@yandex-team.ru Signed-off-by: Peter Maydell ---

[PULL 03/12] hw/arm/virt: Report correct register sizes in ACPI DBG2/SPCR tables.

2023-11-06 Thread Peter Maydell
From: Udo Steinberg Documentation for using the GAS in ACPI tables to report debug UART addresses at https://learn.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table states the following: - The Register Bit Width field contains the register stride and must be a power of

[PULL 05/12] hw/i386/intel_iommu: vtd_slpte_nonzero_rsvd(): assert no overflow

2023-11-06 Thread Peter Maydell
From: Vladimir Sementsov-Ogievskiy We support only 3- and 4-level page-tables, which is firstly checked in vtd_decide_config(), then setup in vtd_init(). Than level fields are checked by vtd_is_level_supported(). So here we can't have level out from 1..4 inclusive range. Let's assert it. That al

[PULL 01/12] hw/arm/virt: fix PMU IRQ registration

2023-11-06 Thread Peter Maydell
From: Sebastian Ott Since commit 9036e917f8 ("{include/}hw/arm: refactor virt PPI logic") PMU IRQ registration fails for arm64 guests: [0.563689] hw perfevents: unable to request IRQ14 for ARM PMU counters [0.565160] armv8-pmu: probe of pmu failed with error -22 That commit re-defined V

[PULL 11/12] hw/arm/vexpress-a9: Remove useless mapping of RAM at address 0

2023-11-06 Thread Peter Maydell
On the vexpress-a9 board we try to map both RAM and flash to address 0, as seen in "info mtree": address-space: memory - (prio 0, i/o): system -03ff (prio 0, romd): alias vexpress.flashalias @vexpress.flash0 -00

[PULL 10/12] io/channel-socket: qio_channel_socket_flush(): improve msg validation

2023-11-06 Thread Peter Maydell
From: Vladimir Sementsov-Ogievskiy For SO_EE_ORIGIN_ZEROCOPY the 32-bit notification range is encoded as [ee_info, ee_data] inclusively, so ee_info should be less or equal to ee_data. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Maksim Davydov Message-id: 20231017125941.810461-7-vs

[PULL 08/12] block/nvme: nvme_process_completion() fix bound for cid

2023-11-06 Thread Peter Maydell
From: Vladimir Sementsov-Ogievskiy NVMeQueuePair::reqs has length NVME_NUM_REQS, which less than NVME_QUEUE_SIZE by 1. Fixes: 1086e95da17050 ("block/nvme: switch to a NVMeRequest freelist") Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi Reviewed-by: Maksim Davydov Me

[PULL 07/12] mc146818rtc: rtc_set_time(): initialize tm to zeroes

2023-11-06 Thread Peter Maydell
From: Vladimir Sementsov-Ogievskiy set_time() function doesn't set all the fields, so it's better to initialize tm structure. And Coverity will be happier about it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Peter Maydell Reviewed-by: Maksim Davydov Message-id: 20231017125941.81

[PULL 02/12] tests/qtest/bios-tables-test: Allow changes to virt SPCR and DBG2

2023-11-06 Thread Peter Maydell
Allow changes to the virt board SPCR and DBG2 -- we are going to fix an error in the UART descriptions there. Signed-off-by: Peter Maydell --- tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qt

[PULL 04/12] tests/qtest/bios-tables-test: Update virt SPCR and DBG2 golden references

2023-11-06 Thread Peter Maydell
Update the virt SPCR and DBG2 golden reference files to have the fix for the description of the UART. Diffs from iasl: @@ -1,57 +1,57 @@ /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20200925 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Di

Re: [PATCH v2 05/35] tcg/optimize: Split out arg_new_constant

2023-11-06 Thread Philippe Mathieu-Daudé
On 28/10/23 21:44, Richard Henderson wrote: Fixes a bug wherein raw uses of tcg_constant_internal do not have their TempOptInfo initialized. Signed-off-by: Richard Henderson --- tcg/optimize.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) Reviewed-by

[PULL 12/12] target/arm: Fix A64 LDRA immediate decode

2023-11-06 Thread Peter Maydell
In commit be23a049 in the conversion to decodetree we broke the decoding of the immediate value in the LDRA instruction. This should be a 10 bit signed value that is scaled by 8, but in the conversion we incorrectly ended up scaling it only by 2. Fix the scaling factor. Cc: qemu-sta...@nongnu.or

[PULL 09/12] hw/core/loader: gunzip(): initialize z_stream

2023-11-06 Thread Peter Maydell
From: Vladimir Sementsov-Ogievskiy Coverity signals that variable as being used uninitialized. And really, when work with external APIs that's better to zero out the structure, where we set some fields by hand. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Peter Maydell Reviewed-by:

Re: [PATCH v2 03/35] tcg/optimize: Split out do_constant_folding_cond1

2023-11-06 Thread Philippe Mathieu-Daudé
On 28/10/23 21:44, Richard Henderson wrote: Handle modifications to the arguments and condition in a single place. Signed-off-by: Richard Henderson --- tcg/optimize.c | 57 -- 1 file changed, 27 insertions(+), 30 deletions(-) Reviewed-by: Phi

Re: [PATCH 13/29] target/riscv: Use GDBFeature for dynamic XML

2023-11-06 Thread Alex Bennée
Alex Bennée writes: > Alex Bennée writes: > >> From: Akihiko Odaki >> >> In preparation for a change to use GDBFeature as a parameter of >> gdb_register_coprocessor(), convert the internal representation of >> dynamic feature from plain XML to GDBFeature. >> >> Signed-off-by: Akihiko Odaki >>

Re: [PATCH] Add class property to configure KVM device node to use

2023-11-06 Thread Paolo Bonzini
Queued, thanks. Paolo

[PULL 10/10] MAINTAINERS: Add an entry for Hyper-V Dynamic Memory Protocol

2023-11-06 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Acked-by: David Hildenbrand Signed-off-by: Maciej S. Szmigiero --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8e8a7d5be5de..d4a480ce5a62 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2656,6 +2656,14 @@ F:

Re: [PATCH 01/29] default-configs: Add TARGET_XML_FILES definition

2023-11-06 Thread Alex Bennée
Richard Henderson writes: > On 11/3/23 12:59, Alex Bennée wrote: >> From: Akihiko Odaki >> loongarch64-linux-user has references to XML files so include them. >> Fixes: d32688ecdb ("default-configs: Add loongarch linux-user >> support") >> Signed-off-by: Akihiko Odaki >> Message-Id: <2023103005

Re: [PATCH v2 04/11] qapi: golang: Generate qapi's alternate types in Go

2023-11-06 Thread Victor Toso
Hi, On Mon, Nov 06, 2023 at 07:28:04AM -0800, Andrea Bolognani wrote: > On Mon, Oct 16, 2023 at 05:26:57PM +0200, Victor Toso wrote: > > This patch handles QAPI alternate types and generates data structures > > in Go that handles it. > > > > Alternate types are similar to Union but without a discr

Re: [PATCH] xen/pt: Emulate multifunction bit in header type

2023-11-06 Thread Paul Durrant
On 03/11/2023 17:26, Ross Lagerwall wrote: The intention of the code appears to have been to unconditionally set the multifunction bit but since the emulation mask is 0x00 it has no effect. Instead, emulate the bit and set it based on the multifunction property of the PCIDevice (which can be set

Re: [PATCH v4 06/17] hw/xen: automatically assign device index to block devices

2023-11-06 Thread Paul Durrant
On 06/11/2023 14:34, David Woodhouse wrote: From: David Woodhouse There's no need to force the user to assign a vdev. We can automatically assign one, starting at xvda and searching until we find the first disk name that's unused. This means we can now allow '-drive if=xen,file=xxx' to work wi

Re: [PATCH v4 13/17] hw/i386/pc: support '-nic' for xen-net-device

2023-11-06 Thread Paul Durrant
On 06/11/2023 14:35, David Woodhouse wrote: From: David Woodhouse The default NIC creation seems a bit hackish to me. I don't understand why each platform has to call pci_nic_init_nofail() from a point in the code where it actually has a pointer to the PCI bus, and then we have the special case

Re: [PATCH v4 16/17] doc/sphinx/hxtool.py: add optional label argument to SRST directive

2023-11-06 Thread Paul Durrant
On 06/11/2023 14:35, David Woodhouse wrote: From: David Woodhouse We can't just embed labels directly into files like qemu-options.hx which are included from multiple top-level RST files, because Sphinx sees the labels as duplicate: https://github.com/sphinx-doc/sphinx/issues/9707 So add an 'e

Re: [PATCH 53/71] hw/sensor: Constify VMState

2023-11-06 Thread Richard Henderson
On 11/6/23 03:55, Philippe Mathieu-Daudé wrote: On 6/11/23 07:58, Richard Henderson wrote: Signed-off-by: Richard Henderson ---   hw/sensor/adm1272.c    | 2 +-   hw/sensor/dps310.c | 2 +-   hw/sensor/emc141x.c    | 2 +-   hw/sensor/lsm303dlhc_mag.c | 2 +-   hw/sensor/max31785.c 

Re: [PATCH v4 17/17] docs: update Xen-on-KVM documentation

2023-11-06 Thread Paul Durrant
On 06/11/2023 14:35, David Woodhouse wrote: From: David Woodhouse Add notes about console and network support, and how to launch PV guests. Clean up the disk configuration examples now that that's simpler, and remove the comment about IDE unplug on q35/AHCI now that it's fixed. Update the -ini

Re: [PATCH v2 2/5] tests/tcg/s390x: Test CLC with inaccessible second operand

2023-11-06 Thread Richard Henderson
On 11/6/23 01:31, Ilya Leoshkevich wrote: Add a small test to prevent regressions. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.target | 1 + tests/tcg/s390x/clc.c | 48 + 2 files changed, 49 insertions(+) create mode 100644 tests

Re: [PATCH v2 04/11] qapi: golang: Generate qapi's alternate types in Go

2023-11-06 Thread Andrea Bolognani
On Mon, Nov 06, 2023 at 04:52:12PM +0100, Victor Toso wrote: > On Mon, Nov 06, 2023 at 07:28:04AM -0800, Andrea Bolognani wrote: > > On a partially related note: while I haven't yet looked closely at > > how much effort you've dedicated to producing pretty output, from a > > quick look at generate_

Re: [PATCH v2 3/3] hw/ide/via: implement legacy/native mode switching

2023-11-06 Thread BALATON Zoltan
On Mon, 6 Nov 2023, Kevin Wolf wrote: Am 25.10.2023 um 00:40 hat Mark Cave-Ayland geschrieben: Allow the VIA IDE controller to switch between both legacy and native modes by calling pci_ide_update_mode() to reconfigure the device whenever PCI_CLASS_PROG is updated. This patch moves the initial

Re: [PATCH v2 3/5] target/s390x: Fix LAALG not updating cc_src

2023-11-06 Thread Richard Henderson
On 11/6/23 01:31, Ilya Leoshkevich wrote: LAALG uses op_laa() and wout_addu64(). The latter expects cc_src to be set, but the former does not do it. This can lead to assertion failures if something sets cc_src to neither 0 nor 1 before. Fix by introducing op_laa_addu64(), which sets cc_src, and

Re: [PATCH v2 4/5] tests/tcg/s390x: Test LAALG with negative cc_src

2023-11-06 Thread Richard Henderson
On 11/6/23 01:31, Ilya Leoshkevich wrote: Add a small test to prevent regressions. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.target | 1 + tests/tcg/s390x/laalg.c | 27 +++ 2 files changed, 28 insertions(+) create mode 100644 tests/tcg/s

Re: [PATCH v4 06/41] vfio: Introduce base object for VFIOContainer and targeted interface

2023-11-06 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: Introduce a dumb VFIOContainerBase object and its targeted interface. This is willingly not a QOM object because we don't want it to be visible from the user interface. The VFIOContainerBase will be smoothly populated in subsequent patches as well as interf

Re: [PATCH v4 07/41] vfio/container: Introduce a empty VFIOIOMMUOps

2023-11-06 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: This empty VFIOIOMMUOps named vfio_legacy_ops will hold all general IOMMU ops of legacy container. Signed-off-by: Zhenzhong Duan Reviewed-by: Cédric Le Goater Thanks, C. --- include/hw/vfio/vfio-common.h | 2 +- hw/vfio/container.c

Re: [PATCH v4 08/41] vfio/container: Switch to dma_map|unmap API

2023-11-06 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: From: Eric Auger No fucntional change intended. Signed-off-by: Eric Auger Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan --- v4: use SPDX identifier, use assert Reviewed-by: Cédric Le Goater Thanks, C. include/h

Re: [PATCH v4 09/41] vfio/common: Introduce vfio_container_init/destroy helper

2023-11-06 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: This adds two helper functions vfio_container_init/destroy which will be used by both legacy and iommufd containers to do base container specific initialization and release. No fucntional change intended. Suggested-by: Cédric Le Goater Signed-off-by: Zhe

Re: [PATCH] target/riscv: don't enable Zfa by default

2023-11-06 Thread Daniel Henrique Barboza
On 11/6/23 12:21, Jerry ZJ wrote: We do have some cases that failed. SiFive e-series cores (https://static.dev.sifive.com/SiFive-E21-Manual-v1p0.pdf ) do not have F extension (For example: rv32imc_zicsr_zifencei_zba_zbb). When we use

Re: [PATCH v4 11/41] vfio/container: Move space field to base container

2023-11-06 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: From: Eric Auger Move the space field to the base object. Also the VFIOAddressSpace now contains a list of base containers. No fucntional change intended. Signed-off-by: Eric Auger Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by: Zhenzhong

Re: [PATCH v4 12/41] vfio/container: Switch to IOMMU BE set_dirty_page_tracking/query_dirty_bitmap API

2023-11-06 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: From: Eric Auger dirty_pages_supported field is also moved to the base container No fucntional change intended. Signed-off-by: Eric Auger Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan --- v4: use assert Reviewed-by: Cé

Re: [PATCH v4 10/41] vfio/common: Move giommu_list in base container

2023-11-06 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: From: Eric Auger Move the giommu_list field in the base container and store the base container in the VFIOGuestIOMMU. No functional change intended. Signed-off-by: Eric Auger Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan

Re: [PATCH v4 16/41] vfio/container: Move vrdl_list to base container

2023-11-06 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: No functional change intended. Signed-off-by: Zhenzhong Duan Reviewed-by: Cédric Le Goater Thanks, C. --- include/hw/vfio/vfio-common.h | 11 include/hw/vfio/vfio-container-base.h | 11 hw/vfio/common.c

Re: [PATCH v4 15/41] vfio/container: Move pgsizes and dma_max_mappings to base container

2023-11-06 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: From: Eric Auger No functional change intended. Signed-off-by: Eric Auger Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan Reviewed-by: Cédric Le Goater Thanks, C. --- v4: Split vrdl_list change out in a seperate pa

Re: [PATCH v4 17/41] vfio/container: Move listener to base container

2023-11-06 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: From: Eric Auger Move listener to base container. Also error and initialized fields are moved at the same time. No functional change intended. Signed-off-by: Eric Auger Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan Rev

Re: [PATCH v4 19/41] vfio/container: Move iova_ranges to base container

2023-11-06 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: Meanwhile remove the helper function vfio_free_container as it only calls g_free now. No functional change intended. Signed-off-by: Zhenzhong Duan Reviewed-by: Cédric Le Goater Thanks, C. --- include/hw/vfio/vfio-common.h | 1 - incl

Re: [PATCH v4 20/41] vfio/container: Implement attach/detach_device

2023-11-06 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: From: Eric Auger No fucntional change intended. Signed-off-by: Eric Auger Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan Reviewed-by: Cédric Le Goater Thanks, C. --- hw/vfio/common.c| 16 h

[PULL 1/3] qcow2: keep reference on zeroize with discard-no-unref enabled

2023-11-06 Thread Hanna Czenczek
From: Jean-Louis Dupond When the discard-no-unref flag is enabled, we keep the reference for normal discard requests. But when a discard is executed on a snapshot/qcow2 image with backing, the discards are saved as zero clusters in the snapshot image. When committing the snapshot to the backing

[PULL 0/3] Block patches

2023-11-06 Thread Hanna Czenczek
The following changes since commit 3e01f1147a16ca566694b97eafc941d62fa1e8d8: Merge tag 'pull-sp-20231105' of https://gitlab.com/rth7680/qemu into staging (2023-11-06 09:34:22 +0800) are available in the Git repository at: https://gitlab.com/hreitz/qemu.git tags/pull-block-2023-11-06 for yo

[PULL 3/3] file-posix: fix over-writing of returning zone_append offset

2023-11-06 Thread Hanna Czenczek
From: Naohiro Aota raw_co_zone_append() sets "s->offset" where "BDRVRawState *s". This pointer is used later at raw_co_prw() to save the block address where the data is written. When multiple IOs are on-going at the same time, a later IO's raw_co_zone_append() call over-writes a former IO's offs

[PULL 2/3] block/file-posix: fix update_zones_wp() caller

2023-11-06 Thread Hanna Czenczek
From: Sam Li When the zoned request fail, it needs to update only the wp of the target zones for not disrupting the in-flight writes on these other zones. The wp is updated successfully after the request completes. Fixed the callers with right offset and nr_zones. Signed-off-by: Sam Li Message

Re: [PATCH v5 3/6] hw/virtio: derive vhost-user-gpio from vhost-user-base

2023-11-06 Thread Michael S. Tsirkin
On Thu, Oct 19, 2023 at 10:56:07AM +0100, Alex Bennée wrote: > Now the new base class supports config handling we can take advantage > and make vhost-user-gpio a much simpler boilerplate wrapper. Also as > this doesn't require any target specific hacks we only need to build > the stubs once. > > M

Re: [PATCH v4 30/41] vfio/iommufd: Add support for iova_ranges

2023-11-06 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: Some vIOMMU such as virtio-iommu use iova ranges from host side to setup reserved ranges for passthrough device, so that guest will not use an iova range beyond host support. Use an uAPI of IOMMUFD to get iova ranges of host side and pass to vIOMMU just li

Re: [PATCH v5 1/6] virtio: split into vhost-user-base and vhost-user-device

2023-11-06 Thread Michael S. Tsirkin
On Thu, Oct 19, 2023 at 10:56:05AM +0100, Alex Bennée wrote: > Lets keep a cleaner split between the base class and the derived > vhost-user-device which we can use for generic vhost-user stubs. This > includes an update to introduce the vq_size property so the number of > entries in a virtq can be

Re: [PATCH v4 21/41] vfio/spapr: Introduce spapr backend and target interface

2023-11-06 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: Introduce an empty spapr backend which will hold spapr specific content, currently only prereg_listener and hostwin_list. Also introduce two spapr specific callbacks add/del_window into VFIOIOMMUOps. Instantiate a spapr ops with a helper setup_spapr_ops an

Re: [PATCH v5 3/6] hw/virtio: derive vhost-user-gpio from vhost-user-base

2023-11-06 Thread Alex Bennée
"Michael S. Tsirkin" writes: > On Thu, Oct 19, 2023 at 10:56:07AM +0100, Alex Bennée wrote: >> Now the new base class supports config handling we can take advantage >> and make vhost-user-gpio a much simpler boilerplate wrapper. Also as >> this doesn't require any target specific hacks we only ne

Re: [PATCH v4 22/41] vfio/spapr: switch to spapr IOMMU BE add/del_section_window

2023-11-06 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: No fucntional change intended. Signed-off-by: Zhenzhong Duan --- include/hw/vfio/vfio-common.h | 5 - include/hw/vfio/vfio-container-base.h | 5 + hw/vfio/common.c | 8 ++-- hw/vfio/container-base.c

Re: [PATCH v4 23/41] vfio/spapr: Move prereg_listener into spapr container

2023-11-06 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: No functional changes intended. Signed-off-by: Zhenzhong Duan Reviewed-by: Cédric Le Goater Thanks, C. --- include/hw/vfio/vfio-common.h | 1 - hw/vfio/spapr.c | 24 2 files changed, 16 insertions(+), 9

Re: [PATCH] virtio: rng: Check notifier helpers for VIRTIO_CONFIG_IRQ_IDX

2023-11-06 Thread Michael S. Tsirkin
On Wed, Oct 25, 2023 at 11:18:41AM -0600, Mathieu Poirier wrote: > Since the driver doesn't support interrupts, we must return early when > index is set to VIRTIO_CONFIG_IRQ_IDX. Basically the same thing Viresh > did for "91208dd297f2 virtio: i2c: Check notifier helpers for > VIRTIO_CONFIG_IRQ_IDX

Re: [PATCH v4 24/41] vfio/spapr: Move hostwin_list into spapr container

2023-11-06 Thread Cédric Le Goater
On 11/2/23 08:12, Zhenzhong Duan wrote: No functional changes intended. Signed-off-by: Zhenzhong Duan Reviewed-by: Cédric Le Goater Thanks, C. --- include/hw/vfio/vfio-common.h | 1 - hw/vfio/spapr.c | 36 +++ 2 files changed, 20 inser

Re: [PATCH v7 10/13] hw/pci-host/gpex: Define properties for MMIO ranges

2023-11-06 Thread Michael S. Tsirkin
On Fri, Nov 03, 2023 at 08:46:46AM +0530, Sunil V L wrote: > ACPI DSDT generator needs information like ECAM range, PIO range, 32-bit > and 64-bit PCI MMIO range etc related to the PCI host bridge. Instead of > making these values machine specific, create properties for the GPEX > host bridge with

Re: [PATCH v5 1/6] virtio: split into vhost-user-base and vhost-user-device

2023-11-06 Thread Alex Bennée
"Michael S. Tsirkin" writes: > On Thu, Oct 19, 2023 at 10:56:05AM +0100, Alex Bennée wrote: >> Lets keep a cleaner split between the base class and the derived >> vhost-user-device which we can use for generic vhost-user stubs. This >> includes an update to introduce the vq_size property so the n

Re: [PATCH] tests: Fix printf format string in acpi-utils.c

2023-11-06 Thread Michael S. Tsirkin
On Thu, Oct 26, 2023 at 08:09:30PM -0700, zhujun2 wrote: > Inside of acpi_fetch_table() arguments are > printed via fprintf but '%d' is used to print @flags (of type > uint). Use '%u' instead. > > Signed-off-by: zhujun2 OK though I never expect this to matter. > --- > tests/qtest/acpi-utils.c

[PATCH] Support Intel 82574L for older macOS native Kext

2023-11-06 Thread Christopher Lentocha
When selecting e1000e as nic for macOS Opencore or other macOS in QEMU emulation, it doesn't work but this patch fixes it by changing a PCI ID for Intel 82574L to support macOS native Intel NIC Kexts, both IDs (0x10F6 & 0x10D3) are 82574L but 0x1003 as DEV ID works well with macOS, without any o

Re: [PATCH v3 0/6] migration: check required entries and sections are loaded

2023-11-06 Thread Michael S. Tsirkin
On Mon, Nov 06, 2023 at 03:35:54PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > Surprisingly, the migration code doesn't check that required migration entries > and subsections are loaded. Either optional or required sections are both > ignored when missing. Ac

Re: [PATCH v5 3/6] hw/virtio: derive vhost-user-gpio from vhost-user-base

2023-11-06 Thread Michael S. Tsirkin
On Mon, Nov 06, 2023 at 05:30:39PM +, Alex Bennée wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Oct 19, 2023 at 10:56:07AM +0100, Alex Bennée wrote: > >> Now the new base class supports config handling we can take advantage > >> and make vhost-user-gpio a much simpler boilerplate wrappe

Re: [PATCH v5 1/6] virtio: split into vhost-user-base and vhost-user-device

2023-11-06 Thread Michael S. Tsirkin
On Mon, Nov 06, 2023 at 05:40:10PM +, Alex Bennée wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Oct 19, 2023 at 10:56:05AM +0100, Alex Bennée wrote: > >> Lets keep a cleaner split between the base class and the derived > >> vhost-user-device which we can use for generic vhost-user stubs

Re: [PATCH v2 19/35] tcg/sparc64: Implement tcg_out_extrl_i64_i32

2023-11-06 Thread Richard Henderson
On 11/6/23 07:05, Philippe Mathieu-Daudé wrote: On 28/10/23 21:45, Richard Henderson wrote: Build fix for missing symbol. Cc: qemu-sta...@nongnu.org Fixes: b8b94ac6753 ("tcg: Split out tcg_out_extrl_i64_i32") Commit b8b94ac6753 looks correct, don't we want: Fixes: dad2f2f5af ("tcg/sparc64: Di

Re: [PATCH v2 07/35] tcg: Add TCGConst argument to tcg_target_const_match

2023-11-06 Thread Philippe Mathieu-Daudé
On 28/10/23 21:44, Richard Henderson wrote: Fill the new argument from any condition within the opcode. Not yet used within any backend. Signed-off-by: Richard Henderson --- tcg/tcg.c| 34 ++-- tcg/aarch64/tcg-target.c.inc | 3 ++- tc

Re: [PATCH v2 31/35] tcg/tci: Support TCG_COND_TST{EQ,NE}

2023-11-06 Thread Philippe Mathieu-Daudé
On 28/10/23 21:45, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/tci.c | 14 ++ 1 file changed, 14 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

[PATCH 09/22] gdbstub: Introduce gdb_find_static_feature()

2023-11-06 Thread Alex Bennée
From: Akihiko Odaki This function is useful to determine the number of registers exposed to GDB from the XML name. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20231025093128.33116-3-akihiko.od...@daynix

[PATCH 03/22] target/arm: hide the 32bit version of PAR from gdbstub

2023-11-06 Thread Alex Bennée
This is a slightly hacky way to avoid duplicate PAR's in the system register XML we send to gdb which causes an alias. However the other alternative would be to post process ARMCPRegInfo once all registers have been defined looking for textual duplicates. And that seems like overkill. Signed-off-b

[PATCH 02/22] gdb-xml: fix duplicate register in arm-neon.xml

2023-11-06 Thread Alex Bennée
Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20231103195956.1998255-3-alex.ben...@linaro.org> --- gdb-xml/arm-neon.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb-xml/arm-neon.xml b/gdb-xml/arm-neon.xml index 9dce0a996f..d61f6b8549 100644 ---

[PATCH 08/22] gdbstub: Add num_regs member to GDBFeature

2023-11-06 Thread Alex Bennée
From: Akihiko Odaki Currently the number of registers exposed to GDB is written as magic numbers in code. Derive the number of registers GDB actually see from XML files to replace the magic numbers in code later. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Ale

  1   2   3   4   5   6   7   >