Re: [PATCH v3 12/13] test: Add some tests for range and resv-mem helpers

2023-10-30 Thread Cédric Le Goater
On 10/11/23 19:52, Eric Auger wrote: Add unit tests for both resv_region_list_insert() and range_inverse_array(). Signed-off-by: Eric Auger --- v2 -> v3: - conversion to new GList based protos --- tests/unit/test-resv-mem.c | 318 + tests/unit/meson.buil

Re: [PATCH] file-posix: fix over-writing of returning zone_append offset

2023-10-30 Thread Sam Li
Naohiro Aota 于2023年10月30日周一 15:39写道: > > raw_co_zone_append() sets "s->offset" where "BDRVRawState *s". This pointer > is used later at raw_co_prw() to save the block address where the data is > written. > > When multiple IOs are on-going at the same time, a later IO's > raw_co_zone_append() call

[PATCH 1/1] MAINTAINERS: update mail address for Weiwei Li

2023-10-30 Thread Weiwei Li
My Iscas mail account will be disabled soon, change to my personal gmail account. Signed-off-by: Weiwei Li --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index cd8d6b140f..aa5c5d4bff 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -323

Update mail account

2023-10-30 Thread Weiwei Li
Hi, all. I'v left my job at Iscas. The old iscas mail acount will be disabled soon. So I'll change to use my personal gmail acount (liwei1...@gmail.com) for future reviewer tasks. Regards, Weiwei Li Weiwei Li (1): MAINTAINERS: update mail address for Weiwei Li MAINTAINERS | 2 +- 1 file chan

Re: [PATCH 0/5] Add LoongArch v1.1 instructions

2023-10-30 Thread gaosong
在 2023/10/28 下午9:09, Jiajie Chen 写道: On 2023/10/26 14:54, gaosong wrote: 在 2023/10/26 上午9:38, Jiajie Chen 写道: On 2023/10/26 03:04, Richard Henderson wrote: On 10/25/23 10:13, Jiajie Chen wrote: On 2023/10/24 07:26, Richard Henderson wrote: See target/arm/tcg/translate-a64.c, gen_store_exclu

[PATCH] hw/arm/pxa2xx_gpio: Pass CPU using QOM link property

2023-10-30 Thread Philippe Mathieu-Daudé
Instead of passing the CPU index and resolving it, use a QOM link to directly pass the CPU. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/pxa2xx_gpio.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/arm/pxa2xx_gpio.c b/hw/arm/pxa2xx_gpio.c index e7c3d99224..c8d

Re: [PATCH v3 01/21] parallels: Set s->used_bmap to NULL in parallels_free_used_bitmap()

2023-10-30 Thread Denis V. Lunev
On 10/27/23 09:46, Alexander Ivanov wrote: After used bitmap freeng s->used_bmap points to the freed memory. If we try to free used bitmap one more time it leads to double free error. Set s->used_bmap to NULL to exclude double free error. Signed-off-by: Alexander Ivanov --- block/parallels.c

Re: [PATCH v3 02/21] parallels: Move inactivation code to a separate function

2023-10-30 Thread Denis V. Lunev
On 10/27/23 09:46, Alexander Ivanov wrote: We are going to add parallels image extensions storage and need a separate function for inactivation code. Signed-off-by: Alexander Ivanov --- block/parallels.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --gi

Re: [PATCH v3 03/21] parallels: Make mark_used() a global function

2023-10-30 Thread Denis V. Lunev
On 10/27/23 09:46, Alexander Ivanov wrote: We will need this function and a function for marking unused clusters (will be added in the next patch) in parallels-ext.c too. Let it be a global function parallels_mark_used(). Signed-off-by: Alexander Ivanov --- block/parallels.c | 14

Re: [PATCH v6 5/5] default-configs: Add TARGET_XML_FILES definition

2023-10-30 Thread Philippe Mathieu-Daudé
On 30/10/23 06:46, Akihiko Odaki wrote: loongarch64-linux-user has references to XML files so include them. Fixes: d32688ecdb ("default-configs: Add loongarch linux-user support") Signed-off-by: Akihiko Odaki --- configs/targets/loongarch64-linux-user.mak | 1 + 1 file changed, 1 insertion(+

Re: [PATCH 1/1] MAINTAINERS: update mail address for Weiwei Li

2023-10-30 Thread Philippe Mathieu-Daudé
On 30/10/23 09:16, Weiwei Li wrote: My Iscas mail account will be disabled soon, change to my personal gmail account. Signed-off-by: Weiwei Li --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH] MAINTAINERS: Fully cover target/i386/*

2023-10-30 Thread Markus Armbruster
Many files in target/i386/ are not covered: target/i386/arch_dump.c target/i386/arch_memory_mapping.c target/i386/cpu-dump.c target/i386/cpu-internal.h target/i386/cpu-param.h target/i386/cpu-qom.h target/i386/cpu-sysemu.c target/i386/cpu.c target/i386/cpu.h

Re: [PATCH v2 0/3] vfio/pci: Fix buffer overrun when writing the VF token

2023-10-30 Thread Cédric Le Goater
On 10/26/23 16:00, Cédric Le Goater wrote: On 10/26/23 09:06, Cédric Le Goater wrote: Hello, This series fixes a buffer overrun in VFIO. The buffer used in vfio_realize() by qemu_uuid_unparse() is too small, UUID_FMT_LEN lacks one byte for the trailing NUL. Instead of adding + 1, as done elsew

Re: [PATCH] util/uuid: Define UUID_STR_LEN from UUID_NONE string

2023-10-30 Thread Cédric Le Goater
On 10/27/23 08:54, Cédric Le Goater wrote: Cc: Fam Zheng Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Cédric Le Goater --- Follow up on : https://lore.kernel.org/qemu-devel/20231026070636.1165037-1-...@redhat.com/ include/qemu/uuid.h | 5 +++-- 1 file changed, 3 insertions(

Re: [PATCH v5] hw/pci: modify pci_setup_iommu() to set PCIIOMMUOps

2023-10-30 Thread Cédric Le Goater
On 10/23/23 10:24, Cédric Le Goater wrote: From: Yi Liu This patch modifies pci_setup_iommu() to set PCIIOMMUOps instead of setting PCIIOMMUFunc. PCIIOMMUFunc is used to get an address space for a PCI device in vendor specific way. The PCIIOMMUOps still offers this functionality. But using PCII

Re: [PATCH v9 4/7] hw/isa/vt82c686: Implement PCI IRQ routing

2023-10-30 Thread BALATON Zoltan
On Mon, 30 Oct 2023, Philippe Mathieu-Daudé wrote: On 7/3/23 12:42, BALATON Zoltan wrote: The real VIA south bridges implement a PCI IRQ router which is configured by the BIOS or the OS. In order to respect these configurations, QEMU needs to implement it as well. The real chip may allow routing

Re: [PATCH v3 04/21] parallels: Add parallels_mark_unused() helper

2023-10-30 Thread Denis V. Lunev
On 10/27/23 09:46, Alexander Ivanov wrote: Add a helper to set unused areas in the used bitmap. Signed-off-by: Alexander Ivanov --- block/parallels.c | 17 + block/parallels.h | 2 ++ 2 files changed, 19 insertions(+) diff --git a/block/parallels.c b/block/parallels.c inde

Re: [PATCH v3 04/21] parallels: Add parallels_mark_unused() helper

2023-10-30 Thread Denis V. Lunev
On 10/30/23 10:06, Denis V. Lunev wrote: On 10/27/23 09:46, Alexander Ivanov wrote: Add a helper to set unused areas in the used bitmap. Signed-off-by: Alexander Ivanov ---   block/parallels.c | 17 +   block/parallels.h |  2 ++   2 files changed, 19 insertions(+) diff --git a/

Re: [PATCH 1/1] MAINTAINERS: update mail address for Weiwei Li

2023-10-30 Thread Bin Meng
On Mon, Oct 30, 2023 at 4:17 PM Weiwei Li wrote: > > My Iscas mail account will be disabled soon, change to my personal > gmail account. > > Signed-off-by: Weiwei Li > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Wish you best of luck on your new journey! Reviewe

Re: [PATCH v9 4/7] hw/isa/vt82c686: Implement PCI IRQ routing

2023-10-30 Thread Philippe Mathieu-Daudé
On 30/10/23 10:02, BALATON Zoltan wrote: On Mon, 30 Oct 2023, Philippe Mathieu-Daudé wrote: On 7/3/23 12:42, BALATON Zoltan wrote: The real VIA south bridges implement a PCI IRQ router which is configured by the BIOS or the OS. In order to respect these configurations, QEMU needs to implement

[PATCH] target/s390x/cpu_models: Use 'first_cpu' in s390_get_feat_block()

2023-10-30 Thread Philippe Mathieu-Daudé
We already have a global 'first_cpu' variable storing a pointer to the first CPU, no need to use a static one. Signed-off-by: Philippe Mathieu-Daudé --- target/s390x/cpu_models.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu

Re: [PATCH] target/s390x/cpu_models: Use 'first_cpu' in s390_get_feat_block()

2023-10-30 Thread David Hildenbrand
On 30.10.23 10:31, Philippe Mathieu-Daudé wrote: We already have a global 'first_cpu' variable storing a pointer to the first CPU, no need to use a static one. Signed-off-by: Philippe Mathieu-Daudé --- target/s390x/cpu_models.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff

Re: [PATCH] linux-user/elfload: Add missing arm64 hwcap values

2023-10-30 Thread Peter Maydell
On Sun, 29 Oct 2023 at 21:01, Marielle Novastrider wrote: > > Specifically DIT, LSE2, and MTE3. > > We already expose detection of these via the CPUID interface, but > missed these from ELF hwcaps. > > Signed-off-by: Marielle Novastrider > --- > linux-user/elfload.c | 3 +++ > target/arm/cpu.h

Re: [PATCH v4 3/3] tests/qtest: Introduce tests for AMD/Xilinx Versal TRNG device

2023-10-30 Thread Peter Maydell
On Mon, 30 Oct 2023 at 06:25, Ho, Tong wrote: > > Hi Peter, > > This is in regard to your comment on the use of g_usleep() in waiting for > an event-bit update from the device under test. > > The TRNG device model presented in patch #1 does not have any asynchronous > behavior. > > So, do you mea

Re: [PULL 00/41] target-arm queue

2023-10-30 Thread Peter Maydell
On Sun, 29 Oct 2023 at 23:15, Stefan Hajnoczi wrote: > > On Fri, 27 Oct 2023 at 23:41, Peter Maydell wrote: > > > > Hi; here's the latest target-arm queue. Mostly this is refactoring > > and cleanup type patches. > Hi Peter, > I can't find this email thread on lore.kernel.org and your git repo >

[PATCH] vl: constify default_list

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau It's not modified, let's make it const. Signed-off-by: Marc-André Lureau --- system/vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system/vl.c b/system/vl.c index 86dd2dce28..f42ccfa216 100644 --- a/system/vl.c +++ b/system/vl.c @@ -194,7 +194,

Re: [PATCH v5 3/5] hw/isa/vt82c686: Reuse acpi_update_sci()

2023-10-30 Thread Bernhard Beschow
Am 29. Oktober 2023 00:07:00 UTC schrieb BALATON Zoltan : >On Sat, 28 Oct 2023, Bernhard Beschow wrote: >> acpi_update_sci() covers everything pm_update_sci() does. It implements >> common >> ACPI funtionality in a generic fashion. Note that it agnostic to any >> Frankenstein usage of the gener

Re: [PATCH 0/4] Fix IRQ routing in via south bridge

2023-10-30 Thread Bernhard Beschow
Am 29. Oktober 2023 11:35:27 UTC schrieb BALATON Zoltan : >On Sun, 29 Oct 2023, Bernhard Beschow wrote: >> Am 28. Oktober 2023 23:56:21 UTC schrieb BALATON Zoltan : >>> This is going back to my otiginal proposal in >>> https://patchew.org/QEMU/cover.1677004414.git.bala...@eik.bme.hu/ >>> impleme

Re: [PATCH] vl: constify default_list

2023-10-30 Thread Philippe Mathieu-Daudé
On 30/10/23 11:15, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau It's not modified, let's make it const. Signed-off-by: Marc-André Lureau --- system/vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH v2 1/1] target/riscv: correct csr_ops[CSR_MSECCFG]

2023-10-30 Thread Heinrich Schuchardt
The CSR register mseccfg is used by multiple extensions: Smepm and Zkr. Consider this when checking the existence of the register. Fixes: 77442380ecbe ("target/riscv: rvk: add CSR support for Zkr") Signed-off-by: Heinrich Schuchardt --- v2: rebase on alistair23/riscv-to-apply-next --- t

[PATCH] target/i386: Only allow injecting MCE on x86 CPUs

2023-10-30 Thread Philippe Mathieu-Daudé
When using heterogeneous machines, we can try to inject a MCE on a non-x86 CPU. Filter the CPU is injectable, otherwise display a hint. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/monitor.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/target/i386

Re: [PATCH] MAINTAINERS: Fully cover target/i386/*

2023-10-30 Thread Philippe Mathieu-Daudé
On 30/10/23 09:53, Markus Armbruster wrote: Many files in target/i386/ are not covered: target/i386/arch_dump.c target/i386/arch_memory_mapping.c target/i386/cpu-dump.c target/i386/cpu-internal.h target/i386/cpu-param.h target/i386/cpu-qom.h target/i386/cpu-sys

Re: [PATCH v6 15/23] ui/gl: opengl doesn't require PIXMAN

2023-10-30 Thread Marc-André Lureau
Hi On Thu, Oct 26, 2023 at 12:45 PM Thomas Huth wrote: > > On 26/10/2023 10.09, Marc-André Lureau wrote: > > Hi > > > > On Thu, Oct 26, 2023 at 10:44 AM Thomas Huth wrote: > >> > >> On 25/10/2023 21.08, marcandre.lur...@redhat.com wrote: > >>> From: Marc-André Lureau > >>> > >>> The QEMU fallba

Re: [PATCH 0/3] Misc ati-vga patches

2023-10-30 Thread BALATON Zoltan
On Mon, 23 Oct 2023, BALATON Zoltan wrote: On Tue, 10 Oct 2023, BALATON Zoltan wrote: Some misc patches I had laying around that could be upstreamed just to clean up my tree a bit. Ping? Is Gerd still the maintainer of gfx or who else should be cc'd on such patches? Ping^2 Regards, BALATON

Re: [PATCH 0/6] arm/stellaris: convert gamepad input device to qdev

2023-10-30 Thread Philippe Mathieu-Daudé
On 17/10/23 14:22, Peter Maydell wrote: (I had this all ready to go before I went off on holiday two weeks ago, except I forgot to actually *send* the emails...) This patchseries converts the stellaris board's gamepad input device to qdev. This isn't a very important bit of conversion (I was jus

Re: [PATCH v5 3/5] hw/isa/vt82c686: Reuse acpi_update_sci()

2023-10-30 Thread BALATON Zoltan
On Mon, 30 Oct 2023, Bernhard Beschow wrote: Am 29. Oktober 2023 00:07:00 UTC schrieb BALATON Zoltan : On Sat, 28 Oct 2023, Bernhard Beschow wrote: acpi_update_sci() covers everything pm_update_sci() does. It implements common ACPI funtionality in a generic fashion. Note that it agnostic to any

[PATCH v7 00/23] Make Pixman an optional dependency

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau Hi, QEMU system emulators can be made to compile and work without Pixman. Only a few devices and options actually require it (VNC, Gtk, Spice for ex) and will have to be compiled out. However, most of QEMU graphics-related code is based on pixman_image_t and format. If

[PATCH v7 01/23] build-sys: add a "pixman" feature

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau For now, pixman is mandatory, but we set config_host.h and Kconfig. Once compilation is fixed, "pixman" will become actually optional. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- meson.build | 10 -- include/ui/qemu-pixman.h

[PATCH v7 08/23] vl: move display early init before default devices

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau The next commit needs to have the display registered itself before creating the default VCs. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- system/vl.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/

[PATCH v7 04/23] ui: add pixman-minimal.h

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau This is a tiny subset of PIXMAN API that is used pervasively in QEMU codebase to manage images and identify the underlying format. It doesn't seems worth to wrap this in a QEMU-specific API. Signed-off-by: Marc-André Lureau Acked-by: Thomas Huth --- include/ui/pixman-

[PATCH v7 07/23] vl: simplify display_remote logic

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau Bump the display_remote variable when the -vnc option is parsed, just like -spice. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- system/vl.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/system/vl.c b/system/vl.c index de6df18

[PATCH v7 14/23] vhost-user-gpu: skip VHOST_USER_GPU_UPDATE when !PIXMAN

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau This simply means that 2d drawing updates won't be handled, but 3d should work. Signed-off-by: Marc-André Lureau Acked-by: Michael S. Tsirkin --- hw/display/vhost-user-gpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/vhost-user-gpu.c b/hw/display/

[PATCH v7 11/23] qmp/hmp: disable screendump if PIXMAN is missing

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau The command requires color conversion and line-by-line feeding. We could have a simple fallback for simple formats though. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- qapi/ui.json | 3 ++- ui/ui-hmp-cmds.c | 2

[PATCH v7 12/23] virtio-gpu: replace PIXMAN for region/rect test

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau Use a simpler implementation for rectangle geometry & intersect, drop the need for (more complex) PIXMAN functions. Signed-off-by: Marc-André Lureau Acked-by: Michael S. Tsirkin --- include/ui/rect.h | 59 + hw/display/virt

[PATCH v7 05/23] vl: drop needless -spice checks

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau Since commit 5324e3e958e ("qemu-options: define -spice only #ifdef CONFIG_SPICE"), it is unnecessary to check at runtime for "-spice" option. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- system/vl.c | 7 +-- 1 file changed, 1 insertion(+), 6 deleti

[PATCH v7 18/23] ui/gtk: -display gtk requires PIXMAN

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 0dbad80fcc..ad1e0155ee 100644 --- a/meson.build +++ b/meson.build @@ -1507,7 +1507,11 @@ gt

[PATCH v7 16/23] ui/vnc: VNC requires PIXMAN

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- meson.build| 6 +- ui/meson.build | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 2d67cbf6d6..f3fc1ba68d 100644 --- a/meson.build +++ b/meson.bui

[PATCH v7 13/23] ui/console: when PIXMAN is unavailable, don't draw placeholder msg

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau When we can't draw text, simply show a blank display. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- ui/console.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/console.c b/ui/console.c index a72c495b5a..8e688d3569 100644 --- a/ui/console.c +++

[PATCH v7 03/23] ui: compile out some qemu-pixman functions when !PIXMAN

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau Those functions require the PIXMAN library. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- include/ui/qemu-pixman.h | 7 +-- ui/qemu-pixman.c | 6 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/include/ui/qemu-pixman.h

[PATCH v7 10/23] ui/vc: console-vc requires PIXMAN

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau Add stubs for the fallback paths. get_vc() now returns NULL by default if !PIXMAN. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- ui/console-vc-stubs.c | 33 + ui/console.c | 3 +++ ui/meson.build| 2 +-

[PATCH v7 20/23] arm/kconfig: XLNX_ZYNQMP_ARM depends on PIXMAN

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau The Display Port has some strong PIXMAN dependency. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- hw/arm/Kconfig | 3 ++- hw/display/Kconfig | 5 + hw/display/meson.build | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --g

[PATCH v7 19/23] ui/dbus: do not require PIXMAN

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau Implement a fallback path for region 2D update. Signed-off-by: Marc-André Lureau --- ui/dbus-listener.c | 90 -- ui/meson.build | 4 +-- 2 files changed, 65 insertions(+), 29 deletions(-) diff --git a/ui/dbus-listener.c

[PATCH v7 23/23] build-sys: make pixman actually optional

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- meson.build | 3 --- 1 file changed, 3 deletions(-) diff --git a/meson.build b/meson.build index ad1e0155ee..a35cd860aa 100644 --- a/meson.build +++ b/meson.build @@ -817,9 +817,6 @@ if not get_option('pixma

[PATCH v7 02/23] build-sys: drop needless warning pragmas for old pixman

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau Since commit 236f282c1c7 ("configure: check for pixman-1 version"), QEMU requires >= 0.21.8. Suggested-by: Thomas Huth Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- include/ui/qemu-pixman.h | 4 1 file changed, 4 deletions(-) diff --git a/include

[PATCH v7 17/23] ui/spice: SPICE/QXL requires PIXMAN

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- meson.build| 6 +- hw/display/Kconfig | 2 +- ui/meson.build | 10 +- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/meson.build b/meson.build index f3fc1ba68d..0dba

[PATCH v7 21/23] hw/sm501: allow compiling without PIXMAN

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau Change the "x-pixman" property default value and use the fallback path when PIXMAN support is disabled. Signed-off-by: Marc-André Lureau Reviewed-by: BALATON Zoltan --- hw/display/sm501.c | 46 +- 1 file changed, 33 insertion

[PATCH v7 09/23] ui/console: allow to override the default VC

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau If a display is backed by a specialized VC, allow to override the default "vc:80Cx24C". As suggested by Paolo, if the display doesn't implement a VC (get_vc() returns NULL), use a fallback that will use a muxed console on stdio. This changes the behaviour of "qemu -displ

[PATCH v7 06/23] qemu-options: define -vnc only #ifdef CONFIG_VNC

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- system/vl.c | 13 + ui/vnc-stubs.c | 12 qemu-options.hx | 2 ++ 3 files changed, 11 insertions(+), 16 deletions(-) diff --git a/system/vl.c b/system/vl.c index 3be1a78a9d..de6

[PATCH v7 22/23] hw/display: make ATI_VGA depend on PIXMAN

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau To avoid a kconfig cycle, change "depends on PCI" to "select PCI". Signed-off-by: Marc-André Lureau Acked-by: BALATON Zoltan --- configs/devices/mips64el-softmmu/default.mak | 3 +-- hw/display/Kconfig | 3 ++- hw/display/meson.build

[PATCH v7 15/23] ui/gl: opengl doesn't require PIXMAN

2023-10-30 Thread marcandre . lureau
From: Marc-André Lureau The QEMU fallback covers the requirements. We still need the flags of header inclusion with CONFIG_PIXMAN. Signed-off-by: Marc-André Lureau --- ui/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/meson.build b/ui/meson.build index 3

QEMU developers fortnightly conference call for 2023-10-31

2023-10-30 Thread Juan Quintela
Hi If you have any topics for this week Conference call, please answer to this email. Thanks, Juan. QEMU developers fortnightly conference call Tuesday 2023-10-31 ⋅ 14:00 – 15:00 Central European Time - Madrid Location https://meet.jit.si/kvmcallmeeting https://www.google.com/url?q=https

Re: [PATCH 1/3] ati-vga: Fix aperture sizes

2023-10-30 Thread Marc-André Lureau
Hi On Tue, Oct 10, 2023 at 5:03 PM BALATON Zoltan wrote: > > Apparently these should be half the memory region sizes confirmed at > least by Radeon drivers while Rage 128 Pro drivers don't seem to use > these. There doesn't seem to be adjustments for the kernel PPC driver https://github.com/torv

Re: [PATCH 2/3] ati-vga: Support unaligned access to GPIO DDC registers

2023-10-30 Thread Marc-André Lureau
On Tue, Oct 10, 2023 at 5:03 PM BALATON Zoltan wrote: > > The GPIO_VGA_DDC and GPIO_DVI_DDC registers are used on Radeon for DDC > access. Some drivers like the PPC Mac FCode ROM uses unaligned writes > to these registers so implement this the same way as already done for > GPIO_MONID which is use

Re: [PATCH 1/1] MAINTAINERS: update mail address for Weiwei Li

2023-10-30 Thread LIU Zhiwei
On 2023/10/30 16:16, Weiwei Li wrote: My Iscas mail account will be disabled soon, change to my personal gmail account. Signed-off-by: Weiwei Li --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index cd8d6b140f..aa5c5d4bff 100644

Re: [PATCH 01/11] qdev: Add qdev_prop_set_array()

2023-10-30 Thread Kevin Wolf
Am 27.10.2023 um 20:06 hat Peter Maydell geschrieben: > On Fri, 8 Sept 2023 at 15:37, Kevin Wolf wrote: > > > > Instead of exposing the ugly hack of how we represent arrays in qdev (a > > static "foo-len" property and after it is set, dynamically created > > "foo[i]" properties) to boards, add an

Re: [PATCH 0/6] arm/stellaris: convert gamepad input device to qdev

2023-10-30 Thread Peter Maydell
On Mon, 30 Oct 2023 at 10:39, Philippe Mathieu-Daudé wrote: > > On 17/10/23 14:22, Peter Maydell wrote: > > (I had this all ready to go before I went off on holiday two > > weeks ago, except I forgot to actually *send* the emails...) > > > > This patchseries converts the stellaris board's gamepad

[PATCH v2 5/6] hw/input/stellaris_input: Convert to qdev

2023-10-30 Thread Peter Maydell
Convert the hw/input/stellaris_input device to qdev. The interface uses an array property for the board to specify the keycodes to use, so the s->keycodes memory is now allocated by the array-property machinery. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philipp

[PATCH v2 6/6] hw/input/stellaris_gamepad: Convert to qemu_input_handler_register()

2023-10-30 Thread Peter Maydell
Now that we have converted to qdev, we can use the newer qemu_input_handler_register() API rather than the legacy qemu_add_kbd_event_handler(). Since we only have one user, take the opportunity to convert from scancodes to QCodes, rather than using qemu_input_key_value_to_scancode() (which adds an

[PATCH v2 2/6] hw/input/stellaris_gamepad: Rename structs to our usual convention

2023-10-30 Thread Peter Maydell
Rename the structs in stellaris_gamepad.c to our now-standard CamelCase convention. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- hw/input/stellaris_gamepad.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-)

[PATCH v2 1/6] hw/input/stellaris_input: Rename to stellaris_gamepad

2023-10-30 Thread Peter Maydell
This source file implements a stellaris gamepad device; rename it so that it is a closer match to the device name. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- include/hw/input/{gamepad.h => stellaris_gamepad.h} | 6 +++--- hw/arm/stell

[PATCH v2 0/6] arm/stellaris: convert gamepad input device to qdev

2023-10-30 Thread Peter Maydell
This patchseries converts the stellaris board's gamepad input device to qdev. This isn't a very important bit of conversion (I was just looking for a small tail-end-of-the-week task), but it does reduce by one the number of users of a couple of legacy APIs: vmstate_register() and qemu_add_kbd_event

[PATCH v2 4/6] hw/input/stellaris_gamepad: Remove StellarisGamepadButton struct

2023-10-30 Thread Peter Maydell
Currently for each button on the device we have a StellarisGamepadButton struct which has the irq, keycode and pressed state for it. When we convert to qdev, the qdev property and GPIO APIs are going to require that we have separate arrays for the irqs and keycodes. Convert from array-of-structs

Re: [PATCH v6 01/12] target/riscv: add zicbop extension flag

2023-10-30 Thread Daniel Henrique Barboza
ze", I think we need to get this node approved by devicet...@vger.kernel.org and merged into [1] first. [1] Linux repo: Documentation/devicetree/bindings/riscv/cpus.yaml We got an ack from the devicetree folks to add the "riscv,cbop-block-size" DT node: https://lore.kernel.

[PATCH v2 3/6] qdev: Add qdev_prop_set_array()

2023-10-30 Thread Peter Maydell
From: Kevin Wolf Instead of exposing the ugly hack of how we represent arrays in qdev (a static "foo-len" property and after it is set, dynamically created "foo[i]" properties) to boards, add an interface that allows setting the whole array at once. Once all internal users of devices with array

Re: [PATCH v5] hw/pci: modify pci_setup_iommu() to set PCIIOMMUOps

2023-10-30 Thread Michael S. Tsirkin
On Mon, Oct 30, 2023 at 10:00:35AM +0100, Cédric Le Goater wrote: > On 10/23/23 10:24, Cédric Le Goater wrote: > > From: Yi Liu > > > > This patch modifies pci_setup_iommu() to set PCIIOMMUOps > > instead of setting PCIIOMMUFunc. PCIIOMMUFunc is used to > > get an address space for a PCI device i

Re: [PATCH 0/5] Add LoongArch v1.1 instructions

2023-10-30 Thread Jiajie Chen
On 2023/10/30 16:23, gaosong wrote: 在 2023/10/28 下午9:09, Jiajie Chen 写道: On 2023/10/26 14:54, gaosong wrote: 在 2023/10/26 上午9:38, Jiajie Chen 写道: On 2023/10/26 03:04, Richard Henderson wrote: On 10/25/23 10:13, Jiajie Chen wrote: On 2023/10/24 07:26, Richard Henderson wrote: See target/a

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

2023-10-30 Thread Yuri Benditovich
On Mon, Oct 30, 2023 at 7:14 AM Akihiko Odaki wrote: > vhost requires eBPF for RSS. When eBPF is not available, virtio-net > implicitly disables RSS even if the user explicitly requests it. Return > an error instead of implicitly disabling RSS if RSS is requested but not > available. > I think t

[PATCH v5 0/4] Add full zoned storage emulation to qcow2 driver

2023-10-30 Thread Sam Li
This patch series add a new extension - zoned format - to the qcow2 driver thereby allowing full zoned storage emulation on the qcow2 img file. Users can attach such a qcow2 file to the guest as a zoned device. Write pointer are preserved in the zoned metadata. It will be recovered after power cyc

[PATCH v5 1/4] docs/qcow2: add the zoned format feature

2023-10-30 Thread Sam Li
Add the specs for the zoned format feature of the qcow2 driver. The qcow2 file can be taken as zoned device and passed through by virtio-blk device or NVMe ZNS device to the guest given zoned information. Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi --- docs/system/qemu-block-drivers.rst.

[PATCH v5 2/4] qcow2: add configurations for zoned format extension

2023-10-30 Thread Sam Li
To configure the zoned format feature on the qcow2 driver, it requires settings as: the device size, zone model, zone size, zone capacity, number of conventional zones, limits on zone resources (max append bytes, max open zones, and max_active_zones). To create a qcow2 file with zoned format, use

[PATCH v5 4/4] iotests: test the zoned format feature for qcow2 file

2023-10-30 Thread Sam Li
The zoned format feature can be tested by: $ tests/qemu-iotests/check -qcow2 zoned-qcow2 Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi --- tests/qemu-iotests/tests/zoned-qcow2 | 126 +++ tests/qemu-iotests/tests/zoned-qcow2.out | 118 + 2 files c

[PATCH v5 3/4] qcow2: add zoned emulation capability

2023-10-30 Thread Sam Li
By adding zone operations and zoned metadata, the zoned emulation capability enables full emulation support of zoned device using a qcow2 file. The zoned device metadata includes zone type, zoned device state and write pointer of each zone, which is stored to an array of unsigned integers. Each zo

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

2023-10-30 Thread Akihiko Odaki
On 2023/10/30 21:14, Yuri Benditovich wrote: On Mon, Oct 30, 2023 at 7:14 AM Akihiko Odaki > wrote: vhost requires eBPF for RSS. When eBPF is not available, virtio-net implicitly disables RSS even if the user explicitly requests it. Return an error

Re: [PATCH v6 12/21] virtio-net: Enable software RSS

2023-10-30 Thread Yuri Benditovich
On Mon, Oct 30, 2023 at 7:14 AM Akihiko Odaki wrote: > virtio-net implements software RSS but does not enable it. Enable it > when RSS is requested, but the eBPF implementation is not available. > We also check if vhost is in use in such a case since software RSS is > incompatible with vhost. A w

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

2023-10-30 Thread Yuri Benditovich
On Mon, Oct 30, 2023 at 2:21 PM Akihiko Odaki wrote: > On 2023/10/30 21:14, Yuri Benditovich wrote: > > > > > > On Mon, Oct 30, 2023 at 7:14 AM Akihiko Odaki > > wrote: > > > > vhost requires eBPF for RSS. When eBPF is not available, virtio-net > > implic

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

2023-10-30 Thread Akihiko Odaki
On 2023/10/30 21:51, Yuri Benditovich wrote: On Mon, Oct 30, 2023 at 2:21 PM Akihiko Odaki > wrote: On 2023/10/30 21:14, Yuri Benditovich wrote: > > > On Mon, Oct 30, 2023 at 7:14 AM Akihiko Odaki mailto:akihiko.od...@daynix.com> >

Re: [PATCH 0/6] arm/stellaris: convert gamepad input device to qdev

2023-10-30 Thread Philippe Mathieu-Daudé
On 30/10/23 12:29, Peter Maydell wrote: On Mon, 30 Oct 2023 at 10:39, Philippe Mathieu-Daudé wrote: On 17/10/23 14:22, Peter Maydell wrote: (I had this all ready to go before I went off on holiday two weeks ago, except I forgot to actually *send* the emails...) This patchseries converts the

[PATCH v5 03/13] hw/i386/acpi-microvm.c: Use common function to add virtio in DSDT

2023-10-30 Thread Sunil V L
With common function to add virtio in DSDT created now, update microvm code also to use it instead of duplicate code. Suggested-by: Andrew Jones Signed-off-by: Sunil V L Acked-by: Alistair Francis --- hw/i386/acpi-microvm.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-)

[PATCH v5 04/13] hw/riscv: virt: Make few IMSIC macros and functions public

2023-10-30 Thread Sunil V L
Some macros and static function related to IMSIC are defined in virt.c. They are required in virt-acpi-build.c. So, make them public. Signed-off-by: Sunil V L Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Reviewed-by: Andrew Jones --- hw/riscv/virt.c | 25 +---

[PATCH v5 13/13] hw/riscv/virt-acpi-build.c: Add PLIC in MADT

2023-10-30 Thread Sunil V L
Add PLIC structures for each socket in the MADT when system is configured with PLIC as the external interrupt controller. Signed-off-by: Haibo Xu Signed-off-by: Sunil V L Reviewed-by: Daniel Henrique Barboza Reviewed-by: Andrew Jones Acked-by: Alistair Francis --- hw/riscv/virt-acpi-build.c

[PATCH v5 12/13] hw/riscv/virt-acpi-build.c: Add IO controllers and devices

2023-10-30 Thread Sunil V L
Add basic IO controllers and devices like PCI, VirtIO and UART in the ACPI namespace. Signed-off-by: Sunil V L Reviewed-by: Daniel Henrique Barboza Acked-by: Alistair Francis --- hw/riscv/Kconfig | 1 + hw/riscv/virt-acpi-build.c | 79 -- 2 files

[PATCH v5 05/13] hw/riscv/virt-acpi-build.c: Add AIA support in RINTC

2023-10-30 Thread Sunil V L
Update the RINTC structure in MADT with AIA related fields. Signed-off-by: Sunil V L Reviewed-by: Daniel Henrique Barboza Acked-by: Alistair Francis Reviewed-by: Andrew Jones --- hw/riscv/virt-acpi-build.c | 43 ++ 1 file changed, 39 insertions(+), 4 deleti

[PATCH v5 01/13] hw/arm/virt-acpi-build.c: Migrate fw_cfg creation to common location

2023-10-30 Thread Sunil V L
RISC-V also needs to use the same code to create fw_cfg in DSDT. So, avoid code duplication by moving the code in arm and riscv to a device specific file. Suggested-by: Igor Mammedov Signed-off-by: Sunil V L Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Reviewed-by: Andrew

[PATCH v5 09/13] hw/riscv/virt-acpi-build.c: Add MMU node in RHCT

2023-10-30 Thread Sunil V L
MMU type information is available via MMU node in RHCT. Add this node in RHCT. Signed-off-by: Sunil V L Reviewed-by: Daniel Henrique Barboza Reviewed-by: Andrew Jones --- hw/riscv/virt-acpi-build.c | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff

[PATCH v5 02/13] hw/arm/virt-acpi-build.c: Migrate virtio creation to common location

2023-10-30 Thread Sunil V L
RISC-V also needs to create the virtio in DSDT in the same way as ARM. So, instead of duplicating the code, move this function to the device specific file which is common across architectures. Suggested-by: Igor Mammedov Signed-off-by: Sunil V L Reviewed-by: Alistair Francis Reviewed-by: Andrew

[PATCH v5 07/13] hw/riscv/virt-acpi-build.c: Add APLIC in the MADT

2023-10-30 Thread Sunil V L
Add APLIC structures for each socket in the MADT when system is configured with APLIC as the external wired interrupt controller. Signed-off-by: Sunil V L Reviewed-by: Daniel Henrique Barboza Reviewed-by: Andrew Jones Acked-by: Alistair Francis --- hw/riscv/virt-acpi-build.c | 34

[PATCH v5 00/13] RISC-V: ACPI: Enable AIA, PLIC and update RHCT

2023-10-30 Thread Sunil V L
This series primarily enables external interrupt controllers (AIA and PLIC) in ACPI tables for RISC-V virt platform. It also updates RHCT with CMO and MMU related information. Below ECRs for these changes are approved by ASWG and will be available in next ACPI spec release. 1) MADT (AIA) - https

[PATCH v5 11/13] hw/riscv/virt: Update GPEX MMIO related properties

2023-10-30 Thread Sunil V L
Update the GPEX host bridge properties related to MMIO ranges with values set for the virt machine. Suggested-by: Igor Mammedov Signed-off-by: Sunil V L Reviewed-by: Alistair Francis --- hw/riscv/virt.c | 47 - include/hw/riscv/virt.h | 1 + 2 f

[PATCH v5 08/13] hw/riscv/virt-acpi-build.c: Add CMO information in RHCT

2023-10-30 Thread Sunil V L
When CMO related extensions like Zicboz, Zicbom and Zicbop are enabled, the block size for those extensions need to be communicated via CMO node in RHCT. Add CMO node in RHCT if any of those CMO extensions are detected. Signed-off-by: Sunil V L Reviewed-by: Daniel Henrique Barboza Reviewed-by: A

[PATCH v5 10/13] hw/pci-host/gpex: Define properties for MMIO ranges

2023-10-30 Thread Sunil V L
ACPI DSDT generator needs information like ECAM range, PIO range, 32-bit and 64-bit PCI MMIO range etc related to the PCI host bridge. Instead of making these values machine specific, create properties for the GPEX host bridge with default value 0. During initialization, the firmware can initialize

  1   2   3   >