Re: [PATCH v2 22/24] tests/avocado: switch to using xen-net-device for Xen guest tests

2023-10-23 Thread David Woodhouse
On Thu, 2023-10-19 at 16:40 +0100, David Woodhouse wrote: > From: David Woodhouse > > Fix the filename in the MAINTAINERS file too. > > Signed-off-by: David Woodhouse > --- >  MAINTAINERS    | 2 +- >  tests/avocado/kvm_xen_guest.py | 2 +- >  2 files changed, 2 insertions(+), 2 d

[PATCH v6 2/9] drm/atomic: Add support for mouse hotspots

2023-10-23 Thread Albert Esteve
From: Zack Rusin Atomic modesetting code lacked support for specifying mouse cursor hotspots. The legacy kms DRM_IOCTL_MODE_CURSOR2 had support for setting the hotspot but the functionality was not implemented in the new atomic paths. Due to the lack of hotspots in the atomic paths userspace com

[PATCH v6 7/9] drm: Remove legacy cursor hotspot code

2023-10-23 Thread Albert Esteve
From: Zack Rusin Atomic modesetting supports mouse cursor offsets via the hotspot properties that are created on cursor planes. All drivers which support hotspots are atomic and the legacy code has been implemented in terms of the atomic properties as well. Due to the above the lagacy cursor hot

[PATCH v6 8/9] drm: Introduce DRM_CLIENT_CAP_CURSOR_PLANE_HOTSPOT

2023-10-23 Thread Albert Esteve
From: Zack Rusin Virtualized drivers place additional restrictions on the cursor plane which breaks the contract of universal planes. To allow atomic modesettings with virtualized drivers the clients need to advertise that they're capable of dealing with those extra restrictions. To do that intr

[PATCH v6 3/9] drm/vmwgfx: Use the hotspot properties from cursor planes

2023-10-23 Thread Albert Esteve
From: Zack Rusin Atomic modesetting got support for mouse hotspots via the hotspot properties. Port the legacy kms hotspot handling to the new properties on cursor planes. Signed-off-by: Zack Rusin Cc: Maaz Mombasawala Reviewed-by: Javier Martinez Canillas Reviewed-by: Martin Krastev --- dr

[PATCH v6 5/9] drm/vboxvideo: Use the hotspot properties from cursor planes

2023-10-23 Thread Albert Esteve
From: Zack Rusin Atomic modesetting got support for mouse hotspots via the hotspot properties. Port the legacy kms hotspot handling to the new properties on cursor planes. Signed-off-by: Zack Rusin Cc: Hans de Goede Cc: David Airlie Cc: Daniel Vetter Reviewed-by: Javier Martinez Canillas --

[PATCH v6 4/9] drm/qxl: Use the hotspot properties from cursor planes

2023-10-23 Thread Albert Esteve
From: Zack Rusin Atomic modesetting got support for mouse hotspots via the hotspot properties. Port the legacy kms hotspot handling to the new properties on cursor planes. Signed-off-by: Zack Rusin Reviewed-by: Gerd Hoffmann Cc: Dave Airlie Cc: Daniel Vetter Cc: virtualizat...@lists.linux-fo

[PATCH v6 0/9] Fix cursor planes with virtualized drivers

2023-10-23 Thread Albert Esteve
v6: Shift DRIVER_CURSOR_HOTSPOT flag bit to BIT(9), since BIT(8) was already taken by DRIVER_GEM_GPUVA. v5: Add a change with documentation from Michael, based on his discussion with Pekka and bump the kernel version DRM_CLIENT_CAP_CURSOR_PLANE_HOTSPOT might be introduced with to 6.6. v4: Make dr

[PATCH v6 9/9] drm: Introduce documentation for hotspot properties

2023-10-23 Thread Albert Esteve
From: Michael Banack To clarify the intent and reasoning behind the hotspot properties introduce userspace documentation that goes over cursor handling in para-virtualized environments. The documentation is generic enough to not special case for any specific hypervisor and should apply equally t

[PATCH v6 1/9] drm: Disable the cursor plane on atomic contexts with virtualized drivers

2023-10-23 Thread Albert Esteve
From: Zack Rusin Cursor planes on virtualized drivers have special meaning and require that the clients handle them in specific ways, e.g. the cursor plane should react to the mouse movement the way a mouse cursor would be expected to and the client is required to set hotspot properties on it in

[PATCH v6 6/9] drm/virtio: Use the hotspot properties from cursor planes

2023-10-23 Thread Albert Esteve
From: Zack Rusin Atomic modesetting got support for mouse hotspots via the hotspot properties. Port the legacy kms hotspot handling to the new properties on cursor planes. Signed-off-by: Zack Rusin Reviewed-by: Gerd Hoffmann Cc: David Airlie Cc: Gurchetan Singh Cc: Chia-I Wu Cc: Daniel Vett

Re: [PATCH v3 0/9] virtio-console: notify about the terminal size

2023-10-23 Thread Amit Shah
On Mon, 2023-10-23 at 05:12 +0200, Filip Hejsek wrote: > I have found this 3 year old patch adding virtio console resize > support, which seems to have been forgotten at that time. I would like > to see this feature merged. > > Szymon, you have originally submitted this patch, would you be willing

Re: [PATCH v6 0/9] Fix cursor planes with virtualized drivers

2023-10-23 Thread Albert Esteve
On Mon, Oct 23, 2023 at 9:55 AM Simon Ser wrote: > On Monday, October 23rd, 2023 at 09:46, Albert Esteve > wrote: > > > Link to the IGT test covering this patch (already merged): > > https://lists.freedesktop.org/archives/igt-dev/2023-July/058427.html > > Hmm. IGT should not be merged before the

Re: [PATCH v3 3/6] target/riscv/tcg: add user flag for profile support

2023-10-23 Thread Andrew Jones
On Fri, Oct 20, 2023 at 07:39:48PM -0300, Daniel Henrique Barboza wrote: > The TCG emulation implements all the extensions described in the > RVA22U64 profile, both mandatory and optional. The mandatory extensions > will be enabled via the profile flag. We'll leave the optional > extensions to be e

Re: [PATCH v2 1/2] hw/cxl: Pass CXLComponentState to cache_mem_ops

2023-10-23 Thread Zhijian Li (Fujitsu)
On 19/10/2023 18:50, Jonathan Cameron wrote: > On Wed, 18 Oct 2023 16:24:07 +0800 > Li Zhijian wrote: > >> cache_mem_ops.{read,write}() interprets opaque as >> CXLComponentState(cxl_cstate) instead of ComponentRegisters(cregs). >> >> Fortunately, cregs is the first member of cxl_cstate, so thei

[PATCH v5] hw/pci: modify pci_setup_iommu() to set PCIIOMMUOps

2023-10-23 Thread Cédric Le Goater
From: Yi Liu This patch modifies pci_setup_iommu() to set PCIIOMMUOps instead of setting PCIIOMMUFunc. PCIIOMMUFunc is used to get an address space for a PCI device in vendor specific way. The PCIIOMMUOps still offers this functionality. But using PCIIOMMUOps leaves space to add more iommu relate

RE: [PATCH 0/5] Live Migration Acceleration with IAA Compression

2023-10-23 Thread Liu, Yuan1
> -Original Message- > From: Daniel P. Berrangé > Sent: Thursday, October 19, 2023 11:32 PM > To: Peter Xu > Cc: Juan Quintela ; Liu, Yuan1 > ; faro...@suse.de; leob...@redhat.com; qemu- > de...@nongnu.org; Zou, Nanhai > Subject: Re: [PATCH 0/5] Live Migration Acceleration with IAA Compr

Re: [PATCH v12 02/11] Add virtio-sound-pci device

2023-10-23 Thread Manos Pitsidianakis
Good morning Volker, On Sun, 22 Oct 2023 14:51, Volker Rümelin wrote: Sorry, I don't understand your last sentence. You add this alias with the following line in patch 02/11, so there is a virtio-sound alias. This alias doesn't work because there is a device with the same name. My bad, I thou

Should we replace QAPI? (was: [PATCH v14 02/14] fixup! migration: New QAPI type 'MigrateAddress')

2023-10-23 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Oct 20, 2023 at 02:37:16PM +0200, Markus Armbruster wrote: >> Fabiano Rosas writes: >> >> > Markus Armbruster writes: >> > >> >> Fabiano Rosas writes: >> >> >> >>> Signed-off-by: Fabiano Rosas >> > >> > Side question: are we using valid JSON at all? I thr

Re: Re: [PATCH] virtio-blk: don't start dataplane during the stop of dataplane

2023-10-23 Thread Kevin Wolf
Am 19.10.2023 um 09:28 hat lv.mengz...@zte.com.cn geschrieben: > On Tue, Oct 17, 2023 at 10:04PM +0800, stefa...@redhat.com wrote: > > > From: hujian > > > > > > During the stop of dataplane for virtio-blk, > > > virtio_bus_cleanup_host_notifier() is be > > > called to clean up notifier at the

Re: [PATCH 11/12] hw/xen: automatically assign device index to block devices

2023-10-23 Thread Igor Mammedov
On Wed, 18 Oct 2023 09:32:47 +0100 David Woodhouse wrote: > On Wed, 2023-10-18 at 09:32 +0200, Igor Mammedov wrote: > > On Mon, 16 Oct 2023 16:19:08 +0100 > > David Woodhouse wrote: > > > > > From: David Woodhouse > > > > > > > is this index a user (guest) visible? > > Yes. It defines

Re: [PATCH 1/4] vhost-user-blk: simplify and fix vhost_user_blk_handle_config_change

2023-10-23 Thread Raphael Norwitz
I don’t understand the “valid for resize only” comment. Looks like this is zero day behavior and I can’t tell why it was added. Does anyone know? With that, reasoning and code looks good: Acked-by: Raphael Norwitz > On Oct 6, 2023, at 4:20 PM, Vladimir Sementsov-Ogievskiy > wrote: > > Let's

Re: [PATCH v3 1/9] blockjob: introduce block-job-change QMP command

2023-10-23 Thread Fiona Ebner
Am 18.10.23 um 17:52 schrieb Kevin Wolf: > Am 13.10.2023 um 11:21 hat Fiona Ebner geschrieben: >> which will allow changing job-type-specific options after job >> creation. >> >> In the JobVerbTable, the same allow bits as for set-speed are used, >> because set-speed can be considered an existing c

Re: [RFC PATCH 48/78] contrib/vhost-user-scsi: add fallthrough pseudo-keyword

2023-10-23 Thread Raphael Norwitz
> On Oct 13, 2023, at 3:48 AM, Emmanouil Pitsidianakis > wrote: > > In preparation of raising -Wimplicit-fallthrough to 5, replace all > fall-through comments with the fallthrough attribute pseudo-keyword. > > Signed-off-by: Emmanouil Pitsidianakis Reviewed-by: Raphael Norwitz > --- > co

Re: [RFC PATCH 47/75] contrib/vhost-user-scsi: add fallthrough pseudo-keyword

2023-10-23 Thread Raphael Norwitz
> On Oct 13, 2023, at 3:48 AM, Emmanouil Pitsidianakis > wrote: > > Signed-off-by: Emmanouil Pitsidianakis Reviewed-by: Raphael Norwitz > --- > contrib/vhost-user-scsi/vhost-user-scsi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/contrib/vhost-user-scsi/vhos

[PATCH v3 02/16] tests: bios-tables-test: Prepare the ACPI table change for smbios type4 count test

2023-10-23 Thread Zhao Liu
From: Zhao Liu Following the guidelines in tests/qtest/bios-tables-test.c, this is step 1 - 3. List the ACPI tables that will be added to test the type 4 count. Signed-off-by: Zhao Liu Reviewed-by: Michael S. Tsirkin --- tests/data/acpi/q35/APIC.type4-count| 0 tests/data/acpi/q35/DS

[PATCH v3 01/16] tests: test-smp-parse: Add the test for cores/threads per socket helpers

2023-10-23 Thread Zhao Liu
From: Zhao Liu Use the different ways to calculate cores/threads per socket, so that the new CPU topology levels won't be missed in these 2 helpes: * machine_topo_get_cores_per_socket() * machine_topo_get_threads_per_socket() Test the commit a1d027be95bc3 ("machine: Add helpers to get cores/ th

[PATCH v3 03/16] tests: bios-tables-test: Add test for smbios type4 count

2023-10-23 Thread Zhao Liu
From: Zhao Liu This tests the commit d79a284a44bb7 ("hw/smbios: Fix smbios_smp_sockets calculation"). In smbios_get_tables() (hw/smbios/smbios.c), smbios type4 table is built for each socket, so the count of type4 tables should be equal to the number of sockets. Thus for the topology in this ca

[PATCH v3 04/16] tests: bios-tables-test: Add ACPI table binaries for smbios type4 count test

2023-10-23 Thread Zhao Liu
From: Zhao Liu Following the guidelines in tests/qtest/bios-tables-test.c, this is step 5 and 6. Changes in the tables: FACP: +/* + * Intel ACPI Component Architecture + * AML/ASL+ Disassembler version 20200925 (64-bit version) + * Copyright (c) 2000 - 2020 Intel Corporation + * + * Disassembly

[PATCH v3 14/16] tests: bios-tables-test: Prepare the ACPI table change for smbios type4 thread count2 test

2023-10-23 Thread Zhao Liu
From: Zhao Liu Following the guidelines in tests/qtest/bios-tables-test.c, this is step 1 - 3. List the ACPI tables that will be added to test the thread count2 field of smbios type4 table. Signed-off-by: Zhao Liu Reviewed-by: Michael S. Tsirkin --- tests/data/acpi/q35/APIC.thread-count2

[PATCH v3 13/16] tests: bios-tables-test: Add ACPI table binaries for smbios type4 thread count test

2023-10-23 Thread Zhao Liu
From: Zhao Liu Following the guidelines in tests/qtest/bios-tables-test.c, this is step 5 and 6. Changes in the tables: FACP: +/* + * Intel ACPI Component Architecture + * AML/ASL+ Disassembler version 20200925 (64-bit version) + * Copyright (c) 2000 - 2020 Intel Corporation + * + * Disassembly

[PATCH v3 10/16] tests: bios-tables-test: Update ACPI table binaries for smbios core count2 test

2023-10-23 Thread Zhao Liu
From: Zhao Liu Change the core count2 from 275 to 260. Following the guidelines in tests/qtest/bios-tables-test.c, this is step 5 and 6. Changes in the tables: APIC: /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20200925 (64-bit version) * Copyright (c) 2000 - 2

[PATCH v3 16/16] tests: bios-tables-test: Add ACPI table binaries for smbios type4 thread count2 test

2023-10-23 Thread Zhao Liu
From: Zhao Liu Following the guidelines in tests/qtest/bios-tables-test.c, this is step 5 and 6. Changes in the tables: FACP: +/* + * Intel ACPI Component Architecture + * AML/ASL+ Disassembler version 20200925 (64-bit version) + * Copyright (c) 2000 - 2020 Intel Corporation + * + * Disassembly

[PATCH v3 09/16] tests: bios-tables-test: Extend smbios core count2 test to cover general topology

2023-10-23 Thread Zhao Liu
From: Zhao Liu The commit 196ea60a734c3 ("hw/smbios: Fix core count in type4") fixed the miscalculation of cores per socket. The original core count2 test (with the topology configured by "-smp 275") didn't recognize that topology-related but because it just created a special topology with only

[PATCH v3 15/16] tests: bios-tables-test: Add test for smbios type4 thread count2

2023-10-23 Thread Zhao Liu
From: Zhao Liu This tests the commit 7298fd7de5551 ("hw/smbios: Fix thread count in type4"). In smbios_build_type_4_table() (hw/smbios/smbios.c), if the number of threads in the socket is more than 255, then smbios type4 table encodes threads per socket into the thread count2 field. So for the

[PATCH v3 12/16] tests: bios-tables-test: Add test for smbios type4 thread count

2023-10-23 Thread Zhao Liu
From: Zhao Liu This tests the commit 7298fd7de5551 ("hw/smbios: Fix thread count in type4"). In smbios_build_type_4_table() (hw/smbios/smbios.c), if the number of threads in the socket is not more than 255, then smbios type4 table encodes threads per socket into the thread count field. So for t

[PATCH v3 00/16] tests: Add CPU topology related smbios test cases

2023-10-23 Thread Zhao Liu
From: Zhao Liu Hi all, This patchset is the v3 which fixes the CI failure [1] reported in v2: Number of hotpluggable cpus requested (520) exceeds the maximum cpus supported by KVM (288) socket_accept failed: Resource temporarily unavailable Changes in v3 = v3 reduces the vCPU num

[PATCH v3 08/16] tests: bios-tables-test: Prepare the ACPI table change for smbios type4 core count2 test

2023-10-23 Thread Zhao Liu
From: Zhao Liu Following the guidelines in tests/qtest/bios-tables-test.c, this is step 1 - 3. List the ACPI tables that will be changed about the type 4 core count2 test case. Signed-off-by: Zhao Liu Reviewed-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ 1 f

[PATCH v3 07/16] tests: bios-tables-test: Add ACPI table binaries for smbios type4 core count test

2023-10-23 Thread Zhao Liu
From: Zhao Liu Following the guidelines in tests/qtest/bios-tables-test.c, this is step 5 and 6. Changes in the tables: FACP: +/* + * Intel ACPI Component Architecture + * AML/ASL+ Disassembler version 20200925 (64-bit version) + * Copyright (c) 2000 - 2020 Intel Corporation + * + * Disassembly

[PATCH v3 11/16] tests: bios-tables-test: Prepare the ACPI table change for smbios type4 thread count test

2023-10-23 Thread Zhao Liu
From: Zhao Liu Following the guidelines in tests/qtest/bios-tables-test.c, this is step 1 - 3. List the ACPI tables that will be added to test the thread count field of smbios type4 table. Signed-off-by: Zhao Liu Reviewed-by: Michael S. Tsirkin --- tests/data/acpi/q35/APIC.thread-count

[PATCH v3 05/16] tests: bios-tables-test: Prepare the ACPI table change for smbios type4 core count test

2023-10-23 Thread Zhao Liu
From: Zhao Liu Following the guidelines in tests/qtest/bios-tables-test.c, this is step 1 - 3. List the ACPI tables that will be added to test the type 4 core count field. Signed-off-by: Zhao Liu Reviewed-by: Michael S. Tsirkin --- tests/data/acpi/q35/APIC.core-count | 0 tests/data/

[PATCH v3 06/16] tests: bios-tables-test: Add test for smbios type4 core count

2023-10-23 Thread Zhao Liu
From: Zhao Liu This tests the commit 196ea60a734c3 ("hw/smbios: Fix core count in type4"). In smbios_build_type_4_table() (hw/smbios/smbios.c), if the number of cores in the socket is not more than 255, then smbios type4 table encodes cores per socket into the core count field. So for the topol

Re: [PATCH v2 2/4] hw/char/stm32f2xx_usart: Update IRQ when SR is read

2023-10-23 Thread Hans-Erik Floryd
On Mon, 23 Oct 2023 at 03:37, Alistair Francis wrote: > > On Sat, Oct 21, 2023 at 4:12 AM Philippe Mathieu-Daudé > wrote: > > > > From: Hans-Erik Floryd > > > > Signed-off-by: Hans-Erik Floryd > > [PMD: Split from bigger patch] > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > Is this requ

Re: [PATCH 11/12] hw/xen: automatically assign device index to block devices

2023-10-23 Thread David Woodhouse
On 23 October 2023 10:30:02 BST, Igor Mammedov wrote: >On Wed, 18 Oct 2023 09:32:47 +0100 >David Woodhouse wrote: > >> On Wed, 2023-10-18 at 09:32 +0200, Igor Mammedov wrote: >> > On Mon, 16 Oct 2023 16:19:08 +0100 >> > David Woodhouse wrote: >> > >> > > From: David Woodhouse >> > > >>

Re: [PATCH v2 10/20] parallels: Add dirty bitmaps saving

2023-10-23 Thread Alexander Ivanov
On 10/21/23 12:40, Mike Maslenkin wrote: On Thu, Oct 19, 2023 at 4:05 PM Alexander Ivanov wrote: Now dirty bitmaps can be loaded but there is no their saving. Add code for dirty bitmap storage. Signed-off-by: Alexander Ivanov --- block/parallels-ext.c | 167 ++

Re: [PATCH] hw/arm/boot: Set SCR_EL3.FGTEn when booting kernel

2023-10-23 Thread Peter Maydell
On Sat, 21 Oct 2023 at 13:30, Michael Tokarev wrote: > > 13.09.2023 14:57, Fabian Vogt : > > Just like d7ef5e16a17c sets SCR_EL3.HXEn for FEAT_HCX, this commit > > handles SCR_EL3.FGTEn for FEAT_FGT: > > > > When we direct boot a kernel on a CPU which emulates EL3, we need to > > set up the EL3 sy

Re: [QEMU][PATCH v4 1/2] xen_arm: Create virtio-mmio devices during initialization

2023-10-23 Thread Anthony PERARD
On Wed, Oct 11, 2023 at 12:22:46PM -0700, Vikram Garhwal wrote: > Hi Anthony, > On Thu, Oct 05, 2023 at 11:40:57AM +0100, Anthony PERARD wrote: > > Hi Vikram, > > > > This patch prevent QEMU from been build with Xen 4.15. See comments. > > > > Also, why didn't you CC all the maintainers of > > in

Re: [PATCH] target/loongarch: Support 4K page size

2023-10-23 Thread Peter Maydell
On Mon, 23 Oct 2023 at 05:06, maobibo wrote: > > > > 在 2023/10/23 上午10:40, Song Gao 写道: > > The LoongArch kernel supports 4K page size. > > Change TARGET_PAGE_BITS to 12. > > > > Signed-off-by: Song Gao > > --- > > target/loongarch/cpu-param.h | 2 +- > > target/loongarch/tlb_helper.c | 9 +++

Re: [PATCH 0/5] Live Migration Acceleration with IAA Compression

2023-10-23 Thread Daniel P . Berrangé
On Mon, Oct 23, 2023 at 08:33:44AM +, Liu, Yuan1 wrote: > > -Original Message- > > From: Daniel P. Berrangé > > Sent: Thursday, October 19, 2023 11:32 PM > > To: Peter Xu > > Cc: Juan Quintela ; Liu, Yuan1 > > ; faro...@suse.de; leob...@redhat.com; qemu- > > de...@nongnu.org; Zou, Nan

Re: [PATCH 0/5] Live Migration Acceleration with IAA Compression

2023-10-23 Thread Juan Quintela
"Liu, Yuan1" wrote: >> -Original Message- >> From: Daniel P. Berrangé >> Sent: Thursday, October 19, 2023 11:32 PM >> To: Peter Xu >> Cc: Juan Quintela ; Liu, Yuan1 >> ; faro...@suse.de; leob...@redhat.com; qemu- >> de...@nongnu.org; Zou, Nanhai >> Subject: Re: [PATCH 0/5] Live Migratio

Re: [PATCH 0/5] Live Migration Acceleration with IAA Compression

2023-10-23 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Mon, Oct 23, 2023 at 08:33:44AM +, Liu, Yuan1 wrote: >> > -Original Message- >> > From: Daniel P. Berrangé >> > Sent: Thursday, October 19, 2023 11:32 PM >> > To: Peter Xu >> > Cc: Juan Quintela ; Liu, Yuan1 >> > ; faro...@suse.de; leob...@redhat.com; q

Re: [PATCH 2/2] igb: Add Function Level Reset to PF and VF

2023-10-23 Thread Akihiko Odaki
On 2023/10/23 12:11, Jason Wang wrote: On Fri, Oct 20, 2023 at 5:41 PM Cédric Le Goater wrote: On 10/20/23 09:40, Cédric Le Goater wrote: On 10/20/23 06:24, Jason Wang wrote: On Tue, Aug 29, 2023 at 5:06 PM Cédric Le Goater wrote: From: Cédric Le Goater The Intel 82576EB GbE Controller

Re: [PATCH v3 1/3] migration: Add documentation for backwards compatiblity

2023-10-23 Thread Juan Quintela
Peter Xu wrote: > On Mon, May 15, 2023 at 10:31:59AM +0200, Juan Quintela wrote: [..] >> +When we do migration, we have to QEMU process: the source and the > > s/to/two/, s/process/processes/ done. >> +target. There are two cases, they are the same version or they are a >> +different version.

Re: [PATCH v3 3/3] migration/doc: We broke backwards compatibility

2023-10-23 Thread Juan Quintela
Fiona Ebner wrote: > Am 15.05.23 um 10:32 schrieb Juan Quintela: >> When we detect that we have broken backwards compantibility in a > > compatibility done > (...) > >> + >> +In qemu-8.0 we got this commit: :: >> + >> +commit 9a6ef182c03eaa138bae553f0fbb5a123bef9a53 >> +Author: Jonathan

[PATCH v1] virtio-mem: fix division by zero in virtio_mem_activate_memslots_to_plug()

2023-10-23 Thread David Hildenbrand
When running with "dynamic-memslots=off", we enter virtio_mem_activate_memslots_to_plug() to return immediately again because "vmem->dynamic_memslots == false". However, the compiler might not optimize out calculating start_idx+end_idx, where we divide by vmem->memslot_size. In such a configuration

Re: [PATCH v1] virtio-mem: fix division by zero in virtio_mem_activate_memslots_to_plug()

2023-10-23 Thread Michael S. Tsirkin
On Mon, Oct 23, 2023 at 01:13:41PM +0200, David Hildenbrand wrote: > When running with "dynamic-memslots=off", we enter > virtio_mem_activate_memslots_to_plug() to return immediately again > because "vmem->dynamic_memslots == false". However, the compiler might > not optimize out calculating start_

Re: [PATCH 2/2] igb: Add Function Level Reset to PF and VF

2023-10-23 Thread Cédric Le Goater
On 10/23/23 12:57, Akihiko Odaki wrote: On 2023/10/23 12:11, Jason Wang wrote: On Fri, Oct 20, 2023 at 5:41 PM Cédric Le Goater wrote: On 10/20/23 09:40, Cédric Le Goater wrote: On 10/20/23 06:24, Jason Wang wrote: On Tue, Aug 29, 2023 at 5:06 PM Cédric Le Goater wrote: From: Cédric Le G

Re: [PATCH] hw/ipmi: Don't call vmstate_register() from instance_init() functions

2023-10-23 Thread Juan Quintela
Thomas Huth wrote: > instance_init() can be called multiple times, e.g. during introspection > of the device. We should not install the vmstate handlers here. Do it > in the realize() function instead. > > Signed-off-by: Thomas Huth Reviewed-by: Juan Quintela It fixes my issues. Should I take

[PATCH v5 01/19] build-sys: add a "pixman" feature

2023-10-23 Thread marcandre . lureau
From: Marc-André Lureau For now, pixman is mandatory, but we set config_host.h and Kconfig. Once compilation is fixed, "pixman" will become actually optional. Signed-off-by: Marc-André Lureau --- meson.build | 10 -- include/ui/qemu-pixman.h | 2 ++ Kconfig.host

[PATCH v5 00/19] Make Pixman an optional dependency

2023-10-23 Thread marcandre . lureau
From: Marc-André Lureau Hi, QEMU system emulators can be made to compile and work without Pixman. Only a few devices and options actually require it (VNC, Gtk, Spice for ex) and will have to be compiled out. However, most of QEMU graphics-related code is based on pixman_image_t and format. If

[PATCH v5 06/19] ui/vc: console-vc requires PIXMAN

2023-10-23 Thread marcandre . lureau
From: Marc-André Lureau Add stubs for the fallback paths. get_vc() now returns NULL by default if !PIXMAN. Signed-off-by: Marc-André Lureau --- ui/console-vc-stubs.c | 33 + ui/console.c | 3 +++ ui/meson.build| 2 +- 3 files changed, 37 inse

[PATCH v5 17/19] hw/sm501: allow compiling without PIXMAN

2023-10-23 Thread marcandre . lureau
From: Marc-André Lureau Drop the "x-pixman" property and use fallback path in such case. Signed-off-by: Marc-André Lureau --- hw/display/sm501.c | 59 +- 1 file changed, 42 insertions(+), 17 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/

[PATCH v5 04/19] vl: move display early init before default devices

2023-10-23 Thread marcandre . lureau
From: Marc-André Lureau The next commit needs to have the display registered itself before creating the default VCs. Signed-off-by: Marc-André Lureau --- system/vl.c | 41 +++-- 1 file changed, 23 insertions(+), 18 deletions(-) diff --git a/system/vl.c b/sy

[PATCH v5 15/19] ui/dbus: do not require PIXMAN

2023-10-23 Thread marcandre . lureau
From: Marc-André Lureau Implement a fallback path for region 2D update. Signed-off-by: Marc-André Lureau --- ui/dbus-listener.c | 90 -- ui/meson.build | 4 +-- 2 files changed, 65 insertions(+), 29 deletions(-) diff --git a/ui/dbus-listener.c

[PATCH v5 02/19] ui: compile out some qemu-pixman functions when !PIXMAN

2023-10-23 Thread marcandre . lureau
From: Marc-André Lureau Those functions require the PIXMAN library. Signed-off-by: Marc-André Lureau --- include/ui/qemu-pixman.h | 7 +-- ui/qemu-pixman.c | 6 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/include/ui/qemu-pixman.h b/include/ui/qemu-pixman.

[PATCH v5 12/19] ui/vnc: VNC requires PIXMAN

2023-10-23 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- meson.build| 6 +- ui/meson.build | 4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 395d7155f6..c4dd9e01ea 100644 --- a/meson.build +++ b/meson.build @@ -1536,7 +1536,11 @

[PATCH v5 08/19] virtio-gpu: replace PIXMAN for region/rect test

2023-10-23 Thread marcandre . lureau
From: Marc-André Lureau Use a simpler implementation for rectangle geometry & intersect, drop the need for (more complex) PIXMAN functions. Signed-off-by: Marc-André Lureau --- include/ui/rect.h | 59 + hw/display/virtio-gpu.c | 30

[PATCH v5 19/19] build-sys: make pixman actually optional

2023-10-23 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- meson.build | 3 --- 1 file changed, 3 deletions(-) diff --git a/meson.build b/meson.build index dbc7af091c..6399321d72 100644 --- a/meson.build +++ b/meson.build @@ -817,9 +817,6 @@ if not get_option('pixman').auto() or have_system

[PATCH v5 18/19] hw/display: make ATI_VGA depend on PIXMAN

2023-10-23 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Acked-by: BALATON Zoltan --- configs/devices/mips64el-softmmu/default.mak | 2 +- hw/display/Kconfig | 2 +- hw/display/meson.build | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)

[PATCH v5 16/19] arm/kconfig: XLNX_ZYNQMP_ARM depends on PIXMAN

2023-10-23 Thread marcandre . lureau
From: Marc-André Lureau The Display Port has some strong PIXMAN dependency. Signed-off-by: Marc-André Lureau --- hw/arm/Kconfig | 3 ++- hw/display/Kconfig | 5 + hw/display/meson.build | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/arm/Kconfig b/hw/a

[PATCH v5 07/19] qmp/hmp: disable screendump if PIXMAN is missing

2023-10-23 Thread marcandre . lureau
From: Marc-André Lureau The command requires color conversion and line-by-line feeding. We could have a simple fallback for simple formats though. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- qapi/ui.json | 3 ++- ui/ui-hmp-cmds.c | 2 ++ ui/ui-qmp-cmds.c | 2 +

[PATCH v5 11/19] ui/gl: opengl doesn't require PIXMAN

2023-10-23 Thread marcandre . lureau
From: Marc-André Lureau The QEMU fallback covers the requirements. We still need the flags of header inclusion with CONFIG_PIXMAN. Signed-off-by: Marc-André Lureau --- ui/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/meson.build b/ui/meson.build index 3

Re: [PATCH v2 0/3] hw/s390x: Don't call register_savevm_live() during instance_init()

2023-10-23 Thread Thomas Huth
On 23/10/2023 13.32, Juan Quintela wrote: Thomas Huth wrote: We must not call register_savevm_live() during instance_init() since instances can be created at any time, e.g. during introspection of a device. We must register the savevm handler during realize() instead. Fix it now in the s390x de

Re: [PATCH v2 0/3] hw/s390x: Don't call register_savevm_live() during instance_init()

2023-10-23 Thread Juan Quintela
Thomas Huth wrote: > We must not call register_savevm_live() during instance_init() > since instances can be created at any time, e.g. during introspection > of a device. We must register the savevm handler during realize() > instead. Fix it now in the s390x devices. > > v2: > - Fixed bug in the t

Re: [PATCH v5 00/19] Make Pixman an optional dependency

2023-10-23 Thread Michael S. Tsirkin
On Mon, Oct 23, 2023 at 03:30:27PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > QEMU system emulators can be made to compile and work without Pixman. > > Only a few devices and options actually require it (VNC, Gtk, Spice for ex) > and > will have to be compi

[PATCH v5 13/19] ui/spice: SPICE/QXL requires PIXMAN

2023-10-23 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- meson.build| 6 +- hw/display/Kconfig | 2 +- ui/meson.build | 10 +- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/meson.build b/meson.build index c4dd9e01ea..3d6e41d1fb 100644 --- a/meson.

[PATCH v5 14/19] ui/gtk: -display gtk requires PIXMAN

2023-10-23 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 3d6e41d1fb..dbc7af091c 100644 --- a/meson.build +++ b/meson.build @@ -1507,7 +1507,11 @@ gtkx11 = not_found vte = no

[PATCH v5 03/19] ui: add pixman-compat.h

2023-10-23 Thread marcandre . lureau
From: Marc-André Lureau This is a tiny subset of PIXMAN API that is used pervasively in QEMU codebase to manage images and identify the underlying format. It doesn't seems worth to wrap this in a QEMU-specific API. Signed-off-by: Marc-André Lureau --- include/ui/pixman-compat.h | 195

[PATCH v5 10/19] vhost-user-gpu: skip VHOST_USER_GPU_UPDATE when !PIXMAN

2023-10-23 Thread marcandre . lureau
From: Marc-André Lureau This simply means that 2d drawing updates won't be handled, but 3d should work. Signed-off-by: Marc-André Lureau --- hw/display/vhost-user-gpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/vhost-user-gpu.c b/hw/display/vhost-user-gpu.c index 1150521

[PATCH v5 09/19] ui/console: when PIXMAN is unavailable, don't draw placeholder msg

2023-10-23 Thread marcandre . lureau
From: Marc-André Lureau When we can't draw text, simply show a blank display. Signed-off-by: Marc-André Lureau --- ui/console.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/console.c b/ui/console.c index a72c495b5a..8e688d3569 100644 --- a/ui/console.c +++ b/ui/console.c @@ -584,6

Re: [PATCH v3 5/9] mirror: implement mirror_change method

2023-10-23 Thread Fiona Ebner
Am 18.10.23 um 18:59 schrieb Kevin Wolf: > Am 13.10.2023 um 11:21 hat Fiona Ebner geschrieben: >> which allows switching the @copy-mode from 'background' to >> 'write-blocking'. >> >> This is useful for management applications, so they can start out in >> background mode to avoid limiting guest wri

[PATCH v5 05/19] ui/console: allow to override the default VC

2023-10-23 Thread marcandre . lureau
From: Marc-André Lureau If a display is backed by a specialized VC, allow to override the default "vc:80Cx24C". For that, set the dpy.type just before creating the default serial/parallel/monitor. As suggested by Paolo, if the display doesn't implement a VC (get_vc() returns NULL), use a fallbac

Re: [PULL v2 00/78] virtio,pc,pci: features, cleanups

2023-10-23 Thread Michael S. Tsirkin
On Fri, Oct 20, 2023 at 09:00:33AM -0700, Stefan Hajnoczi wrote: > On Thu, 19 Oct 2023 at 11:30, Michael S. Tsirkin wrote: > > > > Changes from v1: > > dropped shadow vq patches > > > > The following changes since commit ec6f9f135d5e5596ab0258da2ddd048f1fd8c359: > > > > Merge tag 'migration-

Re: [PATCH v3 0/9] mirror: allow switching from background to active mode

2023-10-23 Thread Fiona Ebner
Am 19.10.23 um 15:36 schrieb Kevin Wolf: > Most of this series looks good to me. Apart from the comments I made in > the individual patches, I would like to see iotests coverage of changing > the mirroring mode. At the least to show that the query result changes, > but ideally also that requests re

Re: [PATCH 11/11] qdev: Rework array properties based on list visitor

2023-10-23 Thread Markus Armbruster
Kevin Wolf writes: > Am 14.10.2023 um 08:36 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 22.09.2023 um 17:05 hat Markus Armbruster geschrieben: >> >> Kevin Wolf writes: >> >> >> >> > Until now, array properties are actually implemented with a hack that >> >> > uses mult

Re: [PATCH v2 2/6] target/riscv/tcg: add ext_zicntr disable support

2023-10-23 Thread Daniel Henrique Barboza
On 10/22/23 23:54, Alistair Francis wrote: On Wed, Oct 18, 2023 at 8:13 AM Daniel Henrique Barboza wrote: Support for the zicntr counters are already in place. We need a way to disable them if the user wants to. This is done by restricting access to the CYCLE, TIME, and INSTRET counters via

Re: [PATCH v14 10/14] fixup! migration: New migrate and migrate-incoming argument 'channels'

2023-10-23 Thread Daniel P . Berrangé
On Thu, Oct 19, 2023 at 04:23:49PM -0300, Fabiano Rosas wrote: > Signed-off-by: Fabiano Rosas > --- > qapi/migration.json | 8 > 1 file changed, 8 insertions(+) Reviewed-by: Daniel P. Berrangé assuming you'll just squash into the previous patch > > diff --git a/qapi/migration.json b

Re: [PATCH v14 04/14] fixup! migration: convert migration 'uri' into 'MigrateAddress'

2023-10-23 Thread Daniel P . Berrangé
On Thu, Oct 19, 2023 at 04:23:43PM -0300, Fabiano Rosas wrote: > Signed-off-by: Fabiano Rosas > --- > migration/file.c | 2 +- > migration/file.h | 1 + > migration/migration.c | 6 ++ > 3 files changed, 8 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé assuming it'l

Re: [PATCH v14 02/14] fixup! migration: New QAPI type 'MigrateAddress'

2023-10-23 Thread Daniel P . Berrangé
On Thu, Oct 19, 2023 at 04:23:41PM -0300, Fabiano Rosas wrote: > Signed-off-by: Fabiano Rosas > --- > qapi/migration.json | 20 ++-- > 1 file changed, 18 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé from a functional POV, and assuming Markus' feedback will be i

[PATCH v13 02/11] Add virtio-sound-pci device

2023-10-23 Thread Manos Pitsidianakis
This patch adds a PCI wrapper device for the virtio-sound device. It is necessary to instantiate a virtio-snd device in a guest. All sound logic will be added to the virtio-snd device in the following commits. To add this device with a guest, you'll need a >=5.13 kernel compiled with CONFIG_SND_VI

[PATCH v13 01/11] Add virtio-sound device stub

2023-10-23 Thread Manos Pitsidianakis
Add a new VIRTIO device for the virtio sound device id. Functionality will be added in the following commits. Based-on: https://github.com/OpenSynergy/qemu/commit/5a2f350eec5d157b90d9c7b40a8e603f4da92471 Signed-off-by: Igor Skalkin Signed-off-by: Anton Yakovlev Signed-off-by: Manos Pitsidianaki

[PATCH v13 00/11] Add VIRTIO sound card

2023-10-23 Thread Manos Pitsidianakis
This patch series adds an audio device implementing the recent virtio sound spec (1.2) and a corresponding PCI wrapper device. v13 can be found online at: https://gitlab.com/epilys/qemu/-/tree/virtio-snd-v13 Ref e7fb941cf7636fdff40cbdcdcd660dec5f15ca3c Main differences with v12 patch series [^v

[PATCH v13 03/11] virtio-sound: handle control messages and streams

2023-10-23 Thread Manos Pitsidianakis
Receive guest requests in the control (CTRL) queue of the virtio sound device and reply with a NOT SUPPORTED error to all control commands. The receiving handler is virtio_snd_handle_ctrl(). It stores all control messages in the queue in the device's command queue. Then it calls virtio_snd_process

[PATCH v13 11/11] docs/system: add basic virtio-snd documentation

2023-10-23 Thread Manos Pitsidianakis
This commit adds basic documentation for using virtio-snd. Signed-off-by: Manos Pitsidianakis Reviewed-by: Alex Bennée Tested-by: Alex Bennée --- MAINTAINERS| 1 + docs/system/device-emulation.rst | 1 + docs/system/devices/virtio-snd.rst | 49 ++

[PATCH v13 06/11] virtio-sound: handle VIRTIO_SND_R_PCM_SET_PARAMS

2023-10-23 Thread Manos Pitsidianakis
Handle the set parameters control request. It reconfigures a stream based on a guest's preference if the values are valid and supported. Based-on: https://github.com/OpenSynergy/qemu/commit/5a2f350eec5d157b90d9c7b40a8e603f4da92471 Signed-off-by: Igor Skalkin Signed-off-by: Anton Yakovlev Signed

[PATCH v13 09/11] virtio-sound: implement audio output (TX)

2023-10-23 Thread Manos Pitsidianakis
Handle output IO messages in the transmit (TX) virtqueue. It allocates a VirtIOSoundPCMBuffer for each IO message and copies the data buffer to it. When the IO buffer is written to the host's sound card, the guest will be notified that it has been consumed. The lifetime of an IO message is: 1. G

[PATCH v13 07/11] virtio-sound: handle VIRTIO_SND_R_PCM_PREPARE

2023-10-23 Thread Manos Pitsidianakis
Handles the PCM prepare control request. It initializes a PCM stream when the guests asks for it. Based-on: https://github.com/OpenSynergy/qemu/commit/5a2f350eec5d157b90d9c7b40a8e603f4da92471 Signed-off-by: Igor Skalkin Signed-off-by: Anton Yakovlev Signed-off-by: Manos Pitsidianakis Reviewed-

[PATCH v13 05/11] virtio-sound: handle VIRTIO_SND_R_PCM_{START,STOP}

2023-10-23 Thread Manos Pitsidianakis
Handle the start and stop control messages for a stream_id. This request does nothing at the moment except for replying to it. Audio playback or capture will be started/stopped here in follow-up commits. Based-on: https://github.com/OpenSynergy/qemu/commit/5a2f350eec5d157b90d9c7b40a8e603f4da92471

[PATCH v13 08/11] virtio-sound: handle VIRTIO_SND_R_PCM_RELEASE

2023-10-23 Thread Manos Pitsidianakis
Handle the PCM release control request, which is necessary for flushing pending sound IO. No IO is handled yet so currently it only replies to the request. Based-on: https://github.com/OpenSynergy/qemu/commit/5a2f350eec5d157b90d9c7b40a8e603f4da92471 Signed-off-by: Igor Skalkin Signed-off-by: Ant

[PATCH v13 04/11] virtio-sound: handle VIRTIO_SND_R_PCM_INFO request

2023-10-23 Thread Manos Pitsidianakis
Respond to the VIRTIO_SND_R_PCM_INFO control request with the parameters of each requested PCM stream. Based-on: https://github.com/OpenSynergy/qemu/commit/5a2f350eec5d157b90d9c7b40a8e603f4da92471 Signed-off-by: Igor Skalkin Signed-off-by: Anton Yakovlev Signed-off-by: Manos Pitsidianakis Revi

  1   2   3   4   5   >