Markus Armbruster wrote:
> Juan Quintela writes:
>
>> Set the 'block_incremental' migration parameter to 'true' instead.
>>
>> Reviewed-by: Thomas Huth
>> Acked-by: Stefan Hajnoczi
>> Signed-off-by: Juan Quintela
>>
>> ---
>>
>> Improve documentation and style (thanks Markus)
>> ---
>> docs/a
On 16/10/23 00:19, Bernhard Beschow wrote:
Am 11. Oktober 2023 18:59:53 UTC schrieb "Philippe Mathieu-Daudé"
:
PCI functions are plugged on a PCI bus. They can only access
external memory regions via the bus.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/pci-host/bonito.c | 6 +++---
1 file cha
Elena Ufimtseva wrote:
> In migration rate limiting atomic operations are used
> to read the rate limit variables and transferred bytes and
> they are expensive. Check first if rate_limit_max is equal
> to RATE_LIMIT_DISABLED and return false immediately if so.
>
> Note that with this patch we wil
Elena Ufimtseva wrote:
> Previous commit cbec7eb76879d419e7dbf531ee2506ec0722e825
> "migration/multifd: Compute transferred bytes correctly"
> removed accounting for packet_len in non-rdma
> case, but the next_packet_size only accounts for pages, not for
> the header packet (normal_pages * PAGE_SI
Elena Ufimtseva wrote:
> Sometimes multifd sends just sync packet with no pages
> (normal_num is 0). In this case the old value is being
> preserved and being accounted for while only packet_len
> is being transferred.
> Reset it to 0 after sending and accounting for.
>
> Signed-off-by: Elena Ufim
Fabiano Rosas wrote:
> 'rs' is not used in that function. It's a leftover from commit
> 9360447d34 ("ram: Use MigrationStats for statistics").
>
> Reviewed-by: Peter Xu
> Signed-off-by: Fabiano Rosas
Reviewed-by: Juan Quintela
queued.
Fabiano Rosas wrote:
> From: Nikolay Borisov
>
> Extract the ramblock parsing code into a routine that operates on the
> sequence of headers from the stream and another the parses the
> individual ramblock. This makes ram_load_precopy() easier to
> comprehend.
>
> Signed-off-by: Nikolay Borisov
Fabiano Rosas wrote:
> We don't need the QEMUFile when we're already passing the
> PageSearchStatus.
>
> Reviewed-by: Peter Xu
> Signed-off-by: Fabiano Rosas
Reviewed-by: Juan Quintela
On Mon, Oct 16, 2023 at 03:39:40PM +1000, Alistair Francis wrote:
> On Fri, Aug 11, 2023 at 5:01 PM Andrew Jones wrote:
> >
> > On Thu, Aug 10, 2023 at 02:07:17PM -0400, Alistair Francis wrote:
> > > On Tue, Aug 8, 2023 at 6:10 PM Vineet Gupta wrote:
> > > >
> > > >
> > > >
> > > > On 8/8/23 14:0
Fabiano Rosas wrote:
> We've found the source of flakiness in this test, so re-enable it.
>
> Reviewed-by: Juan Quintela
> Signed-off-by: Fabiano Rosas
One test still missing to cleanup the serial file.
Will send it later and then we can reenable it.
Later, Juan.
On 10/10/23 22:53, Nicholas Piggin wrote:
On Tue Oct 10, 2023 at 10:03 PM AEST, Joel Stanley wrote:
On Tue, 10 Oct 2023 at 18:23, Nicholas Piggin wrote:
Add simple Linux kernel boot tests for BookE 64-bit and 32-bit CPUs
using Guenter Roeck's rootfs images for Linux testing, and a gitlab
repo
On 10/10/23 09:52, Nicholas Piggin wrote:
POWER10 is the latest IBM Power machine. Although it is not offered in
"OPAL mode" (i.e., powernv configuration), so there is a case that it
should remain at powernv9, most of the development work is going into
powernv10 at the moment.
Signed-off-by: Nic
On 10/10/23 09:52, Nicholas Piggin wrote:
POWER10 is the latest pseries CPU.
Signed-off-by: Nicholas Piggin
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
hw/ppc/spapr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index d4230d364
The VHOST_USER_PROTOCOL_F_XEN_MMAP feature bit was defined in
f21e95ee97d, which has been part of qemu's 8.1.0 release. However, it
seems it was never added to qemu's code, but it is well possible that it
is already used by different front-ends outside of qemu (i.e., Xen).
VHOST_USER_PROTOCOL_F_S
On 10/2/23 09:35, Andrey Drobyshev wrote:
> On 9/19/23 20:57, Andrey Drobyshev wrote:
>> v2 --> v3:
>> * Patch 3/8: fixed logic in the if statement, so that we align on blk
>>when blk_old_backing == NULL;
>> * Patch 4/8: comment fix;
>> * Patch 5/8: comment fix; dropped redundant "if (blk_ne
On 10/10/23 09:52, Nicholas Piggin wrote:
Add simple Linux kernel boot tests for BookE 64-bit and 32-bit CPUs
using Guenter Roeck's rootfs images for Linux testing, and a gitlab
repository with kernel images that I built since there are very few
sources of modern BookE images now.
Signed-off-by:
On 10/10/23 09:52, Nicholas Piggin wrote:
The Hash MMU mode is supported along side Radix in POWER hardware, and
Linux supports running in either mode. Radix is the default so to keep
up testing of QEMU Hash MMU, add some explicit Hash MMU tests.
Signed-off-by: Nicholas Piggin
Nice ! Could we
Fabiano Rosas wrote:
> We're about to enable support for other transports in multifd, so
> remove direct references to sockets.
>
> Signed-off-by: Fabiano Rosas
Reviewed-by: Juan Quintela
queued.
From: Eric Auger
In the prospect to introduce a base object for the VFIOContainer
and derive into the existing legacy container and the iommufd
based container, let's rename the existing one into
VFIOLegacyContainer. This is just an incremental step to ease
the migration. Soon there won't be any
Hi,
Thanks all for giving guides and comments on previous series, here is
the pure iommufd support part.
PATCH 1-15: Abstract out base container
PATCH 16: Add --enable/--disable-iommufd config support
PATCH 17: Introduce iommufd object
PATCH 18-21: add IOMMUFD container and cdev support
PATCH 22
From: Eric Auger
Move the giommu_list field in the base object and store the
base container in the VFIOGuestIOMMU.
We introduce vfio_container_init/destroy helper on the base
container.
No fucntional change intended.
Signed-off-by: Eric Auger
Signed-off-by: Yi Liu
Signed-off-by: Yi Sun
Sign
From: Eric Auger
Let's instantiate a dummy VFIOContainerClass implementation whose
functions are not yet implemented.
No fucntional change intended.
Signed-off-by: Eric Auger
Signed-off-by: Yi Liu
Signed-off-by: Yi Sun
Signed-off-by: Zhenzhong Duan
---
include/hw/vfio/vfio-container-base.h
From: Eric Auger
In the prospect to get rid of VFIOLegacyContainer refs
in common.c lets convert misc functions to use the base
container object instead:
vfio_devices_all_dirty_tracking
vfio_devices_all_device_dirty_tracking
vfio_devices_all_running_and_mig_active
vfio_devices_query_dirty_bitmap
From: Eric Auger
Introduce a dumb VFIOContainer base object and its targetted interface.
This is willingly not a QOM object because we don't want it to be
visible from the user interface. The VFIOContainer will be smoothly
populated in subsequent patches as well as interfaces.
No fucntional cha
IBM EEH is only supported by legacy backend currently, bypass it
for IOMMUFD backend.
Signed-off-by: Zhenzhong Duan
---
hw/vfio/container.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/vfio/container.c b/hw/vfio/container.c
index c86accdb38..dd9534afab 100644
--- a/h
From: Eric Auger
Move the space field to the base object. Also the VFIOAddressSpace
now contains a list of base containers.
No fucntional change intended.
Signed-off-by: Eric Auger
Signed-off-by: Yi Liu
Signed-off-by: Yi Sun
Signed-off-by: Zhenzhong Duan
---
include/hw/vfio/vfio-common.h
From: Yi Liu
Add the iommufd backend. The IOMMUFD container class is implemented
based on the new /dev/iommu user API. This backend obviously depends
on CONFIG_IOMMUFD.
So far, the iommufd backend doesn't support dirty page sync yet due
to missing support in the host kernel.
Co-authored-by: Eri
From: Eric Auger
Introduce an iommufd object which allows the interaction
with the host /dev/iommu device.
The /dev/iommu can have been already pre-opened outside of qemu,
in which case the fd can be passed directly along with the
iommufd object:
This allows the iommufd object to be shared accr
This adds "--enable-iommufd/--disable-iommufd" to enable or disable
iommufd support, enabled by default.
Signed-off-by: Zhenzhong Duan
---
meson.build | 6 ++
meson_options.txt | 2 ++
scripts/meson-buildoptions.sh | 3 +++
3 files changed, 11 insertions(+)
dif
From: Eric Auger
Now we support two types of iommu backends, let's add the capability
to select one of them. This depends on whether an iommufd object has
been linked with the vfio-pci device:
if the user wants to use the legacy backend, it shall not
link the vfio-pci device with any iommufd obj
From: Eric Auger
No fucntional change intended.
Signed-off-by: Eric Auger
Signed-off-by: Yi Liu
Signed-off-by: Yi Sun
Signed-off-by: Zhenzhong Duan
---
include/hw/vfio/vfio-common.h | 6 --
include/hw/vfio/vfio-container-base.h | 5 +
hw/vfio/common.c
From: Eric Auger
dirty_pages_supported field is also moved to the base container
No fucntional change intended.
Signed-off-by: Eric Auger
Signed-off-by: Yi Liu
Signed-off-by: Yi Sun
Signed-off-by: Zhenzhong Duan
---
include/hw/vfio/vfio-common.h | 6 --
include/hw/vfio/vfio-co
From: Eric Auger
Move hostwin_list in base container. This conducts to
passing a base container to vfio_host_win_add/del and
vfio_find_hostwin.
No fucntional change intended.
Signed-off-by: Eric Auger
Signed-off-by: Yi Liu
Signed-off-by: Yi Sun
Signed-off-by: Zhenzhong Duan
---
include/hw/
VFIO Device is also changed to point to base container instead of
legacy container.
No fucntional change intended.
Signed-off-by: Zhenzhong Duan
---
include/hw/vfio/vfio-common.h | 3 +--
include/hw/vfio/vfio-container-base.h | 1 +
hw/vfio/common.c | 23 +
Fabiano Rosas wrote:
> The preferred usage of the Error type is to always set both the return
> code and the error when a failure happens. As all code called from the
> send thread follows this pattern, we'll always have the return code
> and the error set at the same time.
>
> Aside from the conv
This gives management tools like libvirt a chance to open the vfio
cdev with privilege and pass FD to qemu. This way qemu never needs
to have privilege to open a VFIO or iommu cdev node.
Opportunisticly, remove some unnecessory double-cast.
Signed-off-by: Zhenzhong Duan
---
hw/vfio/ap.c | 32 ++
From: Eric Auger
No fucntional change intended.
Signed-off-by: Eric Auger
Signed-off-by: Yi Liu
Signed-off-by: Yi Sun
Signed-off-by: Zhenzhong Duan
---
hw/vfio/common.c| 22 ++
hw/vfio/container.c | 12 +---
2 files changed, 27 insertions(+), 7 deletions(-)
From: Eric Auger
No functional change intended.
Signed-off-by: Eric Auger
Signed-off-by: Yi Liu
Signed-off-by: Yi Sun
Signed-off-by: Zhenzhong Duan
---
include/hw/vfio/vfio-common.h | 2 --
include/hw/vfio/vfio-container-base.h | 2 ++
hw/vfio/container.c | 11 ++
This gives management tools like libvirt a chance to open the vfio
cdev with privilege and pass FD to qemu. This way qemu never needs
to have privilege to open a VFIO or iommu cdev node.
Signed-off-by: Zhenzhong Duan
---
hw/vfio/platform.c | 41 +
1 file c
From: Yi Liu
/dev/vfio/devices/vfioX may not exist. In that case it is still possible
to open /dev/char/$major:$minor instead. Add helper function to abstract
the cdev open.
Suggested-by: Jason Gunthorpe
Signed-off-by: Yi Liu
Signed-off-by: Zhenzhong Duan
---
MAINTAINERS | 6
This gives management tools like libvirt a chance to open the vfio
cdev with privilege and pass FD to qemu. This way qemu never needs
to have privilege to open a VFIO or iommu cdev node.
Opportunisticly, remove a redundant definition of TYPE_VFIO_CCW.
Signed-off-by: Zhenzhong Duan
---
hw/vfio/c
Fabiano Rosas wrote:
> The function is currently called from two sites, one always gives it a
> NULL Error and the other always gives it a non-NULL Error.
>
> In the non-NULL case, all it does it trace the error and return. One
> of the callers already have tracing, add a tracepoint to the other a
From: Eric Auger
Move listener to base container. Also error and initialized fields
are moved at the same time.
No functional change intended.
Signed-off-by: Eric Auger
Signed-off-by: Yi Liu
Signed-off-by: Yi Sun
Signed-off-by: Zhenzhong Duan
---
include/hw/vfio/vfio-common.h | 3
From: Eric Auger
Move vrdl_list, pgsizes and dma_max_mappings to the base
container object
No functional change intended.
Signed-off-by: Eric Auger
Signed-off-by: Yi Liu
Signed-off-by: Yi Sun
Signed-off-by: Zhenzhong Duan
---
include/hw/vfio/vfio-common.h | 13
include/hw/
From: Eric Auger
No fucntional change intended.
Signed-off-by: Eric Auger
Signed-off-by: Yi Liu
Signed-off-by: Yi Sun
Signed-off-by: Zhenzhong Duan
---
include/hw/vfio/vfio-common.h | 4 ---
include/hw/vfio/vfio-container-base.h | 7 +
hw/vfio/common.c | 4
Previously we added support to select iommu backend for vfio pci
device. Now we added others, E.g: platform, ap and ccw.
Signed-off-by: Zhenzhong Duan
---
include/hw/vfio/vfio-platform.h | 1 +
hw/vfio/ap.c| 5 +
hw/vfio/ccw.c | 5 +
hw/vfio/platform
This gives management tools like libvirt a chance to open the vfio
cdev with privilege and pass FD to qemu. This way qemu never needs
to have privilege to open a VFIO or iommu cdev node.
Together with the earlier support of pre-opening /dev/iommu device,
now we have full support of passing a vfio
As pci hot reset path need to reference pci specific functions
and data structures, adding container level callback functions
for legacy and iommufd BE and referencing those pci specific
func/data is no better than implementing reset support with
iommufd BE directly in pci.c
This way we can also s
On Mon, 16 Oct 2023 11:32, Hanna Czenczek wrote:
diff --git a/include/hw/virtio/vhost-user.h
b/include/hw/virtio/vhost-user.h
index 9f9ddf878d..1d4121431b 100644
--- a/include/hw/virtio/vhost-user.h
+++ b/include/hw/virtio/vhost-user.h
@@ -29,7 +29,8 @@ enum VhostUserProtocolFeature {
VHOST
On Sat, Oct 14, 2023 at 10:16:16PM +0300, Michael Tokarev wrote:
> Can't we make -drive if=none the default?
>
> Yes, I know current default is ide, and whole world have to use if=none
> explicitly
> to undo this. I think at this point we can deprecate if=ide default and
> switch to
> if=none i
On 13/10/2023 17.30, Paolo Bonzini wrote:
Install dtc as it is now a mandatory external dependency in order to build QEMU.
Signed-off-by: Paolo Bonzini
---
tests/vm/netbsd | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/vm/netbsd b/tests/vm/netbsd
index 939dc1b22a1..3ef1ec2d9cc
On Mon, 16 Oct 2023 09:23, Paolo Bonzini wrote:
This is an error in Python 3.12; fix it by using a raw string literal.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
tests/docker/docker.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/docker/docker.py b/
On Thu, Oct 12, 2023 at 04:07:50PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 10/11/23 00:01, Alistair Francis wrote:
> > On Sat, Oct 7, 2023 at 12:23 AM Daniel Henrique Barboza
> > wrote:
> > >
> > > Hi,
> > >
> > > Several design changes were made in this version after the reviews and
>
On 5/1/23 16:44, Bernhard Beschow wrote:
Bernhard Beschow (2):
hw/pci-host/bonito: Inline pci_register_root_bus()
hw/pci-host/bonito: Map PCI IRQs in board code
Thanks, queued to mips-next.
On Mon, 16 Oct 2023 09:31, Paolo Bonzini wrote:
They are not needed when building user-mode emulators.
Signed-off-by: Paolo Bonzini
Reviewed-by: Emmanouil Pitsidianakis
On 29/09/2023 15.45, Thomas Huth wrote:
It's a little bit weird that the files in target/i386/ which
are not in a subfolder there do not have any associated
maintainer (and thus nobody might be CC:-ed on changes to
these files). We should have a general x86 section for these
files, similar to wha
On 9/10/23 19:14, Philippe Mathieu-Daudé wrote:
Philippe Mathieu-Daudé (3):
hw/mips: Merge 'hw/mips/cpudevs.h' with 'target/mips/cpu.h'
hw/misc/mips_itu: Declare itc_reconfigure() in 'hw/misc/mips_itu.h'
hw/misc/mips_itu: Make MIPSITUState target agnostic
Queued to mips-next.
On Mon, Oct 16, 2023 at 11:00:14AM +0200, Thomas Huth wrote:
> On 13/10/2023 17.30, Paolo Bonzini wrote:
> > Install dtc as it is now a mandatory external dependency in order to build
> > QEMU.
> >
> > Signed-off-by: Paolo Bonzini
> > ---
> > tests/vm/netbsd | 3 +++
> > 1 file changed, 3 ins
On 9/10/23 11:21, Philippe Mathieu-Daudé wrote:
Since commit 93198b6cad ("i2c: Split smbus into parts") the SDRAM
types are enumerated as sdram_type in "hw/i2c/smbus_eeprom.h".
Using the enum removes this global shadow warning:
hw/mips/malta.c:209:12: error: declaration shadows a variable in
On Mon, Oct 16, 2023 at 10:06:11AM +0100, Daniel P. Berrangé wrote:
> On Mon, Oct 16, 2023 at 11:00:14AM +0200, Thomas Huth wrote:
> > On 13/10/2023 17.30, Paolo Bonzini wrote:
> > > Install dtc as it is now a mandatory external dependency in order to
> > > build QEMU.
> > >
> > > Signed-off-by:
On Mon, 16 Oct 2023 09:31, Paolo Bonzini wrote:
diff --git a/meson.build b/meson.build
index 010d2c649c2..251838f2609 100644
--- a/meson.build
+++ b/meson.build
@@ -2111,6 +2111,7 @@ config_host_data.set('CONFIG_OPENGL', opengl.found())
config_host_data.set('CONFIG_PLUGIN', get_option('plugins')
On 15/10/23 16:15, BALATON Zoltan wrote:
The VIA south bridgges are now mostly used by other machines not just
fuloong2e so split off into a separate section and take maintanership.
Signed-off-by: BALATON Zoltan
---
@@ -2491,6 +2488,15 @@ S: Maintained
F: hw/isa/piix4.c
F: include/hw/so
On 16/10/2023 11.06, Daniel P. Berrangé wrote:
On Mon, Oct 16, 2023 at 11:00:14AM +0200, Thomas Huth wrote:
On 13/10/2023 17.30, Paolo Bonzini wrote:
Install dtc as it is now a mandatory external dependency in order to build QEMU.
Signed-off-by: Paolo Bonzini
---
tests/vm/netbsd | 3 +++
On 16/10/23 08:31, Paolo Bonzini wrote:
Avoid that --enable-cfi --disable-cfi leaves b_lto set to true.
Signed-off-by: Paolo Bonzini
---
configure | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
@@ -1845,6 +1843,7 @@ if test "$skip_meson" = no; then
# QEMU options
On Mon, 16 Oct 2023 09:31, Paolo Bonzini wrote:
Unify HAVE_GDB_BIN (currently in config-host.mak) and
HOST_GDB_SUPPORTS_ARCH into a single GDB variable in
config-target.mak.
Signed-off-by: Paolo Bonzini
Reviewed-by: Emmanouil Pitsidianakis
This patch closes the file descriptor fd on connect failure to avoid
resource leak.
Signed-off-by: Cong Liu
---
contrib/plugins/lockstep.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index f0cb8792c6fa..3c0f2b485181 100644
--- a/con
On 16/10/2023 08.31, Paolo Bonzini wrote:
print_error is only invoked in one place, and $git is unused.
Signed-off-by: Paolo Bonzini
---
configure | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
Reviewed-by: Thomas Huth
On 10/16/23 07:03, Philippe Mathieu-Daudé wrote:
Hi Cédric, Liu, Joao,
On 13/10/23 16:56, Cédric Le Goater wrote:
From: Liu Yi L
This patch modifies pci_setup_iommu() to set PCIIOMMUOps
instead of setting PCIIOMMUFunc. PCIIOMMUFunc is used to
get an address space for a PCI device in vendor sp
On 13/10/23 16:27, Richard Henderson wrote:
On 10/13/23 07:01, Philippe Mathieu-Daudé wrote:
These definitions and declarations are only used by
target/arm/, no need to expose them to generic hw/.
Signed-off-by: Philippe Mathieu-Daudé
---
target/arm/cpu-qom.h | 28 ---
On Mon, Oct 16, 2023 at 11:21 AM Thomas Huth wrote:
>
> On 16/10/2023 11.06, Daniel P. Berrangé wrote:
> > On Mon, Oct 16, 2023 at 11:00:14AM +0200, Thomas Huth wrote:
> >> On 13/10/2023 17.30, Paolo Bonzini wrote:
> >>> Install dtc as it is now a mandatory external dependency in order to
> >>> b
This is an error in Python 3.12; fix it by using a raw string literal
or by double-escaping the backslash.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
tests/vm/basevm.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/vm/basevm.py b/tests/vm/basevm
This is an error in Python 3.12; fix it by using a raw string literal.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
target/hexagon/hex_common.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/hexagon/hex_common.py b/target/hexagon/hex_common.py
inde
This is an error in Python 3.12; fix it by using a raw string literal.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
scripts/tracetool/__init__.py| 14 +++---
scripts/tracetool/format/log_stap.py | 2 +-
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git
This is an error in Python 3.12; fix it by using a raw string literal.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
tests/avocado/virtio_check_params.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/avocado/virtio_check_params.py
b/tests/avocado/virtio
This is an error in Python 3.12; fix it by using a raw string literal.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
docs/sphinx/hxtool.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/sphinx/hxtool.py b/docs/sphinx/hxtool.py
index fb0649a3d5b..9f6b9d87dc
On 12/10/23 06:12, Philippe Mathieu-Daudé wrote:
Philippe Mathieu-Daudé (3):
hw/pci-host/sh_pcic: Declare CPU QOM types using DEFINE_TYPES() macro
hw/pci-host/sh_pcic: Correct PCI host / devfn#0 function names
hw/pci-host/sh_pcic: Replace magic value by proper definition
Series queued
On 10/16/23 11:22, Philippe Mathieu-Daudé wrote:
On 16/10/23 08:31, Paolo Bonzini wrote:
Avoid that --enable-cfi --disable-cfi leaves b_lto set to true.
Signed-off-by: Paolo Bonzini
---
configure | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
@@ -1845,6 +1843,7 @@ if test
On 10/16/23 11:08, Manos Pitsidianakis wrote:
On Mon, 16 Oct 2023 09:31, Paolo Bonzini wrote:
diff --git a/meson.build b/meson.build
index 010d2c649c2..251838f2609 100644
--- a/meson.build
+++ b/meson.build
@@ -2111,6 +2111,7 @@ config_host_data.set('CONFIG_OPENGL',
opengl.found())
config_hos
Meson tries to run scripts via the shebang line if they files are
marked as executable. If "python3" is not in the $PATH, or if it
is a version that is too old, then the script execution fails.
We should make sure to run scripts via the python3 interpreter
that is used for Meson itself. For this, t
Hi Miguel,
> From: Miguel Luis
> Sent: Friday, October 13, 2023 5:34 PM
> To: Salil Mehta
> Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; Marc Zyngier
> ; jean-phili...@linaro.org; Jonathan Cameron
> ; lpieral...@kernel.org; Peter Maydell
> ; Richard Henderson
> ; imamm...@redhat.com;
> andrew
On Sun, 15 Oct 2023 10:39:46 -0700
lokesh jaliminche wrote:
> Hi Everyone,
>
> I am facing performance issues while copying data to the CXL device
> (Emulated with QEMU). I get approximately 500KB/Sec. Any suggestion on how
> to improve this?
Hi Lokesh,
The target so far of QEMU emulation of C
On 10/14/23 21:16, Michael Tokarev wrote:
Can't we make -drive if=none the default?
Yes, I know current default is ide, and whole world have to use if=none
explicitly
to undo this. I think at this point we can deprecate if=ide default and switch
to
if=none in the next release. I think it wil
> From: Shaoqin Huang
> Sent: Monday, October 16, 2023 3:54 AM
> To: Salil Mehta ; qemu-devel@nongnu.org; qemu-
> a...@nongnu.org
> Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron
> ; lpieral...@kernel.org;
> peter.mayd...@linaro.org; richard.hender...@linaro.org;
> imamm...@redhat
Hi Salil,
> On 16 Oct 2023, at 09:52, Salil Mehta wrote:
>
> Hi Miguel,
>
>> From: Miguel Luis
>> Sent: Friday, October 13, 2023 5:34 PM
>> To: Salil Mehta
>> Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; Marc Zyngier
>> ; jean-phili...@linaro.org; Jonathan Cameron
>> ; lpieral...@kernel.or
From: Dmitry Frolov
qemu_ram_block_from_host() may return NULL, which will be dereferenced w/o
check. Usualy return value is checked for this function.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Dmitry Frolov
Reviewed-by: Fabiano Rosas
Reviewed-by: Peter X
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Markus Armbruster
Reviewed-by: Fabiano Rosas
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231011023627.86691-1-phi...@linaro.org>
---
migration/ram.c | 17 ++---
1 file chan
From: Nikolay Borisov
Make the migration json writer part of MigrationState struct, allowing
the 'configuration' object be serialized to json.
This will facilitate the parsing of the 'configuration' object in the
next patch that fixes analyze-migration.py for arm.
Signed-off-by: Nikolay Borisov
Once there:
- Remove unused data parameter
- unfold it in its callers.
- change all callers to call qemu_rdma_registration_start()
- We need to call QIO_CHANNEL_RDMA() after we check for migrate_rdma()
Reviewed-by: Li Zhijian
Reviewed-by: Fabiano Rosas
Signed-off-by: Juan Quintela
Message-ID: <
From: Fiona Ebner
This is intended to be a semantic revert of commit 9b09503752
("migration: run setup callbacks out of big lock"). There have been so
many changes since that commit (e.g. a new setup callback
dirty_bitmap_save_setup() that also needs to be adapted now), it's
easier to do the reve
There is only one flag called with: RAM_CONTROL_BLOCK_REG.
Reviewed-by: Li Zhijian
Signed-off-by: Juan Quintela
Message-ID: <20231011203527.9061-6-quint...@redhat.com>
---
migration/qemu-file.h | 11 ---
migration/rdma.h | 3 +++
migration/qemu-file.c | 10 --
migration/ra
Functions are long enough even without this.
Reviewed-by: Peter Xu
Reviewed-by: Li Zhijian
Signed-off-by: Juan Quintela
Message-ID: <20231011203527.9061-10-quint...@redhat.com>
---
migration/rdma.h | 12 ++--
migration/ram.c| 14 +++---
migration/rdma.c | 40
From: Fabiano Rosas
The script is broken when the configuration/capabilities section is
present. Add support for parsing the capabilities so we can fix it in
the next patch.
Signed-off-by: Fabiano Rosas
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231009184326.15777-
From: Peter Xu
Migration bandwidth is a very important value to live migration. It's
because it's one of the major factors that we'll make decision on when to
switchover to destination in a precopy process.
This value is currently estimated by QEMU during the whole live migration
process by mon
Once there:
- Remove unused data parameter
- unfold it in its callers
- change all callers to call qemu_rdma_registration_stop()
- We need to call QIO_CHANNEL_RDMA() after we check for migrate_rdma()
Reviewed-by: Li Zhijian
Signed-off-by: Juan Quintela
Message-ID: <20231011203527.9061-4-quint...
From: Fabiano Rosas
Add basic tests for file-based migration.
Note that we cannot use test_precopy_common because that routine
expects it to be possible to run the migration live. With the file
transport there is no live migration because we must wait for the
source to finish writing the migrati
The only user of ram_control_save_page() and save_page() hook was
rdma. Just move the function to rdma.c, rename it to
rdma_control_save_page().
Reviewed-by: Peter Xu
Reviewed-by: Li Zhijian
Signed-off-by: Juan Quintela
Message-ID: <20231011203527.9061-7-quint...@redhat.com>
---
migration/qemu
From: Fabiano Rosas
Add a smoke test that migrates to a file and gives it to the
script. It should catch the most annoying errors such as changes in
the ram flags.
After code has been merged it becomes way harder to figure out what is
causing the script to fail, the person making the change is t
u.git tags/migration-20231016-pull-request
for you to fetch changes up to f39b0f42753635b0f2d8b00a26d11bb197bf51e2:
migration/multifd: Clarify Error usage in multifd_channel_connect (2023-10-16
11:01:33 +0200)
Migration Pull request
The only user was rdma, and its use is gone.
Reviewed-by: Peter Xu
Reviewed-by: Li Zhijian
Signed-off-by: Juan Quintela
Message-ID: <20231011203527.9061-8-quint...@redhat.com>
---
migration/qemu-file.h | 4
migration/qemu-file.c | 6 --
migration/rdma.c | 9 -
3 files cha
Change code that is:
int ret;
...
ret = foo();
if (ret[ < 0]?) {
to:
if (foo()[ < 0]) {
Reviewed-by: Fabiano Rosas
Reviewed-by: Li Zhijian
Signed-off-by: Juan Quintela
Message-ID: <20231011203527.9061-14-quint...@redhat.com>
---
migration/rdma.c | 29 -
1 file c
1 - 100 of 489 matches
Mail list logo
