Re: [PATCH v2 1/2] ppc/pnv: Add an I2C controller model

On 10/12/23 22:08, Glenn Miles wrote: From: Cédric Le Goater The more recent IBM power processors have an embedded I2C controller that is accessible by software via the XSCOM address space. Each instance of the I2C controller is capable of controlling multiple I2C buses (one at a time). Prior

Re: [PATCH v2 2/2] ppc/pnv: Connect I2C controller model to powernv9 chip

On 10/12/23 22:08, Glenn Miles wrote: From: Cédric Le Goater Wires up three I2C controller instances to the powernv9 chip XSCOM address space. Each controller instance is wired up to a single I2C bus of its own. No other I2C devices are connected to the buses at this time. Signed-off-by: Céd

Re: [PATCH 03/10] tests/virtio-scsi: Clean up global variable shadowing

On Mon, 09 Oct 2023 13:02, Philippe Mathieu-Daudé wrote: Rename the (unused) 'allow' argument, following the pattern s/allow/alloc Otherwise, Reviewed-By: Emmanouil Pitsidianakis used by the other tests in this file. This fixes: tests/qtest/virtio-scsi-test.c:159:61: error: declaration

[RFC PATCH 00/78] Strict disable implicit fallthrough

Hello, This RFC is inspired by the kernel's move to -Wimplicit-fallthrough=3 back in 2019.[0] We take one step (or two) further by increasing it to 5 which rejects fall through comments and requires an attribute statement. [0]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/co

[RFC PATCH 07/78] hw/virtio/virtio-balloon.c: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/virtio/virtio-balloon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio

[RFC PATCH 10/78] hw/ide/atapi.c: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/ide/atapi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index dcc39df9a4..

[RFC PATCH 12/78] hw/usb: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/usb/dev-mtp.c | 2 +- hw/usb/dev-wacom.c | 2 +- hw/usb/hcd-ehci.c | 4 +++- hw/usb/hcd-xhci.c | 4 ++-- hw/us

[RFC PATCH 08/78] hw/block: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/block/dataplane/xen-block.c | 4 ++-- hw/block/m25p80.c | 2 +- hw/block/onenand.c | 2 +-

[RFC PATCH 15/78] accel/tcg: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- accel/tcg/cputlb.c | 4 ++-- accel/tcg/ldst_atomicity.c.inc | 2 +- accel/tcg/plugin-gen.c | 2 +-

[RFC PATCH 11/78] hw/timer: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/timer/a9gtimer.c | 8 ++-- hw/timer/aspeed_timer.c | 1 + hw/timer/pxa2xx_timer.c | 94 -

[RFC PATCH 05/78] qobject/json: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- qobject/json-lexer.c | 4 ++-- qobject/json-parser.c | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) di

[RFC PATCH 01/78] include/qemu/compiler.h: replace QEMU_FALLTHROUGH with fallthrough

Signed-off-by: Emmanouil Pitsidianakis --- audio/pwaudio.c | 8 hw/arm/smmuv3.c | 2 +- include/qemu/compiler.h | 30 +++--- include/qemu/osdep.h | 4 ++-- target/loongarch/cpu.c | 4 ++-- target/loongarch/translate

[RFC PATCH 18/78] ui/win32-kbd-hook.c: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- ui/win32-kbd-hook.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/ui/win32-kbd-hook.c b/ui/win32-kbd-hook

[RFC PATCH 03/78] fpu/softfloat: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- fpu/softfloat-parts.c.inc | 8 fpu/softfloat.c | 7 --- 2 files changed, 8 insertions(+), 7 de

[RFC PATCH 36/78] target/openrisc: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/openrisc/mmu.c | 2 +- target/openrisc/translate.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions

[RFC PATCH 13/78] hw/adc: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/adc/aspeed_adc.c | 12 ++-- hw/adc/zynq-xadc.c | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-)

[RFC PATCH 37/75] system/rtc.c: add fallthrough pseudo-keyword

Signed-off-by: Emmanouil Pitsidianakis --- system/rtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system/rtc.c b/system/rtc.c index 4904581abe..bb406542c8 100644 --- a/system/rtc.c +++ b/system/rtc.c @@ -48,22 +48,22 @@ QEMUClockType rtc_clock; /

[RFC PATCH 35/78] target/sh4: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/sh4/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sh4/helper.c b/target/

[RFC PATCH 19/78] target/hppa: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/hppa/translate.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target/hppa/tr

[RFC PATCH 40/75] linux-user: add fallthrough pseudo-keyword

Signed-off-by: Emmanouil Pitsidianakis --- linux-user/mips/cpu_loop.c | 8 linux-user/mmap.c | 2 +- linux-user/syscall.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/linux-user/mips/cpu_loop.c b/linux-user/mips/cpu_loop.c index 8735e58bad..38ddca

[RFC PATCH 34/78] target/tricore: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/tricore/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/tricore/tra

[RFC PATCH 09/78] hw/acpi/aml-build.c: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/acpi/aml-build.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/acpi/aml-build.c b/h

[RFC PATCH 54/75] hw/display: add fallthrough pseudo-keyword

Signed-off-by: Emmanouil Pitsidianakis --- hw/display/cg3.c| 2 +- hw/display/cirrus_vga.c | 2 +- hw/display/tcx.c| 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/display/cg3.c b/hw/display/cg3.c index 2e9656ae1c..53eb9831b2 100644 --- a/hw/display/cg3.

[RFC PATCH 54/78] hw/core: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/core/loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/loader.c b/hw/core/loade

[RFC PATCH 32/78] target/m68k: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/m68k/op_helper.c | 3 ++- target/m68k/translate.c | 10 +- 2 files changed, 7 insertions(+), 6 deleti

[RFC PATCH 48/78] contrib/vhost-user-scsi: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- contrib/vhost-user-scsi/vhost-user-scsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contr

[RFC PATCH 39/75] hw/sd/sdhci.c: add fallthrough pseudo-keyword

Signed-off-by: Emmanouil Pitsidianakis --- hw/sd/sdhci.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 5564765a9b..5c641d24de 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -75,138 +75,138 @@ static bool sdhci_check_capab_freq_r

[RFC PATCH 51/78] chardev: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- chardev/char-socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chardev/char-socket.c b/cha

[RFC PATCH 51/75] hw/char: add fallthrough pseudo-keyword

Signed-off-by: Emmanouil Pitsidianakis --- hw/char/nrf51_uart.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/nrf51_uart.c b/hw/char/nrf51_uart.c index dfe2276d71..3e2b35c7ad 100644 --- a/hw/char/nrf51_uart.c +++ b/hw/char/nrf51_uart.c @@ -113,79 +113,79 @@ stati

[RFC PATCH v2 01/78] include/qemu/compiler.h: replace QEMU_FALLTHROUGH with fallthrough

Signed-off-by: Emmanouil Pitsidianakis --- audio/pwaudio.c | 8 hw/arm/smmuv3.c | 2 +- include/qemu/compiler.h | 30 +++--- include/qemu/osdep.h | 4 ++-- target/loongarch/cpu.c | 4 ++-- target/loongarch/translate

[RFC PATCH 14/78] util/error-report.c: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- util/error-report.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/error-report.c b/util/er

[RFC PATCH 20/78] target/mips: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/mips/sysemu/physaddr.c | 2 +- target/mips/tcg/micromips_translate.c.inc | 4 +- target/mips/tcg

[RFC PATCH 38/75] hw/scsi: add fallthrough pseudo-keyword

Signed-off-by: Emmanouil Pitsidianakis --- hw/scsi/esp.c | 2 +- hw/scsi/megasas.c | 2 +- hw/scsi/scsi-bus.c | 4 ++-- hw/scsi/scsi-disk.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index 9b11d8c573..d6c8298f51 100644 --- a/hw/sc

[RFC PATCH 46/75] contrib/rdmacm-mux: add fallthrough pseudo-keyword

Signed-off-by: Emmanouil Pitsidianakis --- contrib/rdmacm-mux/main.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/contrib/rdmacm-mux/main.c b/contrib/rdmacm-mux/main.c index 771ca01e03..dda6917d58 100644 --- a/contrib/rdmacm-mux/main.c +++ b/contrib/rdmacm-mux/ma

[RFC PATCH 31/78] target/xtensa: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/xtensa/op_helper.c | 8 target/xtensa/translate.c | 2 +- 2 files changed, 5 insertions(+), 5 deletio

[RFC PATCH 56/75] hw/net: add fallthrough pseudo-keyword

Signed-off-by: Emmanouil Pitsidianakis --- hw/net/cadence_gem.c | 4 ++-- hw/net/can/can_sja1000.c | 4 ++-- hw/net/igb_core.c| 2 +- hw/net/igbvf.c | 2 +- hw/net/imx_fec.c | 2 +- hw/net/net_rx_pkt.c | 2 +- hw/net/pcnet.c | 2 +- hw/net/rtl8139.c

[RFC PATCH 56/78] hw/input: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/input/hid.c | 3 ++- hw/input/tsc2005.c | 4 ++-- hw/input/tsc210x.c | 2 +- 3 files changed, 5 insertions(+),

[RFC PATCH 50/78] hw/audio: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/audio/asc.c| 2 +- hw/audio/cs4231a.c| 2 +- hw/audio/gusemu_hal.c | 2 +- 3 files changed, 3 insertio

[RFC PATCH v2 12/78] hw/usb: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/usb/dev-mtp.c | 2 +- hw/usb/dev-wacom.c | 2 +- hw/usb/hcd-ehci.c | 4 +++- hw/usb/hcd-xhci.c | 4 ++-- hw/us

[RFC PATCH 41/78] linux-user: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- linux-user/mips/cpu_loop.c | 8 linux-user/mmap.c | 2 +- linux-user/syscall.c | 2 +- 3 file

[RFC PATCH v2 19/78] target/hppa: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/hppa/translate.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target/hppa/tr

[RFC PATCH v2 04/78] qapi/opts-visitor: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- qapi/opts-visitor.c | 1 + qapi/string-input-visitor.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletion

[RFC PATCH 26/78] target/s390x: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/s390x/cpu.c | 4 ++-- target/s390x/kvm/kvm.c | 2 +- target/s390x/mmu_helper.c

[RFC PATCH 04/78] qapi/opts-visitor: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- qapi/opts-visitor.c | 1 + qapi/string-input-visitor.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletion

[RFC PATCH 30/78] target/nios2: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/nios2/helper.c| 6 +++--- target/nios2/translate.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-

[RFC PATCH v2 10/78] hw/ide/atapi.c: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/ide/atapi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index dcc39df9a4..

[RFC PATCH 27/78] target/riscv: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/riscv/insn_trans/trans_rvi.c.inc | 2 +- target/riscv/insn_trans/trans_rvzce.c.inc | 22 +++

[RFC PATCH v2 59/78] hw/intc: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/intc/apic.c | 2 +- hw/intc/arm_gicv3_kvm.c | 16 hw/intc/armv7m_nvic.c | 12 ++--

[RFC PATCH v2 75/78] migration: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- migration/migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/migration.c b/mig

[RFC PATCH 45/75] disas: add fallthrough pseudo-keyword

Signed-off-by: Emmanouil Pitsidianakis --- disas/hppa.c | 4 ++-- disas/m68k.c | 2 +- disas/sh4.c | 4 +++- disas/sparc.c | 2 +- 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/disas/hppa.c b/disas/hppa.c index dcf9a47f34..1a2bdb8d39 100644 --- a/disas/hppa.c +++ b/disas/hppa

[RFC PATCH 37/78] target/hexagon: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/hexagon/idef-parser/parser-helpers.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/

[RFC PATCH 50/75] chardev: add fallthrough pseudo-keyword

Signed-off-by: Emmanouil Pitsidianakis --- chardev/char-socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index 73947da188..1562e066a4 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -549,34 +549,34 @@ stat

[RFC PATCH 38/78] system/rtc.c: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- system/rtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system/rtc.c b/system/rtc.c index 49

[RFC PATCH v2 65/78] hw/nvme: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/nvme/ctrl.c | 24 hw/nvme/dif.c | 4 ++-- 2 files changed, 14 insertions(+), 14 deletio

[RFC PATCH 52/78] hw/char: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/char/nrf51_uart.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/nrf51_uart.c b/h

[RFC PATCH v2 16/78] audio: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- audio/audio.c | 16 audio/jackaudio.c | 4 ++-- audio/pwaudio.c | 4 ++-- 3 files changed, 1

[RFC PATCH v2 15/78] accel/tcg: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- accel/tcg/cputlb.c | 4 ++-- accel/tcg/ldst_atomicity.c.inc | 2 +- accel/tcg/plugin-gen.c | 2 +-

[RFC PATCH 55/75] hw/input: add fallthrough pseudo-keyword

Signed-off-by: Emmanouil Pitsidianakis --- hw/input/hid.c | 3 ++- hw/input/tsc2005.c | 4 ++-- hw/input/tsc210x.c | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/input/hid.c b/hw/input/hid.c index a9c7dd1ce1..15fffc5dfb 100644 --- a/hw/input/hid.c +++ b/hw/input/hid

[RFC PATCH v2 57/78] hw/net: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/net/cadence_gem.c | 4 ++-- hw/net/can/can_sja1000.c | 4 ++-- hw/net/igb_core.c| 2 +- hw/net/igbvf.c

[RFC PATCH 43/75] hw/m68k/mcf_intc.c: add fallthrough pseudo-keyword

Signed-off-by: Emmanouil Pitsidianakis --- hw/m68k/mcf_intc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/m68k/mcf_intc.c b/hw/m68k/mcf_intc.c index 4cd30188c0..9556a0ccb7 100644 --- a/hw/m68k/mcf_intc.c +++ b/hw/m68k/mcf_intc.c @@ -58,34 +58,34 @@ static void mcf_intc_

[RFC PATCH v2 07/78] hw/virtio/virtio-balloon.c: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/virtio/virtio-balloon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio

[RFC PATCH 53/75] hw/core: add fallthrough pseudo-keyword

Signed-off-by: Emmanouil Pitsidianakis --- hw/core/loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index 4dd5a71fb7..559d63a1e2 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -625,138 +625,138 @@ toosmall: /* Load a U-Boot

[RFC PATCH v2 77/78] tests/unit/test-char.c: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- tests/unit/test-char.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/test-char.c b/t

[RFC PATCH 45/78] hw/dma: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/dma/omap_dma.c| 32 hw/dma/pxa2xx_dma.c | 4 ++-- hw/dma/sparc32_dma.c | 2

[RFC PATCH v2 63/78] hw/ipmi: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/ipmi/ipmi_bmc_extern.c | 2 +- hw/ipmi/smbus_ipmi.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-

[RFC PATCH v2 40/78] hw/sd/sdhci.c: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/sd/sdhci.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci

[RFC PATCH v2 29/78] target/cris: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/cris/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/cris/translate

[RFC PATCH v2 03/78] fpu/softfloat: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- fpu/softfloat-parts.c.inc | 8 fpu/softfloat.c | 7 --- 2 files changed, 8 insertions(+), 7 de

[RFC PATCH 21/78] target/sparc: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/sparc/ldst_helper.c | 4 ++-- target/sparc/mmu_helper.c | 6 +++--- target/sparc/translate.c | 3 ++- targe

[RFC PATCH 24/78] target/alpha: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/alpha/helper.c| 6 +++--- target/alpha/translate.c | 4 +++- 2 files changed, 6 insertions(+), 4 deletions

[RFC PATCH 22/78] target/ppc: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/ppc/cpu_init.c| 8 target/ppc/excp_helper.c | 6 +++--- target/ppc/mmu-radix64.c | 6 +++--- t

[RFC PATCH v2 42/78] hw/i386: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/i386/intel_iommu.c| 4 ++-- hw/i386/kvm/xen_evtchn.c | 2 +- hw/i386/x86.c| 2 +- 3 files changed,

[RFC PATCH v2 44/78] hw/m68k/mcf_intc.c: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/m68k/mcf_intc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/m68k/mcf_intc.c b/hw/m68k/m

[RFC PATCH v2 69/78] hw/rdma/rdma_backend.c: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/rdma/rdma_backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/rdma_backend.c b/h

[RFC PATCH v2 33/78] target/rx: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/rx/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/rx/translate.c b/tar

[RFC PATCH v2 20/78] target/mips: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/mips/sysemu/physaddr.c | 2 +- target/mips/tcg/micromips_translate.c.inc | 4 +- target/mips/tcg

[RFC PATCH v2 27/78] target/riscv: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/riscv/insn_trans/trans_rvi.c.inc | 2 +- target/riscv/insn_trans/trans_rvzce.c.inc | 22 +++

[RFC PATCH v2 53/78] nbd: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- nbd/client.c | 4 ++-- nbd/common.c | 2 +- qemu-nbd.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-)

[RFC PATCH v2 31/78] target/xtensa: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/xtensa/op_helper.c | 8 target/xtensa/translate.c | 2 +- 2 files changed, 5 insertions(+), 5 deletio

[RFC PATCH v2 36/78] target/openrisc: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/openrisc/mmu.c | 2 +- target/openrisc/translate.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions

[RFC PATCH 41/75] hw/i386: add fallthrough pseudo-keyword

Signed-off-by: Emmanouil Pitsidianakis --- hw/i386/intel_iommu.c| 4 ++-- hw/i386/kvm/xen_evtchn.c | 2 +- hw/i386/x86.c| 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 2c832ab68b..bdb2ea3ac5 100644 --- a/hw

[RFC PATCH v2 24/78] target/alpha: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/alpha/helper.c| 6 +++--- target/alpha/translate.c | 4 +++- 2 files changed, 6 insertions(+), 4 deletions

[RFC PATCH v2 05/78] qobject/json: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- qobject/json-lexer.c | 4 ++-- qobject/json-parser.c | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) di

[RFC PATCH v2 55/78] hw/display: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/display/cg3.c| 2 +- hw/display/cirrus_vga.c | 2 +- hw/display/tcx.c| 4 ++-- 3 files changed, 4

[RFC PATCH v2 08/78] hw/block: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/block/dataplane/xen-block.c | 4 ++-- hw/block/m25p80.c | 2 +- hw/block/onenand.c | 2 +-

[RFC PATCH v2 14/78] util/error-report.c: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- util/error-report.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/error-report.c b/util/er

[RFC PATCH v2 32/78] target/m68k: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/m68k/op_helper.c | 3 ++- target/m68k/translate.c | 10 +- 2 files changed, 7 insertions(+), 6 deleti

[RFC PATCH 02/78] block: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- block/block-copy.c| 1 + block/file-posix.c| 1 + block/io.c| 1 + block/iscsi.c | 1

[RFC PATCH v2 18/78] ui/win32-kbd-hook.c: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- ui/win32-kbd-hook.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/ui/win32-kbd-hook.c b/ui/win32-kbd-hook

[RFC PATCH 49/78] hw/arm: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/arm/omap1.c | 8 hw/arm/pxa2xx.c| 6 +++--- hw/arm/stellaris.c | 1 + 3 files changed, 8 insertio

Re: [RFC PATCH v2 71/78] hw/s390x: add fallthrough pseudo-keyword

On 13.10.23 09:57, Emmanouil Pitsidianakis wrote: In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- Reviewed-by: David Hildenbrand See Rb's on the other two patc

[RFC PATCH v2 46/78] disas: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- disas/hppa.c | 4 ++-- disas/m68k.c | 2 +- disas/sh4.c | 6 +++--- disas/sparc.c | 2 +- 4 files changed, 7 inse

[RFC PATCH 48/75] hw/arm: add fallthrough pseudo-keyword

Signed-off-by: Emmanouil Pitsidianakis --- hw/arm/omap1.c | 8 hw/arm/pxa2xx.c| 5 +++-- hw/arm/stellaris.c | 1 + 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/arm/omap1.c b/hw/arm/omap1.c index d5438156ee..c54a4ec553 100644 --- a/hw/arm/omap1.c +++ b/hw/arm/

[RFC PATCH 44/75] hw/dma: add fallthrough pseudo-keyword

Signed-off-by: Emmanouil Pitsidianakis --- hw/dma/omap_dma.c| 32 hw/dma/pxa2xx_dma.c | 4 ++-- hw/dma/sparc32_dma.c | 2 +- 3 files changed, 19 insertions(+), 19 deletions(-) diff --git a/hw/dma/omap_dma.c b/hw/dma/omap_dma.c index 77797a67b5..dd43dbf3d2

[RFC PATCH 42/78] hw/i386: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/i386/intel_iommu.c| 4 ++-- hw/i386/kvm/xen_evtchn.c | 2 +- hw/i386/x86.c| 2 +- 3 files changed,

Re: [PATCH v3 01/13] migration: Create migrate_rdma()

On 12/10/2023 04:35, Juan Quintela wrote: > Helper to say if we are doing a migration over rdma. > > Reviewed-by: Peter Xu > Signed-off-by: Juan Quintela Reviewed-by: Li Zhijian > --- > migration/migration.h | 2 ++ > migration/options.h | 1 + > migration/migration.c | 1 + > migrat

Re: [PATCH v3 10/13] migration/rdma: Check sooner if we are in postcopy for save_page()

On 12/10/2023 04:35, Juan Quintela wrote: > Reviewed-by: Peter Xu > Signed-off-by: Juan Quintela Reviewed-by: Li Zhijian > --- > migration/rdma.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/migration/rdma.c b/migration/rdma.c > index d3bba05262..932d4ed

[RFC PATCH 29/78] target/cris: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/cris/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/cris/translate

[RFC PATCH v2 28/78] target/avr: add fallthrough pseudo-keyword

In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/avr/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/avr/translate.c

Re: [PATCH v3 04/13] migration/rdma: Remove all uses of RAM_CONTROL_HOOK

On 12/10/2023 04:35, Juan Quintela wrote: > Instead of going trhough ram_control_load_hook(), call > qemu_rdma_registration_handle() directly. > s/trhough/through Reviewed-by: Li Zhijian > Reviewed-by: Peter Xu > Signed-off-by: Juan Quintela > --- > migration/qemu-file.h | 1 - > migr

  1   2   3   4   5   6   7   >